kCFErrorDomainCFNetwork (error code 1) in real device but no in simulator

When I try to obtain a local html file from device, I obtain an kCFErrorDomainCFNetwork (error code 1)
Domain: kCFErrorDomainCFNetwork
Error Code: 1
Description: The operation couldn't be completed (CDFErrorDomainCFNetwork error 1.)

That error only happens in real devices (in the emulator works fine).
This error disappears if:
i) I navigate to a http:// page (the error happen only when I read a html file from local)
ii) If I use useWebKit={false}
This is my WebView:
<WebView
  originWhitelist={['*']}
  source={{ uri: "file://xx/xxx/xxx.html" }}
  allowFileAccess={true}
  useWebKit={true}
/>

Regards,
Jose I. Merino

Thanks for reporting, @jimerino ! If you get a chance to submit a PR to fix this issue, we would be happy to test it.

The issue is also present on Android, but with a different error: net::ERR_ACCESS_DENIED
Works on a simulator, but not on a real device

@Arjan-Zuidema I've have this problem in Android and solved with:
i) Make sure the props in WebView originWithilist and allowFileAccess are proper
    originWhitelist={['*']}
    allowFileAccess={true}

ii) If the local file is in a directory outside from the assigned app directories, you must give read access to external storage:
https://developer.android.com/reference/android/Manifest.permission.html#READ_EXTERNAL_STORAGE
If is in the emulator, I think the key factor is the ii) because the emulator has less restrictions than a real device.
In iPhone I suspect that in UIWebView the method to read from http server and local file are the same: load(:), but in WKWebView load(:) is only for http server and must use loadHTMLString(_:baseURL:) method to local files.
After work I'll try to watch the code and see if that suspect is a founded suspicion or not...

@jimerino I don't have this issue in version 4.1.0 but in any versions above I get net::ERR_ACCESS_DENIED
I already have set the props
originWhitelist={['*']}
allowFileAccess={true}

My source props are
source: {
 uri: "file:///data/user/0/<appid>/files/embed/index.html"
}

<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" /> is set in AndroidManifest.xml
I also tried asking for permissions on the fly, but that does not seem to fix the problem.

@Arjan-Zuidema
/data/user//... Not completly sure but and userId = 0 gives me a clue that you're trying access to user root folder
Have you try to read an html file from cache folder?

@jimerino /data/user/0/ is what RNFS.CachesDirectoryPath gives me, I just solved it by using RNFS.ExternalCachesDirectoryPath. Thanks for your input!

@jamonholmgren
I've made a PR. Be gentle, it's my first PR :)
This post gives me the clue:
https://stackoverflow.com/questions/35847493/loading-local-file-works-fine-in-simulator-but-crash-on-device
The only thing I do is check if there's a host in the URL and call to loadRequest if true and the new method loadFileURL if not (but, please, check it. Don't know if there's a collateral damage in that simple if).
Regards,
Jose I. Merino

Your PR didn't work for my case but I think it's related too (#471)
And also this http://www.openradar.me/45346962

in visitSource method change :
[_webView loadFileURL:request.URL allowingReadAccessToURL:request.URL];
to
NSString*documentPath = NSSearchPathForDirectoriesInDomains(NSDocumentDirectory,NSUserDomainMask,YES).firstObject;
        [_webView loadFileURL:request.URL allowingReadAccessToURL:[NSURL fileURLWithPath:documentPath]];

in didMoveToWindow method add:
[_webView.configuration.preferences setValue:@YES forKey:@"allowFileAccessFromFileURLs"];
it works for me.

in visitSource method change :
[_webView loadFileURL:request.URL allowingReadAccessToURL:request.URL];
to
NSString*documentPath = NSSearchPathForDirectoriesInDomains(NSDocumentDirectory,NSUserDomainMask,YES).firstObject;
        [_webView loadFileURL:request.URL allowingReadAccessToURL:[NSURL fileURLWithPath:documentPath]];

in didMoveToWindow method add:
[_webView.configuration.preferences setValue:@YES forKey:@"allowFileAccessFromFileURLs"];
it works for me.

works for me

@Lemo-yxk Thank you it works for me as well

@Lemo-yxk thanks, saved me also! Can you explain why this is needed and what does it do?

in visitSource method change :
[_webView loadFileURL:request.URL allowingReadAccessToURL:request.URL];
to
NSString*documentPath = NSSearchPathForDirectoriesInDomains(NSDocumentDirectory,NSUserDomainMask,YES).firstObject;
[_webView loadFileURL:request.URL allowingReadAccessToURL:[NSURL fileURLWithPath:documentPath]];
in didMoveToWindow method add:
[_webView.configuration.preferences setValue:@YES forKey:@"allowFileAccessFromFileURLs"];
it works for me.

It works in RN 0.73.  Thanks!

Irony, I hit this error (not in WebView, unfortunately, in a websocket connection) and first result in Google is this issue. 😆


[ActionNameAttribute("XXX")] not considered while generating client

Hi,
In our Api definition , we are not following generic WebApi Model route definition, and we have multiple routes with different url parameters. So the generated client code contains like
    System.Threading.Tasks.Task<FileResponse> PostAsync(ApisDocDetails contactEmergencyPostRequestContent, string carrierCode, string dep, string depDate, string fltNum, string seqNum);
    System.Threading.Tasks.Task<FileResponse> **PostAsync**(ApisDocDetails contactEmergencyPostRequestContent, string carrierCode, string dep, string depDate, string fltNum, string seqNum, System.Threading.CancellationToken cancellationToken);
    System.Threading.Tasks.Task<FileResponse> **Post2Async**(PaxContactEmergencyRequest contacts, string carrierCode, string dep, string depDate, string fltNum, string seqNum);
    System.Threading.Tasks.Task<FileResponse> Post2Async(PaxContactEmergencyRequest contacts, string carrierCode, string dep, string depDate, string fltNum, string seqNum, System.Threading.CancellationToken cancellationToken);
    System.Threading.Tasks.Task<FileResponse> **Post3Async**(PaxContactEmailMobileRequest contacts, string carrierCode, string dep, string depDate, string fltNum, string seqNum);
    System.Threading.Tasks.Task<FileResponse> **Post3Async**(PaxContactEmailMobileRequest contacts, string carrierCode, string dep, string depDate, string fltNum, string seqNum, System.Threading.CancellationToken cancellationToken);
    System.Threading.Tasks.Task<FileResponse> **Post4Async**(PaxAddressesPostRequest contacts, string carrierCode, string dep, string depDate, string fltNum, string seqNum);
    System.Threading.Tasks.Task<FileResponse> Post4Async(PaxAddressesPostRequest contacts, string carrierCode, string dep, string depDate, string fltNum, string seqNum, System.Threading.CancellationToken cancellationToken);

How can I avoid the numbers in the client definition and make use of ActionNameAttribute ?

This should be supported:
https://github.com/NSwag/NSwag/blob/master/src/NSwag.SwaggerGeneration.WebApi/WebApiToSwaggerGenerator.cs#L378

I think the problem is that the method names are generated from the OperationId and this is not changed with the ActionNameAttribute... You can use the SwaggerOperationAttribute to set the operation ID... (by default set to "controllerName_methodName").

Yes Rico,If I set by SwaggerOperationAttribute, it works. But I am
restricted to add Swagger nuget for our api project :(  if we could
have ActionNameAttribute
support as well, it will be really helpful for me ...
On Wed, Jun 28, 2017 at 10:50 AM, Rico Suter<EMAIL_ADDRESS>wrote:

I think the problem is that the method names are generated from the
OperationId and this is not changed with the ActionNameAttribute... You can
use the SwaggerOperationAttribute to set the operation ID... (by default
set to "controllerName_methodName").
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NSwag/NSwag/issues/821#issuecomment-311572481, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFR36dxI8DQ5cG5Wm-l7AqKRUh7OLaqRks5sIfemgaJpZM4OGviy
.

--
With regards
Midhun

Unfortunately the action name is not the same as the operation id. But you can just copy the code for the attribute into your project (namespace can be changed): https://github.com/NSwag/NSwag/blob/305db1d4afcd4179fec2b0ea70127af631cfe4b5/src/NSwag.Annotations/SwaggerOperationAttribute.cs

But we should use the ActionNameAttribute to generate the operattion id .. ill check look into this


Add usage, style, code, and accessibility documentation to assets in Carbon Styles library

Add usage, style, code, and accessibility documentation to each component in Carbon styles
https://github.com/carbon-design-system/carbon/blob/main/packages/styles/carbon.yml
assets:
  accordion:
    name: Accordion
    description: An accordion is a vertically stacked list of headers that reveal or hide associated sections of content.
    externalDocsUrl: https://www.carbondesignsystem.com/components/accordion/usage
    status: stable
    type: component
    platform: web
    noIndex: true
    thumbnailPath: ./thumbnails/accordion.svg
    tags:
      - data-display
      - content-element
    documentation:
      usagePath: https://github.com/carbon-design-system/carbon-website/blob/main/src/pages/components/accordion/usage.mdx
      stylePath: https://github.com/carbon-design-system/carbon-website/blob/main/src/pages/components/accordion/style.mdx
      codePath: https://github.com/carbon-design-system/carbon-website/blob/main/src/pages/components/accordion/code.mdx
      accessibilityPath: https://github.com/carbon-design-system/carbon-website/blob/main/src/pages/components/accordion/accessibility.mdx

Reference from carbon-website repo
https://github.com/carbon-design-system/carbon-website/tree/main/src/pages/components

Hey team! Please add your planning poker estimate with ZenHub @andreancardona @francinelucca @jdharvey-ibm

I updated documentation to docs in that example per the schema: https://github.com/carbon-design-system/carbon-platform/blob/main/docs/resource-schemas.md#asset-keys
It makes sense to add this to the existing Carbon Styles config file: https://github.com/carbon-design-system/carbon/blob/main/packages/styles/carbon.yml
At a later point in time, whenever we'd move those *.mdx pages from the carbon-website repo to https://github.com/carbon-design-system/carbon/tree/main/packages/styles - once we do that, we should consider placing those *.mdx files in a folder per asset, where each asset folder has its own carbon.yml with relative paths for usagePath, etc.


Localization on the BelongsTo doesn't work

I'm unable to use the Localization on the BelongsTo while related to this belongsTo from the parent Ajax call.

Same here


Fix tests.

The tests branch (https://github.com/digitalbazaar/data-hub-client/tree/tests) is supposed to:

bring over the tests from https://github.com/digitalbazaar/bedrock-web-data-hub/
get tests running in both browser (with karma testing) and in node
the intent is that this module can be a browser and node replacement for bedrock-web-data-hub

I did have the bedrock-web-data-hub tests running using this module (see https://github.com/digitalbazaar/bedrock-web-data-hub/tree/data-hub-client) but apparently that somehow broke.
[EDIT: bedrock-karma 1.4 broke things, tests will run with 1.3]
Tasks:

[x] Fix tests to run again in karma.
[ ] Remove bedrock things from the tests.  Some of the 'bedrock-web' test deps may actually work in node.  It may makes sense to just merge them in here?  Need to look into this.
[ ] Get tests to run in node.  There are a few WebCrypto calls that need to be fixed up for this.  The likely approach is to move browser specifics into a file (foo-browser.js), add a file with a node implementation (foo.js), and use the package.json browser override to map the node file to the browser one for bundler use.

@davidlehn just to keep you updated Pretender employs an IIFE pattern which means that on import or require it causes the node tests to fail. I am currently trying to stub it out, but that can be difficult as mocha spawns a different node process for each test. proxyquire can be used to handle this, but would need to be conditional. I'm also pretty close to mock keypair data too.


daemon: change when restored endpoints are inserted into endpoint manager

daemon/state.go:restoreOldEndpoints is executed before
pkg/identity/allocator.go.InitIdentityAllocator. Previously, endpoints were inserted into the endpointmanager in d.restoreOldEndpoints.
pkg/identity/allocator.go.InitIdentityAllocator calls daemon/policy.go:TriggerPolicyUpdates, which causes regeneration of policy for all endpoints managed by the endpointmanager. pkg/identity/allocator.go.InitIdentityAllocator is called before the daemon.l7Proxy is bootstrapped. This would result in errors like the following:
Error regenerating endpoint: can't update network policy, proxy disabled

which can result in the endpoints being put into not-ready state. This is because endpoints were inserted into the endpointmanager before daemon.l7Proxy was bootstrapped.
To fix this, move the insertion of endpoints into the endpoint manager in daemon/state.go:regenerateRestoredEndpoints, which is called after daemon.l7Proxyis bootstrapped, and after pkg/identity/allocator.go.InitIdentityAllocator. Since it is not desirable to try to regenerate endpoints until daemon.l7Proxy is bootstrapped, and daemon/state.go:regenerateRestoredEndpoints regenerates the endpoints, it is guaranteed that the above error will not be hit because daemon.l7Proxy is created synchronously before daemon/state.go:regenerateRestoredEndpoints is called.
Signed-off-by: Ian Vernon<EMAIL_ADDRESS>Summary of changes:
Fixes: #4390

This change is

test-me-please

This is probably fine but endpointmanager.Insert also updates some lookups for each EP. Those are used in the workload watchers to correlate events (I think). Since we've delayed the inserts to after all the restores are complete, and to after InitIdentityAllocator and daemon.go:init this might make our startup behaviour a little weird because of the large delay. In particular, I would expect that we might ignore containers for a little longer, until we do a periodic full sync of that data.

This is probably fine but endpointmanager.Insert also updates some lookups for each EP. Those are used in the workload watchers to correlate events (I think). Since we've delayed the inserts to after all the restores are complete, and to after InitIdentityAllocator and daemon.go:init this might make our startup behaviour a little weird because of the large delay. In particular, I would expect that we might ignore containers for a little longer, until we do a periodic full sync of that data.

I'm unsure how large this delay will be - especially since there will be no endpoints to regenerate when InitIdentityAllocator is initially called.

test-me-please

@raybejjani @ianvernon wasn't the entire restore previously happening around the place where this PR is proposing to put the endpointmanager.Insert()? We just moved parts of that workflow earlier to fix races with the IPAM?

@joestringer it appears so, yes.


I added a deep meaning movie code

issue #3
meaning 1:literal meaning
meaning 2:when you wake up from your illusion , then come find me

Awesome @Arccfire


Move 'warn_user()' message to stderr and add color

Example outputs (color not shown below, but lines starting with "WARN" are in yellow):
(new-host-4):~/cloudtruth-cli $ cargo run -q -- env
WARN: No 'environments' sub-command executed.
(new-host-4):~/cloudtruth-cli $ cargo run -q -- run -i none -- "command contains spaces"
WARN: command contains spaces, and will likely fail.
Try using 'cloudtruth run command "command contains spaces"'
sh: contains: command not found
(new-host-4):~/cloudtruth-cli $

Found a better way for other code reuse.


Raster shape drawing

Implement basic raster shape drawing for dcv.plot module.
Sources:
https://en.wikipedia.org/wiki/Bresenham's_line_algorithm
https://en.wikipedia.org/wiki/Xiaolin_Wu's_line_algorithm

Integration with GGPlotD is implemented: 85d43c300f76c40037430fa448e56a9b834dd8b0


React Basic GUI Implementation

@theiceoan  - I've just fixed the gui - performed functional testing, and now tested running Angular and React apps in parallel - one shows live changes in the other - and vice versa.  Next things to fix here are the dismissal of the trade ticket and the ticket's stickiness of the toggle button for side.


Add dtc compatible with 3.8.13 kernel

Use RCN's script to fetch and build a dtc compiler compatible with
the 3.8.13 kernel used by the Machinekit image.
General cleanup of the machinekit/scripts directory
Signed-off-by: Charles Steinkuehler<EMAIL_ADDRESS>

Thanks!

ps, re-queue-ing the weekly builder, so this will be part of this week's image. ;)

On 11/20/2016 10:05 AM, Robert Nelson wrote:

ps, re-queue-ing the weekly builder, so this will be part of this week's image. ;)

Thanks!!
--
Charles Steinkuehler
<EMAIL_ADDRESS>

My jenkins build bot didn't like something:
http://rcn-ee.homeip.net:8080/job/weekly_bb.org_machinekit-debian-jessie/18/console
so i reworked it:
https://github.com/RobertCNelson/omap-image-builder/commit/4ab9d5fea5440927e9a9495d3b90396d675e4cc3
https://github.com/RobertCNelson/boot-scripts/commit/66e42b05a39b7d7aab745da2de8ddaa68b7ba09d

On 11/20/2016 11:55 AM, Robert Nelson wrote:

My jenkins build bot didn't like something:
http://rcn-ee.homeip.net:8080/job/weekly_bb.org_machinekit-debian-jessie/18/console
so i reworked it:
4ab9d5f
https://github.com/RobertCNelson/omap-image-builder/commit/4ab9d5fea5440927e9a9495d3b90396d675e4cc3
RobertCNelson/boot-scripts@66e42b0
https://github.com/RobertCNelson/boot-scripts/commit/66e42b05a39b7d7aab745da2de8ddaa68b7ba09d

Yeah, I had a nasty time getting your dtc.sh script running, but I
though the version I pushed was working.
Regardless, the new way looks much better, thanks!
--
Charles Steinkuehler
<EMAIL_ADDRESS>

ah, i think i found it..
"sudo rsync"..
added:
/usr/bin/rsync

to my /etc/sudoers on the build bots..

On 11/20/2016 2:23 PM, Robert Nelson wrote:

ah, i think i found it..
"sudo rsync"..

I believe the rsync failed because you deleted all the files it would
have copied.
...but that's OK, because the files were only scripts to build the dtc
utility which you're now building in a different (and better!) way.
So there are some warning messages and (unimportant) errors in the
output, but it looks like everything builds OK.  I'm going to try and
take some time next week to do some testing, clean things up, and add
some SoC+FPGA target image configurations, so look for another PR
soon-ish.
--
Charles Steinkuehler
<EMAIL_ADDRESS>


how can i create a conversation?

how can i create a conversation?

just send a message using user id.
Talk::sendMessageByUserId($userId);

ty ! what did not realize was that we passed parameter in this command?
if you put 0 or nothing return all inbox  if you pu the user id return empty array

You may first set authenticated users id like this
Talk::setAuthUserId(auth()->user()->id);

and then call this method with a receiver id
Talk::sendMessageByUserId($userId);

sorry in this command Talk::getInbox() can you explain what is parameter's ?

Please read the doc.
https://github.com/nahid/talk#getinbox
this method has two optional parameters $offset and $take

and what they do, can you explain?
thanks in advance

Its helps to you to make pagination.


Update starfinder.html

Bug Fixes

NPC initiative not rolling when set to 0
Internal Compendium not importing

@wing-it, Any chance for an out of sequence merge on these fixes? They're two things that break for people.

@wing-it  The initiative bug is actually something that prevents the sheet from being useful in the common event of combat breaking out.


Add Coltrane ruby app

Fixes #220801
A music calculation library/CLI written in Ruby.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] Tested, as applicable:

[x] Tested basic functionality of all binary files (usually in ./result/bin/)

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/931


kaminari without Rails will end up in "uninitialized constant Rails::Railtie"

Hello guys,
First of all: Thank you so such for this gem and all the work put into it, I love it!
I'm currently building a ruby gem that depends on kaminari but I can't make it work without commenting the lines on my local kaminari installed gem:
# if not using Railtie, call `Kaminari::Hooks.init` directly
if defined? Rails
  require 'kaminari/railtie'
  require 'kaminari/engine'
end

Since kaminari depends on actionpack that in turn depends on rails-html-sanitizer the line https://github.com/amatsuda/kaminari/blob/master/lib/kaminari.rb#L36 returns true because rails-html-sanitizer defines the class Rails::Html::Sanitizer: https://github.com/rails/rails-html-sanitizer/blob/master/lib/rails-html-sanitizer.rb
Subsequently require 'kaminari/railtie' and require 'kaminari/engine' will fail because I don't have Rails and ::Rails::Railtie, ::Rails::Engine are not defined.
I didn't want to open a PR with just two "IF's" but I also didn't want my gem to depend on a local changed kaminari version.
Could you guys make a quick fix, or shall I open a PR?
or this isn't even a bug and I'm missing something all together?
Thanks in advance!
@yuki24

@goncalvesjoao This seems a little tricky. I'll look into this issue, but for the time being, could you just manually require kaminari components one by one as a workaround?
# In Gemfile
gem 'kaminari', require: false

# Load Kaminari components one by one before you call the .page method
require 'kaminari/config'
require 'kaminari/helpers/action_view_extension'
require 'kaminari/helpers/paginator'
require 'kaminari/models/page_scope_methods'
require 'kaminari/models/configuration_methods'
require 'kaminari/hooks'

Kaminari::Hooks.init

I suppose this would work (I'm sorry I don't remember why I didn't do so when I firstly wrote this...)
-if defined? Rails
+if defined? ::Rails::Railtie

We're requiring 'rails' at L6, which should defined ::Rails::Railtie when rails is bundled. https://github.com/rails/rails/blob/1621eda81d6abcc13c7755606752710b5d84c49b/railties/lib/rails.rb#L11

Ah, no. It wasn't me who initially wrote this code. OK, I'll push the fix.
Thank you @goncalvesjoao for finding and reporting this 🐛 !

@amatsuda do you think we should backport this change?

@yuki24 I guess so. I'll do the backporting later.

Sorry for the late reply.
Awesome!
Glad to be of use.
Especially for a gem that I've been using for years. Thanks guys :laughing:


higher fov options

can you please make higher fov options or at least make fov mods compatible?

try changing 100 in this line, maybe this will work


Nested advanced queries

Based on the advanced queries document, is it possible to have nested advanced queries? For example:
{
  articles: searchArticles(search:'abc'') {
    nodes {
        text
        posts:searchComments(search: 'def') {
            nodes {
                text
            }
      }
}

(Which would return articles with 'abc' in the text, and any comments with 'def' in the text)

Yep

The latter is a “computed column” though.
https://www.graphile.org/postgraphile/computed-columns/

That's great, thanks. I thought it might be related but missed the part about additional parameters


[FR]: longPressDraggable Support for onLongPress Event & onClick Event

This library is amazing!
However, I have a requirement for longPressDraggable where I need to respond to onLongPress first before responding to onDragStarted().
Currently, the internal implementation of longPressDraggable intercepts the long press event. Could you add a new function or an interface like onLongPress: () -> Unit = { }?

+1

Hmm can't you just use onDragStart? It should be called right after a long press
longPressDraggable uses detectDragGesturesAfterLongPress which doesn't have a separate onLongPress so I don't know how I can add one easily.
suspend fun PointerInputScope.detectDragGesturesAfterLongPress(
    onDragStart: (Offset) -> Unit = { },
    onDragEnd: () -> Unit = { },
    onDragCancel: () -> Unit = { },
    onDrag: (change: PointerInputChange, dragAmount: Offset) -> Unit
)

Or are you suggesting something like making onDragStarted a suspend function where dragging wouldn't start until it returns?

Yes, this approach can solve the issue of missing the onLongPress event. However, my requirement also includes an onClick event, which I use to trigger navigation actions.
When I attempted to chain .clickable() with longPressDraggable() using Modifier, I found that the .clickable() event would be triggered after the drag ends, leading to unexpected navigation behavior.
To address this, I adjusted the code to use awaitPointerEventScope for gesture detection, and I submitted a PR to demonstrate this functionality: https://github.com/Calvin-LL/Reorderable/pull/56.
Would you be willing to allow me to continue contributing to this feature request?
Alternatively, would you consider changing the internal modifier in ReorderableLazyCollection.kt to open, so that users of the library can override it themselves?


Update Jun Kang's PPP draft

Jun Kang's PPP is now up to date.
View here
Closes #181.

Codecov Report

Merging #196 (65e5a21) into master (2ea4de7) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #196      +/-   ##
============================================
- Coverage     79.70%   79.46%   -0.25%
- Complexity      749      751       +2
============================================
  Files           111      111
  Lines          2212     2225      +13
  Branches        234      235       +1
============================================
+ Hits           1763     1768       +5
- Misses          380      386       +6
- Partials         69       71       +2

Impacted Files
Coverage Δ

...in/java/seedu/address/logic/parser/ParserUtil.java
80.45% <0.00%> (-7.55%)
:arrow_down:

...in/java/seedu/address/model/date/ReminderDate.java
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea4de7...65e5a21. Read the comment docs.


0.13 on notice

I'm think I'm gonna remove 0.13 unless someone wants to fix the build.
0.13 thank you for your serivce. /bow

Yea i think nobody needs it anymore.

0.13 removed with commit 629a3fade3eeebeabba85c1a532c81033b07df22.


docs: fixing a few typos

Description
Found a couple typos in online documentation while using it as a template for BSR
Fixes #169
Type of change:

Documentation update

Features:

textual typo fix

Might just want to check with @hollandjg to see why the second build test isn't working? It's odd, given that it's just a minor change in the documentation.

Might just want to check with @hollandjg to see why the second build test isn't working? It's odd, given that it's just a minor change in the documentation.

looks like it's passed now without me doing anything else... strange...

Might just want to check with @hollandjg to see why the second build test isn't working? It's odd, given that it's just a minor change in the documentation.

looks like it's passed now without me doing anything else... strange...

but now they are not passing again... i have been seeing the following error regularly, and now i'm not sure if it's local to me or global:
An unexpected error has occurred: CalledProcessError: command: ('/home/runner/.cache/pypoetry/virtualenvs/autora-X42fqSpF-py3.9/bin/python', '-mvirtualenv', '/home/runner/.cache/pre-commit/repopsmig3z3/py_env-python3.8', '-p', 'python3.8')
return code: 1
expected return code: 0
stdout:
    RuntimeError: failed to find interpreter for Builtin discover of python_spec='python3.8'

This should be fixed now – the PR has been updated to include changes from #175


try to retain grafana pv when converting managedchart to addon

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:

Rancher-monitoring Grafana pv (when existing) is deleted and recreated when upgrading from v112 to v120.
Note: In Harvester v1.1.2, the grafana pvc is enabled by default. Unless the rancher-monitoring managedchart was changed.
Solution:

Try to retain grafana pv when upgrading.
Note: Controller side fix will be tracked in https://github.com/harvester/harvester/issues/4118, it will on top of
Issue https://github.com/harvester/harvester/issues/4108
PR https://github.com/harvester/harvester/pull/4110
Related Issue:
https://github.com/harvester/harvester/issues/4071
Test plan:

Install v112
Upgrade  v120
Check PVC and pv

The grafana pvc has smaller AGE than pv.
e.g. 2m9s vs 32d

kubectl get pvc -A
NAMESPACE                  NAME                                                                                STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS         AGE
cattle-monitoring-system   alertmanager-rancher-monitoring-alertmanager-db-alertmanager-rancher-monitoring-alertmanager-0   Bound    pvc-2cdebcbd-6d6e-473a-bc0c-4203714fdebc   5Gi        RWO            harvester-longhorn   32d
cattle-monitoring-system   prometheus-rancher-monitoring-prometheus-db-prometheus-rancher-monitoring-prometheus-0           Bound    pvc-6c8796a4-3119-4fa4-b619-33497f2751bd   50Gi       RWO            harvester-longhorn   32d

cattle-monitoring-system   rancher-monitoring-grafana                                                                       Bound    pvc-e2983b67-035a-485e-bb44-fbf6309389cb   2Gi        RWO            harvester-longhorn   2m9s

kubectl get pv -A
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                                                                                STORAGECLASS         REASON   AGE
pvc-2cdebcbd-6d6e-473a-bc0c-4203714fdebc   5Gi        RWO            Delete           Bound    cattle-monitoring-system/alertmanager-rancher-monitoring-alertmanager-db-alertmanager-rancher-monitoring-alertmanager-0   harvester-longhorn            32d
pvc-6c8796a4-3119-4fa4-b619-33497f2751bd   50Gi       RWO            Delete           Bound    cattle-monitoring-system/prometheus-rancher-monitoring-prometheus-db-prometheus-rancher-monitoring-prometheus-0           harvester-longhorn            32d

pvc-e2983b67-035a-485e-bb44-fbf6309389cb   2Gi        RWO            Retain           Bound    cattle-monitoring-system/rancher-monitoring-grafana                                                                       harvester-longhorn            32d

@mergifyio backport v1.2


Write Building UIs in Flutter codelab

Write a codelab that shows users how to build a Flutter UI.

Code the UI for a chat app
The app doesn't work yet.
Leads to Firebase codelab...see https://github.com/flutter/flutter/issues/7702

Done. https://flutter.io/tutorials/layout/


update builtin_types for latest Zig

Looks like it's not needed and highlightning is created somewhere else...


Migrate identifiers reference into documentation

This is a Feature Request

What would you like to be added
Migrate https://github.com/kubernetes/community/blob/master/contributors/design-proposals/architecture/identifiers.md into a new page within https://kubernetes.io/docs/reference/
Why is this needed
The identifiers reference documentation is useful to Kubernetes users as well as to the contributor community.
We should:

present it as part of the documentation
localize it

After migration, https://github.com/kubernetes/community/blob/master/contributors/design-proposals/architecture/identifiers.md should become a short document that links to the new page, at least for a few years.
Comments
/language en
/kind feature
/sig architecture

hey @sftim  I would like to help with this

/assign

I've changed my mind on what we should do here; see  https://github.com/kubernetes/website/pull/29993#pullrequestreview-847160549
Sorry about that.


Add disabled state

The checkbox needs a disabled state besides the basic checked/unchecked. Are you receiving pull requests?

This feature would be very useful

PR here https://github.com/crazycodeboy/react-native-check-box/pull/35

In the meantime the PR is merged you can install the fork by:
npm install<EMAIL_ADDRESS>


Feature validation

@dramich I think I was too focused on matching the current validation for feature and didn't consider how the webhook affects all requests. Removed create/delete checks and narrowed scope of value/lockedValue validation to prevent just the specific case that matters.


modal background issue only in ios devices

I tried to find this issue already but didn't seem to find any, not sure if I'm doing anything wrong.
Desktop version of one of my modals (android devices display like this with different width obviously):

IOS version of one of my modals:

The background becomes black for no reason (I can think of) if the modal height is bigger than device's. It displays the viewable part correctly when you open it, but the modal part that is not viewable on open, once you scroll down, background is black. Text is there, though.

Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case via JS Bin or CodePen and report back with your link, Bootstrap version, and specific browser and OS details.

Closing due to no follow-up with a demo of a reduced test case.


Release React 4.5.0 (Dart 2 Compatible!!!)

React is now compatible with the Dart 2 SDK!
Consumer Consumption Tests

[x] PASSED over_react
[x] PASSED wsd

Had to remove usage of deprecated isCompositeComponentWithType test utility to get tests to pass using the 1.24.3 SDK + dartdevc compiler

QA +1

Tests pass using Dart SDK 1.24.3
Tests pass using Dart SDK 2.0.0
Examples function as expected
Consumer tests pass

+1 to https://github.com/cleandart/react-dart/pull/150/commits/f0ade101b7b699c7bec5eb53218d34bd94556315, https://github.com/cleandart/react-dart/pull/150/commits/bc2c7ee7fd92f8618594c26770334a262305c9c6 and https://github.com/cleandart/react-dart/pull/150/commits/001afe0b2adade434fc67bd488c2795ef521b5eb


The function getPublicKey() does not pad the returned value with 0 if the calculated public key should have zeros at beginning

The result is that the user gets wrong value.
In function getPublicKey(...)
  return P.x!.toBigInteger()!.toRadixString(16);

Should be
  return P.x!.toBigInteger()!.toRadixString(16).padLeft(64, '0');

@johnonchain

Can you send a pull request? If not I can do it eventually, but inertia is a force.

will send soon.

Update: Once I pad the 0's to the returned value of public key, even then there seems to be a problem where the signed nostr message/event is not being accepted by the relays, so it indicates the messages using such secret key ( with leading 0's in its public key) aren't being generated correctly.

To give a sample for investigators
ea7daa0537b93aa3ae4495a274ecc05077e3dc168809d77a7afa4ec1db0fb3bd # private key
0ba0206887bd61579bf65ec09d7806bea32c64be1cf2c978cf031a811cd238db # public key

Trying to figure out whats wrong here. This is really huge issue for all dart/flutter client, cause its making signatures wrong as @vishalxl said . Unfortunately haven't been able to figure out where is the problem, but will continue next week trying

Fixed in https://github.com/nbd-wtf/dart-bip340/commit/669a18d1670cdd6df36a54f4ba798fbc58c69410.

Had a discussion with @fiatjaf and we werent able reproduce failing events (so it was probably mistake on my site). In this case, just leading 0's were the issue


newly handed out docker volume mounts can refer to deleted dots

/var/lib/dotmesh/container_mnt/admin # ls -alh
lrwxrwxrwx    1 root     root          62 Jul  5 13:06 dotscience-project -> /var/lib/dotmesh/mnt/dmfs/397bd76b-34d9-4b64-5248-13e850172215

BUT
luke@dot:~/ps/dotscience-ui-spike$ dm dot show dotscience-project
Dot admin/dotscience-project:
Master branch ID: caa5f787-7271-4f01-62d8-d4dca6b2fff8
Dot is currently selected.
Commits: 1
Dot size: 19.00 kiB (all clean)
Branches:
* master
   Replication Status:
    server c1259a93e0498e4d [MASTER] (status: active: waiting, 1 snaps (v0)) is up to date

Note that the fsIds do not line up. This happened after I deleted a dot and tried to make a new one with the same name. I guess the symlink was still lying around. Isn't deletion meant to clean up these /var/lib/dotmesh/container_mnt symlinks?

trying this again didn't exhibit the same problem, so it's at least intermittent fwiw.

this happened after https://github.com/dotmesh-io/dotmesh/issues/488 fwiw

Needs to happen on all nodes plz :-)

There's some code already in place to delete the symlinks, but it's being missed or coming too late in some error cases, so I've added code to do a synchronous deletion on the current node when Delete happens - which should create a somewhat better illusion of the delete happening synchronously (from one vantage point).


Is choo abandoned / no longer maintained?

It's considered stable & feature complete. Critical issues are addressed, but there's currently nobody being paid to work full time on it.

@yoshuawuyts Ok, thanks. The very old pull requests that are neither merged nor rejected make the project look unmaintained.

@obv-mikhail ah yeah, I can imagine the optics of that aren't great. The truth to that is though that a a lot of those are good PRs that require a bit more work in the ecosystem to fully support. We haven't properly scoped out a next major version yet, and they'd be part of that so they haven't been merged yet into mainline Choo. Which means they've been open for a while, and probably will be until the next semver major.
Does that make sense?

@yoshuawuyts Yes it does. Thanks again.


cmd/compile: investigate wasm sync inlining

https://go-review.googlesource.com/c/go/+/148958/ made sync.Mutex.Unlock inlinable.
It worked for Wasm, but then CL 164461 and CL 153797 landed and the resulting merge no longer passed the inlining tests.
As a quick fix, https://go-review.googlesource.com/c/go/+/165339 ignored wasm in the inlining tests.
Investigate & re-enable.
/cc @ALTree @neelance @aclements @CAFxX

The test now explains:
// FIXME: This test is disabled on architectures where atomic operations
// are function calls rather than intrinsics, since this prevents inlining
// of the sync fast paths. This test should be re-enabled once the problem
// is solved.

This applies to wasm since it has no atomic operations yet. The test needs to be reenabled after the threads proposal landed.


Set up a charts repository for easy installation

Would be nice with something like this:
$ helm repo add service-catalog https://service-catalog.charts.k8s.io/
$ # or
$ helm repo add service-catalog https://k8s-service-catalog-charts.charts.k8s.io/
$ helm install service-catalog/catalog
$ helm install service-catalog/ups-broker

and an update on every new release
cc @MHBauer @duglin

yep - would be even nicer if we could put the ups-broker into the "catalog" chart

@luxas any idea how the k8s.io domain works? How helm repo works for setting up a server? Any thoughts on what https://kubeapps.com/ is ?
@duglin Isn't this just done by moving the ups chart into the catalog chart? Maybe we could symlink it?

cc @jbeda @thockin @ixdy who knows how the k8s.io domain work
@MHBauer It's basically a redirect domain: https://github.com/kubernetes/k8s.io
Anyway, let's start with https://k8s-service-catalog-charts.storage.googleapis.com/ or something like that; just a normal GCS bucket.

This is a duplicate of https://github.com/kubernetes-incubator/service-catalog/issues/735. Referencing this issue in #735 & closing


i try to import the zip file and it says "not a lively wallpaper file"

That's strange! Make sure your Lively Wallpaper is up to date and try downloading it from this link: https://github.com/DigitalNaut/AudioDotVisualizer/releases/download/Release/AudioDot_v1.0.zip

I have same problem,but I have latest version.


Question about security group

Dear Maintainer,
I have a couple of questions regarding your security group definitions.
My goal is to have least possible access and only access the vault servers via its ELB from anywhere. Apart from that each of the servers (vault and consul) should have very strict rules as there are also other EC2 instances in the same VPC which should NOT be able to access the,.
vault_cluster.allowed_inbound_cidr_blocks

Line: https://github.com/hashicorp/terraform-aws-vault/blob/master/main.tf#L78

Is this supposed to be HTTPS access to each of the vault clusters?
Is it sufficient, if I only allow the Vault ELB as inbound or does each vault cluster also need
to talk to the other vault clusters?
module "vault_cluster" {
  ...
  allowed_inbound_cidr_blocks          = ["<IP_ADDRESS>/0"]
  ...
}

security_group_rules.allowed_inbound_cidr_blocks

Line: https://github.com/hashicorp/terraform-aws-vault/blob/master/main.tf#L125

Is it safe to only specify the CIDR of the consul clusters or do I need external access here?
module "security_group_rules" {
  ...
  allowed_inbound_cidr_blocks          = ["<IP_ADDRESS>/0"]
  ...
}

consul_cluster.allowed_inbound_cidr_blocks

Line: https://github.com/hashicorp/terraform-aws-vault/blob/master/main.tf#L191

What exactly needs to connect to the consul cluster as the safest minimum?
module "consul_cluster" {
  ...
  allowed_inbound_cidr_blocks = ["<IP_ADDRESS>/0"]
  ...
}

Is this supposed to be HTTPS access to each of the vault clusters? Is it sufficient, if I only allow the Vault ELB as inbound or does each vault cluster also need to talk to the other vault clusters?

If you only want access via the ELB, then set allowed_inbound_cidr_blocks to an empty list and set allowed_inbound_security_group_ids to the security group of the ELB.

Is it safe to only specify the CIDR of the consul clusters or do I need external access here?

The Consul agents should be accessible from Vault and Consul. Ad both of their security group IDs to allowed_inbound_security_group_ids.

What exactly needs to connect to the consul cluster as the safest minimum?

Consul should be accessible from Vault. Add its security group IDs to allowed_inbound_security_group_ids.

@brikis98 thanks for the reply. I dug a little deeper into this and am in need of some more clarifications. I'm a bit lost at the moment and want to ensure that I give out the least possible privileges. I will put it as simple yes/no so I can make sure I only have what I really need.
Vault
8301 (consul agent port?)
In your example 8301 is allowing TCP and UDP.

Does the vault instance need to allow inbound TCP on 8301 from itself?
Does the vault instance need to allow inbound TCP on 8301 from other vault instances?
Does the vault instance need to allow inbound TCP on 8301 from consul instances?
Does the vault instance need to allow inbound UDP on 8301 from itself?
Does the vault instance need to allow inbound UDP on 8301 from other vault instances?
Does the vault instance need to allow inbound UDP on 8301 from consul instances?

8201 (Vault HA port?)
In your example 8201 is only allowing TCP.

Does the vault instance need to allow inbound TCP on 8201 from itself?
Does the vault instance need to allow inbound TCP on 8201 from other vault instances?
Does the vault instance need to allow inbound TCP on 8201 from consul instances?

Consul
8300 (server rpc port)
In your example 8300 is only allowing TCP.

Does the consul instance need to allow inbound TCP on 8300 from itself?
Does the consul instance need to allow inbound TCP on 8300 from other consul instances?
Does the consul instance need to allow inbound TCP on 8300 from vault instances?

8301 (lan port)
In your example 8301 is allowing TCP and UDP.

Does the consul instance need to allow inbound TCP on 8301 from itself?
Does the consul instance need to allow inbound TCP on 8301 from other consul instances?
Does the consul instance need to allow inbound TCP on 8301 from vault instances?
Does the consul instance need to allow inbound UDP on 8301 from itself?
Does the consul instance need to allow inbound UDP on 8301 from other consul instances?
Does the consul instance need to allow inbound UDP on 8301 from vault instances?

8302 (wan port???)
In your example 8302 is allowing TCP and UDP.
As the name says serf_wan_port, is this actually required for a setup in a single VPC?

Does the consul instance need to allow inbound TCP on 8302 from itself?
Does the consul instance need to allow inbound TCP on 8302 from other consul instances?
Does the consul instance need to allow inbound TCP on 8302 from vault instances?
Does the consul instance need to allow inbound UDP on 8302 from itself?
Does the consul instance need to allow inbound UDP on 8302 from other consul instances?
Does the consul instance need to allow inbound UDP on 8302 from vault instances?

8500 (api port?)
In your example 8500 is only allowing TCP.

Does the consul instance need to allow inbound TCP on 8500 from itself?
Does the consul instance need to allow inbound TCP on 8500 from other consul instances?
Does the consul instance need to allow inbound TCP on 8500 from vault instances?

8600 (dns port?)
In your example 8600 is allowing TCP and UDP.

Does the consul instance need to allow inbound TCP on 8600 from itself?
Does the consul instance need to allow inbound TCP on 8600 from other consul instances?
Does the consul instance need to allow inbound TCP on 8600 from vault instances?
Does the consul instance need to allow inbound UDP on 8600 from itself?
Does the consul instance need to allow inbound UDP on 8600 from other consul instances?
Does the consul instance need to allow inbound UDP on 8600 from vault instances?

Others
cli rpc port
I also see Consul inbound 8400/tcp from vault and <IP_ADDRESS>/0 by the default example, however no vault instance exposes this port, or am I missing something here?
Thanks for your time.


invalid copy batch size error when the processed array is empty

Bicep version
0.4.63
Describe the bug
Serial deployment of resources by using decorator "batchSize" in front of the module does not work when the processed array is empty.
When I put @batchSize(1) in front of the module, the deployment fails with error that the batchSize is higher than the copy count, which is true but it should be able to skip the processing in that case. I tried to achieve that with a condition to check if the array is empty but the same error is generated in that case.
To Reproduce
Deployments of the following role assignments need to be done in serial mode. But some of the aksCluster objects in parameters file have an empty outboundPublicIps array and in that case the issue occurs.
@batchSize(1)
module publicIpsRoleAssignmentRes 'resource-group-role-assignment.bicep' = [for (outboundPublicIp, i) in aksCluster.network.outboundPublicIps: if (aksCluster.systemAssignedManagedIdentity && !empty(aksCluster.network.outboundPublicIps)) {
  name: 'publicIpsRoleAssignmentMI-${uniqueString(aksCluster.name)}-${i}'
  scope: resourceGroup(empty(aksCluster.network.outboundPublicIps) ? 'dummy' : union(defaultOutboundPublicIpsObject, outboundPublicIp).resourceGroup)
  params: {
    // Network Contributor role
    roleDefinitionId: '4d97b98b-1d4f-4787-a291-c67834d212e7'
    principalId: aksCluster.systemAssignedManagedIdentity ? reference(resourceId('Microsoft.ContainerService/managedClusters', aksCluster.name), '2020-09-01', 'Full').properties.identityProfile.kubeletidentity.objectId : ''
  }
  dependsOn: [
      aksClusterRes
  ]
}]

In that case, when deploying, this gives error:
InvalidTemplate - Long running operation failed with status 'Failed'. Additional Info:'Deployment template validation failed: 'The template 'copy' definition at line '1' and column '36822' has an invalid copy batch size. The copy batch size must be a non-negative integer value and cannot exceed the copy count '0'. Please see https://aka.ms/arm-copy for usage details.'.'

Additional info:
extending the copy count with a condition in the generated ARM-file does fix it.
      "copy": {
        "name": "publicIpsRoleAssignmentRes",
        "count": "[if(equals(length(parameters('aksCluster').network.outboundPublicIps), 0), 1,length(parameters('aksCluster').network.outboundPublicIps))]",
        "mode": "serial",
        "batchSize": 1
      },

How can we achieve this in bicep?

+1

This is a bug in the runtime. We need to relax the validation on batch size for empty copy loops.

Following seems to be a workaround for the issue :
@batchSize(1)
module publicIpsRoleAssignmentRes 'resource-group-role-assignment.bicep' = [for i in range(0, ((length(aksCluster.network.outboundPublicIps) == 0) ? 1 : length(aksCluster.network.outboundPublicIps))): if (aksCluster.systemAssignedManagedIdentity && !empty(aksCluster.network.outboundPublicIps)) {
  name: 'publicIpsRoleAssignmentMI-${uniqueString(aksCluster.name)}-${i}'
  scope: resourceGroup(empty(aksCluster.network.outboundPublicIps) ? 'dummy' : union(defaultOutboundPublicIpsObject, aksCluster.network.outboundPublicIps[i]).resourceGroup)
  params: {
    // Network Contributor role
    roleDefinitionId: '4d97b98b-1d4f-4787-a291-c67834d212e7'
    principalId: aksCluster.systemAssignedManagedIdentity ? reference(resourceId('Microsoft.ContainerService/managedClusters', aksCluster.name), '2020-09-01', 'Full').properties.identityProfile.kubeletidentity.objectId : ''
  }
  dependsOn: [
      aksClusterRes
  ]
}]

This is a bug in the runtime. We need to relax the validation on batch size for empty copy loops.

@majastrz not necessarly. If you can allow the code to be translated to:
"copy": {
                "name": "publicIpPrefixesRoleAssignmentMICopy",
                "count": "[length( parameters( 'aksCluster' ).network.outboundPublicIpPrefixes )]",
                // avoids conflicts of assigning the same role at the same time
                "mode": "Serial"
            },

it should work without having to do anything additional on runtime. If I remember @briandmoore is aware of this trick.

@majastrz - any thoughts on if it would be just as much work to relax the constraint vs generating this workaround in the JSON?

transpiling @batchSize(1) to mode: serial would seem to simplify this quite a bit...

I wasn't aware of that workaround, so thanks for the info!
We are transpiling @batchSize(1) to mode: serial. The issue appears to be that we are additionally emitting batchSize: 1 in that case. The runtime check is triggered by the presence of the batchSize property in the JSON. So if we stop emitting batchSize when batchSize is set to 1, we should be ok.
@alex-frankel The cost is slightly lower for a Bicep fix, so I think I'll take that approach. However, I will need to add a test to the runtime repo to make sure we assert on this runtime behavior and prevent any future regression in this area.

Does this fix work for @batchSize(2) though? Seems like we'd need an IL fix for any batchSize value to work generically with an empty array, unless I'm mistaken.

Also, from the error message, it seems like it would also fail on batchSize(n) where n is less than the number of resources in the loop.

Yes, you're right. A bicep fix would only make the batchSize == 1 workaround work but it would still be broken for batchSize != 1. Runtime fix it is 😊 (it should be an easy one).

yeah good catch - though I'm struggling to come up with the scenario (with batchsize(2)) where you wouldn't want the error...

yeah good catch - though I'm struggling to come up with the scenario (with batchsize(2)) where you wouldn't want the error...

We don't want it when count == 0.

@bmoore-msft I think there was a case for the number in batchsize() to be dynamic but still it is I would rather say API problem but as we all know API problems are hard to fix. The API I am talking about is Azure Automation where you can import PowerShell modules in parallel as long as you are not importing more than 5. So if you want to import 10 modules you batch size will be 5 but if you want to import 2 modules your batch size would be 2. Of course you could also go with setting static value of 1. I have not tested this API for some time but I doubt that the issue is resolved. Overall the batchsize(1) where array could be empty or not is the most common case as we have probably 6-7 cases where we need to do this.
P.S. as we are converting our solutions to Bicep we have logged/+1 a few advanced cases where Bicep cannot translate the code to what is possible in ARM.

I've got a fix to the deployments engine for this in review - will update this thread once it's been deployed.

yeah good catch - though I'm struggling to come up with the scenario (with batchsize(2)) where you wouldn't want the error...

I have one such scenario. I'm running a large deployment that could potentially exceed the cap of 800 resources per deployment. As a work around, I'd like to batch my resources to avoid hitting the limit (batchSize(100), for instance). However, I don't know in advance how many resources will be passed. If I pass less than 100 resources, Bicep will complain that my batch size is greater than my resource count.

yeah good catch - though I'm struggling to come up with the scenario (with batchsize(2)) where you wouldn't want the error...

I have one such scenario. I'm running a large deployment that could potentially exceed the cap of 800 resources per deployment. As a work around, I'd like to batch my resources to avoid hitting the limit (batchSize(100), for instance). However, I don't know in advance how many resources will be passed. If I pass less than 100 resources, Bicep will complain that my batch size is greater than my resource count.

Never mind, that wouldn't work... I can't apply batchsize at the module level to batch resources into multiple deployments. Back to the drawing board.

@guythetechie I believe that even you batch in 800 ARM will still complain around the 800 limit as you cannot do more than 800 deployments with single deployment. You also will hit the 800 deployment history per resource group/subscription/management group. There is automatic purging but it might not help you in that case as it kicks ones when certain limit is reached and if you reach the 800 limit before the purging completes your deployment will still fail.


Adding serialized save file and storing theme settings.

Resolves #8
CHANGES

A new configuration file is now available for saving certain user specific-settings.
If one does not already exist, the configuration file will be created at the following directory:

Linux and MacOS: if defined, $XDG_CONFIG_HOME/logicrs/config.json. If not, $HOME/.config/logicrs/config.json
Windows: %USERPROFILE%\AppData\Local\logicrs\config.json

Currently, the settings file is only used for saving the theme, so that this persists between application sessions.
If for some reason writing or reading from or to the settings file becomes impossible, an error message will be logged and the application will proceed under the assumption that user settings cannot be accessed.

TESTING CRITERIA

Open the application.
Change the theme by selecting an option from Settings -> Theme.
Close the application.
Restart the application and notice that the chosen theme from Step 2 is now loaded immediately.
Also notice that when accessing Settings -> Theme, the radio button will now be set to the currently selected theme.

Please do let me know if you have any thoughts on the implementation - I am very new to Rust so if you have any suggestions for improvements I would be very happy to implement them!

Awesome, excellent job!


botan2: 2.17.3 -> 2.18.0

Motivation for this change
https://botan.randombit.net/news.html#version-2-18-0-2021-04-15
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 121164 at d4c033a2 run on x86_64-linux 1

2 packages marked as broken and skipped:

neopg
tlspool

5 packages built successfully:

biboumi
botan2
corectrl
kea
softhsm

1 suggestion:

warning: missing-phase-hooks
configurePhase should probably contain runHook preConfigure and runHook postConfigure.
Near pkgs/development/libraries/botan/generic.nix:30:3:
   |
30 |   configurePhase = ''
   |   ^


How can I convert a ByteBuffer to a FloatBuffer (as java.nio.ByteBuffer#asFloatBuffer factory method)?

Hi,
I want to reuse a Java implementation which converts a ByteBuffer to a FloatBuffer. How can I achieve this?
Thanks.

There's currently no support for that! Pull requests are supported however :)

Okay. Maybe I'll search for another approach!


Rotation transformation updates for >= iOS8 and enabled split view

Created Launch Screen storyboard to enable split view
Fixed iOS7 check

= iOS8 we have a rootViewController instead of caring about transforming the UIWindow.

+1


Make new HttpContext properties virtual

Fixes https://github.com/aspnet/AspNetCore/issues/10594

Ref assemblies...


Add the default navigation collapse with the theme.

Fix #194
Before : With fullname for autopai

After : with obj name for autoapi

Well Done @Revathyvenugopal162 . We will all benefit from it.


[1.8.4] Cannot be built on Windows

I'm getting errors while trying to build release-1.8.4 with Visual Studio 2017:
Cannot open include file: 'autoconfig.h': No such file or directory
Cannot open source file: '..\..\threadutil\src\FreeList.c': No such file or directory
Cannot open source file: '..\..\threadutil\src\LinkedList.c': No such file or directory
Cannot open source file: '..\..\threadutil\src\ThreadPool.c': No such file or directory
Cannot open source file: '..\..\threadutil\src\TimerThread.c': No such file or directory
Cannot open include file: 'upnpconfig.h': No such file or directory

This is an older problem introduced with: https://github.com/mrjimenez/pupnp/commit/c493ccbebe5cc648327fc77b572d6dbfe59598e8
The pregenerated file was removed, and as VS doesn't run autoconf or configure, it isn't genrated again.

Half of the problem solved! Just about 1year passed. Hope 2021 will bring windows builds back :D

@mrjimenez, I take it you are not interested in fixing Windows build? Why don't you remove broken Windows configuration and instruction then to make it clear the project no longer supports Windows?

@emptyVoid is it same situation with the latest tarball?
I imagine the intention is to support windows, but I would assume that @mrjimenez like myself runs *nix exclusively.
Really what we need is a friendly windows developer to help fix up the build :+1:

It's the same with master, except that upnpconfig.h isn't mentioned anymore.
As I stumpled over this while porting aMule to cmake, I could offer to do here the same. I could test on linux and win atm.

I've checked 1.12.0 -- headers generated by autotools are missing (autoconfig.h, upnpconfig.h, and config_sample.h). A few compatibility issues with modern Windows SDK and Visual C Standard Library.
I agree CMake-based build system would be great -- one place to define sources for all platforms. Would require some effort to replicate autotools functionality though (like make dist).

Why? make dist is meant to create a tarball including such thing like configure pregenerated, so the user doesn't need to run e.g. autogen.
As cmake replaces that stuff, make dist would just do nothing than creating a tarball similar to the zip you can download here. With cmake you just use that zip, or better git to checkout, then configure, build and maybe install.

I have no idea why it's needed, I've just stumbled upon a concern about it in https://github.com/pupnp/pupnp/issues/159#issuecomment-578134284.

Exactly what I meant. dist should run bootstrap and pack the source.
But in this case here I would use cmake in addition, not as a replacement, so just on windows the outdated and not working vc-projects can get deleted and generated in a working version, on linux it or the old stuff can be used, and on other plattforms the usual ways stay as they are.

In any case, just closing the issue, taking into account windows builds are still not there - awkward from my perspective. Cause of the issue is not solved. So why close?

Hi folks,
I don't mean to offend anyone, so please excuse me if that was the case. I am not against reopening it, and so I will.
The issue was opened in February 2019, and is about 1.8.4. 1.8.x is bugfix only. There has not been a windows programmer in this project for a long time. As far as I remember, windows development files have been removed more than a year ago. These files were a visual studio support contributed by windows programmers interested in making the library compile on this IDE. But windows compilation became broken in many ways due to the lack of support, and the community decided to remove them.
If I recall correctly, autotools could be used in windows using mingw or cygwin, but really, I am not sure about it since I don't do any programming in Windows since 1998. I imagine someone must have already tried that, since it would be the obvious path to me.
If anything, closing it was good because at least now people are discussing the issue, who knows if we can find someone to make a windows build?
Best regards,
Marcelo.

Hi Vollstrecker,
Good to see you here! It's been a while since aMule days.

Exactly what I meant. dist should run bootstrap and pack the source.
But in this case here I would use cmake in addition, not as a replacement, so just on windows the outdated and not working vc-projects can get deleted and generated in a working version, on linux it or the old stuff can be used, and on other plattforms the usual ways stay as they are.

That seems to be a great solution. An alternative build that does not conflict is great. As mentioned in #159 I have nothing against changing the build system. Autotools is a pain, but as pointed by @ukleinek , changing build systems usually just changes the set of problems to resolve. One plus to adding an alternative.
Best regards,
Marcelo.

Not for me, I'm still active there. It's an interesting coincidence that you closed that one just one day after I finished the other stuff. I commited yesterday a bunch of chnages for the amule windows build for wx cryptopp etc and just wanted to start today including upnp.
So I maybe would've send you a pullrequest on tuesday or wednesday without offering the changes first.
And @ukleinek is right, changing always brings some new views. I had yesterday errors in my build that didn't happen before. I'm not sure it's from how I create cryptopp, or that now paths of our code are reached, that just haven't been used before without anyone knew it for the past years. So maybe here some things like that will pop up, too.

https://github.com/Vollstrecker/pupnp
The first part is done, replacing autoheader is a real pita.
*.la for libtool won't be integrated, most of the distributions don't ship them anymore.
For now only the build on linux is tested.
Next step are the test-progs.

NIce job!
We'll be waiting for the pull requests.

Hi everyone,
I tried to use Vollstrecker's work and get everything to compile in Visual Studio 2019. I failed... Anyhow, I used cygwin to compile the last release, version copied the config files, changed a couple of things (like remove IPv6 support) and setup the Visual Studio project files. The resulting commit can be viewed here: https://github.com/Stullemon/pupnp/commit/5deec7c0df90faf59efa0b0c6ec61b4a2f74b51b
I hope this'll help the next person running into this issue on a Windows based project. :-)
Regards,
Stulle

Maybe you could tell me how you failed. You recreated autoconfig.h, I didn't check how this affects other plattforms, but shipping a file that configures the build to the local requirements doesn't look that smart to me.
An yes, there didn't happen that much for some time, that's just because I started this to allow amule to build it's deps while it's own build, and as this only works when upnp  is able to do the same, I'm just at enabling pthreads-w32 for this. This works almost, but the tests are not trivial on each project, and even harder to get them all combined. Plus, I'm no windows guy, so understanding the win-specialies takes some time, and doing it all in a virtualbox takes even more time.

I reckon it was just my impatience and my lack of understanding of CMake. That said, the build apparently fails (partially because recent versions of pupnp have changed the file/dir structure) but the generation of the config files works. So what I will look into is how to just use the configuration file generation excluding any other build steps in order to integrate that into the VS2019 solution files. I will get back here when I made that work out for me.

k, but wouldn't it be easier to find out what is not working with the generated file, so users of other VS-versions or IDEs could benefit, too?

Sure, which is why I want to update the VS Project Files so they provide all means to compile correctly in a VS solution. Truth be told, I am really no expert in these matters and I am mostly just trying to get it to work for another project which I work on. I hope somebody else will be able to pick up the crumbs and revise the cmake project entirely from the point where I'll leave it. In the end I prefer the VS project file build mechanisms, which is why I don't care enough for educating myself in cmake more than I need to.

I'm not talking about educating yourself. I'm talking about telling me what is wrong. Here it didn't fail and anything I know is that file generation works, but you need something else to get it working.
Why don't you just tell me what and why you had to change?

Oh, sorry about that. I thought you were out of time which is why your fork is not merged up to the most recent release version of pupnp. My bad. So, here is what I did:

Clone your fork
Add official pupnp as remote rootRep
git pull rootRep master
Navigate to directory ./build/vc10
Open libupnp.sln with Visual Studio 2019
Retarget projects to VS2019 (SDK and platform tools both to most recent version)
Open folder view in Solution Explorer panel (which automatically executes CMake)

The following output is generated:
1> CMake generation started for default configuration: 'x64-Debug (default)'.
1> Command line: "cmd.exe" /c ""C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO\2019\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Ninja"  -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="D:\C++\pupnp_Vollstrecker\out\install\x64-Debug (default)" -DCMAKE_C_COMPILER:FILEPATH="C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.27.29110/bin/Hostx64/x64/cl.exe" -DCMAKE_CXX_COMPILER:FILEPATH="C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.27.29110/bin/Hostx64/x64/cl.exe"  -DCMAKE_MAKE_PROGRAM="C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO\2019\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\Ninja\ninja.exe" "D:\C++\pupnp_Vollstrecker" 2>&1"
1> Working directory: D:\C++\pupnp_Vollstrecker\out\build\x64-Debug (default)
1> [CMake] -- Setting package-version to 1.14.1
1> [CMake] -- Setting ixml-version to 11.0.0
1> [CMake] -- Setting upnp-version to ..
1> [CMake] -- The C compiler identification is MSVC 19.27.29112.0
1> [CMake] -- The CXX compiler identification is MSVC 19.27.29112.0
1> [CMake] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.27.29110/bin/Hostx64/x64/cl.exe
1> [CMake] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.27.29110/bin/Hostx64/x64/cl.exe - works
1> [CMake] -- Detecting C compiler ABI info
1> [CMake] -- Detecting C compiler ABI info - done
1> [CMake] -- Detecting C compile features
1> [CMake] -- Detecting C compile features - done
1> [CMake] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.27.29110/bin/Hostx64/x64/cl.exe
1> [CMake] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.27.29110/bin/Hostx64/x64/cl.exe - works
1> [CMake] -- Detecting CXX compiler ABI info
1> [CMake] -- Detecting CXX compiler ABI info - done
1> [CMake] -- Detecting CXX compile features
1> [CMake] -- Detecting CXX compile features - done
1> [CMake] -- Check if the system is big endian
1> [CMake] -- Searching 16 bit integer
1> [CMake] -- Looking for sys/types.h
1> [CMake] -- Looking for sys/types.h - found
1> [CMake] -- Looking for stdint.h
1> [CMake] -- Looking for stdint.h - found
1> [CMake] -- Looking for stddef.h
1> [CMake] -- Looking for stddef.h - found
1> [CMake] -- Check size of unsigned short
1> [CMake] -- Check size of unsigned short - done
1> [CMake] -- Searching 16 bit integer - Using unsigned short
1> [CMake] -- Check if the system is big endian - little endian
1> [CMake] -- Looking for sys/socket.h
1> [CMake] -- Looking for sys/socket.h - not found
1> [CMake] -- Looking for ws2tcpip.h
1> [CMake] -- Looking for ws2tcpip.h - found
1> [CMake] -- Check size of socklen_t
1> [CMake] -- Check size of socklen_t - done
1> [CMake] -- Check size of off_t
1> [CMake] -- Check size of off_t - done
1> [CMake] -- Looking for fseeko
1> [CMake] -- Looking for fseeko - not found
1> [CMake] -- Looking for strnlen
1> [CMake] -- Looking for strnlen - found
1> [CMake] -- Looking for strndup
1> [CMake] -- Looking for strndup - not found
1> [CMake] -- Looking for pthread.h
1> [CMake] -- Looking for pthread.h - not found
1> [CMake] -- Found Threads: TRUE
1> [CMake] -- Check size of pthread_rwlock_t
1> [CMake] -- Check size of pthread_rwlock_t - failed
1> [CMake] -- Configuring done
1> [CMake] CMake Error at upnp/CMakeLists.txt:14 (ADD_LIBRARY):
1> [CMake]   Cannot find source file:
1> [CMake]
1> [CMake]     src/api/ActionComplete.c
1> [CMake]
1> [CMake]   Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
1> [CMake]   .hpp .hxx .in .txx
1> [CMake]
1> [CMake]
1> [CMake] CMake Error at upnp/unittest/CMakeLists.txt:1 (ADD_EXECUTABLE):
1> [CMake]   Cannot find source file:
1> [CMake]
1> [CMake]     main.c
1> [CMake]
1> [CMake]   Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
1> [CMake]   .hpp .hxx .in .txx
1> [CMake]
1> [CMake]
1> [CMake] CMake Error at upnp/CMakeLists.txt:191 (ADD_LIBRARY):
1> [CMake]   No SOURCES given to target: upnp_static
1> [CMake]
1> [CMake]
1> [CMake] CMake Error at upnp/CMakeLists.txt:14 (ADD_LIBRARY):
1> [CMake]   No SOURCES given to target: upnp_objects
1> [CMake]
1> [CMake]
1> [CMake] CMake Error at upnp/CMakeLists.txt:122 (ADD_LIBRARY):
1> [CMake]   No SOURCES given to target: upnp_shared
1> [CMake]
1> [CMake]
1> [CMake] CMake Error at upnp/unittest/CMakeLists.txt:1 (ADD_EXECUTABLE):
1> [CMake]   No SOURCES given to target: unittest
1> [CMake]
1> [CMake]
1> [CMake] CMake Generate step failed.  Build files cannot be regenerated correctly.
1> 'cmd.exe' '/c ""C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO\2019\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Ninja"  -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="D:\C++\pupnp_Vollstrecker\out\install\x64-Debug (default)" -DCMAKE_C_COMPILER:FILEPATH="C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.27.29110/bin/Hostx64/x64/cl.exe" -DCMAKE_CXX_COMPILER:FILEPATH="C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.27.29110/bin/Hostx64/x64/cl.exe"  -DCMAKE_MAKE_PROGRAM="C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO\2019\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\Ninja\ninja.exe" "D:\C++\pupnp_Vollstrecker" 2>&1"' execution failed with error: ''cmd.exe' '/c ""C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO\2019\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Ninja"  -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="D:\C++\pupnp_Vollstrecker\out\install\x64-Debug (default)" -DCMAKE_C_COMPILER:FILEPATH="C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.27.29110/bin/Hostx64/x64/cl.exe" -DCMAKE_CXX_COMPILER:FILEPATH="C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.27.29110/bin/Hostx64/x64/cl.exe"  -DCMAKE_MAKE_PROGRAM="C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO\2019\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\Ninja\ninja.exe" "D:\C++\pupnp_Vollstrecker" 2>&1"' returned with exit code: 1'.

Note that Pthreads4Win is not available when building the solution. However, I also do not presume that this is the error that keeps me from getting this to work.
Furthermore (and this is probably due to how I expect this to work for me), it automatically tries to build x64-debug, building/caching everything to a corresponding output dir. Now, when I want to build x64-release or x86-debug I need to manually add configurations in Visual Studio, which would then be stored in a CMakeSettings.json file. Since it is my aim to have it all compile after opening the solution file (or after integrating the project files in another solution file, for the matter) and hitting the build solution button, this is also undesireable.
Please let me know if you need anything else. Any improvement will be much appreciated!

Sorry for the delay, too many parallel stuff going on.
First, it's not unusual for build-systems to fail if source-files are removed, VS, autotools, you name it, so your 3rd step causes the first problems. I'm going to adjust this all, when the process itself works.
Second, I know it is possible (and usually works), but I really not recommend to use the VS-cmake module. The best thing of cmake is, that it's always possible to build outside the source-tree, so you don't pollute your source with anything generated but not needed. VS always stores CMakeSettings.json in the source-dir. I strongly recommend cmake-gui for the configuration.
From my mind I can't remember if pthread is mandatory, but I think so. That's why I interrupted work on this stuff and switched to get pthread buildable with cmake. My final plans are, that if pthread is not foundwhile configuration, it's downloaded into the build-dir and configured there. Then it is built while building upnp, and then it is installed while upnp is installed. That's the original plan from amule, which then downloads upnp, which then keeps track of it's own deps.
Finally the release/debug flavors will be added as a last step. Adding them all together to the project is way less work, than doing the whole work for all flavors in parallel. So I first get everything from the last paragraph done, then the unittests, and then the comfort-functionalities.

Hi Vollstrecker,
Posix threads are required. It seems reasonable to require a previous
installation of a pthread library on config. The Linux autotools files
require it and simply abort the build process if pthreads are not found.
Care must be taken if using MinGW64, because it is an option to install it
with its own thread library, in which case it is not necessary to download
and build. I don't know about other compilers.
There is a git repository in sourceforge for a project called POSIX Threads
for Windows that has been updated about a year ago. I don't know if this is
the best choice. The home page claims that posix code should run
unmodified, so it seems like a good thing. From my past experience with
Windows, I would try to build a DLL and run with it, I would not link it
statically, but this is up to you.
https://sourceforge.net/projects/pthreads4w/
git repo:
$ git clone git://git.code.sf.net/p/pthreads4w/code pthreads4w-code
Regards,
Marcelo.

Yeah, that's actually the one i used for building on Windows... For all i can tell: It appears to be working just fine.

I found that one already, I hoped to find something similar on github, but here the youngest is from 2016. Maybe I'll clone that into a repo here and keep it in sync with the sf one. I need to add cmake-support there, too. Otherwise I would have to configure it outside cmake with the way they provide, including the checks to make sure their buidl-environment is complete.
For sure there is a switch to turn downloading and building of the deps, and even if it is turned on, the checks if the system-provided one is useable are always run, so download happens only when there's no other possibillity.
Same problem would occur on linux, too. As I aim to get one build-system for all plattforms.

Hi again,
On Wed, Nov 18, 2020 at 6:44 PM Vollstrecker<EMAIL_ADDRESS>wrote:

For sure there is a switch to turn downloading and building of the deps,
and even if it is turned on, the checks if the system-provided one is
useable are always run, so download happens only when there's no other
possibillity.
Same problem would occur on linux, too. As I aim to get one build-system
for all plattforms.
In fact, that is a problem only in very old linux distributions. Posix
threads have long been incorporated in glibc, it is unlikely that it does
not pass the configure test in any recent system.

The automatic download feature is really a plus, I think it could even be
postponed in a first release. But again, that's your call.
Best regards,
Marcelo.

I found that one already, I hoped to find something similar on github, but here the youngest is from 2016. Maybe I'll clone that into a repo here and keep it in sync with the sf one. I need to add cmake-support there, too. Otherwise I would have to configure it outside cmake with the way they provide, including the checks to make sure their buidl-environment is complete.
For sure there is a switch to turn downloading and building of the deps, and even if it is turned on, the checks if the system-provided one is useable are always run, so download happens only when there's no other possibillity.
Same problem would occur on linux, too. As I aim to get one build-system for all plattforms.

I actually cloned it to here, already: https://github.com/Stullemon/pthreads4w

threads have long been incorporated in glibc

Jep, that's why it is hard to find them as separate sources. But checking for them (or better for the correct compiler switches) and stopping config seems better to me than getting strange compile errors afterwards.

The automatic download feature is really a plus, I think it could even be
postponed in a first release.

I remember trying to follow the instructions with downloading and compiling this stuff like in the README (iirc). I failed miserably, so doing the cmake for this is needed anyways (at least for me, as I'm still not experienced enough with dev-stuff on win) to get upnp finished. The download part is just 2 more lines when that is done. I think I postpone the unittests (of both) for the first release as it's not trivial to define them in subdirs (which obviously happens with separate downloaded stuff).

I actually cloned it to here

You want to to commit directly there, do you prefer pull-requests?

I made some big steps, the pthreads is done (execpt the unittests), but with upnp installation I have a little problem. Is there any reason to have the DEBUG/NDEBUG defines in the outconfig instead of the cmd-line?

I actually cloned it to here

You want to to commit directly there, do you prefer pull-requests?

We could push it into my repository, if you like. However, I want to clarify that I will not be maintaining the repository actively. So we can do it whichever way you think is best.
Also, great to know you are making progress. I cannot say anything useful about your question, though. Sorry about that.

I made some big steps, the pthreads is done (execpt the unittests), but with upnp installation I have a little problem. Is there any reason to have the DEBUG/NDEBUG defines in the outconfig instead of the cmd-line?
I mean, if they would be on cmd-line I wouldn't have to create two autoconfig.h and two sample_config.h, and projects including that stuff usually have them on cmdline for their own stuff anyways.

I am sorry, I did not understand your question. What is outconfig? Do you mean configure.ac? Which cmd-line are you referring to?
autoconfig.h is automatically generated by configure. I also don't know about sample_config.h.
Regards,
Marcelo.

I meant that in autoconfig.h (and I think sample_config.h, too) DEBUG or NDEBUG ist defined, so there is only the choice to build either with or without debug support, or to install the header into separate dirs. The second option isn't supported by the cmake export for the targets.
I just decided to remove them from the config and tell the source by compiler-define what it's supposed to do. So on cmake-build you will get upnp.dll and upnpd.dll for both versions (and upnps.dll and upnpsd.dll for the static ones). And the exported files let's any dependant project know about every of them.
I first thought about changing the names back to the normal ones on linux but then decided, if the distributions ship the lib built by cmake, the projects that use it, can either use the release-version as found the usual way, or switch to cmake, too.


Handle upstream configuration CC value metadata changes

See zwave-js/node-zwave-js#2193 for more context. This PR will need to be merged and released alongside the release of that PR so that things don't break in zwavejs2mqtt. We will also need to update zwave-js and zwave-js-server at the same time in the addon

@balloob I added some logic to check types for min and max to get around some typing errors, just wanted a second pair of eyes on it in case there was a better way to do this. The issue is that because the ValueMetadata type includes the ConfigurationValue type, typescript assumes that min and max can be of type ConfigValue which is only for the Configuration CC and is a superset of the types that are supported in other CCs

The only way I've found to make this work better is to explicitly Union all of the metadata types. I know we had talked about being more explicit about typing, do we want to do that here too? There's an increased maintenance cost with that approach

The only way I've found to make this work better is to explicitly Union all of the metadata types. I know we had talked about being more explicit about typing, do we want to do that here too? There's an increased maintenance cost with that approach

Decided to be explicit about types.

Going to go ahead and merge this to unblock the other PRs and because I think this is as clean as I can make it. I can adjust if needed


[Android][ListView] Wrapping items take up the height of the whole container

It seems like after the update (0.29 or 0.30, not 100% sure which one, but it worked on 0.28) items in a ListView that wrap, take up the height of the whole container. The more items are wrapping, the longer is their height, so I assume it's taking up the container height. There is nothing special in styling or structure there. Just a ListView with item template passed in.
Container styling to make items wrap. If they don't wrap, the height is fine.
<ListView 	contentContainerStyle={{ 		flexDirection: 'row', 		flexWrap: 'wrap' 	}} 	renderRow={ (item) => (<ItemTemplate item={item} />) } />
If flexWrap is set to 'wrap' and there are not enough items to wrap (all fit on one line), the height of the items is fine.
When items wrap:

When items don't wrap:

The only fix for this right now is to set a fixed height to the item. Not ideal, but it works for now. Is anyone having this issue? Maybe you have found a better fix?
React Native: 0.30.0
OS: Mac

What happens if you change contentContainerStyleto:
{ flexDirection: 'row', flexWrap: 'wrap', alignItems: 'flex-start' }

This may be related to https://github.com/facebook/react-native/issues/8960.
I wonder if any of these issues are the result of recent changes to css-layout (for example, https://github.com/facebook/css-layout/pull/185).

@ryankask: thanks for the quick response. Unfortunately, adding alignItems: 'flex-start' didn't help.
Not sure if it matters, but I have set width for item. When I removed it, it didn't help, though.

@quietbits Interesting. I can reproduce the issue but alignItems fixes it. Could you post the row container's style?

@ryankask, sure. I'm posting the whole item with styles. Maybe there is something off with item element styles.
<TouchableOpacity
	style={{ width: 125, elevation: 3, margin: 5, padding: 5 }}
>
	<View style={{ alignSelf: 'center', marginBottom: 5 }}>
		<FadeInImage
			source={{ IMAGE_URL }}
			style={{ height: 125, width: 125 }}
		/>
	</View>
	<View style={{ flex: 1, alignSelf: 'flex-start', marginBottom: 5 }}>
		<Text
			numberOfLines={2}
			style={{ textAlign: 'center' }}>
			[TEXT 1]
		</Text>
	</View>
	<View>
		<Text style={{ textAlign: 'center' }}>[TEXT 2]</Text>
	</View>
</TouchableOpacity>

The idea is to have item elements always aligned this way:

image to the top (it is fixed height)
text 1 right after the image
text 2 always at the bottom

Here is illustration of it.

@facebook-github-bot label Icebox

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/androidlistview-wrapping-items-take-up-the-height-of-the-whole-container
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.

@facebook-github-bot close


build: Add verbosity levels

It is controlled with a V variable. V=1 is the default. To use, call make -j4 V=x where x is 0, 1, 2 or 3. English words can be used as well, silent or quiet for level 0, info for level 1, all for level 2 and raw for level 3.
Fixes #1535.

Maybe some documentation on how to enable a more verbose (or raw) building on hacking.md?

After that, LGTM

Added some docs.

Docs LGTM


UI: Fix bugs in the create organization form

🐛 Summary
Fix bugs in the Create new organization form
To reproduce

Go to the top menu dropdown and select "Manage Organizations".
Select the "Create New Organization" button from the table.
The form has a field called "Tags" which should allow you to add multiple tags. It is currently not functional.
If you click submit, it does not have form validation or confirmation and will go through.

Expected behavior
In the create new organization form, you should be able to add new tags and not be able to click submit until passing validation.

Switching over to a different prioritized task- open for reassignment.


Add expires_on field to OMIS Quote

This adds a new field expires_on to an OMIS quote.
The value is auto-generated from the delivery date when creating a quote and an error is raised if the delivery date is too close and the resulting expiry date would be in the past.

Codecov Report

Merging #450 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #450      +/-   ##
===========================================
+ Coverage    96.12%   96.14%   +0.01%
===========================================
  Files          102      103       +1
  Lines         3200     3213      +13
  Branches       280      281       +1
===========================================
+ Hits          3076     3089      +13
  Misses          85       85
  Partials        39       39

Impacted Files
Coverage Δ

datahub/omis/quote/utils.py
100% <100%> (ø)
:arrow_up:

datahub/omis/quote/constants.py
100% <100%> (ø)

datahub/omis/quote/serializers.py
100% <100%> (ø)
:arrow_up:

datahub/omis/quote/manager.py
100% <100%> (ø)
:arrow_up:

datahub/event/constants.py
100% <0%> (ø)
:arrow_up:

datahub/event/serializers.py
100% <0%> (ø)
:arrow_up:

datahub/event/urls.py
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc42d1...8b33234. Read the comment docs.


Add documentation/example for how to support new boards

I'm looking at extending this repo's support to a Intel Atom E3800 based SBC. I imagine the steps are something like creating a new directory board/kubos/<new_board> and adding my kernel's config. Having a step by step for how to generate the kernel config files and any other prerequisites might be useful.

Hey @cevans01! We are currently working through our documentation and we are planning on working on a porting guide. We do have a community slack where you can talk to our engineers about your porting efforts, I can send you an invite if you'd like.

That would be great, thanks
On Thu, Apr 27, 2017 at 1:34 PM, Ryan Plauche<EMAIL_ADDRESS>wrote:

Hey @cevans01 https://github.com/cevans01! We are currently working
through our documentation and we are planning on working on a porting
guide. We do have a community slack where you can talk to our engineers
about your porting efforts, I can send you an invite if you'd like.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubostech/kubos-linux-build/issues/29#issuecomment-297785420,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA9Edvy3G4Ed6ubFodic1KVS0XTdKVq8ks5r0NG2gaJpZM4NKcRD
.

Ok great! We'll send one over. We like to hang out in the kubos channel.


Respect PKGEXT

repro check -l mypkg.pkg.tar generates build/mypkg.pkg.tar.xz, and of course hashes are different.
Probably low prio since all official packages use .pkg.tar.xz extension, but anyway.

Actually this is solved by just providing a custom makepkg.conf via -M.


Obtaining the maven coordinates of dependencies managed via bazel-deps from an aspect

Good day,
First, let me apologise in advance if this question ends up being more Bazel specific rather than bazel-deps specific: I've only recently started learning it, and while I feel like this is something related to bazel-deps I may be wrong. Please close the issue if this is so.
Secondly, thank you for sharing this tool with the community: I'm happy to say it is helping us in a meaningful way.
The Question
Using an aspect I'm trying to obtain the maven coordinates of dependencies that are imported/managed with bazel-deps. This seems to work well for java dependencies (although I'm not sure to understand why), but fails for scala.
Looking at the bazel-<project>/external/@<dep>/jar/BUILD file, I can see that indeed, the tags attribute is set to what I need (here, as an example, let's use json4s-core):

package(default_visibility = ['//visibility:public'])
java_import(
    name = 'jar',
    tags = ['maven_coordinates=org.json4s:json4s-core_2.12:3.6.7'],
    jars = ['org_json4s_json4s_core_2_12.jar'],
    srcjar = ":org_json4s_json4s_core_2_12-sources.jar",
)
filegroup(
    name = 'file',
    srcs = [
        'org_json4s_json4s_core_2_12.jar',
        'org_json4s_json4s_core_2_12-sources.jar'
    ],
    visibility = ['//visibility:public']
)

The problem, as I perceive it, is that the BUILD files generated from our dependencies.yml file references the filegroup above, not the java_import rule, preventing me from accessing the tags attribute in java_import.
Funnily, this does not concern java dependencies, where the relevant tags are correctly being collected.
Could it be because for scala, in the generated BUILD file, we rely on scala_import, but for java we rely on java_library? If so, is there a work-around?
Attempts at a solution
Having grepped around in the bazel-deps sources, I noticed that https://github.com/johnynek/bazel-deps/blob/48fdf7f8bcf3aadfa07f9f7e6f0c9f4247cb0f58/src/scala/com/github/johnynek/bazel_deps/templates/external_workspace_backend.bzl contains a template for issuing scala_library rules if the kind of the dependency is library, though I've found no way to mark a dependency as a "library" rather than an import.
The final word
Anyway, I'm not sure I grasp every layer in the process of dependencies.yml -> workspace + BUILD file generation -> import of external repositories -> usage of external repositories, but that's another story entirely: things work fine for building, that's a start :)
Many thanks again for your work.
Kindly

So, after looking at this with a fresh pair of eyes, it looks like my ignorance is to blame, not bazel deps :)
Long story short:

I got confused by the binding that happens between @<dep> and //external (which also binds
resolving the correct target (ie, the jar instead of the filegroup) gets me a step closer to what I want. I'm not there yet, but that's a limit of my Bazel knowledge.

Happy coding!

So, to clarify (just in case I need to open another issue for a – likely – upcoming question):
the BUILD files generated by bazel-deps in the WORKSPACE where we use the dependencies correctly contain a scala_import, as the doc specifies.
That scala_import itself references the //external:jar/... that points to the filegroup in the example above. The BUILD file in the sample is the one generated by the macro in workspace.bzl.
Thanks for the reply!


Ensure random team generation always ends up with 6 Pokemon

Shoehorning monotype generation into normal team generation results in several issues, especially for mono-ice where there are only 28 possible Pokemon in the pokemonPool to begin with:

Rotom-F, Ninetales-A and Sandslash-A are all going to be unfairly downsampled even though their alternate formes are not legal options on mono ice (Kyurem downsampling should be OK, because all are ice)
We limit to 2 Pokemon per tier even though most Ice types are likely to be clustered in the lower tiers (or just Untiered) because theyre kind of trash
We limit the number of type combinations even though a large fraction of Ice types are actually just pure Ice. We increase the 'allowable number of type combos' from 1 to 2 for monotype, but this is probably still too low for Ice.
We only consider a single set for a Pokemon and dispose of the entire Pokemon if the set doesn't fit instead of rerolling the set

I'm merely documenting these issues here, but instead going with the simplest possible fix for having < 6 members on the team which is to just throw in another loop (with an EXHAUSTION constant to prevent infinite iteration). I'm also utilizing our fulltest tagging better - even with 1000 iterations it still only takes 3s on my notebook which is still substantially less than some of our slow tests which take 1 minute on our machine. I've also preseeded to make the first team generated one with only 5 mons before this change.

In theory, you should just need two loops, with the second one relaxing the "2 pokemon per tier" and type combo restrictions. Unless the randbat algorithm has massively changed since I originally wrote it, nothing else should be necessary.

I'm having trouble understanding how the "2 pokemon per tier" and "2 allowed type comboes" can fix themselves with multiple passes, though?

I mean the simplest fix is removing the tier restriction for Monotype. Monotype doesn’t really follow standard tiers anyway; something in RU could be OU in Monotype.

I'm merely documenting these issues here...

Was meant to be a hint that this was just a strawman proposal, I'm glad its garnered discussion.

I'm having trouble understanding how the "2 pokemon per tier" and "2 allowed type comboes" can fix themselves with multiple passes, though?

The multiple loops works around the 'species downsampling' and 'only evaluating on set' issues. I didn't solve 2 pokemon per tier or 2 allowed type combos, though actually one easy way to do so would just be to use the outer loop counter as a multiplier on the number per tier or per type combo.

In theory, you should just need two loops, with the second one relaxing the "2 pokemon per tier" and type combo restrictions.

EXHAUSTION = 2 plus the multiplier I discussed above then. I think you'll still want more loops though, I don't see why we should be removing species entirely just because we got unlucky with randomSet.

I mean the simplest fix is removing the tier restriction for Monotype.

Completely?

I don't even know in what sense a set "wouldn't qualify". Clearly the randbat code has changed drastically since I originally wrote it.
Why do we have a tier limit, anyway? Clearly that just means the level offsets need to be rebalanced?

Why do we have a tier limit, anyway?

For more balanced teams.  Literally everyone would agree Random Battle became significantly better after the tier limit was added.

Completely?

Not necessarily. I'll make it max 3 or something I guess for Monotype.

9f8e20 unforunately does not cause my test case to pass, nor does increasing the type combo limit from 2 -> 3 in the same way that tier was increased.
I've updated this PR to gradually relax these two limits as the outer loop progresses.

Oh yeah, worth noting that I'm still very open to alternative solutions, I just think that they should pass the test introduced by this PR. :)

For more balanced teams.  Literally everyone would agree Random Battle became significantly better after the tier limit was added.

Maybe we should limit untiered mons specifically? For everything else, level balance should be enough.

Friendly ping - @TheImmortal / @Zarel, how do you feel about the specific solution introduced in this PR which has an outer loop that gradually relaxed restrictions per iteration and actually solves the immediate 5-Pokemon monoice issue?

Yes, I can merge as-is and we can improve it later.