Add a typed ProjectionExpression constructor

This PR adds an extra ProjectionExpression constructor with a type parameter.
Let me know what you think about it! I know that it's a low-level API and we probably can't encourage users using it, but it can be really useful sometimes to hide some dirt under the table.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

BTW I noticed that https://github.com/zio/zio-dynamodb/tree/series/2.x/.idea is commited into the repo! Is it intended? (it def conflicts with my local settings and locally idea overwrites it)

So re $$ proposal - I think I would prefer the existing clean separation of High level and low level APIs - for instance in the High level API the use of .unsafeTo is actually "safe" in the scope of a ZIO Schema derived from the trait/case class - but is literally unsafe here for $$ as the field name and type are associated my hand

closing for reason mentioned in comment

Re-opened as I can see this will be useful for defining ProjectExpressions for enums that are non root


bug(a11y): sbb-form-field has an invisible focus step A4A#39

Preflight Checklist

[X] I have read the Contributing Guidelines for this project.
[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Bug type
Accessibility
It affects the following packages
Components
Which version of Lyne Components are you using
No response
Operating system
No response
Browser / Browser version
No response
Input mode
None
Additional settings
No response
What happened?
It seems like that you can focus something invisible inside the component in android talkback
Steps to reproduce the issue

try to focus some Element on the page
navigate to an input element inside a formfield
you will have an empty/invisible focus step

Relevant log output
No response

From an initial analysis, we were unable to identify the cause of the bug. We will run further tests with the "debug node tree" feature enabled and update the issue if anything relevant emerges.

Update: after a thorough analysis of the component, several attempts were made to achieve the goal of either removing the invisible step or making the step visible. Such attempts included:

A partial refactoring of the component's structure
A combination of aria attributes and/or roles
The use of display: contents; on some of the elements that might currently be visible to the screen reader
A more explicit management of tab indexes inside the component
Any reasonable combination of the above
Other possible solutions that have been considered include: the use of focusin and focusout listeners to manually direct the focus to the wanted element and overriding the shadowRoot.delegatesFocus property.
Unfortunately, none of these approaches achieved the desired effect without compromising the component's UX on other platforms.


API refactor

A simple refactor to separate "RESTful" JSON API from templated HTML views.

Rebased

wait for me to rebase and force push here, sorry. review shouldnt change much tho

rebased, should be good to review @wisygig


Update Development_Process.md

The SOLID principles are very important for creating clean code. The Wiki's entry had examples to demonstrate the SOLID principles, but they were hard to visualize. I added diagrams for the examples of all five SOLID principles. I also slightly modified one of the examples (SRP) to add clarity and consistency with the diagram.

Addressed comments by langsonzhang by adding appropriate arrows for additional clarity


Sponsored issue: Mark down editor issue

Links with underscores are not working
Priority Support

@tytac116 is using  Mintycode to fund this issue.
If you would like to accept  bounty for solving this issue join Mintycode.
Thank you in advance for helping.

Needs more details. The following is working just fine.
* [example_link 1](https://example.org/this_n_that_)
* [_example link_ 2]

[_example link_ 2]: http://example.org/example_2


feat(): display ens avatar if set by the user

Fixes #680

This is blocked until we figure out a way to request ENS avatar text records in one request.

@midgerate when I go to https://bafybeifsrc7h2h23ixzjjgxhahm62wqp45nbn4zvh4syqysq7fipvruy5e.on.fleek.co/#/sushigov.eth
I see a bunch of requests being fired for ENS avatar but I don't see any ENS addresses on that page. We should only check ENS names for avatars.

@samuveth can you explain this a little more? I check for ensname before I try to fetch the avatar.

Who is using ENS avatar isnt something very new? It seem like we will be sending lot of requests but wont get much avatar. I'd rather show CryptoPunk instead of ENS avatar at this point. Not sure why this was prioritized.

Who is using ENS avatar isnt something very new? It seem like we will be sending lot of requests but wont get much avatar. I'd rather show CryptoPunk instead of ENS avatar at this point. Not sure why this was prioritized.

@bonustrack Yes agreed, too many requests for something that doesn't really seem to be used yet.

@midgerate we could still make the changes to useProfiles with updateAddressArray in another PR.


Possible false positive "Call to a virtual function in a destructor"

https://lgtm.com/projects/g/godotengine/godot/snapshot/cdd8d432ebe5b6cb55eeeaa1ff7de926f76bd8f7/files/modules/bullet/collision_object_bullet.cpp#L234
It says it's calling a virtual function reload_shapes() in remove_all_shapes() which is called from the destructor. The issue is that remove_all_shapes is called with a flag that make sures virtual function is not called when calling from the destructor. Does this count as a false positive?

I agree that's a false positive: the virtual function cannot actually be called from the destructor. I'm less sure whether we should enhance the analysis with sensitivity to Boolean flags in order to suppress this alert. I'm not seeing this pattern in the other results from this query.
Do you think it's an idiomatic pattern to suppress part of the function's behaviour by passing a Boolean flag? An alternative would be to have two different functions with helpful names -- one that doesn't call reload_shapes and one that calls the first function followed by reload_shapes.
A less satisfying solution is to suppress the alert by adding a suppression comment on its line. See https://lgtm.com/help/lgtm/alert-suppression.

@Anutrix just following up on this problem reported - have you worked around this issue by using an alert suppression or have you created two different functions? Does the workaround meet your expectations? Cheers

My bad. I forgot about it. The project is open-source and the maintainer hasn't connected the project directly to lgtm on github(yet?). Since, I am not a maintainer I can't just add an alert suppression comment unless there's more concrete reason to do so. Regarding the naming and splitting, it's still being discussed.

@Anutrix ah no worries! Take your time to look into it and see what would work best for you. Any questions on this very issue - please do post here. If you find any other issue - feel free to start a new issue or if you have a more open question you'd like to discuss, we also have a forum https://discuss.lgtm.com/ where you can post your questions and concerns. Cheers.


Enhance slack notifications integration

Description
Adds logic to ping specific slack groups for specific dag failures, ignore any index task failures and ignore task failures from any playgrounds(will notify for failures only on the main airflow-ci)

Codecov Report

Merging #123 (49fba01) into master (cc55fb2) will decrease coverage by 1.39%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   95.97%   94.58%   -1.40%
==========================================
  Files          21       21
  Lines         796      813      +17
==========================================
+ Hits          764      769       +5
- Misses         32       44      +12

Flag
Coverage Δ

gha
94.58% <33.33%> (-1.40%)
:arrow_down:

python-3.9
94.58% <33.33%> (-1.40%)
:arrow_down:

unit
94.58% <33.33%> (-1.40%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

dags/openshift_nightlies/util/slack_integration.py
36.00% <29.41%> (-14.00%)
:arrow_down:

dags/openshift_nightlies/util/var_loader.py
95.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc55fb2...49fba01. Read the comment docs.


[url_launcher] Fixes call to setState after dispose.

@kristoffer-zliide found a very subtle issue with the current Link implementation: it may call onPlatformViewCreated after it's been disposed by the framework.
The problem is a race condition between the time a Link controller initializes and it notifies the framework that it's completely created, because the PlatformViewLink widget that is being used as a base for the Platform View of the widget doesn't allow for async Platform View Creation callbacks.
The web initialization, however, needs an async callback, because of the way that Platform Views are created there. Since the creation callback cannot be async, the current factory method creates the Link widget controller and calls its init as an "unawaited" future (pretty much).
The current implementation has a subtle bug where the controller initialization and disposal can be triggered out of order, because of a race condition with the framework. In this case:

An app adds a large amount of Link widgets to the a page, in a scrollable list.
The user flings the view.
The framework starts disposing and creating big batches of new widgets to repaint the page.
Because of the unawaited async initialization, some of the batches of widgets may get disposed in the time it takes the framework to await invokeMethod<void>('create', args).
This causes that when the code attempts to notify the framework that the view has been created (onPlatformViewCreated(viewId)), the view has already been disposed (because the page continued scrolling), and the code fails as described in the issue.

This PR:

checks that any given widget controller hasn't been disposed before calling onPlatformViewCreated.
removes a BuildContext context parameter that is no longer needed.

This is a simplified version of Kristoffer's PR: https://github.com/flutter/plugins/pull/5431. I cherry-picked the commit where Kristoffer added the unit test for this PR.
Issues

Fixes https://github.com/flutter/flutter/issues/102741
Closes https://github.com/flutter/plugins/pull/5431

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

(Removing the tag so a google_maps PR lands first)

Granted, this PR is simpler than #5431 in the sense that it changes fewer lines of code, but at the price of this code
controller._initialize().then((_) {
    if (_instances[viewId] == controller) {
        params.onPlatformViewCreated(viewId);
    }
});

which requires four lines of comments, compared to
await SystemChannels...;
if (_isDisposed) {
  return;
}
params.onPlatformViewCreated(viewId);

which is self-explanatory to any (Flutter) developer (check if you're still alive after an await, back out if not). It also leaves in a .then() and a dangling future. But, either way, both PRs fix the issue. 🚀

@kristoffer-zliide thanks again!


updated the priority of outputting full content

Thanks for opening this back then Sam 🙏 Gonna close this out now v3 has diff editing


[Documentation] Compilation issues on RTD

On Read the docs, autodoc does not work correctly with cython modules .
The solution is to produce the *.rst files of the API locally, and push these files to GitHub. This can be done by capturing the following sphinx events: autodoc-process-signature, autodoc-process-docstring.
However, these events are raised before the docstrings are parsed by the napoleon extension. The first step is therefore to get rid of napoleon and the Google style for docstring. I prefer a more verbose doc style anyway (like the Python standard library).

Issue closed as the docs are moved to GitHub Pages.


Typo

There is a possible typo here.

I am not sure what you mean. You can always open a pull request to fix what you think is wrong.

I think OP means that the wording of the description is unclear.
currently, it's this:
Stops path finding when its save to stop or after the bot encountered an error while path finding. To force stop use bot.pathfinder.setGoal(null). Emits path_stop when stopped.
that's difficult to read, and it's not clear what 'safe to stop' means.
perhaps something like this would be better:
Stops pathfinding as soon as the bot has reached a safe location (i.e. standing on solid ground?). Emits path_stop when called.
Note: to force stop immediately, use bot.pathfinder.setGoal(null)
also, what does "or after the bot encountered an error while path finding" mean? the path_stop event may be emitted then, but don't all errors stop the bot anyway?

Yeah when there is an error it will always stop. It will probably emit the event that corresponds with the error the bot encountered and not the path_stop event. The stop function is designed to stop the bot when it reached the next path node in the current path. So basically it will avoid stopping mid air. This is especially useful as currently when the bot stops path finding it cancels all velocity and could drop like a rock mid jump when not using pathfinder.stop().

okay. In that case, I don't think it's necessary to include the error part; I don't see how it's relevant to bot.pathfinder.stop(). perhaps we can just rephrase that section of the docs to something like:
Stops pathfinding as soon as the bot has reached the next node in the path (this prevents the bot from stopping mid-air). Emits path_stop when called.
Note: to force stop immediately, use bot.pathfinder.setGoal(null)

What I meant is that it is written as "... its save to stop ..." instead of "... its *safe to stop ..." but I guess that also works.

@Jovan-04 do you have time to make a pr? If not I can make one at some point.

Or someone else is also free to make a pr to fix it

What I meant is that it is written as "... its save to stop ..." instead of "... its safe to stop ..." but I guess that also works.
yeah, I figured. but if I'm fixing a typo, I may as well make the docs more clear too
**it looks like the typo you mentioned was on a different branch, that doesn't look like it's being used or updated. @IceTank do you know what's happening with that branch?

@Jovan-04 do you have time to make a pr? If not I can make one at some point.

redid the wording for master branch in #327


chore: testing out the pipe stuff to show ttd

Just wanted to try this cause I haven't really gotten to use pipes at all - still really rough (and slower) but it's a kinda fun demo of the api

Just wanted to try this cause I haven't really gotten to use pipes at all - still really rough (and slower) but it's a kinda fun demo of the api

RE comparing pipes to my buffer impl:
I realize now that I could have made my impl async too so I should do that for more like-for-like comparison. I also noticed this does use the InitialBufferSize or do any explicit buffer growing. Will the Pipe handle that? What happens if you have have a single token that’s larger than the buffer?


Refactor defaults

This is a follow up to https://github.com/request/request/pull/1518
Much more simplified defaults and params initialization in index.js. Basically flattened the logic, also moved the wrap closure outside of the defaults method and I left it in index.js because I think it's very closely related to the request method, and the convenience http verb methods. Also completely dropped all of the object extend closures, as I don't think they add any substantial value to that piece of code.
/cc @nylen @FredKSchott @mikeal

:+1: with comments

I managed to squeeze the code a bit further by removing redundant data structure returned by initParams
Regarding your comment @FredKSchott about passing a string to the wrapRequestMehod function, I can't figure out a good way to remove the string parameter from there without introducing complexity in another place.
The reason for passing string there is to be able to set the params.method which is later used in the request function to abort the request on HEAD + body.
Similar to the way the http verb methods set the method name after calling initParams, the wrapRequestMethod is doing exactly the same, again after the initParams was called.
Here is the catch - on wrapped http verb method + requester, the default http verb method is never called, because the requester takes precedence. Therefore the request method is never set, so the request can't be aborted in the request function (and we have a test for that too).


Added Feedback Hub integration helper

I thought this would make a nice addition to Template 10. The new Monetization SDK adds support for the new feedback for developers system, which is absolutely wicked. So, since Template 10's job is to make the developer's life easier, I thought adding a helper utility for the Feedback Hub integration would be awesome. Not many additions, but here's the major stuff:

Added the Store Engagement SDK to the library
Added a Feedback utility to the Nuget library, which handles the integration.

Is there a lot of benefit to offering this helper? While the store engagement SDK doesn't really have a lot of downside to including, I am not sure the helper does a lot for users either.

Don't mean to discourage but there are straightforward approaches to this, see for instance a sample here, rather than bloat T10 with utilities that devs choose to include.

This is a nice addition that will benefit only a few developers. For the rest, this seems unnecessary, and should I be wrong, adding it to an app is pretty easy-peasy. I vote, no. This time.


Split amathutils_lib from #1609

New Feature
This issue picks up the changes of amathutils_lib from #1609.
Fundamental diff to develop

delete class point
change the args of find_distance and find_angle from point to const geometry_msgs::Point &.

Difficult to split


Installed HACS but custom repositories AlexxIT/SonoffLAN doesn't show

Unfortunately the AlexxIT/SonoffLAN is not present in de HACS integration section.
Is there any other way to install this ?
arch | x86_64
chassis | vm
dev | false
docker | true
docker_version | 19.03.11
hassio | true
host_os | HassOS 4.15
installation_type | Home Assistant OS
os_name | Linux
os_version | 5.4.72
python_version | 3.8.5
supervisor | 2020.10.0
timezone | Europe/Brussels
version | 0.116.4
virtualenv | false
HACS v 1.6.0 (709 repositories)

You have to add a custom repository by the name AlexxIT/SonoffLAN as shown here: https://github.com/AlexxIT/SonoffLAN#install-with-hacs

The gif differs from my setup;

Hacs updated today v1.6.1

I found it.... I had to select the three dots in the upper right corner, choose 'Custom Repositaries'and then add the AlexxIT/SonoffLAN repositary! Thanks!


Support for non-amd64 architectures.

Currently the operator does not support architectures besides amd64. This is a request to add builds and docker images which support other architectures. (Arm, Arm64, s390x etc.)

@HindrikStegenga Would like to run spark on AWS A1?

No, I wanted to run it on a Pi. I don't need to do that anymore though.


Bump zxcvbn-php version

This change is

Great – thanks! Released a new version on packagist (2.1) also which includes this update: https://packagist.org/packages/olssonm/l5-zxcvbn#v2.1
Just out of curiosity – are you using this package in a project? Just fun to know =)

thanks!
yes we do use it at https://hugo.events/ for website and backoffice
for website we've decided to lower threshold to 0 for now as it was too hard for people to come up with initial passwords :)

Cool, I see – thanks for sharing! =) Always fun to how people use different packages. Nifty service you got there too.

thanks for this work!
On Wed, Jan 25, 2017 at 1:03 PM Marcus Olsson<EMAIL_ADDRESS>wrote:

Cool, I see – thanks for sharing! =) Always fun to how people use
different packages. Nifty service you got there too.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/olssonm/l5-zxcvbn/pull/3#issuecomment-275091287, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAaEgAdKbmSAKK_1-csFrFtjNy50FjXJks5rVzorgaJpZM4LrFg2
.


Question : Regarding orion.meteor.com/docs

Did you use the pages extension to build orion.meteor.com/docs ?

No, the site fetchs the readme from github and shows them

oh ok, if i wanted to use something similar with the pages would that be possible. I guess the question I'm asking is is it possible to build pages or a docs section using the pages extension or is that out of the scope for pages.

It's totally in the scope. Any doubt you can ask


transfer value notification difference in applicationlog response

The applicationlog response for neo-go has a differences in the transfer value for T5 block  2486 (basically the first block in which a transfer happens on T5)
blockhash: 0xe0f8d56fb07b79be5d572ccf0ad7b643e7cbc24d48dede875fd7e041e5debb7f
neo-cli
"contract": "0xd2a4cff31913016155e38e474a2c06d08be276cf",
                            "eventname": "Transfer",
                            "state": {
                                "type": "Array",
                                "value": [
                                    {
                                        "type": "ByteString",
                                        "value": "av+ilhHxk5cTywAyS9cScHaQyeU="
                                    },
                                    {
                                        "type": "Any"
                                    },
                                    {
                                        "type": "Integer",
                                        "value": "18705520"   <- OK
                                    }
                                ]
                            }

neo-go
                    "contract": "0xd2a4cff31913016155e38e474a2c06d08be276cf",
                            "eventname": "Transfer",
                            "state": {
                                "type": "Array",
                                "value": [
                                    {
                                        "type": "ByteString",
                                        "value": "av+ilhHxk5cTywAyS9cScHaQyeU="
                                    },
                                    {
                                        "type": "Any"
                                    },
                                    {
                                        "type": "Integer",
                                        "value": "18705519" <- not OK
                                    }
                                ]
                            }

Wow. That's a surprise. The balance value is decreased correctly, otherwise we'd have state issues:
$ ./bin/neo-go contract testinvokefunction -r https://rpc.t5.n3.nspcc.ru:20331 --historic  2485 0xd2a4cff31913016155e38e474a2c06d08be276cf balanceOf e5c990767012d74b3200cb139793f11196a2ff6a
{
  "state": "HALT",
  "gasconsumed": "2028330",
  "script": "DBRq/6KWEfGTlxPLADJL1xJwdpDJ5RHAHwwJYmFsYW5jZU9mDBTPduKL0AYsSkeO41VhARMZ88+k0kFifVtS",
  "stack": [
    {
      "type": "Integer",
      "value": "5950000000"
    }
  ],
  "exception": null,
  "notifications": []
}
$ ./bin/neo-go contract testinvokefunction -r https://rpc.t5.n3.nspcc.ru:20331 --historic 2486 0xd2a4cff31913016155e38e474a2c06d08be276cf balanceOf e5c990767012d74b3200cb139793f11196a2ff6a
{
  "state": "HALT",
  "gasconsumed": "2028330",
  "script": "DBRq/6KWEfGTlxPLADJL1xJwdpDJ5RHAHwwJYmFsYW5jZU9mDBTPduKL0AYsSkeO41VhARMZ88+k0kFifVtS",
  "stack": [
    {
      "type": "Integer",
      "value": "5931294480"
    }
  ],
  "exception": null,
  "notifications": []
}

But something happened to the transfer event...

And it seems like this happens with every block, specifically for this burning events.

The balance value is decreased correctly, otherwise we'd have state issues:
yeah I expected this to be some representation error, not state. but don't know the code enough to start debugging this

It's correct in the transfer log as well:
$ curl -sd '{ "jsonrpc": "2.0", "id": 1, "method": "getnep17transfers", "params": ["e5c990767012d74b3200cb139793f11196a2ff6a",<PHONE_NUMBER>830,<PHONE_NUMBER>840] }' https://rpc.t5.n3.nspcc.ru:20331 | json_pp
{
   "result" : {
      "sent" : [
         {
            "transfernotifyindex" : 0,
            "blockindex" : 2486,
            "assethash" : "0xd2a4cff31913016155e38e474a2c06d08be276cf",
            "txhash" : "0xe0f8d56fb07b79be5d572ccf0ad7b643e7cbc24d48dede875fd7e041e5debb7f",
            "amount" : "18705520",
            "timestamp" :<PHONE_NUMBER>838
         }
      ],
      "received" : [],
      "address" : "NVfj3vnyBCUb2E2eSFacY3N4Q1UU9ed3FG"
   },
   "jsonrpc" : "2.0",
   "id" : 1
}

Unfortunately the DB is affected in this case, not the contract state, but application logs that are saved there.


Uncaught TypeError: Livewire.components is undefined

protected $listeners = [
        'sweetalertConfirmed',
        'sweetalertDenied',
];
public function logout()
{
        sweetalert()
            ->timer(0)
            ->showDenyButton()
            ->addInfo('confirm or deny action');
}

public function sweetalertConfirmed(array $payload)
{
        auth()->logout();
        sweetalert()->addSuccess('sweetalert was confirmed');
}

public function sweetalertDenied(array $payload)
{
        sweetalert()->addError('sweetalert was denied');
}

i have code for laravel 10 and livewire 3 and get Uncaught TypeError: Livewire.components is undefined
when i click button logout, here my button logout:

    Logout

how can fix this code

Hi @andhikapepe,
I’m currently working on reducing the number of open issues to keep the project organized.
If you’re still experiencing this problem, please update to the latest version of PHPFlasher. If the issue persists, feel free to reopen this issue or open a new one.


IFramePanel type={PanelType.medium} does not work

Category
[ ] Enhancement
[x] Bug
[ ] Question
Version
1.16.0
Expected / Desired Behavior / Question
<IFramePanel url={this.state.iFrameUrl}
type={PanelType.medium}  //Use PanelType enum
headerText="Panel Title"
closeButtonAriaLabel="Close"
isOpen={this.state.iFramePanelOpened}
onDismiss={this._onDismiss.bind(this)}
iframeOnLoad={this._onIframeLoaded.bind(this)} />
Observed Behavior
Requires int not PanelType value

Steps to Reproduce
Copy the example code from
https://sharepoint.github.io/sp-dev-fx-controls-react/controls/IFramePanel/
Thanks! Keep up the good work!!

Hi @RyanHealy.
Just tested and it works perfectly.
One thing to mention - the library is based on office-ui-fabric-react version 5.131.0.
So if you're using v6 (which is default for SPFx 1.10) you may need to uninstall it and install v5.


manage.py failing

running
python manage.py dbseed
gets the error
Traceback (most recent call last):
File "manage.py", line 1, in
from flask.flask_script import Manager
ImportError: No module named flask_script

modifiying
from flask.ext.script import Manager
from flask.ext.migrate import Migrate, MigrateCommand
to
from flask_script import Manager
from flask_migrate import Migrate, MigrateCommand
seem to succeed in fixing the issue

Hi @mhbw,
I was unable to reproduce the issue with python 2.7.13 or 3.4.6. I would recommend perhaps installing either of those versions in a fresh virtual environment and following the steps in the readme again.
If you have any other issues I'll be happy to assist.
José


Database upgrade from V1 to V2 error.

Description
When updating to the latest version of LP, the plugin automatically updates its database from V1 to V2.  The following error occurred when this happened and it told me to report this on GitHub.
https://mclo.gs/iyB2Xqn
Reproduction Steps
Perform a V1 database update to V2 on git-Paper-"c016e03" (MC: 1.20.1).  The error message is then printed to the console.
Expected Behaviour
The V1 database should be automatically updated to V2 without any errors.
Server Details
git-Paper-"c016e03" (MC: 1.20.1)
LuckPerms Version
LuckPerms-Bukkit-5.4.102
Logs and Configs
Here is an Mc.Logs link to the exact error that was produced.
Error message: https://mclo.gs/iyB2Xqn
Attached is the config files for LP after this error.
LuckPerms.zip
Server plugin list: https://mclo.gs/IECkT1R
Extra Details
No response

Please see comments on other issues: https://github.com/LuckPerms/LuckPerms/issues?q=Something+went+wrong+whilst+upgrading+the+LuckPerms+database


[azure-core] Adjusts literalincludes for docs.microsoft.com

Verified correct rendering locally with sphinx.

Can one of the admins verify this patch?


Preserve modification date of screenshots

Hey, thank you for you the script!
I was wondering how to sort the screenshots by date, so I adapted it to set the modification date based on the one from the original file.

Great idea, thanks for your pull request!
I just tried running it on my local Win 10 setup real quick but both dates (creation & modification) seem unaffected from the change. They still show created and modified today?

os.mtime only touches the modification time, it seems there's no easy way to change the creation time without using windows APIs.
This is what I get with my changes:
Before

After

I'm running Windows 10 1909. Can you see the changes described above?

Ok nevermind, I figured it out. It had something to do with the python version I used. Turns out I was somehow stuck on 3.5.1 - on what appears to be a 5 year old release.
I just updated to 3.7.7 and the modified date is correct now.
So I will merge your changes now, thank you very much for your contribution!


uninitialized model throws: Attempt to execute code removed by Dart AOT compiler (TFA) when compiled to exe

What happened?
I need to have an uninitialized model (let's call it Product) like this:
final Product prod;

if (something) {
    prod = Product('prod 1');
} else {
    prod = Product('prod 2');
}

the problem appears when I compile the app using dart compile exe ... and run it, it throws that error:
Attempt to execute code removed by Dart AOT compiler (TFA)
Notes:

It DOESN'T work whenever I specify the type Product
It DOES work if initialize it immediately (final prod = Product('prod');)
It DOES work if I don't use a type (final prod; for example)

I think I can work around it for now, I am just hoping this would get fixed :)
if this not the appropriate place for this issue please guide me
Repro steps

dart create dummy_project
dart pub add realm_dart
dart run realm_dart install
create a file lib/model.dart with the following contents:import 'package:realm_dart/realm.dart';

part 'model.g.dart';

@RealmModel()
class _Product {}

dart run realm_dart generate
put the following code in bin/dummy_project.dart:import 'package:dummy_project/model.dart';

void main(List<String> arguments) {
  final Product prod;
  prod = Product();
  print(prod);
}

dart compile exe bin/dummy_project.dart -o bin/out
./bin/out
panic :/Unhandled exception:
Attempt to execute code removed by Dart AOT compiler (TFA)
#0      main (file:///home/khaled/Documents/dummy_project/bin/dummy_project.dart)
#1      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:294)
#2      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:189)

Version
Dart SDK version: 3.1.0 (stable) (Tue Aug 15 21:33:36 2023 +0000) on "linux_x64"
What Atlas Services are you using?
Local Database only
What type of application is this?
Dart standalone application
Client OS and version
OS: openSUSE Tumbleweed x86_64
Code snippets
final Product prod;

if (something) {
    prod = Product('prod 1');
} else {
    prod = Product('prod 2');
}

Stacktrace of the exception/crash you're getting
Unhandled exception:
Attempt to execute code removed by Dart AOT compiler (TFA)
#0      main (file:///home/khaled/Documents/dummy_project/bin/dummy_project.dart)
#1      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:294)
#2      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:189)

Relevant log output
No response

Related to https://github.com/dart-lang/sdk/issues/52874
Dont make the product final. Make it nullable
final Product prod; to Product? prod;

Hello @milindgoel15, thanks for the comment.
I already worked around it by using "late"
But really, I don't want to make it nullable when it's not, and I don't want to use "late" and lose the static analysis/lints, and obviously I don't want it to be dynamic.
I just thought it would be nice for this particular case to be solved.
Thanks anyway.

You could do ternary check instead of assigning them in the if else.
final Product product = something ? First : second

Huh, clever!
Unfortunately my actual code is a bit more complicated than a simple boolean check.
Will try to make it work tho, thanks!

Huh, clever!
Unfortunately my actual code is a bit more complicated than a simple boolean check.
Will try to make it work tho, thanks!

If its a state, perhaps try https://riverpod.dev/, maybe a stream as then you can avoid nullable via an empty stream

There was a number of dart compiler bugs introduced with Dart 3 in relation to classes marked Finalizable (such as RealmObject subclasses). This is fixed by upgrade to 3.3 or later https://github.com/realm/realm-dart/pull/1648.


Update overview-opc-twin.md

@antamb : Thanks for your contribution! The author(s) have been notified to review your proposed change.

The typo fix looks good; thanks.


Add refresh method to fake backends

Summary
Details and comments
Fixes #1707

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

13 of 48 (27.08%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 82.05%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_runtime/utils/backend_encoder.py
8
17
47.06%

qiskit_ibm_runtime/fake_provider/fake_backend.py
5
31
16.13%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
6084

Relevant Lines:
7415

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

13 of 49 (26.53%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 82.016%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_runtime/utils/backend_encoder.py
8
17
47.06%

qiskit_ibm_runtime/fake_provider/fake_backend.py
5
32
15.63%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
6061

Relevant Lines:
7390

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

13 of 49 (26.53%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 82.016%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_runtime/utils/backend_encoder.py
8
17
47.06%

qiskit_ibm_runtime/fake_provider/fake_backend.py
5
32
15.63%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
6061

Relevant Lines:
7390

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

13 of 49 (26.53%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 82.016%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_runtime/utils/backend_encoder.py
8
17
47.06%

qiskit_ibm_runtime/fake_provider/fake_backend.py
5
32
15.63%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
6061

Relevant Lines:
7390

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

13 of 49 (26.53%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 81.929%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_runtime/utils/backend_encoder.py
8
17
47.06%

qiskit_ibm_runtime/fake_provider/fake_backend.py
5
32
15.63%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
6048

Relevant Lines:
7382

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

13 of 49 (26.53%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 81.929%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_runtime/utils/backend_encoder.py
8
17
47.06%

qiskit_ibm_runtime/fake_provider/fake_backend.py
5
32
15.63%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
6048

Relevant Lines:
7382

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

13 of 49 (26.53%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 81.941%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_runtime/utils/backend_encoder.py
8
17
47.06%

qiskit_ibm_runtime/fake_provider/fake_backend.py
5
32
15.63%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
6053

Relevant Lines:
7387

💛  - Coveralls


Ingest Excel file and perform data wrangling to format variables

4.1 Import data so Time is a standalone column
my_data  <-read_excel(here("data", "une_rt_a__custom_14324113_page_spreadsheet_long.xlsx"),
sheet = 3,skip = 10) %>%
clean_names()
my_data
names(my_data)

Using {lubridate} package to create final date variable
We use make_daet() function to create a date variable from existing day, month, year variables
library(lubridate)
data_time_fmtd <- new_dates %>%
mutate(date = make_date(year,month,day))
Subset variables and re-arange columns order
date_time_fmtd2 <- data_time_fmtd %>%
select(date,x2,x3,x4,x5,x6,x7,x8,x9,x10,x11,x12,x13,x14,x15,x16,
x17,x18,x19,x20,x21,x22,x23,x24,x25,x26,x27,x28,
x29,x30,x31,x32,x33,x34,x35,x36,x37,x38)
5. Assign meaningful column names
Previouly we created a list containing column names
my_col_names <- names(COL_NAMES)
length(my_col_names)

Assign meaningful column names

Previouly we created a list containing column names
my_col_names <- names(COL_NAMES)
length(my_col_names)

[1] 38

Its length matches the list of columns from our main dataframe date_time_fmtd2
names(date_time_fmtd2)
length(date_time_fmtd2)

[1] 38

So I can use names() function with a list created out of "my_col_names" object

I will replace existing column names from main dataframe by items from my "my_col_names" list
date_time_fmtd3 <- date_time_fmtd2

Assign column names to date_time_fmtd3 dataframe from my_col_names vector
names(date_time_fmtd3) = c(my_col_names)

Rename dataframe as EU_UNEMP
EU_UNEMP <- date_time_fmtd3


cdc panic on SortEngineFactory.Create

What did you do?

set enable-pull-based-sink=false in cdc server config
create a cloud storage sink using master branch code

What did you expect to see?
no panic
What did you see instead?
github.com/pingcap/tiflow/cdc/processor/sourcemanager/engine/factory.(*SortEngineFactory).Create(0x0, {{0xc00131a292?, 0xc0047aa580?}, {0xc00131a2aa?, 0x32562c0?}})
        github.com/pingcap/tiflow/cdc/processor/sourcemanager/engine/factory/factory.go:75 +0x7d
github.com/pingcap/tiflow/cdc/processor.(*processor).lazyInitImpl(0xc003d86000, {0x41d51c0?, 0xc000db8078?})
        github.com/pingcap/tiflow/cdc/processor/processor.go:685 +0x9cb
github.com/pingcap/tiflow/cdc/processor.(*processor).tick(0xc003d86000, {0x41d51c0?, 0xc000db8078})
        github.com/pingcap/tiflow/cdc/processor/processor.go:561 +0x84
github.com/pingcap/tiflow/cdc/processor.(*processor).Tick(0xc003d86000, {0x41d51c0, 0xc000db8078})
        github.com/pingcap/tiflow/cdc/processor/processor.go:489 +0x3a5
github.com/pingcap/tiflow/cdc/processor.(*managerImpl).Tick(0xc0005e6ff0, {0x7f4d87f74958?, 0xc00282e420}, {0x419ac68?, 0xc000731020})
        github.com/pingcap/tiflow/cdc/processor/manager.go:137 +0x4af
github.com/pingcap/tiflow/pkg/orchestrator.(*EtcdWorker).Run(0xc00287e4d0, {0x7f4d87f74958, 0xc00282e420}, 0xc00082f2f0, 0x2faf080, {0x38ac61e, 0x9})
        github.com/pingcap/tiflow/pkg/orchestrator/etcd_worker.go:290 +0xfa6
github.com/pingcap/tiflow/cdc/capture.(*captureImpl).runEtcdWorker(0xc0010dc500, {0x41d5260?, 0xc00282e420}, {0x7f4d87f74990, 0xc0005e6ff0}, {0x419ac68, 0xc000731020}, 0x392a4cf?, {0x38ac61e, 0x9})
        github.com/pingcap/tiflow/cdc/capture/capture.go:511 +0x185
github.com/pingcap/tiflow/cdc/capture.(*captureImpl).run.func3()
        github.com/pingcap/tiflow/cdc/capture/capture.go:365 +0x299
golang.org/x/sync/errgroup.(*Group).Go.func1()
        golang.org/x/sync@v0.1.0/errgroup/errgroup.go:75 +0x64
created by golang.org/x/sync/errgroup.(*Group).Go
        golang.org/x/sync@v0.1.0/errgroup/errgroup.go:72 +0xa5

Versions of the cluster
TiCDC version (execute cdc version):
git commit hash: b633cef010a52a152c3ab6d2bd27cb1da563d365

Fixed in latest master branch. The panic no long appears.


I want to give settings.ajax an object directly and not make an ajax call

I want to give settings.ajax an object directly and not make an ajax call
I have added this function to Reactables.jsx
`
isJson(item) {
item = typeof item !== "string" ? JSON.stringify(item) : item;
  try {
      item = JSON.parse(item);
  } catch (e) {
      return false;
  }

  if (typeof item === "object" && item !== null) {
      return true;
  }

  return false;

}
`
an try to make something like :
`
if(this.isJson(this.settings.ajax)) {
this.setLoader(columns.length);
this.jsonData = this.settings.ajax;
this.createTable(this.jsonData);
this.setTableSort();
} else {
  //make the call to get json data
  fetch(this.settings.ajax).then((response) => ... in the build() function

`
I have managed to compile an index.js file a file with this modifications but when I compile my project I get :
Uncaught (in promise) TypeError: E.forEach is not a function
Can you please add an option like this an option like this in the near future?
The reason that I'm asking for this option is that I don't always want to make and ajax call to get the json rows. Maybe I want to build an rows object  on the fly and re-render the datatable with the rows object that I have created.
Thank you

Another thing that I will find useful will be:
If I have some amounts in some column of the table, maybe I want to have the totals of those cells in the table footer

Never mind about giving settings.ajax an object directly and not make an ajax call, I made it myself. Moving on to add other features.

Hi ragugit, glad to see u contributing with ideas as it develop our skills.
Yes you can upload a file say with var data = require('./data.json');
Then u can even pass that data as <Reactables editor={editor} settings={settings} data={data}>
Wonderful, then the user somehow need to make CRUD ops with that data - how can she do that? And what if it is not a nodejs server, but a script included in html page? Should we disable all CRUD buttons then?
Let's think about counters - yet it is good idea to count any int/double data column, but how to serve that functionality if there are 50, 75, 125 rows per page, counting only those showed? Probably those that total resulting?
PS just try to think through those proposals and complete the big picture, thx.

Hi,
What I did is to test the settings.ajax and if it a object or a json (and not a link) to go ahead and create the table.
This is good because if some how there are some  changes made to the object or a json data you can reset settings.ajax and call setState again.
I have also added custom classes on table header and on each cell in the body.
Future plans include adding a footer to the table, and adding a custom event to know when the table got rendered.
My time to work on this project is very limited but I'm not in a hurry
thx

As this question is to old, I'm closing it. Nevertheless, I've implemented the feature proposed here "If I have some amounts in some column of the table, maybe I want to have the totals of those cells in the table footer" - it is helpful in many accounting tasks, so thank u for the proposal.


Trying to install - Building wheel for lxml (pyproject.toml) ... error

W10 x64, Python 3.12.
I've installed Microsoft C++ Build Tools with "C++ build tools".
Then trying to install SRTranslator via pip  and getting error
<...>
Building wheel for lxml (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for lxml (pyproject.toml) did not run successfully.
  │ exit code: 1

<...>

 C:\Users\EXPRES~1\AppData\Local\Temp\xmlXPathInittcl7bd0n.c(1): fatal error C1083: cannot open include file: libxml/xpath.h: No such file or directory,
      *********************************************************************************
      Could not find function xmlCheckVersion in library libxml2. Is libxml2 installed?
      *********************************************************************************

I've installed lxml via pip, and also did pip install --upgrade setuptools - doesn't help :(
Tried to manually install from www.lfd.uci.edu lxml-4.9.0-cp311-cp311-win_amd64.whl and lxml-4.9.0-cp311-cp311-win32.whl - both are "not a supported wheel on this platform".

Seems like lxml library isn't available in python 3.12 (yet). Try downgrade python (3.10 maybe???) or ask the developers of that package.
Closing it due the issue is not from this package

Just please change libxml==4.9.3 (actual version) in requirements and it should work.

@eXpressionist done


Why not use

The component uses <input type="text" > as the underlying input control. While this works fine on the desktop, on a phone, normally I would like the numeric keypad to appear whenever the control has focus.
Having <input type="text"> makes it very annoying to enter a number using this component as one has to switch input method first.
So the question is, why not use <input type="number"> as the underlying input control? And whether I can override the default input type?

The mobile use case is essentially the only benefit, as far as I can tell.
You'd have to override different browser behavior w.r.t rendering number inputs, e.g. up and down buttons in WebKit, as well as validation.

Thanks @cdtinney, that is correct! I would add that this component provides more functionality (like custom formats) which is not possible with the native number inputs. As for the input method see  #24 .


pylsp never gets configured

So, I've read the logs for my own runs of pylsp, and I poked around on the issues for both pylsp and kak-lsp, and found this conundrum.
pylsp doesn't want to use initializationOptions, since per their comments, it's not very standardized: python-lsp/python-lsp-server#195
But from everything I can see, and my own local tests, kak-lsp doesn't send workspace/configuration unless requested, which pylsp never does. It would be nice to be able to ensure that the configuration is also sent via this, at least maybe via a config option.
Essentially, from everything I can see, pylsp isn't loading the configuration from kak-lsp since it ignores the initialization options and kak-lsp doesn't send a separate workspace/configuration message.
When I check the logs, I see calls for textDocument/didOpen, textDocument/codeLens, and initialized sent to the server, but no workspace/configuration.

But from everything I can see, and my own local tests, kak-lsp doesn't send workspace/configuration unless requested, which pylsp never does.

This is expected behavior, the spec says

The workspace/configuration request is sent from the server to the client to fetch configuration settings from the client.

so we should not send this unless we're asked to.
pylsp configuration actually works fine, because we send workspace/didChangeConfiguration which essentially has the same information. This must be a problem in your configuration.

if you see a panic in logs (search for ERRO) then upgrading would help if it's https://github.com/kak-lsp/kak-lsp/issues/654

So, I saw #654 and thought it was totally separate to my case, but it might be. I thought I looked for errors in the log but this ERRO was sneaky:
Dec 04 06:58:58.451 ERRO Failed to parse header, module: kak_lsp::language_server_transport:79

Will use latest commit and see if that fixes it. Until then, here's the current log I have:  .kak-lsp.log

Okay, the latest commit definitely adds in the didChangeConfiguration call, whereas the previous version I was on (14.1.0) didn't. Will let you decide if you want to keep this open or track this in the other issue, depending on whether you think they're sufficiently different. And attaching the new log:
.kak-lsp.log

"Language server error" means pylsp terminated due to an error. Your latest log says it can't find the flake8 module.
You explicitly asked for flake8, so that makes sense. You probably just need to install it.
I don't think there's a kak-lsp issue left here but LMK if otherwise

Yeah, I'll close this. Thanks for helping with the debug since I seem to just not be able to read logs. ><


Slow to open Files

Description
every time I close Files and reopen it, it always takes a few seconds to load
I tried to restart my pc and reinstall the software but nothing changed.
Steps To Reproduce
No response
Expected behavior
I expect to open like the normal file explorer. Instantly.
Files Version
2.1.13
Windows Version
Windows 11 Insider Preview 22543.1000 (rs_prerelease)
Relevant Assets/Logs
https://user-images.githubusercontent.com/45063794/153402471-a3e5fba4-e796-43af-acfe-d7ca72f472e8.mp4
debug.log
debug_fulltrust.log

We're excited to share that startup performance will be significantly improved in the upcoming release of version 3. You can download the preview version from our website https://files.community/download.


merge package from arlac77/npm-package-template-esm-only

.travis.yml

chore(travis): remove node versions 12.5.0
chore(travis): add node versions -10,-11,-12,12.6.0

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   93.05%   93.05%
=======================================
  Files           6        6
  Lines         216      216
  Branches       39       35    -4
=======================================
  Hits          201      201
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f765ad...58f0309. Read the comment docs.

:tada: This PR is included in version 1.0.12 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Generate a list of potential partners for this project

Identify Chicago based partners who work in smaller areas. Look for environmental justice groups serving at the neighborhood (ideally).
Partner should have the ability to communicate info to these areas.

I think we can mark this done for now. If can't find a partner from the current list, we can revisit.

Okay sounds good!


[Event Request] Codeunit 6620 "Copy Document Mgt." - Procedure: CopyPurchReturnShptLinesToDoc  - Event: OnAfterCopyPurchReturnShptLinesToDoc

Hi Development Team,
We would like to see the following event added to the Codeunit 6620 "Copy Document Mgt.":
Similar to my other requests:

OnAfterCopySalesShptLinesToDoc
OnAfterCopySalesInvLinesToDoc
OnAfterCopySalesCrMemoLinesToDoc
OnAfterCopySalesReturnRcptLinesToDoc
OnAfterCopyPurchRcptLinesToDoc
OnAfterCopyPurchInvLinesToDoc
OnAfterCopyPurchCrMemoLinesToDoc

The CopyPurchReturnShptLinesToDoc procedure is public and also used in automated testing when copying lines from different documents.
We are missing and 'end of lines loop'/ 'before end of procedure' event to process information which was gathered during the procedure.
The automated tests are also using these procedures to test a copy line from multiple documents, so for our feature, we are unable to write successful tests.
The code with the requested added event:
 procedure CopyPurchReturnShptLinesToDoc(ToPurchHeader: Record "Purchase Header"; var FromReturnShptLine: Record "Return Shipment Line"; var LinesNotCopied: Integer; var MissingExCostRevLink: Boolean)
    var
        // vars
    begin
        MissingExCostRevLink := false;
        InitCurrency(ToPurchHeader."Currency Code");
        OpenWindow();

        OnBeforeCopyPurchReturnShptLinesToDoc(TempDocPurchaseLine, ToPurchHeader, FromReturnShptLine);

        with FromReturnShptLine do
            if FindSet() then
                repeat

                    // --- Code ---

                    if CopyLine then begin
                        NextLineNo := GetLastToPurchLineNo(ToPurchHeader);
                        OnCopyPurchReturnShptLinesToDocOnAfterCalcNextLineNo(ToPurchHeader, FromReturnShptLine, FromPurchHeader, NextLineNo, InsertDocNoLine);
                        if InsertDocNoLine then begin
                            InsertOldPurchDocNoLine(ToPurchHeader, "Document No.", 3, NextLineNo);
                            InsertDocNoLine := false;
                        end;
                        repeat
                            ToLineCounter := ToLineCounter + 1;
                            if IsTimeForUpdate() then
                                UpdateWindow(2, ToLineCounter);

                            OnCopyPurchReturnShptLinesToDocOnBeforeCopyPurchLine(ToPurchHeader, FromPurchLineBuf, CopyItemTrkg);

                            if CopyPurchDocLine(
                                ToPurchHeader, ToPurchLine, FromPurchHeader, FromPurchLineBuf, NextLineNo, LinesNotCopied, false,
                                "Purchase Document Type From"::"Posted Return Shipment", CopyPostedDeferral, FromPurchLineBuf."Line No.")
                            then begin
                                if CopyItemTrkg then begin
                                    if SplitLine then
                                        ItemTrackingDocMgt.CollectItemTrkgPerPostedDocLine(
                                          TempItemTrkgEntry, TempTrkgItemLedgEntry, true, FromPurchLineBuf."Document No.", FromPurchLineBuf."Line No.")
                                    else
                                        ItemTrackingDocMgt.CopyItemLedgerEntriesToTemp(TempTrkgItemLedgEntry, ItemLedgEntry);

                                    ItemTrackingMgt.CopyItemLedgEntryTrkgToPurchLn(
                                      TempTrkgItemLedgEntry, ToPurchLine,
                                      FillExactCostRevLink and ExactCostRevMandatory, MissingExCostRevLink,
                                      FromPurchHeader."Prices Including VAT", ToPurchHeader."Prices Including VAT", true);
                                end;
                                OnAfterCopyPurchLineFromReturnShptLineBuffer(
                                  ToPurchLine, FromReturnShptLine, IncludeHeader, RecalculateLines,
                                  TempDocPurchaseLine, ToPurchHeader, FromPurchLineBuf, CopyItemTrkg);
                            end;
                        until FromPurchLineBuf.Next() = 0;
                    end;
                    OnAfterCopyReturnShptLine(FromReturnShptLine, ToPurchLine);
                until Next() = 0;

        >>>>>>> New Event <<<<<<<<
        OnAfterCopyPurchReturnShptLinesToDoc(ToPurchHeader, FromReturnShptLine, LinesNotCopied, MissingExCostRevLink);
        >>>>>>> New Event <<<<<<<<
        CloseWindow();
    end;

The new event:
  [IntegrationEvent(false, false)]
  local procedure OnAfterCopyPurchReturnShptLinesToDoc(ToPurchHeader: Record "Purchase Header"; var FromReturnShptLine: Record "Return Shipment Line"; var LinesNotCopied: Integer; var MissingExCostRevLink: Boolean)
  begin
  end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 53388.


shapelib: 1.6.0 - 1.6.1

Description of changes
Update shapelib to the lastest patch version and move package to by-name.
List of changes: https://github.com/OSGeo/shapelib/releases/tag/v1.6.1

shapelib: 1.6.0 - 1.6.1
shapelib: move to by-name

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 334765 run on x86_64-linux 1

2 packages failed to build:

pytrainer
pytrainer.dist

8 packages built:

gnudatalanguage
gpsbabel
gpsbabel-gui
gpsbabel-gui.doc
shapelib
tilemaker
viking
xastir


"Unknown" modalities are mentioned in the text

ran into while reviewing https://github.com/bids-standard/bids-specification/pull/475  . Text refers to RARE and FLASHsubsampled although none such is listed among known modalities
$> git grep -e RARE  -e FLASHsubsampled
src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md:are used to record the same modality (e.g. RARE and FLASH for T1w) this field
src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md:distinction (e.g. just between RARE and FLASH, or between RARE, FLASH, and
src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md:FLASHsubsampled) remains at the discretion of the researcher.

These appear to be suggestions for acq- values.
https://github.com/bids-standard/bids-specification/blob/abf6f7329cf84fcf1eec819813c278daddcde35c/src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md#L156-L169

nah, I think I just rushed into filing an issue... indeed it makes sense to annotate "peculiar" acquisitions  for which we have no suffix in acq-.


Simplify middleware approach using Koa-like fns

Closes #48

Coverage decreased (-0.8%) to 94.61% when pulling fb47ae463a2786c109482775d237420f6203d5c2 on refactor-middleware into e99b956cecaa7853e949cac2fd0f21096fb6f4d9 on master.

Coverage decreased (-0.8%) to 94.61% when pulling f763eb660e2178e498156f2574d4ab4c68a45fe4 on refactor-middleware into e99b956cecaa7853e949cac2fd0f21096fb6f4d9 on master.

Coverage increased (+0.9%) to 96.337% when pulling 3e2ed7347b7b0fc01bd97d8e3588f525fa05d175 on refactor-middleware into e99b956cecaa7853e949cac2fd0f21096fb6f4d9 on master.

Coverage increased (+0.4%) to 95.811% when pulling c268232cdc3ae9628a43a5606eb00901de789dca on refactor-middleware into e99b956cecaa7853e949cac2fd0f21096fb6f4d9 on master.

Coverage increased (+0.7%) to 96.127% when pulling f00ef6e8675cead0e585685bf8a488032d3d393e on refactor-middleware into e99b956cecaa7853e949cac2fd0f21096fb6f4d9 on master.

Coverage increased (+0.3%) to 95.795% when pulling 25f41dbe37a6bb5fa45656bc7a545db7ec417468 on refactor-middleware into e99b956cecaa7853e949cac2fd0f21096fb6f4d9 on master.

Coverage increased (+1.007%) to 96.462% when pulling cf4aa691d30776134b904b283792462440506974 on refactor-middleware into e99b956cecaa7853e949cac2fd0f21096fb6f4d9 on master.

Coverage increased (+1.007%) to 96.462% when pulling cf4aa691d30776134b904b283792462440506974 on refactor-middleware into e99b956cecaa7853e949cac2fd0f21096fb6f4d9 on master.


Add ability to view markdown source on comments

I've seen this on other sites and I think it's a nice touch and has some utility. For example on this post I wanted to use the same comment layout as  the other commentator for consistency, so with this feature I could view source and copy it.

Closed by https://github.com/larvalabs/pullup/pull/376.


WIP: changes for kubernetes v1.5.1

This v1.5 kubernetes upgrade broke a bunch of stuff for me.
There is a new version of kubernetes-plugin that looks like it was targeting support for v1.5.1
Changes (?) in the plugin require user to create a container called "jnlp" in the pod, or it will create one for you.  If you are upgrading from an older kubernetes-plugin with no other changes, this is almost certainly not what you want.
I am sure this is on purpose as there are other Docker cloud providers that don't require you to build JNLP slave into your test container.  But the default pod definition brings up a slave container with jnlp worker and nothing else on it.  I used a custom pod definition and was caught off guard by this "jnlp" container that was missing all of my project's custom dependencies.  Could not figure out how this was intended to be used, and it doesn't seem to be mentioned in the docs, but when I named my container "jnlp" in the pod definition, it prevented this other container from being created and that just fixed everything for me.
Marked as WIP because I'm not sure that kubernetes-plugin:v0.10 is really a finished product, or so sure that I actually know what I'm doing, so someone who knows more about this than I do should probably do some review before pushing the button to merge.  Might be other changes needed.
It kind of looks like they (kubernetes-plugin) wanted to get something pushed out the door that works with 1.5, since 1.5 is already out now.

Not sure I can sign a CLA right now, my @nd.edu account is the one I'm committing as and I'll have to run it by campus lawyers if I'm going to sign anything as an employee (they will probably say no), so let me know if I can submit this as an issue instead to get this addressed... if I need to I will send a PR from my personal account instead.

I just ran into this yesterday. The new default does seem to be a bit bizarre as it is a breaking change. Can you create an issue from this? Then I'll put this into a PR that also bumps the Jenkins image and version in the chart after I've done more testing.

@viglesiasce, this is fixed in #315

Closing in favor of #315


have a error while i add IMU date for backpack_2d

hi,
I have set the IMU drive in ros,and  changed the launch,when i runned the launch i got the following warn：
[ WARN] [1478952719.408758831]: W1112 20:11:59.000000  5699 tf_bridge.cc:51] "base_imu_link" passed to lookupTransform argument target_frame does not exist.
This is the lua：
include "map_builder.lua"
options = {
  map_builder = MAP_BUILDER,
  sensor_bridge = {
    horizontal_laser_min_range = 0.,
    horizontal_laser_max_range = 20.,
    horizontal_laser_missing_echo_ray_length = 1.5,  constant_odometry_translational_variance = 0.,
    constant_odometry_rotational_variance = 0.,
  },
  map_frame = "map",
  tracking_frame = "base_imu_link",
  published_frame = "laser_link",
  odom_frame = "odom",
  provide_odom_frame = true,
  use_odometry_data = false,
  use_horizontal_laser = true,
  use_horizontal_multi_echo_laser = false,
  num_lasers_3d = 0,
  lookup_transform_timeout_sec = 0.2,
  submap_publish_period_sec = 0.3,
  pose_publish_period_sec = 5e-3,
}
MAP_BUILDER.use_trajectory_builder_2d = true
TRAJECTORY_BUILDER_2D.use_imu_data = true
TRAJECTORY_BUILDER_2D.use_online_correlative_scan_matching = true
TRAJECTORY_BUILDER_2D.motion_filter.max_angle_radians = math.rad(0.1)
return options

This is the launch:
<launch>
  <node name="cartographer_node" pkg="cartographer_ros"
      type="cartographer_node" args="
          -configuration_directory $(find cartographer_ros)/configuration_files
          -configuration_basename backpack_2d.lua"
      output="screen">
    <remap from="scan" to="/laser_scan" />
  </node>
<node pkg="razor_imu_9dof" type="imu_node.py" name="imu_node" output="screen">
   <param name="port" type="string" value="/dev/ttyUSB0"/>
   <param name="frame_id" type="string" value="base_imu_link" />
   <remap from="imu" to="/imu/data" />
</node>
</launch>

My guess is that you've not changed your URDF to reflect the name of the IMU link "base_imu_link". This is more of a ROS issue than a Cartographer issue. I suggest taking followup questions to http://answers.ros.org/

hi,
I added the IMU data in backpack_2d, but no matter how I placed the IMU in the direction（z or x or y-axis aligned wit word), I always get the Max inclination exceeded 20 warning:
[ WARN] [1479380979.407526014]: W1117 19:09:39.000000 78094 local_trajectory_builder.cc:241] Max inclination exceeded: 48.309 > 20
[ INFO] [1479380987.814185144]: I1117 19:09:47.000000 78094 collated_trajectory_builder.cc:79] imu rate: 48.76 Hz 2.05e-02 s +/- 2.00e-03 s (pulsed at 100.03% real time)

Sounds like a separate issue. Please open a new issue and include your configuration, URDF, launch files, specs for the IMU, and a bag.

ok


.0 is reserved address in V4, and in Linux prefix:: address does not work

=> please start AA at 1 :)

(prefix:: address is 'subnet device anycast' according to Cisco IOS documentation, so it is a bad idea.)

d3fdc841271370578ebd410d8fefb5f00d4e4b2d and f76f309df08e82244a1a7cbcf0d612f728be7404 should fix that.


POL-1167 p90/95/99 Support for Azure Rightsize Compute/SQL Policies

Description
This adds support for p90/p95/p99 metrics to the Azure Rightsize Compute Instances and Azure Rightsize SQL Databases policy templates as well as some other changes outlined below:
Azure Rightsize Compute Instances Changelog:

Added support for p90, p95, and p99 metrics for both CPU and memory.
Improved calculations for Minimum and Maximum for both CPU and memory.*

Azure Rightsize SQL Databases Changelog:

Added Threshold Statistic parameter to assess utilization based on various CPU metrics
Added CPU minimum, maximum, p90, p95, and p99 metrics to incident table

* Previously, the policy was actually reporting the daily average minimum and maximum CPU usage, since it was averaging the daily metrics returned by the Azure API. It now reports the lowest minimum value and the highest maximum value from those data sets instead, which is more accurate and looks less strange next to the relevant p90/p95/p99 metrics.
Link to Example Applied Policy
https://app.flexera.com/orgs/6/automation/applied-policies/projects/7954?policyId=668442998e6ee150dc4b45b8
(Azure Rightsize SQL Databases was tested in a client environment where data is available)
Contribution Check List

[X] New functionality includes testing.
[X] New functionality has been documented in the README if applicable
[X] New functionality has been documented in CHANGELOG.MD

With 15min interval seeing results that make more sense imo:

Maybe nit-picking, but perhaps the order of fields in export declaration should be:
Min,Avg,p90,p95,p99,Max (?)


Implement Color > Settings >clear()

Implement clear (Resolve #116)

@matthew-carroll please review this PR. Thanks

I did check the test reference from processing.org, but their test depends on PGraphics, which we haven't implemented yet. So I came up with my own test cases


Basic / Digest auth functionality no longer working

cb32af217f0a55ad106b96197a5a13a75f2ab5b4 replaced the existing auth functionality with passport.js and a browser-based login form. This eliminated the ability to make Basic / Digest auth requests to the API, e.g. curl -u "admin:admin" "http://localhost:3210/omk/odk/submissions/Encrypted_Malawi_social_mobilization.json?offset=0&limit=5000" and curl --digest -u "admin:admin" "http://localhost:3210/omk/odk/submissions/Encrypted_Malawi_social_mobilization.json?offset=0&limit=5000" (both now return 401 Unauthorized).
Why is this a problem? ODK makes automated authenticated requests using Digest auth over HTTP.
This may not be a problem yet, but I wanted to flag it to ensure that ODK auth'd requests continue to work.

@mojodna The basic authentication is working now (https://github.com/hotosm/OpenMapKitServer/commit/35736ab3ac1a3b1776f5bab5651ec9f2077ed3b3). I configured the digest according to the documentation of passportjs, but it's not working yet. I'll keep trying to make it work.

Now that I've got a working setup, I've tried this with both ODK Collect (mobile) and ODK Briefcase. Neither prompt for a username/password. While this is convenient, it may not make sense to allow data to be fetched (ODK Briefcase) w/o being authenticated.


Add Ops Tool to PROD for Distro-build-tooling

Issue #, if available:
Description of changes:
Added the Deployment and Service values that are pulled when adding the tool to prod. Added the image information for the tool in the public ecr.
Tested the tool against personal repo and got expected responses to opened issues.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Stanford Cars Analysis

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : Stanford Cars Analysis
:red_circle: Aim : Analyze the data of the Stanford Cars.
:red_circle: Dataset : https://www.kaggle.com/jessicali9530/stanford-cars-dataset
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.
Hello, ML-Crate contributors, this issue is only for the contribution purposes and allocated only to the participants of SWOC 2.0 Open Source Program and JWOC '22 Open Source Program.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'SWOC' and 'JWOC' contributors of 'ML-Crate' project.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Participant ID :
Approach for this Project :
What is your participant role?

[ ] SWOC 2.0 Participant.
[ ] JWOC 2022 Participant.
[ ] Contributor

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Full name : Nupur Kelkar
GitHub Profile Link: https://github.com/Nupur2471
Approach for this Project: Creating a CNN Model for Classification.  Using XGboost and InceptionResNetV2 Model to figure out which has better accuracy.

Nice approach. Go ahead, issue assigned to you @Nupur2471

Issue has been un-assigned from you due to inactivity.
@Nupur2471

Full name : Prince Thakkar
GitHub Profile Link : https://github.com/rising-star2712
Participant ID : NA
Approach for this Project : CNN , XG Boost , with Open CV , this is my first time trying open CV , requesting you to assign this issue to me , would love to work on it
What is your participant role?

waiting for the issue to be assigned and will start the work as soon as possible

Issue assigned to you @rising-star2712

Unassigned. ML-Crate is going to be part of DWOC from Jan, 15, all the unfinished issues will be taken by the contributors of DWOC.

Hey, @abhisheks008
I'd like to work on this.
Full name : Soumya Kushwaha
GitHub Profile Link : https://github.com/Soumya-Kushwaha
Participant ID : NA
Approach for this Project : Use YOLO along with Inception

Sure why not.
Assigned to you @Soumya-Kushwaha

Full name : Ahmed Mohammed  Anwar
GitHub Profile Link : https://github.com/Anwar11234
Participant ID : NA
Approach for this Project : building a computer vision model to detect plate number of a car
What is your participant role? KWOC 2023 Participant.

Hey @Anwar11234 sorry for the delay, I was in vacation with my family. Issue assigned to you @Anwar11234


Enable import of quizzes

Description
~Create json schema and an HTTP endpoint to import quizzes~
Give Niklas a guide how to use the API to import quizzes
Acceptance Criteria

[ ] quizzes can be imported

we disussed with niklas that a description of the api and tutorial how to do it is sufficient

@LG1401 should be probably done this sprint with 1 SP


cmake doesn't accept SCIP 9 anymore

With 8fdef68, our interface tests fail with
CMake Error at CMakeLists.txt:78 (find_package):
  Could not find a configuration file for package "SCIP" that is compatible
  with requested version "8.0.0".

  The following configuration files were considered but not accepted:

    [<https://cijenkins.zib.de/job/SCIPOptSuite_test_interfaces/ws/scipoptsuite-9.1.2/build/scip/scip-config.cmake,>](https://cijenkins.zib.de/job/SCIPOptSuite_test_interfaces/ws/scipoptsuite-9.1.2/build/scip/scip-config.cmake,) version: 9.1.2

I assume the "at least" of "at least SCIP 8.0.0" didn't work.

Looks like it is trying to enforce semver compatibility rules, where 9.… is "incompatible" with 8.…. It should not be doing this by default, especially considering that there is no easy option to disable this behavior. (There is only EXACT which does an even stricter match.) It is possible to specify a version range, but no open-ended range, and it also requires support from both the used version of CMake (the minimum currently accepted, 3.3, does not support this, only 3.19 and newer do) and the individual Find*.cmake/*Config.cmake module.
The easiest way to work around this is probably to not specify a version in find_package at all, but to check it manually with if (SCIP_VERSION VERSION_LESS "8.0.0"). I will try this later today.

This is actually a misfeature of the SCIP build system.
scip/src/CMakeLists.txt has this:
write_basic_package_version_file(
${PROJECT_BINARY_DIR}/scip-config-version.cmake
    VERSION ${SCIP_VERSION_MAJOR}.${SCIP_VERSION_MINOR}.${SCIP_VERSION_PATCH}
    COMPATIBILITY SameMajorVersion
    )

The SameMajorVersion there is causing this behavior. See the generated scip-config-version.cmake to see the behavior. (You cannot even specify a range like 8.0.0...9.9.9 or 8.0.0...<10.0.0, it will reject any range that is not restricted to a single major version.)
I will work around this as described in my previous comment, but it should really be fixed in SCIP. The compatibility should be AnyNewerVersion. If a dependent package really wants to specify SCIP 8.x.x only, it should request the range 8.0.0...<9.0.0 explicity. It should not be done by default, especially because there is no way to opt out of this behavior.

Filed scip#116 for this.


chore(deps): update common-dev-assets digest to 9dac941

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
ecde068 -> 9dac941

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ig-k8s: Consolidate entrypoint binary on main gadget tracer manager binary

The entrypoint logic is currently compiled as an independent binary. There is not any reason to do this way, this logic should be directly called from the main function of the gadget tracer manager process.
Ref https://github.com/inspektor-gadget/inspektor-gadget/pull/2207#issuecomment-1798489733

/assign

Hi @mauriciovasquezbernal , is issue open for contributions?

@KapilSareen for sure.

/assign


Mention babel-plugin-js-logger in README.md

Hi,
hope you like the following nice babel plugin:
https://www.npmjs.com/package/babel-plugin-js-logger
https://github.com/core-process/babel-plugin-js-logger
Would you like to add a reference to your README.md?
Thanks!
Niklas

Nice plugin, feel free to raise a pr against the jslogger readme

https://github.com/jonnyreeves/js-logger/pull/45

Thanks! :+1:

@jonnyreeves Have a look at our logger-example project. It is a self-contained showcase on how to use js-logger within your backend and frontend code efficiently.


webpack not creating a folder/directory

I'm using Windows 8 and my current webpack version is 2.4.1.
Here's webpack.config.js
module.exports = {
	entry: "./app/assets/scripts/App.js",
	output: {
		path: __dirname +  "./app/temp/scripts",
		filename: "App.js"
	}
}

and here's the output, problem is it's not creating the scripts folder and App.js file under temp directory

I'm using Windows 10 so it might vary but I think what's causing you troubles is the "." in your output.path property.
It's probably creating a directory very similar to your working directory but with an extra dot:
I'm working in a "test" directory and it creates next to it a "test." directory

@Axnyff Thank you! I removed the "." in my output.path and it worked like a charm. However, my travel-site folder doubled. The one have a "." at the end of the name. Whenever I delete the one with the ".", the one without "." is having "." at the end. What cause this?

Here's the code you suggested
module.exports = {
	entry: "./app/assets/scripts/App.js",
	output: {
		path: __dirname +  "/app/temp/scripts",
		filename: "App.js"
	}
}

That's a Windows bug i think, windows is deleting the wrong folder.

It looks like you just deleted our lovely crafted issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template. I'm closing this. Please open a new issue with filled issue template. Also make sure your issue is not a question. Questions should be posted on Stack Overflow.


Clarify virtualenv vs project directory confusion

Closes #114

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Bump

Thanks for this. I've added a few comments.
Two more things:

do you mind making a PR on the develop branch instead?
feel free to do the change in nefertari's getting started too

@jstoiko I will create new PR based on develop branch.


Lost password link

Would be handy to reset password.

I will reset all your passwords. Seriously, this is starting to become quite annoying. See #118 and to a lesser degree #73

Note: creating user accounts is now optional with the DRIBDAT_NOT_REGISTER environment setting, which is useful when using OAuth (currently = Slack) for login. This way you can disable regular accounts after creating an admin user, and use third-party auth for everyone else.

Adding Flask Mail and corresponding settings is relatively trivial. Then add a hash field to the User model, which is set to a randomized value when a password reset mail is requested. Include a link to the dashboard (i.e., login via e-mail) as well as to the profile editor (i.e. to change password) in the mail body. I'm running out of excuses for not doing this soon.

As per #184, I have made it easier for administrators to reset passwords. There are several SSO options. In the age of Bitwarden & co., I see losing your password as a definite first world problem. We can re-open this if this continues to be a source of discomfort for users.

As per #184, I have made it easier for administrators to reset passwords. There are several SSO options. In the age of Bitwarden & co., I see losing your password as a definite first world problem. We can re-open this if this continues to be a source of discomfort for users.

Sites like OpenCollective (pictured below) don't use passwords at all: either login via an e-mail link, or use SSO (i.e. you're someone else's problem :^)
As long as the Dribdat site is efficiently set up with Mailgun or so for sending mails, I don't see a problem with that. I'm reopening this issue to make losing passwords a thing of the past, by making e-mail login the default and password login optional.


Use a extensible type for Maelstrom messages

Instead of fixed enum with RPC messages provide a place for extending
RPC messages. This is done with a base protocol and several structures
that implement this base protocol

Nice refactor, +1

Thanks, I have realized that all messages should go throw Maelstrom.
Now work on send RPC function.


string terminator: NUL, not NULL

Please fix: the null character (string terminator), aka '\0', is typically shortened to NUL, not NULL (which refers to the null pointer, i.e. (void*)0). Although a subtle issue, it can confuse inexperienced programmers. Thank you!

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 006e82ed-1dab-6821-bcf8-dc897ce297e0
Version Independent ID: 5aa1d5db-3dbf-703e-b700-a093bc0663b8
Content: strlen, wcslen, _mbslen, _mbslen_l, _mbstrlen, _mbstrlen_l
Content Source: docs/c-runtime-library/reference/strlen-wcslen-mbslen-mbslen-l-mbstrlen-mbstrlen-l.md
Service: unspecified
Product: visual-cpp
GitHub Login: @corob-msft
Microsoft Alias: corob

Thanks for spotting an inconsistency. In the Microsoft documentation, we use NUL as the name of a device that consumes all input and has no output, while NULL is used as a null pointer (in C-specific documentation), or (very rarely) a zero value. It's not supposed to be what we call the null character - usually, we call it the null character, or a null terminator.
I found about a half-dozen uses of NULL that referred to a character, rather than a pointer. I have a fix in the works to refer to these consistently as a null character or null terminator (no bold or uppercase) as used in the relevant standards, while NULL is now consistently used as the name of the null pointer, as defined in the headers.


UI ux 71 bookmark results

Some issues with this PR, but I want to merge so @WeiXinFam can finish off her ticket.


Updated Controller Spec link to yaml version

Just noticed this broken link while I was setting this up on my box.

Can one of the admins verify this patch?

My bad, I forgot to update the markdown docs when changing the formats. Thanks for noticing!


Could you provide the complete testing script for LAPT model?

When I run sh scripts/ood/lapt/test.sh,  I noticed that there was no output.
Upon reviewing the script, it seems that the test script is fully commented out. Could you kindly confirm if this is intentional or if there’s an issue with the script?
Thank you for your time and assistance!

Thanks for your interest. the "scripts/ood/lapt/test.sh" has been updated.


Update Japanese docs to apply token rotation (#413) changes

Update the Japanese docs with the same token rotation information that was introduced in #413 .
The page URLs

https://slack.dev/bolt-python/ja-jp/concepts#token-rotation

Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

Fixed by #418


XSD auto-validation

Automatic validation of all subsystem config XMLs against XSD schema on on build + fixes of found problems.

This one needs a rebase - I think I made some similar changes to the schema when it failed validation in WildFly so should be a simple one.

Rebased + fixes of XSD


[Simple AA in NewDot] Support FORWARDED report action in NewDot

~cc @tgolen as this relates to your project: https://github.com/Expensify/Expensify/issues/396071~
Actually i think this relates to mine, https://github.com/Expensify/Expensify/issues/393839
Problem:
Currently, we do not support showing the FORWARDED Report Action in NewDot. The report action currently is displayed like this in NewDot:

We started writing the code here, but it remains commented out
We need to implement this b/c we are bringing Control workspaces to NewDot. Report "Forwarding" happens when:

Control workspace has "Advanced Approvals" enabled
Submitter submits report to Approver
Approver Forwards & Approves to Final approver

Solution:
Support it!

@shawnborton I tagged design here b/c I want to make sure we get the correct copy for showing the Forwarded report action in NewDot.
The current copy in OldDot is: You approved and forwarded this report to <next approver>
I don't think we want to mention the term "Forwarded" / forwarding concept in NewDot, we want to make it always read "Approve" IIRC, so I suggest one of these copies:

approved $<amount> (this follows the existing APPROVED report action text)
approved and passed to <next approver> for further approval

Hey @Beamanator appreciate the tag! For these kinds of things, this is more of a copy/marketing thing though I think, so let's see if @jamesdeanexpensify has a strong opinion.
I'm not sure the best way to word this though... maybe something simple like:

approved $XX.XX and then sent to XXXX

cc @trjExpensify @Expensify/design for more thoughts too

Hm yeah, tricky one.. this wording has always been a bit confusing. The next steps in the header communicate who's next up to approve, right? Further, the next in-line will receive a whisper message in the workspace chat to be notified of the action they need to take?
So I'm sorta' inclined to just stick with the standard for the time being:

approved $100.00

Oh those are good points about the next steps banner, I would be cool with an approach like you are suggesting.

Sounds good to me too

Yeah I'm down for that approach too. Nice and simple.

sounds good to me!

Not overdue Melvin, we have agreement above on what copy to use for the system message.

Nice, thanks for the discussion y'all! Sounds like we're going with:

approved $100.00

👍

PR is ready for review 👍  assigning @mananjadhav here since you were auto-assigned to review the PR! 🙏

PR is on staging as of yesterday, hopefully will get to prod today

I'll add the payment summary tomorrow. @mananjadhav, can you please propose regression test steps for this one?

Summarizing payment on this issue:
Contributor+: @mananjadhav $250, please request on Newdot

@mananjadhav please also propose new regression test steps 🙏

@mananjadhav friendly bump to propose regression steps.

Manan is out, posting for Melvin.

This is a new feature so we don't have an offending PR. I am not sure if we have regression tests managed centrally for this. But specifically for this issue we can take the steps from the PR.
Regression Test Proposal

In OldDot, create a Control policy with 3 members:

The owner
An approver (user role)
An submitter (user role)

In OldDot, make sure the policy has advanced approvals turned on (in the Members tab), with these settings:

submitter has submitsTo set to the approver
approver has approves to / forwardsTo set to the owner

Make sure the policy has isPolicyExpenseChatEnabled set to true, by running this in the console when you have that policy open in OldDot:
p = Policy.getCurrent();
p.policy.isPolicyExpenseChatEnabled = true;
p.save();

In OldDot, as the Submitter, create a report & add an expense to it, then submit the report.

As the approver, log in to both OldDot & NewDot in separate tabs

As the approver, in OldDot, "Approve & Forward" the report

Verify that in NewDot, the report action approved $<amount shows up live both in the report & in the LHN

While in OldDot the report action reads "Approved and forwarded to ..." but we agreed we just want it to say approved $<amount in NewDot.

For the report action item, right-click the item and click on Copy to clipboard. Verify on paste it shows approved $<amount.

$250 approved for @mananjadhav

Awesome, thanks Manan!


fix: exclude AWS common rule

Summary
The GenericRFI_QUERYARGUMENTS rule is blocking login with Google accounts.
Related #142

What specifically is being sent as a query param that is being blocked?
Also I'm curious if we have something in place that will protect us from the attacks we are potentially opening ourselves to by disabling this rule, or if we even care for this product.
FYI The rule we are disabling does this:

Inspects the value of query arguments and blocks common cross-site scripting (XSS) patterns using the built-in XSS detection rule in AWS WAF. Example patterns include scripts like .

It's failing on the :// in the query params for the Google account sign in callback:
/auth/google?state=${STATE}&code=${CODE}&scope=email%20profile%20openid%20https://www.googleapis.com/auth/userinfo.email%20https://www.googleapis.com/auth/userinfo.profile&authuser=0&hd=cds-snc.ca&prompt=none

Inspects the values of all query parameters and blocks requests attempting to exploit RFI (Remote File Inclusion) in web applications. Examples include patterns like ://.

Currently there's nothing else protecting against this in the app.
Related, we may not need GenericRFI_BODY excluded.  That was a copy/paste pull-in from ListManager that can probably be removed.


Setting make options like -j 8

First, thank you for this great tool.
How can I set command line options for make?

Thanks!
I added such an option in the next version.

As this is issue is closed does it mean that this feature is in the current release version?
Many thanks.

@Andy-Richards no, it's not yet released. Will try to push an update before the end of the year.


Distinguish between normal and dev dependencies.

There is no current way to identify whether a vulnerable dependency only affects the development environment e.g. whether it comes from devDependencies or dependencies in package.json.
We should add a field to the output to present this information, if we can extract it.

I tried adding a column called DevDependency to the output table. Would the below output resolve this issue?

We are thinking of placing the devDependencies in a separate table under the normal dependencies.
So if we identify any dep dependencies, we will print two tables, with the first table containing only main deps, and a second table containing dev deps.

@another-rex probably better to have support for marking "groups" that packages belong to, to support arbitrary groupings and have the default of no group take priority (since that is typically what are considered production dependencies); then in your output you just print-by-group and naturally sort "no group" to the top

@cuixq This might be an interesting starter project to tackle.


TokenResponse.Issued set to Now instead of UtcNow

...in TokenResponse.FromHttpResponseAsync

I'll look at this - using DateTime.Now is almost always a code smell.
In particular, this means any code that tries to check IsExpired may be invalid around a DST transition - in either direction.
I suspect we'll want to add a UtcIssued property, use that everywhere internally, and deprecate Issued... but maintain it for backward compatibility. Urgh.
It might be worth deprecating IClock.Now as well - or at the very least check everywhere it's used internally.

IssuedUtc might be better from a discoverability standpoint since docs/IntelliSense alphabetize, but it does go against the UtcNow/Now convention.

Urgh. It gets worse - this is stored within the authentication store, which will include the DateTime value. Given that two applications could use the same store, one using an old version of the library and one using a new version, we probably need to be able to read from either and store both. Horrible.