Is it possible to use this with home-manager without using flakes?

#29 mentions home-manager, however only when using flakes. I currently have no interest in using flakes, so I hope it's possible to use it with a traditional config.
Thanks :smile:

I don't have a nixos system available at the moment but I think this might be what you are looking for?

Does that indeed apply to home-manager? I'm not very knowledgeable on the Nix language so I have no idea how to translate that to something else

Hi, @hyperspace01!
I don't use home manager. I suggest you first explore the extensions attrset in repl.
nix-repl> t = (import (builtins.fetchGit {
            url = "https://github.com/nix-community/nix-vscode-extensions";
            ref = "refs/heads/master";
            rev = "c43d9089df96cf8aca157762ed0e2ddca9fcd71e";
          })).extensions

nix-repl> t.x86_64-linux.<TAB>
t.x86_64-linux.forVSCodeVersion            t.x86_64-linux.open-vsx-release            t.x86_64-linux.vscode-marketplace-release
t.x86_64-linux.open-vsx                    t.x86_64-linux.vscode-marketplace

If you use overlays.default on nixpkgs, you should have a pkgs.vscode-extensions and other attrsets.
nix-repl> pkgs = import <nixpkgs> {system = builtins.currentSystem; overlays = [overlays.default];}
nix-repl> pkgs.vscod<TAB>
pkgs.vscode                        pkgs.vscode-langservers-extracted  pkgs.vscode-with-extensions
pkgs.vscode-extensions             pkgs.vscode-marketplace            pkgs.vscodium
pkgs.vscode-fhs                    pkgs.vscode-marketplace-release    pkgs.vscodium-fhs
pkgs.vscode-fhsWithPackages        pkgs.vscode-utils                  pkgs.vscodium-fhsWithPackages

Choose the necessary attrset and use like with pkgs.vscode-marketplace;

You forgot ; at the end of line 152.
But I'd try something like:
extensions =
  with (import (builtins.fetchGit {
        url = "https://github.com/nix-community/nix-vscode-extensions";
        ref = "refs/heads/master";
        rev = "c43d9089df96cf8aca157762ed0e2ddca9fcd71e";
  })).extensions.x86_64-linux; [
  vscodevim.vim
 ];

@hyperspace01 , you'll be more productive if you study the Nix language basics
https://nixos.org/manual/nix/stable/language/constructs.html#language-constructs

Alright, thanks a lot everyone!


Epic/SR-2 - Fall 2024 SpringRoll maintenance

SpringRoll 2.7.0 release

Updated base Node version in nvmrc and workflows to 20
Dependabot update: Bump follow-redirects from 1.15.2 to 1.15.6
Bellhop updated to 3.6.0

Ticket: https://pbskids.atlassian.net/browse/SR-12

Hey folks, I had to re-add 14.x to the node version list in the workflow. The PR wasn't able to merge until that check ran. I'm guessing it's because the workflow on the main branch still has 14.x but since it wasn't in the updated workflow it was just hanging.

@deycorinne are those checks configured under branch protections? Can you check and see if it can be removed?

Ooh good call I do see it under branch protections. I can remove the 14.x one and add a 20.x one

Branch protections should be updated now!
Thanks @selenaqian I've removed 14.x from the workflow, and it seems to be good now!


Addressing 4 flaky tests in fastjson1-compatible

What this PR does / why we need it?
This PR fixes the issues captured in https://github.com/alibaba/fastjson2/issues/2029
Summary of your change

As elaborated in the above mentioned issue, The assertions performed in the 4 tests are asserting on JSON data but the order of elements between the anticipated JSON and generated JSON varies.

The 4 identified tests are :

com.alibaba.fastjson.issue_2100.Issue2182#test_for_issue.
com.alibaba.fastjson.issue_2400.Issue2447#test_for_issue.
com.alibaba.fastjson.issue_1100.Issue1177_1#test_for_issue.
com.alibaba.fastjson.issue_2400.Issue2428#test_for_issue.

This leads to the assertion failing non-deterministically as the order of elements does not remain consistent.

In order to address this issue and carry out the validation on both the presence and order of elements in the JSON object, we can use the JSONAssert instead of plain string assertion.

The biggest advantage of JSONAssert is the ability to configure the assertion to check not only the components but also their order.

Usage of JSONAssert will require the org.skyscreamer.jsonassert.JSONAssert dependancy and the necessary changes have been made in pom.xml

Please indicate you've done the following:

[X] Made sure tests are passing and test coverage is added if needed.
[X] Made sure commit message follow the rule of Conventional Commits specification.
[X] Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (885f3d4) 75.26% compared to head (75c57d2) 73.56%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2030      +/-   ##
============================================
- Coverage     75.26%   73.56%   -1.71%
+ Complexity    21547    20824     -723
============================================
  Files           634      622      -12
  Lines         85248    84500     -748
  Branches      18882    18678     -204
============================================
- Hits          64166    62161    -2005
- Misses        13163    14379    +1216
- Partials       7919     7960      +41

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thank you @wenshao !


Ensure w_botline is valid in getwininfo()

This is needed to make sure we're not returning stale information to the
user.

I think it is better to put the test in test_bufwintabinfo.vim


Fix simple typo: misbehaviors -> misbehaviours

There is a small typo in README.rst.
Should read misbehaviours rather than misbehaviors.

This is a nitpick, but that's not a typo. That's the American spelling.


Add Tailwind CSS example

Add Tailwind CSS example. Please review/merge.

Hi @yuyaohshimo! This is really cool, but there already is a Tailwind example. Does that not suit your needs?

Hi @EmilTholin! I wanted to use Tailwind CSS with Webpack.

Are you saying the current tailwind example isn't implemented correctly?

At the very least, the PR needs to pass linting. Let's get that taken care of.

Are you saying the current tailwind example isn't implemented correctly?

No, but I thought the current Tailwind example isn't compiled by Webpack.

https://github.com/nozzle/react-static/blob/master/examples/glamorous-tailwind/package.json#L10

According to above script, the current Tailwind example is compiled by postcss-cli instead of Webpack:

True
On Mon, Dec 18, 2017 at 8:07 PM yuyaohshimo<EMAIL_ADDRESS>wrote:

Are you saying the current tailwind example isn't implemented correctly?
No, but I thought the current Tailwind example isn't compiled by Webpack.
https://github.com/nozzle/react-static/blob/master/examples/glamorous-tailwind/package.json#L10
According to above script, the current Tailwind example is compiled by
postcss-cli instead of Webpack:
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nozzle/react-static/pull/236#issuecomment-352626701,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCfkFLXXdKThzYr3GIgdwGNsJwWbfks5tByiDgaJpZM4Q_Vkr
.

@tannerlinsley
I fixed linting in the commit.


escape example URLs

CATS used an allow list to exclude example links and other non-clickable links from 404 reports. The new broken link report doesn't support an allow list, so this PR is to escape example links as inline code.

@meganbradley : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Fixed version parsing for Minecraft 1.10

This fixes the version parsing code expecting a single digit.
I also cleaned up a bunch of the code since there were inconsistencies with indents, among other things.
@mkremins I removed the build status image on the README since I do not host a CI server anymore.  It would be helpful if you set up Travis CI or an alternative for the project.  If you do, let me know and we can make it deploy to my repository automatically.  For now, I have deployed the version manually for people to use.

Alright, sounds good – thanks for contributing!
I might look into setting up my own CI for Fanciful at some point in the near future, but it's a low priority for me. Fanciful is becoming increasingly obsolete due to the switch away from CraftBukkit, and I haven't played Minecraft in years now, so my understanding of what else people might want out of the library is limited at best. It might be time to sunset Fanciful entirely, or maybe to start looking for an additional maintainer or two who can respond to requests more effectively.

Just to follow up, Fanciful is now set up on Travis CI.


Added functionality to start the first app in the list with the Return Key

A bit more convenient then switching to your mouse

Sorry, I've already done something similar on the cleaning branch. Instead of redefining the gdk.KEY_Page_Up behaviour, I decided to grab focus by either the first pinned item (if any), or the first app button. See https://github.com/nwg-piotr/nwg-drawer/commit/b0852f76801d980782d3bbe7c3a8929e88ab2959


All machine readable output "Lists" should use Kind: List

[kind/Enhancement]

Which functionality do you think we should update/improve?
There are some json machine output commands that are not using the correct List for example:

odo catalog list services uses ServiceTypeList
odo catalog list components uses ComponentTypeList
odo application list uses ApplicationList

These should be List
Why is this needed?
To follow Kubernetes standards.

/unassign @cdrage
/kind feature
/area json-output

This issue is marked for clean up, so lets get that removed or it will close

/remove-lifecycle rotten

These should be List

What List?
@cdrage point to the place where is being done correctly?

I think maybe @cdrage meant something on the lines of https://github.com/kubernetes/kubectl/blob/9fae31af80294050f1480951b7fae1ababad9c1a/pkg/cmd/get/get.go#L764 .
I had been thinking that maybe this issue asks me to remove the types like project/ProjectLIst , component/ComponentList, catalog/ServiceTypeList etc... ( I think I got confused by the kind/cleanup label on this issue. )  and then use the k8s.io/apimachinery/corev1.List or metav1.List  type wherever those List types are being computed.
Now, after reading "readable output" in the Issue's title, maybe the intention is to just the print resources Lists ... as  k8s.io/apimachinery/corev1.List or metav1.List instead of our self defined types like ProjectList , AppList, etc...
I was confused why should these List types be cleaned up since these are being used in other standard projects like k8s/client-go, openshift/client-go and kubectl as well..but then I realised maybe this is only about the aspect of machine readable output and not all other processing logic.
I might be wrong even now but this is my fresh look on this issue.

You've got it completely correct. Yes. The point is to convert simply the name ComponentList, ServiceTypeList to just "List".
And then within "List" we use ListMeta and list each component, servicetype, etc.


When load is called, currentPage is not updated, but renderPage(1) is called.

This has been fixed in the following fork:
https://github.com/jordanchapian/angular-pdf-viewer

Hi!,
any chance of fixing this bug in this repo?.
Thank you very much!
Regards.


could not open pbi file

Dear PacBio,
We have had 4 lanes of data, so I samtools merged these 4 lanes. Sorted and indexed this file. I sorted and indexed a bam file resulting from the mapping from minialign. When I run ppbam, I consistently get the following error:
ERROR: could not open PBI file: /sub.sorted.bam.pbifor reading
commands:
$ minialign -t8 -xont final.fasta > temp.sam
$ samtools view -@ 8 -S -b -o unsorted.bam temp.sam
$ samtools sort -@ 8 unsorted.bam sorted_mini
...   samtools merge ALL_SUBREADS.bam
$ samtools sort -@ 4 Hs.subreads.bam sub.sorted
$ samtools index sub.sorted.bam
$ pbbamify --input=sorted_mini.bam --output=sorted_mini.pb.bam final.fasta sub.sorted.bam
$ pbbamify --version
0.18.0
Please can you help me?
regards,
Peter Thorpe

Hi Peter,
Does your dataset (sub.sorted.bam) have a .pbi index associated with it?
It looks like Pbbamify cannot locate it. Can you try generating it using the pbindex tool?
Best regards,
Ivan.

Thanks you very much for the reply Ivan.
I have 4 flow cells of data which I merged (samtools merge).  If I index this (like you suggested I get the following error when running pbbamify.
 ERROR: read group ID not found

However, if I index a single cell's data and use this single data set, pbbamify does work.
So can I merge all the data? I need it all to achive the coverage for Arrow, right?
regards,
Peter Thorpe

Hi Peter,
May I suggest that instead of merging the BAMs, you try creating a PacBio dataset from all the input SMRT cell runs? Pbbamify can read that, and it would simplify your process.
For example:
dataset create mydataset.xml subreads1.bam subreads2.bam subreads3.bam ...

Then use mydataset.xml instead of sub.sorted.bam in the example you shared above.
Best regards,
Ivan.

Thank you very much for your help with this! I really appreciate it. :+1:  (I didnt know I could do that)
cheers,
Pete

Dear Laguda,
I am a user and nothing to do with PacBio. Can you give more detail on how it failed? So you know, this pbamify approach does work for me, do keep trying it is worth it.

From: laguda-1996<EMAIL_ADDRESS>Sent: 26 November 2018 04:25:21
To: PacificBiosciences/pbbam
Cc: Peter Thorpe; State change
Subject: {Disarmed} Re: [PacificBiosciences/pbbam] could not open pbi file (#21)
Dear PacBio:
I have a similar problem. I want to convert the. BAM file into the. pb. BAM format that is exclusive to pacbio. I used the pbbamify software with the following instructions:
pbbamify --output=SRR8180828.pb.bam /home/dsy/hisat2/genome_tran/GCF_000005845.2_ASM584v2_genomic.fna /home/dsy/hisat2/SRR8180828.bam.
But it can't run. There's no response. Do you have any suggestions?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://github.com/PacificBiosciences/pbbam/issues/21#issuecomment-441621189, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJhCqDo1HU6ux_jOk51FdHaiVzGsBr6Oks5uy92xgaJpZM4VdHYs.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/PacificBiosciences/pbbam","title":"PacificBiosciences/pbbam","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/PacificBiosciences/pbbam"}},"updates":{"snippets":[{"icon":"PERSON","message":"@laguda-1996 in #21: Dear PacBio:\r\nI have a similar problem. I want to convert the. BAM file into the. pb. BAM format that is exclusive to pacbio. I used the pbbamify software with the following instructions: \r\npbbamify --output=SRR8180828.pb.bam /home/dsy/hisat2/genome_tran/GCF_000005845.2_ASM584v2_genomic.fna /home/dsy/hisat2/SRR8180828.bam.\r\n\r\nBut it can't run. There's no response. Do you have any suggestions?"}],"action":{"name":"View Issue","url":"https://github.com/PacificBiosciences/pbbam/issues/21#issuecomment-441621189"}}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/PacificBiosciences/pbbam/issues/21#issuecomment-441621189", "url": "https://github.com/PacificBiosciences/pbbam/issues/21#issuecomment-441621189", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [PacificBiosciences/pbbam] could not open pbi file (#21)", "sections": [ { "text": "", "activityTitle": "laguda-1996", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@laguda-1996", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n"commandName": "IssueComment",\n"repositoryFullName": "PacificBiosciences/pbbam",\n"issueId": 21,\n"IssueComment": "{{IssueComment.value}}"\n}" } ] }, { "targets": [ { "os": "default", "uri": "https://github.com/PacificBiosciences/pbbam/issues/21#issuecomment-441621189" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n"commandName": "MuteNotification",\n"threadId": 359953964\n}" } ], "themeColor": "26292E" } ]

Hi @laguda-1996,
Is your FASTA file indexed? (i.e. using samtools faidx)? If not, please try that and give it another go.
If that's not the problem, can you paste the error message here?
Thanks.

Derek

Dear Laguda, I am a user and nothing to do with PacBio. Can you give more detail on how it failed? So you know, this pbamify approach does work for me, do keep trying it is worth it.
…
________________________________ From: laguda-1996<EMAIL_ADDRESS>Sent: 26 November 2018 04:25:21 To: PacificBiosciences/pbbam Cc: Peter Thorpe; State change Subject: {Disarmed} Re: [PacificBiosciences/pbbam] could not open pbi file (#21) Dear PacBio: I have a similar problem. I want to convert the. BAM file into the. pb. BAM format that is exclusive to pacbio. I used the pbbamify software with the following instructions: pbbamify --output=SRR8180828.pb.bam /home/dsy/hisat2/genome_tran/GCF_000005845.2_ASM584v2_genomic.fna /home/dsy/hisat2/SRR8180828.bam. But it can't run. There's no response. Do you have any suggestions? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub<#21 (comment)>, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJhCqDo1HU6ux_jOk51FdHaiVzGsBr6Oks5uy92xgaJpZM4VdHYs. {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/PacificBiosciences/pbbam","title":"PacificBiosciences/pbbam","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"[https://github.com/PacificBiosciences/pbbam"}},"updates":{"snippets":{"icon":"PERSON","message":"@laguda-1996 in #21: Dear PacBio:\r\nI have a similar problem. I want to convert the. BAM file into the. pb. BAM format that is exclusive to pacbio. I used the pbbamify software with the following instructions: \r\npbbamify --output=SRR8180828.pb.bam /home/dsy/hisat2/genome_tran/GCF_000005845.2_ASM584v2_genomic.fna /home/dsy/hisat2/SRR8180828.bam.\r\n\r\nBut it can't run. There's no response. Do you have any suggestions?"}],"action":{"name":"View Issue","url":"#21 (comment)"}}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#21 (comment)", "url": "#21 (comment)", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [PacificBiosciences/pbbam] could not open pbi file (#21)", "sections": [ { "text": "", "activityTitle": "laguda-1996", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@laguda-1996", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n"commandName": "IssueComment",\n"repositoryFullName": "PacificBiosciences/pbbam",\n"issueId": 21,\n"IssueComment": "{{IssueComment.value}}"\n}" } ] }, { "targets": [ { "os": "default", "uri": "#21 (comment)" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n"commandName": "MuteNotification",\n"threadId": 359953964\n}" } ], "themeColor": "26292E" } ]

Thank you very much for your help firstly.
I want to use isoseq3, which comes from https://github.com/PacificBiosciences/IsoSeq3.
To run this software, you first need the pacbio. bam and pacbio. bam. PBI files.
There seems to be only a few species of files on the Internet(https://downloads.pacbcloud.com/public/dataset/RC0_1cell_2017/), so I want to make these two files myself.
I downloaded the genome file of E. coli and the SRA file of pacbio sequencing from NCBI.
Then I used the comparison software hisat2 to generate Sam files and convert them into BAM files.Then I use the pbbamify instruction:  pbbamify --output=SRR8180828.pb.bam /home/dsy/hisat2/genome_tran/GCF_000005845.2_ASM584v2_genomic.fna /home/dsy/hisat2/SRR8180828.bam
"/home/dsy/hisat2/genome_tran/GCF_000005845.2_ASM584v2_genomic.fna",this is the genome file I downloaded, which is also the file used when comparing hisat2.
"/home/dsy/hisat2/SRR8180828.bam",this is the bam file I generated using hisat2.
But I entered this instruction without any response.

Hi @laguda-1996,
Is your FASTA file indexed? (i.e. using samtools faidx)? If not, please try that and give it another go.
If that's not the problem, can you paste the error message here?
Thanks.
* Derek

Thank you very much for your answer.
My fasta file has no index.Is the index of the fasta file used in the following command or the index is used in the comparison software (I use hisat2 to generate the bam file)?
pbbamify --output=SRR8180828.pb.bam /home/dsy/hisat2/genome_tran/GCF_000005845.2_ASM584v2_genomic.fna /home/dsy/hisat2/SRR8180828.bam
I will first try to generate an index using the method you gave.
At the moment, the situation I encountered was that the input song command did not respond, it did not throw any errors.But when I want to close this terminal, this terminal shows that there is still a process running on the terminal.I typed top to see the CPU usage and it really didn't work.


Lastpass Import

Hi thanks for the program. Here's a little script to mung LastPass export into required format
#!/usr/bin/python
from __future__ import annotations
import csv
import os.path
import sys
from io import StringIO
from pathlib import Path
from urllib.parse import ParseResult, urlparse, urlunparse

from bs4 import BeautifulSoup

def main() -> None:
    path = Path(sys.argv[1])
    soup = BeautifulSoup(path.read_text(), 'html5lib')
    src_rows = csv.DictReader(StringIO(soup.find('pre').text))
    dst_rows = []

    for src_row in src_rows:
        if not src_row['password']:
            continue
        url = src_row['url']
        result = urlparse(url)
        if not result.netloc:
            continue
        hostname = urlunparse(
                ParseResult(result.scheme, result.netloc, '', '', '', ''))
        dst_rows.append({
            'hostname': hostname,
            'formSubmitURL': url,
            'username': src_row['username'],
            'password': src_row['password'],
        })

    with open(path.with_suffix('.csv'), 'w') as file:
        writer = csv.DictWriter(file, ['hostname', 'formSubmitURL', 'username',
                                       'password'])
        writer.writeheader()
        writer.writerows(dst_rows)

if __name__ == '__main__':
    main()

That's super nice of you.
I may include it as another command line like the chrome extractor when I get some time.

@dj-foxxy Quick question, since your extraction doesn't contain 'usernameField' and 'passwordField', does the 'login autocompletion' with autofilling ?

@avallete The lastpass export didn't contain that data, however, the imported creds have been autocompleted.

Lastpass import feature done here: #7 into lastpass_exporter.py script.
I've changed the approach to only handle .csv extraction from lastpass (since it is possible to extract to csv and that is the default export type from the web interface, plus, it prevent from adding the new beautifulsoup dependency).


my modifications

Hi @irustm. I made some changes. Summary:

stripped out the README. don't worry. i'll add content back in later
i renamed the component's class to FullCalendarComponent (it was CalendarComponent). this is more consistent with the module name FullCalendarModule
i rearranged the location of the some of the files in projects/fullcalendar/src/lib/calendar
i added a bunch of build scripts. don't worry about them too much. they will change soon. are you okay with some of them being bash? are you able to run them?

questions:

for me, the tests are hanging in the Chrome browser that pops up. this happens even before i started making changes. is it happening to you?

example project:

please take a look at my new example project: https://github.com/fullcalendar/fullcalendar-example-projects/tree/master/angular/src/app
in your example project (https://github.com/ng-fullcalendar/ng-fullcalendar4-demo), where are you including fullcalendar's styles? i couldn't figure that out

if you like my changes, please merge. if you have questions, please let me know.
-adam

let me clarify: npm run e2e works well, but npm run test hangs

@arshaw styles in angular.json config
https://github.com/ng-fullcalendar/ng-fullcalendar/blob/v3/angular.json#L31


Declare dependencies we use, drop unused dependencies

For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

I left this un-squashed as a way to track the individual project changes as I iterated through each project's transitive dependencies to the others.


[Feature request] Allow docker:dind in pipeline

Docker in docker (dind) needs to run with --privileged which is not an option as of now. With dind we could do some advanced stuff with docker like leverage caching #16223 #16198 or push multiple images during a build. This could widely extend the possibilities of Rancher pipeline.

I think the best way would be to introduce a new step type for dind to have managed environment.


Map tooltip bus

Description
resolve #84
add a nice tooltip with info about the bus.
with an option to see the old JSON .
screenshots
with style card
on mobile

Desktop

with old json

:partying_face: :balloon:


Save Attachments implementation

Need to implement saving of attachments with statements.

@brianjmiller Any plans on adding support for attachments to this library? I'm prototyping something and could use it. Thanks for any info!


Temp tables staying in database

Hi Borris. I noticed periodically in my code that the temp tables the Bulk insert creates end up not being dropped. the thing that bothers me, is that I now have a piece of code where it happens every time, what is the solution?

I need example of it.
Can you add full snipped code where it is happening or maybe create some small test project with that code, share it somewhere and send a link.
Btw when creating an issue it should include steps to reproduce behavior:
creating-an-issue
how-we-write--issues

Okay I will


Fix terminology

We use package everywhere even though non-command packages are a non-goal -- we should fix that.

Eh, I guess repo.Pkg is good enough for now.


experimentalUseProvidedRuntime not effected when running "npm run deploy"

Recently I've been using SST to develop an serverless application, using Quarkus, which is a Java Framework, to develop lambda function code.
In order to provide a better performance, Quarkus provides an ability to build function to native image, which can be used with provided/ provided.al2 runtime in lambda instead of java runtime.
Following experimentalUseProvidedRuntime docs, I tried to config with provided/provided.al2 runtime,  here is the configuration of a function in an API
const api = new Api(context.stack, "api", {
    routes: {
        "POST /app": {
            function: {
                runtime: "java11",
                java: {
                    experimentalUseProvidedRuntime: "provided.al2"
                },
                handler: "io.quarkus.amazon.lambda.runtime.QuarkusStreamHandler::handleRequest",
                environment: {
                    "QUARKUS_PACKAGE_TYPE": `native`
                }
            }
        }
    }
}

but it seems not working. When run npm run deploy, lambda function still configured with Java11 runtime
After reading some source code of SST, it seems that provided runtime is not supported any more?

sst/constructs/Function.js

/*
if (isJavaRuntime) {
  const providedRuntime = (bundle as FunctionBundleJavaProps)
    .experimentalUseProvidedRuntime;
  if (providedRuntime) {
    cfnFunction.runtime = providedRuntime;
  }
}
*/

If so, how can I use provided runtime or is it impossible? Please let me know.

Hmm that's weird.

@ljd1991 I brought the code back in #3314.
The ability to use user provided runtime for Java was contributed by the community. I don't have a setup at hand to test it.
Can you give v2.25.3 a try, and see if it works.

@ljd1991 I brought the code back in #3314.
The ability to use user provided runtime for Java was contributed by the community. I don't have a setup at hand to test it.
Can you give v2.25.3 a try, and see if it works.

hello @fwang, I tried with v2.25.3 and provided runtime is configured properly. Thanks for the work~
I still wonder why are these codes excluded in the first place, were there any bugs related to these codes?

Awesome.
Looks like the code was commented out when SST went from v1 to v2. No it wasnt intentional.

We are transition this repo to https://github.com/sst/v2 and are closing this issue for now. If it is still relevant please reopen it there - sorry for the trouble


Member details ENS/Ethereum address display font typeface

ENS/Ethereum address is not displaying correctly on the members details page.
Ethereum Address:

ENS:

Looks to be affecting Neon only. Perhaps we need a line-height added to the styles.

I'll fix this in Neon today when I do another upstream sync and deploy for it. I had to fix some other similar style bugs with it yesterday. Neon has some little quirks that aren't consistent with all the other DAO styles. Not sure why that is.


Automated cherry pick of #258: - etcd clean failed state pods

Cherry pick of #258 on release/3.4.
#258: - etcd clean failed state pods

/lgtm
/approve


diablo-nx not launching in Yuzu (tracking issue)

Since I'm making commits to Yuzu (Switch emulator) I will be looking into this. For context I think it will be easier to debug from this side than emulator-side. I'll create a sister issue for them as well once I figure out how to compile and rule out anything dumb such as not checking the right directory.
Steps

Copied DIABDAT.MPQ and contents of diablo-nx.zip to AppData\Roaming\yuzu\sdmc\switch\diablo-nx.
In Yuzu (master), File -> Load File... -> diablo-nx.nro.
Yuzu shows loading bar for 1s, followed by game immediately closing back to the rom list.

Notes

Does create a diablo.ini in yuzu\sdmc, so it is doing something before closing.

Issues

[ ] NRO game title/header metadata is missing.
[ ] Game immediately closes.

Switch support has been up streamed and is being maintained there: https://github.com/diasurgical/devilutionX it has both multiplayer, widescreen and 60fps support and should work with the emulators as well.


Don't get into itemBuilder if itemsLength == 0

It breaks when itemsLength == 0, because it goes into itemBuilder, and then try to access index which doesn't exist...

This isn't a problem in the package, since it's safely guarded here https://github.com/Bdaya-Dev/circular-widgets/blob/master/lib/src/circular_widgets.dart#L31
I think the problem is in your code, you have to rebuild the CircularWidgets widget when the length changes (using Provider or StreamBuilder for example)


Fix #90: escape column name in Ranker#rearrange_ranks

This PR fixes #90. Now usage of keyword column name does not produce SQL syntax error anymore in Ranker#rearrange_ranks method.
Summary:

fix Ranker#rearrange_ranks SQL syntax error when column name is SQL keyword;
implement special test case which reproduces #90;
QA this change for MySQL, PostgreSQL and SQLite.

@mixonic I can see that the build fails for some of the platforms. I'm wondering what could be a better way to fix this issue? I personally don't like my solution, but it works for me (I use PostgreSQL in my project). If you could help to figure out a better fix, I can do this on the weekend.

@mkalygin hm odd, many of the test failures are for Postgres and ActiveRecord 4.
This failure (https://travis-ci.org/mixonic/ranked-model/jobs/341197781) seems like we're not loading the right gem:
4.1.16/lib/active_record/connection_adapters/connection_specification.rb:190:in `rescue in spec': Specified 'postgresql' for database adapter, but the gem is not loaded. Add `gem 'pg'` to your Gemfile (and ensure its version is at the minimum required by ActiveRecord). (Gem::LoadError)

Perhaps something has changed on Travis and we were relying on a gem that was pre installed.

FWIW this approach looks great to me 👍 really excellent.

@mixonic awesome, so what should I do in order to make it merged? I had similar issues working locally BTW. I just installed what worked for me to make a test and was wondering is it only me or not.
This https://github.com/mixonic/ranked-model/pull/118 fixes this issue as far as I can see. Maybe it should be merged before everything else.

@mixonic any updates on this bug? Wish to use official release instead of my own custom branch.

i think it should be escaped also in `update_rank!'
got the error there
lib/ranked-model/ranker.rb

@dedekm I'm not sure that this gem is actively supported... So I would fork, fix the bug and use your own branch instead of official release.

It is supported. Let's look into this again. I can merge your changes.
Is it possible to do this query as a hash rather than with a string in Rails?

@brendon what do you mean by "hash"? The column name should be escaped, but it really depends on the database adapter used by the ActiveRecord. I'm willing to finish this PR, let me know what should we do here in order to merge it.

Hi @mkalygin, you can pass a hash to update_all rather than a string and then let Rails do the escaping. I'm not 100% sure if that works for self-referencing values though. I'm currently working on #130 which affects the code you've changed so I'll try to get that merged today for you to work from there.

@brendon awesome, just ping me whenever the code is ready and I'll fix this bug from there.

Thanks @mkalygin, I've just merged my fixes into master so you can go ahead now :)

@brendon I've investigated an ability to use a hash instead of a string. And I think there is no cleaner way to do it, since it contains self reference to the same column.
E.g. update_all(ranker.column => "#{ranker.column} + 1") won't work, since it will try to set a string as the column value.
There is no short and easy to read solution with Arel either. And I wouldn't use Arel's UpdateManager here, since this query is trivial.
So I think a solution I already have should be good here. I've also resolved conflicts with master branch.

Thanks @mkalygin :) I'll merge this now :)


index out of range panic

Summary
I had a crash of node, logs attached
Steps to reproduce
https://pastebin.com/raw/rVnHAVt1
https://pastebee.com/?05a3568672967385ab32a1ea0154a53596cc50ad188cc2116d5d1754f1b022e0
Expected behavior
node isn't crashing
Actual behavior
node is crashing

Thanks for reporting this! We will have a look at this. Did you apply any special (non-default) configuration of your node? How did you install and run Bee? What version of Bee were you running?

45c179bbcd6ae0ae1df1d7d29be4004763af6a10f7b8: context deadline exceeded
panic: runtime error: slice bounds out of range [:16] with capacity 0

goroutine 5550134 [running]:
github.com/ethersphere/bee/pkg/localstore.New.func4(0xc009e12639, 0x20, 0x27, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	github.com/ethersphere/bee/pkg/localstore/localstore.go:233 +0xd1
github.com/ethersphere/bee/pkg/shed.Index.Get(0xc00040f5f0, 0xc000295c30, 0x1, 0x1, 0xc000c4fd40, 0xc000c77770, 0x16fbf78, 0x16fbf80, 0xc009e12639, 0x20, ...)
	github.com/ethersphere/bee/pkg/shed/index.go:154 +0x26d
github.com/ethersphere/bee/pkg/localstore.(*DB).setSync(0xc00010d800, 0xc00a57f840, 0xc009e12639, 0x20, 0x27, 0x0, 0x20, 0x40, 0xc800000000000000)
	github.com/ethersphere/bee/pkg/localstore/mode_set.go:134 +0x178
github.com/ethersphere/bee/pkg/localstore.(*DB).set(0xc00010d800, 0x0, 0xc0088faec0, 0x1, 0x1, 0x0, 0x0)
	github.com/ethersphere/bee/pkg/localstore/mode_set.go:64 +0x1af
github.com/ethersphere/bee/pkg/localstore.(*DB).Set(0xc00010d800, 0x185bd60, 0xc009942d80, 0x0, 0xc0088faec0, 0x1, 0x1, 0x0, 0x0)
	github.com/ethersphere/bee/pkg/localstore/mode_set.go:38 +0xf3
github.com/ethersphere/bee/pkg/pusher.(*Service).chunksWorker.func2(0xc000374f20, 0xc00000e4d0, 0xc000262c18, 0xc000cce180, 0xc0002ee360, 0x185bd60, 0xc009942d80, 0x1865e60, 0xc0062e2a00)
	github.com/ethersphere/bee/pkg/pusher/pusher.go:166 +0x248
created by github.com/ethersphere/bee/pkg/pusher.(*Service).chunksWorker
	github.com/ethersphere/bee/pkg/pusher/pusher.go:130 +0x68d


overrideProximityRange | MumbleSetTalkerProximity Causing audio drop off

Describe the bug
A clear and concise description of what the bug is.
Using 'overrideProximityRange' causes a drop off in audio at the last defined proximity range. For example if I had a cycled proximity range of 2.0 and I then use overrideProximityRange(5.0, false), the players listening will hear the audio now drop (not fade out) at the proximity range of 2.0.
To Reproduce
Steps to reproduce the behavior:

Use native audio
Cycle through the configured proximity ranges. Proximity distance will function as normal.
Call the export overrideProximityRange(5.0, false)
Listening players will have the audio drop at the last set proximity range for that player

Expected behavior
Proximity range should increase to the specified value and the audio should fade as the player gets closer to the edge of the specified distance.
Server Info:

Server Version: 5326
Client Version: canary
Client Build: b2372
Game: FiveM

Additional context
The issue looks to be related to the MumbleSetTalkerProximity. Checking MumbleGetTalkerProximity I can confirm the specified value set in overrideProximityRange is passed through. What makes this even stranger is the fact that if you add a forth proximity range to Cfg.voiceModes this forth proximity functions as expected.

Something to note - NetworkSetTalkerProximity seems to work fine and doesn't cause this unexpected drop off in hearing distance, however it's probably not a good idea to mix & match the Network/Mumble natives.

Just here to say 'Can confirm' @AvarianKnight. C'mon man work

Are you guys having this issue specifically with the megaphone paid resource? I have it too with it. It's really weird, I don't think it makes any sense to be the native's fault but a resource fault. Why would the same native setter not work with completely valid data just because the value is not added to Config.voiceModes?

Yes, I created my own megaphone using this export and it does the same thing described here. Tested it and checked with MumbleGetTalkerProximity and it does show the correct range. I don't know why it still uses the Config.voiceModes modes instead of a custom one.

Are you guys having this issue specifically with the megaphone paid resource?

The megaphone paid resource? Are people really trying to monetize something so simple that can be implemented in a few minutes of work?

@AvarianKnight Circling back on this. Can

Didn't mean to close this


Chocolatey package fails when running Boxstarter with Packer

When running the following provisioner with packer the installation of chocolatey package VisualStudio2013ExpressWeb and git.install fails (while other chocolatey packages run without issues).
The provisioner does the following:
{
      "type": "powershell",
      "inline": [
        "$ErrorActionPreference = \"Stop\"",
        "$env:chocolateyVersion = \"<IP_ADDRESS>\"",
        "iex ((new-object net.webclient).DownloadString('https://chocolatey.org/install.ps1'))",
        "cinst boxstarter -y",
        "& \"${env:AppData}\\Boxstarter\\BoxstarterShell.ps1\"",
        "$result = Install-BoxstarterPackage -PackageName c:\\Packerfile.ps1 -DisableReboots",
        "$result",
        "if ($result.Errors.Length -gt 0) { exit 1 }",
        "c:\\sysprep.ps1"
      ]
}

And Packerfile.ps1 has the following content:
cinst VisualStudio2013ExpressWeb
cinst git.install

It fails with an Unable to run scheduled task :
++ Boxstarter starting Calling Boxstarter's vendored Chocolatey to install VisualStudio2013ExpressWeb. This may take several minutes to complete...

Chocolatey (v<IP_ADDRESS>) is installing 'VisualStudio2013ExpressWeb' and dependencies. By installing you accept the license for 'VisualStudio2013ExpressWeb' and each dependency you are installing.
DotNet4.5.1 v<IP_ADDRESS>40606
Microsoft .Net 4.5.1 Framework is already installed on your machine.
VisualStudio2013ExpressWeb v12.0.21005.20150920

Downloading VisualStudio2013ExpressWeb 32 bit from 'http://download.microsoft.com/download/B/B/2/BB2AB17F-7BF1-477B-8BD5-488C843F122B/vns_full.exe'
Finished installing 'VisualStudio2013ExpressWeb' and dependencies - if errors not shown in console, none detected. Check log for errors if unsure.
++ Boxstarter finished Calling Boxstarter's vendored Chocolatey to install VisualStudio2013ExpressWeb. This may take several minutes to complete... 00:00:16.9417204
ERROR: The system cannot find the file specified.
Write-Error : VisualStudio2013ExpressWeb did not finish successfully. Boo to the chocolatey gods!
-----------------------
[ERROR] Unable to run scheduled task. Message from task was
-----------------------
At C:\Users\packeradmin\AppData\Roaming\Boxstarter\Chocolatey\chocolateyinstall\helpers\functions\Write-ChocolateyFailure.ps1:30 char:3
+   Write-Error $errorMessage
behaviors that change state without prompting for confirmation. Start
+   ~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorExcep
using it now in your automated scripts.
tion
+ FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorExceptio
n,Write-Error

Write-Error : Package 'VisualStudio2013ExpressWeb v12.0.21005.20150920' did not install successfully: Unable to run scheduled task. Message from task was

When running the same cinst commands directly from packer without using boxstarter it installs fine.
Isn't the interception of chocolatey commands just for checking whether reboots are necessary? And wouldn't the DisableReboots option render this intercept unnecessary? I can't find anything about the intercept trying to wrap it in a scheduled task.

Oh interesting. Boxstarter has some "special" logic it uses when running inside of a winrm session. It runs the MSIEXEC via a scheduled task. Boxstarter makes an incorrect assumption that only calls to Install-BoxstarterPackage using -ComputerName, -Session, or -ConnectionURI will be remote and it creates the scheduled task when that condition applies.
Here that assumption is broken because packer "owns" the winrm connection and not boxstarter.
I believe (and will double check) that this is addressed in the next version of boxstarter in progress. You can work around this for now by explicitly creating the Scheduled task first:
$secpasswd = ConvertTo-SecureString "vagrant" -AsPlainText -Force
$credential = New-Object System.Management.Automation.PSCredential ("vagrant", $secpasswd)
Create-BoxstarterTask $Credential
$result = Install-BoxstarterPackage -PackageName c:\\Packerfile.ps1 -DisableReboots
Remove-BoxstarterTask

Thanks! Unfortunately it results in The term 'Create-BoxstarterTask' is not recognized as the name of a cmdlet, even though I execute & "${env:AppData}\Boxstarter\BoxstarterShell.ps1 a couple of lines earlier. This should import the Boxstarter.Common module, right? Any thoughts?

Ah I missed one detail. The Boxstarter.Common module is intended to be internal to boxstarter and its functions are not exposed outwards by default. However if you explicitly import it it should do the trick:
Import-Module "$($Boxstarter.BaseDir)\Boxstarter.Common\boxstarter.common.psd1

Thanks a lot, Matt, I got it working now! And it enables me to use Invoke-FromTask now as well.
Hopefully the next version does away with some of this boilerplate, so the provisioning part becomes a bit more concise. I've put my whole template below, it might help someone get this up and running.
The ticket can be closed, but maybe you need it open to verify this is fixed in the next version? Otherwise feel free to close it.
{
  "variables":
  {
    "gce_account_key_file": "{{env `GCE_ACCOUNT_KEY_FILE`}}",
    "gce_project_id": "{{env `GCE_PROJECT_ID`}}",
    "gce_zone": "{{env `GCE_ZONE`}}",
    "gce_network": "{{env `GCE_NETWORK`}}",
    "gce_use_internal_ip": "{{env `GCE_USE_INTERNAL_IP`}}",
    "gce_source_image": "{{env `GCE_SOURCE_IMAGE`}}",
    "gce_target_image": "{{env `GCE_TARGET_IMAGE`}}-{{env `GO_PIPELINE_LABEL`}}",
    "winrm_username": "{{env `WINRM_USERNAME`}}",
    "winrm_password": "{{env `WINRM_PASSWORD`}}",
    "winrm_timeout": "{{env `WINRM_TIMEOUT`}}",
    "startup_script": "winrm quickconfig -quiet & net user /add {{env `WINRM_USERNAME`}} {{env `WINRM_PASSWORD`}} & net localgroup administrators {{env `WINRM_USERNAME`}} /add & netsh advfirewall firewall set rule name=\"Windows Remote Management (HTTP-In)\" profile=public new remoteip=any & winrm set winrm/config/service @{AllowUnencrypted=\"true\"} & winrm set winrm/config/service/auth @{Basic=\"true\"} & powershell.exe -NoProfile -ExecutionPolicy Bypass -Command \"Set-ExecutionPolicy -ExecutionPolicy bypass -Force\""
  },
  "builders":
  [
    {
      "type": "googlecompute",
      "account_file": "{{user `gce_account_key_file`}}",
      "project_id": "{{user `gce_project_id`}}",
      "zone": "{{user `gce_zone`}}",
      "source_image": "{{user `gce_source_image`}}",
      "machine_type": "n1-standard-2",
      "disk_size": "50",
      "image_name": "{{user `gce_target_image`}}",
      "network": "{{user `gce_network`}}",
      "use_internal_ip": "{{user `gce_use_internal_ip`}}",
      "communicator": "winrm",
      "winrm_username": "{{user `winrm_username`}}",
      "winrm_password": "{{user `winrm_password`}}",
      "winrm_timeout": "{{user `winrm_timeout`}}",
      "metadata": { "windows-startup-script-cmd": "{{user `startup_script`}}" },
      "tags": ["allow-winrm-by-tag"]
    }
  ],
  "provisioners":
  [
    {
      "type": "file",
      "source": "./sysprep.ps1",
      "destination": "c:/sysprep.ps1"
    },
    {
      "type": "file",
      "source": "./entrypoint.ps1",
      "destination": "c:/entrypoint.ps1"
    },
    {
      "type": "file",
      "source": "./Packerfile.ps1",
      "destination": "c:/Packerfile.ps1"
    },
    {
      "type": "powershell",
      "inline": [
        "$ErrorActionPreference = \"Stop\"",
        "$env:chocolateyVersion = \"<IP_ADDRESS>\"",
        "iex ((new-object net.webclient).DownloadString('https://chocolatey.org/install.ps1'))",
        "cinst boxstarter -y",
        "& \"${env:AppData}\\Boxstarter\\BoxstarterShell.ps1\"",
        "Import-Module \"$($Boxstarter.BaseDir)\\Boxstarter.Common\\boxstarter.common.psd1\"",
        "$secpasswd = ConvertTo-SecureString \"{{user `winrm_password`}}\" -AsPlainText -Force",
        "$credential = New-Object System.Management.Automation.PSCredential (\"{{user `winrm_username`}}\", $secpasswd)",
        "Create-BoxstarterTask $credential",
        "$result = Install-BoxstarterPackage -PackageName c:\\Packerfile.ps1 -DisableReboots",
        "Remove-BoxstarterTask",
        "$result",
        "if ($result.Errors.Length -gt 0) { exit 1 }",
        "c:\\sysprep.ps1"
      ]
    }
  ]
}

Where sysprep.ps1 does the following

$ErrorActionPreference = "Stop"

trap
{
    Write-Error $_
    exit 1
}

Function CommandExists()
{
    param
    (
        $command
    )

    $oldPreference = $ErrorActionPreference

    $ErrorActionPreference = 'stop'

    try
    {
        if(Get-Command $command)
        {
            return $true
        }
    }
    catch
    {
        return $false
    }
    finally
    {
        $ErrorActionPreference=$oldPreference
    }
}

# cleanup and sysprep
if ((CommandExists GCESysprep) -eq $true)
{
    # google cloud
    Write-Output "Executing GCESysprep..."

Glad you got it working! I'll keep this open to make sure this gets fixed right.

Matt,
This issue also appears to affect chef on the client node when invoking Install-BoxstarterPackage over winrm through a boxstarter package, since chef also uses winrm.   It would be impacted when called from any "provisioner-like" tool including chef, packer, vagrant, puppet, etc, etc. Plan to address this as soon as v2.6 is released (getting very close).

@nevercast Can you see this message and the following one to see if this fixes your issue?

Not sure if this is still relevant. These days I create my windows vms with just packer version 1.3.5 (using the powershell provisioner), chocolatey 0.10.11 and without boxstarter; seems to work fine over winrm. So for me it's okay to close this issue unless you want to check whether it actually works with latest boxstarter.

Thanks @JorritSalverda


Adjust the 'Organisers' autosuggest to include option to add as free text

During user testing people where confused about using tab to complete their entry as free text. On a tablet, there's no such thing as the tab button so it's impossible to add free text organisers to the field. My suggestion is to add a small link at the bottom of the autosuggest results list that asks the user if they want to add the entry as free text.

Assigning to @oszkarnagy for feedback


worker: Replace "endpoints" with "tablets" in flags and variables.

@alainjobart

This change is

Previously, michael-berlin (Michael Berlin) wrote…
> #### worker: Replace "endpoints" with "tablets" in flags and variables\.
>
> @alainjobart
>
>
>

Reviewed 27 of 27 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


sign_transaction fails with "TypeError: string indices must be integers"

	tx_transfer_signed = b.sign_transaction(tx_transfer, testuser1_priv)
Results in an error:
  File "/usr/local/lib/python3.4/dist-packages/BigchainDB-0.3.0-py3.4.egg/bigchaindb/util.py", line 489, in get_fulfillment_message
    previous_tx = b.get_transaction(fulfillment['input']['txid'])
TypeError: string indices must be integers

Where tx_transfer is:
tx_transfer = {} {
  "id": "c42c55f59ef14840e71dc1df6d93c1a71f78761228164c02200baaf9c52fcfbc",
  "transaction": {
    "conditions": [
      {
        "cid": 0,
        "condition": {
          "details": {
            "bitmask": 32,
            "public_key": "J5c2aiAFQfGMJ2bjhYjncpzM9SbSRk5vYosmuSYYB3hH",
            "signature": null,
            "type": "fulfillment",
            "type_id": 4
          },
          "uri": "cc:4:20:_cSbP2BD6MOB26LBVgUGYHqYfrYi3U_tRQ5DtnRaGog:96"
        },
        "new_owners": [
          "J5c2aiAFQfGMJ2bjhYjncpzM9SbSRk5vYosmuSYYB3hH"
        ]
      }
    ],
    "data": null,
    "fulfillments": [
      {
        "current_owners": [
          "C5T2mqSmZbZA76mFgVYuXeKAY8NCG1dbkHk353pigfm9"
        ],
        "fid": 0,
        "fulfillment": null,
        "input": "ff68f58a7a5dc0cf1be82bac7458380e2404330ff823e0861c4325ea27a5038d"
      }
    ],
    "operation": "TRANSFER",
    "timestamp": "1462428844.375934"
  },
  "version": 1
}

Hi @bitcartel
a few questions:

tx_transfer = {} {...: I am assuming the first curly braces are a typo?
How did you create the transaction?

"fulfillments": [
      {...
        "input": "ff68f58a7a5dc0cf1be82bac7458380e2404330ff823e0861c4325ea27a5038d"
      }
    ],

In the current version 0.3.0 , we support multiple inputs and outputs. Hence the input to a transaction should be of the form
"input": {
    "txid": "ff68f58a7a5dc0cf1be82bac7458380e2404330ff823e0861c4325ea27a5038d",
    "cid": <some integer, in this case 0>
}

For more info, see https://bigchaindb.readthedocs.io/en/latest/python-server-api-examples.html#transfer-the-digital-asset

Oops, typo.  {} fixed now.
Using 0.3.0, commit 2b34c939b20de6cb3c545b89e6b93c428297f03d
Transaction created like this, based on API docs:
	b = bigchaindb.Bigchain()
	testuser1_priv, testuser1_pub = bigchaindb.crypto.generate_key_pair()
	digital_asset_payload = {'msg': 'Hello BigchainDB!'}
	tx = b.create_transaction(b.me, testuser1_pub, None, 'CREATE', payload=digital_asset_payload)
	tx_signed = b.sign_transaction(tx, b.me_private)
	b.write_transaction(tx_signed)
	# wait for asset in loop (sleep, poll)
	tx_retrieved = b.get_transaction(tx_signed['id'])

	testuser2_priv, testuser2_pub = bigchaindb.crypto.generate_key_pair()
	tx_transfer = b.create_transaction(testuser1_pub, testuser2_pub, tx_retrieved['id'], 'TRANSFER')
	tx_transfer_signed = b.sign_transaction(tx_transfer, testuser1_priv)

@bitcartel like @diminator mentioned since version 0.3.0 an input also needs to specify the condition id (since we added support for multiple inputs and outputs).
In your previous code you should replace tx_retrieved = b.get_transaction(tx_signed['id']) with
# Retrieve the transaction with condition id
tx_retrieved_id = b.get_owned_ids(testuser1_pub).pop()

More details here http://bigchaindb.readthedocs.io/en/latest/python-server-api-examples.html#transfer-the-digital-asset

Thanks. Might be worth removing older docs like 0.2 and just keeping 'latest' and the most recent point release.

Also, after creating a tx or transfer and then writing it to bigchaindb, I enter into a loop where I sleep and poll to retrieve the tx.  It takes around 5 seconds each time to retrieve a tx.  It's the same if I create and write multiple tx to bigchaindb, and try to retrieve them all.  Is bigchaindb polling rethinkdb every 5 seconds?  Is that why tx are not retrieved quicker than this?  Is this configurable?

If user1 has received many transactions, are the spendable outputs returned by get_owned_ids() unsorted or in some order e.g. timestamp, most recent tx is at end of list?

The outputs are not ordered.

Also, after creating a tx or transfer and then writing it to bigchaindb, I enter into a loop where I sleep and poll to retrieve the tx. It takes around 5 seconds each time to retrieve a tx. It's the same if I create and write multiple tx to bigchaindb, and try to retrieve them all. Is bigchaindb polling rethinkdb every 5 seconds? Is that why tx are not retrieved quicker than this? Is this configurable?

The 5 seconds is an hardcoded timeout in the block creation method. What we do is try to bundle up to 1000 transactions per block for performance reasons, so when a node is creating a block and if has fewer then 1000 transactions it waits up to 5 seconds for new incoming transactions. That is the reason for the wait. We do this to avoid creating a lot of small blocks if the transactions are coming in at a slow pace. We will be looking at ways to optimize this timeout (or possibly remove it).

relates to #427
Closing this since all questions seemed to have been answered


Community Meeting February 22, 2022

At 11am Eastern, 8am Pacific, 3pm UTC; find your time
Video call link: https://meet.google.com/ohf-kwvd-mrp
Or dial: (US) +1<PHONE_NUMBER> PIN: 936<PHONE_NUMBER>#
More phone numbers: https://tel.meet/ohf-kwvd-mrp?pin=9361820877398
Or join via SIP<EMAIL_ADDRESS>Meeting recordings available on YouTube at https://www.youtube.com/channel/UCfP_yS5uYix0ppSbm2ltS5Q
This issue will collect prospective agenda topics. Add topics you'd like to discuss below!

Issue triage: as of writing we're at 78 issues.  I took a pass last week to try and clean some up but it might be good to have some sort of regular cadence we can rotate on to make sure we're not just accumulating baggage, getting things tagged as appropriate, and don't leave questions hanging where we have answers.

Wanted to have a quick chat about this issue: https://github.com/kcp-dev/kcp/issues/535

Recording: https://youtu.be/SMVA3GgF2Ww

Next https://github.com/kcp-dev/kcp/issues/551


Proposing process to post deprecation plans

Proposal to prevent future "surprises" for the community over changes to features such as thumbnail controls: https://about.mattermost.com/mattermost-4-0/#comment-3436068337

we already have a process for this so you need to update it in both places and make sure it's consistent: https://github.com/mattermost/docs/blob/master/source/process/deprecated-features.rst
I think we should add a guideline about how often in advance we should try to announce the deprecation as well.

In cases like those image sizes, we could also include a brief point in the marketing about why the settings are being removed. I think that guy thinks we're removing the ability to post images like Slack does which wasn't how it worked in the first place.

We also had forum posts on deprecations (except the thumbnail one).
Maybe we should link to those in the release announce for community feedback whenever we mention upcoming and current deprecations.

Closing and moving discussion to Platform Meeting


Fix: LlamaIndex 0.10.x migration

Title: Fix: LlamaIndex 0.10.x migration

Description:
This pull request addresses the issue reported in Chainlit #752 regarding migration problems encountered with LlamaIndex version 0.10.x. The main focus of this fix is to ensure compatibility and smooth migration from earlier versions to LlamaIndex 0.10.x without causing disruptions to existing functionalities.
Changes:

Fixed all breaking changes that resulted from deprecated methods and properties in the new version.
Updated the llama_index test to work with this newer version.

Great work! Is there a timeline for the deployment?

I checked out the HEAD of main branch, installed that version of chainlit, and I now get
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/Users/vincent/Workspace/rag/venv/lib/python3.11/site-packages/chainlit/__main__.py", line 1, in <module>
    from chainlit.cli import cli
  File "/Users/vincent/Workspace/rag/venv/lib/python3.11/site-packages/chainlit/cli/__init__.py", line 24, in <module>
    from chainlit.server import app, register_wildcard_route_handler
  File "/Users/vincent/Workspace/rag/venv/lib/python3.11/site-packages/chainlit/server.py", line 150, in <module>
    build_dir = get_build_dir("frontend", "frontend")
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/vincent/Workspace/rag/venv/lib/python3.11/site-packages/chainlit/server.py", line 147, in get_build_dir
    raise FileNotFoundError(f"{local_target} built UI dir not found")
FileNotFoundError: frontend built UI dir not found

I guess this has to do that the "frontend" folder is not taken into account when I create a wheel of the backend folder and install that. I think I will wait for the official release :-)

You can follow the "contributing" document to launch Chainlit from source. I believe you're missing the frontend compilation step pnpm run buildUi to get it to work.


feature: iOS/Android App Authentication

Inspired by #211

User opens iOS app and the user is not authenticated
iOS app generates a random code (100+ characters long) called dropbox_code
iOS app must support UniversalLinks
iOS app opens a browser to http://<auth_portal_base_url>/login?otp_code=<random-code>&app_link=<universal_link>
The user authenticates in the browser. When authenticated, the browser opens a link to iOS app
The iOS app calls http://<auth_portal_base_url>/otp?code=<random-code> and received JWT token that could be used to access API endpoints. The app can access the OTP endpoint with the code only once. The portal destroy the  after a user accesses it.

Closed in favor of https://github.com/greenpau/caddy-security/issues/22


The libxt-dev depends should be checked with the configure script.

Steps to reproduce
1.run "./configure" without installing "libxt-dev" and related depends.
2.Configuring finished and got no error.
3.After compling,"/usr/bin/" got no "gvim"
4.Launch "vim --version" with the terminal, noticed that the "vim" does  not support gui feature.
5.Compile again,got the same error.
6. I found it probably depends "libxt-dev" head files.
7. After installing that,I compile vim again,and it supports gui feature this time.
Expected behaviour
It should check the "libxt" head files with the configure script.
Version of Vim
9.0.1572
Environment
Operating System:deepin V20.9
Logs and stack traces
No response

shouldn't you use --enable-gui=gtk3 --fail-if-missing ?

shouldn't you use --enable-gui=gtk3 --fail-if-missing ?

Thanks,I will try this way next version

You can build Vim without GUI, so this is just fine. If you look at the configure output you can see why it decided to not build the GUI version. You can use that as hint for what package might be needed.
What packages you would need to install depends on what GUI you want and what those packages are called on your specific system. The number of combinations is huge, and it constantly changes, therefore trying to provide instructions in the Vim distribution is close to impossible. Just use your favorite search engine to find hints, or use pre-build Vim packages for your system.

I see,but I need to compile the GUI version and upload as simple gui apps.I will try the way by @chrisbra


fix: ensure we can sort pub/sub backlog regardless of version used

merged this change into: https://github.com/launchflow/buildflow/pull/214


Add design document of interface_test.

The reason of this change
By creating a framework for interface testing, we can perform efficient testing with less effort.
Design documentation will be created to discuss the design and usage.
Approach
We will use rclpy's API to gather information about the topics that nodes are sending and receiving. Since no actual messages are sent or received, the test can be completed in a short time.
The predefined topic information is compared with the actual information to ensure that the specification and implementation are consistent.
Alternatives
I considered using launch_testing to actually send and receive messages. However, this test is time consuming. It also requires more effort to set up the test than the above approach, since we have to define the appropriate inputs for each node.
For these reasons, I did not adopt this approach.

Same as this comment.
https://github.com/autowarefoundation/autoware.universe/issues/380#issuecomment-1038659995
If you create an issue, please write more descriptions so that people can understand.

@KeisukeShima Could you describe what errors can be prevented by this kind of test?
For example, "if a developer mistakenly wrote here as ..., then it will cause the error of ...".


lodash: Fix _.has and _.result

Fixing _.has and _.result:

has: doc + added support for arrays on path
result: add return type + doc + added support for arrays on path

lodash/lodash.d.ts
to authors(@bczengel @chrootsu). could you review this PR?
:+1: or :-1:?
check list

[ ] pass the Travic-CI test?

:+1:

@bczengel thanks!
@fbarriga thanks mate!


Check system property ro.modversion

Check system property ro.modversion  which can be used to identify certain custom roms such as Cyanogenmod

custom roms don't imply a root.

@scottyab is there any update on this enhancement?

Hey @pawan007jangid  as @devxpy mentioned custom roms don't imply a root, but still valid to check for it I think. But no update, really, feel free submit a PR

Custom ROMs imply something much deeper than a root. When the OS itself is under someone's control at the source code level, anything can happen even without root


User namespace issue while running mbtci image in Jenkins agent

--- An error occurred in the library step: dockerExecute
Error: docker: Error response from daemon: OCI runtime create failed: container_linux.go:348: starting container process caused "cannot set uid to unmapped user in user namespace": unknown.

Hi,
Do you still encounter this issue?
Best regards,
Tal

Hi,
Do you still encounter this issue?
Best regards,
Tal

Closing as there's no response for a long period.


CurseForge support

Is your feature request related to a problem? Please describe.
In addition to being able to download from Spigot, it would be useful to be able to download plugins from CurseForge as well.
Describe the solution you'd like
Curseforge support

Ticket can probably be merged into https://github.com/Neocky/pluGET/issues/13 actually. Not sure if there is any difference between https://dev.bukkit.org/bukkit-plugins and https://www.curseforge.com/minecraft/bukkit-plugins

Merged into #13


fix: use productID to detect ledger type

fixes issue on certain linux hosts when strings are not
decoded properly. though strings issue must be fixed,
it is still remains convenient to ProductID as source
of detection Ledger type
Signed-off-by: Artur Troian<EMAIL_ADDRESS>

/cc @jleni


Add shared global styles

Both the developer site and the open source site should have similar global styles (box sizing, font size, etc). Let's add the shared global styles to this project.

Done with #32


armcap: skip probing _armv7_tick()

Using _armv7_tick() leads to crashes on a variety of AArch32 Android devices while providing little benefit. Nobody has succeeded in getting a reliable repro to debug it for years, so just disable it by default on these known problematic configurations unless the user opts in by setting OPENSSL_armcap.
If this approach is acceptable, this should also be backported to OpenSSL_1_1_1-stable to resolve the linked issues.

Fixes #14838
Fixes #17009
Fixes #17465

Thanks. This looks good, but you will need to sign a CLA:
https://www.openssl.org/policies/cla.html

Really OpenSSL shouldn't be probing for support like this on any platform. It's very unreliable in big.LITTLE situations. See https://github.com/openssl/openssl/issues/14838#issuecomment-820900637
Although it doesn't look like the feature OpenSSL wants here even has a getauxval value. So I'd also suggest revisiting uses of the feature in the first place.

Really OpenSSL shouldn't be probing for support like this on any platform. It's very unreliable in big.LITTLE situations. See https://github.com/openssl/openssl/issues/14838#issuecomment-820900637

I don't think it's even exclusive to big.LITTLE platforms. I've seen a crash on a MediaTek T31-based device which appears to be a single cluster of 4 Cortex-A55 cores.

Although it doesn't look like the feature OpenSSL wants here even has a getauxval value. So I'd also suggest revisiting uses of the feature in the first place.

We could just remove the probe entirely and require users to set ARMV7_TICK in OPENSSL_armcap for that functionality to be enabled. Either approach is fine with me.

I suggest we just never probe for it.

I suggest we just never probe for it.

Sounds good to me. I removed the probe entirely in my latest push.

Agreed that's the right change, but note that, since OPENSSL_armcap_P is not public API, this amounts to removing use of the ARMV7_TICK feature from OpenSSL. (Which I also think is correct.)

OPENSSL_armcap_P can't be accessed directly, but if set, the OPENSSL_armcap environment variable is used to initialize OPENSSL_armcap_P. That overrides OpenSSL's feature detection and allows use of the ARMV7_TICK feature.

Ah fair. Unclear to me whether that code is worth carrying given that, but okay. :-)

Unfortunately there is no way to set individual bits with OPENSSL_armcap not overriding also the other bits. That makes the ARMV7_TICK code fairly useless.

Unfortunately there is no way to set individual bits with OPENSSL_armcap not overriding also the other bits. That makes the ARMV7_TICK code fairly useless.

Okay, is the preference then to just nuke _armv7_tick() entirely?
If so, should we keep that ARMV7_TICK bit reserved for backwards compatibility with older applications/scripts that may set OPENSSL_armcap manually?

Yes, nuke it.  It's only uses as a very low quality entropy source.  We should be able to live without it.
As a fallback, perhaps introduce a configuration option that enables/allows it.  My rationale is that some embedded platforms are quite lacking in entropy and this clock might help.

Yes, nuke it. It's only uses as a very low quality entropy source. We should be able to live without it.
As a fallback, perhaps introduce a configuration option that enables/allows it. My rationale is that some embedded platforms are quite lacking in entropy and this clock might help.

Could that configuration option just be setting the OPENSSL_armcap environment variable? On an embedded device, one could reasonably know the capabilities ahead of time and enable the use of this feature (and others) if the CPU and kernel supported it. That use case would work with the PR as it is now.

I'd prefer a build time option but an environment variable might work.  The former is less risky.
@openssl/otc ??

As a fallback, perhaps introduce a configuration option that enables/allows it. My rationale is that some embedded platforms are quite lacking in entropy and this clock might help.

Is even that necessary? PRNG-wise, looks like this goes into get_timer_bits which rightfully says it is not considered a trusted entropy source. If the embedded platform lacks sufficient entropy, this won't change things (CVE-2008-0166). If it does, this is unnecessary.
It also goes into ossl_method_cache_flush_some, which has no other entropy source. But given this feature cannot actually be enabled without crashes, perhaps that component should be redesigned to not use this in the first place.

It also goes into ossl_method_cache_flush_some, which has no other entropy source. But given this feature cannot actually be enabled without crashes, perhaps that component should be redesigned to not use this in the first place.

This path shouldn't need changing.  It doesn't require a good RNG or entropy.  A completely deterministic PRNG will achieve the desired result.  I was attempting to mitigate a theoretical DoS attack where the same cache elements are flushed each time.  I doubt it's possible to do anything useful but attackers have proven time and again to be rather resourceful.

If you just remove ARMV7_TICK, your "deterministic" RNG will be return 0. Dunno if that's good enough for your purposes. :-)

It checks for the zero timer and seeds with a 1 in that case :smile:

Oh, I see. I missed that the value goes into an xorshift thing.

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

ping @openssl/otc for second review

This pull request is ready to merge

Merged to master and 3.0. Thank you.


Added theme support <Api28

You can apply custom theme under API 28

@siczmj Thanks for your contribution! It looks great but cannot be used on API 28+, that might make effect inconsistent.
I will still keep it free to use for users (developers). We should consider if our apps really need customize bioprompt dialog theme before using it.


Research to get more direct images for pages.

We found out that the search is looking up the page and adding more then one parameter means it might not have a page.


Check notifications for alerts with decimal limits

Also check disable and mute buttons from notification.

1.15.6

1.15.6 @andreevdenis If we are supposed to allow same decimals to be set as in resolution then looks like setting alert will round it to "0.0" even when "0.00" was the selected resolution.

Accuracy settings apply to displaying values only. I round alert limits to 0.1 on purpose. Because we store these values in main units (Celsius for example) we're loosing precission in other units. When you work with F for example. Try to set alarm limit as 15.5 F in station web. Because of conversion it will be saved as 15.49. This looks wierd to me. So in my opinion it's better to avoid unnecessarily precise values and use limits of 0,1 precission. Hope it makes sense.
@laurijamsa what do you think?

I can see that currently on Android (and web) it's possible to set alert values with 2 decimal precision (for example 20,15C). But after doing it, the app shows 20,1C.
First issue is that 20,15 should be rounded to 20,2 and not 20,1.
Second issue is that even if the app shows 20,1 as the limit, currently I get emails from the cloud that say my limit is 20,15C. Confusing.
Because we store F and K alert levels in the base format (C), we also cannot always store lower precision (0,1C) values because that would lead to even bigger problems than the current one (15,5F is shown as 15,49F).
So, maybe we should store the alert levels using 0,001C precision and round Fahrenheit to 0,01F precision. Would that fix everything?

This might work. Can we do it as part of 1.16?

Yeah I see why not because this is not a big issue.

Maybe milestone 1.150284 and 1.169034. :-)
See related issue with webui  # 216
Inanity:
Floating point Bad.
irrefutable:

The world is round.

This is really a fixed point system.  In order to be virheetöntäll values for temp and hum, air-pressure  and battery should be in hundredths (or even tenths). Values for acceleration in mG.  Similar issue with charting axises.
Just because there is a decimal in it does not make it floating point.

Only thing worse (a project running under a system I was admin for (for over 10 years ) is keeping money in floating point.
Sorry I just had to vent. I guess it's too lat for that now.

QA passed


Tweak readme

Get rid of this massiv list and show some nice logos instead.

I'll use my admin privilege to merge this. It's just a readme update