Suggested improvements to user page

Building off of https://github.com/ossfriday/ossfriday/pull/40, a few more things to build out the user page:

How do people sign up for emails? Do we automatically add them to Mailchimp when they sign in, or should they manually opt in on the dashboard? (Side note: I'm not totally convinced we should still do emails, let's chat when you're back @mikemcquaid)

On the homepage, "Sign up with GitHub" should be a front and center button in at least two places:

and

For the maintainer page, I'd similarly put it: 1) on the hero and 2) below the Get ready for Open Source Friday heading/subtext.

Oh another question. The user page shows @prs_count, but I'm not sure that's the right metric.
Andrew's original vision (https://github.com/ossfriday/ossfriday/issues/2) was to make this "not tied to pull requests", which I strongly agree with.
Can we count a broader set of activity here? e.g.:

Commits
Reviewing PRs
Commenting on an issue or PR
Closing issues
Merging PRs

How do people sign up for emails? Do we automatically add them to Mailchimp when they sign in, or should they manually opt in on the dashboard? (Side note: I'm not totally convinced we should still do emails, let's chat when you're back @mikemcquaid)

@nayafia 👍 to chatting more. If we do I'd say allowing them to opt-in but putting it front-and-center when they first sign in your be good. Additionally, I think allowing people to just enter an email address somewhere lower down the page would be good (if not signed in).

On the homepage, "Sign up with GitHub" should be a front and center button in at least two places:

Agreed 👍

Can we count a broader set of activity here?

I'll investigate further but it's going to be a bit more complicated/"expensive" (re: API quota). I think this is linked to the commit access you've mentioned; I don't think someone should be considered to have participating in Open Source Friday from commenting on a random repo they don't have commit access to.

Can we count a broader set of activity here?

I investigated the APIs we provide for these things (i.e. search) and it's not great news, I'm afraid.

Commits: we cannot do global, site-wide commit searches based just on username and being public (we may be able to do this if we had users e.g. manually enter the specific repository their commits are on)
Reviewing PRs: we can search for PRs reviewed by a certain person but not the date on which that review happened (without an additional API call for each PR to check the date)
Commenting on an issue or PR: we can search for issues/PRs reviewed by a certain person but not the date on which that comment happened (without additional API call, as above)
Closing issues: we can't do global, site-wide search for issues that were closed by a given user (we may with manual entry, as above)
Merging PRs: we can't do global, site-wide search for PRs that were closed by a given user (we may with manual entry, as above). The other approach would be to serve for merge commits which works in the same way.

At least for the contributor workflow: I don't think any of the above are going to be possible in a way that provides a good user experience, scales, and/or produces correct data. I do think the PR is the fundamental unit of work for non-maintainers on an open-source project, though. I don't think that any of the above would be valuable from contributors on any projects I maintain currently or previously.
For the maintainer workflow it's a bit trickier; arguably if we're just looking at their creation of PRs they aren't really being nudged into separate workflows than contributors. Maybe that's OK (I think it may be) but if it isn't then maintainers are likely to know in advance which repositories they are likely to perform Open Source Friday work on and could add them on signup and we can search for some of these other actions (e.g. commits, reviews) in their repositories specifically. Again, this has the potential of scaling problems so we'd probably need to limit the number of repos they can add.
Note this issue will be auto-closed shortly but let's keep talking about things here to keep conversation in one place.


hyprutils - required packages not found?

Hello All. I'm trying to install some of the hyprwm plugins, but when I run hyprpm update, I'm getting the following error. required packages were not found (hyprutils)...
➜  ~ rm -r ~/.local/share/hyprpm
➜  ~ hyprpm update

 ╍━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━  0 / 5  Cloning the hyprland re! Cloning https://github.com/hyprwm/hyprland, this might take a moment.
✔ cloned
✔ checked out to running ver
! configuring Hyprland
 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╍━━━━━━━━━━━━━━━━━━━  3 / 5  Building Hyprland
✖ Could not configure the hyprland source, cmake complained:
-- The C compiler identification is GNU 14.2.1
-- The CXX compiler identification is GNU 14.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/lib64/ccache/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/lib64/ccache/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Gathering git info
fatal: No names found, cannot describe anything.
-- Found Python3: /usr/bin/python3.12 (found version "3.12.4") found components: Interpreter
Building itab.c/itab.h...
-- Found PkgConfig: /usr/bin/pkg-config (found version "2.1.1")
-- Found wayland-protocols at //usr/share/wayland-protocols
-- Configuring Hyprland in Release with CMake
-- Checking deps...
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found OpenGL: /usr/lib64/libOpenGL.so  found components: GLES3
-- Checking for module 'hyprutils>=0.2.1'
--   Package 'hyprutils', required by 'virtual:world', not found
CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:619 (message):
  The following required packages were not found:

   - hyprutils>=0.2.1

Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPkgConfig.cmake:841 (_pkg_check_modules_internal)
  CMakeLists.txt:90 (pkg_check_modules)

This likely means that you are missing the above dependencies or they are out of date.

But it is installed...
hyprcursor.x86_64                                         0.1.9-2.fc40                                     @updates
hypridle.x86_64                                           0.1.2-1.fc40                                     @copr:copr.fedorainfracloud.org:solopasha:hyprland
hyprland-debuginfo.x86_64                                 0.42.0-2.fc40                                    @copr:copr.fedorainfracloud.org:solopasha:hyprland
hyprland-debugsource.x86_64                               0.42.0-2.fc40                                    @copr:copr.fedorainfracloud.org:solopasha:hyprland
hyprland-git.x86_64                                       0.42.0^24.gitc86db7b-1.fc40                      @copr:copr.fedorainfracloud.org:solopasha:hyprland
hyprland-welcome.x86_64                                   0~5.git51561c0-1.fc40                            @copr:copr.fedorainfracloud.org:solopasha:hyprland
hyprlang.x86_64                                           0.5.2-1.fc40                                     @copr:copr.fedorainfracloud.org:solopasha:hyprland
hyprlang-devel.x86_64                                     0.5.2-1.fc40                                     @copr:copr.fedorainfracloud.org:solopasha:hyprland
hyprlock.x86_64                                           0.4.1-1.fc40                                     @copr:copr.fedorainfracloud.org:solopasha:hyprland
hyprpaper.x86_64                                          0.7.1-1.fc40                                     @copr:copr.fedorainfracloud.org:solopasha:hyprland
hyprpicker.x86_64                                         0.3.0-1.fc40                                     @copr:copr.fedorainfracloud.org:solopasha:hyprland
hyprshot.noarch                                           1.3.0-1.fc40                                     @copr:copr.fedorainfracloud.org:solopasha:hyprland
hyprutils.x86_64                                          0.2.1-1.fc40                                     @copr:copr.fedorainfracloud.org:solopasha:hyprland

Any idea what's causing this? I'm running Fedora 40 @ 6.10.3-269.rog.fc40.x86_64

fedora splits packages into base and -devel. Do you have hyprutils-devel?

Ah, I did not -- good to know. Sorry for my ignorance.

Thanks for all the amazing work on Hyprland @vaxerski (and all contributors)!

assuming fixed, closing


Use cookstyle instead of rubocop if available

Newer versions of Chef DK include Cookstyle, which is a specific version of Rubocop with specific rules for Chef cookbooks.
By default, instead of using rubocop, this extension should look for cookstyle and use that if possible.

Yes, I think it's time. Do we still agree with the default of leaving it disabled but enabled via workspace or user setting?

I think rubocop is enabled by default (from my tests and from https://github.com/pendrica/vscode-chef#rubocop-linting), but foodcritic is disabled by default. I'd prefer leaving it enabled by default with cookstyle as well, but don't feel strongly about it since I could just turn it on if needed.


Not working on Arch

I'm using Arch linux with budgie-desktop and gnome installed as well. Both dconf and gconftools-2 are installed, but the theme instalation always fails with the following error:
Error gconftool not found!
Possible fix, enter the following and run again:
export GCONFTOOL=/path/to/gconftool/

I've tried to set this environment variable with
export GCONFTOOL=$(which gconftool-2)
and
export GCONFTOOL=$(which dconf)
but neither of these worked.

I have managed to find a solution. Just uninstalled every package related to gconf with pacman -Rcns gconf and the error is gone.


feat: Win/Linux Dual Compatible WORKSPACE

Description

Dependent on #2806 - do not merge before; needs rebase to main once merged

New changes are only the most recent commit - https://github.com/pytorch/TensorRT/pull/2907/commits/14e079b2363d9f6aaa0d59d06e333fdffdc0290d

Add support for OS compatibility in the WORKSPACE file and BUILD files across the repository

Upgrade bazel version to enable Windows builds in MSVC command prompt

Validate multiple builds on CI, including with new Bazel version

Steps to Build on Windows Using the New WORKSPACE
Portions adapted from discussion with @HolyWu in #2806

Clone Torch-TRT (this repo)
Open x64 Native Tools Command Prompt for VS 2022
Install latest version of Torch (i.e. with pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu121)
Run set DISTUTILS_USE_SDK=1
Run set INCLUDE="C:\TensorRT\bazel-tensorrt\external\tensorrt_win\include";%INCLUDE%, where TensorRT is the root of your Torch-TRT clone and bazel-tensorrt is the root of your Torch-TRT clone appended to bazel-

This is analogous to setting LD_LIBRARY_PATH on Linux

Run python setup.py bdist_wheel
Run python -m pip install dist/*.whl

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

[ x ] My code follows the style guidelines of this project (You can use the linters)
[ x ] I have performed a self-review of my own code
[ x ] I have commented my code, particularly in hard-to-understand areas and hacks
[ x ] I have made corresponding changes to the documentation
[ x ] I have added tests to verify my fix or my feature
[ x ] New and existing unit tests pass locally with my changes
[ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

Installation instruction update


Feature/add bizflycloud provider

Description

Fixes #ISSUE
Checklist

[ ] Unit tests updated
[ ] End user documentation updated

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

198 of 231 (85.71%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 70.084%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

provider/bizflycloud/bizflycloud.go
193
226
85.4%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
13391

Relevant Lines:
19107

💛  - Coveralls


Crash after edit something new on morphology

Create a new morph or select an existing morp
Add new row (Vector and Patterns either way)
Edit whatever
Add
Crashed

See the video
https://github.com/feagi/brain-visualizer/assets/65916520/66e68733-0c23-48e4-8326-32d9999be750

Seems that FEAGI will (sometimes?) not send the class of a morphology, which is where the error is stemming from @m-nadji-tehrani

fixed


Allow to set up subscriptions discount if the backer engages for a given period of time

It's quite common for SaaS startups to have "2 months free" if you subscribe for a whole year. It may be interesting to copy that model and let the maintainer set up discounts if the backer engages for a period of time.

Cleaning up GitHub. Closing older ideas - will resurface if needed or feedback given instead.


Automated Package Upgrade

:tada: This PR is included in version 19.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Design opni model training infra

architecture break-down:
API/UI: For POC, we use FastAPI as the api host, UI/CLI can be another add-on layer to it.
ImageBuild: For POC, user should provide the image. Later on, user can provide requirement + configs and we automatically build it.
Backend: use Nats + Jetstream as the persistent task queue.
Data Storage: For POC we start with S3, and can eventually support many other sources.


chore: bump to 2.0.0

#minor

Coverage remained the same at 50.84% when pulling c8824cbc79fe001152ef1b6a7a29142e019781e2 on cwhitten/2.0.0 into 99a74b9a5686d30759a331fadb25a0d301c89852 on main.

Applying an override to test the 1.4 -> 2.0 upgrade installers


Remove lodash dependency

Use array.filter instead lodash.find.
Advantages:

Compatible with ie9+
Smaller file sizes.

File
before (with lodash)
after (without lodash)

dist/break.bundle.js
68.2 KB
4.7 KB

dist/break.bundle.min.js
12.9 KB
2.5 KB

dist/break.js
4.42 KB
4.2 KB

cc @nygardk =)


v0.3monitoring: optional- escalation to user when issue

telegram or email escalation when the monitoring finds failures or problem

Escalation to be done through prometheus + grafana stack right now


[WIP][2.6] Encode '+' character when download tgz file

The '+' character in URL is treated as encoded character ' ' (space) when calling url.String(), and some chart version is formatted with 100.0.0+up1.0.0, so replace the character + to %2B.
Issue: https://github.com/rancher/rancher/issues/39465
Solution
Replace + character in url to %2B when downloading tgz tarball from helm repo.
Example:
from https://<server>/assets/rancher-aks-operator/rancher-aks-operator-100.0.6+up1.0.7.tgz
to https://<server>/assets/rancher-aks-operator/rancher-aks-operator-100.0.6%2Bup1.0.7.tgz

I don't think this PR is enhanced enough to fix this issue, so I closed this PR.


Fix specs on OSX

After #40 was merged, the build_spec is failing due to a mismatch of the ::settings::vardir. Specs pass on Debian (and TravisCI) but should work in any environment.

Meh. Just use Docker on Mac to run specs.


Forms not setting 'pristine' property on control change

On form control changes, controls are only being set as dirty and not being tested for pristine status. Also, AbstractControl does not have related methods markAsPristine and reset.
In Angular1, NgModel captured _originalValue and set pristine on value change. Are there plans to implement this in the current version of Angular?

/cc @TedSander @alorenzen @nshahan

This is a duple of https://github.com/dart-lang/angular/issues/216


Tf front end for sparse reshape op

This PR builds the TF Frontend for sparse_reshape op. TF Documentation

@zhiics @comaniac @yongwww would you like to review? Thanks!

is this PR is same to #7125?

Sorry I meant to mark this pr as draft it's still work in progress


Automated cherry pick of #8809: fix: baremetal usage should exclude converted hypervisor

Cherry pick of #8809 on release/3.4.
#8809: fix: baremetal usage should exclude converted hypervisor

Codecov Report

Merging #8811 (dc19e7b) into release/3.4 (02bcce1) will decrease coverage by 2.63%.
The diff coverage is 2.83%.

@@              Coverage Diff               @@
##           release/3.4   #8811      +/-   ##
==============================================
- Coverage         6.22%   3.58%   -2.64%
==============================================
  Files              759     304     -455
  Lines           117145   62557   -54588
==============================================
- Hits              7289    2243    -5046
+ Misses          109197   60159   -49038
+ Partials           659     155     -504

Flag
Coverage Δ

aFlag
3.58% <2.83%> (-2.64%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/appsrv/stats.go
0.00% <0.00%> (ø)

pkg/cloudcommon/notifyclient/events.go
0.00% <0.00%> (ø)

pkg/cloudcommon/notifyclient/notify.go
1.84% <0.00%> (-0.40%)
:arrow_down:

pkg/compute/models/buckets.go
1.10% <0.00%> (+0.03%)
:arrow_up:

pkg/compute/models/cachedimages.go
1.73% <0.00%> (-0.08%)
:arrow_down:

pkg/compute/models/capabilities.go
0.00% <0.00%> (ø)

pkg/compute/models/cloudaccounts.go
0.48% <0.00%> (-4.66%)
:arrow_down:

pkg/compute/models/cloudregionresource.go
0.00% <0.00%> (ø)

pkg/compute/models/cloudregions.go
1.54% <0.00%> (-0.04%)
:arrow_down:

pkg/compute/models/dbinstance_skus.go
2.83% <0.00%> (-0.02%)
:arrow_down:

... and 469 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c047d69...dc19e7b. Read the comment docs.


chore(deps): bump https://github.com/zeebe-io/zeebe-cluster-helm from 0.0.141 to 0.0.142

Update zeebe-io/zeebe-cluster-helm from 0.0.141 to 0.0.142
Command run was jx step create pr chart --name zeebe-cluster --version 0.0.142 --repo https://github.com/zeebe-io/zeebe-full-helm.git

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign salaboy
You can assign the PR to them by writing /assign @salaboy in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: salaboy:x: pow-devops2020You have signed the CLA already but the status is still pending? Let us recheck it.


WIP: docker-compose-no-mesos.yml to cross-check e2e tests without Mesos

Implementing mesosphere/kubernetes-mesos#383.

quick'n'dirty

/cc @karlkfi

Gonna want this under cluster/docker so it can be launched with KUBERNETES_PROVIDER=docker

Sure. This was just a quick hack.
Might be worth it to refactor that both directories share the same code.

is this still useful?

See https://github.com/mesosphere/kubernetes-mesos/issues/383#issuecomment-130103985 for reasoning.


[feature] add options for width and height preview

This is related to #15 , in my case the problem was the width and height of the preview, I solved it by modifying these lines:

These modifications that I made probably won't work on other screen sizes, other font sizes and other telescope settings like layout_config and it's a bit "dirty" to modify the source code of the extension, so I think it would be nice to have these options available.

I don't know if you're interested but, I already added those options on top of what tembokk's fork provides!


vr: fix password server run with empty gateway in isolated network with RVRs

Description

This is regression issue of #3898
The password server in isolated network with RVRs run with wrong parameter
root@r-1083-VM:~# ps -ef|grep pass
root      1070     1  0 20:58 ?        00:00:01 python /opt/cloud/bin/passwd_server_ip.py ,<IP_ADDRESS>

it is because the gateway is "" for eth0 in /etc/cloudstack/ips.json.
This does not impact vpc with redundant VRs.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
restart network with cleanup, the new VR seems ok
root@r-1085-VM:~# ps -ef|grep pass
root      5468     1  0 21:37 ?        00:00:00 python /opt/cloud/bin/passwd_server_ip.py <IP_ADDRESS>,<IP_ADDRESS>

How Has This Been Tested?

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1018

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-1204)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28810 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3943-t1204-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_02_vpc_privategw_static_routes
Failure
188.87
test_privategw_acl.py

test_03_vpc_privategw_restart_vpc_cleanup
Failure
179.20
test_privategw_acl.py

test_04_rvpc_privategw_static_routes
Failure
237.15
test_privategw_acl.py

test_04_rvpc_privategw_static_routes
Error
264.77
test_privategw_acl.py

@

@weizhouapache the private gateway errors have either not been fixed or have returned. Any resolution/opinion? cc @rhtyd

@DaanHoogland the private gateway issue is merged into master, not 4.13

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-1214)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26817 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3943-t1214-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_02_vpc_privategw_static_routes
Failure
174.65
test_privategw_acl.py

test_03_vpc_privategw_restart_vpc_cleanup
Failure
175.00
test_privategw_acl.py

test_04_rvpc_privategw_static_routes
Failure
226.93
test_privategw_acl.py

@DaanHoogland the fix for private gateway issue is merged into master, not 4.13

should those fixes be backported to 4.13?


Add support to provide name and value to data table selections.

This allows developers to add the following attributes to rows of the table body. This will then tell the data table JS to set the name and value of the checkbox to what is provided as the attribute values.
data-mdl-data-table-selectable-name and data-mdl-data-table-selectable-value are the attributes that are available for definition.
Use-case: Using the checkboxes in a submitted form to say, delete records or specify which records are to be modified.

Could you also add something in the README describing this new option?

@Garbee If you get a chance, would you mind rebasing?

Yup, I'll rebase and address the issues after lunch.

ah, also need to dump dataset usage and use getAttribute for IE10 support! So, dumping this PR since I'm not entirely sure where the conflict came in and too worried about breaking things. Making a new PR with a fresh build of master to include all needed changes.


Change to update to support ID column

Missed this in previous PR, but extends support for designating ID column name to updates

@Dartths I implemented this change on master. No need for this PR anymore, will close it. The Dapper NuGet v1.0.1 is on the way, containing this change.


feat(options): do not use giturl anymore

Fix #797
Fix #799

@rofe Should we also remove Add this project from the context menu on github urls?

Yes, absolutely. I'll create a new issue for that.

:tada: This PR is included in version 6.48.0 :tada:
The release is available on:

GitHub release
v6.48.0

Your semantic-release bot :package::rocket:


Outdated Development Docs

The images in the [development docs] do not match what I see when I run the docker compose file.
based to docs it should display such list of running containers:

But here is what shows in the terminal:

Also, the instruction to stream the logs for the indexer is incorrect/outdated:

you can check if it's syncing properly by streaming the logs for the indexer:
docker logs indexer_indexer_1 -f

but the container name indexer_indexer_1 is not found.

fixed in https://github.com/threefoldtech/tfchain_graphql/commit/fc306bd532b201f5e0f0a41bf548254bc39de39b


Debug does not show why test fails

Even in debug mode, the error only have the exit status 1 instead of the full error message.

redirect stdout and stderr in debug mode. see a0662fc2033c362165c8b3ec57a8906dab43f3c1


Update design & roadmap

It's my honor to join this great project, some questions raised above, please kindly clarify them, thanks.

@jiere

As it shown, does it mean the "Y-axis" value of the black curve is "power" and the "Y-axis" value of the red curve is "Total power reduction"?

In the graph
The black curve is plotted against the values on the left hand side of the y axis. It represents the power values of the node. The red curve represents power reduction when the cluster was using packing strategy, the same principle PEAKS propose. It is plotted against the values on the right hand side Y axis.

How could the power reduction data come out? IIUC, the data comes from the "peaks-default.png". Since the diagram title is "PEAKs vs Default", this diagram is part of the methodology, how could PEAKS scheduling happen before the born of methodology, what's the PEAKS scheduling mechanism at first?

We used the following scheme:

the default kube scheduler spreads the load, and
PEAKS packs the nodes.

Asser Tantawi conducted these tests. I will request for more information on the implementation of the PEAKS mechanism

Another question is about the meaning of the "power profile". What's the meaning of the Y-axis value of each point on the black curve? Idle power without any workload scheduled onto node by PEAKS or Default?

@ Asser Tantawi


fix SR-4166: mode attribute presence check changed.

Changes how the __mode__ attribute is checked. __has_attribute should query for __mode__, assuming the DI variant will be available.

Resolves SR-4166.

@hughbe Would you be able to confirm if the original intention of this line is still covered and working fine in your environment? Thanks.

@swift-ci please smoke test

Looks like this works: https://godbolt.org/g/H2hmUp


Refactor testing tab to use JUnit

Currently the testing tab uses a input, expected output vs. actual output testing approach. These are all represented as actual files in the file system. Ideally, we should be using the projects JUnit test cases as they are more standard for Java projects than a file comparison approach.

SIDE NOTE: On Mac and Eclipse 4.2 I was unable to get the current testing tab approach to function properly. This could be either fixed, or simply refactored to the JUnit approach.

I'm closing this issue as a great deal of time has passed. If there is renewed interest just reopen or make a new issue and link to this one.


[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
7e55ce6372ec71e2c7389b20e39574c292358dd9
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


feat(gemini sdk): add  generativeaionvertexai function calling advanced

Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist

[x] I have followed Sample Format Guide
[ ] pom.xml parent set to latest shared-configuration
[ ] Appropriate changes to README are included in PR
[ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
[ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
[x] Tests pass:   mvn clean verify required
[x] Lint  passes: mvn -P lint checkstyle:check required
[ ] Static Analysis:  mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
[ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
[ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
[ ] Please merge this PR for me once it is approved

Added complex response from some external API

@TetyanaYahodska kindly wait for a review from @gericdong before merging.

@TetyanaYahodska Please address the lint issue.


Compound work not showing in UV

Summary
The compound work is not showing the blank UV, so I'm slightly concerned about how it will behave when the UV is fixed. The attached PDFs split and the parent/child works are listed in the item list. However, there is no indication that the UV would be showing the works if it was functioning on Staging. https://adl.s2.adventistdigitallibrary.org/concern/generic_works/a6adc2cd-cb6f-4b86-bdb7-4e3d766eba50
Acceptance Criteria

[ ] A compound work displays in the UV

I tested by creating a new work on staging, and the multiple image files are all showing in the UV.
https://adl.s2.adventistdigitallibrary.org/concern/images/e70822d3-bc3b-40e6-afe3-8f26357806a3?locale=en
I also tested with multiple PDFs, but they are not showing in the UV. Only the first PDF is showing in PDF.js. I see childworks in the items list, but the UV doesn't render yet. I don't see anything in GoodJob to indicate that it's still running, but I'll still check back later and hope to see the UV displaying all three PDFs.
https://adl.s2.adventistdigitallibrary.org/concern/generic_works/600641e8-8cc7-453c-a12d-c0ad34a027cf

Update! The compound work with multiple PDFs is showing them all in the UV. Hooray!


Please allow key selection when getting shared access signature in blob container

Is your feature request related to a problem? Please describe.
When using Azure Portal to get a shared access signature for a blob container, there's no way to select which access key is used to generate the secret. Key 1 is always used. Please allow key selection at this time.
Describe the solution you'd like
When you select your storage account, select storage explorer, expand blob containers, right click your blob container, select Get Shared Access Signature. In the next window where you select access policy, start and expiry time, and permissions, please add a dropdown for which key will be used to generate the secret used in the query string.
Describe alternatives you've considered
The only alternative, as far as I know, to specify the access key is with powershell, as shown here: https://docs.microsoft.com/en-us/sql/relational-databases/tutorial-use-azure-blob-storage-service-with-sql-server-2016?view=sql-server-2017
Additional context
This process would make it easier for quick one-offs where scripting the solution may be impractical, but you still want the flexibility of specifying key 2 instead of the default key 1.

Related to #421


Create a developer app on Github

We need it in order to retrieve the data.
We can check if we can retrieve the data by curl the github.com website, but I'm not sure if the policy allow us to do it

Can you take this @nicpuppa ?

In the settings for Schrodinger-Hat org we need to give permissions to create a Personal access tokens
https://docs.github.com/en/organizations/managing-programmatic-access-to-your-organization/setting-a-personal-access-token-policy-for-your-organization

I think we'd need to create a github app for this

https://docs.github.com/en/graphql/guides/forming-calls-with-graphql#authenticating-with-a-github-app

I have already created a GitHub App under the organization but we have to decide which things a user must do in order to retrieve its information.
Perhaps it may be possible to use PAT instead of GitHub Apps.


Add backup label to submariner-broker resource

Submariner broker resource is not backed up if it is missing backup label. This can break submariner in case of backup+restore. Broker object is only created when submariner is installed on a managed cluster. Check for label when deploying submariner-agent and add if not already present.
Related to stolostron/backlog#22005
Signed-off-by: Vishal Thapar<EMAIL_ADDRESS>

/cc @tpantelis @sridhargaddam
/approve


Indicator setup > Targets: Aggro validation and some styling cleanup

Issue
The validation while setting up your targets is still a bit aggro.
Acceptance criteria
LoP only
The validation timing and wording looks great. Just a styling request.
Right now it looks like this:

Can you use this styling instead, for visual consistency -- ignore the words, just talking about the background colors, lines, size of the red text, etc:

[x] 1. Validation styling updated for consistency.

Midline/Endline
Right now, as soon as I tab out of the Midline value field, I see this:

On production, I don't see this validation unless I (a) try to submit the form with an empty value field (b) delete an existing value, leaving the field empty (but prior to submitting)

[x] 1. Mimic the validation behavior on Prod.

Events
Validation is looking good!
Time aware
Right now, as soon as I tab out of the first value field, I see this:

On production, I don't see this validation unless I (a) try to submit the form with an empty value field (b) delete an existing target value, leaving the field empty (but prior to submitting)

[x] 1. Mimic the validation behavior on Prod.

Housekeeping

[ ]  Unit test/s written wherever applicable
[ ]  i18n tags included wherever applicable
[ ]  Functionality is accessible to people using screen readers

PASSED.
LoP only scenario looks good:

Midline/endline and time-aware validation is no longer aggro. It no longer yells at me when I tab out of the first value field -- only upon submit or if I delete a value and don't replace it.


List of blocked sites

[ ] viralnova.com

Goose found correct top node, but was unable to fetch images inside it (403 forbidden error), thus it had to try getting opengraph images. It was lucky because the site had that kind of data.
Examples:
http://www.viralnova.com/family-on-the-moon/

[fixed] add user_agent when downloading images


feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Brief Information
This pull request is in the type of:

[ ] bug fixing
[x] new feature
[ ] others

What does this PR do?
Resolves #16946
provide splitLine.showMinLine and splitLine.showMaxLine.
When using xAxis[type=time], it allow user hide first/last splitLine.
uplot style:

After: How is it fixed in this PR?
Like showMinLabel/showMaxLabel, it add new option showMinLine adn showMaxLine.
Document Info
One of the following should be checked.

[ ] This PR doesn't relate to document changes
[x] The document should be updated later
[ ] The document changes have been made in apache/echarts-doc#xxx

Please don't commit the files in the dist folder

I have some concern on this PR.
I think it may be a better idea to hide min/max line only if the first/last tick is not calculated by nice tick (which usually happens when the user deliberately sets a min/max value to the axis.
For example, in this demo, the min tick is -20 and it is expected to be displayed because -20 is a nice tick.

While in another case, the axis is set to have min: -22. In this case, the splitLine of -22 is expected to be hidden if showMinLine is set to be false.

I think this logic may make more sense. @pissang What do you think?

@Ovilia @pissang
how to judge whether it is nice tick?   Or is this any plan yet?

@MeetzhDing Sorry for the late reply. You can find the code here.

@Ovilia showMinLine type is   boolean | 'auto' now
    // null/undefined (true) | true | false | 'auto' (true when nick tick only)
    showMinLine?: boolean | 'auto',
    // null/undefined (true) | true | false | 'auto' (true when nick tick only)
    showMaxLine?: boolean | 'auto',

@Ovilia  please check pr again

@Ovilia please check pr again

@Ovilia please check again

Superseded by #20114


Can it run in memory?

I mean, when the app begins, LiteDB can load all data into memory, and then LiteDB synchronizes with the local file when the collection change.
Maybe it's not necessary, I only ask a question.

Yes it's possible. You can load you file to memory and initialize LiteDB using MemoryStream and when you want persist in disk, write from memory to disk. some like this:
var mem = new MemoryStream(File.ReadAllBytes("data.db"));

using (var db = new LiteDatabase(mem))
{
 // here, all database are in memory only
}

File.WriteAllBytes("data.db", mem.ToArray());

Good.

Please note that you have to open the memory stream this way, in order to be expandable:
using (var ms = new MemoryStream())
{
   // Do your thing, for example:
   m.Attachments[0].ContentStream.CopyTo(ms);

   return ms.ToArray(); // This gives you the byte array you want.
}


Implement new MOVI virtual opcode and use it in codegen.

It should be primarily useful to replace ADDI


Setup website for project using GitHub pages

Would be good to setup a GitHub pages website for the project. We already have man etc in markdown docs, so should be possible to setup Actions to build webpages from those docs on each commit to master branch as well.

What are you envisioning here? just a generic front end to the same data that is exposed on github? Not entirely sure that's necessary.
For an actual website about picoTracker I'm working on it myself.

When we chatted about this in Discord I think the idea was to have a friendly format for the manual instead of pointing people at just the markdown file in the repo.

obsolete.


[finalization] dev container feature distribution specification

A forum to discuss the dev container feature distribution specification.
A continuation of the discussion found here: https://github.com/devcontainers/spec/issues/7

Whaou! I love ❤ this new file organization. I was able to create and test my own features quickly.
Good work 👍

Once again me you guys 😀


add SetAttrOnFile/GetAttrFromFile stub impl.

Hi.
go-uefi does not build on my M1 Macbook because unix.FS_IOC_GETFLAGS/unix.FS_IOC_SETFLAGS doesn't exist here. The IsImmutable and UnsetImmutable functions use that. There is an immutable bit for files on Darwin that can be accessed with chflags() but the code path seems to be only related to reading UEFI vars from sysfs which isn't happening on OSX anyways.
This PR moves the Linux specific code into its own file with the proper build constraint and add a stub implementation for Darwin. Alternatively we would need to change the signature on SetAttrOnFile and GetAttrFromFile because chflags() expects a path, not and fd.

M1 Macbook as in running OSX or Linux? I have never really aimed at supporting osx so not sure the value it has there. What is the goal?

Yes OSX. I'm developing on a Macbook and one of my dependency happens to be go-uefi. I use it for parsing various EFI structures.

Thanks for the patch!


Quality report

What do you think about putting a quality report in the output folder ?
The quality report will be based on .jshintrc and scan themes and widgets folder.

This should be done before like tests


provisioning exception: UnauthorizedAccessException

Bug
Here is the exception that occurred:     Type =     Microsoft.SharePoint.Client.ServerUnauthorizedAccessException Message =     Accesso negato. Non si dispone dell'autorizzazione per eseguire questa     azione o per accedere alla risorsa. Source =     Microsoft.SharePoint.Client.Runtime ServerStackTrace = ServerErrorCode =     -2147024891 ServerErrorTypeName = System.UnauthorizedAccessException     ServerErrorTraceCorrelationId = 742be59e-30f0-0000-b222-51fe36d32127     TargetSite = Void ProcessResponseStream(System.IO.Stream) StackTrace = at     Microsoft.SharePoint.Client.ClientRequest.ProcessResponseStream(Stream     responseStream) at     Microsoft.SharePoint.Client.ClientRequest.ProcessResponse() at     Microsoft.SharePoint.Client.ClientRequest.d__6.MoveNext()     --- End of stack trace from previous location where exception was thrown     --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task     task) at     System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task     task) at Microsoft.SharePoint.Client.ClientRequest.d__0.MoveNext()     --- End of stack trace from previous location where exception was thrown     --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task     task) at     System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task     task) at     Microsoft.SharePoint.Client.ClientRuntimeContext.d__0.MoveNext()     --- End of stack trace from previous location where exception was thrown     --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task     task) at     System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task     task) at     Microsoft.SharePoint.Client.ClientContext.d__4.MoveNext()     --- End of stack trace from previous location where exception was thrown     --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task     task) at     System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task     task) at     Microsoft.SharePoint.Client.ClientContextExtensions.d__7.MoveNext()     --- End of stack trace from previous location where exception was thrown     --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task     task) at     System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task     task) at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)     at     Microsoft.SharePoint.Client.FileFolderExtensions.d__36.MoveNext()     --- End of stack trace from previous location where exception was thrown     --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task     task) at     System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task     task) at Microsoft.SharePoint.Client.FileFolderExtensions.EnsureFolderPath(Web     web, String webRelativeUrl, Expression`1[] expressions) at     OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectFiles.ProvisionObjects(Web     web, ProvisioningTemplate template, TokenParser parser,     ProvisioningTemplateApplyingInformation applyingInformation) at     OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyRemoteTemplate(Web     web, ProvisioningTemplate template, ProvisioningTemplateApplyingInformation     provisioningInfo, Boolean calledFromHierarchy, TokenParser tokenParser) at     OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectHierarchySequenceSites.ProvisionObjects(Tenant     tenant, ProvisioningHierarchy hierarchy, String sequenceId, TokenParser     tokenParser, ProvisioningTemplateApplyingInformation applyingInformation)     at     OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyProvisioningHierarchy(Tenant     tenant, ProvisioningHierarchy hierarchy, String sequenceId,     ProvisioningTemplateApplyingInformation provisioningInfo) at Microsoft.SharePoint.Client.TenantExtensions.ApplyProvisionHierarchy(Tenant     tenant, ProvisioningHierarchy hierarchy, String sequenceId,     ProvisioningTemplateApplyingInformation applyingInformation) at     SharePointPnP.ProvisioningApp.WebJob.ProvisioningFunction.d__2.MoveNext()     in     C:\github\sp-provisioning-service\SharePointPnP.ProvisioningApp\SharePointPnP.ProvisioningApp.WebJob\ProvisioningFunction.cs:line     388 HResult = -2146233088
Expected or Desired Behavior
Contoso Landing page Template from https://provisioning.sharepointpnp.com/home/details?packageId=db23f624-2778-4800-9cd1-577287c2682f gets provisioned on my tenant building a site collection with several custom web parts
Observed Behavior
The site collection is created however the look is different from what was expected and the above exception is received by email. My guess is that the default communication site collection is created and custom web parts are not installed correctly
Steps to Reproduce
visit https://provisioning.sharepointpnp.com/home/details?packageId=db23f624-2778-4800-9cd1-577287c2682f and click "Add to your tenant"

The target site collection wasn't already existing, here is the correlation ID.
PnP Correlation ID: 14c3c781-7ea0-4368-9bcd-4fe72100ba72

any update on this?

Hi @RiccardoAmadi,
I had a look at the issue on our side and the only thing that I can see is that there is a file (but I cannot figure out which one) that fails to copy because of a missing/wrong folder to which you do not have access. I'd like to ask you if you can try provisioning another template, to figure out if it is a problem related to that template or something more general. Thanks.

Actually, I just had an idea: are you creating the target site with ITA as the default language? Because the template targets an ENG site ... that could be a good reason for not being able to find the "Shared Documents" library, which in Italian is called "Documenti", if I'm not mistaken ...

@PaoloPia Thanks for your help

I've tried with a couple of templates resulting on the same type of error
There was no prior site as I was selecting a new site name/url hence no default language, I've also switched the tenant default language to ENG from ITA before provisioning. (might the site collection default language be an issue?)
Now I made a new site collection from sharepoint admin center specifiyng custom template and english as default language and later I tried again provisioning. But looks like I still have the same kind of issue again (Unfortunately your site provisioning at least partially failed!)

I tried again selecting a Team Site as the site collection template and I've got again the partial fail, this time I can see the site with some color formatting but the layout is standard team site and most of the content is probably missing. On another test I got a full success with a different template on a non-pre existing site collection. This one looks like it worked but it's not what I wanted, the template I used here is https://provisioning.sharepointpnp.com/home/details?packageId=c26dac20-7177-4bbc-9ed0-dcf6b7b529f1

Just to be sure: what is the template that you would like to apply? Thx.

this Contoso Landing Site


carthage update never completes

We are having trouble using carthage update with a Cartfile that contains the following:
github "watson-developer-cloud/ios-sdk"
On the terminal window, the following messages display but the update never completes.
*** Fetching ios-sdk
*** Fetching swift-sdk
I noticed that a Cartfile was added to in commit https://github.com/watson-developer-cloud/swift-sdk/commit/a8b1a763452f137006cdc72bc2d00c7a70f4496c#diff-60bb710c5144ead8f8cb73a22de579ab yesterday. That is when we started seeing problems with our Starter doing the carthage update.

Yes! We're also seeing this. Sometimes I get something like:
*** Fetching swift-sdk
[1]    45331 illegal hardware instruction  carthage bootstrap --verbose --platform iOS

Other times it just hangs.
Pertinent versions:
$ git --version
git version 2.10.1 (Apple Git-78)
$ carthage version
0.18
$ swift --version
Apple Swift version 3.0.2 (swiftlang-800.0.63 clang-8<IP_ADDRESS>)
Target: x86_64-apple-macosx10.9

I'm looking into why Carthage is hanging now. I tested carthage update before publishing the release yesterday and Carthage had completed building dependencies successfully. I'll post updates accordingly.

@stupergenius, @bjulbricht: As a quick fix to allow you to build the sdk dependencies, please specify version 12 of the app within your Cartfile:
github "watson-developer-cloud/ios-sdk" ~> 0.12.0
The renaming must have affected Carthage somehow. Rebuilding the binaries now to see if that'll change anything.

Ah - whoops. Good point about the new Cartfile that was added. That seemed to have created a loop while executing carthage update. I'm regenerating the binaries one last time now so the Cartfile will be removed when grabbing the repo, but if you specify the latest commit in your Cartfile, you should be able to grab v13:
github "watson-developer-cloud/ios-sdk" "35aa20bcb8d8e733a8743449309db42de356655f"

A Cartfile with the following:
github "watson-developer-cloud/swift-sdk"

works when I run carthage update --platform iOS and carthage update in a sample project I've made.

Thanks Sarah for the quick turnaround!


fix: Update the version of log4j for bug fixes

What is the purpose of the change
Fix the bug on log4j
refer: https://github.com/apache/logging-log4j2/pull/608
Brief changelog

Update the version of log4j-api and log4j-core to 2.15.0
Exclude the log4j-api in spring-boot

Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #9378 (dfafc0d) into master (a0d48d2) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9378      +/-   ##
============================================
- Coverage     60.87%   60.54%   -0.33%
+ Complexity      448      446       -2
============================================
  Files          1100     1100
  Lines         44507    44460      -47
  Branches       6473     6441      -32
============================================
- Hits          27092    26917     -175
- Misses        14450    14580     +130
+ Partials       2965     2963       -2

Impacted Files
Coverage Δ

...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java
28.35% <0.00%> (-50.75%)
:arrow_down:

...va/org/apache/dubbo/rpc/support/AccessLogData.java
53.16% <0.00%> (-37.98%)
:arrow_down:

...ng/transport/dispatcher/WrappedChannelHandler.java
47.82% <0.00%> (-15.22%)
:arrow_down:

...ng/transport/dispatcher/all/AllChannelHandler.java
68.96% <0.00%> (-13.80%)
:arrow_down:

...g/apache/dubbo/remoting/p2p/support/FileGroup.java
50.94% <0.00%> (-13.21%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
50.00% <0.00%> (-11.54%)
:arrow_down:

...in/java/org/apache/dubbo/common/utils/JVMUtil.java
81.13% <0.00%> (-11.33%)
:arrow_down:

...che/dubbo/remoting/transport/mina/MinaChannel.java
35.52% <0.00%> (-10.53%)
:arrow_down:

.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java
62.06% <0.00%> (-10.35%)
:arrow_down:

.../remoting/transport/netty4/NettyClientHandler.java
72.88% <0.00%> (-10.17%)
:arrow_down:

... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d48d2...dfafc0d. Read the comment docs.


quantify sphericity functions

This commit added BiomedImage.py, test_biomedimage.py, and LabelConnectivity files. Note, I have tried to use the LabelConnectivity object but it kept giving me the object of types set is not JSON serializable. So in this commit, I'm still using the string input for labelConnectivity. Thank you!

Hi All. I have just submitted new changes for biomedimage.py and its tests. Thank you for taking the time to review them.


fix(remix-serve): handle os signals by closing dev server

Add simple signal handlers to the remix-serve cli that will close down the dev server if it receives either a TERM or INT operating system signal. In the case of a failed shutdown of the dev server, log to stderr.

@MichaelDeBoey I've pushed up changes for each of your two feedback items - let me know if you have anything else on this one!

Thank you for the contribution :)


Description missing for enum properties

My OpenAPI definition contains schemas that include string properties that are enums. The properties have descriptions, but the descriptions are not included in the RapiDoc output. The output only has the word "Allowed" (in bold) and the list of enum values.
An example property:
        applicationClientType:
          description: The category or type of the application client
          type: string
          enum:
            - Analytics
            - AR
            - ComputerVision
            - Gaming
            - IoT

you should enable multiline description schema-description-expanded=true
or click on the toggle single/multiple line description link on top-right


Do you have RetinaNet + Resnet101

Can this model be used together with resnet101 and is so, Do you guys the results of  RetinaNet + Resnet101?
Is it possible to share please?

@isalirezag This model can be used with any backbone. But we do not have the results of Resnet101 because of the limit GPU resources.

Can this model be used together with resnet101 and is so, Do you guys the results of RetinaNet + Resnet101?
Is it possible to share please?

@isalirezag  hi, You have achieved RetinaNet or Resnet101

Can this model be used together with resnet101 and is so, Do you guys the results of RetinaNet + Resnet101?
Is it possible to share please?

@isalirezag  hi, are you achieved RetinaNet or Resnet101?


Add CertificateValidationScript Parameter to Web Cmdlets

closes #4899
This adds a -CertificateValidationScript parameter to Invoke-RestMethod and Invoke-WebRequest which allows the user to supply a custom validation script as a PowerShell ScriptBlock to validate Server Certificates for HTTPS connections.
The ScriptBlock also has 4 automatic variables created which allows the user to use either $args, Param(), or the automatic variables to inspect the HttpRequestMessage being sent to the server, X509Certificate2 certificate returned by the server, the X509Chain certificate chain of the server certificate, and the SslPolicyErrors.  The ScriptBlock is converted to a Closure and is wrapped in a Func delegate which is used as the HttpClientHandler.ServerCertificateCustomValidationCallback. The ScriptBlock has access to the calling scope and any ScriptBlock exceptions are treated as a certificate failure.
Documentation Needed
This new parameter will need to be documented and an example added. The documentation will need to note that the $using: scope is not supported and will result in a certificate failure. it will also need to note that if the site redirects, the same validation script will apply for all hops. Finally, it will also need to state that -SkipCertificateCheck will override anything supplied in -CertificateValidationScript.

@lzybkr @SteveL-MSFT Is there something more I need to do for this PR?

LGTM but we need review from MSFT experts.

@PowerShell/powershell-committee reviewed the topic of params or automatic variables passed to the script block delegate.  There was concerns about new automatic variables scoped only to this usage but would needed to be documented in the about_automaticvariables topic which may create some confusion.  In addition, params seems to be a general pattern already in use across PowerShell, so the request is to use params for the script block (and update the doc draft accordingly).
There were other concerns we didn't have time to discuss such as which runspace the delegate ran in.  For now, continue that discussion in this PR.

Well that's baffling. It's not a surprise that the certificate validation doesn't work on macOS. I ran into similar issues enabling -Certificate because macOS (and some linux distors) use a different implementation than openssl but, how did these tests manage to pass on macOS in previous commits?

working: https://travis-ci.org/PowerShell/PowerShell/jobs/282050275
not working: https://travis-ci.org/PowerShell/PowerShell/jobs/287024709

It should have failed before.

There was concerns about new automatic variables scoped only to this usage but would needed to be documented in the about_automaticvariables topic which may create some confusion.

@SteveL-MSFT Was the prospect of providing the callback parameters to the scriptblock by way of properties on $_ contemplated?  That feels like the most PowerShell-ey style to me.  There is precedent for non-pipeline use of $_ instead of param() in ValidateScript().
I've been favoring $_ over param() for scriptblock predicates like ServerCertificateCustomValidationCallback mainly because the param() block ends up being repeated, often overshadows the predicate in character count, and usually doesn't provide much useful information to a reader.
Here's a mock-up of param() vs $_ for illustration:
{
    param($Message,$Cert,$Chain,$PolicyErrors)
    Assert-CertificateCompliance -Policy Strict -Message $Message -Cert $Cert -Chain $Chain -PolicyErrors $PolicyErrors
}

{$_ | Assert-CertificateCompliance -Policy Strict}

For me the point of this PR is to be able to impose per-URL certificate requirements.  So I'll end up with policy data structures looking something like this:
@{
    Uri = 'https://github.com'
    CertificateValidator = {
        $_ | Assert-CertificateCompliance -Policy Strict
        $_ | Assert-Certificate Server -Thumbprint d79f076110b39293e349ac89845b0380c19e2f8b
    }
}

@{
    Uri = 'https://www.powershellgallery.com'
    CertificateValidator = {
        $_ | Assert-CertificateCompliance -Policy Strict
        $_ | Assert-Certificate Intermediate -Thumbprint 98af62baa639b0827f887c75a77f4afd4eff2685
    }
}

The validation scriptblock gets repeated for each uri so noise from param() adds up.

@alx9r no, using members of $_ wasn't something that was considered and is an interesting approach.  Would like some others to chime in on this proposal.  cc @lzybkr @JamesWTruher @HemantMahawar

@SteveL-MSFT I had an early draft that did it that way. I had dropped it in favor of the automatic variables before submitting the PR.

@markekraus sorry, must have missed it.  Getting myself involved in too many discussions on here to keep track of them (something I'm learning not to do!)

@SteveL-MSFT I don't think the draft ever made it's way to my public repo so I don't think you missed anything, actually. My point was more that I'm on board with the idea of a $_ with members if that lends any weight in the decision making.

After much trial and error I determined that the only safe way to do this where any kind of event triggers were in place was run the ScriptBlock in a completely new session state and runspace. Variables could easily be imported, but I did tests where the event triggers updated a variable at that same time as callback and that resulted in a hang. Importing functions and modules leaves them in a disconnected state from the user's context (module scoped variables are lost).
I have incorporated the $_. I'm open for suggestions on renaming the members. Right now they are Request, Certificate, CertificateChain, and SslErrors. This current implementation does not support param(). I'm assuming we want to go with one or the other and not both.
I have tested the current code with the event triggers @lzybkr provided and it works. no hangs.
The down side is that the ScriptBlock is now devoid of the calling scope. I was originally under the impression it would need to be done this way and I think that so long as it is documented it should be acceptable. Any of the other means of making the scope available results in either unpredictable behavior or hangs. I think no scope is better than some broken scope.

...I did tests where the event triggers updated a variable at that same time as callback and that resulted in a hang.

I'm curious what these tests looked like.  It doesn't seem like Register-ObjectEvent naturally accepts PSVariables in its parameters.  It also doesn't seem like the Register-ObjectEvent -Action scriptblock has access the call site's variables.  In the tests that hung how did the event handler get a reference to the same variable as the callback?

I have incorporated the $_. I'm open for suggestions on renaming the members. Right now they are Request, Certificate, CertificateChain, and SslErrors.

I see that the current documentation for HttpClientHandler.ServerCertificateCustomValidationCallback doesn't name its parameters.  For that matter, there is very little documentation about the semantics of that callback altogether.  dotnet/corefx#24774 might improve that documentation and that might lead to parameter names.  If ServerCertificateCustomValidationCallback does end up with documented parameter names, it seems like the properties on $_ should have identical names.  The closest documented callback interface seems to be full .net's System.Net.Security.RemoteCertificateValidationCallback.  I propose adopting the corresponding names from that callback interface in the meantime.

The down side is that the ScriptBlock is now devoid of the calling scope. I was originally under the impression it would need to be done this way and I think that so long as it is documented it should be acceptable. Any of the other means of making the scope available results in either unpredictable behavior or hangs. I think no scope is better than some broken scope.

Is there a reason that the scope rules wouldn't be the same as for other scriptblocks using remote variables?  Invoke-Command -Session -ScriptBlock, for example, provides access to local variables in the remote session by way of the $using: expression.
FWIW, I think this would be a pretty awkward interface without having some way of making user objects available in the callback scriptblock.  A natural use would be as follows:
@{
    u='https://github.com/some/important/file'
    thumbprint = 'd79f076110b39293e349ac89845b0380c19e2f8b'
},
@{
    u='https://powershellgallery.com/some/other/important/file'
    cv = '98af62baa639b0827f887c75a77f4afd4eff2685'
} |
    % {
        # ... do some prep things
        Invoke-WebRequest $_.u -CertificateValidationScript {
            # ... a bunch of tests that are identical for every certificate
            $_.Certificate.Thumbprint -eq $using:_
        }
        # ... do some cleanup things
    }

Without $using:, arguments, or some other means of passing data, it will be tough to separate the concern of which thumbprints are acceptable for which url from the concern of checking for certificate revokation, for example.

I'm curious what these tests looked like.
I just used the same variable in @lzybkr's example and used it

$t = [System.Timers.Timer]::new(10)
$t.AutoReset = $true
Register-ObjectEvent -InputObject $t -EventName Elapsed -Action { Write-Host 'event' }
$t.Enabled = $true
$script = {$t.Enabled = $false; $true}
irm -uri https://expired.badssl.com
#hangs

$t was being populated as a PSVarabile in the iss.

I propose adopting the corresponding names from that callback interface in the meantime.

I disagree. Unless it is documented on this API, we should use something generic that is easier for PowerShell users to use. Sender is a terrible choice when it's an HttpRequestMessage. If Sender were the documented name for this API, then I would concede that's probably better.

Is there a reason that the scope rules wouldn't be the same as for other scriptblocks using

$using in every instance I've seen is a unique implementation. If there were a generic API for adding this capability to a ScriptBlock, then $using: would be awesome to have here. but I see no point in adding yet-another-using-implimentation for validation callbacks on cmdlets that don't normally do any work with ScriptBlocks.

Without $using:, arguments, or some other means of passing data,..

Erm, not really? I mean yea, not on the ease of use level that using variables from the calling scope or $using:, but, most validation logic is fairly static, in my experience. Create module, Import it in the ScriptBlock, magic. or use CSV, Clixml, JSON files for confgis if you don't wants it hard coded in the the PS Script.
I'm not saying this is ideal. What I am saying is that I can't see a safe way to get the calling scope available in the remote scope with out severely over-complicating the implementation.
Also, these validations scripts are "per call". For 6.1 I want to look at adding session persistent options. One of them will be add your own .NET delegates for cert validation, So if you want to have some variable magic then you can. The goal in this PR is to provide the basic implementation that will work for most people on a "per call" basis. I think most will just need to ensure a static thumbprint or 2 against URLs. Complex validation scenarios are not the goal of the implementation in this PR, but are on my radar for the futre.

Complex validation scenarios are not the goal of the implementation in this PR, but are on my radar for the futre.

OK.  Got it.  Thanks @markekraus

rebased to fix merge conflict.

@markekraus Athother merge conflict.

rebased.

@PowerShell/powershell-committee reviewed this and recommends using the param() format.  Specifically, $_ provides no context on what it represents.  Typically $_ means the current object and reusing it in the scriptblock changes that expectation.  Using param() makes the code more readable and therefore maintainable.

@markekraus Please rebase with next new commit to get latest updates and pass CIs.

@iSazonov I still need to incorporate the changes per the committee's decision. I will hopefully have free time this week. I will rebase before I commit the changes.

FYI, I'm waiting on #5518 as this will need to rebased again and more drastically.

Due to the issues of rebasing this and that the code still needs to be updated to fit the review comitee's decision, I'm going to close this PR. I will attempt to address this feature before 6.1.0.


Extract creation of sortedStackedBars to a transform data method

Planning poker score: 1 (0-89 Fibonacci)

Can get conflicts with #106


Fix get params for urls in css

Fix for issue #147

Hi. Thank you for contribution. Can you please add test for this functionality?

@stereobooster When will you be able to merge and release a new version of the package?

I can merge, but we need to wait @peterbe to release it

@peterbe can you release new version with this fix?


Feature/2276 Make candidate responses to bespoke question on Ex.187 visible

What's included?
Closes #2276
Who should test?
✅ Product owner
✅ Developers
How to test?
Example application: https://jac-admin-develop--pr2277-feature-2276-candida-ed5kqmxt.web.app/exercise/09zuw8tcILdrH2DJZA2g/applications/draft/application/aYWsPP6QjSVD9mmhGYtR
Go to the application and check if "Resignation from the Department for Work and Pensions (DWP)" section appears.
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Additional context

apply site

admin site

Related permissions
Have permissions been considered for this functionality?

No permission changes required
Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@nickaddy I just copied the second question from apply. Not sure if the wording needs to be updated.


Switch off performance-enum-size clang-tidy check for now.

It warns on every enum if it is smaller than fitting into a uint32_t to use a smaller type. While it might be an interesting exercise at some point to look at these, right now, this is a somewhat noisy check.

About 1/6 of the lines from clang-tidy over all code in OpenRoad_clang-tidy.out are due to this warning (with a lot of duplicates as it creates a new warning in each header it finds an enum with that condition)

Are these in face many unique problems or just many instances of a few problems that fall in headers?  Given the potential memory savings I'd like to analyze it more before turning it off.

Missing DCO

Are these in face many unique problems or just many instances of a few problems that fall in headers? Given the potential memory savings I'd like to analyze it more before turning it off.

There are many duplicates, I think unique mentions are about 200ish. In particular if enums are stored in tight data structures, that can be super-useful indeed; if this is data at rest somewhere (if it is serialized in some form), it is probably good to double-check that this does not mess up anything in the storage format.

You can find all the instances by looking through the clang-tidy output:
grep performance-enum-size OpenRoad_clang-tidy.out | sort | uniq

What version of clang-tidy are you using?  I get 0 results from that grep.

I'm using Ubuntu LLVM version 14.0.0

I think that check was introduced in 18.  It seems we should start with an agreement on version.
The CI action uses ubuntu-latest which is 22.04 (https://github.com/actions/runner-images) which uses 14.0 by default.  ubuntu-24.04 is on 18

Looks like it will switch to 24 soon https://github.blog/changelog/2024-11-05-notice-of-breaking-changes-for-github-actions/

I am using clang-tidy 18.1.8 (nixos unstable)

With 18 I still only see   240 [performance-enum-size] in the summary

yep, 240 sounds about right (in the *.out file you see a lot of duplicates because each file that includes a header with an enum, it reports it anew. Maybe I should pre-filter in each of the out files first).

After playing with it for a quite a while I agree to turn this off.  The main problem is working with enums with specified types and bitfields in the db becomes quite a headache.


Mid v1.4 Review

Hi all, I have reviewed your DeveloperGuide in your PR. Do read the comments and change if needed.

Will do. Thank you!

I assume all of us have read the comment. Closing this.


Update speedtest extension

Description
Fix for no internet connection. Also it now catches any exit that is not successful.
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@stevensd2m thanks for the contribution. I will review it in the next 24h.

The only thing I notice is that the metadata images should be with the same background, could you correct them both @stevensd2m 🙂

@pernielsentikaer updated the no-internet-connection background the closest to the already existing one (did not want to actually replace the original one).

We actually need to replace that one too, since it's showing the old design, do you mind doing that one too @stevensd2m  🙂

@pernielsentikaer done :)

Thanks 👏


Model Error: Please provide a model_fn implementation

Summary of Issue
When calling invoke_endpoint function inside of a lambda function generates the following error.
ModelError
Cause
{
  "errorMessage": "An error occurred (ModelError) when calling the InvokeEndpoint operation: Received server error (500) from model with message \"\nPlease provide a model_fn implementation.\nSee documentation for model_fn at https://github.com/aws/sagemaker-python-sdk\n\nTraceback (most recent call last):\n  File \"/opt/conda/lib/python3.6/site-packages/sagemaker_inference/transformer.py\", line 110, in transform\n    self.validate_and_initialize(model_dir=model_dir)\n  File \"/opt/conda/lib/python3.6/site-packages/sagemaker_inference/transformer.py\", line 158, in validate_and_initialize\n    self._model = self._model_fn(model_dir)\n  File \"/opt/conda/lib/python3.6/site-packages/sagemaker_pytorch_serving_container/default_inference_handler.py\", line 48, in default_model_fn\n    \"\"\"))\nNotImplementedError: \nPlease provide a model_fn implementation.\nSee documentation for model_fn at https://github.com/aws/sagemaker-python-sdk\n\n\". See https://us-east-2.console.aws.amazon.com/cloudwatch/home?region=us-east-2#logEventViewer:group=/aws/sagemaker/Endpoints/testPyTorchEndpoint in account<PHONE_NUMBER>54 for more information.",
  "errorType": "ModelError",
  "stackTrace": [
    "  File \"/var/task/index.py\", line 46, in handler\n    batchPredictions()\n",
    "  File \"/var/task/index.py\", line 17, in batchPredictions\n    response = runtime.invoke_endpoint(EndpointName=endpointName,\n",
    "  File \"/var/runtime/botocore/client.py\", line 357, in _api_call\n    return self._make_api_call(operation_name, kwargs)\n",
    "  File \"/var/runtime/botocore/client.py\", line 676, in _make_api_call\n    raise error_class(parsed_response, operation_name)\n"
  ]
}

Model tarball was created using the following steps from the files in this repo:
Generate a trained model file last_saved.pt and store in auto-labeler/scibert/sagemaker/
Delete auto-labeler/scibert/sagemaker/test.py file. It's only used for locally generating inferences using the model and isn't needed by Sagemaker.
Move generate.py and requirements.txt to a new folder auto-labeler/scibert/sagemaker/code/
Rename sagemaker folder to scibert-X.X-model. Replace X.X with the next version numbers ex. 0.1 to 0.2.
Run tar -cvzf scibert-X.X-model.tar.gz scibert-X.X-model to generate a tarball.
Upload tarball to s3://petal-bucket
Issue Type

[x] Bug
[ ] Enhancement

Environment
GCC AWS PETAL account.
Operating System: https://github.com/nasa-petal/PeTaL-db/blob/main/dynamodb-cf-template.yaml#L352
Python environment: https://github.com/aws/deep-learning-containers/blob/master/available_images.md#elastic-inference-containers

I ran this from CloudShell
aws sagemaker create-model --cli-input-json file://create_model.json
aws sagemaker create-endpoint-config --cli-input-json file://create_config.json
aws sagemaker create-endpoint --endpoint-name 'pytorchendpoint' --endpoint-config-name 'pytorchconfig'
aws sagemaker-runtime invoke-endpoint --endpoint-name 'pytorchendpoint' --body fileb://input.json --content-type=application/json output_file.txt

invoke-endpoint gives same model_fn not found error. My hunch is that the problem lies with a misconfiguration of either container image I'm using and/or the environment variables SAGEMAKER_PROGRAM or SAGEMAKER_SUBMIT_DIRECTORY.
Next I tried modifying the container image in create_model.json to this<PHONE_NUMBER>84.dkr.ecr.us-east-2.amazonaws.com/pytorch-inference:1.8.1-cpu-py36-ubuntu18.04
invoke-endpoint now times out.
create_model.json
{
    "ModelName": "pytorchmodel",
    "PrimaryContainer": {
        "Image": "763104351884.dkr.ecr.us-east-2.amazonaws.com/pytorch-inference-eia:1.5.1-cpu-py36-ubuntu16.04",
        "ModelDataUrl": "s3://petal-bucket/linear-regression.tar.gz",
        "Environment": {
            "SAGEMAKER_PROGRAM": "inference.py",
            "SAGEMAKER_SUBMIT_DIRECTORY": "/opt/ml/model/code",
            "SAGEMAKER_CONTAINER_LOG_LEVEL": "20",
            "SAGEMAKER_REGION": "us-east-2",
            "MMS_DEFAULT_RESPONSE_TIMEOUT": "500"
        }
    },
    "ExecutionRoleArn": "XXXXXXX"
}

linear-regression.tar.gz
linear-regression.tar.gz/
|- model_0.pth
|- code/
  |- inference.py
  |- requirements.txt


Added option to add or remove colors

Implementation of add and remove color buttons, users can inform the hex code of a color and after pressing the "Add Color" button it will be created a button in the menu with the new color and the extension will change to this color, pressing the "Remove Color" button will remove the menu button of the color informed, the only color that can't be removed is crunchyrollOrange.
Changes:
Created add and remove color buttons
Using Promises to get user chrome data
Removed change color button
Current options page:

Increase the Remove Color button size

Increase the Remove Color button size. In the case, the best would be to have the width auto with horizontal padding.

New design:


Add option to defer initial host change detection

I've been trying to test a directive with EasyTestWithHost and it's fantastic for all my cases save one -- I have one test case where I need to set-up a spy which I know should get triggered in the initial change detection cycle (in ngAfterContentInit in my case).
If I do TestBed.get(token) before I called this.create() (in order to spy on a method), I get an error saying overrideComponent cannot be called after inject which makes sense. Ideally I'd like to have an option for this.create() which suppresses the first change detection in the host so that I can call it once I've created my spy.
Looking at the code, this may not be a trivial change as the change detection may be needed for other aspects of the test set-up. I'll have a play if I get time and submit a PR.

Thanks, this is a great idea. I am quite busy right now, but I would love to see a PR.

I think you can add a little example, so others ( or me ) will try to add this too.

Let me see if I can chop down my code to a simple use-case to give a concrete example

Here's an example of the problem: https://gist.github.com/euangoddard/d5f63ab13153fac5e99789b406293e6a
This use-case is a lot more simplistic than I have and in the example given I could override the provider when I set up the testing module. That option isn't available to me in the real case

This is the line where change detection is triggered:
https://github.com/NetanelBasal/ngx-easy-test/blob/master/src/easy-test.ts#L165
Try remove it temporarily and see if it's working.

We have new API with support for your request. Check it.

That looks perfect. I'll try it out when I get a chance. Many thanks for this!


Make less strict ESLint config for testing files

Testing requires creating mocks and using fixtures and sometimes uglier mutable code. This is fine (and sometimes preferred) for tests, but with our strict production ESLint configuration we need to use multiple eslint disable comments which is ugly.
We could turn off the problematic rules in the test config (only applied for tests files based on filename pattern).

Close now that the eslint plugin has moved?

I'd transfer instead. That said, this is not necessarily the priority.


python3Packages.omnikinverter: 0.6.2 -> 0.7.0

Motivation for this change
https://github.com/klaasnicolaas/python-omnikinverter/releases/tag/v0.7.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 159982 run on x86_64-linux 1

2 packages built:

python310Packages.omnikinverter
python39Packages.omnikinverter


ms-sys: avoid leaking the build timestamp into the manpage

Also proposed upstream as https://sourceforge.net/p/ms-sys/patches/8/
Motivation for this change
This makes the ms-sys deterministic, so building the same sources always produces the same bits.
Can be verified with nix-build '<nixpkgs>' -A ms-sys --check
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Added comment, merging.


Performance

The way exif gets data is unnecessarily bad for performance. Suppose I want one tag (in my case, orientation), getImageData actually parses EXIF, IPTC, and XMP data before I can ask for my one tag). A simple improvement would be:
getData() accepts a third "types" parameter, which defaults to {exif: true, iptc: true, xmp: true} and then handleBinaryFile only gets the data the user asks for:
    // FIX add types parameter
    function getImageData(img, callback, types) {
        if (typeof types !== 'object') {
          types = {
            exif: true,
            iptc: true,
            xmp: true,
          };
        }
        function handleBinaryFile(binFile) {
          // FIX use types parameter to skip stuff
            var data = types.exif ? findEXIFinJPEG(binFile) : false;
            var iptcdata = types.iptc ? findIPTCinJPEG(binFile) : false;
            var xmpdata= types.xmp ? findXMPinJPEG(binFile) : false;
            img.exifdata = data || {};
            img.iptcdata = iptcdata || {};
            img.xmpdata = xmpdata || {};
            if (callback) {
                callback.call(img);
            }
        }

I should add that the code in handleBinaryFile is unnecessarily verbose; you could write three lines of code instead of six:
img.iptcdata = types.iptc ? findIPTCinJPEG(binFile);
And just have the parsers return {} instead of false.
This simple change gives me a >2x speedup when handling an image, and given that parsing a smartphone photograph takes 800-2000ms on a fast laptop this is not insignificant.

Actually the performance hit is less significant than I thought because the big hit is the http request that pulls the file a second time (sigh).

Thanks.
Ur advice does really help on my project about APP.
The performance hit is much more enlarged in a small APP than a laotop.
I use it to solve the orientation issue in Hybrid APP which using HTML input(type="file") to select photo from users' mobilephone.
Thanks Indeed.


How to support bower?

To supprot bower, I find in https://webpack.github.io/docs/usage-with-bower.html .
but not work;
and then I find other in https://github.com/lpiepiora/bower-webpack-plugin
but also not work;
I want to use vaadin UI components that It's build bower.
Am I missing something?

The starter doesn't support bower, most won't anymore.
For reference, the vast majority of the JavaScript community has moved away from Bower, the reasons are too numerous to bother mentioning.
Point being, as opposed to trying to wedge Bower in anyone of the current starters I highly suggest you simply stop using it.


Question: How to know if LhInstallHook succeeded

Are you referring the native API or the .NET method?
In the native API it will return STATUS_SUCCESS for success. Otherwise, STATUS_NO_MEMORY (unable to find appropriate block of memory within range of target entry point), STATUS_NOT_SUPPORTED (the target entry point contains unsupported instructions) or STATUS_INSUFFICIENT_RESOURCES (too many hoks)
In the .NET wrapped method it will throw an exception if an error occurs.


Video lag issue, when there are around 40 participants.

Hi,
Thanks for the idea, have implemented it on my side and have used it for around 6 months it was working quite well until we discovered a very disturbing issue which forced us to quit this architecture and move to some open source SFU.
We faced the video lag issue, when there are around 40 participants lets say, and I debugged it for around 10 days and found some of the root causes of the issue that made me think that we can't move forward with this architecture, kindly share your thoughts on this.
This issues even exists on the demo application as well.
One of the main issues I found was that the call was running in a tab in headless browser and that tab is a process and that is running on a core in cpu but when number of videos increase the canvas drawing gets increases and a time comes when the core of the tab get to its maximum and everything starts to cause issues like video lag.
I tried to do various things to tackle it:
Dividing the call on multiple tabs to use more than one cpu cores to get full potential of the cpu and one way was to open child tab but the issue was that the child tab is not a separate process it shares the same cpu core as of it's parent so it didn't help then there was another way to open child tab in a way that it runs in a separate tab but it can't access the data of the parent tab so the child tab was a separate process but the major issue was that now it can't access the streams in parent tab and parent tab can't access the streams in child tab. I tried another thing to share streams between parent child which was to make local peer connections between tabs which made it possible to share the streams between parent and child but it was a very tight structure, anything happened with the local peer connection and whole thing will start causing issues so I didn't pursue that. So in short this parent child tab things didn't helped.
Using web workers to achieve kind of multi threading , it had the same issue it can't access the tab's streams but I tried another thing like I tried to move the canvas rendering to the workers for that I need to send the streams data somehow to the worker so I uses one of the browser's api to share data from tab to web worker, I basically captured frames from video and starting sending it to web worker but this was quite overhead as well because there were many streams and each streams have many frames and it caused a lot of issues because of that. So it didn't worked as well.
So at the end I have to move away from this architecture and use some other stuff. It was a really good idea to use headless browser to achieve the MCU concept in our own tech stack but I think browsers have their own limitations.
Kindly share your thoughts on this, thanks @mganeko
Here are the server specs:
OS: Linux
Cores: 32 cores

Thank you for trying this repo.
MCU is heavy task, so I do not recommend to use it for more than 25 participants.
I think SFU is good option.

Ok I think it should be mentioned in the docs somewhere. I actually tried it on a big application, worked for around 2 months and after some time stuck into this issue.
It even cause issue for 5 participants as well not in the example but in my app and the reason is that in example only one canvas is being used but in my app i create n canvases based upon the participants screen dimensions.
MCU is heavy task, and the best solutions for these things are c++ based solutions but browsers are definitely good choice for these things, like you said it can be used to some extent for few participants but the main purpose of MCU is to achieve large number of participants which with this approach can't be achieved.

Regarding SFU:
I tried sfu with headless approach as well but the  CPU usage was too high and the reason was the encoding/decoding of streams on the server.
As in SFU the outgoing streams from server increase exponentially so the encoding/decoding of streams just east the CPU resources.
So even for SFU the best approach is the c++ based solutions. They have customized the webrtc so that the server doesn't encode/decode the stream packets it just routes them as it is.


[SINHALA] Link to USE documentation is broken

Link to USE spec the introduction is broken <https://docs.microsoft.com/en-us/typography/OpenTypeDev/USE/>
Should direct to https://docs.microsoft.com/en-us/typography/script-development/use instead.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7b600ff4-6e07-bce1-ac22-14bbecfa9ea4
Version Independent ID: f9de5cd2-043e-5e2b-33d7-7c27b10f2928
Content: Creating and Supporting OpenType Fonts for Sinhala Script - Typography
Content Source: typographydocs/script-development/sinhala.md
Product: windows
GitHub Login: @mijacobs
Microsoft Alias: mijacobs

Closing as Fixed.


Create Default Builder also seems to do some other static files stuff

When running on a Development environment inspecting the IWebHostEnvironment.WebRootFileProvider immediately in startup.cs Configure method:
    public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
        {

Shows me that WebRootFileProvider is now being set to a composite that inlcudes static files (web assets) from project references "wwwroot" directories as well as "bin/{build-config/{target-framework}/wwwroot" directories. I assume this host.CreateDefaultBuilder configuring this and including static web assets from referenced projects for you - but I can't see this documented anywhere. Is here the right location for that?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d47f38e2-bc36-cfb8-b0cc-17a534689f8b
Version Independent ID: 3fec6e08-fc99-7a5c-796f-3f2347cad891
Content: Static files in ASP.NET Core
Content Source: aspnetcore/fundamentals/static-files.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

It sets the content root directory and other things.
You can look at the source to see all that it's doing, but you can't access static files without calling app.UseStaticFiles();

@Rick-Anderson - understood.
I wasn't very clear though so apologies, and just let me make sure I have actually put my point accross - if you still dismiss it fair enough.
The docs specifically talk about serving files within the "WebRoot" directory (its all over them).
With the introduction of "Static Web Assets" this is no longer true when the environment is a "Development" Environment.
I thought it might be worth mentioning that when the environment.IsDevelopment is true, the host will serve up files from outside the projects "web root" folder, by virtue of using the new manifest file that is produced by a build - there are "content root" paths in there that point to possibly other locations:

Locally referenced projects "wwwroot" and bin/ output directories
Referenced NuGet packages that contain static web assets.

CreateDefaultBuilder doesnt just set content root (which has no impact on static files, web root does) - it now also extends WebRootFileProvider to include additional ones to serve outside the webroot directory, but only for Development environments.
I think it might benefit the docs to mention this or link to some other doc that describes this feature, but I'm just putting it out there - if you think otherwise obviously happy to leave this issue closed!
Cheers

@dazinator  that's good information. Yes, in dev mode there is more access. This info might be useful because an app that works in dev mode won't work in production mode because it's using resources only available in dev mode.

@Rick-Anderson

because an app that works in dev mode won't work in production mode because it's using resources only available in dev mode.

In production mode (after a dotnet publish occures) these static assets that get sourced from the manifest, are copied by dotnet publish into the wwwroot directory of the published application. Therefore in production mode, all the same assets should still be reolvable using the same subpaths as before and the application should work as it always has - except now there is no manifest mapping those assets to their source locations.

The only time I think you could hit an issue is if you were to dotnet run a non published application 's binaries (bin output folder) on a non Development environment - where those sources (projects and nuget packages) weren't available. I think it's fairly safe to say that this isn't typical or recommended workflow however :-)

Moved to Static files master issue and update to 3.1 #13599


code style templates bool isRequest

Version of Beast
v67
issue
throughout the library you use
template<bool isRequest, [...]
which results in
beast::http::parser<true, [...]>
wouldn't it be cleaner if it'd be
template<enum Type, [...]
with the result
beast::http::parser<beast::http::type::request, [...]>
https://blog.ometer.com/2011/01/20/boolean-parameters-are-wrong/

Robert C. Martin's Clean Code Tip #12: Eliminate Boolean Arguments

You want to add enum type to beast::http::?

no. I'm suggesting, that using true/false for the message type may gets interpreted as "bad practice".

Well you're not the first to complain :) I rather like bool. Its concise and expresses the dual nature of messages quite well. I have no desire to replace bool, true, and false with beast::http::kind, beast::http::kind::request, and `beast::http::kind::response'.

check, asked and answered :smile:

If you feel strongly about it, consider participating in the Boost formal review! Just sign up at the Boost developers mailing list. Any comments or criticisms are welcome. You can raise this point, but if you would offer a post with your experiences using the library (good or bad) that would be extremely helpful not only for the formal review process but also to help me make the library better at suiting everyone's needs. Sign up here:
http://www.boost.org/community/groups.html#main


Update to SDK version 1.11

Looks like this was superseded by 1.12.3 :) https://github.com/pd-rs/crankstart/commit/280936bb953c0467849b34b58c1caa1c790c79fb

Yep.


getting ipmag.plot_net() to be the same size in subplots

Is your feature request related to a problem? Please describe.
At present, when you try to embed ipmag.plot_net() within subplots they end up being different sizes. It would be nice if there are the same size. I don't know why this is happening as one would think they would be the same size.
Additional context
Here is an example (the difference is subtle, but enough to be a problem):

you can try to change the figure size, making the height a little smaller

Can you give some example code that has worked to get them the same size?

if the figure size is (10,4), then you get different sizes of subplots

if you change the figure size to (10,3), then the sizes of subplots become the same

Interesting. That is a rather unsatisfying solution, however, as it would be nice to have an approach that makes them the same size regardless of the choice of overall dimensions.

I guess the problem is that the plot_di_mean function was created for a single figure but if you make subplots, the code will want to fill the entire space of the figure, causing the sizing issue. I think another option is to specify the size of each subplot.
I had similar problems with Matlab. Sometimes I use the tiled layout instead of subplots to resolve the issue.


Unable to find "Business document management" on feature management page

"Enable Business document management" seems outdated.
Currently the web page says:
To start Business document management, you need to open the Feature management workspace and enable the Business document management feature.
Use the following procedure to enable Business document management functionality for all legal entities.
Open the Feature management workspace.
On the New tab, select the Business document management feature in the list.
Select Enable now to turn on the selected feature.
Refresh the page to access the new feature.
However, on Update35 there are not feature called "Business document management"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0c9d868b-2b3b-26c9-f8ff-863e6f8cd9d4
Version Independent ID: 9ea7a0a4-99ab-aca8-ca48-62ee8c02a92b
Content: Business document management overview - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/analytics/er-business-document-management.md
Service: dynamics-ax-platform
Product: ****
Technology: ****
GitHub Login: @NickSelin
Microsoft Alias: nselin

Thank you for your feedback. @NickSelin can you please take a look?

@NickSelin, BUG 469227 created to track the issue.

@artemt1, can you click the Check for updates button to refresh the list of available features and make the Business document management feature available for enabling as described in the Feature management overview topic? Thank you!


make users optional when creating and interacting with sessions

Partial work on this has been done.
Creating sessions without a user is possible. However calling sessions.chat without specifying  a user causes a 404 error:
ApiError: status_code: 404, body: {'error': {'message': 'Session <session_id> not found for developer <dev_id>'}}

Closed via #338