Misleading display of occurrence polygon as a single point

The occurrences in this data set are polygons in WKT format (the data also contains the centre point of each polygon). The GBIF portal displays these occurrences as point localities, whereas they are fairly sizeable polygons - see attached screenshot for MULTIPOLYGON(((7.60206388888889 50.0938677383311,7.58881388888889 50.5434074870227,8.29440388888889 50.549817483425,8.30102388888889 50.1001777348173,7.60206388888889 50.0938677383311))) (based on http://openlayers.org/en/master/examples/wkt.html )
It would be great if the portal could display WKT as this gives the user a much better sense of what the data represents. This occurrence is not a single point locality at a single time, but summarises 10,000-99,999 observations in a rectangular area over more than two decades (1972-1995).
from
http://dev.gbif.org/issues/browse/PF-2281?jql=project %3D PF AND status %3D Open

@thomasstjerne might be worth mapping this as well then? https://www.gbif.org/occurrence/1229591899


snapcraft: Consider debian ppc64el convention

Debian convention is to call it endian little rather than little endian,
hence ppc64el rather than ppc64le. So if build system is debian,
then snap image built on it will fail to set the correct qemu binary
name.
Fixes: #473
Signed-off-by: Nitesh Konkar<EMAIL_ADDRESS>

/test

@nitkon I included this patch in the snap-next branch and a new 1.6.2 version was released, you can install it running: sudo snap install kata-containers --candidate --classic  or downloading and installing directly the .snap file from here https://launchpad.net/~kata-containers-dev/+snap/snap-next/+build/544721

@nitkon does this new version works for you?

@devimc : Nope
root@01:/home/nitesh/split_patch# sudo snap install kata-containers --edge --classic
kata-containers (edge) 1.7.0-alpha1 from Kata Containers (katacontainers*) installed

root@01:/home/nitesh/split_patch# ls -lrt /snap/kata-containers/current/usr/bin/qemu-system-ppc64
-rwxr-xr-x 1 root root 15775584 May  1 06:47 /snap/kata-containers/current/usr/bin/qemu-system-ppc64

root@01:/home/nitesh/split_patch# sudo docker run -ti --runtime kata-runtime busybox sh
docker: Error response from daemon: OCI runtime create failed: /etc/kata-containers/configuration.toml: file /snap/kata-containers/current/usr/bin/qemu-system-ppc64le does not exist: unknown.

@nitkon I moved it to candidate, sudo snap install kata-containers --candidate --classic

@devimc :
root@01: sudo snap install kata-containers --candidate --classic
kata-containers (candidate) 1.6.2 from Kata Containers (katacontainers*) installed

root@01: cat /snap/kata-containers/current/usr/share/defaults/kata-containers/configuration.toml

[hypervisor.qemu]
path = "/snap/kata-containers/current/usr/bin/qemu-system-ppc64le"

But we want: path = "/snap/kata-containers/current/usr/bin/qemu-system-ppc64"

@nitkon I have set -x, the job will run asap  https://launchpad.net/~kata-containers-dev/+snap/snap-next

@nitkon
Building runtime
+ uname -m
ppc64le
+ pkg_name=runtime
+ realpath go
+ export GOPATH=/build/kata-containers/parts/runtime/build/go
+ realpath ../../go/build
+ export GOROOT=/build/kata-containers/parts/go/build
+ export PATH=/build/kata-containers/parts/go/build/bin:/build/kata-containers/stage/usr/sbin:/build/kata-containers/stage/usr/bin:/build/kata-containers/stage/sbin:/build/kata-containers/stage/bin:/build/kata-containers/parts/runtime/install/usr/sbin:/build/kata-containers/parts/runtime/install/usr/bin:/build/kata-containers/parts/runtime/install/sbin:/build/kata-containers/parts/runtime/install/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin
+ pkg_gopath=/build/kata-containers/parts/runtime/build/go/src/github.com/kata-containers/runtime
+ mkdir -p /build/kata-containers/parts/runtime/build/go/src/github.com/kata-containers/runtime
+ git clone -b 1.6.2 https://github.com/kata-containers/runtime /build/kata-containers/parts/runtime/build/go/src/github.com/kata-containers/runtime
Cloning into '/build/kata-containers/parts/runtime/build/go/src/github.com/kata-containers/runtime'...
Note: checking out '60a989f2a136f79a2ddffc446becdd35da736004'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

[03/May/2019:15:26:36 +0000] "CONNECT github.com:443 HTTP/1.1"<PHONE_NUMBER> "-" "git/2.17.1"
+ cd /build/kata-containers/parts/runtime/build/go/src/github.com/kata-containers/runtime
+ uname -m
+ arch=ppc64le
+ [ ppc64le == ppc64le ]
/bin/sh: 45: [: ppc64le: unexpected operator
+ [ ppc64le == ppc64el ]
/bin/sh: 45: [: ppc64le: unexpected operator
+ make PREFIX=/snap/kata-containers/current/usr SKIP_GO_VERSION_CHECK=1 QEMUCMD=qemu-system-ppc64le

@devimc: I have updated the PR. Can you re-trigger the build snap-next?

/retest

@nitkon done

@nitkon  now I think everything is ok
Building runtime
+ pkg_name=runtime
+ realpath go
+ export GOPATH=/build/kata-containers/parts/runtime/build/go
+ realpath ../../go/build
+ export GOROOT=/build/kata-containers/parts/go/build
+ export PATH=/build/kata-containers/parts/go/build/bin:/build/kata-containers/stage/usr/sbin:/build/kata-containers/stage/usr/bin:/build/kata-containers/stage/sbin:/build/kata-containers/stage/bin:/build/kata-containers/parts/runtime/install/usr/sbin:/build/kata-containers/parts/runtime/install/usr/bin:/build/kata-containers/parts/runtime/install/sbin:/build/kata-containers/parts/runtime/install/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin
+ pkg_gopath=/build/kata-containers/parts/runtime/build/go/src/github.com/kata-containers/runtime
+ mkdir -p /build/kata-containers/parts/runtime/build/go/src/github.com/kata-containers/runtime
+ git clone -b 1.7.0-alpha1 https://github.com/kata-containers/runtime /build/kata-containers/parts/runtime/build/go/src/github.com/kata-containers/runtime
Cloning into '/build/kata-containers/parts/runtime/build/go/src/github.com/kata-containers/runtime'...
Note: checking out '717a30bfe04e158daacf0daeb16a6528d06f8148'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

[03/May/2019:18:33:38 +0000] "CONNECT github.com:443 HTTP/1.1"<PHONE_NUMBER> "-" "git/2.17.1"
+ cd /build/kata-containers/parts/runtime/build/go/src/github.com/kata-containers/runtime
+ uname -m
+ arch=ppc64le
+ [ ppc64le = ppc64le ]
+ arch=ppc64
+ make PREFIX=/snap/kata-containers/current/usr SKIP_GO_VERSION_CHECK=1 QEMUCMD=qemu-system-ppc64
     CLEAN   clean
     GENERATE cli/config-generated.go
     CONFIG  data/kata-collect-data.sh
kata-runtime - version 1.7.0-alpha1 (commit 717a30bfe04e158daacf0daeb16a6528d06f8148)

• architecture:
	Host:
	golang: ppc64le
	Build: ppc64le

• golang:
	go version go1.10.4 linux/ppc64le

• hypervisors:
	Known: firecracker qemu
	Available for this architecture: qemu

• Summary:

	destination install path (DESTDIR) : /
	binary installation path (BINDIR) : /snap/kata-containers/current/usr/bin
	binaries to install :
	 - /snap/kata-containers/current/usr/bin/kata-runtime
	 - /snap/kata-containers/current/usr/bin/containerd-shim-kata-v2
	 - /snap/kata-containers/current/usr/libexec/kata-containers/kata-netmon
	 - /snap/kata-containers/current/usr/bin/data/kata-collect-data.sh
	configs to install (CONFIGS) :
	 - cli/config/configuration-qemu.toml
	install paths (CONFIG_PATHS) :
	 - /snap/kata-containers/current/usr/share/defaults/kata-containers/configuration-qemu.toml
	alternate config paths (SYSCONFIG_PATHS) :
	 - /etc/kata-containers/configuration-qemu.toml
	default install path for qemu (CONFIG_PATH) : /snap/kata-containers/current/usr/share/defaults/kata-containers/configuration.toml
	default alternate config path (SYSCONFIG) : /etc/kata-containers/configuration.toml
	qemu hypervisor path (QEMUPATH) : /snap/kata-containers/current/usr/bin/qemu-system-ppc64
	assets path (PKGDATADIR) : /snap/kata-containers/current/usr/share/kata-containers
	proxy+shim path (PKGLIBEXECDIR) : /snap/kata-containers/current/usr/libexec/kata-containers

     BUILD   /build/kata-containers/parts/runtime/build/go/src/github.com/kata-containers/runtime/kata-runtime
     CONFIG  cli/config/configuration-qemu.toml
     BUILD   /build/kata-containers/parts/runtime/build/go/src/github.com/kata-containers/runtime/containerd-shim-kata-v2
     BUILD   /build/kata-containers/parts/runtime/build/go/src/github.com/kata-containers/runtime/kata-netmon
+ make install PREFIX=/usr DESTDIR=/build/kata-containers/parts/runtime/install SKIP_GO_VERSION_CHECK=1 QEMUCMD=qemu-system-ppc64
kata-runtime - version 1.7.0-alpha1 (commit 717a30bfe04e158daacf0daeb16a6528d06f8148)

right?

@nitkon here is the snap https://launchpad.net/~kata-containers-dev/+snap/snap-next/+build/547995 , use --dangerous to install it, since it's not signed

@devimc : Looks good.
sudo snap install kata-containers --edge --classic
kata-containers (edge) 1.7.0-alpha1 from Kata Containers (katacontainers*) installed

cat /snap/kata-containers/current/usr/share/defaults/kata-containers/configuration.toml | less

# XXX:   Type: kata

[hypervisor.qemu]
path = "/snap/kata-containers/current/usr/bin/qemu-system-ppc64"

@nitkon cool

snap 1.6.2 for ppc updated, please test it
sudo snap install kata-containers --classic

@devimc : I could install the snap and could see the correct qemu name. However kata fails to start on Power due to invalid qemu opiton ... (did not see this issue a few days back)
sudo docker run -ti --runtime kata-runtime busybox sh
docker: Error response from daemon: OCI runtime create failed: unable to retrieve OCI runtime error (open /run/containerd/io.containerd.runtime.v1.linux/moby/43f38076b138e11ab001d81fd83d0316e59010b509af07662e4296144158fb97/log.json: no such file or directory): /snap/kata-containers/current/usr/bin/qemu-system-ppc64 did not terminate sucessfully: qemu-system-ppc64: --root: invalid option


Add default rule on object

This adds a shield parameter to the objectType that will be used if no rule is specified for a field.

Codecov Report

Merging #59 into master will decrease coverage by 0.48%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   98.27%   97.79%   -0.49%
==========================================
  Files          16       16
  Lines         174      181       +7
  Branches       33       36       +3
==========================================
+ Hits          171      177       +6
- Partials        3        4       +1

Impacted Files
Coverage Δ

src/plugin.ts
87.87% <83.33%> (-1.02%)
:arrow_down:

src/index.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8169ef...a242de3. Read the comment docs.


Add clippy target to Makefile

Arguments should match those in the GitHub workflow.

Even this doesn't show errors for me that actions shows. Not sure why.


beacon panic: close of closed channel

keepnetwork/keep-client:v1.3.0-rc.4
2020-09-15T01:52:28.992Z	DEBUG	keep-ethutil	packing parameters for method [relayEntry] with ABI [function relayEntry(bytes _groupSignature) returns()]: [[[24 185 223 129 138 59 78 0 133 201 192 182 195 6 131 29 74 163 249 19 147 19 99 100 66 25 131 23 123 111 49 30 1 232 18 78 112 67 85 205 247 238 7 161 152 56 225 2 190 173 14 35 68 162 200 32 250 143 159 221 124 224 210 136]]]
2020-09-15T01:52:28.992Z	DEBUG	keep-ethutil	resolving error for contract call [{From:[255 14 46 209 160 126 80 65 192 240 212 18 200 96 238 195 171 167 244 189] To:[200 51 122 148 165 13 22 25 21 19 222 244 209 230 26 104 134 191 65 15] Gas:0 GasPrice:<nil> Value:<nil> Data:[172 55 79 75 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 32 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 64 24 185 223 129 138 59 78 0 133 201 192 182 195 6 131 29 74 163 249 19 147 19 99 100 66 25 131 23 123 111 49 30 1 232 18 78 112 67 85 205 247 238 7 161 152 56 225 2 190 173 14 35 68 162 200 32 250 143 159 221 124 224 210 136]}]
2020-09-15T01:52:29.099Z	INFO	keep-relay	relay entry was submitted by the selected group on time at block [8687543]
panic: close of closed channel

goroutine 12138811 [running]:
github.com/keep-network/keep-core/pkg/chain/ethereum.(*ethereumChain).SubmitRelayEntry(0xc000168180, 0xc00f2657c0, 0x40, 0x40, 0xc004fabb08)
	/go/src/github.com/keep-network/keep-core/pkg/chain/ethereum/ethereum.go:203 +0x309
github.com/keep-network/keep-core/pkg/beacon/relay/entry.(*relayEntrySubmitter).submitRelayEntry(0xc00ed87860, 0xc00f2657c0, 0x40, 0x40, 0xc00f075f80, 0x80, 0x80, 0x848fb1, 0xc00f01e5a0, 0xc00f01e6c0, ...)
	/go/src/github.com/keep-network/keep-core/pkg/beacon/relay/entry/submission.go:62 +0x628
github.com/keep-network/keep-core/pkg/beacon/relay/entry.SignAndSubmit(0x1470840, 0xc0000ce6c0, 0x1473700, 0xc0070c6360, 0x1485cc0, 0xc000168180, 0xc000511820, 0x40, 0xe0, 0x21, ...)
	/go/src/github.com/keep-network/keep-core/pkg/beacon/relay/entry/entry.go:150 +0xbae
github.com/keep-network/keep-core/pkg/beacon/relay.(*Node).GenerateRelayEntry.func1(0xc008e18000, 0x1473700, 0xc0070c6360, 0x1485cc0, 0xc000168180, 0xc000511820, 0x40, 0xe0, 0x848fb1, 0xc001449150, ...)
	/go/src/github.com/keep-network/keep-core/pkg/beacon/relay/relay.go:136 +0xd2
created by github.com/keep-network/keep-core/pkg/beacon/relay.(*Node).GenerateRelayEntry
	/go/src/github.com/keep-network/keep-core/pkg/beacon/relay/relay.go:135 +0x328

And here is a bit bigger log snippet.
2020-09-15T01:52:23.428Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:23.428Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:23.428Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:23.428Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:23.429Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:23.430Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:23.508Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:23.508Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:25.250Z	DEBUG	addrutil	ResolveUnspecifiedAddresses:[/p2p-circuit /ip4/<IP_ADDRESS>/tcp/3919 /ip4/<IP_ADDRESS>/tcp/3919] [/ip4/<IP_ADDRESS> /ip4/<IP_ADDRESS>] [/p2p-circuit /ip4/<IP_ADDRESS>/tcp/3919 /ip4/<IP_ADDRESS>/tcp/3919]
2020-09-15T01:52:25.250Z	DEBUG	keep-net-libp2p	replacing default announced addresses [[/ip4/<IP_ADDRESS>/tcp/3919 /ip4/<IP_ADDRESS>/tcp/3919 /ip4/<IP_ADDRESS>/tcp/3919]] with [[/ip4/<IP_ADDRESS>/tcp/3919]]
2020-09-15T01:52:28.572Z	INFO	keep-entry	[member:2] submitting relay entry [0x18b9df818a3b4e0085c9c0b6c306831d4aa3f91393136364421983177b6f311e01e8124e704355cdf7ee07a19838e102bead0e2344a2c820fa8f9fdd7ce0d288] on behalf of group [0x2941ac361bd822bab1796f04b16c339072f529c52101cc9a174e346dfd0252a51d737dd7f22ba24379237dc70f0c3d465653cf209c0f2e61781893d2c3be22ae2453cb89bd84a5b12bbac9cff5296a8a6692557cf594d52e1c04fd3c6cf998570a7e7990339fac095a1c66063d903a5475786ba26cbe8fdeb515c584d63f735f] at block [8687543]
2020-09-15T01:52:28.592Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.593Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.598Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.598Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.657Z	ERROR	keep-chain-ethereum	failed to estimate gas [gas required exceeds allowance (7999992) or always failing transaction]
2020-09-15T01:52:28.658Z	DEBUG	keep-contract-KeepRandomBeaconOperator	submitting transaction relayEntryparams: [24 185 223 129 138 59 78 0 133 201 192 182 195 6 131 29 74 163 249 19 147 19 99 100 66 25 131 23 123 111 49 30 1 232 18 78 112 67 85 205 247 238 7 161 152 56 225 2 190 173 14 35 68 162 200 32 250 143 159 221 124 224 210 136]
2020-09-15T01:52:28.686Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.686Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.726Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.726Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.748Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.748Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.761Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.761Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.762Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.763Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.811Z	DEBUG	keep-chain-ethereum	received gas price suggestion: [5000000000]
2020-09-15T01:52:28.956Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.956Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.957Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.957Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.965Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.965Z	WARN	keep-net-libp2p	message handler is too slow; dropping message
2020-09-15T01:52:28.992Z	DEBUG	keep-ethutil	packing parameters for method [relayEntry] with ABI [function relayEntry(bytes _groupSignature) returns()]: [[[24 185 223 129 138 59 78 0 133 201 192 182 195 6 131 29 74 163 249 19 147 19 99 100 66 25 131 23 123 111 49 30 1 232 18 78 112 67 85 205 247 238 7 161 152 56 225 2 190 173 14 35 68 162 200 32 250 143 159 221 124 224 210 136]]]
2020-09-15T01:52:28.992Z	DEBUG	keep-ethutil	resolving error for contract call [{From:[255 14 46 209 160 126 80 65 192 240 212 18 200 96 238 195 171 167 244 189] To:[200 51 122 148 165 13 22 25 21 19 222 244 209 230 26 104 134 191 65 15] Gas:0 GasPrice:<nil> Value:<nil> Data:[172 55 79 75 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 32 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 64 24 185 223 129 138 59 78 0 133 201 192 182 195 6 131 29 74 163 249 19 147 19 99 100 66 25 131 23 123 111 49 30 1 232 18 78 112 67 85 205 247 238 7 161 152 56 225 2 190 173 14 35 68 162 200 32 250 143 159 221 124 224 210 136]}]
2020-09-15T01:52:29.099Z	INFO	keep-relay	relay entry was submitted by the selected group on time at block [8687543]
panic: close of closed channel

goroutine 12138811 [running]:
github.com/keep-network/keep-core/pkg/chain/ethereum.(*ethereumChain).SubmitRelayEntry(0xc000168180, 0xc00f2657c0, 0x40, 0x40, 0xc004fabb08)
	/go/src/github.com/keep-network/keep-core/pkg/chain/ethereum/ethereum.go:203 +0x309
github.com/keep-network/keep-core/pkg/beacon/relay/entry.(*relayEntrySubmitter).submitRelayEntry(0xc00ed87860, 0xc00f2657c0, 0x40, 0x40, 0xc00f075f80, 0x80, 0x80, 0x848fb1, 0xc00f01e5a0, 0xc00f01e6c0, ...)
	/go/src/github.com/keep-network/keep-core/pkg/beacon/relay/entry/submission.go:62 +0x628
github.com/keep-network/keep-core/pkg/beacon/relay/entry.SignAndSubmit(0x1470840, 0xc0000ce6c0, 0x1473700, 0xc0070c6360, 0x1485cc0, 0xc000168180, 0xc000511820, 0x40, 0xe0, 0x21, ...)
	/go/src/github.com/keep-network/keep-core/pkg/beacon/relay/entry/entry.go:150 +0xbae
github.com/keep-network/keep-core/pkg/beacon/relay.(*Node).GenerateRelayEntry.func1(0xc008e18000, 0x1473700, 0xc0070c6360, 0x1485cc0, 0xc000168180, 0xc000511820, 0x40, 0xe0, 0x848fb1, 0xc001449150, ...)
	/go/src/github.com/keep-network/keep-core/pkg/beacon/relay/relay.go:136 +0xd2
created by github.com/keep-network/keep-core/pkg/beacon/relay.(*Node).GenerateRelayEntry
	/go/src/github.com/keep-network/keep-core/pkg/beacon/relay/relay.go:135 +0x328
2020-09-15T01:52:31.658Z	DEBUG	keep-block-counter	subscribing to new blocks
2020-09-15T01:52:32.465Z	INFO	keep-chain-ethereum	using [1m0s] mining check interval
2020-09-15T01:52:32.466Z	INFO	keep-chain-ethereum	using [500000000000] wei max gas price
2020-09-15T01:52:32.470Z	INFO	keep-chain-ethereum	fetching relay chain config

2minlog.txt

Thank you for submitting the issue @gregbostrom 🙌 This is indeed a problem, same as https://github.com/keep-network/keep-core/issues/1333, that should be solved during the work on https://github.com/keep-network/keep-core/issues/491.


Update 09_jsonb-support.adoc

Hi,
Maven was having trouble pulling the dependency without the appropriate Helidon version, so I added it and it worked.

Did you follow https://helidon.io/docs/latest/#/about/04_managing-dependencies ?
I.e Are you importing the helidon-bom ?

No, I haven't tried that, I guess i missed this part of the doc, will do
Thank you!
On Fri, Jun 28, 2019 at 1:17 PM Romain Grecourt<EMAIL_ADDRESS>wrote:

Did you follow
https://helidon.io/docs/latest/#/about/04_managing-dependencies
https://protect-us.mimecast.com/s/BkKQCZ6GPVU9DPnVuzWMFW?domain=helidon.io
?
I.e Are you importing the helidon-bom ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://protect-us.mimecast.com/s/CyFrC1wpKrcNknwDfG7mqg?domain=github.com,
or mute the thread
https://protect-us.mimecast.com/s/FGxCC2kqLvtzRKoJhBwK08?domain=github.com
.

--
Nahatolly D. Bah Bioh
Student ID: 000613586
Program and Start Date: B.S. Software Development 10/01/16
My Mentor: Keith Baker
Phone:<PHONE_NUMBER> Eastern Time
<EMAIL_ADDRESS>


Compilation in Ubuntu fails due to assert/cassert difference

Fixed and tested to work on Ubuntu

Also tested to work on Mac OS X


Add more context about phone numbers parsing errors

To Do

[ ] Pass the country code to the parsing function, to allow non international formats

I just pushed a commit to handle country code, I also removed the get_formatted_phone_number function as it seems that phonenumbers.format_number cannot fail (am I right? we should probably check the logs)

I just checked the logs, and I could not find any error on get_formatted_phone_number. And it looks safe according to its doc.
So everything looks good to me :+1:


Running rails db:migrate clears out queue_schema.rb.

I am trying to install latest solid queue into a project I'm working on, but when I run rails db:migrate then it clears out the queue_schema.rb file. I can load the schema with rails db:prepare, however I do have to run migrations in my primary database, but it always clears out the queue schema. Is there a migration file or multiple migration files for solid queue anymore?

I guess I should just take the schema and dump it into a migration file. Sorry if this is a noobie question but I haven't used multiple DBs in Rails before so I'm trying to figure out if my configuration is broken or if this is expected behavior.

Maybe if this is the normal current behavior solid queue install should put a migration into the solid_queue_migrate path? Because it does say to set the database configuration migrations_paths to queue_migrate, so I think that would indicate something should be there.

Huh, sorry for the trouble, @gregschmit! That seems really strange! It should just work without you having to do anything, and it shouldn't clear the queue schema. Would you mind sharing your database.yml configuration?

Sure, here is my database.yml:
default: &sqlite
  adapter: sqlite3
  pool: <%= ENV.fetch("RAILS_MAX_THREADS", 10) %>
  timeout: 5000

development:
  primary:
    <<: *sqlite
    database: db/development.sqlite3
  solid_queue:
    <<: *sqlite
    database: db/development_queue.sqlite3
    migrations_paths: db/solid_queue_migrate

test:
  primary:
    <<: *sqlite
    database: db/test.sqlite3
  solid_queue:
    <<: *sqlite
    database: db/test_queue.sqlite3
    migrations_paths: db/solid_queue_migrate

production:
  primary:
    <<: *sqlite
    database: db/production.sqlite3
  solid_queue:
    <<: *sqlite
    database: db/production_queue.sqlite3
    migrations_paths: db/solid_queue_migrate

In hindsight to me it makes perfect sense that the schema would be cleared, because there are no migration files inside db/solid_queue_migrate. By the way, I originally had everything set to queue_migrate and queue_schema.rb because that was the default but ended up prepending solid_ just for consistency. I was able to make everything work by putting the template queue_schema.rb into a migration file inside the db/queue_migrate` directory and now things are smooth.

I guess my main question is why solid queue doesn't install migrations even in a separate directory, and why the bin/rails solid_queue:install:migrations was removed (and not replaced by rails railties:install:migrations FROM=solid_queue). It seems as long as there are no migrations, then anytime someone runs migrate the schema would be cleared if they don't have an existing local database. The user would have to remember to load the schema first for that particular database.

Huh, sorry for the trouble, @gregschmit! That seems really strange! It should just work without you having to do anything, and it shouldn't clear the queue schema. Would you mind sharing your database.yml configuration?

For me it didn't work automatically because I'm using config.active_record.schema_format = :sql.
I've converted the template schema into a migration and now it works, but I'm worried about future changes on the schema, I'll keep the generated queue_schema.rb and check the diffs. Are the future updates planned to land as a migration in the queue's migrations_paths?
thanks for the work on this amazing gem 💎

Yes, these are great points @gregschmit and @eduardinni. We had planned to include future changes to the schema as regular migrations in the queue db migration paths, yes, but you both bring up a good point... let me think a bit more about this.
Thank you 🙏

the bin/rails solid_queue:install command created a queue_schema.rb file but with rails db:prepare the database was never created
what I did is:

I created a task file:  lib/tasks/solid_queue.rake
then I run that task rails solid_queue:load_schema

This created the database from the solid queue schema file
Finally don't forget to add config.active_job.queue_adapter = :solid_queue to your environment file or to application.rb if you are using solid queue in all environments
I might not be that sophisticated, but it was confusing for me that the install generator was creating a schema file instead of migration file (probably better under a "queue_migrate" folder) and it was not loaded into the database without that rake task!

the bin/rails solid_queue:install command created a queue_schema.rb file but with rails db:prepare the database was never created

Is it possible you didn't have the right configuration in database.yml before running db:prepare? 🤔

@scratchoo I just replicated your account by creating a new app, running solid_queue:install, and the running db:prepare. It doesn't create the database because it hasn't been configured in config/database.yml. Once I added the configuration there (see the top section under # Installation), then it created the database as expected on db:migrate.
@gregschmit You've found a multi-db handling bug in Rails. I've opened https://github.com/rails/rails/issues/52829 to track it. Thanks for tickling that! We fixed a related issue in db:migrate, but db:migrate must be taking a different path. We'll get it sorted before Rails 8.0.0.final. Maybe we can even backport the fix to 7.2.x.

@dhh still not working for me,
I have this on database.yml
development:
  primary:
    <<: *default
    database: demo_dev
  queue:
    <<: *default
    database: demo_production_queue
    migrations_paths: db/queue_migrate

When I run rails db:prepare the output is:
Created database 'demo_dev'
Created database 'demo_production_queue'
Created database 'demo_test'
My own migrations seem to run without terminal output (when using db:prepare) but there is no migrations files related to solid_queue that was created, even if I create the folder db/queue_migrate myself, there is no chance!
Supposing that the solid_queues migration files shouldn't be created and only queue_schema.rb should be enough, still the solid_queue tables are never created from that!
My Rails version is <IP_ADDRESS> in case I am missing something

Supposing that the solid_queues migration files shouldn't be created and only queue_schema.rb should be enough, still the solid_queue tables are never created from that!

Yes, the queue_schema.rb file should be enough, no migration files needs to be created. This is very strange. How are you checking that the tables aren't there? Just by starting solid queue and getting an error? Or in a different way?

@rosa by running bin/dev I am getting a bunch of errors type: ActiveRecord::StatementInvalid: PG::UndefinedTable: ERROR:  relation "solid_queue_processes" does not exist (ActiveRecord::StatementInvalid) etc

Thank you! Another question: do you have config.solid_queue.connects_to correctly set for development? In application.rb?

Yeah that was an important thing I did was to add the connects_to configuration: https://github.com/gregschmit/rails-rest-framework/blob/72f5871709ffd5a588eea34796eaa096798713f2/test/config/application.rb#L64
I think solid queue should install a migration into queue_migrations directory, not a queue_schema.rb file, because otherwise in the future it causes more work when there are schema changes. You could theoretically ship both, but the schema derives from migrations anyway so I don't see the purpose. Perhaps the thinking is that the solid queue DB can always be dropped because it's not persistent data, but I would still prefer to have migrations installed rather than schema.

I didn't but even after adding config.solid_queue.connects_to :my_queue_db_name it didn't solved the issue!
I created a new demo app, and got the same error, I upload it to a repo here: https://github.com/scratchoo/solid_demo

Ahh, looks like that connects_to is wrong. It should look like this:
config.solid_queue.connects_to = { database: { writing: :queue } }

The installer also creates bin/jobs for you.

@rosa yes I updated my comment above, but still not an obvious thing to do! because of the key database: I would expect to put the queue database name (so how I do even know!)  and if this line is important, as I said above, it should be in the installation section.

All this is preconfigured out of the box for new Rails 8 apps, but yes, it's probably worth stressing more forcefully in the installation section of the README that all these have to match. database.yml db name has to correspond to the connects_to name. This is one area where having the database name for connects_to in the solid_queue.yml config might make things a bit easier. But also maybe just more forceful docs will help. I'll take a swing at an update.

Yes, the installer adds that for you but in production.rb. Solid Queue is more intended for production, Rails ships with another adapter for development, the async adapter.

@rosa I see that it was added to production.rb by the generator, can I ask why it's only used for writing { database: { writing: :queue } } what about reads?

I've add added the point about other environments and the importance of matching the configuration names for the databases here: https://github.com/rails/solid_queue/commit/dab31d9fbe5d9fde708761aeec6ff75305b66053

@scratchoo If you only set writing, it'll use the same for reading. You only need to add reading if it differs.

I'm going to close this one as there don't seem to be any more specific Solid Queue issues here. Thanks everyone!

Totally fine with this closing out, but I just wanted to reiterate my question: why would this gem not release the schema for the separate DB as one initial migration? So if it changes in the future a migration can be added and it would execute when running the routine db:migrate that happens on deploy. It seems like if I upgrade in the future and there are schema changes, I'll have to drop the old DB and re-execute db:prepare, but that wouldn't happen until I noticed the problem.

Does db:prepare detect if schema changed and if there are no migration files then it drops the DB and re-executes the schema?

It seems like if I upgrade in the future and there are schema changes, I'll have to drop the old DB and re-execute db:prepare, but that wouldn't happen until I noticed the problem.

No, no, if we add a migration in the future, we'll include it as a migration, and you'll be able to install it and run it with db:migrate.
Migrations are from moving from one schema version to another,  not about loading an entire DB, which is what applications setting up Solid Queue for the first time will be doing.

Ah, I understand. To be honest it still strikes me as odd to have a "starting schema" rather than an "initial migration" but I'll get over it, especially since it seems to be a pattern that is being embraced by the framework.

I'm getting exactly the same problem.
I think starting with migrations instead of a pre-generated schema should be the better solution.
The solid_cache gem is doing it, so only solid_queue has a different way to work.

Hey @gregogalante, the bug in Rails that came up here was just fixed yesterday: https://github.com/rails/rails/pull/52830

The solid_cache gem is doing it, so only solid_queue has a different way to work.

No, Solid Cache works in the same way as Solid Queue, a schema file that gets copied during install.

I think starting with migrations instead of a pre-generated schema should be the better solution.

To be honest it still strikes me as odd to have a "starting schema" rather than an "initial migration"

For me it didn't work automatically because I'm using config.active_record.schema_format = :sql.

came here to +1 all of this. I really didn't like the initial starting schema.

partially because it this broke in a very surprising way
db/migrate_path is such an established standard for decades now
any future migrations necessary to be added to solid_queue will have to go into a db/migrate_path anyways

feels really 2 patterns that could be squashed into one already established one. (i've never been a big db:prepare fan because of edge cases i've ran into. db:migrate has always been reliable)
great to see this is patched here though going forward: https://github.com/rails/rails/pull/52830
thanks for all your hard work! solid_queue is great! just my 2 cents.

I was able to create a temporary work around by creating generating a migration under db/queue_migrate/xxxxxx_create_initial_solid_queue_tables.rb. This way it will run is a normal migration and not empty the schema file.


import replacements for path might also replace path/

Currently there is no logic in here to handle path/. This just works(tm) for file fetching, but for importReplacements, it's different.
Unsure how I feel about making people have to defensively code for both.
Answer may be that this is on users to get their replacements correct.

Talked to @lukebatchelor about this, and since path and path/ mean different things, so it would be a bad idea to auto-substitute both. This then falls to people using react-codesandboxer to write their replacements with this in mind.


Add JDBreaksLoading

Project URL
https://github.com/jamesdouble/JDBreaksLoading
Description
Add JDBreaksLoading
Why it should be included to awesome-ios (optional)
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 3 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Warning

:warning:
Found 1 link issue, a project collaborator will take care of these, thanks :)

Link issue by awesome_bot

Line
Status
Link

519
301
https://github.com/bwide/BWCollectionView redirects tohttps://github.com/bwide/CollectionNode

  Generated by :no_entry_sign: Danger

Hey @jamesdouble, please fix the issue above before we can approve your PR

@lfarah
Sorry for wating, I have updated my README.

@jamesdouble thanks for updating the README. Looks really good 👍


Give variable defaults in the template file

It was suggested the template file could include defaults for variables if the author so desires.
Perhaps it could leverage multi-document YAML files and look like this:
!Defaults
  foo: bar
  quux: 5
---
this_is_foo: !Var foo
also_quux: !Var quux

Output:
this_is_foo: bar
also_quux: 5

The document containing !Defaults may contain only that, it does not matter where in the document !Defaults is specified, there may be multiple documents containing !Defaults, latest wins, and any document containing !Defaults is erased from the output.

Fixed by #12


Update Amadeus API

Thank you for taking the time to work on a Pull Request for this project!
To ensure your PR is dealt with swiftly please check the following:

[X] Your submissions are formatted according to the guidelines in the contributing guide
[X] Your additions are ordered alphabetically
[X] Your submission has a useful description
[X] The description does not end with punctuation
[X] Each table column should be padded with one space on either side
[X] You have searched the repository for any relevant issues or pull requests
[X] Any category you are creating has the minimum requirement of 3 items
[X] All changes have been squashed into a single commit

Thanks for your contribution @alnacle!
Can you Please resolve the conflicts?

The Amadeus API has already been updated to the new url 😅


reth's callTracer output is different from erigon/geth's traces when a tx executes the SELFDESTRUCT opcode

Describe the bug
See relevant geth issue there: https://github.com/ethereum/go-ethereum/issues/16459 - I think it's important for reth to return outputs as identical as possible to 90% of the other nodes out there.
Steps to reproduce
Consider the following TX on Goerli testnet: 0x389fed47c06d9e9c15e075339a2c820f009ba130165e58b95c757b51e25e5597. 0.01ETH is transferred by this TX via the SELFDESTRUCT opcode.
If you run debug_traceTransaction in erigon and geth, you get from both nodes:
$ curl -H "Content-Type: application/json"  --data '{"jsonrpc":"2.0", "method": "debug_traceTransaction", "params": ["0x389fed47c06d9e9c15e075339a2c820f009ba130165e58b95c757b51e25e5597",  {"tracer": "callTracer"}],"id":1}'  <IP_ADDRESS>:8545
{
  "jsonrpc": "2.0",
  "id": 1,
  "result": {
    "from": "0x208c016d29599bbb836e02f30798578e75bb62a0",
    "gas": "0x54a1",
    "gasUsed": "0x6f46",
    "to": "0x6c3782df9e7e0b6e723e7debbc1c690afb258009",
    "input": "0x43d726d6",
    "calls": [
      {
        "from": "0x6c3782df9e7e0b6e723e7debbc1c690afb258009",
        "gas": "0x0",
        "gasUsed": "0x0",
        "to": "0x208c016d29599bbb836e02f30798578e75bb62a0",
        "input": "0x",
        "value": "0x2386f26fc10000",
        "type": "SELFDESTRUCT"
      }
    ],
    "value": "0x0",
    "type": "CALL"
  }
}

If you run it from reth, you are missing the call with the value 0x2386f26fc10000 making it impossible to know that 0.01ETH was transferred:
$ curl -H "Content-Type: application/json"  --data '{"jsonrpc":"2.0", "method": "debug_traceTransaction", "params": ["0x389fed47c06d9e9c15e075339a2c820f009ba130165e58b95c757b51e25e5597",  {"tracer": "callTracer"}],"id":1}'  <IP_ADDRESS>:8545
{
  "jsonrpc": "2.0",
  "result": {
    "from": "0x208c016d29599bbb836e02f30798578e75bb62a0",
    "gas": "0xa6e9",
    "gasUsed": "0x1cfe",
    "to": "0x6c3782df9e7e0b6e723e7debbc1c690afb258009",
    "input": "0x43d726d6",
    "output": "0x",
    "value": "0x0",
    "type": "CALL"
  },
  "id": 1
}

Node logs
N/A

Platform(s)
Linux (x86)
What version/commit are you on?
v0.1.0-alpha.4
What database version are you on?
v0.1.0-alpha.4
If you've built Reth from source, provide the full command you used
cargo build --profile maxperf --features jemalloc
Code of Conduct

[X] I agree to follow the Code of Conduct

this should be fixed now

Amazing thanks!
I don't have time to test but you guys should check there's no issues with failed optimism l1 -> l2 TXs too (type 126).


Add the ability to change axis properties for ROC plot

Describe the Enhancement
METviewer R script for ROC doesn't allow users to manipulate axis labels size, font , position and the range directly but they can use 'Plot Script Command' as a work around. We need to add this functionality to the Python ROC
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

[ ] 1-2 days: find and implement Python plotly support for orientation of the tick labels, font size, location of labels with respect to x-axis

Sub-Issues
Consider breaking the enhancement down into sub-issues.

[ ] Add a checkbox for each sub-issue here.

Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee

[ ] Select engineer(s) or no engineer required
[ ] Select scientist(s) or no scientist required

Labels

[ ] Select component(s)
[ ] Select priority
[ ] Select requestor(s)

Projects and Milestone

[ ] Review projects and select relevant Repository and Organization ones
[ ] Select milestone

Define Related Issue(s)
Consider the impact to the other METplus components.

[ ] METplus, MET, METdb, METviewer, METexpress, METcalcpy, METplotpy

Enhancement Checklist
See the METplus Workflow for details.

[ ] Complete the issue definition above.
[ ] Fork this repository or create a branch of develop.
Branch name:  feature_<Issue Number>_<Description>
[ ] Complete the development and test your changes.
[ ] Add/update unit tests.
[ ] Add/update documentation.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into develop.
Pull request: feature <Issue Number> <Description>
[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Close this issue.

support incorporated as part of issue #11 Closing


(DOCUMENT-448) Specify format for 'ensure' value when using a version.

https://tickets.puppetlabs.com/browse/DOCUMENT-448

Travis is failing because the commit starts with a DOCUMENT project ticket. Can you amend the commit to replace (DOCUMENT-448) with (docs), and note the ticket number in the commit description instead?
One other suggestion, then :+1: from me.

@gguillotte Done and done! Just waiting on travis.

Yay, tests pass this time!

I added a second commit to address the gem provider. If this is better, let me know and I'll rebase, otherwise I'll ditch it in favor of something better.

@rnelson0 @joshcooper If gem is the only exception, then I think all that needs to change over the original commit is to mention that as briefly as possible: "Ranges or semver patterns are not accepted except for the gem package provider."
Otherwise I'm :+1: for rebasing and merging this..

Okay, I think I got this now!

I'm good with this. I can't seem to merge it, though, GH is saying the branch is out of date with master. :/ I'm having problems with a different PR that make me think there might be an issue on my end or with GH. CC @nfagerlund

Got the merge button and merged it! Thanks @rnelson0!


Added support for request profiling via django-silk

What's Changed
This adds support for user session profiling via django-silk. This allows a user to enable a setting in their user profile which persists until they log out or disable the setting. Django silk will then log all subsequent requests for that user's session. Administrators can access the logs in the silk UI.
Screenshots

TODO

[x] Explanation of Change(s)
[x] Added change log fragment(s) (for more information see the documentation)
[x] Attached Screenshots, Payload Example
[x] Unit, Integration Tests
[x] Documentation Updates (when adding/changing features)
[ ] Example Plugin Updates (when adding/changing features)
[ ] Outline Remaining Work, Constraints from Design

We want to add a setting to toggle this feature. Also backport to LTM.


Java 8 rendering issue on Ubuntu

Ubuntu 14.04 LTS with Unity does not render the DragPanel correctly.
It is not cleared, and thus "stacks" its draw calls.

Fix is
java -jar -Dsun.java2d.opengl=True ScreenCapture.jar


I18N support for heroes and items.

I guess I can add other language like Chinese support by creating a new zh.js in src/lang. But it seems not supporting heroes names translation.

That's because this data is from the Dota 2 site:
http://www.dota2.com/jsfeed/itemdata
We can get other languages with something like the following:
http://www.dota2.com/jsfeed/itemdata?l=schinese
However we don't want to bundle all the other languages into the JS bundle so we need to rethink how we load tooltip data.

So is this a considering feature?

I'd like to do it at some point but it requires a code change to how we get the tooltip data.

merge with #338


⚠ Punto de Fuga has degraded performance

In db542a5, Punto de Fuga (http://puntodefugapodcast.com) experienced degraded performance:

HTTP code: 200
Response time: 7683 ms

Resolved: Punto de Fuga performance has improved in 1b845f8.


Multivariate input for media data

Hello,
I am currently working on constructing an MMM model, but the media data involved is multivariate in nature. To provide some context, the media features encompass not only costs but also include impressions and clicks, all of which have historical data.
Consequently, I'd like to inquire about the compatibility of your library with this type of media data input shape. To give an example, the media_data would not have the shape (117, 3) shown in demo, but it would be instead (117, 3, 3):
117: Number of weeks
3: Number of media
3: Number of features (costs, impressions, costs)
Thanks in advance!

In an MMM, you would typically only include the measure of impact (or influence if you like). In this case, I would go with Impressions although some would suggest clicks. Consumers don't see the cost so that features in the cost matrix but isn't the driver of behaviour (at least not directly). You only want to use the imps in this model, leave clicks altogether and use Cost in the cost matrix.


WebviewInput and LazilyResolvedWebviewEditorInput have same type ID?

Not clear to me how the one relates to the other, but typically editors should have different type IDs per kind. And if the one is only used as parent type, it could remain abstract

This is by-design. LazilyResolvedWebviewEditorInput  is just a specialized implementation of WebviewEditorInput. From the workbench's point of view, the two use the same editor and are functionally the same
We only need to differentiate LazilyResolvedWebviewEditorInput for the implementation of webview editors themselves, such as: https://github.com/microsoft/vscode/blob/cadabab73fef89fe0c4bfe23b5a33cd58e39ea9c/src/vs/workbench/contrib/webview/browser/webviewWorkbenchService.ts#L272


Crash on CompositeEventMonitor only on Ad Hoc builds

[x] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?
ℹ I upgraded into v5.1.0. When testing on a Debug and Release builds, the app functions properly. But when I build the app on Ad Hoc with Debug mode (to give to testers via App Distribution), there's a crash on a certain page.
Here's the stack trace I get on Crashlytics. Unfortunately I cannot debug it in Xcode because the crash only happened on Ad Hoc builds.
0  libswiftCore.dylib             0x260b93c5c _swift_release_dealloc + 16
1  Alamofire                      0x1010c9740 closure #1 in CompositeEventMonitor.request(_:didCompleteTask:with:) + 459 (EventMonitor.swift:459)
2  Alamofire                      0x1010c9740 closure #1 in CompositeEventMonitor.request(_:didCompleteTask:with:) + 459 (EventMonitor.swift:459)
3  libswiftCore.dylib             0x260b93c68 _swift_release_dealloc + 28
4  Alamofire                      0x1010de280 outlined init with copy of EventMonitor (<compiler-generated>)
5  libswiftCore.dylib             0x260b93c68 _swift_release_dealloc + 28
6  Alamofire                      0x1010de328 block_destroy_helper.122 (<compiler-generated>)
7  libsystem_blocks.dylib         0x232a74a44 _Block_release + 152
8  libdispatch.dylib              0x232a197d4 _dispatch_client_callout + 16
9  libdispatch.dylib              0x2329c7008 _dispatch_main_queue_callback_4CF$VARIANT$mp + 1068
10 CoreFoundation                 0x232f6cb20 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
11 CoreFoundation                 0x232f67a58 __CFRunLoopRun + 1924
12 CoreFoundation                 0x232f66fb4 CFRunLoopRunSpecific + 436
13 GraphicsServices               0x23516879c GSEventRunModal + 104
14 UIKitCore                      0x25f7c8c38 UIApplicationMain + 212
15 [MY-APP-NAME]                          0x100946414 main + 20 (AppDelegate.swift:20)
16 libdyld.dylib                  0x232a2a8e0 start + 4

What did you expect to happen?
ℹ The app runs normally on Debug (when compiled directly on Xcode) and Release (TestFlight and AppStore) builds, even on the certain page that crashes.
What happened instead?
ℹ The app crashes on Ad Hoc builds, but just on a certain page.
Alamofire Environment
Alamofire version: 5.1.0
Xcode version: 11.4.1
Swift version: 5.2.2
Platform(s) running Alamofire: iOS
macOS version running Xcode: macOS Catalina Version 10.15.4

This is similar to the other crashes we're seeing, most likely related to the Swift 5.2 compiler. @kennethvl Can you try two things: a build using Xcode 11.3.1 and a build using the Xcode 11.5 beta. That way we can see if this issue existed on Xcode 11.3.1 (probably not) and whether it's fixed in Xcode 11.5. This should help us narrow it down and report bugs to Apple.

@jshier a little bit update, actually the crash also happens in TestFlight. Currently I reverted back into version 5.0.5 and it runs well again (no crash). Haven't tried what you suggested yet though.

@kennethvl Are you using a custom Session instance with any custom queues? How are you performing the requests that are crashing?

Closing, as this was likely a Swift runtime issue which may be fixed in newer versions of Xcode and Swift.


[doc-enhancement][Updates for See Also and keywords]

Updates for See Also and Description(metadata)

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/how-to/get-teams-context.md
90
10
link
:white_check_mark:

msteams-platform/overview.md
94
4
link
:white_check_mark:

msteams-platform/samples/app-templates.md
84
104
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 0a4c4ac:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/overview.md
:warning:Warning
View
Details

msteams-platform/samples/app-templates.md
:warning:Warning
View
Details

msteams-platform/bots/how-to/get-teams-context.md
:white_check_mark:Succeeded
View

msteams-platform/overview.md

Line 208, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'concepts/app-fundamentals-overview'.
Line 209, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'concepts/design/design-teams-app-process'.
Line 210, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'concepts/design/map-use-cases'.

msteams-platform/samples/app-templates.md

Line 173, Column 3: [Warning: file-not-found - See documentation] Invalid file link: '../concepts/design/personal-apps'.
Line 174, Column 3: [Warning: file-not-found - See documentation] Invalid file link: '../concepts/design/design-teams-app-fundamentals'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit c6eefcf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/get-teams-context.md
:white_check_mark:Succeeded
View

msteams-platform/overview.md
:white_check_mark:Succeeded
View

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
82
37
link
:white_check_mark:

msteams-platform/bots/how-to/get-teams-context.md
90
10
link
:white_check_mark:

msteams-platform/overview.md
94
4
link
:white_check_mark:

msteams-platform/samples/app-templates.md
84
104
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
90
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 58472a0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/design/designing-apps-in-meetings.md
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/teams-apps-in-meetings.md
:white_check_mark:Succeeded
View

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/get-teams-context.md
:white_check_mark:Succeeded
View

msteams-platform/bots/what-are-bots.md
:white_check_mark:Succeeded
View

msteams-platform/overview.md
:white_check_mark:Succeeded
View

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/Universal-actions-for-adaptive-cards/Up-To-Date-Views.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/cards-reference.md
:white_check_mark:Succeeded
View

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
:white_check_mark:Succeeded
View

msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
99
6
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/design/designing-apps-in-meetings.md
94
23
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/teams-apps-in-meetings.md
96
1
link
:white_check_mark:

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
82
37
link
:white_check_mark:

msteams-platform/bots/how-to/get-teams-context.md
90
10
link
:white_check_mark:

msteams-platform/bots/what-are-bots.md
84
13
link
:white_check_mark:

msteams-platform/overview.md
94
4
link
:white_check_mark:

msteams-platform/samples/app-templates.md
84
104
link
:white_check_mark:

msteams-platform/task-modules-and-cards/cards/Universal-actions-for-adaptive-cards/Up-To-Date-Views.md
89
13
link
:white_check_mark:

msteams-platform/task-modules-and-cards/cards/cards-reference.md
83
53
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
90
6
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
94
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
99
6
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/design/designing-apps-in-meetings.md
94
23
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/teams-apps-in-meetings.md
96
1
link
:white_check_mark:

msteams-platform/bots/bot-basics.md
84
49
link
:white_check_mark:

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
82
37
link
:white_check_mark:

msteams-platform/bots/how-to/authentication/add-authentication.md
83
124
link
:white_check_mark:

msteams-platform/bots/how-to/conversations/subscribe-to-conversation-events.md
89
22
link
:white_check_mark:

msteams-platform/bots/how-to/get-teams-context.md
90
10
link
:white_check_mark:

msteams-platform/bots/what-are-bots.md
84
13
link
:white_check_mark:

msteams-platform/concepts/app-fundamentals-overview.md
83
13
link
:white_check_mark:

msteams-platform/concepts/capabilities-overview.md
95
5
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-fundamentals.md
100
0
link
:white_check_mark:

msteams-platform/concepts/design/personal-apps.md
96
8
link
:white_check_mark:

msteams-platform/overview.md
94
4
link
:white_check_mark:

msteams-platform/samples/app-templates.md
84
104
link
:white_check_mark:

msteams-platform/samples/integrate-web-apps-overview.md
84
26
link
:white_check_mark:

msteams-platform/tabs/how-to/build-adaptive-card-tabs.md
95
6
link
:white_check_mark:

msteams-platform/task-modules-and-cards/cards/Universal-actions-for-adaptive-cards/Up-To-Date-Views.md
89
13
link
:white_check_mark:

msteams-platform/task-modules-and-cards/cards/cards-reference.md
83
53
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
90
6
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
94
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 518951f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/design/designing-apps-in-meetings.md
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/teams-apps-in-meetings.md
:white_check_mark:Succeeded
View

msteams-platform/bots/bot-basics.md
:white_check_mark:Succeeded
View

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/authentication/add-authentication.md
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/conversations/subscribe-to-conversation-events.md
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/get-teams-context.md
:white_check_mark:Succeeded
View

msteams-platform/bots/what-are-bots.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/app-fundamentals-overview.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/capabilities-overview.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/design/design-teams-app-fundamentals.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/design/personal-apps.md
:white_check_mark:Succeeded
View

msteams-platform/overview.md
:white_check_mark:Succeeded
View

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/integrate-web-apps-overview.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/build-adaptive-card-tabs.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/Universal-actions-for-adaptive-cards/Up-To-Date-Views.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/cards-reference.md
:white_check_mark:Succeeded
View

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
:white_check_mark:Succeeded
View

msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit beadc0d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/concepts/device-capabilities/mobile-camera-image-permissions.md
:warning:Warning
View
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/design/designing-apps-in-meetings.md
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/teams-apps-in-meetings.md
:white_check_mark:Succeeded
View

msteams-platform/bots/bot-basics.md
:white_check_mark:Succeeded
View

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/authentication/add-authentication.md
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/conversations/subscribe-to-conversation-events.md
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/get-teams-context.md
:white_check_mark:Succeeded
View

msteams-platform/bots/what-are-bots.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/app-fundamentals-overview.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/capabilities-overview.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/design/app-structure.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/design/design-teams-app-fundamentals.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/design/enable-app-customization.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/design/personal-apps.md
:white_check_mark:Succeeded
View

msteams-platform/overview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/integrate-web-apps-overview.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/build-adaptive-card-tabs.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/Universal-actions-for-adaptive-cards/Up-To-Date-Views.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/cards-reference.md
:white_check_mark:Succeeded
View

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
:white_check_mark:Succeeded
View

msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/device-capabilities/mobile-camera-image-permissions.md

Line 9, Column 1: [Warning: yaml-duplicate-key] Key 'keywords' is already defined, remove the duplicate key.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
99
6
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/design/designing-apps-in-meetings.md
94
23
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/teams-apps-in-meetings.md
96
1
link
:white_check_mark:

msteams-platform/bots/bot-basics.md
84
49
link
:white_check_mark:

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
82
37
link
:white_check_mark:

msteams-platform/bots/how-to/authentication/add-authentication.md
83
124
link
:white_check_mark:

msteams-platform/bots/how-to/conversations/subscribe-to-conversation-events.md
89
22
link
:white_check_mark:

msteams-platform/bots/how-to/get-teams-context.md
90
10
link
:white_check_mark:

msteams-platform/bots/what-are-bots.md
84
13
link
:white_check_mark:

msteams-platform/concepts/app-fundamentals-overview.md
83
13
link
:white_check_mark:

msteams-platform/concepts/capabilities-overview.md
95
5
link
:white_check_mark:

msteams-platform/concepts/design/app-structure.md
96
4
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-fundamentals.md
100
0
link
:white_check_mark:

msteams-platform/concepts/design/enable-app-customization.md
93
3
link
:white_check_mark:

msteams-platform/concepts/design/personal-apps.md
96
8
link
:white_check_mark:

msteams-platform/concepts/device-capabilities/mobile-camera-image-permissions.md
88
22
link
:white_check_mark:

msteams-platform/overview.md
94
4
link
:white_check_mark:

msteams-platform/resources/schema/manifest-schema.md
86
91
link
:white_check_mark:

msteams-platform/samples/app-templates.md
84
104
link
:white_check_mark:

msteams-platform/samples/integrate-web-apps-overview.md
84
26
link
:white_check_mark:

msteams-platform/tabs/how-to/build-adaptive-card-tabs.md
95
6
link
:white_check_mark:

msteams-platform/task-modules-and-cards/cards/Universal-actions-for-adaptive-cards/Up-To-Date-Views.md
89
13
link
:white_check_mark:

msteams-platform/task-modules-and-cards/cards/cards-reference.md
83
53
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
90
6
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
94
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 9c7a1ad:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/design/designing-apps-in-meetings.md
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/teams-apps-in-meetings.md
:white_check_mark:Succeeded
View

msteams-platform/bots/bot-basics.md
:white_check_mark:Succeeded
View

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/authentication/add-authentication.md
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/conversations/subscribe-to-conversation-events.md
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/get-teams-context.md
:white_check_mark:Succeeded
View

msteams-platform/bots/what-are-bots.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/app-fundamentals-overview.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/capabilities-overview.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/design/app-structure.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/design/design-teams-app-fundamentals.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/design/enable-app-customization.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/design/personal-apps.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/device-capabilities/mobile-camera-image-permissions.md
:white_check_mark:Succeeded
View

msteams-platform/overview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/integrate-web-apps-overview.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/build-adaptive-card-tabs.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/create-tab-pages/content-page.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/developer-tools.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/Universal-actions-for-adaptive-cards/Up-To-Date-Views.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/cards-reference.md
:white_check_mark:Succeeded
View

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
:white_check_mark:Succeeded
View

msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
99
6
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/design/designing-apps-in-meetings.md
94
23
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/teams-apps-in-meetings.md
96
1
link
:white_check_mark:

msteams-platform/bots/bot-basics.md
84
49
link
:white_check_mark:

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
82
37
link
:white_check_mark:

msteams-platform/bots/how-to/authentication/add-authentication.md
83
124
link
:white_check_mark:

msteams-platform/bots/how-to/conversations/subscribe-to-conversation-events.md
89
22
link
:white_check_mark:

msteams-platform/bots/how-to/get-teams-context.md
90
10
link
:white_check_mark:

msteams-platform/bots/what-are-bots.md
84
13
link
:white_check_mark:

msteams-platform/concepts/app-fundamentals-overview.md
83
13
link
:white_check_mark:

msteams-platform/concepts/capabilities-overview.md
95
5
link
:white_check_mark:

msteams-platform/concepts/design/app-structure.md
96
4
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-fundamentals.md
100
0
link
:white_check_mark:

msteams-platform/concepts/design/enable-app-customization.md
93
3
link
:white_check_mark:

msteams-platform/concepts/design/personal-apps.md
96
8
link
:white_check_mark:

msteams-platform/concepts/device-capabilities/mobile-camera-image-permissions.md
88
22
link
:white_check_mark:

msteams-platform/overview.md
94
4
link
:white_check_mark:

msteams-platform/resources/schema/manifest-schema.md
86
91
link
:white_check_mark:

msteams-platform/samples/app-templates.md
84
104
link
:white_check_mark:

msteams-platform/samples/integrate-web-apps-overview.md
84
26
link
:white_check_mark:

msteams-platform/tabs/how-to/build-adaptive-card-tabs.md
95
6
link
:white_check_mark:

msteams-platform/tabs/how-to/create-tab-pages/content-page.md
84
18
link
:white_check_mark:

msteams-platform/tabs/how-to/developer-tools.md
92
5
link
:white_check_mark:

msteams-platform/task-modules-and-cards/cards/Universal-actions-for-adaptive-cards/Up-To-Date-Views.md
89
13
link
:white_check_mark:

msteams-platform/task-modules-and-cards/cards/cards-reference.md
83
53
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
90
6
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
94
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


Publish to crates.io?

I noticed that this language is not published to crates.io while many other tree sitter languages are. Is there a reason for that?

It'd be great to have this binding on crates!

Published now


Make a javascript_enabled property

We have a phantom--nojs file just sitting there, not useful to anybody in particular.
People can manually trigger the noJS mode of Phantom or Casper through the before_capture hook, or specify their own nonJS snap file. But it would be nice if we offered a dedicated option in the YAML file (javascript_enabled: true or false. true by default).

No longer valid. The changes this would require under the hood are too unclean (we're already passing too many arguments to the command line than is advised for maintainability!) and this can be easily accomplished using the beforeCapture hook.
I've added some clear examples for achieving this, which can be retrieved by running wraith setup: https://github.com/BBC-News/wraith/commit/b0f1aaee13d8162bdc59c4170ada6ba5c7ba7fb7


While using inbuilt libraries, It throw File Not Found Error

Describe the bug
In the Current version of the Ae project: While using inbuilt libraries, It throws File Not Found Error. For example, if you want to include String.aes and then try to compile it. The file read (As I assume) if found statement after include It tries to read the file from directory path as given, It works if you use custom libraries that are saved locally.
To Reproduce
Steps to reproduce the behavior:

Create new contract with include String.aes (As an example)
Then perform compilation aeproject compile
You can find the error listed.

File to include 'String.aes' not found. Check your path or it is from Sophia default library .
Expected behavior
It should work without creating a file for the inbuilt library so no need to find the code to paste in it. Since everything will be compiled on the server compiler (local or remote), There requires a check for inbuilt libraries that if it found one, For e.g. Oracle.aes It shouldn't perform file system read operation on it.
Aeproject information (please complete the following information):

OS executed at: Ubuntu 20
AEproject Version: Latest as of Today.

Should be fixed with 3.0.4. Please let us know if you have any further issues with it.

Thank you.


Remove scroll from td-step-body

This repository's issues are reserved for feature requests and bug reports.
Do you want to request a feature or report a bug?
bug
Bug Report
Create a  which sub steps are tall enough to have scrolling.
Screenshots or link to CodePen/Plunker/JSfiddle
https://i.imgur.com/xqIjUvn.png
Note: the grid-list has an additional border styling and that causes the scroll to show up..
What is the expected behavior?
Simply doubt that anyone on earth would want to have scroll inside a card.
What is the motivation / use case for changing the behavior?
It will look acceptable.
Other information
I think scrolling in any of your components should be something set by the user not predefined.

For the most part all container components try to fit the height of it, kinda like md-tabs does it.
Also removing the scroll is not the solution since we add it but its basically trying to fit the height dynamically. Removing the scroll would only hide the scroll bar but the content would be cut, so we need to find the real issue.
Can you replicate this in plnkr?

I dont  understand why do you want to limit the height of this object? If the user wants fixed height he should able to define that + the scroll. Forcing this causes issues most importantly being unable to listen on any scroll events. Pls checkout how its done in material

We arent limiting the height, thats my point. This is most likely a bug that we need to replicate.

Same problem here after updating.
.td-step-content {
  overflow: hidden !important;
}

fixed my problem.

Thanks @elmartino, this info is useful since it means angular 4.2.0 might be the culprit with their animations breaking changes.
AUTO_STYLE might not be applied correctly on height depending on padding or margin of content.
Do you have a code snippet or plnkr of what causes your issue?


Can't add belgua on Discord

Friend requests are automatically struck down by samurai or something. I've got some questions I'd like to get answered :smile:

Hello, please join the server link in the description of this repository.


Create .editorconfig to set standards

Fixes #14

This conflicts with the new contribution guidelines proposed in #16

@IDisposable can you please rebase and resolve merge conflicts. Ta.

I've resolved the merge conflicts, sorry for the delay... I only code in leap years, and internal reviews took a while


Code cleanup

Fixes performed:

Standardize the Gemfile and gemspec
Fixes to README
Change :in_transaction_mode to :transaction_guard

Rename :allowed to :disabled to better reflect syntax (i.e. sidekiq_options transaction_guard: :disabled)

Various other small changes

TODO:

[ ] Add installation/usage/development docs to README
[x] Ensure that the SidekiqTransactionGuard.in_transaction? call is thread safe. Not entirely sure if it is @bdurand

Should look into (#2) to rename gem before too long.

renamed the repository and merged the PR

On Aug 22, 2018, at 11:44 AM, Winston Durand<EMAIL_ADDRESS>wrote:
Should look into (#2 https://github.com/bdurand/sidekiq-transaction-guard/issues/2) to rename gem before too long.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/bdurand/sidekiq-transaction-guard/pull/1#issuecomment-415137702, or mute the thread https://github.com/notifications/unsubscribe-auth/AACjPyg9dV0pP5mFSNTB1Xz2oJLETLIcks5uTaaEgaJpZM4WGQum.


Firebase* Swift imports not working on integrating framework depending upon Firebase itself

Describe your environment

Xcode version: 12.4
Firebase SDK version: 7.2.0
Installation method: CocoaPods
Firebase Component: (Auth, Core, Database, Firestore, Messaging, Storage, etc)

Describe the problem
I have a Cocoapods Swift framework that depends on Firebase (Core, Database, Storage, and a few others). I'm trying to add that framework to my app that also depends on Firebase via react-native-firebase. After I added the framework to my app and tried to build the app, I get the following error for all Firebase* imports in the Framework's Swift code:
No such module 'FirebaseCore'
No such module 'FirebaseAuth'
...

I tried cleaning everything, from node_modules to build folder to derived data.
I also tried using $RNFirebaseAsStaticFramework = true.
But nothing worked for me.
Please point me in the right direction.

Thanks for reporting, @mohsinulhaq. Can you try to update your SDK to the latest one and see if that would fix the issue? If not, can you share your Podfile or a project that reproduces this issue?

https://github.com/mohsinulhaq/Swift-Firebase-Framework-error
@rizafran here's a repro for the issue, for easy development, I have put the Framework in the ios/TestFramework folder instead of another GitHub repo.
Run yarn. post-install hook handles the pod installation.
Once installation completes, building the app will produce the above error of it not able to compile the Swift files in the framework (test.swift in my framework):

I also tried the same process by using various versions all the way up to the latest (7.9.0).
For all versions from my current one (7.2.0) to 7.8.0, the error I get is the same. But weirdly for 7.9.0, the error changes to failing on some random Firebase pod everytime I try to build the app, like FirebaseInstallations or FirebaseStorage, as shown in the screenshot:

@mohsinulhaq this looks like you may just need to update the header search paths in the xcconfig of the pod you're creating.


[Zh] glossary and nit fix

add zh support for glossary
nit fix on land space emoji for zh
fix for #306

it seems  https://www.health.state.mn.us/communities/environment/climate/docs/film/vocab_list.pdf  link is missing ref https://github.com/cncf/tag-env-sustainability/actions/runs/7289572083/job/19864470326?pr=315#step:7:124
should we have another PR to fix this link?

@leonardpahlke , could you please help with this PR?


Multi region

What type of PR is this?
/kind feature

What this PR does / why we need it:
Release image in cloudgouv region
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #189
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:

[ ] squashed commits
[ ] includes documentation
[ ] adds unit tests

Closes #189

Closes #181

@outscale-mdr Are you ok with the latest version ?


Tabula-Extractor installation issue

Hi, I have installed JRuby and on  JRuby IRB Console [<IP_ADDRESS>.pre1 (2.2.0), tried the installation command  "jruby -S gem install tabula-extractor", I get the below error,
irb(main):002:0>  jruby -S gem install tabula-extractor
SyntaxError: (irb):2: syntax error, unexpected tIDENTIFIER
jruby -S gem install tabula-extractor
^
from org/jruby/RubyKernel.java:990:in eval' 	from org/jruby/RubyKernel.java:1300:in loop'
from org/jruby/RubyKernel.java:1110:in catch' 	from org/jruby/RubyKernel.java:1110:in catch'
from C:\jruby-<IP_ADDRESS>.pre1/bin/jirb_swing:53:in `script'
Can you help me?

I also tried installing tabula-extractor on CMD and getting below error, what could be wrong?
C:>jruby -S gem install tabula-extractor
ERROR:  Loading command: install (Win32::Registry::Error)
The system cannot find the file specified.
ERROR:  While executing gem ... (NoMethodError)
undefined method `invoke_with_build_args' for nil:NilClass


fix: cleanup code

Plans:

[x] Module for code
[x] Bot subclass with startup func for client session
[ ] Consistency of style
[ ] Pre-commit to help with a consistent style
[ ] Allow people to turn off linking loops so they dont destroy test servers by accident
[ ] Not use questionable import styles (like the ones in link and autopaste, wtf epic)
[x] Use proper cog related constants
[ ] Use _ for unused variables
[ ] Resolve pyright basic type issues

Why should this be a module?

Why should this be a module?

All the code in one encapsulated place, who get main.py lost in config and meta files when it can be in one place


Fixed tests in Waypoint: Use Comments to Clarify Code

Added check for null and changed length check to larger than 0 (becuase we need only one comment to pass the tests)
Issue #1579

Is this tested on a local copy of FCC?

Yes ;)

Awesome work!

Thanks, the same goes for You guys :+1:


Update the getting started guide for v1.0-rc1

The getting started guide need to be updated to

Ensure that local and K8s install experiences are separate.
The reader is directed to the quickstarts
The install script will install v1.0-rc1 CLI as a choice.

RC1 website has been setup and configured with versioning

Rest of work (link to quickstarts, separate installation guides) can be done tomorrow first thing


[Question]: How can I get stream or byte array Tracing zip?

Your question
How can I get stream or byte array "Tracing zip"?
I want send it to other location, not save in path.

This is not possible, we recommend storing the trace in a temporary location for that and then reading the file.
what is your use-case?


psycopg vs. psycopg2

There is no way to use the package with the psycopg adapter rather than psycopg2, or is there?
Reason I'm asking is that the Django project itself recommends the former these days, when the latter has been the go-to standard for many projects for years now, I believe. They even make a note about how psycopg2 support will likely be dropped in the future.
I couldn't find anything about this anywhere in the docs, everything just seems to point to this project defaulting to psycopg2 for use with Postgres. What I did find after spending quite some time combing through old tickets was this PR: https://github.com/jazzband/dj-database-url/pull/26 – is the engine attribute a) an undocumented feature and b) what I'm looking for?

So, this package just selects the Django DB backend. The Django backend then picks psycopg/psycopg2 based on what you've got installed which isn't anything to do with this project.
Admittedly, the engine param is undocumented and could do with fixing, but isn't needed in your case.


Bot says "failed to parse JSON" when getting music.

Please tick all applicable boxes.

[X] I am using Python 3.5.3 or higher (run python --version on the command line)
[X] I have followed the official guides to install the bot for my system
[X] I have updated my dependencies to the latest version using the appropriate update script

Which version are you using?

[X] The latest master version (release-260419)
[ ] The latest review version

What type of issue are you creating?

[X] Bug
[ ] Feature request
[ ] Question

Description of issue
I tell the bot to play a Spotify playlist and it says "Failed to parse Json".
First time I have seen this issue.
Steps to reproduce

Take a month long brake from using computer.
Run music bot.
3.Update dependencies.
Run music bot.

Log file
Please attach your MusicBot log file (located at logs/musicbot.log) to this issue. You can do so by dragging and dropping the file here. If you do not include your log file, you WILL be asked to provide one.
musicbot.log

the one month brake is not the issue here.
See: HERE

Youtube-dl is taken down due to an official DMCA requests. There is no fix for now

Youtube-DL is still fully functional - the takedown ONLY effected the Github repo. https://youtube-dl.org/ . Having issues with MusicBot myself but YoutubeDL still works locally outside of MusicBot.

A fix for this was pushed to youtube-dl within an hour prior to it being taken down. A fork was found containing the committed change here:
https://github.com/nrdmn/youtube-dl/commit/416da574ec0df3388f652e44f7fe71b1e3a4701f
To install this fix: Clone the repo above, uninstall youtube-dl, use pip to install youtube-dl using the repo you just cloned, and restart your bot. Until there's an official repo for youtube-dl again this fix should pull you through.


[Animations] fadeOut animation doesn't work for windows

After trying to set up animations for windows, I've noticed that fadeOut animations doesn't work as exepected.
Current behavior

Disable windowsOut animation to make it use fade
Close a window
Notice how it just disappear without any kind of animation.

Expected behavior
The window disappears with a fade effect.
Infos
Video
https://user-images.githubusercontent.com/93444783/195686443-72cb5b29-0153-429d-8dc0-d5c1182c9a74.mp4
Configuration
animations {
    enabled=1

    animation=windows,1,1.5,default
    animation=fadeOut,1,10,default
    animation=windowsOut,0,1,default
    animation=border,1,10,default
    animation=workspaces,1,3,default
}

Hyprland version
Hyprland, built from branch main at commit 170def35d79210f9124cdfd7da563d5d384dcae9dirty (simplify shouldRenderWindow and fix one cond).
flags: (if any)

fixed in 670d6ce8f476cbdced7aa62e7d8c16a48bccf0d5

FYI: windowsOut works with fadeOut without any issues.


docs: Use ReadTheDocs url for docs

The default RTD view should also get updated to point to the 'stable' docs.

c.f. https://servicex.readthedocs.io/en/stable/

@ketan96-m @ponyisi @BenGalewsky This is ready for review. Let me know if you have any questions.


[WIP] Workflow: add the stop_after_phase flag

We need to stop the execution of the workflow in some cases without
the reboot requirement. Adding the flag to provide such functionality.

Can one of the admins verify this patch?


Performance Decrease If Left Open For A Long Period

I've been noticing an issue with Scout as I go to generate my SCSS files recently. Since I do a ton of FED, I usually leave Scout running in the background to compile my SCSS across a bunch of different projects. When I start the app, generation times are around 2-350ms, but over the course of the day the times steadily keep creeping up, sometimes taking over two seconds to compile.
I assumed this was just because my files are getting larger so there's more to compile, however, if I quit the app, wait a second or two and then relaunch, it will go back to generating like it was previously around 300ms. I've noticed this performance behavior across the two Macbook Pros and one MacMini that I have at the office so I'm sure its not machine dependent (also the MBP's are the latest gen so I know system processing power isn't the bottleneck either).
Any idea why this is so? Something to do with an app cache getting full after multiple generations, perhaps?

I'll have to look into this. It's not something I've tested for, so I'm not sure what is occurring. Probably some cache building up or not being cleared. I'll be curious if it's something I have control over. More than likely this is being caused by one of Scout-App's dependencies:

Node-Sass which handles reading files, handing them off to LibSass, and returning the data from LibSass
LibSass itself which actually processes the data handed to it by Node-Sass and returns CSS data to Node-Sass
Chokidar which monitors for file changes and then has Node-Sass do it's thing

Sounds good @TheJaredWilcurt. Let me know if I can provide insight by providing a dump or log of any kind.


[$500]  Expensifiy Card - Issue with card connection error message on tester@applausecard Wallet

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.10-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Log in with<EMAIL_ADDRESS>Navigate to Wallet

Expected Result:
No error message should be displayed
Actual Result:
"Issue with card connection|" error message is displayed on<EMAIL_ADDRESS>Wallet screen
There's an issue with this card connection, which may result in you my not seeing transactions. Please contact your administrator to resolve
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/3e38331e-6d08-443a-90ea-10326f1c1763
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013dc1a1ba0f45eb6a
Upwork Job ID:<PHONE_NUMBER>115284992
Last Price Increase: 2023-12-15

where do we get the password for<EMAIL_ADDRESS>

@abeebridwan aBa9)KMdJ9PmoJzc

@lanitochka17

@lanitochka17
i tried logging into<EMAIL_ADDRESS>using this password "aBa9)KMdJ9PmoJzc" you shared here

@abeebridwan aBa9)KMdJ9PmoJzc

Here is a short video showing the whole process
trying to log in to the<EMAIL_ADDRESS>account to reproduce the issue
https://www.awesomescreenshot.com/video/23145996?key=18e6f687a0abb02570f505c8ecd9e652
Please share working details to log into the<EMAIL_ADDRESS>account so I can continue and submit a proposal for the issue.
Thanks,
Regards,
Ahsan Mahmood
Freelancer @ Upwork

Awaiting proposals

Hey @aoneahsan @abeebridwan were you able to request the details to continue testing?

@bfitzexpensify  no weren't ... I did requested but no response

can you please let us know if we need to mention someone specific?

I'm going to close this as it's only specific to a single account, rather than broadly reproducible


Adding database models to the request object?

I have a question about what the request object can be used for within Express. In particular, I'm considering creating a middleware that adds a database model to the request object, something like this:
const express = require('express');
const db = require('./databaseModel.js');

const app = express();

app.use((req, res, next) => {
    req.db = db;
    next();
}

app.get('/store', (req, res) => {
    req.db.getAllStoreItems()
    .then(storeItems => res.send(storeItems))
    .catch(error => res.sendStatus(500));
}

Is this an appropriate use of the request object? I'm considering this approach because it will make it easier to test my route controllers (I can just pass in a mocked database without needing to monkey patch the models), but I haven't seen this usage pattern much online so I'm not sure if there are performance implications/other gotchas that I'm not considering.
Thanks for the help!

While this is a very common approach, it is actually not the best way.  The best way would be to use one of three other approaches:

app.set:  you could do app.set('myModel, model) then in the handler function req.app.get('myModel').
app.locals: Similar to above, but would also make them available in the view rendering
res.locals: Similar to 2 but you could selectively do it for different routes, where as the app ones are global to the application

Let me know if you need more details on these, or examples.
Now for the main reason not to do req.db = myModel.  It is a performance antipattern.  In an http server the request and response objects are probably the most commonly created objects.  So the runtime will optimize things for this.  But if you modify its shape by adding a key it will deopt it.  Specifically the app settings, app.locals and res.locals are made for this because deopting them is not such a big deal.  I have some benchmarks which I used to compare this and found that just one modification to req can cut perf in half in a basic reduced test case.

Closing since question was answered and no further follow up questions.

@wesleytodd thanks for the detailed answer!