Code scanning: organization-level API for alerts (GHES)

Summary
An external code scanning org-level API to review code scanning alerts at organization level.
Users want to understand code scanning alerts across their organization, so that they can generate insights and better understand their overall security status.  Users want to address questions like "which repositories have lots of code scanning alerts?", "which repositories are not fixing their code scanning alerts?", and "do different repositories have different types of alerts?".  The code scanning org-level API will allow users to review alerts at org-level and derive these insights.
Intended Outcome
The existing code scanning API is only available at repository level.  This makes it difficult for users to retrieve and understand code scanning alerts across an organization.
How will it work?
The code scanning org-level API will be a new API which will be available on Cloud and GitHub Enterprise Server (see separate roadmap item). The API will support one endpoint to retrieve all code scanning alerts.

🚢 This has shipped to GHES 3.5<EMAIL_ADDRESS>


move SymGrad and RCall kernels to functional_ops

This moving of SymbolicGradient and RemoteCall is because
their OPs are defined in ops/functional_ops.h .
Benefits:
if a C++ developer only imports ops/function_ops.cc and kernels/function_ops.cc,
without 2 functional_ops.cc files,
then there won't be runtime errors reporing the OPs are not found.
Other influence:
This commit removes the 2 kernels from //tensorflow/core/kernels:android_core_ops,
which is safe since the two OPs are not defined yet.

Nagging Assignee @yifeif: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @yifeif: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @yifeif: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @yifeif: It has been 59 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Thanks for reviewing @alextp!

@gdh1995 gentle ping to resolve conflicts

Sorry but recent days I have no enough time to complete this PR. So let me close it.


[Wallet Attestation - Dynamic Component View ] Process

This flow could be prone to 'man-in-the-middle' attacks at 'Message 2' Link
Indeed we need to guarantee that a malicious actor cannot redirect Trust Chain verification to a fake chain.
To avoid this an option Wallet Instance could include Wallet Provider's Public Key (Instance will need to be updated in case of key changes in this case), other option would be that Wallet Provider or its Trust Chain Anchor need to be 'anchored' in a Trust List/Registry managed by the Supervisory Body where its Public Key is available.
From Wallet Provider's side, to avoid that third parties could request a Wallet Attestation (therefore the attestation would come not from the Wallet Instance but from a malicious actor), there should be a method to securely identify a real Wallet Instance (for example there could be an instance identifier encrypted with a dedicated WP Private Key).

the trust chain is fastly renewed to check against any revocation of its subject
the trust chain is resolved under a well known trust anchor, that defines if the subject can play the role of wallet provider
wallet provider's public key may rotate, therefore I'm againts any hard-coded cryptographic binding within the application'd code.
the Trust List as reinforcment makes sense, since it is inline with the eIDAS trust architecture, at the same time the trust list may contain the trust anchors or the wallet providers.
at the same time a bogus wallet provider, listed in the trusted list as well, may became an adversary. For this reason some security/implementation consideration should be developed along this issue. there may be cases where a wallet instance knows how to interact with its wallet provider. We need to explain and make this clear to the implementers

Wallet Providers though their Trust Chain Root Authorities are anchored in Trust List managed by appointed Supervisory Body or  by a delegated authority. Wallet Providers and their Trust Chain Anchors are anchored in a Trust List managed by a Supervisory Body, accredited by National Accreditation Bodies, and certified by Conformity Assessment Bodies (CAB). This ensures the integrity and authenticity of wallet solutions are rigorously maintained. These layers of security and oversight create a trusted environment, allowing users to rely on the legitimacy and safety of their wallet instances. Consequently, this robust framework significantly mitigates the risk of fraudulent redirections, safeguarding users' transactions and data.


POSTGRES storage

https://vercel.com/storage/postgres

This is not really worth implementing, at least at the moment. A database would be read-only, with no real filtering performed at all. It will be much easier out to at least a few hundred cities to simply store the GeoJSON files within this repo, and load them individually. This will change how the mutation algorithm works, and also require storing another series of data files, but still be much easier to maintain without setting up a database.


fast framework example

@danice Another beautiful example. Thank you.

i tried to use https://github.com/ben-girardet/aurelia-fast-adapter to register fast components, but it was not working. I'm trying to get a fix for that...


Added the script that creates byte tx for hedera wrapped tokens

Detailed description:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist

[ ] Documentation added
[ ] Tests updated

Can we move this to scripts/token/wrapped/create_bridge/create_bridge.go much like the associate_bridge one


cannot find package "." in

Important Details
How are you running Sentry?
On-Premise w/ Docker, version x.y.z, but it doesn't matter
Description
When I try to build my packages in monorepo which uses vendoring I receive error.
CGO_ENABLED=0 GOOS=linux go build -ldflags "-X main.Version=91f3601 -X main.Hash=91f3601" -installsuffix cgo -o ./bin/gcdn-storage-api .

../../vendor/github.com/getsentry/sentry-go/client.go:20:2: cannot find package "." in:

/drone/src/vendor/github.com/getsentry/sentry-go/internal/debug

I believe that the problem is that you are trying to import 'internal' package and when I build my packages they can't use you internal package during build because of '../../vendor' this dot thing.
It could work if I have 1 package in the root of my module, but I have multiple packages.
My directory structure:
├── src
│   ├── app-1 (imports sentry lib)
│   ├── app-2 (imports sentry lib)
│   ├── app-3 (imports sentry lib)
└── vendor
    ├── github.com
    ├── go.elastic.co
    ├── go.mongodb.org
    ├── go.uber.org
    ├── golang.org
    ├── google.golang.org
    ├── gopkg.in
    ├── howett.net
    ├── k8s.io
    ├── modules.txt
    └── sigs.k8s.io

Steps to Reproduce

Create dir foo, init go module there
Create directory src and add main.go there
Write some code in main go which interacts with sentry lib
run go mod vendor
go build -o mybin ./src
profit, you have received error

What you expected to happen
My packages can be built

Yeah, sorry that I created issue in a wrong project. Have you looked into it?

Cc @rhcarvalho

Hi @gofort, I could not reproduce the problem with the steps you provided.
What Go version are you using?
Try:
Save this file as sentrygo333.go:
// +build ignore

package main

import (
	"fmt"
	"os"
	"os/exec"
	"strings"
)

func main() {
	path, err := os.MkdirTemp("", "sentrygo333-")
	if err != nil {
		panic(err)
	}
	defer os.RemoveAll(path)
	err = os.Chdir(path)
	if err != nil {
		panic(err)
	}
	shell("pwd")
	shell("go", "version")
	shell("go", "mod", "init", "sentry-go/issues/333")
	shell("mkdir", "src")
	f, err := os.Create("src/main.go")
	if err != nil {
		panic(err)
	}
	f.WriteString(`package main

import (
	"fmt"

	"github.com/getsentry/sentry-go"
)

func main() {
	sentry.Init(sentry.ClientOptions{})
	fmt.Println("Built using Sentry SDK version", sentry.Version)
}
`)
	f.Close()
	shell("cat", "src/main.go")
	shell("go", "get", "./...")
	shell("go", "mod", "vendor")
	shell("tree", "-L", "4")
	shell("go", "build", "-o", "mybin", "./src")
	shell("./mybin")
	shell("sh", "-c", "strings mybin | grep vendor/github.com/getsentry")
}

func shell(prog string, arg ...string) {
	fmt.Println("$", prog, strings.Join(arg, " "))
	cmd := exec.Command(prog, arg...)
	cmd.Stdout = os.Stdout
	cmd.Stderr = os.Stderr
	err := cmd.Run()
	if err != nil {
		panic(err)
	}
}

Then run:
go run sentrygo333.go

Output:
$ pwd
/private/var/folders/5f/7dv67jv51d55gzm_723cp1d80000gn/T/sentrygo333-30299174
$ go version
go version go1.16.2 darwin/amd64
$ go mod init sentry-go/issues/333
go: creating new go.mod: module sentry-go/issues/333
$ mkdir src
$ cat src/main.go
package main

import (
        "fmt"

        "github.com/getsentry/sentry-go"
)

func main() {
        sentry.Init(sentry.ClientOptions{})
        fmt.Println("Built using Sentry SDK version", sentry.Version)
}
$ go get ./...
go get: added github.com/getsentry/sentry-go v0.10.0
$ go mod vendor
$ tree -L 4
.
├── go.mod
├── go.sum
├── src
│   └── main.go
└── vendor
    ├── github.com
    │   └── getsentry
    │       └── sentry-go
    └── modules.txt

5 directories, 4 files
$ go build -o mybin ./src
$ ./mybin
Built using Sentry SDK version 0.10.0
$ sh -c strings mybin | grep vendor/github.com/getsentry
/private/var/folders/5f/7dv67jv51d55gzm_723cp1d80000gn/T/sentrygo333-30299174/vendor/github.com/getsentry/sentry-go/internal/debug/transport.go
/private/var/folders/5f/7dv67jv51d55gzm_723cp1d80000gn/T/sentrygo333-30299174/vendor/github.com/getsentry/sentry-go/client.go
/private/var/folders/5f/7dv67jv51d55gzm_723cp1d80000gn/T/sentrygo333-30299174/vendor/github.com/getsentry/sentry-go/transport.go
/private/var/folders/5f/7dv67jv51d55gzm_723cp1d80000gn/T/sentrygo333-30299174/vendor/github.com/getsentry/sentry-go/dsn.go
/private/var/folders/5f/7dv67jv51d55gzm_723cp1d80000gn/T/sentrygo333-30299174/vendor/github.com/getsentry/sentry-go/hub.go
/private/var/folders/5f/7dv67jv51d55gzm_723cp1d80000gn/T/sentrygo333-30299174/vendor/github.com/getsentry/sentry-go/integrations.go
/private/var/folders/5f/7dv67jv51d55gzm_723cp1d80000gn/T/sentrygo333-30299174/vendor/github.com/getsentry/sentry-go/sourcereader.go
/private/var/folders/5f/7dv67jv51d55gzm_723cp1d80000gn/T/sentrygo333-30299174/vendor/github.com/getsentry/sentry-go/util.go
/private/var/folders/5f/7dv67jv51d55gzm_723cp1d80000gn/T/sentrygo333-30299174/vendor/github.com/getsentry/sentry-go/interfaces.go
/private/var/folders/5f/7dv67jv51d55gzm_723cp1d80000gn/T/sentrygo333-30299174/vendor/github.com/getsentry/sentry-go/sentry.go
/private/var/folders/5f/7dv67jv51d55gzm_723cp1d80000gn/T/sentrygo333-30299174/vendor/github.com/getsentry/sentry-go/tracing.go
/private/var/folders/5f/7dv67jv51d55gzm_723cp1d80000gn/T/sentrygo333-30299174/vendor/github.com/getsentry/sentry-go/scope.go

As you can see the build works just fine and vendor/github.com/getsentry/sentry-go/internal/debug/transport.go is included in the build.

I have found out where the problem is. It could be reproduced only in my CI system and the problem was that I have 'debug' word on my .gitignore, so package was not added to git and build failed because it could not find this package.
Sorry for this irrelevant issue.
Bests,
Bogdan

Glad you got it working!

I have found out where the problem is. It could be reproduced only in my CI system and the problem was that I have 'debug' word on my .gitignore, so package was not added to git and build failed because it could not find this package. Sorry for this irrelevant issue.
Bests, Bogdan

Thank you! Have the same issue.
I made go mod vendor on my codebase and locally everything was ok. But on my CI it failed with
vendor/github.com/minio/minio-go/v7/api-bucket-tagging.go:30:2: cannot find package "." in:
	/builds/my-team/my-project/vendor/github.com/minio/minio-go/v7/pkg/tags
make: *** [Makefile:50: build] Error 1

Issue was that my .gitignore file had these lines
# Auto-generated tag files
tags

After removing them I realised that vendor/github.com/minio/minio-go/v7/pkg/tags folder was ignored. After I added it the error is disapeared.
How to troubleshot: comment all lines in .gitignore or move it then check git status to understand which files are missed.


Gulp 4 task alias

How can I have a task nodemon get aliased to also be callable through gulp dev? Does it make sense to have to do gulp.task('dev', gulp.series('nodemon')); instead of gulp.task('dev', 'nodemon');?
When I do the first code snippet, I get an error:
AssertionError: Task function must be specified
    at Gulp.set (/Users/Eytan/Desktop/hths-lunch/node_modules/gulp/node_modules/undertaker/lib/set.js:14:3)
    at Gulp.task (/Users/Eytan/Desktop/hths-lunch/node_modules/gulp/node_modules/undertaker/lib/task.js:14:8)
    at Object.<anonymous> (/Users/Eytan/Desktop/hths-lunch/gulpfile.js:168:6)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Liftoff.handleArguments (/usr/local/lib/node_modules/gulp/bin/gulp.js:136:3)

@ilanbiala looking at the log seems to me more likely to be an error with the undertaker package, did the named function solve your problem?


Avoid dropping Esc characters from VT responses

GetChar checks if the vkey is VK_ESCAPE. CharToKeyEvents however
tries really hard to figure out the vkeys of all characters.
To avoid these issues all we need to do is to simply use the existing
WriteString function we already use for all other VT responses.
If it's good for conhost responses, it's good for ConPTY responses.
Additionally, this removes another IsVtInputEnabled which was
redundant with WriteString which worked exactly the same internally.
Closes #17813
Closes #17851
Probably also related to #17823
Validation Steps Performed

Wrote a small app to send and receive a DA1 request. It works ✅
WSL already worked to begin with (and still works now) ✅
No double-encoding of mouse input events ✅

FYI, I've tested the Windows version of yazi with this branch and it is working now, so I think it's safe to close #17823 as well. I'm assuming the failed query responses were also responsible for it not responding to any input, because that's no longer a problem.

Oh nice. This also fixes the double-encoding of mouse input events when win32-input-mode is enabled!

Related #17656

Please tell me in which release should we expect this change?

Please tell me in which release should we expect this change?

@unxed Since it fixed a regression in 1.22, it was released to the preview channel on Friday, 27 September with version 1.22.2702.0.


The comment codes/whitespace in csproj file are missing after editing the csproj file and reopening it.

Test the scenario on the build d15rel\25909.02;
Repro steps:
1>Edit csproj and change some codes to comment;
2>Save and close the csproj file;
3>Reopen the csproj and find the comment codes missing.

Expected result:
Reopen the edited csproj file and the comment codes still exist in the file;
Actual result:
Reopen the edited csproj file and find the comment codes missing.

@333fred - could be a msbuild issue similar to #742?

I think it's probably related, but I'm not sure it's exactly the same.

Adding whitespace to this bug as well, as they're the same issue. A CPS change is needed to fix this.

For RC3, the comment part of this issue should be resolved. Whitespace is still being stripped, that will be fixed post-RC3.

Fixed with #1266.


Right-clicking in folder empty space causes crash

Description
Greetings,
When I open multiple folders in COLUMN view, right-clicking on the blank block to the right causes the whole program to crash (it could be one right-click or multiple). I think there may be a problem with the implementation of the right margin block in this view.
Steps To Reproduce
1.switch to the "column" view.
2.open two or more folders.
3.right click the blank block twice or more.
4.then crashed.
Expected behavior
I dont know what is the expected behavior but not crashed.
Files Version
Version:<IP_ADDRESS>
Windows Version
Windows 10 Professional 21H1
Relevant Assets/Logs

Not specific to column view:
2021-12-28 10:46:14.7413|ERROR|AppUnhandledException|Layout cycle detected.  Layout could not complete. Layout cycle detected.  Layout could not complete. 	Windows.UI.Xaml.LayoutCycleException: Layout cycle detected.  Layout could not complete. Layout cycle detected.  Layout could not complete.

Merging with #5666


No .fill method on Array

const numbers: Array<number> = [];

numbers.fill(500); // Error here

Property "fill" does not exist in "Array<number>"

Playground

Thank you fro contribution ^_^


In order to share chirps, I can refactor the csv database to a webservice

download
https://bit.ly/4eugCty
I put the necessary dlls in the archive


feat(reroute): Allow for dynamic asynchronously rerouting #13176

The Problem
The current SvelteKit Reroute functionality doesn't support dynamic rerouting for localization where settings are stored in a database.
The solution?
Modify the Reroute function to return MaybePromise<void | string> and update its implementation in server/response.js and client/client.js.
Usage
import type { Reroute } from '@sveltejs/kit';

export const reroute: Reroute = async ({ url }) => {
    if (url.pathname.startsWith('/api')) {
        return;
    }

    const response = await fetch(url.protocol + '//' + url.host + '/api/locales');

    const locales = await response.json(); // as Type[];

    // write re-routing logic here
};

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

[x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

preview: https://svelte-dev-git-preview-kit-13186-svelte.vercel.app/
this is an automated message

Relevant Issue: #13176


Not downloading pictures in answers

So I just realized that it's not dowloading pictures embedded in answers? Is it a bug, or expected?

It's simply not implemented. I actually don't use tumblr myself and i didn't know there is an answer post type. For the tumblr implementation I took the hard way and we're stepping down all the paths of each post kind instead of just use regular expression or some type of general matching.
It's probably just 3-10 lines of code and similar to the other post kinds already implemented though. You might want to add it for yourself, or wait till someone does it. I don't have time to do this right now though..


[BIOMAGE-1208] - Update defaultFilterSettings when QC pipeline is run with auto

Background
Link to issue
https://biomage.atlassian.net/browse/BIOMAGE-1208
Link to staging deployment URL
https://ui-agi-test-exp-copy.scp-biomage.net
Links to any Pull Requests related to this
N.A.
Anything else the reviewers should know about the changes here
This ticket is part 2 of the database migration.

The first part has been done via a script, adding hardcoded defaultFilterSettings to all projects in production.
This ticket saves the calculated auto configs from QC pipeline into defaultFilterSettings when auto is enabled, effectively updating the auto value when the QC pipeline is run.

Changes
Code changes
Definition of DONE
Your changes will be ready for merging after each of the steps below have been completed:
Testing

[ ] Unit tests written
[X] Tested locally with Inframock (with latest production data downloaded with biomage experiment pull)
[X] Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils
Documentation updates
Is all relevant documentation updated to reflect the proposed changes in this PR?

[ ] Relevant Github READMEs updated
[ ] Relevant wiki pages created/updated

Approvers

[ ] Approved by a member of the core engineering team
[ ] (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

[ ] After the PR is approved, the unstage script in here: https://github.com/biomage-ltd/biomage-utils is executed. This script cleans up your deployment to staging

Optional

[ ] Photo of a cute animal attached to this PR

For some reason the PR is also merging some changes other than yours too, are we ok with that?
Also the staging link doesn't seem to be working for me.

For some reason the PR is also merging some changes other than yours too, are we ok with that?
Also the staging link doesn't seem to be working for me.

Are these the changes that it is also trying to merge in?
If these are the only ones, then the code coverage one and the violin plot should be good to merge. I have no idea about update to use output instead of current filter settings though.


docs: add new workflow documents

Signed-off-by: wuhuizuo<EMAIL_ADDRESS>

/hold

/unhold

/approve

fixed, please review it again 🌹 @Mini256

/approve cancel
need more reviews.

/approve


Trivial point

A null entry to port selection displays offer for help or ctrc-d to quit and then quits.
Johns-MacBook-Pro:folie john$ ./folie
Folie v2.2-23-g23dc02f
Select the serial port:
  1: /dev/cu.Bluetooth-Incoming-Port
  2: /dev/cu.Bluetooth-Modem
?
Enter '!help' for additional help, or ctrc-d to quit.
Johns-MacBook-Pro:folie john$

Good catch, thanks.


Cross resource group nodes

Feature Description

One-line feature description (can be used as a release note): Add support of cross resource group nodes.
Primary contact (assignee): @feiskyer
Responsible SIGs: sig-azure
Design proposal link (community repo): https://github.com/kubernetes/community/pull/2479
Link to e2e and/or unit tests:
Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @khenidak
Approver (likely from SIG/area to which feature belongs): @brendandburns
Feature target (which target equals to which milestone):

Alpha release target (1.12)
Beta release target (x.y)
Stable release target (x.y)

/sig azure
/sig storage
/milestone v1.12

/kind feature
/stage alpha

@feiskyer thank you. this has been added to the 1.12 Feature Tracking sheet. Please keep the post updated with links to PRs and design docs proposals.

Community PR created https://github.com/kubernetes/community/pull/2479

Hey there! @feiskyer I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@zparnold We will update docs in repo https://github.com/kubernetes/cloud-provider-azure. Should it also be placeholded?

Only if it needs to go into the general https://kubernetes.io/ website
docs. :)
On Mon, Aug 20, 2018 at 9:47 PM Pengfei Ni<EMAIL_ADDRESS>wrote:

@zparnold https://github.com/zparnold We will update docs in repo
https://github.com/kubernetes/cloud-provider-azure. Should it also be
placeholded?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/features/issues/604#issuecomment-414532102,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE81SPUL3EjV9Wte-npQHzQYGOzLxPFoks5uS3SzgaJpZM4VoNqe
.

@justaugustus Which folder do you suggest?

@justaugustus Yep, codes have been merged now and docs will be added to https://github.com/kubernetes/cloud-provider-azure

Thanks for the update!

Hi folks,
Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to alpha/beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?
We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP.

It's already part of KEP, https://github.com/kubernetes/community/pull/2479. Let's keep it in v1.13.
/milestone v1.13

@feiskyer can you please update the original post with milestone of beta for 1.13? Thanks!
/stage beta

can you please update the original post with milestone of beta for 1.13? Thanks!

@kacole2 Sorry, didn't catch you. The PR has already been merged, why its milestone should be changed?

@feiskyer sorry, I should have been more clear. In the original post description please update the milestone information so it’s clear
‘’’
Feature target (which target equals to which milestone):
Alpha release target (1.12)
Beta release target (x.y)
Stable release target (x.y)
‘’’

@kacole2 Thanks. Updated.

@feiskyer what work is left for this to land in Beta in 1.13? Is there a list of pending PRs we are tracking for this (code, test and docs) or is everything merged?

Hi @feiskyer, will there be any updates to the docs necessary for 1.13? The deadline for placeholder PRs for the 1.13 release is November 8. So it's important to make a docs PR as soon as possible if needed.

@feiskyer is this still on track for 1.13? is there any pending PR for this for 1.13 - code, docs ? We are fast approaching Code slush (11/9) and Code freeze (11/16)

@AishSundar No docs required, thanks

I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.
Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

yep, this is on tracked.
/milestone v1.15

@feiskyer, we're doing a KEP review for enhancements to be included in the Kubernetes v1.15 milestone. After reviewing your KEP, it's currently missing test plans and graduation criteria which is required information per the KEP Template. Please update the KEP to include the required information before the Kubernetes 1.15 Enhancement Freeze date of 4/30/2019. Thank you

@feiskyer, Enhancement Freeze for Kubernetes 1.15 has passed and this did not meet the deadline. Still missing Test Plans and Graduation Criteria from the KEP. This is now being removed from the 1.15 milestone and the tracking sheet. If there is a need for this to be in 1.15, please file an Enhancement Exception. Thank you. @claurence
/milestone clear

/milestone v1.16

Hi @feiskyer , I'm a 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If it's not graduating, I will remove it from the milestone and change the tracked label.
Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.
Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.
Thanks!

@rbitia Yep, already added to 1.16 milestone

Are you planning to graduate to stable or beta?

Hey @rbitia! We're going GA/Stable with this in 1.16. :)

Yep, we're working on the e2e tests for this.

Hi @feiskyer, I'm the v1.16 docs release shadow.
Does this enhancement require any new docs (or modifications)?
Just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday,August 23rd. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!
Thanks!

@VineethReddy02 Thanks, no new docs are required.

@feiskyer urgent request can you please update the KEP with Graduation Criteria. This is a requirement for being included in the current 1.16 milestone. Please respond back with the PR ASAP. Thank you.

@kacole2 thanks, would do

Update: PR sent at https://github.com/kubernetes/enhancements/pull/1202

Documents have been added at https://github.com/kubernetes/cloud-provider-azure/blob/master/docs/using-cross-resource-group-nodes.md.
E2e tests have been added at https://github.com/kubernetes/cloud-provider-azure/pull/205.
Because aks-engine doesn't support to provision cross-resource-group nodes, the e2e tests couldn't be run periodically yet. But I think aks-engine should not be the blocker for this feature.
/close


feat(source): Default key for UpsertAvro

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add default hidden primary key column _rw_kafka_key with type varchar when we cannot extract key schema from avro.

Checklist

[ ] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR contains user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

Will change the type to bytea later.

when we cannot extract key schema from avro

I am a little confused. I thought in most cases, the key part will go directly into _key column, regardless of the encode. cc @st1page we may sync later


types for database?

I'm trying to figure out how to get the types to work in the provider. I currently have the following when creating my db where DatabaseCollections is the types I've setup for my db:
const [db, setDb] = React.useState<RxDatabase<DatabaseCollections>>()

...

const db = await createRxDatabase<DatabaseCollections>(…)

…

<Provider db={db}>{…}</Provider>

However I get the following type error on the Provider component:
Type 'RxDatabase<DatabaseCollections>' is not assignable to type 'RxDatabase<CollectionsOfDatabase>'.

You don't have to specify any types through the Provider, you can simply pass them when consuming data via useRxQuery, or useRxData.
useRxQuery example:
const collection = useRxCollection<Character>('characters');

const query = useMemo(() => {
  if (!collection) {
    return;
  }
  return collection.find();
}, [collection]);

const { result: characters } = useRxQuery<Character>(query);

useRxData example:
const queryConstructor = useCallback(
  (c: RxCollection) => c.find(),
  []
);
const { result: characters } = useRxData<Character>('characters', queryConstructor);


feat(hekla,mainnet): make p2p.sync always required

Converted this to draft, let's wait for the new client release

Closed by https://github.com/taikoxyz/taiko-mono/pull/18648


Frontend framework support

See this: https://github.com/webui-dev/webui/issues/109
I tried to do as I was advised by @AlbertShown, or rather change the path imports of all js/and css scripts in the html file to out/path instead of path, but it had exactly no effect.
Error receiving script files for current html

But this script's located right

Right now my page looks like this when I export HTML from React through NextJS

But it should be like this:

Exported this page to github pages is: https://griffith1deady.github.io/languages
Minimal code for error is:
import std/os, webui

var window: Window

proc main =
  window = newWindow(1)
  window.runtime = NodeJs
  window.show("languages.html")
  wait()

setCurrentDir(currentSourcePath().parentDir() & "/out")

main()

All source files with pages & resources, more precisely exporting my site https://github.com/griffith1deady/griffith1deady.github.io packed in an archive:
NIM.zip
Also, you may notice some visual differences between my resources and those on the work site: all this is because I just used earlier commits.
Do I think something is just blocking the distribution of files?

You may see errors on other pages, too, if you change the file name to one not edited under out/

Thank you for the package, I can reproduce the issue.
I'm investigating.

nim -d:webuiLog c test.nim
./test
[User] webui_new_window_id([1])...
[Core]          WebUI v2.3.0
[Core]          _webui_init()...
. . .
[Core]          _webui_file_exist([XXX/out/out/_next/static/css/5df3faa623ded248.css])...

/out/out/ does not exist.
I'm looking how to fix it...

If you put all the resources in out/out, that won't work either.
The same goes for all the other pages, even if you do something like this:

VSCode can find the file, but WebUI cannot.

I have to answer that in the beginning it just couldn't find the files, but now it's blocking access/syntax error when reading them.

Try this code:
import webui

var window: Window

proc main =

  # Create a new window object
  window = newWindow(1)

  # Make NodeJs as the `.ts` and `.js` interpreter
  # The command `node` should works on your system
  # window.runtime = NodeJs

  # Next WebUI version will have an option to change
  # the web-server root path like this:
  # window.setRoot(currentSourcePath().parentDir() & "/out")
  # Then all resource can be loaded as "/resources..."

  # Show the new window using a local HTML file
  # The web-server root path is: "/"
  # All resources should be: "/out/resources..."
  window.show("/out/languages.html")

  # Wait until all windows get closed
  wait()

main()

According to this: https://webui.me/docs/#/nim_api?id=show-window
don't forgot to add <script src="/webui.js"></script> at the end of your HTML files.

Okay, thank you!


Allow vscode.dev to load and save text from URLs

It would be cool if I could open vscode.dev with loadUrl and saveUrl query parameters, and it could use them to load and save text.
Example:
I have a website at example.com, and I have implemented endpoints to load and save over Azure Storage blobs.

https://example.com/files/load/foo.json
https://example.com/files/save/foo.json

I could create links on a page to open foo.json in vscode.dev like so:
Edit foo.json

vscode.dev would call the load endpoint which returns text/text, and then when the user saves, it would POST to the save endpoint.

This can be achieved by an extension which would implement a file system provider and call those endpoints accordingly.


Cannot import name 'BertForWebqa'

Thank you for your contribution on this baseline! But when I try to run this repo on my own device, when I ran run_webqa.py, it said ImportError: cannot import name BertForqa. Could you give me a hand? Thank you so much!

Moving run_webqa.py to the directory above the vlp/ makes the imports work since pytorch_pretrained_bert isn't inside vlp/. However, there still seem to be path issues while loading the dataset.


Initial hosting setup

Need to do the initial hosting set up of the site on my Debian self-hosted server.

added dates


Color of horizontal Lines incompatible with dark Mode

On a web page with white text and a dark background ("dark mode"), the pseudocode block looks a bit strange.
In particular, the horizontal lines remain black, even though the text and the vertical lines are  white.

To fix this, I suggest replacing
border: 2px solid black;

inside of pseudocode.css with:
border-width: 2px;
border-style: solid;

This way you could use pseudocode.js also on a dark website.

Thanks for reporting this issue, @Mavoort!
I have reviewed your changes and left some minor comments. I've also linked your PR to this bug so this issue will be closed automatically when we merge your change.


Fix Arduino Version

Missing few things, such as:

Macro for max power
Auto adjust power randomly

Also fix string in Arduino version via .c_str()

Fixes #39 (probably).


Revise translations

I've redone some parts of the translation which seemed odd (machine-translated?).
Please let me know if you like the style of translation and also whether the headers (ms.translationtype etc.) of the files need to be changed. I'll add commits as necessary.
Thanks!

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: karottenbaum sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Hello @karottenbaum  , thank for your contribution. We are currently reviewing it.
We will communicate the decision taken accordingly. Thanks for your time and support.
Kind regards,  Microsoft C&E Localization Team


Add a check for the legacy msmart package on import

Try to fail more obviously on systems that have conflicting packages

Maybe not necessary after all


Task-based Inspection for Mingsai #17

Please review the R6 of 5.1 Functional Requirements section of the SRS, what do you think should be the precision for the result? What is the reason that traffic model and climate model have data from 2006 to 2100, would that be a likely change in the future?

Two decimal places are enough.
Climate predictions are only available until 2100.
Yes, both traffic data and climate data are very likely to change.


support for @angular/forms

This PR should resolve #627.  Uses the new providers/directives from @angular/forms

thank you very much. I will take a look at this later today.

@jFensch You forgot to add the @angualr/forms to the .config/bundles-system.js. Can you please update this?

@Dinistro and rebase is must, or cherry pick at least

@jFensch Can you please rebase your branch to resolve the conflicts?

@jFensch Some tests are not running, can you please fix them?

@valorkin Now we need to do this be our own. Unluckily I have finals on monday and so I don't have time to do it right now.

Recloning and fixing the tests...give me a minute.
Sorry

Hi guys :)  Any idea when the broken 1.0.17 will be fixed?  I'm getting the "No provider for NgModel" also, and can't move forward with my development.  Would really appreciate this being fixed.

+1

i'm having same issue with rc4

Yeah, same here. Can't wait for the update.
Thanks for your hard work as always guys!

Yes, thank you for the hard work and commitment.  All of us who are using the ng-bootstrap library really do appreciate it.  We would not be able to move forward with Angular 2 without it!  Please let us know about the status of this breakage so we can make plans accordingly.  Much appreciated :)

In order to use new forms you need to enable them:
https://github.com/valor-software/ng2-bootstrap/blob/development/demo/index.ts#L57-L58
and use NgModel from angular/forms

Don't work for me. Added
disableDeprecatedForms(),  provideForms(),
and used NgModel from @angular/forms. Still ORIGINAL EXCEPTION: No provider for NgModel! with ng2-bootstrap 1.0.20

@trollr @valorkin i will take a look at this.

Just a heads up, it does work fine for me with 1.0.22.

@trollr @juampi I forgot to add the support for typeahead inside a form...

Oh, I see. I didn't test typeahead.

@trollr This PR should fix it: #723


Trying to drag someone while holding a rifle always causes the rifle to be dropped, no matter the active hand combination

Reported by @"Herbert Falsevor#3037"

Isn't this due to drag/pull taking up a handslot? And I'm pretty certain this isn't specific to rifles

This is not the case anymore, you cant pull if both of your hands are full and pulling takes the free hand


Kristina - Maple

Great job Kristina! I don't have feedback after looking through your code. I think you did a good approach. Your code was clean and readable.


Set custom ID for rootView

Currently, the preload ID (to be used with supersonic.layers.push, for example) for the rootView is set to the full location path of the view, i.e. http://localhost/app/example/index.html. This is confusing. Instead, you should be able to define in config/structure.coffee:
rootView:
  location: "example#index"
  id: "index"

+1

Ran into issues with this today. +1

+1

I saw a pull request for this get merged (https://github.com/AppGyver/steroids/pull/1010). But I am still unable to call the replace method on my rootView even after giving it an ID in my structure.coffee file.
Is there any way to do this currently?

any updates?

Coming up in the iOS/Android release pipeline, no ETA. The native code hasn't been released yet.


feat: Tower.test/0 and mix tower.test to help confirm tower well configured

closes #63

Closing in favor of #69


when editing the text on a sign, the sign is isn’t where it should

it makes the text go above the sign on the text editing gui

You're probably using Re-Console, some mod is modifying is changing back the Sign Edit screen


*: lease timetolive

Fix https://github.com/coreos/etcd/issues/5868.

@xiang90 @heyitsanthony Addressed. PTAL. Thanks.

@gyuho
Discussed with @heyitsanthony. The current approach does not work well since we will renew the lease when probing.
I think we should still have a separate user facing RPC for getting the information of a lease. Probably we should call it TimeToLive
message LeaseTimeToLiveRequest {
  // ID is the lease ID for the lease to keep alive.
  int64 ID = 1;
}

message LeaseTimeToLiveResponse {
  ResponseHeader header = 1;
  // ID is the lease ID from the keep alive request.
  int64 ID = 2;
  // TTL is the remaining time-to-live for the lease.
  int64 TTL = 3;
  // Keys is the list of keys attached to this lease.
  repeated string keys = 5;
}

@xiang90 Ok will try that approach today. Thanks!

Now probe is a separate RPC but uses the same logic as keep-alive.
PTAL. Thanks.

LGTM in general. Some minor issues need to be fixed.

@xiang90 All addressed. PTAL. Thanks!

rename all probe to timetolive?

@xiang90 Just renamed them all. PTAL. Thanks!

There are still a few probes in the code. let's fix them up.

@xiang90 PTAL.

lgtm in general. defer to @heyitsanthony. I have to prepare for my flight. :(

@xiang90 Have a great trip. I will address your feedback by tonight. Thanks.

PTAL. I put the ReadAll lines into goroutine. I think checking context inside goroutine makes it complicated as well, because we still need to receive the error from the goroutine.

@heyitsanthony @xiang90 All addressed. PTAL. Thanks.

Thanks @gyuho!
LGTM. Defer to @heyitsanthony

@heyitsanthony All addressed. PTAL.

changed Keys to [][]byte
changed 'TTLtofloat64` to not truncate milliseconds
changed output function to print out attached keys only when --keys flag is passed
added LeaseOption to clientv3
fixed toErr

Thanks!

Now TTL is int64

lgtm after fixing minor doc nit. Thanks!

Just updated the comments. Will merge after greens. Thanks a lot!


rtw-env script deleted by cylc reload

Describe the bug
When running recipe_test_workflow prototype, the main bin/rtw-env script is deleted from the cylc-run directory whenever the workflow is reloaded with cylc vr. This means that most apps no longer run after a reload.
It's not a major issue, because cylc vr is only useful in developing the workflow, and even then it is just a time-saver to avoid re-running the workflow end-to-end.

The solution, from Cylc 8.2 onward, is to store the script in share/bin, which will be included in paths for rose apps.

The issue applies to lib/ as well, so the clone step should write to share/lib/ (or share/lib/python?)


Ability to export some of tweaks

If it's possible, for each or some of tweaks ability to export it with reg file or ps script or bat etc will be nice

This is beyond the scope for now. However, we do have a feature that is being developed to take in variables for a fully automated run. These could easily be tossed in the .bat file so you wouldn't even need the gui.


[BLOG] Cloud Native Sustainability Week 2023

Authors: @leonardpahlke @guidemetothemoon
Reviewers: TBD
TAG ENV Lead: @leonardpahlke

Abstract
Announcement blog post about the cloud native sustainability week, see http://tag-env-sustainability.cncf.io/cloud-native-sustainability-week/ ref tracking issue #95
Scope
event: cloud native sustainability week
Expected audience
we plan to publish it to on the TAG blog and the CNCF blog. This blog post should serve as reference point to anyone in the community to get info about the event.
Goals and Non Goals

goal: intro the event
goal: starting point to learn about the event
non goal: dive into decision etc.

Tasks
A more complete summary of tasks are described on XYZ.

[x] Outline Blog post

[x] [Author] described the abstract of the blog post, defined the scope, goals and non-goals, and defined the expected audience.
[x] [Author] notified TAG ENV community to review the outline via Slack on the tag-env-sustainability channel.
[x] [TAG ENV Lead] One of the TAG ENV leads assigned themselves to wrangle the blog
[x] [TAG ENV Lead] Blog post outline and theme has been discussed

[x] [Author] Blog post written and ready for review
[x] Review

[x] [Author] blog post PR opened (blog posts are added to the website/content/blog folder, images to website/static/images/blog/<YEAR>-<MONTH>-<title>/*.jpg)
[ ] [Author] notified TAG ENV community for review via Slack on the tag-env-sustainability channel.
[ ] [Author] gave a minimum of a week to collect public feedback, depending on reviews this will get extended. If there is a major event (conference, etc.) or holidays coming up, please extend accordingly.
[ ] [Author] Feedback and comments have been resolved.
[ ] [Reviewers] reviewed blog post.
[x] [TAG ENV Lead] reviewed blog post.
[x] [TAG ENV Lead] ready to get published.
[x] [TAG ENV Lead] notified one of the ToC liaisons to sign off the blog post.
[x] [TAG ENV ToC Liaison] reviewed blog post.
[x] [TAG ENV Lead] merged blog post.
[x] optional [TAG ENV Lead] schedule the blog post on the CNCF blog next to the TAG ENV blog
[ ] [Author] Wrote feedback about the blog post process as a comment under this issue

Comments
document: https://docs.google.com/document/d/1cKIlwes0Ws6H1y9LTXHDE-mQ6anNkDDeHUiRxWItS4Q/edit?usp=sharing

blog post published to the TAG ENV blog for tomorrow (sep 6) https://tag-env-sustainability.cncf.io/blog/


HADOOP-18843. Guava version 32.0.1 bump to fix CVE-2023-2976

Bumping guava version to 32.0.1-jre to fix CVE-2023-2976

@jojochuang Can this be done?
This is the only dependency of hadoop-common that still has guava 31.1-jre

We'd also need to release a new hadoop-thirdparty version so the main hadoop repo can use.

@jojochuang Done.

is this ready to go in?
can we get the parquet update in too, at which point we can/should push out a new release -though that won't be a drop-in replacement JAR, will it?
of course, we need to qualify the upgrade

@Killianoc no schedule

@jojochuang any ETA on this?

Is there any movement here?

Is is getting merged anytime soon ?

I've hit the approve and run button to see what the ci builds say. if things are good I'll merge

I've hit the approve and run button to see what the ci builds say. if things are good I'll merge

Any chance you could merge this soon. Got a CVE reporting against hadoop-shaded-guava.

I've hit the approve and run button to see what the ci builds say. if things are good I'll merge

@steveloughran any chance of this being merger and new version released soon?

ok, let's merge
@fredbalves86 what name do you want to use for credit in the commit message?
+what apache jira account is yours to assign the work to?

ok, let's merge
@fredbalves86 what name do you want to use for credit in the commit message? +what apache jira account is yours to assign the work to?

You can use Frederico Alves
I don't have an apache jira account

done. mukund has been looking at doing a new 3.3.x release...we should get this out first

@steveloughran will we have a new release soon?

@steveloughran when will mvn repo be updated with the new jar?

new release is out; 3.4.0 RC2 will ship it!


Fix wrong require arity

require accepts a single operand.
That's crashing when bundling the source code with Webpack.

Good catch! 👍

Fixed in 4.0.5 - thanks @oliviertassinari !


LineEdit cursor is sometimes invisible if 2D scaling is below the native resolution

Godot version
3.4.2.stable
System information
Windows 10, GLES3
Issue description
All text editing controls use a cursor line width of 1 pixel in exported projects. This causes issues when using controls with different scales. This is a common use case when scaling down UI to fit smaller resolution screens.
Example:
This LineEdit has rect_scale=(0.9, 0.9)
At some cursor positions, it is visible:

However, in others, it is always invisible:

Steps to reproduce
See above
Minimal reproduction project
lineeditScaleBug.zip

This causes issues when using controls with different scales. This is a common use case when scaling down UI to fit smaller resolution screens.

Control scaling should only be used for animation purposes, as it breaks down in many situations (input handling, containers, …). Do not rely on Control scaling for multiple resolutions. Use Godot's built-in support for multiple resolutions instead, which supports specifying a custom scale factor since Godot 3.4.

In our project we don't explicitly scale down nodes, but our base resolution is set higher than some platforms we deploy to, resulting in them being scaled down by the engine. So perhaps the issue title/description could be improved.

To my knowledge, this automatic scaling can't be easily detected on the node's size, so I'm not sure what could be done (other than defaulting the caret width to 2).

Solution is probably allowing users to set the caret width in theme properties.

Duplicate of https://github.com/godotengine/godot/issues/24207 (same cause).


2MASS 0415 Ingest

Short description: Ingest of 2MASS 0415-09. Updates the Burg03 IRTF data within the JSON file, adds the AKARI (Sora12), FIRE (Simc13), KECK I LRIS (Burg04), and KECK I LRIS (Kirk08) data using a new script.
Link to relevant issue: Closes #559 & #375
For data ingests:
[x] includes script used for ingest
[x ] includes modified JSON files
[ ] Add new tests
[ ] Update the Versions table

Submitted new edits to the ingest script. Updated JSON files as well to include necessary references for AKARI.

All test pass now! Updated the following lines in test_data.py to update the number of spectra to be found in the database.
def test_spectra(db):
    regime = "nir"
    t = db.query(db.Spectra).filter(db.Spectra.c.regime == regime).astropy()
    **assert len(t) == 582, f"found {len(t)} spectra in the {regime} regime"**

Ingested the publication for the IRC instrument. Added details to the AKARI telescope entry. Corrected the regime values for the LRIS KECK spectra to optical from nir.


initial work in progress

test failing - have to amend regexMatches to use for (const regexMatch of Object.keys(regexMatches)) {

Hey @TwitchBronBron ready for review - I have taken the work as far as I can, just require your input before I proceed further, thanks.

cc @chrisdp


Fixed padding for text

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after), along with a short summary of changes:
Issue
Fixes #
Changelog:

align-top added

Test URLs:

Original: https://www.sunstar.com/about/chairman-interview
Before: https://main--sunstar--hlxsites.hlx.live/about/chairman-interview
After: https://fix-lead--sunstar--hlxsites.hlx.live/about/chairman-interview

Library

[ ] New Blocks introduced in this PR
If yes, please provide details below
Block Name : For e.g. cards

[ ] Documented in sidekick library

[ ] New variations introduced in this PR
Variation Name :  For e.g. cards (grid)

[ ] Documented in sidekick library

[ ] New mixins introduced in this PR
Mixin Name :  For e.g. compact, white

[ ] Documented in sidekick library

@ehrro Yeah, my fault I didn't check, I assumed the lead variant had its own padding that would override this, I added a padded variant to text


Add scheduler docs missing from website.

Docs for DC/OS Marathon Scheduler and Kubernetes Scheduler exist in the repo, but are not shown on the website as they are missing from website/data/toc.yaml.
Verified by building the site after this change, docs for these schedulers are present.

My understanding is that these docs are not currently displayed in the sidebar because they're either not fully baked or not currently up to date.
@sanjeev @kramasamy Are these docs more or less up to date?

This document is not fully flushed out yet.

I'm going to close this for now. PR #2444 will add the Kubernetes doc (as well as the TOC reference) and future PRs will address the other schedulers.


[Feature] Refactor dev setup to accomodate for opentofu

Currently, bits of the validation setup (see the Makefile and the contributing guide) assume that the developer is using terraform. With the emergence of opentofu, this is not strictly the case anymore. We amend the setup / guide to accommodate this
The success criteria is that I should be able to run the equivalent of make test-stack without terraform installed

I was planning on doing this too, but using Terragrunt.

I guess we're having parallel thinking :smile:

opentofu usage through terragrunt should be included in this issue.


Batch account location lookups for sparse ledger

This PR builds upon #14520. This adds batching for the location lookups in the sparse ledger conversion function.
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

!ci-nightly-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

I'm a little bit concerned about performance of self_find_or_batch_lookup. Does the performance gain of batch lookup justify going over the list of identifiers 3 times here? Is preserving the order of identifiers important? If it's not, then this could be done a little faster.

@Sventimir What's your performance concern exactly? The operation is O(n).


Improve any to other type casting

Description:
Currently, we cannot directly cast an any value to another value. The below code snippet will produce an error(error: 'string' cannot be cast to 'int') which can be confusing to the user because the string->int casting is possible in Ballerina.
any choice = io:readln("Enter choice 1 - 5: ");
var intChoice = <int>choice;

We need to add an additional line to cast the any->string first, like below.
any choice = io:readln("Enter choice 1 - 5: ");
string s = <string>choice;
var intChoice = <int>s;

It is better if we can do this unboxing automatically.
See also https://github.com/ballerina-platform/ballerina-lang/issues/8842.

This is no longer valid with the changes introduced with https://github.com/ballerina-platform/ballerina-lang/pull/13479, introducing the type cast expression specified in the 0.990.0 spec.
string to int conversion cannot be done using the diamond operator.
The current alternative is to use .convert(), but this would change in the future (refer - https://groups.google.com/d/topic/ballerina-dev/9wSEMbqkltI/discussion).
    var intChoice = int.convert(choice);


etckeeper: Do not attempt to push to GitHub

This would actually make sense to get the commits made by the apt hooks.
However, this is not working and randomly causes etckeeper to hang, which in turns causes sync.yml not to terminate.
I think we should find a better way to deal with commits caused by package installation, but I'm not sure yet what the solution is.

Nevermind, this now works fine with the other automation fixes.


added 'Azure SQL Managed Instance' here and there

In text where SQL Server and Azure SQL database are specifically mentioned it leads one to think it's not applicable to Azure SQL Managed Instance where in many cases it's also applicable to MI. Not sure about XML compression (Applies to: SQL Server 2022 (16.x) Preview and later, and Azure SQL Database Preview.), if that's also in preview for MI.
Kind regards, inge

Docs Build status updates of commit c233a0b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

docs/t-sql/statements/create-index-transact-sql.md
:x:Error

Details

docs/t-sql/statements/create-index-transact-sql.md

Line 66, Column 267: [Error: include-not-found] Invalid include link: 'https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/includes/ssazuremi_md.md'.
Line 92, Column 69: [Error: include-not-found] Invalid include link: 'https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/includes/ssazuremi_md.md'.
Line 282, Column 136: [Error: include-not-found] Invalid include link: 'https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/includes/ssazuremi_md.md'.
Line 449, Column 142: [Error: include-not-found] Invalid include link: 'https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/includes/ssazuremi_md.md'.
Line 516, Column 150: [Error: include-not-found] Invalid include link: 'https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/includes/ssazuremi_md.md'.
Line 528, Column 150: [Error: include-not-found] Invalid include link: 'https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/includes/ssazuremi_md.md'.
Line 560, Column 150: [Error: include-not-found] Invalid include link: 'https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/includes/ssazuremi_md.md'.
Line 601, Column 81: [Error: include-not-found] Invalid include link: 'https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/includes/ssazuremi_md.md'.
Line 616, Column 107: [Error: include-not-found] Invalid include link: 'https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/includes/ssazuremi_md.md'.
Line 666, Column 69: [Error: include-not-found] Invalid include link: 'https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/includes/ssazuremi_md.md'.
Line 832, Column 150: [Error: include-not-found] Invalid include link: 'https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/includes/ssazuremi_md.md'.
Line 884, Column 150: [Error: include-not-found] Invalid include link: 'https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/includes/ssazuremi_md.md'.
Line 943, Column 105: [Error: include-not-found] Invalid include link: 'https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/includes/ssazuremi_md.md'.
Line 1244, Column 150: [Error: include-not-found] Invalid include link: 'https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/includes/ssazuremi_md.md'.
Line 1297, Column 150: [Error: include-not-found] Invalid include link: 'https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/includes/ssazuremi_md.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@ingebeumer - you can't use github links for the INCLUDES ... they have to be the live links ..
@rwestMSFT - Can you review this PR?
This will need to be moved or resubmitted via the private repo so we can view the staged content before merging.
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

These MI changes must be done in a private PR. Please close this and open a new PR in sql-docs-pr.


Link to license in documentation leads to a 404

At the bottom of https://feathers-vuex.feathers-plus.com/api-overview.html#global-configuration the link to the license leads to https://feathers-vuex.feathers-plus.com/LICENSE/. This URL displays a 404 error.

Thanks for noticing this.  I'll get to it soon.


New feature: /save and /load saves and restores the edited-files list

Frequently used feature: store and load the list of editable and read-only workspace file names.

@paul-gauthier may I ask for an indication -- can this be merged, or should I drop it?

Thanks for your interest in aider and for taking the time to work on this PR. Unfortunately, I don't think I'll be able to merge this it. I like the concept and I know other users are interested in something like this. But the UX and implementation details in this PR probably aren't appropriate to merge.

I appreciate the time you took to look at it.
Being a recent pro dev on a large legacy project, I also appreciate that my implementation may be not suitable for this particular code base.
Still, you did not say to "just drop it" -- may I ask for a word of a guidance, what can I improve about it, to make it compatible with your code, please?

I also think this would be useful.  How about if we narrowed the scope to simplify the UX?  I think we get 90% of the benefit with 10% of the complexity.

Modify the no-argument drop to save the state in memory before clearing the active state
Add a new command (undrop?) to load the most recently dropped context

This addresses the most common use case (I have a complex context but I need to narrow it temporarily so I don't confuse the LLM for a surgical edit, before continuing with the bigger project) without adding complexity around marshaling to files etc.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

What about something like /session mysession command? Aider would remember open files in the current session. You can return to your previous session (would solve the save/load request) and you could also switch between the sessions when working with aider `/session myothersession" (which would solve @jbellis's use case).

I also think this would be useful. How about if we narrowed the scope to simplify the UX? I think we get 90% of the benefit with 10% of the complexity.
1. Modify the no-argument `drop` to save the state in memory before clearing the active state

Sorry mate, but it seems to me that overloading an existing clear-purpose command with more functionality would only worse the learning curve
and what if one wanted to drop one file but accidentally did not specify a file? I know I would be annoyed by the undesired behaviour
@wladimiiir I take your point of naming the save-point,
but regarding /session {name}  there still would be a need to know if it means "please load" or "please save" or "please clear"
at this time, load/save/drop has the simplest functionality and UX, in my humble opinion

and what if one wanted to drop one file but accidentally did not specify a file

then you undrop, and then re-drop the one you intended
(actually I would recommend using a bare add to instead of adding undrop which is nicely symmetrical)

My idea is just this simple:
/session {name}

in case session {name} does not exist, create a new session and set it as the active one
in case the session {name} exists, load the stored files and set the session as the active one

While in active session /read-only, /add, /drop will automatically update the active session files, you don't need to save them manually.

Good thinking, I like the session proposal.

I just pushed code that implements /save and /load a bit differently:
/save <fname> will save all the added and read-only files into a text file, like this:
/load some/file.py
/load second/file.py
/read-only another/file.py

/load <fname> will load an execute any slash-commands from a file. In particular, it can run the commands from a /save file to recreate the active context. But if you make a file with other /commands, it can execute those too. Probably will fail to work with some commands.

You could put /drop at the top of the bar file?

If I have to manually edit files then I submit that the UI has failed to do its job.

(And the next time I modify the file set I have to manually edit it again after /save.)

Given that the original author has implemented a functionality very similar to what I have tried to do,  I think that this PR can be closed.
not least because it would cause serious conflicts in the UI
@paul-gauthier thank you!


[DO NOT REVIEW][epskc] prototype of publishing _meshcop-e._udp

See https://github.com/openthread/ot-commissioner/pull/261 for commissioner side changes

Superseded by https://github.com/openthread/ot-br-posix/pull/2259


Warn user to use tree_method='gpu_hist' with GPU DataFrames

Hi, I was wondering if there is any interest in adding a warning for users who are working with GPU DataFrames (i.e., cuDF) but haven't specified tree_method='gpu_hist' (and thus end up training the model on CPUs)?
cc @ayushdg

Hi, thank you for raising the issue.
I'm not sure whether that's necessary. It's a legitimate use case to have input device different from xgboost device. I don't have a strong preference for this.

Okay, just wanted to ask. Thanks!


Introduce AbsoluteMininputCount coordinator config

I believe that this should be the last coordinator config.
We need to also have Name and ReadMoreURI but..... Those are not configs, there are coordinators properties, that we should probably store somewhere else.
These coordinator configs are also slightly annoying because most are network-agnostic, except the endpoint. I think it is ok, but it would probably be better to completely separate

I am merging this because we discussed and approved the concept + this PR is easy + I already made 2 of the kind + I need this for 2 other PRs


Add STOP instruction to terminate payload execution

Closes https://github.com/antmicro/litex-rowhammer-tester/issues/32.
This PR makes NOOP with timeslice=0 be interpreted as STOP. Execution of STOP takes 1 cycle and terminates execution of payload. Timeslice is now interpreted as the exact number of cycles of instruction execution. It is invalid to use DFI instructions with timeslice=0. Generation of row-hammer payload has been updated to use the new timeslice interpretation and add STOP instruction.
If the Encoder class is used to define the payload, it will prevent such errors. It however does not perform full payload verification and it would be good to run the actual payload verifier before payload is transferred. The payload verifier would now need to use the new timeslice interpretation and support STOP.
We can merge it if it looks ok to you @sqazi.

I agree that the payload verifier should be used and needs to be modified to support the STOP instruction.  But, not all payloads are expected to pass verification (we will intentionally violate the protocol to gather information).  So verifier enable would have to be a user-specified flag.  That is outside the scope of the current change.
The current change looks fine to me.

I agree that the payload verifier should be used and needs to be modified to support the STOP instruction.  But, not all payloads are expected to pass verification (we will intentionally violate the protocol to gather information).  So verifier enable would have to be a user-specified flag.  That is outside the scope of the current change.
The current change looks fine to me.


[WIP] dns: add support for clusters based on SRV DNS record

One more attempt to address #125 (resolve cluster IPs via SRV-record)
Yet on early stage. Tested with Consul and the collowing configuration:
  clusters:
  - name: local-php
    connect_timeout: 0.25s
    lb_policy: round_robin
    # http2_protocol_options: {}
    cluster_type:
      name: envoy.clusters.dns_srv
      typed_config:
        "@type": "type.googleapis.com/envoy.extensions.clusters.dns_srv.v3.DnsSrvClusterConfig"
        srv_names:
          - srv_name: _local-php._tcp.service.consul.
    dns_resolvers:
    typed_dns_resolver_config:
      name: envoy.network.dns_resolver.cares
      typed_config:
        "@type": type.googleapis.com/envoy.extensions.network.dns_resolver.cares.v3.CaresDnsResolverConfig
        resolvers:
          - socket_address:
              address: <IP_ADDRESS>
              port_value: 8600

Based on discussion and design doc by @kylebevans in https://github.com/envoyproxy/envoy/issues/125#issuecomment-761908695

Testing locally with Consul:
run consul:
consul agent -server -advertise=<IP_ADDRESS> -data-dir=consul-data -ui -bootstrap-expect=1 -dev -log-level=debug

Add service nodes:
consul services register -name=local-php -id=web-1 -address=<IP_ADDRESS> -port=80 -tag=v1 -tag=prod
consul services register -name=local-php -id=web-2 -address=<IP_ADDRESS> -port=81 -tag=v1 -tag=prod

Verify that the service local-php can be resolved via Consul:
dig @<IP_ADDRESS> -p 8600 local-php.service.consul. SRV
# or
dig @<IP_ADDRESS> -p 8600 _local-php._tcp.service.consul. SRV

main doc: https://developer.hashicorp.com/consul/docs/services/discovery/dns-static-lookups

Hi there, apologies for openning in this state - I acknowledge that there still lots.
I just needed someone to point me at what I'm missing and get feedback whether I'm going in the right direction.

Thanks for you contribution. But based on our contributing rules (see https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md), any extension, should have a maintainer sponsor to help review and maintain the code.
And I think this should be a DNS extension rather than a new cluster extension?

And I think this should be a DNS extension rather than a new cluster extension?

Based on previous discussion, it was decided to go with the cluster extension. Basically, I followed the previous proposal.
I will be happy to discuss the new design if someone helps me to find the right place. The initial issue doesn't seem to have activity :/

This isn't yet forgotten, going to ping maintainers in the maillist

I'll sponsor this extension. I'll take a closer look at the PR early next week.

Hi @ggreenway, Thank you for the response.
Just in case, I'm happy to move this extension to contrinb if someone feels it would be a better move.


More ways to deploy

I am trying to set juicy-ctf up using a local on premise ubuntu server.  Could there be some sort of instructions on how to set this up on pure ubuntu and use just one computer (virtualization or two docker instances perhaps)
This would probably need to include instructions on how to install kubernetes and helm to fit this method the best.
Also, as a possibility, if a docker image was added as a deployment method, that would be nice also. (have docker as a wrapper so that everything is contained inside)

JuicyCTF is explicitly for Kubernetes environments. For single servers where you want to launch multiple Juice Shop instances the recommendation is to launch those on different ports an assign them to training or CTF participants, e.g. with
for i in {10..19}; do docker run -d -p 40$i:3000 bkimminich/juice-shop; done

Hi @jimender2
Björn already summed it up quite nicely, just one thing.
Even thought JuicyCTF is currently only compatible with kubernetes, it should be possible to also add compatibility with other orchestrators, (docker swarm or just with raw docker containers or maybe even with native processes) as the projects really only needs the possibility to spin up new JuiceShop instances at a stable network address, so that the loadbalancer can direct traffic to the instances reliably.
This would require some work but would very much be possibly.
I don't think that i will implement this myself as I'm pretty happy with the kubernetes solution for myself and it works great for the usecases we use it @iteratec.
As to documentation on how to do set it up with kubernetes on a bare Ubuntu server I'm unfortunately not really an expert at either as I'm mostly using k8s clusters managed by cloud providers. If you could write up a guide to your experiences on how to set it up that would be really cool! Would happily merge a guide or link to one!

Closing as the question seems answered.
If you got more questions, feel free to open up another issue or pinging us in slack 👍


Bump noobaa-operator to 2.0.7

Bump noobaa-operator to 2.0.7

/ok-to-test

@nimrod-becker For some reason your PR does not update our code under vendor/github.com/noobaa/noobaa-operator that @dannyzaken 's PR did update - perhaps you are missing a step of dep-update?

@kshlm
Re-applied the noobaa affinity changes


chore(all): update jspm skeletons to Bootstrap 4.1.0

This is based on the work of @maroy1986. I haven't updated the ASP.NET skeletons as I don't have Visual Studio installed to test them.


Update search_handlers.py

Fixed import order at line 8

Haystack search did not work, because SearchHandler was imported as SearchResultsPaginationMixin, which has no super class:
Error:  object.__init__() takes exactly one argument (the instance to initialize)


copy_and_rename does copying of only files and not internal folders (no recursion)

E.g. when we copy tesseract folder with copy_and_rename, the tessdata folder is not copied.

Maybe it was planned?

probably error. copying should be recursive.

Resolved, so close it.


BlueJeans error when installing via Munki

Running a fresh Autopkg run and installing via Munki returns the following error:

Installing Blue Jeans (1 of 1)...
Preparing for installation…
Preparing the disk…
Preparing Blue Jeans…
Waiting for other installations to complete…
Configuring the installation…
26.440098 percent complete...
Writing files…
55.600702 percent complete...
Moving items into place…
Validating packages…
97.75 percent complete...
Install of Blue Jeans failed with return code 1...
ERROR: ------------------------------------------------------------------------------
ERROR: installer: Package name is Blue Jeans
ERROR: installer: Installing at base path /
ERROR: installer:PHASE:Preparing for installation…
ERROR: installer:PHASE:Preparing the disk…
ERROR: installer:PHASE:Preparing Blue Jeans…
ERROR: installer:PHASE:Waiting for other installations to complete…
ERROR: installer:PHASE:Configuring the installation…
ERROR: installer:STATUS:
ERROR: installer:%26.440098
ERROR: installer:PHASE:Writing files…
ERROR: installer:%55.600702
ERROR: installer:PHASE:Moving items into place…
ERROR: installer:PHASE:Validating packages…
ERROR: installer:%97.750000
ERROR: installer: The install failed (The Installer encountered an error that caused the installation to fail. Contact the software manufacturer for assistance.)
ERROR: ------------------------------------------------------------------------------

The applications still installs correctly in the /Applications/ folder and is usable, but Munki does not recognize it as installed and continues to try to install every time you try to install it. If it is marked as a Managed Install, Munki recognizes it as install and doesn't not try to reinstall.

Bluejeans has changed the postinstall script in the package. While I could update the recipe to replace it with a "better" one, I'm uncomfortable with doing that, as the script could be updated again in the future and the autopkg recipe might be used for days/weeks/months with a "wrong" postinstall script. I'm not sure how best to proceed here.

One of the things the postinstall script does is attempt to use the open command to open an app in the current GUI user's context...
#!/bin/bash

 #Update the application ownership to the user who initiated the install, if it's not root.
  if [ "$USER" != "root" ]; then
 	   chown -R $USER:"$(id -gn $USER)" /Applications/Blue\ Jeans.app
  fi
  cp /Applications/Blue\ Jeans.app/Contents/Resources/com.bluejeans.app.detector.plist /Library/LaunchAgents
  chmod 755 /Applications/Blue\ Jeans.app/Contents/Resources/start-carmel-detector.sh
  open -a /Applications/Blue\ Jeans.app --args init-app-detector

I have no idea what this thing is doing/is supposed to do...
% cat /Applications/Blue\ Jeans.app/Contents/Resources/start-carmel-detector.sh
#!/bin/sh
SYSTEM_APP_PATH="/Applications/Blue Jeans.app/Contents/MacOS/BlueJeans"
USER_APP_PATH="$HOME/Applications/Blue Jeans.app/Contents/MacOS/BlueJeans"
APP_DETECTOR_PATH="$HOME/Library/Application Support/Blue Jeans/desktop/carmel-detector/main.js"

if [ -f "$SYSTEM_APP_PATH" ]; then
	APP_PATH="$SYSTEM_APP_PATH"
elif [ -f "$USER_APP_PATH" ]; then
	APP_PATH="$USER_APP_PATH"
fi

if [ -f "$APP_DETECTOR_PATH" ]; then
	"$APP_PATH" "$APP_DETECTOR_PATH"
else
	"$APP_PATH" "init-app-detector"

% cat /Library/LaunchAgents/com.bluejeans.app.detector.plist
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
    <dict>
        <key>Label</key>
        <string>com.bluejeans.app.detector</string>
        <key>Program</key>
        <string>/Applications/Blue Jeans.app/Contents/Resources/start-carmel-detector.sh</string>
        <key>RunAtLoad</key>
        <true/>
    </dict>
</plist>

The LaunchAgent it copies into place seems to start the same process as did the postinstall script; so it appears the postinstall script attempts to start it during the current login session, and the LaunchAgent does it for subsequent logins.

Fixing this mess is possible, but I suspect the a future release of the BluejeansApp pkg will change things again.

This commit https://github.com/autopkg/gregneagle-recipes/commit/6ff8ffd77307cf3f39200bf23fe0f2aaba11f4bd addresses the issue in my testing, but I think it likely to break again in the future (possibly without us noticing for a while).


🚀 Feature Request: Convert D1's ink table usage to logger.table

Describe the solution
.

This was done in #7065


fix bug: allow specify cpu/memory resource requests separately

fixes: #12249

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hzxuzhonghu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: gyliu513
If they are not already assigned, you can assign the PR to them by writing /assign @gyliu513 in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
400b0aa6c937246560200279a43905cb81dd10b9
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
400b0aa6c937246560200279a43905cb81dd10b9
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
400b0aa6c937246560200279a43905cb81dd10b9
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
400b0aa6c937246560200279a43905cb81dd10b9
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
400b0aa6c937246560200279a43905cb81dd10b9
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
400b0aa6c937246560200279a43905cb81dd10b9
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
400b0aa6c937246560200279a43905cb81dd10b9
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
400b0aa6c937246560200279a43905cb81dd10b9
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
400b0aa6c937246560200279a43905cb81dd10b9
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
400b0aa6c937246560200279a43905cb81dd10b9
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu, ymesika
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [ymesika]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@duderino

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
400b0aa6c937246560200279a43905cb81dd10b9
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
400b0aa6c937246560200279a43905cb81dd10b9
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
400b0aa6c937246560200279a43905cb81dd10b9
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
23ecfd0b0149c65bd8427cd8e6f7b574b86b5902
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
400b0aa6c937246560200279a43905cb81dd10b9
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
23ecfd0b0149c65bd8427cd8e6f7b574b86b5902
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
23ecfd0b0149c65bd8427cd8e6f7b574b86b5902
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
23ecfd0b0149c65bd8427cd8e6f7b574b86b5902
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
23ecfd0b0149c65bd8427cd8e6f7b574b86b5902
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
23ecfd0b0149c65bd8427cd8e6f7b574b86b5902
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio_auth_sds_e2e

ping @duderino this is a bug absolutely

@linsun @geeknoid @wenchenglu @utka
Greetings fellow admins.  @rshriram couldn't get in touch with me (my fault) so he made a call and merged this.   I think he made the right call so giving it a post-merge /lgtm.