error CS1503: Argument 2: cannot convert from 'method group' to 'EventCallback'

Description:
When using EventCallBack<T>, I countered an issue about error CS1503: Argument 2: cannot convert from 'method group' to 'EventCallback'
I have checked other github blogs which related to this, mostly reported that, this has been fixed in preview 7 version. Right now, i have tested with preview 7 build but could not get resolve it.
Here the link which i checked earlier.
https://github.com/aspnet/AspNetCore/issues/10077
https://github.com/aspnet/AspNetCore/issues/8385
https://github.com/aspnet/AspNetCore/pull/10730
https://github.com/aspnet/AspNetCore/issues/10077
Whether any syntax changes required to resolve in preview 7 version?
Screenshot:

Please find my component structure:
Rendering Page [Index razor page]

      @page "/"
      @using GenericEvent.Shared.Models;
      @inject IJSRuntime jsruntime;

    <MyGenComponent Data="@MyData">
        <Events>
        <NonGenericEvents EventTwo="@Event2"></NonGenericEvents>
        <GenericEvents EventOne="@EventOne"></GenericEvents>
         </Events>

    </MyGenComponent>

    @functions {
        public List<string> MyData = new List<string>() { "a", "b", "c", "d" };

        public void Event2(EventArguments args)
       {

       }

       public async Task EventOne(EventArgsData<string> data)
       {
        //dummy call
        await jsruntime.InvokeAsync<string>("call");
       }
      }

MyGenComponent.razor

    @using GenericEvent.Shared.Models;

    @typeparam T;

            @ChildContent

    @functions {
    [Parameter]
    protected RenderFragment ChildContent { get; set; }

    [Parameter]
    public IEnumerable<T> Data { get; set; }
    }

Events.razor

      @using Microsoft.AspNetCore.Components;

      @inherits ComponentBase

     <CascadingValue Value="@this">
        @ChildContent
    </CascadingValue>

     @functions{

    [Parameter]
    protected RenderFragment ChildContent { get; set; }

    public GenericEvents<object> GenEvents { get; set; }

    public NonGenericEvents NonGenEvents { get; set; }

     }

GenericEvents.razor

      @using Microsoft.AspNetCore.Components;
      @using GenericEvent.Shared.Models;

       @typeparam TValue

      <CascadingValue Value="@this">

     </CascadingValue>

     @functions{

     [Parameter]
    public EventCallback<EventArgsData<TValue>> EventOne { get; set; }

    }

NonGenericEvents.razor
   @using Microsoft.AspNetCore.Components;
    @using GenericEvent.Shared.Models;

   <CascadingValue Value="@this">

   </CascadingValue>

   @functions{

     [Parameter]
     public EventCallback<EventArguments> EventTwo { get; set; }

     }

To Reproduce
Clone this Github repository and run the application
https://github.com/gurunathancs1991/BlazorGenericEvents
We are also expecting the solution for this thread too
https://github.com/aspnet/AspNetCore/issues/12116
Additional context

C:\Users\GurunathanA>dotnet --info
.NET Core SDK (reflecting any global.json):
 Version:   3.0.100-preview7-012814
 Commit:    efad165932

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.17763
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\3.0.100-preview7-012814\

Host (useful for support):
  Version: 3.0.0-preview7-27912-14
  Commit:  4da6ee6450

.NET Core SDKs installed:
  1.1.13 [C:\Program Files\dotnet\sdk]
  1.1.14 [C:\Program Files\dotnet\sdk]
  2.1.202 [C:\Program Files\dotnet\sdk]
  2.1.502 [C:\Program Files\dotnet\sdk]
  2.1.602 [C:\Program Files\dotnet\sdk]
  2.1.700 [C:\Program Files\dotnet\sdk]
  2.2.202 [C:\Program Files\dotnet\sdk]
  2.2.300 [C:\Program Files\dotnet\sdk]
  3.0.100-preview7-012814 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.0.0-preview4-19216-03 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.0.0-preview7.19363.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 1.0.15 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.0.16 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.1.12 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.1.13 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.0.0-preview4-27615-11 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.0.0-preview7-27912-14 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.0.0-preview7-27912-14 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

A workaround (maybe even the correct way):
<GenericEvents TValue="string" EventOne="@EventOne"></GenericEvents>

I agree that this still seems like an issue as creating verbose markup when handling events (without databinding).
Take the InputSelect for example. ValueChanged either requires T to be defined or a lambda expression within ValueChanged. Compounding the problem is ValueExpression which is also required, this is leading to some very clumsy looking markup @(()=>. This isn't going to be the DX people expect when coming from jQuery, WebForms or even React.

Current value: @form.MyProperty

<EditForm Model="form">
    <InputSelect ValueChanged="@DoThing"
                 T="string"
                 ValueExpression="@(()=> form.MyProperty)">
        <option value="0">0</option>
        <option value="100">100</option>
        <option value="200">200</option>
        <option value="300">300</option>
    </InputSelect>
</EditForm>

@code {
    MyForm form = new MyForm();

    void DoThing(string s)
    {
        form.MyProperty = s;
    }

    public class MyForm
    {
        public string MyProperty { get; set; }
    }
}

   <InputSelect ValueChanged="@((string s) => DoThing(s))"
                 ValueExpression="@(()=> form.MyProperty)">
        <option value="0">0</option>
        <option value="100">100</option>
        <option value="200">200</option>
        <option value="300">300</option>
    </InputSelect>

From what I can tell, the problem is that the compiler does not use the the generic type parameter for type inference in method calls. Here's a fairly trivial example:

public void Foo()
{
    Tester<int>(2, TestAction);
    // This fails complaining about type inference
    Tester<int>(2, CreateDelegate(TestAction));
}

public void TestAction(int x) { }

public void Tester<T>(T value, Action<T> input) { }

public static Action<T> CreateDelegate<T>(Action<T> action) => action;

We effectively get the same code when we code-gen a Razor file like this:
<InputSelect ValueChanged="ChangedInt" />

@code {
    public void ChangedInt(int value)
    {
    }
}

using Microsoft.AspNetCore.Components;

namespace razor1.Pages
{
    public class Index : Microsoft.AspNetCore.Components.ComponentBase
    {
        protected override void BuildRenderTree(Microsoft.AspNetCore.Components.RenderTree.RenderTreeBuilder builder)
        {
            __Blazor.razor1.Pages.Index.TypeInference.CreateInputSelect_0(builder, 0, 1, Microsoft.AspNetCore.Components.EventCallback.Factory.Create(this,
                           ChangedInt
            ));
        }

        public void ChangedInt(int value)
        {
        }
    }
}
namespace __Blazor.razor1.Pages.Index
{
    internal static class TypeInference
    {
        public static void CreateInputSelect_0<T>(global::Microsoft.AspNetCore.Components.RenderTree.RenderTreeBuilder builder, int seq, int __seq0, global::Microsoft.AspNetCore.Components.EventCallback<T> __arg0)
        {
            builder.OpenComponent<global::Microsoft.AspNetCore.Components.Forms.InputSelect<T>>(seq);
            builder.AddAttribute(__seq0, "ValueChanged", __arg0);
            builder.CloseComponent();
        }
    }
}

The compiler fails the type inferrence, picks the wrong overload for EventCallback.Factory.Create and generates the method group conversion error reported here.
From playing around, one of the ways to solve this would be to modify the code in TypeInference to pass the Action<T> in and produce the EventCallback<T> in there. This works well, but we now have the pain of having to code-gen an overload per overload of EventCallback.Factory.Create<T>. Changing the code-gen is going to be fairly involved, so I'm sending it back to triage to consider for a later release.

Workarounds that have been pointed out by others in the thread that work:

Specify the type parameter

<InputSelect T="int" ValueChanged="ChangedInt" />

(I filed an issue to do a pass over blazor input elements to consider renaming T to TValue or something slightly better)

Use a delegate or perform an explicit cast

<InputSelect ValueChanged="(int x) => ChangedInt(x)" />

<InputSelect ValueChanged="(Action<int>)ChangedInt" />

Thanks for contacting us, @gurunathancs1991.
As @pranavkm has pointed out, you will have to go with one of the provided workarounds here.
Type inference will always have limitations and it's unfortunate that this is one of them.

EdCharbeneau commented on 23 Jul wrote: but this solution is not working with
ASP.NET Core and Blazor updates in .NET Core 3.0 Preview 9.19424.4
Current value: @form.MyProperty

0
100
200
300

@code {
MyForm form = new MyForm();
void DoThing(string s)
{
    form.MyProperty = s;
}

public class MyForm
{
    public string MyProperty { get; set; }
}

}

0
100
200
300

Sorry my mistake:
EdCharbeneau was OK: the solution works very well


BMP180 pressure and temp sensor support.

Hi,
I needed support for BMP180 and I needed to lear Rust. Here is result :)
Tested on my real BMP180 against other library (same results) and test scenario based on BMP180 documentation.

I'm afraid you missed #27. But shouldn't be much of a problem.

Yes, definitely I missed that one :) Single file so yes - no problem to extract that to separate crate.

Awesome, thanks for the contribution.  Been busy lately, but hoping to get back to being a better maintainer here or adding other maintainers that will be able to drive things more actively.

Did you ever extract this to its own crate? I'm interested in using it :D.

As I wrote in #27, I've started working on it.
What needs to be done:

[ ] Decide where to put the sensor traits (Thermometer, Accelerometer...)
[ ] Create and publish the crate for the traits
[ ] Who should be the owner (of crates, repo)?
[ ] Licenses
[ ] Fill info into Cargo.toml for each sensor and publish them.
[ ] Merge #28

Closing this as we are moving away from adding additional sensors/traits to this crate in favor of building those on top of embedded-hal traits.


Fluo needs operation to get a list of spans

Fluo transactions needs an operation to fetch a set of spans like :
interface Snapshot {
  Map<Bytes, Map<Column, Value>> get(Collection<Span>);
}

This is needed because there currently is no low level operation to get different columns from many rows.  There is only an operation to get the same columns from many row.

I ended up adding a more specific method that used RowColumn instead of Span.  My rational is that RowColumn implies that the return value needs to fit into memory.
interface Snapshot {
  Map<Bytes, Map<Column, Value>> get(Collection<RowColumn>);
}


Can you bypass Snow 2? 🎉

This isn't really an issue, more of an invite to hack Snow again!

Snow 2 ❄

Snow 2 has been just released!

Full list of PRs and features introduced since last version (1.5.0) can be found at #76

Most important change to Snow was recognizing this task isn't doable without some CSP help

Which is why from this version forward Snow requires:

unsafe-inline to be forbidden
object-src to not allow same origin srcs

In order to introduce a higher level of security

Therefore, the demo app you know and love now enforces script-src 'self'; object-src 'none';

Your time is precious being highly talented figures, so I'd understand if you can't - but I invite you to give bypassing Snow another crack, with the hope that v2 is better secured.
Tagging former Snow security contributors @mmndaniel @arxenix @NDevTK @magicmac @rwaldron @benjamingr @naugtur   @mhofman (thank you for your help so far ❤ sorry if I forgot anyone)
Clarifications

Snow 2 solves all former issues (hopefully) which is why almost all of them are marked as "closed"
One issue that isn't fully addressed yet is #73 by @magicmac which is inertially more complicated and is being thought of @ #122

moved to #130

The demo page is broken


Update python-package.yml

This commit tries to use linux-20.04 for Python 3.6.8.

Sorry, @beauremus. I thought I was modifying the original pull-request but it opened a new one. I didn't want to lose the changes, so I went ahead and made the new request.

And now I see that we don't have a runner for this so it'll never work. I'll just cancel this request.


Test using default hub and tag

What this PR does / why we need it:
To be able to test with default settings in istioctl
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

@chxchx: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign @yutongz @sebastienvas

PTAL


deployonSave deploys to all targets

Hi,
When i hit ctrl+s my file is deployed to all targets, even though I have specified a target under my packages
Here is my config:
{
    "deploy": {
        "packages": [
            {
                "name": "my_app",
                "description": "my_app",
                "deployOnSave": true,
                "files": [
                ],
                "exclude": [
                    "**/.git/**"
                ],
                "targets": [
                    "server01"
                ]

            }
        ],
        "targets": [
            {
                "type": "sftp",
                "name": "server01",
                "description": "upload to server01",
                "dir": "/var/my_app",
                "host": "server01", "port": 22,
                "user": "root", "password": "password"
            },
            {
                "type": "sftp",
                "name": "server02",
                "description": "upload to server02",
                "dir": "/var/my_app",
                "host": "server02", "port": 22,
                "user": "root", "password": "password"
            }
        ]
    }
}

The expected behavior is that deployOnSave only would deploy to server01, but here is the output for a ctrl+s with the above configuration:
Deploying file 'c:/work/my_app/app.jar' to '/var/my_app' ('server01')...
Deploying file 'c:/work/my_app/app.jar' to '/var/my_app' ('server02')...
[OK]
Finished.
[OK]
Finished.

It works correct, but this has "historical" reasons.
The targets property in a package entry was added AFTER the deploy on save feature has been implemented.
I added a new global setting called useTargetListForDeployOnSave since version 4.2.0 that works as you except this:
{
    "deploy": {
        "useTargetListForDeployOnSave": true
    }
}

If you do not want to set the property, you have to copy the value of targetsproperty to deployOnSave:
{
    "deploy": {
        "deployOnSave": [ "server01" ]
    }
}

The problem is that the original meaning of the targets property is, that you do not need to select a target in the GUI after you selected the package.
With the useTargetListForDeployOnSave property, you can extend this behavior now.

BTW: You can also define this setting for single packages since version 4.4.0 now (this would overwrite the global setting):
{
    "deploy": {
        "packages": [
            {
                "name": "my_app",
                "description": "my_app",

                "deployOnSave": true,
                "targets": [ "server01" ],

                "useTargetListForDeployOnSave": true,

                // ...
            }
        ],

        // ...
    }
}


Side By Side + High Quality breaks Overlay

Setting an Overlay to be side by side (parallel or crossed) and also setting it to be high quality breaks the overlay and the whole application really, is this expected?

Pretty sure this has been fixed. If not please create a new issue with repro steps and ideally an example project. Thanks!


Update Download table heading

PR for #8479

Before:

After:

Downloads column shifts to the left.
Should I make sure that it does not shift?

@clairernovotny Could you take a look at the proposed changes in the screenshot above? Thanks!

Used table-layout: fixed to make the shift better.
Initial:

After:

Sorry, seems that I haven't completely followed your contributing guidelines.


feat: Add support for --dump-inputs

Fixes #684
This PR adds support for the CLI flag --dump-inputs which prints out input sources without collecting and checking links.

I added tests in ac3fa41. I think this PR is now good to go!

Great! I made a minor change to run the integration tests from a newly-created fixtures/dump_input subfolder. The reason being, that it's easier to keep the test fixtures isolated this way. Otherwise, we'd have to update the dump_input tests if we moved files around for other tests.
Hope that's fine. Looks good to me now. 😃

Yes, that's fine! Makes total sense to move these test files into their own folder for the obvious reasons you mentioned :smile: Thank you for merging this super quickly!


Non uniform angles

Allow non-uniform projection parameters for sensors like HDL-64

Coverage decreased (-0.3%) to 76.371% when pulling 0e55a7af63003b2dba8220cdd57208caa6156742 on non-uniform-angles into 5e4d5622c09dd461373f98e87f87b1f0cd26c885 on master.

Coverage decreased (-0.5%) to 76.683% when pulling 745561dcab124b19c58eb58872f1ec57a6f62a05 on non-uniform-angles into 1e42947188f1692dd8a811f99f6db4b388952c64 on master.

Coverage increased (+0.7%) to 77.883% when pulling ad250002c2c4c809cae326f67acd581dc0a5c8a3 on non-uniform-angles into 1e42947188f1692dd8a811f99f6db4b388952c64 on master.


unable to achive 91.82 in ner

Thanks for the code, but i am unable to achieve F1 91.82 in ner by using the same config given in repo. Any help?

@omerarshad
Hi friend~I also can not achieve the result 91.82.
And I quite doubt that the hyperparameters used in this project are quite different from that used in Ma's paper (End-to-end Sequence Labeling via Bi-directional LSTM-CNNs-CRF).  The dimensions of the hyperparameters are much larger.
So, I doubt that is this comparable to Ma's model ?
btw, could you share with me what F1 score you achieve ?
Thx~

I was able to achieve 91.05 after lot of hyper parameter tuning using Glove embeddings.

cool !
Could you tell me some key parameters ?
I was suffering from tuning parameters for a long time, and haven't got an idea result...

what's your best score achieved?

Sorry guys, I already changed the error information in README.md, since I was wrongly use the CoNLLeval.py function.

What did you changed? Do we need to pull your code again?


dynamic radius

Would be great if it was possible to define the radius in realtime and in meters. This would allow for a user to be able to customize what hi (she) is seeing and how fine tuned.
What are your thoughts on this?

If you can implement this efficiently then yep sure :)
I think prunecluster has this, so maybe check that out as an alternative?
https://github.com/SINTEF-9012/PruneCluster

Sorry but I know nothing regarding clustering, that is why my issue is phrased as a question/request.
Could it be possible to have a zoom / radius relational table? Then if we could get a function to convert meters to pixel, we could do something similar.

Hi @lpinto-eu,

a function to convert meters to pixel

You should be able to do this using Leaflet map conversion methods, probably a combination of distance and latLngToContainerPoint, having to make up 2 LatLng's (on same latitude) until you get your desired distance in meters.
This highlights BTW that a meters specification for clustering radius would be somehow very strange. E.g. near the poles, 1 meter may take a lot of pixels, whereas on the equator, for the same zoom level, 1 pixel can represent a few hundreds meters.
As for dynamically changing the clustering radius, it seems to me that a very easy way to achieve a similar result, the "brute" way, would be to create a new MCG whenever a different radius is desired. Add first the new one to the map, so that the clustering computation is performed, then remove the old one.


Public demo navigation has different layout than local npm demo.

Please forgive me if I'm missing a setting, configuration parameter or missing something else more obvious, but why does your public SC5 demo have a left vertical sidebar layout and then the demo for users that run locally have a top horizontal layout? I'm guessing everything configurable completely, but in a way it's kind of weird to see your demo and then get a slightly different demo after running. Personally, I think your public demo is much cleaner with the left vertical sidebar navigation and was hoping to see a clone of this after my first run.  Now I'm suspecting I have to do extra templating and layout to get to where I expected to be based on your public demo. Not hard, but different than what I had expected as the initial output. Screen shots are attached to make it clear what i'm referring to.
Thanks for your time and patience! Again, I'm sorry if this is obvious but I thought it was important enough to bring up as an issue.
PUBLIC DEMO:

LOCAL NPM DEMO:

The public demo is based on 0.3.6 (yes, it needs to be updated) and the horizontal menu was introduced in 0.3.9. Some huge style guides had performance problems since rendering the whole main section was enforced. With the horizontal navigation you can navigate directly to desired sub-section. We also wanted to give more horizontal space for the actual content. It's true that horizontal menu does not work well if you have many main section.
In the ideal use-case this should be configurable or customisable.

+1
I agree, making this a configurable option is very desirable.  I'm unsure how much of a design/implementation impact it is, but you could solve the issue for the left-menu by introducing flyouts on hover similarly to what is done with the horizontal menu.

+1
I would love to be able to have an option to use the left menu vertical navigation. To me it was part of my decision making process when searching what living style-guide to use. Granted it wasn't the #1 decision, but it was a part of the process to use your really awesome product. Really the amount of work you have done, the quality of the product and the way you are so responsive is worth of donations! Of which I'd be happy to contribute. If may have your pay pal or method of donation, I will contribute. A sincere thank you for what you are doing.

Public demo is now updated to 0.3.13. I updated the title of this issue.

+1 For vertical Styleguide navigation

https://www.google.com/design/spec/ (Vertical)
http://primercss.io/scaffolding/ (Vertical)
http://www.getmdl.io/ (Horizontal)
http://bootstrapdocs.com/v3.3.5/docs/css/ (Mixed)
https://material.angularjs.org/latest/ (Vertical)

It would be great to have a vertical nav. Hope you can create this new feature.

Since vertical nav feature has been reintroduced in 0.3.46 with configureable option, I'm closing this issue.


statics: Remove unneeded (and kinda odd) static str's

These make non-static str database names ackward to use

congrats!
66Origin doesn't seem interested in maintaining Sofa, so you get my PR's ;-)
Had a quick discussion in rust channels about this.. these static str's are really weird, and add a ton of un-needed complexity around non static (aka non- "databasename") values.
Here's an example common error:
error[E0759]: cannot infer an appropriate lifetime
--> src/deploymentdb/mod.rs:5:19
|
5 | pub async fn open(name: &str)
|                   ^^^^  ---- this data with an anonymous lifetime `'_`...
|                   |
|                   ...is captured here...
...
8 |     client.db(name.clone()).await
|               ------------ ...and is required to live as long as `'static` here

    Finished test [unoptimized + debuginfo] target(s) in 6.97s
     Running target/debug/deps/sofa-9dc88c2fa70911b4

running 13 tests
test sofa_tests::a_sys::a_should_check_couchdbs_status ... ok
test sofa_tests::a_sys::b_should_create_sofa_test_db ... ok
test sofa_tests::a_sys::c_should_create_a_document ... ok
test sofa_tests::a_sys::d_should_destroy_the_db ... ok
test sofa_tests::b_db::a_should_update_a_document ... ok
test sofa_tests::b_db::b_should_remove_a_document ... ok
test sofa_tests::b_db::c_should_get_a_single_document ... ok
test sofa_tests::b_db::d_should_create_index_in_db ... ok
test sofa_tests::b_db::e_should_list_indexes_in_db ... ok
test sofa_tests::b_db::f_should_ensure_index_in_db ... ok
test sofa_tests::b_db::g_should_find_documents_in_db ... ok
test sofa_tests::b_db::h_should_bulk_get_a_document ... ok
test sofa_tests::b_db::i_should_bulk_get_invalid_documents ... ok

test result: ok. 13 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

   Doc-tests sofa

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

Sorry this took a while, but I agree that these are a bit awkward. Let me merge this request.


DrawerGroup in combination with react-navigation is broken

UI-Kitten v5
Consider the below:
import React, { useState } from 'react'
import { Drawer, DrawerItem, DrawerGroup, IndexPath } from '@ui-kitten/components'

export const DrawerContent = ({ navigation, state }) => {
  const [selectedIndex, setSelectedIndex] = useState(0)
  return (
    <Drawer
      selectedIndex={selectedIndex}
      onSelect={index => {
        setSelectedIndex(index)
        navigation.navigate(state.routeNames[index.row])
      }}>
      <DrawerItem title='Home' />
      <DrawerItem title='View recent locations' />
      <DrawerItem title='Symptoms Checker' />
      <DrawerItem title='News' />
      <DrawerItem title='Statistics' />

      <DrawerGroup title='Data'>
        <DrawerItem title='Import' />
        <DrawerItem title='Export' />
      </DrawerGroup>

      <DrawerGroup title='Legal'>
        <DrawerItem title='Privacy' />
        <DrawerItem title='Licenses' />
        <DrawerItem title='Acknowledgements' />
      </DrawerGroup>
    </Drawer>
  )
}

If I click on Import it gives the following for index:
{ row: 0, section: 5 }

However, as per the docs and logic, you need to pass an index to react-navigation
navigation.navigate(state.routeNames[index.row])

Hence, in this case, it will pass 0 when as far as react-navigation is concerned the screen I have chosen has an index of 5
This also means that the DrawerItem highlight is also broken.
Expected behavior
DrawerGroup index.row should not be relative OR give a third parameter as the actual index that react-navigation needs
  System:
    OS: macOS 10.15.4
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Binaries:
    Node: 12.13.1 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.4 - /usr/local/bin/npm
  SDKs:
    iOS SDK:
      Platforms: iOS 13.4, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK:
      API Levels: 23, 28
      Build Tools: 28.0.3, 29.0.1, 29.0.3
      System Images: android-23 | Google APIs Intel x86 Atom, android-26 | Google APIs Intel x86 Atom, android-27 | Google Play Intel x86 Atom, android-28 | Intel x86 Atom_64, android-28 | Google Play Intel x86 Atom, android-29 | Google APIs Intel x86 Atom
  IDEs:
    Android Studio: 3.6 AI-192.7<IP_ADDRESS>41897
    Xcode: 11.4/11E146 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.13.1 => 16.13.1
    react-native: 0.62.2 => 0.62.2
  npmGlobalPackages:
    react-native-cli: 2.0.1

@pitops
You have:
Section 0: Home
Section 1: View recent locations
...
Section 5: Data

However, as per the docs and logic, you need to pass an index

The routeNames is a 1-dim array, and the configuration of the drawer you've built assumes usage of 2-dim arrays (array of sections, where a section is an array of routes). So the output you have is correct.
I would suggest mapping an existing array of routeNames to the one used in drawer component:
const routes: {
  Statistics: ['Statistics'],
  Data: ['Import', 'Export'],
};

onSelect={index => {
  const sectionRoutesKey = Object.keys(routes)[index.section];
  const sectionRoute = routes[sectionRoutesKey][index.row];
  navigation.navigate(sectionRoute);
}}

@artyorsh
Your method is feasible, but the answer you gave is wrong. It must be judged to run, and there will be performance problems during operation. This is related to the Drawer component. So you can say that this method is not feasible.

but the answer you gave is wrong

From the end of the framework:
How can the UI layer we provide can probably know about the navigation layer of your app?
The framework gives you an abstraction layer of how you can compose the views, but the business logic is always stays up to you, being dependent on how you compose the view.

but the answer you gave is wrong

From the end of the framework:
How can the UI layer we provide can probably know about the navigation layer of your app?
The framework gives you an abstraction layer of how you can compose the views, but the business logic is always stays up to you, being dependent on how you compose the view.

Yes, I think I found the reason for performance.
onSelect adds judgment to run. But "selectedIndex" doesn't know how to make it the selected state color.

@artyorsh
If selectedIndex is based on row, and let row be highlighted. So why the highlighted part is only DrawerItem outside of DrawerGroup.

@artyorsh
I solved it, although a little luck. But thank you anyway.

@mofengfs
I was testing it with a demo in a meantime https://snack.expo.io/pvRIVrzJE

@artyorsh
Oh, thank you. However, there are still some problems, such as launching the app, the first click will report an error: TypeError: Cannot read property'section' of null

@artyorsh
need your help


Matrices and Arrays

eyeM, diagM(v,k)
zerosM, onesM, randM

sizeAsArray as an input (for most of the array/matrix creators)
diagM(A,k)
moved to init function to the beginning
Fixed syntax highlighting for documentation

Move usage.jl to examples folder

Types can be given as an input argument

blkdiagM only for square matrices
zerosM, onesM, randM, eyeM (n)  gives n by n matrix

Manual blkdiagM was written with non-square support. Until BlockDiagonals adds returning Arrays and also supports non-square matrices

According to the Matlab help manual, if you really want to make eyeM compatible to MATLAB and this package really useful and reliable, you should support all of these:
I = eye
I = eye(n)
I = eye(n,m)
I = eye(sz)
I = eye(classname)
I = eye(n,classname)
I = eye(n,m,classname)
I = eye(sz,classname)
I = eye('like',p)
I = eye(n,'like',p)
I = eye(n,m,'like',p)
I = eye(sz,'like',p)

and the test cases must cover all these possible inputs. Similar to diagM, zerosM, onesM or randM.
Another challenge here is you must set up a performance benchmark to test computational performance is similar to the built-in one. Even the most inconspicuous degradation can be vital for these inner-most operations.
If these two can't be guaranteed, then I don't see the advantages brought by this package compared to reading the Julia documentation and learn how to use it.
Another very practical challenge is: if you don't find out a way to generate all these codes automatically, it would be an extremely tedious work that perhaps even you yourself might give up after several PRs.

According to the Matlab help manual, if you really want to make eyeM compatible to MATLAB and this package really useful and reliable, you should support all of these:
I = eye
I = eye(n)
I = eye(n,m)
I = eye(sz)
I = eye(classname)
I = eye(n,classname)
I = eye(n,m,classname)
I = eye(sz,classname)
I = eye('like',p)
I = eye(n,'like',p)
I = eye(n,m,'like',p)
I = eye(sz,'like',p)

and the test cases must cover all these possible inputs. Similar to diagM, zerosM, onesM or randM.
Another challenge here is you must set up a performance benchmark to test computational performance is similar to the built-in one. Even the most inconspicuous degradation can be vital for these inner-most operations.
If these two can't be guaranteed, then I don't see the advantages brought by this package compared to reading the Julia documentation and learn how to use it.
Another very practical challenge for a package maintainer is: if you don't find out a way to generate all these codes automatically, it would be an extremely tedious work that perhaps even you yourself might give up after several PRs.

I added the option for giving type as an input argument. Now I think everything is covered.

With regard to the performance, you need to add them into runtests.jl and let the CI tells us the result. These operations are really sensitive to speed; optimization without benchmark is an anti-pattern here.

I think our ideas are diverging here. Here are my thoughts:

If this package is designed to provide compatibilities for Matlab users, make it friendly (really compatible) to Matlab users. Don't surprise them with missing API unless there's a good reason.
This package itself should be a thin wrapper on existing functions. Any new features and bug fixes should go to other julia packages.

Here're some tough comments:
Regardless of the different opinions; the current codes will be really hard to maintain in the future. Although the ideas are great, I don't think this PR is worth continuing. Mostly it's because your coding experiences don't support you to maintain a package now. In the open-source world, passion is all we have, but that's far from enough.
My advice is:

pause this PR (but not close it),
really learn and use Julia in the wild for several months,
if you still think your current ideas are great, continue it in another PR (but split different functionalities into different PRs).

I see you have both strong opinion and permissions here. So I'd like to make this the last comment on this PR.


Add self-contained SafeArea to NavigationRail

The NavigationRail does not respect SafeAreas by default. This requires wrapping a SafeArea to ensure it is available, for example, when using an iPhone with a notch:
import 'package:flutter/material.dart';

void main() {
  runApp(const Material3Demo());
}

class Material3Demo extends StatelessWidget {
  const Material3Demo({Key? key}) : super(key: key);
  @override
  Widget build(BuildContext context) {
    return MainScreen();
  }
}

class MainScreen extends StatefulWidget {
  const MainScreen({Key? key}) : super(key: key);

  @override
  State<MainScreen> createState() => _MainScreenState();
}

class _MainScreenState extends State<MainScreen> {
  int _selectedIndex = 0;

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(
          title: const Text('Demo'),
        ),
        backgroundColor: Colors.amberAccent[100],
        body: SafeArea(
            bottom: false,
            top: false,
            child: Row(
              children: [NavigationRail(
                minWidth: 50,
                destinations: const <NavigationRailDestination>[
                  NavigationRailDestination(
                    icon: Icon(Icons.widgets_outlined),
                    label: Text('Demo 1'),
                  ),
                  NavigationRailDestination(
                    icon: Icon(Icons.format_paint_outlined),
                    label: Text('Demo 2'),
                  ),
                ],
                selectedIndex: _selectedIndex,
                useIndicator: true,
                onDestinationSelected: (index) {
                  setState(() {
                    _selectedIndex = index;
                  });
                },
              ),
              Expanded(child: Container(color: Colors.blueAccent[100])),
              ]
            )),
      ),
    );
  }
}

This looks somewhat as expected:

But when flipped it definitely looks off:

When consulting the guidelines for SafeArea on iOS, the margins the SafeArea is applying are correct in landscape mode:
https://github.com/flutter/flutter/issues/28956#issuecomment-472188242
But it makes me wonder if the NavigationRail should function more like the AppBar. This widget has a self-contained SafeArea, and is how

the background of the AppBar extends up through the status bar area while
the content of the AppBar is inset below the status bar.

Seen here:

And implemented here:
https://github.com/flutter/flutter/blob/9313fb8e287b63b5c3b740156cc7cf4a86f722d1/packages/flutter/lib/src/material/app_bar.dart#L1011
The Material Design spec does not provide a recommendation for NavigationRail as it relates to notches, likely because the NavigationRail is recommended for larger screens, we may want to reach out to the design team.
https://material.io/components/navigation-rail#behavior
I think the AppBar behavior that contains its own SafeArea makes sense, especially since the current NavigationRail can end up in the middle of a notch. It would be nice if we could handle this cleanly for our users, no one will ever want a rail in a cutout.
Widgets that contain their own safe area as a pattern seems to allude folks as well, I found these while looking into this:

https://stackoverflow.com/questions/67542879/flutter-safearea-avoid-notches-but-ignore-rounded-corners
https://stackoverflow.com/questions/64464468/flutter-whitespaces-displaying-for-image-in-portrait-and-landscape

Interested parties may be...
@darrenaustin
@QuncCccccc (Thanks for finding this!)
@craiglabenz

Oh sweet, sounds like the research has already been done here. This should be an easy fix.

I am going to close this to defer to #101605, @QuncCccccc I see you already assigned there, let me know if I can assist.

@Piinks Thanks a lot for all the explanation! I'll take a look for both problems.


Exclude objects from receiving auto-generated translations

Describe the bug
When working with the TranslationFile / GenerateCaptions features, AL extension adds trans-units for objects / fields with missing captions. We have lots of objects that don't require translations (temporary upgrade / buffer tables, argument tables, internal tables, ...) We'd like to be able to either tag the table / object with a new 'UseCaptions'  = No property to exclude the object from the translation updates / checks, either to have a 'ExcludeTranslations.json' file where we can list objects to be excluded.
5. Versions:

AL Language:

Wouldn't the Locked attribute do that?
value(0; "")
{
    Caption = '', Locked = true;
}

That tags the xliff translation element with the translate="no" attribute, so that it is ignored by any translation tool that you might use (we use webtranslateit and it certainly excludes all elements with that attribute).
I mean, I know that it is not exactly what you are asking for, but we use it just for that (internal tables, things that don't require captions), and it has certainly solved that need for us.

That should do it, but it looks like extremely tedious busywork/spam. :-P Excluding whole objects from translation would be far easier/tidier.

@dtkb Hehehe, totally true! I just though I should mention the Locked option because I must admit we didn't found out about it until a few months ago 😅 (when we had a similar problem).
P.S. Inspired by your comment, but totally unrelated to this ticket, I've just posted this idea: https://experience.dynamics.com/ideas/idea/?ideaid=8121da28-99a1-ea11-8b71-0003ff68c1c1


Ctrl-K in "switch workspace buffer" kills buffer under cursor

hi, i just noticed that.
reproduce:
press [SPC b b] or [SPC ,] when you have multiple buffers and then Ctrl-K -> Instead of moving up, it kills buffer under cursor.

I cannot reproduce this. Please show me your  M-x doom/info, and if your config is up somewhere I can see it, please link it.

- OS: gnu/linux (x86_64-pc-linux-gnu)
- Shell: /usr/bin/fish
- Emacs: 27.0.50 (cze 18, 2019)
- Doom: 2.0.9 (HEAD -> develop, origin/develop, origin/HEAD fbf58aac 2019-07-03 16:37:48 +0200)
- Graphic display: t (daemon: nil)
- System features: XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD PDUMPER LCMS2 GMP
- Details:
  ```elisp
  env bootstrapper: nil
  elc count: 0
  uname -a:  Linux 5.0.0-20-generic #21-Ubuntu SMP Mon Jun 24 09:32:09 UTC 2019 x86_64
  modules:   (:completion company (ivy +fuzzy) :ui doom doom-dashboard doom-quit hl-todo modeline nav-flash ophints (popup +all +defaults) tabbar treemacs vc-gutter vi-tilde-fringe window-select workspaces :editor evil file-templates fold multiple-cursors rotate-text snippets :emacs dired electric vc :term term :tools direnv editorconfig eval flycheck flyspell (lookup +docsets) magit pdf rgb tmux upload :lang common-lisp crystal data erlang elixir emacs-lisp go (haskell +intero) javascript markdown (org +attach +babel +capture +export +habit +present +protocol) php python rest ruby rust (sh +fish) web :config default)
  packages:  (rvm robe yari goto-gem projectile-rails ruby-tools auto-complete zoom graphql-mode graphql company-flx evil-anzu helm-dash zeal-at-point google-translate (evil-snipe :disable t) (solaire-mode :disable t) (forge :disable t) (evil-escape :disable t))
  exec-path: (~/.rvm/gems/ruby-2.5.3@global/bin ~/.rvm/gems/ruby-2.5.3@orms/bin ~/.rvm/rubies/ruby-2.5.3/bin/ ~/.fzf/bin ~/go/bin ~/.rvm/rubies/ruby-2.5.3/bin ~/.rvm/bin /bin ~/.fzf/bin /usr/local/sbin /usr/local/bin /usr/sbin /usr/bin /sbin /bin /usr/games /usr/local/games /snap/bin /usr/local/libexec/emacs/27.0.50/x86_64-pc-linux-gnu)

https://github.com/intpl/.doom.d

@hlissner take a look at this: https://github.com/abo-abo/swiper/commit/d52c176e3cca6a6e533e26d577b0aa9ce352d8af

do make update and you will reproduce it i believe

daa7107 should fix this. Let me know if that isn't the case and I will reopen this issue. Thanks for bringing it to my attention!

yes it's perfect, thank you!


fixing inconsistent flag naming in lncli queryRoutes

outgoing chan id flag has two different namings:

outgoing_chanid in queryroutes
outgoing_chan_id in payinvoice

This PR unifies that to outgoing_chan_id for the sake of consistency

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

@aljazceru, remember to re-request review from reviewers when ready

Replaced by/included in https://github.com/lightningnetwork/lnd/pull/7689, original commit author credits are preserved.


HPSS path is not flexible when extracting archived files

The extract command ignores the HPSS path passed to it and still looks for archived files at the HPSS path used in the create command.
I noticed this because I renamed my HPSS directory from ACME to E3SM. When extracting, it still tries to find the archive under the ACME directory.
Can we use the HPSS path supplied to the extract command instead of the original one?

@tangq This was fixed in the latest code on master. Try that and let me know if it works for you.

After talking to @tangq in person about this, this issue seems resolved. Feel free to open it if something is wrong.


CC-31 Changes for Signature Pad restructuring

https://github.com/Components-care/backlog/issues/31

Move signature pad in Non-standalone group
Move SignPadDialog to Non-Standalone group
Use Dialog from Non-Standalone group
Use Sign pad from Standalone group

@TQjona , Suggested changes done, Please review

@TQjona , Suggested changes done, Please review

@TQjona , Suggested changes done, Please review


Finalized size calculation methodology

Closes #185
In neo-go we are going to calculate the size of an object by simply counting the number of bytes.
len(Bytes)

the golang implementation of the size calculation is quite different from the corresponding C# and python. But the result should match. This approach has been validated by testing 1000 block tests cases:
block_test.go.txt

Codecov Report

Merging #215 into dev will decrease coverage by <.01%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##              dev     #215      +/-   ##
==========================================
- Coverage   52.35%   52.34%   -0.01%
==========================================
  Files          77       77
  Lines        2741     2749       +8
==========================================
+ Hits         1435     1439       +4
- Misses       1156     1160       +4
  Partials      150      150

Impacted Files
Coverage Δ

pkg/wire/payload/transaction/base.go
66.66% <0%> (-5.68%)
:arrow_down:

pkg/chain/chaindb.go
63.05% <100%> (ø)
:arrow_up:

pkg/wire/payload/block.go
92.85% <0%> (+14.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d84d44...25a9658. Read the comment docs.

Award dauTT 200 points
Award decentralisedkev 100 points for review

https://neoscan.io/transaction/81db58e8e3fcae21d4d614c008935de2fcb2d53bdf05ce5b4a40e13c3a110314


Boats render water inside of them

Boats can sometimes render water inside of them while bobbing in water.

The only fix for this would be to make it so the bottom of the boat can't dip into the water far enough for it to render inside, or somehow occlude water rendering specifically and only through the bottom part of a boat. Also, I'm fairly certain even modern does this.

Modern uses an invisible model face that occludes water rendering inside of it.


fix(@angular/ssr): handle nested redirects not explicitly defined in router config

This commit ensures proper handling of nested redirects that are implicitly structured but not explicitly defined in the router configuration.
Closes #28903

Question: Is the intent here to make it so redirectTo: '/foo' is relative to the base URL while redirectTo: 'foo' or redirectTo: './foo' is relative to the current route?
I do wonder if redirectTo: 'foo' might be confusing and ambiguous for some devs, but it seems like this aligns with the app router at least?

The Angular router offers various ways to define redirects, and the goal here is to support these options. I agree that it can be confusing and ambiguous—personally, I also found it difficult to fully grasp how redirects work. The fact that an empty string is interpreted as a trailing slash.
Example of Route Configuration:
const routes: Routes = [
  {
    path: '',
    pathMatch: 'full',
    redirectTo: 'some',  // Redirects to '/some'
  },
  {
    path: ':param',
    children: [
      {
        path: '', // This is treated as a slash
        pathMatch: 'full',
        redirectTo: 'thing',  // Redirects to './thing' (relative to :param)
      },
      {
        path: 'else',  // This is treated as /else
        pathMatch: 'full',
        redirectTo: 'thing',  // Redirects to './thing' (relative to :param)
      },
      {
        path: 'thing',
        component: DummyComponent,
      },
    ],
  },
];

I updated the logic to actually resolve these during extraction.

The changes were merged into the following branches: main, 19.0.x


[pigeon] linux generator only supports 123 total custom types

https://github.com/flutter/packages/pull/6840 adds support for unlimited custom types to all generators besides via the overflow class. This functionality needs to be extended to the gobject generator as well.

fyi @robert-ancell. This isn't high priority, but it would be awesome if you could take a look at some point.

I'm reading through the change and it's not clear what needs to change to support this. Is there some documentation on how the additional custom types are encoded? Or perhaps a quick summary to get me started?

I'm reading through the change and it's not clear what needs to change to support this. Is there some documentation on how the additional custom types are encoded? Or perhaps a quick summary to get me started?

Essentially we added a class that handles overflow (more than 123 custom types) by just encoding them as a class with type value and the data stored in it. It still uses the pigeonCodec for encoding/decoding.
If you run the tool/generate.dart command with -o as an argument, it will add a bunch of types to the core_tests pigeon and generate them with the new overflow class system so you can see it in action.
I can do a better write up if you want, or answer any questions, just let me know :)


I got this error below when try to create pentaho/biserver

Tag latest not found in repository docker.io/pentaho/biserver

Sorry, I got this error because I dona use Tag

:+1: Glad you figured out the issue


feat(menu): added icons to items in the hamburger menu

Closes #2209
Changes proposed in this pull request:

Added icons to items in the hamburger menu

note
useTranslator seems to have been automatically fixed by the linter and was included in the commit. Let me know if this is a problem.

Should this pr be closed? Looks like #2220 did almost the exact same.


Update Repository name in GettingStarted.md

The name of the swift repository has changed from apple/swift to swiftlang/swift

@swift-ci please smoke test


upgrade representable

Just started using this gem so I don't admit to being an expert, but I am somewhat familiar with representable and this seems like what we are shooting for and now tests pass.   The change is from passing options straight into to_json or to_hash to passing the key :user_options.

@pfenig @sqrrrl  It is expected any movement on this proposal?

It's fine, I'd just like to bundle this with some other larger changes that affect dependencies (dropping Hurley, upgrading httpclient) but I'm blocked waiting for the next httpclient release that contains an important fix. Should hopefully be soon though.

Does the latest version of httpclient (v2.8.1, released 2 days ago) contain the fix you were waiting for? I'm using reform which requires representable >= 2.4, so would be very happy to see this PR merged.

Yep, will take a look at getting a 0.10 release out in the next week or so.

Closing, but I applied these changes in the v0.10 branch. Hope to have that out soon.


Add a create function to use Pastel without ppx

This PR creates a function create as an alternative to the createElement function used by the JSX ppx.
This allows users who don't use the PPX (OCaml) to use Pastel with a nicer API.
In OCaml:
Pastel.create ~color:Pastel.Blue ["World"]

vs
Pastel.createElement ~color:Pastel.Blue ~children:["World"] ()

Awesome! This will also help for using Pastel in places like: https://fb.workplace.com/groups/567987173671510/permalink/828579050945653/
No need to change yet, but I wonder if we use Pastel.make rather than Pastel.create. I think I see the former more often

@kyldvs I like make better as well!
I wonder if it would make sense to pass it a string instead of a list of string also. The user would be responsible to concatenate the strings if needed.

Keeping it as a list might be nice so we can maintain the nested feature of pastel
Pastel.(make(
  ~color=Blue,
  [
    "Just Blue",
    make(~bold=true, ["Blue and bold"]),
    "Just Blue",
  ],
))

@bandersongit Any thoughts on this? :)


coinbaseWallet > appLogoUrl not working and default favicon url won't add / after domain

Check existing issues

[X] I checked there isn't already an issue for the bug I encountered.

Describe the bug
I am passing the appLogoUrl to the function, but the logo is broken in UI. After inspecting I found that it's using default favicon itself.
Favicon works for me but it's broken as it's missing / in the image URL after the domain like below
https://domainNameassets/favicons/apple-touch-icon-180x180.png
Where the expected URL is https://domainName/assets/favicons/apple-touch-icon-180x180.png
Link to Minimal Reproducible Example
No response
Steps To Reproduce
No response
What Wagmi package(s) are you using?
@wagmi/connectors
Wagmi Package(s) Version(s)
5.0.21
Viem Version
2.x
TypeScript Version
No response
Anything else?
No response

Probably worth follow up upstream on Coinbase Wallet SDK https://github.com/coinbase/coinbase-wallet-sdk

Probably worth following up upstream on Coinbase Wallet SDK https://github.com/coinbase/coinbase-wallet-sdk


MSC1862: Presence Capabilities

Rendered
Synapse implementation
Riot implementation

i before e except after c :-p

The proposal doesn't state the functional problem/feature that it's trying to solve/add.

Seems as though this proposal has become a bit of a cold case. In an effort to incite commentary...
@mscbot fcp merge

I assume the intention is that the new capabilities API isn't authed (ie. can be hit by anyone). That said, would the server sometimes advertise different caps for different users? For now I might suggest just saying it's authed: it is simpler to open it up later if required than introduce more keys that only appear if you send your access token. Either way we should probably be clear about it.

The currently specced capabilities API  has auth required, so I could be more clear here and say that the response could be scoped to the user or the server.

:eyes: @ara4n @dbkr @erikjohnston @richvdh @uhoreg

(The buildkite script is broken, btw)

(The buildkite script is broken, btw)

It's fixed on master. can you merge forward?

@richvdh done

Anyone else?

Looks good to me. I'd like to see this land in r0.5.0 so that clients can implement this rather than hard coding a list of servers with presence disabled. In #riot:matrix.org, asking why everyone is offline is a very common question. If Riot could just disable the feature automatically then that would eliminate that feeling of brokenness that new users get.

I'd strongly recommend that someone start proving this in an implementation, and solicit reviews asap - the FCP is already proposed, just needs checkboxes.

@turt2live This is now a thing at https://github.com/matrix-org/synapse/pull/5666

Just needs more people to FCP it to advance it from the spec side

I've added a simple riot implementation too

@Half-Shot looks like this has some unresolved comments which might prevent it from entering FCP. Would recommend resolving old threads and addressing comments.

To echo @richvdh: I'm not sure this solves what we want it to solve. Presumably this is trying to fix the UX of not knowing if we have accurate presence information, but I don't actually think this solves that as we would still have unknown presence due to other servers.
Would this be better solved with having e.g. riot handle unknown presence better? Not greying out avatars and having the room list order incorporate last time we saw an action from a user I think could go a long way to making this proposal redundant.

Would this be better solved with having e.g. riot handle unknown presence better? Not greying out avatars and having the room list order incorporate last time we saw an action from a user I think could go a long way to making this proposal redundant.

Yes, certainly a lot of this could be solved by listening for receipts/messages and using that as a faux presence system.
The other half to the proposal is giving servers a way to report that PUT will not be handled by the homeserver, and I think there is still some value in reporting something other than success there.

Yes, certainly a lot of this could be solved by listening for receipts/messages and using that as a faux presence system.

This seems like the wrong way to solve the problem.

The other half to the proposal is giving servers a way to report that PUT will not be handled by the homeserver, and I think there is still some value in reporting something other than success there

Could you enlarge upon this? What is the value of it?
As per https://github.com/matrix-org/matrix-doc/pull/1862#discussion_r317078257, I think I have progressed today from "why is this needed at all" to "ok, but this feels like the wrong solution". I feel like we can achieve the same effect with minor tweaks to the APIs instead.

The other half to the proposal is giving servers a way to report that PUT will not be handled by the homeserver, and I think there is still some value in reporting something other than success there

Could you enlarge upon this? What is the value of it?

Certainly. A few clients have experimented with supporting users setting their own presence status at one point or another, where a user had to hit buttons to change their presence state rather than using sync to do it (which is the point of this endpoint).
If I hit buttons to change my presence state in my matrix client and it happily does so, while the actual request is being ignored by the homeserver, that's a rather poor UX. Certainly if you expect "unavailable" to mean "please don't bother me" and then people bother you because the feature doesn't work, that seems pretty awful.
Which brings me back to the capabilities flag. I'd rather disable features like these in clients where the homeserver doesn't support them by way of flag, but failing that I would like for error codes to be returned when a feature doesn't work so that the client can relay that information back to the user.

Is there anything holding this proposal back?
@Half-Shot @richvdh @KitsuneRal

it's pretty clear that this MSC needs some more attention; for example the thread at https://github.com/matrix-org/matrix-doc/pull/1862#discussion_r317078257 ends with @Half-Shot agreeing to replace the "should clients show whether users are online" logic with information based on the results of /sync, which doesn't seem to have happened.
meanwhile https://github.com/matrix-org/matrix-doc/pull/1862#discussion_r318566909 has got a bit confused with conflating the behaviour on the read side and on the send side, possibly with some alternative suggestions about how to proceed?
In any case, it seems we're agreed that capabilities are not the right mechanism for determining how clients should display presence state, so this is back to @Half-Shot  to update. It might be best to replace this MSC with alternative proposals which handle the send and read side separately, but I'll leave that to you.
In the meantime I'm going to make an executive decision to
@mscbot fcp cancel

it's pretty clear that this MSC needs some more attention; for example the thread at https://github.com/matrix-org/matrix-doc/pull/1862#discussion_r317078257 ends with @Half-Shot agreeing to replace the "should clients show whether users are online" logic with information based on the results of /sync, which doesn't seem to have happened.
meanwhile https://github.com/matrix-org/matrix-doc/pull/1862#discussion_r318566909 has got a bit confused with conflating the behaviour on the read side and on the send side, possibly with some alternative suggestions about how to proceed?
In any case, it seems we're agreed that capabilities are not the right mechanism for determining how clients should display presence state, so this is back to @Half-Shot  to update. It might be best to replace this MSC with alternative proposals which handle the send and read side separately, but I'll leave that to you.
In the meantime I'm going to make an executive decision to
@mscbot fcp cancel


Feature request - add underline and strikethrough support for Label markup

https://www.libsdl.org/projects/SDL_ttf/docs/SDL_ttf_22.html
[u]underlined text[/u]
[s]strikethrough text[/s]

I want implement this feature. @dessant could you point me to the correct files?


Popup not scaling

The "are you sure" popup is not scaling.
I don't know why...

Tween node is in pause process mode

#55

Done in #55


tlsHandshakeTimeoutError potentially invoking unwanted IsContextErr flow?

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.
Which version of Elastic are you using?
[ ] elastic.v7 (for Elasticsearch 7.x)
[X ] elastic.v6 (for Elasticsearch 6.x)
[ ] elastic.v5 (for Elasticsearch 5.x)
[ ] elastic.v3 (for Elasticsearch 2.x)
[ ] elastic.v2 (for Elasticsearch 1.x)
This might be important for this issue: sniffing is disabled.
Please describe the expected behavior
The tlsHandshakeTimeoutError might have to be reassessed, it might be better in this case to treat is an error that results in retrying followed by another connection selection, so it doesn't immediately give up.
Please describe the actual behavior
The client is performing regular search requests by selecting one of the connected nodes as known by the ES client. However, when one of the nodes drops and returns, there might be a small time window where the following happens:

A client performs another request and selects that returned node
A TLS handshake timeout error occurs.
The following code snippet is activated when the following error occurs:

client.go, method PerformRequest(ctx context.Context, opt PerformRequestOptions) invokes
func IsContextErr(err error) bool {
	if err == context.Canceled || err == context.DeadlineExceeded {
		return true
	}
	// This happens e.g. on redirect errors, see https://golang.org/src/net/http/client_test.go#L329
	if ue, ok := err.(*url.Error); ok {
		if ue.Temporary() {
			return true
		}
		// Use of an AWS Signing Transport can result in a wrapped url.Error
		return IsContextErr(ue.Err)
	}
	return false
}

More detailed: the error is evaluated as *url.Error and the return true path is executed because the tlsHandshakeTimeoutError struct implements Temporary() as always returning true.
The issue here is that we believe these lines of code were not intended for this type of error (tlsHandshakeTimeoutError). It will now immediately give up the request and not retry, let alone retry followed by selecting another connection.
Any steps to reproduce the behavior?
What I have done to mimic this:

Add https://localhost with a self-signed certificate as one of the configured ES nodes, implementing a mocked version of one of the POST search query involved (could be any), plus a HEAD so health checks can be enabled.
Spin an es client with one valid ES node, one localhost node URL configured.
Let it perform its health checks
Perform the POST call a few times, this should use each node at will and both should work.
Shutdown and reboot the localhost process
Perform the POST call, the client will now initiate another TLS handshake session for the revived localhost node, break on line if trace != nil && trace.TLSHandshakeStart != nil { for at least 10s exceeding the default Transport TLShandshake timeout.
The error tlsHandshakeTimeoutError will be sent back by the code all the way up to the es client code.
The IsContextErr() flow as documented above will be executed.
No other node will be selected and this request is given up.

Another way (but likely a bit harder) is to restart a real node in the ES cluster added by the scenario that a TLS handshake timeout error occurs. We have not yet tried this approach though we think this scenario should come very close if not equal to the actual scenario we see happening in our live environments.
EDIT: a more simple way (this will only show the code flow though, not actually reproduce end-to-end) is to set a very low timeout before performing the request:
c.c.Transport = &http.Transport{
	TLSHandshakeTimeout: 1 * time.Microsecond,
}

Just adding it in for the sake of being complete.

Any news or info on this ?

Any  updates on this?


fix: deprecated DIAL_USE_FILE_STORAGE env var

Breaking changes

DIAL_USE_FILE_STORAGE is deprecated
the status of DIAL_URL env var now defines whether DIAL file storage will be used or not

Conf migration

Before DIAL_USE_FILE_STORAGE
Before DIAL_URL
After DIAL_URL

∅
URL
∅

∅
∅
∅

False
URL
∅

False
∅
∅

True
URL
URL

True
∅
NA (the configurationwas incorrect in the first place)

/deploy-review


Remove bi curious from list of badwords

By all account bi curious is in no way a bad word and remains the most respectful way to refer to many peoples sexual preferences.

Completely agree. Thanks for your contribution!

By totally different logic, shouldn't 'big black' probably be removed also?  It's..  a little general...  I should be able to talk about 'big black boxes vs little black boxes' or something :-)

@bglusman: If you submit a PR, I'll gladly merge it.


PHP 7.4 and laravel horizon

Info:

Docker version ($ docker --version): Docker version 19.03.5, build 633a0ea838
Laradock commit ($ git rev-parse HEAD): https://bitbucket.org/lionslair/laradock/src/master/
System info (Mac, PC, Linux): Ubuntu 18.04 LTS
System info disto/version:

Issue:
Using php 7.4 in .env I get the following output
checking for oniguruma... no
configure: error: Package requirements (oniguruma) were not met:
Package 'oniguruma', required by 'virtual:world', not found
Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.
Alternatively, you may set the environment variables ONIG_CFLAGS
and ONIG_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.
ERROR: Service 'laravel-horizon' failed to build: The command '/bin/sh -c docker-php-ext-install mysqli mbstring pdo pdo_mysql tokenizer xml pcntl exif' returned a non-zero code: 1

Expected behavior:
laravel-horizon compiles with php 7.4
Reproduce:
Clone the above repository and do docker-compose up with .env PHP_VERSION=7.4

Relevant Code:
checking for oniguruma... no
configure: error: Package requirements (oniguruma) were not met:

Package 'oniguruma', required by 'virtual:world', not found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables ONIG_CFLAGS
and ONIG_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.
ERROR: Service 'laravel-horizon' failed to build: The command '/bin/sh -c docker-php-ext-install mysqli mbstring pdo pdo_mysql tokenizer xml pcntl exif' returned a non-zero code: 1

I have repaired it
RUN docker-php-ext-install mysqli pdo pdo_mysql tokenizer xml pcntl
delete mbstring

Your fix seems to solve that original issue but then I get issues about
configure: error: unrecognized options: --with-libzip
and similar with other parts. I feel like maybe other containers or options are not ready for php 7.4 yet. Do not get the issues on 7.3

@lionslair yes，you are right。It not ready for php 7.4 yet。

I had the issue, and I provided a fix in #2414, its for the php worker, but may work for laravel horizon

i also get those error message when trying to build php-worker with PHP 7.4
removing mbstring on Dockerfile like @zoulux suggest has fix the problem :D

Hi there 👋
I was also struggling to upgrade my Laravel Dockerfile from 7.3 to 7.4 and I was having the exact same error messages.

First, I got the error configure: error: unrecognized options: --with-libzip which I fixed by removing the following line since according to this, it is now re-bundled by PHP >= 7.3.

RUN docker-php-ext-configure zip --with-libzip

Next, I got the error configure: error: Package requirements (oniguruma) were not met. I fixed that one by removing the installation of mbstring since according to this, it is already installed and configured by the PHP image I was using. An alternative to that one is to install the libonig-dev library to fix the dependency problem.

I hope this helps 🍀


Adding a PausableTimer to allow pause/resume functionality without altering existing code

I have created another "class": PausableTimer which acts exactly like the current Timer, but has three extra methods, and two additional fields. The additional fields allow the PausableTimer to keep an internal state of its total elapsed time, (a accumulation of every "elapsed" passed to the callback). This means that instead of passing "elapsed" to the timer callback, it passes the "totalElapsed" of the timer. That means, that even if the PausableTimer is paused, it can still keep it's animation state upon being resumed.
The Pausable Timer implementation solves this issue: #14
As mentioned in the pull title: as it is a new "class" it will not alter any existing code, and will not make any breaking changes. Although, if you like the implementation, you may, of course, feel free to combine PausableTimer and Timer.
I've also updated the ReadMe to explain the new class and its new methods.

@mbostock - Is there any update on this? I don't personally need it pulled in, but it would be nice to have some feedback.

Hi @woodev01. Thanks for the suggestion and apologies for the delayed response. I would suggest releasing this as a separate library if you want to make it available to others!

thanks very much ，Im in trouble With this problem now


RefactorStart

Just a start, to track here

please write a descriptive PR summary, and choose a descriptive PR name (see about all other PR)

@khrapovs, could you kindly look at the changes to forecastinghorizon? I´m not sure whether they would revert your earlier changes.

@fkiraly There is a new argument consecutive with default value False in to_absolute. Given this value the behavior of the method is identical to already existing. So, no complaints from my side.

@khrapovs, are you certain that the behaviour is otherwise identical??
For instance, the case distinction based on if is_timestamp seems to be removed.

I would strongly hesitate adding any new arguments in methods of the forecastinghorizon. This needs explanation for a review first...

For instance, the case distinction based on if is_timestamp seems to be removed.

No, a few old lines migrated "as is" to _index_range function.

I would strongly hesitate adding any new arguments in methods of the forecastinghorizon. This needs explanation for a review first...

@danbartl I would tend agree. Is it 100% impossible to achieve the same result without touching ForecastingHorizon interface? Perhaps it is, but it is hard to judge without diving deep into the proposed change.

@danbartl, is this ready for review?

👀 (reviewing)

@fkiraly I added all the doc strings as suggested, and also dropped the requirement to have a truncate_fit attribute in the transformer.

Added FeatureUnion and more doc strings


Use  element for directory listing entries

https://deno.land/std/ <-
The directory links seem to be some other generic element using click events. I can't Ctrl + click those, drag them, etc.

Should that functionality be added? If so I could take on the task, just assign me the ticket.


Officially Support TYPO3

What happened (or feature request):

Feature Request tied to v1.2.0 of the roadmap.

What you expected to happen:
We've tested and manually stood up a TYPO3 site to get a sense of what would be necessary to make it a supported, 1st class citizen alongside WordPress and Drupal 7/8. Once we refactor how we handle CMS specific logic, we will be using that as a way to officially support TYPO3.
More details and acceptance criteria to follow once we get within 2 sprints of starting this issue.

Adding this as a running list of requirements/nice to haves as we attempt to converge on the acceptance criteria necessary for this feature. In an email exchange with @wmdbMattes, he mentioned the following items.

IMPORTANT: ImageMagick / Graphicsmagick binaries accessible for the PHP process (we use exec() calls here).
Somewhat important: Ghostscript compiled into IM/GM
Nice to Haves: pdf2text, pdfinfo, catdoc, ppthtml, unrtf, unzip and xlhtml (for our built-in search)

I was able to confirm that we have ImageMagick installed via apt-get and accessible to PHP exec calls (pass exec ('convert -version'); as a test). We don't have Graphicsmagick, but I'm not sure that is needed in addition to Imagemagick. As for category 2 and 3 items, we don't have Ghostscript or any of the pdf2X converters. We do have unzip.
To provide context as to why these GS and pdf2X libraries are needed/important, @wmdbMattes explained that TYPO3 provides mini-photoshop like set of functionality in the backend to manipulate photos and that requires the ability to support these types of format X to Y conversions.

I wanted to call this out explicitly. We've already introduced necessary additions to the web and database containers to pave the way for TYPO3 support. See https://github.com/drud/ddev/issues/500#issuecomment-344619097. So that reduces the number of items in the overall acceptance criteria.


www.netflix.com sloow loading

Hi,
Thanks for the project. I set up dns (Digital Ocean SFO) on my machine(France). Everything is smooth. Pandora.com. spotify. ipinfo.io. pages loads in just few seconds. However when I try to open netflix.com something it will just stuck on loading page. no respone for a long time and suddently the netflix.com webpage loads. What do you think is the key issue that cause this problem? Thanks

However when I use the proxy I setup on the dns server(digital ocean SFO). netflix.com open in just seconds. Weird issue.

You may find rebuilding in a different DC, using a different tunnel server (you can have a max of 5) at a different time of day will sort this issue out. I believe it to be congestion at different points along the path.

Please re-open if still having issues..


Applicability in the Maritime Domain (Open Waters or Docks)

Hi @wzzheng,
I'm very interested in your work, as I think it paves the way for more open-source camera-only experimentation in 3D occupancy mapping.
I have two questions for you:

In the comparison table with Tesla occupancy network, you reported a large discrepancy in terms of inference speed (10 ms vs. 290 ms), which would make the model not suitable for downstream real-time tasks. Why does the forward pass take so long? Maybe it's just due to the hardware and there is no actual noticeable discrepancy in place.
Could the methodology be applicable outside the urban domain, where the appearance of the outer environment could have drastically different properties (besides updating the semantic labels for the 3D occupancy)? In particular, we are experimenting autonomous navigation for unmmaned surface vehicles (USVs), which should be able to handle both docks scenarios as well as open waters. Thus far, we have always been quite limited in the complexity of the models, as the dataset that we have has roughly the same cardinality as yours, which was regarded as too small. Focusing on the maritime domain, if docks is not too dissimilar from an urban scenario in terms of point cloud density, open waters is orders of magnitude sparser, while retaining few objects that could provide meaningful training signal, besides the water surface, albeit being simpler to model. Would that cope well with the TPVformer model, or are there any concerns in the implementation you think would need to be addressed?

Thanks for your interest!

Here is a detailed inference speed of TPVFormer for your reference. The main latency lies in the TPV construction stage.  However, the current code is not optimized for speed. There is still much room for improvement. As for the comparison with Tesla, we think the main discrepancy lies in the hardware design. Their on-car hardware is perhaps designed for this, resulting in the much faster speed.

I'm still not quite certain about your scenario, but based on my current understanding, I do not think the point cloud density would be a large problem, as TPVFormer only relies on camera inputs in the test phase. However, the learned model might overfit the training point cloud density and output different occupancies for dock and open water scenarios.
I don't know if I'm getting this right, but I'm open to more discussions!

Thank you @wzzheng for the detailed reply,
I will investigate a bit more the code behind the TPV construction. I think I might have to try and optimize the code a bit, but not by much, as we still have a pretty powerful computer on board.
As for the second question, my concerns are more oriented towards over fitting in training. I read the paper more carefully, and if I understood correctly you use TPVformer to generate dense semantically-rich 3D representations (varying depending on the task) supervised only on the sparse signal provided by the point clouds. How sparse can the training signal become to still train the model successfully? I am a bit worried considering the very sparse nature of open waters, and the non-homogeneity if the data between open waters and docks scenarios, but I guess we will just have to train the model on our data and see if and what it's able to learn.
I will keep you posted.


Make a current directory name in lowercase letters

You can find all details here - https://github.com/facebook/jest/issues/715.
In short, this PR will fix Jest for Windows users.

Hopefully this can eventually be removed: https://github.com/node-modules/fast-path/issues/5

Thanks for troubleshooting this and sending a PR. There is a PR for node-haste which aims to fix this issue inside of node-haste which will also fix it for react-native :)
Follow along here: https://github.com/facebook/node-haste/pull/41 – after this is done I can tag jest-cli 0.9.0 :)


Convert About page to use Vue bindings

See if I can use Vue's model bindings on the About page

I had to dig around in the TypeScript with Composition API docs, but I got it to work.


[RFC]: extended_apis: control register access exit handling

I would like to add an API to support handling control register accesses for both monitoring and intervening objectives.
This API was originally designed for cr3, but I think that the same design would fit all control registers (cr0, cr3, cr4 and cr8); that being said, I currently do not wish to handle special cases (e.g., cr4 shadow etc.); I will leave that to the callback function's logic.
Proposed APIs:
For each control register, I want to add the following options (illustrated by cr3 as an example):
using cr3_value_type = intel_x64::cr3::value_type;

vmcs:: enable_cr3_load_hook(
cr3_value_type (*callback)(cr3_value_type )
)

vmcs::enable_cr3_store_hook(
cr3_value_type (*callback)(cr3_value_type )
)
where the signature for the load and store callbacks receive the cr3 value (to be stored or loaded) and returns the cr3 value to be actually stored or loaded.
If the callback is for monitoring only, it can perform whichever bookkeeping operations it wishes and return the value given; if it is for intervening, it can modify the value however it wants and return the new value that will be set.

vmcs::vmcs:disable_cr3_load_hook

vmcs::vmcs:disable_cr3_store_hook
which will simply disable the exit controls for that register.

The control flow will build upon the design of @connojd in https://github.com/connojd/extended_apis/blob/ecr/src/exit_handler/src/exit_handler_intel_x64_eapis.cpp:

exit_handler_intel_x64_eapis::handle_exit would check for control_register_accesses.
exit_handler_intel_x64_eapis::handle_exit__ctl_reg_access()
which will switch on the register number, read the value about to be read/set, and call the callbacks     that were set with vmcs::enable_control_register_access_hook. It will then emulate the instruction by setting the returned value from the callback to the required register (the cr in a load, or the gpr in a store) in the VMCS guest area, then calling
exit_handler_intel_x64_eapis::advance_and_resume().

Default
It will be disabled by default.

@scalys7 This sounds great. Could minor questions / comments:

We should have this setup for all of the CRs including CR0 (wasn't mentioned above).
Should we use the index or should be have a set of functions for each CR? Like enable_cr0_access_hook? This way there is less testing involved because you don't have to have code to check the cr #.
We should use a C++ alias instead of UNIT64, this way we can change the type if need be in the future.

Other than that... nice RFC!

On the first point, i've updated the rfc.
The second, I don't see how beneficial (performance wise) it will be, as the switch on the cr number will only be avoided on enable/disable and not in the exit handler which is heavier. Then it all comes down to ease of usage; I can go with both ways, whichever seems nicer to you guys.
The third, no problem, but do you mean use a predefined alias (if so, which one?) or one made up for this purpose?

I think I would prefer enable_cr0_access_hook/disable_cr0_access_hook, and so on as providing a CR# as part of the API would require an enum which would be more verbose, and a bit more cumbersome.
Each CR already has it's own alias:
https://github.com/Bareflank/hypervisor/blob/master/bfvmm/include/intrinsics/crs_intel_x64.h#L46
So you should be able to use this, in an alias defined in the VMCS. Something like:
using cr0_value_type = intel_x64::cr0::value_type

In that case, I prefered adding a different api for store & load, as someone might care for stores/loads only, and this could affect performance vastly as it can prevent unnecessary vm-exits.
See my updated rfc.

LGTM +1

@connojd @brendank310 ?

A few comments after starting to play with the code:

There is only a store/load cr3 and cr8 execution control; for cr0 and cr4, the following is stated by the Intel manual:

MOV to CR0. The MOV to CR0 instruction causes a VM exit unless the value of its source operand
matches, for the position of each bit set in the CR0 guest/host mask, the corresponding bit in the CR0
read shadow. (If every bit is clear in the CR0 guest/host mask, MOV to CR0 cannot cause a VM exit.)

same goes for cr4. This means that if I'd want enable_cr0_load_hook to actually assert that all loads will execute our hook, I'd have to modify the mask and shadow and make sure that it will never match the above conditions. Would that something that you'd want me to do?
My recommendation would be not to do so, and to only hook these commands when they do not match the normal conditions; this way, we can let the user decide whether he wants to hook all the commands or only the ones that cause an exit normally.
Also, note that for cr0 and cr4, store never exists!
Thus I will remove the store APIs for them.

There isn't an alias for cr8. Should I create one? I forked the extended-eapis repo, and the appropriate spot for that alias should be crs_intel_x64.h...

I'm thinking that vmcs isn't the appropriate namespace for these APIs. I think exit_handler_intel_x64_eapis will do the job.

What are your thoughts?

1:
Probably best to provide in your RFC, the APIs for all 4 registers, as I bet they will not all look the same. For 3 and 8, what you have will work. For 0 and 4, the user should provide the desired mask for load, and as you stated, there would be no APIs for store.
2:
Your right, we are missing CR8. @JWZepf Feel free to provide a PR for the hypervisor repo that adds this missing set of APIs. That was my bad as I forgot to add them.
3:
Right now, all of the APIs for setting up the VMCS are in the VMCS namespace. Out of curiosity, why exit_handler_intel_x64_eapis?
So far, I think this is really shaping up to look pretty awesome. Thanks for the hard work.

@scalys7 LGTM. I agree with @rianquinn with putting the enable/disable functions in the VMCS though

So I updated my RFC; a few notes/questions:

In cr0/cr4 load hooks, should I check / force the masks to specific actions in regards to certain fields? or should I let the programmer live with the consequences?
E.g., the vmx enable bit of cr4.
For the cr8 hooks, I am waiting for you to add a cr8_value_type.

@scalys7 Crap.... sorry about that. I'll have that up in ASAP. As for #1, let them live with the consequences for now.

The PR for this was merged. Once I do some additional cleanup, and merge this work into v1.2, I will close this ticket. Great job @scalys7

The updates can be here. The only functional change was the VMCS doesn't register a callback, but rather the exit handler has a set of callbacks that can be overloaded.
https://github.com/Bareflank/extended_apis/commit/547fe82079c42c1d1535909efcd90a18ca933058
This code has also been cleaned up so that it will be accepted by the 1.2 build system as well, and the port of that code is complete.


possible enhancement?

Consider a extreme case in cui i have a application with a strong dynamic for insertion /removal of rows .
Every time i insert a new row, OrientDB  increments counter for the current rid . so,
It could reach the maximum value just with 1 row present in database (with many insert, delete)
OClusterPosition could wrap a Number not a long, so the dimension of this number can be dynamic(long or biginteger if is necessary).
A side effect of this problem is also in distrubuted system: what does it happen if cluster in a server reach the maximum rid ?
Is there some technical problem to make it ? It could be usefull to know it for understanding if in the future i need  it if i have a way for solving it.

With long numbers you can store 2^63. This means that with a rate of insertion of 1,000 records/sec, you'd need 106,751,991,167 years to have this problem. I think we can close this issue.


Custom noteskin not showing up

Describe your bug here.
I tried adding the png and xml in assets/shared/images/noteSkin but it won't show up in-game, and I also tryed replacing the list txt file, but it is just showing up as the Default one.
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
I edited list.txt in assets/shared/images/noteSkin

I'm using 0.7.1h btw


Non information about OS for patches

NO information about OS applicability of the patches for WSUS in this article. It misleads people. My peer tried to install those patches to server 2016 for two days.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 216e808f-64f5-7681-3f7b-bfc1f4193b71
Version Independent ID: 8f9a6ef6-6eff-430f-a6d8-b59143c7fdb2
Content: Manage Windows as a Service - Configuration Manager
Content Source: sccm/osd/deploy-use/manage-windows-as-a-service.md
Product: configuration-manager
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

Hi @ilnuri, thank you for sharing and I'm sorry for the difficulties. I assume you're referring to the prerequisites?
This article in general is on the backlog for a revision. I'll use this issue to track that effort.

Hello,
Thank you!
Отправлено с iPhone

12 июня 2018 г., в 19:18, Aaron Czechowski<EMAIL_ADDRESS>написал(а):
Hi @ilnuri, thank you for sharing and I'm sorry for the difficulties. I assume you're referring to the prerequisites?
This article in general is on the backlog for a revision. I'll use this issue to track that effort.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

is there any Windows 10 License Consideration for using Windows as Service ( SCCM )


ENH: Feature toy data

Summary
Adds synthetic toy datasets so users can see, use, and create examples of properly formatted data that works with the tool.
Key changes:

datasets module refactor -> the SyntheticData class is completely reformatted.
Added function generate_synthetic_data in datasets.synthetic_data for reproducible toy data generation.
Added small CLI tool generate_ageml_data for generating this data in a directory of choice, so users do not have to point to the virtual environment where the package is installed to use the data.
Updated pyproject.toml to accomodate CLI addition.
Added tests for the datasets module.
Added a tutorial in docs/TUTORIAL.md as a getting started document.
Makes toy datasets importable from the datasets module.
Refactors test_visualizer.py to work with the refactored SyntheticData class.

Other changes

Updated .gitignore to ignore notebooks that could be useful for developers.
Added pre-commit configuration file, .pre-commit-config.yaml. Passes a ruff linter hook.
Updated README to link Colab notebook.
Updated TUTORIAL

Notes

Manually tested all ageml pipelines with the toy datasets.

Resolved all comments from @JGarciaCondado, ready to merge.


Enhanced queries for connected devices

Was just asked whether there was an easy way to get the following:

A list of all the devices connected
Easily query if a certain device type is connected (ie. keyboard, mouse etc.)

Right now, you can query a specific device with the following:
Corale.Colore.Core.Chroma.Instance.Query(Corale.Colore.Razer.Devices.Tartarus).Connected
I'm proposing and plan to implement the following methods:
Chroma.Instance.Query(Corale.Colore.Razer.DeviceType deviceType).Connected
Chroma.Instance.ConnectedDevices() which returns List<DeviceInfo>()

Please let me know if you could suggest better methods.

Just realised a better way to query a connected devicetype would be this:
Chroma.Instance.Headset.Connected

There is some value to this change, but for keyboards, given the different layouts it may simplify the checks too much?

@brandonscott That is true. For keyboards you may still have to query which device it is. However, lets say you separate out the logic per device type, or simply want to show / hide options based on connected types, then this would definitely be handy.
As for layouts, I personally think there should be a definition for each layout, as a few share the same and I'm sure more devices will in the future too. We would then have the ability to query as to which layout it is instead of individual devices.
example:
switch(Keyboard.Layout){
     case Razer.Keyboard.Layouts.Standard:
     // do something
     break;
     case Razer.Keyboard.Layouts.Mini:
     // do something else
}

We should raise this with Razer if we agree this would make beneficial to most.

Also, if you wanted keyboard device specific code, you would currently have to do something like this:
function Connected(DeviceInfo d){
    return c.Query(d).Connected;
}

if(Connected(Razer.Devices.Blackwidow)){
    // Do something
}else if(Connected(Razer.Devices.BlackwidowTe)){
    // Do something else
}else if(Connected(Razer.Devices.Deathstalker)){
    // Do something very different
}

Could potentially be shortened to a switch statement:

if(!Keyboard.Instance.Connected){
    return;

switch(Keyboard.Instance.Device)){
    case Razer.Devices.Deathstalker:
        // Do something
    break;
    case Razer.Devices.BlackwidowTe:
        // Do something else
    break;
    case Razer.Devices.Deathstalker:
        // Do something
}

It just feels cleaner.

Granted, in the rare case someone may have two of the same devices / device types connected.

This is the big issue with having a Layout property. The Keyboard class doesn't represent a single device with its own layout, it represents every (Chroma) keyboard device connected to the system and method calls to it will affect every connected device of the applicable type.
IIRC we raised this issue with Razer before regarding detecting different physical layouts and their response was basically "Nope, we just expect nobody to only ever have a single of any possible device type connected.".

Ok, so having created a new method for listing the connected devices, which is just a simple List<Devices>(), seems we should also add the Device Name to DeviceInfo.

Or at least attach the Guid.

_devices = new Dictionary<Guid, DeviceInfo>(); this is the easiest solution specifically for the list of connected devices.
DeviceInfo alone contains no reference to the device itself.


chore: upgrade Realtime to v0.25.0

What kind of change does this PR introduce?
Chore
What is the new behavior?
Upgrade Realtime to v0.25.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 48.584%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
2419

Relevant Lines:
4979

💛  - Coveralls


Standardize README

Add community and license sections
Add standard README header including Kitura icon

The Blue* frameworks are used by lots of other projects. IMHO, we should not label them with the Kitura icon as it may lead to them being misrepresented as Kitura specific. Thoughts?

@billabt understood. Would it be an more acceptable if I removed the Kitura icon and left the rest of the header as is? Ideally I'd like to leave the links to Slack and the community section at the end of the README as I don't see why users of the Blue* frameworks couldn't have a small exposure to Kitura, as I don't think these make it look Kitura specific?

That sounds fine to me. Thanks. We should probably make the changes to the other Blues ASAP for consistency.

I'll try and push identical changes to all of the other Blue* repositories by end of day today.

Ok, sounds good.  Once that's done, I'll merge them all either tonight or tomorrow morning and do a release.  Thanks.

@helenmasters Don't forget BlueRSA. 😉 Thanks.


Improving Long-Form Generation with Customizable Chunking Methods and Output Verification

Is your feature request related to a problem? Please describe.
The current chunking method can split text into parts that are too long for the model, leading to reduced quality, skipped words, or hallucinations.
Describe the solution you'd like
-It would be greatly appreciated if additional chunking methods could be provided, such as splitting on every sentence, comma, or other customizable delimiters.
-Have an output verification feature. This could involve displaying each chunk's generated audio below the corresponding text, allowing us to listen to and review each part individually. This would enable us to identify and re-generate any problematic parts, ensuring the final output quality. If a particular chunk's audio sounds unnatural or contains errors, we could re-generate just that chunk, rather than having to re-generate the entire output.
-Consider using pre-generated reference voice embeddings to accelerate regeneration times when re-generating specific parts of the output.
-Before merging the split audio parts for the final output, it would be great to have an option to insert X second/millisecond silence between parts.
Describe alternatives you've considered
One possible alternative is to use batch generation with text files or custom formatting, which could address the issues mentioned above, although it would require more manual effort from users.
Additional context
Thank you so much for your hard work!

D.I.Y


Meta: Enforce .tsx extensions

Resolves #4158

Looks like this copy is repeated from elsewhere. Let’s make a generic throwError function that throws or logs a regular single-line emoji-less string


Shortcut for jumping to next chapter

Describe your suggested feature
In SY and J2K theres a feature while reading with which you can jump to any chapters you want while being in chapter and dont have return to the title menu. I request that feature be included in mihon too.
Other details
No response
Acknowledgements

[x] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version 0.16.0.
[X] I will fill out all of the requested information in this form.

It's still 2 click either way