Added loop support

This commit adds the previous Loop requirement extension directly into the CWL v1.3 spec.

The important question here is: do we still need loopSource or we can directly use the source field here?
I remember the problem was that the source field requires a step_name/output_name format for the argument, while the loopSource here requires just the output_name, as the step_name is always the current one.
I think that we can proceed in two ways: either modify the schema_salad to handle both behaviors, or keep the loopSource specific definition.

Putting this PR in Draft state, as it depends on this one.

Needs a changelog entry

This is still true

@tom-tan We could make it optional but without needing a LoopRequirement, like conditionals are in CWL v1.2: https://www.commonwl.org/v1.2/Workflow.html#Conditional_execution_(Optional)

My comment about "Could we expand the names to last_iteration_output and all_iteration_outputs" still applies, the rest looks good.

There was an error in how we were running the self-check (are all the CWL documents used in the conformance tests valid at the schema level) which I fixed in #46 and rebased into here
tests/loop/invalid-no-when.cwl is invalid at the CWL schema level on purpose, which causes that check to fail. I'm not against having it in the conformance tests, but we need a way to easily mark it so we don't do the schema validation on it.

Filename pattern; Alas invalid is also used in other conformance tests that are schema-salad compliant. Either we rename those files or find another word to stick in the CWL document filename
put schema-breaking tests in tests/invalid folder or similar

I think the best idea would be to simply remove the test, as we can easily rely on SchemaSalad validation to assess this behaviour, without the need for a specific test


server/cache: add kv to cluster

We update cache and kv separately in different places, which may not be safe and hard to maintain.
This PR updates both cache and kv consistently inside clusterInfo.

Rest LGTM

PTAL @overvenus


DDT-29: event-subscription filters

The commented changes are from other commits. I will push a branch.
You can ignore this pull request+


Feature/native targets filename rule

This PR adds a new analysis rule that requires native Nuget packages to have their .targets file match their package name.
This resolves #845.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: aerotog sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

PR updated and ready for review.

Thanks!


Toolbar Container needs more top/bottom padding

The toolbar container across the dashboards could use more top/bottom padding for the buttons found within it.
Comparison to toolbar in Portal:

I fixed this in https://github.com/microsoft/azuredatastudio/pull/14188


Missing bee family on about page

Only 5 bee families are given on the "meet the bees" section. There are 6 families in N.A. and 7 globally...

added missing families and links


Console Spam

Getting a lot of console spam to do with:
info.servertools.permission.asm.STPClassTransformer
Not sure if it's causing any issues but there seems to be a lot of it, I've uploaded the latest log below:
https://www.dropbox.com/s/zz6x4x3f1utnavy/fml-server-latest.log?dl=0

I too also have its issue. I ran my server for a little over an hr and 23% of the lines contain the above string above.
Server Ran form 23:40:32 to 00:10:42
fml-server-latest.log size is 85997 lines long
20133 lines contain info.servertools.permission.asm.STPClassTransformer:
[I got the 20133 number form gedit ctrl+f]
If another 12-13 MB log file would help I would be happy to upload it (compressed or uncompressed).


Dependabot duplicating PRs

Interestingly dependabot opened two PRs:

https://github.com/ansys/pymapdl/pull/2408
https://github.com/ansys/pymapdl/pull/2409

However, althought mentioned pyvista[trame] in the pyproject doc dependency #2409 did change pyvista in the test dependencies, effectively being #2409 a copy of #2408.
Pinging @ansys/pyansys-core for visibility. Check your pyvista (and possible duplicated packages) dependabot PRs!

I will keep an eye on this, if issue persist I will open an issue in dependabot repo (if any)


Write customManagers entry to update renovateVersion string in Markdown files

We want to get updates from Renovate bot for the renovateVersion string in the FAQ Markdown file.
How?
@rarkins proposed:

I think that using npm or Docker versions as "close enough" is good enough for us. We won't want to update this all the time either, e.g. we could update this monthly like we do with renovate versions in other docs.

Source:

https://github.com/renovatebot/renovate/pull/32054#issuecomment-2434658591

Todos
I don't know enough to write the new Renovate configuration. I hope someone smart at regex can help! Here are the todos:
Write new config code in default.json:

[ ] Write a new customManagers entry, to update the "renovateVersion": "38.120.1" pattern string in Markdown files.
[ ] Use the version of Renovate from npm, or Docker as "close enough" approximation of the version of the Mend hosted Renovate app.
[ ] Set the schedule to monthly (or match the schedule for the other Markdown docs updates).

i think this simply needs another regex added here:
https://github.com/renovatebot/.github/blob/bf45bb3cc9b96de46a437bd4d03820ca71ac1241/default.json#L140-L151


docs(getting-started-enabling-plugins) fixed formatting

Summary
Fixed formatting on getting-started/enabling-plugins page.
Due to bad indents the whole content was formatted as code snippet:

Full changelog
Fixed bad indents.
Checklist:

[x] Commit message & atomicity checked
[x] Documentation
[x] Spellchecked my updates
[x] Ready to be merged

@coopr Thanks for your reviews!
And sorry for the multiple PRs. I noticed the same issue at other pages after the first PR got merged and thought that it would be strange to fix one page in one PR and three other pages - in another PR. So, I (wrongly) decided to keep one PR for one page.


Error decoding Code-128

Hi,
there is a problem on decoding barcode code-128.

It's not recognized every time and when recognized is of type UPCE.
I've tried with other app on AppStore and it's recognized correctly.
Is this a bug?

It's easy see UPC-E in other barcodes. I'd recommend restricting the scan to only look for Code-128 barcodes.


manifest.json invalid

Hi,
First of all, thanks for all the hard work that's gone into this.
After doing a build (clean install), the manifest.json file appears to be wrapped as a module:
module.exports = {
	"name": "React Boilerplate",
	"icons": [
        ...

This in turn causes errors with the chrome devtools, and the app doesn't get recognised as a PWA:

PS: I'm not an webpack expert, so I might be missing something.

yes, that needs to be plain old json https://developer.mozilla.org/en-US/docs/Web/Manifest
the module.exports = part can be removed.  leaving a valid json file.
to import the json file elsewhere in the app there's a webpack loader for that json-loader

Ahh, good catch, this is a bug! Would you mind submitting a PR fixing this? Thanks!

As far as I can tell, json-loader is already in place and doing what it's supposed to, namely wrap a JSON file as a module. Looking at the source code, that's literally most of what it does:
return "module.exports = " + JSON.stringify(value, undefined, "\t") + ";";

Removing json-loader completely seems to remove the issue, importing the JSON file in it's original state with no transforms. I assume this is because file-loader is taking over?
I think the solution to this problem is removing json-loader completely, unless it's needed for any other reason?

Ahh, no what we should do is import the manifest.json file with the file loader: import ‘file-loader?manifest.json :+1:

Ah! I think I just realised what's happening. We're already using file-loader like you suggest, but the json-loader is still picking up the .json extension and processing the file because it's defined in the global loaders.
By adding ! in front of the file-loader statement we can tell webpack to explicitly use the file-loader only:
import '!file?name=[name].[ext]!./manifest.json';

This fixes the problem. I'm just creating a pull request now.

👍

Thanks @bnhovde, good catch! :fire:

No probs, happy to help. Keep up the good work! ✌


feature request: allow caller to override state handlers

This is more of a feature request than a pull request, but the clearest way to explain what I mean is to supply some example code.  If you like the idea, feel free to implement it some other way and/or with some other name.
What I want is a State effect module that allows the caller to override its handlers.  In general, the caller's ability to supply their own handlers is one of the strengths of algebraic effects, right?  So while it makes sense to supply a standard handler, I think it would also make sense to supply a way to use a caller-supplied handler, without forcing the caller to use the currently-ugly try_with OCaml builtin.
The reason I want this at the moment is that I have modules A and B, say, which have their own instances of State, say A.S and B.S.  Then any code that uses both of them has be wrapped in A.run ~init:inita @@ fun () -> B.run ~init:initb @@ fun () ->.  I'd like to instead have a single outer state instance that stores both states together, say C with C.state = {a : A.state; b : B.state}, and define C.run to wrap its argument in both A.handle and B.handle that pass off to the components of the C state.  Then the actual caller can just call C.run.
One thing that's nice about this is that if there are multiple places calling run, then adding a new state-using module alongside A and B will only require changing the definition of C.run rather than having to make sure to find all the places where A.run and B.run are called to add another module's run also.  But more importantly, C can do fancier things than just storing a single copy of the two states, such as maintaining an undo buffer for both states together, without needing to pollute the code of A or B with that logic.

@mikeshulman In other libraries we have been using try_with for this feature. Do you think it is a good name?

Hmm... it doesn't really speak to me ("try" only really makes sense to me for exceptions, not effects), but I guess it matches the name of OCaml's handler function.  Whatever you want, I don't have strong feelings.

Yeah it's mostly for OCaml's syntax. I wonder if we should have a module that implements undo trees. :thinking:

I updated my PR to use try_with, so if you're happy with my version other than the name you can just merge it.

@mikeshulman I made both arguments optional. Does that sound good to you? Sadly you can't review your own PR.

Well, I have trouble thinking of a situation in which one would want to call it with one argument and not the other.  But if you want to do it that way (for consistency with other try_withs, I guess?) I don't see a problem with it.


Make expenses great again

We have lots of states for expenses - all of which can use design help.
Some background on how the system works:

Expense is filed by anyone, status = PENDING
A Core Contributor or Host can approve or reject. Status updates to APPROVED or REJECTED.
A Host can pay. Expense status updates to PAID. We also create a transaction in the Collective's Ledger that updates the balance of the collective.

We have three different viewers for an expense:

Public/anyone

All the basic info visible for an expense: title, amount, category (travel, food, etc), status (pending, approved, paid), submittedBy (name only), date of expense, payoutMethod (as in how to reimburse - paypal or manual. note: this is missing from the screenshot.)

ex: https://www.opencollective.com/opencollective and https://opencollective.com/opencollective/expenses

Core Contributor/Member

All the info that's public
SubmittedBy is now name and email
Payout Method is editable, can be changed from paypal to manual and vice versa (missing from screenshot)
Notes field (private field to share things like here's my bank info to send the wire to) (missing from screenshot)
Attachment (receipt that's attached to the expense)
Actions: Approve or Reject

What it looks like today:

Host

All the info for Core Contributor
If payoutmethod is 'paypal', we need to show the paypal email.
Actions: Pay

What it looks like today:

Other things needed:

disable states of buttons with ability to show a message. For example, there isn't enough money in the collective, a green 'pay' button doesn't make sense. Instead, we should disable the button and put a message saying, you need more money in the collective. (Currently, we let you hit it and then show the error).

Note that we are going to need to do something similar for Transactions. Currently, we show the following for a transaction:

ex: https://opencollective.com/opencollective/transactions
When a transaction is an expense, we want to show some of the original expense information in it, like notes and the original receipt, so likely have a "+" button to expand it.

Hi guys, here's the screens for the expenses widget. It shows:

Expense pending (Public - hidden receipt)
Expense pending (Core Contributor / Member)
Expense pending (Host)
Expense pending (Host - no funds available)

Let me know your feedback. I'll work now on the mobile version (300px width).

que lindas @cuiki !

Gracias @piamancini !
Guys, here is the updated versions with the mobile views. I had also forgot the small feature of changing the payout method in the Core Contributor/Member version.
Let me know if you have any feedback. :D

Very nice @cuiki!! More comments once I get a chance to dig in.
On Mon, Mar 27, 2017 at 1:39 PM Darío Muñoz<EMAIL_ADDRESS>wrote:

Gracias @piamancini https://github.com/piamancini !
Guys, here is the updated versions with the mobile views. I had also
forgot the small feature of changing the payout method in the Core
Contributor/Member version.
Let me know if you have any feedback. :D
[image: expenses-widget-updated]
https://cloud.githubusercontent.com/assets/981188/24369641/e1cff7ec-12e1-11e7-90e5-57d2bd346054.jpg
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenCollective/OpenCollective/issues/329#issuecomment-289527679,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF0vPYs5kA2BNS1YTzKxyqMFXD1F0pHXks5rp_RBgaJpZM4MlUlP
.

Hi again. Here is the view for transactions. I took the liberty of working a bit on that page. Regardless of if you implement it now or no, it shows how to display the details of an expense. It was a simple solution using the same component for now. Let me know your thoughts.
Zeplin link: https://zpl.io/2soJvo

i like that a lot @cuiki. i'm going to implement once i get back to coding.

@cuiki - Let's add fees while this is still fresh in your mind.
On expenses: we need to show paypal fees in cases where Payout Method is Paypal. It's usually 2.9% + $0.30. Maybe by the pay button? If it's a $40 expense, we could show the final amount - $41.56.
On transactions: we have a few fees to show.

Expenses: paypal fees (payment processor fees)
Donations: stripe fees (payment processor fees), host fees and platform fees.

For transactions, fees can be in the detailed view.

Hey @asood123, are the fees visible for all versions of the expense or just for Contributors and Hosts?

All versions
On Tue, Apr 4, 2017 at 5:29 PM Darío Muñoz<EMAIL_ADDRESS>wrote:

Hey @asood123 https://github.com/asood123, are the fees visible for all
versions of the expense or just for Contributors and Hosts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OpenCollective/OpenCollective/issues/329#issuecomment-291637574,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF0vPU7Y1ubf0Rpc9nDfIRlQK1rcbWEzks5rsrZBgaJpZM4MlUlP
.

Also @asood123, can you give me example amounts for donations? Just like you did for PayPal.
› Donations: Stripe fees (?) + Host fee (?) + Platform fee (?) = $??

Hi guys, so here are the changes applied from the feedback:

Expenses - All I did was move the amount below the Payout Method info. I think it was the simplest and best solution for now.

For transactions I added the fees and I made a Donation detail view. The amounts are not realistic in the example since I don't know the fees for donations. Once I get them I'll update the mock to reflect this.

Zeplin links remain. 🌮

@cuiki For a $10 donation:

Stripe fee: 2.9% + $0.30, so $0.59
platform fee: 5%, $0.50
host fee: 5%, $0.50

Net for collective: $10.00 - $0.59 - $0.50 - $0.50 = $8.41.
I think in most cases, it's better to show the absolute fee and maybe we can show the percentage on overlay?

Yeah, but that only works on desktop. There are no tooltips in mobile, and we'd have to rely on something like iPhone's 3D-touch. That's why I opted for showing it there. Err, wait you mean overlay like in a modal?

Good point, re: mobile. Let's show it for now.

Cool. Instances are now updated in Zeplin.

Transactions (Expenses) › https://zpl.io/1nn4Aq
Transactions (Donations) › https://zpl.io/1nn50P

@cuiki can you help me design the view of all expenses across all the collectives that a host is hosting?

Hey, take a look in Zeplin: https://zpl.io/Vxmor9W

closing this. design has been updated


Custom Output for edit field?

I'd like a few of my relationship-based edit fields to, instead of the relationship selector, show custom html so I can link to that entity's admin page.
Similar to how I can do it for a col:
        'savingsAccount' => [
            'output' => function ($value) {
                if ($value) {
                    $id = $value->id;
                    return "$id";
                }
            }

Is this possible?
(this also would help me hack around morph relationships in #191)
Thanks in advance

That would me great, especially for relationship types.


Update remote config firebase quickstart

Hello,
I would like to update the quickstart to the last version of googleapis since it could hurt some devs out there 😀

@Eomm thanks for doing this!  Happy to merge once the CLA is signed.

@googlebot I signed it!

Thanks!


python310Packages.argilla: 1.19.0 -> 1.20.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.argilla is: Argilla: the open-source data curation platform for LLMs
meta.homepage for python310Packages.argilla is: https://github.com/argilla-io/argilla
meta.changelog for python310Packages.argilla is: https://github.com/argilla-io/argilla/releases/tag/v1.20.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.20.0 with grep in /nix/store/0j09w7pa3ymhj66b5q9ba0wmb9fdknn1-python3.10-argilla-1.20.0
found 1.20.0 in filename of file in /nix/store/0j09w7pa3ymhj66b5q9ba0wmb9fdknn1-python3.10-argilla-1.20.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.argilla
python311Packages.argilla

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/0j09w7pa3ymhj66b5q9ba0wmb9fdknn1-python3.10-argilla-1.20.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.argilla https://github.com/r-ryantm/nixpkgs/archive/1a5f1c6a217cbc9adb2e90f8b21db35c4b6ea750.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/1a5f1c6a217cbc9adb2e90f8b21db35c4b6ea750#python310Packages.argilla

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/0j09w7pa3ymhj66b5q9ba0wmb9fdknn1-python3.10-argilla-1.20.0
ls -la /nix/store/0j09w7pa3ymhj66b5q9ba0wmb9fdknn1-python3.10-argilla-1.20.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python310Packages.argilla
python311Packages.argilla

Maintainer pings
cc @happysalada for testing.

Result of nixpkgs-review pr 275171 run on x86_64-linux 1

4 packages built:

python310Packages.argilla
python310Packages.argilla.dist
python311Packages.argilla
python311Packages.argilla.dist


Avoid to install or edit nginx

Hi all
I had a issue a long ago and it was resolved by changing:
sudo nano /etc/nginx/sites-enabled/default
#listen [::]:80;
#listen [::]:443 ssl http2 default_server;
sudo /etc/init.d/nginx restart
https://github.com/arakasi72/rtinst/issues/579
The problem now it is I am reinstalling the script in the previous install, but when I execute the script, it removes the "#" in the default file. So the issue is back and I can avoid it as before.
Is there any way I can avoid this? I tried to edit the script but it fails and now I get the following error all the time:
Installing nginx
Job for nginx.service failed because the control process exited with error code.
See "systemctl status nginx.service" and "journalctl -xe" for details.
If I put back the "#" nginx service is running again, but it is not configured, so rutorrent is not starting. Rtorrent is running but not rutorrent.

Hi all,
According with "journalctl -xe" the issue is "nginx[29146]: nginx: [emerg] socket() [::]:80 failed (97: Address family not supported by protocol)"
So, nginx is trying to start on IPv6 address “[::]:80” and failed due to unsupported address family. It means, the machine does not have an IPv6 address set.
How can I tell the script to avoid to start on IPv6?
Many thanks


[1495] Create service user for Okta -- In Test

Related Issue or Background Info
1495
This work represents the desire to have a service user for Okta which uses a service user account API tokens instead of personal user tokens. This PR is to temporarily modify the token only for the test environment, to ensure that no issues come up with the new token before moving onto different environments, by making the permanent change and exposing it to a wider variety of use cases.
A service user for Okta was created. The user has access to all environments, and largely, clones the permissions of the user our current token operates under. The user can be viewed in Okta here simplereport-developer.
The user is associated with a google group at<EMAIL_ADDRESS>All developers will be added to this google group.
Changes Proposed

Create Okta service user
Store API token in Github secrets
Modify test to use new API token

Additional Information
This method of testing, merging the PR, letting it be used, and then rolling out to other environments may be clunky. If anyone has better methods, I am all ears.
Screenshots / Demos
I have logged into test after the deploy with the new token, and have not had any issues. I view this PR as a test which allows any issues to come up.

Checklist for Author and Reviewer
UI

[ ] Any changes to the UI/UX are approved by design
[ ] Any new or updated content (e.g. error messages) are approved by design

Testing

[ ] Includes a summary of what a code reviewer should verify

Changes are Backwards Compatible

[ ] Database changes are submitted as a separate PR

[ ] Any new tables that do not contain PII are accompanied by a GRANT SELECT to the no-PHI user
[ ] Any changes to tables that have custom no-PHI views are accompanied by changes to those views
(including re-granting permission to the no-PHI user if need be)
[ ] Liquibase rollback has been tested locally using ./gradlew liquibaseRollbackSQL or liquibaseRollback
[ ] Each new changeset has a corresponding tag

[ ] GraphQL schema changes are backward compatible with older version of the front-end

Security

[ ] Changes with security implications have been approved by a security engineer (changes to  authentication, encryption, handling of PII, etc.)
[ ] Any dependencies introduced have been vetted and discussed

Cloud

[ ] DevOps team has been notified if PR requires ops support
[ ] If there are changes that cannot be tested locally, this has been deployed to our Azure test, dev, or pentest environment for verification

This PR seems fine, though I would have expected the OKTA_API_TOKEN to have been stored in KeyVault and passed to the relevant application environments via Terraform during the build as opposed to set in the GitHub environment
I am concerned though about using a Google Group for the Okta User. This seems like something that should be handled in AD using a CDC address? Let's follow up offline

Agreed on the API token - it's technically not in scope but this would be a nice improvement. As currently written we have a chicken and egg problem with the Okta API key, because the Terraform provider expects it to be defined before actually running any Terraform scripts (that would then presumably use a resource to retrieve that value). I think we could get around that by using the CLI to retrieve the secret in the GH Action before running TF.
Also agreed on the Google Group. I see why a group email is necessary, but CDC may have a solution they prefer more.

Ahh that makes sense about the Terraform provider. Thanks for the context!

I will investigate some other ways implementing a shared email for the group, hopefully the CDC has a preferred method.


Skip android API classes

I suggest get_classes method should contain features what skip android API classes.

This is somewhat implemented in the Analysis module already via this method: https://androguard.readthedocs.io/en/latest/api/androguard.core.analysis.html#androguard.core.analysis.analysis.ClassAnalysis.is_android_api

oh~ thank you


Garage mujoco import error

Hi,
On running the halfcheetah code, I get the following error:
Traceback (most recent call last):
  File "./transformer_ppo_halfcheetah.py", line 10, in <module>
    from garage.envs.mujoco.half_cheetah_vel_env import HalfCheetahVelEnv
  File "../anaconda3/envs/transformer-metarl/lib/python3.7/site-packages/garage/envs/mujoco/__init__.py", line 9, in <module>
    from garage.envs.mujoco.ant_dir import AntDirEnv
  File "../anaconda3/envs/transformer-metarl/lib/python3.7/site-packages/garage/envs/mujoco/ant_dir.py", line 5, in <module>
    from garage.envs.mujoco.ant import AntEnv
  File "../anaconda3/envs/transformer-metarl/lib/python3.7/site-packages/garage/envs/mujoco/ant.py", line 3, in <module>
    from .mujoco_env import MujocoEnv
  File "../anaconda3/envs/transformer-metarl/lib/python3.7/site-packages/garage/envs/mujoco/mujoco_env.py", line 8, in <module>
    from garage.envs.mujoco.core.serializable import Serializable
ModuleNotFoundError: No module named 'garage.envs.mujoco.core'

Could you please let me know if you have come across this and how you fixed it. Thanks!

Just a few followup questions:

Are you using garage from the local src/garage folder or the one from pip installation? Because pip installed package doesn't have garage/envs/mujoco/mujoco/core folder.
As an alternative to using garage package, I did an appropriate sys.path.append in transfomer_ppo_halfcheetah.py to use the local src/garage. But, that gives the following error:

File "./src/garage/experiment/experiment.py", line 369, in __call__
    result = self.function(ctxt, **kwargs)
  File "examples/torch/transformer_ppo_halfcheetah.py", line 148, in transformer_ppo_halfcheetah
    max_episode_length=max_episode_length)).spec
  File "./src/garage/envs/gym_env.py", line 147, in __init__
    self._render_modes = self._env.metadata['render.modes']
KeyError: 'render.modes'

I am trying to use the work as a baseline. It would be really nice if you could share your thoughts on how to setup the conda env appropriately, thanks!

@SapanaChaudhary I solved same problem by downgrading gym to 0.21.0
pip uninstall gym
pip install gym==0.21.0


different nav arrow styling on each carousel

I have like 3 carousel in one page on my website, and from that 3 carousel, it have each different bg and position styling, i wonder if i can add my own class on the button tag?

You can check this issue on how to customize the Navigation addon #17.
If you want advanced control, you can create your own custom navigation component, and use it instead of the currently shipped with the carousel. check the Navigation component source code for this. ;)


wc: perform lseek once to correct the result from count_bytes_fast path

When using stdin, its possible that the given stdin does not start from the beginning. An example,
hbina@akarin:~/git/uutils$ stat --format='%s' /etc/group
1088
hbina@akarin:~/git/uutils$ (dd ibs=2 skip=1 count=0; wc -c) < /etc/group
0+0 records in
0+0 records out
0 bytes copied, 1.4948e-05 s, 0.0 kB/s
1086
hbina@akarin:~/git/uutils$ (dd ibs=2 skip=1 count=0; cargo run -- wc -c) < /etc/group
0+0 records in
0+0 records out
0 bytes copied, 1.4948e-05 s, 0.0 kB/s
1088

See: https://github.com/uutils/coreutils/issues/3977#issuecomment-1257208684
Signed-off-by: Hanif Bin Ariffin<EMAIL_ADDRESS>

Looks excellent! Do you think you can create a test case for this?

Sure, if the testing library have something equivalent to this (dd ibs=2 skip=1 count=0; cargo run -- wc -c) < /etc/group but I have never seen one like it around here. Perhaps there's a different way to invoke this behavior?

Yeah I'm also not sure how to do this, that's why I asked :) Maybe we could call bash with that comman as input? It's very hacky but I don't really see another way.

I have no idea how to do that. Any pointers?

I guess you saw that it is failing with:
cannot subtract i64fromi32``
https://github.com/uutils/coreutils/actions/runs/3189440893/jobs/5204481975

Sorry yea, I was putting this PR on pause while I was trying to solve https://github.com/uutils/coreutils/pull/3987#issuecomment-1264348896

no worries ;)

@hbina are you planning to write a test or it is too hard?

It seems that my solution doesn't work in the context of a bash -c
hbina@akarin ~/g/uutils (hbina-wc-do-an-lseek-to-check-fast-bytes-calculation) [2]> bash -c "(dd ibs=2 skip=3 count=0; /home/hbina/git/uutils/target/debug/build/coreutils-f4f87c7d4e42b737/out/../../../wc -c) < /etc/group"
0+0 records in
0+0 records out
0 bytes copied, 1.6812e-05 s, 0.0 kB/s
mode:32768
mode:32768
1088
hbina@akarin ~/g/uutils (hbina-wc-do-an-lseek-to-check-fast-bytes-calculation)> bash -c "(dd ibs=2 skip=3 count=0; wc -c) < /etc/group"
0+0 records in
0+0 records out
0 bytes copied, 1.6051e-05 s, 0.0 kB/s
1082

Any idea why?

Seems to work for me:
$ bash -c "(dd ibs=2 skip=3 count=0; wc -c) < /etc/group"
0+0 records in
0+0 records out
0 bytes copied, 1,1655e-05 s, 0,0 kB/s
1522
$ bash -c "(dd ibs=2 skip=3 count=0; target/debug/coreutils wc -c) < /etc/group"
0+0 records in
0+0 records out
0 bytes copied, 1,4239e-05 s, 0,0 kB/s
1522

Are you sure you got the correct binary?

https://github.com/uutils/coreutils/pull/3987#issuecomment-1272508062

Yep, i got the wrong wc somehow....
Anyways, I have added a test. Hopefully it's good enough. Some of that ".last().unwrap()" weirdness can be removed if I know what options to pass to dd I think.

@tertsdiepraam the android test is failing because it can't find /etc/group. Do you know of a file that exists in all unix variants?

There's nothing special about /etc/group in this case right? I think it could just be a fixture of the tests.

Turns out we have some sample files like lorem_ipsum.txt to work with. I can't create a file in the tests, each command seems to run a separate instance.

I can't create a file in the tests, each command seems to run a separate instance.

Each test indeed runs in a tmp directory. You can access it with
let at = &scene.fixtures;

at.touch("filename");
// and
at.write("filename", "contents");

That being said, using the lorem_ipsum.txt is great!

Oh I didn't know about those! Thanks for the suggestion.

I suppose we should write some more documentation for those 😄

@hbina ping ?

I honestly don't remember at all why I removed that change. I am going through it now and I don't think it make particular sense either. So I will close this PR and hopefully someone else picks it up.


Add Mesh transformation

Objective
It can sometimes be useful to transform actual Mesh data without needing to change the Transform of an entity. For example, one might want to spawn a circle mesh facing up instead of facing Z, or to spawn a mesh slightly offset without needing child entities.
Solution
Add transform_by and transformed_by methods to Mesh. They take a Transform and apply the translation, rotation, and scale to vertex positions, and the rotation to normals and tangents.
In the load_gltf example, with this system:
fn transform(time: Res<Time>, mut q: Query<&mut Handle<Mesh>>, mut meshes: ResMut<Assets<Mesh>>) {
    let sin = 0.0025 * time.elapsed_seconds().sin();

    for mesh_handle in &mut q {
        if let Some(mesh) = meshes.get_mut(mesh_handle.clone_weak()) {
            let transform =
                Transform::from_rotation(Quat::from_rotation_y(0.75 * time.delta_seconds()))
                    .with_scale(Vec3::splat(1.0 + sin));
            mesh.transform_by(transform);
        }
    }
}

it looks like this:
https://github.com/bevyengine/bevy/assets/57632562/60432456-6d28-4d06-9c94-2f4148f5acd5

I like this, but maybe it would be better to implement this as Add and AddAssign?

Not sure, maybe? But it'd probably be Mul instead of Add. Transformations are typically represented with multiplication, e.g. transform * point is equivalent to transform.transform_point(point); you can't add or subtract transforms.
I could at least add a transformed_by method so that you could create and transform the mesh on a single line instead of having to define a mutable mesh and separately call transform_by on that

I ended up adding transformed_by and implementing Mul<Mesh> for Transform. You can now do this:
let transform = Transform::from_xyz(0.0, 2.0, 0.0);

// These are equivalent
let cuboid = Mesh::from(shape::Box::default()).transformed_by(transform);
let cuboid = transform * Mesh::from(shape::Box::default());

let mut cuboid = Mesh::from(shape::Box::default());
cuboid.transform_by(transform);

Feel free to suggest further improvements/changes to the API

Why did you implement Mul<Mesh> for Transform and not Mul<Transform> for Mesh? You could also implement MulAssign<Transform> for Mesh and be able to perform syntax like this:
let mut cuboid = Mesh::from(shape::Box::default());
cuboid *= transform;

// or

let cuboid = Mesh::from(shape::Box::default()) * transform;

For consistency. You can't do point * transform or point *= transform, so I don't see why you'd be able to do mesh * transform. Whether or not you should be able to do point * transform is a separate discussion

Here to mention that I ran into exactly this use-case (wanted a xz plane circle).
I do think the Mul<> operator not being symmetric is a bit weird, and I will most likely used the transformed_by  variant.

alternatively to avoid a division, (normal.xyz * scale.yzx * scale.zxy).normalized() (component-wise multiplication)

If any component of scale is zero it will cause a division by zero and result in infinite-length normals, maybe the division-skipping version that uses only multiplications is a better option

If any component of scale is zero it will cause a division by zero and result in infinite-length normals, maybe the division-skipping version that uses only multiplications is a better option

Won't the multiplication version similarly fail when we attempt to normalize the product? Or is .normalized implicitly "normalize or zero" behavior?

I can use normalize_or_zero for it

No, the multiplication-only version will work fine, i'm talking about only one component being zero. normalize_or_zero is unneeded

Thanks for the patience and the fixes


generateSASToken 401 error fix

[Enter feedback here]
generateSASToken function returns 401 error. Function below works correctly
private function generateSasToken($uri)
{
    $expiresInMins = 60 * 60;
    $totalSeconds = time();
    $expires = $totalSeconds + $expiresInMins;
    $toSign = rawurlencode($uri) . "\n" . $expires;

    $signature = rawurlencode(base64_encode(hash_hmac('sha256', $toSign, $this->sasKeyValue, TRUE)));

    $token = "SharedAccessSignature sr=" . rawurlencode($uri) . "&sig="
                . $signature . "&se=" . $expires . "&skn=" . $this->sasKeyName;

    return $token;
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 514b59a0-95b1-3692-bc38-73113df0b5e3
Version Independent ID: 1e143db8-a9c7-d670-e35b-ea9f84ef2efa
Content: How to use Azure Notification Hubs with PHP
Content Source: articles/notification-hubs/notification-hubs-php-push-notification-tutorial.md
Service: notification-hubs
GitHub Login: @sethmanheim
Microsoft Alias: sethm

@TF-Jonny Thanks for the feedback! We are currently investigating and will update you shortly.

@TF-Jonny Thanks for the feedback! I have assigned the issue to the content author to review further and update the document as appropriate.

@TF-Jonny Thank you for reaching out and sorry for the slow response. If this is still an issue please open a new support ticket. #please-close


AM-2902 patch to PR 1582

Jira link (if applicable)
AM-2902 "Update Refresh Job process to permit a refresh of all judicial users by jurisdiction code"
Change description
Refactor JRD call getJudicialDetailsByServiceName.

NB: This PR is a patch to #1582.

Checklist

[x] commit messages are meaningful and follow good commit message guidelines
[x] README and other documentation has been updated / added (if needed)
[x] tests have been updated / new tests has been added (if needed)
[x] Does this PR introduce a breaking change NO

This PR is being replaced by #2099.


Clear up use of ingress rules over command line

Which Cloudflare product does this pertain to?
Cloudflare One
Existing documentation URL(s)

https://developers.cloudflare.com/cloudflare-one/connections/connect-apps/do-more-with-tunnels/migrate-legacy-tunnels/

Section that requires update

After configuring DNS/LB records for each zone you want to serve, follow the Configure a Tunnel instructions to create a config file with ingress rules. The ingress rules describe how to dispatch requests to your origins based on hostname and path. For example, if you used to run:
$ cloudflared tunnel --hostname tunnel.example.com --url https://localhost:3000

You can have an equivalent ingress rule:
ingress:
  - hostname: tunnel.example.com
    service: https://localhost:3000
  - service: http_status:404
# Note that the last rule is the catch-all rule and is required.

What needs to change?
The formatting and the wording does not make it clear enough that ingress rules should be used now instead of the command line args. It implies rather that command line args can be used as a replacement.
How should it change?

After configuring DNS/LB records for each zone you want to serve, follow the Configure a Tunnel instructions to create a config file with ingress rules. The ingress rules describe how to dispatch requests to your origins based on hostname and path. For example, if in the past you used to run cloudflared tunnel --hostname tunnel.example.com --url https://localhost:3000, you need have an equivalent ingress rule now:
ingress:
  - hostname: tunnel.example.com
    service: https://localhost:3000
  - service: http_status:404
# Note that the last rule is the catch-all rule and is required.

Additional information
https://support.cloudflare.com/hc/de/requests/2492348

Thank you for the feedback. I can understand how this might be confusing. I've opened PR #5393 and we'll get this up as soon as we can. Thanks for the contribution.


Wrong intellisense overlay position in split-view

The intellisense suggestion overlay is not positioned at the cursor inside the right editor pane. This only happens in split view.

VSCode Version: 1.13.0-insider c615b43be67170e166779c9020a249442c4f36fc
OS Version: MacOS Sierra 10.12.4

Steps to Reproduce:

open vscode
split editor pane
type in the right pane

@ramya-rao-a Woa, that was quick! Thanks for having a look at it 👍

:) Thanks for reporting @marvinhagemeister.
The fix should be out in tonight's insiders.


React frontend, Node Properties Panel

Changes:

Rewrote all JavaScript into React, replacing Angular
New UI with React Bootstrap components
Node Properties Panel displays all properties of selected node in the graph
gulpfile.js is a build tool for compiling React-flavored JavaScript
README changes for developing frontend code

+1

+1

+1

+1


Condition overlays aren't always accurate

Being acute, the overlay should be fairly purple, but it isn't. This is probably a problem with updating the condition client-side.

Resolved with b1.6.0


Key discriminator/dis_FC1/Matrix not found in checkpoint

hello，when i test on my own image dataset, i meet this error~  it seems the ckpt is not same with current architecture of network.

I would test it right now.

my tensorflow version=1.7，  and the error locate at restoring model，like this:
NotFoundError (see above for traceback): Key discriminator/dis_FC1/Matrix not found in checkpoint 	 [[Node: save/RestoreV2 = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2/tensor_names, save/RestoreV2/shape_and_slices)]] 	 [[Node: save/RestoreV2/_133 = _Recv[client_terminated=false, recv_device="/job:localhost/replica:0/task:0/device:GPU:0", send_device="/job:localhost/replica:0/task:0/device:CPU:0", send_device_incarnation=1, tensor_name="edge_138_save/RestoreV2", tensor_type=DT_FLOAT, _device="/job:localhost/replica:0/task:0/device:GPU:0"]()]]

the ckpt is for self-guided encode network, not for discriminator.

It means that i have to use this model to restore self-guided encode network, and train the Generator and Discriminator on my own, then i can test images

Yes

thx！   But training speed is a little slow,. One GPU is used but i have 8 GPUs。

By the way , can you offer the trained main network model ~~

sorry, I have the changed the model but the code has not been updated.


Add tests to projects_controller#index using RSpec and FactoryBot

Description

Adds multiple integration tests to projects_controller#index.
This is the first step in a refactor of that root to move most logic to the model. Thus, the integration tests might be a more thorough then necessary if we move more logic to the model.
Added multiple factories as necessary to develop the tests.

Testing
Code changes were driven by the integration tests added.
Integration tests should be self-explanatory. Please add a note for any test that is not clear.

I'm only seeing the factories, not the tests. What am I missing?

Probably you need to expand the file. Collapsed by default for having too many changes.

I'm eager to see this PR merged. That's a really nice addition!


KYLIN-3290 Leverage getDecalredConstructor().newInstance() instead of newInstance()

Issue : https://issues.apache.org/jira/browse/KYLIN-3290
How to fix : Leverage getDecalredConstructor().newInstance() instead of newInstance()

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@dca3ee7). Click here to learn what that means.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master     #351   +/-   ##
=========================================
  Coverage          ?   23.61%
  Complexity        ?     4826
=========================================
  Files             ?     1133
  Lines             ?    68102
  Branches          ?     9659
=========================================
  Hits              ?    16080
  Misses            ?    50457
  Partials          ?     1565

Impacted Files
Coverage Δ
Complexity Δ

...va/org/apache/kylin/dict/DictionarySerializer.java
0% <0%> (ø)
0 <0> (?)

...n/java/org/apache/kylin/dict/NumberDictionary.java
22.22% <0%> (ø)
2 <0> (?)

...g/apache/kylin/query/relnode/OLAPAggregateRel.java
0% <0%> (ø)
0 <0> (?)

.../apache/kylin/dict/global/GlobalDictHDFSStore.java
70.44% <100%> (ø)
18 <0> (?)

...n/java/org/apache/kylin/common/util/ClassUtil.java
51.66% <100%> (ø)
9 <1> (?)

...va/org/apache/kylin/dict/TrieDictionaryForest.java
87.32% <100%> (ø)
62 <0> (?)

...ain/java/org/apache/kylin/dict/TrieDictionary.java
73.02% <100%> (ø)
57 <1> (?)

.../java/org/apache/kylin/dict/NumberDictionary2.java
71.42% <100%> (ø)
2 <0> (?)

...rg/apache/kylin/dict/DictionaryInfoSerializer.java
56.66% <20%> (ø)
5 <0> (?)

...n/java/org/apache/kylin/query/QueryConnection.java
83.33% <50%> (ø)
3 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca3ee7...fe29b71. Read the comment docs.


Switch to a modern reactive framework

Options:

Reactive Streams
Reactive Extensions
IAsyncEnumerable
Akka .NET

Notes:

From Reactive Extensions to Reactive Streams - Bartosz Sypytkowski

Reactive Streams

Dataflow
Reactive Streams

SourceBlock<TOutput>
IPublisher<T>

TargetBlock<TInput>
ISubscriber<T>

 IPropagatorBlock<TInput,TOutput>
IProcessor<T, U>

Push/pull
Don't seem to have picked up in .NET 🤦🏻♂

Reactive Extensions

Dataflow
Rx

SourceBlock<TOutput>
IObservable<T>

TargetBlock<TInput>
IObserver<T>

 IPropagatorBlock<TInput,TOutput>
ISubject<TSource, TResult>

DataflowBlockOptions.TaskScheduler
.ObserveOn(_: IScheduler)

Push-based (OK for client applications)
It is definitely a more modern pattern that extension developers would be more familiar with.
Documentation is outdated (MSDN and Introduction to Rx) or non-existent (ReactiveX website). It still seems to be vary much alive (code and .Net YouTube channel).
Books are available but outdated

Rx.NET in Action (Manning 2017), T. Dresher - browsable for free 5m/day, new edition in MEAP.
Reactive Programming for .NET Developers (Packt 2016), A. Esposito and M. Ciceri.
Rx.Book (2019 draft), E. Petro.
Functional Programming in C# (Manning 2017), E. Buonanno - has a chapter on "Data streams and the Reactive Extensions", second edition in MEAP due in 2021.

Reactive.UI implements MVVM using Observables.

IAsyncEnumerable

Pull-based
No documentation... does it have any API to work with it?

Akka .NET

Dataflow
Akka .NET

SourceBlock<TOutput>
Source<TOut, TMat>

TargetBlock<TInput>
Sink<TIn, TMat>

 IPropagatorBlock<TInput,TOutput>
IFlow<TOut, out TMat>

Push/pull
Less known in the community, but very powerful.

Framework Analysis
Resources:

From Reactive Extensions to Reactive Streams - Bartosz Sypytkowski

Reactive Streams

Dataflow
Reactive Streams

SourceBlock<TOutput>
IPublisher<T>

TargetBlock<TInput>
ISubscriber<T>

 IPropagatorBlock<TInput,TOutput>
IProcessor<T, U>

Push/pull
Don't seem to have picked up in .NET 🤦🏻♂

Reactive Extensions

Dataflow
Rx

SourceBlock<TOutput>
IObservable<T>

TargetBlock<TInput>
IObserver<T>

 IPropagatorBlock<TInput,TOutput>
ISubject<TSource, TResult>

DataflowBlockOptions.TaskScheduler
.ObserveOn(_: IScheduler)

Push-based (OK for client applications)
It is definitely a more modern pattern that extension developers would be more familiar with.
Documentation is outdated (MSDN and Introduction to Rx) or non-existent (ReactiveX website). It still seems to be vary much alive (code and .Net YouTube channel).
Books are available but outdated

Rx.NET in Action (Manning 2017), T. Dresher - browsable for free 5m/day, new edition in MEAP.
Reactive Programming for .NET Developers (Packt 2016), A. Esposito and M. Ciceri.
Rx.Book (2019 draft), E. Petro.
Functional Programming in C# (Manning 2017), E. Buonanno - has a chapter on "Data streams and the Reactive Extensions", second edition in MEAP due in 2021.

Reactive.UI implements MVVM using Observables.

IAsyncEnumerable

Pull-based
No documentation... does it have any API to work with it?

Akka .NET

Dataflow
Akka .NET

SourceBlock<TOutput>
Source<TOut, TMat>

TargetBlock<TInput>
Sink<TIn, TMat>

 IPropagatorBlock<TInput,TOutput>
IFlow<TOut, out TMat>

Push/pull
Less known in the community, and it not well integrated with the standard .NET libraries and frameworks
Actors provide low-level interfaces to build anything we want with a simple concurrency model
More powerful than we need


Does not return error ENOENT when program not found on Windows

Thanks for developing cross-spawn! It is disappointing that Node.js does not support this out of the box, and your package provides something of great value to those developing packages that require support for Windows.

Normally, when spawn cannot find the program to be executed it returns an error ENOENT. However, since this command is wrapped in cmd.exe it no longer does that, and instead returns an error generated by cmd.exe and has returnCode=1 and stderr in the form “command” is not recognized as an internal or external command, operable program or batch file.
My workaround was to check if returnCode equals 1 (non-zero) and if the stderr message contains similar text, such as the part: is not recognized as an internal or external command.
I am using it here for my package Atom Beautify: https://github.com/Glavin001/atom-beautify/commit/57ffe7543b6599c48fb878a6ffc89c0ca19af833
Please let me know what you think, and if I should submit a Pull Request with the workaround I described above.

Hi Glavin, thanks!
Yes I would be interested in working around it, but your approach won't work on non-english operating systems because the error message won't be in english. I'm not sure if there's another way to correctly identify the issue, perhaps it needs further investigation.

Bummer! Very good point. I'm not sure what we can do for non-English windows support. I would have hoped that it would return a more useful/unique error number than 1.
I've been using node-which to help retrieve an absolute path for executables. It supports windows as well. Maybe we could use it to resolve the command executable to an absolute path and if that fails then it indicates the same as ENOENT.
—
Sent from Mailbox
On Sun, Jun 14, 2015 at 12:34 PM, André Cruz<EMAIL_ADDRESS>wrote:

Hi Glavin, thanks!
Yes I would be interested in working around it, but your approach won't work on non-english operating systems because the error message won't be in english. I'm not sure if there's another way to correctly identify the issue, perhaps it needs further investigation.
Reply to this email directly or view it on GitHub:
https://github.com/IndigoUnited/node-cross-spawn/issues/16#issuecomment-111841497

Yea that would work. Perhaps what we should do is run the command and if error code is 1 we use which to disambiguate between a ENOENT or a real exit code of 1. What do you think?

I agree. How about if it it is both Windows and error code is 1 then it makes sense to do the check using which.
The error generated can be taken from here: https://github.com/joyent/node/blob/d13d7f74d794340ac5e126cfb4ce507fe0f803d5/deps/npm/lib/utils/spawn.js#L17-L21

Yep exactly. Can you do a PR with the implementation and tests?

For sure. I'll put it on my TODO list for over these next few days. Let me know if you have any other ideas.
—
Sent from Mailbox
On Sun, Jun 14, 2015 at 8:10 PM, André Cruz<EMAIL_ADDRESS>wrote:

Yep exactly. Can you do a PR with the implementation and tests?
Reply to this email directly or view it on GitHub:
https://github.com/IndigoUnited/node-cross-spawn/issues/16#issuecomment-111883228

Unfortunately, it looks like spawnSync does not return ENOENT error the same as spawn does.
If I log the results from spawnSync when trying to spawn not-a-program it does not contain the field for error and so does not have ENOENT error:
{ pid: 38051,
  output: [ null, <Buffer >, <Buffer > ],
  stdout: <Buffer >,
  stderr: <Buffer >,
  status: -1,
  signal: null }
undefined '' -1
      1) should give ENOENT error for program not found

Async spawn works as expected.

The problem I am realizing now is that cross-spawn really handles the rewriting of the command passed into the applicable spawn method and leaves the rest up to the method. This may not really be straightforward to implement in cross-spawn without reimplementing spawn, or at least swapping its internal EventEmitter. spawn had two EventEmitters internally which allowed it to essentially watch for ENOENT error on the close event and emit a different event to the publish EventEmitter that is available when you call spawn. My workaround was using the publically available EventEmitter, however I cannot proxy the message sent to the handlers subscribing to exit or close, like Node.js does internally with spawn.
For instance, I want to detect that the spawn ended, I would listen to exit event. We need cross-spawn to also listen for this event, however when it occurs we need to also check the code and actually control the flow of the events / change the event if applicable. See https://github.com/joyent/node/blob/d13d7f74d794340ac5e126cfb4ce507fe0f803d5/deps/npm/lib/utils/spawn.js#L13-L16 for example of what Node.js's implementation of spawn does. We could have a cross-spawn EventEmitter that acts as a proxy between the spawn's EventEmitter and therefore could actually change the error messages / flow emits if applicable, in the exact same way Node.js internal spawn does. However then this does not work for spawnSync. Which we could then implement a sync-specific solution.
Just some things I want to get your thoughts on before I continue implementing.

What we can do is rewrite the emit function to prevent exit and close to actually emit the event and trigger the process of checking if the command exists. I can do a proof of concept in a branch and we could merge your efforts of using AppVeyor.

This is fixed! Landed in 1.0.0

Awesome! Thank you for implementing this. This is great! Will be testing it out on my package soon.

@Glavin001 Let me know if its working for you. If you are interested in how I've implemented, here it is:
https://github.com/IndigoUnited/node-cross-spawn-async/blob/master/lib/enoent.js#L14
https://github.com/IndigoUnited/node-cross-spawn/blob/master/index.js#L12

Is this still an issue on current versions of Node.js? I don't see any issue in the node.js repo linked

Thanks for developing cross-spawn! It is disappointing that Node.js does not support this out of the box, and your package provides something of great value to those developing packages that require support for Windows.
Normally, when spawn cannot find the program to be executed it returns an error ENOENT. However, since this command is wrapped in cmd.exe it no longer does that, and instead returns an error generated by cmd.exe and has returnCode=1 and stderr in the form “command” is not recognized as an internal or external command, operable program or batch file.
My workaround was to check if returnCode equals 1 (non-zero) and if the stderr message contains similar text, such as the part: is not recognized as an internal or external command.
I am using it here for my package Atom Beautify: Glavin001/atom-beautify@57ffe75
Please let me know what you think, and if I should submit a Pull Request with the workaround I described above.

discord


refactor: supress some clippy lints

@yegor256 take a look, please
I've cloned the project and noticed some clippy warnings that wasn't fixed

@l3r8yJ thanks!


ApiDescription - issue in Core 3.0 project

Hi
Maybe this has been cover elsewhere before, but I'm having an issue with an ApiDescription reference in the NSwag.Generation.Processors namespace.
I'm in the process of upgrading our projects from core 2.2 to core 3.0 and have run into an issue with ApiDescription in the AspNetCoreOperationProcessorContext class.
I created a "processor" class that inherits from IOperationProcessor and it seems that the  Microsoft.AspNetCore.Mvc.ApiExplorer library is missing or incorrectly referenced.
I'm currently using 13.1.3 version of Nswag and the only way I can get past the compile error is to:
Add this the following to NSwag.Generation.AspNetCore.csporj
 <ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp3.0' ">     <PackageReference Include="Newtonsoft.Json" Version="12.0.2" />     <PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="3.0.0" />   </ItemGroup>   <ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp3.0' ">     <FrameworkReference Include="Microsoft.AspNetCore.App" />   </ItemGroup>
Add netcoreapp3.0 to the <TargetFrameworks> in NSwag.Generation.AspNetCore.csporj
If I have got this wrong please let me know.
Thanks

Encountered the same issue today. Here's how things look from Visual Studio's perspective:

I ended up using reflection to get around the issue:
    public class MyDocumentProcessor : IOperationProcessor
    {
        public bool Process(OperationProcessorContext context)
        {
            if (context is AspNetCoreOperationProcessorContext aspnetContext)
            {
                var apiDescription = (Microsoft.AspNetCore.Mvc.ApiExplorer.ApiDescription) typeof(AspNetCoreOperationProcessorContext).GetProperty("ApiDescription").GetValue(aspnetContext);
                var actionDescriptor = apiDescription.ActionDescriptor;
            }

            return true;
        }
    }

Is there another solution then adding a new target framework to NSwag.Generation.AspNetCore.csproj?


Podman runtime issues on Fedora 36

Hey there thank you for providing containerlabs! It's an awesome project but sadly the podman backend on Fedora is not working right.
Here are the problems I faced:
Image-Pull
Containerlabs can't use podman to pull images that are not in fqdn format because it runs without a tty and podman tries to open a dialogue asking where it should pull the image from.
$ grep image clab.yml
      image: networkop/cx:4.3.0
$ containerlab deploy -t clab.yml
INFO[0000] Containerlab v0.27.1 started
INFO[0000] Parsing & checking topology file: clab.yml
Error: short-name resolution enforced but cannot prompt without a TTY
$
$ grep image clab.yml
      image: docker.io/networkop/cx:4.3.0
$ containerlab deploy -t clab.yml
INFO[0000] Containerlab v0.27.1 started
INFO[0000] Parsing & checking topology file: clab.yml
Trying to pull docker.io/networkop/cx:4.3.0...
Getting image source signatures
Copying blob sha256:037bde409e95375706430fda81106acb0b6d8aedad2c6bc77bfc40779060d60e
...

Socket
Containerlabs tries to call docker.sock, but even after activating podman.socket docker.sock won't get created. You can bind mount the socket tho, but that doesn't seem like a good solution and containerlabs should instead just use the correct socket.
$ touch /var/run/docker.sock
$ mount -o bind /var/run/podman/podman.sock /var/run/docker.sock

Networking
Also networking doesn't work as expected containerlabs throws errors. That might be related to the new netawark backend?!
$ podman info --debug | grep networkBackend
  networkBackend: netavark
$ containerlab deploy -t clab.yml
INFO[0023] Creating lab directory: /root/netw/clab-cvx02
INFO[0023] Creating docker network: Name="clab", IPv4Subnet="<IP_ADDRESS>/24", IPv6Subnet="2001:172:20:20::/64", MTU="1500"
WARN[0023] failed to enable LLDP on docker bridge: open /sys/class/net/br-5e2a1b164bc5/bridge/group_fwd_mask: no such file or directory
WARN[0023] failed to disable TX checksum offloading for the br-5e2a1b164bc5 bridge interface: no such device
WARN[0023] errors during iptables rules install: missing DOCKER-USER iptables chain. See http://containerlab.dev/manual/network/#external-access
ERRO[0023] failed deploy phase for node "sw1": more than one result for network ID

Changing the backend back to CNI doesn't make it any better and throws even more errors... In any case containerlabs just hangs...
$ podman info --debug | grep networkBackend
  networkBackend: cni
$ grep "^network_backend" /etc/containers/containers.conf.d/network.conf
network_backend = "cni"
$ containerlab deploy -t clab.yml
WARN[0000] Failed to decode the keys ["network.network_backend"] from "/etc/containers/containers.conf.d/network.conf".
INFO[0000] Containerlab v0.27.1 started
INFO[0000] Parsing & checking topology file: clab.yml
INFO[0000] Creating lab directory: /root/netw/clab-cvx02
WARN[0000] failed to enable LLDP on docker bridge: open /sys/class/net/br-64227f557fd8/bridge/group_fwd_mask: no such file or directory
WARN[0000] failed to disable TX checksum offloading for the br-64227f557fd8 bridge interface: no such device
ERRO[0000] failed deploy phase for node "sw1": more than one result for network ID
^C
$

Also where the hell did it get the br-64227f557fd8 bridge name from?! If I'm not mistaken it should cni-clab0 or similar. At least that's what podman provisioned with it's default podman network cni-podman0

Hi @modzilla99
I'm so sorry about that! Roman is right indeed, I didn't update the code for v4, it is still on my list. Let me see if I can get it done in a couple of days.
As for more details,

Containerlabs can't use podman to pull images that are not in fqdn format because it runs without a tty and podman tries to open a dialogue asking where it should pull the image from.

Yeah, I don't think we can work around this limitation in clab. Podman was always designed to work with fqdn-based names (even preferring localhost/ for local ones)
It is possible to reconfigure podman to not enforce the manual choose (and iterate over the list of repos), but I'm not sure we should be reconfiguring users' systems. Probably a better approach would be just to document this.

Containerlabs tries to call docker.sock, but even after activating podman.socket docker.sock won't get created. You can bind mount the socket tho, but that doesn't seem like a good solution and containerlabs should instead just use the correct socket.
Hmm. I don't think this should be the case; I'll look into it. Thx

Networking

Yes, this is the (un)fortunate part - networking API got a decent amount of rework between v3 and v4 and became incompatible. The good news is - v4 API is better and allows us to solve some earlier issues.

Also where the hell did it get the br-64227f557fd8 bridge name from?! If I'm not mistaken it should cni-clab0 or similar.
In v3 api they didn't allow to set the bridge name, so we had to rely on podman-generated naming.

Thank you so much for the detailed report. I'll provide an update soon.

@LimeHat  as for the issue with fqdn names, can't we use the same logic we used for other runtimes?
https://github.com/srl-labs/containerlab/blob/46100ef74a702c2b73af5deba38305b0a2f335ad/utils/containers.go#L15

Hi @modzilla99 , I submitted a pr (#919) to enable podmanv4 support, will be merged soon.
I want to follow-up on your "docker.sock" comment - are you trying to use containerlab in a container? It is the only reference I see in the our code (our documentation, to be precise) to docker.sock
If not, something strange is going on.
re

@LimeHat as for the issue with fqdn names, can't we use the same logic we used for other runtimes?

Hmm. Maybe. Didn't know we had this logic built-in.
I noticed that on my centos setup, in fact, "short-name-mode = "permissive" by default. And it looks up for short names across 4 different registries: unqualified-search-registries = ["registry.fedoraproject.org", "registry.access.redhat.com", "registry.centos.org", "docker.io"]
I'll check why do we have this difference between centos & fedora. And if enforcing mode is the new normal - I can add a call to the function as you suggested.

@modzilla99 here is a beta build for you to try out fixes that @LimeHat added
With the following pull command you get a containerlab binary at your working directory. To use this downloaded binary - ./containerlab deploy.... Make sure not forget to add ./ prefix in order to use the downloaded binary and not the globally installed containerlab!
docker run --rm -v $(pwd):/workspace ghcr.io/oras-project/oras:v0.12.0 pull ghcr.io/srl-labs/clab-oci:c66b5eaf

With #919 merged we should have initial support for podman v4 and sunsetting v3
I am closing this issue with a goal to have more rectified issues around podman support in the future


Remove duplicated definitions of maven-jar-plugin

avro-parent already defines a maven-jar-plugin execution to generate the
test-jar that all others project inherit, so no need to do it again in
every module.

Thanks for cleaning this up


adding default/max DigiCert validity dates

This code fixes an issue where a certificate is being renewed and the CA has been re-configured to issue shorter lived certificates.  Today, this breaks renewal, but after this change, the certificate validity will be handled gracefully, and reduced if necessary.

Added option for DIGICERT_MAX_VALIDITY.  Fixes validity periods so that requested validity does not exceed max validity.
-If DIGICERT_MAX_VALIDITY is not set, then DIGICERT_DEFAULT_VALIDITY will be both the default and max validity.
-Created config_mock, to replace current_app.config.get() in tests
-Updated Tests

Coverage increased (+0.2%) to 59.149% when pulling 38b7d6e5e33e3a91c0fc356a60828c06d5fae7e4 on renewal_validity_01 into 4df64a87e5175331de0b17c34f97a3fcfcb5bfa9 on master.


Compilation errors report do not point to the location

Summary
When one gets a PlutusTx compilation error like
 GHC Core to PLC plugin: Error: Reference to a name which is not a local, a builtin, or an external INLINABLE function: Variable GHC.Num.Integer.integerGt#

there is no indication of the origin of the error in the original source code, and one gets a 3000+ lines long error report which is pretty much useless.
Steps to reproduce the behavior
An example contract that's failing to build can be found here but it's easy to reproduce with simpler code.
Actual Result
An example output from Plutus compilation.
out.md
Expected Result
As a PlutusTx developer, I would like the compiler to tell me where the problem is in my source code.
In this particular case, I expect something like:
Plutus compiler error in line 167, column 22:  GHC.Num.Integer.integerGt# is not a local, a builtin, or an external INLINABLE function
Possible fix: You are trying to use a literal number inside a multiway-if expression which is not supported by the Plutus compiler, please check https://plutus.readthedocs.io/en/latest/troubleshooting.html#non-inlinable-functions

Describe the approach you would take to fix this
I am not a compiler engineer and I am not aware of the details of the internals of the PlutusTx plugin, so it's very hard for me suggest an approach.
System info
OS: Mac OS X Ventura 13.6 arm64
GHC: 9.2.8
Plutus: <IP_ADDRESS>

I've tried adding GHC.ppr (GHC.getSrcSpan n) to the error message, but all it gave me was <no location info>, since if GHC attempted to print the location of the binding site of a variable that it doesn't recognize. I've tried to persuade GHC to do something with the Tickish thing, but to no avail.
I guess we'll have to wait for @michaelpj to come from his vacation for this one, since he's probably the only person who's intimately familiar with GHC internals in our team. @zliu41 or do you happen to know how to reliably get source locations out of GHC?

We should print the src spans in the context wherever we have them. But we often don't have them. Adding -g can help (it seems to add more src spans), but in general I think we can't go from an arbitrary GHC Core expression to its src span, which sucks :(

but in general I think we can't go from an arbitrary GHC Core expression to its src span, which sucks :(

So there's no way we can resolve this ticket by implementing the desired functionality? In that case, I have to close the issue as "won't do".


Address vale issues

Fix two vale issues

Cancelled CI until everything moves through, but the doc style check went through.


Environment-Waterworld

Hello, thanks for sharing code for your paper. I have a little question that could you share the code of the Waterworld environment? I can't find the code for this environment in github. Thanks!

It's not my paper. I just made a quick implementation of it.
Also, the authors reference the Waterworld environment from Gupta et al, that they use. I would reference that.


Confirm button when exiting game

If you are in a game and press the exit button, it should ask you to confirm... Especially since for computer games there is no way to get back to the game.

Added in 2555c92.


[Bug] 13 INTERNAL: Failed to parse server response when local activity has only error return parameter and returns nil

Describe the bug
When running a workflow with a local activity that has only an error return parameter, and the local activity returns nil, the web UI can't show the workflow and shows this error:
13 INTERNAL: Failed to parse server response
When using the cli to show to show the workflow history, it shows it properly.
To Reproduce
Steps to reproduce the behavior:

Run a workflow with the above conditions:

func Workflow(ctx workflow.Context, name string) (string, error) {
	ao := workflow.LocalActivityOptions{
		ScheduleToCloseTimeout: time.Minute,
		StartToCloseTimeout:    time.Minute,
	}
	ctx = workflow.WithLocalActivityOptions(ctx, ao)

	err := workflow.ExecuteLocalActivity(ctx, Activity).Get(ctx, nil)
	if err != nil {
		return "", err
	}

	return "", nil
}

func Activity(ctx context.Context) error {
	return nil
}

Go to web UI, open workflow and see the error.

Expected behavior
The workflow history should be presented in the UI
Screenshots

Browser: Chrome
Temporal Web Version: 1.7.0
Tctl Version: 1.7.0

We need to revisit the fix we made in https://github.com/temporalio/sdk-go/pull/367/files

for ref, here is the original same issue #365


[MRESOLVER-347] Ability to control conn reuse

Transport HTTP new config to not reuse connections

https://issues.apache.org/jira/browse/MRESOLVER-347

Please document the new option in https://github.com/apache/maven-resolver/blob/master/src/site/markdown/configuration.md as well

This is logically wrong and counter-productive.

This is not about Azure per se, this is feature to add "ability to not reuse connections". It may become required in some other environments, while MAY work for Azure as well (as circumvention)

@michael-o I started the discussion on the mailing list and asked if it's feasible to add some kind of configuration to resolve the problem of failing builds because the pool connection TTL is higher than the Azure limit.
From my perspective, there are four possible ways to solve it.

The user can deactivate the pooling altogether.

The user can specify the TTL.

The default TTL is set lower than Azure.

The HttpClient can detect this kind of stale connection.

would, of course, be good because the next one will not run into the problem altogether, but even then, it may be useful to be able to configure this if in a specific environment the TTL can't be longer than e.g. two minutes.

Therefore for me point 2. would be a good enough solution maybe combined with a more sensible default (= 3.) on top.

there was some fixes there https://issues.apache.org/jira/browse/WAGON-545
maybe worth to look at copy those fixes here (as the wheel has been re invented here)?

Applied changes: max TTL for connections is 10 minutes, is set on pool (for that refactored class SslConfig as it is not "just SSL" config anymore).


Allow hc::parallel_for_each to support priority.

We want to implement hipCreateStreamWithPriority. However, since all kernel launches must go through the hc:parallel_for_each syntax, this will require modification to the HC API.
Specifically, preemption capabilities at the block level for kernels with higher priority that are being executed on the GPU.

hipLaunchKernel and hipLaunchKernelGGL internally call hipModuleLaunchKernel. See https://github.com/ROCm-Developer-Tools/HIP/blob/master/src/functional_grid_launch.inl#L128. And hipModuleLaunchKernel directly constructs an aql packet and dispatches it. See https://github.com/ROCm-Developer-Tools/HIP/blob/master/src/hip_module.cpp#L203.
So HIP kernels do not use hc:parallel_for_each. So all that is required in HIP is to create a hsa queue with higher priority. In case you still need enhancements in HC API so as to enable a similar feature in HC-mode applications, please file a separate issue in the HCC repo.

Hi @mangupta, great that clears a few things. Though, I'm not sure if this approach will allow us to obtain fine grained prioritization. With the priority queue, we'd be able to prioritize the scheduling of one kernel over another, but once a kernel is dispatched, there needs to be a mechanism in place to pre-empty a lower priority kernel mid-computation (save its state) and let a higher priority kernel execute.


Fix/re add system tests

Codecov Report

Merging #146 (c762d29) into main (57cab1e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   80.96%   80.96%
=======================================
  Files          19       19
  Lines         767      767
  Branches      157      157
=======================================
  Hits          621      621
  Misses        146      146


select new admin-ui for mongodb

The rockmongo project seems dead.
website is down.
1.1.8 is only in the repo, but not on github releases.
our crawler can't pick this up.
i will not switch this to githubs archive.zip.
we need to select a new, better maintained admin interface for mongo
http://docs.mongodb.org/ecosystem/tools/administration-interfaces/#admin-uis
a php based solution would be nice.
but a binary application could fit,too. maybe robomongo?
i'm open for suggestions.

My suggestion is Robomongo - http://robomongo.org/


Add GitHub CI to Repo

This PR adds a GitHub Actions CI job for all pushes to all branches in this repo. This also adds typing from the generic typing library for backwards compatibility with previous version of Python 3.
The steps of interest of the CI particularly are:
      - name: Install Python
        uses: actions/setup-python@v2
        with:
          python-version: '3.7'
      - name: Install requirements
        run: pip install tox && pip install .
      - name: Run tests
        run: python -m unittest discover test

@idea404 Thanks!


Prototype Cassandra framework

@mesosphere-ci retest this please

@loren Have you considered adding readiness checks for Cassandra nodes, so that we only move forward with the installation when the current node JOINS the ring. The way it is currently right now, things will eventually work but will cause unnecessary noise as @verma7 points out.

@mesosphere-ci retest this please

As @verma7 @mohitsoni, have said, a readiness check will be needed to add more than one C* node at a time.
@verma7:  Please create issues for the features you need before this framework can be considered to have reached feature parity.  In particular I am interested in detailed reasons why node replacement requires the use of the replace_address instead of a replace being the removal of a node from the cluster and the addition of a new node (a policy also not implemented yet).
Finally, all the above are good valid things to work on, but I don't think they should block a PR clearly labeled as "Prototype".  A fully featured solution should not be the goal of this PR.

retest this please

@verma7 I just added the readiness check as part of this PR and verified that the task for node N+1 does not transition from PENDING to STARTING until node N is COMPLETE, based on nodetool reporting it as "UN".


[Bug] Completed activity for which cancellation was requested causes duplicate ResolveActivity activation job

Describe the bug
When a Workflow requests to cancel an Activity, Core uses TRY_CANCEL mode and immediately activates the workflow with a ResolveActivity activation where the result is canceled.
If the activity completes before it heartbeats again core will resolve the activity again, this time with result set to completed.
The node SDK will throw an error saying that there's no pending completion for that activity.
To Reproduce
Steps to reproduce the behavior:
Run the cancel-http-request workflow in the node sdk and set the activity's heartbeatTimeout to something high like 3 minutes.
Expected behavior
Core should not resend an ActivityResolve activation job.
Screenshots/Terminal ouput
Caught error while worker was running Error: No completion for taskSeq 0

Run the the test with this command:
RUN_INTEGRATION_TESTS=1 npx ava packages/test/lib/test-integration.js -m "cancel-http-request don't completeOnActivityCancellation" -T 100s

@Sushisource was this fixed by #112?

Indeed it was, thanks for the reminder.


Extension to data spreadsheet component

Extension spreadsheet component
Brief description
Teams in Data & AI require an extension to the data spreadsheet component with an expandable row (Target CPD 4.6 November release).
Details
Users want to see additional data in an expandable row of a column. Therefore we need an extension to the current spreadsheet component.
See example here:

Catalog:
collapsed:
expanded:
Data quality:
expanded:
Current existing component in PAL (Canary): https://carbon-for-ibm-products.netlify.app/?path=/story/ibm-products-components-dataspreadsheet-dataspreadsheet-canary--data-spreadsheet
General design guidance: https://pages.github.ibm.com/cdai-design/pal/components/data-spreadsheet/usage
Link to Design Link to example or existing component
Links to other materials
Design Maintainer(s)

Marion Brülls

Tasks
Before starting work on this epic, please review and complete the following.

[ ] Initial review of design/existing code

Working in Carbon for IBM Products package

[ ] Have you reviewed our
contribution guidelines?
[ ] Have you noted our
code guidelines?
[ ] Did you use the CLI to scaffold your new component?

One more team that would benefit from this extension:
Match 360:

Adding one more requirement after discussing with teams:

Selecting a column will trigger a right hand side panel to show further meta data that are relevant for a user
There is a need for Watson studio, IKC catalog, and Data quality as well.


Access to tree height after rendering

Is there a way to get the tree's height? The only way I've found is by multiplying the rowHeight with tree.visibleNodes() - but the latter is only available inside the node renderer.
I'd like to use custom scroll bars with this package.

Oh I see what you mean. You need the height of the whole list. Not the scroll container. I suppose you could do that with what you did above. The tree api is available from the parent component if you pass a ref to the Tree component.
Maybe something like this in your parent component:
const tree = useRef()
const rowHeight = 20

useLayoutEffect(() => {
  // tree.current is the same "tree" prop passed to the node renderer.

  const height = tree.current.visibleNodes() * rowHeight
}, [tree.current && tree.current.visibleNodes()])

return <Tree ref={tree} rowHeight={rowHeight} />

Ah, being able to get to the tree api from the parent element changes things!
This is how I made it work (with types), should anyone else stumble upon the same problem:
const [treeHeight, setTreeHeight] = useState(0);
const treeRef = useRef<TreeApi<any>>(null);

useLayoutEffect(() => {
    setTreeHeight(rowHeight * (treeRef.current?.visibleNodes?.length ?? 0));
}, [treeRef.current?.visibleNodes]);

return  <Tree<any> ref={treeRef} height={treeHeight} />

(The height prop on Tree is required to disable "native" scrollbar flashes. any being the tree item's props type.)
Thanks again @jameskerr, for your help and this awesome package!


Fix the pre service action configuration test

Description
Move the configuration test into a ruby_block to ensure it is ran during convergence rather than during compilation.
Issues Resolved

None

Check List

[x] All tests pass. See TESTING.md for details.
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable.

Released as: 1.0.2


Eng 2509 fix bug where the metrics plot fails to render when canceled

Describe your changes and why you are making these changes
This PR fixes a bug where we failed to render metrics when its upstream is cancelled. Specifically we fixed two issues:

ensure the get_artifact_results handler returns all metadata without the content when an artifact is cancelled.
Render canceled metric history in list but hide the graph when there's nothing to show.

To make the issue easier to surface in the future, we also added a manual QA workflow that consists of a failed op and some downstream, cancelled metrics and checks.
Related issue number (if any)
ENG-2509
Loom demo (if any)

Checklist before requesting a review

[ ] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[ ] I have performed a self-review of my code.
[ ] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[ ] If this is a new feature, I have added unit tests and integration tests.
[ ] I have run the integration tests locally and they are passing.
[ ] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[ ] All features on the UI continue to work correctly.
[ ] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@likawind, this PR seems to depend on the other PR you opened (#1049). Can you either refactor that out or change this to compare against that branch, so we can view the relevant code?

@vsreekanti thanks, it's merged now

Thanks, @likawind! Just to clarify, does this fix the potential issue where there are some valid runs and some failed runs of the metric? I've actually noticed this as well, so I want to be sure!

@vsreekanti do you mean that the same metric's states are different across runs?
I haven't verify yet but I believe so. The fixed behavior should be that, we plot all available results, and we show canceled ones in the list section

Yeah, imagine you have:

Success
Failure
Success

Does this now graph correctly? It would be great to verify just in case!

@vsreekanti this is how it looks when states are mixed, we plot any metrics that has values and show all of them in the list

Okay, that's perfect!

@vsreekanti I did find a separate issue here: https://linear.app/aqueducthq/issue/ENG-2578/fix-a-bug-where-metric-history-list-shows-failed-metrics-as-canceled


Upload on Modrinth Please

https://modrinth.com/

Thank you 😊

You are welcome :)
Interesting that you remembered this issue


[Upload]add response to onSuccess

🤔 这个 PR 的性质是？

[x] 日常 bug 修复
[ ] 新特性提交
[ ] 文档改进
[ ] 演示代码改进
[ ] 组件样式/交互改进
[ ] CI/CD 改进
[ ] 重构
[ ] 代码风格优化
[ ] 测试用例
[ ] 分支合并
[ ] 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

fix(Upload): 添加参数 response 到事件 onSuccess，单文件是对象，多文件是数组，tdesign-vue-next#1774

[ ] 本条 PR 不需要纳入 Changelog

☑ 请求合并前的自查清单
⚠ 请自检并全部勾选全部选项。⚠

[x] 文档已补充或无须补充
[x] 代码演示已提供或无须提供
[x] TypeScript 定义已补充或无须补充
[x] Changelog 已提供或无须提供

Codecov Report

Merging #1584 (3ca2ec3) into develop (492d477) will increase coverage by 4.37%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1584      +/-   ##
===========================================
+ Coverage    57.94%   62.32%   +4.37%
===========================================
  Files          407      677     +270
  Lines        15371    16167     +796
  Branches      2931     2812     -119
===========================================
+ Hits          8907    10076    +1169
+ Misses        6187     5795     -392
- Partials       277      296      +19

Impacted Files
Coverage Δ

src/range-input/range-input-popup-props.ts
25.00% <0.00%> (-75.00%)
:arrow_down:

src/grid/row-props.ts
71.42% <0.00%> (-28.58%)
:arrow_down:

src/select/util.ts
65.00% <0.00%> (-26.67%)
:arrow_down:

src/select/props.ts
54.54% <0.00%> (-20.46%)
:arrow_down:

src/affix/affix.tsx
22.72% <0.00%> (-16.34%)
:arrow_down:

src/date-picker/props.ts
53.84% <0.00%> (-16.16%)
:arrow_down:

src/upload/props.ts
58.33% <0.00%> (-13.10%)
:arrow_down:

src/date-picker/date-range-picker-props.ts
42.85% <0.00%> (-11.69%)
:arrow_down:

src/select/optionGroup.tsx
31.57% <0.00%> (-9.60%)
:arrow_down:

src/cascader/props.ts
55.55% <0.00%> (-8.74%)
:arrow_down:

... and 474 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Migration to ghc-8.0 with subhask-branch ghc-8.0

There are many things changed from subhask for ghc-7.10 to subhask-branch for ghc-8.0
i tried to compile it naively, but i run into many problems when trying to compile HLearn (Currently stuck on Distributions.hs.. with many things not properly defined, like >< as data-kind instead of type family, VectorSpace renamed to Vector and many other things i cannot solve properly without deeper knowledge).
A brief example of the errors i currently get are
src/HLearn/Models/Distributions.hs:60:12: error:
    • Could not deduce: v ~ (forall g. Monoid g => g)
      from the context: Hilbert v
        bound by the instance declaration
        at src/HLearn/Models/Distributions.hs:59:10-40
      ‘v’ is a rigid type variable bound by
        the instance declaration
        at src/HLearn/Models/Distributions.hs:59:10
      Expected type: Moments v
        Actual type: Moments (forall g. Monoid g => g)
    • In the expression: Moments zero zero zero
      In an equation for ‘zero’: zero = Moments zero zero zero
      In the instance declaration for ‘Monoid (Moments v)’
    • Relevant bindings include
        zero :: Moments v
          (bound at src/HLearn/Models/Distributions.hs:60:5)

src/HLearn/Models/Distributions.hs:71:51: error:
    • Could not deduce: Scalar v ~ Scalar (Square v)
      from the context: Hilbert v
        bound by the instance declaration
        at src/HLearn/Models/Distributions.hs:70:10-40
      Expected type: Scalar (Square v)
        Actual type: Scalar (Moments v)
      NB: ‘Scalar’ is a type function, and may not be injective
    • In the second argument of ‘(.*)’, namely ‘r’
      In the third argument of ‘Moments’, namely ‘(c .* r)’
      In the expression: Moments (r * a) (b .* r) (c .* r)
    • Relevant bindings include
        r :: Scalar (Moments v)
          (bound at src/HLearn/Models/Distributions.hs:71:22)
        c :: Square v (bound at src/HLearn/Models/Distributions.hs:71:18)
        b :: v (bound at src/HLearn/Models/Distributions.hs:71:16)
        a :: Scalar v (bound at src/HLearn/Models/Distributions.hs:71:14)
        (.*) :: Moments v -> Scalar (Moments v) -> Moments v
          (bound at src/HLearn/Models/Distributions.hs:71:5)

src/HLearn/Models/Distributions.hs:78:51: error:
    • Could not deduce: Scalar v ~ Scalar (Square v)
      from the context: Hilbert v
        bound by the instance declaration
        at src/HLearn/Models/Distributions.hs:77:10-40
      Expected type: Scalar (Square v)
        Actual type: Scalar (Moments v)
      NB: ‘Scalar’ is a type function, and may not be injective
    • In the second argument of ‘(./)’, namely ‘r’
      In the third argument of ‘Moments’, namely ‘(c ./ r)’
      In the expression: Moments (r / a) (b ./ r) (c ./ r)
    • Relevant bindings include
        r :: Scalar (Moments v)
          (bound at src/HLearn/Models/Distributions.hs:78:22)
        c :: Square v (bound at src/HLearn/Models/Distributions.hs:78:18)
        b :: v (bound at src/HLearn/Models/Distributions.hs:78:16)
        a :: Scalar v (bound at src/HLearn/Models/Distributions.hs:78:14)
        (./) :: Moments v -> Scalar (Moments v) -> Moments v
          (bound at src/HLearn/Models/Distributions.hs:78:5)

src/HLearn/Models/Distributions.hs:117:17: error:
    • Could not deduce: Scalar (Square v) ~ r
      from the context: (FiniteModule v, Hilbert v)
        bound by the instance declaration
        at src/HLearn/Models/Distributions.hs:112:10-63
      ‘r’ is a rigid type variable bound by
        a type expected by the context:
          forall r. Real r => r
        at src/HLearn/Models/Distributions.hs:117:17
      Expected type: forall r. Real r => r
        Actual type: Scalar (Square v)
    • In the second argument of ‘(*)’, namely ‘size sigma’
      In the first argument of ‘(**)’, namely ‘(2 * pi * size sigma)’
      In the first argument of ‘(*)’, namely
        ‘(2 * pi * size sigma) ** (- fromIntegral (dim v) / 2)’
    • Relevant bindings include
        v' :: v (bound at src/HLearn/Models/Distributions.hs:119:13)
        sigma :: Square v
          (bound at src/HLearn/Models/Distributions.hs:122:13)
        mu :: v (bound at src/HLearn/Models/Distributions.hs:121:13)
        v :: Elem (Normal v)
          (bound at src/HLearn/Models/Distributions.hs:116:37)
        m2 :: Square v (bound at src/HLearn/Models/Distributions.hs:116:32)
        m1 :: v (bound at src/HLearn/Models/Distributions.hs:116:29)
        (Some bindings suppressed; use -fmax-relevant-binds=N or -fno-max-relevant-binds)

src/HLearn/Models/Distributions.hs:117:67: error:
    • Could not deduce: Scalar v ~ (forall r. Real r => r)
      from the context: (FiniteModule v, Hilbert v)
        bound by the instance declaration
        at src/HLearn/Models/Distributions.hs:112:10-63
    • In the second argument of ‘(*)’, namely
        ‘(v' `vXm` reciprocal sigma) <> v'’
      In the first argument of ‘exp’, namely
        ‘((- 1 / 2) * (v' `vXm` reciprocal sigma) <> v')’
      In the second argument of ‘(*)’, namely
        ‘exp ((- 1 / 2) * (v' `vXm` reciprocal sigma) <> v')’
    • Relevant bindings include
        v' :: v (bound at src/HLearn/Models/Distributions.hs:119:13)
        sigma :: Square v
          (bound at src/HLearn/Models/Distributions.hs:122:13)
        mu :: v (bound at src/HLearn/Models/Distributions.hs:121:13)
        v :: Elem (Normal v)
          (bound at src/HLearn/Models/Distributions.hs:116:37)
        m2 :: Square v (bound at src/HLearn/Models/Distributions.hs:116:32)
        m1 :: v (bound at src/HLearn/Models/Distributions.hs:116:29)
        (Some bindings suppressed; use -fmax-relevant-binds=N or -fno-max-relevant-binds)

Are you planning on upgrading HLearn or do you want to focus on subhask for now?
Greetings,
Drezil

Thanks for the report.
I don't have immediate plans for upgrading hlearn.  I want to do it, but I have a lot of other work getting in the way.  I'm not sure when I'll get around to it.


Update CRDB image tags

Updates versions from 2.0.0 to 2.0.4

Obviated by https://github.com/helm/charts/pull/7176. This should be closed now.
/close


Circle CI tag in readme is broken

Context

https://circleci.com/gh/MagicHQ/magic-js
Circle CI is broken

We recently renamed the GitHub organization from MagicHQ to MagicLabs, which explains this. I'll make sure it's resolved before the next release 😃


Delombok

The Lombok on a such small codebase is not so helpful but makes build process more complicated.
The code reporting tools like Checkstyle and Spotbugs seems to report lines incorrectly.
I upgraded the Checkstyle to latest version that works on Java 8. Also the Spotbugs may be upgraded but... it then reports even more warnings that breaks a build.

OK - but the pipeline is failing with check style issues


image-based gadgets: introduce map iterators

Map iterators are the base of (most) toppers and profilers. Gadgets write data into maps that are regularly fetched (and emptied) into data sources.
Follow-up PRs will be

support for toppers
support for profilers
export from those maps directly to otel-metrics

In addition to the map iterators, this PR also adds the features shared by those follow-up PRs:

perform a clear screen before outputting data from the CLI operator if the cli.clear-screen-before annotation is present on the data source
add a none output mode to the CLI operator, that is basically ignoring the data
helpers to get per-datasource values from params

Thanks for the reviews! I will merge now and we can continue to optimize further with the follow-up PRs.


Close issues where author did not respond

Can we automate with GH actions?
https://github.com/probot/no-response
@Borda what do you think about this?

so you mean something else then stale?
stale gives warning after N days inactive and closes after another D days >> issue/PR is closed after N+D days
Do you want if an issue is marked as wait on author close it after D days or another custom delay?

Yes, exactly.

Hey, any updates there ?


no such option: interface_driver

Hi Emilien Macchi,
the config "interface_driver" has been moved away to neutron.agent.common.config.py
So it causes NoSuchOptError.
Can you update your script?
2015-08-05 18:44:11.701 949 CRITICAL l3healthcheck [req-8529f2e6-dbc6-4753-9d02-537c55411c3a  None] no such option: interface_driver 2015-08-05 18:44:11.701 949 TRACE l3healthcheck Traceback (most recent call last): 2015-08-05 18:44:11.701 949 TRACE l3healthcheck   File "/usr/bin/neutron-l3-healthcheck", line 338, in <module> 2015-08-05 18:44:11.701 949 TRACE l3healthcheck     main() 2015-08-05 18:44:11.701 949 TRACE l3healthcheck   File "/usr/bin/neutron-l3-healthcheck", line 323, in main 2015-08-05 18:44:11.701 949 TRACE l3healthcheck     server = L3healthcheck(socket.gethostname()) 2015-08-05 18:44:11.701 949 TRACE l3healthcheck   File "/usr/bin/neutron-l3-healthcheck", line 307, in __init__ 2015-08-05 18:44:11.701 949 TRACE l3healthcheck     self.manager = L3healthcheckManager(host) 2015-08-05 18:44:11.701 949 TRACE l3healthcheck   File "/usr/bin/neutron-l3-healthcheck", line 259, in __init__ 2015-08-05 18:44:11.701 949 TRACE l3healthcheck     self.l3_hc_agent = L3HealthcheckAgent(host) 2015-08-05 18:44:11.701 949 TRACE l3healthcheck   File "/usr/bin/neutron-l3-healthcheck", line 111, in __init__ 2015-08-05 18:44:11.701 949 TRACE l3healthcheck     if not self.conf.interface_driver: 2015-08-05 18:44:11.701 949 TRACE l3healthcheck   File "/usr/lib/python2.7/dist-packages/oslo/config/cfg.py", line 1648, in __getattr__ 2015-08-05 18:44:11.701 949 TRACE l3healthcheck     raise NoSuchOptError(name) 2015-08-05 18:44:11.701 949 TRACE l3healthcheck NoSuchOptError: no such option: interface_driver

It might be related to https://github.com/redhat-cip/neutron-l3-healthcheck/pull/3 - can you confirm?

yes, thank you


Test mmbenchv1.1

how to test mmbenchv1.1?

Hi, @ZhaoyangLi-nju ,
We recommend you to adopt VLMEvalKit: https://github.com/open-compass/VLMEvalKit to evaluate mmbench v1.1. You need to first clone the repo and install it locally.
Usage: https://github.com/open-compass/VLMEvalKit/blob/main/docs/en/Quickstart.md
# Multi-GPU
torchrun --nproc-per-node={N_PROC} run.py --data {DATASET_NAME} --model {MODEL_NAME}
# Single-GPU
python run.py --data {DATASET_NAME} --model {MODEL_NAME}

For MMBench v1.1, the corresponding dataset names are:

MMBench_DEV_EN_V11
MMBench_DEV_CN_V11
MMBench_TEST_EN_V11
MMBench_TEST_CN_V11

For test splits, you need to submit the prediction files to our evaluation service: https://mmbench.opencompass.org.cn/mmbench-submission to get the final scores.


Error migration file to S3.

I am not sure what's the problem, below is my error log:
14 verbose stack Exit status 1
14 verbose stack     at EventEmitter. (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:255:16)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at EventEmitter.emit (events.js:191:7)
14 verbose stack     at ChildProcess. (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:40:14)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at ChildProcess.emit (events.js:191:7)
14 verbose stack     at maybeClose (internal/child_process.js:877:16)
14 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
15 verbose pkgid<EMAIL_ADDRESS>16 verbose cwd /b01_backend/parse/parse-files-utils
17 error Darwin 15.6.0
18 error argv "/usr/local/Cellar/node/6.6.0/bin/node" "/usr/local/bin/npm" "start" "config.js"
19 error node v6.6.0
20 error npm  v3.10.7
21 error code ELIFECYCLE
22 error<EMAIL_ADDRESS>start: node index.js "config.js"
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>start script 'node index.js "config.js"'.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the parse-files-utils package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error     node index.js "config.js"
23 error You can get information on how to open an issue for this project with:
23 error     npm bugs parse-files-utils
23 error Or if that isn't available, you can get their info via:
23 error     npm owner ls parse-files-utils
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]

there's insufficient info here and its ver old.  going to close.   if this is still an issue, please re-open.


Add Authentication For Providers Like Github

In yard.yaml each remote should accept an auth: field. This would likely be provided through an env var https://github.com/mcmah309/containeryard/issues/1

No longer needed since the local git instance is used.


Container reachability & skaffold / kind support

This PR brings the following changes:

Adds skaffold support;
Fixes #7 with an updated README to use the docker bridge network.

@bussyjd did a little change to the README, the stack works as expected but the web client is missing from the kubernetes.deployment.yaml file. Running it separately kind of defies the purpose of rolling out the whole stack in one command, can we fix? Domo arigato!

Following a quick chat with @bussyjd, we'll add support for skaffold deployment of the frontend in a separate PR.


Exclusively use scipy.stats

Just use the functions from SciPy. Don't convert them to Q(), even though that's an engineering nomenclature.
https://docs.scipy.org/doc/scipy/reference/stats.html

With the exception of Q() and Qinv(), I've already done this.