Cache style attribute to prevent needless update

I'm not sure how much this really helps. If an object is defined in-line, then it will be different each time. I'm assuming that if you are setting style via a string, the browser probably won't do anything if it is the same (and you should probably use statics anyway).

Seems like a very good change to me. I don't think assuming browsers are smart about avoiding work is a valid assumption here in the general case.

Doing informal testing on this page:
var body = document.body;
var value = 'background-color: red;';
var attrs = { style: value };

console.time('set same cssText');
for (var i = 0; i < 1000; i++) {
  body.style.cssText = value;
}
console.timeEnd('set same cssText');

console.time('test cssText');
for (var i = 0; i < 100; i++) {
  if (value !== body.style.cssText) {
    body.style.cssText = value;
  }
}
console.timeEnd('test cssText');

console.time('test attrs');
for (var i = 0; i < 100; i++) {
  if (value !== attrs.style) {
    body.style.cssText = value;
  }
}
console.timeEnd('test attrs');

# Chrome
set same cssText: 3.227ms
test cssText: 0.268ms
test attrs: 0.133ms

# Firefox
set same cssText: 4.58ms
test cssText: 0.53ms
test attrs: 0.31ms

I wish jsPerf were still alive...

jsPerf is back from the dead! http://jsperf.com/set-csstext-vs-test-and-set

Perhaps we could only cache in the string case. I don't want to cache in the object case as we would be holding on to an otherwise dead object. This would prevent the object from being reclaimed by the incremental garbage collector.

Updated.

I implemented your original change in #71, as it made sense to do so. We already cache objects in the attributes array (which is unfortunate), so it doesn't hurt any more to do it here too.

We already cache objects in the attributes array (which is unfortunate), so it doesn't hurt any more to do it here too.

Actually, on thinking about after you told me to only cache the cssText string, it makes sense to not cache the object. I imagine putting objects on normal properties is to grab them in some later function, and switch on behavior:
patch(container, function() {
  el = elementVoid('div', null, null, ['prop', obj]);
});

// later
if (el.prop.data) {
  // something
}

These objects don't change the element itself. But a style object does:
var styles = { color: 'red' };
patch(container, function() {
  el = elementVoid('div', null, null, ['style', styles]);
});
// el's text color is red.

// later
styles.color = 'black';
styles.backgroundColor = 'yellow';
patch(container, function() {
  el = elementVoid('div', null, null, ['style', styles]);
});
// el's styles haven't been updated.

I would expect the second patch to update the elements styles, even though the same styles object was used.

Implemented as a result of #71


Add support for && and || operators in the expressions

Hi. First of all, I want to thank you for this project, I really like the idea of a tool that's somewhere in-between Dapper and EntityFramework :)
But currently, it's possible to make queries only out of very simple expressions (e.g. no conditional statements).
I'd like to have this code working:
 await _repo.SearchAsync<MyEntity>(s => s.Prop1 == 3 && s.Prop2 == "test");

But it says "System.NotSupportedException: Operation: Expression 'AndAlso' is currently not supported."
Any plans for adding such functionality in the future?
UPD. I'm testing it on .net core 3.0, RepoDb.Mysql

RepoDb had thorough support on query tree expression.
See the codes here at 54. That address your concern, or, let me check this.

Also, the codes here mimics yours.
Btw, would you be able to share your model?
I tested this one using the codes below and it works.
[TestMethod]
public void TestMySqlConnectionQueryAsyncViaExpression()
{
	// Setup
	var table = Database.CreateCompleteTables(1).First();

	using (var connection = new MySqlConnection(Database.ConnectionString))
	{
		// Act
		var result = connection.QueryAsync<CompleteTable>(e => e.ColumnInt == 0 &&
			e.ColumnVarchar == "Test").Result.FirstOrDefault();

		// Assert
		Helper.AssertPropertiesEquality(table, result);
	}
}

I would assume that you are using the underlying method QueryAsync for your SearchAsync.

Thanks for the fast reply.
Yes, I'm using QueryAsync method like this:
public async Task<List<TEntity>> SearchAsync<TEntity>(Expression<Func<TEntity, bool>> expression) where TEntity : class
        {
            using var connection = _connectionFactory.GetConnection();
            return (await connection.QueryAsync(expression)).ToList();
        }

I was not fully precise when I provided an example of expression. In my case it also contains negation of a bool property:
await _repo.SearchAsync<MyEntity>(s => s.Prop1 == prop1 && !s.Prop2)

Without ! it works just fine.

Great, I have to look at this then. This is a UnaryExpression then I could not say that why RepoDb fails to it. I have to debug it first.
Thank you for this and will definitely will get back to you.
But as an alternative fix, you can use the code below.
await _repo.SearchAsync<MyEntity>(s => s.Prop1 == prop1 && s.Prop2 == false);

By the way, always use the AsList() method over ToList() method. It cast things if it is castable, that is much more faster when converting each item ;)

Just verified this one and this is a bug. It is very easy to replicate.

Thank you for this bug report.

The fix is available at RepoDb.Core (v1.10.11).


CI on PR test

Coverage increased (+0.3%) to 88.098% when pulling 24152f03642faed08c6ad0e7b95fd6f62533b3cc on hirotomo-moriwaki:develop into 17d9e97da585e1352f2d7dce78040da1b6c56270 on mordred-descriptor:develop.

done


fix(@angular-devkit/core): project extension warning message should identify concerned project

PR Checklist
Please check to confirm your PR fulfills the following requirements:

[ x ] The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
When logging invalid project extensions, the project name is identified to make it easier to determine which project is malformed in a large workspace
Does this PR introduce a breaking change?

[ ] Yes
[ x ] No

Other information

Formatted and updated language per CI failure + @JoostK's suggestion. Thanks!


Jupyter Notebook does not execute !python or %run in the selected conda environment.

VSCode Version: 1.53.0
OS Version: macOS 10.15.7

Steps to Reproduce:

Open Jupyter notebook in VS Code.  Select a kernel with a Conda environment with a package that isn't in the base env.
Run a .py script using ! python <name>.py or %run <name>.py that imports a package in the selected conda environment.

The attached image shows a Jupyter Notebook that worked fine yesterday before VS Code updated to 1.53.0 from the previous version.

Does this issue occur when all extensions are disabled?: Yes/No
Not sure.

After submitting the above issue I deleted VS Code by opening my Mac Applications folder, right clicking on VS Code, selecting Move to Trash.  I then downloaded VS Code 1.52.1 from here, unzipped the download, dragged VS Code back to my Applications folder.  Opened VS Code and the Jupyter Notebook displayed above, re-ran the cells and NO ERROR!  There is an issue with 1.53.0!

Ok, so it seems fixed, thus closing.
fyi @rebornix for notebooks

LOL!  No, 1.53.0 is not "fixed".  I reverted from 1.53.0 back to 1.52.1.  I hoped reporting this would 1) rule out various potential causes for what I have reported is broken in 1.53.0 and 2) help others know a solution since version 1.53.0 cost me hours of troubleshooting effort yesterday.  My report does NOT justify closing this issue.

File against python extension please https://github.com/microsoft/vscode-python
Thanks!

https://github.com/microsoft/vscode-python/issues/15327


Proposed exports

For Nota, I have implemented a new syntax as a Markdown extension using the interface in @lezer-parser/markdown: https://github.com/nota-lang/nota/blob/markdown/packages/nota-syntax/lib/parse.ts
Everything worked quite well -- great job on the flexible API design! But I ran into a few cases where I needed functionality that's currently private to markdown.ts. I'd like to show what those cases are, and in turn propose they be exported.

Type should be exported from index.ts: I need Type in order to post-process the Markdown AST. However, although Type is exported from markdown.ts, it's not accessible through the module root. My bundler can't seem to resolve import "@lezer/markdown/dist/markdown" so it's not easy for me to import it from the file directly.
BlockResult should be exported: this type appears in a public interface (BlockParser.parse), so it would be nice to name it directly.
InlineContext constructor should be exported: similar to the problems described in #6, I had issues dealing with relative vs. global indexes inside block parsers. My solution was to just construct an InlineContext for a given line, use absolute indexes everywhere, and then let the context methods handle the translation to relative indexes for me. But this strategy requires access to the InlineContext constructor, which isn't exported.

If you're ok with any of these, let me know and I will put up a pull request.

Since Type only covers a part of the node types in an extended parser, and the library provides separate vocabulary for defining node types, I intentionally kept that enum out of the public interface. You can construct something like it, for a specific parser, by iterating through parser.nodeSet.types and building up an object. Or, if you want to refer to node types statically, use their names. Does that help?

BlockResult should be exported:

It's boolean | null, which is only a few characters more than the name. What is gained by exporting this?

My solution was to just construct an InlineContext for a given line

There's a bunch of other internal stuff that would probably have to be exposed for this (such as resolveMarkers) and I'm not sure I want to complicate the public interface for this rather specific use. What kind of block are you defining here, and where do the problems with relative/absolute indices come from?

The code you linked seems to have already moved in the meantime.
In any case, I can see the use for an abstraction to help here, but simply exporting the InlineContext constructor feels dodgy—that does a bunch of things that don't make sense for a task like this. Maybe we should split off a superclass of InlineContext that just does the position-offsetting and element-building, and export that instead? Not too sure about the name, though. Maybe InputWindow or something.

I actually would also like to see the Type enum exported as well. When dealing with the syntax tree, I find that I frequently am checking if a certain node is a certain type. Although yes I can clearly do node.type.name === 'StrongEmphasis', I think it would be much nicer from a dev perspective to be able to do node.type.name === MarkdownType.StrongEmphasis.
In general, I find enums much better to use in this case, as they are a better guarantee of forwards compatibility and they improve discoverability. Although of course I can just make my own version of the enum, this enum would become outdated if a new node type was ever added to lezer-parser/markdown.


Get attributes of webelement / get xPath (or CSS selector)

Hi Florent,
New question. Is there a way to get all the attributes of a webelement?
If I dimension e as Webelement I can check the attributes: IsDisplayed, IsEnabled, IsSelected, tagname
within the control pane.
Of course, I can retrieve attributes with e.attribute, but I need to name the attribute.
I'm trying to help my users with creating an xpath / css selector. So if there is a way to retrieve an xpath location or css from the webelement, that's even better. (as input to locate the elements:)
Funcion getElements(searchString as String)
dim e as Webelement
dim driver as Webdriver
For each e in driver.FindElementsByXPath("//*[contains(text(),'" & searchString & "')]")
listbox1.add e.text '&  "  " & e.xpath
Next
Thanks!

New question. Is there a way to get all the attributes of a webelement?

Yes, here is an example:
Const JS_LIST_ATTRIBUTES As String = _
  "var d={}, a=this.attributes;  " & _
  "for(var i=0; i<a.length; i++) " & _
  "  d[a[i].name]=a[i].value;    " & _
  "return d;                     "

Sub ListAttributes()
  Dim driver As New FirefoxDriver
  driver.Get "https://en.wikipedia.org/wiki/Main_Page"
  Set elt = driver.FindElementById("mw-content-text")
  Set atts = elt.ExecuteScript(JS_LIST_ATTRIBUTES)
  For Each att In atts
    Debug.Print att.Key & "  " & att.Value
  Next
  driver.Quit
End Sub

I'm trying to help my users with creating an xpath / css selector. So if there is a way to retrieve an xpath location or css from the webelement, that's even better. (as input to locate the elements:)

The only way I know is by running some JavaScript:
Const JS_BUILD_CSS As String = _
  "var e=this,p=[],h=function(a,s){if(!a||!s)return 0;for(var i=0,l=a.length;i<l;i" & _
  "++){if(s.indexOf(a[i])==-1)return 0};return 1;};for(;e&&e.nodeType==1;e=e.paren" & _
  "tNode){if(e.id){p.unshift('#'+e.id);break;}var i=1,u=1,t=e.localName,c=e.classN" & _
  "ame&&e.className.split(/[\s,]+/g);for(var s=e.previousSibling;s;s=s.previousSib" & _
  "ling){if(s.nodeType!=10&&s.nodeName==e.nodeName){if(h(c,s.className))c=null;u=0" & _
  ";++i;}}for(var s=e.nextSibling;s;s=s.nextSibling){if(s.nodeName==e.nodeName){if" & _
  "(h(c,s.className))c=null;u=0;}}p.unshift(u?t:(t+(c?'.'+c.join('.'):':nth-child(" & _
  "'+i+')')));}return p.join(' > ');"

Const JS_BUILD_XPATH As String = _
  "var e=this,p=[];for(;e&&e.nodeType==1;e=e.parentNode){if(e.id){p.unshift('*[@id" & _
  "=\''+e.id+'\']');break;}var i=1,u=1,t=e.localName,c=e.className;for(var s=e.pre" & _
  "viousSibling;s;s=s.previousSibling){if(s.nodeType!=10&&s.nodeName==e.nodeName){" & _
  "if(c==s.className)c=null;u=0;++i;}}for(var s=e.nextSibling;s;s=s.nextSibling){i" & _
  "f(s.nodeName==e.nodeName){if(c==s.className)c=null;u=0;}}p.unshift(u?t:(t+(c?'[" & _
  "@class=\''+c+'\']':'['+i+']')));}return '//'+p.join('/');"

Sub BuildLocators()
  Dim driver As New FirefoxDriver
  driver.Get "https://en.wikipedia.org/wiki/Main_Page"

  Set elements = driver.FindElementsByCss(".hlist")

  Set list_css = elements.ExecuteScript(JS_BUILD_CSS)
  For Each txt In list_css
    Debug.Print txt
  Next

  Set list_xpath = elements.ExecuteScript(JS_BUILD_XPATH)
  For Each txt In list_xpath
    Debug.Print txt
  Next

  driver.Quit
End Sub

A better way would be to use the browser inspector to copy the selector.
You could also use a plugin:
https://chrome.google.com/webstore/search/selector?_category=extensions
https://addons.mozilla.org/fr/firefox/addon/firepath/?src=search


Fix PGO Pipeline

The existing PGO versioning logic hit an issue at the start of this year, since it used a YYMMDDhhmm format for part of the version of the nuget package which hit an overflow issue once the year became "22".
This is primarily a port of the corresponding fix from WinUI3.

/azp run

/azp run


Fish shell: The placeholder {} does not escape backslashes

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux
[x] Mac OS X

Shell

[x] fish

Problem / Steps to reproduce
echo "test\\" | fzf --preview 'echo {} | less'

This effectively produces something along
echo 'test\' | less

fish supports escaping single quotes, the other shells don't. Therefore, fish exits with

Unexpected end of string, quotes are not balanced

Unfortunately this means backslashes have to be escaped for fish only (unless other shells are known to support backslash escapes in single quotes).

I tried to fix the issue by applying a different escaping rule when $SHELL is set to fish. Let me know if it doesn't help.


Add set command and add get info by display name

Closes #35
You can set your display name with .set name 😸:angery:🥰:shibthumbsup: and your languages with .set languages 🇹🇼🇹🇼🇹🇼
Info now also shows an @ mention (without pinging) of the user and their languages
Since display names will be in the leaderboard, it makes sense to be able to search for user info by them. We could also include @ mentions in the leaderboard, but I feel like this defeats the purpose of setting your own display name

Codecov Report
Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (b0d8adb) 89.93% compared to head (49567d7) 88.54%.

Files
Patch %
Lines

src/word_debt_bot/game/core.py
60.00%
6 Missing :warning:

src/word_debt_bot/cogs/game_commands.py
80.76%
5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #45      +/-   ##
==========================================
- Coverage   89.93%   88.54%   -1.39%
==========================================
  Files          10       10
  Lines         318      358      +40
==========================================
+ Hits          286      317      +31
- Misses         32       41       +9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Addressed feedback


Add link checker to the to-do-board

Short description

This PR adds an AJAX call for the link checker row on our To-Do-Board in order to hopefully increase the loading times so we can enable the row on our system.
Proposed changes

Add an AJAX call for the broken link context
Add additional optional properties to the HTML template

Side effects

The loading times were normal for 1200+ pages in one region (but only 7 regions and not a lot of pages in the other regions). Is there a way to test this more reliably before merging it and testing it on the test system?

Resolved issues

Fixes: #2824

Pull Request Review Guidelines

The loading times were normal for 1200+ pages

Unfortunately the performance problems on the production server are caused by the many page translations (mostly old versions)

Is there a way to test this more reliably before merging it and testing it on the test system?

Yes, you can load a database dump onto the test system to test it with realistic data. We still need to create proper documentation for how to do that, but for now you can take a look here: https://github.com/digitalfabrik/integreat-cms/pull/2832#issuecomment-2182293775
I have shared a dump on the nextcloud with you.
I did some tests with the database dump on this pr, and unfortunately, for münchen it takes over a minute to load on my pc. Maybe it makes sense to wait for #2832?

Maybe it makes sense to wait for https://github.com/digitalfabrik/integreat-cms/pull/2832

Sure, makes sense :)

@david-venhoff I rebased to develop now. Could you please check, if the loading times have improved? If not, I will talk to @osmers about it :)

@deen13 Thank you for your review. The suggested changes should be implemented now :) Could you please review this PR again? :)


New protocol for displaying Siesta related UI to the user

I have a bug in my code (not Siesta!) where I am not properly handling all the cases that a ResourceEvent can return, and it got me to thinking.  Since I'm using this code to show and hide a spinner, and potentially an error result, I looked at ResourceStatusOverlay, which is doing almost the same thing.  However, I want to use the spinner that the rest of my app uses, which takes care of its own rotation and other view related issues, and I want any errors to use a different class.
It seems like the proper thing to do is to split ResourceStatusOverlay into a protocol and implementing class.  The protocol would have default implementations for the Siesta specific methods, leaving the display-related methods for a class to implement.  Do you think this is the right approach, @pcantrell?

Belated reply: yes, I like this idea, and have thought along similar lines in the past but never did anything about it.
One could split out just the logic pieces — i.e. no UIKit dependencies, but just observedResources, displayPriority and friends — and then have a protocol with showLoading etc. that ResourceStatusOverlay (and custom resource state indicator views) would implement. Is that more or less what you're thinking?
I haven't thought much beyond what I typed above. If you want to investigate and take a crack at it, go for it!


Mavlink mission sync + MissionFeasibilityChecker

I was looking at moving MissionFeasibilityChecker to a lib so that it could also be used during mavlink mission sync. There are a few things that would have to change (the way it handles geofence), but it looks doable.
Any comments/suggestions/objections before I try?

Doesn't the checker run as soon as a new mission is loaded? Couldn't the _mission part in the navigator run the checker when it doesn't run using the on_inactive() call?

@julianoes it does, but by that time the mavlink handler has already positively acknowledged the mission upload to the ground station. The proposed change allows the mavlink module to negatively acknowledge the mission upload if it fails feasibility checks which will allow for a more predictable UX on the ground station.

@NaterGator Hm good point! Ok, in that case I can see a clear benefit of converting the checker to a lib call.

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 30 days. Feel free to reopen this issue if you deem it appropriate.
(This is an automated comment from GitMate.io.)


[firebase_admob] AdView not destroy on page navigation

I'm trying to dispose adview while navigating to a video player page.
I used
_bannerAd?.dispose();
_bannerAd = null;

to destroy the davies but the ad is still shown on the new page. I discovered that using Navigator.pop before Navigator.push solve the issue but i don't want to pop the previous page.

I can't seem to find a way around this too

I use myBanner.dipose() method before calling Navigator...push and it works fine.
class AdMob {
static void closeBanner(){
if(myBanner != null){
myBanner.dispose();
myBanner = null;
}
}
}
AdMob.closeBanner();
Navigator.of(context).push(MaterialPageRoute(builder....));

thank you @d-apps ! @Seedorf161 did it help?

Hi @Seedorf161
for what I can see the issue is related to a FlutterFire plugin,
please open the issue in the dedicated github.
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
thank you


Add Marketplace call

Work
Adds Marketplace to client.
Code snippet
client.marketplace
# => {"id"=>"c298d7ea-ea8c-486e-95d9-1e45ae3787ab", "name"=>"test", "short_name"=>nil, "color_1"=>nil, "color_2"=>nil, "color_3"=>nil, "color_4"=>nil, "color_5"=>nil, "website"=>nil, "payment_frequency"=>"weekly", "alt_marketplace_id"=>nil, "state"=>"pending", "logo"=>nil, "active"=>true, "alt_marketplace_auth"=>nil, "currency"=>"AUD", ...}

Coverage decreased (-0.001%) to 99.06% when pulling 51b241dad5178073db407cf53143a9c2fc6905b0 on marketplace into f600bb8f79ffe4380953b6f16095d579e37a75fa on master.

Coverage remained the same at 99.5% when pulling 9a9794e29c170fbf9bbc8c561523b579abb6ddb1 on marketplace into 0ecb433afcd5bf5c451020c7c5a9021559ec65e8 on master.

@romsssss Merge conflict again. Haha. Let me know when you've rebased master to this branch. I'll make the release afterwards. Thanks!

Merging this in now. Thanks for the good work.


UIStoryboard mainStoryboard extensions

This pull request adds a mainStoryboard property to UIStoryboard.
I was not sure whether it was best to add it to ez or as a separate extension, but an extension feels more logical.
I also added it to the readme.

Thanks 👍

https://github.com/goktugyil/EZSwiftExtensions/commit/43baca094374fe225146e09098ea0392c658fe54
https://github.com/goktugyil/EZSwiftExtensions/commit/ee9704060a98857ec5044afbfcbeb1e82c13ff27
Fixed some file reference stuff


Add test for group by with select alias

Related to #1437

This looks good to merge

Looks good to me. Thanks for rebasing the branch, Timo.


Fix to respect font-family in host config

Defect
We had a wrong condition check on when to fall back to default value for font-family. As a result we ignore the font family given in the host config.
Fix
Corrected the condition check to respect host config or fall back to default.
Tests
Using iOS Visualizer, verify that font changes per host config.

Thanks!


Paste .env file content (making coolify even cooler)

Here is a general thing that I love to address, make UI even better. Generally speaking UI helps a lot when it comes to configuring complicated setups. But they also get in the way and sometimes its the smallest things that does the trick. For instance, configuring env variables.

While it makes complete sense it still is a tedious work to update this. Consider the flow. You probably already have an .env file (at least I hope you do) and now you need to put all the values into this. It would actually be easier to enter all if we could paste the content of the file instead and leave it at that.
Or even better, paste in the .env and parse it to fields.
Even allow to repeat and update existing.
Step two allow to enable / disable visability for build time

I can work on this @andrasbacsai
Is that okay with you?

Sure! Thank you! 🙏
I imagine it as a simple textarea and with a function that parses and adds it as secrets.

If I remember correct, the current UI does not allow for changing visibility for build on previously added rows. If so, then I suggest allowing to change that at any time.


Enable ScheduleDaemonSetPods featuregate by default for v1.11

What this PR does / why we need it:
For < 1.12 shoot clusters the daemon set pods are not scheduled by the kube-scheduler but by the kube-controller-manager. This can lead to situations where pods with a high priority cannot be started properly. This PR adds ScheduleDaemonSetPods by default for  v1.11 clusters.
Which issue(s) this PR fixes:
Fixes #2076
Release note:

ScheduleDaemonSetPods feature gate is now enabled by default for 1.11 clusters to ensure correct scheduling of system-critical-pods

/hold, identified further issues when the feature gate is enabled that need to be investigated first.

@zanetworker we have seen for a 1.11.10 cluster having this feature gate enabled that the kube-scheduler does not schedule the DaemonSet pods for newly created nodes with the reasoning "node not ready". However, for the node to get ready the DaemonSet pods for kube-proxy + calico need to be installed (both running in host network). But as the kube-scheduler does not schedule them the node can never get ready.

Closing this PR based on our discussion.
For 1.10 and 1.11 clusters enabling this feature-gate won't help much as the kube-scheduler takes node readiness into consideration  and fails to schedule Networking pods (e.g., Calico) which will result in a broken setup due to FailedPlacement.  As a result, we recommend upgrading to higher versions of kubernetes for clusters with these issues where the feature-gate is enabled by default.


ISPN-5208 Segments in topologies should always have at least 1 owner

https://issues.jboss.org/browse/ISPN-5208

@galderz Tested. The exceptions no longer appear on client.

Pushed, thanks Galder


implemented 4x4 matrix multiplication using NEON intrinsics

same as the other PR, each PR should be self-contained and not depend on another. You include the file but not the changes required in the Makefile in order to build it.

Didn't change the B[N][N] to *B[N] because I get segmentation fault from the transposing function. Have tried other ways to fix it, but I couldn't.


I have a question about PEM_read_RSAPrivateKey.

    FILE* pubfp = fopen("public.pem", "rb");
    FILE* privfp = fopen("private.pem", "rb");
    RSA *rsa_priv, *rsa_priv_read;
    RSA *rsa_pub, *rsa_pub_read;
    rsa_pub = RSA_new();
    rsa_priv = RSA_new();
    rsa_priv_read = PEM_read_RSAPrivateKey(privfp, &rsa_priv,0,0);

see above codes.
I was confused about PEM_read_RSAPrivateKey's second parameter.
is equels both rsa_priv_read, rsa_priv?
should I free(RSA_free) variable only one?
I can't find description PEM_read_RSAPrivateKey function. does anyone notify me document of PEM_read_RSAPrivateKey? or I am waiting your reply. thanks.

The documentation is a bit vague on the matter.  Here's what it says:

The PEM read functions all take an argument TYPE **x and return a TYPE * pointer. Where TYPE is whatever structure the function uses. If x is NULL then the parameter is ignored. If x is not NULL but *x is NULL then the structure returned will be written to *x. If neither x nor *x is NULL then an attempt is made to reuse the structure at *x (but see BUGS and EXAMPLES sections).  Irrespective of the value of x a pointer to the structure is always returned (or NULL if an error occurred).

Essentially, the caller is responsible for freeing the pointer, period.  If rsa_priv and rsa_priv_read point at the same thing, freeing should of course only happen once.


Remove wirble development dependency

wirble doesn't seem to have a license.

Coverage remained the same at 90.983% when pulling dec8f2aae1164a94c7c0910d73a87c3c3faf17ab on feature/drop-wirble into 2b1fed132dbcf4bc22f7205619df25fe53bf7f6a on develop.

Missed that this had already been committed as 2b1fed13


[example] with-apollo-and-redux-saga

An Example that shows how apollo (2.x) and redux-saga can co-exist through next. And how on the top-level you can selectively choose what you need on the fly.

pages/index uses: withReduxSaga
pages/about uses: neither
pages/blog/index uses: withApollo, withReduxSaga
pages/blog/entry uses: withApollo

This was broken off from with-apollo-and-redux from #3463 (& #3484) where showing how Apollo and Redux can work separately, grew to expand from 'simply' redux itself.
This example also has expanded the lib to show how one can create multiple actions, reducers, sagas, etc. without needing to maintain a single large file for each by using rootReducer and rootSaga.

@notrab If you have time to review this too, that'd be sweet. (Thanks for the review earlier!)
This includes a deeper dive from with-apollo-and-redux that focuses on redux-saga and instead of telling that you can use redux (earlier example mirrors the existing with-apollo-and-redux that shows an empty object), it really shows them co-existing, as well as having the reworked Vote Buttons as well.
If the Vote Buttons in terms of adding and subtracting are of benefit, I can throw them into the other examples that use them. Unsure if this particular PR example should be on its own, or if it would be more beneficial to rework the existing with-redux-saga, so that's a question for anyone too. 😀


Add CAC's boolean fields to Storepoint description

CAC maintains some boolean fields we should add to Storepoint's description:
is_collecting_samples: true,
is_collecting_samples_by_appointment_only: true,
is_collecting_samples_for_others: null,
is_collecting_samples_onsite: null,
is_evaluating_symptoms: null,
is_evaluating_symptoms_by_appointment_only: null,
is_hidden: false,
is_ordering_tests: true,
is_ordering_tests_only_for_those_who_meeting_criteria: true,
is_processing_samples: null,
is_processing_samples_for_others: false,
is_processing_samples_onsite: null

Extracted from https://spark-bio.slack.com/archives/D011DMG3TGF/p1587358730035600.

@neilberkman not sure if we have any requirements but if we do, could you add them here?

Current status: needs feedback from Erika.

Hi Rod,
I just looked over the information. The boolean information to include is:
is_collecting samples
This will enable us only to display facilities that are directly interfacing with patients, and make sure not to display just labs.
Also include:
is_processing_samples
is_processing_samples_for_others
is_processing_samples_onsite
This information is useful because it could help people determine for healthcare providers or employers where they can send their samples to be processed if they do collection on-site, but need to do send-outs to other locations.

@ErikaMCheung we'll need to translate these into text to be included in the descriptions. Any thoughts on wording?

My initial thought here would be either to turn the list into populated checkboxes:

[ ] processes samples
[ ] processes samples for others
[ ] processes samples onsite

Or to only list trues:

[ ] Processes samples for others
[ ] Processes samples onsite

Latter would be simpler to implement, but both are doable.

@ivanoblomov you should see what's available in terms of formatting for text within the description field in Storepoint.

@neilberkman got a link?

@ivanoblomov check Slack

Thanks, very helpful!

@ErikaMCheung looks like we can insert HTML into the description, so how about something like this?

I'm assuming we can update the CSS to tweak the spacing around the bulleted list, but if not, we can always throw a line break in there.

Hey Rod, for this one. I think what we should do is simply create a tag that would work like a filter for these locations. This information is useful not so much for an everyday citizen, but more specifically for healthcare providers & collection facilities.

Discussed with @ErikaMCheung and decided that we'll turn these booleans into a second filter for healthcare providers at a later date.
We will, however, do an OR on the drive-thru tag(s) and the boolean field (if either is true, site is a drive through) once Erika determines the boolean-field name.


** DO NOT MERGE ** Pull Metadata from JSON-LD on Bibdata.

This won't work until Bibdata's working.

Looks like the update to CC broke assigning a collection, and somehow the tests didn't catch it

...Huh, nevermind, it's working this morning.

Closes #315


feat: initial version of the azure.developer.signing library

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

Please dont close, I'll get some bandwidth to work on this real soon.

Please dont close, I'll get some bandwidth to work on this real soon.

I plan to put some effort into submitting this PR this week, barring any more safe secrets initiative.

Closing for now until I get a resolution on how to proceed with testing.


Independent allocation

Catherine West mentions a crucial missing feature, independent allocation in her RustConf talk, as @nabijaczleweli mentioned to me:
https://youtu.be/aKLntZcp27M?t=2026
@kyren Could you elaborate what exactly you mean by that?

Not kyren, but the problem arises when you want to have a single ID space shared across multiple arrays, as done elsewhere in the talk.
For example, an ID might represent a whole entity in a game world, which has one entry in a physics slotmap, one entry in an animation slotmap, one entry in an NPC slotmap, etc. This single ID needs to be shared across all the maps so the entity itself can remain a single lightweight integer.
At the same time, each of these slotmaps can independently have or not have an entry for a given ID. For example, not every entity has an entry in the NPC slotmap. And this can change over time- some slotmaps might represent transient aspects of entities like status effects.

Hey, sorry for not responding earlier!
@rpjohnst has it right, but if it helps, you can see an example of what I meant by independent allocation and how you can use it here: https://github.com/kyren/simplecs/blob/master/src/generational_index.rs

@rpjohnst @kyren I believe this sounds a lot like what @eddyb was describing in this reddit comment earlier: https://www.reddit.com/r/rust/comments/8zkedd/slotmap_a_new_crate_for_storing_values_with/e2l1m2c/
He called it secondary maps, and we had a short discussion but I didn't pursue it further. I'll have to think about it a bit more.
My main issue with it is that there's no clear ownership/time of deletion for 'associated components'. In particular, this (phrased in terms of @kyren's example) fails:
let mut alloc = GenerationalIndexAllocator::new();
let k = alloc.allocate();
let mut arr = GenerationalIndexArray::new();
arr.insert(k, "test");
alloc.dellocate(k);
assert_eq!(arr.get(k), None);

In the spirit of the more holistic approach used by ECS/data-oriented design/etc., this sort of thing is usually handled as a separate "cleanup" concern, not by any kind of hidden connection or state between the GenerationalIndexArray and its "parent" GenerationalIndexAllocator.  Game loops (should) have a very clear order of execution, where the application itself knows far better than the library ever could when and how to clear out stale components, if that's even necessary. (For example it's not in simpleecs, because new components will just overwrite dead ones.)

Should this fail? IMO it should. But it might make it expensive and require referencing and potentially locking a mutex for SlotMap or GenerationalIndexAllocator (with ugly interior mutability). Maybe I just have to accept that those associated components will stick around after removal.

Yep, you're absolutely right that that fails.  This was used internally to a larger ECS system that provided the guarantee that deleting an Entity deleted it from every component, by only providing a higher level Entity delete method and ensuring it there.
That's a really good point though and I think it IS surprising that that works, and it really shouldn't.
There are a couple of irritating things you could do like make the id not Copy or Clone and be consumed by removal, but you're right that it's sort of a tricky API problem.
I didn't have time to get into this in the talk, but I kind of figured that it might be tricky to provide a very general API for this which is why I hadn't seen one yet.
Also @rpjohnst point is a good one, that simplecs wouldn't clear out old entities until they were overwritten, which is another potentially bad behavior.
Just for the record, simplecs is not something people should use, it is not meant as an actual library or anything I planned on improving.  It is an extracted form of the WIP ECS that I was working on, there only because I wanted to explain some design points.  Nobody should use it, but it is there if anybody thinks it is interesting.
The most interesting thing about it I think is that my preferred form of ECS design is just the "EC" part and not really the "S" part, becuase ECS is just an interesting sort of data structure.  The problem with this approach is that you really actually sort of want system scheduling because you can easily beat performance wise something like relying on RwLocks, but I still enjoy treating ECS as just a very fancy particular sort of data structure.  I also had not seen before the specific technique used to ensure lock order based on typeid, and I thought that might be useful to somebody.  I probably should write a readme explaining this in the project.

@kyren So I think I'll go with a design that's subtly different than yours, but achieves the same thing. In your design the allocator is central and you only have 'properties'.
My design will be a backwards compatible extension of the current design of SlotMap. That is, you still have an actual entry that you insert/remove. Then you can create efficient secondary maps to a SlotMap to store properties for an entry. API would look something like this:
let mut weapons = SlotMap::new();
let knife = sm.insert("knife");
let gun = sm.insert("gun");
let mut damage = sm.new_secondary_map();
damage.insert(knife, 10);
damage.insert(gun, 40);

Would that satisfy your concerns?

Yeah, I think so.  I'm not sure because I don't have something concrete to look at, but I think an API like that could work for a large number of use cases.  (I'm making some assumptions about how this will work internally here).
Something that wasn't fully fleshed out before I extracted it into "simplecs" was how to serialize entities including internal references, so that's probably something that we should think about.  You can kind of do it no matter what as long as the key type is Ord or Hash or something like that, and you can, at serialization time, come up with your own mapping of Key to say u64 or something, and then at load you can reverse the process to come up with a mapping from u64 to a new set of Keys.  Maybe that's simple enough, but maybe it's worth thinking of a way that could be easier?

Something that wasn't fully fleshed out before I extracted it into "simplecs" was how to serialize entities including internal references, so that's probably something that we should think about.

Internal references already work in slotmap and can be serialized using the built-in serde support without issue. That's one of the killer features of slotmap: representing and allowing arbitrary serialization of graph structures.

Internal references already work in slotmap and can be serialized using the built-in serde support without issue. That's one of the killer features of slotmap: representing and allowing arbitrary serialization of graph structures.

Oh, shows how much I know!  How will that work with secondary maps which may not be serialized / deserialized at the same time, does it just work somehow?

Oh, shows how much I know! How will that work with secondary maps which may not be serialized / deserialized at the same time, does it just work somehow?

It would just work, assuming you serialize/deserialize at the same time.
Since Keys are versioned, it would also just work if you don't serialize/deserialize at the same time, but obviously I can't time travel so you're going to get the information from the time you did the operation.

I have bad news and good news. After more brainstorming I believe the design of DenseSlotMap to be fundamentally incompatible with secondary maps in Rust. The performance just would not be good for the secondary maps, and makes the 'dense' a rather hollow promise.
The good news is that I believe I can make SlotMap to have really good iteration speed as well, even when it is very sparse. If I succeed I will simply drop DenseSlotMap and only provide SlotMap.
@kyren What are your thoughts on providing both sm.new_secondary_map() and sm.new_secondary_sparse_map()? The latter would have a HashMap rather than Vec as underlying storage for when you want to have properties for a small portion of elements, rather than the majority. Because with only new_secondary_map() you're looking at O(n) worst case space usage for each property even if you only store it for one element.

Just wondering what would happen if knife is removed from "sm" after
let mut damage = sm.new_secondary_map();
let knife_damage = damage.insert(knife, 10);

I presume damage.get(knife_damage) would produce None?
No idea about names, maybe derived_map or composite_map instead of secondary_map?
Also if we consider that specific elements various of a slotmaps make up an 'actual' entity how would it work? The examples above seems to apply a common property to slotmap elements of the same type, rather than coalescing different slotmap types into a single entity.

Hi yeah I think I prefer secondary maps as well!
Sorry my 2nd query got mangled somehow. What I meant to say is that I understand that an ECS has a SOA architecture. Is a secondary map designed to support this? And if so how would it be used.
I.e say I have a SlotMap and a SlotMap how would a secondary map help construct a consistent entity that had both health and position?

I think for some reason left and right angle brackets are being mangled in the comment box! I meant a SlotMap containing  “Health” components and a SlotMap containing  “Position” components.
I can see from your example how it might work though, thanks!

You need backticks (`) around your code snippets, otherwise the angle brackets are interpreted as HTML tags.
Also, you can edit your own past comments to fix them.

Progress update: I've finished removing DenseSlotMap in favour of HopSlotMap, which is nicely compatible with secondary maps: https://github.com/orlp/slotmap/commit/bdf2e3c1c1e66ea752cd691022462cf561de4793
I'm now focusing on finishing the secondary maps: slotmap::SecondaryMap and slotmap::SparseSecondaryMap.

A month went by and I just saw 7e3527f3750a8fe2ca666dd27a5082923a319dd8! I guess a release with secondary maps isn't far away anymore? 😄

@Nimelrian Correct. I'm still working on SparseSecondaryMap backed by a HashMap and changing Key into Key<M> to prevent cross-slotmap usage.

I'm kinda new to Rust and waited for this feature to finally get a little bit more into it, so I'm probably not the best person to give feedback. I may be able to take a look over it in terms of "how easy is it for a beginner to get something done with the library/feature", but don't let that get into the way of a release.
The only thing I'd like to see as of now would be unit tests ;)

I used the current master branch to play around a little bit and so far the ergonomics feel right in terms of creating/inserting values.
As you already said, removing a value from the main SlotMap does not remove it from any secondary maps.  This obviously puts additional load on the lib user since he's responsible for keeping this invariant (SecondaryMaps shouldn't contain keys which aren't stored in a SlotMap) intact.
As I said, I'm still new to Rust, but sometimes questions from "newcomers" often inspire solutions one may not have thought of before. Wouldn't it be possible to implement some variation of the Observer/Observable pattern? Though I'd guess that the borrow checker may have a problem with that. As I said, I lack the deeper knowledge.
Other than that, it's looking good so far. Maybe @kyren is able to chime in as well, since she mentioned this feature was missing in general. Is keeping the invariant intact important in the gamedev industry?

As you already said, removing a value from the main SlotMap does not remove it from any secondary maps. This obviously puts additional load on the lib user since he's responsible for keeping this invariant (SecondaryMaps shouldn't contain keys which aren't stored in a SlotMap) intact.

Not necessarily. A SecondaryMap does not leak memory even if the old key is never removed.
Either way, it's impossible to guarantee this through Rust alone without breaking the cornerstone of why SlotMap and SecondaryMaps are so useful: they are independent. As soon as you introduce some dependency of one on the other you are looking at multiple borrows, locking, exclusivity, etc...

Fixed with release 0.3.0.
@kyren I would love it if you'd take a moment to go over the design I've implemented and let me know if it still is missing something that you really want.
It would also be really nice if could you also update the part in your blog post (https://kyren.github.io/2018/09/14/rustconf-talk.html) talking about slotmap that it now provides the features you were missing (assuming my API is satisfactory).


cheat: 2.5.1 -> 3.0.3

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

homepage should read https://github.com/cheat/cheat
description should not contain the name of the package, suggestion: Create and view interactive cheatsheets on the command-line


Update lsp-types to 0.97 and add notebook support

This PR implements support for notebook document synchronization which was added in LSP 3.17
This is still draft, because lsp-types currently does not support notebook document synchronization. gluon-lang/lsp-types#268 but still has a few issues, so this PR currently overrides the lsp-types dependecy.

@zebreus  gluon pr has been merged?

@ebkalderon Can this be merged? We would like to begin work on https://github.com/denoland/vscode_deno/issues/932.


Feature/3402 drawer layout example

Fixes # BLUI-3402

Changes proposed in this Pull Request:

Added Drawer Layout examples

Screenshots:

To Test:

yarn start:reactdev
Note: Need to manually build the react components and paste node modules in docs
There is an issue with temporary drawer positioning for which issue has been logged https://github.com/brightlayer-ui/react-component-library/issues/534

This isn't how the rail variant should be appearing - do you know why it's off-centered?

No skinny rail variant example?

@emclaug2 Please review.

@bkarambe , can you fix conflicts and merge this PR?


Midocean University

Web site university : https://midocean.ae/en/
Among the program : https://midocean.ae/en/master-of-artificial-intelligence/

@Anfani2069 There are several files in the request, along with file.zip. It must not be there. Please remove file.zip and make pull request again.  I have to close this request without merging. Thank you for your understanding.

Hello,
I've done, thank you !
Le lun. 23 sept. 2024 à 12:05, Philip Torchinsky @.***>
a écrit :

@Anfani2069 https://github.com/Anfani2069 There are several files in
the request, along with file.zip. It must not be there. Please remove
file.zip and make pull request again. I have to close this request without
merging. Thank you for your understanding.
—
Reply to this email directly, view it on GitHub
https://github.com/JetBrains/swot/pull/23806#issuecomment-2367760497,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOMWZUKUARVONEF7RJIVGYDZX7RU7AVCNFSM6AAAAABOUQ3FCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRXG43DANBZG4
.
You are receiving this because you were mentioned.Message ID:
@.***>


json.zip not available anymore

The documentation needs changing because the json.zip package is not updated anymore in the "data link" (don't you love old corp lingo?)
The latest available version is 26:
http://www.unicode.org/Public/cldr/26/
From 27 and on there is no json package:
http://www.unicode.org/Public/cldr/27/
They announced this and didn't even apologized for breaking links. Supposedly everything can be found not far from here, but good luck with that.
(Globalize 0 was so much easier to use. I've been chasing this crud all morning.)

Hi, thanks for pointing it out. But, this same page has already been updated: https://github.com/jquery/globalize/blob/master/doc/cldr.md :smile:
The link you are using points to an older point in time of the documentation.


Clean Up ANSWER_QUESTION Logs

The ANSWER_QUESTION log event contains an awful lot of unnecessary junk:
{
  "answer": {
    "id": null,
    "_id": null,
    "tags": null,
    "type": "choice",
    "level": null,
    "title": null,
    "value": "No",
    "layout": null,
    "version": null,
    "children": [

    ],
    "encoding": "markdown",
    "subtitle": null,
    "published": false,
    "attribution": null,
    "relatedContent": null
  },
  "correct": true,
  "questionId": "ch_d_p3|d2626a79-66ea-47b1-8e7a-3e841c12dc88",
  "explanation": {
    "id": null,
    "_id": null,
    "tags": [

    ],
    "type": "content",
    "level": null,
    "title": null,
    "value": null,
    "layout": null,
    "version": null,
    "children": [

    ],
    "encoding": "markdown",
    "subtitle": null,
    "published": false,
    "attribution": null,
    "relatedContent": null
  },
  "dateAttempted":<PHONE_NUMBER>934
}

All of the null tags could easily be dropped, as could the published: false, lines and the empty children tags. This is a space saving of about 60% on this event, and makes the log much easier to read too!
The log is created in QuestionFacade.java, and it may be that the PgLogManager.java ObjectMapper is the place to fix it.

This will also affect the QUESTION_ATTEMPT_RATE_LIMITED events too.

The simple solution:
Jackson implements a @JsonInclude annotation which can be given the argument NON_EMPTY, NON_NULL or NON_DEFAULT to filter on the values of the fields when serialising. This annotation can be set on either the class or on individual field level of the DTOs so it is quite flexible.
The problem with the simple solution:
This would mean that the JSON that is sent to the front-end would also not include those empty/null fields...
It doesn't seem to affect the web app from what I've seen but I can't be certain that something somewhere won't break.
If this is good enough then let me know, I doubt it is.
Otherwise, we could go down the route of creating our own annotation (@DoNotLogIf("defaultValueForField")) with a custom serialiser, or there might be a slightly quicker solution using setMixinAnnotations or something, and having a separate object mapper for logging.

I think you can configure the jackson serialiser used in the logging code to ignore null values. This might be better than marking each POJO field. I will have a look at where it is when I have some time and let you know.

Ah cool, something like that would be good, I will let you know if I get around to looking at it before you. Thanks!

@mlt47 Do we think this is fixed now?

Yes, it now does not store null valued fields in the JSON blob.
It does still store "empty" values ("", [], etc.) but I think that we should stick to that so that, when looking back over a  log event which was causing a problem, there is no ambiguity whether the missing value was an empty-value or a null-value.


English translation

Do you plan to add an English translation?

I'm not sure if your mention of English translation refers to i18n.
If it does, I've already added English and Chinese languages. They can be switched by the language setting in Obsidian.
And if you want to add more languages, feel free to submit a pull request.


MNT: List at least one microarch_level to avoid redundant builds

Motivation: https://github.com/conda-forge/microarch-level-feedstock/issues/11

Always list a microarch_level in recipe/conda_build_config.yaml to avoid conda-build searching for and setting an incorrect microarch_level, resulting in redundant builds.

c.f. https://github.com/conda-forge/conda-forge.github.io/pull/2197

Bump build number.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[N/A] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

ℹ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12309964826. Examine the logs at this URL for more detail.

@conda-forge-admin, please rerender

@conda-forge/blasfeo this is ready for review.


Improve Ferdi's design

Description

Ferdi's design - for the most part - is still the same as Franz's design. There are some things though, that me or other members of the Ferdi community notices, that could be improved in Ferdi's design.
This PR aims to improve and update Ferdi's design. Everybody that wants to suggest further changes, feel free to commit them into the "design-improvements" branch or create a PR to it if you are not part of the Ferdi org yet.
Changes so far:

The Settings modal got updates as suggested in #976:

Buttons are "bolder" than before to give them more visibility:

The cursor is a pointing cursor when hovering over clickable items such as buttons or links

Update branding to be the same that we use on Twitter

Update authentification screens to use solid color instead of the gradient

Let me know any feedback you have on these changes.
Checklist:

[x] My pull request is properly named
[x] The changes respect the code style of the project ($ npm run lint)
[x] I tested/previewed my changes locally

@vantezzen
Hi. I have a suggestion taked it from my previous use of Rambox. In Rambox the services arranged in 2 groups: chats services & email services. Since Ferdi containing more than these 2 types of services, ex: cloud drive services, such categorization in Ferdi UI will be very useful. For that I would like to suggest on you to grouping the services within 4 categories:

Chat services,
Email services,
Cloud drive services,
Other services.

Best regards.

@vantezzen it looks good, thank you!


ASN/CIDR/Name Target allowed

Allows ASN/CIDR/Name as target.
Tools suggestion:
metabigor
asnlookup
asnip
mapcidr
3klector
HostHunter

shifted to v0.4.0 milestone

This is better to make a manual research than automate


Product getting save if price and weight is negative in variants of configurable product.

Framework Version: 0.1.4

Framework Version: 0.1.5
Fixed


Fix no_proxy to noProxy for rancher chart

value is noProxy (per https://github.com/rancher/rancher/blob/v2.6.3/chart/values.yaml#L89 and https://rancher.com/docs/rancher/v2.6/en/installation/install-rancher-on-k8s/chart-options/), this is correct in v2.5 doc at https://rancher.com/docs/rancher/v2.5/en/installation/other-installation-methods/behind-proxy/install-rancher/

Hi @axeal, could you also update this in the Install Cert Manager section as well?

@jtravee no_proxy is the correct value for the cert-manager chart, so no update needed there (https://github.com/cert-manager/cert-manager/blob/master/deploy/charts/cert-manager/values.yaml#L180)


Accept Uint8Arrays in place of Buffers

This pull request relaxes input type from Buffer to Uint8Array. It still returns Buffers back to ensure backwards compatibility. It also adds missing TS JSDoc comments as they helped me understand interfaces between components.

Does the require('util') mean we need to include it in the dependencies list to make sure we have it available for webpack@5?

Does the require('util') mean we need to include it in the dependencies list to make sure we have it available for webpack@5?

I'm not sure what changes with webpack@5 but:

It is only for testing on <=node@10 otherwise TextEncoder/TextDecoder are available as globals.
I am only realizing now this doesn't even run on CI so I could probably just assume we're on at least LTS
If we need to add dep for webpack@5 it's probably better to just switch to global or have a separate module that takes care of this.

Oh I was wrong in suggesting that:

It is only for testing on <=node@10 otherwise TextEncoder/TextDecoder are available as globals.
I am only realizing now this doesn't even run on CI so I could probably just assume we're on at least LTS

I do see now that this is not the case, it is used in the code not just test

@rvagg I have addressed your remark by pulling in web-encoding dependency that just provides TextEncoder / TextDecoder across various configurations.

You need to cut a new version of web-encoding @gozala, the 1.0.1 package is 110Mb and unpacked is 356Mb thanks to a bundled version of Linux Chromium in a .cache directory.
btw if this comes from consuming puppeteer then check out https://github.com/rvagg/polendina#minimising-puppeteers-size to reduce the size, having ~300Mb extra junk in each of my package directories even for devdeps drives me mad.

You need to cut a new version of web-encoding @Gozala, the 1.0.1 package is 110Mb and unpacked is 356Mb thanks to a bundled version of Linux Chromium in a .cache directory.
btw if this comes from consuming puppeteer then check out https://github.com/rvagg/polendina#minimising-puppeteers-size to reduce the size, having ~300Mb extra junk in each of my package directories even for devdeps drives me mad.

I'm guessing it is coming from playwright-test, which I end up using because I could not figure out https://github.com/rvagg/polendina/issues/10. BTW you and @hugomrdias might want to consider converging two.

You need to cut a new version of web-encoding @Gozala, the 1.0.1 package is 110Mb and unpacked is 356Mb thanks to a bundled version of Linux Chromium in a .cache directory.

I end up adding .cache to .npmignore to solve this.

There so not be any .cache or bundle browser in the playwright-test npm package install, it lazy downloads the browser binary to the OS temp folder only once per version, if this is not happening please open an issue and i will fix it!

Thank you @Gozala


Crash on optimizing of some maps

As said above, Optimize doesn't work for some maps because of instant CTD.
crash.zip

Here are another 2 maps, the difference is they have clipnodes limit exceeded (though they were compiled successfully).
P. S. "Clean" function also causes CTD for those maps.
limit.zip

crash at vis decompress function

out of bounds

they have clipnodes limit exceeded (though they were compiled successfully).

I wonder which compiler allowed that to happen 🤔


Improve Cesium Viewer performance when clamping to 3d Tiles with HeightReference.CLAMP_TO_3D_TILE

Feature
Current state:
Clamping billboards & labels to a 3d tile with HeightReference.CLAMP_TO_3D_TILE drops the FPS of the cesium viewer when zooming / moving the camera. Above a certain number of points the FPS drops to 0 (viewer freezes), and the presence of labels lowers the threshold for this. This does not happen when clamping to terrain with HeightReference.CLAMP_TO_TERRAIN.
Feature Request: If possible, support clamping a larger number of billboards & labels to 3d tiles without noticeable performance impact in the Cesium viewer.

Thanks for opening this request @gdiehlEB! Would you be able to give us the a rough number of billboards and labels you're typically dealing with?

Just to update this issue with info discussed in Slack:

@gdiehlEB shared a typical use case site (customer site so it was shared privately)
Linework layer appears to have 332 billboards, 83 of these with label

Also reported with clamping models to Google's 3D Tiles in https://github.com/CesiumGS/cesium/issues/12055


fix TypeError in MemcachedHandler::__construct()

Description
fix #1204
port from RedisHandler
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPdocs
[x] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

Broken unit tests...

Oh... I'm Sorry...
that is fixed now.

Thanks merged!


why can eosjs run in node and browser, yet cannot run in react native?

I know eosjs(especially ecc module) need some node built-in modules.
but now that in some easy way it can run in web browser.
why can't we use its browser version in react native?
so my question is

what happened during eosjs node version's changing to browser version?
why browser version is not runnable in react native?
many thanks if you can tell me.

my guess: it is because we get the browser version by browserify. And the output of browserify cannot run in reactnative.
like: https://stackoverflow.com/questions/40777337/how-to-use-browserified-libraries-in-react-native

This is because the browserify provided by current eosjs version is incompatible with react native.
In order to operate in react native, other work is required like custom transformers


Bluetooth dongle not detected

I'm running Noble in an Electron app but sometimes the dongle we're using is not detected and so onStateChanged is not triggered.
After digging into the code we found that BluetoothHciSocket.prototype.isDevUp returns false even if the device is plugged in.
https://github.com/sandeepmistry/node-bluetooth-hci-socket/blob/master/lib/usb.js#L68
We're using a BCM20702A0 dongle with PID 21E8 and VID 0A5C which should be supported.
Is there any way to recover from this? or force detection of the dongle again?

@mhle please provide debug logs, by setting the DEBUG env var to *.
I'm thinking the adapter is not responding to the HCI reset command, but we'll see what the debug logs say.

I have the same problem with my BLE USB Dongle (chipset: CSR8510 A10).
My code always communicates with the dongle only every 2nd time!!
I found out that although 'this._isUp' is true, it still does not work. The function noble.on() won't run.
In the following you can see the debug output for the case when there is no communication with the dongle:

Thank you for your helps..

And here is the debug output when there is a communication to the dongle:

I am still trying to solve this problem. It is strange, that SanDeep's "enter-exit.js" code always runs.
My code is based on "enter-exit.js", so I do not understand why I got this problem? Because I did not change the code in its basic functionality.
Here is the debug output of "enter-exit.js" to compare with those above.

@boredSinan looks like the adapter is still scanning when you start you app the 2nd time, and then doesn't respond to any HCI commands after the reset command.
How are you exiting your app? noble tries to stop scanning on exit here: https://github.com/sandeepmistry/noble/blob/master/lib/hci-socket/bindings.js#L96
Another thing to try is, adding a delay here, to give the adapter some time before we send other HCI commands:  https://github.com/sandeepmistry/noble/blob/master/lib/hci-socket/bindings.js#L96
setTimeout(function() {
  this._isUp = true;
}.bind(this), 500);

PS: I like the coloured screenshots, but please also copy/paste the test next time, it's easier to search etc.

Thanks a lot Sandeep, for your suggestions.
I found out my problem: There is the following function in my code:
//Wait function in ms
function pauseMs(millis) {
var date = new Date();
var curDate = null;
do {
curDate = new Date();
}
while (curDate - date < millis);
}
And the problem always occured when I closed the Node.js application at the same time as the code was running the pauseMs() function (this function was called several times in my code). Because of that, the onExit() function could not be executed.
Now I don't close the Node.js application at the same time as the application is paused (because of pauseMs()), there are no problems anymore!

Thanks a lot Sandeep, for your suggestions.
I found out my problem: There is the following function in my code:
//Wait function in ms
function pauseMs(millis) {
var date = new Date();
var curDate = null;
do {
curDate = new Date();
}
while (curDate - date < millis);
}
And the problem always occured when I closed the Node.js application at the
same time as the code was running the pauseMs() function (this function was
called several times in my code). Because of that, the onExit() function
could not be executed.
Now I don't close the Node.js application at the same time as the
application is paused (because of pauseMs()), there are no problems anymore!
I uploaded this post on:
https://github.com/sandeepmistry/node-bluetooth-hci-socket/issues/13
2015-12-04 2:01 GMT+01:00 Sandeep Mistry<EMAIL_ADDRESS>
@boredSinan https://github.com/boredSinan looks like the adapter is
still scanning when you start you app the 2nd time, and then doesn't
respond to any HCI commands after the reset command.
How are you exiting your app? noble tries to stop scanning on exit here:
https://github.com/sandeepmistry/noble/blob/master/lib/hci-socket/bindings.js#L96
Another thing to try is, adding a delay here, to give the adapter some
time before we send other HCI commands:
https://github.com/sandeepmistry/noble/blob/master/lib/hci-socket/bindings.js#L96
setTimeout(function() {
this._isUp = true;
}.bind(this), 500);
PS: I like the coloured screenshots, but please also copy/paste the test
next time, it's easier to search etc.
—
Reply to this email directly or view it on GitHub
https://github.com/sandeepmistry/node-bluetooth-hci-socket/issues/13#issuecomment-161841444
.

@boredSinan cool, thanks for following up!
@mhle any updates from my request in https://github.com/sandeepmistry/node-bluetooth-hci-socket/issues/13#issuecomment-160309753

Closing due to lack of activity.


I have try some example and there are some problem in my phone

address book example: when I fill the text input, the keyboard can block the text input, and I can't see what I fill just now. em...And I can't delete characters that I typed.
widgets example: some widget response slow . some times wait a minmute, it can be fine.
game example: when the game first started,  it is not smooth enough. Is there some way to optimize?

Thanks for the bug report.  It sounds like you're reporting several issues at once, which makes it a bit hard to triage and fix the issues.
I'm going to focus this issue on the first thing you describe, which is that the keyboard can block the input field.  Please file separate bugs about the other issues.

Dupe of https://github.com/flutter/flutter/issues/103


Support anonymous comments

I think we can leverage getAppAccessToken() to post comments as the bot, allowing visitors to leave comments without signing in. Maybe we should also add a signature like

Anonymous wrote:

at the beginning of the posted comment, to indicate that it was made by an anonymous user (not the bot itself).
The thing is, we shouldn't pass the token directly to the client, because that would let users misuse the token to act as the bot. We need to create a new API route for addDiscussionComment and addDiscussionReply, and that's not something I'm really keen on.
Also, I'm not sure how/where the sign in buttons should be placed...
Edit:
Also mentioned below: anonymity and comments tend to not go well together. If implemented, this should be an opt-in feature.

Slightly sceptical that this is a good idea. Anonymity and comments don't generally go well together... 🤔

@carltongibson yes, indeed. I was thinking that it could be an opt-in feature.
I just posted this here to gather opinions, so it's still "decision needed". Thanks for coming by!

I think that this should be a choice that website owners can make, but it shouldn't be enabled by default.

@laymonage this feature will be useful since some people may not have GitHub account.

Good idea, but make also that users without github account can provide their custom username to comment.

@laymonage this feature will be useful since some people may not have GitHub account.

true, but you can make a GitHub account

Good idea, but make also that users without github account can provide their custom username to comment.

I’m not quite sure what you mean by this. If you mean saying “Name(anonymous) wrote” instead of “Anonymous wrote” that could work.

This would be great! It would allow migrating from other comments systems with ease.

@laymonage is this very hard to implement? I think this is the only important feature that is missing.

Anonymous comments are definitely a great idea! @laymonage  because I often have family and friends who are not developers and therefore do not have a Github account, but after reading my blog and wanting to add some comments, they are blocked from signing up for a github account.
Of course, if anonymous comments are allowed, be careful not to be harassed by spam — just like other anonymous comment systems.

I would personally love this for my blog. I think this would lower the barrier to entry to engagement and to the point about bots, I agree in principle but I also get bot posts from GitHub occasionally. I am fine with the onus being on the site maintainer (such as myself). Is there any way I could do anything to make this happen?

Like several others here, this is a feature I would very much take advantage of were it possible as many who would read my blog may not use GitHub.  Many of the other commenting systems do offer anonymous comments, but there is a wonderful simplicity that comes with Giscus in it's ability to keep the comments on GitHub itself instead of an external site.  It would be even nicer if it could have the best of both worlds.

This one is needed. Also, we need some moderation policy for this one, otherwise, bots can spam our website commenting system.

I'd use this

Sounds great

Is there any update on this feature?
I would love to have this feature

I too would use this feature

Any update here?

I think this feature would be great.

I am skeptical of anonymous comments. However, anonymous reactions (fixed set of emojis) that are passed through to Github discussion topic or reply could be a good feature.
It allows a casual visitor to engage with the content and provide feedback to the more active participants.

I also think it would be a very nice feature. Although anonymity and comments might not be the best combination. I would like to allow non-technical people to comment on my site.

In reviewing options for commenting systems for statically generated websites (Jekyll, Gatsby, Next.js etc), Giscus is the closest thing to perfect as a comments system for technical blogs, personal sites, etc.
The ability to support lighter / no authentication to comment is the only feature missing.
I see above there are quite a few (valid) concerns about connecting identity <> comments, and several who aren't quite sold on the value of non-authenticated commenting, but the fact remains that not everyone on the internet has a Github account, and the added friction of the currently required flow would prevent some users from commenting. (A feature for some, but not all site owners.)
One way to structure the separation of concerns would be:
[ user ]
   |    \__________(optional path)____
   v                                  \
[ identity / GitHub auth ]             |
   |                                   v
   |                 [ "anonymous" /w form fields, eg name / email ]
   |                                   |
                                       v
   |                 [ akismet / other spam filtering (similar to Staticman) ]
   |           ________________________/
   |          /
   |         |
   v         v
[ giscus / API bridge ]
           |
           v
[ GitHub Discussions (Data Layer)]

That way, you have Giscus to manage Frontend + Integrations, GitHub for authentication (but it's no longer an absolute requirement) and GitHub Discussion for storage. The majority feature set and UX can also heavily push for the "standard" GitHub authenticated flow, eg by default everything comes up like it does now, and only switch out to a form with name / email behind an unemphasised "I don't have GitHub" link or similar. Friction on the 'anonymous' flow would totally be fine, since at the moment it's just not possible if the user doesn't have, know or want to have a GitHub login.
TLDR; definitely a lot of work to build out the unauthenticated commenting flow, but it would add significant value.

this would be an awesome feature - the creation of a github account is quite tedious if someone just wants to leave a comment. a link sent to the email, or something else instead of a github account for auth would be much appreciated

I think this is a great feature, any update?

Really love to see any updates.

Seriously. It's been three years since this issue was opened.
This project is intended for blogs and similar static web pages.
Limiting comments to only people that have a github account is ridiculous, be real, most of the users that will read those blogs/static websites do not have GH account, possibly never even heard of it.
Requiring users to register yet another account, especially if they will only use it once ever in their life for a single comment on a single blog they randomly happened upon is unrealistic and absolutely unnecessary hurdle.
For my personal usecase, I am trying to integrate this project into a Jekyll based website, where I handle my own authentication. (my site is using an invite token sent by an email and supercookies to awoid any kind of "log-in" process from the users. Security is not high on the ladder for me, user convenience and idiotproofing is the absolute top priority)
I'd absolutely love to be able to use giscus for this purpose, especially since the content and comments are hosted on GitHub Discussions, also allowing images in posts and I was able to get giscus to work with a private repository and service_token.
I'd really prefer to be able to avoid having to develop my own solution / gutting out giscus to re-write it to utilize the repository GHApp for sending the comments. But seeing as I'm time-pressured, I'll probably not be able to avoid having to go down that route. If I get a working solution, I'll link it here, for the sake of others getting stuck on the same problem.

I think I had it running somewhere. I probably used an anonymous user which would be placeholder for people to coment without having to register. Haven't used it for a while and would need to check.

From: Tibor Dancs @.>
Sent: Tuesday, June 25, 2024 3:38:04 PM
To: giscus/giscus @.>
Cc: Daniel Zbinden @.>; Comment @.>
Subject: Re: [giscus/giscus] Support anonymous comments (#65)
Seriously. It's been three years since this issue was opened.
This project is intended for blogs and similar static web pages.
Limiting comments to only people that have a github account is ridiculous, be real, most of the users that will read those blogs/static websites do not have GH account, possibly never even heard of it.
Requiring users to register yet another account, especially if they will only use it once ever in their life for a single comment on a single blog they randomly happened upon is unrealistic and absolutely unnecessary hurdle.
For my personal usecase, I am trying to integrate this project into a Jekyll based website, where I handle my own authentication. (my site is using an invite token sent by an email and supercookies to awoid any kind of "log-in" process from the users. Security is not high on the ladder for me, user convenience and idiotproofing is the absolute top priority)
I'd absolutely love to be able to use giscus for this purpose, especially since the content and comments are hosted on GitHub Discussions, also allowing images in posts and I was able to get giscus to work with a private repository and service_token.
I'd really prefer to be able to avoid having to develop my own solution / gutting out giscus to re-write it to utilize the repository GHApp for sending the comments. But seeing as I'm time-pressured, I'll probably not be able to avoid having to go down that route. If I get a working solution, I'll link it here, for the sake of others getting stuck on the same problem.
—
Reply to this email directly, view it on GitHubhttps://github.com/giscus/giscus/issues/65#issuecomment-2188991454, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVENUXZR6JTQK2ZP2PCQQKLZJFXDZAVCNFSM4452U332U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMJYHA4TSMJUGU2A.
You are receiving this because you commented.Message ID: @.***>

@ZbindenDaniel Please share your solution of using anonymous user when you find it.

Nevermind. I realized I used another framework in the end. Check out this repo: https://github.com/jacobwb/hashover
It allows for anonymous commenting and might suit your other needs as well.
Good luck and have fun

Von: Sohang Chopra @.>
Gesendet: Dienstag, Juni 25, 2024 7:03:53 PM
An: giscus/giscus @.>
Cc: Daniel Zbinden @.>; Mention @.>
Betreff: Re: [giscus/giscus] Support anonymous comments (#65)
@ZbindenDanielhttps://github.com/ZbindenDaniel Please share your solution of using anonymous user when you find it.
—
Reply to this email directly, view it on GitHubhttps://github.com/giscus/giscus/issues/65#issuecomment-2189478319, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVENUX7XMIRKMTALSN5I7BDZJGPHTAVCNFSM4452U332U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMJYHE2DOOBTGE4Q.
You are receiving this because you were mentioned.Message ID: @.***>

Nevermind. I realized I used another framework in the end. Check out this repo: https://github.com/jacobwb/hashover
It allows for anonymous commenting and might suit your other needs as well.
Good luck and have fun

Von: Sohang Chopra @.>
Gesendet: Dienstag, Juni 25, 2024 7:03:53 PM
An: giscus/giscus @.>
Cc: Daniel Zbinden @.>; Mention @.>
Betreff: Re: [giscus/giscus] Support anonymous comments (#65)
@ZbindenDanielhttps://github.com/ZbindenDaniel Please share your solution of using anonymous user when you find it.
—
Reply to this email directly, view it on GitHubhttps://github.com/giscus/giscus/issues/65#issuecomment-2189478319, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVENUX7XMIRKMTALSN5I7BDZJGPHTAVCNFSM4452U332U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMJYHE2DOOBTGE4Q.
You are receiving this because you were mentioned.Message ID: @.***>

Thank you, that looks really good!

Honestly, I'd love to use giscus, but lack of this one exact feature necessarily stops me from that 😕


Publish to Live

Docs Build status updates of commit fabb309:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azps-6.6.0/azps-msgraph-migration-changes.md
:white_check_mark:Succeeded
View (azps-6.6.0)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Refactor HandlerHub for lazy loading

https://github.com/fabric8io/fabric8-maven-plugin/blob/54ebf791ea70c341331824e9e1f517c41f25b70a/core/src/main/java/io/fabric8/maven/core/handler/HandlerHub.java
Currently 8 Handler instances are created by the constructor unnecessary populating the java heap  as only 1 of the 8 instances are used at a moment of time.

Hi @dev-gaur
I would like to contribute the fix for this issue.
This is my first time contribution to open source.
Please let me know what approach to take to fix this.
Is it fine to have a null check and then create the instance in the getter methods?

Yes, create the instance in the getter methods.
For eg.,
    public JobHandler getJobHandler() {
        return jobHandler;
    }

can be refactored as
    public JobHandler getJobHandler() {
        return new JobHandler(podTemplateHandler);
    }

Thanks. Which branch should I use to make these changes and send a pull request?

Create a branch called #issue1587 :)
On Wed 27 Mar, 2019, 23:35 Karthik Rao<EMAIL_ADDRESS>wrote:

Thanks. Which branch should I use to make these changes and send a pull
request?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fabric8io/fabric8-maven-plugin/issues/1587#issuecomment-477284352,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHM4PMicXSYphNEN0wcNiZtxCLeZmYyAks5va7LUgaJpZM4b9Wrd
.

Won't this change make the getter method return a new handler instance every time the getter method is invoked?

If you'll look into the usage of those handlers instance, we don't want to let one instance affect the state of the another handler instance, so we need a fresh instance everytime getXHandler( ) is called.

@ theexplorist
I was working on this item as you can see from the comments above.
At least have the courtesy of putting a comment before taking up other's task and submitting a pull request.
This is the second time I am in this situation in the week. :(

@karthikmg we can't lock an issue on any particular contributor. @theexplorist created a PR which was good to merge.
There are other starter issues for you to work on.
You can get involved in the kubernetes-client repository as well
https://github.com/fabric8io/kubernetes-client/labels/low hanging fruit


PacReq:

Types
-bin (Binary release of the package)
URL
https://sourceforge.net/projects/ventoy/files/v1.0.96
Building guide
No response
Additional context
Ventoy is an open source tool to create bootable USB drive for ISO/WIM/IMG/VHD(x)/EFI files.

@Elsie19 Hi,
This package will be great. I don't know how to up a PacReq.
Regards.
Davius

@Elsie19 Hi,
This package will be great. I don't know how to up a PacReq.
Regards.
Davius

What do you mean "up a pacreq"?

@Elsie19 Hi,
This package will be great. I don't know how to up a PacReq.
Regards.
Davius

What do you mean "up a pacreq"?

I mean, setting it as required =)
I will add it soon I think

duplicate here
https://github.com/pacstall/pacstall-programs/issues/2278


Colmap gui + imgs2poses.py still gets error

I am using imgs2poses.py to estimate the camera poses for my own dataset.
However, it always returns with ERROR: the correct camera poses for current points cannot be accessed.
On the other hand, I can use colmap gui to reconstruct a part of the camera poses. (e.g. not pose of every image is estimated)
And I execute 'imgs2poses.py' with the same argument on the sparse folder and database.db generated by colmap gui.
However, it still returns with ERROR: the correct camera poses for current points cannot be accessed.
Can you give me instructions about how to use colmap gui + imgs2poses.py to make the pose estimation work?
Thank you!

The code of LLFF (imgs2poses.py) requires that every image to be estimated, so it returns error in your case. You can modify imgs2poses.py and my llff.py so that it only reads the correctly estimated images and discard the rest, or you need to tune COLMAP so that all image poses are estimated.

If you want to modify the python files, I suggest that you bring the content of imgs2poses.py to llff.py, i.e. read colmap files directly from llff.py as it allows every variable to be visible inside llff.py.
I will probably make a commit to dev to do this, i.e. eliminating the dependency on imgs2poses.py from LLFF code.

Thank you for your fast reply!
I actually filtered out those images that are not reconstructed by colmap gu in the folder images. For more details, I also ran dense reconstruction with colmap gui.  And it will generate a folder densethat contains all the images using for dense reconstruction. I use these images as the filtered images. Should this be acceptable forimgs2poses.pyto read as the images inimages` folder all have camera poses.
Or I am misunderstanding some part of colmap?
Thank you!

Hmm, I don't have experience using the dense reconstruction. Can you try changing the strings sparse to dense in this function (and maybe other paths) and run imgs2poses.py to see if it succeeds?

Thank you for your suggestions.
I modified imgs2poses.py a little bit to ignore all the images that are not reconstructed by colmap gui.
However, this might cause some problems in the boundary npy file. (Not sure)
I will train the data first and see if it works.
Thank you very much again!

@wolterlw Thanks for your kind words!
Do you mean poses_bounds.npy? If you use your own camera poses (not from COLMAP), I'm afraid you need to do some code modifications.
Basically you need to do the followings:

Set the intrinsics according to image size
https://github.com/kwea123/nerf_pl/blob/422ce4bf5755aec5ca7ff4b24868b21f03145e37/datasets/llff.py#L188-L193
Set the extrinsics in "camera to world" format, and change its orientation to "right up back"
https://github.com/kwea123/nerf_pl/blob/422ce4bf5755aec5ca7ff4b24868b21f03145e37/datasets/llff.py#L195-L199
Find the nearest bounds for each image and scale the poses so that everything lies roughly inside [-1, 1]
https://github.com/kwea123/nerf_pl/blob/422ce4bf5755aec5ca7ff4b24868b21f03145e37/datasets/llff.py#L205-L211

I believe the code is sufficiently commented, you just need to follow these steps. Do not hesitate to post another issue, or to share your data if you have further questions.

@alex04072000 Can you share your data where COLMAP fails to estimate the pose for some images? I want to test my code to handle this case. Thanks!

The dependency of LLFF code is now removed. The pose from COLMAP is read and converted inside datasets/llff.py directly, and the result is verified to match the LLFF poses_bounds.npy (so no need to change anything for previously trained models).
The remaining task is to check if this code really ignores (I believe it does) the unreconstructed images and can successfully use the rest (the good images) to train. For this I'll need your help if you can provide the data or check by yourself. I will close this issue for now, feel free to comment if you still encounters error.

Hey,
I am facing the same issue. I am using the bird dataset (https://vision.in.tum.de/data/datasets/3dreconstruction). Can you tell me what should I do?
Can you provide the link to your silica dataset?

@kainataltaf Are you using the latest code on dev branch? What's the full error message?
silica data is here

@kwea123 No, I am using the master branch. The error is ERROR: the correct camera poses for current points cannot be accessed.

The master branch is old code to support colab usage. If you don't use colab, please switch to dev branch and see if the error persists. If you need to use colab and the master branch absolutely, the error won't be fixed there. You need to re-take the photos until COLMAP reconstructs every camera poses correctly.

I am using colab.

File "/nerf_pl/datasets/llff_1.py", line 216, in read_meta     visibilities[j-1, i] = 1 IndexError: index 25 is out of bounds for axis 0 with size 23

The dependency of LLFF code is now removed (on dev branch). The pose from COLMAP is read and converted inside datasets/llff.py directly, and the result is verified to match the LLFF poses_bounds.npy (so no need to change anything for previously trained models).
The remaining task is to check if this code really ignores (I believe it does) the unreconstructed images and can successfully use the rest (the good images) to train. For this I'll need your help if you can provide the data or check by yourself. I will close this issue for now, feel free to comment if you still encounter error.

In the dev branch how do I do step 3 of my own data that is "Run colmap sparse reconstruction"? Do I need to do it from the GUI directly since there is no more LLFF - imgs2poses.py to do it for me


Carlos can support expire time like AwesomeCache

Carlos can support expire time like AwesomeCache?

Hi @arden, currently Carlos doesn't support expiration time of cached entries. This feature is tracked in #89 but there is no ETA at the moment.
If you have any ideas how to integrate this in generic CacheLevel instances, both out of the box and user-provided, feel free to drop them here!
Thanks and have a good Easter

I'll close this since the development can be tracked in the existing issue.


Migrate to ES6

Migration is quite simple, but it's possible to achieve a visually cleaner code as a result, especially when it comes to the functional programming. It's not critical - but I can take care of it.
I think it would simplify further development

I'm not sure it worth it since ES6 syntax will introduce incompatibility issue with older browsers or older versions of nodejs.
We may also add an additionnal compilation step (using babel) but I'm not sure it will work due to the use of browserify.


PermissionError: [Errno 13] Permission denied:

Problem description The system is Windows 11. When reading a txt document, PermissionError: [Errno 13] Permission denied: appears. The code is as follows:
from unstructured.partition.auto import partition
partition("data_input\cureus\cureus-0015-00000040274.txt")

The problem code is located as follows:
tokenize.py
with tempfile.NamedTemporaryFile() as tmp_file:
    tgz_file = tmp_file.name
urllib.request.urlretrieve(NLTK_DATA_URL, tgz_file)

I tested the following usage and it is also incorrect, and the same problem occurs;
with tempfile.NamedTemporaryFile() as tmp_file:
    tfp = open(tmp_file.name, 'wb')

After checking the document, I found that the following code is normal on the linux system, but not supported on the windows system. So how to use it correctly on the windwos system partition("data_input\cureus\cureus-0015-00000040274.txt")

@yufengaotianya please provide a full stack trace with line numbers so we can see where the problem is occurring.
Also, if you want us to understand the text please translate it to English for us :) I adjusted this one using Google Translate: https://translate.google.com/?sl=auto&tl=en&op=translate
@Coniferish probably something for you to look at while you're in there on the txt partitioner. I think what we're going to want to do is use with tempfile.TemporaryDirectory() as tmpdir: rather than NamedTemporaryFile which has known problems under Windows.

errno13.txt
Hi, I've recently ran into this issue as well.
I've attached the trace. Hopefully it will help.

Okay, thanks for this @seanmj :)
I think I've found the problem.
In the meantime if you revert to v0.14.9 that should avoid this this problem for the time being. Let us know how you go :)

Hi,
I have the same problem when trying to read a docx!
I will try the last proposed solution of downgrading to v0.14.9

pip install -U unstructured==0.14.9

this solution works! ty

$ pip install -U unstructured==0.14.9

It worked for me too.

@scanny, can you confirm and/or link the PR that addressed this issue and close this if appropraite?

Okay, thanks for this @seanmj :)
I think I've found the problem.
In the meantime if you revert to v0.14.9 that should avoid this problem for the time being.  Installing unstructured=0.15.0 or later will get that fix :)

Hi @scanny, facing this similar issue again. Unstructured version is 0.16.5.
here's the trace:
File "/usr/local/lib/python3.10/site-packages/unstructured/nlp/tokenize.py", line 86, in download_nltk_packagesn    urllib.request.urlretrieve(NLTK_DATA_URL, tgz_file_path)n  File "/usr/local/lib/python3.10/urllib/request.py", line 241, in urlretrieven    with contextlib.closing(urlopen(url, data)) as fp:n  File "/usr/local/lib/python3.10/urllib/request.py", line 216, in urlopenn    return opener.open(url, data, timeout)n  File "/usr/local/lib/python3.10/urllib/request.py", line 525, in openn    response = meth(req, response)n  File "/usr/local/lib/python3.10/urllib/request.py", line 634, in http_responsen    response = self.parent.error(n  File "/usr/local/lib/python3.10/urllib/request.py", line 563, in errorn    return self._call_chain(*args)n  File "/usr/local/lib/python3.10/urllib/request.py", line 496, in _call_chainn    result = func(*args)n  File "/usr/local/lib/python3.10/urllib/request.py", line 643, in http_error_defaultn    raise HTTPError(req.full_url, code, msg, hdrs, fp)nurllib.error.HTTPError: HTTP Error 403: Forbidden

Track on #3795