API call to require() module

I propose an API call which would do the equivalent of require("foo") and push the exports object onto the stack.  In minisphere 4.0 I want to move to a more modular core API like Node.js has and it would be useful to be able to access core modules from C code.

Thinking about this a bit more, an API which is just an interface for require() is a ticking time bomb security-wise: Even if you can guarantee you'll get the right module with a given name--which is not easy to guarantee, depending on how your module loader is set up--there's still the risk that some JS code will overwrite your modSearch and then all bets are off.
It's also not particularly useful in most cases to load C modules this way--if you already have the functionality implemented natively, you can just call the native functions directly.
What would be useful, however, is the ability to compile/evaluate a given piece of code as though it were a CommonJS module, and push the exports to the stack.  This would allow use cases such as loading the TypeScript transpiler as a module directly from C (minisphere, e.g., loads this using duk_eval(), which pollutes the global object).
This could probably even be done without much footprint cost, since the "execute as module" primitive already needs to exist in order to have a built-in require().

Adding a C API for require() has been my intention also. When I wrote the original loader mechanism I intended to add it, but it's not as straightforward as just adding a duk_require(ctx, id) API call if one wants to support relative module resolution for C code too, so I had to postpone it. For example, if a native module is loaded, its initialization code may want to load more modules relative to its own module ID.
The API needs to handle that somehow, perhaps via an explicit resolution root argument or some hidden state. The explicit resolution root would be something like duk_require(ctx, root, id). I'd prefer an explicit resolution root over hidden state (as is done for Ecmascript code out of necessity) because it's stateless and makes fewer assumptions about how the mechanism is used which is nice in the C API.
Re: overwriting Duktape.modSearch, that doesn't seem like a security issue to me:

The code that could potentially overwrite Duktape.modSearch can also eval arbitrary code, edit Duktape.modLoaded directly to forcibly load/unload modules, etc. I don't think the effects of replacing Duktape.modSearch are any more serious.
All code being loaded is ultimately controlled by the application. So if the application only provides trusted code via module loading, the only real issue would be accidental overwriting (which doesn't seem like an important issue to me). On the other hand, if the module loader loads untrusted code all the sandboxing issues come into play, and removing visibility of Duktape.modLoaded from application code is one of the sandboxing measures typically used.

Regardless, having "execute as a module" as a primitive would be useful and should handle ES6 modules too.

For the security issues I was more referring to the case where some C code calls duk_require() expecting to get a known module back and ends up getting something else entirely because modSearch has been replaced.  It's unsafe for the same reason it's unsafe to do, say:
duk_get_global_string(ctx, "Duktape");
duk_get_prop_string(ctx, -1, "act");
duk_call(ctx, 0);

Because modSearch can be replaced on the JS side (unless C code disables it by making the property nonwritable) the only safe time for native code to load a module by name is when it's doing so on behalf of Ecmascript code.  The native code can't safely make any assumptions about what it gets back.
If every line of JS code run by the app is trusted, this isn't an issue of course.  But that's not often the case - in my experience people use scripting engines because they want their app to be extensible. :)

Yes, but what code will replace modSearch if all code is from a trusted source? And if not, there are a lot of issues to consider re: sandboxing if untrusted code (actively malicious rather than just broken) is going to be executed.

Note the difference between accidents (say, a broken application extension) vs. actively malicious code. It seems highly unlikely to me that a module accidentally replaces modSearch. Actively malicious code can do that and much more besides, which is where the sandboxing issues (all of them) come into play. I don't see this API as a special case: it's as safe or unsafe as saying require('foo') from Ecmascript code, or duk_eval_string(ctx, "require('foo')"); why should a direct C API be any different?

If all the code is trusted, there's no issue.  However that's often not the case - think platforms like Node.js or even minisphere.  In environments like that it would never be safe for C code to call require.
Maybe the code being run isn't even malicious, but has still replaced modSearch as part of implementing a custom module system.  in that case the C code might expect duk_require() to return one thing but it ends up returning something else (or throwing).  Here it's not a security issue, of course, it just prevents the user from replacing the module loader due to assumptions made by the native code.

If all the code is trusted, there's no issue. However that's often not the case - think platforms like Node.js or even minisphere. In environments like that it would never be safe for C code to call require.

But in such cases it's never safe to e.g. eval, print, console.log, JSON.parse etc: all of these can be replaced at any time by anything. Also stringifying values is unsafe because Object.prototype.toString() can be replaced, and so on.
I don't see why this API call is any different from these - or duk_eval_string(ctx, "require('foo')").

Agreed, which is why Duktape has e.g. duk_json_decode(). :)  I would never reference JSON.parse() directly from C for exactly that reason - it's not predictable.
I feel like I'm failing to articulate this properly - me typing on an iPhone likely has something to do with it.  I'll think on it some more.

Hmm, so when you say:

In environments like that it would never be safe for C code to call require.

... do you also mean that it's equally unsafe to use require() from Ecmascript in such environments?
In other words, you're actually more interested about loading a specific file bypassing the module cache rather than loading a module which would also be visible and shared by other callers? That would certainly be possible but the downside would be that the module wouldn't be cached or shared; if it were, it's exports table could again be modified by untrusted code.
By the way, if untrusted code is really an issue, it's pretty easy to hide the entire Duktape object from user code. This also makes the environment less Duktape specific. Or, if you need a few variables from the Duktape object, you can construct a replacement while the original retains a hidden reference and is used for the module cache.

I would never reference JSON.parse() directly from C for exactly that reason - it's not predictable.

Would the same apply to Ecmascript code which is part of the engine/platform? If not, why not? :)
But I think I see what you mean, and if I'm correct you're actually not really wanting to do a require() but rather load a module bypassing the module loader (including the search mechanism, caching, sharing, etc).

Hmm, so suppose I load a module bypassing the module loader stuff and that module requires a sub-module. How should that get handled?
If that sub-require is loaded using the module loader, you'll have the same issue trusting the result (in your use case) because arbitrary stuff may be loaded.
If the sub-require is not handled by the module loader, how should it be handled?
Maybe in your use case the solution would be to have a separate "module loader domain" with a separate search function, separate module cache, which wouldn't be accessible to user code.

Okay, let's stop using the word "untrusted" because that's a loaded term - despite what I said above I'm not actually concerned with security in this case.  My concern is more practical.  What it comes down to is that native code and Ecmascript may be written by different people.  Each one is a black box from the perspective of the other, mediated by a scripting language where monkey-patching is encouraged.  So to answer your question above:

Would the same apply to Ecmascript code which is part of the engine/platform? If not, why not? :)

No, it would not.  If JSON.parse has been monkey-patched by Ecmascript code, then the Ecmascript code can deal with the fallout.  The native code, in the general case, cannot--and in fact has no way of even knowing the rug was pulled out from under it.

Point taken on the submodule issue, though.  Unfortunately I don't really have any ideas how to handle that...

Regarding hiding of the Duktape object: I briefly considered using duk_del_prop_string() to remove the object, but then I wondered if that would also prevent Duktape itself from accessing Duktape.modSearch.  Which actually highlights what I was getting at with the black box comment, now that I think of it...

Maybe you're assuming Ecmascript code wouldn't be used for writing the infrastructure/platform parts (this is not generally true however)?
But in any case I think this is definitely not an issue for a duk_require() C API call, which I think should more or less just mimic duk_eval_string(ctx, "require('foo')") at least re: trusting modules. A separate mechanism for loading code in a module context may be needed in the future, as the function wrapper is a bit awkward and a little less efficient that necessary.

Regarding hiding of the Duktape object: I briefly considered using duk_del_prop_string() to remove the object, but then I wondered if that would also prevent Duktape itself from accessing Duktape.modSearch. Which actually highlights what I was getting at with the black box comment, now that I think of it...

That should be covered by the sandboxing documentation. Briefly, Duktape needs to maintain hidden references to various internal objects to satisfy Ecmascript semantics as many operations depend on the "original" value of certain built-ins. Internally these references are e.g. thr->builtins[DUK_BIDX_ARRAY_PROTOTYPE].
The same applies to Duktape.modSearch(), the default require() implementation looks it up like this:
https://github.com/svaarala/duktape/blob/master/src/duk_bi_global.c#L1068-L1069
So yes, that will work even after you've deleted the visible Duktape object reference from the global object, as Duktape won't look up the object via the global object.
A bit off topic, this is one more example why I think the module loading mechanism should be more separated from Duktape core: for some environments it's very nice that Ecmascript code can implement a module search function so that it's easy to play with etc, while in others it'd make much more sense if the loading mechanism (including a search function, module cache, etc) would only be visible to C without having to go into actual sandboxing stuff.

Right, as long as the native code and Ecmascript code are written by the same person (or in general, the same entity), there's no issue.    In that case it's not even safe for the infrastructure code written in Ecmascript to access built-ins because the user code may have replaced them (with good intentions even!)
The main difference as far as I'm concerned is that it's easy for the startup code written in JS to simply do var _JSON = JSON; etc. before running any user code.  That's... well, quite a bit more tedious to do in C code.  Generally you'd have to use the stash for something like that.

All that said, I do understand your point that it's not qualitatively different from the other "unsafe" cases and is just a consequence of using a scripting language where monkey-patching is encouraged.  So if you think there's a use case for duk_require(), I wouldn't be against it.
However in my case it's not what I need.  What I need is the ability to execute module code as a module so that I can load, say, the TypeScript transpiler without making it visible through the global object in the process.  Currently I would need to create a separate heap for this, which is kind of overkill and somewhat inelegant. :)

Right, but generally it's quite difficult to get any useful guarantees. For example, doing var _JSON = JSON; is not enough because user code can make even the stored JSON reference useless:
duk> Object.prototype.toJSON = function () { return 'foo'; };
= function anon() {/* ecmascript */}
duk> JSON.stringify([ 1, 2, 3])
= "foo"

So what I'm trying to say is that there are no actual guarantees from Duktape to prevent these (other than actual sandboxing) because there's no easily defined, useful, and consistent goal for such guarantees, at least that I can think of, without going into actual sandboxing.

Agree, I think I understand what you'd like to accomplish, and in summary:

Ability load code in a "module context" would be useful, though this doesn't solve the issue with sub-modules.
Ability to have module loader domains which are kept separate would be useful.

As a first thought I don't think Duktape should try to provide a module loading mechanism with multiple security domains and such. It seems better to actually make fewer assumptions than currently but make it possible to write an application which has a module loader "on the side" if that requires Duktape support (e.g. the ability to load code in module context without writing the tedious wrappers yourself).

Instead of multiple domains, what if duk_eval_module() (placeholder name) got as a parameter, a callback function which would receive the resolved module ID and return either the submodule source or exports on the valstack?  So basically, an impromptu modSearch.

In addition to handling sub-requires there's also the issue of module caching/sharing which would need an additional module cache parameter. Also note that modules may not be require'd at load time so that callback would need to be in place indefinitely as would the cache. Adding these would essentially mean implementing the ability to have multiple module loaders in a single global environment, so I don't see easy (and version/feature stable) shortcuts.

That's true.
As an initial implementation I would be okay with it if submodules were loaded using the normal modSearch (the transpiler has no external dependencies anyway),  we'd just have to be careful to do it in a way that doesn't prevent extensibility in the future. :)

Right, and that's really my concern: adding a little bit of it makes it a versioning concern which needs a lot of cumulative work and distraction to support and back out of if it turns out to be wrong.
So I'd rather Duktape core not get involved in application module loading strategies (there are so many different approaches with quite different issues involved) except to provide the lowest level primitives needed to implement them. For example, you can implement a parallel module loader even currently as there's very little magic in the built-in loader (the function wrapper stuff can be used in the same way). I don't mind providing examples in the distributable of course.

Maybe another issue to address in the 2.x module reword would be support for multiple module loaders in one global context. Though I'm not sure if there's much to address except to make sure there are no missing pieces in running multiple loaders in parallel.
There needs to be a module loader to handle require() and import from global code but this shouldn't prevent the application from using a separate loader e.g. for infrastructure components. So what's needed is the ability to initiate a module load using some module loader with that loader being inherited for sub-module loading. That doesn't require anything from Duktape for the CommonJS case because one can just create a new require for every module as Duktape does now (no direct support is needed from Duktape to do this). However, it may need some support for the ES6 module case because import is a keyword (unlike require which is a function binding).

The main thing that has stopped me from rolling my own require so far is that the "magic" needed to support relative module IDs is tedious to implement in C (and it has to be in C because my engine is heavily sandboxed w.r.t. the file system).

You could just copy the current implementation and modify it :)

Anyway, I see your point. Maybe it could be implemented differently in the future, ES6 import will need something different in any case as it can't be replaced for each module being loaded.
Maybe Duktape could provide a "current module" context which both a CommonJS loader and ES6 loader could work with.

I'll look later, but I'm assuming you attach the resolved ID directly to the require function somehow and then look that up when it's called.

Yeah, it's stored in the require function and looked up using duk_push_current_function().
Re: that module context, here's roughly what I mean. Suppose foo/bar.js is loaded and it has the module ID foo/bar:
// foo/bar.js

var _currentModule = module;  // for later lookups

function test() {
    // Eventual sub-require when called.
    var sub = require('./quux');
}

exports.test = test;

When require() is called it could get access to the calling module using a duk_push_calling_module() or something thereof. That function would: (1) look up the calling function, (2) look up _currentModule within that function using a slow path lookup. The result would be the module table relevant to the calling function, which is the same for all functions declared in a module (regardless of nesting). The variable name would in an actual implementation be an internal one so that it'd be invisible as far as standard semantics are concerned.
A similar approach would be to attach a .module to each declared function, with the value being the same for all functions declared inside a module. But this would be property bloat compared to the alternative presented above.

The above is (probably) technically incorrect if a module exports its require function which then gets called from someone outside the module:
// foo.js
exports.myRequire = require;

With the current require() implementation require('foo').myRequire('./bar') it will get resolved relative to foo as if the require() was inside the module. With the proposal above it would get resolved relative to the call site of .myRequire().
This is probably not a practical concern though; and you can't export the "import context" of an ES6 module so it's a CommonJS issue only.

Note that Node.js has module.require():
https://nodejs.org/docs/latest/api/modules.html#modules_module_require_id
So there might be modules in the wild that rely on calling require() using another module's context, although I imagine the use cases would be limited and it doesn't apply to Duktape in its current state anyway.

With the current anonymous function approach that case could be handled by prepending this to the module being loaded:
module.require = function (id) { return require(id); };

That way the require call would always come from the module source itself.
This behavior is beyond CommonJS but still an interesting point of comparison. If the module context must follow require then it more or less has to be in the function itself, which also means a separate function needs to be created for every module loaded which is not ideal for low memory environments.

I'd be curious to investigate how Node.js implements require().  Given that it does have a separate module.require (instead of saying, just export require yourself), I wonder if it actually uses some kind of context tracking like you mentioned above for bare require...

Interesting tidbit from the CommonJS spec:

Relative identifiers are resolved relative to the identifier of the module in which "require" is written and called.

Emphasis mine.  Technically Duktape is out of spec right now.

Interesting indeed :) I don't really understand that requirement completely. What would it mean, for example, to say:
var foo = otherModule.exportedRequire;
foo();

require is not "written" here (assuming that part refers to the function name being called) but is called. That may seem like an odd distinction but eval semantics already do that to distinguish between direct and indirect eval calls.
I'm assuming that simply refers to the call site because anything else would impose requirements on the engine. Assuming it simply refers to the call site, the current Duktape implementation is then indeed violating the specification for an exported require function. The "_currentModule" approach I described above would actually fix that. Or maybe not completely; there are odd cases like calling through a with binding where the binding object is declared in yet another module, perhaps provided through a Proxy, etc, etc. Hardly real world cases though :)

My assumption would be the same, that it refers to the call site.  Which explains the existence of module.require in Node - exporting require normally wouldn't work.

I'll need to check how other CommonJS implementations actually behave, as even "call site" is not always that well defined, consider e.g. evals:
var req = require('foo/bar').myRequire;

eval('req("./quux")');

var indirectEval = eval;
var globalObject = new Function('return this')();
globalObject.req = req;  // make available for indirect eval
indirectEval('req("./quux")');

A direct eval executes in the call site context so maybe that should resolve relative to the file where "eval" is called. On the other hand for Duktape eval code is a separate compilation unit. An indirect eval executes in the global context so maybe that shouldn't. These are not as trivial to implement (at least in Duktape) as just looking up the caller function.
Function constructor is also interesting:
var req = require('foo/bar').myRequire;

var fun = new Function('r', 'r("./quux")');
fun(req);

Because the created function executes in the global scope it might be logical that resolution would also happen as if for global code.
Anyway, this is good to look into when things are changed around the module mechanism :)

Hm, I guess this is no longer relevant now that module support has been moved out of Duktape core.  Move to close?

Maybe not - there will be an ES6 import mechanism later on. With the module mechanism out of the core I think the cleanest way to implement that would be to provide a way to register the provider for require/ES6 import. And there should also be a C API to require/import a module. Not sure how it would work yet, but this is still relevant.


any todo on Separable Convs after Conv2D is done?

@geohot we can get that speeeed!

That's already supported with the groups argument!

@geohot
im talking about depthwise convolution which are 7x less params than normal.
https://towardsdatascience.com/a-basic-introduction-to-separable-convolutions-b99ec3102728
depthwise separable conv -> depthwise conv + point wise conv


[Network]: get virtualnetwork gateway vpn connection health

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[x] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-js

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Automation for azure-sdk-for-ruby

Can one of the admins verify this patch?

Automation for azure-sdk-for-java

@EvgenyAgafonchikov could you check Network CI?

@sergey-shandar, it looks like jobs are green now. Though I see

The agent: Hosted VS2017 3 lost communication with the server.

for NetworkValidation step, it seems to be DevOps internal issue.
Cannot find the way to restart the job to re-check (possible because it is marked as passed).

@sergey-shandar, it looks like jobs are green now. Though I see
The agent: Hosted VS2017 3 lost communication with the server.
for NetworkValidation step, it seems to be DevOps internal issue.
Cannot find the way to restart the job to re-check (possible because it is marked as passed).

Does that mean that we can merge this PR?


Upgrade snakeYaml and woodstox versions

Purpose
$title
Fixes: #40060
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

We need to test whether this will change the error messages and if changes this will be a breaking change as well. In that case better to include in the release note.

We need to test whether this will change the error messages and if changes this will be a breaking change as well. In that case better to include in the release note.

Compared error messages with 1.2.37, there is no change in error messages


Support for OpenAPI Specification 3.1

Hello,
I'm reaching out on behalf of the team at Hasura, where we've been utilizing the openapi-to-graphql library extensively. Specifically, we've integrated it within our services to facilitate users in creating actions from an OpenAPI specification.
Recently, we've noticed a surge in user requests, urging us to support OpenAPI Specification 3.1. Given the growing demand and the advancements in the 3.1 spec, it would be beneficial for the openapi-to-graphql library to consider this version.
Do you have a plan to implement support for version 3.1?
We can imagine two possible solutions:

Translate 3.1 to 3.0: this is similar to the current support for 2.1, using an external library or mechanism to downgrade the 3.1 specifications to 3.0.

Switch Primary Support from 3.0 to 3.1: and finding a method to translate from 3.0 to 3.1, as the library do now from 2.1 to 3.0

We understand each approach has pros and cons and would require a certain development effort.
We would like to know your thoughts and if there is any way that we could help.
Thanks!
Daniele

@dancamma Currently, OtG is not being actively maintained. We are currently looking to onboard new maintainers. If that interests you at all, please let me know. Otherwise, sadly, development for OtG is paused for the time being.


[Message/Header] - Add Support for Icon Groups

Hi.
When using a group of icons in a message, they lose their size and margin. Test in this JSFiddle.

Most components currently do not support icon groups. I could see including support for message and header, which might use this pattern more frequently, but changing all instances of icon across components would be a big deal lib wise.

You may consider about .icon.icons if it suitable across whole library

Would have to replicate the whole rule in each case, i.e
.ui.icon.message > .icon:not(.close),
.ui.icon.message > .icons {

}

@jlukic why '.icon.icons' not valid?
It steal matching
.ui.icon.message > .icon:not(.close) {
}

The community fork Fomantic-UI now supports icon groups in header and message by
https://github.com/fomantic/Fomantic-UI/pull/1798 and
https://github.com/fomantic/Fomantic-UI/pull/1799


Show issue title for comment news feeds

it could go just under the header line:
username commented on issue organisation/project-name#221
Need to process the input using sql queries directly
"Comment text goes here"
This is because with so many issues, it can become a little confusing what issue number refers to what issue!

Hi, you now can test this on develop branch and https://try.gogs.io

Tested and seems to work fine. However, when you create a new issue, on the dashboard, it just displays the title where the comment body goes for this issue - could this same style in this issue be applied to new issues?
e.g.:
Username opened issue org/projname#44 - Something is broken
A short few lines of the body of the issue here...

Make sense..

Here we go again! https://try.gogs.io/


Serve IPFS API

Optionally serve the IPFS API if the API addr is specified in the config.

Coverage remained the same at 26.636% when pulling 8056c5480cd8b8c9c5af8f75c2907b69294e34db on api into c9965134630dfd6586cfc9728a59c15dd832f259 on master.


[Migrated] ImportError: cannot import name six after update

Originally from: https://github.com/Miserlou/Zappa/issues/886 by dvschramm

Context

After deployment or update, the six library cannot be found. this is when using the boto library to work with kinesis

Virtual environment and 2.7
Expected Behavior

You should be able to import six without issue.
Actual Behavior

when using the boto library you get an ImportError
 from boto import kinesis   File "/var/task/boto/__init__.py", line 27, in <module>   from boto.pyami.config import Config, BotoConfigLocations   File "/var/task/boto/pyami/config.py", line 29, in <module>   from boto.compat import expanduser, ConfigParser, NoOptionError, NoSectionError, StringIO   File "/var/task/boto/compat.py", line 49, in <module>   from boto.vendored import six ImportError: cannot import name six
Possible Fix

Not sure. When I uninstalled six locally, then reinstalled locally then did an update. It worked.
Steps to Reproduce

create a file that uses boto to import kinesis "from boto import kinesis"
zappa update or deploy
run the specified code

Your Environment

Zappa version used:  zappa==0.42.0

Operating System and Python version:  OSX Python2.7

The output of pip freeze:
Flask==0.12.2
Jinja2==2.9.6
MarkupSafe==1.0
PyYAML==3.12
Unidecode==0.04.20
Werkzeug==0.12
amqp==2.1.4
appdirs==1.4.3
argcomplete==1.8.2
base58==0.2.4
billiard==<IP_ADDRESS>
boto==2.46.1
boto3==1.4.4
botocore==1.5.40
cached-property==1.3.0
celery==4.0.2
click==6.7
defusedxml==0.5.0
docutils==0.13.1
durationpy==0.4
future==0.16.0
futures==3.1.1
hjson==2.0.2
isodate==0.5.4
itsdangerous==0.24
jmespath==0.9.2
kappa==0.6.0
kombu==4.0.2
lambda-packages==0.15.0
lxml==3.7.3
optionaldict==0.1.1
packaging==16.8
placebo==0.8.1
pycrypto==2.6.1
pyparsing==2.2.0
python-dateutil==2.6.0
python-slugify==1.2.4
pytz==2017.2
requests==2.14.2
requests-toolbelt==0.7.1
s3transfer==0.1.10
six==1.10.0
toml==0.9.2
tqdm==4.11.2
troposphere==1.9.3
vine==1.1.3
wechatpy==1.4.1
wheel==0.29.0
wsgi-request-logger==0.4.6
wsgiref==0.1.2
xmltodict==0.11.0
zappa==0.42.0
zeep==1.6.0

Link to your project (optional):  client project

Your zappa_settings.py:
{
"dev": {
"debug":true,
"log_level": "DEBUG",
"app_function": "app.app",
"s3_bucket": "zappa-faqhhfe4o",
"events": [{
"function": "connector.process_chatstream_events",
"event_source": {
"arn":  "arn:aws:kinesis:us-west-1:406498607568:stream/blueleapchat",
"starting_postion": "TRIM_HORIZON",
"batch_size": 50,
"enabled": true
}
}]
}
}

python2.7 no longer supported.
closing.


Update sbt-updates to 0.6.3

Updates com.timushev.sbt:sbt-updates from 0.6.2 to 0.6.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.timushev.sbt", artifactId = "sbt-updates" } ]

labels: sbt-plugin-update, early-semver-minor, semver-spec-patch, commit-count:1

Codecov Report

Merging #55 (359579c) into main (8b63391) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines          316       316
  Branches         6         6
=========================================
  Hits           316       316

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b63391...359579c. Read the comment docs.


VITS codes failed to run for Python 3.10.12

Hi, I managed to run VITS on Python 3.8.12 but when I upgraded to Python 3.10.12, I've got the following error:
Traceback (most recent call last):
File "/content/drive/MyDrive/vits/train.py", line 290, in
main()
File "/content/drive/MyDrive/vits/train.py", line 50, in main
mp.spawn(run, nprocs=n_gpus, args=(n_gpus, hps,))
File "/usr/local/lib/python3.10/dist-packages/torch/multiprocessing/spawn.py", line 239, in spawn
return start_processes(fn, args, nprocs, join, daemon, start_method='spawn')
File "/usr/local/lib/python3.10/dist-packages/torch/multiprocessing/spawn.py", line 197, in start_processes
while not context.join():
File "/usr/local/lib/python3.10/dist-packages/torch/multiprocessing/spawn.py", line 160, in join
raise ProcessRaisedException(msg, error_index, failed_process.pid)
torch.multiprocessing.spawn.ProcessRaisedException:
-- Process 0 terminated with the following error:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/torch/multiprocessing/spawn.py", line 69, in _wrap
fn(i, *args)
File "/content/drive/MyDrive/vits/train.py", line 117, in run
train_and_evaluate(rank, epoch, hps, [net_g, net_d], [optim_g, optim_d], [scheduler_g, scheduler_d], scaler, [train_loader, eval_loader], logger, [writer, writer_eval])
File "/content/drive/MyDrive/vits/train.py", line 137, in train_and_evaluate
for batch_idx, (x, x_lengths, spec, spec_lengths, y, y_lengths) in enumerate(train_loader):
File "/usr/local/lib/python3.10/dist-packages/torch/utils/data/dataloader.py", line 633, in next
data = self._next_data()
File "/usr/local/lib/python3.10/dist-packages/torch/utils/data/dataloader.py", line 1345, in _next_data
return self._process_data(data)
File "/usr/local/lib/python3.10/dist-packages/torch/utils/data/dataloader.py", line 1371, in _process_data
data.reraise()
File "/usr/local/lib/python3.10/dist-packages/torch/_utils.py", line 644, in reraise
raise exception
IndexError: Caught IndexError in DataLoader worker process 0.
Original Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/torch/utils/data/_utils/worker.py", line 308, in _worker_loop
data = fetcher.fetch(index)
File "/usr/local/lib/python3.10/dist-packages/torch/utils/data/_utils/fetch.py", line 54, in fetch
return self.collate_fn(data)
File "/content/drive/MyDrive/vits/data_utils.py", line 114, in call
torch.LongTensor([x[1].size(1) for x in batch]),
File "/content/drive/MyDrive/vits/data_utils.py", line 114, in
torch.LongTensor([x[1].size(1) for x in batch]),
IndexError: Dimension out of range (expected to be in range of [-1, 0], but got 1)
It appears Python 3.10.12 is complaining the input tensor is of wrong shape but that doesn't happen for Python 3.8
May I ask why is this happening? Thanks.

You can try running the code using Python3.7. Python3.7 works for me.


Switch from Travis-CI to GHA

Signed-off-by: Daniel Egger<EMAIL_ADDRESS>

r? @ryankurte
(rust_highfive has picked a reviewer for you, use r? to override)

Huh, what did we have a GitLab CI file for?
bors try

No idea. Seems James has introduced it in early 2018.

@jamesmunns / @Emilgardis any idea what the GitLab CI file was for?

@adamgreig a while ago I ran svd2rust_regress on my gitlab instance, which mirrored the GitHub repo. It's not needed anymore.

Thanks for confirming!
bors merge


add metric for current config generation

@geirst please review
@yngveaasheim @bratseth FYI

I've changed the name to "content.proton.config.generation" now.  It's possible to change it to "content.config.generation" with some restructuring, but getting to "config.generation" would need rewriting the proton metrics engine to have multiple root metric-sets.

👍 thanks!


[stdlib][SR-2239]: add support for AAPCS64 variadics

Support variadics on aarch64 aapcs64

Resolves SR-2239.

@swift-ci Please smoke test

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 22d98a1feb08eef327c283ef3b0db1132ef5b86e

Just fix spacing, indentation and formatting.

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 22d98a1feb08eef327c283ef3b0db1132ef5b86e

@swift-ci please test macOS platform

I tried applying these changes as a patch to swift-4.1-DEVELOPMENT-SNAPSHOT-2018-03-05-a since that branch has many fewer test failures than master on Linux aarch64.  The ClangImporter/ctypes_parse.swift test passes now but the stdlib/VarArgs.swift test still fails (although it does much better).  It looks like handling of FP arguments is not correct:
/scratch/jasonm/swift-4.1-DEV-2018-03-05_AAPCS64-patch/swift/test/stdlib/VarArgs.swift:21:12: error: expected string not found in input
 // CHECK: The answer to life and everything is 42, 42, -42, 3.14
           ^
<stdin>:1:1: note: scanning from here
The answer to life and everything is 42, 42, -42, 0.000000
^

NB: I'm a swift newbie so I apologize if I'm doing something wrong here but I thought my input might help.

@jasonm128
The VarArgs.swift should pass in the last patch. Just tested on aarch64 android.

I can confirm that this latest version fixes the VarArgs.swift test on Linux aarch64 (Ubuntu 16.04).
However, since the whole sizeof(double)/sizeof(int) thing didn't work, I think it might be clearer to just set _fpRegisterWords = 2.  This would match the style of the other architectures in this file.  I'll defer to @compnerd on this though.

@swift-ci please test

@swift-ci please test

Can we get this merged with the "swift-4.1-branch" and the "swift-4.2-branch"?

@compnerd please take a look?

@airspeedswift @jrose-apple can you help?
This issue is blocking all the builds on https://ci-external.swift.org/computer/ubuntu-16.04-aarch64/
What do we need to do to get this approved and merged?
Thanks.

@jrose-apple thanks for looking at this.

@KoVuInc @jasonm128 are you available to update this PR?

@futurejones I'm willing to help but I'm not sure I'm able. I'm still new to Swift so I'm not familiar with a lot of the subtleties. I maintain an aarch64 system and have been trying to make Swift available for other users. I also don't have push access to the OP's repo. Let's see if @KoVuInc is available and I'll try to help if not.

@futurejones @jasonm128  Sure, I'll spend sometime to update this PR.

@KoVuInc It's been a while and there hasn't been any activity here.  The SR has been released back to the community.  Thank you for everything you did here.  I'm sure some other contributor will find this patch a very helpful place to start.


Using a custom MDX file for the AutoDocs Page Template causes a build error when running tests

Describe the bug
Our project uses a custom DocumentationTemplate.mdx file. The storybook and build-storybook commands work with no issue. When I try to run the tests with this addon, a build error is thrown. Removing the custom docs page template allows the tests to run.
Error
Module parse failed: Unexpected token (12:0)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| import { UsageExample } from './usageBlock';
|
> <Meta isTemplate />
|
| <Title />
=> Failed to build the preview

Template file
import {
  Meta,
  Title,
  Subtitle,
  Description,
  Primary,
  Controls,
  Stories,
} from '@storybook/blocks';
import { UsageExample } from './usageBlock';

<Meta isTemplate /> {/* This is where it errors out */}

<Title />

<Subtitle />

<Description />

<UsageExample />

## Primary Example

<Primary />

## Properties Reference

<Controls />

## Additional Stories

<Stories />

preview.js
import DocumentationTemplate from './DocumentationTemplate.mdx';
import { setCustomElementsManifest } from '@storybook/web-components';
import customElements from '../custom-elements.json';

export default {
  parameters: {
    docs: {
      page: DocumentationTemplate,
    },
    backgrounds: { disable: true },
  },
};

setCustomElementsManifest(customElements);

To reproduce
Here is a link to a branch on our repo where the error can be reproduced: https://github.com/kyndryl-design-system/shidoka-foundation/tree/docs/visual-testing
Environment
Latest versions of storybook and this addon.

@brian-patrick-3 thanks for filing. this looks like a corner case. in order to speed up Storybook's build process in the visual test addon, we run a "test" build which is like a normal build but with a bunch of features turned off. You can try manually re-enabling them. I'm guessing the MDX one specifically might solve it:
https://storybook.js.org/docs/api/main-config-build#testdisablemdxentries

@shilman Hello, I also encountered the same situation. Even after making disableMDXEntries: true, still the same error happens (sample repository). This situation seems to be happening when a mdx file is called in a TypeScript file.
Example:
import mdx from "./Button.mdx";

const meta = {
  title: "Example/Button",
  component: Button,
  parameters: {
    layout: "centered",
    docs: {
      page: mdx, // this seems to be causing the error
      iframeHeight: 100,
    },
    viewMode: "docs",
  },
} satisfies Meta<typeof Button>;

Thank you.

Same issue here. I'm using Svelte, and the error log is a bit different:
Error: [storybook:external-globals-plugin] Parse error @:10:145
file: [...]/src/stories/Card.mdx
    at parse (.\node_modules\es-module-lexer\dist\lexer.cjs:1:402)
    at Object.transform (.\node_modules\@storybook\builder-vite\dist\index.js:55:3377)
    at file:///[...]/node_modules/rollup/dist/es/shared/node-entry.js:19579:40

I also have the import mdx from './file.mdx', which is then used with docs: { page: mdx }, and test: { disableMDXEntries: false }` does not fix the error.

Possibly related: https://github.com/storybookjs/storybook/issues/25114

I think MDX files need addon-docs to be enabled, so the test.disabledAddons setting should help instead:
// Replace your-framework with the framework you are using (e.g., react-webpack5, vue3-vite)
import type { StorybookConfig } from '@storybook/your-framework';

const config: StorybookConfig = {
  framework: '@storybook/your-framework',
  stories: ['../src/**/*.mdx', '../src/**/*.stories.@(js|jsx|mjs|ts|tsx)'],
  addons: [
    '@storybook/addon-links',
    '@storybook/addon-essentials',
    '@storybook/addon-interactions',
    '@storybook/addon-a11y',
  ],
  build: {
    test: {
      disabledAddons: [], // 👈 don't disable any addons
    },
  },
};

export default config;

Possible fixes we could do:

Be smart about detecting MDX file imports in the preview and enable addon-docs if they are there - this sounds like a lot of effort and static analysis complexity
Have an "mdx imports are no-ops" builder plugin/loader when in test mode. Making the import not crash but just do nothing instead.
Improve the build-time error to describe how to enable addon-docs. (this might solve general confusions about MDX, not just when it breaks in test/VTA mode)
Document this shortcoming in the VTA docs.

I had the same as issue starter. I had MDX files as well. So i thought read the docs and disable them in build: test. But still an error. Then i runned the command it would do (for example pnpm run build-storybook --output-dir=/var/folders/bm/ytjcjmvn3jz405v52dxmmz4r0000gn/T/chromatic--37144-qPMX3BxyAlXt --webpack-stats-json=/var/folders/bm/ytjcjmvn3jz405v52dxmmz4r0000gn/T/chromatic--37144-qPMX3BxyAlXt) and this didn't fail on the mdx part. So then i cried and started googling :)
Very glad to find the same issue and the fix by @JReinhold just to add disabledAddons: [], // 👈 don't disable any addons since the mdx part is in the @storybook/addon-essentials. Please update this in the docs team :)


update pdfjs to latest 4.6.82

build our viewer.js with the source of pdf.js (it should be easy if we switch to gulp, use DefinePlugin to mock it too ugly)
use the global event bus, and remove _boundEvents (api change in pdfjs)

should close https://github.com/FirstTimeInForever/intellij-pdf-viewer/pull/102

before update, there are different pdf.js versions:

cmaps, pdf.worker.js, pdf_viewer.css, 2.6.347, via pdfjs-dist in package.json
images, locale, 2.5.207, via pdf.js in postinstall.js
viewer.css, 2.7.570, with little modification
viewer.html (index.html), viewer.js, 2.8.335, with little modification
// viewer.html and viewer.js doesn't change much from 2.8.335 to 2.12.313

after update, the versions are updated to the same version.

I'm thinking of remove pdfjs-dist in npm, and use the pdf.js releases .
pdfjs-dist in npm never distribute the default viewer, and has no plan.
https://github.com/mozilla/pdf.js/issues/5609
https://github.com/mozilla/pdf.js/issues/5709
https://github.com/mozilla/pdf.js/issues/6545
https://github.com/mozilla/pdf.js/issues/7203
https://github.com/mozilla/pdf.js/issues/7780
https://github.com/mozilla/pdf.js/issues/9127
https://github.com/mozilla/pdf.js/issues/9144
https://github.com/mozilla/pdf.js/issues/9210
https://github.com/mozilla/pdf.js/issues/16997
If we choose pdf.js releases, it would be simple in bootstrap.
we can only inject our viewer.js and fixes.css.

Thanks for the links, strange decision they made! I agree intwould be a lot better if we could use the source including the default viewer directly, that would make updating a lot easier. A pull request would be greatly appreciated!
I'll merge this one already so at least we have a working version.


Bug: Developer's Delight and Teleport Probe are usable without actually having the item.

If the Developer's Delight or Teleport Probe is added to the client-side inventory without actually being in the server-side inventory and it is used, it will still work.  There should be a check in the packets which checks if the Developer's Delight or Teleport Probe is in the player's hand before doing what the packets request.

I can't fix this for the developers delight item as it is fully client side. So there is no packet to the server.
With the teleport probe I can also not easily prevent opening the GUI but I can prevent the teleport. So I'll do that then

The probe abuse is fixed next release


[CLI]: early_terminate param for sweep configuration does not appear to work at all

Describe the bug

(technically, since the sweep feature is serviced by your own backend, this is not a bug on the wandb client)
The early_terminate param for the sweep configuration does not work at all in my testing. I actually read the source code implementation (https://github.com/wandb/sweeps/blob/master/src/sweeps/hyperband_stopping.py#L48) since the documentation is atrocious, so I tried to test early_terminate for myself. Here is a report of the test using a dummy sweep: https://api.wandb.ai/links/yanyiphei/9um766xr (I wanted to share the sweep directly but I dont think theres a way (???) so I just pasted the sweep yaml config and all available charts).
Now, referencing both the report and the source code, you can see that the first bracket is 4. therefore, the threshold (see source code for what this is) should be 4.049. Now, because the history of visionary-sweep-2 has a min loss value of 4.504 within the first bracket, it should be early terminated at the first bracket per the implementation. However, it is not. In fact, it should be early terminated for every successive bracket but it continues to run until completion.
So either there is a bug or something not present in the code or documentation is causing bizarre behaviors (e.g. maybe the early terminate check is run async or on some (very slow) polling rate)

Additional Files
No response
Environment
WandB version: 0.16.3
OS: 14.3.1 (23D60)
Python version: 3.10.1
Versions of relevant libraries:
Additional Context
No response

I just did some debugging directly in the source code and found that all my sweep runs have empty history (i.e. run.history = [], not just for the target goal metric but for all metrics logged. So this explains why early termination is not working at all. Why is no history saved for my sweep runs? I setup my sweep configuration by simply following your tutorials.

after some more digging, I think I found the bug. The early termination function expects the metric history to be stored in the .history attribute of the run, but when the controller queries for the runs (which are eventually passed to the early termination function), it runs the following GQL query
            """
        query SweepWithRuns($entity: String, $project: String, $sweep: String!, $specs: [JSONString!]!) {
            project(name: $project, entityName: $entity) {
                sweep(sweepName: $sweep) {
                    id
                    name
                    method
                    state
                    description
                    config
                    createdAt
                    heartbeatAt
                    updatedAt
                    earlyStopJobRunning
                    bestLoss
                    controller
                    scheduler
                    runs {
                        edges {
                            node {
                                name
                                state
                                config
                                exitcode
                                heartbeatAt
                                shouldStop
                                failed
                                stopped
                                running
                                summaryMetrics
                                sampledHistory(specs: $specs)
                            }
                        }
                    }
                }
            }
        }
        """

so it doesnt even query for the history, only for sampledHistory.

oh but I see that you are doing this https://github.com/wandb/sweeps/blob/6e25b8bcf2adada723538e675c6de34f5faebb22/src/sweeps/run.py#L74, thus loading history from sampled history

ok I think I found the bug now. When you call _sweep_object_read_from_backend, you set self._sweep_metric after you run the query (https://github.com/wandb/wandb/blob/1ae34d584eec9fbf3b21bd02108ce278a70f665a/wandb/wandb_controller.py#L443), but the code expects self._sweep_metric to be set in order to create the specs for the sample history (https://github.com/wandb/wandb/blob/1ae34d584eec9fbf3b21bd02108ce278a70f665a/wandb/wandb_controller.py#L432)

oh, and another issue. The current pip version of sweeps has the following incorrect implementation: h[band] treats the band values as 1-indexed (https://github.com/wandb/sweeps/blob/95d3ccad7ef6ce7c7af77b5bf7efd933b50b9336/src/sweeps/hyperband_stopping.py#L189), but the latest commit on main has the correct implementation: h[band-1] treating the brand values as 0-indexed (https://github.com/wandb/sweeps/blob/master/src/sweeps/hyperband_stopping.py#L189). this also explains why my specific example above didnt trigger early termination

I applied all these changes locally and everything works, including the specific example in the description. pls fix this asap because my ML workflow is heavily reliant on early termination working.

WandB Internal User commented:
yiphei commented:
after some more digging, I think I found the bug. The early termination function expects the metric history to be stored in the .history attribute of the run, but when the controller queries for the runs (which are eventually passed to the early termination function), it runs the following GQL query
            """
        query SweepWithRuns($entity: String, $project: String, $sweep: String!, $specs: [JSONString!]!) {
            project(name: $project, entityName: $entity) {
                sweep(sweepName: $sweep) {
                    id
                    name
                    method
                    state
                    description
                    config
                    createdAt
                    heartbeatAt
                    updatedAt
                    earlyStopJobRunning
                    bestLoss
                    controller
                    scheduler
                    runs {
                        edges {
                            node {
                                name
                                state
                                config
                                exitcode
                                heartbeatAt
                                shouldStop
                                failed
                                stopped
                                running
                                summaryMetrics
                                sampledHistory(specs: $specs)
                            }
                        }
                    }
                }
            }
        }
        """

so it doesnt even query for the history, only for sampledHistory.

WandB Internal User commented:
yiphei commented:
oh, and another issue. The current pip version of sweeps has the following incorrect implementation: h[band] treats the band values as 1-indexed (https://github.com/wandb/sweeps/blob/95d3ccad7ef6ce7c7af77b5bf7efd933b50b9336/src/sweeps/hyperband_stopping.py#L189), but the latest commit on main has the correct implementation: h[band-1] treating the brand values as 0-indexed (https://github.com/wandb/sweeps/blob/master/src/sweeps/hyperband_stopping.py#L189). this also explains why my specific example above didnt trigger early termination

WandB Internal User commented:
yiphei commented:
I applied all these changes locally and everything works, including the specific example in the description. pls fix this asap because my ML workflow is heavily reliant on early termination working.

The early_terminate parameter for the sweep configuration does not work at all in my test.
Is there any progress on this issue?

they released a fix so it should work now.

Hi @Eunchan24 @yiphei this should be resolved now. Can you please add some time.sleep() calls between your experiments as it might be related that your runs are executed faster than the Sweep server checks?

WandB Internal User commented:
yiphei commented:
actually, it still doesnt fully work. I followed up in https://community.wandb.ai/t/early-terminate-param-for-sweep-configuration-does-not-seem-to-work-at-all/6094/20.


Request to support doctest for QNX cross compilation tool

we want use doctest on Qnx-OS ,but meet a error with qnx cross compilation tool : ntoaarch64-g++, see detail:
In file included from /build/src/main_dev.cpp:2:0:
/build/../../code/doctest/doctest.h:3289:9: error: reference to 'ostream' is ambiguous
std::ostream* push() {
^
In file included from /build/src/main_dev.cpp:2:0:
/build/../../code/doctest/doctest.h:508:48: note: candidates are: typedef class std::basic_ostream<char, std::char_traits > std::ostream
typedef basic_ostream<char, char_traits> ostream; // NOLINT(modernize-use-using)
^
In file included from /qnx700_sdp/target/qnx7/usr/include/c++/v1/ios:215:0,
from /qnx700_sdp/target/qnx7/usr/include/c++/v1/ostream:138,
from /qnx700_sdp/target/qnx7/usr/include/c++/v1/fstream:169,
from /build/../../code/doctest/doctest.h:3120,
from /build/src/main_dev.cpp:2:
/qnx700_sdp/target/qnx7/usr/include/c++/v1/iosfwd:147:38: note:                 typedef class std::__1::basic_ostream std::__1::ostream
typedef basic_ostream          ostream;
^
In file included from /build/src/main_dev.cpp:2:0:
/build/../../code/doctest/doctest.h: In member function 'doctest::String doctest::detail::::pop()':
/build/../../code/doctest/doctest.h:3302:33: error: no matching function for call to 'doctest::String::String(std::__1::stringstream&, unsigned int&)'
return String(ss, sz);
^

doctest version: 2.4.9
Operating System: Qnx
Compiler+version : ntoaarch64-g++

try
#include <unistd.h>
#include <ostream>

int isatty (int filedes) {
    (void)filedes;
    return 1; // color
}

#define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
#include "doctest.h"

int factorial(int number) { return number <= 1 ? number : factorial(number - 1) * number; }

TEST_CASE("testing the factorial function") {
    CHECK(factorial(1) == 1);
    CHECK(factorial(2) == 2);
    CHECK(factorial(3) == 6);
    CHECK(factorial(10) == 3628800);
}

@longwenliu Please provide a minimal reproducible example.


dummy provider filter

The test suite on the master branch is currently failing, due to a small issue with filtering.
The failing test is test_reordering, and the underlying cause is that available_backends({'simulator': False}) is returning ibmqx2, ibmqx4, ibmqx5, local_dummy_simulator. Clearly, the last one should not be there, since it is a simulator. The reason it shows up is that filter is not implemented for the dummy provider. This PR addresses that.
(The above test does not fail when run individually. Only when run with other tests, the local_dummy_backend persists in the wrapper.available_backends()).

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Thanks @ajavadia , good catch, specially since it would only surface depending on the order tests gets executed. Moving forward, the clean solution would be either to make sure we don't mingle with the default provider (as happened during test_timeout) or ensure we start in a clean state avoiding the global state (probably not using the wrapper in the tests, except for the ones for the wrapper) - but cool fix in the meantime! :+1:


[INSTALL]

System information

Windows 10
python 3.8.2 64-bit
fiftyone-0.18.0
pip

Commands to reproduce
import fiftyone as fo

Describe the problem
I get this error when I import fiftyone.
  File "C:\Python38\lib\site-packages\fiftyone\__init__.py", line 25, in <module>
    from fiftyone.__public__ import *
  File "C:\Python38\lib\site-packages\fiftyone\__public__.py", line 15, in <module>
    _foo.establish_db_conn(config)
  File "C:\Python38\lib\site-packages\fiftyone\core\odm\database.py", line 181, in establish_db_conn
    config = get_db_config()
  File "C:\Python38\lib\site-packages\fiftyone\core\odm\database.py", line 84, in get_db_config
    config = DatabaseConfigDocument.objects.get()
  File "C:\Python38\lib\site-packages\mongoengine\queryset\base.py", line 281, in get
    raise queryset._document.MultipleObjectsReturned(
fiftyone.core.odm.database.MultipleObjectsReturned: 2 or more items returned, instead of 1
Skipping automatic non-persistent dataset cleanup

Hmm strange. In order to resolve this error you will have to connect directly to your MongoDB database and delete the duplicate document that has somehow been created in the config collection of your fiftyone database.
To do this, start a mongod server in one shell:
# If you installed from pip, you should have a `mongod` binary here
MONGOD_PATH=/path/to/your/env/lib/python3.8/site-packages/fiftyone/db/bin/mongod

# If you installed from source, it should be here
MONGOD_PATH=~/.fiftyone/bin/mongod

# This is the default location where your database lives on disk
# If you customized your `database_dir` config, use that value here
DB_PATH=~/.fiftyone/var/lib/mongo

# Start mongo sever
$MONGOD_PATH --dbpath $DB_PATH

Then start an interactive shell in another terminal (if you installed from pip, I believe you'll have to install the mongo shell separately):
# If you installed FiftyOne from pip, provide your path here
MONGOS_PATH=/path/to/mongo

# If you installed from source, you should have a `mongo` binary here
MONGOS_PATH=~/.fiftyone/bin/mongo --shell

# Start mongo shell
$MONGOS_PATH --shell

Now delete the duplicate document:
# If you customized your `database_name` config, use that value here. The default is `fiftyone`
> use fiftyone

# You will see two documents here
> db.config.find({})
{ "_id" : ObjectId("XXXXX"), "version" : "0.18.0", "type" : "fiftyone" }
{ "_id" : ObjectId("YYYYY"), "version" : "0.17.2", "type" : "fiftyone" }

# Delete one of the documents
> db.config.deleteOne({"_id": ObjectId("YYYYY")})


style(test): update specs lint, hint friendly

Cosmetic updates to lint friendly spec. For some reason eslint glob doesn't grab all files, change it to specifying directory.

Merged with ccdd165.


[BUGFIX] Correctly resolve internal alias names

Tests are expected to fail - that's actually the PoC that the missing case in alias handling is reproducible.

Closed in favour of PR #31


Feature/mongodb sink set add to set save operations

Added SET, ADD_TO_SET and SET operations for MongoDB sink.
Documented MongoDB sink new features.

Detected more errors. Sorry for canceling it again


[4.x] CallableResolver is misused as Container provider

#2555 introduced a new method getContainer for the CallableResolverInterface.
This is actually a hack that is used to hide a real dependency to the ContainerInterface. Classes that use CallableResolverInterface::getContainer need to be refactored to depend on ContainerInterface directly and the method CallableResolverInterface::getContainer should be removed again.
Here is an example how Slim\Routable uses the CallableResolver to fetch the container:
$this->callableResolver->getContainer():
https://github.com/slimphp/Slim/blob/5311e952552dcd3c8c49a363c438649031965783/Slim/Routable.php#L63-L64

There’s more changes coming to Route/RouteGroups/Routable that is upcoming as I discussed in #2583. It will deal with all of this.

Closing #2591 has been merged


[FEA] RankGauss op

Is your feature request related to a problem? Please describe.
Not related to the problem.
Describe the solution you'd like
RankGauss is a great way of representing data for NNs. It is not supported out of the box (AFAIK) by any other library. Would be great to have it in nvtabular 🙂
Describe alternatives you've considered
Preprocessing data manually using cudf before passing it to nvtabular.
Additional context
Implementation and functionality outlined in an NVIDIA technical blog post

this might help for implementation: https://developer.nvidia.com/blog/gauss-rank-transformation-is-100x-faster-with-rapids-and-cupy/

We also had a previous issue talking about this here https://github.com/NVIDIA-Merlin/NVTabular/issues/250


Release new dplace-data v2.2

Hi @xrotwang, when you get a minute, can you please release 2.2. I don't think we need anything of the open issues handled for the time being.

Do you need this before the weekend?

And do we need this imported in the web app right away?

No & No.

What Glottolog version should release with? 4.2 or 4.3?

See https://github.com/D-PLACE/dplace-data/pull/291

may as well go for the latest and greatest!

In particular since the other changes barely merit a new minor version (see https://github.com/D-PLACE/dplace-cldf/commit/bca2e2de714aecc91d25c9b97aeb48ae15433c1d) :)

See https://github.com/D-PLACE/dplace-data/releases/tag/v2.2.0

thanks @xrotwang !

Yes, thanks @xrotwang!


Update ISBI dataset

GTG from my side! (made the path to install the ISBI volume a little modular)


Syntax Errors in ImageView.dart file

There are syntax errors in ImageView.dart file. I want to work on this issue as a GSSOC 21 participant.

Please add GSSOC 21 label

What kind of syntax errors you were facing ?

Okay, Got it so there were brackets missing.

Okay, Got it so there were brackets missing.

Yes Sir !!!

Please add GSSOC 21 label

Please refrain from adding these comments related to labels in the issues. We have a github action for it or else the mentors would automatically add them.  I get notifications for all of these. Instead insure that your PRs are given the gssoc21 and the respective level tag.
In the PR description always write:
Closes # issue_number for it to work.
That being said, @SapinderSingh nice work finding out the bug.


[Bug] Cursor shifts position while typing in Rich Text Editor Widget

Description
https://user-images.githubusercontent.com/23132741/132465865-a22c1651-e32d-4156-92ea-578a858d0455.mov
Steps to reproduce the behaviour:
Add steps to reproduce this behaviour, include console / network logs & screenshots

Go to https://app.appsmith.com/applications/6131b0ce987e5a1cc9ff72f3/pages/61326208987e5a1cc9ff74f0
Click on new Post
Try to type inside Rich Text Editor Widget
See error

Important Details

Version: [Cloud / Self-Hosted vx.x]
OS: [e.g.MacOSX]
Browser [e.g. chrome, safari]
Environment [production, release, deploy preview]

@Rishabh-Rathod are you taking about RTE or the input widget, Also there is something specific is your app, I cant see to reproduce this on other apps, EX the standup app

@somangshu this doesn't happen every time it is quite random. I saw it lastest in the above app created by @aswathkk
Sorry for the confusion I saw the issue in RTE (Rich Text Editor Widget).

@areyabhishek can you please drop your app here, we will debug this and take it forward


Random crash master branch

Getting some random crashes in the dev and master branch, seems to get the error randomly whenever its getting ready to spin a pokestop or before launching a pokeball.
Traceback (most recent call last):
File "C:\Users\Alimentosybebidas\Desktop\PokemonGo-Bot\pokecli.py", line 220, in
main()
File "C:\Users\Alimentosybebidas\Desktop\PokemonGo-Bot\pokecli.py", line 211, in main
bot.take_step()
File "C:\Users\Alimentosybebidas\Desktop\PokemonGo-Bot\pokemongo_bot_init_.py", line 36, in take_step
self.stepper.take_step()
File "C:\Users\Alimentosybebidas\Desktop\PokemonGo-Bot\pokemongo_bot\stepper.py", line 62, in take_step
self.work_at_position(position[0], position[1], position[2], True)
File "C:\Users\Alimentosybebidas\Desktop\PokemonGo-Bot\pokemongo_bot\stepper.py", line 139, in work_at_position
self.bot.work_on_cell(cell, position, pokemon_only)
File "C:\Users\Alimentosybebidas\Desktop\PokemonGo-Bot\pokemongo_bot_init.py", line 96, in work_on_cell
hack_chain = worker.work()
File "C:\Users\Alimentosybebidas\Desktop\PokemonGo-Bot\pokemongo_bot\cell_workers\seen_fort_worker.py", line 74, in work
" (Total: " + str(self.bot.item_inventory_count(item_id)) + ")", 'green')
File "C:\Users\Alimentosybebidas\Desktop\PokemonGo-Bot\pokemongo_bot_init.py", line 268, in item_inventory_count
inventory_dict = inventory_req['responses'][
TypeError: 'NoneType' object has no attribute 'getitem'
OS: windows 10
Git Commit: 32cefeed4760d6b5d2b3eb76d783d0f13d068e83
Thanks for the great work guys.

Does this happen every time you spin a pokestop or try to catch a pokemon?

No I can run for a few mins or almost an hour, its totally random.

It appears that the request to get the item count comes back in a bad state.

as you stated, you can run it for a few pokestops which means that code is correct as it can 'getitem'. so this is mostlikley a server issue


Update language-spec.md with missing =

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Allow to filter runners via config

This feature allows to specify which runners will be triggered during pronto run. Might solve #365.
Reason
I use pronto:

on local machine
on CI
as git pre-commit hook
as git pre-push hook

In each of those cases I would like to run different linters. For example I want to run all pronto linters on CI and only fast-enough linters on git pre-commit hook. With this feature I could add PRONTO_SKIP_RUNNERS or PRONTO_RUNNERS env variable in order to control which runners will be triggered.
I know that there is a -r (aka --runner) flag, but:

it does not have --skip-runner options;
it does not work very well, especially with other flags (some times it tries to load file pronto/-r file);
it does not skip runners which where already loaded.

Filtering
Whiteliting runners via config
# .pronto.yml
runners:
  - rubocop
  - reek

This will ensure that only rubocop and reek runners will run.
Blacklisting runners via config
also it's possible to blacklist runners (filter out) like this:
# .pronto.yml
skip_runners:
  - rubocop
  - reek

Filtering via env variable
Filtering can be done with env variables:
# whitelist:
PRONTO_RUNNERS="rubocop reek" pronto run

# blacklist:
PRONTO_SKIP_RUNNERS="rubocop reek" pronto run

Other notable things
I could not resist to do small refactoring in config.rb and runners.rb classes, I hope it's not a big deal. Let me know if I need to open separate ticket just for refactoring.
Also I'm not sure if config structure is good enough. As an alternative I see nested structure for runners like this:
runners:
  only:
    - reek
    - rubocop
  except:
    - rubocop

Would be nice to receive some feedback about it.

@doomspork can you check my PR?

Personally, I like a nested config more.

@mknapik are you talking about this case:
# .pronto.yml
skip_runners:
  - rubocop
  - reek

or something completely different?

I'd love to see tests with a runners context with clear 4 cases:

no only nor except
just only
just except
both only and except

Added more tests. Let me know if there is something else missing.

You've proposed a structure like:

Also I'm not sure if config structure is good enough. As an alternative I see nested structure for runners like this:
runners:
only:

reek
rubocop
except:
rubocop

and I think I like it more.
It would also probably require adjusting env vars accordingly (probably PRONTO_RUNNERS_EXCEPT and PRONTO_RUNNERS_ONLY).
@prontolabs/core Does anyone has on opinion on config format?

@povilasjurcys can you rebase this PR?

@ashkulz rebased the code :+1:

Hmm, not sure why the CI ran twice and failed for pull_request -- do you have any idea, @dsander?

@ashkulz Not super sure to be honest, maybe #398 fixes that. Generally I think it was wrong to use pull_request_target in the action.

@povilasjurcys can I trouble you to merge/rebase again? GitHub CI failed for 2.4, hopefully #398 fixed that 🤞

Also, I'd appreciate a change to README.md which documents this change as well 🙂

Also, I'd appreciate a change to README.md which documents this change as well

@ashkulz I added two lines in the readme. Let me know if that's enough or not.

can I trouble you to merge/rebase again? GitHub CI failed for 2.4, hopefully #398 fixed that crossed_fingers

Sadly tests for ruby 2.4 is still failing. I highly doubt that it's because of changes in this PR

I added two lines in the readme. Let me know if that's enough or not.

I think you need to elaborate what happens by default i.e. both the options are not provided, otherwise looks good to me!

Sadly tests for ruby 2.4 is still failing. I highly doubt that it's because of changes in this PR

Sorry to trouble you -- can you merge master again? @dsander made a PR which should fix that.

I think you need to elaborate what happens by default i.e. both the options are not provided, otherwise looks good to me!

Added separate table with some top-level properties here. Since it's a new thing, I would like to hear your opinion

@ashkulz can we merge this PR?

@ashkulz: It seems like this one can be merged now, right?

Thanks for the contribution, @povilasjurcys! Sorry for the delay in reviewing :see_no_evil:


Removed the need of worldwide.png and changed to '🌐' emoji following …

…the same structure as the country flags.
Did a minor change in "lib/src/country_list_view.dart"
Widget _flagWidget(Country country)
As I could have problems loading the asset worldwide.png at some times I changed so worldwide as well uses emoji as the rest of the country flags.

@codeItRalf Thank you for your contribution. Released in v2.0.17.


Add pushover notification

@wizzro Thanks for your contribution!

I've tagged your feature with version 2.4.0


Show game and cards

Show the players, the battlefield, hands, decks, cards, etc. in libGDX after starting a game

Player hand now shows correctly.

Enemy hand now shows correctly.

Players are now also shown. This concludes this issue.


 Can anyone review this?

Thanks for sending this change so quickly. We will need to decide on the best syntax for this. It might be better to put this under a more generic command like ALTER SYSTEM or ALTER SESSION.

I think ALTER SESSION is ok, session users should only be able to kill there own queries.

@electrum get comments addressed.

We definitely want this functionality, but we don't know how we want to expose it to users.  Can you open an issue to discuss the syntax and implications of implementing this.  I'd kick off this discussion with how other systems implement this.
I'm going to close this for now.  If we end up landing on this syntax, we can reopen this.


feat(wallet-info): blur private key

:tada: This PR is included in version 1.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

25 PSF tokens rewarded. TXID:
884dc51a00554806493659dd7ba8babfaba9c3250838930fc7c0e12c655b6bd3


Add headers to input form and description on hover.

User story
As a user, I want to know what each input form button does, so I can more easily retrieve the data I want.
Acceptance criteria

[ ] There should be a header describing the buttons in the input form.
[ ] When a button is hovered over, a more detailed description is provided.

Sprint Ready Checklist

[ ] Acceptance criteria defined

[ ] Team understands acceptance criteria

[ ] Team has defined solution / steps to satisfy acceptance criteria

[ ] Acceptance criteria is verifiable / testable

[ ] External / 3rd Party dependencies identified

[ ] Ticket is prioritized and sized

Notes
Add any helpful notes here.

Moot point since we've moved to Material UI.


Loading alignment jumpiness fix

This change should go into the hammerlab. I think they would appreciate this.
https://github.com/hammerlab/pileup.js


Jellyseerr crashes on Raspberry pi 4

Description
I attempted to install jellyseerr on a raspberry pi 4b, and it crashed immediately.
Version
The latest docker version (digest sha256:558927b7caaf42c4940bc21f1aa46bc3d6dc1730e4b1539b701ed6961d6b2c7d) (the develop docker version also crashes with the same error)
Steps to Reproduce

Use the docker-compose.yml from https://hub.docker.com/r/fallenbagel/jellyseerr
run sudo docker-compose up
it pulls the image and crashes

Screenshots
No response
Logs
pi@[REDACTED]:~/jellyseerr $ sudo docker-compose up
Creating network "jellyseerr_default" with the default driver
Pulling jellyseerr (fallenbagel/jellyseerr:latest)...
latest: Pulling from fallenbagel/jellyseerr
57fb4b5f1a47: Pull complete
d1393c274244: Pull complete
1af5ea6e06a0: Pull complete
ccde71dd47a8: Pull complete
4178c73c1d34: Pull complete
68a8f3ca0c92: Pull complete
a4f7e167d14d: Pull complete
Digest: sha256:558927b7caaf42c4940bc21f1aa46bc3d6dc1730e4b1539b701ed6961d6b2c7d
Status: Downloaded newer image for fallenbagel/jellyseerr:latest
Creating jellyseerr ... done
Attaching to jellyseerr
jellyseerr    |
jellyseerr    |
jellyseerr    | #
jellyseerr    | # Fatal error in , line 0
jellyseerr    | # unreachable code
jellyseerr    | #
jellyseerr    | #
jellyseerr    | #
jellyseerr    | #FailureMessage Object: 0xbeaa85fc
jellyseerr exited with code 133

Platform
desktop
Device
Raspberry pi 4b 8gb
Operating System
Raspbian GNU/Linux 10 (buster) armv7l
Browser
Not relevant
Additional Context
No response
Code of Conduct

[X] I agree to follow Overseerr's Code of Conduct

Could you try what this person block quoted?
https://github.com/jesec/flood/issues/390#issuecomment-1186491973
I havent been able to reproduce this on my rpi

Thanks! That fixed the issue, and it's working perfectly now!


drivechain-server: move sync + balance fetch to server

Resolves #228 by moving balance fetching and sync to the server struct.

Needs a rebase!

Good stuff good stuff


Update README.md

Makes it easier for users to install the library. I figured out the installation procedure by running the python script (setup.py) with the --help flags.

Please see #23, it fixes this issue in an easier way


Request: Sub Menus

Hi, this looks like one of the simplest and amazing thing to have. Thanks a LOT for this. However, I cant see in the demo if we want to have a simple drop down (not mega menu) but have sub-menus as well. Is it already there, if so can you please 2-3 levels of submenus in the demo ?..
thanks again for sharing this.. I want to use in in one of my theme but because of not having sub menus I find it hard. I would highly appreciate your input on this.
thanks

Hello @WPThemer ,
Thanks for your kind words! I created this menu for the same reasons you recognized here.
The way this menu is coded, when you need your sub-menu to have another level of sub-menu, the whole menu is transformed into megamenu.
That was the whole idea behind this menu. This menu uses NO classes that you need to put in HTML (jquery eject's when needed) and that was another idea, thats way you can implement it with wordpress seamlessly. Also no custom walkers are needed for this menu to work with wordpress.
If you want to choose only classic multy-level dropdowns for one menu element, and megamenu for other, you can do this with classes. You need to write custom CSS (not much) and you need to remove the "intelligence" from the jquery. Also you would need to configure some menu options in functions.php or create a custom walker for menu.
Let me think about your request and how could i implement this into megamenu.js . Also if you have an idea how to do it, i will be very happy to help you, or you could make a pull request.
Thanks for using megamenu.js!

HI Mario, thanks for your quick reply.
Honestly, it has always been so complex to implement Mega Menus, there are tons available, and due to their complexity its really hard to adopt but this one is to the point and so simple, I already tried on my theme (just one one portion and took less than 2 minutes to implement in wordpress) and it looks great, automatically converts to mega menu. But at some point, you also need to have sub-levels of menus but not always the mega menu, here is an example : http://goo.gl/1YPk8X
I will play with it and see what I can do, but as you see as I love it and couldn't come up with something simple yet powerful :) you are the captain...
thanks once again...
cheers

Hello, just to let you know, your request is in development with v2

Will this eventually be implemented? Just curious as it's still Open


feat: add include_external_repositories and exclude_prefixes attributes to copy_to_directory

Also change the default behaviour such that files from external repositories are not included unless the external repository is listed in include_external_repositories

LGTM. I'll let Alex approve once the example is in.


Adding UNL Domain Validation file

UNL had us do domain validation by adding a special .well-known file.

Thanks @CannonLock .  That sounds like approval to me!


Dependency caching

Utilize pip to organize dependencies e.g. for PDKs.
The installed package needs to provide a dependency.py file which contains a dependency dict with all the source information.
Siliconcompiler reads this information and if possible downloads+caches the information to the location of the freepdk45 package.
Alternatively a path in the network drive can be specified.
Currently only the final path path of the pdk will be stored in the pdk information of the schema as before.
This path contains the unique id (project_name+commit_id or a custom unique_id).
We could also store this information in a more prominent place in the schema.
Depends on the dependency-caching branch of freepdk45.

freepdk45-data is not installed on the CI right now which leads to tests failing.
Just wanted to get some initial feedback on the approach.
After that I'll publish the freepdk45-data package on pypi and add it as a requirement.

Abandoning this in favor of newer PRs #2071, #2074


[SPARK-9151][SQL] Implement code generation for Abs

JIRA: https://issues.apache.org/jira/browse/SPARK-9151
Add codegen support for Abs.

Merged build triggered.

Merged build started.

Test build #37724 has started for   PR 7498 at commit 0c8410f.

LGTM.

Test build #37724 has finished for   PR 7498 at commit 0c8410f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Thanks - merging this.


GH-34142: [C++][Parquet] Fix record not to span multiple pages

Rationale for this change
Parquet data page v2 requires pages change on record boundaries. Currently the parquet-cpp writer does not enforce this.
What changes are included in this PR?
Change ColumnWriter to split data page on record boundaries when data page v2 is applied.
Are these changes tested?
Add test TEST(TestColumnWriter, WriteDataPagesChangeOnRecordBoundaries)
Are there any user-facing changes?
No.

Closes: #34142

@wjones127 @emkornfield @pitrou @etseidl @mapleFU Please take a look if this is a clean fix.

Gentle ping @emkornfield
@pitrou @wjones127 Have time take a look?

Generally, looks OK to me once other reviewers are happy.

The skeleton LGTM. I wonder that if ther is a corner case:
rep-levels 1, 1, 0
batch = 3

And we found last record is 0, but the last record should not be flushed?

In your case, the batch will call action twice:

levels: 1, 1, w/ page size check
levels: 0, w/o page size check

Please take another pass, thanks! @wjones127


Set $CARGO_INSTALL_ROOT and $PATH used in cargo install

Motivation
When you have multiple devenv managed Rust projects, you want them to use their own $CARGO_INSTALL_ROOT, otherwise cargo install will overwrite executables that belong to other projects.
See https://doc.rust-lang.org/cargo/commands/cargo-install.html

Could you review this PR again, please? @shyim

@domenkozar Do you want to review and merge this PR?

@Atry I tried to resolve the merge conflict, but it created an issue with formatters. Could you run pre-commit run -a and commit?

Formatted


Fetch workflow triggers always new PRs

This is due very likely to end line characters for all lines where field Remarks (charater) contains multiple lines.
So, the changes in the raw csv file are not content-wise.
Maybe using httr::write_memory()?

It seems that new data have been fetched. So, probably this issue is not valid? I have enabled again the hourly fetch-data workflow so that I can see whether a new PR will be created and why.

No new PRs are triggered, see: https://github.com/riparias/pov-fishes-occurrences/actions/runs/3096320651/jobs/5011740133.
Issue can be closed.
Still, @filipmahieu mentioned that WFS for this layer is slightly unstable/slow. Coud it be that the origin of this issue is due to it?


Request: add lightrun.com/answers to the filter

Evidence: https://lightrun.com/answers/microsoft-wsl-wsl-2-nic-bridge-mode--has-tcp-workaround
Original: https://github.com/microsoft/WSL/issues/4150
https://lightrun.com/answers is a collection of github issues.

Thanks a lot!

You might want to limit the filter to *://lightrun.com/answers/* as it seems Lightrun is also a legit business.
Disclaimer: not affiliated, just noticed some seemingly normal search results are being removed.

Thanks a lot for your contribution. Sorry I totally miss the notification. You are right.


Insights section has interference data from the original repo

@w1g0 could you explain this one? Thanks!

Sure, I noticed that the insights have all the data of the original repo. It might be useful to have a way to reset it. If we want to see contributions from the original repo go there to see the contributors. Also the activity line starts from way before we started this sibling.

We can get rid of this but I'll need to nuke the whole repo including the current tweets.
If / when we migrate to @eth_classic, we should use that as an opportunity to do so.


Telegram Clone

Is your feature request related to a problem? Please describe.
This will be a TELEGRAM WEB APP CLONE and it will be made using HTML,CSS,JS , The Code will be Responsive and here will be some funcationlities like

few contacts
their chats
my info
settings
chat text area

Describe the solution you'd like.
I will use HTML,CSS,JS to make this.The Code will be Responsive
Describe alternatives you've considered.
NA
Add any other context or screenshots about the feature request here.
DEMO

@swapnilsparsh kindly assign


fix position of docker stats source in send-data/use-json-configure-s…

Purpose of this pull request
This source is in table for log sources, but in fact it is a metric source.
Select the type of change:

[x] Minor Changes - Typos, formatting, slight revisions
[ ] Update Content - Revisions and updating sections
[ ] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

@JainM6 I have signed it two times already. I have signed it third time now, with my GitHub username as "Name".

@aboguszewski-sumo : I have added your id to the cla bot. It's merged.


v2 protovalidate support

The upcoming version of PGV (protoc-gen-validate) is going to be protovalidate
We would like to switch to using protovalidate which is technically backward compatible but our scala code can't catch-up with it.
Contribution guide is here for adding a new language support: https://github.com/bufbuild/protovalidate/tree/main

Hi @Dogacel , thanks for starting this issue. It would be great if we can have protovalidate support. It looks like there is going to be significant amount of work involved. Assuming this is a commercial use case, can you check if your organization can sponsor the work and we'd have it result in an open source project? Happy to discuss in private at thesamet at gmail.com

Hi @Dogacel , thanks for starting this issue. It would be great if we can have protovalidate support. It looks like there is going to be significant amount of work involved. Assuming this is a commercial use case, can you check if your organization can sponsor the work and we'd have it result in an open source project? Happy to discuss in private at thesamet at gmail.com

Hi, unfortunately, we are moving away from scala and our company is really tight on resources. We really would like to help this but I am planning to work on this outside the work hours 🙂
I'll still ask just in case but I would say chances are very low. Thanks for the kind offer!


Point Grab to Artifactory

& provide credentials
See https://stackoverflow.com/questions/38300697/how-to-enrich-grabresolver-with-login-credentials

Resolved for Jenkins Slave.
For Jenkins Master see https://github.com/FIDATA/infrastructure/issues/87


How can I only convert velodyne data to rosbag?

How can I only convert velodyne data (*.bin) to rosbag? Only need to convert velodyne data, without image data.
I can use it to convert raw_data to rosbag.
But I can not use it to convert only odometry data in this website odometry:
In other words, this tools only can convert data that meets the formatting requirements( format in raw_data .
How can I convert odometry sequences in this website to rosbag?
So how to use folder "velodyne_points" without calibration file or image folder?
Looking forward to any reply

My problem is solved.

we provide the mapping of the training set to the raw data of the KITTI dataset.
The following table lists the name, start and end frame of each sequence that
has been used to extract the visual odometry / SLAM training set:
Nr.     Sequence name     Start   End

00: 2011_10_03_drive_0027<PHONE_NUMBER>40
01: 2011_10_03_drive_0042<PHONE_NUMBER>00
02: 2011_10_03_drive_0034<PHONE_NUMBER>60
03: 2011_09_26_drive_0067<PHONE_NUMBER>00
04: 2011_09_30_drive_0016<PHONE_NUMBER>70
05: 2011_09_30_drive_0018<PHONE_NUMBER>60
06: 2011_09_30_drive_0020<PHONE_NUMBER>00
07: 2011_09_30_drive_0027<PHONE_NUMBER>00
08: 2011_09_30_drive_0028<PHONE_NUMBER>70
09: 2011_09_30_drive_0033<PHONE_NUMBER>90
10: 2011_09_30_drive_0034<PHONE_NUMBER>00

Hello, did you manage to convert only the velodyne data? I didn't find option for that (only raw_synced, odom_color and odom_gray). Thanks  a lot in advance!

@AbnerCSZ hello，the 03: 2011_09_26_drive_0067 can't be found in official website. Do you have this dataset? Or，do you know why it can't be found? my Email<EMAIL_ADDRESS>

@AbnerCSZ did you tried it only with the raw velodyne data or does the velodyne data work too?


Add BufferedProcessLogger and thread it through assertTesterPasses

When running CI tests the logger interacts with global state which affects the log being output. the BufferedProcessLogger creates a stable buffer for the log stdout which is required for tests relying on a stdout.
Contributor Checklist

[ ] Did you add Scaladoc to every public function/method?
[x] Did you add at least one test demonstrating the PR?
[x] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[ ] Did you add appropriate documentation in docs/src?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?
[x] Did you add text to be included in the Release Notes for this change?

Type of Improvement

bug fix
new feature/API

API Impact

Adds a new ProcessLogger subclass for buffering stdout and stderr
Backend Code Generation Impact

N/A
Desired Merge Strategy

Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Add BufferedProcessLogger for stable stdout logging
Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
[ ] Did you review?
[ ] Did you check whether all relevant Contributor checkboxes have been checked?
[ ] Did you do one of the following when ready to merge:

[ ] Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
[ ] Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Replaced by https://github.com/chipsalliance/chisel3/pull/2769


show the timestamp of the generated data

If the builds that generate the data fails, you'd have an idea of when the data is from if you can see the timestamp of the file.
Suggested solution.
https://stackoverflow.com/a/25064125/2055199

Works, closing.


Minor: Postgres - parameter group args use postgres16

I can't create a Postgres DB using sst.aws.Postgres with Postgres 17 without needing to transform the parameter group. It would be great if SST could figure out the correct version based on the version of Postgres requested.
Required workaround:
new sst.aws.Postgres("...", {
	vpc,
	version: "17.2",
	transform: {
		parameterGroup: (parameterGroupArgs) => {
			parameterGroupArgs.family = "postgres17";
		},
	},
});

To replicate, just run this, removing the transform.

Released in v3.3.68.


[FEATURE REQUEST] Max icons per line

Possibly by adding &maxperline=5 or something similar to the request URL

Implemented in 58b5fa3acfde43a1f489c75b65504d01aeedbf9e, thank you!


Handle invalid Scratch Org IDs in session

 An invalid (not uuid) scratch_org_id in the session should not trigger application errors.


Making async calls in a Xamarin.Forms app

Hello All,
I've been working on a POC to create a mobile app using Xamarin.Forms. Could you please provide some sample code for Xamarin.Forms?
In one of my XAML pages I'm calling a method to fetch the data in Salesforce to then set the BindingContext to the results. However, as soon as I make async calls (using await) the main thread is released (as expected) and all controls in the form get loaded without the data.
Any help/sample code would be very much appreciated!
Thanks!

I don't have any experience with Xamarin Forms. Did you get this to work and, if so, can you share your learning?
I'm going to close this for now.


npm interprets __ as <strong> in package description

see: https://www.npmjs.com/package/extend-proto

fixed by https://github.com/pillarjs/extend-proto/commit/27ece1dbe4ace20e10e279811e3dbb3a661992cb


add v1beta1 managed service account

issue reference: https://github.com/open-cluster-management-io/managed-serviceaccount/issues/77

/hold

/cc @qiujian16 @xuezhaojun

I am considering moving the generated client from "pkg/generated/clientset" to "apis/generated/clientset", which opens the possibility of using the apis directory as a submodule in the future.
@qiujian16 WDYT?

I am considering moving the generated client from "pkg/generated/clientset" to "apis/generated/clientset", which opens the possibility of using the apis directory as a submodule in the future. @qiujian16 WDYT?

generated/clientset maybe? mostly we do not put client and type in one root directory.

mostly we do not put client and type in one root directory.

OK, if putting client and type in one root directory is not a good practice, I'd prefer to keep it "pkg/generated/clientset"

/unhold

/lgtm


fix veDeposit id generation

Closes #605

I created an issue to update the tests to make sure that this isn't happening anywhere else. I can do that if it helps: https://github.com/oceanprotocol/ocean-subgraph/issues/607

thanks, makes sense
will follow up on #607 then


Adjust the default RetryOn policy.

This adjusts the default retry policy to more correctly match Istio's, and add one new kind of retry that Istio does not seem to do: reset.
WRT "more correctly" matching Istio, the bug was copied from net-istio, which supplied retriable-status-codes, but not a list of codes that are actually retriable!  Looking at the actual Istio code, it seems to be retrying 503s using this mechanism: https://github.com/istio/istio/blob/748c6209f606fb2276bdd4abaf277d4979d172bc/pilot/pkg/networking/core/v1alpha3/route/retry/retry.go#L39
I suspect that this is the remaining delta to resolve the connection reset errors that pop up intermittently with net-contour, but not net-istio...
Fixes: https://github.com/knative-sandbox/net-contour/issues/237

/lgtm
/approve


Add compatibility PHP 8.3.

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

https://github.com/yiisoft/yii2/discussions/19957#discussioncomment-7653161


Update documentation for delete_user & $last_seen

This is merged at https://github.com/mixpanel/mixpanel-node/pull/102


Need to upgrade the NTP NFS SSH service for more secure

Need to upgrade the NTP NFS SSH and other Board fundamental services for more secure

nginx base image

make list for component version
which components should be upgraded


g++ not found during package tests

Solution to issue cannot be found in the documentation.

[X] I checked the documentation.

Issue
It seems that aesara isn't able to locate the g++ compiler that was installed as a runtime dependency.
At least it reports this in the logs: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=523596&view=logs&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&t=841356e0-85bb-57d8-dbbc-852e683d1642&l=1060
Installed packages
Refers to build log on github actions

Environment info
Refers to build log on github actions

@maresb

Should be fixed by #77. Compare with these logs.

Should be fixed by #77. Compare with these logs.

OK, closing for now.


Any timeout, any re-try option?

~$ youtube-dl -f bestaudio https://www.youtube.com/watch?v=*** -v
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-f', 'bestaudio', 'https://www.youtube.com/watch?v=***', '-v']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2014.10.15
[debug] Python version 2.7.6 - Linux-3.13.0-38-generic-x86_64-with-Ubuntu-14.04-trusty
[debug] Proxy map: {}
[youtube] Setting language
From this moment on nothing happens and the script gets stuck often and should be stopped manually.

the option --socket-timeout 2 (seconds?) not always exit and anyway without re-try the download :(

--retries.


add hover intent jquery plugin

maybe make a "nav" package with html and all

no 3rd party plugins. use bower install