Easy way to revert changes, especially for remote locked-out scenarios

Maybe a "Cisco-like" approach would be something worth considering?
I mean, having 2 separate configs:

A running config, effective immediately at "Save"
A start-up config, effective at OS load. Would require an extra "Save to start-up config" step to be modified.

This way, if a mistake is made, and you get locked-out or something, a restart would be also a roll-back, since no "Save" has been made to the start-up config yet.
Thank you!

Hi!
It would be much more easier to find in that remote location a pair of "dumb enough hands" able to only cycle the power than a pair of "smart enough hands" able to properly reinstate a backup config.
Otherwise, I completely agree with everything else you have said, 100% true and standing.
Thank you.

I just messed up my config trying to configure multi subnet routing with the firewall. So I got here from google, must mean that it's more frequent than expected.
I would propose to keep config changes in a local git so it's possible to view changes to the xml/config files and revert to prior setup. Using git would require minimal effort and provide a robust and not obscure way to manage configuration changes.

Add a backup on boot -am "System reboot configuration commit"
Add a backup on login web/console -am "Login configuration commit"
Auto backup changes every 5 minutes while still logged in -am "WIP configuration commit"

Testing configs could be a branch and once everything is good, confirm merge back to master.
Sounds nice no ?

@johnr14 shell option 13: Restore a backup ;)

Franco was so nice to point me to this request since I posted a similiar FR here: https://github.com/opnsense/core/issues/3695
For me a similar functionality would be nice, too.
I prefer a solution that could be used from UI and CLI the same way.
To be sure only one user is entering that configuration mode with potential reset a locking for the session would be necessary in my opinion. This way other administrators on the same firewall would see, that the system changes are maybe reseted by someone else.
One more thing I would need is the possibility to select the configuration I want to revert to from the backup history for example. This way you could select the current running configuration when you enter the mode or you select a configuration from the past. If the timer runs out the selected configuration is applied.
One more feature would be to select "revert and reboot", to be sure the firewall reverts to a configuration state defined ealier and then does a reboot to be sure everything works as requested. This could be handy if critical changes to interfaces are done that maybe need a reboot to be aktiv and fully functional.
From technical perspective I would prever an implementation that works the same way on UI and CLI so a service or helper tool that is triggered through api would be the way to go?

This issue has been automatically timed-out (after 180 days of inactivity).
For more information about the policies for this repository,
please read https://github.com/opnsense/core/blob/master/CONTRIBUTING.md for further details.
If someone wants to step up and work on this issue,
just let us know, so we can reopen the issue and assign an owner to it.

I realize this is a bit of an old thread, however, rather than duplicating I thought it would be proper to post here.
I have multiple sites that am having to make several changes that could break access (Network address changes, Firewall changes, Routing, Etc.)  ........ I'm scared. HAHA!
The remote sites have 0.75% technical experience. Yes, I might be able to find someone to power cycle a router. However, I've also worked as an MSP and had the resident "IT person" unplug the network cable to "reboot" which they thought worked because "the lights went off and came back on" (Link Lights) #facepalm
Needless to say, took me a bit to figure out that's what they were doing.
I was thinking about my MikroTik days and remember that if I happened to make a incorrect change that those changes would be reverted if I failed to connect back or didn't apply them within X time. Sometimes it was a pain, but it saved my butt so so many times. Kept me from having to make calls to talk someone through a reboot and just gave me a bit of room to breathe.
@banym had a good template as well and I include his here for comparison. Personally, I feel like the simpler thing would be to take a snapshot as soon as the breaking change option is enabled. I can see the use in giving the option for a timer, however, I would think setting a "middle-road" 120 seconds would be a default.
Describe the solution you'd like
It would be nice to lock the firewall in a "major change" mode where only one session is able to do changes until the major change mode is exited. This mode should be able to define a working configuration from the backup config history or the current configuration when this specific mode is activated. It should be possible to set a timer for change commitment. Now the administrator can for example make significant changes to routing or rules that possible could lock him out of the firewall. If he does not approve that his change was successful and works as intended the firewall roles back to the defined configuration. This way the administrator can log in an "try" again or rethink his change
I would submit something the below as a rough draft for an option.
The ability might stay disabled by default and only enabled prior to the change. This would allow the option to stay out of the way and only be used when explicitly needed.
@fichtner -- I believe this to be a worthwhile addition to the OS and would be a step in the direction of more enterprise use-cases. My development skills are limited, however, I would commit to time testing and anything within my abilities to help this become a actual feature.
I would welcome any thoughts or feedback on the suggestion.
Example Change --->  Admin has to change a WAN IP

Scenario - Successful Change

Admin logs in and enables "Breaking Changes Mode" (Or whatever better name)

The working config is immediately snapshot.
Notification alert is placed at the top bar
No other logins are allowed but the user
Working config is marked as the config to be used for restoration
Perhaps the connection is marked for monitor?
Timer Starts (120 second?)
Notification Alert shows at top (See above)

Admin makes changes just as they normally would

Complete with "Apply Changes", etc.

Tests changes and is happy with results

Connection either not broken or reconnected within timer

Admin disables "Breaking Changes Mode"

Previous snapshot config is then removed to prevent use on reboot.
System returns to normal operation
Notification removed from top bar

Now lets try a screw-up....

Scenario - Failed Change

Admin logs in and enables "Breaking Changes Mode" as before

Same as above happens to enable feature

Admin makes changes just as they normally would

Complete with "Apply Changes", etc.

Finds they have made a mistake and are unable to connect back to the GUI

Connection timer expires, or some other defined trigger

"Breaking Changes Mode" begins

Previous Snapshot is automatically restored
Router is Rebooted (if needed)
Other actions such as logging the issue, etc...

Admin wait for completion of restore
- Perhaps an email or other notification could be sent notifying all is well again.
Admin is able to start again, thankful they have not created a bigger problem requiring an on-site visit (For me, an EXPENSIVE multiple day trip)


Removing broken GAMMA link

What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
This removes a broken link from the contributing nav. Fortunately any external links to https://gateway-api.sigs.k8s.io/contributing/gamma will continue to work because there's already a redirect in place (thanks @kflynn!).
Which issue(s) this PR fixes:
Fixes #2259
Does this PR introduce a user-facing change?:
NONE

/lgtm


Scrape the about section of a repository.

Proposed Method:
.about()
Description
Create a method to get the details of a repository, that is the about the section.
To what class it belongs?:
Repository

I want to work on this issue under JWOC.

Go ahead @Akshat103 :))


Please consinder providing a public api file

What would you think about providing a file for public apis so that other languages can write generators that can generate code which is easier to read on that language.
For example Steam provides a json file for Steamworks-SDK.
steam_api.txt
Only having a header file either requires using generic ffi-binding-generator where the yielding code is unreadable or manually parsing header file which is not great to write or writing every binding manually which is hard to maintain.
With this file it is very easy to generate ffi-bindings and create a readable code.
Example: https://github.com/aeb-dev/steamworks_gen which generates https://github.com/aeb-dev/steamworks

How is this json file generated itself?
What tools exist to create bindings from this json file?
What languages does this work with?

How is this json file generated itself?

I do not know but I believe there are tools to generate such files (not limited to json)

What tools exist to create bindings from this json file?

If I understand your question correctly, the point of this json file is to be able create bindings easily. So someone writes a generator in their langauge.
Let me explain further, not all languages have tools for auto-generating corresponding bindings from header. Even if they have, the tools are so generic that the generated code is unreadable/hard to understand/hard to reason. So you feel the pressure to write bindings from scratch but that is also hard to maintain and time consuming.
For example, I wanted to have steamworks binding in dart. Dart has a tool called ffi-gen which tries(not everything is supported) to generate bindings from headers file.
Another example in c#: https://github.com/Facepunch/Facepunch.Steamworks/blob/master/Generator/Program.cs

What languages does this work with?

What do you mean? It is a json file so any language that can parse json can write a binding generator if the language supports ffi/interop

Based on your response, these seem to be the answers to my questions.

How is this json file generated itself?

unknown if any tool exists to do this

What tools exist to create bindings from this json file?

someone needs to write this

What languages does this work with?

it will work with any language where someone is willing to write binding code using the json somehow

Is that all correct?
The goal for Box2D v3.0 is to make it easy to create bindings, but not to necessarily make those bindings myself (too many languages).
So in order to make this happen:

Someone needs to write a generator that takes a few Box2D headers and generates a json file
Someone needs to create a binding generator that consumes the json
This whole process needs to be testable in github actions

Another question, is the json following a published schema?

Is that all correct?

Yes

The goal for Box2D v3.0 is to make it easy to create bindings, but not to necessarily make those bindings myself (too many languages).

I agree.

So in order to make this happen:
1. Someone needs to write a generator that takes a few Box2D headers and generates a json file
2. Someone needs to create a binding generator that consumes the json
3. This whole process needs to be testable in github actions

Just to be on the same page. Box2c should only care about step 1.

Another question, is the json following a published schema?

AFAIK no. By the way you do not need to make it in a json file. Maybe there are other easily consumable formats. I am not expert in this topic but I found having a separate file very useful.
If you want to give a detailed look here is the steam sdk
sdk.zip
Under public/steam you can find the related steam_api.json
If you prefer, I can explain the whole process on discord. My discord username is on github profile page, you can ping me anytime

Thanks for explaining. I think this is a good idea. I just need to learn more about it.
I probably won't work on this soon (other priorities), so I'll table it for now. I may ask for more information in the future.

You are welcome. Nice to hear that!
You can also ping me for testing/creating a prototype in another language

Here's an example of another library which does that
https://github.com/raysan5/raylib/tree/master/parser
There is a custom "parser" taking the header file, then generating various output formats for it
https://github.com/raysan5/raylib/blob/master/parser/raylib_parser.c
https://github.com/raysan5/raylib/blob/master/parser/output/raylib_api.json

Using clang you can compile with -ast-dump=json which gives you everything you need, however, it's extremely noisy and could do with a bit of cleanup. -fsyntax-only helps a little bit but there's an exhausting amount of bloat to read through when first writing a generator, so a utility tool to basically get rid of everything that isn't function syntax and struct declarations is recommended.


compiler allows void values in lists

I think the following behavior is inconsistent.
  var foo=print(0); // void
  print([foo]); // prints [null]
  print({foo: 1}); // analyzer fails to detect the error, but dart2js complains about void

I think it should be an error in both cases, which is supposed to be detected by the analyzer.

The static type of foo ends up being List<void>.
The specification has some specific restrictions on where a void typed expression may occur, it's disallowed in all but a specific list of syntactic constructs, and an element position of a list/set literal or key/value position of a map literal is not explicitly allowed, so it should be a compile-time error.
The analyzer fails to void expressions in list/set literals and map literals.
The common front-end only fails to detect them in list/set literals.

This is actually working as intended, except the dart2js error: When the type of foo is void, [foo] can get the type List<void> based on bottom up inference (when there is no constraint to the contrary in the context type), and print is happy about printing a List<void>, as it should be. Similarly, {foo: 1} gets the inferred type Map<void, int> and print should print it.
However, the following is an error, because the void typed expression foo doesn't:
void main() {
  var foo = print('');
  Map<Object, int> map = {foo: 1};
}

Moving to area-web as per @eernstg 's comment.

If this is a type inference bug, then we are likely looking at a corner case in the CFE.
Note that the VM behaves the same same way as dart2js on the example above.

Closing for the lack of interest.

Closing this issue is fine, thanks! I can't see any evidence that any tool behavior is wrong (and the example I mentioned here does get reported as an error), so there is nothing to do.


Add tutorial for using "RESTful API in an android app"

Add tutorial for using "RESTful API to work with JSON" in order to show how to use a companies RESTful API in order to get information from the company and use it for various tasks such as compiling data. Include app with tutorial and links to the companies API and other sources used to make the app. Here is a link to get you started, What is RESTful?
200 pts

F16 OK (200 pts)


<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed

Is this a bug report?
Yes
Have you read the Bugs section of the How to Contribute guide?
Yes
Environment

react-native -v:
react-native-cli: 2.0.1
react-native: 0.46.4
node -v:
v6.11.0
npm -v:
3.10.10

Target Platform: Android
Development Operating System: Windows 10 64Bit
Build tools: react-native-cli

Steps to Reproduce

git clone git@github.com:GeekyAnts/NativeBase-KitchenSink.git
cd NativeBase-KitchenSink/
npm install

Expected Behavior
No warnings specially related to 'react' and 'react-native' inter-dependency
Actual Behavior
In Console:
WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed
package.json after npm install:
{
	"name": "NativebaseKitchenSink",
	"version": "2.3.1",
	"private": true,
	"devDependencies": {
		"jest": "20.0.4",
		"react-test-renderer": "16.0.0-alpha.13"
	},
	"scripts": {
		"start": "react-native start",
		"android": "react-native run-android",
		"ios": "react-native run-ios",
		"test": "node node_modules/jest/bin/jest.js --watch"
	},
	"jest": {
		"preset": "react-native",
		"transformIgnorePatterns": ["node_modules/(?!react-native|native-base-shoutem-theme)"]
	},
	"dependencies": {
		"color": "~1.0.3",
		"lodash": "^4.13.1",
		"native-base": "2.3.1",
		"react": "16.0.0-alpha.13",
		"react-native": "0.46.4",
		"react-navigation": "1.0.0-beta.11"
	}
}

Reproducible Demo
https://github.com/GeekyAnts/NativeBase-KitchenSink
What happens if you go forward ?
Runs as expected

Hi @sura2k ! I think that you have to update NPM with : npm install npm@latest -g
I had the same problem but the problem disappear when I've updated npm. Hope it helps ! :)

Np. Closing

Please solve this. I am having the same problem. I have tried npm i npm@latest -g


Any options to disable TLS v1.0 and TLS v1.1 for the cluster-agent?

Hi,
we are using Microk8s for quite some time now.  Our lastest company's Qualys-Scan revealed a vulnerability under port 25000:
microk8s version
MicroK8s v1.26.0 revision 4390
Trying to configure the tags as decribed in the staled issue: https://github.com/canonical/microk8s/issues/2896 did not have the desired result.  The cluster-agent seem to refuse to start using these tags:
e.g. --ssl-version or --cipher
Jan 24 17:21:09 *** systemd[1]: Started Service for snap application microk8s.daemon-cluster-agent.
Jan 24 17:21:09 *** microk8s.daemon-cluster-agent[3488952]: Error: unknown flag: --ssl-version
Are there other than that other options to disable TLS v1.0 and TLS v. 1.1 ?

Hi @thaviphone, thank you for reporting this
Indeed, after testing I also found some issues with cluster-agent accepting TLS v1.0 and v1.1 connections. I'll investigate further and get back to you.

Hi @neoaggelos , is there any update on this?

Hi @thaviphone @KarthikK123. Following up after some investigation. With the latest MicroK8s 1.26/stable, I am getting the following:
for ver in tls1 tls1_1 tls1_2 tls1_3; do openssl s_client -connect localhost:25000 -$ver </dev/null > /dev/null 2>/dev/null && echo $ver worked || echo $ver failed; done
tls1 failed
tls1_1 failed
tls1_2 worked
tls1_3 worked

Can you check whether the cluster-agent accepts TLSv1.0 and TLSv1.1 connections on your end? Thanks!
For more context: this was an issue in the past (pre 1.24) where the cluster-agent was served using an old version of gunicorn. Since 1.24, the cluster-agent is a Go service and this should not be an issue any more.

I just tried this out, I am still seeing v1.0 and v1.1 are being accepted.
for ver in tls1 tls1_1 tls1_2 tls1_3; do openssl s_client -connect localhost:25000 -$ver </dev/null > /dev/null 2>/dev/null && echo $ver worked || echo $ver failed; done tls1 worked tls1_1 worked tls1_2 worked tls1_3 worked
I'm on microk8s v1.26.1, revision 4595

confirming having the same on my end...  output is excactly the same...
I'm also on microk8s v1.26.1 revision 4595

by far I'm not a programer/coder or anything...  I know nothing about Go...  I'm not even able to read your code...  not to mention on the Go service, which is used...  but I can think of the Go service being an "web server service"...  so in my simplest understanding and thoughts of a web service, there must be an option to set a kind of min tls version to be used...  is there possibly something missing?  Maybe an option in the Go service setting a min version of tls?

I’ve been getting TLS1 and 1.1 on fresh installs of Ubuntu 22.04 and 22.10

I tested on a fresh Azure VM running Ubuntu 20.04.

I'm running a four node cluster on Rocky Linux 8.0

Hi @neoaggelos, did you get a chance to investigate further? This is still being flagged in our company scans

Hi @KarthikK123
Okay, finally got it, nmap --script ssl-enum-ciphers to the rescue. We will add an option to set the min TLS version accepted. I am also keen on having it set to TLS1.2 by default starting from 1.27 (I'm not as excited for adding this to 1.25 or 1.26 at the moment, out of fear of breaking existing environments).

Hi @KarthikK123 @thaviphone and anyone else that is interested in this. The linked PR is merged and there is a new build out on 1.26/edge and 1.25/edge channels. No extra arguments are needed. The build will be pushed to 1.26/stable and 1.25/stable respectively with the next patchlevel release, expected in a few days.
sudo snap refresh microk8s --channel 1.26/edge

Thanks for the update @neoaggelos! Please let me know once the change is pushed to the stable channel so that I can verify that it is not being flagged on our end anymore.


Container can not be accessed by another Docker host

Hi,
I have two hosts which have Docker (1.13.0) integrated with Flannel (0.5.5):
host1: eth0/<IP_ADDRESS>, flannel0/<IP_ADDRESS>, docker0/<IP_ADDRESS>
host2: eth0/<IP_ADDRESS>, flannel0/<IP_ADDRESS>, docker0/<IP_ADDRESS>

There is a container running on host1 whose IP is <IP_ADDRESS>, I can ping it from host1, but I can not  ping it from host2 or from any containers in host2.
Here is the output of tcpdump in host1 when I ping <IP_ADDRESS> from host2:
# tcpdump -nni eth0 host <IP_ADDRESS> and <IP_ADDRESS>
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on eth0, link-type EN10MB (Ethernet), capture size 262144 bytes
22:07:19.207158 IP <IP_ADDRESS>.8285 > <IP_ADDRESS>.8285: UDP, length 84
22:07:20.207372 IP <IP_ADDRESS>.8285 > <IP_ADDRESS>.8285: UDP, length 84
22:07:21.207464 IP <IP_ADDRESS>.8285 > <IP_ADDRESS>.8285: UDP, length 84
...

# tcpdump -nni flannel0 icmp
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on flannel0, link-type RAW (Raw IP), capture size 262144 bytes
22:09:14.556410 IP <IP_ADDRESS> > <IP_ADDRESS>: ICMP echo request, id 19788, seq 4, length 64
22:09:15.556218 IP <IP_ADDRESS> > <IP_ADDRESS>: ICMP echo request, id 19788, seq 5, length 64
22:09:16.556210 IP <IP_ADDRESS> > <IP_ADDRESS>: ICMP echo request, id 19788, seq 6, length 64

And there is no any output of tcpdump -nni docker0 icmp. So it seems the packets were not delivered from flannel0 to docker0 in host1.
Any ideas about what's wrong in my environment? Thanks!

sudo iptables -P FORWARD ACCEPT fix this
Docker change log

It works, thanks @adaiguoguo !!!

Same problem here, worked with @adaiguoguo , thanks very much!

我也碰到了原来是这个问题已解决。

works for me,  should save my hours if saw this earlier, great!

Thank you very much @adaiguoguo
It works


[device_info] - Web not supported

Description
The main repo README for device_info doesn't match the package README:
https://github.com/fluttercommunity/plus_plugins/tree/main/packages/network_info_plus#platform-support

Did device info and network info get mixed up? Network info does not have web support, but device info is available on all platforms.

device info for web:

Oh that looks good.

I'll update the right readme file


Fixed False Grit's upgrade not displaying in compendium

Assuming no more bugs appear, this is probably my last PR (at least until after release). Thanks Gk for all your hard work ^^

Turns out there are a couple of other changes I should make so I'm closing this, will re-PR later.


Adding all skins to Inventory Changer

would be cool if all skins were added to inventory changer not just the ones that are possible.
like doppler on an awp (example)
this is how the skinchanger used to work before the update to inventory changer. also if anyone is willing to help out id try adding it myself but im a brain ded paster maybe its complex i dont really know..

you can edit config file and add custom paintkit

you can edit config file and add custom paintkit

what am i doing wrong then it doesnt seem to work its just blank in game

you can edit config file and add custom paintkit

what am i doing wrong then it doesnt seem to work its just default in game

paint kit name is useless it's not even used by the cheat, its only purpose is to let you know where is the item in config file.
you should change paintkit number you can get paintkit number from sites like csgostash https://csgostash.com/skin/782/Karambit-Gamma-Doppler

you can edit config file and add custom paintkit

what am i doing wrong then it doesnt seem to work its just default in game

paint kit name is useless it's not even used by the cheat, its only purpose is to let you know where is the item in config file. you should change paintkit number you can get paintkit number from sites like csgostash https://csgostash.com/skin/782/Karambit-Gamma-Doppler

the paint kit id 416 is doppler though not sure if im doing something wrong.. im confused

gh

sorry I tested this out and it didn't work apparently,
the script puts paint kit index of each weapon separate, you can't use paintkit of another weapon, unless you hack the code, but even then I don't think the game would accept this custom weapon.
here is a simple solution, get the latest build of osiris with skin changer, and update it, it shouldn't be that difficult
https://github.com/danielkrupinski/Osiris/releases/tag/pre-inventory-changer

sorry I tested this out and it didn't work apparently, the script puts paint kit index of each weapon separate, you can't use paintkit of another weapon, unless you hack the code, but even then I don't think the game would accept this custom weapon. here is a simple solution, get the latest build of osiris with skin changer, and update it, it shouldn't be that difficult https://github.com/danielkrupinski/Osiris/releases/tag/pre-inventory-changer

alright yea. i was just making a suggestion because ive seen other cheats with inventory changer and custom skins. i have a build of osiris that has the older skinchanger ill just use that. thanks for the help anyways i appreciate it

I tested this code which should add deagle with gamma doppler skin, it doesn't work, the game just displays blank square like this
https://imgur.com/9iHZJy5
// const auto itemIndex = StaticData::getItemIndex(WeaponId::Deagle, 1090); //deagle with ocean drive skin "works!"
const auto itemIndex = StaticData::getItemIndex(WeaponId::Deagle, 1121); // deagle with glock gamma doppler skin "doesn't work"
DynamicSkinData dynamicData;
dynamicData.wear = .1337f;
dynamicData.seed = 137;
dynamicData.statTrak = 1337;
auto dynamicDataIdx = Inventory::emplaceDynamicData(std::move(dynamicData));
Inventory::addItemAcknowledged(itemIndex, dynamicDataIdx);

so there's no way the game will accept custom skins in inventory, it was working in skin changer because the script applied skins differently by forcing "fallbackpaintkit" value and item index to -1 so the game displays skin in "fallbackpaintkit".
the current inventory changer has a skin changer but it just maps item index to the item index of the skin equipped in inventory (i.e. our false inventory).
so here is an idea: add option of "custom paintkit", when the cheat sees this custom paintkit field , it applies skin by old method "fallbackpaintkit".

good idea thanks for looking into this man ;)


Features

Can you add a one tap install plugin so we can upload files to it and then people can use it for one tap install?

Can you please change the title of this issue to reflect it's actual content?


The configuration command removes all new lines from the pom

Plugin name and version
<groupId>com.microsoft.azure</groupId>
<artifactId>azure-webapp-maven-plugin</artifactId>
<version>2.5.0</version>

Actual behavior
I ran the :config command and completed the form. The configuration was saved to my pom, but it also removed every blank line on my pom, so I had to go and put these all back manually

I don't think it's good for the plugin to change with the pom file this much:

Expected behavior
Don't remove blank lines from the pom. People use them to help readability in large pom files.
Steps to reproduce the problem

@JasonFreeberg Thanks for your report, we will investigate this issue soon.

this issue should be fixed by commit https://github.com/microsoft/azure-maven-plugins/commit/a93f2d47b9a323ff3351472cf3c7d50b1777a0c0


removing unused collect deadline user plugin

CollectDeadlineUser seems to be unused but requires deadlinecommand executable to be installed on host machine. Removing it shouldn't affect anything as its results are not used anywhere.

Closes #150


Stack navigator for each tab code example warning

When running on a bare react-native project, the stack navigator for each tab code example triggers the following warning:
Found screens with the same name nested inside one another. Check:

Home, Home > Home

A similar warning is displayed when switching to the "Settings" tab.
Should the name prop of each Tab.Screen change to avoid this warning?

I am a beginner in react-navigation as well but I think you should use unique names for your screens/tabs... try doing that

@Illu  can you assign me this!


WaterDogPE proxy server transferring support

It doesn't support waterfog pe server transferring

Please provide the code, the expected functionality and the actual functionality.

Doesn't matter on my code, it joins the server fine. But the server uses a proxy that can switch between servers like if it was a dimension. And when it tries to transfer the bot becomes invisible and gets stuck on the NETHER screen

I did get the switch dimension packet
It changed to nether but didn't change to overworked again

I'm not understanding your issue. You're making an issue inside the bedrock-protocol repository. This library allows you to create clients and servers for Minecraft Bedrock Edition. It does not implement any behavior minus basic boilerplate necessary for joining a server or handling a client. (Or perhaps you are referring to the Relay? We don't intercept any transfer packets and forward them directly, this could be an added feature in a PR. )
If you would like additional behaviors you will need to implement that yourself. See https://github.com/PrismarineJS/bedrock-protocol/wiki/Using-bedrock-protocol for more information.
I'll close if this and move to a discussion if this is a general support question and not an issue with the library.

Well I don't think it can be done by clients, I think it has to supported by bedrock protocol first,
You can test it  for better understanding on Aetherpe.net by making an island and trying to do /is go

Closing as not enough information provided. If you have more information like code, expected and actual behavior to add please reopen.


Unable to open URL ... 404 Client Error: Not Found

"error: Unable to open URL: https://api.twitch.tv/kraken/user.json (404 Client Error: Not Found)"
Log:
http://i.imgur.com/Pxfteir.png

Ran into the same issue just now, even tried getting a new oauth token and still doesn't work.

Nevermind, apparently it works now for me.... I think they just had some sort of minor server hiccup for their api. Does it work now for you?


pidfile and File.exists? alias fix for ruby > 3.2.x

Noticed this stopped working with 3.3.3.
I read that .exists? alias was removed, which was where this was complaining.
Still using this package for a lot of CLI type scripts to create a semaphore, so decided to keep it.
I tried putting the .exists? alias back in on my scripts, but that was a pain, so I forked so I can just load my own source for the package.
https://github.com/sonjz/pidfile
i'm not good with rake so i just manually created a .gemspec
see bundler_test/Gemfile for bundler install test.
Haven't fully tested, just thought I'd post.

Decided to just pull the code into my lib folder, not good with gems, got stuck with 'require': cannot load such file -- pidfile (LoadError) not able to find the path even though .gemspec and all was fine.
giving up closing, clobbering everything except my code change.


enhanced the login page

Added hover effect differently, changed the titles of buttons, enhanced the animations.
previous:

now:

Hi, @anuragverma108 @huamanraj
I hope you're doing well. I've addressed the issue #886 and created a pull request to resolve it.
Could you please review the PR and let me know if any adjustments are needed?
Best regards,
Tanisha Garg

@huamanraj Please review it and give your valuable suggestions.

Great contribution to GSSOC'24! 🎉


Property not found in statics of

How do I add a static method to a class, outside of its definition?
example: flow.org/try/...
The Fantasy Land Specification says  to add certain functionality as a static member of the constructor (Semigroup spec). When I try to do this via
class Animal {}
Animal.is_a = is_a  // function 'is_a' defined elsewhere

I get the error:
3: Animal.is_a = is_a
                 ^ property `is_a`. Property not found in
13: Animal.is_a = is_a
    ^ statics of Animal

If I do a property declaration is_a: number => number; there is no change.
If I declare a dummy static function static is_a () {} and then try to overwrite it with Animal.is_a = is_a I get the error:
13: Animal.is_a = is_a
           ^ property `is_a`. Covariant property `is_a` incompatible with contravariant use in
13: Animal.is_a = is_a
    ^ assignment of property `is_a`

I want to be able to add and modify class functionality for code reuse, and to avoid having to wrap objects in a function.
What is the proper way to do this? Any insight is very much appreciated.

I also looked at the proposal-class-public-fields.
Section 2.1.1 Static Semantics: IsStatic:
I tried using ClassElement:staticPublicFieldDefinition
is_a: static number => number
it gave me an error saying the static is a reserved word
/*:: is_a: static number => number */
                ^ Use of future reserved word in strict mode

In Try flow, this works:
function is_a (x) { return x }

class Animal {
  static is_a: number => number
  speak() {
    return "Animal"
  }
}

Animal.is_a = is_a;

const biped = new Animal()

const ans = Animal.is_a(42)

The error you got about static looks like you may be missing a needed babel plugin, maybe class properties transform?

That worked, thank you very much. (You can close the issue)
Where can I request that this info be added to the documentation page?https://flow.org/en/docs/types/classes/
Or, should I just submit a pull request to said documentation page?

You're welcome to submit a PR to the doc page (in this repo) or we can change the title/description of this issue to be about adding the docs and I can do it in a little bit.

I'd like to submit the PR. I'll do it as soon as I have a minute in the next 4 hours.


Feat/data preprocessing

Call get_data() from preprocess.py to get IterableDataset of the hugging face data with cleaning and filtering. We remove line comments, docstrings, and trailing whitespace / extra new lines. The logic to remove docstrings while ignoring multiline strings was somewhat sketchy. I set the delimiter of multiline strings """ to a flag value, then regex over all doc strings, then replace flag value back to """. You can look at first 100 example input by running main to test and it looks correct. There are also some tests for the clean_comments function itself. The filtering is also pretty rudimentary, just include content if it imports any popular data science package. Pushing to main because retrain-tokenizer and chunking need this feature.

@Maxim12313 This should be merged into feat/dataset, @michaeljcliao made that branch to act as a branch for you guys to merge all dataset related branches into


Reconcile clobber error with jsonpatch

Fixes https://github.com/conda-forge/jsonpatch-feedstock/issues/11
Context: https://github.com/xlwings/jsondiff/issues/24 https://github.com/stefankoegl/python-json-patch/issues/93

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Clarify semantics of "private" rooms with a tooltip

Right now. it is not clear to people what it means when a room is created (or marked) private.  Also, the little "locked" icon is hard to interpret.
One simple way to help would be adding a tooltip for the room name that says, e.g., "Private room: you have been granted access by Jane Smith" or "Private room: you are seeing it because you have moderator privileges"

We should consider this in the new UI.


Support limit_mode_batches (int) for infinite dataloader

What does this PR do?

Update of #2787
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?
[x] Did you verify new and existing tests pass locally with your changes?
[x] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@rohitgr7 is it still wip or ready to review?

ready!

Hello @rohitgr7! Thanks for updating this PR.

In the file tests/trainer/test_dataloaders.py:

Line 263:120: E501 line too long (120 > 119 characters)

Thanks @awaelchli ✌


Error code 174979597

Hey!
I was watching the 1st course and during the "Meow" section I pressed the wrong key because it kept write meow over and over and wouldn't stop. Making it impossible to stop it, clear, etc. I refreshed the page, but it went straight to meow and repeating 'meow.' Closed the tap and now when I go to the cs50.dev site and this is what pops up.
"Unable to open '174979597'
Unable to resolve resource vscode-remote://codespaces%2Bfriendly-space-yodel-v6gww55x6pxpcx7xj/workspaces/174979597"
Version: 1.91.1
Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Embedder: codespaces

Please reach out to your course support personnel.


Do not install docs and weak depa

Description
Minify image by not installing docs and weak deps.
Refs: #3879

/retest


Add support for INSERT OVERWRITE

The patch simply added support for INSERT OVERWRITE.
We should also support CREATE TABLE AS SELECT (CTAS). However, the org.apache.flink.table.api.bridge.java.StreamStatementSet does not support CTAS yet. We need to make change to the OSS Flink first.

Thanks for the fix @becketqin. Won't we have similar issues with other DDL commands like DROP, CREATE, ALTER etc? WDYT?

Comment referring to INSERT INTO in SqlTransform should also be fixed?

Thanks for the fix @becketqin. Won't we have similar issues with other DDL commands like DROP, CREATE, ALTER etc? WDYT?

In our offline conversation, we finally concluded that we will add support for all the DDLs (Yeah, I guess it does not hurt to support all the DDLs. I'll update the patch.). Are you planning to add them as part of them same patch?

Had a discussion with @venkata91 offline again.
What is not supported with this patch is the non-computing DDL only statements. After checking the code a bit more, I found supporting that is somewhat changing the design principle of the Flink runner. After all, the non-computing statements has nothing to do with Beam. Users should probably just use TableEnv to execute the statements, instead of run the statements through the Beam pipeline which is a detour. So we will keep the patch as is.

Had a discussion with @venkata91 offline again.
What is not supported with this patch is the non-computing DDL only statements. After checking the code a bit more, I found supporting that is somewhat changing the design principle of the Flink runner. After all, the non-computing statements has nothing to do with Beam. Users should probably just use TableEnv to execute the statements, instead of run the statements through the Beam pipeline which is a detour. So we will keep the patch as is.

Agreed! We can revisit this if needed in the future.


Allow enum without arguments

Sorry, I created a conflict. Can you update this and merge at your own discretion? Thanks.


Transpose of matrix in CPP

Please assign this issue to me @SayantanMaiti

@Itachi8374 Sure. Go for it!

please assign it to me
@SayantanMaiti

@SayantanMaiti please reply, if you are assigning it to me or letting the other guy deal with this issue.


Search with MySQL backend errors if query has more than 2 words

When using the new MySQL search backend, the search throws the following exception if my search contains more than 2 words. Works fine if those words are a phrase (enclosed in double quotes). I am opening this PR to see if I can replicate the behavior I am seeing locally in our TOX suite - 3 word search works OK in Postgres and SQLite but not in MySQL.
One other odd thing, self.connector always seems to be empty.
  File "/vote-ve/lib64/python3.7/site-packages/django/db/models/expressions.py", line 480, in as_sql
    sql, params = compiler.compile(self.lhs)
  File "/vote-ve/lib64/python3.7/site-packages/django/db/models/sql/compiler.py", line 445, in compile
    sql, params = node.as_sql(self, self.connection)
  File "/vote-ve/lib64/python3.7/site-packages/wagtail/search/backends/database/mysql/query.py", line 206, in as_sql
    compiled_query = compiler.compile(self.query)  # Compile the query to a string
  File "/vote-ve/lib64/python3.7/site-packages/django/db/models/sql/compiler.py", line 445, in compile
    sql, params = node.as_sql(self, self.connection)
  File "/vote-ve/lib64/python3.7/site-packages/wagtail/search/backends/database/mysql/query.py", line 153, in as_sql
    sql, params = compiler.compile(self.value)
  File "/vote-ve/lib64/python3.7/site-packages/django/db/models/sql/compiler.py", line 445, in compile
    sql, params = node.as_sql(self, self.connection)
  File "/vote-ve/lib64/python3.7/site-packages/wagtail/search/backends/database/mysql/query.py", line 87, in as_sql
    if self.lhs.invert and self.connector == '+':  # NOTE: This is a special case for MySQL. If either side's operator is AND (+), and it is inverted, the operator should become NOT (-). If we did nothing, the result could would be '+X +(-Y)' for And(X, Not(Y)), which seems correct, but produces a wrong result. The solution is to turn the query into '+X -Y', which does work, and therefore this is done here.

Exception Type: AttributeError at /search/
Exception Value: 'CombinedLexeme' object has no attribute 'invert'

@kaedroho @ACMCMC I am sorry I didn't get any real world testing done until now. I don't see why this error is happening. I am wondering if the connector being blank means the problem is earlier than when this error is thrown. The problem happens with 'and' and 'or' queries, though I only provided a failing test for the 'and' condition. Any ideas?

Hi @cnk ! I need to look into it and can't really provide an answer right now, as I am travelling and don't have my laptop or access to a computer right now. I will get home on Monday, and I hope I can find out a proper answer then. Thanks so much for bringing this up! I hope this is not too urgent 🙏

@ACMCMC Not urgent at all. I am just embarrassed I can't see what the problem is. Enjoy your travels!

Perfect, thanks 🤞 I will get back to you on this issue as soon as I can look into it @cnk 🙌

Perfect, thanks 🤞 I will get back to you on this issue as soon as I can look into it @cnk 🙌

I have been able to reproduce your problem, and I believe I have solved it. I can either make a PR to this branch (mysql-search-problem), or open an issue with a PR solving it directly on the wagtail repo.
In a side note, please be aware that the test that you have specified self.backend.search('Javascript The Definitive', models.Book, operator='and') will not 'work' as expected. More specifically, it will not return the 'JavaScript: The Definitive Guide' Book. That's because MySQL doesn't index stop words ('The'). So, as our search query will be '+Javascript +The +Definitive', it's impossible that any entry contains 'The', and therefore it's impossible that any entry matches the three specified search terms. However, self.backend.search('Javascript Definitive Guide', models.Book, operator='and') will indeed work as expected. A possible improvement would be to remove stopwords from search queries. A similar case is found here.

@ACMCMC Why don't we just close this PR and you start a fresh one? The only reason I created this as a PR was so I could get GitHub to run the combinations of django versions + different search backends.
And I am glad to hear MySQL doesn't index stop words. I was quite surprised to find that ElasticSearch did index 'the'.


Support ResolvePlugin

What problem does this feature solve?
Be consistent with Webpack behavior
Example: https://github.com/unjs/unplugin/blob/bb2444b1f3140968723584dedfe8d5fbec1ee2fb/src/webpack/index.ts
What does the proposed API of configuration look like?
See https://webpack.js.org/configuration/resolve/#resolveplugins

cc @Boshen, unplugin need resolvePlugin to make rspack support work

resolve plugin seems has large cost than resolve hooks, we may support resolve first and see whether we could provide better unplugin support. cc @h-a-n-a @ahabhgk

bump

So what's current status of this feature now? Is it an accepted feature to be added into rspack core?

bump

@sxzz we already support resolve hook and make resolveId works in unplugin now, can you help take a look https://github.com/unjs/unplugin/pull/388


Broadcast page is not working without preview

Broadcast page is not working without preview, send now button is not working.

Preview field me type nhi hona chahiye, but when user type in preview box, its works


[1.16.5] Server crash on startup with Crossroads

Describe the Bug
The server crashes when I start a fresh new server.
On a client, the mods works just fine.
When I delete Crossroads 2.6.5 from the server and keep Essentials 2.11.1, the server starts just fine.
When I infernal-expansion 2.4.0 and keep Crossroads and Essentials, the server starts just fine.
Reproduction Steps

add the folowing mods to a minecraft forge 36.2.35 server:

Crossroads 2.6.5
Essentials 2.11.1
Infernal Expansion 2.4.0

Start the server and watch it fail

Delete Crossroads or Infernal Expansion

Start the server and watch it succeed

Expected Result
compatibility between the 2 mods so it can start on a server (client works just fine)
Screenshots and Videos
No response
Operating System
Windows 11
Mod Version
2.4.0
Minecraft Version
1.16.5
Forge Version
36.2.35
Other Mods
Crossroads 2.6.5
Essentials 2.11.1
Additional Context
I also made an issue on their github: https://github.com/Crossroads-Development/Crossroads/issues/209
debug.log
latest.log

You are using an outdated version of Infernal Expansion. This bug has been fixed in 2.5.0. Please update to the latest version.


Fix pause/resume behavior

At least on Firefox, pause and resuming a video causes VideoSub to stop
showing subtitles correctly. This is because the 'play' event is used to
reset the current subtitle; however, the 'play' event is also triggered
on resume. In other words, 'play' should not change the subtitle
position.
To simplify edge cases and ease readbility, all situations
where the current subtitle position might change have been merged into
the update_position() function.

And again, thanks!


Allow alternative Access-Control-Allow-Credentials values (close #808)

In some implementations of Snowplow, the collection server may specify access-control-allow-origin header to the wildcard '*'. This is commonly used in staging or development environments where requests are intentionally made cross-domain. In this case, the XHRHttpRequest is rejected when access-control-allow-origin='*' and withCredentials=true with the following exception;

Access to XMLHttpRequest at 'https://collection.example.com/i?QUERY_PARAMS' from origin 'http://localhost:3000' has been blocked by CORS policy: The value of the 'Access-Control-Allow-Origin' header in the response must not be the wildcard '*' when the request's credentials mode is 'include'. The credentials mode of requests initiated by the XMLHttpRequest is controlled by the withCredentials attribute.

The browser terminates the request because it is not safe to include credentials when access-control-allow-origin accepts any origin. In theory, other sites could send cross-origin requests with credentials from the client's website, raising a genuine security concern. However, in staging or development environments, we might intentionally make cross-origin requests to a collection server that does not require credentials. Setting the access-control-allow-credentials to false will prevent cookies, authorization headers, and TLS certificates from being included in the request, and allow the scenario above to complete successfully.

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

I'm open to the idea of making this configurable, I'm curious for what reasons you'd like to change this flag though? There's already a lot of configuration options in the tracker, whilst powerful it does up the complexity somewhat, although with good default values that is partially negated.
I know sometimes it comes back in pen tests as a warning, but in terms of what the tracker does when it comes to "third party" events having it default to true is the most compatible option and I'm not sure why you'd want it be false. As far as I know, it makes no difference at all when its a same-site request.
With the PR though, this is currently a breaking change as the default you've used it false. We'd need that to be true to accept this PR (and we'd need you to sign the CLA too).

I signed it!

Confirmed! @MitchPierias has signed the Contributor License Agreement. Thanks so much.

I'm open to the idea of making this configurable, I'm curious for what reasons you'd like to change this flag though? There's already a lot of configuration options in the tracker, whilst powerful it does up the complexity somewhat, although with good default values that is partially negated.
I know sometimes it comes back in pen tests as a warning, but in terms of what the tracker does when it comes to "third party" events having it default to true is the most compatible option and I'm not sure why you'd want it be false. As far as I know, it makes no difference at all when its a same-site request.

Hi Paul, thank you for taking a look at this pull request. I'd like the option to disable credentials for use in development and staging environments when the collection server does not require credentials and cross-origin is intentional. In development, for example, the access-control-allow-origin of the collection server is often set to the wildcard '*' to allow requests from localhost. In this instance, the browser terminates the request because withCredentials is always set to true, even when we don't want to provide credentials, and any origin can make requests.

With the PR though, this is currently a breaking change as the default you've used it false. We'd need that to be true to accept this PR (and we'd need you to sign the CLA too).

I've now updated the default value and related comments to false to prevent a breaking change.

Hey @MitchPierias
My colleague @greg-el is going to review this, but I don't forsee any issues. I've cherry-picked your commit into a new branch based off the release/3.2.0 branch and fixed the conflicts, as it's in conflict with the next release now. No big issue, just two new configuration options being added to out_queue.
For most users who want this, I anticipate a change to the collector will be needed as described in #808 but we will deal with that later.

Hey @paulboocock, how long until we can expect the 3.2.0 release?

Hey @paulboocock and @greg-el, how long until we can expect the 3.2.0 release?

It'll be out in January. It's quite a big release but it's all currently in test so shouldn't be too long now.


Improve cobertura absolute/relative path report generation

closes #413

I've tested it on Windows and Linux both with Jenkins build server and Cobertura Plugin. ReportGenerator is also still working.

Some comments but idea is ok to me, thank's!

FYI after merge of this https://github.com/dotnet/runtime/issues/934#issuecomment-523152939 we'll do splits with zero allocation.

running the nightly build - I noticed the slashes are not normalized
on linux the paths are all:
folder/folder/file
and windows:
folder\folder\file
Might not be an issue.. but perhaps worth noting

running the nightly build - I noticed the slashes are not normalized

I don't think that's a problem, reporters should understand all OS path format and @daveMueller can confirm that it works on some reporters like jenkins/report generator...btw before this update were they normalized in some way?

Yes I can confirm that it works on the reporters Jenkins Cobertura Plugin and Report Generator. I checked the old code and there it also wasn't normalized (https://github.com/tonerdo/coverlet/blob/b3c99fffe757431403a0f4f3c4cc1e798ff97863/src/coverlet.core/Reporters/CoberturaReporter.cs#L155).
Also Path.DirectorySeparatorChar is used to concatenate the strings and thus the format is bound to the OS specific path.


Between a relation and an identifier, binary operators should be in prefix form

Test case: =+4
Temml output:
<math display="block">
  <mrow>
    <mo>=</mo>
    <mo form="prefix" stretchy="false">+</mo>
    <mn>4</mn>
  </mrow>
</math>

Also this situation: (+4)
Temml output:
<math display="block">
  <mrow>
    <mo form="prefix" stretchy="false">(</mo>
    <mo form="prefix" stretchy="false">+</mo>
    <mn>4</mn>
    <mo form="postfix" stretchy="false">)</mo>
  </mrow>
</math>

This currently renders correctly actually:
={+4}

With the <mrow>, the browser knows apparently to put it into prefix mode.
The question is which solution is better? Specifying prefix mode or adding a dummy mrow?

This is the algorithm:

If the [...] operator is the first in-flow child of a grouping element, mpadded or msqrt with more than one in-flow child (ignoring all space-like children) then it has form prefix.

covered by #227


[Windows Terminal - Command Palette]: Clear buffer button is not functional via mouse and keyboard.

Windows Terminal version
1.22.2362.0
Windows build number
27695.1000
Other Software
Test Environment:
OS: Windows 11 Version Dev (OS Build 27695.1000)
App: Windows Terminal Preview
Steps to reproduce
Repro steps :
1.Open Windows Terminal.
2.Open the 'Command Palette' using 'Ctrl + Shift + P' keys.
3.Navigate to the clear buffer control and activate it via mouse and keyboard.
4.Observe the issue.
User Experience
Users are unable to perform the "Clear Buffer" action using either mouse or keyboard, which can hinder their workflow.
Attachments:
Clear buffer button is not  functional via mouse and keyboard..zip
Expected Behavior
Clear buffer button should be functional via both mouse and keyboard and on activating clear buffer button, it should clear all the buffer from the editing window.
Actual Behavior
Clear buffer button is not functional via mouse and keyboard.
Clear buffer button is not functional with the shortcut key as well, which is added from actions.

Hey! This was previously reported in #17867. I'll close your issue as a duplicate then. 🙂 /dup #17867
The good news is that a PR to fix it has been opened and should go out soon: #17884


ignore propagate_in_transaction in processCommand if command is async

Another thread may be propagating a transaction during an async command, however async commands are read only so it should be safe to execute it even if another thread is in a transaction.
Fixes #663.

Should we make propagate_in_transaction a serverTL variable?  I think this is just papering over a race.

Each client is tied to a thread so a transaction cannot cross threads, makes sense to make it thread local.

What about client_pause_in_transaction? Same deal?

We had discussed offline ensuring KEYS in a MULTI/EXEC block runs synchronously but I don't see that implemented here.


Add RStudio Connect folder to R gitignore

Reasons for making this change:
RStudio Connect is a way of publishing R content. The rsconnect folder is created to enable publishing, but is specific to a user.
Links to documentation supporting these rule changes:
https://community.rstudio.com/t/should-i-include-the-rsconnect-folder-to-gitignore/98237
If this is a new template:

Link to application or project’s homepage: TODO

[ ] ****


Show rating scale

Show the maximum rating, like 3.73 / 5 instead of just 3.73.

[ ] anime
[ ] book
[ ] movie

I guess these are the places where changes need to be done.. ?
movie.py line no: 11
anime.py line no: 15
book.py line no: 25
I can take this up....

@nikhilgeo Sure, go ahead! :smile:


dcp metrics supports gpu architecture

Ask your question
My environment is running dcgm-exporter, an error is reported：DCP metrics are supported for Volta, Turing or Ampere GPUs architectures only. Does dcgm currently support these architectures, and does Hopper not?

@lxzjd , Can you tell us about your environment and show output of the `nvidia-smi', also please share error log. Thank you in advance.

@nvvfedorov,
This is my nvidia-smi output:

error log：

My metrics profile default-counters.csv：

I know nvidia P40 certainly does not support the DCP metrics, but I'm very confused with this error, I tried the nvidia H800 don't have the error log, but curl http://localhost:9400/metrics also can't see the DCP related indicators. I just want to know what architectures dcgm's dcp metrics currently support.

@lxzjd, it appears that on the H800 machine, you are using the default configuration for the DCGM-exporter, which does not include DCP metrics. Please update the configuration to use the dcp-metrics-included.csv file instead.

@nvvfedorov , thank you very much, my problem is solved, the H800 does get dcp metrics, I confused the default configuration of the k8s startup with the default configuration file of the docker startup. DCP metrics are supported for Volta, Turing or Ampere GPUs architectures only that error log is too easy to misunderstand. Can you change it?


Сonfigurable axios instance with retrays and interceptors.

Is there an existing issue that is already proposing this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe it
Hi!
When using the package, I constantly encounter problems:

There is no possibility to set a retry. To do this, you need to do some utility functions in the services, or connect third-party libraries. Since you can not trust third-party services and it is better to do a retry if the request is unsuccessful (For example, status 503).
There is no possibility to additionally configure axios instance. For example, I almost always need to specify an interceptor that would transform the error by deleting sensitive data (for example, auth token).

Therefore, I constantly need to do some actions when using methods from HTTPService.
Describe the solution you'd like
I would like to be able to pass options for the retry and interceptors at once when initializing HttpModule.
Example with retries:
export type RetryOptions = {
    retryableStatuses: number[]; // statuses under which the retry will be made
    retryableCodes: string[]; // codes under which the retry will be made
    limit: number; // limit of retries
    delay: number; // delay for retry
}

export type HttpModuleOptions = {
    axiosConfig: AxiosRequestConfig;
    retryOptions?: RetryOptions;
};

export class HttpService {
    constructor(@Inject(RETRY_OPTIONS) private readonly retryOptions: RetryOptions | undefined) {}

    request<T = any>(config: AxiosRequestConfig): Observable<AxiosResponse<T>> {
        const obs = this.makeObservable<T>(this.instance.request, config);

        return this.makeRetryableRequest(obs);
    }

    protected makeRetryableRequest<TResponseData = unknown>(
        response: Observable<AxiosResponse<TResponseData>>
    ): Observable<AxiosResponse<TResponseData>> {
        if (this.retryOptions === undefined) {
            return response;
        }

        return response.pipe(rxjs.retry({ delay: ..., count: ... })).
    }
}

Example with interceptors:
export type Interceptor = {
    onFulfilled: (value: any) => any;
    onRejected: (error: any) => any;
    options?: AxiosInterceptorOptions;
}

export type HttpModuleOptions = {
    axiosConfig: AxiosRequestConfig;
    axiosInstanceInterceptors?: { response: Interceptor[] };
};

export class HttpService {
    constructor(
        @Inject(AXIOS_INSTANCE_TOKEN)
        protected readonly instance: AxiosInstance = Axios,
        @Inject(AXIOS_INSTANCE_INTERCEPTORS)
        private readonly interceptors: Interceptor[],
    ) {
        this.interceptors.forEach(interceptor => {
            instance.response.use(interceptor.onFulfilled, interceptor.onRejected, interceptor.options);
        });
    }
}

Teachability, documentation, adoption, migration strategy
No response
What is the motivation / use case for changing the behavior?
When initializing the module, I want to immediately set everything that is necessary to work with axios :)
I specified the use cases in the problems.

Thanks for your suggestion!
This has been discussed in the past and we decided to not implement it in the foreseeable future.
If you think your request could live outside Nest's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.


customshader - How can I define a array in cunstomShader uniforms?

I would like to use vec3 array in fragmentshader like three.js

Array uniforms aren't supported yet - https://github.com/CesiumGS/cesium/issues/10310


Output display

Is it possible to be able to select/redirect which chat panel NEP output goes to?

This is not possivel :(


Fix two issues found by docstyle checker

@tisnik Your image is available in the registry: docker pull MISSING_REGISTRY_NAME/MISSING_IMAGE_NAME:SNAPSHOT-PR-30


Validation Error in StreamVisualization

Hi, not sure if this issue has been covered before.
On trying to build the Sensor Visualization sample I'm receiving this error:
Validation error. error 80080204: App manifest validation error: Line 18, Column 76, Reason: The max version tested value must not be less than the min version value. SensorVisualization
Looking at the AppManifest that is built and it is indeed larger. I reset both the min and max versions in the package manifest file to <IP_ADDRESS> to no avail ether. Any idea what could be happening? I'm using VS Version 16.8.5 and OS version 20291.1000 on the HoloLens.

@martinjpratt Hi, this problem should be due to the fact that the version of WIN SDK we specified when installing VS2019 is lower than the version of WIN SDK configured in Sensor Visualization Demo.
For me, the version of WIN SDK I installed is 10.0.18362.0, but the version of WIN SDK configured by Sensor Visualization Demo is 19041.1.191206, so the build will fail.
My solution is as follows:

Hope to help you.


Failures to complete cargo publish --execute <STEP> leave unknown partial modifications.

I just started trying cargo publish on a crate and I've run into three different failure cases which were not caught by dry runs, and each of them has lead to partially complete publication that I tried to back out. In the last case, I'm not even sure how to back out the changes.
First, I checked out a new test branch because I was anxious about modifying my main branch: git checkout -b cargo-release-test.
That failed, because it attempted a git push and this is a new branch. Easy enough to revert.
Second, I was not authenticated to crates.io. This had created a new git commit, which I rolled back with git reset --hard HEAD^ which I think was sufficient (but I'm not certain).
Third, I was authenticated to crates.io, but my git remote to push to was not called origin. I looked up the correct argument (--push-to <MY REMOTE>), but now I cannot rollback the operation. Rollback steps:

error: tag v0.1.4 already exists, so I did git delete v0.1.4
Next: error: <my crate> 0.1.4 is already published, so I did cargo yank --version 0.1.4
Now I still get the same error message, and I cannot tell how or where cargo-publish gets this information, since the crate is yanked from crates.io and there is no git tag.

I assume failures like this are common, so how can users safely revert a publication? Or is the best path forward to simply issue a new release, then yank the botched release versions?
My ideal (and I'm not sure this is possible) would be some way to "fully prepare" a publication, then "atomically" commit or rollback. I assume this is impossible to do atomically since crates.io and git must be fully in sync. Any thoughts along these lines?
Assuming that ideal isn't possible, then perhaps a good improvement is to provide a hint to users about what to do if a publication fails part-way through, something like:

error: …
This publication is in an incomplete state. To proceed, fix the issue, then make a new release with a new version, then do cargo yank --version XXX, then tag the incomplete releases: git tag vXXX-publish-failure

What to do depends a lot on the specific case.
We try to catch what errors we can before the confirmation prompt.
Some failures happen during the publish.  If nothing was published, then its easy to just revert.  If some packages were published, the user likely should fix them up and resume from where they left off.  For failures after publish, I just resume where I left off.  We specifically offer the Step subcommands to allow people to pick up where they left off.  You mentioned yanking, that is also another possible route.  The problem is identifying these correctly and clearly specifying the options can get pretty complicated, both to implement and for users to process.

As there isn't a way to do fully perform operations or roll back, we show all of the relevant information in the dry run (if you increase the verbosity level enough), and we've designed things to be more recoverable (pick up where left off it it is appropriate, revert if not, etc), I'm going to go ahead and close this.
If there are thoughts on more concrete actionable steps to take, let us know!


Crash bringing up menu in win10

It looks like it's the screenshot-taker because that's the last thing in the log (it creates the mini screenshot but not the larger one).
From the log it seems it executes
https://github.com/GrognardsFromHell/TemplePlus/blob/4ee727329a3007896967b59538d0a8f70dd72e03/graphics.cpp#L523
And crashes in the first command since it doesn't make it to the second one.
Here's the end of it:
[2015-08-07 20:45:23.328] [core] [debug]  read 2956 bytes up to 966543
[2015-08-07 20:45:23.328] [core] [debug] Loading savegame for system D20 Load Save (45)
[2015-08-07 20:45:23.329] [core] [info]
------------------------------STATUS_START
[2015-08-07 20:45:23.329] [core] [info] --------------------Darkun
[2015-08-07 20:45:23.329] [core] [info] --------------------Prash
[2015-08-07 20:45:23.329] [core] [info]
D20Status_PrintObjHandleConditionDebugInfo(): [Brawl Player]
[2015-08-07 20:45:23.329] [core] [info] --------------------Theodin
[2015-08-07 20:45:23.329] [core] [info] --------------------Erwyn
[2015-08-07 20:45:23.329] [core] [info] --------------------Slutt
[2015-08-07 20:45:23.329] [core] [info]
D20Status_PrintObjHandleConditionDebugInfo(): [Failed_Copy_Scroll]
[2015-08-07 20:45:23.329] [core] [info]
------------------------------STATUS_END
[2015-08-07 20:45:23.329] [core] [debug]  read 184336 bytes up to 1150879
[2015-08-07 20:45:23.329] [core] [debug] Loading savegame for system objfade (48)
[2015-08-07 20:45:23.329] [core] [debug]  read 1076 bytes up to 1151955
[2015-08-07 20:45:23.329] [core] [debug] Loading savegame for system D20Rolls (53)
[2015-08-07 20:45:23.329] [core] [debug]  read 12 bytes up to 1151967
[2015-08-07 20:45:23.329] [core] [debug] Loading savegame for system Secretdoor (54)
[2015-08-07 20:45:23.329] [core] [debug]  read 408 bytes up to 1152375
[2015-08-07 20:45:23.329] [core] [debug] Loading savegame for system RandomEncounter (56)
[2015-08-07 20:45:23.354] [core] [info] Python: import math # builtin
[2015-08-07 20:45:23.416] [core] [info] Python: Initializing Co8 Persistent Data module
[2015-08-07 20:45:23.416] [core] [info] Python:
[2015-08-07 20:45:23.476] [core] [info] Python: import time # builtin
[2015-08-07 20:45:23.514] [core] [debug]  read 4 bytes up to 1152379
[2015-08-07 20:45:23.514] [core] [debug] Loading savegame for system ObjectEvent (57)
[2015-08-07 20:45:23.514] [core] [debug]  read 76 bytes up to 1152455
[2015-08-07 20:45:23.514] [core] [debug] Loading savegame for system Formation (58)
[2015-08-07 20:45:23.514] [core] [debug]  read 140 bytes up to 1152595
[2015-08-07 20:45:23.514] [core] [info] Loading UI data from save game.
[2015-08-07 20:45:23.514] [core] [info] gameuilib_load: Start Pos: 4
[2015-08-07 20:45:23.514] [core] [info] gameuilib_load: Function 4 (Intgame) read to: 4, Total: (0)
[2015-08-07 20:45:23.514] [core] [info] gameuilib_load: Function 8 (Anim-UI) read to: 8, Total: (0)
[2015-08-07 20:45:23.514] [core] [info] gameuilib_load: Function 10 (WMap-Rnd) read to: 1328, Total: (0)
[2015-08-07 20:45:23.514] [core] [info] gameuilib_load: Function 13 (Dlg-UI) read to: 18060, Total: (0)
[2015-08-07 20:45:23.515] [core] [info] gameuilib_load: Function 17 (Logbook-UI) read to: 52872, Total: (0)
[2015-08-07 20:45:23.515] [core] [info] gameuilib_load: Function 19 (Townmap-UI) read to: 63408, Total: (0)
[2015-08-07 20:45:23.515] [core] [info] gameuilib_load: Function 23 (Worldmap-UI) read to: 63516, Total: (0)
[2015-08-07 20:45:23.515] [core] [info] gameuilib_load: Function 30 (party_pool) read to: 63644, Total: (0)
[2015-08-07 20:45:23.515] [core] [info] gameuilib_load: Function 32 (Party-UI) read to: 63648, Total: (0)
[2015-08-07 20:45:23.515] [core] [info] gameuilib_load: Function 33 (Formation-UI) read to: 63652, Total: (0)
[2015-08-07 20:45:23.515] [core] [info] gameuilib_load: Function 34 (Camping-UI) read to: 63672, Total: (0)
[2015-08-07 20:45:23.515] [core] [info] gameuilib_load: Function 35 (Help-Inventory-UI) read to: 63676, Total: (0)
[2015-08-07 20:45:23.515] [core] [info] gameuilib_load: Function 38 (UI-Manager) read to: 63680, Total: (0)
[2015-08-07 20:45:23.515] [core] [info] gameuilib_load: Function 39 (Help Manager-UI) read to: 63692, Total: (0)
[2015-08-07 20:45:23.515] [core] [info] Completed loading of save game
[2015-08-07 20:45:23.525] [core] [info] Python: initializing _co8init.py
[2015-08-07 20:45:23.525] [core] [info] Python:
[2015-08-07 20:45:23.525] [core] [info] Python: modules\ToEE\save\slot0009.co8
[2015-08-07 20:45:23.525] [core] [info] Python:
[2015-08-07 20:45:33.175] [core] [debug] Creating screenshot with size 64x48 in save\temps.jpg
Full log:
https://drive.google.com/open?id=0BzF5KfpDewVYakF6R2pkUDRoY1U

If this is too much trouble btw, I'll just make a win10 release without taking screenshots...

 : Format 22 Type 1 Usage 1  Pool 0 MultisampleType 0 Quality 0  W 1600 H 900
[2015-08-12 21:59:11.223] [core] [debug] Stretched Scene CreateRenderTarget result obtained
[2015-08-12 21:59:11.223] [core] [debug] Stretched Scene copied from front buffer

Was a bug due to lack of DirectX9 installation on user's end.


Spyder --light is not functioning

From<EMAIL_ADDRESS>on 2013-06-19T10:45:43Z
Spyder Version:  2.2.0
Python Version:  2.7.5
Qt Version:      4.8.4, PyQt4 (API v2) 4.9.6 on Windows 7
I've installed WinPython 64bit in C:\WinPython-64bit-<IP_ADDRESS>
The directory includes both Spyder.exe and Spyder (light).exe files.
Spyder.exe works fine. On the other hand Spyder (light).exe systematically crashes after briefly opening a shell and then displaying the splash screen for a split second. If I subsequently launch either application I get a warning window advising me to use the --reset option. Doing so does not modify what happens. Any clue?
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1449

From<EMAIL_ADDRESS>on 2013-06-23T14:50:30Z
Well, thank you for trying to help but that sounds too arcane for me, especially with WinPython running its own tidy directory -I don't want to mess that up.

From<EMAIL_ADDRESS>on 2013-06-19T11:29:04Z
Try to run 2.2.0 from source https://code.google.com/p/spyderlib/wiki/NoteForContributors

From<EMAIL_ADDRESS>on 2013-06-25T18:24:29Z
Yes, thanks. Same results from the command prompt, with no output given.

From<EMAIL_ADDRESS>on 2013-06-25T11:57:28Z
I guess you should file this bug against WinPython - https://code.google.com/p/winpython/ , because Spyder is a Python application, and I don't know how these .exe files are produced.
Can you try running "Spyder (light).exe" from cmd.exe session to see if it outputs anything there?
Labels: OpSys-Windows

From<EMAIL_ADDRESS>on 2013-06-28T15:21:42Z
I'm having a similar effect on a FreeBSD 9.1 platform.
Spyder 2.2.0
Python 2.7.5
py27-qt4-4.10.2
A regular spyder session runs fine. But from a Terminal running "spyder --light" or "spyder -l" briefly flashes the splash screen and then crashes. Upon restart it gives the --reset advice but that doesn't help.
The terminal output upon the crash is:
Traceback (most recent call last):
File "/usr/local/lib/python2.7/site-packages/spyderlib/spyder.py", line 2094, in main
mainwindow = run_spyder(app, options, args)
File "/usr/local/lib/python2.7/site-packages/spyderlib/spyder.py", line 1989, in run_spyder
main.setup()
File "/usr/local/lib/python2.7/site-packages/spyderlib/spyder.py", line 801, in setup
self.ipyconsole.register_plugin()
File "/usr/local/lib/python2.7/site-packages/spyderlib/plugins/ipythonconsole.py", line 773, in register_plugin
self.main.editor.load)
AttributeError: 'NoneType' object has no attribute 'load'

From<EMAIL_ADDRESS>on 2013-06-26T10:02:11Z
No that doesn't do anything...

From<EMAIL_ADDRESS>on 2013-06-26T00:35:07Z
Does --help option works in command prompt? I guess no, but just in case..

From<EMAIL_ADDRESS>on 2013-06-28T17:58:02Z
Yes, I applied the revised patches and spyder --light works fine now.

From ccordoba12 on 2013-06-28T16:16:52Z
Thanks for reporting, this is a problem that we already fixed and we'll be released in our next version.
For reference, this is the commit that fixed it: revision 35b31bea0ff0
Summary: Spyder --light is not functioning  <span class="oldvalue"> (was: spyder --light not functioning) </span>
Status: Fixed
Labels: -OpSys-Windows Cat-SpyderGUI MS-v2.2.1


Improve Webstorm doc

#542 Add info about ES7 support, fix numeration, add info about sudo usage, add details about ESLint package selection and some other

Thanks!


Positional Identifier value

Trying to validate the attached file, I get the following "PositionalIdentifier" values inside NodeIdentification objects.

/ids1/specifications1/specification2/applicability1/attribute1/name1/ids1/specifications1/specification2/applicability1/attribute1/name1/restriction1
/ids1/specifications1/specification2/ids1/specifications1/specification2/applicability1
/ids1/specifications1/ids1/specifications1/specification6

It looks like an unwanted repetition. How I should interprate them?
ids file test.zip

Thanks for the bug report. Fixed in ce816ee


docker add hudi docker compose

Proposed changes
Issue Number: close #xxx
Problem summary
Add hudi docker compose.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

Hi @hechao-ustc , thanks for you contribution.
There are some issues:

Please add more details about how to run this docker in your PR comment, such as how to start container, how to connect to hudi using Doris' catalog feature.
Describe the pre-installed data set you uploaded to the hudi container.
It is not a good idea to upload large file, such as bundle jar file or data file in github repo. Maybe you can pack them in a zip file and give it to me, I can help you to put it some where for easy downloading

Hi @hechao-ustc , thanks for you contribution. There are some issues:

Please add more details about how to run this docker in your PR comment, such as how to start container, how to connect to hudi using Doris' catalog feature.
Describe the pre-installed data set you uploaded to the hudi container.
It is not a good idea to upload large file, such as bundle jar file or data file in github repo. Maybe you can pack them in a zip file and give it to me, I can help you to put it some where for easy downloading

Thanks for your comment, I will modify it

Hi @hechao-ustc , thanks for you contribution. There are some issues:

It is not a good idea to upload large file, such as bundle jar file or data file in github repo. Maybe you can pack them in a zip file and give it to me, I can help you to put it some where for easy downloading

Hi  @morningman , How can I send you the zip file.

run buildall

run buildall


Add hyper check for containerRuntimeVersionRequirementMet

Problems introduced by rebasing to v1.1

Failed tests will be fixed by another PR


Query results out of order in 0.4.3+

I had a line of code like:
@categories = model.categories.rank(:row_order).includes(:articles).merge(scoped_articles).references(:articles)

On 0.4.2 it returned categories in the expected ranked order.
However on 0.4.3-0.4.4 the order is no longer correct.
However I noticed that it does work in the later version if I move the rank() to the end:
@categories = model.categories.includes(:articles).merge(scoped_articles).references(:articles).rank(:row_order)

Would you consider this a regression? Or does rank() always need to be at the end like that?

Hi @richardonrails, the code for the rank scope is just:
      scope :rank, lambda { |name|
        reorder ranker(name.to_sym).column
      }

Things might be coming unstuck with reorder. I changed it here: https://github.com/mixonic/ranked-model/commit/ab5a57e59e4a72ddd424aa6757c30e90dc35cb1d
This wipes out other orders set prior. Can you do some digging to see if you're setting other orders that you would have rather seen merged instead of wiped? It's a bit of a tricky one.
ancestry has the concept of ordered_by_ancestry_and() as a way around this. Perhaps we could come up with something similar? But let's see what you find first.

I'm doing something like this:
@categories = model.categories.rank(:row_order).includes(:articles).merge(articles.rank(:row_order)).references(:articles)

So while there is another ordering involved in this line of code -- it is for the articles rather than the categories. Not sure if that answers your question...

Hi @richardonrails, it would definitely make a difference. SQL only allows for one ORDER BY clause as far as I'm aware, so when you use multiple rails order()'s it joins them together. Because we switched to using reorder() instead of order() earlier order clauses get thrown out and the last one takes effect. Are you wanting to have categories ordered by their position, then the related articles also ordered by the article's position within? If not, just omit the rank on articles and the other one will flow through. If so, you might need to not use rank() and instead use a custom order('categories.row_order', 'articles.row_order').


Fixed float regex to accept formats like 1E5, 1E-5 and 1E

Because echo 0.00001 prints 1.0E-5 so polygons with small numbers fail.

Thanks for your contribution.
I am not sure if geographic coordinates should include Eng notation. Eng Notation is supported by the others parser libraries. Example : https://github.com/creof/wkt-parser/blob/master/tests/CrEOF/Geo/WKT/Tests/PointParserTest.php#L104
@ddproxy @djlambert please share your thoughts

Well, I guess it wouldn't break anything to support it so why not.
If you decide not to, then there is a bug here https://github.com/creof/doctrine2-spatial/blob/master/lib/CrEOF/Spatial/PHP/Types/Geography/Point.php#L51 since every value is parsed (even if it's already float) which means that parsing 0.00001 fails because (string) 0.00001 is 1.0E-5 which fails in this parser.

That's definitely a bug there. There's no point wasting time with the parser.
Are there any examples in the wild of coordinate strings using E notation with symbols or cardinal direction included?

That's definitely a bug there. There's no point wasting time with the parser.

I've created a PR: https://github.com/creof/doctrine2-spatial/pull/138

Are there any examples in the wild of coordinate strings using E notation with symbols or cardinal direction included?

In both PostGIS and MySQL SELECT ST_AsText(ST_GeomFromText('POINT(1E-3 2)')) outputs POINT(0.001 2) so the notation seems to be supported.

It is supported in the WKT format. Was curious if you'd ever seen something like 79°56′3.0E-6″W (or however it'd work out)

@JanJakes Can you write a couple of tests in https://github.com/creof/geo-parser/blob/master/tests/CrEOF/Geo/String/Tests/ParserTest.php ?

When thinking about the formats there's a potential (edge case) problem with integer vs. float detection. If I understand it well, formats like 40° 26.222' should be <integer>° <float>', right? Then because of this https://github.com/JanJakes/geo-parser/blob/66dda03aa3b525ee85adcf9a64c2a433c32de470/lib/CrEOF/Geo/String/Lexer.php#L67 values like 1E5 will by considered integers (which is OK), but values like 1E-5 will be considered integers as well. So that condition should probably be fixed to something like false !== strpos($value, '.') || false !== strpos(strtoupper($value), '-E'), what do you think?

I think we're getting things mixed up here, and I'm not convinced the regex needs to be changed. This parser was designed to process values in the various degree/minute/second representations used by humans. While "1E5°" is a legitimate value, is it valid in this format? I haven't been able to find an example nor can I imagine this type of value being found on a chart, log, or other dataset with coordinates in a D-M-S format. If this type of value was programmatically generated the issue would be in the number formatter. A string value of "1E5" or "1E-5" shouldn't be handled by the library, and if I hadn't so poorly coded the logic fixed in creof/doctrine2-spatial#141 I doubt this PR or #8 would have come about. If I'm overlooking something please correct me.

The https://github.com/creof/doctrine2-spatial/pull/141 bug was definitely the reason for this PR. On the other hand I think there's no reason not to include the exponential form as long as it is handled correctly (the -E case would have to be fixed). I'm afraid complicated geometries are always generated by machines so there might be a reason to accept this form. Instead of adding this form to official examples it could be just noted somewhere below, something like: "All numbers are also accepted in exponential form, i.e. 1E5 (integer), 1.2E5 (float) or 1E-5 (float)."
That saying, fixing https://github.com/creof/doctrine2-spatial/pull/141 is probably good enough for my use case at the moment.


Copyright attributions on the map

To avoid the 'i' overlapping with the rest of the boxes, if possible, move it just outside the box.

To maintain copyright requirements the attribution must stay within the map. The next commit for this issue will move the legend above the copyright notice to fix the clipping issue


Roll Flutter Engine from f9c497f178d3 to 2bb13ccb8503 (1 revision)

https://github.com/flutter/engine/compare/f9c497f178d3...2bb13ccb8503
2024-06-19<EMAIL_ADDRESS>[Impeller] Compute correct-ish binding order for Vulkan. (flutter/engine#53463)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


PURCHASE-1484 prevent crashes when staging image data is corrupt

@kierangillen saw some crashes in the app when staging was flaky that were related to certain artworks not having full image data. Here we add a fail-safe so the app will not crash if that happens again, it will just not render any images.
https://artsyproduct.atlassian.net/browse/PURCHASE-1484
#trivial

#mergeongreen


Error trying to run ApplyProductWithNegationFunction and ReconstructOracleParameters

I'm trying to call the quantum operation using the F# console app in the docs:
Quantum code
namespace Quantum {

    open Microsoft.Quantum.Canon;
    open Microsoft.Quantum.Intrinsic;

    /// Instantiates the oracle and runs the parameter restoration algorithm.
    operation RunAlgorithm(bits : Bool[]) : Bool[] {
        Message("Hello, quantum world!");
        // construct an oracle using the input array
        let oracle = ApplyProductWithNegationFunction(bits, _, _);
        // run the algorithm on this oracle and return the result
        return ReconstructOracleParameters(Length(bits), oracle);
    }
}

F# App
namespace Host

open System.Diagnostics
open Quantum
open Microsoft.Quantum.Simulation.Simulators
open Microsoft.Quantum.Simulation.Core

module Host =
    [<EntryPoint>]
    let main _ =
        printfn "Hello, from classical world"

        use simulator = new QuantumSimulator();

        let parity = Seq.reduce(<>)

        let sampleBits = new QArray<bool>([| false; true; false |]);
        printfn "Samples bits: %A" sampleBits

        let algorithm = RunAlgorithm.Run(simulator, sampleBits).Result
        printfn "Bits from Quantum Computation: %A" algorithm

        // Process the results: in this case, verify that:
        // - the length of the return array equals the length of the input array
        Debug.Assert(algorithm.Length = sampleBits.Length, "Return array length differs from the input array length")
        // - the parity of the returned array matches the parity of the input one
        Debug.Assert((algorithm |> parity) = (sampleBits |> parity), "Return array should have the same parity as the input one")

        0

But I'm getting this error:
C:\Users\Fabrício\Desktop\Development - Windows\GitHub - Public\QuantumHelloWorld\Oracle\Quantum\Library.qs(11,22): error QS5022: No identifier with the name "ApplyProductWithNegationFunction" exists. [C:\Users\Fabrício\Desktop\Development - Windows\GitHub - Public\QuantumHelloWorld\Oracle\Quantum\Quantum.csproj]
C:\Users\Fabrício\Desktop\Development - Windows\GitHub - Public\QuantumHelloWorld\Oracle\Quantum\Library.qs(13,16): error QS5022: No identifier with the name "ReconstructOracleParameters" exists. [C:\Users\Fabrício\Desktop\Development - Windows\GitHub - Public\QuantumHelloWorld\Oracle\Quantum\Quantum.csproj]
C:\Users\Fabrício\.nuget\packages\microsoft.quantum.sdk\0.22.187631\Sdk\Sdk.targets(149,5): error MSB3073: The command "dotnet "C:\Users\Fabrício\.nuget\packages\microsoft.quantum.sdk\0.22.187631\DefaultItems\../tools/qsc/qsc.dll" build --format MsBuild -v Normal --response-files obj/qsharp/config/qsc.rsp" exited with code -3. [C:\Users\Fabrício\Desktop\Development - Windows\GitHub - Public\QuantumHelloWorld\Oracle\Quantum\Quantum.csproj]
C:\Users\Fabrício\.nuget\packages\microsoft.quantum.sdk\0.22.187631\Sdk\Sdk.targets(154,5): error : Q# compiler failed with exit code: -3. [C:\Users\Fabrício\Desktop\Development - Windows\GitHub - Public\QuantumHelloWorld\Oracle\Quantum\Quantum.csproj]

I also tried use VSCode IntelliSense to import the namespace, but it was not found.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c5e6d25a-d9bf-089d-f2e7-0b6b11959bcd
Version Independent ID: c5e6d25a-d9bf-089d-f2e7-0b6b11959bcd
Content: Write a Q# and .NET program to run on a local quantum simulator - Azure Quantum
Content Source: articles/how-to-csharp-qdk-local.md
Service: azure-quantum
Sub-service: qdk
GitHub Login: @cjgronlund
Microsoft Alias: cgronlun

I resolved it with some code from this website Quantum computing simulation using Q# with C#, but I think that would be useful to change the sample code in the docs.
Final code:
namespace Quantum {

    open Microsoft.Quantum.Arrays;
    open Microsoft.Quantum.Measurement;
    open Microsoft.Quantum.Canon;
    open Microsoft.Quantum.Intrinsic;

    operation ApplyProductWithNegationFunction (vector : Bool[], controls : Qubit[], target : Qubit) : Unit is Adj {
        for (bit, control) in Zipped(vector, controls) {
            (ControlledOnInt(bit ? 1 | 0, X))([control], target);
        }
    }

    operation ReconstructOracleParameters(N : Int, oracle : ((Qubit[], Qubit) => Unit)) : Bool[] {
        use (x, y) = (Qubit[N], Qubit()) {

            oracle(x, y);

            if (N % 2 == 1) {
                X(y);
            }

            let m = MResetZ(y);

            ResetAll(x);

            return m == One
                ? ConstantArray(N, false) w/ 0 <- true
                | ConstantArray(N, false);
        }
    }

    /// Instantiates the oracle and runs the parameter restoration algorithm.
    operation RunAlgorithm(bits : Bool[]) : Bool[] {
        Message("Hello, quantum world!");
        // construct an oracle using the input array
        let oracle = ApplyProductWithNegationFunction(bits, _, _);
        // run the algorithm on this oracle and return the result
        return ReconstructOracleParameters(Length(bits), oracle);
    }
}

Hi @tcNickolas, could you take a look at this?

The problem is that the docs page references the sample at https://github.com/microsoft/Quantum/blob/main/samples/interoperability/dotnet/qsharp/Operations.qs, but it doesn't quote the complete Q# code, just the last operation from it. If someone tries to reproduce the example looking just at the docs, without clicking through the sample folder to find the Q# code, they are going to get this error indeed, since some of the necessary Q# code is missing.
Given that we include F# and C# code from the interop example in the docs page completely, I'd recommend to include complete Q# code as well.
Let me know if you'd like my help sending the PR!

Resolved with #503. Thanks, @tcNickolas and @SoniaLopezBravo for the help!


Help bug

The botton help and chat are bugged, when I click them, nothing happens, I am having difficulties resolving challegens without any help.
Please fix it ASAP

Try joining using these links: https://github.com/FreeCodeCamp/FreeCodeCamp/wiki/Help-Rooms
I assume your issue is the "Join" button is not working in the chat sidecar?

@AbboudJr did you get this cleared up? Also, can you point to a specific challenge where this is happening along with the browser version as well.
The Help and Chat are working fine for me in Chrome Version 48.0.2564.116 (64-bit)

@AbboudJr a week has passed since this issue was created - have you been able to dive into more specifics or has this been resolved?

Closing as stale. @techtolentino thanks for your help :+1:


Lost equipped item on death

There was an instance when in the game I died and the money went from 1000 to 15 and I lost the armor that was equipped. Based on past experience and some code reading you are not supposed to be able to drop equipped items, and money should go down by 25% only.
Log details and game version
latest develop 8e371845af9b17cfbe1bc7ab8dd77f66d8e80577

Might be related/be the same thing as #319

Merge the auto-save PR. Good note from @Adrijaned there near the end that I think we should try to address via this issue:

In one of oniatus' refactors of create player workflow, which accepts the new ship for player to create with items and such, or null if it is o be the same as previous, which is used on startup/respawn. However, when called with null, it loads the previous ship from savefile (y'know, startup), but for respawn, this means you respawn with ship you last used before saving.

So we want to come up with some sane behavior in that case to avoid surprises around death/respawn/reload.


[SECURITY] Improper Signature Decoding Leading to Unhandled Panics in P2P Protocol (Discv4) - RecoveryId::from_byte

A Denial of Service (DoS) vulnerability was identified in the implementation of the Discovery Version 4 (Discv4). The vulnerability stems from improper handling of malformed signatures in the P2P message decoding process. By sending specifically crafted UDP packets with an invalid signature, an attacker can trigger a panic in the server's code, which leads to the node ceasing to process further requests.
Vulnerability details

Severity: Critical
Affected components : decode() (lambda_ethereum_rust/crates/networking/p2p/discv4.rs)

Steps to reproduce
Start a localnet using this command :
cargo run --bin ethereum_rust -- --network test_data/genesis-kurtosis.json --authrpc.port 8551 --http.port 8545 --authrpc.jwtsecret ./ethereum-package/static_files/jwt/jwtsecret

Create an exploit that sends a malformed P2P packet to the node :
use std::net::UdpSocket;

fn hex_to_bytes(hex: &str) -> Vec<u8> {
    (0..hex.len())
        .step_by(2)
        .map(|i| u8::from_str_radix(&hex[i..i + 2], 16).unwrap())
        .collect()
}

fn main() {
    let addr = "<IP_ADDRESS>:30303";
    let malformed_packet_hex = "7ca638368bf8ec32051e5f7c8510d8321d85c6807f4fc3ffb1689cce5580a8e534f486e4e92f2fdf592912aa77ad51db532dd7f9b426092384c9c2e9919414fd480d57f4f3b2b1964ed6eb1c94b1e4b9f6bfe9b44b1d1ac3d94c38c4cce915bc0f02f7c984bebfbc3982765f80a03e1bf98f025f98d54ed2f61bbef63b6b46f50e12d7b937d6bdea19afd640be2384667d9af086018cf3c3bcdd";
    let malformed_packet = hex_to_bytes(malformed_packet_hex);
    let socket = UdpSocket::bind("<IP_ADDRESS>:0").expect("Failed to bind socket");
    socket.connect(addr).expect("Failed to connect to server");
    socket.send(&malformed_packet).expect("Failed to send data");

    println!("Malformed packet sent to {}", addr);
}

thread 'tokio-runtime-worker' panicked at crates/networking/p2p/discv4.rs:89:62:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'tokio-runtime-worker' panicked at /home/.../lambda_ethereum_rust/crates/networking/p2p/./net.rs:96:69:
called `Result::unwrap()` on an `Err` value: JoinError::Panic(Id(13), "called `Option::unwrap()` on a `None` value", ...)
thread 'tokio-runtime-worker' panicked at /home/.../lambda_ethereum_rust/crates/networking/p2p/./net.rs:54:48:
called `Result::unwrap()` on an `Err` value: JoinError::Panic(Id(10), "called `Result::unwrap()` on an `Err` value: JoinError::Panic(Id(13), \"called `Option::unwrap()` on a `None` value\", ...)", ...)

Root cause
The vulnerable code is located in the Packet::decode() function, which decodes incoming P2P packets. The panic occurs when the function tries to interpret an invalid signature:
let hash = H256::from_slice(&encoded_packet[..hash_len]);
let signature_bytes = &encoded_packet[hash_len..header_size];
let packet_type = encoded_packet[header_size];
let encoded_msg = &encoded_packet[header_size..];

let head_digest = Keccak256::digest(&encoded_packet[hash_len..]);
let header_hash = H256::from_slice(&head_digest);

if hash != header_hash {
    return Err(PacketDecodeErr::HashMismatch);
}

let digest = Keccak256::digest(encoded_msg);
let signature = &Signature::from_slice(&signature_bytes[0..64]).unwrap();
let rid = RecoveryId::from_byte(signature_bytes[64]).unwrap(); ---> here

The RecoveryId::from_byte() function expects a value between 0 and 3. When the value exceeds this range, the function returns None. The subsequent .unwrap() call on this None value causes a panic, crashing the specific thread handling the P2P packet.
In the previous PoC, we modified the last byte of the signature to 0x0f and then recalculate the Keccak256 hash for the packet header. This causes the server to attempt to decode the signature, triggering the panic before any checks or validations can catch the malformed packet. Since the panic happens at the decoding stage, the server stops processing requests and may require a restart.
Impact
This vulnerability can cause the node to stop responding to P2P discovery requests, effectively isolating it from the network. Although the node does not fully crash, it experiences a severe degradation in service.
Recommendation
Add Validation Checks Before Decoding:
To prevent this vulnerability, validation checks should be added before attempting to decode the signature and other sensitive fields. By validating the integrity and format of incoming data early, the server can reject malformed or tampered packets before they are processed. Additionally, implementing proper error handling mechanisms instead of relying on unwrap() would allow the server to safely handle unexpected inputs without crashing or desynchronizing the node.

to fix your trouble check this solution click
maybe this will solve your problem.


Singleton

Convert on-performance to a singleton, so multiple instances can receive all events, without losing any of the existing data.
There's no good ways to do this, but I think using a singleton will be the most convenient to use / least prone to errors. Also not a fan of the "for all listeners to receive all events, they must be attached in the same tick" — but think in practice it'll be good enough. Wellllp, hope this good!
edit: depends on https://github.com/choojs/on-performance/pull/3 to be merged first.

v1.1.0 :tada: