Caption description update

Hey, I think it's not much effective to edit generated files because they will be regenerated each time you run npm run build command.

Oh, i see.
I'll rewrite it tomorrow. Ok?


为什么payload没有限制文件传输大小?

<dubbo:protocol name="hessian" host="${dubbo.protocol.host}" port="57994" server="jetty" payload="8388608"/>
我设置了这个和
<dubbo:provider registry="defaultRegistry" register="${dubbo.registry.register}" timeout="${dubbo.timeout}" filter="-exception" delay="-1" payload="8388608"/>
都没有作用,我传输60M的文件都没异常
uploadBytes(String systemName, String bizType, String fileSuffix, byte[] data)
这是为啥呢?
怎么才能够限制data的大小?

can you make a testcase for me?

@Test
public void upload() {
File file = new File("D:\web.jar");
try {
byte[] data = Files.toByteArray(file);
for (int i = 0; i < 100; i++) {
Response response = warehouseFacade.uploadBytes("apv", "ocr", "jar", data);
}
Response uploadBytes(String var1, String var2, String var3, byte[] var4);
<dubbo:protocol name="hessian" port="57994" server="jetty" payload="8388608"/>
<dubbo:provider registry="defaultRegistry" register="${dubbo.registry.register}" timeout="5000" filter="-exception" delay="-1" payload="8388608"/>
<dubbo:service registry="defaultRegistry" interface="facade.WarehouseFacade" ref="warehouseFacade" protocol="hessian" timeout="12000"/>

can you make a testcase for me?

dubbo 2.6.2

You can assert the length of data that it should be equal or bigger than you expect

You can assert the length of data that it should be equal or bigger than you expect

my file just 24M, i don't know how to see this Provide interface payload attribute...

I looked into code, hessian protocol do not check payload for now, use dubbo protocol instead.

I looked into code, hessian protocol do not check payload for now, use dubbo protocol instead.

But I'm transmitting big files.i need use hessian protocol,Is the Hessian protocol unsupported?Is there any other way?
thank you.

I think you better limit the file upload size in web container, not by dubbo.
Similar issue dicussed here #2813

thank you for your time,i was find other way to limit that files size.


useParams type problem in Typescript with strictNullChecks

Version
6.0.0-beta.0
Test Case
https://codesandbox.io/s/react-router-forked-qwcx0?file=/index.tsx
Steps to reproduce
There error is not shown because CodeSandbox doesn't support strict mode, but it shows if you download it and run locally
Expected Behavior
The useParams return type is defined as  Record<string, string>
But in strictNullChecks mode ist's parsed like Record<string, string|undefined>
Quick and dirty fix is Record<string, any>
Is there some way to fix this?
Actual Behavior

Thanks

That isn't how that type should behave. Something else must be going on in your environment. Here's it working find in the playground: https://www.typescriptlang.org/play?useDefineForClassFields=true&noUnusedLocals=true&noUnusedParameters=true&preserveConstEnums=true&target=99#code/C4TwDgpgBACghgJzgWwM5QLxQEoQMYD2CAJgDyrAICWAdgOYA0UF19AfANwCwAULxAA8wRYFABmAVxp5gVAjSgTUEeEjQAKAJQAuWIhToA3ryhQEEYBIQLDAXyhx0qg9x63evQjQpQw+tJiKys4amp7yPn5UCACSxIEAchLIAEYQCAB0fgjKMTTA6tkGWXDRcWF8PF6oBAA2EBm1BHSFpbHEmkA

No, it's not, the error is shown when also this is ticked

This is a beta feature and not a default of strict mode, so I wouldn't expect us to add support for it. If you have this enabled you can get around it with a null coalescing operator: parseInt(params.pairId ?? '')

OK,
I have solved it like this:
const pairId = Number.parseInt( params.pairId as string )

That isn't how that type should behave. Something else must be going on in your environment. Here's it working find in the playground: https://www.typescriptlang.org/play?useDefineForClassFields=true&noUnusedLocals=true&noUnusedParameters=true&preserveConstEnums=true&target=99#code/C4TwDgpgBACghgJzgWwM5QLxQEoQMYD2CAJgDyrAICWAdgOYA0UF19AfANwCwAULxAA8wRYFABmAVxp5gVAjSgTUEeEjQAKAJQAuWIhToA3ryhQEEYBIQLDAXyhx0qg9x63evQjQpQw+tJiKys4amp7yPn5UCACSxIEAchLIAEYQCAB0fgjKMTTA6tkGWXDRcWF8PF6oBAA2EBm1BHSFpbHEmkA

@timdorr  I find that the typing for return of useParams that is Record<string, string> might be wrong, because should be Record<string, string | undefined>.
const {userId} = useParams();   // <== if there is a `userId` it is of type `string` but might be also not existing/optional

In v5 we were using something like:
const {id, lang} = useParams<{
      id?: string;
      lang?: string;
    }>();


Inconsistent Results between RoaringBitmap.andNotCardinality(s1, s2) and RoaringBitmap.andNot(s1, s2).getCardinality()

Describe the bug
I have noticed an issue where there are inconsistent results when using RoaringBitmap.andNotCardinality(s1, s2) and RoaringBitmap.andNot(s1, s2).getCardinality().
result

RoaringBitmap version:
<dependency>
                <groupId>org.roaringbitmap</groupId>
                <artifactId>RoaringBitmap</artifactId>
                <version>0.9.45</version>
 </dependency>

Java version:
Open JDK 11

We need a reproducible test case. The current report is incomplete and cannot be investigated.
I am going to close this. Please open a new bug report with an example of the issue you have outlined. The example should be reproducible.

Please be aware that it is most likely that the bug is in your own code. You need to do enough investigation to provide strong evidence that the bug is in our library.
If you have done this work, then you should be able to provide us with enough information so that we can reproduce the issue.
We are not magicians: if we cannot verify that there is an issue, then we have no hope of fixing it.

@lemire
Okay, I'll give you the duplicate code
import com.fasterxml.jackson.databind.ObjectMapper;
import org.roaringbitmap.RoaringBitmap;

import java.io.File;
import java.io.IOException;

/**
 * <br>
 * 〈〉
 *
 * @author shencangsheng
 * @create 2023/7/24
 */
public class Main {
    public static void main(String[] args) throws IOException {
        ObjectMapper objectMapper = new ObjectMapper();
        RoaringBitmap s1 = RoaringBitmap.bitmapOf(objectMapper.readValue(new File("/tmp/s1.json"), int[].class));
        RoaringBitmap s2 = RoaringBitmap.bitmapOf(objectMapper.readValue(new File("/tmp/s2.json"), int[].class));
        System.out.println(RoaringBitmap.andNotCardinality(s1, s2));
        System.out.println(RoaringBitmap.andNot(s1, s2).getCardinality());
    }
}

This is the output

This is the input file
input.zip


Config customization not working correctly

Tried using this config, but to no avail - Resource Scanner bugs out and points in seemingly random directions, and does not allow input of any of the custom items such as magnetite.
Config: cool-resource-finder-registry.json
I know the json is valid, the only thing I can think of is that the config file isn't meant for this many entries - or it's not meant for custom groups, not sure.  Any ideas?

From further testing, it seems these are the issues at hand:

Adding modded target blocks to a group causes the Resource Scanner to not work for that group - adding blocks from Minecraft does not cause this
Crafting table does not accept modded recharge items, only those from Minecraft itself
Custom groups must be in the minecraft namespace to work, otherwise the game will crash.  (Example: spelunkery:raw_magnetite)
Other than that, the config works fine, but these issue but a larger dampener on those who want to configure it for large modpacks.  Let me know if there's any way I can help.

@Cephelo many thanks for report. Is that happens with any mod or with some particular? It will be great to get some minimal list of mods where it breaks.
ps: suspect that is due to load order of mods, maybe resources of third-party mods not ready yet. Will try to reproduce on my own with some random mod.

Ah, that is https://www.curseforge.com/minecraft/mc-mods/spelunkery, will check your config. Sorry for releasing buggy mod :)

@Cephelo can you try please updated version 0.1.2? I reproduced every issue(maybe except crash), problem was with loading order. Now mod will validate if block or item is found or not and it will try parse config in lazy manner, when all mods already pre-populated its blocks. Config for madnetite works fine now(at least in my setup).
ps: it was pointing not to player, but to air, that is default behaviour for items registry, when block not found - return air block xD

Fixed in latest versions.


fix: add default export type

I was working on a project that uses Typescript and this package was having this error related to the default export type. So I made some changes and here it is. Please check it and if everything is okay, kindly merge it or request changes.

Thank you! I had no idea what I was doing.


Re-enables smoke tests and integration tests

This PR fixes #20885

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.003%) to 41.943%

Files with Coverage Reduction
New Missed Lines
%

extensions/machine-learning/src/common/processService.ts
3
77.78%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
28923

Relevant Lines:
64086

💛  - Coveralls


[CI][Archery] Archery linking should also check for undefined symbols macOS

Describe the enhancement requested
Referring to the original issue filed https://github.com/apache/arrow/issues/40018, splitting up the integration per supported operating systems.
Component(s)
Archery

@kou for this one, need to find a solid way to find the paths for the allowed libraries in the system and then find the symbols.
This need a bit of an investigation in my end as I haven't found a feasible way yet. Appreciate any pointers if possible. 🙂

We can use nm on macOS too.
We can use otool -L instead of ldd on macOS:
$ otool -L arrow-dataset-15.0.0/aarch_64/libarrow_dataset_jni.dylib
arrow-dataset-15.0.0/aarch_64/libarrow_dataset_jni.dylib:
	@rpath/libarrow_dataset_jni.dylib (compatibility version 0.0.0, current version 0.0.0)
	/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 2202.0.0)
	/System/Library/Frameworks/Security.framework/Versions/A/Security (compatibility version 1.0.0, current version 61040.61.1)
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.12)
	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1600.157.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1336.61.1)


[Bug] Series symbol rotation is not respected in legends

Version
5.3.0
Link to Minimal Reproduction
https://codepen.io/Harshitha19/pen/RwMRxEd
Steps to Reproduce

Create a scatter series with different symbols, symbolRotation, and enable legends.
Observe that series symbol rotation is not being inherited by the legends symbol.

Current Behavior
Series symbol rotation is not inherited by the legends symbol.

Expected Behavior
Legends symbol should inherit the series symbol rotation.
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

Conclusion
Adding a method getLegendIcon() to scatterSeriesModel can solve this problem. Submitting a PR to solve this.
Problem location

More info
Interesting enough, I've found that line series would not have such problem becasue of a judgement here:
https://github.com/apache/echarts/blob/add11459ee43a56f7ff5b300c76b3f801f59f3c6/src/component/legend/LegendView.ts#L371
Since the method getLegendIcon() exists only in LineSeriesModel and MapSeries, the judgement is not satisfied for scatter chart so the icons styles are not inheritated.

Hi, This is something we are also looking for the solution. Can I get the status or any suggestions/ workaround in this regard would be much appreciated.


[SPARK-19421][ML][PySpark] Remove numClasses and numFeatures methods in LinearSVC

What changes were proposed in this pull request?
Methods numClasses and numFeatures in LinearSVCModel are already usable by inheriting JavaClassificationModel
we should not explicitly add them.
How was this patch tested?
existing tests

Test build #72104 has started for PR 16727 at commit 7833430.

Test build #72104 has finished for PR 16727 at commit 7833430.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72104/
Test PASSed.

Merged build finished. Test PASSed.

ping @jkbradley

@zhengruifeng Thanks for pointing it out. I think we should remove it. LGTM

The original PR was merged a few days ago, would you be OK with making a new JIRA just to avoid confusion? You can make it related to the previous JIRA. But otherwise looks good to me.

@holdenk I created another jira to track this issue. Thanks all for revewing!

ping @jkbradley

This looks good, merging into master. Thanks for doing this cleanup work @zhengruifeng :)


Add the "skip news" entry for some dependabot PRs

Codecov Report

Merging #13897 into main will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13897      +/-   ##
==========================================
- Coverage   59.86%   59.84%   -0.03%
==========================================
  Files         693      693
  Lines       38355    38355
  Branches     5516     5516
==========================================
- Hits        22961    22952       -9
- Misses      14214    14220       +6
- Partials     1180     1183       +3

Impacted Files
Coverage Δ

src/client/datascience/crossProcessLock.ts
79.41% <0.00%> (-11.77%)
:arrow_down:

src/client/common/utils/platform.ts
60.00% <0.00%> (-8.00%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0.00%> (-0.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13cf31a...09fd98f. Read the comment docs.


RDKDEV-680 xdial code quality issues

most of the compilation warnings should be gone (there are some that are caused by included headers, mostly Thunder headers - these can be easily fixed without changes to Thunder framework)
the memory leaks should be gone
it should be possible to compile xdial with gssdp >= 1.2

Internal ticket for tracking https://ccp.sys.comcast.net/browse/RDKCOM-3645

Hi @apatel859
Can you please review this PR?

https://github.com/rdkcentral/xdialserver/pull/84 - against 23Q2_sprint (https://github.com/rdkcentral/xdialserver/tree/23Q2_sprint) created instead


chore: keeping dependencies up to date

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.
You may find that it works just fine, or you may not.
SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.8.0
YOUR TYPESCRIPT VERSION: 4.8.2

thanks


feat: Create a image pond #8

resolves issue #8
Image preview is created using https://github.com/pqina/filepond
Height is posts wrapper div is  converted to % so that when preview is generated it does not overflow the wrapper
Tip: Always keep height/width of div in responsive units like % so that when view of your application changes your components will not get overflowed.
If you need any changes in the code feel free to mention them :)

Have you tested the application by posting the image?

@git-anurag-hub yes i tested it , it works on my device
are you having any issues ?

If you want you can do the same for editing avatar :))

@git-anurag-hub sure i'll update that also


only works inside of Image component

<Image source={src} style={styles.img}>
       <BlurView blurType="light" blurAmount={10} style={styles.blur}>
              <Text>Hi, I am a tiny menu item</Text>
       </BlurView>
</Image>

blurView works when you put it inside of react-native image component like the above. However it does not when you put it inside of View wrapper like below
<View style={styles.container}>
       <BlurView blurType="light" blurAmount={10} style={styles.blur}>
              <Text>Hi, I am a tiny menu item</Text>
       </BlurView>
</View>

The module versions I am using:
"react-native": "0.35.0"
"react-native-blur": "1.2.0"

I believe this is an iOS limitation, not necessarily this library

Just checked this issue in<EMAIL_ADDRESS>with<EMAIL_ADDRESS>- it works in both cases.

Thank you!


[Bug]: Saint Andrew Apostle calculated as Ordinary Time in 2023

What happened?
When requesting a liturgical year calendar for 2023, Saint Andrew apostle has ORDINARY_TIME as the liturgical season. Should be ADVENT.
This doesn't happen when requesting a civil year calendar for 2022.
Version
dev (Edge)
Which browser or browsers are you seeing the problem on? (can select more than one, or N/A if not applicable)
No response
Relevant error messages
No response

I see what's going on. Saint Andrew falls on both sections of the Calendar that are produced: Nov 30 2022 and then again Nov 30 2023. So Saint Andrew should show up twice in the same "Liturgical" year. But when we merge the two calendars, same keys overwrite each other, so "SaintAndrewAp" from 2023 overwrites "SaintAndrewAp" from 2022. We are still seeing Saint Andrew apostle in the correct position in the 2022 section, because both calendars produced were sorted by date, so the 2023 Saint Andrew overwrites the 2022 Saint Andrew but keeps the position that the 2022 Saint Andrew had.
In fact, on further inspection, there is no Saint Andrew 2023, there is no "Nov 30 2023" on the final calendar!
I don't see any way of preserving both, unless we refactor our output so that it's not an associative array of key => festivity, but key becomes another property of the festivity, and the output will be a simple array not an associative array. I believe this is the only way to have two celebrations with the same key and preserve both of them.


Unable to suppress extra info message with geometry.Polygon.is_valid

When calling the geometry.Polygon.is_valid test, if the test fails, in addition to the boolean a message Self-intersection at or near point <x>, <y> is printed. Is there a means to suppress this info, leaving only the boolean?
(Apologies if this is more suited to the discussion list, but I am unable to access the discussion site listed on Shapley's website.)

The issue can be replicated with the following:
import shapely.geometry as geometry
cs = [(11, 3), (20, 12), (13, 7), (18, 4)]
poly = geometry.Polygon(cs)
poly.is_valid

>>> Self-intersection at or near point 14.25 6.25
>>>False

How can the Self-intersection message be suppressed?

@benlaken it looks like you have a debug build of GEOS and code like this is writing to stderr: https://github.com/libgeos/libgeos/blob/99f187fb3fd777440acb51fff371d20a80e6e1ed/src/noding/SegmentNode.cpp#L90. There's no recourse other than to rebuild GEOS with debugging disabled.

Better to set only the shapely logger, like this :
logging.getLogger('shapely.geos').setLevel(logging.CRITICAL)
It removes all Shapely errors/warnings messages but I was forced to do it because the message I wanted to ignore and get ride of is logged as an error.


Cannot access the proxy server on embedded mode

Hi,
When using embedded mode I cant seem to access the proxy server. It throws Http Error 403 Forbidden. Is this a limitation in embedded mode? The reason I need this is that I am using a remote webdriver and I need to use the proxy server that the embedded mode created to be used remotely.

I'm going to close this since embedded mode has been working. @breinjhel - if you are still having problems, please reopen and post more information and some test code.

@jekh Ok. Thanks.


Adding new tutorial buffered_host_streaming

Signed-off-by: tyoungsc<EMAIL_ADDRESS>Description
New FPGA tutorial: buffered_host_streaming
Type of change

[X] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

[X] Command Line

Otherwise the code is rather modern compared to the usual FPGA code I read... :-)

@keryell I'll take that as a compliment :)

For the readme, two minor comments:
-The subtitle "Tutorial Design" seems out of place and unnecessary.
-Missing the subtitle Building the [sampleName] Tutorial just after the license section.


Сypress test. Email verification system.

Motivation and context
Cypress test for check email verification system.
For this CVAT build with the email support system on a cron travis-ci type. Since in this case, the tests are run through the Firefox browser, the mail system verification test is disabled for the ability to run through the Chrome browser. Tests based on checking the functionality of the login, changing the password, etc. are disabled for running through the Firefox browser.
How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Coverage decreased (-0.1%) to 62.733% when pulling e218d5a53e1f0e606ed8e6dde44cbbba87964e14 on dvkruchinin:dkru/cypress-test-check-email-verification into a9b28175626768305811a63fcbebd3d9baf6553a on openvinotoolkit:develop.

Redesigned the definition of sets depending on the CI type.
The cron type will not run tests focused on the need to register a new user and their subsequent login to perform any actions. For a normal test run (pr, push into develop), a test aimed at checking the mail verification system will not be run.

@dvkruchinin Could you please resolve conflicts?

Could you please resolve conflicts?
Done.


Benchmark framework for ATS

Do we really need to check in all these copies of e.g. the default body factory again? Couldn't we have a "setup" script that takes the necessary files from an install directory instead, before running the benchmark? Similar to how autest takes a "install" directory as a bas for setting up a test.

I think the config files that contain only comments should be removed or compressed to a single line of "#".

Yeh, I agree with @SolidWallOfCode, we should only duplicate files that are making changes. Or even better, have the benchmark script(s) modify the necessary configs accordingly.
Ideally, this benchmark tool should work similar to how autest works, where you specify the install directory of the ATS installation you want to benchmark, and then magic happens.

[approve ci]

[approve ci]


Option to draw DAGs from left to right, rather than only top to bottom.

Thanks for this. Really helpful.
This is a suggestion for an enhancement: Option to draw DAGs from left to right, rather than only top to bottom.

Can see why this messes up the clarity of text labels written horizontally.


chore: Address all non-doc lint issues

Closes #6464

The failing job is unsurprisingly because of doc-related lint issues. They'll still be a pain for us (and our community contributors) for the foreseeable future, but this PR should reduce both the number and severity of people getting hit by lint issues unrelated to their changes.
With this PR merged in we'll be a bit closer to having no lint issues on main, and so a bit closer to being able to use https://pre-commit.ci/ instead of our custom pre-commit workflow. Note that we don't currently use https://pre-commit.ci/ because it provides no way to only lint changed files, and so its check would fail for every PR.

I've got mixed feelings about the doc string changes (e.g. args to parameters). I guess that's coming from a flake8 check we where skipping in the old ci setup? Is that coming from darqlint ? I'm a little confused because it mentions wanting google style, numpy style, or sphinx style doc strings but the new pattern doesn't seem to conform to any of those three.
We explicitly picked the google style guide for docs when we settled on a doc string convention last year. I'm not certain but I feel like we already had lint checks covering that on the Gitlab side because we actually did a big batch of manual doc string addition's at one point.
Is that something we actually want to change? /cc @edgarrmondragon @aaronsteers

I've got mixed feelings about the doc string changes (e.g. args to parameters). I guess that's coming from a flake8 check we where skipping in the old ci setup? Is that coming from darqlint ? I'm a little confused because it mentions wanting google style, numpy style, or sphinx style doc strings but the new pattern doesn't seem to conform to any of those three.
We explicitly picked the google style guide for docs when we settled on a doc string convention last year. I'm not certain but I feel like we already had lint checks covering that on the Gitlab side because we actually did a big batch of manual doc string addition's at one point.

@pandemicsyn @WillDaSilva I agree with Florian and we indeed had those checks in GitLab CI.
I'm also not too comfortable reviewing and merging such a large changeset. What do you guys think about splitting the work in PRs either 1) per module or 2) per styleguide violation (e.g. WPS115).
I remember we agreed tackling typing with strategy 1, so it might make sense to agree on a similar approach.

I'm also not too comfortable reviewing and merging such a large changeset. What do you guys think about splitting the work in PRs either 1) per module or 2) per styleguide violation (e.g. WPS115).

👍 yea I agree, a lot of these changes appeared like doc string changes - so wasn't sure what the line count would look like with those removed. It definitely makes it hard to pick out manual fixes that could be more prone to errors and warrant some scrutiny.
Not quite as concerned about changes like that in meltano core where we have pretty good coverage, but the API's testing is iffy so would be easy for small unintentional bugs to slip through.

@edgarrmondragon I'll close this PR and split the changes into 1 PR per module (or other logical group for sparse changes, so as to avoid making 100+ PRs).
@pandemicsyn The Parameters: section is valid for Google docstrings, and as explained in the commit where it was done, it is more accurate. It is also the key used by Mkdocstrings to populate the table of parameters (see: https://github.com/meltano/meltano/issues/5948). I'll pull it out into a separate PR.


view: fix runDiagnostic output display

Fixes: #293

@shwstppr the output should also show stderr and exit value like old UI:
exitcode: 0

stderr:

stdout: PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes 64 bytes from <IP_ADDRESS>: icmp_seq=0 ttl=50 time=7.575 ms 64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=50 time=8.030 ms 64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=50 time=14.950 ms 64 bytes from <IP_ADDRESS>: icmp_seq=3 ttl=50 time=7.617 ms --- <IP_ADDRESS> ping statistics --- 4 packets transmitted, 4 packets received, 0% packet loss round-trip min/avg/max/stddev = 7.575/9.543/14.950/3.127 ms

Side-note I'm getting network error, for some reason the API request fails that I couldn't debug - are you seeing this as well (when using a non-local mgmt server env):

@rhtyd it works with a lab env and also with cloudmonkey local env
Made changes to show stderr and errorCode,

@shwstppr please follow the changes in future/related PRs

@rhtyd I'll ask before making changes in future/related PRs


Seeing a few different data race reports

Your environment.

Version: v1.9.0
Client: ion-sdk-js: 1.6.0
Environement: K8S
Are you using a TURN server?  coturn
Other Information

==================
WARNING: DATA RACE
Write at 0x00c000317ba0 by goroutine 140:
  github.com/pion/ion-sfu/pkg/sfu.(*DownTrack).writeSimpleRTP()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/sfu/downtrack.go:291 +0x18b
  github.com/pion/ion-sfu/pkg/sfu.(*DownTrack).WriteRTP()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/sfu/downtrack.go:149 +0x1f7
  github.com/pion/ion-sfu/pkg/sfu.(*WebRTCReceiver).writeRTP()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/sfu/receiver.go:273 +0x21b

Previous read at 0x00c000317ba0 by goroutine 195:
  github.com/pion/ion-sfu/pkg/sfu.(*DownTrack).handleRTCP()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/sfu/downtrack.go:450 +0x4f5
  github.com/pion/ion-sfu/pkg/sfu.(*DownTrack).Bind.func1()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/sfu/downtrack.go:95 +0x64
  github.com/pion/ion-sfu/pkg/buffer.(*RTCPReader).Write()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/buffer/rtcpreader.go:22 +0xcf
  github.com/pion/srtp/v2.(*ReadStreamSRTCP).write()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/stream_srtcp.go:30 +0x79
  github.com/pion/srtp/v2.(*SessionSRTCP).decrypt()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/session_srtcp.go:173 +0x23d
  github.com/pion/srtp/v2.(*session).start.func1()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/session.go:141 +0x1d3

Goroutine 140 (running) created at:
  github.com/pion/ion-sfu/pkg/sfu.(*WebRTCReceiver).AddUpTrack()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/sfu/receiver.go:114 +0x1a4
  github.com/pion/ion-sfu/pkg/sfu.(*router).AddReceiver()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/sfu/router.go:176 +0x61d
  github.com/pion/ion-sfu/pkg/sfu.NewPublisher.func1()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/sfu/publisher.go:49 +0x2a4

Goroutine 195 (running) created at:
  github.com/pion/srtp/v2.(*session).start()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/session.go:120 +0x3c8
  github.com/pion/srtp/v2.NewSessionSRTCP()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/session_srtcp.go:62 +0x805
  github.com/pion/webrtc/v3.(*DTLSTransport).startSRTP()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/dtlstransport.go:193 +0x88c
  github.com/pion/webrtc/v3.(*DTLSTransport).Start()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/dtlstransport.go:353 +0x80a
  github.com/pion/webrtc/v3.(*PeerConnection).startTransports()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/peerconnection.go:2040 +0x3b1
  github.com/pion/webrtc/v3.(*PeerConnection).SetRemoteDescription.func2()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/peerconnection.go:1113 +0x176
  github.com/pion/webrtc/v3.(*operations).start()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/operations.go:84 +0x7b
==================

==================
WARNING: DATA RACE
Write at 0x00c000416480 by goroutine 51:
  runtime.slicecopy()
      /usr/local/go/src/runtime/slice.go:246 +0x0
  github.com/pion/ion-sfu/pkg/buffer.(*Bucket).push()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/buffer/bucket.go:83 +0x3d6
  github.com/pion/ion-sfu/pkg/buffer.(*Bucket).addPacket()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/buffer/bucket.go:59 +0x4c9
  github.com/pion/ion-sfu/pkg/buffer.(*Buffer).calc()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/buffer/buffer.go:286 +0x386
  github.com/pion/ion-sfu/pkg/buffer.(*Buffer).Write()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/buffer/buffer.go:214 +0x1c4
  github.com/pion/srtp/v2.(*ReadStreamSRTP).write()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/stream_srtp.go:64 +0x79
  github.com/pion/srtp/v2.(*SessionSRTP).decrypt()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/session_srtp.go:165 +0x25e
  github.com/pion/srtp/v2.(*session).start.func1()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/session.go:141 +0x1d3

Previous read at 0x00c000416483 by goroutine 111:
  runtime.slicecopy()
      /usr/local/go/src/runtime/slice.go:246 +0x0
  github.com/pion/rtp.(*Header).MarshalTo()
      /go/pkg/mod/github.com/pion/rtp@v1.6.2/packet.go:294 +0x884
  github.com/pion/srtp/v2.(*srtpCipherAesCmHmacSha1).encryptRTP()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/srtp_cipher_aes_cm_hmac_sha1.go:76 +0xc4
  github.com/pion/srtp/v2.(*Context).encryptRTP()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/srtp.go:67 +0x165
  github.com/pion/srtp/v2.(*SessionSRTP).writeRTP()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/session_srtp.go:128 +0x105
  github.com/pion/srtp/v2.(*WriteStreamSRTP).WriteRTP()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/stream_srtp.go:137 +0xdd
  github.com/pion/webrtc/v3.(*srtpWriterFuture).WriteRTP()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/srtp_writer_future.go:85 +0x78
  github.com/pion/webrtc/v3.(*RTPSender).Send.func1()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/rtpsender.go:179 +0x90
  github.com/pion/interceptor.RTPWriterFunc.Write()
      /go/pkg/mod/github.com/pion/interceptor@v0.0.9/interceptor.go:82 +0x72
  github.com/pion/webrtc/v3.(*interceptorToTrackLocalWriter).WriteRTP()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/interceptor.go:47 +0xf5
  github.com/pion/ion-sfu/pkg/sfu.(*DownTrack).writeSimpleRTP()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/sfu/downtrack.go:307 +0x4d2
  github.com/pion/ion-sfu/pkg/sfu.(*DownTrack).WriteRTP()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/sfu/downtrack.go:149 +0x1f7
  github.com/pion/ion-sfu/pkg/sfu.(*WebRTCReceiver).writeRTP()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/sfu/receiver.go:273 +0x21b

Goroutine 51 (running) created at:
  github.com/pion/srtp/v2.(*session).start()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/session.go:120 +0x3c8
  github.com/pion/srtp/v2.NewSessionSRTP()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/session_srtp.go:62 +0x805
  github.com/pion/webrtc/v3.(*DTLSTransport).startSRTP()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/dtlstransport.go:188 +0x678
  github.com/pion/webrtc/v3.(*DTLSTransport).Start()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/dtlstransport.go:353 +0x80a
  github.com/pion/webrtc/v3.(*PeerConnection).startTransports()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/peerconnection.go:2040 +0x3b1
  github.com/pion/webrtc/v3.(*PeerConnection).SetRemoteDescription.func2()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/peerconnection.go:1113 +0x176
  github.com/pion/webrtc/v3.(*operations).start()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/operations.go:84 +0x7b

Goroutine 111 (running) created at:
  github.com/pion/ion-sfu/pkg/sfu.(*WebRTCReceiver).AddUpTrack()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/sfu/receiver.go:114 +0x1a4
  github.com/pion/ion-sfu/pkg/sfu.(*router).AddReceiver()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/sfu/router.go:176 +0x61d
  github.com/pion/ion-sfu/pkg/sfu.NewPublisher.func1()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/sfu/publisher.go:49 +0x2a4
==================

==================
WARNING: DATA RACE
Write at 0x00c0005eb108 by goroutine 25:
  github.com/pion/ion-sfu/pkg/buffer.(*RTCPReader).OnPacket()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/buffer/rtcpreader.go:38 +0x4ae
  github.com/pion/ion-sfu/pkg/sfu.(*router).AddReceiver()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/sfu/router.go:117 +0x3e6
  github.com/pion/ion-sfu/pkg/sfu.NewPublisher.func1()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/sfu/publisher.go:49 +0x2a4

Previous read at 0x00c0005eb108 by goroutine 123:
  github.com/pion/ion-sfu/pkg/buffer.(*RTCPReader).Write()
      /go/pkg/mod/github.com/pion/ion-sfu@v1.9.0/pkg/buffer/rtcpreader.go:21 +0x66
  github.com/pion/srtp/v2.(*ReadStreamSRTCP).write()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/stream_srtcp.go:30 +0x79
  github.com/pion/srtp/v2.(*SessionSRTCP).decrypt()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/session_srtcp.go:173 +0x23d
  github.com/pion/srtp/v2.(*session).start.func1()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/session.go:141 +0x1d3

Goroutine 25 (running) created at:
  github.com/pion/webrtc/v3.(*PeerConnection).onTrack()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/peerconnection.go:442 +0x164
  github.com/pion/webrtc/v3.(*PeerConnection).startReceiver.func1()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/peerconnection.go:1167 +0x58a

Goroutine 123 (running) created at:
  github.com/pion/srtp/v2.(*session).start()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/session.go:120 +0x3c8
  github.com/pion/srtp/v2.NewSessionSRTCP()
      /go/pkg/mod/github.com/pion/srtp/v2@v2.0.1/session_srtcp.go:62 +0x805
  github.com/pion/webrtc/v3.(*DTLSTransport).startSRTP()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/dtlstransport.go:193 +0x88c
  github.com/pion/webrtc/v3.(*DTLSTransport).Start()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/dtlstransport.go:353 +0x80a
  github.com/pion/webrtc/v3.(*PeerConnection).startTransports()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/peerconnection.go:2040 +0x3b1
  github.com/pion/webrtc/v3.(*PeerConnection).SetRemoteDescription.func2()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/peerconnection.go:1113 +0x176
  github.com/pion/webrtc/v3.(*operations).start()
      /go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/operations.go:84 +0x7b
==================

What did you do?
When building with the -race flag, I frequently see the above data races being reported
What did you expect?
No data races
What happened?
No immediate negative side effects, but probably worth a fix to prevent potential issues

hey @tab1293 thxs for reporting going to look at it !!


Bug: Create insights - PR showing as zero for all added insights in form

Describe the bug
Number of PRs for any given repository is shown as zero in the selected repo area in Create Insights page.
create-insights-pr-zero-issue.webm
Steps to reproduce

Go https://insights.opensauced.pizza/hub/insights/new
Click on "Add to Page" buttons
On the right hand side, the repo is added but the PR number does not match. (matches if 0)

Browsers
Chrome
Additional context (Is this in dev or production?)
dev and production
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[X] I agree to follow this project's Contribution Docs

.take

Shall I work on this issue?

Please do :slightly_smiling_face:

I am going to be busy for a week or two. I have unassigned myself for now. Will pick it up when I am able to.

I will .take this.

Hmmm yes, something's not right with the prs/insights endpoint or our data. For example, using spf13/cobra (where I know several prs have been opened within the last few weeks):
curl -X 'GET' \
  'https://api.opensauced.pizza/v1/prs/insights?page=1&limit=10&range=30&repo=spf13%2Fcobra' \
  -H 'accept: application/json'

I get:
[
  {
    "day": "2023-08-01",
    "interval": 30,
    "all_prs": 0,
    "accepted_prs": 0,
    "spam_prs": 0
  },
  {
    "day": "2023-07-02",
    "interval": 60,
    "all_prs": 0,
    "accepted_prs": 0,
    "spam_prs": 0
  }
]

This will require we look deeply at what's going on with our backfill services and API to ensure data quality.

This was fixed in a change to our ETL service, please confirm @ThePiyushAggarwal
https://github.com/open-sauced/etl/pull/80


Toml should not add a key which is protected or private

I am using typescript, it should not appear on TOML after parse if the variable was Protected or Private

The information about protected/private isd not available at runtime. TypeScript only uses the class member modifiers to statically analyze your code at compile-time. After compilation is done, a private attribute on a class is no different than a public one.

So it is impossible to hide unwanted key while parsing to TOML ?

It doesn't have much to do with TOML, the exact same thing would happen if you'd want to serialize to JSON. Unless, of course, you're using static analysis to read the code (as opposed to execute the code in the browser or in Node environment).
To do it at run-time, you might want to check our decorators. For example, class-transformer utilizes them to perform serialization for sending and receiving data via the network.


cyclops-functionaljava has a compile time dependency on Javaslang

Should be runtime / provided only.

Merged in https://github.com/aol/cyclops/pull/202


Add Capella version of ExecutionPayload and ExecutionPayloadHeader

PR Description
It involved creating interfaces for the ExecutionPayload , ExecutionPayloadHeader , BuilderBid, SignedBuilderBid and their schemas and then create Bellatrix and Capella implementations.
Fixed Issue(s)
related to #6357
Documentation

[X] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[X] I thought about adding a changelog entry, and added one if I deemed necessary.

..in progress..

@Schema annotation on tech.pegasys.teku.api.schema.interfaces.UnsignedBlindedBlock should include BlindedBlockCapella.class

I think we should merge this and have a follow up for jackson schema classes


Fix mobile width of map by defining a max-width instead of width

Summary:
The map seems to bleed into the edge of the screen on mobile viewports. This is due to the width being set to 600px. Here's what it looks like in mobile:

Changes:

[x] Change width to max-width to allow the map to shrink and it will prevent the map from bleeding over the edge, while also growing up to 600px on desktop viewports.

Looks great, thanks!


[1.15.2] Mod Interaction - Curios

Opening the Curios Inventory removes the Trash Slot.

I opened a issue at Curios github
https://github.com/TheIllusiveC4/Curios/issues/47#issuecomment-613846300
and they said they cannot fix it and the Slot have to be added to their inventory as well.

Try pressing T to toggle the Trash Slot. The slot works in nearly every inventory GUI.

Is it possible to enable it by default?

Currently only by shipping the TrashSlot.json in the modpack. #74


save game manager, pause menu

Hi,
i see that the pause menu have the variable: paused menu, such as a gui texture. Now this don't uses it. How make I at insert a gui texture? the gui texture don't is in use from unity 4.6.
Greetings Samuele

Or create a gui texture?

They're called sprites in Unity 4.6 and above.
On Sat, 11 Apr 2015 16:26 samusam<EMAIL_ADDRESS>wrote:

Or create a gui texture?
—
Reply to this email directly or view it on GitHub
https://github.com/TheSniperFan/unityserializer-ng/issues/14#issuecomment-91869404
.

Now i created a sprite but doesn't it go in pause gui. What is the procedure for insert a sprite in variable gui texture?

Hold on, I'll try it on my own system.
On Sat, 11 Apr 2015 16:35 samusam<EMAIL_ADDRESS>wrote:

Now i created a sprite but doesn't it go in pause gui. What is the
procedure for insert a sprite in variable gui texture?
—
Reply to this email directly or view it on GitHub
https://github.com/TheSniperFan/unityserializer-ng/issues/14#issuecomment-91870257
.

ok

As GUITexture is now deprecated, you'll have to create a GameObject with a
GUITexture component, and then use that.
On Sat, 11 Apr 2015 16:37 samusam<EMAIL_ADDRESS>wrote:

ok
—
Reply to this email directly or view it on GitHub
https://github.com/TheSniperFan/unityserializer-ng/issues/14#issuecomment-91870560
.

ok, tnks

Have a look at the example. It's not the most intuitive way to go about this, but the provided PauseMenu script is nothing but a simple example in the first place.


CDN links to maxcdn.com are broken

Describe the bug
I'm using twemoji.parse to convert text with emojis into image links.  The image links are broken.
To Reproduce
Try opening any of the following URLs from the README:

https://twemoji.maxcdn.com/v/latest/72x72/2764.png
https://twemoji.maxcdn.com/svg/2764.svg

Expected behavior
The images or SVG should load.

https://twemoji.maxcdn.com/v/latest/twemoji.min.js forwards to https://www.stackpath.com/blog/
Did Elon not pay his maxcdn bill or something??

@smashah He can't pay for anything lol

Hi, a fork that is currently actively maintained by former Twitter developers may help. It uses jsDelivr instead of MaxCDN for CDN provider.


FileNotFoundError: ImageFaceFusionPipeline: ImageFaceFusion: [Errno 2] No such file or directory: '/home/ubuntu/.cache/modelscope/hub/damo/cv_unet-image-face-fusion_damo/faceEnhance/GPEN-BFR-1024.pth'

No such file or directory: '/home/ubuntu/.cache/modelscope/hub/damo/cv_unet-image-face-fusion_damo/faceEnhance/GPEN-BFR-1024.pth'

same bug

@FuNian788 @luoxianjun can you gays delete the old repo or '/home/ubuntu/.cache/modelscope/, and then restart it to see if this problem can be solved by repo updating.

I fixed the bug by directly downloading model in ModelScope, and I think your solution may help. PS gays may be guys :)

I fix this bug by add the code below in the front of the  run_inference.py file
from modelscope.hub.file_download import model_file_download
model_file_download('damo/cv_unet-image-face-fusion_damo', file_path='faceEnhance/GPEN-BFR-1024.pth')

@longlongago's comment finally allowed me to track down this file.
Here's a direct link:
https://www.modelscope.cn/models/iic/cv_unet-image-face-fusion_damo/file/view/master/faceEnhance%2FGPEN-BFR-1024.pth


Added response headers to the Validation failure case of ResponseValidationFailureReason.unacceptableStatusCode

Issue Link :link:
https://github.com/Alamofire/Alamofire/issues/2245
Goals :soccer:
Adding the response headers to the ResponseValidationFailureReason.unacceptableStatusCode enum
Implementation Details :construction:
The response headers help me to determine necessary information about the validation failure.
Testing Details :mag:
A test has been created that the header is passed all the way through from validate in the test testThatValidationForRequestWithUnacceptableStatusCodeResponseFailsWithResponseHeaders

Thanks for the PR! However, it is unlikely to be merged for a few reasons:

When implementing the new error model for Alamofire 4, we thought long and hard about what to include with the error cases themselves. We decided that including only the most relevant pieces of information would be best, otherwise we'd eventually just end up capturing the entire Request with the error, which is unnecessary.
This fundamental change to the error enum would be a breaking change and would have to wait until Alamofire 5 to ship anyway.
Alamofire's validation is designed to be extensible, so you could provide your own validation and error, which will be passed to the response parsers, so any custom payloads that are needed could be handled that way.
We'll be looking at how validation and and response parsing interact for Alamofire 5, so there may be significant changes in this area over the next few months.

We'll review how this sort of request can be integrated into the library.

I agree with @jshier here @richardPFisk. You are duplicating the Request itself in the error condition which is something we worked hard to avoid in the AF 4 implementation. You have access to the Request object in validation and response closures if you need it. That would be a more applicable way to achieve the same result.
Thanks anyways! 🍻

Thanks for the time to consider this PR. Using custom validation is a good solution.
Keep up the great work!


Investigate what has to be done to use jlink with Javalin

https://docs.oracle.com/javase/9/tools/jlink.htm

Thanks @Playacem. Let's wait until someone who is really passionate about modules comes along before working more on this.

This would be super great to have.
Javalin will start to tackle aspects outside the http req resp cycle - which will add value in other places
Modules are underused because there isn't much guidance on how to use it on a 'real world' project - javalin can be that industry leader

It would be nice. Are you interested in working on this @asad-awadia?

I would love to - just don't know how 🤔
Was hoping to learn modules through this lol
I know jlink and jdep but not modules

Well, I would be great if you could work on it, but not a lot of people seem to know modules, so I'm not sure anyone here will be able to help :)


Fixed incorrect offsetting when applying ShaderMasks

ShaderMasks are applying incorrect offsets when masking over their children. For example, the following mask should be centered in the container, but is incorrectly offset.

The PR correctly offsets the mask, and updates the unit test to properly test for this behavior:

This seems to be partly undoing a fix that was applied in https://github.com/flutter/flutter/pull/10458.
/cc @jason-simmons Can you take a look at it since you authored the other change?

We should make sure we add a golden test this time, because it's going to be a lot harder to get confused when updating a golden test than a number in a unit test, especially since what we really care about is the pixel output here.

@mjohnsullivan Would you be up for adding a golden test to this like Hixie suggested in his previous comment?

Here is the guide for goldens in the wiki: https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter
We'll chat about this more offline today. :)

Added two golden file tests; the images should show that the concentric circles are centered in the Container:

Synced to head!

Disregard the bot. I have to update that message. :)


Rename the namespace for LoadTesting Sdk

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.LoadTesting


xworkspaces missing monitor

Describe the issue
Some workspaces aren't displayed by polybar.
Expected behavior:
All workspaces should be displayed.
Actual behavior:
Some workspaces aren't displayed.

Did you also experience this bug in an earlier version of polybar? Yes
If no, what was the last version where this worked correctly? Don't know

To Reproduce
Config:
[bar/example]
modules-center = ewmh

[module/ewmh]
type = internal/xworkspaces

xrandr output:
Screen 0: minimum 8 x 8, current 5360 x 1440, maximum 32767 x 32767
eDP1 connected primary 1920x1080+0+0 (normal left inverted right x axis y axis) 380mm x 210mm
   1920x1080     60.04*+  59.93
   [...]
DP1 connected 3440x1440+1920+0 (normal left inverted right x axis y axis) 800mm x 330mm
   3440x1440     59.97 +  74.98*
   [...]

Open one workspace on the left screen.
Open two workspaces on the right screen.
The last one isn't displayed.
Polybar Log
Nothing relevant in logs.
Screenshots

Environment:

WM: i3-gaps version 4.16.1
Distro: Linux 5.2.5-arch1-1-ARCH x86_64 GNU/Linux
Output of polybar -vvv:

polybar 3.4.0

Features: +alsa +curl +i3 +mpd +network(libnl) +pulseaudio +xkeyboard

X extensions: +randr (+monitors) +composite +xkb +xrm +xcursor

Build type: Release
Compiler: /usr/bin/c++
Compiler flags: -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -Wall -Wextra -Wpedantic -O3 -DNDEBUG
Linker flags: -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now

Additional context
The problem comes from this code block:
https://github.com/polybar/polybar/blob/58d72c4f1939ae1af4e853c19b9e1cd1be3de8db/src/modules/xworkspaces.cpp#L168-L173
In my example I have three workspaces, bounds.size()=3 and m_desktop_names.size()=3 so step=1 then when we enter into the following loop, there is only one workspace registered for each viewport.
https://github.com/polybar/polybar/blob/58d72c4f1939ae1af4e853c19b9e1cd1be3de8db/src/modules/xworkspaces.cpp#L198-L200

Hum, It might be quite hard to fix that.
I don't understand how the assignment is done. That's really strange :/

I also never understood why this is done this way. We may just need to rewrite this part of the module, it doesn't make sense to me either.

Okay but I don't know if I can do that without forcing m_monitorsupport to true :/
I'll see what I can do when I'll finish what I'm doing (updating my PRs because of the conflicts :cry:, …)

Any updates on this? I'm dealing with the same issue; it appears that xworkspaces is unable to display more than 3 workspaces on each monitor (I have two). When more than 3 on each monitor are open, active workspaces overwrite the ones previously displayed by the module, instead of occupying more space on the bar (which is the expected behavior).
I normally use >15 workspaces at any one time, and this is rather inconvenient.

I tried two or three things, I think I might have a way to solve this problem. I'll try to work on that.

Okay but I don't know if I can do that without forcing m_monitorsupport to true :/

Why can't we assume that _NET_DESKTOP_VIEWPORT is 0, 0 if it's not supported? In that case all desktops would be on the same monitor.

Hi, any update on this problem?


Cache condition responses

We should introduce a cache for condition responses. To start with, this could be as simple as using a map that stores response for a particular condition. We need to evaluate the added memory footprint.

This is a good one to start with  https://github.com/konveyor/analyzer-lsp/blob/60dc2048444cfcf91fe3032c1ca59fcd5e4b6f13/provider/provider.go#L368-L374. The GetDependencies() is used everytime a condition is evaluated when a dep selector is present.

Hey @pranavgaikwad,
I am thinking of adding a new field depsCache in javaServiceClient struct to store the cache dependencies
type javaServiceClient struct {
	// Other fields...
	depsCache map[uri.URI][]*provider.Dep
}

We also have to modify GetDependencies()
func (p *javaServiceClient) GetDependencies() (map[uri.URI][]*provider.Dep, error) {
	if p.depsCache != nil {
		return p.depsCache, nil
	}

	// Rest of the existing code remains the same...

	p.depsCache = m
	return m, nil
}

By this every time when GetDependencies() function is called, It will store the dependencies in depsCache
What are your thoughts on this??
Should i raise a pr by making these changes??

@RipulHandoo I should have updated this, I ended up adding the deps cache already in my PR for dep labels. If you could come up with a generic way of caching condition responses and propose a solution, that'd be awesome!

Hey @pranavgaikwad !!
I am thinking of defining a new struct Cache that will be like a storage box
type Cache struct{
        //As ```map[string]interface{}``` this will store response of any type
         data map[string]interface{}
}

Creating a Constructor to initialize and return the cache value
func NewCache() *Cache {
    return &Cache{
        data: make(map[string]interface{}),
    }
}

Methods to Set and Get the Cache
func (c *Cache) Set(key string, value interface{}) {
    c.data[key] = value
}

func (c *Cache) Get(key string) (interface{}, bool) {
    value, found := c.data[key]
    return value, found
}

And just implement in any function
func (p *javaServiceClient) GetDependencies() (map[uri.URI][]*provider.Dep, error) {
    // Create a cache instance specific to this function
   // Here assume that our cache struct is in package with namely "caching"
    cache := caching.NewCache()

    // Check if dependencies are already cached
    if deps, found := cache.Get("dependencies"); found {
        return deps.(map[uri.URI][]*provider.Dep), nil
    }

    // ... Calculate the dependencies ...
    // Once dependencies are obtained, store them in the cache
    cache.Set("dependencies", m)

    return m, nil
}

What are your thoughts on this approach??

I would love for this to be at a layer between the provider condition evaluate calls, and the provider clients themselves.
I wonder if we can create a handler-like approach, and one of the handlers can be a cache.

+1 to what Shawn said above

@shawn-hurley @pranavgaikwad Yes that would be much better.
This make a Cache Handler
type Cache struct {
	data map[string]interface{}
}
type CacheHandler struct {
	cache *Cache
}
// NewCache creates a new Cache instance
func NewCache() *Cache {
	return &Cache{
		data: make(map[string]interface{}),
	}
}
// NewCacheHandler creates a new CacheHandler instance
func NewCacheHandler() *CacheHandler {
	return &CacheHandler{
		cache: NewCache(),
	}
}
// GetDependencies retrieves dependencies from the cache
func (ch *CacheHandler) GetDependencies() (map[uri.URI][]*provider.Dep, error) {
	if deps, found := ch.cache.Get("dependencies"); found {
		return deps.(map[uri.URI][]*provider.Dep), nil
	}
	return nil, errors.New("Dependencies not found in cache")
}

// SetDependencies stores dependencies in the cache
func (ch *CacheHandler) SetDependencies(deps map[uri.URI][]*provider.Dep) {
	ch.cache.Set("dependencies", deps)
}

when the GetDependencies() method will be called, it will first look for the dependencies stored in cache. If not it will calculate them and store them in the cache
// GetDependencies retrieves the dependencies from the provider client
func (p *javaServiceClient) GetDependencies() (map[uri.URI][]*provider.Dep, error) {
	// Check if dependencies are already cached
	if deps, found := p.cache.GetDependencies(); found {
		return deps, nil
	}

	// ... Calculate the dependencies ...
	m := make(map[uri.URI][]*provider.Dep)
	// Simulating dependency calculation
	m[uri.URI("example.com/dependency1")] = []*provider.Dep{&provider.Dep{}}

	// Once dependencies are obtained, store them in the cache
	p.cache.SetDependencies(m)

	return m, nil
}

@RipulHandoo I think a provider should not worry about setting the cache at all @shawn-hurley right?

I hoped it would be something providers never have to know about.
But if we are making the changes in the provider code that we own that encapsulates the external providers (such as GRPC) I think that would be fine, as it would happen outside the scope of the actual provider implementation.
Can you try to wrap the calls to a Handler in the CacheHandler to cache the results?
basically add to the Cache struct a Handler interface, and when we create a Provider, wrap it in the cache handler.
Does that make sense @RipulHandoo ? If a quick phone call would help we can schedule some time!

I hoped it would be something providers never have to know about.
But if we are making the changes in the provider code that we own that encapsulates the external providers (such as GRPC) I think that would be fine, as it would happen outside the scope of the actual provider implementation.
Can you try to wrap the calls to a Handler in the CacheHandler to cache the results?
basically add to the Cache struct a Handler interface, and when we create a Provider, wrap it in the cache handler.
Does that make sense @RipulHandoo ? If a quick phone call would help we can schedule some time!

@pranavgaikwad @shawn-hurley
I'll try and let you know if i could not fix that then a phone call will help a lot.
But
Upon reviewing the codebase again, it has come to my attention that the javaServiceClient struct already includes a depsCache field of type map[uri.URI][]*provider.Dep. This field serves as a cache to store fetched dependencies for the client.
The code for caching in the GetDependencies function is effectively implemented using thisdepsCachefield. When the GetDependencies function is called, it first checks if the depsCache is not empty. If the cache is populated with previously fetched dependencies, the function directly returns the cached result, avoiding redundant computations.
Given this existing caching mechanism, introducing an additional cache struct or using a handler chain with a cache handler might be redundant and unnecessary in this context.
Correct me if I'm wrong..

@RipulHandoo depsCache is an interim solution specific to the Java provider...for the condition caches, we are looking for a generic solution that handles responses from all provider conditions not just dependency ones and also for all providers.

I could be totally off-base here, but I wanted to throw my hat into the ring on this issue. I went ahead and forked the repo here and did some preliminary work on this. I can create a PR so we can discuss on there as well, if you folks want.
I created a struct, ConditionalCache in engine/conditions.go, that simply has two maps, mapping a string to the ConditionResponse and error that can result from a Conditional calling Evaluate. Then, in each of the Evaluate methods I marshal the struct of the Conditional into a string and use that string in the cache, caching the result of the function if it wasn't found. engine/conditions.go:Rule.When already uses YAML.marshal on Conditionals, so it shouldn't be a problem if that was working correctly.
In terms of performance benefits, I went ahead and ran the containerized demo with time sudo podman run -v $(pwd)/demo-output.yaml:/analyzer-lsp/output.yaml:Z test-analyzer-engine, and these were the results:
Without cache:
  real    1m35.181s
  user    0m0.214s
  sys     0m0.202s

With cache:
  real    1m31.411s
  user    0m0.219s
  sys     0m0.202s

A small performance increase, but this could just be due to system varaiblility more than anything. I could definitely see if conditions are reused this could result in better performance (if my implementation doesn't break anything)
There is a small hitch with this implementation - it requires that all the necessary fields to uniquely identify a Conditional to be public. I had to modify testConditional in engine_test.go in order for them to pass. Unsure if this is a problem or not. ProviderCondition contains the field ConditionInfo interface{}, which also may or may not be an issue. I could also see that we could make each Conditional provide it's own hash function to sidestep any potential issues with YAML, but that may require a lot more effort than it's worth.
Even though this requires each Evaluate method to be modified, it also allows each Conditional to opt in to the caching.
Would love to get your thoughts on this!

@JonahSussman I think rule-example.yaml is not a good representation for performance benefits. The benefits will be more apparent when there are multiple rules, a good portion of them making the exact same queries multiple times, etc.

@JonahSussman, this implementation looks good to me, I would probably handle some way for the condition to set its own cache key of some sort rather than yaml marshal the whole thing.
I agree with @pranavgaikwad it will take a better example, honestly I would be interested in using this to test out some of the bigger test cases that come from the windup shim to see if there is an increase

@RipulHandoo does the code that @JonahSussman sent make sense? do you want to take that commit and make some of the changes?

@shawn-hurley This implementation makes a lot of sense.
I'll be more than happy to commit on this.
And talking about the yaml.Marshal() method,
I am thinking of caching each condition like this
// Get the sorted conditions
conditions := sortConditionEntries(a.Conditions)

// Generate a cache key for the sorted conditions
cacheKey := generateCacheKey(conditions)

// Check cache
cacheResponse, cacheError, cacheOk := GlobalConditionalCache.Get(cacheKey)
if cacheOk {
	return cacheResponse, cacheError
}

// Evaluate conditions
for _, c := range conditions {
   // ... existing evaluation logic ...
}

// Set cache at the end
GlobalConditionalCache.Set(cacheKey, fullResponse, nil)

return fullResponse, nil

We can generate the cacheKey using some hash function or some other way.
Would love to hear your thoughts on this...

I think that hash of the conditions could work I truly have not thought about it

@shawn-hurley
I am thinking of generating the cache by converting the whole condition into slice and then generating the hash for it.
func generateCacheKey(conditions []ConditionEntry) string {
   // Use a hash function to generate a unique cache key
   hash := sha256.New()
   hash.Write([]byte(fmt.Sprintf("%v", conditions)))
   return hex.EncodeToString(hash.Sum(nil))
}

What do you think?

when we call the underlying provider, we should have a stringified thing for the actual conditions (it does the replacement) IIRC. I think she sum that string is fine.
I do wonder if the key could just be that string vs a hash

https://github.com/konveyor/analyzer-lsp/blob/main/provider/provider.go#L388
the templatedInfo

@shawn-hurley
I think if i am not wrong the templateCondition function
https://github.com/konveyor/analyzer-lsp/blob/main/provider/provider.go#L479
returns byte[]of slice that we can use as a key as it will be unique.
Other doubt i've is like Evaluate() function has 3 parameters but when we are calling it from provider.go
https://github.com/konveyor/analyzer-lsp/blob/main/provider/provider.go#L388
we are only passing 2 parameters
Why so?

@RipulHandoo are you still working on it?
@pranavgaikwad is this issue still on ?

No @Parthiba-Hazra. You can work on it if you want.


fix(core): array-type.ts to have immutable model

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug Fix in a new Feature.  The array-type.ts type in core should support immutable model changes
What is the current behavior? (You can also link to an open issue here)
currently, you cannot directly change the model for a FieldType due to the set function being deprecated.  the ArrayType that extends it appends an item using .splice instead of using the spread operator [...model]. Because of this, when a library, like material and its mat-table, expects immutable changes from a model they aren't supported out of the box.  The work around being to encapsulate in a custom array-type a separate field that properly returns an immutable model when reading said value
What is the new behavior (if this is a feature change)?
With the changes given, this updates the base library to supporting immutable model changes thereby supporting other libs that expect immutable models
Please check if the PR fulfills these requirements

[x] The commit messages follow our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[ ] A unit test has been written for this change.
[x] Running npm run build produced a successful build. (Unit testing can be done by running npm test;)
[x] My code has been linted. (npm run lint to do this. npm run build will fail if there are files not linted.)

Please provide a screenshot of this feature before and after your code changes, if applicable.
Other information
stackblitz of the issue and work around
https://stackblitz.com/edit/angular-rv7jtn
hit Add item to bring up a nested form.  hit save to save that item and what should happen is it adds another to the model and shows in the table.  the model is updated (as you can see in the number changes in the header) but the table is not due to the fact that basing the table off the model yields the same array reference.  To fix follow the comments and it will work properly however I think the preferred fix would be this PR.
This particular use case is being able to use formly arrays based on json schema generated formly configs but having a readonly list and an imbedded form for adding singles that can be extended to be a modal or a simple form as I have it implemented there.
Currently, there are no tests written that support the code.   Also, due to it being a small change I simply edited on GitHub.

or use formControl.value instead of model https://stackblitz.com/edit/angular-rv7jtn-tkeyfq

@aitboudad 👍 not sure how I missed that :(.  Should I cancel this PR?

let's closing then!


adds default plotting x,y,z categories

@DanielJMaher Looks good to me.  Review functionality and merge when you are ready.

@oceanzus  merged.


Add ability to get a lazy plain object.

It's really useful that I am able to get an object reference from Restangular and have angular update the view dynamically.

// Do stuff with restangular on the result.

However it would be nice to have access to both a restangular document and a non-restangular document.

// Do stuff without restangular.

Is this possible now?

Do you mean an object that is equal to the one on your server?
One without any Restangular-specific properties?
That is actually possible. Look here: https://github.com/mgonto/restangular#element-methods
plain()

The problem is that I can't use #plain in the view because it is only attached after the response.

Please see https://github.com/mgonto/restangular#how-can-i-access-the-unrestangularized-element-as-well-as-the-restangularized-one


Add Heroku section under Services & Integrations in the docs.

While writing documentation for the new Heroku features I had great difficulties picking the right place to put these docs.
Since we have quite a few Heroku-specific features I think it's good to give it a prominent place in the navigation.

Move host metrics to Heroku section (added Netlify redirect to not break the old link).
Add Heroku section with:

Logdrain

Errors

Host metrics

Dashboards

Would it make sense to also move the Deploy Markers docs for Heroku to here?
PS: We also have documentation in Heroku's Dev Center. Keeping info shared across two platforms will probably lead to a hot mess. I'm looking into this.

Would it make sense to also move the Deploy Markers docs for Heroku section here?

Ah yeah, I'll add that here too!


test(dm): fix unstable tests

Signed-off-by: lance6716<EMAIL_ADDRESS>
What problem does this PR solve?

Issue Number: close #5602
What is changed and how it works?

resume may see old error, so we don't check result: true
two MySQL sources are concurrent

Check List
Tests

No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.

/cc @sdojjy

Codecov Report

Merging #6498 (b05f526) into master (f0e21a6) will increase coverage by 0.0215%.
The diff coverage is 78.1170%.

Flag
Coverage Δ

cdc
66.1167% <72.0306%> (+0.0397%)
:arrow_up:

dm
52.0299% <ø> (-0.0429%)
:arrow_down:

engine
64.1587% <90.1515%> (+0.0578%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #6498        +/-   ##
================================================
+ Coverage   59.4618%   59.4833%   +0.0215%
================================================
  Files           762        765         +3
  Lines         87377      87606       +229
================================================
+ Hits          51956      52111       +155
- Misses        30815      30881        +66
- Partials       4606       4614         +8

/cc @lichunzhu @buchuitoudegou

/merge


CI: pulsar does not run tests with httpServer enabled

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
Problem found in private tests, hot-fixed https://github.com/apache/pulsar/pull/20070 (which does not add proper tests)
Solution
some of the e2e integration tests should enable httpServer, possibly other options to provide better coverage
Alternatives
No response
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Please assign this to me.

@MMirelli assigned. But would you explain your plan and an estimate since this is somehow a release blocker?

I would:

clone an integration test (like this one)
pass httpServerEnabled=true when starting up the server
running some smoke test after deployment

WIP: https://github.com/apache/pulsar/compare/master...MMirelli:pulsar:mm-implement-integration-test-with-httpServer-enabled-20071
4. replace this

Thanks for your update @MMirelli!
After a closer look I find that it's not something wrong with CI settings and not a release blocker but an enhancement to improve test coverage. Go ahead and feel free to ping me as a reviewer once you have a workable patch.


quick fix for unawaited_futures inserts and invalid await in a cascade

class C {
  Future<String> something() {
    return Future.value('hello');
  }
}

void main() async {
  C()..something(); // unawaited_futures
}

Running the quick fix "Add 'await' keyword" results in invalid code.
class C {
  Future<String> something() {
    return Future.value('hello');
  }
}

void main() async {
  C()await ..something(); // expected to find ';'
}

An alternative fix to suggest could be to ignore the future, but I'm not sure if it's a good idea to offer that. WDYT @lrhn
class C {
  Future<String> something() {
    return Future.value('hello');
  }
}

void main() async {
  C()..something().ignore();
}

I think ignore may be the best we can do for now.
The problem with a cascade invocation of an async function, is that the value is never available as an expression, so there is no way to wrap in unawaited or await.
We could add something, but the real answer here is "if it hurts, stop doing it!".
You shouldn't call an async function that way, just make it a non-cascade, and treat the future properly.
Or use ignore, which is safer than unawaited if an error actually happens.
Or wait for us to finally add a suffix .await.
Today: use ignore, rewrite to not be a cascade, or refuse to do anything.
Either it's fine with me.

We could certainly write a fix (or extend the existing fix) to split the cascade appropriately so that an await could be added, but I suspect that this case won't come up very often and that we're better off just disabling the fix for invocations in cascades.

class C {
  Future<String> something() {
    return Future.value('hello');
  }
}

void main() async {
  C()..something(); // unawaited_futures
}

Running the quick fix "Add 'await' keyword" results in invalid code.
class C {
  Future<String> something() {
    return Future.value('hello');
  }
}

void main() async {
  C()await ..something(); // expected to find ';'
}

An alternative fix to suggest could be to ignore the future, but I'm not sure if it's a good idea to offer that. WDYT @lrhn
class C {
  Future<String> something() {
    return Future.value('hello');
  }
}

void main() async {
  C()..something().ignore();
}

we're better off just disabling the fix for invocations in cascades.

This SGTM as well.

I think ignore may be the best we can do for now.
The problem with a cascade invocation of an async function, is that the value is never available as an expression, so there is no way to wrap in unawaited or await.
We could add something, but the real answer here is "if it hurts, stop doing it!".
You shouldn't call an async function that way, just make it a non-cascade, and treat the future properly.
Or use ignore, which is safer than unawaited if an error actually happens.
Or wait for us to finally add a suffix .await.
Today: use ignore, rewrite to not be a cascade, or refuse to do anything.
Either it's fine with me.

We could certainly write a fix (or extend the existing fix) to split the cascade appropriately so that an await could be added, but I suspect that this case won't come up very often and that we're better off just disabling the fix for invocations in cascades.

I'm sorry, I have no idea about things here, I didn't mean to make a mistake on purpose.


add delivery config

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@delivery approve

Failed to approve change: d8ddcc65-dbb0-4d5d-90c5-5575ea3a64d0 @afiune

:+1:

@delivery approve

Failed to approve change: d8ddcc65-dbb0-4d5d-90c5-5575ea3a64d0 @afiune

@delivery approve

Change: d8ddcc65-dbb0-4d5d-90c5-5575ea3a64d0 approved by: @afiune

This PR has passed 'Acceptance' and is ready to be delivered!
Use: '@delivery deliver' when validated in acceptance.


cannot capture www.hertz.co.uk due to crash of PhantomJS

Using version phantomjs-1.9.7-linux-x86_64 (on a linux machine obviously) and using our own rasterize JS file OR the example.js rasterise file inside /phantomjs-1.9.7-linux-x86_64/examples/, I am unable to capture the page of hertz.co.uk (or .it, .de etc). When I attempt this (by example executing "sudo /opt/cm2/bin/phantomjs ./phantomjs-1.9.7-linux-x86_64/examples/rasterize.js http://www.hertz.co.uk dummy.png dummy.html")
phantomJs crashes. I have attached the .dmp file. Although I had to rename the extension to be a jpg so i could upload the file!
cheers
david

Please upgrade to PhantomJS 2. 1.9.x is no longer supported, and known to have many crasher bugs that are fixed in 2 version.


Anima_on_started/compleleted will not work well at sometimes in Godot 4

Hi! I just start to use this amazing tool. But there are few issues I got:

anima_on_started/completed will not worked at some times:1. Lambda function. 2. None parameter function. 3. Function with array parameter.

For this issue. I checked from code(tween.gd). And I found that fn.callv(args) will not call function with none parameter

anima_on_started/completed may be called at almost same time.

I tried to get changing values from callbacks. Values maybe the final value not changing value(For instance form picture. Value in anima_on_started should be 100 not 70).

For first issue. I tried to remove "[null]" parameter from callabacks. And call "fn.call()" instead of "fn.callv(args)". But I also want to listent to your advice for this issue.
For the rest issues. I didn't step deep into codes.
Please take look if you have time. Thanks!

Yes, this PR fixes the issue: https://github.com/ceceppa/anima/pull/36


Test layer menu to work with sub levels

Test current implementation with one more sublevel, e.g., the menu item "Educação" have a layer "IDEB por município...". This layer could have a sub layer to be shown when clicked.

It's not working properly with search.

Filed in #99


Sort plugins by human-readable name, not (hyphenated) codename

Sorting by plugin name continues to use the codename, even though the hub supports the human-readable name now.
A related nice-to-have would be to
- update the sorting algorithm to ignore "napari*" at the beginning, OR
- omit "napari*" at the beginning of the human-readable name.
Otherwise, users sorting by name have to remember to look at plugin names beginning with "napari".
cc: @neuromusic @psobolewskiPhD

Oooo, I like this—thumbs up from me.
See related napari/napari issue: https://github.com/napari/napari/issues/5304
The npe2 manifest includes display_name:
https://napari.org/stable/plugins/manifest.html#fields
This is intended to be used in user facing fields.
I get a that a plugin dev may want napari-foobar to be in the plugin name for purposes of GitHub, PyPi, etc. for their napari plugin implementation of foobar segmentation, once the napari-hub and GUI is involved, it's obvious that the plugins are napari plugins, so Foobar Segmentation is a much more understandable.

@psobolewskiPhD :D
We recently added support for a variety of npe2 fields, including display_name... But even though this shows up on plugin pages and cards:
Example

However, what @kandarpksk is noting here is that our sorter still sorts based on the package name, not the display name.
(I updated the issue title to clarify)

LGTM! I tried it out in the home page, as well as with a search. The ordering logic also seems to match the sitemap at a glance.


Moved API implementation to its own folder, updated SDK example a bit

Perhaps it'd be better to merge into refactor branch. Also do you think that we shouldn't use sdk folder? In refactor branch every folder contains api/sdk folders with the corresponding implementation


Bosun  with elasticsearch as backend storage not working

Hi,
I have following dev.conf for bosun-windows-amd64.exe for latest release.
logstashElasticHosts=http://blueduck:9200
smtpHost = host:[port]
emailFrom =<EMAIL_ADDRESS>httpListen = :8070
timeAndDate = 202,75,179,136
stateFile = ../bosun.state
ledisDir = ../ledis_data
checkFrequency = 5m

notification default {
	email =<EMAIL_ADDRESS>	print = true
}

And doing following api call which result in 404  server error.
POST http://<IP_ADDRESS>:8070/api/put HTTP/1.1
Host: <IP_ADDRESS>:8070
Connection: keep-alive
Content-Length: 495
Cache-Control: no-cache
Origin: chrome-extension://fdmmgilgnpjigdojojpjoooidkmcomcm
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.87 Safari/537.36
Content-Type: application/json
Accept: */*
Accept-Encoding: gzip, deflate
Accept-Language: en-GB,en-US;q=0.8,en;q=0.6

[{
	"metric": "hello.world",
	"timestamp":<PHONE_NUMBER>,
	"value": 1234,
	"tags": {
		"name": "vinayak",
		"desi": "tech"
	}
}, {
	"metric": "hello.world",
	"timestamp":<PHONE_NUMBER>,
	"value": 123,
	"tags": {
		"name": "vinayak",
		"desi": "tech"
	}
}, {
	"metric": "hello.world",
	"timestamp":<PHONE_NUMBER>,
	"value": 12,
	"tags": {
		"name": "vinayak",
		"desi": "tech"
	}
}, {
	"metric": "hello.world",
	"timestamp":<PHONE_NUMBER>,
	"value": 34,
	"tags": {
		"name": "vinayak",
		"desi": "tech"
	}
}]

Even tried with bosun docker container .. it is giving 500 internal server error for same request.
I want to use bosun api to send the time series data from an application and want to use Elasticsearch as backend storage for bosun.
Please help me to configure it.
Thanks & regards,
Vinayak

You can only query ES in Bosun, to use /api/put you must configure OpenTSDB instance.

@dimamedvedev Hey, can you provide some more details on how to setup ES with Bosun please?

@21stio Basically you set ES-related config options in bosun.conf as described here http://bosun.org/configuration#backends and after that you can run functions in "Expression"as described here http://bosun.org/expressions#logstash-query-functions-deprecated or here http://bosun.org/expressions#elastic-query-functions depending on what ES version you use.


codon: 0.15.5 -> 0.16.1

Description of changes
https://github.com/exaloop/codon/releases/tag/v0.16.1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

On macos 10.15 I got:
error: hash mismatch in fixed-output derivation '/nix/store/54vpprgbsig2g0qmmc0h4hnbn5qa5ljk-codon-deps-0.16.0.tar.gz.drv':
         specified: sha256-a1zGSpbMjfQBrcgW/aiIdKX8+uI3p/S9pgZjHe2HtWs=
            got:    sha256-KfemYV42xBAhsPbwTkzdc3GxCVHiWRbyUZORPWxx4vg=

@risicle Thanks! Turns out the dependencies are different on Darwin systems.
I tried it in a virtual machine, and now I'm getting
./result/bin/codon --version
dyld: Library not loaded: /nix/store/vq59agppci8ll3n7bfgyzkdx08gyhp0m-codon-0.16.0/lib/libcodonc.dylib
  Referenced from: /Users/paveloom/Playground/nixpkgs/./result/bin/codon
  Reason: image not found
Abort trap: 6

Seems like there is a misbehaved symbolic link created somewhere.

Aight, that's fixed now, too.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2322


Don't show empty row when no cluster driver.

Proposed changes
Don't show empty row when no provider is selected.
Types of changes

Bugfix (non-breaking change which fixes an issue)

Linked Issues

Further comments
From:

To:

Corresponding RFE https://github.com/rancher/rancher/issues/18264


Updates to the MindSET page

In the FAQ section "When and where is MindSET organized?" The time we convey in all other materials is nine am.
MindSET modules are organized three to four times a semester on Saturday morning from '9:00 am' to 12:00 pm on the University of Michigan's North Campus. Specific room numbers are conveyed to the schools at the beginning of each term.

In the last section "What if my child misses a Saturday session?" there is a typo:

"We understand that attending all the sessions may not 'be' possible for students."

I (rlneu) attached the new parking map in an email to Mike Hand

This is the link to the feedback form. https://docs.google.com/forms/d/13A7YEZduqq-kBQ6SDW7YvNRg-heWPqF85SwWq1EvSGo/viewform?usp=send_form

Turns out that the K-12 chairs can update the map directly. Click "update
mindset photos" from the mindset page:
https://tbp.engin.umich.edu/outreach/mindset/ and you'll be able to change
the parking photo.
Please attempt to verify that it works correctly.

I was able to change the photo.  Thanks for implementing the other changes.
On Mon, Jan 26, 2015 at 1:17 PM, mikehand<EMAIL_ADDRESS>wrote:

Closed #169 https://github.com/tbpmig/mig-website/issues/169 via 57509ca
https://github.com/tbpmig/mig-website/commit/57509ca83ccb55c529cbad75e7bf31d4b11997f9
.
—
Reply to this email directly or view it on GitHub
https://github.com/tbpmig/mig-website/issues/169#event-224812330.


getCurrentTime() fails as tracks are ending

I have a track whose duration is 6.81795, as logged using ws.getDuration(). I am also logging ws.getCurrentTime() on the timeupdate event.
The final log of ws.getCurrentTime() is 6.795971, which is incorrect. It ought to be 6.81795 because the track ended and this was the final time. When a track finishes, calls to getCurrentTime() should not be misleadingly reporting any time that is not the final time.
Note, although the call to getCurrentTime() is accurate in the finish event, the last call to getCurrentTime in the timeupdate event still ought to equal the song duration because, when a track finishes playing, that is a time update.

I think this is something to blame the HTMLMediaElement for. We could add a workaround by artificially emit a final event with the exact value of the total duration, though.


add lora modem driver first version

add lora modem driver

support lorawan modem(lsd4wn-2l...) based on uart

需要解决下冲突


Feat/subband entropy

This pull request is created to merge the feat/subband_entopry branch with aim2.

Hi Amir,
Thanks for the submission of this new metric. I reviewed the code you have committed. Please, find my comments below:

Use Python type hints with variables and functions as much as possible to catch possible runtime bugs and to improve code readability. Especially in the m7_subband_entropy.py file. See https://docs.python.org/3/library/typing.html
Install and use pre-commit (see README.md) that will unify coding style automatically and check for possible errors.
Fix any errors reported by Mypy (see README.md)
Fix any warnings reported by Pytest (see README.md)
I am not familiar with the metric, but try to cover different edge cases with your tests. You can create and add new test images, if needed.
In addition to documenting the return type (use type hints) of m7, please also specify the range of return values. For example, Subband entropy (float, [0, +inf]) if correct.
What's the magic value of 0.008 in line 162 of m7_subband_entropy.py? Move it to private constants
Add documentation to all methods in image_visual_clutter_utils.py. Unify the format with image_utils.py.
I assigned m7 to the 'Perceptual Fluency' category. Is that correct?
Run Evaluator App (see README.md) to generated updated results.csv and quantiles.csv files. Copy results.csv to the /frontend/src/assets/ folder.
Fix all score data for m7 in metrics.json. You can get range values from quantiles.csv (see above).

Done.
Done.
Test files contain a warning due to "pyrtools". i opened an issue in their code.
Done.
I add black.png to test file.
Done.
Done.
Done.
Yes.
I ran evaluator just to see if it works fine. I generate the histogram and moving it to histograms path.
I have the rates, i will add them after checking with you and others.

Done.

Hi Amir, I updated dependencies, documentation, and evaluation results. See the commit changes above.

Could you fix or report this other pyrtools warning as well, which is shown when you run pytest ..

../../../../.local/share/virtualenvs/backend-idCl-4aN/lib/python3.7/site-packages/pyrtools/tools/display.py:10
/Users/mplaine/.local/share/virtualenvs/backend-idCl-4aN/lib/python3.7/site-packages/pyrtools/tools/display.py:10: UserWarning: Unable to import IPython.display.HTML, animshow must be called with as_html5=False
warnings.warn("Unable to import IPython.display.HTML, animshow must be called with "

Are the unit tests for the metric m7 comprehensive enough, at least for now?

The following error message is shown in the browser's console upon the execution of Subband entropy in dockerless mode. Any idea why this happens and how to fix it?

TypeError: Cannot read properties of undefined (reading '0')
at eval (RecordedResultsChart.js?2b68:36)

Docker fails to install the web app due to the following error (again related to pyrtools). Any idea why this happens and how to fix it?

#21 163.1     building 'pyrtools.pyramids.c.wrapConv' extension
#21 163.1     creating build/temp.linux-x86_64-3.8
#21 163.1     creating build/temp.linux-x86_64-3.8/pyrtools
#21 163.1     creating build/temp.linux-x86_64-3.8/pyrtools/pyramids
#21 163.1     creating build/temp.linux-x86_64-3.8/pyrtools/pyramids/c
#21 163.1     gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -I/usr/local/include/python3.8 -c pyrtools/pyramids/c/convolve.c -o build/temp.linux-x86_64-3.8/pyrtools/pyramids/c/convolve.o -fPIC -shared
#21 163.1     unable to execute 'gcc': No such file or directory
#21 163.1     error: command 'gcc' failed with exit status 1
#21 163.1     ----------------------------------------
#21 163.1 ERROR: Command errored out with exit status 1: /usr/local/bin/python -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-5makg467/pyrtools_535a13cc9b2848ddbd672bbbbc85f402/setup.py'"'"'; file='"'"'/tmp/pip-install-5makg467/pyrtools_535a13cc9b2848ddbd672bbbbc85f402/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(file) if os.path.exists(file) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' install --record /tmp/pip-record-xolk7y99/install-record.txt --single-version-externally-managed --compile --install-headers /usr/local/include/python3.8/pyrtools Check the logs for full command output.
failed to solve: rpc error: code = Unknown desc = executor failed running [/bin/sh -c export DEBIAN_FRONTEND=noninteractive   && apt-get update   && apt-get install -y --no-install-recommends wget unzip gnupg2   libglib2.0-0 libnss3 libgconf-2-4 libxcb1 libfontconfig1 xvfb   && useradd --system -s /sbin/nologin aim   && mkdir -p /home/aim   && wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add -   && echo "deb http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google-chrome.list   && apt-get update -qqy   && apt-get -qqy install ${CHROME_VERSION:-google-chrome-stable}   && rm /etc/apt/sources.list.d/google-chrome.list   && python -m pip install --no-cache-dir --upgrade pip   && pip install --no-cache-dir -r requirements.txt   && VERSION=$(wget -qO- https://chromedriver.storage.googleapis.com/LATEST_RELEASE)   && wget -q "https://chromedriver.storage.googleapis.com/${VERSION}/chromedriver_linux64.zip" -O driver.zip   && unzip driver.zip   && chmod +x chromedriver   && mkdir -p webdrivers   && mv chromedriver ./webdrivers/chromedriver_linux   && apt-get remove --purge -y --auto-remove unzip gnupg2   && apt-get clean   && chown -R aim .   && chown -R aim ../metrics.json   && chown -R aim /home/aim   && rm -rf driver.zip /etc/apt/sources.list.d/google-chrome.list /var/lib/apt/lists/* /var/cache/apt/*]: exit code: 1

I will check it. I think I know what I should do.
Yes, at least for now. Also, I checked all of 500  Alexa images with the original author's Matlab code and got the same result.
related to issue number 4?
it seems the "gcc" is not installed. according to the documentation  it needs gcc version >= 6 in order for the C code to compile.

I committed a fix. Thanks for the link!
That's great to hear! No need for further actions.
Unrelated. I will have a look at this today. It could be related to bad values, file formatting, or a bug in the code. In case of the latter, I will ask whether Valentin would have time to look at it as he has written that part of the code.
Thanks for the links. I will look at this today as well. I will contact Valentin (our Docker expert), if needed.

Fixed now

@vanntile Would you have time to look at issue #3 above? I get the following error when the execution of the 'Subband entropy' metric (m7) completes. results.json and metrics.json should both be fine so I am leaning towards a bug in RecordedResultsChart.js.
Here is the error message:
vue.esm.js?a026:628 [Vue warn]: Error in updated hook: "TypeError: Cannot read properties of undefined (reading '0')"

found in

---> <Results> at src/components/Results.vue
       <AIMForm> at src/components/AIMForm.vue
         <App> at src/App.vue
           <Root>
warn @ vue.esm.js?a026:628
logError @ vue.esm.js?a026:1902
globalHandleError @ vue.esm.js?a026:1897
handleError @ vue.esm.js?a026:1857
invokeWithErrorHandling @ vue.esm.js?a026:1880
callHook @ vue.esm.js?a026:4244
callUpdatedHooks @ vue.esm.js?a026:4376
flushSchedulerQueue @ vue.esm.js?a026:4361
eval @ vue.esm.js?a026:1998
flushCallbacks @ vue.esm.js?a026:1924
Promise.then (async)
timerFunc @ vue.esm.js?a026:1951
nextTick @ vue.esm.js?a026:2008
queueWatcher @ vue.esm.js?a026:4427
update @ vue.esm.js?a026:4569
notify @ vue.esm.js?a026:739
reactiveSetter @ vue.esm.js?a026:1064
pushResults @ index.js?58ae:101
wrappedMutationHandler @ vuex.esm.js?2f62:844
commitIterator @ vuex.esm.js?2f62:466
eval @ vuex.esm.js?2f62:465
_withCommit @ vuex.esm.js?2f62:624
commit @ vuex.esm.js?2f62:464
boundCommit @ vuex.esm.js?2f62:409
pushResults @ index.js?58ae:74
wrappedActionHandler @ vuex.esm.js?2f62:851
dispatch @ vuex.esm.js?2f62:516
boundDispatch @ vuex.esm.js?2f62:406
$socketClient.onMessage @ AIMForm.vue?2660:444
instance.onmessage @ VueSimpleWebSocket.module.js?83cf:1
vue.esm.js?a026:1906 TypeError: Cannot read properties of undefined (reading '0')
    at eval (RecordedResultsChart.js?2b68:36)
    at Array.forEach (<anonymous>)
    at fillData (RecordedResultsChart.js?2b68:26)
    at VueComponent.updated (Results.vue?82a0:171)
    at invokeWithErrorHandling (vue.esm.js?a026:1872)
    at callHook (vue.esm.js?a026:4244)
    at callUpdatedHooks (vue.esm.js?a026:4376)
    at flushSchedulerQueue (vue.esm.js?a026:4361)
    at Array.eval (vue.esm.js?a026:1998)
    at flushCallbacks (vue.esm.js?a026:1924)

Obviously, the histogram generation for m7 fails due to this issue.

@mplaine I have found the mistake, it's in the plot generation function, it seems to appear due to a configuration of the data I was not previously expecting and a bug in the code. Will update the plot generation formulas

Thanks for your help and quick fix, Valentin! Histograms work with all metrics now.
While testing the histograms with various inputs, I noticed two more minor issues related to them.

Your score is sometimes associated with a wrong bar. For example, the X-axis tick value on the left-hand side of the your score bar is sometimes lower than your score.
Your score bar is not drawn at all if it falls into the last bucket and is less than the last X-axis tick value. Related to the above, I assume.

I have attached two screenshots (inputs) and their associated metric (contour congestion) results to illustrate and reproduce the issues. airbnb.com for issue #1 and aalto.fi for issue #2.
test_files.zip
Let me know if need help in testing or further explanation of the issues.

For both of the above issues. The x-ticks are rounded (up as I recall) and the value of your result isn't, this being the source of the discrepancy. The plotting is in fact correct, it's just that if you want to round the x-ticks values, this might be the result. A fix for it is not obvious and would literally try to make it "wrong".
For the second issue. Again, I think the plot is correct, just that the last bar doesn't have any meaningful height as it only has our result (a small enough frequency to be invisible).

intl.format(...) rounds to the closest decimal (down or up). I unified the way how all values shown in histograms are rounded. IMO, values shown in the resulting histograms are now more logical. I tested this with several inputs.
@vanntile What's your opinion, and did I miss any lines that should be edited as well?

@mplaine Checked it myself. LGTM

Thanks for your help Amir and Valentin! The branch has been merged to 'aim2' and I deleted this feature branch.

Thank you both. @mplaine If you have time please take a look at feature congestion pull request. I remember we could not have both scalar and image output metrics together because of visualizationType in 'metrics.josn'. As a result, I just return the scalar one.


replace 'problems' key with 'exercises' in config.json

see #10

I forgot to point out that as of exercism/x-api#137, it is safe to remove problems.


Add tutorial

We should add a Basics: Dart tutorial on the protobuf homepage:
https://developers.google.com/protocol-buffers/docs/overview

Done


[BUG] Issue Title

Seid version
Show us output of seid version --long | head
Chain ID
Which chain are you running into issues with?
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Ok I would love to but for some reasons when I go to get my residency verification with every single peice of mail that clearly states I am eligible for verification I am turned away and asked to do it again. And I have many many times and I don't know what you are wanting from me exactly because I am following the instructions and required request and the information that provides the information that you have requested is from the Canadian government so if you kindly give me a explanation as to why I am unable to verify my residency?


Fix readme configuration-options anchor

Thanks for the great gem! Have been using this for a few years now.
Encountered this super minor thing here; an incorrect anchor to the configuration-options section.

Thanks a lot, @richardvenneman