Determine strategy for using string resources in presenters

  @Override final public void checkForMapbook() {

    mPath = mFileManager.fileExists();
    if (mPath != null){

      loadMapbook(new DataManagerCallbacks.MapbookCallback() {
        /**
         * If successfully loaded, populate view
         * @param mobileMapPackage - MobileMapPackage
         */
        @Override final public void onMapbookLoaded(final MobileMapPackage mobileMapPackage) {
          final List<ArcGISMap> maps = mobileMapPackage.getMaps();
          mView.setMaps(maps);
          final Item item = mobileMapPackage.getItem();
          mView.populateMapbookLayout(item);

          // Get the file size and date
          final long mapbookSize = mFileManager.getSize();
          final long mapbookModified = mFileManager.getModifiedDate();

          mView.setMapbookMetatdata(mapbookSize, mapbookModified, maps.size());

          final byte[] thumbnailData = item.getThumbnailData();
          if (thumbnailData != null && thumbnailData.length > 0) {
            mView.setThumbnailBitmap(thumbnailData);
          }else{
            final ListenableFuture<byte[]> futureThumbnail = item.fetchThumbnailAsync();
            futureThumbnail.addDoneListener(new Runnable() {
              @Override public void run() {
                try {
                  final byte[] itemThumbnailData = futureThumbnail.get();
                  mView.setThumbnailBitmap(itemThumbnailData);
                } catch (final Exception e) {
                  Log.e(TAG,e.getMessage());
                  mView.showMessage("There were problems obtaining thumbnail images for maps in mapbook.");
                }
              }
            });
          }
        }

        /**
         * If the mapbook fails to load, show a message
         * @param error - Throwable
         */
        @Override final public void onMapbookNotLoaded(final Throwable error) {
          Log.e(TAG, "Problem loading map book " + error.getMessage());
          mView.showMapbookNotFound();
          mView.showMessage("There was a problem loading the mapbook");
        }
      });

Was thinking the presenter can determine which string resource to provide and the view handles loading the resource. Have to think about this a bit more so we can handle this through a separate issue if we want to dig deeper.

See these links for inspiration on Context and MVP:
https://stackoverflow.com/questions/34303510/does-the-presenter-having-knowledge-of-the-activity-context-a-bad-idea-in-the?noredirect=1&lq=1
https://stackoverflow.com/questions/39100105/need-context-in-model-in-mvp


Add graphs to detail page

Phil suggests d3.

Had a ton of issues using D3. I settled with Chartjs. Chartjs uses canvas while D3 uses SVG (by default?).
Here is a screenshot.

I've used Chart.js before. I think we should invest more time in trying to figure out D3.

I can take a whack at it if you'd like.

I couldn't figure out how to scale the svg. If you can get it to fill 100% width while keeping the height at 300px, d3 would be great.

Commit what you have so far and I'll take a look on the morning.

This is probably useless for any d3 effort, but here you go. I don't have the d3 code but I was able to get it (barely) working using rd3.


Rename Stretch, Style, Weight to have Font prefix

This brings them into line with how they're used in parley::style as well as closer to how they're named in CSS where these properties are font-stretch (since renamed to font-width), font-style, and font-weight.
This is a precursor to extracting this code into a separate crate for styling text.

I'm sort of mixed on this, but:

If we extract these to a separate crate (#209), then we'll have to agree on a common name for them.
We already have 2 names for them within these 2 crates and it gets annoying.
Masonry does a re-export of parley::fontique::Weight as TextWeight, but then goes on to use TextWeight, FontWeight (from parley::style) in doc comments, and also Weight, all in the same code.

So it would be nice to have a single name for these.
In this PR, I chose Font* because of the mapping to what the CSS Fonts specifications use.

https://github.com/linebender/xilem/pull/778 shows why having a single name in Parley and Fontique will be good (and why that name should be FontWeight and not Weight).

Sgtm. I think we should generally try to mirror CSS naming moving forward.

In a subsequent PR, I will suggest renaming FontStretch to FontWidth and see how we all feel about that.


Automated cherry pick of #9138: fix(monitor): modify influxdbSuggestDriver query err

Cherry pick of #9138 on release/3.5.
#9138: fix(monitor): modify influxdbSuggestDriver query err

Codecov Report

Merging #9167 (2718630) into release/3.5 (6a15e02) will increase coverage by 11.90%.
The diff coverage is 3.77%.

@@               Coverage Diff                @@
##           release/3.5    #9167       +/-   ##
================================================
+ Coverage         5.98%   17.88%   +11.90%
================================================
  Files              796       85      -711
  Lines           125693     8911   -116782
================================================
- Hits              7522     1594     -5928
+ Misses          117504     7147   -110357
+ Partials           667      170      -497

Flag
Coverage Δ

aFlag
17.88% <3.77%> (+11.90%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../monitor/alerting/conditions/suggestrulereducer.go
0.00% <0.00%> (ø)

pkg/monitor/alerting/conditions/suggestquery.go
2.00% <2.00%> (ø)

pkg/util/seclib2/seclib.go
86.04% <100.00%> (ø)

pkg/hostman/system_service/system_service.go

pkg/baremetal/tasks/basedeploy.go

pkg/keystone/models/roleresource.go

pkg/cloudcommon/db/quotas/context.go

pkg/cloudprovider/snapshot_policy.go

pkg/compute/models/guestjoints.go

pkg/mcclient/options/k8s/service.go

... and 668 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa2105...2718630. Read the comment docs.

/lgtm
/approve


A remaining IntCounter

This was left behind in #2928 because it was changed after the PR was proposed.

@overvenus PTAL

/run-integration-tests

@breeswish
You need to do the benchmark after introducing Int Metric.

@siddontang yup. i'm going to test these PRs together: Use IntCounter, Add metrics to FuturePool, Reduce Worker lock contention.


Enums in error responses lead to invalid code

When returning enums from an error like this
{
  "openapi": "3.0.1",
  "info": {
    "title": "N/A",
    "version": "0.0.0"
  },
  "paths": {
    "/health/live": {
      "get": {
        "tags": [
          "Health"
        ],
        "operationId": "GetLiveHealthStatus",
        "responses": {
          "200": {
            "description": "Success",
            "content": {
              "text/plain": {
                "schema": {
                  "$ref": "#/components/schemas/HealthStatus"
                }
              }
            }
          },
          "503": {
            "description": "Server Error",
            "content": {
              "text/plain": {
                "schema": {
                  "$ref": "#/components/schemas/HealthStatus"
                }
              }
            }
          }
        }
      }
    }
  },
  "components": {
    "schemas": {
      "HealthStatus": {
        "enum": [
          "Unhealthy",
          "Degraded",
          "Healthy"
        ],
        "type": "string"
      }
    }
  }
}

it generates invalid C# (at least, haven't tried with the other languages)
#if NETSTANDARD2_1_OR_GREATER || NETCOREAPP3_1_OR_GREATER
#nullable enable
        public async Task<HealthStatus?> GetAsync(Action<LiveRequestBuilderGetRequestConfiguration>? requestConfiguration = default, CancellationToken cancellationToken = default) {
#nullable restore
#else
        public async Task<HealthStatus?> GetAsync(Action<LiveRequestBuilderGetRequestConfiguration> requestConfiguration = default, CancellationToken cancellationToken = default) {
#endif
            var requestInfo = ToGetRequestInformation(requestConfiguration);
            var errorMapping = new Dictionary<string, ParsableFactory<IParsable>> {
                {"503", HealthStatus?.CreateFromDiscriminatorValue},
            };
            return await RequestAdapter.SendPrimitiveAsync<HealthStatus?>(requestInfo, errorMapping, cancellationToken);
        }

the error given is 'HealthStatus' is a type, which is not valid in the given context. There is no CreateFromDiscriminatorValue to call.

Hi @nascosto
Thanks for your interest in Kiota and for reporting this.
This is currently a limitation. The error mapping was built with object types as error responses. It won't handle enum or scalar values since the error type needs to derive from exception/error so it can be thrown.
What could be done would be to project an additional type in those cases, with a "value" property which would map to the enum/scalar type.


Skip excess AppVeyor CI run if Pull Request opened from non default (master) branch.

See this PR for example https://github.com/AvaloniaUI/Avalonia/pull/948

Thanks! I didn't know this existed.

It's my pleasure. Travis also has an option to remove excess build (Build branch updates).
.
But after direct commits to master the build should be started manually.


Problem with whitespace css on top of AppWrapper, explanation why this is?

Hi,
I wanted to ask why it is that you use padding-top: 10px; in your AppWrapper component?
Because I saw the problem that when I disable these padding-top: 10px; that there comes a huge whitespace on top visible, and I dont know why? Is here a reason or problem fore or what can we do? Because thanks to the padding-top: 10px; I cant put my logo fully against the top without the padding having there? :(
padding activated on homepage with AppWrapper

padding DEACTIVATED gives WHITESPACE on homepage with AppWrapper

Thanks already for the help.
Filip

I can't find anything similar to padding-top: 10px in the entire project. Can you please provide the line number?

Hi,
Its in the file app/containers/App/index.js
The const AppWrapper = styled.div element has a padding of 0 16px. I changed the 16px to 10 px, sorry About That.
Sincerely,
Filip
On 28/03/2017, at 10:41 PM, Mihir Karandikar <notifications<EMAIL_ADDRESS>wrote:
I can't find anything similar to padding-top: 10px in the entire project. Can you please provide the line number?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/react-boilerplate/react-boilerplate/issues/1662#issuecomment-289717548, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQZB4Br7a1ZMSG414ez1nvyTodlUfzb1ks5rqNWzgaJpZM4Mpm7p.

Closing due to inactivity


requirement failed: The columns of A don't match the number of elements of x

Hello,
Following up on some gitter chat with @kevinykuo
Here is the issue. When I train my Naive Bayes model:
mymodel <- mydata%>% select(myday,headline, type) %>%
  filter(!is.na(headline)) %>%
  mutate(class = if_else(type == 'good', 1, 0)) %>%
  select(headline, class) %>%
  na.omit() %>%
  ft_regex_tokenizer(input.col='headline',
                     output.col = 'mytoken',
                     pattern = "\\s+",
                     gaps =TRUE,
                     min_token_length = 3) %>%
  ft_count_vectorizer(input_col = 'mytoken', output_col = 'final') %>%
  ml_naive_bayes( label_col = "class",
                  features_col = "final",
                  prediction_col = "pcol",
                  probability_col = "prcol",
                  raw_prediction_col = "rpcol",
                  model_type = "multinomial",
                  smoothing = 1,
                  thresholds = c(1, 1))

which works.

> mymodel
NaiveBayesModel (Transformer)
<naive_bayes_123456789>
 (Parameters -- Column Names)
  features_col: final
  label_col: class
  prediction_col: pcol
  probability_col: prcol
  raw_prediction_col: rpcol
 (Transformer Info)
  num_classes:  int 2
  num_features:  int 21413

Then I test with the same dataset
df_process <- mydata%>% select(myday,headline, type) %>%
  filter(!is.na(headline)) %>%
  mutate(class = if_else(type == 'good', 1, 0)) %>%
  select(headline, class) %>%
  na.omit() %>%
  ft_regex_tokenizer(input.col='headline',
                     output.col = 'mytoken',
                     pattern = "\\s+",
                     gaps =TRUE,
                     min_token_length = 3) %>%
  ft_count_vectorizer(input_col = 'mytoken', output_col = 'final')

ml_transform(x = mymodel, df_process)

works perfectly et the prediction column pcol is there and makes sense.
Now I load another dataset, that contains different textual data that can be formatted in the same way. The difference is that the headlines look-like-this-so-I-use-regex-to-parse-them (and sometimes I can have something like sparklyr-is-good sparklyr-is-there (two matches), so I need to explode the matching list)
other_df <- df_new  %>% filter(!is.na(u)) %>%
  select(u) %>%
  head(5) %>% ft_regex_tokenizer(input.col='u',
                                              output.col = 'myoutput',
                                              pattern = "([a-z]+-)+[a-z]*",
                                              gaps =FALSE,
                                              min_token_length = 3) %>%
  mutate(myword = explode(myoutput)) %>%
  filter(!is.na(myword)) %>%
  ft_regex_tokenizer(input.col='myword',
                     output.col = 'mytoken',
                     pattern = "-",
                     gaps =TRUE,
                     min_token_length = 3) %>%
  ft_count_vectorizer(input_col = 'mytoken', output_col = 'final') %>%
  mutate(class = 1) %>%
  select(final, u, mytoken, class) %>%
  na.omit()

but now
ml_predict(x = mymodel, other_df)
gives

Error: org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 313.0 failed 4 times, most recent failure: Lost task 0.3 in stage 313.0 (TID 12345, 123, executor 5): org.apache.spark.SparkException: Failed to execute user defined function($anonfun$1: (vector) => vector)

and

Caused by: java.lang.IllegalArgumentException: requirement failed: The columns of A don't match the number of elements of x. A: 21413, x: 21

I am lost here... Any ideas? Thanks!!

sorry typo, its mymodel. let me fix that

CountVectorizer is an Estimator, so you need to get a CountVectorizerModel from training on the big dataset, and use the same model on the test dataset. Most straightforward way to do this is via pipelines, i.e. put the tokenizer, count vectorizer, and the naive bayes in one pipeline, train that, then use the resulting PipelineModel to transform the new dataset.

I see, but the two datasets cannot be pre-processed in the same way as you see above. therefore including the processing of the train dataset in the pipeline will not work when applied to the new data. does that make sense?

Oh I see that your tokenizer must be different. So instead of using that, you'd use the appropriate tokenizer along with the already-trained count vectorizer and naive bayes models.

first of all, thanks for taking the time to helping me out here. I am not sure I understand your solution. Could you perhaps use the names above to show me what you mean? I should create a pipeline just with the naivebayesmodel? then what is the difference wrt what I did already?!

You're not creating any pipelines, you're executing each transformation eagerly. I'd follow the solution at https://stackoverflow.com/questions/50534224/how-to-train-a-ml-model-in-sparklyr-and-predict-new-values-on-another-dataframe/50571170#50571170.
Once you have model, you can pull out the count vectorizer and naive bayes stages via ml_stages(model, c("count_vectorizer", "naive_bayes")) (assuming you use the default UIDs), then use that to transform the new data after it's been tokenized appropriately.

More concretely, something like the following
training_data <- mydata %>%
  select(myday,headline, type) %>%
  filter(!is.na(headline)) %>%
  mutate(class = if_else(type == 'good', 1, 0)) %>%
  select(headline, class) %>%
  na.omit()

pipeline <- ml_pipeline(sc) %>%
  ft_regex_tokenizer(input.col='headline',
                     output.col = 'mytoken',
                     pattern = "\\s+",
                     gaps =TRUE,
                     min_token_length = 3) %>%
  ft_count_vectorizer(input_col = 'mytoken', output_col = 'final') %>%
  ml_naive_bayes( label_col = "class",
                  features_col = "final",
                  prediction_col = "pcol",
                  probability_col = "prcol",
                  raw_prediction_col = "rpcol",
                  model_type = "multinomial",
                  smoothing = 1,
                  thresholds = c(1, 1))

model <- ml_fit(pipeline, training_data)

new_data <- df_new  %>% filter(!is.na(u)) %>%
  select(u) %>%
  head(5) %>% ft_regex_tokenizer(input.col='u',
                                 output.col = 'myoutput',
                                 pattern = "([a-z]+-)+[a-z]*",
                                 gaps =FALSE,
                                 min_token_length = 3) %>%
  mutate(myword = explode(myoutput)) %>%
  filter(!is.na(myword)) %>%
  ft_regex_tokenizer(input.col='myword',
                     output.col = 'mytoken',
                     pattern = "-",
                     gaps =TRUE,
                     min_token_length = 3)

ml_stages(model, c("count_vectorizer", "naive_bayes")) %>%
  ml_transform(new_data)
)

yes, it works! the naive bayes returns some garbage predictions, but this is another story :) thanks!

Hello @kevinykuo just a quick performance issue if you have 2 min.
When I try the code above with naive_bayes, running model <- ml_fit(pipeline, training_data) takes about 5 minutes (I have approx 100 million rows).
If I replace ml_naive_bayes() with ml_decision_tree_classifier(), processing fails miserably after more than an hour of processing. I am trying a few options such as max_memory_in_mb and cache_node_ids but the discrepancy in performance is really striking.
Is this expected? Dictionary is about 200k words

Yes, there are performance differences between different ML algorithms implemented in Spark. I'm going to close this one since the original issue was resolved, but you are welcome to open a new one for perf related to ml_decision_tree_classifier(). That said, you might be better of asking that one in Stack Overflow since is something persisting across Spark, not sparklyr in particular.


[Bug] VS Code git highlight modified lines Loss

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: Version: 1.80.1 (Universal)
OS Version: Darwin x64 21.6.0

Descriptions:
I have enabled Git tracking settings in VSCode, which means that next to my line numbers, there will be highlights showing the changes I made in the local version. However, a peculiar situation has arisen within the same project directory. While some files are being accurately tracked and highlighted, others are not displaying the highlighting anymore. For instance, both main.py and Monster/app/app.py have a "M" next to their filenames on the left side, indicating modifications. While main.py is correctly displaying the changes I made, the same cannot be said for Monster/app/app.py. I have verified that the source control panel does show the differences for both files, but the line-by-line highlights next to the line numbers in Monster/app/app.py are not appearing as expected!
Steps to Reproduce:

git clone git@github.com:1chooo/evolving-beasts.git
modify app.py, Monster/app/app.py
It happens!

Screenshots

main.py(work!)
Monster/app/app.py(not work!)
Monster/app/app.py(in source control)

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.81.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

Hey @lszomoru I have recorded the problem.
https://github.com/microsoft/vscode/assets/94162591/e099f094-f732-436a-905f-e32f7746ce70

Hey @lszomoru, this issue might need further attention.
@1chooo, you can help us out by closing this issue if the problem no longer exists, or adding more information.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


[ISSUE-183] - ListPipelinesResponse is missing prev_page_token field

Added prev_page_token field in ListPipelinesResponse class in order to handle list pipelines prev_page_token field.
See [https://github.com/databricks/databricks-sdk-java/issues/183] for more details.

Closed as ListPipelinesResponse class is generated.


Staging

Changes Unknown when pulling b4f3480ae97f04449c3ce39c9059538ecdfe2324 on staging into ** on master**.

Changes Unknown when pulling 9c2f99a00efe1ef5ed7f8a46c98f3bd467721bf2 on staging into ** on master**.

Changes Unknown when pulling 95a7feb5e6cc9ff9873b97dfbccc416f8d97f407 on staging into ** on master**.

Changes Unknown when pulling 95a7feb5e6cc9ff9873b97dfbccc416f8d97f407 on staging into ** on master**.

Changes Unknown when pulling 40a8692b465b599e651daedbab96923fe3017c1b on staging into ** on master**.

Changes Unknown when pulling 40a8692b465b599e651daedbab96923fe3017c1b on staging into ** on master**.

Changes Unknown when pulling 69c5bbbb11d1630b17ce0d9bc2b0ba6a1a7c9e8a on staging into ** on master**.

Changes Unknown when pulling e72ed68607933a6873de3d6958038d2f80d5e1b8 on staging into ** on master**.

Changes Unknown when pulling aee193b1bfc596972f3e74269e93350a19f6ad60 on staging into ** on master**.

Changes Unknown when pulling aee193b1bfc596972f3e74269e93350a19f6ad60 on staging into ** on master**.

Changes Unknown when pulling 14c4b97e11c8e41aefa93c2e2e548d71c3a6e822 on staging into ** on master**.

Changes Unknown when pulling 8e0659cce4d164d9e6c901c26f39f8a62cf97eb8 on staging into ** on master**.

Changes Unknown when pulling 8e0659cce4d164d9e6c901c26f39f8a62cf97eb8 on staging into ** on master**.

Changes Unknown when pulling 9193268b5cfa367f7a2b8556fa145b1e54e83c27 on staging into ** on master**.

Changes Unknown when pulling 87418d79ce944f15e2ed905bfcd1c60c8a29ffc3 on staging into ** on master**.

Changes Unknown when pulling e8fcd341bf1619582b67a17b51c5bebb18058e3d on staging into ** on master**.

Changes Unknown when pulling 4a53e1951f951145c34956ccde7e1e3ac2d5ecc2 on staging into ** on master**.

Changes Unknown when pulling 4a53e1951f951145c34956ccde7e1e3ac2d5ecc2 on staging into ** on master**.

Changes Unknown when pulling 0d4153d5d5e4d1d4f96f15b8d89e840c113e7289 on staging into ** on master**.

Changes Unknown when pulling d91e58aab67d08e5b30ea830365093acdba7e6bb on staging into ** on master**.

Changes Unknown when pulling d91e58aab67d08e5b30ea830365093acdba7e6bb on staging into ** on master**.

Changes Unknown when pulling a4f070e331954433ae5cf0215fbc22fa7ba34d6c on staging into ** on master**.

Changes Unknown when pulling a4f070e331954433ae5cf0215fbc22fa7ba34d6c on staging into ** on master**.

Changes Unknown when pulling 871b2f298666c2e00c71a84cc427ce1b419be398 on staging into ** on master**.

Changes Unknown when pulling 468a0046ab15f7df91589837c982cde6f74bf5f1 on staging into ** on master**.

Changes Unknown when pulling 468a0046ab15f7df91589837c982cde6f74bf5f1 on staging into ** on master**.

Changes Unknown when pulling 6db789068914e27530c7d140d176ef9506389f37 on staging into ** on master**.

Changes Unknown when pulling 6db789068914e27530c7d140d176ef9506389f37 on staging into ** on master**.

Changes Unknown when pulling fb61383e9180da529774fe283fa6bfa25cf490be on staging into ** on master**.

Changes Unknown when pulling 6594a709b102c2519e23a209001e37009a6e36fa on staging into ** on master**.

Changes Unknown when pulling d7b0c0e58fe1b04a750c6c34cfa03255f3de2051 on staging into ** on master**.

Changes Unknown when pulling 064a6db28d0c4da5ca70ea94507f8c28bb3765e3 on staging into ** on master**.

Changes Unknown when pulling bce54dff0c377d8d6d700a68180aefcc3ca7e76a on staging into ** on master**.

Changes Unknown when pulling bce54dff0c377d8d6d700a68180aefcc3ca7e76a on staging into ** on master**.

Changes Unknown when pulling 23417f91281164990bb5faf86640491b02ae2398 on staging into ** on master**.

Changes Unknown when pulling 23417f91281164990bb5faf86640491b02ae2398 on staging into ** on master**.

Changes Unknown when pulling 79440d2980b2460805128e2dcad65006da11e0b7 on staging into ** on master**.

Changes Unknown when pulling 79440d2980b2460805128e2dcad65006da11e0b7 on staging into ** on master**.


Hey @fredmararac,

Mauricio,
I have the same problem as you had. Could you add more details how to fix it. I don't know how and where to create a custom filter.
Regards,
Martin
Hey @fredmararac,
Yes, we did. The only issue we had was with the return Url and we created a custom filter to access it and put it back. Maybe the new versions work out of the box, I haven' tried. But if they don't let me know and I can share our fix with you.
Regards,
Originally posted by @MauricioArroyo in https://github.com/IdentityServer/IdentityServer4/issues/3186#issuecomment-544155208

Hey @mpospisil  that was sometime ago but I can share with you what we did, it's quite simple.
We created an ActionFilterAttribute where we ensure the right returnUrl.
Something in the lines of
            if (context.ActionArguments.ContainsKey("ReturnUrl"))
            {
                context.ActionArguments["ReturnUrl"] =
                    context.HttpContext.Request.QueryString.ToString().Replace("?ReturnUrl=", "");
            }

and then on the account controller methods, such as login, we setup this filter
 [HttpGet]
 [AllowAnonymous]
 [ServiceFilter(typeof(AwsUrlFilterAttribute))]
 public async Task<IActionResult> Login(string returnUrl)

I hope that helps, that was our workaround to make it work.

Hey @preqproaws . I have solved the issue. In the latest IdentityServer4 doesn't require any special filters but problem was in my configuration.


Root privileges are not enough

I have the exact same problem. I tried this and it only got me so far: node-gyp threw a make error (ELIFECYCLE).
5 warnings and 1 error generated.
make: *** [Release/obj.target/marker_index/src/native/marker-index-wrapper.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:188:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:254:12)
gyp ERR! System Darwin 17.7.0
gyp ERR! command "/usr/local/Cellar/node/11.6.0/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /usr/local/lib/node_modules/slap/node_modules/marker-index
gyp ERR! node -v v11.6.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/<redacted>/.npm/_logs/2019-03-25T09_34_50_118Z-debug.log

Same. Looks like this project isindeed dead.

Seed this issue, I have answered it, #414

Seed this issue, I have answered it, #414


Cannot read property '$isServer' of null

Should useSWRV work in an on click handler? I'm getting the following error
[Vue warn]: Error in v-on handler: "TypeError: Cannot read property '$isServer' of null"

found in

---> <Home> at src/views/Home.vue
       <App> at src/App.vue
         <Root>
vue.runtime.esm.js?2b0e:1888 TypeError: Cannot read property '$isServer' of null
    at useSWRV (use-swrv.js?7713:86)
    at onClick (Home.vue?76f2:16)
    at invokeWithErrorHandling (vue.runtime.esm.js?2b0e:1854)
    at HTMLButtonElement.invoker (vue.runtime.esm.js?2b0e:2179)
    at HTMLButtonElement.original._wrapper (vue.runtime.esm.js?2b0e:6917)

Here is a minimal reproduction:
<template>
	<div>
		<button @click="onClick">Click me</button>
	</div>
</template>

<script>
import useSWRV from 'swrv';

const fetcher = async (key) => {
	return key;
};

export default {
	setup() {
		const onClick = () => {
			const { data } = useSWRV('test', fetcher);
			console.log(data)
		};

		return {
			onClick,
		};
	},
};
</script>

useSWRV is a composition function, which is meant (by design of the vue composition api) to be invoked only in the setup() hook. So binding it in a click handler would result in errors.
One option you can do is bind to a ref for the useSWRV cache key (e.g. const hasClicked = ref(false)) so that it only fires when you click.
const hasClicked = ref(false)

const onClick = () => {
  hasClicked.value = true
};

const { data } = useSWRV(() => hasClicked.value && 'test', fetcher);

return {
  onClick,
};

Ah that makes sense. In my case, I was actually using it to verify inputs from the user. For example, they add a phone number to a list and I was kicking off swrv to get information about the number. The logic probably should have been in it's own component anyway so this will just force me to adhere to that philosophy :)


Added Random Name Generator

Added Random Name Generator.
Issue No = #328

@Priyanshi662 Please review this PR !!

@Priyanshi662 Please review this PR !


Add hotkey to put computer to sleep!

On windows 10, I could put the machine to sleep with a "simple":
[Win + x], [u], [s]
On windows 11, [Win + x] still brings up the system menu, but the [u] [s] doesn't work any more, so I have to navigate with my mouse. What a pain!
I would love a simple hot key to put the computer to sleep.
Even better if I can customize it :)

just noticed the Remap keys section. So close! does not let you remap a key combination. I'll have to use a function key for now

Ok, Get out.
Remap shortcuts is already there.
I must be blind
You guys are way ahead of me!

@jsormaz  did the remap keys or remap shortcuts works as expected? I map ctrl+alt+end to sleep key. but nothing happened when I pressed the combination keys.


@Api(hidden = true) does not hide controller operations

Using springfox-swagger2:2.8.0 and springfox-swagger-ui:2.8.0 (same issue with 2.9.0):
When I set the hidden=true property on the @Api annotation, the controller and all its endpoints are still appearing on swagger-ui
@RestController
@Api(tags="Accounts", hidden=true)
@RequestMapping(value="/v2/accounts")
public class AccountsController {

    @ApiOperation(value = "Get account")
    @GetMapping(value = "/{reference}")
    public Account getAccount(@PathVariable String reference) {
        ....
    }
}

If I specifically set the hidden property directly on the @ApiOperation, it works correctly. But sometimes I want to hide all the endpoints of a controller. For now, I need to add a hidden=true on all the @ApiOperation of the controller, and that can be boilerplate.
The hidden=true property on the @Api annotation was working on old versions of springfox, like the 2.3.0 I think, so it might be a regression.
Thanks !

After digging a bit it appears that it works if I put a @ApiIgnore on the controller.
But I don't know it is the intented way to do it because it is a Springfox specific annotation while @Api is a swagger annotation. Any guidance for doing this ?
Thanks :)

Thanks for reporting. Will add this to the list of features

better use @ApiIgnore in controller level.

Seems related to #1731, which was marked as closed. I can confirm as well the same functionality expectation is failing for us, but using @ApiIgnore alleviates the problem. If we can automate this functionality for @Api(hidden = true) -> @ApiIgnore, that would be extremely nice, but it's nice to know there's at least an alternative for now.

@ApiIgnore    very good

@ApiIgnore shows the entry of Controller. How to completely hide this?

@javaHelper you can add "/test/" to @RequestMapping of controller

@ApiIgnore shows the entry of Controller
@Deprecated
@RestController
@RequestMapping("/test/test-rest")
@Api(tags = "testRest", description = "test rest test rest", hidden = true)
@ApiIgnore
public class TestRest {
.....
}

@MVTalent What version are you using. This totally works, infact its used internally as well.

checked on versions 2.8.0 and 2.9.2

Not sure, it should work with 2.9.2

It does not work with 3.0.0.

I am not sure why this regression has been marked as closed ?

Hide controller or method?
Please use @ApiIgnore for that controller or method...
Thanks


Carla bounding box

I am trying to extract 3D bounding box and 2D bounding box using camera sensor or the lidar sensor. I am using Caral Version 0.9.3
It is obvious how to extract the bounding box using the old api from the previous issues . But I am wondering how to return the bounding box for each object in the scene after the huge modification in carla API.

I tried this code in the  automatic_control.py file to visulize the 3D bounding box
in the while True:
for vehicle in world.world.get_actors().filter('vehicle.*'):
    print(vehicle.bounding_box)
    # draw Box
    transform = vehicle.get_transform()
    bounding_box = vehicle.bounding_box
    bounding_box.location += transform.location
    world.world.debug.draw_box(bounding_box, transform.rotation)

But I found that there is huge lag in the box relative to the car

I found that this problem do not appear with static cars it only appears with moving ones. This another example from ROS with the same problem.

I tried to play with life_time=-1.0, persistent_lines=True in the function draw_box but unfortunately it did not help much. Still the bounding box is not in synch with the actual car

I would say the problem is that there is a lag of at least one frame from the moment you read the car position until you draw the box.
So things happen in this order

Simulator sends "world tick" with the current transform of every vehicle
In Python you calculate bounding box based on this transform and do a draw request
Simulator parses this request

But another tick may have happened just before parsing the request, thus the box will be drawn on the next frame. At this point there is no way of guaranteeing that. Once #1258 is fixed, you might have the chance of accomplish this, but still there is a very small window between send world and parse requests. Ideally this should be done with synchronous mode #1244.
On top of that there is another lag that can be affecting, if you send draw requests for each vehicle, it may happen that the simulator cannot parse all the request in a single frame (it has a limited amount of time each frame allocated for this). Thus you'll get a growing queue of requests adding some lag. This hopefully will be fixed with #784.
Good news is, that those three issues are planned to be implemented in the coming release by the end of February :grin:

Thank You @nsubiron for your detailed response.
I have another question, what is the reference point for the box that returns from carla (Carla.World, Vehicle, our the sensor)? and what is the units of the produced box is it in centimeters or meters?

We have been dealing a lot with this lately. Good results started to appear once used custom drawing of 3d boxes client-side (a lot of time went into dealing with tranformations):

It is still not perfect, you can see the the green box shifting a bit when driving on a curb. This gets worse with speed, despite using:

synchronous mode
setting sensor_tick to 0.1 (10fps) https://carla.readthedocs.io/en/latest/cameras_and_sensors/#sensorcamerargb
running server and client on the same machine
Funny enough, our bounding boxes are now getting a bit ahead of cars seen on the screen.

What would really help is to have synchronous sensor listen function as it gets really bad the more sensors you set. We tried to synchronize it but sometimes (with multiple 4K cameras and lidar) the listen function would continue to receive data for more than 30 seconds after the last world.tick() was sent.
Also, the world.debug.draw_box seems to have some delay on it's own... :)

I see...  actually I made a mistake in my previous comment. Even with #1258 fixed, all the commands you send have effect in the next frame. I think that's why there is always a delay in the debug box. Plus on top of that there is no batch command for debug messages, so you can have an extra lag by sending each box individually, and on top of that I'm not sure how debug draws are implemented in UE4 nor if they have any extra delay.
Drawing the boxes in the client-side is probably the best approach.
Also, if you are able to share the code please do, a lot of people in the community would be very thankful :)

What would really help is to have synchronous sensor listen function as it gets really bad the more sensors you set.

Rendering is done in a separate thread in Unreal Engine, and this thread can be up to two frames behind the main thread. After that, the buffer is passed to another thread that sends it to the client. This is good for performance because while we are rendering and sending the image the main thread is already calculating the next frame, we minimize the time any thread is idle, but of course with big images you can have a significant delay.
But that's the point of the synchronous mode, you can block the main thread until you receive the images. In the synchronous_mode.py example that we release, we use a Python queue to wait for the image, so we call client.tick() only after receiving the image. That worked for the example. But yeah, this is a pretty new feature, so please report if you find something not working as expected.

@Soolek  This is a very interesting implementation, great work!. Hope that this becomes a python tool in carla to be used in client side.

Oh, I wasn't aware of the synchronomous_mode.py - it contains a very crucial synchronisation example that we have been struggling with (i.e. how to match video frame with transformation data):
world.wait_for_tick().frame_count should be matched with what ends in sensor.listen() property .frame_number!
Thanks to this I will be able to synchronise buffers (bounding boxes on image), thank you!
Once we polish the client bounding boxes I promise to rewrite the code to manual_control.py as we are using a sandbox opencv-based client at the moment

Also, if you are able to share the code please do, a lot of people in the community would be very thankful :)

I have just created a pull request: https://github.com/carla-simulator/carla/pull/1383

The functionality was merged! Thanks @Soolek


Default input policy should depend on $BLOCK_INCOMING

I really don't like using the default input policy DROP as I like to be aware of the incoming packets. If we use DROP policy, these packets are not logged and we might miss information about potential attacks.

Let's do something like this instead: 64b68430ebaa8875325be3bddade104000ba14cd
Let me work on it for a while and then we can change the default policy. K?

No wait... it still doesn't work :/
From iptables man page:
       -P, --policy chain target
              Set  the  policy for the chain to the given target.  See the section TARGETS for the legal targets.  Only built-in (non-user-defined) chains can
              have policies, and neither built-in nor user-defined chains can be policy targets.


Replace traefik with nginx

https://github.com/rancher/k3s/issues/817

why not traefik or nginx?

I've been having good luck with Traefik 2, the CRDs are pretty nice - but I guess the nginx ingress may be easier to get started with due to its ubiquity.

Will these changes work in a mixed-architecture cluster?  It looks like there is a check for the architecture (of the cluster? of the master? or something else?) and if it is arm, the arm image will be explicitly referenced.
It’s unfortunate that the ngoni image is not yet a true multi-arch image.


[OSD] update node version to include 14.21.3

Description
As called here:
https://github.com/opensearch-project/opensearch-build/pull/3356
Add the node version called out in our nvm file.
Issues Resolved
n/a
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Waiting for: https://github.com/opensearch-project/opensearch-build/pull/3356


Replacing 'HTTP' by 'HTTPS' for securing links

Currently, when we access the modified pages with HTTP, it is
redirected to HTTPS automatically. So this commit aims to
replace HTTP to HTTPs for security.
Co-Authored-By: Nguyen Phuong An<EMAIL_ADDRESS>Signed-off-by: Kim Bao Long<EMAIL_ADDRESS>Which problem is this PR solving?

Replacing HTTP by HTTPS for deprecated links

Short description of the changes

Minor changes

I think I tried it before, but I had problems with the base image not having the proper CAs to trust the cert from some of the mirrored servers. In fact, it looks like a couple of the CI runs for this PR failed for similar reasons:
Executing: /tmp/tmp.odvUpQGwUE/gpg.1.sh --fetch-keys
https://dl.yarnpkg.com/debian/pubkey.gpg
gpgkeys: protocol `https' not supported
gpg: no handler for keyserver scheme `https'
gpg: WARNING: unable to fetch URI https://dl.yarnpkg.com/debian/pubkey.gpg: keyserver error

+1 to this idea in general.
I think I tried it before, but I had problems with the base image not having the proper CAs to trust the cert from some of the mirrored servers. In fact, it looks like a couple of the CI runs for this PR failed for similar reasons:
Executing: /tmp/tmp.odvUpQGwUE/gpg.1.sh --fetch-keys
https://dl.yarnpkg.com/debian/pubkey.gpg
gpgkeys: protocol `https' not supported
gpg: no handler for keyserver scheme `https'
gpg: WARNING: unable to fetch URI https://dl.yarnpkg.com/debian/pubkey.gpg: keyserver error

Thanks for your comment :) I will close this PR :D

Don't see my comment as a refusal to accept your PR! I'd really appreciate if you could move forward and figure out if there's a way to make the build use TLS for its remote connections.

Yep. I got it :D I will try to figure out it as your recommendation :D


HSEARCH-3601 Fix a few typos and quirks in the documentation

https://hibernate.atlassian.net//browse/HSEARCH-3601

Pull Request Test Coverage Report for Build 1

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.143%

Totals

Change from base Build 278:
0.0%

Covered Lines:
18408

Relevant Lines:
20650

💛  - Coveralls

Merged thanks!


disable resync with parse for app upgrade

disable resync with parse server for app appgrade.  app will subscribe to parse when my course view is refreshed

Got it :+1:

note: need some more testing after assessment task

The existing code looks harmless and we should do a pretty serious testing pass on notifications before releasing it. Closing.


Remove non-Apache2 license references

In https://github.com/enketo/enketo-xslt/blob/master/xsl/openrosa2html5form.xsl, it's stated that:

Enketo-xslt is free software: you can redistribute it and/or modify

it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or

However, https://github.com/enketo/enketo-xslt/blob/master/LICENSE suggests enketo-xslt is released under the Apache licence.
Which one's correct?

Ah, thanks for catching that! It should be Apache2 (like all enketo products). I will fix that.
Since you're looking into this, I would like to highlight this crucial library that Enketo uses: https://github.com/enketo/enketo-xpathjs. Unfortunately, I didn't write this (great) library and have no control over the license. There is no alternative either.

Thanks for the clarification!  I noticed the xpathjs license it's AGPL.  If it's a crucial library, does that mean that enketo-transformer is also AGPL'd?

I don't think so. It's not part of enketo-transformer. It's crucial for enketo-core (which is in everything). Since I don't include the code in the repo, I think I can license enketo-core differently, but I'm not 100% sure.


PowerToys text extract shows blurred screen when launching and does not work.

Microsoft PowerToys version
0.67.1
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
TextExtractor
Steps to reproduce
PowerToys Text Extractor shows blurred screen when launching PowerToys Text Extractor and does not work.

✔ Expected Behavior
PowerToys Text Extractor shows the screen and extract text from cropped area
❌ Actual Behavior
PowerPowerToys Text Extractor shows blurred screen when launching PowerToys Text Extractor and does not work.

Other Software
I have 3 screens attached all are blurred screen. all scaled at 100%
PowerToysReport_2023-02-09-14-39-32.zip
Windows 11 22H2 (OS Build 22621.1194).

Can you confirm this is still an issue with PowerToys v0.72?
/needinfo


practical range usage often causes unnecessary closure allocations.

john.loughran.colvin (@John-Colvin) reported this on 2021-07-28T16:06:01Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=22155
CC List

kinke

Description
void foo(int[] a, int b) @nogc {
        import std.algorithm.iteration : map;
        size_t i = 0;
        foreach (el; a.map!(x => x + b))
            a[i++] = el;
    }

onlineapp.d(1): Error: function `onlineapp.foo` is `@nogc` yet allocates closures with the GC
onlineapp.d(4):        onlineapp.foo.__lambda4 closes over variable b at onlineapp.d(1)

or the more common case for us:

    a.map!(x => a + b).array;

which ends up allocating an unnecessary extra closure, even if `a.length` is 0.

It is not clear to me exactly how this could be fixed even conceptually, but it is worth documenting as a real problem.

I want to use the GC freely, but I also want to be in control. Random closures that you can't spot easily cause a lot of problems. Using `@nogc` is way too restrictive for these use cases, e.g. you might be totally fine with GC allocation *inside* the lambda, you just don't want to do another one to capture. Every allocation is individually expensive, often dwarfing the rest of the code in the function.

kinke commented on 2021-07-29T05:12:42Z
LDC optimizes it away with -O for the 2 given testcases (via the GC2Stack IR pass) - conceptually, it can prove that the closure doesn't escape after inlining *everything*, and moves it back to the stack.


TextField being covered by inputAccessoryView

Hi,
when a textfield is added to the alert view and it becomes the first responder, the keyboard appears.
When moving alert view up, you're not taking into consideration if the textfield has an inputAccessoryView. You should move the alert view adding also the height of this view.
Davide

Hi @CivicFan, good catch. I'll look into this.


gapps upload fails if .html and .js/.gs files collide on either side

First, Apps Script appears to not allow two files differing only in .gs and .html extensions. The Apps Script UI itself handles this really poorly: if you attempt to create a Foo.html, and you already have a Foo.gs, the request to have Foo.html created will silently fail, with no error messages.
gapps upload also fails if you try to upload both a Foo.js and Foo.html; I'm okay lumping this in with all the other "gapps will fail if you do anything unusual" cases that exist. However, if you attempt to upload only a Foo.html file (no Foo.js), but Foo.gs exists in Drive/server side, the request will fail.
Does gapps upload remove files prior to attempting to add news ones? (Is this even how this operation works? Looking at the docs, it wasn't particularly clear if it was.) If not, this could avoid erroring out despite the state that we want to sync being completely valid.
(Also, is it possible to get gapps upload to output any sort of error message about why it fails?)

@thanatos
The native editor also fails when you add same file names. Without errors.
As far as I know, Drive API for Script Files usually returns not 200OK while an error.

I think we could create some more checks and little by little start adding more advanced ones. From what I can tell the upload command knows little about the reasons of why it the fails but by adding those kinds of pre-checks we could pinpoint it a little better. Or maybe to not delay the push, run then only after the fail if they take too long. What do you guys think?


Remove all window.data

remove all window.data, window.semester, window.terms
remove the use of ["val"]

conflicts resolved.


[FLINK-16411][Azure] Use Maven cache in the same data center

What is the purpose of the change
It is a known problem (https://github.com/microsoft/azure-pipelines-tasks/issues/11864) that the Caching task in AZP is slow.
This PR is introducing a check if the mirror in the datacenter is reachable. If so, we'll use it, instead of Google's mirror.
Verifying this change
I've triggered this also to a private AZP to validate the conditions: https://dev.azure.com/georgeryan1322/Flink/_build/results?buildId=298&view=results

Thanks for the review. Merging


chore(release): v0.4.0

:robot: I have created a release beep boop
0.4.0 (2023-06-21)
Features

split upload page from search page. (a6c9af2)

Bug Fixes

downgrade typescript for build error. (e7197f1)
gh-46 search input error toast. (f383bbc)
instance key updatedAt display. (833b7f6)
website logo icon. (f90a200)

Performance Improvements

gh-42 updated queries refetch config. (47e1337)
header item responsive. (17db843)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/riccox/meilisearch-ui/releases/tag/v0.4.0 :sunflower:


click & open tracking for sent e-mails from free yahoo/hotmail mailboxes through SMTP relay

I'm looking to install postal soon in order to use it for the messages of my own domains. Great project!
I was also wondering if by chance it was possible to set up and use postal as SMTP relay in order to track click & open for messages sent from free e-mail providers such as yahoo or hotmail in a similar way as bananatag or saleshandy would allow me to do.
In the case of these two freemium services the tracking is possible but the need to pass them my mailbox credentials in order to let them authenticate and relay to yahoo/hotmail SMTP server with my account feels an extremely high price to pay to me, and for this privacy reasons I was looking for a self-hosted solution.
I tried to go through the postal documentation and search on the past issues here on github and it looks like that the webserver that listens to the connections for the tracking is by default on the same domain of the e-mail boxes (which is something that would not work with a free yahoo or hotmail address) and that SMTP relay with autenthication is not supported (at least until some time ago).
Could you guys confirm that what I would like to achieve is not possible?
Thank you again and keep up with the great work

Those services appear to allow you to send messages through their services via your usual email provider to apply their functionality.
Postal provides email sending and receiving services to other applications. With some customisations, you may be able create the setup you want however you would have to make some changes to how Postal functions to allow you to use the domains you can't add normally to Postal (like yahoo.com) and authenticate against their SMTP servers.
Theres no guarantee that any of this would work and it would make updating Postal difficult so if this functionality is what you need, you may be better off getting your own domain name to send emails from so you can use Postals tracking in the more standard ways.

Thank you for replying.
Yes, there are no problems for me in using postal with my own domains, I just wanted to try using it to also track (while keeping my data completely private) the e-mail that I send from some free personal e-mail boxes that I'm still using.
I'll try to experiment and see if I can dig a little bit through the code with a friend to see if customizing it for that purpose is doable.


build: snapshot testing circleci

Due to the fact that @angular/bazel introduced a breaking change in the snapshot builds that requires us to have multiple different versions of the Bazel TypeScript rules, I cannot easily to proceed with that PR.
The easiest solution would be to have a different WORKSPACE file that targets the Bazel build with the Angular snapshot output.


Add "mark as unread" feature

This PR fixes #273, but with another approach.
Overview
Now there's a "Mark as unread" button in "Notifications" area on pull request and issue pages.

When you mark that issue/PR as unread, extension remembers it and keeps it in storage until that same page is visited again. On notifications page, notifications remembered by the extension look and function exactly the same as "native" ones (first two notifications are created by the extension):

Implementation
Notifications are stored in localStorage under unreadNotifications key. Minimum enough info is stored to render a notification in /notifications page. When the unread page is visited again, entry with the same URL (notification.url === location.href) is removed from the storage, marking that page as "read".
When /notifications page is visited, notifications are fetched and rendered into the lists, categorized by repository. If that list doesn't exist, extension creates it too.
What works

Different icons depending on notification's target state (open/closed issue, open/merged/closed pull request).
Avatars of issue/PR's participants.
Relative timestamp (2 days ago).
Check icon, which marks that notification as read.
"Mark all as read" check icon.

What doesn't (TODO)

Mute icon, which unsubscribes from that thread.
"Mark all as read" button at the top right does not remove extension's notifications.
Rendering notifications when no "native" notifications are rendered previously (https://cloudup.com/c6Zho6w5QZt).
"Participating" tab.
Duplicated notifications in case when remembered thread gets updated.

Would love to hear all the feedback ;)

Mute icon, which unsubscribes from that thread.

Not important. Just remove the icon.

"Mark all as read" button at the top right does not remove extension's notifications.

I can live without this. I never use the "mark all as read" button.

Rendering notifications when no "native" notifications are rendered previously (https://cloudup.com/c6Zho6w5QZt).
"Participating" tab.
Duplicated notifications in case when remembered thread gets updated.

These would be nice to fix, but not essential.

Been using this for a couple of days now and it's working beautifully! :)

Bias aside, I :heart: it too, been waiting for this feature for years. Lack of this thing was making me delay reading threads, because I knew I would forget about them later.

As for TODO, perhaps we could merge this PR and create issues for those, so that people could pick them up?

As for TODO, perhaps we could merge this PR and create issues for those, so that people could pick them up?

That rarely happens though. So if we merge this now, we should be fine with those things never getting fixed.
Would be nice to at least fix:

Duplicated notifications in case when remembered thread gets updated.

I could see that being annoying.

Sure, agree ;)

Rendering notifications when no "native" notifications are rendered previously (https://cloudup.com/c6Zho6w5QZt).
"Participating" tab.
Duplicated notifications in case when remembered thread gets updated.

Fixed all of those. "Participating" tab now works as expected, notifications shown only if you participate in the thread.

This looks great to me, but I'll give @DrewML @hkdobrev @paulmolluzzo a couple of days to review.

@vdemedes nice work!
This is working as expected here no issues. I also appreciate the way the localstorage is being handled so it's not an ever-increasing pile of data. Thanks for that.
👍  LGTM

LGTM

Lack of this thing was making me delay reading threads, because I knew I would forget about them later.

BTW I alleviate this by using my email and keeping the email for the notification in my inbox. However it's not working for a notification where I'm not participating and I haven't received an email. However most things I want to look at and still want to keep for later like this PR are in my email.

Don't get me wrong, I would really use and love this feature a lot. Thank you for your work!

PR is ready to go!
@sindresorhus @paulmolluzzo @hkdobrev glad you like it!

Awesome! I've been using this for a while now and it's my favorite feature. Great work @vdemedes :)

@vdemedes Can you open an issue about what was not implemented in this pull request? In case someone wants to fix it.

@sindresorhus Thanks! Sure, I will open the issues.


Add check for sqlite3 version in setup.py

Add check for minimal supported sqlite3 version in setup.py.
It the version is too low, things mostly work except for a few DB queries that return wrong results which is pretty bad. cf. https://github.com/icubam/icubam/pull/278#issuecomment-614182505

Checked that this works as expected in https://github.com/icubam/icubam/pull/278 (cf CI log)

Very good catch!  I thought the sqlite version was intrinsically tied to the python version but it wasn't clear 100%, this makes things very explicit.  To be sure this is the version that support INSERT OR UPDATE? (UPSERT)?

To be sure this is the version that support INSERT OR UPDATE? (UPSERT)?

Yes, it is Sqlite 3.24 https://www.sqlite.org/lang_UPSERT.html


Isolate types

This may fix the transitive dependency @jsign mentioned.

There is one file where I'm not sure about how it will effect the transitive dependency situation for a program that imports the client package. It is test_utils.go in the client package. It contains this code:
package client

import (
	"context"
	"testing"

	"github.com/textileio/fil-tools/api/server"
	"github.com/textileio/fil-tools/tests"
	"google.golang.org/grpc"
)

This is mysterious to me because I don't know if a program that imports the client package actually imports the test files as well. If so, the imports of
"github.com/textileio/fil-tools/api/server"
"github.com/textileio/fil-tools/tests"

may branch out into all the extra dependencies we're trying to avoid.
Other than that, the client package now only imports the various simple types package and pb package included in each index/module package.

Did you try to make a simple project and import it now and see if it resulted?

There is one file where I'm not sure about how it will effect the transitive dependency situation for a program that imports the client package. It is test_utils.go in the client package. It contains this code:
package client

import (
	"context"
	"testing"

	"github.com/textileio/fil-tools/api/server"
	"github.com/textileio/fil-tools/tests"
	"google.golang.org/grpc"
)

This is mysterious to me because I don't know if a program that imports the client package actually imports the test files as well. If so, the imports of
"github.com/textileio/fil-tools/api/server"
"github.com/textileio/fil-tools/tests"

may branch out into all the extra dependencies we're trying to avoid.
Other than that, the client package now only imports the various simple types package and pb package included in each index/module package.

Test files in general should be on the form *_test.go so the compiler knows that shouldn't be included on main compilation. So, that should help.

I'm doing heavy work on the next PR and have some realization about something related to this.
Currently, the tests of the CLI assume that some things are already running in the host. (that's the reason these tests are the only ones flagged with the -short condition in go test).
Now, there are two options to fix that:
1- Spin them up in the test itself.
2- Spin them up in the test but without needing to run the code to do it.
Option 1 should be kind of discarded. If the server is instantiated in the test code itself, it will inevitably have the dependencies we don't want to have. If the tests have those dependencies, so will do the code of the client.
Option 2 sounds better and it's the way I'm testing things for the Fast API in my next PR. I'm spinning up dependencies by running a docker container. That would mean that we could run a server with docker, run the test, and then kill it. This way the code of the test (and thus CLI) never would have an import that we don't want (all is abstracted in the docker container).

On the other side, if deleting/commenting that test would avoid moving the client to a separate repo (considering the changes you've already made in this PR), I think it is worth it. So you may want to try that.

I did some extra research about the current behavior of Go Modules, and it doesn't matter if the import graph doesn't include other things. All dependencies of the Go Module that contains that subpackage will be considered in the project go.mod.
Someone is working in a proposal for Go Module dependency pruning to solve exactly this problem. If the import dependency graph doesn't include dependencies of the module, not force them in the module dependency graph. So, best-case scenario on 1.15 (so, to minor version ahead) will this work.
To be 100% sure that now won't work, I did an even simpler client, simple main.go:
package main

import "github.com/textileio/fil-tools/util"

func main() {
	_, err := util.TCPAddrFromMultiAddr(nil)
	if err != nil {
		panic(err)
	}
}

This simple client uses the util subpackage (textileio/fil-tools/util) which only imports:
import (
	"fmt"
	"time"

	ma "github.com/multiformats/go-multiaddr"
)

End result: annoying things in textileio/fil-tools go.mod are considered in this program. So, even if we make the work of cleaning the import graph of fil-tools/api/client, that still isn't enough.
Conclusion: for how things works now in Go, we should extract the client to another repo.
In fact, the nasty dependencies that we want to avoid for the client, are in fil-lotus for the same reason. We're interested in some subpackages of Lotus, but get all the deps bag for free.

Ok thanks for the research. Closing.


HOSTEDCP-972: Add pre-commit command to Make file

What this PR does / why we need it:
Adds the pre-commit command to the Make file to automatically update Golang and API dependencies, build the source code, build the e2e's, verify source code formatting, and run unit tests.
Which issue(s) this PR fixes:
Fixes HOSTEDCP-972
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.

/approve
/lgtm


Record user activity

Add a new database table that records the active users (with a granularity of once per minute).
Closes NCI-Agency/anet#3880
Closes AB#469
User changes

none

Super User changes

none

Admin changes

none

System admin changes

[ ] anet.yml or anet-dictionary.yml needs change
[x] db needs migration
[ ] documentation has changed
[ ] graphql schema has changed

Checklist

[x] Described the user behavior in PR body
[x] Referenced/updated all related issues
[x] commits follow a repo#issue: Title title format and these 7 rules
[x] commits have a clean history, otherwise PR may be squash-merged
[ ] Added and/or updated unit tests
[ ] Added and/or updated e2e tests
[x] Added and/or updated data migrations
[ ] Updated documentation
[x] Resolved all build errors and warnings
[ ] Opened debt issues for anything not resolved here

Obsoleted by #4074


Localhost and Pins Exception

Hello, thank you for such great library.
I'm currently implementing it for our app,
Basically, it works.
But,
We have in
network_sec_config.xml  - a localhost domain.
when running the app, the library throw exception :
    DomainValidator domainValidator = DomainValidator.getInstance(false);
    if (!domainValidator.isValid(hostname)) {
        throw new ConfigurationException("Tried to pin an invalid domain: " + hostname);
    }

@jobot0  Can you help please ?
I see that
DomainValidator domainValidator = DomainValidator.getInstance(false);
domainValidator is always inited with false, and thats why it fails in returning true
in returning allowLocal && hostnameRegex.isValid(domain)
because allowLocal is always false.
BTW, localhost sits inside  different [domain-config]
without  [pin-set] , and your library throws exception where no pins provided there.
I don't want pins there..
Thanks for the help...
Jazzy.

Hello,
Thanks for the report. Just to make sure we understand issue, can you post your full network_sec_config.xml ?

Sure, here it is :
<?xml version="1.0" encoding="utf-8"?>
<network-security-config>
    <base-config cleartextTrafficPermitted="false"/>
    <domain-config cleartextTrafficPermitted="true">
        <domain includeSubdomains="true">cloudfront.net</domain>
        <domain includeSubdomains="true">amazonaws.com</domain>
        <domain includeSubdomains="true">localhost</domain>
        <pin-set>
            <pin digest="SHA-256">XXX</pin>
            <pin digest="SHA-256">XXX</pin>
        </pin-set>
        <trustkit-config enforcePinning="false"/>
    </domain-config>

    <domain-config>
        <domain includeSubdomains="true">URL1</domain>
        <pin-set>
            <pin digest="SHA-256">XXX</pin>
            <pin digest="SHA-256">XXX</pin>
        </pin-set>
        <trustkit-config enforcePinning="true"/>
    </domain-config>

    <domain-config>
        <domain includeSubdomains="true">URL2</domain>
        <pin-set>
            <pin digest="SHA-256">XXX</pin>
            <pin digest="SHA-256">XXX</pin>
        </pin-set>
        <trustkit-config enforcePinning="true"/>
    </domain-config>

</network-security-config>

Thanks! We'll take a look.

Hey @nabla-c0d3
Did you had a chance to look into it ?
Thanks...

Hi @jazzyjester I'm checking into this issue. Sorry for the delay of our answer.

Hey @jobot0 , almost 2 months passed and we are waiting for this fix.
any news regarding this ticket ?


Add Datetime.timezone

This should be pretty much all of them. I've extracted them from https://timezonedb.com/time-zones.

@k4nar Thank you! Please, look at very small change request.

@k4nar What do you think about GMT offset. Can it be useful? I mean following:
>>> Datetime().gmt_offset()
'UTC +02:00'

I'll fix it by myself, thank you.

I'll fix it by myself, thank you.

Ok great, I was about to do it :) .

What do you think about GMT offset. Can it be useful?

I don't remember having this need before, but some might find it useful. However for a random timezone-aware datetime, I would advise to generate a datetime in UTC and switch to a random timezone with an appropriate library.


Add NOTE do use version 3.6 or above

Add NOTE do use version 3.6 or above

@khowling : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@khowling Thanks for your suggestion, I added a comment. Can you please update per the suggestions?

@GitHubber17 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@snehagunda - I updated the Note alert according to your feedback.
Is the submission ready for merge? Thank you

#sign-off

@SnehaGunda: I'm sorry - only the author of this article, @srchi, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@GitHubber17 can you please merge this PR?

Thank you!


Using "Condition" attribute for resource creation

Hi , I am trying to get a template to create an S3 bucket only if a condition is met. Here is my code snippet
cft.conditions.add(Condition(
		"CreateBucketEnabled",
		{"Fn::Equals" : [{"Ref" : "CreateS3Bucket"}, "True"]}
		)
)
cft.resources.add(Resource(
	'AppS3Bucket',
   'AWS::S3::Bucket',
	 properties =
   {
      "BucketName": join('-',ref('AWS::StackName'),'-app')
	 },
	c_ref('CreateBucketEnabled')

)
)

when I run cfn_py_generate i get the template.json file but I do not see the Condition attribute  in the json file. Am I missing something here ? Can you please help ?
"Resources": {
    "AppS3Bucket": {
      "Type": "AWS::S3::Bucket",
      "Properties": {
        "BucketName": {
          "Fn::Join": [
            "-",
            [
              {
                "Ref": "AWS::StackName"
              },
              "-app"
            ]
          ]
        }
      }
    },

This may be the same as #29. If so, try the workaround listed there and let me know if it unblocks you.
In the meantime, the release containing that fix is Coming Soon™.

Acting under the assumption that this is indeed a duplicate of #29, it was fixed in https://github.com/seandst/cfn-pyplates/commit/1266a9744fb40be743e822fb554539341e82c1d1 and will be in the next release.


Unexpected token {

Hi guys I've been running into this occasionally since setting my transpiler to babel. If I refresh it goes away and it's different files most of the time. I can go hours without seeing it or see it twice in two reloads. I'm not sure what the issue is.
system.src.js:122 Uncaught (in promise) Error: (SystemJS) https://localhost.catalystapps.com:8080/ui/app/pages/site/detail/macros/macros.js: Unexpected token (20:48)
	  18 | 	prevVals: null,
	  19 |
	> 20 | 	init: function(applyValues, saveDoc, onChange) {
	     | 	                                               ^
	  21 | 		mod.applyValues = applyValues
	  22 | 		mod.saveDoc = saveDoc
	  23 | 		mod.onChange = onChange

'*.js': {
    'loader': 'plugin-babel',
    'format': 'cjs',
    'babelOptions': {
        'modularRuntime': false
    }
}

Which version of plugin-babel are you using here? Have you tried updating to the latest?

I have<EMAIL_ADDRESS>

I will try updating now

I upgraded to 0.0.15 and just ran into the same issue. Again it's intermittent and very hard to reproduce. I wish I had better steps.

Here's a full stack
1474320648319
Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36

Error: (SystemJS) https://localhost.catalystapps.com:8080/ui/app/pages/site/detail/viewers/viewers.js: Unexpected token (15:20)
	  13 |
	  14 | 	kImporters: {
	> 15 | 		xhtml: function() {
	     | 		                  ^
	  16 | 			return SystemJS.import('./preview/preview.js', module.id)
	  17 | 		},
	  18 | 		pdfviewer: function() {
	SyntaxError: https://localhost.catalystapps.com:8080/ui/app/pages/site/detail/viewers/viewers.js: Unexpected token (15:20)
	  13 |
	  14 | 	kImporters: {
	> 15 | 		xhtml: function() {
	     | 		                  ^
	  16 | 			return SystemJS.import('./preview/preview.js', module.id)
	  17 | 		},
	  18 | 		pdfviewer: function() {
	    at c.h.raise (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:15:18733)
	    at c.i.unexpected (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:14:7064)
	    at c.i.expect (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:14:6938)
	    at c.m.parseBlock (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:14:16021)
	    at c.m.parseFunctionBody (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:15:15079)
	    at c.m.parseFunction (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:14:18390)
	    at c.m.parseFunctionExpression (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:15:8353)
	    at c.m.parseExprAtom (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:15:7613)
	    at c.m.parseExprSubscripts (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:15:3126)
	    at c.m.parseMaybeUnary (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:15:2744)
	    at c.m.parseExprOps (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:15:1321)
	    at c.m.parseMaybeConditional (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:15:902)
	    at c.m.parseMaybeAssign (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:15:186)
	    at c.m.parseObjPropValue (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:15:12928)
	    at c.m.parseObj (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:15:12348)
	    at c.m.parseExprAtom (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:15:7563)
	    at c.m.parseExprSubscripts (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:15:3126)
	    at c.m.parseMaybeUnary (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:15:2744)
	    at c.m.parseExprOps (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:15:1321)
	    at c.m.parseMaybeConditional (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:15:902)
	    at c.m.parseMaybeAssign (https://localhost.catalystapps.com:8080/ui/jspm_packages/npm/systemjs-plugin-babel@0.0.15/systemjs-babel-browser.js:15:186)
	Error loading https://localhost.catalystapps.com:8080/ui/app/pages/site/detail/viewers/viewers.js as "./viewers/viewers.js" from https://localhost.catalystapps.com:8080/ui/app/pages/site/detail/doc.js

+1. Happens on Google Chrome(Chrome/53.0.2785.116) , but never saw it on Safari/Firefox

If anyone can share a replication here that would be a great start.

It very hard to reproduce, but I believe it only happens on the Chrome version mentioned above. I checked in Canary and I am yet to see the error. I believe its a Chrome issue.

 Since it's random files and only happens sporadically there is nothing that points to a single specific issue here. Perhaps it is chrome as @spiritson suggests.

Without uncrossing my fingers Chrome 54 has yet to cause this error. I'm unsure what would be in the engine that would cause this.

@Medros , Good that you are not seeing this error in 54. Hopefully the issue is dead.  Technically no explanation though


Log akka configuration on start

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

I like this overall. I'm a bit concerned that it could expose secrets since the command line and environment variables are in the full config. Any thoughts @janisz

You're right it's not necessary and potentially dangerous. I saw config is printed in metronome and thought that could be useful for tuning akka configuration.

I think the right way to do this would be to load the config ourselves
(passing it to the actor system) and log it out with secret like things
masked out.
On Mon, Nov 21, 2016 at 4:36 PM janisz<EMAIL_ADDRESS>wrote:

You're right it's not necessary and potentially dangerous. I saw config is
printed in metronome and thought that could be useful for tuning akka
configuration.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mesosphere/marathon/pull/4667#issuecomment-262112477,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAweZpQerAsby8YDojQNv9UIS-eKX9chks5rAjj5gaJpZM4K3SZg
.


[HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers

Change Logs
Describe context and summary for this change. Highlight if any code was copied.
[HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Impact
Describe any public API or user-facing feature change or any performance impact.
none
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@yihua have a review plz


[release/7.0.1xx] installer fails to build using a sdk+packages built by installer

If you build installer using an SDK and packages from a previous installer build, the build fails.
runtime repo's crossgen2.csproj project fails to resolve the RuntimeIdentifier.
I've patched it in https://github.com/dotnet/installer/pull/14549 using:
-    <RuntimeIdentifiers Condition="'$(DotNetBuildFromSource)' == 'true'">$(PackageRID)</RuntimeIdentifiers>
+    <RuntimeIdentifier Condition="'$(DotNetBuildFromSource)' == 'true'">$(PackageRID)</RuntimeIdentifier>
+    <AppendRuntimeIdentifierToOutputPath Condition="'$(RunningPublish)' != 'true'">false</AppendRuntimeIdentifierToOutputPath>

The fsharp repo fails with:
    FSharp.Build -> /home/tmds/tarball61/src/fsharp/artifacts/source-build/self/src/artifacts/bin/FSharp.Build/Proto/netstandard2.0/FSharp.Build.dll
    FSharp.Compiler.Service -> /home/tmds/tarball61/src/fsharp/artifacts/source-build/self/src/artifacts/bin/FSharp.Compiler.Service/Proto/netstandard2.0/FSharp.Compiler.Service.dll
FSC : error : no entrypoint specified in executable binary [/home/tmds/tarball61/src/fsharp/artifacts/source-build/self/src/src/fsc/fscProject/fsc.fsproj::TargetFramework=net7.0] [/home/tmds/tarball61/Tools/source-built/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj]
##vso[task.logissue type=error;sourcepath=FSC;linenumber=0;columnnumber=0;code=;]no entrypoint specified in executable binary [/home/tmds/tarball61/src/fsharp/artifacts/source-build/self/src/src/fsc/fscProject/fsc.fsproj::TargetFramework=net7.0%5D
    fsc -> /home/tmds/tarball61/src/fsharp/artifacts/source-build/self/src/artifacts/bin/fsc/Proto/net7.0/fsc.dll
FSC : error : no entrypoint specified in executable binary [/home/tmds/tarball61/src/fsharp/artifacts/source-build/self/src/src/fsi/fsiProject/fsi.fsproj::TargetFramework=net7.0] [/home/tmds/tarball61/Tools/source-built/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj]
##vso[task.logissue type=error;sourcepath=FSC;linenumber=0;columnnumber=0;code=;]no entrypoint specified in executable binary [/home/tmds/tarball61/src/fsharp/artifacts/source-build/self/src/src/fsi/fsiProject/fsi.fsproj::TargetFramework=net7.0%5D
    fsi -> /home/tmds/tarball61/src/fsharp/artifacts/source-build/self/src/artifacts/bin/fsi/Proto/net7.0/fsi.dll

This was fixed with https://github.com/dotnet/fsharp/pull/13963 and fsharp also checked in a fix for it which has already flown into 7.0 with https://github.com/dotnet/installer/pull/14608


Fixed Coveralls config

coveralls isn't getting data currently, it was uploading a blank report.

don't merge this in yet, wait for coveralls to show some data


Thread Commissioning

Initial implementation of Thread Commissioning.
This is a work-in-progress and currently defaults to disabled.  Use the --enable-joiner and --enable-commissioner configure options to enable support for the respective commissioning roles.

I am trying to enable hardware entropy to run on CC2538. But seems that SRAM is not big enough to store .bss + .data section.
This is before including commissiong
arm-none-eabi-size arm-none-eabi-ot-cli
text	   data	    bss	    dec	    hex	filename
97832	   2180	  20296	 120308	  1d5f4	arm-none-eabi-ot-cli
This is after including commissioning
arm-none-eabi-size arm-none-eabi-ot-cli
text	   data	    bss	    dec	    hex	filename
159132	   2200	  37948	 199280	  30a70	arm-none-eabi-ot-cli
.bss + .data is larger than 32KB of CC2538's SRAM.
The extra 17KB is mainly caused by libmebdcrypto.
This is before including commissioning
176	      0	    805	    981	    3d5	libmbedcrypto_a-mbedcrypto.o (ex libmbedcrypto.a)
This is after including commissioning
228	      0	  16784	  17012	   4274	libmbedcrypto_a-mbedcrypto.o (ex libmbedcrypto.a)
We have uncommented many feature via modifying mbedtls-config.h.
Could we comment parts of them or optimize to make data fit to SRAM?

@luwannest, I just pushed a change that should reduce the mbedtls memory pool by about half.  Not sure if that is enough to allow for initial testing, but it's a start.

The stack would overflow while running to mbedtls_ctr_drbg_reseed while Dtls::Start.
So I add more 512 bytes for the stack in PR #502 .
Not sure do we need to need this now as work around or we will optimize further?

@luwannest, thanks for pointing out the stack depth issue.  Ideally we would determine what is causing the high stack utilization and attempt to optimize that out.  However, I understand we can optimize later.
I think this change is fine, but #502 should only be merged in once we've merged the Thread Commissioning support.

@jwhui , I did the following tests for the commissioning via capturing pcap to verify DTLS handshake, Joiner Handshake and Commissioner Petition Handshake.
1, Leader (Commissioner) < --- > Joiner
This is to verify DTLS handshake and Joiner Handshake.
2, Leader < --- > Router (Commissioner)
This is to verify Commissioner Petition and Keep Alive.
3, Router (Commissioner) < --- > Leader (Joiner Router) < --- > Joiner
This is to verify Joiner Router.
I encounter a problem is that JR is enabled by default to my under standing, so Router and Leader can both be JRs. It would be a little bit hard to control. The following scenario may happen Joiner talk with Commissioner directly, but not relayed by JR which is expected by 8.2.
Also another problem need to be enhanced is that CLI and PHY radio do not work very well during DTLS handshakes. There are a lot of retransmissions and no CLI response. Except for the usage of RAM.
And we also need to provide a way to configure different PSKd (8.1.2),
I think that this commit looks good to me, but needs improvements. I would prefer that it not enabled by default.

@luwannest, thanks for testing this.
For Test 8.2, does the Harness enforce a topology using the whitelist and/or blacklist feature?  The topology description in the test spec certainly has a specific topology in mind.
For the CLI being unresponsive, that is expected while the EC-JPAKE operations are going on.  This should not generally be an issue since the Joiner does not really need to do much while it is Joining.  Using low-power commissioner probably isn't the typical use case either.  However, we should be looking into the retransmission issue.  From looking at the trace, it looks like the EC-JPAKE operation is not done by the time the Commissioner responds.  Would be good to know how much time each EC-JPAKE step takes.
Setting the PSKd can easily be added.

Time taken of each step of EC-JPAKE on CC2538.
For Commissioner:
ClientHello: 7.3 sec
ServerHello: 7.1sec
ServerKeyExchange: 3.8 sec (above 3 steps takes largest time for one handshake around 18.1 sec, so I suggest change min timeout from 8 sec to 20 sec)
ClientKeyExchange: 7.4 sec
For Joiner:
ClientHello: 7.2sec
ServerKeyExchange:3.8sec
ClientKeyExchange: 7.4 sec
The pcap trace after changing min timeout to 20 sec.
commissioning-dtls-6thSep.tar.gz

@jwhui I have ran the 8.1.1 Harness commissioning test, some existing issues:

The harness gave the test pass, but actually it didn't verify the DTLS process as certification test plan specified, only checked the exists of discovery request and discovery response. I will report this issue to Thread Group's JIRA.

According to the test plan and specification, We may need to add the Steering Data TLV and Joiner UDP Port TLV in Discovery Response message sent by Commissioner, Joiner must use the specified Joiner Port as destination port for DTLS.

Sounds like this PR is in a testable state.  Any concerns with merging this now to speed further development on commissioning?

LGTM 👍


Added support for JSON deserialization of string timestamps

Fixes #1456

Beautiful PR! Thank you for this! 🙇


Allow for force unwrapping

What does this PR do?
There are cases when we need to unwrap far more than just what is done natively in Accelerate, such as when we have TPUs/SPMD.
This PR expands extract_model_from_parallel to support situations such as using XLA's FSDPv2.
Alternative to https://github.com/huggingface/transformers/pull/29780, which we can upstream to transformers by just using recursive=True
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc @shub-kris
We can't test it on TPUs since we don't have our runners, but @shub-kris tested this himself :)

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


tigergprah's impl  cannot run

Hello，Whether I try to run start.sh, set.sh, or load in one. sh, the following error message will appear：

Therefore, when I execute benchmark, the following issues will occur：

Hello @Ask-sola, unfortunately, I don't have an insight on why this happens. You may consult the TigerGraph implementation in the LDBC SNB BI repository for hints on how to set up a TG database:
https://github.com/ldbc/ldbc_snb_bi/tree/main/tigergraph


default scaling for low-count data

When loading MIBI data, the default scaling is always much too low. This is fairly low priority, but it would be nice if the guess for a cap value worked better for data with very low (1-20) counts per pixel.

I'm not sure what you mean by scaling in this context. Do you mean the default zoom, when large images are downsampled so they can fit in memory, the default brightness values, or something different?
If you mean the default brightness values, you can configure them to best suit your data by clicking on the preferences entry in the main menu.

Hi Rob, yes, the default brightness is just what I was referring to. What would be nice is if mantis attempted to auto-scale the brightness for each channel independently, for example by setting the scaling to the max value of that channel in the image.
It also appears that it saves the settings if you've loaded an image set before, and sets those as the default. This is an awesome feature!!

Awesome, I'm glad you like that it saves the settings from last time! If you're analyzing multiple image sets (a project) it will also copy any brightness adjustments you've made as you move from image set to image set.
Maybe I'm not understanding, but I think you can do what you just described in the preferences pane. If you go to the preferences pane, you can set the default min and max brightness as a percentage of channel's max value for each channel. So if you wanted no scaling for every channel, you can go through each channel and set the default brightness to 0% and 100%. Is that what you were thinking? If not, can you walk me through an example? Is there a heuristic that you're thinking would be useful for automatically picking how the brightness should be scaled?

Sure thing. Could you explain what type of scaling is being done on the main page when we adjust the brightness?
Also, you said that "If you go to the preferences pane, you can set the default min and max brightness as a percentage of channel's max value." But then you said that no scaling would be setting the max to 100% of the max value, which actually does sound like scaling to me?

Would be happy to explain! The brightness values on the sliders on the main page are taken from the selected marker and are the minimum and maximum pixel intensities for that marker.  When you adjust the brightness Mantis does a linear transformation.
In TypeScript we generate m and b for the linear transformation by doing the following:
let b = curChannelSelectedMin === 0 ? 0 : curChannelSelectedMin / channelMaxIntensity
let m = curChannelSelectedMax === 0 ? 0 : channelMaxIntensity / (curChannelSelectedMax - curChannelSelectedMin)

We then apply these values to the image using a WebGL Uniform that looks like this:
gl_FragColor = min((gl_FragColor * m) + b, 1.0);

We do min with 1.0 here because WebGL only displays values between 0 and 1. When the image is first loaded, the pixel intensities are scaled to the range of 0 and 1 for the purposes of display.
So if you set the brightness values for a channel to 0% and 100%, the only scaling that should be going in is scaling to the range of 0 to 1 so that we can display the image. A display value of 1 will only correspond to the maximum pixel intensity for the selected marker.

Got it, thanks! I didn't realize the data was already max-scaled 0-1. In
that case, the settings tab for % max intensity as a default would
definitely work for us.
I started playing around with it, and it appears that's its doing some
calculations as you change this value. It lags a bit, and can't slide more
than 10% per second; if I drag the slider faster than that, it lags out and
then overshoots.
Thanks,
Noah
On Wed, Feb 5, 2020 at 11:25 AM Robert Schiemann<EMAIL_ADDRESS>wrote:

Would be happy to explain! The brightness values on the sliders on the
main page are taken from the selected marker and are the minimum and
maximum pixel intensities for that marker. When you adjust the brightness
Mantis does a linear transformation.
In TypeScript we generate m and b for the linear transformation by doing
the following:
let b = curChannelSelectedMin === 0 ? 0 : curChannelSelectedMin / channelMaxIntensity
let m = curChannelSelectedMax === 0 ? 0 : channelMaxIntensity / (curChannelSelectedMax - curChannelSelectedMin)
We then apply these values to the image using a WebGL Uniform that looks
like this:
gl_FragColor = min((gl_FragColor * m) + b, 1.0);
We do min with 1.0 here because WebGL only displays values between 0 and

When the image is first loaded, the pixel intensities are scaled to the
range of 0 and 1 for the purposes of display.

So if you set the brightness values for a channel to 0% and 100%, the only
scaling that should be going in is scaling to the range of 0 to 1 so that
we can display the image. A display value of 1 will only correspond to the
maximum pixel intensity for the selected marker.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ParkerICI/mantis-viewer/issues/19?email_source=notifications&email_token=ADJB47JDBP2NR4AA6ODTFNDRBMHBTA5CNFSM4KP55ZTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK4VBOQ#issuecomment-582570170,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJB47PUXZY5CVL2EHSEIDTRBMHBTANCNFSM4KP55ZTA
.

Awesome, I'm glad that the settings for default brightness works for you!
Yeah, we're aware of that lag. I hadn't thought of it in a bit, so thanks
for the reminder! Those values get saved to a file on disk, and with the
way things are currently written that happens every time the value changes.
We have a ticket to fix that, but didn't get around to it for the 1.0
release. We should be getting to it for the 1.1, if not sooner!
Thanks again,
Rob
On Wed, Feb 5, 2020, 10:04 AM ngreenwald<EMAIL_ADDRESS>wrote:

Got it, thanks! I didn't realize the data was already max-scaled 0-1. In
that case, the settings tab for % max intensity as a default would
definitely work for us.
I started playing around with it, and it appears that's its doing some
calculations as you change this value. It lags a bit, and can't slide more
than 10% per second; if I drag the slider faster than that, it lags out and
then overshoots.
Thanks,
Noah
On Wed, Feb 5, 2020 at 11:25 AM Robert Schiemann<EMAIL_ADDRESS>
wrote:

Would be happy to explain! The brightness values on the sliders on the
main page are taken from the selected marker and are the minimum and
maximum pixel intensities for that marker. When you adjust the brightness
Mantis does a linear transformation.
In TypeScript we generate m and b for the linear transformation by doing
the following:
let b = curChannelSelectedMin === 0 ? 0 : curChannelSelectedMin /
channelMaxIntensity
let m = curChannelSelectedMax === 0 ? 0 : channelMaxIntensity /
(curChannelSelectedMax - curChannelSelectedMin)
We then apply these values to the image using a WebGL Uniform that looks
like this:
gl_FragColor = min((gl_FragColor * m) + b, 1.0);
We do min with 1.0 here because WebGL only displays values between 0 and

When the image is first loaded, the pixel intensities are scaled to
the
range of 0 and 1 for the purposes of display.

So if you set the brightness values for a channel to 0% and 100%, the
only
scaling that should be going in is scaling to the range of 0 to 1 so that
we can display the image. A display value of 1 will only correspond to
the
maximum pixel intensity for the selected marker.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/ParkerICI/mantis-viewer/issues/19?email_source=notifications&email_token=ADJB47JDBP2NR4AA6ODTFNDRBMHBTA5CNFSM4KP55ZTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK4VBOQ#issuecomment-582570170
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ADJB47PUXZY5CVL2EHSEIDTRBMHBTANCNFSM4KP55ZTA
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ParkerICI/mantis-viewer/issues/19?email_source=notifications&email_token=AA7D37CM6BIYOXX46WLSO43RBMLVXA5CNFSM4KP55ZTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK4ZHUA#issuecomment-582587344,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7D37CPIV5WKHDBQUYFUW3RBMLVXANCNFSM4KP55ZTA
.


Created hook fired multiple times for mixins when mounted using Vue test utils

Version
1.0.0-beta.25
Reproduction link
https://github.com/jimmaaay/vue-test-utils-created-hook-issue
Steps to reproduce

Clone repo
Run npm run test:unit

What is expected?
A console.log output of:
Mixin1: Created
Mixin2: Created
App: Created
What is actually happening?
A console.log output of (minus unnecessary lines):
Mixin1: Created
Mixin2: Created
Mixin1: Created
Mixin2: Created
App: Created

If you run npm run serve and check the console in the browser you'll see the console output that I expect to see in the unit tests

I have a similar problem with the "mounted"-hook.

This is fixed in Vue 2.5.18+