ion-select with multiple value not work properly on ios devices

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ x ] 3.x
I'm submitting a ...  (check one with "x")
[ x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

On ios device after selecting option in multichoice select for a fraction of a second it sets the option value to true and then returns false. The problem only occurs on the iPhone. Android and emulator works correctly.
DOM At the moment of clicking:
<button class="alert-tappable alert-checkbox disable-hover alert-checkbox-button alert-checkbox-button-ios alert-checkbox-button-default alert-checkbox-button-default-ios activated" ion-button="alert-checkbox-button" role="checkbox" aria-checked="true" id="alert-input-2-0">...</button>

DOM After click:
<button class="alert-tappable alert-checkbox disable-hover alert-checkbox-button alert-checkbox-button-ios alert-checkbox-button-default alert-checkbox-button-default-ios" ion-button="alert-checkbox-button" role="checkbox" aria-checked="false" id="alert-input-2-0">...</button>

Related code:
<ion-item *ngFor="let question of questions">
    <ion-label>{{question.question}}</ion-label>
    <ion-select [multiple]="question.questionType == 'CHECKBOX'"
                [formControlName]="'question' + question.questionId">
        <ion-option *ngFor="let answer of question.answers" [value]="answer.value">
           {{answer.answer}}
        </ion-option>
    </ion-select>
</ion-item>

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
global packages:

   @ionic/cli-utils : 1.5.0
   Cordova CLI      : 6.5.0
   Ionic CLI        : 3.5.0

local packages:

   @ionic/app-scripts              : 1.3.8
   @ionic/cli-plugin-cordova       : 1.4.1
   @ionic/cli-plugin-ionic-angular : 1.3.2
   Cordova Platforms               : ios 4.4.0
   Ionic Framework                 : ionic-angular 3.4.2

System:

   Node       : v6.9.0
   OS         : macOS Sierra
   Xcode      : Xcode 8.3.3 Build version 8E3004b
   ios-deploy : 1.9.1
   ios-sim    : 5.0.13
   npm        : 3.10.8

Hello, thanks for using Ionic! Can you install our wkwebview plugin and give this another try please?

I use  apache wkwebview because only on this I have the ability to send requests to the sites and multiple select now works, but ther is something wrong with getting custome header value from response:
    public doLogin(user: any, success: Function, fail: Function) {
        this.http.post(PARSE_SERVER_USER_URL + 'api/auth/login', {
            'username': user.username,
            'password': user.password
        }).subscribe(
            response => {
                if (response.headers) {
                    let token = response.headers.get('x-auth-token');
                    let that = this;
                    this.setUser(response.json()).then(function () {
                        that.loginSuccess(token, response.json(), success);
                    });
                }
            },
            error => {
                this.loginFailure(fail);
            }
        );
    }

token is null
I have to investigate it more deeply, but maybe someone knows some possible cause.

I use  apache wkwebview (because only on this I have the ability to send requests to the service) and multiple select now work, but ther is something wrong with getting custome header value from response:
    public doLogin(user: any, success: Function, fail: Function) {
        this.http.post(PARSE_SERVER_USER_URL + 'api/auth/login', {
            'username': user.username,
            'password': user.password
        }).subscribe(
            response => {
                if (response.headers) {
                    let token = response.headers.get('x-auth-token');
                    let that = this;
                    this.setUser(response.json()).then(function () {
                        that.loginSuccess(token, response.json(), success);
                    });
                }
            },
            error => {
                this.loginFailure(fail);
            }
        );
    }

token is null
I have to investigate it more deeply, but maybe someone knows some possible cause.

No problem! The wkwebview plugin will be installed by default in a future release.

Is there other ways to fix this issue? Because I tried wkwebview plugin and it produces 2 new other issues just so that I can fix this 1 issue, which doesn't make sense to me.
The new other issues are:

CORS. The older webview uses to contact my XML-RPC backend server API with no origin specified. It worked until I install wkwebview and it ran into CORS issue on iOS.
Bouncing of view upon input focus. The lower the input textfield in a page, the more bounce. No configuration seems to be available to fix this issue.


Documentation with examples for glob

Hi!
I'm enjoying to use this plugin a lot, thanks for your work!
One thing I just figured out mostly by trial and error was how to narrow down search results by just certain file types. A use case I have pretty commonly is for example searching in test-files or environment files. That would be files that have the pattern *.spec.* or *.env.
It turns out that this is already possible but I didn't really know how and the documentation did not provide a lot of information about that for me either.
Maybe I'm not the only one that got stuck there, so I would like to update the documentation with how to use the glob separator and provide a few examples.
I'll create a PR for it. I just wanted to have a related issue here, so the PR doesn't just come out of the blue :)
If there's something else to do, please let me know - I didn't contribute to a lot of open source projects yet

Don’t need a special PR, the wiki is open for editing for exactly this reason.

Ok nice, I should have searched the wiki first as it seems :D
There already is something in there, but not particularly for my use case. I'll update the wiki, thanks!

Ok nice, I should have searched the wiki first as it seems :D
There already is something in there, but not particularly for my use case. I'll update the wiki, thanks!

No pressure at all, whatever you contribute is appreciated :)


Multiple images getting picked

Multiple images are getting picked after pressing cancel  and then selecting an image

https://user-images.githubusercontent.com/99650688/162185638-cbd6ec2d-a9cb-4378-a700-950a65cb7b8e.mp4


[Doc] Documented simplest example contains wrong variable names

Description
The current documented simple example shows the variable hostname and temp_license:
module "eks_blueprints_addon_cbci" {
  source = "REPLACE_ME"

  hostname     = "example.domain.com"
  cert_arn     = "arn:aws:acm:us-east-1:0000000:certificate/0000000-aaaa-bbb-ccc-thisIsAnExample"
  temp_license = {
    first_name  = "Foo"
    last_name  = "Bar"
    email =<EMAIL_ADDRESS>    company = "Acme Inc."
  }

}

But the variable names are actually hosted_zone and trial_license.

Actually the full definition would be like
module "eks_blueprints_addon_cbci" {
  source  = "cloudbees/cloudbees-ci-eks-addon/aws"
  version = "~> 3.16720.0"

  hosted_zone    = "example.domain.com"
  cert_arn     = "arn:aws:acm:us-east-1:0000000:certificate/0000000-aaaa-bbb-ccc-thisIsAnExample"
  trial_license = {
    first_name  = "Foo"
    last_name  = "Bar"
    email =<EMAIL_ADDRESS>    company = "Acme Inc."
  }

}


POST API to send alerts to Alert manager

What this PR does / why we need it:
This API allows alerts to be pushed to Alert Manager
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
NA
Special notes for your reviewer:
Release note:

POST API
http://localhost:50040/v1beta/alert
Request body
{
    "annotations": {
      "a1": "v1",
      "a2": "v2"
    },
    "endsAt": "0001-01-01T00:00:00Z",
    "startsAt": "0001-01-01T00:00:00Z",
    "generatorURL": "http://",
    "labels": {
      "l1": "v1",
      "l2": "v2"
    }
}

@skdwriting @xing-yang @leonwanghui please review

/retest

Coverage decreased (-0.1%) to 30.553% when pulling 3bc91c47f84214a05d4df70389a8535247ca229c on rhsakarpos:alertpost into bae5a6ba87845d36bfd9e6991ce9c52e2bb384fc on opensds:development.

Need a rebase.


Issue with acs commons error handling

Required Information

[ ] AEM Version, including Service Packs, Cumulative Fix Packs, etc: ____ Version <IP_ADDRESS>___
[ ] ACS AEM Commons Version: _3.17.0 and 3.19.0
[ ] Reproducible on Latest? yes

Expected Behavior
When we are accessing any page inside one microsite it is redirecting us to the  error page of other microsite. Although we have error pages published for that microsite.
Example:
In case of any error on /content/testing/us/en page then it is redirecting us to the error page of  "/content/app/us/en".
We do have error pages for both /content/testing/us/en and /content/app/us/en
the error handling is setup with acs commons as recommended.
Steps to Reproducehttps://stryker-build64.adobecqms.net/content/marketing-operations/us/en/indextest.html >> this Url should go to the https://stryker-build64.adobecqms.net/content/marketing-operations/us/en/error

Can you set loggin to DEBUG on com.adobe.acs.commons.errorpagehandler.impl and reproduce the erroring condition?
I would double-check all your errorPages properties - it sounds like one isn't updated (or maybe not published after an update?)
This feature hasnt changed in ages - and im not sure how it could know abotu some other trees error pages unless there's an errorPages property pointing to it (or its the fallback in the OSGi config).
Also, are you sure no one deployed ErrorDocument directives on Apache webserver(dispatcher) that hard-coded to goto the /content/app/us/en?

@AnupamaKarru - few observations

I assume your errorPages property is set  on all your cq:Page trees properly. Your OSGi only lists 1 mapping in paths, so i assume other are handled elsewhere (you dont need the OSGi paths at all if you are handled it at the cq:Page property leve)
If the ErrorDocument directive is active for all your microsites, then this will override what AEM returns AS the error page. based on the info you provided, my guess is AEM is returning the correct error page - but the ErrroDocument is setting the 5xx/4xx response and returning with the error page specified there (which is hardcoded to /app/us/en/errors.html ..)

You can test this, but hitting AEM Publish directly (port 4503) without going through dispatcher and see if you have different behavior.

Yes, errorPages property is set on all pages.But we have OSGI config as well pointed to single url.
Both errorDocument and OSGI has the same value configured.
I tried hitting the publish url but it is still going to /app/us/en/errors.html

Please provide an update.


Built-in Observability interface in BullMQ

Hello,
this is not an issue, it's just to inform that we have finally creating a generic observability interface for BullMQ, which can be used to implement an OpenTelemetry version of it, which we will actually also provide very soon. You are welcome to give any feedback to the PR as we are still ironing out and learning about observability ourselves:
https://github.com/taskforcesh/bullmq/pull/2721

Hi @manast, thank you! This is fantastic news, thank you for letting us know.
My two cents: while I understand the desire to avoid pulling in an additional dependency, I would recommend leveraging OpenTelemetry's own @opentelemetry/api package when possible, rather than, going by the PR linked, re-implementing a subset of it in your own code. Perhaps it could be an optional dependency, with a thin wrapper around it to account for it not being present. You may want to look at the Next.js or Prisma's internal OpenTelemery tracer wrappers for examples of this.
If the intention is for the library to be agnostic towards which telemetry system is used, and therefore tying it to @opentelemetry/api is not on the table, then I would still suggest that building these OpenTelemetry-esque semantics into it, as done in the PR, will not be friendly to other telemetry systems.
Instead, in that scenario, I would suggest providing "instrumentation hooks" at key functions worth instrumenting. The instrumentation hook is responsible for calling the actual function that performs the task being instrumented, and receives the same contextual information as the original function would have. This allows the actual instrumentation that uses the hooks to make use of them in whichever way it needs.
I've mocked up what I mean by this in a TypeScript playground. Please feel free to let me know if you have any questions.

I appreciate the interface that we are providing may not be implementable by other telemetry systems, I guess we will figure that out later on. However I do not think it is possible to simplify it just as in the code you provide, as there are important semantic relations between when jobs are produced vs when they are consumed, and how the context data is actually stored and propagated in the jobs options, etc. Overall I think our current solution is a good trade-off. For users not caring about telemetry no new dependencies are needed and the overhead is negligible, for users caring about Otel telemetry they just need to import the Otel plugin and they are all set. Worst case scenario only Otel will work with this interface, I think that's still a good enough solution.


SQL Server is not capable of sorting Integer JSON Fields

There exists a column : field_values which contains json data.
The json fields datatype are as as follows:
name : STRING
id : Integer
quality : STRING
If applied sorting based on "id" then Postgres query provides correct resultset as below,you can see the id sorted correctly
EG:Entries are ordered=>0,1,2,3,4,5,6,7,8,9,10,11........

But when tried the same via SQL Query,then result set is fetched  with respect to "id" field,"id" is treated as text hence resultset obtained is not accurate.
EG:Entries are ordered as =>0,1,10,11,12,13.......

It would be very beneficial to get this enhancement on work as I could not find any other alternatives too.
Sometimes JSON Data can be dynamic hence casting into a type is not an option.
Just as Postgres does it,can SQL do it?
Software Details as below:
SQL Server Management Studio						15.0.18131.0
Microsoft Analysis Services Client Tools						15.0.1347.0
Microsoft MSXML						3.0 6.0
Microsoft Internet Explorer						9.11.17134.0
Microsoft .NET Framework						4.0.30319.42000

@flash0077 Please ask product support or in support forums.
#please-close


Allow to disable body limitation size

Q
A

Bug fix?
no

New feature?
yes

BC breaks?
no

Deprecations?
no

Related tickets
-

Documentation
https://github.com/php-http/documentation/pull/259

License
MIT

What's in this PR?
This PR allow to set the httpplug.profiling.captured_body_length to NULL to avoid body truncate in the Symfony profiler.
Why?
I want to view all the body content of a Request or Response.
Checklist

[x] Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
[x] Documentation pull request created (if not simply a bugfix)

To Do

[x] If accepted, update documentation

Thanks, LGTM

I've created the documentation PR, and update this PR description.

i am not sure if this is a good idea. you could set the limit to 100k or whatever crazy high value. removing the limit could break in bad ways when you ever happen to load several megabyte of data.

Sure, it could be dangerous. But when I use the Symfony profiler (in dev mode), I don't want that my body content will be truncate.
In a debug purpose, I want to have all information I need.
I'm going to open a new PR in the message component to update the formatter.

I'm going to open a new PR in the message component to update the formatter.

i just changed the code that you will adjust, please check the newest master: https://github.com/php-http/message/pull/111

i just changed the code that you will adjust, please check the newest master: php-http/message#111

👍

@dbu I think there is some cases where it's useful, specially when uou know that the remote api will never throw a too big responsel.
As an example when using a client for elasticsearch, i know that i will never get a too big output, and that i can always show the the full body, (but i often hit the default limit here).

apart from that i am okay to merge this as soon as we have the merge request against php-http/message to state that null is explicitly supported.

thanks for this contribution (and your patience while we figured out how to exactly do this ;-) )

No problem 😄


Question.

Hello.
How i can load complex object async w/o using rx?
When i receive as
EventEntity data = mData.select(EventEntity.class).limit(1).get().first();
data is contain empty objects with FETCH state? but i need full LOADED object

mData.select(EventEntity.class).limit(1).get().toObservable().first();

@BOOMik Off-topic: Great title...
@FuriousSeraphim Quoting OP "without rx". Observable is rx.

Your object will be loaded using that query, but as you said it is not a async call in your example. If you're not using RxJava you can simply run that code in another thread the api is thread safe. There are a number of ways to do that Java 8 CompletableFuture.supplyAsync for example.


multinode: watch Kubernetes service resources instead of depending on etcd

Deploying etcd is hard, so maybe we should just watch Kubernetes services instead.
cc @naoki9911

Theoretically, the multi-node bypass can handle pod-to-pod communications without the proxy.
bypass4netns can expose the pod's ports on the node by bypassing the socket when bind(2) called, and other pods can connect to the exposed ports.
But, I think this approach is not elegant.
We need to handle all connect(2) calls to rewrite their destination address to node's IP and ports.
Also, this approach consumes many ports on the node and other nodes other than pods can connect to the exposed ports.
I think your multiplexing proxy approach is bettter.
The following procedure will enable the approach for SOCK_STREAM.
When the pod's connect(2) is handled, connecting to the proxy and sending destination information in the handler.
Multiplexing proxy reads the destination information and connects to the destination pod.
But, applying the same approach for SOCK_DGRAM will be difficult.
The multiplexer will cause huge performance degradation.

bypass4netns can expose the pod's ports on the node by bypassing the socket when bind(2) called, and other pods can connect to the exposed ports.

Yes, but it might be insecure to directly expose bare pod ports to other nodes, and it is hard to handle port number conflicts across pods


Extraction failed

Hi,
the following article was failed to fetch: https://www.oakridger.com/obituaries/story-obituaries-2021-01-25-thomas-howard-scott-4254755001
this is not a single page app...
Thanks

@aviNrich the way this website was built is quite strange. It includes 2 iframes for header and footer. Other parts are stored as a Redux state object in a pair of <script id="__NEXT_DATA__" type="application/json"></script> tags, those are being rendered with JavaScript.

Ok, thanks


v6: Remove deprecated spo site classic  commands. Closes #3458

Closes #3458
Removes deprecated spo site classic  commands:

spo site classic add
spo site classic list
spo site classic set

Thank you for your contribution. Manually merged


main: expand strict coverage

When the strict flag was originally introduced, it didn't take into
account the fact that the conversion function can return non-fatal
reports. This corrects that mistake by failing when there are any
reports that are returned.

Whoops, that report is for the parsing logic, and this report is for the validation logic. nvm.


Identify why forums index loads slowly

While not too slow, I suspect that some associations could be loaded more easily using includes to reduce the number of database hits.

Fixed with forum overhaul in #921.


Update product name from "Business Central" to "Sales"

There appears to be an issue with the product that is being referenced in the first sentence.
"When you integrate Dynamics 365 Sales with Business Central, you can decide whether to synchronize data in selected fields of Business Central records (such as customers, contacts, and sales people) with equivalent records in Business Central (such as accounts, contacts, and users)."
The second mention of "Business Central" should be "Sales" as it reference accounts, contacts, and users which are D365 CE terms.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bf4cd40b-ac70-ebb4-aca9-dea6ad6bf2f8
Version Independent ID: ab3ea9a9-83cc-2367-2e48-eb298f03d0c1
Content: Synchronization and Data Integration - Business Central
Content Source: business-central/admin-synchronizing-business-central-and-sales.md
Service: dynamics365-business-central
GitHub Login: @bholtorf
Microsoft Alias: bholtorf

Hello,
Thank you for your feedback! Our apologies for the very long wait for an answer!
A member of our team has at long last reviewed your feedback and updated the article in question.


Properly escape parameters to Dwoo "a" blocks.

I'd expect to use local variables without HTML escaping, and have the Dwoo {a} block escape them for me. But it doesn't.
This can allow XSS injection in some cases, e.g. where URL parameters are copied back into the output, and breaks XHTML validation as well if {a} blocks are used.

Thanks, that sounds like a sensible patch. Can you just remove those commented out lines? They are not useful anymore, so they shouldn't be in the code.


📃:  Rock-Paper-Scissors

🔴 Title :Rock-Paper-Scissors
🔴 Tech stack : html, css
🔴 Objective : to tech basics
📸 Screenshots
https://github.com/user-attachments/assets/8d82a21d-5abb-4101-9e69-6aa9404b03dc
✅ Details to Include When Taking the Issue:
Name : Aman Kumar
GSSOC ext, Hacktoberfest,
Participant Role (Specify the Open Source Program name, e.g., GSSOC, Hacktoberfest, etc.):

Happy Contributing! 🚀
Wishing you all the best on your open source journey. Enjoy! 😎

Hey @Amankr200 I can work on this.

assign me first

there already in the project


Added ability to set additional arguments during queue creation.

Right now it isn't possible to set additional parameters. This commit adds this ability.

Yikes, I'm a bit behind  : )  Looks good to me. $PSBoundParameters.ContainsKey('Arguments') might be a simpler test, but this should work as is.
Thanks!


Add link to network isolation documentation

@davidkline-ms,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


fix jira ticket number in fixed issues for 79411 CD release notes

CDS-59624 listed twice in CD release notes 79411. Second reference should be CDS-59544.
https://harness.atlassian.net/wiki/spaces/PD/pages/21400387685/NG+Release+SAAS+May+26th+2023+for+794xx-+Build
https://harness.atlassian.net/browse/CDS-59544
What Type of PR is This?

[ ] Issue
[ ] Feature
[x] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Setup mkdocs and add documentation

closes #57
TODO:

[x] deploy docs on readthedocs or github pages

Could we do something like this to avoid duplicate dependency defs: https://stackoverflow.com/a/73600610


Upgrade to OkHTTP3

New version required some syntax changes and calls can no longer be cancelled by tag, so we now maintain a list of current calls and search that list when a cancel is made.
Resolves #573

Now using version 3.2; call cancelling uses lists of running and queued calls provided by the dispatcher.


Error deleting default DHCP options

[ERROR] ClientError: An error occurred (InvalidDhcpOptionsId.Malformed) when calling the DeleteDhcpOptions operation: The dhcp-options ID 'default' is malformed
Traceback (most recent call last):
  File "/opt/python/aws_lambda_powertools/middleware_factory/factory.py", line 134, in wrapper
    response = middleware()
  File "/opt/python/aws_lambda_powertools/utilities/validation/validator.py", line 129, in validator
    response = handler(event, context)
  File "/opt/python/aws_lambda_powertools/tracing/tracer.py", line 305, in decorate
    response = lambda_handler(event, context, **kwargs)
  File "/opt/python/aws_lambda_powertools/logging/logger.py", line 442, in decorate
    return lambda_handler(event, context, *args, **kwargs)
  File "/var/task/account_setup/lambda_handler.py", line 54, in handler
    ec2.delete_vpc(default_vpc_id)
  File "/var/task/account_setup/resources/ec2.py", line 85, in delete_vpc
    vpc.dhcp_options.delete()
  File "/opt/python/boto3/resources/factory.py", line 580, in do_action
    response = action(self, *args, **kwargs)
  File "/opt/python/boto3/resources/action.py", line 88, in __call__
    response = getattr(parent.meta.client, operation_name)(*args, **params)
  File "/opt/python/botocore/client.py", line 530, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/opt/python/aws_xray_sdk/ext/botocore/patch.py", line 38, in _xray_traced_botocore
    return xray_recorder.record_subsegment(
  File "/opt/python/aws_xray_sdk/core/recorder.py", line 462, in record_subsegment
    six.raise_from(exc, exc)
  File "<string>", line 3, in raise_from
  File "/opt/python/aws_xray_sdk/core/recorder.py", line 457, in record_subsegment
    return_value = wrapped(*args, **kwargs)
  File "/opt/python/botocore/client.py", line 960, in _make_api_call
    raise error_class(parsed_response, operation_name)

in regions: sa-east-1, ca-central-1

Fixed in ae724922fce7b09f8300e8cf14276cf20663fa32


[NF] Designing a double cage rotor for SCIM

Since we are working on the simulation of SCIMs (#165) right now I think it would be a good point to start thinking about implementing a double cage rotor for machines.
For the design i suggest the following layout:

This is in good agreement with many commercially available laminations. The dimensions as given are the dimensions which are often provided with a rotor.

Hello,
Thank you for this schematics :)
To add this new slot you will need to define a new SlotWind daughter, you can take inspiration from the following tutorial: https://pyleecan.org/tuto.add.slot.html
Note that PR #180 change how the build_geometry_wind method is defined (we will soon update this tutorial). Now you only need to define build_geometry and get_surface_wind which is an easier method. By the way, can you add on the schematics where the "winding surface" is ? Maybe you will have to cheat as in SlotW60 and SlotW61 build_geometry_wind if the "W2 part" is empty.
Best regards,
Pierre

The typical rotor for an induction motor is made of cast aluminium, so all voids will be filled. So the two slots will be part of the winding surface. So the winding surface would be:

I did already take a look at the tutorial but today i have the time to actually start working on it. Thanks for the heads up on the new convention in build_geometry.
all the best,
Menno

I just made the csv file for the new Hole, called HoleDC. I don't see any problem with this file. However it is not recognized by the run_generate_classes function somehow. The file is in pyleecan/Generator/ClassesRef/Slot.
When i run the generator every file is updated except for HoleDC. So i tried recreating the file, but nothing seems to work. Somehow when i change a file which is updated nothing changes either.
Am i missing something?
HoleDC.zip
In the mean time i will just try to start writing the build_geometry code, which should be possible without generating the class first

??? I tried to generate and it worked for me. Have you checked the generator terminal output?
Regarding the name 'Hole' I think it better should be 'Slot' since it is opened.

Ah, slot is indeed the better name. I will change it, but what do you mean by terminal output? If you mean the output in command prompt:
The output seems to be alphabetically ordered, however the name HoleDC (which i will change) is mentioned nowhere in the list.
Than at the end it sais "1716 files left unchanged".
The class generator script has not changed in the last couple of days right? So it should work

Can you make sure that the generator scan the correct folder ? Maybe if you have install pyleecan from pip it can be called on another folder.

Hello,
The last webinar is all about "how to contribute to pyleecan". Did you finished the implementation of this slot ? If not do you think that we can use it to create the "live" equivalent of the "how to add a slot tutorial". Then I would create the schematics and push the code on the 6th November.
Otherwise does anyone have a slot that we can use ?
Best regards,
Pierre

Hey pierre,
So far i created the points and lines, i dont know how much more there is to do, but i think there still is some way to go. But feel free to use this for your webinar. I wont mind at least.
All the best,
Menno

Hello,
Normally "points and lines" should be enough to make it work but we can add some other methods to optimize it. Can you share your code with us ? I will carry on the work for the other methods then.
Best regards,
Pierre

Hello @MVreemann ,
I should start working on the slot tomorrow or on Thursday. Can you share your code with me so I can save some development time ?
Best regards,
Pierre

Hey Pierre, Sorry for the long delay, i am still struggling with internet at home, but luckily i currently can finally access internet. so here are the files you asked for, i hope its not too late
SlotDC.zip

Hello,
Thank you for your code, I will use it to create all the methods live tomorrow :)
I will be using this schematics:

The winding area is not the one you intended but it will be better for the explanation in the webinar. We can then easily change it to your definition.
Best regards,
Pierre

Hello,
Do you think we can close this issue or do you need further work on the slot . For instance should we introduce a new property "type_active_surface" to switch from the surface I have defined and an active surface that would overlap the full slot ?
Best regards,
Pierre

For the validation of #165 we have data on a double squirrel cage rotor with a slightly different rotor design. I am currently working on the implementation of that. I'll put the documentation in this issue. After that i think we can close it.
All the best,
Menno

Hello,
what do you think of a general property for all slots that is None (for default active surface) or has a user specified height for the surface starting from slot bottom.
Best regards, Sebastian


0.6.14 Uncaught Error: Missing: SyncTestZoneSpec for Angular RC4 tests

Since 0.6.14 I'm getting Uncaught Error: Missing: SyncTestZoneSpec for my Angular2 RC4 unit tests. They work with 0.6.13.
Affected project and failing build as a reference.
I'm using angular2-webpack-starter for my Angular2 project (like many others) which references zone.js via ~0.6.12 (package.json). This issue is likely affecting a lot of people.

same issue happening for me.. is there any update?

Downgrading to zone.js to 0.6.13 works for me.

We get the same error with Angular 2 RC5. We are also using a configuration similar to angular2-webpack-starter, and therefore also automatically got the new zone.js version in our CI builds.

I did the below changes to the config/karma-test-shim.js (or config/spec-bundle.js) and unit tests worked again.
require('zone.js/dist/zone');
require('zone.js/dist/long-stack-trace-zone');
require('zone.js/dist/async-test');
require('zone.js/dist/fake-async-test');
require('zone.js/dist/sync-test');
require('zone.js/dist/proxy-zone'); // since zone.js 0.6.14
require('zone.js/dist/jasmine-patch'); // put here since zone.js 0.6.14

yup. that's the right fix. you need to load the sync-test zone in your testing harness.

We are using Angular2 RC2.
The above test shim update did not resolve the issue.
I updated package.json to this:
-    "zone.js": "^0.6.12",
+    "zone.js": "^0.6.14",

and updated to include: require('zone.js/dist/sync-test');
These steps did not resolve the issue.
Forcing a downgrade to 0.6.13 resolved the issue.
  "dependencies": {
    "@angular/compiler": "2.0.0-rc.2",
    "@angular/common": "2.0.0-rc.2",
    "@angular/core": "2.0.0-rc.2",
    "@angular/http": "2.0.0-rc.2",
    "@angular/platform-browser": "2.0.0-rc.2",
    "@angular/platform-browser-dynamic": "2.0.0-rc.2",
    "@angular/router": "2.0.0-rc.2",
    "@angular/router-deprecated": "2.0.0-rc.2",
    "@angular/upgrade": "2.0.0-rc.2",
    "@ngrx/core": "^1.0.0",
    "@ngrx/store": "^2.0.1",
    "core-js": "^2.4.0",
    "es6-promise": "^3.2.1",
    "es6-shim": "^0.35.1",
    "reflect-metadata": "^0.1.3",
    "require": "^2.4.20",
    "rxjs": "^5.0.0-beta.9",
-    "zone.js": "^0.6.12",
+    "zone.js": "0.6.13",
    "material-design-lite": "^1.1.3",
    "getmdl-select": "^1.0.4"
  },

@cdcooksey Did you clear out your node modules and rerun npm install?

As of 0.6.15, the proxy-zone package has been renamed to proxy. The following imports work for us.
require('zone.js/dist/zone');
require('zone.js/dist/long-stack-trace-zone');
require('zone.js/dist/async-test');
require('zone.js/dist/fake-async-test');
require('zone.js/dist/sync-test');
require('zone.js/dist/proxy'); // since zone.js 0.6.15
require('zone.js/dist/jasmine-patch'); // put here since zone.js 0.6.14

@SaltyDH thanks - we found the order of the dependencies was also important...

Fixed by updating the 'files' array in karma.config.js with:
  'node_modules/zone.js/dist/zone.js',
  'node_modules/zone.js/dist/long-stack-trace-zone.js',
  'node_modules/zone.js/dist/async-test.js',
  'node_modules/zone.js/dist/fake-async-test.js',
  'node_modules/zone.js/dist/sync-test.js',
  'node_modules/zone.js/dist/proxy-zone.js',
  'node_modules/zone.js/dist/proxy.js',
  'node_modules/zone.js/dist/jasmine-patch.js',

NOTE: as indicated by others, the order is important

Just wasted almost an hour on this! The order of imports is indeed important. I use tslint and I've blindly applied the autofix for the "ordered-imports" rule in VS Code (via the TSLint extension), so it sorted them alphabetically. Btw, it would be nice if zone.js fixed this dependency on the order of imports. Easy to overlook, this; and feels like a magic spell, or even like a bug if you ask me, a humble guest in the strange javascript world.

The sort order I needed for Angular 4.0.0 generated using the CLI was so:
import 'zone.js/dist/long-stack-trace-zone'
import 'zone.js/dist/proxy.js'
import 'zone.js/dist/sync-test'
import 'zone.js/dist/jasmine-patch'
import 'zone.js/dist/async-test'
import 'zone.js/dist/fake-async-test'

@julie-ng In which file did you throw those imports in?

@RoestVrijStaal I just ran into the same problem. The imports are already in src/test.ts but TSLint changes their order if you have "ordered-imports" enabled. Changing the order back to the order listed above (and disabling TSLint for this file) solved the problem for me.

I have made a PR #982 to add a new zone-testing file , hope it can resolve this issue.

Same issue for me, after tslint auto fixed many files in my project the client tests did not work anymore.
Thanks for the hint with the import orders, that solved the problem for me.


Accessing documents in the pipelines container

I am struggling to access the documents that I upload in the Open WebUI interface. How can I do it? Is there an API? In the Custom RAG example there is this piece of code:
self.documents = SimpleDirectoryReader("./data").load_data()
but for me that returns nothing, and I got to understand that as the pipeline is running on a separate container, the path that I’m trying to access in that piece of code is in the pipelines container. Is there any way to do this?

There may be an easier way, but I've switched from using sqlite w/ webui.db (the default) to using postgres and qdrant.  This allows for the separation needed for my pipeline to work.  My script looks up the collections associated with the 'knowledge' in postgres and the I can feed those details in when searching in qdrant, but I do find the use of collections as they are currently implemented to be sub-optimal; it would be great to see multi-tenancy.


DO NOT MERGE: SB-482 In Progress

@metacosm I'm guessing that the versions of these boosters need to be updated at this point?

@lincolnthree yes and format updated for newer launcher version.


Vocals/Inst being not equal in length causes the shorter audio to loop to accomodate for the longer audio

Describe your bug here.
A more bearable version of https://github.com/ShadowMario/FNF-PsychEngine/issues/8400, which has been marked as closed. For those that want to know and duplicate, here is how.

Your audio files, Inst.ogg and Vocals.ogg don't have the exact same length. In vanilla/base gameplay, that's Week 6's Thorns.
Play normally until the end.

For Thorns, it should be a few seconds of pure silence as Inst.ogg is longer than Vocals.ogg, but the latest updates have caused Vocals.ogg to basically restart just as Inst.ogg ends.
#8400 is what happens on pre-Week 7 game engines, including Kade Engine, pre-0.6 Psych Engine, and the downloadable Itch.io build.
Virtually every build has this problem unless they're playing the Newgrounds/Week 7 version if I recall correctly.
At least Psych's audio bug sounds better instead of "screeching noises".
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No edits, it's an ontouched build.

Closing this, bug is actually really fixed.


[MacOS] Update pwsh to 7.4

Description
This PR updated pwsh version to 7,4
Related issue:
https://github.com/actions/runner-images-internal/issues/5688
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run macos11, macos12


add additional metrics and logs

This PR ads two additional metrics:

loadbalancer_activations__count : counter for activation starts in load balancer
invoker_container_start__ count

I also adds another info level log statement with container start information

@markusthoemmes I have changed the code to use transid.mark.

@rabbah I have consolidated the two log messages when starting an activation into one that looks like this
[2018-02-05T10:49:55.757Z] [INFO] [#tid_3] [ContainerPoolBalancer] loadbalancer: activation started for namespace 23bc46b1-71f6-4ed5-8c54-816aa4f8c502 and activation d72c63deb6a84562ac63deb6a8f56244

Regarding the type related comment I will leave the parameters at 'String'  for now.


Prevent fqn collisions?

For example, if you have 2 operations within the dependencies with same fully qualified name, currently they will overwrite each other silently. Should the compiler prevent that?

Do they overwrite, or just get picked at apparent random?

Last one wins, but note that although snakeyaml maintain the order, according to yaml spec the order in maps is not guaranteed...

if you using our best practices you wont have this situation - closing this

Unless the enforcement of file name == operation name is in place, claiming that best practices keep this from being an issue is, at best, dubious.
Either way, there should be some way to find the issue other than cursing, swearing, and hoping somebody else knows what's going on :(


Synchronous store writes

In many places in the Narwhal codebase we need to persist state and only proceed when we are sure the operation completed successfully. Write now it seems the only way to do it is to combine store.write.await with a store.read_notify.await, which seems wasteful

https://github.com/MystenLabs/mysten-infra/pull/174

Closed with https://github.com/MystenLabs/mysten-infra/pull/174


Ignore src path for npm

AFAIK there're people who actually require our src instead of dist to get smaller code on ES6-enabled platforms, so this might be a breaking change.

there're people who actually require our src instead

astexplorer does.
The readme also encourages this (emphasis mine):

Acorn is written in ECMAScript 6, as a set of small modules, in the project's src directory, and compiled down to bigger ECMAScript 3 files in dist using Browserify and Babel. If you are already using Babel, you can consider including the modules directly.

Yup. Closing as it's a breaking change with no real benefit.


Switch/Case statments using dictionaries.

This behaviour is already shown in lightweightswitch.py but feel free to add your example. I also prefer your file name.
Btw in the last line you have a typo. Nome -> None

Ty, I will fix and request a new pull.


Pressing return key when editing metadata should not duplicate or remove fields

 Issue by mephillips-durham
Wednesday Apr 15, 2015 at 16:53 GMT
Originally opened as https://github.com/projecthydra/sufia/issues/1040

If I edit a file in Sufia, the "Abstract or Summary" box is quite tall, which encourages people to enter potentially more than one paragraph.  If I type some text in this box and press return then an extra instance of the abstract field appears below the one I am editing.  My cursor remains in the one I was editing.

In IE 10 the content I have just typed appears in the new instance as well as the original.
In Chrome the extra instance of the abstract field is blank.
If I do not realise what has happened, and press return again, then the instance of the field I was originally editing is removed.
In IE 10 I get my original content back.
In Chrome I lose all that I have typed because the extra instance was blank.

The same problem occurs for single-line edit boxes like Keyword.
I think that for text areas like Abstract I think that return should cause a new line to be started (if that's acceptable in the metadata model, which it may not be).  For the other fields it might be OK to add a new instance of the field but only if the cursor is moved to the new instance.

 Comment by mtribone
Monday Apr 20, 2015 at 13:37 GMT

We're having a similar conversation about the enter key here:
https://github.com/projecthydra/hydra-editor/pull/84

 Comment by mjgiarlo
Tuesday Dec 15, 2015 at 18:26 GMT

Related to #939?

 Comment by mtribone
Tuesday Dec 15, 2015 at 18:41 GMT

@mjgiarlo Nope. Not related to #939


Fix _find_subtree method.

didn't work with nested systems previously
apply this fix to version >= 2.0

@PanekOndrej Thanks for the fix. What do you mean by "apply this fix to version >= 2.0"? Do you mean we should create bug fix releases for pyosl 0.2, 0.3 and 0.4, including this fix?

@rfahlberg Yes, exactly. I was thinking we should add this fix to releases 0.2.1 and 0.3.0 (create 0.2.2 and 0.3.1) . This bug was unnoticed for quite a while. Not sure if necessary.


Fix errors when connect service bus by managed identity

Fix errors when connect service bus by managed identity.

Hi, @saragluna .
Please help to review this PR.


add Example.Greet

fixes #545
I have had to modify the run-examples.sh to use the stdlib and to provide some input to stdin.
This example doesn't actually work correctly yet because Standard.IO.Terminal.readLine doesn't work correctly, see #577.

Thanks for contributing! I'll look at addressing #577

Thanks for contributing! I'll look at addressing #577


external comments plug-in

Hello
Sorry, but I don't know where to post this information !
I just integrated an external comment plug-in: HashOver.
It works perfectly with Typemill and the Cyanine theme.
If you want to know how to integrate it, I'll describe in a few days the manipulation in a new article on my blog.
Have a nice day.

Great, thank you for sharing, let us know about the blog article here. I remember that there was some demand for a comment system: https://github.com/typemill/typemill/issues/186

Thank you for sharing, it looks very good! You can also integrate it with a plugin if you don't want to change the theme directly, but the way you described works too. Good to know that there is a self hosted open source alternative to disqus!!

Sorry, I am not a software developer. But I would like a comment-plugin very much! Would be great, if there is someone out there, implementing it. Thanks a lot!
regards,
Suitbert

thank you again for the hints for a comment system. I will close it for now since I want to focus on Bug reports right now.


(PUP-9395) specify version-specific documentation parameters during install

With this commit, install specifies version-specific options for documentation.
Apply those options independent of the :source parameter.

@tkishel could you rebase your PR on the latest 4.10.x (now that the bundler 2 fix is in)?

CLA signed by all contributors.

I don't think this needs to go into 4.10.x? 5.5 seems fine to me. Landing any code in 4.10.x will cause a CI run, which is just extraneous load if we're never going to need to ship this

Superseded by PR #7320


React Document verification

reference: https://dtstack.yuque.com/rd-center/sm6war/fhg5vx

@qiuysh

#11


Update Docker entrypoint.sh to use new store.path flag name

Update the docker directories entrypoint.sh file to use the updated flag name, changing repo.path to store.path.

Would be good if your changelog entry also included a link to the PR, pls

Resolved


dump.cs not generated from specific game.

Hai, I tried to generate dump.cs for game package name com.mobile.legends, I started the game and it's not generate the dump.cs. But, one of other game I tried it does generate the dump.cs, do you have any idea what's the problem?

同问

May be worth checking where it thinks the game directory is because for me, i logged /data/user/0/<game_name> which doesnt work, so i hard coded a path that the app can use.

too


Proposed 0.80.0

Codecov Report

Merging #2249 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2249      +/-   ##
==========================================
- Coverage    70.12%   70.1%   -0.02%
==========================================
  Files          689     689
  Lines        50800   50800
==========================================
- Hits         35621   35611      -10
- Misses       15179   15189      +10

Impacted Files
Coverage Δ

src/ripple/protocol/impl/BuildInfo.cpp
82.6% <ø> (ø)
:arrow_up:

src/ripple/server/impl/BaseHTTPPeer.h
86.95% <0%> (-3.11%)
:arrow_down:

src/ripple/protocol/impl/STVar.cpp
85.71% <0%> (-2.6%)
:arrow_down:

src/ripple/app/misc/SHAMapStoreImp.cpp
78.92% <0%> (-1.03%)
:arrow_down:

src/ripple/core/impl/JobQueue.cpp
86.85% <0%> (-0.47%)
:arrow_down:

src/ripple/protocol/impl/Serializer.cpp
69.96% <0%> (-0.35%)
:arrow_down:

src/ripple/basics/DecayingSample.h
86.11% <0%> (+8.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e5490e...cafe18c. Read the comment docs.


Triaging guidelines

I have cleaned up and added some structure for labeling issues. I have went through all open issues and categorized them. This is the resulting structure that I found helpful, and hope that other maintainers will find it useful to filter out interesting issues, and to aid in closing those those that will not be considered for fixing.
Every issue is to be marked with a type. I have found these types to be useful so far

type/bug
type/docs
type/maintenance
type/question
type/feature-proposal

They should all be fairly self evident. I decided to call it "feature proposal" instead of "feature request", because the word "request" invites people to think that one can ask for it and it will just auto-magically happen by itself. In general, I think feature proposals needs clear motivation to even be considered. Just because one "wants the feature" does not mean that it is a good feature. Just because the feature exists elsewhere does not make it good either.
One the type of issue has been established it can be further categorized into

category/API-usage: Anything related to the causual usage of the library, such as macros, matchers, etc...
category/API-driver: Issues related to the C++ interface for driving doctest through a custom main
category/BDD: Stuff related to support of the BDD test syntax
category/build-system: There are seveal build systems, they can be further sub-categorized with build-system/* labels
category/CLI: Command line interface (i.e. adding new flags, etc.)
category/config: Configuration system (i.e. DOCTEST_CONFIG_... stuff)
category/floats: Floating point checks
category/strings: Stringification of types and variables
category/reporting: Anything related to the reporter system, usually people want to add new reporting mechanism
category/platforms: Supporting new platforms. Currently supported platforms have their own labels under platform/*.

Before a feature proposal or bug is to be considered seriously, it needs to satisfy certain requirements, such as providing a minimal reproducible example, or in the case of feature proposals, it needs to be motivating.
The following labels can be used to mark incomplete issues

incomplete/needs-MRE
incomplete/needs-motivation
incomplete/needs-clarification

Every issue can be given a "verdict" documenting why it is to be closed (without fixing)

verdict/duplicate
verdict/false-positive: Usually related to static analysis or wrong usage of C++
verdict/stale: Issue has no interest from participants over a long period of time
verdict/wontfix: Any other reason

Please let me know what you think about this label system. I am preparing an update to the CONTRIBUTORS.md file with information on how to file a proper bug report, how to make a feature proposal, and other ways one can contribute to the library. Some of these labels will be part of that documentation.

Sounds great! I should have done something like this many years ago.


Animation issue in Setting Modal

@yuwenmemon @shawnborton  @marcaaron Please review.
Details
The transition effect on the Setting modal is not the same on different devices and TransitionOut is not detectable.
Fixed Issues
Fixes #1358
Tests
Run the app on a mobile device and observe the animation while opening and closing the settings modal. Now open the application on the web browser and observe the animation effect. It should look the same.
Steps:

Click the avatar on the left sidebar.
Observe the opening animation.
Close the setting screen by either clicking the close icon or clicking backdrop.
Observe the closing animation.
Now repeat 1-4 for different platforms and compare the animation.

Tested On

[x] Web
[x] Mobile Web
[x] Desktop

Screenshots

Web

Mobile Web

Desktop

Hey Guys,
I have checked and found one issue. While we resize the app lower than the mobile resolution on the web the app breaks. The cause of this issue is that the animation is not being built and attached dynamically. After thorough testing, I found that react-native-modal supports dynamic animations but its equivalent modal-enhanced-react-native-web which we are using for the web platform lacks that code. I have successfully added that into the modal-enhanced-react-native-web package (Check the PR Dekoruma/react-native-web-modal#43 ) but I think the maintainer of that repo is not responsive. Thus is it possible we can use our own copy of this package where we can use my modified version?

I have successfully added that into the modal-enhanced-react-native-web package (Check the PR Dekoruma/react-native-web-modal#43 ) but I think the maintainer of that repo is not responsive. Thus is it possible we can use our own copy of this package where we can use my modified version?

Ah hmm that's interesting. I didn't realize we were using this package on web instead of react-native-modal.
I'm not sure we'll want to fork this repository, but if it's the only option then we'd need to fork it first to our organization and then merge your changes in there.
Perhaps we can wait a bit and see if they respond to that PR or we can reach out directly and nudge them. It has only been a day so maybe they will still respond.

@marcaaron  Check here. I was thinking the same initially. But then I come to know this after hours of fooling around with react-native-modal code.
https://github.com/Expensify/Expensify.cash/blob/d4ba77f3732b422b0f6b26740da489af28982d21/config/webpack/webpack.common.js#L113-L120

Thanks for the context. Yes, I think the best thing to do is wait for a bit and try to get your code merged into modal-enhanced-react-native-web if possible.

I agree. But the last update was in 2018. We better mail the guy. :smile:

Looking into this a bit more and I think there is a possibility we are just doing something wrong.
Can we try to fix this with styling somehow? If the maintainer doesn't respond then we've decided to only fork the repository as a last resort (and most likely we won't do it). I did some testing with this library on another branch and think it should work correctly under normal circumstances.

So this lib is very old fork of react-native-modal for the web and almost 90% code is same but react-native-modal is updated more often but this fork has not been updated since 2018. I have picked the necessary code from react-native-modal to patch PR changes but I am sure a lot can be changed.
You can just pick both and compare to see what part of code is still behind from the react-native-modal.

@parasharrajat, I understand what you are trying to do here. But I am suggesting we explore a better solution without forking the library if you cannot get these changes merged. We are not interested in maintaining a fork of this library.

Will explore more for some solution

Perfect, I removed the modal-enhanced-react-native-web package. There are two reasons.

We just don't need a separate package for the web as react-native-modal compiles to the web.
modal-enhanced-react-native-web is outdated and not maintained. The maintainer is suggesting to use other here.

Now react-native-modal works for both web and native.
Please review.

Just chiming in to say that I think the animation issue's root cause may be related to how many chats you have in your list and probably indicate a performance issue somewhere.
Observe:
master with only one chat
https://user-images.githubusercontent.com/32969087/106976730-07e2df80-66fd-11eb-93b2-617baca34c0e.mp4
master with many chats
https://user-images.githubusercontent.com/32969087/106976742-0c0efd00-66fd-11eb-8c83-f3785178ccc6.mp4
parasharrajat:parasharrajat-animation with many chats
https://user-images.githubusercontent.com/32969087/106976776-17fabf00-66fd-11eb-9d82-292000e24def.mp4

I will dig this out why its behaving that way.

So, Surely it's a performance issue, If you use useNativeDriver then we get smooth animations.
Before
https://user-images.githubusercontent.com/24370807/106992084-a4f55500-679d-11eb-8d60-a936b04e092a.mp4
After
https://user-images.githubusercontent.com/24370807/106992075-9dce4700-679d-11eb-8e66-2da68edd21f1.mp4
Now one thing worth mentioning is that the Swipe gesture is not behaving the same. Look at the before the video, swipe happens back and forth, and follows your finger. But in after the video, the swipe happens in one go, and it does not follow your finger.
FPS of the js thread is pretty low when we run the animations or open the Setting the modal. (it drops to 4 or 6 from 59.3 on opening the setting modal). This is the main issue, I think as per the article here. Animations are calculated on the JS thread so I am sure it can't be smooth at 4 fps.
Tip

First thing, I noticed is that withWindowDimensions wrapper component is bad for performance as it updates while animations are running, on the other hand, useWindowDimensions does not update which boost the fps to 12 from 4 on my device.

Sorry, I'm not really sure what useNativeDriver has to do with anything. The issue states the animation inconsistency is with the web implementation. In react-native-web there is only one thread for animations to run on.

I noticed is that withWindowDimensions wrapper component is bad for performance as it updates while animations are running

How did you verify this?

@marcaaron  Web issue is resolved it works fine now. But animation is not at all showing on my android device as you mentioned https://github.com/Expensify/Expensify.cash/pull/1367#issuecomment-773716385.
useNativeDriver is basically helping on android.

I noticed is that withWindowDimensions wrapper component is bad for performance as it updates while animations are running

I used useEffect hooks to log the props that are coming from the withWindowDimensions, so when we run the animation you will see a series of logs with the props value which means props are changing.
useEffect(() => {
console.debug(props.windowWidth);
}, [props.windowWidth]);

On the other hand, when I used useWindowDimensions, there was no output when the animation was running.
I may be wrong :smile:

Ok thanks for the explanation. I think presence of a re-render itself does not necessarily indicate a performance issue. On the other hand re-rendering something that is expensive to re-render might. So I think we are re-rendering something (probably OptionRow items) and that is causing some performance issue. But it could be any number of things.

I am not sure if this comes under the scope of this issue

If in fixing web we break Android then I'd say it maybe falls under the scope 😄
Anyway, I tested your suggestion to try useNativeDriver on Android and it works well. But note that it seems to have a bug on iOS where there is a strange flash. See docs here: https://github.com/react-native-modal/react-native-modal#the-modal-flashes-in-a-weird-way-when-animating
Other than that, I like the solution as presented. The performance issues I experienced are caused by unnecessary OptionRow re-renders and can be fixed by modifying the memo() areEqual like so...
https://github.com/Expensify/Expensify.cash/blob/ed64a9d59b84e7d0107287ff4e5fbefc40dd1b81/src/pages/home/sidebar/OptionRow.js#L160-L195
Maybe there is something else to look into but so far this seems to resolve things for me even with many many chats in the list so perhaps we can incorporate the above changes for now.

@marcaaron  @yuwenmemon
I have patched the following things for now

Added useNativeDriver for android only.
Removed the if condition here as it destroys the node on the route change thus no exit animations for the new Group Page.
https://github.com/Expensify/Expensify.cash/pull/1367/files#diff-1407d7e65cda4bcbcccbdfc4ee27d5950ea06bf3a94a153ce3eccf1a08c222e9

@marcaaron Let me know if this is what you want. Thanks

@parasharrajat left a couple more comments and you have conflicts to fix. overall solution looks good to me.

Updated

@stitesExpensify @yuwenmemon feel free to give this a review/test.


feat: add vpc_enable variable

Hello,
I added a variable that allows to disable vpc-baseline submodule. We use the default VPC and we can't just wipe out the route table and NACL.
Also regarding the aws documentation it should be enough to enable the flow log only for packet rejects and the traffic_type is hardcoded to ALL in the submodule.
Thank you for publishing this module, it really helped a lot with setting up the alarms required by CIS benchmark.

LGTM, thank you!


Major refactors

Add tests for self evaluation local functions
Add IIFE documentation
Fix internal bundled module name collisions by making the script tag type module
Account for scenario where import has no exports, like an IIFE. No need to track internally
Make as prop optional, so IIFE Imports don't require a alias
Tests restructure & resilience refactor

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2b95a89) 96.50% compared to head (4154881) 96.52%.
 Consider uploading reports for the commit 354cf7e to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##               main       #5      +/-   ##
============================================
+ Coverage     96.50%   96.52%   +0.02%
  Complexity       29       29
============================================
  Files             5        5
  Lines           143      144       +1
============================================
+ Hits            138      139       +1
  Misses            5        5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Markdoc error after install

Hi
Ive just done a fresh install and after cloning and doing a pnpm i i get this error:
9:20:07 AM [vite] Error when evaluating SSR module /home/bronze/coding/astro-ink/astro.config.mjs: failed to import "@astrojs/markdoc"

09:20:07 AM [astro] Unable to load /home/bronze/coding/astro-ink/astro.config.mjs

 error   The requested module 'astro/assets' does not provide an export named 'emitESMImage'
file:///home/bronze/coding/astro-ink/node_modules/.pnpm/@astrojs+markdoc@0.1.0_astro@2.1.0_react@18.2.0/node_modules/@astrojs/markdoc/dist/index.js:5
import { emitESMImage } from "astro/assets";
         ^^^^^^^^^^^^
SyntaxError: The requested module 'astro/assets' does not provide an export named 'emitESMImage'
    at ModuleJob._instantiate (node:internal/modules/esm/module_job:124:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:190:5)

I only managed to run the dev server after i commented out the import markdoc from "@astrojs/markdoc"; line at https://github.com/one-aalam/astro-ink/blob/main/astro.config.mjs#L9

Apologies for the trouble @bronze. There seems to be an issue with Markdoc integration and Astro's latest Vercel server builds - https://github.com/one-aalam/astro-ink/blob/main/astro.config.mjs#L38. I'm trying to find out a fix, if it doesn't works I'll disable the support of Markdoc for now.

Hey man no trouble! Just opened this to give you a heads up. :)
Thank you for your work on this!


General refactor mainly focused in DIC and lazy loading

Apply state pattern on bootstrap to separate Global store and Local store state
Add CMP Facade exposing use case methods and also a command consumer to be complaint with IAB
Add Dependency Containers by state adding feature of lazy loading and eager loading
Unify Object Oriented paradigm, we use FP only in some justified cases
Fix all tests

Codecov Report

Merging #27 into feature/develop-v1.0.0 will decrease coverage by 1.42%.
The diff coverage is 92.09%.

@@                    Coverage Diff                     @@
##           feature/develop-v1.0.0      #27      +/-   ##
==========================================================
- Coverage                   97.95%   96.53%   -1.43%
==========================================================
  Files                          31       30       -1
  Lines                        1225     1241      +16
  Branches                      115      108       -7
==========================================================
- Hits                         1200     1198       -2
- Misses                         25       43      +18

Impacted Files
Coverage Δ

...mp/application/services/GetConsentStatusUseCase.js
100% <ø> (ø)

...p/application/services/SetVendorConsentsUseCase.js
100% <ø> (ø)

...c/cmp/application/services/GetVendorListUseCase.js
100% <ø> (ø)

src/cmp/application/services/PingUseCase.js
100% <ø> (ø)

src/cmp/application/services/commandConsumer.js
100% <100%> (ø)

...p/application/services/GetVendorConsentsUseCase.js
100% <100%> (ø)

.../cmp/application/services/GetConsentDataUseCase.js
100% <100%> (ø)

...p/infrastructure/controller/IframeCommunication.js
100% <100%> (ø)

src/cmp/application/Cmp.js
89.18% <86.2%> (ø)

...p/infrastructure/container/BaseConsentContainer.js
82.85% <89.02%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24895d6...a9399ad. Read the comment docs.


[Bug] doris 外部数据源 链接presto 类型映射不支持varch

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
doris-1.2.4-1
What's Wrong?
doris-1.2.4-1 新功能增加链接presto外部数据源测试
trino版本 trino-412，对接数据源是mysql，然后库tpch表customer，在doris上查询 varchar字段出现UNSUPPORTED_TYPE

What You Expected?
希望改掉这个bug
How to Reproduce?
No response
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello, this bug occurred because our original trino only tested hive sources, not mysql. I have fixed it and it will be released in version 1.2.5


Add /workflows REST API

This improves latency of typical operations including digdag workflows
command.

@danielnorberg PTAL


shortened IDN URLs unable to open - stored wrong (with %) in database (Firefox)

Reproducible Bug Summary

Shorten any IDN URL, like www.tübingen.de
output is: "http://t%c3%bcbingen.de added to database"
open short link with Firefox (!) e.g.: http://siwik.de/go/s8z5
Site-Loading error occurs (server not found), but URL is displayed correctly in address field. Must press ENTER, then website will be loaded.
Bug only occurs (only?) with Firefox. Tested with Chrome and Opera - will work. Probably Chrome and Opera just opens everything what looks like a domain (well done,tho).

This is a bug because...
The IDN could be stored "correctly" in the database,
not http://t%c3%bcbingen.de
but http://tübingen.de (or to be "safe" the resolved pendant blah-b-.de)
I installed the IDN plugin but this only seems to be useful if YOURLS is hosted ON AN IDN. But not for IDNs to be shortened.
Technical details

YOURLS version: 1.7
PHP version: 5.3.28
MySQL 5.5.35
Firefox 33.1
Opera 12.17
Chrome 38.0.2125.111 m

....and by the way some credits to OZH for this/his great work.

Got the same issue in IE 11

Same issue with Firefox 36.0.1. The links work perfectly fine with Chrome though.
Also tested in Android Web browser, but the shortened link does not redirect to the long url properly either.
(Weird thing though is that it's a near-perfect copy of a working existing copy of a site running YOURLs, with only the relevant variables and values changed.)

Hey, I got issues with all browser and got my site hosted at µ.domain.de. Yourls fails all the time.
You need to open ./includes/functions.php and edit the function yourls_get_request() after $root being set:
$root = idn_to_ascii($root);
$serverhost = idn_to_ascii($_SERVER['HOST']);
$request = str_replace($root . "/", '', $serverhost . $_SERVER['REQUEST_URI']);

I really don't like the coding style and the fact that I cannot use idn_to_utf8(). But this project seems abandoned. Shouldn't we fork it?

Sure, go ahead :)

I have a similar issue; if I set the site URL as xn--6ca.ninja it works, and even http://æ.ninja/1 works, but if I set the site URL to æ.ninja, it redirects to front page. The only downside of using it the functional way is that it doesn't output the URL with the unicode character, so you have to manually replace the IDN value with the special character if you want the effect. Happy to PR this if it helps...

@aendrew aren't you mixing up 2 things: shortening an IDN domain, and using YOURLS on an IDN domain ?

@ozh Oh! Indeed I am. Should I open a new issue?

Closing this particular issue - duplicate of the well known funky char encoding issue


PMID:24947517 NTR:

Increased localization to septum during vegetative growth
descendant of:
FYPO:0004655	increased protein localization to cell division site

use FYPO:0003337 - it's defined as vegetative (text and xp)


Update durable-functions-unit-testing.md

Removed references to TraceWriter and changed to use ILogger as per the linked code sample

@kzhen : Thanks for your contribution! The author(s) have been notified to review your proposed change. @kadimitr

#assign:kadimitr

kadimitr is not a valid GitHub ID, or is not a collaborator on this repo.

@ggailey777 - it doesn't look like that's a valid GitHub user associated with this repo.  I'm assigning to @jpconnock . (can you review the PR or reassign it?) thanks.

#reassign:ggailey777

#sign-off

@ggailey777: I'm sorry - only the author of this article, @kadimitr, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

I made myself the owner of this article in the private repo. Please merge this PR.


Warning "TODO: variable is assigned but never used (ABAP cleaner)" is simply not true! ;-)

Hey,
I've just got the warning "TODO: variable is assigned but never used (ABAP cleaner)" re one variable (ls_pm_b_iloa) that I use just a couple of lines further in MOVE-CORRESPONDING:

Do I miss something here?
Thanks!
Regards,
Vlad

Hi Vlad,
hm, my impression is that this comment is somehow a leftover of earlier cleanup runs (and maybe it was true at that point, before the MOVE-CORRESPONDING line was added?): These TODOs are only generated above declaration lines, so I'd suppose this initially read SELECT SINGLE ... INTO @DATA(ls_pm_b_iloa) ..., but then the inline declaration was manually changed to an upfront declaration.
With an inline declaration, ABAP cleaner (at least in its current version) would remove the TODO:

and otherwise, the TODO is not introduced anymore with the MOVE-CORRESPONDING line:

Maybe you could check that. In any case, the question remains whether ABAP cleaner should nevertheless look for such leftover TODOs and clean them away, even if they are no more located above declaration lines.
Kind regards,
Jörg-Michael

Hi JM
and thanks for the weekend-reply ;-)
If it's a leftover it was a sticky one: Even after a few logoffs from & logins into the developer-system, a couple of Eclipse restarts, a shut-down over the night, a reboot of my Mac this morning AND further development (= ABAP cleaner runs, compilations and transports) the TODO-comment line was still there.
It finally disappeared only after I manually deleted it.
After this running ABAP cleaner didn't resurrect ;-) it.
I'm naturally happy with the end-result now.
Nevertheless I think that it must be a bug: The comment shouldn't persist after a new ABAP cleaner run IMHO.
What do you think?
Thanks again!
Regards,
Vlad

Hi Vlad,
well, this has nothing to do with logins or restarts, because the TODO comment is not dynamically displayed or stored in some kind of buffer – it is really inserted into the code. However, cleaning it away definitely makes sense, so I just added this to the implementation.
Kind regards,
Jörg-Michael

Hi Vlad,
thanks again for reporting this – with version 1.13.2, which was just released, ABAP cleaner should now clean up obsolete comments, even if they have become detached from declaration statements (for whatever reason).
Kind regards,
Jörg-Michael


How to get user timeline ?

How can I get the user timeline feed ?
Doing this:
    const timeline = ig.feed.timeline('cold_start_fetch'); let items = timeline.items();
returns nothing
Is this a bug ?

Is this a bug ?

No, this is the Promise.


Check if cached connection can support more pub/subs before reusing

Hello,
A single connection can only support 255 publishers or consumers, given that the publisherId is an 8 bit integer.
https://github.com/rabbitmq/rabbitmq-server/blob/main/deps/rabbitmq_stream/docs/PROTOCOL.adoc#declarepublisher
Other libraries like Go and Java create a new connection when this limit is reached: https://groups.google.com/g/rabbitmq-users/c/MQ-Bub3q13c/m/9-3cKfpbAAAJ
The issue with the current implementation is that the cached connection is always used when creating publishers, and this means that on the 256th publisher, it will crash because the publisherId of 256 won't fit into the 8 bit slot.
In this PR, we check to see if a connection can first support an additional publisher. If not, we create a new connection.
This would be a first-stab implementation. Please let me know any shortcomings and would be happy to fix.

Hey @tarzacodes, apologies, I have since reevaluated our usage of RabbitMQ and may go in a different direction. So I'm afraid I can no longer give this PR the care it deserves. I will close it in the meantime and perhaps it can serve as a reference to anyone else encountering this issue.


Fix listener migration & #937 exception

Adds type parameters when migrating ProviderListener to ref.listen
Checks for null to prevent #937 exception
Improves test output to contain diff when tests fail, so it is easier to develop the migration code.
@rrousselGit Can you take a look at this when you have time?
@creativecreatorormaybenot Not sure if this will fix your problem of not finding anything to migrate, but it does get rid of the exception you saw in #937

Will definitely retry once this has landed 🚀

LGTM


[BUG] added zeros to my symbols

Hi,
I am writting a code generation libary where i use your libary to write my data into object files.
As i debugged another error and looked at my disassemblys i found a bunch of unexppected zeros in my object file.  Which are sometimes there but sometimes aren't.
I don't know if it's an error in my libary but i logged the values and they seem alright when i log them.
Bye
Cr0a3

I'll need a way to reproduce the problem. Note that it is normal to have zeroes due to alignment padding.

Is the alignment in bytes? So when i give it 0x123456 it appends an empty byte if i specfie as the alignemnt 4?

Padding is inserted before the data that needs to be aligned, not after it.

Ok, thank you.

I'll need a way to reproduce the problem. Note that it is normal to have zeroes due to alignment padding.

Here's the rough code where i use your libary: https://github.com/Cr0a3/ygen/blob/main/src/Obj/wrapper.rs#L168-L287
To test the problem you need to run ./test.bat or these 3 commands (from the root of the repo:
cargo run -p simplelang -- -in="tools/simplelang/example.sl" -o="out.o"
llvm-objdump -d out.o --x86-asm-syntax=intel > dump.asm
gcc out.o

The issue is there only sometimes. Mostly when the add function is on top. The expected data is printed and the data from the object file is in dump.asm.
Sorry for the incovienence

I fixed the bug. It was caused by having invalid relocation offsets in my code. Then llvm-objdump added padding zeros so that most bytes would be a valid instruction


tsconfig paths not respected for styles

So the issue is that the paths setting from the tsconfig.app.json is not respected for style files imports since the cli 1.3.0.
My setup is that I have a module inside of my project, aliased in tsconfig.app.json using:
    ...

    "paths": {
      "@core/*": [
        "./core/*"
      ]
    }

The module consists of various ts and scss files.
The files are imported as:
import { SomeClass } from '@core/module/file';
and for styles as:
@import '~@core/module/styles'; // this fails since 1.3.0
Since<EMAIL_ADDRESS>the styles import of this kind is not working.
Simple reproducible example:
https://github.com/nnixaa/cli-scss-alias-issue/commit/40c33c8db58ae6f9b6c73670f0a16624428d388a
Versions
tested and reproducible on cli 1.3.0, 1.6.2, 1.6.3
tested and works fine on cli 1.2.6, 1.2.7

Repro steps

clone the project https://github.com/nnixaa/cli-scss-alias-issue
run npm start

Observed behavior
ERROR in ./node_modules/css-loader?{"sourceMap":false,"importLoaders":1}!./node_modules/postcss-loader/lib?{"ident":"postcss","sourceMap":false}!./node_modules/sass-loader/lib/loader.js?{"sourceMap":false,"precision":8,"includePaths":[]}!./src/styles.scss
Module build failed:
@import '~@core/module/styles'; // this fails since 1.3.0
^
      File to import not found or unreadable: ~@core/module/styles.
Parent style sheet: stdin
      in /Users/nixa/Development/Sandbox/scss-alias-tsconfig/src/styles.scss (line 2, column 1)
Error:
@import '~@core/module/styles'; // this fails since 1.3.0
^
      File to import not found or unreadable: ~@core/module/styles.
Parent style sheet: stdin
      in /Users/nixa/Development/Sandbox/scss-alias-tsconfig/src/styles.scss (line 2, column 1)
    at options.error (/Users/nixa/Development/Sandbox/scss-alias-tsconfig/node_modules/node-sass/lib/index.js:291:26)
 @ ./src/styles.scss 4:14-191
 @ multi ./src/styles.scss

Desired behavior
Should import styles correctly as per configured paths setting.
Possibly related
https://github.com/angular/angular-cli/issues/8117 (workaround used there fixes the issue)
https://github.com/angular/angular-cli/issues/8036

Any updates/fixes/workaround on this?

Any updates on this?

Same problem

still valid issue

still valid issue. workaround for this is to add this entry in .angular-cli.json
    {
        "apps": [{
            ...
            "stylePreprocessorOptions": {
                "includePaths": [
                    "./app/global-styles"
                ]
            },
            ...
        }]
    }

Do you know if there is a way to make VS Code go to definition(ctrl/cmd + click) still works?
This can fix the build issue, but I am missing go to definition

Any news on this? The workaround does not work for me.
My tsconfig:
"paths": {
    "@projx/components": [
        "projects/projx/components/src/public_api"
    ],
    "@projx/components/*": [
        "projects/projx/components/*"
    ],
    "~@projx/components/themes/default": [
        "projects/projx/components/src/lib/styles/themes/default.scss"
    ]
}

Inside my local SCSS file:
@import '~@projx/components/themes/default';

Still, it doesn't work.

Closing as this is working as intended. TypeScript config paths are meant to work solely for TypeScript.
As suggested above you can use includePaths to shorten your SCSS import.


Support manually in-place authentication token update

As mentioned in #54, the lack of authentication token update mechenism may cause active lease and watch become unusable after the token expire. The solution gave in https://github.com/etcdv3/etcd-client/issues/45#issuecomment-1213260731 does theoretically solved it. However, recreating the client means every LeaseKeeper & Watcher needs to be rebuild. This makes the implementation quite complex.
Since updating token automatically is somehow difficult due to tonic's design (#45), I think updating token manually may be a better solution.
The field token in AuthService is changed to an Arc<Mutex<Option<HeaderValue>>> to support in-place modification and sharing between multiple services. The cost of the Mutex is acceptable since it only involves a clone of a small HeaderValue in every request.
The token update method is temporarily Client::update_auth. I am not sure where to put it since it may not be correspond to any service abstraction.

I think there are 3 ways to add the reauthentication API:

Add a dedicated struct AuthHandle as a field of Client. It should be able to be got by a method of Client, and be cloned like other fields. We can have methods like update_token and remove_token on it.
Add update_token and remove_token to AuthClient. However, this feels weird since XxxClient should only contains certain methods of its rpc service.
Keep the current design (and add remove_token) on Client. But since we need &mut Client everytime updating token, this may not be as flexible as the first solution.

IMO the first one is better since it could makes the reauthenticate easier without affecting other running tasks.

I think there are 3 ways to add the reauthentication API:
1. Add a dedicated struct `AuthHandle` as a field of `Client`. It should be able to be got by a method of `Client`, and be cloned like other fields. We can have methods like `update_token` and `remove_token` on it.

2. Add `update_token` and `remove_token` to `AuthClient`. However, this feels weird since `XxxClient` should only contains certain methods of its rpc service.

3. Keep the current design (and add `remove_token`) on `Client`. But since we need `&mut Client` everytime updating token, this may not be as flexible as the first solution.

IMO the first one is better since it could makes the reauthenticate easier without affecting other running tasks.

I preferred the second.

I preferred the second. Add to AuthClient:
etcd_client::auth_client().update_token(name, password);

The methods in AuthClient correspond one-to-one with the service Auth in protobuf, and all functions involve changes to the cluster configuration.
Therefore, I prefer the first approach, where the method for updating the client token is placed in a separate handler. This ensures the correspondence between XxxClient and the corresponding RPC service

AuthClient is responsible for functions related to authentication

A more accurate description, in my opinion, would be that AuthClient is responsible for modifying and querying authentication information of the cluster. As for the token setting on the client side, I don't think it's appropriate to include them here

AuthClient is responsible for functions related to authentication

A more accurate description, in my opinion, would be that AuthClient is responsible for modifying and querying authentication information of the cluster.

I don't think it's necessary to take the AuthClient's responsibilities too seriously. I don't want to restrict AuthClient to server-side settings and create separate objects for both client-side and server-side.

I have no idea why clippy fails 😅

I have no idea why clippy fails 😅

help: try adding this
|
354 + impl Default for LeaderKey {
355 +     fn default() -> Self {
356 +         Self::new()
357 +     }
358 + }


GPT2 774M weights released!

🚀 Feature
Hi! OpenAI released the 774M weights in GPT2, is it possible to integrate this into pytorch-transformers?
https://twitter.com/OpenAI/status/1163843803884601344
Also, sorry for the obnoxiously quick ask! Thanks for all the great work you do for the community.
Thanks!

I did the following:

Run download_model.py 774 from here
Create a file named config.json with the following contents (Might be correct but I am not super sure):

{
    "vocab_size": 50257,
    "n_ctx": 1024,
    "n_embd": 1280,
    "n_head": 20,
    "n_layer": 36,
    "n_positions": 1024,
    "embd_pdrop":0.1,
    "attn_pdrop": 0.1,
    "resid_pdrop": 0.1,
    "layer_norm_epsilon": 1e-5,
    "initializer_range": 0.02
}

Clone this repo

Run python .\pytorch-transformers\pytorch_transformers\convert_gpt2_checkpoint_to_pytorch.py --gpt2_checkpoint_path models/774M --pytorch_dump_folder_path ./ --gpt2_config_file config.json

Mofiy modeling_gpt2.py to point to your newly generated file by changing GPT2_PRETRAINED_MODEL_ARCHIVE_MAP and GPT2_PRETRAINED_CONFIG_ARCHIVE_MAP (this is the above config.json)

Realize there's no way you can fine-tune this your PC's GPU you need to rent something with more memory.

I tested.
One v100 isn't enough to handle this model.
Maybe only TPU's?
Or 2 V100 more.

We've added it on master.
You can install from source and use the shortcut name gpt2-large to use it (but beware, it's big!)

Question: Will the gpt2-large be added to Write With Transformer? I've been eagerly looking forward to that since the moment the 774M was released!

@zacharymacleod Glad you asked! We're definitely planning on adding it in the near future :)

Seems to me as if this has been addressed via #1064 . Closing the feature request now!


fix:windows file permission

What kind of change does this PR introduce?
a bug fix for windows file permission
Summary

added a retry mechanism (max_retries and retry_delay_seconds) to handle cases where the file deletion fails due to the file being locked or accessed by another process.
you can find do_fastsam function in openadapt/adapters/ultralytics.py
Checklist

[x] My code follows the style guidelines of OpenAdapt
[x] I have performed a self-review of my code
[ ] If applicable, I have added tests to prove my fix is functional/effective
[x] I have linted my code locally prior to submission
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
[ ] New and existing unit tests pass locally with my changes

How can your code be run and tested?
python -m openadapt.replay VisualReplayStrategy --instructions "<your instructions>"

Looks like the build is failling (clck "Details"):
https://github.com/OpenAdaptAI/OpenAdapt/actions/runs/9628215324/job/26557412749?pr=791

Run poetry run black --preview --check . --exclude '/(alembic|\.cache|\.venv|venv|contrib|__pycache__)/'
would reformat /Users/runner/work/OpenAdapt/OpenAdapt/OpenAdapt/openadapt/adapters/ultralytics.py
would reformat /Users/runner/work/OpenAdapt/OpenAdapt/OpenAdapt-2024-06-22_22-43-54/adapters/ultralytics.py

Looks like the build is failling (clck "Details"):
https://github.com/OpenAdaptAI/OpenAdapt/actions/runs/9628215324/job/26557412749?pr=791

```
Run poetry run black --preview --check . --exclude '/(alembic|\.cache|\.venv|venv|contrib|__pycache__)/'
would reformat /Users/runner/work/OpenAdapt/OpenAdapt/OpenAdapt/openadapt/adapters/ultralytics.py
would reformat /Users/runner/work/OpenAdapt/OpenAdapt/OpenAdapt-2024-06-22_22-43-54/adapters/ultralytics.py
```

@abrichr this 5bc685fedcdb7bc44a540d67e90a6f11152e0c40 should fix build issues

Looks like the build is failling (clck "Details"):
https://github.com/OpenAdaptAI/OpenAdapt/actions/runs/9628215324/job/26557412749?pr=791

```
Run poetry run black --preview --check . --exclude '/(alembic|\.cache|\.venv|venv|contrib|__pycache__)/'
would reformat /Users/runner/work/OpenAdapt/OpenAdapt/OpenAdapt/openadapt/adapters/ultralytics.py
would reformat /Users/runner/work/OpenAdapt/OpenAdapt/OpenAdapt-2024-06-22_22-43-54/adapters/ultralytics.py
```

@abrichr this 5bc685fedcdb7bc44a540d67e90a6f11152e0c40 should fix build issues

Looks like the build is failling (clck "Details"):
https://github.com/OpenAdaptAI/OpenAdapt/actions/runs/9628215324/job/26557412749?pr=791

```
Run poetry run black --preview --check . --exclude '/(alembic|\.cache|\.venv|venv|contrib|__pycache__)/'
would reformat /Users/runner/work/OpenAdapt/OpenAdapt/OpenAdapt/openadapt/adapters/ultralytics.py
would reformat /Users/runner/work/OpenAdapt/OpenAdapt/OpenAdapt-2024-06-22_22-43-54/adapters/ultralytics.py
```

@abrichr this 5bc685fedcdb7bc44a540d67e90a6f11152e0c40 should fix build issue


LODs for street assets

The lamposts/plants/other street assets need LODs since we are sprinkling these assets procedurally.

highly recommend checking out https://www.simplygon.com/
the blender plugin is pretty gud


[Feature] Can I convert resnet50 mmcls model to torchvision?

Branch
master branch (0.24 or other 0.x version)
Describe the feature
I trained a resnet50 model in mmcls, can I convert it to torchvision?
Will you implement it?

[ ] I would like to implement this feature and create a PR!

Yes, sure. You can convert your weight to torchvision style, by changing the weight's key. We provide the torchvison2mmcls script, you can refer to writing a reverse script


1.3.0 Fault tolerance is identified as yes,  dolphinscheduler how should the logic be controlled

1.3.0 Fault tolerance is identified as yes,  dolphinscheduler how should the logic be controlled

When I restarted all the services, it was the same,

When the workflow status is submitted successfully, executing, ready to pause, or ready to stop, if the master hangs up,  when the master restarts, the workflow is fault-tolerant, the fault-tolerant flag is YES


added extra properties required for domain creation

added extra properties required for domain creation of Oracle Identity Governance
Signed-off-by: Tanmay<EMAIL_ADDRESS>

Thank you !


Make mark a11y friendly :)

Coverage remained the same at 91.667% when pulling 2f4dc333343024825636525e1a8fa88e63885e93 on a11y into d2a4fe1cbb0604d703b9013fdf9059395245d0be on master.


Service race condition? (Unobserved, but theoretically possible)

There is a possible race condition when a service is deployed, and then a pod or rc that depends on that service is deployed. If the service is not running, the pod/rc may not get the appropriate environment variables.
The solution would be to deploy a service, and then wait until the service is in state RUNNING (?).

see #236

The future of Helm is at kubernetes/helm. Helm Classic is in maintenance mode, so I'm closing this issue.


Any plans for development team to participate at future conferences?

Love the project!
Any plans for the Featuretools team to provide any training at future conferences or host developer sprints?
I would be excited to see this at SciPy 2019 to throw that suggestion out there.

Absolutely!
We already have some talks/training sessions in the works, but if you or anyone has other suggestions send us an email at<EMAIL_ADDRESS>We're thinking through developer sprints now as we've had a few people ask. What did you have in mind for that?

Great to hear!
Here are some ideas for sprints I've seen before:
Beginner/Intermediate level:

Additional tutorials with new features, or update existing tutorials with new features
Additional code example snippets for documentation
General documentation improvement
Address "Good First Issue" bugs
Create additional tests
Answer any Stack Overflow questions or improve responses

Advanced level:

Address any hard bugs/issues
Work on new features
Collaborate with other open source leaders/maintainers to make improvements

To clarify my above comment about SciPy as it might appear that I'm apart of the body of organizers, I'm not, just planning to attend the conference and stay for the sprint days.


Error using DoneInvokeEvent in actions.assign

Bug or feature request?
Bug
Description:
I define an action in machine configuration. The action should be executed after a promise is resolved. The action is defined like this.
    setResult: actions.assign<FetchContext, DoneInvokeEvent<MessageStatus>>((ctx, e) => {

Typescript then give me an error saying that "MyEvent is not assignable to DoneInvokeEvent".
(Bug) Expected result:
Compiles ok!
(Bug) Actual result:
Compilation error
(Bug) Potential fix:
nominal typing?!?
Link to reproduction or proof-of-concept:
Here is a gist with code that shows the problem.

Hi @erizet
Correct me if I am wrong, but wouldn't be the case of just editing in your gist the following line?
type FetchEvent = FetchEventWithMessageId | FetchEventWithMessageStatus | DoneInvokeEvent<MessageStatus>;

Hi @assuncaocharles
Your observation is correct, but I was told to open this issue by @davidkpiano.
This is from our conversation Gitter.

@erizet So, this really needs nominal typings (opaque/unique strings) in TypeScript, but there is a good workaround:
interface MyDoneEvent { type: 'done.invoke'; data: T }
type FetchEvent =
FetchEventWithMessageId
| FetchEventWithMessageStatus
| MyDoneEvent;
// ...
setResult: actions.assign((ctx, e: MyDoneEvent) => {
return { messageStatus: e.data };
}),
We're basically saying that even though the done event is something like 'done.invoke.whatever', we'll coerce it to that specific 'done.invoke' value for now so that the discriminated unions work correctly
Can you open an issue with this? https://github.com/davidkpiano/xstate/issues/new I have a "temp" fix for it so that DoneInvokeEvent works as-is
(using the same fix as above)

Slight problem with that solution is that it doesnt handle multiple, different, done events in a single machine - no idea how to solve this in TS right now though

Slight problem with that solution is that it doesnt handle multiple, different, done events in a single machine - no idea how to solve this in TS right now though

I'm having this constraint right now, and using the union with | DoneInvokeEvent<MessageStatus> makes the events type string , limiting my events types.

Agreed. Having an event like DoneInvokeEvent where the type could be anything makes it super hard to handle the event object in other contexts (for example, analyzing the result of onDone in a guard, or retrieving the event object in a service).
Specifying the dummy type done.invoke makes the type checker happy without any runtime errors. But under the hood, this type isn't actually what appears at runtime. In the future, enforcement of InvokeEvent types would be super helpful!

This is a good use case for a codegen tool to generate the required types. I've got a demo working in this package, albeit buggy.
Introspecting the machine and divining the connections between all of these services and actions would lead to some pretty awesome type inferences. I've added an example output below.
https://gist.github.com/mattpocock/f70734aa596a97355cc30a01bceb2539
Note that you can get perfect typechecking on all the data payloads of done.invoke.<serviceName> by assigning their types in the event type you pass as a generic into Machine. It extracts which events cause which services, so casting (event.data as any) is no longer required.

Just a note (for my reference too), the event is properly inferred inline:

One of the problems is that actions (as well as guards, etc.) defined in the machine options (second arg of createMachine(..., options)) are assumed to occur in any state, which is why we can't safely infer that a DoneInvokeEvent can occur in some arbitrary transition(s) (even though it might be clear in the machine config that it's only used within an invoke block).
Again, not an easy (much less possible) problem to solve without a codegen like what @mattpocock is working on. Explicitly defining what kinds of events an action in option.actions expects is probably the best thing to do here.
Alternatively, you can define the assign action inline. It's already serializable there.

I have the actions written in a diff obj, I opted to not use assign<Context, Event>({}) but just inline the event assign<Context, DoneInvokeEvent<...>>({}) in the case of DoneInvokeEvent, callback also has like a nicer interface than invoke Promise, as it just raises an event, and its all cake from there.

Closing this as Typegen has since been introduced to resolve typing issues like these.


Tracking not working

Tracking doesnt seem to be working. It can find matching titles from kavita but upon clicking it will show the error below.

Thanks for your report. I'll take a look for it.

Sorry for late. I've been busy in the meantime.
Kavya Tracker was updated to 1.0.0 and the issue was resolved.

Awesome. Thank you!


1.17v 6.0.0

Whenever enabled, the console is spammed with the number 1 once per line. https://paste.ee/p/qeWGd

Oops! Left my debug code in!

Ah it is your code okay. Was just looking around to see if I could find it.

is there going to be a patch for this soon?

Yes, along with other optimisations.

Yes, along with other optimisations.

So, what exactly is being published in CurseForge as "LightOverlay 6.0.1 for MC 1.17.1"? I couldnt find a the 6.0.1 commit in the repository. Are the CurseForge releases for 1.17.1 coming from your 1.16.2 branch? Does it include the commit 5b36cf6b846515145dc1f93e4f8e9ea108420090 ? It's a bit hard to match CureForge releases andcommits without some repository tags.


make $inserted work

Right now, $inserted doesn't seem to fire when its RHS is being can-imported.  Perhaps it fires but the thing being can-imported hasn't resolved, yet?
In this example, *animations.customFadeIn doesn't run
<can-import
	from="can-stache-animate/demos/inserted-animations"
	{^value.animations}="*animations"
/>

...but in the following example, handleInserted does run (it's on the viewModel).  See the inserted demo

So, this works:
<can-import from="can-stache-animate/demos/inserted-animations"
 {^value.animations}="*animations" />
{{#*animations}}

{{/*animations}}

..but it would be really nice if we didn't have to do that.

Probably the best way around this would be to either do the above ({{#*animations}}) or register helpers for the animations that you want to use for inserted:
import canStacheAnimate from 'can-stache-animate';
import stache from 'can-stache';

export default Component.extend({
  ...
  helpers:{
    fadeIn: canStacheAnimate.animations.fadeIn
  }
});

Alternative:
It could be nice to register all of the animations under an animations object on the stache helpers
stache.registerHelper("animations", canStacheAnimate.animations);

..in order for that to work, we would need to use get (or similar) in can-stache/helpers/core's getHelper method (here)
..I'll create another issue for that