Catch all route

Is there a way to add a catch all route that deals with every request that doesn't match one of the other specified routes.
 I will try to get it to work that way.

It works, I did it this way:
try
{
    $response = $dispatcher->dispatch(
        $request->getMethod(),
        $request->getPathInfo()
    );

    $response->send();
}
catch(NotFoundException $exception)
{
    // handles everything else, e.g. POST /foo
    $response = new Response;

    // do whatever

    $response->send();
}

Rubber ducking with a github issue. 👌

@felixkiss yes, that's how I do it currently, considering building a strategy that will handle that but nothing confirmed yet.

Can this be re-opened. I am interested in this as well. Converting existing app to SPA and need to route all requests to the SPA now.

@patrickheeney The main problem here is for us to assume how the user will want to deal with this. I have a few things planned for v2 which will take these considerations in to account but some solid code examples from such as yourself for exact use cases would be helpful.

@philipobenito Here are some suggestions:
Laravel way:
Route::any('(.*)', function($page) {
    dd($page);
});

Or
Route::any('(:any)/(:all?)', function($first, $rest=''){
    $page = $rest ? "{$first}/{$rest}" : $first;
    dd($page);
});

Maybe something event related? Catch a RouteNotMatched route and be able to easily forward the call onto another route?
Maybe a catch-all strategy that only gets called after routes do not match in a last attempt to get a response?

To give you some more context, here are a few others:
Symfony, More
catch_all:
    path:     /{catchall}
    defaults:
        _controller: YourProjectBundle:Index:catchAll
    requirements:
        catchall: ".+"

Klein
*                    // Match all request URIs
[*]                  // Catch all (lazy)
[*:trailing]         // Catch all as 'trailing' (lazy)
[**:trailing]        // Catch all (possessive - will match the rest of the URI)

$klein->respond('*', function ($request, $response, $service) { $service->render('header.phtml'); });

Aurora
$router->add('catchall', '{/controller,action,id}')
    ->addValues(array(
        'controller' => 'default',
        'action' => 'index',
        'id' => null,
    ));

My problem is that whilst I do see a use case, I don't necessarily see a "good" use case if that makes sense?
You could actually achieve this via a pattern matcher and a regular expression (http://route.thephpleague.com/wildcard-routes/). I'm just not sure that I'd personally recommend it. I'd be happy to change my view though if somebody can give me a good reason why this is useful other than "It's easier" which have been the only reasons I've been given for it so far.

@patrickheeney sorry, only just seen your first comment with use cases, will ponder it and get back to you.

@philipobenito In that case, maybe all we need is some documentation? I first searched there and then eventually lead to here. OP seemed to have the same issue.
Some follow up questions after looking at wildcard routes:

How should we format the regex to have it match everything?
I'd like to add the regex right into the route without the pattern matcher, but is this possible?
How do we ensure the catch all runs last? If we have various parts of the systems adding routes via the DI, we can't guarantee the order they are defined in. We would need a sort order or something to say this route should run after all the others.

I personally don't care how it is implemented (or if it already is), just looking for an easy expressive way to define a catch-all route. I can't speak for everyone else, but I believe every router I have looked at so far has implemented this because there must be a use case for it.
I think the ability to add our own logic in here would be suitable. Maybe something like this:
protected function handleNotFound()
    {
        if ($this->getStrategy()->handles('NotFound') {
            return $this->getStrategy()->handle('NotFound');
        }

        throw new NotFoundException;
    }

That way the strategy can take care of handling the exception and the RestfulStrategy would no longer be hard-coded into the Dispatcher. We could then add our own CatchAll strategy which throws a NotFoundException after we have performed some custom logic. It wouldn't effect the router at all. This needs more then a few seconds thought, but that is what initially appeals to me.

So how about this, strategies could expose not only the dispatch method but how to handle not found and not allowed? That would allow you to catch and do whatever you like. This is something I'd definitely be interested in doing.
As for the regex, yes you can define directly in the route, something like this should suffice /{any:(.*)}.
As for running the catch all last, that's not how the matching works in FastRoute (underlying library from), it pulls matches out of a larger regular expression, this is why it's fast and this is why it's not as simple as with most routers to provide a catch all. Also the idea of running it last would suggest it is not actually a catch all but a catch everything else, this has to be specific as if I were to implement it there would have to be that distinction. However, catch everything but would also be possible by building a regular expresion to ignore the matches that you need to define separately.
Again, because other routers implement this is not for me the best reason to implement it here. Defining your routes explicitly is good practice, but I understand from your perspective of a SAP that it's a little different.
What I think is the best way forward with this is for v2 (being developed now with the same functionality but depending on PSR-7 instead of a concrete implementation of Symfony Http Foundation and a few small additions) is to expose the behaviour around not found and not allowed to the Strategy with a default behaviour of allowing the exceptions to bubble out. This would easily allow you to build a SAP Strategy, or for me to even include one in the package.

I think it sounds like a great plan. As there is a distinction between catch-all and catch-everything-else, I think you covered the use case for the former.
Should anything be done about the latter? Or should we do like the OP and catch the NotFound exception and handle it however we need. The alternative would probably be a way to $router->addStrategy(new NotFoundStrategy, [Interface:NOTFOUND]); so that you can bind strategies but only for certain criteria?

Oh I get that, long day that's all, if I ever sound a little to the point it's usually because I'm quite busy, never mean anything by it, massively appreciative of all discussion.
As for the catch-everything-else situation, I think by exposing the not found functionality to a strategy this could be handled quite elegantly with a custom strategy without the need for any exception catching in the front controller/bootstrap.
I think by doing that we are essentially making the router completely extensible but with a few defaults thrown in there for the 99%ers.

As for the regex, yes you can define directly in the route, something like this should suffice /{any:(.*)}.

$route->map('GET', '/{any:(.*)}', 'FOUROHFOURController::FOUROHFOUR');
Fatal error: Uncaught exception 'FastRoute\BadRouteException' with message 'Regex "(.*)" for parameter "any" contains a capturing group'

Where can I find the documentation for things like $request->getMethod() and $request->getPathInfo() ?

As for the regex, yes you can define directly in the route, something like this should suffice /{any:(.*)}.

$route->map('GET', '/{any:(.*)}', 'FOUROHFOURController::FOUROHFOUR');
Fatal error: Uncaught exception 'FastRoute\BadRouteException' with message 'Regex "(.*)" for parameter "any" contains a capturing group'

Came here by search, and although it's an old closed issue, I think it might help other people too. This does work for catching all routes when using FastRoute:
$route->map('GET', '/{any:.*}', 'FOUROHFOURController::FOUROHFOUR');


merge from template-arlac77-github

.github/workflows/codeql_analysis.yml

chore: add 16.13.1 (jobs.analyze.steps.with.node-version)

:tada: This PR is included in version 1.10.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Change hash serialization to native redis hash

For more details check this comment:
https://github.com/davydovanton/sidekiq-history/pull/26#issuecomment-117247351

closed by #33


Connection via usb

Hi there! I'd like to suggest you consider the possibility of adding usb connection feature to Macro Deck. I had to configure an adb server in order to use it via usb but it has an issue: pc connection gets very slow because it creates an extra network which consumes a large amount of data because it uses a tethering. It kinda makes it impossible to stream if you don't have at least a 500 Mbits of band plan. My plan is 100 Mbits and it delivers about 30Mbits of upload 99% of the time. With Macro Deck using tethering in order to work via usb it slows donw to 3 Mbits of upload and 10Mbits of download. Macro Deck should implement usb connection. It's much better than wi-fi connection. As a comparison Deckboard has usb connection and I use it without loss of network speed on pc because it does not create extra network and does not need tethering in order to work. So I have to use only Deckboard which is a pity because I'd like to use Macro Deck.
I really hope Macro Deck implements this feature in next update(s) even if you consider charge a few dollars for it. I paid $20 for Deckboard Pro and I'd pay something around this value for this extra feature on Macro Deck too.
Cheers!

There is a USB connection on Macro Deck.

how do you connect via usb?

Actually there's not a real usb connection. By the way, the MD developer himself told me that the software does not have usb feature but he is working on it for the next versions. As I said in my previous message, I can connect via usb but not directly. I have to create a tethering usb connection which creates a network between the mobile and the computer. It was slowing down my pc Internet speed. I found out this was happening because my pc was using the mobile network instead of its own network board. I solved the problem setting its network as primary.

how do you connect via usb?

You have to activate the usb debug and usb tethering in order to create a network between pc and mobile. In order to avoid that your pc slows down Internet speed, maybe you have to configure its own network as primary. I'm gonna try to show you how although I'm from Brazil and I'm not sure what are the features name in English. Try following this simple steps:

Press Window Key on your pc keyboard;
Type network and see weather it shows something like "Show network connection". You may try the full name too;
Click on the showed option;
Right click the your pc correct network board Ethernet connection;
Click on Properties;
Search, in the list, "IP protocol Version 4 (TCP /IPv4)" and click it;
Click the Properties button;
Click the advanced button;
Uncheck the last option "Automatic metric" and type 10 in the field right below it.
Click OK

This might solve the Internet slow speed.


webassets wrong version

https://github.com/miracle2k/django-assets/blob/master/django_assets/__init__.py#L9 staters that the version must be 0.11 but the current version is 0.11.1 this causes py.test to fail with:
File "/home/vagrant/.virtualenvs/primarysite/bin/py.test", line 9, in
load_entry_point('pytest==2.7.2', 'console_scripts', 'py.test')()
File "/home/vagrant/.virtualenvs/primarysite/local/lib/python2.7/site-packages/_pytest/config.py", line 32, in main
config = _prepareconfig(args, plugins)
File "/home/vagrant/.virtualenvs/primarysite/local/lib/python2.7/site-packages/_pytest/config.py", line 85, in _prepareconfig
pluginmanager=pluginmanager, args=args)
File "/home/vagrant/.virtualenvs/primarysite/local/lib/python2.7/site-packages/_pytest/core.py", line 521, in call
return self._docall(self.methods, kwargs)
File "/home/vagrant/.virtualenvs/primarysite/local/lib/python2.7/site-packages/_pytest/core.py", line 528, in _docall
firstresult=self.firstresult).execute()
File "/home/vagrant/.virtualenvs/primarysite/local/lib/python2.7/site-packages/_pytest/core.py", line 393, in execute
return wrapped_call(method(*args), self.execute)
File "/home/vagrant/.virtualenvs/primarysite/local/lib/python2.7/site-packages/_pytest/core.py", line 109, in wrapped_call
wrap_controller.send(call_outcome)
File "/home/vagrant/.virtualenvs/primarysite/local/lib/python2.7/site-packages/_pytest/helpconfig.py", line 28, in pytest_cmdline_parse
config = outcome.get_result()
File "/home/vagrant/.virtualenvs/primarysite/local/lib/python2.7/site-packages/_pytest/core.py", line 138, in get_result
py.builtin._reraise(*ex)
File "/home/vagrant/.virtualenvs/primarysite/local/lib/python2.7/site-packages/_pytest/core.py", line 123, in init
self.result = func()
File "/home/vagrant/.virtualenvs/primarysite/local/lib/python2.7/site-packages/_pytest/core.py", line 394, in execute
res = method(*args)
File "/home/vagrant/.virtualenvs/primarysite/local/lib/python2.7/site-packages/_pytest/config.py", line 636, in pytest_cmdline_parse
self.parse(args)
File "/home/vagrant/.virtualenvs/primarysite/local/lib/python2.7/site-packages/_pytest/config.py", line 746, in parse
self._preparse(args)
File "/home/vagrant/.virtualenvs/primarysite/local/lib/python2.7/site-packages/_pytest/config.py", line 713, in _preparse
self.pluginmanager.consider_setuptools_entrypoints()
File "/home/vagrant/.virtualenvs/primarysite/local/lib/python2.7/site-packages/_pytest/core.py", line 278, in consider_setuptools_entrypoints
plugin = ep.load()
File "/home/vagrant/.virtualenvs/primarysite/local/lib/python2.7/site-packages/pkg_resources/init.py", line 2338, in load
self.require(*args, **kwargs)
File "/home/vagrant/.virtualenvs/primarysite/local/lib/python2.7/site-packages/pkg_resources/init.py", line 2355, in require
items = working_set.resolve(reqs, env, installer)
File "/home/vagrant/.virtualenvs/primarysite/local/lib/python2.7/site-packages/pkg_resources/init.py", line 832, in resolve
raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.VersionConflict: (webassets 0.11.1 (/home/vagrant/.virtualenvs/primarysite/lib/python2.7/site-packages), Requirement.parse('webassets==0.11'))

I believe this should fix it.

Will this fix be released soon? Thanks!


Update update-intro.html

A quotation is missing at the end of the command

There is already a PR https://github.com/kubernetes/website/pull/40484 which is addressing the same issue.

Duplicated by PR https://github.com/kubernetes/website/pull/40484
/triage duplicate


Update the api because in my opinion PROCESSING is not a closed delivery.

I have modified this file because status PROCESSING is not delivered. I was missing my current delivery, I saw it by closed_delivery because of the status change. Only status PICKED_UP should in my opinion be closed delivery.

Agree. As my order wasn't on the way yet, I wasn't sure what the term would be :)


As a CIF user, I want to validate email as a unique identifier of a contact, so that I don't duplicate contact information

Description:
Wireframe:
Use of email address as a unique identifier for each contact so as to not have repetition or duplicate contacts. This can enable user to know if they've previously entered the information, by a error message below the field.
Acceptance Criteria:
Given I am a CIF Project Coordinator
And I am entering contact information on the contact form
When I am entering a contact email
And it already exists in the system
Then an error message is displayed
Given I am a CIF Project Coordinator
And I am editing contact information on the contact form
When I am updating a contact email
And it already exists in the system
Then an error message is displayed
Development Checklist:

[ ] Validation on email address - This can be done in the same way we validate the uniqueness of the proposal reference (using the isUniqueValue('email') computed column on the contact form_change record)
[ ] Warning message if email address exists in system
[ ] Meets the DOD

Notes:

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[x] User story is included
[x] User role and type are identified
[x] Acceptance criteria are included
[x] Wireframes are included (if required)
[x] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

This

Hey team! Please add your planning poker estimate with ZenHub @BCerki @dleard @gurjmatharu @mikevespi @pbastia @Sepehr-Sobhani

Updated priority to high as this user story should be completed before soft launch to support initial data entry of project information.


JVM hangs on Mac OS X while profiling

I built the profiler from source after installing unittest-cpp from source and specifying the library to link as well as the include directories. I don't think I got any errors from the maven or the underlying make invocation. I got the liblagent dynamic library as expected in my builds directory. I then started my jvm like this:
java -agentpath:/Users/rajiv/honest-profiler/build/liblagent.dylib -jar ~/Downloads/perftest.jar
It says start and then just keeps there forever consuming a ton of cpu till I kill it.
So something like this:
Rajivs-MacBook-Pro:build rajiv$ java -agentpath:/Users/rajiv/honest-profiler/build/liblagent.dylib -jar ~/Downloads/perftest.jar
Start

My application prints something to the standard line as soon as it starts and I don't see any of that being printed either.

I used the Oracle jdk 1.8 when compiling both honest profiler and my own jar.

Sorry this is the wrong project.


[WIP] dts: Make generation for clocks consistent with other phandle-array properties

Working on removing the special-casing for clocks in the code.

Might be done now. Just needs some cleaning up.

Replaced with https://github.com/zephyrproject-rtos/zephyr/pull/21506.


[Exploratory] Capture good assertion messages.

This just is a quick spike exploring the best way to capture assertion messages.
The only place this does not work great is for wrapOnlyPatterns, since you can end up with a situation where powerAssertContext does not exist even though the args has elements that do not stringify well.
@twada - What do you think about moving this logic into empower-core? Auto populating event.computedMessage or similar?
Maybe we can offer a standard way to map wrapOnlyPatterns to messages?
{
  wrapOnlyPatterns: {
    't.throws(fn, [message])': {
       defaultMessage: 'should throw'
    },
    't.doesNotThrow(fn, [message]': {
        defaultMessage: 'should not throw'
    }
  }
}

// ...

function onAssert(event) {
  var message;
  if (event.enhanced === false) {
     message = event.defaultMessage
  }
}

What do you think about moving this logic into empower-core? Auto populating event.computedMessage or similar?

:+1: The less custom code in AVA dealing with this the better :)

What do you think about moving this logic into empower-core? Auto populating event.computedMessage or similar?
Maybe we can offer a standard way to map wrapOnlyPatterns to messages?

@twada :arrow_up: Any thoughts?

@sindresorhus @jamestalmage Sorry for my late response. I'm a little busy these days.

What do you think about moving this logic into empower-core? Auto populating event.computedMessage or similar?
Maybe we can offer a standard way to map wrapOnlyPatterns to messages?

Sure! Please send a pull-req to empower-core > @jamestalmage
For wrapOnlyPatterns, I do not want to change container type from Array to Object.
So I prefer
  wrapOnlyPatterns: [
    {
      pattern: 't.throws(fn, [message])',
      defaultMessage: 'should throw'
    },
    {
      pattern: 't.doesNotThrow(fn, [message]',
      defaultMessage: 'should not throw'
    }
  ]

to
  wrapOnlyPatterns: {
    't.throws(fn, [message])': {
       defaultMessage: 'should throw'
    },
    't.doesNotThrow(fn, [message]': {
        defaultMessage: 'should not throw'
    }
  }

@jamestalmage Can this be resolved now that empower-core is updated?

Yep. Relevant changes to empower-core are here

Sorry about pinging you all over the place @jamestalmage, but trying to clean up some long-running PR/issues. What's the next step with this PR? Not saying it should be fixed right now. Just would be useful to know the path forward.

No worries!
The issue here would be building up TAP output that would actually show these assertion messages. I think I would like to get a couple other things done first:

Bring our tap output more inline with node-tap. Specifically, the yaml output for our errors. This should make the output from all the tap-mocha-reporters much nicer. For example, our errors currently have expected and actual properties, but the tap reporters prefer found and wanted (A bit odd in the JS world, but TAP has it's roots in other programming languages - Perl mostly I think).

Integrate clean-yaml-object over serialize-error. I think it will help with 1. Advantages over serialize-error are pretty printing of Buffers, removes large objects attached to some Errors by Domains and EventEmitters, and a few others. I extracted it from node-tap, but haven't gotten around to integrating it.

Use tap-emitter. That's really early stages right now. The next step is creating a good way to print subtests. I would love for that to also end up being code shared with node-tap, but that won't be as straightforward as clean-yaml-object or stack-utils were (since it's not directly extracted from node-tap in the first place).

Thanks for the update. Solid plan.

For example, our errors currently have expected and actual properties, but the tap reporters prefer found and wanted

Tape uses actual/expect, so I always assumed that was correct. Doesn't really matter either way. Better to be as compatible with node-tap output as possible.

I would love for that to also end up being code shared with node-tap, but that won't be as straightforward as clean-yaml-object or stack-utils were (since it's not directly extracted from node-tap in the first place).

Awesome that we can share some code with node-tap. Improving those libs will improve both test runners. Hopefully we can share even more code in the future.

Yeah sure - I'll file a couple issues on tap-emitter for where I think it should go and we can bikshed there.

RE: actual/expected
Neither is technically "right". The contents of TAPs yaml output is completely unspecified as far as I know. As I recall the fancy mocha style diffs only print when using found / wanted. Maybe it would be better to hunt down where that happens and file a PR so it could use either (i.e. prefer the current properties, but fallback to actual/expected).

Relevant:
https://github.com/isaacs/testanything.github.io/blob/tap14/tap-version-14-specification.md

It's confusing. The v14 draft has examples with both wanted/found and expected/got and expect/got.
// @isaacs

Should we track the remaining work in some issues rather than this PR?

@jamestalmage perhaps you could open issues to track remaining work, and then close this PR?

Closing as this will never be merged and remaining todo's are tracked in #723


Update v0.3.x to v1.0.x

Important: This PR currently targets base-0.3-and-1.0 branch, which is currently identical to release-0.3. This way we can see how it looks like when we upgrade v0.3.x to v1.0.x, but we don't modify the release-0.3 branch. After merging this PR, we will just merge base-0.3-and-1.0 into master.
This PR:

Adds v1alpha4 and v1beta1 API types
Changes Helm charts structure so they are all in helm/cluster-api/templates to match current structure from release-1.0.

Testing
Description on how cluster-api-app can be tested.

[ ] fresh install works

[ ] AWS
[ ] Azure
[ ] OpenStack

[ ] upgrade from previous version works

[ ] AWS
[ ] Azure
[ ] OpenStack

Other testing
Description of features to additionally test for cluster-api-app installations.

[ ] check reconciliation of existing resources after upgrading
[ ] X still works after upgrade
[ ] Y is installed correctly

Checklist

[ ] Update changelog in CHANGELOG.md.
[ ] Make sure values.yaml and values.schema.json are valid.

Tested on godsmack, cluster is created just fine.


fix bug in site.github.repo

This doesn’t seem right given the current page and site config works as intended.


error with filter when trying documentation example

(my first lines in Polars, hope this is not a fault of mine)
Have you tried latest version of polars?

yes

What version of polars are you using?
8.0.4
What operating system are you using polars on?
Kubuntu 23.10
What node version are you using
v20.10.0
Describe your bug.
When filtering a string column matching a value, the function seems to interpret the value to match as a column name; this differs from the examples in the documentation.
What are the steps to reproduce the behavior?
(as in https://pola-rs.github.io/nodejs-polars/interfaces/pl.DataFrame-1.html#filter)
df = pl.DataFrame({
    "foo": [1, 2, 3],
    "bar": [6, 7, 8],
    "ham": ['a', 'b', 'c']
})

df.filter(
    pl.col("foo").lt(3)
    .and(pl.col("ham").eq("a"))
)

What is the actual behavior?
            return (0, dataframe_1._DataFrame)(_ldf.collectSync());
                                                    ^

Error: not found: unable to find column "a"; valid columns: ["foo", "bar", "ham"]

Error originated just after this operation:
DF ["foo", "bar", "ham"]; PROJECT */3 COLUMNS; SELECTION: "None"
    at Object.collectSync (/home/gabriele/repos/opra/node_modules/nodejs-polars/bin/lazy/dataframe.js:61:53)
    at Proxy.filter (/home/gabriele/repos/opra/node_modules/nodejs-polars/bin/dataframe.js:192:50)
    at evalmachine.<anonymous>:7:4
    at Script.runInThisContext (node:vm:121:12)
    at Object.runInThisContext (node:vm:295:38)
    at run ([eval]:1020:15)
    at onRunRequest ([eval]:864:18)
    at onMessage ([eval]:828:13)
    at process.emit (node:events:514:28)
    at emit (node:internal/child_process:951:14)

What is the expected behavior?
This should return
shape: (1, 3)
┌─────┬─────┬─────┐
│ foo ┆ bar ┆ ham │
│ --- ┆ --- ┆ --- │
│ i64 ┆ i64 ┆ str │
╞═════╪═════╪═════╡
│ 1   ┆ 6   ┆ a   │
└─────┴─────┴─────┘

Please use:
const df = pl.DataFrame({
    "foo": [1, 2, 3],
    "bar": [6, 7, 8],
    "ham": ['a', 'b', 'c']
})

df.filter(
    pl.col("foo").lt(3)
    .and(pl.col("ham").eq(pl.lit("a")))
)

Thanks for pointing this out, I will have a PR to fix this issue shortly. Thx


Fix #1799

Nothing is blocking insert-ordered-containers-0.2 from entering Nightly, except no aeson-1 there yet.

But the lack of aeson 1 is blocking that version.

So the insert-ordered-containers bound have to be explicitly listed there?
It's a bit unfortunate, as I as maintainer have done my job

If a new version of a dependency is released, and that stops your package compiling/passing the tests, then it is your responsibility to modify your package.

I did, insert-ordered-containers-0.2 support the latest versions of each dependency.
Also there is version of servant-swagger supporting insert-ordered-containers-0.2, which just entered nightly yesterday.
I opened https://github.com/fpco/stackage/issues/1872

Closing, already handled by the massive pruning.


[Bug]:TMBd dynamic_collections not updating poster through template

Version Number
1.16.5
What branch are you on?
master
Describe the Bug
I am following the instructions here https://metamanager.wiki/en/latest/metadata/dynamic.html for adding posters to some dynamic collections but it is not updating.
templates:
  optional:
    - my_collection_poster
  tmdb_collection_details: <<value>>
  collection_order: release
  url_poster: <<my_collection_poster>>
dynamic_collections:
  TMDb Collections:          # This name is the mapping name
    type: tmdb_collection
    remove_suffix: "Collection"
    template_variables:
      my_collection_poster:
        124916: https://theposterdb.com/api/assets/49811

This is the output for that collection in the log
|====================================================================================================|
|                    101 Dalmatians (Live-Action) Collection Collection in Movies                    |
|====================================================================================================|
|                                                                                |
|================== Validating 101 Dalmatians (Live-Action) Collection Attributes ===================|
|                                                                                |
| Validating Method: template                                                                        |
| Value: [{'value': ['124916'], 'tmdb_collection': ['124916'], 'key_name': '101 Dalmatians (Live-Action) Collection', 'key': '124916', 'my_collection_poster': 'https://theposterdb.com/api/assets/49811', 'name': 'TMDb Collections'}] |
|                                                                                |
| Collection Warning: collection_order not found using library default_collection_order: release     |
|                                                                                |
| Validating Method: collection_order                                                                |
| Value: release                                                                                |
|                                                                                |
| Validating Method: label                                                                           |
| Value: TMDb Collections                                                                            |
|                                                                                |
| Validating Method: tmdb_collection_details                                                         |
| Value: ['124916']                                                                                |
|                                                                                |
| Validating Method: minimum_items                                                                   |
| Value: 2                                                                                |
|                                                                                |
| Looking for: 101 Dalmatians (Live-Action) Collection                                               |
|                                                                                |
| Validation Successful                                                                              |
|                                                                                |
|==================== Running 101 Dalmatians (Live-Action) Collection Collection ====================|
|                                                                                |
| Sync Mode: sync                                                                                |
|                                                                                |
| Builder: tmdb_collection: 124916                                                                   |
|                                                                                |
| Processing TMDb Collection: (124916) 101 Dalmatians (Live-Action) Collection (2 Items)             |
|                                                                                |
| 2 IDs Found: [(11674, 'tmdb'), (10481, 'tmdb')]                                                    |
|                                                                                |
|                                                                                |
|=================== Adding to 101 Dalmatians (Live-Action) Collection Collection ===================|
|                                                                                |
| 1/2 | 101 Dalmatians (Live-Action) Collection Collection | + | 101 Dalmatians (1996)               |
| 2/2 | 101 Dalmatians (Live-Action) Collection Collection | + | 102 Dalmatians (2000)               |
|                                                                                |
| 2 Movies Processed                                                                                |
|                                                                                |
|============== Updating Details of 101 Dalmatians (Live-Action) Collection Collection ==============|
|                                                                                |
| Detail: tmdb_collection_details will update Collection Summary                                     |
| Collection Metadata Edits                                                                          |
| Summary | A live-action remake film series of the 1961 Disney animated film 101 Dalmatians         |
| Label | +TMDb Collections                                                                          |
| Details: have been updated                                                                         |
|                                                                                |
| Asset Directory Created: config/assets/101 Dalmatians (Live-Action) Collection                     |
| 1 posters found:                                                                                |
| Method: tmdb_collection_details Poster: https://image.tmdb.org/t/p/original/oSeIai1ioj4dbq7WgbPzpsSCzkS.jpg |
| 1 backgrounds found:                                                                               |
| Method: tmdb_collection_details Background: https://image.tmdb.org/t/p/original/eTaNHqpi7VldgcrDetfTzk4FeDi.jpg |
| Detail: tmdb_collection_details updated poster to [URL] https://image.tmdb.org/t/p/original/oSeIai1ioj4dbq7WgbPzpsSCzkS.jpg |
| Detail: tmdb_collection_details updated background to [URL] https://image.tmdb.org/t/p/original/eTaNHqpi7VldgcrDetfTzk4FeDi.jpg |
|                                                                                |
|====================================================================================================|
|                    Finished 101 Dalmatians (Live-Action) Collection Collection                     |
|                                    Collection Run Time: 0:00:00                                    |
|====================================================================================================|

my_collection_poster: shows the correct URL of https://theposterdb.com/api/assets/49811, but it is not being applied to the collection as you can see from above.
There is also this at the beginning of the log file
|===================================== Scanning Metadata Files ======================================|
|                                                                                |
| Loading Metadata File: config/Movies.yml                                                           |
|                                                                                |
| Config Warning: template: optional must be a dictionary                                            |
| Config Warning: template: tmdb_collection_details must be a dictionary                             |
| Config Warning: template: collection_order must be a dictionary                                    |
| Config Warning: template: url_poster must be a dictionary                                          |
|                                                                                |
|====================================================================================================|

Relevant Collection/Playlist Definition
No response
Logs
https://gist.github.com/Stuke00/7587e1c62715c30ccb484a8356bee74a

is there any difference in behavior if you wrap the URL in quotation marks?
124916: "https://theposterdb.com/api/assets/49811"

is there any difference in behavior if you wrap the URL in quotation marks?
124916: "https://theposterdb.com/api/assets/49811"

thanks for the suggestion, unfortunately it did not make a difference.

The wiki is incorrect there so you are using templates wrong you need to tell dynamic collections what template your using and you also need to name the template like this. I'll fix the wiki
templates:
  tmdb_collection_template:
    optional:
      - my_collection_poster
    tmdb_collection_details: <<value>>
    collection_order: release
    url_poster: <<my_collection_poster>>
dynamic_collections:
  TMDb Collections:          # This name is the mapping name
    type: tmdb_collection
    template: tmdb_collection_template
    remove_suffix: "Collection"
    template_variables:
      my_collection_poster:
        124916: https://theposterdb.com/api/assets/49811

ahh thank you! I knew something seemed off about it but I couldn't put my finger on it.  I just made the changes and it's working now!


Always generate full source map.

Fixes CSP warnings with "quicker" source map
Better development experience by default

Should we remove run-fullmap from https://developers.mattermost.com/contribute/server/developer-workflow/#useful-server-makefile-commands?

I will take care of this.


Fixed an edge case for grep - install breaks on Linux

Users may have an option set for grep to use color.
This was inserting escape characters in "/usr/bin/zsh"

That's weird, how are you running the setup instructions (with which command)?

The curl one. The setup is fine, I followed the instructions verbatim. It's just that the install script couldn't have predicted that I have an env var (GREP_COLOR) so that grep always uses color coding. And those escape characters were getting passed into chsh and causing an error.

That is strange. Setting $GREP_COLOR does not unconditionally enable coloring, at least where I'm familiar with it (e.g. on OS X and Debian Linux). It just specifies which color to use when coloring is on. Perhaps you have an alias or function set up to make grep do --color=always? (If it was the more common --color=auto, then it would only do colorization when outputting to a tty; subshell output capturing or piping it to tail would disable the colorization.)
Doing this change to use grep --color could break this for platforms where grep doesn't have a --color option. Would probably be better to defend against it by reverting whatever env var or alias etc is causing it to do the coloring.
This is something you might want to address in your system's setup. Other things that are calling out to grep are not going to be expecting it to add coloring, either.

Ahh, you're right! It was an alias, not an env var. My mistake. :) Closing!


boardd: add second independent fw version check

pandad does the flashing and version check, then launches boardd. boardd should also double check the fw version independently

@deanlee want to try this one? It's this check here https://github.com/commaai/openpilot/blob/e816c81a5af8684cf3eb6f0c9d578cf82ebc1588/selfdrive/boardd/pandad.py#L55


"Will not blame X, Outside the current workspace."

Hello there,
Due to an annoying bug related to git gutters in vscode (https://github.com/microsoft/vscode/issues/176497) I have to use a workaround, which sets --git-dir argument to the actual directory of the .git folder...
... which causes git blame to think that all files are outside its current workspace.
The workaround in question can be found here: https://stackoverflow.com/questions/75615136/vscode-vscodium-showing-git-gutters-even-though-there-are-no-actual-changes-in-t
Is there anything I can modify in the workaround script or in the extention itself to make them work well together? Thanks.

I've updated my script to work nicely with both vscode and git blame extension, but I may have an idea as to why this extension started misbehaving:
perhaps it makes more sense to parse --work-tree here instead of --git-dir: https://github.com/Sertion/vscode-gitblame/blob/main/src/git/util/gitcommand.ts#L71-L72

General Furman.
I am not exactly sure what I can do here.
I've found some places in the extension where we assume that the git path and the file path has overlap and I'm working on changing them to be more generic. Other than that the modified script looks like it should work. The extension uses the vscode.git built-in extension to get the path to the git executable (permanent link).
Perhaps this was the issue you where running into?

Hi, the modified script works. Waiting for VSCode to get fixed :(


global fwd and subnet error msgs fix & test cases

Fixed the error message to indicate correctly the state of vlans and
vxlans instead of printing an empty string instead of a number when 0.
The test cases are testing too many things in one test case, split out
the tests for forward mode and subnet as they are doing more validation.
Signed-off-by: Chris Plock<EMAIL_ADDRESS>

build PR

build PR

build PR

build PR

Changes LGTM but let's get a @contiv/reviewers-core-networking review as well because I can't validate the network stuff is correct

#1043 needs to be merged first.

build PR


Added compatibily for QT6

Hi,
I really like your RibbonUI. Because I wanted to test it with a FreeCAD version which is build with QT6, i've created a Fork.
The changes I've made:

Changed PySide2 to PySide -> PySide is a special module in FreeCAD that handle the choice for PySide2 or PySide 6. See https://wiki.freecad.org/PySide for more information
Changed QAction to QWidgetAction to make the Ribbon work with both PySide2 and PySide 6.
Added a package xml. This because i added this Git as a custom repository to the addon manager.
Added two pre-commit files: pre-commit-config.yaml and pre-commit-search-and-replace.yaml. When you work with, the second one will automaticly search for Pyside2 and PySide6 and replace it with PySide.

If you can use the changes feel free to merge or copy them.
Kind regards,
Paul Ebbers

These are great additions, thank you very much for adding support for Qt6 and the rest :)

I have merged your changes, thank you again :)

No problem. Happy to help!


Python Sciki-learn API LGBMClassifier predict raw_score=True return probability outside 0 and 1

How you are using LightGBM?
 Python package
LightGBM component: LGBMClassifier from sklearn API
Environment info

Operating System: Linux
CPU/GPU model:
C++ compiler version:
CMake version:
Java version:
Python version: 3.7.6
R version:
Other:

LightGBM version or commit hash:
Error message and / or logs

Reproducible example(s)

Tried both with and without 'objective': 'binary'
params = {
'boosting_type': 'dart',
'learning_rate': 0.1,
'objective': 'binary',
'drop_rate': 0.1,
'verbose': 0
}
params = {
'boosting_type': 'dart',
'learning_rate': 0.1,
'drop_rate': 0.1,
'verbose': 0
}
gbm = lgb.LGBMClassifier(**params, n_estimators=500)
Steps to reproduce

Hi @mikiwzh !
When you pass raw_score=True it means that estimator will return not probability, but raw scores before transformation.


Add Applications

I've added Heroic Games Launcher, OperaGX, JDK 20 from Azul/Zulu, Monitorian, Nano, and Neovim.

Not alphabetized and I'd never add OperaGX to my utility.


ask for help

I'm a little confused about which code I want to run

I'm a little confused about which code I want to run

what is problem about the code?


[noob question] Building source faild.

When i tried to build from source (having issues that have been fixed in dev) i get the following errors when compiling.
note: i'm using netfx-4.7.2-devpack v<IP_ADDRESS>80712

5>Done building project "GeneratePatchTargetHashes.csproj" -- FAILED.
3>LocateSteamApp -> C:\Program Files (x86)\Steam\steamapps\common\Mount & Blade II Bannerlord\Modules\MnB2-Bannerlord-CommunityPatch\tools\LocateSteamApp\bin\Debug\net472\LocateSteamApp.dll
4>C:\Program Files (x86)\Steam\steamapps\common\Mount & Blade II Bannerlord\Modules\MnB2-Bannerlord-CommunityPatch\tools\Antijank\MessageBox.cs(36,28,36,40): error CS0122: 'AppDomainManager.AllocConsole()' is inaccessible due to its protection level
4>C:\Program Files (x86)\Steam\steamapps\common\Mount & Blade II Bannerlord\Modules\MnB2-Bannerlord-CommunityPatch\tools\Antijank\MessageBox.cs(50,28,50,39): error CS0117: 'AppDomainManager' does not contain a definition for 'FreeConsole'
4>C:\Program Files (x86)\Steam\steamapps\common\Mount & Blade II Bannerlord\Modules\MnB2-Bannerlord-CommunityPatch\tools\Antijank\TickExceptionHandler.cs(34,28,34,36): error CS0122: 'CustomDebugManager.Instance' is inaccessible due to its protection level
4>C:\Program Files (x86)\Steam\steamapps\common\Mount & Blade II Bannerlord\Modules\MnB2-Bannerlord-CommunityPatch\tools\Antijank\TickExceptionHandler.cs(44,28,44,36): error CS0122: 'CustomDebugManager.Instance' is inaccessible due to its protection level
4>C:\Program Files (x86)\Steam\steamapps\common\Mount & Blade II Bannerlord\Modules\MnB2-Bannerlord-CommunityPatch\tools\Antijank\TickExceptionHandler.cs(54,28,54,36): error CS0122: 'CustomDebugManager.Instance' is inaccessible due to its protection level
4>C:\Program Files (x86)\Steam\steamapps\common\Mount & Blade II Bannerlord\Modules\MnB2-Bannerlord-CommunityPatch\tools\Antijank\TickExceptionHandler.cs(64,28,64,36): error CS0122: 'CustomDebugManager.Instance' is inaccessible due to its protection level
4>C:\Program Files (x86)\Steam\steamapps\common\Mount & Blade II Bannerlord\Modules\MnB2-Bannerlord-CommunityPatch\tools\Antijank\TickExceptionHandler.cs(74,28,74,36): error CS0122: 'CustomDebugManager.Instance' is inaccessible due to its protection level
4>C:\Program Files (x86)\Steam\steamapps\common\Mount & Blade II Bannerlord\Modules\MnB2-Bannerlord-CommunityPatch\tools\Antijank\TickExceptionHandler.cs(84,28,84,36): error CS0122: 'CustomDebugManager.Instance' is inaccessible due to its protection level
4>C:\Program Files (x86)\Steam\steamapps\common\Mount & Blade II Bannerlord\Modules\MnB2-Bannerlord-CommunityPatch\tools\Antijank\MbEventExceptionHandler.cs(63,52,63,76): error CS1061: 'StackTrace' does not contain a definition for 'FindModuleFromStackTrace' and no accessible extension method 'FindModuleFromStackTrace' accepting a first argument of type 'StackTrace' could be found (are you missing a using directive or an assembly reference?)
4>C:\Program Files (x86)\Steam\steamapps\common\Mount & Blade II Bannerlord\Modules\MnB2-Bannerlord-CommunityPatch\tools\Antijank\TickExceptionHandler.cs(125,55,125,79): error CS1061: 'StackTrace' does not contain a definition for 'FindModuleFromStackTrace' and no accessible extension method 'FindModuleFromStackTrace' accepting a first argument of type 'StackTrace' could be found (are you missing a using directive or an assembly reference?)
4>C:\Program Files (x86)\Steam\steamapps\common\Mount & Blade II Bannerlord\Modules\MnB2-Bannerlord-CommunityPatch\tools\Antijank\PathHelpers.cs(127,25,127,35): error CS0117: 'LoaderPatch' does not contain a definition for 'ModuleList'
4>C:\Program Files (x86)\Steam\steamapps\common\Mount & Blade II Bannerlord\Modules\MnB2-Bannerlord-CommunityPatch\tools\Antijank\MessageBox.cs(18,43,18,65): warning CS0169: The field 'MessageBox.OwnerFormResourceDepot' is never used

Actually a perfectly reasonable question 🙂
Those were fixed in the antijank-enc branch, which we haven't had a chance to add yet.
You can just check that branch out and build it, although you'll be a few days behind the latest stuff in here. Also you may need to rename the repo's folder (the one in Modules) from MnB2-Bannerlord-CommunityPatch to CommunityPatch or you'll get a crash when starting Bannerlord (it's weird, I know).

If you really want all the latest changes, you can merge that branch into dev on your local machine.
Something like this:
git checkout dev
git checkout -b my_dev_plus_antijank
git merge antijank-enc

You can also just unload the Antijank project and just build CommunityPatch


Feature/pap 162 persistant logging

Problem
We need persistent logging in the server for security and trouble shooting purposes.
Solution
Replaced the pino-http with winston.
Type of change
Please delete options that are not relevant.

[x] Improvement or Refactoring (potential breaking changes)

How Has This Been Tested?
Verified that changes did not break existing requestLogger.test.ts
Checklist:

[x] I have performed a self-review of my code
[x] My changes generate no new warnings
[x] Existing unit tests pass locally with my changes

This looks great, Oscar. I have heard great things about Winston, and I believe it will help us troubleshoot issues more fluently when they come up. Nice work!


Fixed issue with the regex for redirecting of frontend content

Not having the * was causing frontend paths also being ignored.
See regex demo with * https://regexr.com/4oq28
See regex demo of original pattern https://regexr.com/4oq2b i.e. without *

Pull Request Test Coverage Report for Build 366

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.906%

Totals

Change from base Build 365:
0.0%

Covered Lines:
45

Relevant Lines:
53

💛  - Coveralls


Remove trailing spaces after a comment symbol

I usually comment stuff with a space between the comment symbol and the actual comment. Like this:
# commented code

But using <leader>cu leaves the space in, resulting in badly indented lines in python. Is there a workaround for this?

As of the merging of #183, this should be fixed.

Thank you, @jonafato

For python this is currently the default behavior. For other languages you can set let g:NERDSpaceDelims = 1 for the extra space to be your default.


Automator: update<EMAIL_ADDRESS>in<EMAIL_ADDRESS>

Generated by Automator - 2022-09-14T03:00:12+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless_istio_release-1.15
e1f6e2f88853f3214c2593c6392704626ab31022
link
true
/test integ-distroless

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-distroless


Update links for Adam13531

My links were from back when I worked on Bot Land. I wanted to update them now that I've shifted my show to Adam Learns.
Thanks for maintaining this repository!

Thanks for the update 👍


Feature request : Auto-update option

Hi,
I am writing a commercial program. I will make an executable and distribute it through my website. CLients will purchase it online and download it. When I will create a new version of software, I will upload it on server. And I need my program to check if there is a new version or not. If it exists a new version, the program will auto-update itself.
That would be cool to have this option.

I think this is completely unrelated to the Nuitka's task. Nuitka is a compiler. What you want is a combination of requests to your servrer and downloading new version. It could be implemented in Python using requests and maybe some other stuff, and then included into your program.

@MarSoft yes it could.
What I am doing with Nuitka is 3 fold. One is to solve the performance problem. This is dear to my heart and my driving motivation. Second, the distribution problem is also to be solved, and standalone is accepted by me, but not very close to my heart. And third, commercial users want security, and convience for deployment.
I am creating a commercial offering that will e.g. offer encypted tracebacks, automatic update, better obfuscucation, etc. with which I intend to earn the money to pay for my reduced day job hours. I am already able to work 2 days less, and to spend the time on this kind of thing. As it's a commercial value only, it won't be part of regular Nuitka, but will make me money for those who need these things only to hide their non-free software and non-free data.
Also, there is no point, in everybody implementing these things on their own. That will cost time that usually is not available or costs more than what I intend to charge. And of course, integrating with Nuitka will allow for some things to be smarter. Yes, you can encrypt your stack traces in pure python as well, but being woven into Nuitka allows for them to be much more compact and to not contain much of the data at all.

@kayhayen Considering it has been quite some time. Do you have a approximate timeline as to when we can expect your commercial offering which would include security, encryption, obfuscation etc.

The encrypted tracebacks are almost done, but we want 0.6.10 to be out, before I put it out there as an actual offering, as that will bring onefile as well.

The encrypted tracebacks are almost done, but we want 0.6.10 to be out, before I put it out there as an actual offering, as that will bring onefile as well.

@kayhayen Is there any progress? Looking forward to trying out the relevant solution

@renyijiu there is an auto-update plugin in Nuitka commercial, that allows you to do it for onefile distributions. It doesn't work for standalone mode, and since macOS is in app bundle mode, effectively that, I am not yet advertising it, until I finish it.


support default in-cluster access for debug

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
563b263e90cda6cf306cd25d3c1bd718e7319cf6
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
563b263e90cda6cf306cd25d3c1bd718e7319cf6
link
/test release-notes_istio

gencheck_istio
563b263e90cda6cf306cd25d3c1bd718e7319cf6
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
563b263e90cda6cf306cd25d3c1bd718e7319cf6
link
/test release-notes_istio

gencheck_istio
563b263e90cda6cf306cd25d3c1bd718e7319cf6
link
/test gencheck_istio

integ-pilot-multicluster-tests_istio
563b263e90cda6cf306cd25d3c1bd718e7319cf6
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


fix(pyproject): update github urls

Google index the pypi project but url to github was not correct.

Released new version just now.


No Nav Bar in Contact page

Currently the Contact Page doesn't contain a Navbar so it is difficult to navigate to other pages.
Screenshot for the above issue

@07sumit1002 kindly assign me this issue.

can you assign me this issue

Please assign me this issue I will fix this issue.


A Style Guide for PRAW Documentation

Issue Description
Recently, I've been working to standardize some of the terminology in the documentation and to bring it up-to-date (Reddit Gold has been renamed for more than a year, for example), and I asked bboe on #1150 if we could add a "Style Guide" rst for documentation to package_info so that we could standardize people's docstrings in general and make sure we're on common ground here going forward.
Here are my thoughts and suggestions as a starting point.
Subreddit and User Notation
The site officially uses the u/ prefix for usernames and r/ prefix for subreddits, with no trailing /. So:

r/redditdev, not /r/redditdev or /r/redditdev/
u/spez, not /u/spez or /u/spez/

Furthermore, subreddit_name_prefixed is an attribute returned with objects, and it's always in the form r/SUBREDDIT.
Example Subreddit / User in Python Examples
Since the addition of example code to PRAW documentation, there have been a plethora of subreddits used in the example code snippets, including:

r/test
r/redditdev
r/reddit_api_test
r/SUBREDDIT
r/iama
r/praw_test (not a real subreddit)

I do not personally have a strong preference, but I feel we should standardize one to use for consistency. My suggestion is r/test, so that people can attempt to post comments and submit without any particular limitations. We probably don't want people testing out posting submissions to r/redditdev, and r/SUBREDDIT actually has a purpose of sharing subreddits.
On the other hand, u/spez is already consistently used as an example user, and I think that should continue.
Proper Capitalization
Reddit as a company and a site name is now always capitalized as "Reddit". The lowercase "r" in the logo is merely a stylistic choice.
Confusingly, redditor with the lowercase "r" is the standard form for a Reddit user.
Markdown is always capitalized as well.
Use of Inline Code Blocks
Inline code blocks are frequently used, but it's sometimes a bit inconsistent throughout the documentation. Some have single quotes for string values 'spez', others don't. I'm not sure if there was some sort of decision made in the past about this, but we should agree on some convention.
Adherence to "Official" Terminology
This is where things get a bit confusing, and where PRAW contributors as a whole need to agree on where we intend to diverge from the site's "official" terminology.
What do I mean by that? In an effort to make the site more accessible to non-redditors, Reddit has changed up a good many of the classic terms long-time users may be familiar with:

Classic Term
"Official" Reddit Term

sub/subreddit
community

subscribe/unsubscribe (to a subreddit)
join/leave

subscribers
members

user-subreddit / user profile
profile

subscriptions
My Communities

multi/multireddit
custom feed

link posts/text posts
posts

thread/comment thread
comments

emoji (e.g. :snoo:)
custom emoji

Let's be honest, no one is going to stop using the term "subreddit", especially people dealing with PRAW and I believe the term should still be used in PRAW documentation due to its pervasiveness and the audience of those who will read said documentation, and also because the attributes in objects always use the classic terms. Furthermore, the site often changes terms with little warning (see: join/leave).
Nevertheless, I believe we should have a table in this document detailing where our documentation's terminology differs from the current "official ones", so newcomers to Reddit in general have an easy reference to what documenters mean, and also make sure we use our own terms consistently.

Anyway, this is just a proposal for contributors here to see if we can agree on things and then codify them in a new document.

Thanks for this. I think PRAW would benefit a lot from a style guide. I'm gonna quote some of what you said and then ramble about my opinions.

I feel we should standardize one to use for consistency. My suggestion is r/test

I agree. Though, some examples only work for subreddits where the authenticated user is a moderator, and most PRAW users are not mods at /r/test. Any thoughts on that?

Confusingly, redditor with the lowercase "r" is the standard form for a Reddit user.

This gets at something that I think about when writing PRAW documentation that you don't mention: the difference between referring to a "reddit thing" and to a PRAW class. On Reddit, you may encounter a redditor, and you may wish to use PRAW to send that redditor a message, and to do so you might create a Redditor instance. Throughout PRAW there are classes named after Reddit concepts and, while some usages obviously refer to one or the other, many uses of these "shared names" could go either way. I think it would be helpful to have a policy about this in the style guide, though I don't know exactly what the policy would be.
In addition, a number of first lines of docstrings use obvious class names without tagging them with the :class: Sphinx markup. It would be nice to enforce that all references to class names be tagged as such, but that is at odds with the pydocstyle requirement that the first paragraph of a docstring be only one line (because of the extra characters :class: adds).

Inline code blocks are frequently used, but it's sometimes a bit inconsistent throughout the documentation.

Personally, I (try to?) use them any time I'm documenting something that is a literal value in Python, such as True, -17, and yes, "a string". This would be my preferred guideline in the style guide.
I do think that we should not use single quotes for strings (now that we format the codebase with Black), and that we should run Black on all of the code samples.

I believe the term should still be used in PRAW documentation due to its pervasiveness and the audience of those who will read said documentation, and also because the attributes in objects always use the classic terms.

So long as we have classes with these names, I think we should continue using the names as the primary way of referring to the concepts (so, "subscribers" beats "members"). I guess we should also add something that says "the official Reddit term is…" in the places where the "wrong" term is used most prominently (such as in the Subreddit class documentation, for the word "subreddit"). I also like your table suggestion for the style guide.

I'm adding some rules onto here:
Documentation:

Always leave an empty line
All indented blocks should be indented in increments of 4.


Document PERMISSIVE mode for incremental mTLS adoption.

https://github.com/istio/istio/issues/6403

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incfly
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdake
Assign the PR to them by writing /assign @sdake in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@diemtvu @wattli PTAL.

/hold
I have followed these instructions myself in the snapshot release, will remove the hold once that's available and instructions are verified.

Hi, I did some refactoring and the file you edited has moved in the repo. Please rebase and push again. Sorry for the inconvenience.

@incfly: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign @geeknoid
Could you take a look? Thanks!

/lgtm
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incfly, wattli
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
Assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold cancel

@sdake @frankbu Can some of you approve the PR? Thanks!

Please update uses of backticks with {{< text> }} sequences instead.
In addition, we generally no longer have What's next section in the site. Instead, we have auto-generated See also sections. Check out the netlify preview to see what that looks like. You can probably just remove the What's next section entirely, I've done this for the rest of the site already.

New changes are detected. LGTM label has been removed.

@geeknoid , please take a look. @incfly is OOO so I am taking over this.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incfly, wattli
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
Assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

Deploy preview for preliminary-istio failed.
Built with commit d1f33c9912fcd0c659923acd676b7102e3c16510
https://app.netlify.com/sites/preliminary-istio/deploys/5b44ea57c6aed61d7c2df5fe


How to get SVG.toDataURL()

Hi,
I want to know how to get data url from svg.js.
Thanks.

What exactly are you talking about? Example? Code?
sayasajer<EMAIL_ADDRESS>schrieb am Fr., 05.02.2016, 6:20:

Hi,
I want to know how to get data url from svgjs
Thanks
—
Reply to this email directly or view it on GitHub
https://github.com/wout/svg.js/issues/455.

Are you talking about exporting the whole svg?

I'm assuming they are meaning base64 encoding the svg so it can be used as a data url string, something like this...
https://github.com/sampumon/SVG.toDataURL

Yes, Thank you for understanding because I do not know how to explain more.
The reason why I want to export the whole svg is because I want to use it in Pixijs Sprite.

You can use window.atob() to convert an XML string to base64 encoded data. At least that works in Firefox. For other non supporting browsers you can fallback to a base64 poly fill. you can get the xml string with the svg() method which returns the whole svg as String.
Make sure you add the type to the base64 encoded string which should be data:image/svg+xml;base64,

Quick questions?
How does this differ than the export plugin?
Getting the full SVG work with nested SVGs?

The export plugin is obsolete. Its implemented in the core since svg.js v2. Same goes for the import plugin.

@Fuzzyma

The export plugin is obsolete. Its implemented in the core since svg.js v2. Same goes for the import plugin.

I am not quite follow you. If it implemented since v2, then how I can use it? Is there any example?

I already wrote that in this thread and it's written in the docs. A call do
root.svg() will return the whole svg as a string.
sayasajer<EMAIL_ADDRESS>schrieb am Do., 11.02.2016, 8:23:

@Fuzzyma https://github.com/Fuzzyma
The export plugin is obsolete. Its implemented in the core since svg.js
v2. Same goes for the import plugin.
I am not quite follow you. If it implemented since v2, then how I can use
it? Is there any example?
—
Reply to this email directly or view it on GitHub
https://github.com/wout/svg.js/issues/455#issuecomment-182745683.

Thanks for reply.
I managed to use svg.js in pixi js now. Here is the codes in jsbin

Can i get the SVG string without adding it to the DIV or append to the document body?

In order to export the svg you ofc must have it in the dom. That's after all a dom library because it works in a browser. If you don't need the dom you don't need a browser either and you just can generate the svg on server-side...


Added tests for --repo flag for helm fetch command

[ ] Added tests for --repo flag on helm fetch command
[ ] Also added tests for (pkg/repo).FindChartInRepoURL

thank you @sushilkm


Layer Ordering Problem

Hi bcvery1,
It looks like you have been doing a lot of work on this library. I was doing a similar thing last year and had a few insights while implementing.
I started out, like you, with a separate types of ObjectGroups, ImageLayers, and TileLayers. Unfortunately, if you do that, it is impossible to reproduce Tiled maps correctly when drawing, because you lose the layer order between the different types. In Tiled, you can put any layer type in any order and that should be how they are drawn. The draw function now will right now iterate through all the tile layers, then all the image layers, (then presumably objectgroups and groups later). In tiled however you can intersperse all layer types in any order.
While I was struggling with this problem I realized that actually ObjectGroups, ImageLayers, TileLayers, and Groups can all be parsed into a single struct type which can then identify the type using the xml.Name.
You can see my solution here: https://github.com/elliotmr/tmx/blob/master/tmx.go#L92
There is also a pixel integration example library here:
https://github.com/elliotmr/tmx/tree/master/pixeltmx
Since I don't have time to work on my library, feel free to use any concepts from it in yours.

Hey @elliotmr thanks for your input, it is much appreciated.
That sort of insight will definitely help as TilePix grows.  I'll definitely take a look through your repo, thank you for the offer.


TypeError: Cannot read properties of undefined (reading 'only')

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
I trying to use theme inside the another component . That is not working and i getting this error
TypeError: Cannot read properties of undefined (reading 'only')
`
import { Card, CardContent, Container, Typography } from "@mui/material";
import { makeStyles } from "@mui/styles";
import { Box } from "@mui/system";
import React from "react";
import { useState } from "react";
import { useSelector } from "react-redux";
import PortfolioCards from "./PortfolioCards";
let useStyle = makeStyles((theme) => ({
margin_to_box: {
marginTop: "10px",
},
container_style: {
display: "flex",
alignItems: "center",
justifyContent: "space-around",
flexDirection: "row",
[theme.breakpoints.only("xs")]: {
fontSize: "10px",
},
},
card_style: {
display: "flex",
alignItems: "center",
justifyContent: "space-between",
flexDirection: "row",
[theme.breakpoints.only("xs")]: {
flexDirection: "column",
},
},
box_style: {
display: "flex",
flexWrap: "wrap",
justifyContent: "space-between",
[theme.breakpoints.only("xs")]: {
justifyContent: "center",
},
},
mobileDisplay: {
minWidth: "550px",
margin: "10px",
[theme.breakpoints.only("xs")]: {
fontSize: "16px",
minWidth: "100px",
},
},
}));
const Portfolio = () => {
let coins = useSelector((state) => state.allCoins.coins);
let style = useStyle();
return (

Current Value: 290000

Invested Value: 290000

Returns : 290000

Returns %: 290000

Invested Coins

{coins.map((coin) => (
<>
//Here Im passing a new component
;
</>
))}

);
};
export default Portfolio;

That component
import { makeStyles } from "@material-ui/styles";
import { Avatar, Card, CardContent, Typography } from "@mui/material";
import axios from "axios";
import React, { useEffect, useState } from "react";
let useStyle = makeStyles((theme) => ({
card_style: {
display: "flex",
alignItems: "center",
justifyContent: "space-between",
flexDirection: "row",
[theme.breakpoints.only("xs")]: {
flexDirection: "column",
},
},
mobileDisplay: {
minWidth: "550px",
margin: "10px",
[theme.breakpoints.only("xs")]: {
fontSize: "16px",
minWidth: "100px",
},
},
}));
const PortfolioCards = ({ coin }) => {
const [newArr, setnewArr] = useState({});
let value = newArr.price * coin.AmountOfCoins;
let valueNow = value - coin.orderAmount;
let optionsForById = {
params: {
referenceCurrencyUuid: "yhjMzLPhuIDl",
timePeriod: "24h",
},
headers: {
"x-rapidapi-host": "coinranking1.p.rapidapi.com",
"x-rapidapi-key": "e818a2ac84msh1b7e3db0c06c590p17c8a1jsna91177a65c0e",
},
};
const fetchCoinById = async (uuid) => {
const response = await axios
.get(https://coinranking1.p.rapidapi.com/coin/${uuid}, optionsForById)
.catch((err) => {
console.log(err);
});
setnewArr(response.data.data.coin);
};
useEffect(() => {
fetchCoinById(coin.id);
}, []);
let style = useStyle();
return (
<>

{coin.coinName}
Coins you have:{coin.AmountOfCoins}

Invested:{coin.orderAmount.toFixed(3)}

Current:
{value.toFixed(3)}

Returns:{valueNow.toFixed(3)}

</>
);
};
export default PortfolioCards;
`
Expected behavior 🤔
I want to use theme inside that component
Steps to reproduce 🕹
Steps:

Context 🔦
Actually i'm trying to use theme inside a component But getting this error
TypeError: Cannot read properties of undefined (reading 'only')
Theme was working fine in first component but when i try to use in component called inside first component i getting error
Your environment 🌎

`npx @mui/envinfo`
  Using Chrome browser
 "dependencies": {
    "@emotion/react": "^11.7.1",
    "@emotion/styled": "^11.6.0",
    "@material-ui/styles": "^4.11.4",
    "@mui/material": "^5.4.2",
    "@mui/styles": "^5.3.0",
    "@testing-library/jest-dom": "^5.16.0",
    "@testing-library/react": "^11.2.7",
    "@testing-library/user-event": "^12.8.3",
    "axios": "^0.25.0",
    "react": "^17.0.2",
    "react-dom": "^17.0.2",
    "react-redux": "^7.2.6",
    "react-router-dom": "^6.2.1",
    "react-scripts": "4.0.3",
    "redux": "^4.1.2",
    "redux-thunk": "^2.4.1",
    "web-vitals": "^1.1.2"
  },

Which component is the error coming from?
Please provide a codesandbox where we can reproduce the error. You can form this template.

I have a problem in createTheme importing.
App not getting the breakpoints values (up,between,only etc..) Thats why its showing error
TypeError: Cannot read properties of undefined (reading 'only')


Implement sprite/script/media listing

For example, the following links:
http://dev.opensprites.gwiddle.co.uk/sprites
http://dev.opensprites.gwiddle.co.uk/scripts
http://dev.opensprites.gwiddle.co.uk/media

Check this out: http://dev.opensprites.gwiddle.co.uk/site-api/list.php
One problem. Do we really want to be able to share entire sprite files, or make virtual collections of assets? Because the way I'm thinking about this is, we don't want duplicate files (waste of space), and my upload script already extracts out assets from sprite and project archives, so why not make "sprites" a virtual collection of assets that you can download in one bundle? It's kind of like how Scratch treats 2.0 projects.
If you see index.php, it reflects my ideas. I replaced it with lists of

Popular assets
Featured assets
Popular collections
Featured collections

I call the virtual organization of assets a "collection," but we could call it a "sprite" instead, if need be.
So what we should really rename the navbar tabs to are

Assets
Scripts
Collections

Thoughts?

Check out the front page: http://dev.opensprites.gwiddle.co.uk/
It's something, at least

That API is pretty cool! That will be handy for creating that mod page I've always wanted. <3


BUG: Kineticists not gaining the benefit of CON mod to damage for 2 action elemental blast

Level 2 kineticist with 2 STR, 4 CON

When the attack is set to 2 action, I'm not seeing the bonus damage from CON applied.
I glanced through the rule element and didn't see anything obvious that would be the issue unfortunately. :(
First noticed on version 6.0.4

Not able to reproduce, but it looks like the attack roll in chat is a single-action blast.

Weird. I set the toggle to 2 action :/ not sure whats going on there
On Fri, Jun 28, 2024, 18:46 Shark that walks like a man <
@.***> wrote:

Not able to reproduce, but it looks like the attack roll in chat is a
single-action blast.
—
Reply to this email directly, view it on GitHub
https://github.com/foundryvtt/pf2e/issues/15266#issuecomment-2197744194,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZFXCVVE6HXOXNAXNJEHJ3ZJXRUVAVCNFSM6AAAAABKAUB6ZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJXG42DIMJZGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Check if the elemental blast action exists more than once on the sheet: #14651

Ah! That was it, thank you!
On Sat, Jun 29, 2024 at 1:07 PM oWave @.***> wrote:

Check if the elemental blast action exists more than once on the sheet:
#14651 https://github.com/foundryvtt/pf2e/issues/14651
—
Reply to this email directly, view it on GitHub
https://github.com/foundryvtt/pf2e/issues/15266#issuecomment-2198264145,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZFXCSU2IL6C3BMXUVXQZDZJ3SVNAVCNFSM6AAAAABKAUB6ZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGI3DIMJUGU
.
You are receiving this because you authored the thread.Message ID:
@.***>


Builds fail without explanation

Details

Project URL: https://readthedocs.org/projects/httpolice/ (and others)
Build URL (if applicable): https://readthedocs.org/projects/httpolice/builds/5704942/ (and others)
Read the Docs username (if applicable): vfaronov

Expected Result
Builds should succeed, or at least produce an explanation of why they failed.
Actual Result
In the past few days* most of my builds have been failing without explanation. I start a build, it shows up as “Triggered” or “Cloning”, then I refresh the page and it’s already “Failed”. On the build page, all I see is:

This is happening with various versions, various projects. Sometimes I can unbreak it by wiping the version, or by disabling it in Admin → Versions and enabling again. Other times I can’t. Right now the httpolice project is stuck. I have not been able to discern a pattern.
* “In the past few days” may not be relevant information because I hadn’t triggered a build for some time prior to that.

This is happening to me too.
Project URL:  https://readthedocs.org/projects/portalmehpc/
Build URL: https://readthedocs.org/projects/portalmehpc/builds/5713163/
Username: Toddwickizer
Here is an image:
http://i.imgur.com/bBHyznB.png
Zero information at all. it builds locally just fine with make html. I am very new to RTD so any help would be great!

Identical issue here. My last successful build was triggered July 8, 2017 1:15am and my next-most recent changes (today) result in the same Unexpected Error.
Project URL: https://readthedocs.org/projects/fasealign/
Build URL: https://readthedocs.org/projects/fasealign/builds/5713532/ (most recent)
RTD Username: EricWilbanks

Same here.

Project URL: https://readthedocs.org/projects/bezier/
Build URLs

https://readthedocs.org/projects/bezier/builds/5713807/
https://readthedocs.org/projects/bezier/builds/5713690/
https://readthedocs.org/projects/bezier/builds/5713589/

RTD Username: dhermes

Hi @agjohnson @ericholscher, I tried to troubleshoot these builds without much success. It looks like @towicode's build logs that it was passing 1 day ago but failing today.
Interestingly, it looks like @vfaronov's project build is passing now.
I wonder if the 24 hour max age in #3005 introduced a weird caching issue for builds.

@willingc

Interestingly, it looks like @vfaronov's project build is passing now.

As I mentioned, this issue seems to be intermittent or with non-obvious conditions. I just tried triggering stable and got the same failure: https://readthedocs.org/projects/httpolice/builds/5715813/
I’m not sure my issue is the same as that of others here, as in my builds there’s not even that one line of output about creating a virtualenv.

I wonder if the 24 hour max age in #3005 introduced a weird caching issue for builds.

I first observed this issue 6 days ago, earlier than #3005.

Something else I just noticed: some of my failed builds have the (correct) commit hash listed on their page:

while others don’t even have that:

My two projects that were failing have started succeeding again (e.g. 1, e.g. 2)

Thanks @dhermes. It looks like everyone's docs but @vfaronov's are building now.
@vfaronov Have you tried wiping and cleaning the builds that are failing?

@willingc

Have you tried wiping and cleaning the builds that are failing?

Yes, I have.

Recent PRs #3009 and #2979 appear to have resolved this issue.
@vfaronov, your doc build is now reporting passing https://readthedocs.org/projects/httpolice/builds/5732769/ Do you wish to go ahead and close this issue out?

@willingc Thank you! My affected projects and versions seem to be working right now. But, if you don’t mind, I’ll wait until tomorrow before closing this issue, just to be sure.

@willingc I’m afraid the problem persists: https://readthedocs.org/projects/httpolice/builds/5740724/

@vfaronov This recent failure may be unrelated as I am having some build failures currently. Will you check again in a few hours? Thanks.

@willingc Still failing: https://readthedocs.org/projects/httpolice/builds/5742426/

@vfaronov I spent some time looking at your source code. Your docs build environment and process are both a bit different than common sphinx builds on RTD. I spent about 30 minutes trying to work on getting your docs to build myself. I suspect that the reason your docs are not building is due to a regression introduced in either your code or RTD's code. I would recommend getting the docs to build correctly using a conda environment or requirements.txt file (one that is not in tools subdirectory) as well as a readthedocs.yml file in your root directory.
Good luck. The jupyterhub and nbgrader docs along with others from Project Jupyter are good examples.

@willingc

Your docs build environment and process are both a bit different than common sphinx builds on RTD.

I did recently add something unusual to the HTTPolice project docs. And I started observing this issue about the same time.
But this issue now also affects previous versions of this project — such as 0.5.2 (build #5750046) — which had a straightforward Sphinx configuration that had not been touched in a while, and which did not experience this issue a few months ago. I even disabled “Install your project inside a virtualenv” and it’s still the same.
Do you think deleting the project from Read the Docs and creating it anew might help?

Actually, the first manifestation of the issue was before I started changing my Sphinx conf, so these recent changes can’t be the culprit.

I wouldn't delete the project since it is serving your cached docs. I spent about an hour trying to get it to work yesterday.
@ericholscher @agjohnson Is there a way to completely reset a build other than using Wipe in the version settings?

Same for me http://readthedocs.org/projects/joinrpg/builds/5756878/

@leotsarev Your issue is different. You should add a requirements.txt file.

@willingc I've added requirements.txt; no effect. I can download the project onto my Linux host, pip install -r requirements.txt and after that make html works fine. But still not on RTD unfortunately.
(Same project as @leotsarev's, https://readthedocs.org/projects/joinrpg/builds/5757539/)

I was mistaken when I originally said that I had multiple affected projects. Of my projects, only one seems to be affected by this issue. Other two were suffering from an unrelated issue, which had confused me.

Our project seems affected since a month, without any explanation.

@vfaronov It looks like your docs are passing now.
@pierre-24 In the RTD admin page for the project, are you building in a virtualenv using setup.py?

@willingc

It looks like your docs are passing now.

No, they are failing intermittently, like before.

@willingc Yes we are. When I build a branch which was part of a recent pull request (mais in the end of July), it builds without any issue.

So, now that I can check, this project and that one  have the same configuration, and are based on the same github repo. The second one is just a fork of the first one. But the build of the first one systematically fails (no matter the version, the branch or the tag), while there is no problem with the second. And I really don't understand why.

any news ?

@pierre-24 I'm traveling for the next few weeks. Pinging @ericholscher @agjohnson re: any ideas on the first build???

Sorry for bugging, but any news?

Guys, what's the timeframe? Should we consider migrating out of RTD? What we can do to help investigating?

I've addressed this in #3073. There is a hotfix out, folks should test their builds again

Thank you @agjohnson, my project seems to be OK now. @leotsarev @pierre-24 what about yours?

Last build passed. I'll play around and report if it is stable.
Anyways, thanks a lot, that's great.


New pkg do not needs devfs to be mounted when running in chroot

This was introduced in 2019 when pkg open /dev/null after doing the chroot. In the next release of pkg, this should not be required anymore as pkg will open /dev/null before doing the chroot.
Should not be merged until the new pkg is released.

the should not be merged until new pkg is release and available in the quarterly branch

Poudriere doesn't require using the latest ports tree or pkg. For example, at work we can still use latest Poudriere with our older custom ports tree with older pkg. Is there harm in having this mount?

the should not be merged until new pkg is release and available in the quarterly branch
Not a poudriere question but I am curious to know whether if this is true as I was trying to build some custom images and pkg still needs devfs to be mounted. I was using HEAD(src) and a custom pkg repository built from HEAD(ports) and still needed devfs to be mounted. Even if the said change has not reflected into quarterly I believe it should be in the HEAD but despite that it's failing.


Dbeaver still display functions that are deleted.

System information:

Operating system (distribution) and version : Debian 11
DBeaver version : Version <IP_ADDRESS>203060510
Additional extensions

Connection specification:

Database name and version PostgreSQL 13
Driver name : php pgsql
Do you use tunnels or proxies (SSH, SOCKS, etc)? no

Describe the problem you're observing:
Hello,
I'm working on some functions in my pgsql database. I've deleted some functions that i've created but dbeaver still display them in the functions sub-menu. if i right click and then delete, a pop up show up and says that "the function does not exist" so i can't delete it.
Even if i use DROP FUNCTION, same message regarding the not existing functon.
But the more annoying is that if i try to create another function with the name of the "supposed" deleted function, it says that i can't create it because the function already exists... so i'm kinda stuck in a loop.
the function i'm playing with are returning TABLE.
thanks for your help

Hello @MattRGX
Have you tried to refresh the "Functions" tab in the Database Navigator Editor? After function deleting.

Yes i refreshed it many times.
I even deleted my connection and start from a fresh one. After connecting to my fresh new connection, the functions are still here and can't delete them.

How do you delete your functions? Via DBeaver UI or in SQL Editor with the DROP statement?

99.99% of the time, i do it via DBeaver UI.

About permissions - maybe the issue related to this #15563
Can you provide an example of your function DDL?

CREATE OR REPLACE FUNCTION declaration.get_crypto_symbol() RETURNS TABLE(crypto_symbol character varying)  LANGUAGE plpgsql AS $function$ begin 	return query  		select 			currency_name 		from 			declaration.declare_currencies 		where 			is_crypto 		order by id asc; end;$function$ ;

So i managed to delete the persistent functions with DROP command.
in the sub_menu functions the function was displayed like this
get_crypto_symbol(varchar)
but to delete it i had to use
DROP FUNCTION get_crypto_symbol()
without specifying the parameter between the parenthesis.
The thing is if i try to detele via the UI, the code generated is
DROP FUNCTION get_crypto_symbol(varchar)
so i guess it's a bug from DBeaver.
If you want me to do more test, just let me know

Yes, I see the issue with the incorrect DROP statement. And it is  related to https://github.com/dbeaver/dbeaver/issues/15563
We will fix it in the next release, I hope.

Is there something in the error logs? https://github.com/dbeaver/dbeaver/wiki/Log-files
I am talking about the original issue, "DBeaver still displays functions that are deleted".
Also, what commit mode do you have?

Does this error with other functions repeat for you? Or was this issue just once for one specific function?
Is this problem still persist?

There has been no update on the issue for a long time. If it is still actual - feel free to reopen it with additional info.


Making the admin panel fully responsive

Description
Made the admin panel fully responsive.
Fixes:  #566

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have made this from my own
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

https://user-images.githubusercontent.com/66300439/161922738-75ebd91b-5b5f-4b27-a85c-81493057c5d9.mp4

https://deploy-preview-590--cool-front-end-templates.netlify.app/admin dashboard/

It looks fine in the video she attached, is it just me who is facing the issue? @DEEPALI-SUK please verify

U are viewing  it in the tablet version I made it mobile responsive.

It must be responsive for all screen sizes

It must be responsive for all screen sizes

Ok then i'll do it for the tablet and make a new pr.

No need to make a new PR. Add commits in this one only

No need to make a new PR. Add commits in this one only

Ok

I have made the commits and made it responsive for the tablet also.

It's not working on my device. Any of the other mentors please help me review this.

@arpit456jain I think the level could be increased by 1 as it took me 3days to make this website responsive as the code was really bad.

Yup thanks @astha2412


update.sh: do not restore stable (tag) branch

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew tests with your changes locally?

Restoring stable branch post-update could lead to unsuspecting users
with homebrew.devcmdrun being stuck forever on an old tag.
Fixes #1111. (A much more detailed description of the problem can be found there.)
I'm worried about the damage that's already done. There should be users that are already stuck, and since we no longer update to master, we can't modify their update logic.

I've been wondering whether this is better than just having everyone always on master and master reflecting either origin/master or the latest tag.

I'm worried about the damage that's already done. There should be users that are already stuck, and since we no longer update to master, we can't modify their update logic.

I'm not. We set the dev-cmd stuff for people we expect to be working on Homebrew so have some familiarity with git. These are by their nature more technical users.

I'm not. We set the dev-cmd stuff for people we expect to be working on Homebrew so have some familiarity with git. These are by their nature more technical users.

The problem is they may not notice until quite some time later, if ever.

I've been wondering whether this is better than just having everyone always on master and master reflecting either origin/master or the latest tag.

I think developers should have their initial branch restored either way, unless you disable auto update out right for developers (which actually may be a good idea).

I think developers should have their initial branch restored either way, unless you disable auto update out right for developers (which actually may be a good idea).

I agree, I just mean for the branches we do have people on rather than v1.0.1 maybe it makes sense to always have master.

The problem is they may not notice until quite some time later, if ever.

Now we have a core/formula separation I'm less concerned about this. They will notice eventually and the workaround is pretty simple.


use LNBITS_ALLOWED_FUNDING_SOURCES and create/restore database backup when switching funding source

This PR adds two features:

Sets 'LNBITS_ALLOWED_FUNDING_SOURCES' to the currently configured funding source in StartOS. This makes it so that you cannot change the funding source from the LNBits admin UI. (preventing the deletion of the database when a user accidentally changes this)

When the funding source is changed (now only possible from the StartOS UI), it creates a backup of database.sqlite (suffixed with funding source name, e.g. database.sqlite.LndRestWallet).
It then checks if there is an existing backup of the new funding source (e.g. database.sqlite.CLightningWallet) and moves that backup back to 'database.sqlite'

This makes it so that you can switch between the two supported funding sources, while not losing any data.
If needed, I can split this PR in two, as I think 1 would be nice to have to prevent user errors. 2 is more opiniated.
I tested 1, which works perfectly.
I tested 2 so far that I can see that the mechanism works (backing up / restoring when switching between funding source). But I do not have a working CLN node that I can actually test with.

The first feature seems to be working as expected, however I am seeing a few issues when testing switching between LN implementations that would require addressing:

Admin Password: Starting with LND and switching to CLN as the funding source seems to work as expected (with the exception of point 2 below), but then switching back to LND results in Properties showing the Admin password for CLN funding source DB. This seems to happen because the Admin password is set and saved to /app/data/start9/admin_password.txt when the superuser account does not yet have a username set (generally a fresh install). If the superuser account is set i.e. username != "", then Properties will just pull the password from /app/data/start9/admin_password.txt with no knowledge of whether this is the correct password. LNbits itself only stores a hash of the password, so any passwords shown to the user need to be persisted elsewhere. In this case, that would mean persisting and being able to differentiate between the CLN and LND Admin password (assuming a DB for each exist), so the correct Admin Password could be shown to the User.
Persisted login problems: Starting with LND (and having logging into the admin account) and then switching to CLN results in the Admin user still being logged in despite admin account is different with a different password. I suspect this is a result of LNbits cookies from the login with an LND backend still being valid despite the changed backend and a different admin password. Perhaps more problematic: If logged in as a non-admin user, switching LN implementations results in Error: 401: User not allowed after launching the UI; The UI is then stuck on this page and does not allow going back to the register/login page unless browser cookies are cleared.
Stale Config Warning: If the feature to switch between accounts were added, the config warning should be deleted or updated for any new considerations once the feature is complete.

3 can be fixed easily, 1 should be possible with some changes to the docker_entrypoint, but I don't know if there is much that can be done about 2 within the lnbits-startos package as this behavior relates to browser cookies issued by the upstream service. Barring a satisfactory solution to point 2, I'm not convinced toggling between multiple accounts is viable as a feature.

I see, yeah that's tricky to fix from the package. Shall I sent a PR with just the allowed funding source change or will you add it in next release (lnbits 1.0 seems close to release)

The allowed funding source is a good change and one less unnecessary footgun for users.
Feel free to open another PR - I wouldn't want to deprive you of contributor credit 😄


Build Queue Callback Not Called When Specifying a Locator

When I specify a locator to try and locate a build queue, my callback never gets called yet I believe the call succeeds.

Submitted pull request https://github.com/jeef3/teamcity/pull/3 to resolve this.

Fixed in #3


Subtitle support for VR with HMD

I installed the dumped subtitles for the VPVR pack. While the subtitles were displayed on the CM3D2 window on the desktop, none were visible in the HMD.
Displaying the subtitles just as is in the viewport isn't the best idea, it leads to hard to read text. The normal UI in the game is on a curved surface, that follows only larger movements of the head and ignores small movements.
One possible solution might be, to place the subtitle UI elements on that surface, but it's not visible in the Vacation menu, only in normal gameplay, so it might not be the best way.
Another possible solution may be to place the subtitles on the transparent clipboard that also contains the VPVR tutorial. This board can be moved by the player, so it has the advantage, that you can place the subtitles wherever you want. The problem here is, that this clipboard is only visible in the Vacation scenes. This clipboard also contains some of the normal UI (FPS display, little gear icon for options) so my guess is, that the (normally curved) UI overlay is just added directly to this clipboard. If that's the case, then attaching the subtitles to that UI frame should be enough.

Hey, thanks for the info!
Indeed, the subtitle feature was implemented by simply putting them as a screen overlay. While simple and sensible for windowed applications, that approach does not work with HMDs as screen-space elements are simply disabled by Unity in VR mode.
I will consider on adding a better support for pure VR mode. We shall see on a final implementation, but I will most likely opt in for a more general solution by moving the subtitles into its own UI element that is independent of the game's UI*.

Yes, UX may suffer from the choice, but I'd rather have a working implementation first.