Feature/pull game files from s3

Created DataTransfer class to handle read/write of the S3 bucket

S3 class is now more general purpose

Fixed directory of data uploaded to S3
New import_file arg to trigger import at the beginning of deadbot process
New build_num arg to select version to import. Default will get the latest version

Be sure to add shutil to the poetry config with poetry add shutil as well

I didn't need to install shutil as it looks like its just a part of python by default

Looks great!  Nice job!


Can't rename directory (folder, catalog) if it's a single child of its parent directory. (Not a permission issue)

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.81.0, commit 6445d93c81ebe42c4cbd7a60712e0b17d9463e97
OS Version: MacOS 13.4 (22F66)

Steps to Reproduce:

Open any folder from File > Open Folder
In Explorer panel, in opened folder, create new folder (parent) and single sub folder (child)
Try to rename child subfolder either by selecting it and pressing Enter on keyboard or by right clicking and selecting Rename option from context menu

Result:
Can't rename folder if it's an only child of its parent.
https://github.com/microsoft/vscode/assets/106629516/5e6af290-2c02-4083-b479-f95c77766db6

Duplicate #188571

Thanks @lramos15 for referencing the original issue and sorry for my duplicate. I will close it.


PerfCollect Does Not Gather Separate CoreCLR Symbol Files

CoreCLR now generates separate .dbg symbol files.  Perfcollect needs to grab these files when zipping up a trace, otherwise, native symbols cannot be resolved.  Ideally, for every ELF binary, we look for a pointer to a debug file if the binary doesn't contain symbols, and then copy that debug file into the trace.

FYI: @mikem8361

This is dependent on https://github.com/dotnet/coreclr/issues/4091.


Add TLS spec to Ingress

Adds TLS spec to Ingress

Checklist

[x] PR contains a single logical change (to build a better changelog).
[x] Update the documentation.
[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog.

Question: Currently it's assumed that the TLS secret is provisioned by cert-manager. Should we add functionality to manage secrets, e.g. to be able to provision commercial certificates?

Should we add functionality to manage secrets, e.g. to be able to provision commercial certificates?

I don't think that this is needed atm, we're using LE all over the place...

Fine by me, however we should then clearly state that cert-manager is required and maybe even make the cert-manager annotation a default value?

Yes :+1:


Feature: Support search by distance threshold

SDK
Python
Description
Instead of only limiting the search by top-k the search could be limited by a distance threshold. This is consistent with the Voronoi cell approach as you can enumerate the cells that are within a given distance of the cell that contains the search point (you need to consider that the search point can be anywhere in the cell and adjust the distance accordingly).
This would allow the database to be used in more flexible ways, e.g:

for document clustering where you want to find all points within some threshold distance of a given point (like in DBSCAN)
for maintaining a database of queries and matching a stream of incoming documents to all queries that are within the distance threshold

Thanks, this is a good idea. I think this is a duplicate of #745, so I'm closing it in favor of that one.

The distinction here is that I would desire no limit at all.

You are always welcome to set the limit to like a billion. No limit means no bound on latency, which I think should be explicitly opt in.


Support machines with multiple network interfaces

This is to support setups where machines have multiple network interfaces with multiple ips.  The descriptor for a DC now contains the ips for all the interfaces for all the nodes in that DC.  Then when a cross DC connection is created using zero mq it tries each interface is tried until it finds one that succeeds.  If the DCs are unable to establish a connection after a timeout an error is returned.  Since we are using zero mq which abstracts the connection layer we need to send a message manually and wait for an ack.
[This fixes the issue with Grid5000 where we could only connect within a single cluster, as certain machines have several addresses, some of which are valid public internet address, but only accept traffic from within the cluster]

Can you have a look at the merge conflicts?

I've merged this pull into https://github.com/SyncFree/antidote/pull/195 since they were relying on each other, so I will close this one.


DimensionMismatch("No precise constructor for RBState found. Length of input was 4.")

Sorry, why do I meet an error when I run the code x = zeros(model)[1] in Quadrotor.ipynb:
DimensionMismatch("No precise constructor for RBState found. Length of input was 4.")
Stacktrace:
 [1] RBState(x::Tuple{Tuple{Tuple{Tuple{SVector{3, Float64}, SMatrix{3, 3, Float64, 9}, SVector{3, Float64}, SVector{3, Float64}}}}})
   @ StaticArrays ~/.julia/packages/StaticArrays/OWJK7/src/convert.jl:1
 [2] StaticArray (repeats 4 times)
   @ ~/.julia/packages/StaticArrays/OWJK7/src/convert.jl:4 [inlined]
 [3] build_state(::Quadrotor{QuatRotation}, ::SVector{3, Float64}, ::SMatrix{3, 3, Float64, 9}, ::SVector{3, Float64}, ::SVector{3, Float64})
   @ RobotDynamics ~/.julia/packages/RobotDynamics/tXate/src/rigidbody.jl:134
 [4] zeros(model::Quadrotor{QuatRotation})
   @ RobotDynamics ~/.julia/packages/RobotDynamics/tXate/src/rigidbody.jl:28
 [5] top-level scope
... ...

The problem is with the newest version of Rotations.jl. They broke some compatibility with the previous version. For now just use v1.0 of Rotations.jl and that should fix the issue.

Sorry, after I changed the version of Rotations.jl to v1.0.4 using ]add<EMAIL_ADDRESS>I still met this error.


Add ISPN eviction strategy LRU to folo-sealed

@ruhan1 Do we need to port this over to the other 2 branches as well?

@jdcasey  we don't need. I checked 1.2.x and master, both have the correct eviction strategy. I guess this is why the leak is only on 1.1.x.


Need: Email address of dreamer

Hei everyone,
something is not quite correct in the display of information and / or in the question.
a) I cannot see the phone number of the dreamer in the dream. Usually, as an admin, I could see the email address and the phone number of the dreamer. With the current system I can not access the email-adress (which is about the most important thing!). I can also not access the phone number unless I use admin power and go to 'edit the dream' to check what they entered in the box.
FYI: IF I click on the 'dream crew' icon I should be taken to a user profile. The URL is f.e. https://dreams.kiezburn.org/users/701  and that could give me the email address, but currently it leass to an empty page
In short: Need to access phone number & emailaddress (Priority here!) of dreamers to set up contact sheet.

If the emailaddress cannot be accessed anymore because it is not displayed through the user profile we need to make another box in the sign up form asking people for their 'preferred email address for dream communication (don't worry, won't be public)' just like the phone number question and display that to admin right users.


ReorderableListView unable to drag on flutter 3.3.6

Steps to Reproduce

Execute flutter run on the code sample
...
...

Expected results:
Actual results:

Code sample

           ReorderableListView(
              onReorder: (oldIndex, newIndex) {
                int dropIndex = newIndex;
                if (oldIndex < newIndex) {
                  dropIndex = newIndex - 1;
                }
                final moveItem = _optionSort.removeAt(oldIndex);
                _optionSort.insert(dropIndex, moveItem);
                setState(() {});
              },
              children: [
                for (final item in _optionSort)
                  Padding(
                    key: ValueKey(item.id),
                    padding: const EdgeInsets.symmetric(vertical: 3.0),
                    child: ListTile(
                      title: Text(item.name),
                      trailing: Icon(Icons.menu),
                    ),
                  )
              ],
            )

Logs

it works well for me code sample

@corioste
Please check above code sample and see if it works in your case.
If your use case is different, please provide flutter doctor -v and complete minimal code sample that shows the behavior you are reporting.

i found the solution dragging in flutter 3 it needs to add the
                          index: _optionSort.indexOf(item),
                          child: const Icon(Icons.drag_handle),
                        )),```


Builder: Free memory on failure

Prevent memory leaks by freeing all allocated memory on failure.

fixed with e4f915ea59464437ce61b33552085adc90046388


Enable dependency locking for executable binary distributions

Thanks!

I'm not familiar the dependency locking. The description of the difference embed and depsEmbedded is useful for me. Could you write a short description?

Sounds good. Added some comments in: 2c558fa7b17069c76f652695e514eee8ae3e3f7c

This PR create four lockfiles(compileClasspath.lockfile, depsEmbedded.lockfile, pluginEmbedded.lockfile and runtimeClasspath.lockfile), resolve library dependency and embed specific version jar into embulk package. Correct?

compileClasspath and runtimeClasspath are the same with other util libraries and plugins. They are used as normal librarires.
depsEmbedded and pluginEmbedded are contained like /lib/(something).jar in the final executable Embulk distribution binary (like embulk-0.10.45.jar). They are loaded by a sub classloader, not the top-level Java application classloader, so that they are not visible from plugins.
You may want to try unzip -l embulk-0.10.44.jar to see what are included.

Anyway, merging...

Thank you for your comment!


Fixing Pagintation When Retrieving a Page Other Than the First Page

Description
Fixing pagination via the Spring SDK when PageRequest and CosmosPageRequest are used with a page other than the first page. Updated/fixed unit tests.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

/azp run java - cosoms - ci

LGTM @trande4884 , great work. However, we should add more tests for this.

@kushagraThapar I added some more tests. Let me know if there are any other specific cases you want covered.

/azp run java - cosmos - tests

/check-enforcer override


Taking the example from their docs, if I am using AbbreviatedStackTraces and type sum([]), I get an easily readable stack trace:
julia> using AbbreviatedStackTraces
[ Info: Precompiling AbbreviatedStackTraces [ac637c84-cc71-43bf-9c33-c1b4316be3d4]
[ Info: Skipping precompilation since __precompile__(false). Importing AbbreviatedStackTraces [ac637c84-cc71-43bf-9c33-c1b4316be3d4].

julia> sum([])
ERROR: MethodError: no method matching zero(::Type{Any})

Closest candidates are:
  zero(::Type{Union{Missing, T}}) where T
   @ Base missing.jl:105
  zero(::Union{Type{P}, P}) where P<:Period
   @ Dates ~/.julia/juliaup/julia-1.9.3+0.aarch64.apple.darwin14/share/julia/stdlib/v1.9/Dates/src/periods.jl:51
  zero(::FillArrays.Zeros{T, N}) where {T, N}
   @ FillArrays ~/.julia/packages/FillArrays/FwMoZ/src/FillArrays.jl:591
  ...

Stacktrace:
  [1-12] ⋮ internal
       @ Base, Unknown
    [13] sum(a::Vector{Any})
       @ Base ./reducedim.jl:994
    [14] top-level scope
       @ REPL[137]:1
Use `err` to retrieve the full stack trace.

If I am instead in pager> mode (or, indeed, if I am not using AbbreviatedStackTraces) I get a really long error message!
  expand really long message!!
pager> sum([])
ERROR: MethodError: no method matching zero(::Type{Any})

Closest candidates are:
  zero(::Type{Union{Missing, T}}) where T
   @ Base missing.jl:105
  zero(::Union{Type{P}, P}) where P<:Period
   @ Dates ~/.julia/juliaup/julia-1.9.3+0.aarch64.apple.darwin14/share/julia/stdlib/v1.9/Dates/src/periods.jl:51
  zero(::FillArrays.Zeros{T, N}) where {T, N}
   @ FillArrays ~/.julia/packages/FillArrays/FwMoZ/src/FillArrays.jl:591
  ...

 AbbreviatedStackTraces.jl overrides a lot of functions in REPL.jl. However, we cannot rely on those functions because we need to render them for a pager. It will take either a full rewrite of the REPL mode in TerminalPager.jl or modification in AbbreviatedStackTraces.jl to add an extension to support TerminalPager.jl. I am not sure what is the best approach yet.

I suspected this may be a bigger change. Apart from the substantial amount of time/effort needed for the change, is this something you think is useful and worth working towards (at some point)? Would it help to loop in the maintainer for AbbreviatedStackTraces.jl to hear their view?

Yes, sure! It would be awesome to add this support in TerminalPager.jl!


Build folder under dist/apps/strapi is missing some stuff

When building using yarn nx run strapi:build it generates a dist folder with needed stuff to run the project. It runs just fine but there are missing stuff from the webpack build compared to the yarn nx run strapi:serve build.
You can notice you wont have the internationalisation or any other plugins in settings panel if running the the dist/apps/strapi using yarn start or a custom server as when running the serve you will have all the functionalities in the admin panel
Any workarounds for this?

What version of @nx-extend/strapi are you using?


refactor to eliminate through2 dependency

Enhancements to the core Node.js API have made the through2 dependency unnecessary.  See:
https://github.com/rvagg/through2#do-you-need-this
and the "simplified constructor approach" discussion under
https://nodejs.org/api/stream.html#stream_new_stream_transform_options
as well as the stream.PassThrough class.
The simplified constructor approach was added in Node.js v1.2.0 according to this section:
https://nodejs.org/api/stream.html#stream_simplified_construction
Thus, the simplified constructor approach should be supported by the minimum version of Node.js required by the MarkLogic Node.js API.
As with all changes of dependencies, this refactoring will be best to do at the start of a new release cycle.

Creating a new Jira ticket.


[Bug]: Route53 dangling IP check causes many false positives for A records pointing to non-AWS IPs.

Steps to Reproduce
Route 53 dangling IP check causes many false positives for A records pointing to non-AWS IPs.
https://github.com/prowler-cloud/prowler/blob/ed2ca4d896633bd5777101a3c17700fffba58773/prowler/providers/aws/services/route53/route53_dangling_ip_subdomain_takeover/route53_dangling_ip_subdomain_takeover.py
Expected behavior
Verify IP against AWS whois range before finding creation
Actual Result with Screenshots or Logs
Many false-positives
How did you install Prowler?
Docker (docker pull toniblyx/prowler)
Environment Resource
Docker container
OS used
Ubuntu
Prowler version
v3.5.2
Pip version

Context
No response

Hi @vlsecurity, you're right, thank you for letting us know. It'll be fixed in the next release.

@vlsecurity the above PR should fix this issue


When training with the GL18 dataset, what is the whitening dataset?

Hi, @tonyngjichun
When training with the GL18 dataset, what is the whitening dataset?
Did you ever use "retrieval-SfM-120k-whiten.pkl" from the sfm-120k dataset?
When whitening, it's not clear, but in your code it looks like you're using "retrieval-SfM-120k-whiten.pkl", not the GL18 dataset. right?  (https://github.com/tonyngjichun/SOLAR/blob/852a95fe64d94ab95cc280e0cf68c69a2d6dd7d8/solar_global/examples/train.py#L659)
thanks

Hi, thanks for the question
The model in our paper use end-to-end whitening, i.e. the whitening linear layer is learnt during training. Therefore the test_whiten option is not needed during test time. Otherwise before training we load the pre-trained whitening layer (https://github.com/tonyngjichun/SOLAR/blob/852a95fe64d94ab95cc280e0cf68c69a2d6dd7d8/solar_global/networks/imageretrievalnet.py#L70) and fine-tune from it

Thanks for your quick reply.
That part seems to be using the filip code model as it is.
https://github.com/tonyngjichun/SOLAR/blob/852a95fe64d94ab95cc280e0cf68c69a2d6dd7d8/solar_global/networks/imageretrievalnet.py#L70
Does this mean you don't know which dataset is used?  (There is no mention of this in the filip code.)
thanks

This is the pretrained whitening weights - both trained using SfM120k and GL18 are available in Filip's code. From what I remember, it doesn't really matter which pretrained weights are used for initialisation as long as the model is fine-tuned on GL18. Hope this helps!


Exception in thread "main"

been trying to figure this out for a couple days now but this is the error ive been getting after specifying where the path to the first image is.
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: -1
at java.util.ArrayList.elementData(Unknown Source)
at java.util.ArrayList.get(Unknown Source)
at proRAW.getPrevImage(proRAW.java:134)
at proRAW.getImageData(proRAW.java:152)
at proRAW.retrieveData(proRAW.java:74)
at proRAW.(proRAW.java:41)
at proRAW.main(proRAW.java:387)
I'm new to programming so not sure exactly what the error is and how i can fix it

I'm not an expert on photography, but might it be that the image doesn't have a .raw file extension? :thinking:


Not able to use P4A  jniLibs

Duplicate Check

[X] I have searched the opened issues and there are no duplicates

Describe the bug
Im using 0.25.0.dev3526 not able to use the P4A jniLibs, before its works fine
Code sample
Code
[Paste your code here]

To reproduce
while running flet build apk
Expected behavior
No response
Screenshots / Videos

Captures
[Upload media here]

Operating System
Linux
Operating system details
linux
Flet version
0.25.0.dev3526
Regression
Yes, it used to work in a previous Flet version (please specify the version in additional details)
Suggestions
No response
Logs
Logs
[Paste your logs here]

Additional details
No response

new flet build DOES NOT depend on Kivy's P4A anymore, so you can't use PyJNIus
since new flet build is based on Beeware's toolchain you can probably call Java/Kotlin functions directly from Python, seehere

Correct, it doesn't depend on p4a anymore, but it's not exactly using Beeware's toolchain as well. Python for mobile is now a part of Python 3.13 and backported to 3.12 and below. However, as Beeware and Flet are following the same packaging "standard" their pre-built binary packages should be interchangeable, theoretically.
Is there a separate lib for calling Java/Kotlin functions from Python?


Upgrading from 0.3 to 1.0.0-beta-3

Hi,
I am migrating a large app with a hundred or so routes to the new router. I found it dies with an error that is very hard to trace where it hurts:
"TypeError: Cannot create property 'dynamic' on number '1'"
The only way for me to find it was to comment out whole modules and then determine which one broke it.
and the need to force an empty template property also was hard to trace from the error thrown. Can't that default to an empty string? I have many template-less routes.

Hi @httpete thanks for the feedback.
Did you ever find out what was causing your type error?

Can't that default to an empty string? I have many template-less routes.

I will consider this for the next release. If anything, I think the default would be to render an unnamed <ui-view></ui-view>

Hi @christopherthielen , I did it was an onEnter function I had on my route when I removed it, it went away.
The error it throws when it has an empty template should at least say which route name it is, it doesnt now it just says $default.foo has no template.
I also found that the stateEvents.js doesn't work out of the box, I had to remove the webpack wrapper. But even once on, it doesn't throw the $state***Events the same way, and my app was breaking.  The events are not thrown the same way as 0.3.1 in my opinion.

Thanks Chris,
This widget behaves differently. The "show" event (the first $on.event there ) is fired, and then immediately after the "hideMe" is called. That is the $stateChangeSuccess. I bet this is hard to see. But the widget works fine in 0.3.1, and is always hidden in 1.0 because the this.hideMe() is fired when the show() is called.

        $rootScope.$on(IframerComponent.NAME + '.show', (evt, src, modeCls) => {

            if (src) {
                el.setAttribute('src', src);
                el.style.display = '';
                body.style.overflowY = 'hidden';
                stripClasses();
                el.classList.add(modeCls);

                var sc = $rootScope.$on('$stateChangeSuccess', (evt) => {
                    this.hideMe(evt);
                    sc();
                });
                isShowing = true;
                window.scrollTo(0, 0);
            }

        });

        this.hideMe = (evt) => {
            el.style.display = 'none';
            body.style.overflowY = '';
            stripClasses();
            isShowing = false;
            // Now set to a blank state so I don't flash.
            el.setAttribute('src', 'um/index.html#blank:');
        };

        $rootScope.$on(IframerComponent.NAME + '.hide', this.hideMe);

This is how that event is fired. I go this route (badroute), the controller emits the "show" event, and then it is immediatlly hidden.
`       var iFramerCtrl = ['$scope',,  function ($scope, IFramerService) {
$scope.$emit('iframer.show', IFramerService.getIframeSrc(), 'global');
}];
    // Dashboard route.
    $stateProvider.state('badroute', <angular.ui.IState>{
        url: '/',
        data: {
            iFrameSrc: 'um/index.html#',
        },
        controller: iFramerCtrl
    });`

@httpete thanks for the details.  That's a bug in the polyfill.  I'll fix that in beta.4 -- tracked as #3144
In the meantime, you can use the stateEvents.js polyfill I built and tested from here:  http://plnkr.co/edit/Dtk3kBr1spkb6OISxXpg?p=preview

Moved default template idea to #3178


Fix re-pausing consumer after a rebalance

Fixes https://github.com/spring-projects/spring-kafka/issues/1111
pause() the consumer in the rebalance listener so that the Consumer
will discard any fetched records that would otherwise be returned by
the initial poll.
cherry-pick to 2.1.x

Do we still cherry-pick to 2.2.x?
Thanks

Well, it's not cherry-pick'able into 2.1.x - need a separate PR.
Or we just don't back-port it into 2.1.x and 2.2.x one is enough.
Nevertheless let me know what is in your mind!
Thanks

OK. Looks like according the issue state, we really talk about back-porting only to 2.2.x, not 2.1.x.
Nevermind. let's consider that as a typo in your comment! 😉

I always seem to do that (switching between Kafka and AMQP). Yes, I meant 2.2.x - updated.

Cherry-picked to 2.2.x as https://github.com/spring-projects/spring-kafka/commit/a5bfe1b7987c8d114ebc3c4f3cfa50e3205d5a94 after fixing conflicts in the KafkaMessageListenerContainerTests.


Confused by the loss function.

In your code, you minimized -(oloss + nloss).mean()
which means (oloss+nloss) should be large.
So, "oloss become large and nloss become small " is expected.
Although -(oloss+nloss) decrease,  I got oloss become small and nloss become large, how so?

Thank you for the feedback.
Can you provide a reduced, reproducible case sample? Like, small dataset and a configuration for it.


service.instance.id

ResourceAttributes.SERVICE_INSTANCE_ID has been deprecated. ServiceAttributes doesn't have SERVICE_INSTANCE_ID. is this intended? Should i submit a PR to add it?
I have a module in opentelemetry-java-contrib is depended on io.opentelemetry.semconv.ResourceAttributes. I am trying the replace all the attributes in ResourceAttibutes.

there is 'SERVICE_INSTANCE_ID' in ServiceIncubatingAttributes.

@zeitlinger fyi

there is 'SERVICE_INSTANCE_ID' in ServiceIncubatingAttributes.

will use this.


Added feature bash/zsh completion

It is now possible to let cobra generate autocompletion code for bash and zsh by using a new completion command like this:
# for current bash session
qaz completion bash > /tmp/qaz-completion.sh
source /tmp/qaz-completion.sh

# for future bash sessions if using homebrew
qaz completion bash > $(brew --prefix)/etc/bash_completion.d/qaz

# for current zsh session
source <(qaz completion zsh)

# for future zsh sessions
qaz completion zsh > "${fpath[1]}/_qaz"

The resulting completion script could be improved by implementing autocompletion for config files, stack names and profiles like this (here: zsh, note the :profile:_profiles and :stack:_stacks extension to refer the custom functions _profile and _stacks in the argument description)
function _stacks {
  # warning: this operates on the default config.yml and does not consider a previously given config file using the -c|--config option
  local -a stacks
  stacks=( $(echo "ls" | qaz shell | awk 'NR>5{flag=1}/EOF/{flag=0}flag' | sort) )
  _describe 'stack'  stacks
}

function _profiles {
  local -a profiles
  profiles=( $( cat ~/.aws/credentials 2>/dev/null | sed -n "s/^\[\(.*\)\]$/\1/p" | sort) )
  _describe 'profile' profiles
}

function _qaz {
  local -a commands

  _arguments -C \
    '--debug[Run in debug mode...]' \
    '--no-colors[disable colors in outputs]' \
    '(-p --profile)'{-p,--profile}'[configured aws profile]:profile:_profiles' \
...
function _qaz_change_create {
  _arguments \
    '(-c --config)'{-c,--config}'[path to config file (Required)]:filename:_files' \
    '(-s --stack)'{-s,--stack}'[Qaz local project Stack Name (Required)]:stack:_stacks' \
...

The full extended completion script can be found here: https://gist.githubusercontent.com/thorstenhuhn/7a8356cc57cc07d120eb2e4edb111790/raw/4372f7a280a2116b8dcf3eaa4f0ef2b47318cbe4/_qaz

Awesome, thanks for this.


[SPARK-14733] Allow custom timing control in microbenchmarks

What changes were proposed in this pull request?
The current benchmark framework runs a code block for several iterations and reports statistics. However there is no way to exclude per-iteration setup time from the overall results. This PR adds a timer control object passed into the closure that can be used for this purpose.
How was this patch tested?
Existing benchmark code. Also see https://github.com/apache/spark/pull/12490

Test build #56248 has started for PR 12502 at commit 0e590c5.

Test build #56250 has started for PR 12502 at commit 4bbf249.

Test build #56248 has finished for PR 12502 at commit 0e590c5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56248/
Test PASSed.

Test build #56250 has finished for PR 12502 at commit 4bbf249.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56250/
Test PASSed.

Merged build finished. Test PASSed.

@rxin

LGTM - merging in master.


[ISSUE #5763] add the default subscribe * tag method

Make sure set the target branch to develop
What is the purpose of the change
close https://github.com/apache/rocketmq/issues/5763
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #5764 (d705f19) into develop (646d04f) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #5764      +/-   ##
=============================================
+ Coverage      42.45%   42.49%   +0.04%
+ Complexity      8215     8214       -1
=============================================
  Files           1060     1060
  Lines          73193    73195       +2
  Branches        9598     9598
=============================================
+ Hits           31071    31104      +33
+ Misses         38221    38188      -33
- Partials        3901     3903       +2

Impacted Files
Coverage Δ

...ketmq/client/consumer/DefaultLitePullConsumer.java
74.86% <0.00%> (-0.85%)
:arrow_down:

...e/rocketmq/store/ha/autoswitch/EpochFileCache.java
77.08% <0.00%> (-4.17%)
:arrow_down:

...controller/impl/DefaultBrokerHeartbeatManager.java
82.27% <0.00%> (-3.80%)
:arrow_down:

...he/rocketmq/client/trace/AsyncTraceDispatcher.java
82.21% <0.00%> (-2.41%)
:arrow_down:

...org/apache/rocketmq/common/stats/StatsItemSet.java
41.79% <0.00%> (-1.50%)
:arrow_down:

.../org/apache/rocketmq/store/index/IndexService.java
59.00% <0.00%> (-1.00%)
:arrow_down:

...mq/store/ha/autoswitch/AutoSwitchHAConnection.java
71.62% <0.00%> (-0.55%)
:arrow_down:

...che/rocketmq/acl/plain/PlainPermissionManager.java
78.22% <0.00%> (-0.54%)
:arrow_down:

.../org/apache/rocketmq/store/ha/DefaultHAClient.java
61.53% <0.00%> (-0.52%)
:arrow_down:

...main/java/org/apache/rocketmq/store/CommitLog.java
65.30% <0.00%> (-0.11%)
:arrow_down:

... and 10 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Deprecate all RAND_METHOD_* functions

From point 2 of the Technical Items still to be done list:
Deprecation List Proposal: DH_, DSA_, ECDH_, ECDSA_, EC_KEY_, RSA_, RAND_METHOD_.

Does not include macros defining useful constants (e.g. SHA512_DIGEST_LENGTH).
Excluded from Deprecation: EC_, DSA_SIG_, ECDSA_SIG_.
There might be some others.
Review for exceptions.

Just want to ask a question (might be obvious):  Any function that takes a RAND_METHOD parameter gets deprecated, right?  And internal fields (such as in the ENGINE structure) become deprecated too, right?

I thought that RAND_METHOD was going to be kept.  It's currently the only way to completely replace the RAND DRBGs without writing a provider.  People with hardware RNGs use this.

Well, y'all voted to deprecate it....

With all the agreed upon deprecations it is clear that writing providers is the right way. So yes, I voted for deprecation of the RAND_METHOD as well because it really is a legacy API.

Note that this removes a whole bunch of functions, including

RAND_poll
RAND_add
RAND_seed
RAND_load_file
RAND_write_file
RAND_file_name
RAND_get_method
RAND_set_method

Is this okay?
Because of the last two, existing tests that change the CSPRNG to a fixed byte-stream invalidates some of the KAT's.  Thoughts?

@richsalz none of the RAND methods you mentioned, except for RAND_[gs]et_rand_method(), takes or returns a RAND_METHOD pointer (see below), and none of them is marked for deprecation. (Those functions use the RAND_METHOD interface only internally.) I consider the RAND API a high (application) level API which abstracts the underlying implementation and is remarkable simple to use. The latter holds in particular for RAND_bytes() and RAND_priv_bytes(). So the RAND API is certainly not a legacy interface IMHO. (You might recall that used to think differently and preferred the RAND_DRBG API. But that has vanished already.)
Deprecation of the RAND_METHOD api essentially means that you can't modify the RAND interface anymore by replacing its underlying RAND_METHOD. If you want to provide a different entropy source in the future, you need to implement a provider (pun intended).

include/openssl/engine.h:482: DEPRECATEDIN_3_0(int ENGINE_set_RAND(ENGINE *e, const RAND_METHOD *rand_meth))
include/openssl/engine.h:531: DEPRECATEDIN_3_0(const RAND_METHOD *ENGINE_get_RAND(const ENGINE *e))
include/openssl/rand.h:48: int RAND_set_rand_method(const RAND_METHOD *meth);
include/openssl/rand.h:49: const RAND_METHOD *RAND_get_rand_method(void);
include/openssl/rand.h:54: RAND_METHOD *RAND_OpenSSL(void);
include/openssl/types.h:145: typedef struct rand_meth_st RAND_METHOD;

Because of the last two, existing tests that change the CSPRNG to a fixed byte-stream invalidates some of the KAT's

I don't recall the details, but @slontis was able to adopt the known answer tests.

Internally we shouldn't be using RAND_METHOD.  The KATs use the test RNG as the entropy source.
We did discuss RAND_add, @t-j-h really wanted it and the decision was that it wasn't to be removed from memory.
With the recent revelations about the entropy source, I expect that we will get a replacement for READ_set_method.

the decision was that it wasn't to be removed from memory.

Oh, don't worry: RAND_add() will always be in our memories. ;-)

We did discuss RAND_add, @t-j-h really wanted it

I think that @t-j-h is on the wrong side of history here. Random sources should be provided by experts and not stuffed in by amateur application developers. So there should be a backend API for doing it, not a front end API.

See #13171

A thought for this one: we could introduce a RAND_set0_lib_ctx_rand(OSSL_LIB_CTX *ctx, EVP_RAND_CTX *rand) which overrides the primary, private and public DRBGs on a per library context basis.
This should be enough to replace RAND_METHOD.
The only issue I see is inside the FIPS provider where it isn't possible to gain access to the internal library context.  FIPS internal RAND calls would still go there.
A RAND_set0_global_rand(EVP_RAND_CTX *rand) fails for FIPS since it's not necessarily inside the boundary.

At this point, the approaches and requirements that you want go beyond my modest skills in this area, so I'll leave this PR here, mark it WIP, and hope it's of us. I'm abandoning it.

Congrats on pushing this over the finish line!


How can I get the new Angular template without Visual Studio?

Could there please be instructions for Visual Studio code or how to do things through the command line for https://learn.microsoft.com/en-us/aspnet/core/client-side/spa/angular?view=aspnetcore-8.0&source=recommendations&tabs=visual-studio?

Hello @Donistivanov ... Please re-open this issue using the Open a documentation issue link/feedback form at the bottom of the article. Use of the form adds metadata to your GitHub issue that cross-links the topic and pings the author automatically for a faster response.


Zen Mode does not work when using Github Codespaces as a PWA

I have a Github Codespace instance running and I have installed it as a web app.

However, when using it as an app and toggling Zen Mode with Fullscreen, it blinks for a second and then renders a black window. After that, I have to quit the app and open it again, as even reloading does not work.

It works normally on the browser.
I am using Chrome Version 89.0.4389.128 (Official Build) (x86_64)
And MacOS Catalina 10.15.7 (19H524)

How about if you just do F1 > full screen and not zen mode? Does it work then?

It also does not work.
So, I am suddenly got it to work and tried to figure out how to reproduce this reliably.
Apparently, if you open Codespaces on the browser first, then open it using the "Open in App" link. (see image on first comment). And then, try to go into Fullscreen or Zen Mode, it does not work. I am suspecting there is something wrong with going to full screen.
However, if after that you close the app, and re-open it again directly using the App (by using CMD+Space on the Macbook + "Codespaces"), it works normally.
Let me know if you need any more info.
Thank you!

All good info. Potential duplicate https://github.com/microsoft/vscode/issues/106972
fyi @bpasero @deepak1556

I provided all information asked, why has the issue been closed?

I think it is a duplicate, so no action from you is needed


⚠ Samsung has degraded performance

In 08b87b4, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2593 ms

Resolved: Samsung performance has improved in e1c1dd5.


Diagram CI not working as expected

[minor bug]
The diagram CI tries to push to main directly, but main is protected. An example: https://github.com/vre-hub/vre/actions/runs/4916815447/jobs/8781065068#step:3:180

I will resolve this later, its a bit tricky but since this is just a "for fun" feature it's not important 😄

Closing, ref to #153


Reduce the number of test files

This repo contains a large number of very small test files. These are useful but having so many files bloats e.g. the Julia installation since the tests are shipped. It would probably be better to ship them via a tar-ball and then untar them to some tmp directory when the tests run.

Sir,I wanted to work on it . Is it a good first issue for me to work on it

This was fixed in https://github.com/JuliaLang/TOML.jl/commit/38ee3e0da9d8feafd5990307dd41d5560aa7d0bf. Sorry, I should have closed this issue.

yeah ,no problem sir . It would be great if you add the tags for the good first issues for this repo


Domain Controller DNS needs special attention

Even if you specify custom DNS servers, when you promote a server to a Domain Controller, the VM changes from DHCP provided DNS Server settings from Azure on the nic inside the VM to the standard one provided by AD and sets them manually on the nic. This should be mentioned specially. And is this really supported to set the DNS server settings directly on the NIC inside the VM, or should we manually change to DHCP provided DNS server on the nic inside the VM?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c377fa1e-2274-704a-dcfa-4ac02659bf87
Version Independent ID: 1ba8a48b-a99e-096b-4822-63d62379e605
Content: Create, change, or delete an Azure network interface
Content Source: articles/virtual-network/virtual-network-network-interface.md
Service: virtual-network
GitHub Login: @KumudD
Microsoft Alias: kumud

#reassign: allegradomel

Hey there @KjetilEVRY, our documentation on AD Domain controllers and their role with DNS is documented alongside of our Windows Server Active Directory documentation, see [Install a new Active Directory forest](https://docs.microsoft.com/windows-server/identity/ad-ds/deploy/virtual-dc/adds-on-azure-vm#dns-and-active-directory]'s DNS section.  The document you linked to is the generic documentation for manipulating network interfaces broadly across all of Azure.
All guidance related to DNS and Active Directory should be found in that linked document set.  If you'd like any clarifications added there, please open up an issue against one of those documents so that it can be clarified further so we can get the right authors engaged to help you out.
As @TravisCragg-MSFT mentioned, either way is supported, so please pick the way that best suits your situation.
I'm going to close out this specific issue against this doc page.
#please-close


Separate type specs / coercions from predicates

This extends existing required and optional interfaces to support explicit type specs that are used for input coercion which is applied prior validation. This is a pretty big change as we're separating coercion from validation in the DSL too.
Here's how it works:
Dry::Validation.Form do
   # enable explicit type-specs
   configure { config.type_specs = true }

   required(:name, :string)
   required(:age, [:nil, :int])

   # `schema` implies :hash type spec
   required(:address).schema do
     required(:street, :string)
     required(:city, :string)
     required(:zipcode, :string)
   end

   # `each` implies `:array` type spec
   required(:phone_numbers).each do
     schema do
       required(:prefix, :string)
       required(:num, :string)
     end
   end
end

Notice that this is a pure sanitization/coercion schema without any rules.
Scope of this PR:

[x] Extend required to accept type specs
[x] Extend optional to accept type specs
[x] Add support for type specs in nested schemas
[x] Add support for either symbol-based type specs or dry-types objects
[x] Make sure input-processor is applied only once (which will also fix jruby on CI)
[x] Clean-up :)

As a second step, which will be done in another PR, I'll add a way to infer rules from type specs, which is exactly the opposite of what our complex input-processor compilers are doing. I also suspect some further polishing of the interface directly in master prior 0.8.0 release.
A really cool side-effect of this improvement is: defining a schema is ~80-100 x times faster no, no kidding:
Schema defined in 0.075425
Form defined in 5.43349
Form (with type specs) defined in 0.077061
------------------------------------------------------------------------------
Warming up --------------------------------------
              Schema     1.000  i/100ms
                Form     1.000  i/100ms
Form with type specs     1.000  i/100ms
Calculating -------------------------------------
              Schema     15.248  (±13.1%) i/s -     75.000  in   5.045985s
                Form      0.174  (± 0.0%) i/s -      1.000  in   5.749034s
Form with type specs     14.810  (±20.3%) i/s -     71.000  in   5.000067s

Comparison:
              Schema:       15.2 i/s
Form with type specs:       14.8 i/s - same-ish: difference falls within error
                Form:        0.2 i/s - 87.66x slower

closes #181

No more WIP. WDYT? /cc @AMHOL @fran-worley @jodosha @flash-gordon @mrbongiolo

@solnic looks awesome. Should we update all the specs to use the new definition syntax?

@fran-worley we should update all specs but first I gotta add type=>predicate inference so that we can simply write required(:foo, :str).filled vs required(:foo, :str).filled(:str?) or required(:bar, [:nil, :str]) vs required(:bar, [:nil, :str]).maybe(:str?)

@solnic happy to help update the specs. I think most of the pendings could be made live with this change too :)

@fran-worley that would be great, thanks!

You'll have to sort the jRuby issues... Definitely not my bag!

@fran-worley yeah I'll deal with that over the weekend, ran out of time today already

Reading through this again, this jumped out at me:

Notice that this is a pure sanitization/coercion schema without any rules.

This is the kind of thing I could us implementing closer to the routing/request handling layer of an app, so that the data being passed from it to an app's operations is coerced into proper types. However, if that operation then wanted to apply its own validation scheme with real business rules included, would it need to re-state all those type specs?

@timriley I keep thinking about this but I didn't manage to figure out how this should work in a way where you don't have to, well, repeat yourself too much :) We should explore this idea more prior 1.0.

Cool, sounds good 👍🏼

On 18 Jun 2016, at 6:10 PM, Piotr Solnica<EMAIL_ADDRESS>wrote:
@timriley I keep thinking about this but I didn't manage to figure out how this should work in a way where you don't have to, well, repeat yourself too much :) We should explore this idea more prior 1.0.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


PS2251-03 where to buy in 2016 year

V3SZK-016G-WH
TOSHIBA USB3.0 TransMemory-MX
https://goo.gl/NisgFx

Sandisk SDCZ48-016G
PS2251-03
https://goo.gl/88ASp7
Toshiba V3SZK-032G
PS2251-03
https://goo.gl/L0EK7u

I bought Sandisk SDCZ48-016G, this is the Getflashinfo:

I dont think thats PS2251-03, or am i wrong ;)


add --config-dir support to shellclear cli

I am not sure if this exists or is unnecessary but I couldn't figure out how to set the configuration files directory through the CLI and I want to save it in a different location than homedir.
So I decided to add this to the code, let me know if that works out for you.
Thanks.

@boaz-quotient I've approved running CI, you can take a look at the linting results for example, which might hints your editor isn't using fmt automatically. Would you like help with that?

Codecov Report

Merging #40 (246eb71) into main (6d6c7f1) will decrease coverage by 0.50%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   65.74%   65.24%   -0.51%
==========================================
  Files          17       17
  Lines        1559     1571      +12
==========================================
  Hits         1025     1025
- Misses        534      546      +12

Impacted Files
Coverage Δ

shellclear/src/bin/cmd/default.rs
0.00% <0.00%> (ø)

shellclear/src/bin/shellclear.rs
1.12% <0.00%> (ø)

shellclear/src/config.rs
88.51% <0.00%> (-3.10%)
:arrow_down:

shellclear/src/dialog.rs
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sorry for these chaotic updates. I changed the unit tests to use snapshot + added one more unit test (hopefully this will make the coverage happy)

No worries, everything looks good to me 👍
@kaplanelad is leading this project, when he'll be back from vacation he'll probably cut a new release :)

@jondot "ein bha-ya". No worries it's alright. I personally enjoyed practicing Rust on this project. Thanks for the opportunity.

Thanks, @boaz-quotientm bumped a new version 0.4.1/
Thanks @jondot for the backup :)


Swift4

Fixed #29

Thank @alexszilagyi, this merge request work very well with Swift 4 👍

i think mode should still be a public variable


Spectral library batch generation: .mgf with line break

Basic information

My operating system and version:Mac OS M1
My MZmine version: 3.30

What happened
MZmine 3.30 spectral batch library generation generate a .mgf with one line break per feature. This cause software crash during reuse of the .mgf library.
In attach the input used to create the library and the result (OutputMZmine.txt).
Other things I've noticed:

The line break is perhaps caused by PubChemCID field since there is no line break when not using this identifier during annotation
The field "INCHIAUX" instead of "INCHIKEY"
All features are duplicated, one with raw fragments and another with chimeric precursor selection: is there a way to export either raw or curated ones, not both in the same file?

Still, this is really an interesting adds to mzmine!!
Congrats for the job
Outputmzmine.txt
MZmineinput.csv

We are currently still in the process to restructure some of the library generation aspects. Great to see that you are already using it.

I will have to look into the pubChemCID thing. So you added them during compound annotation and then the mgf gets a break?
INCHIAUX came from GNPS but we are now naming it INCHIKEY in the future.
Why duplicated? So the idea is that we merge all spectra with the same energy (if there are multiple per precursor) then we merge all spectra of different energies.

Exported are the single best/most intense spectra and the merged spectra.

Once this is finished you can download the latest library generation version at the bottom
https://github.com/mzmine/mzmine3/actions/runs/3748621655

Dear Robin,
thanks for your reply, Yes PubChemCID comes from MZmineinput file used in "local database search" module.
Then the idea was to transform results in MS/MS library file.
I ran some test and indeed the line break appears when INCHIAUX (so inchikey) are added in the metadata, not PubchemCID as I thought before.
I'll follow the update
thanks again
G.


playbooks: use meta playbooks generated by "tdp-lib"

/!\ BREAKING CHANGE /!\ Playbook playbooks/all.yml is moved to playbooks/meta/all_per_service.yml. The playbook playbooks/meta/all.yml follow tdp-lib DAG order.
Generated by https://github.com/TOSIT-IO/tdp-lib/pull/101

@leopaul36 For me it is ready to merge, the new playbooks/meta/all.yml is working with the actual DAG.


CollisionObject2D can no longer get shapes from TileMaps

Godot version
4.0.beta2
System information
Windows10, Vulkan API 1.2.0 - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce RTX 2080 Super with Max-Q Design
Issue description
PR #25649 added the ability for CollisionObject2D to get shapes from TileMaps via use_parent.
This feature still exists in the latest 3.5.1-stable but in 4.0.beta2 that feature is no longer available.
use_parent is missing from TileMap. This means objects inheriting from CollisionObject2D like RigidBody2D can no longer get collision shapes from TileMap.
Steps to reproduce
Reproduction Steps:

Create Node2D as root (/Node2D)
Create child RigidBody2D (/Node2D/RigidBody2D)
Create child TileMap (/Node2D/RigidBody2D/TileMap)

RigidBody2D will show ⚠ in 4.0.beta2 because collision shape can not be found.
4.0.beta2

3.5.1

Minimal reproduction project
Minimal project with hierarchy described above created in 3.5.1-stable.
godot-tilemap-use-parent.zip

I have a project that used this feature heavily. If I want to port it to 4.0, I basically have to rebuild it from scratch, without using TileMaps at all. That's a shame, because they were perfect for this project in 3.x.


Use Bio::EnsEMBL::Gene object to get colour key

Instead of EnsEMBL::Web::Object::Gene ...
Fixes ENSEMBL-4805.

Hi - does transcript supporting evidence work with this change ?

Hi @ens-st3, not sure about what you mean and how to test it. But this change will only affect the $gene variable at this line (https://github.com/Ensembl/ensembl-webcode/blob/release/87/modules/EnsEMBL/Draw/GlyphSet_transcript.pm#L1461). It will only affect items that have colour_key such as [gene.logic_name]_[gene.biotype]. Maybe @ens-ap5 will know?

Won't it also potentially affect $colour (https://github.com/Ensembl/ensembl-webcode/blob/release/87/modules/EnsEMBL/Draw/GlyphSet/TSE_transcript.pm#L43) ?
TSE_transcript is used for supporting evidence, for example:
http://www.ensembl.org/Homo_sapiens/Transcript/SupportingEvidence?db=core;g=ENSG00000128573;r=7:114414997-114693768;t=ENST00000403559
I can't find an example in plants though - can you check if if you have any ? The data for these comes from the supporting_feature and transcript_supporting_feature tables.

I checked Metazoa and found the changes works for this page: http://metazoa.ensembl.org/Anopheles_gambiae/Transcript/SupportingEvidence?g=AGAP004707;r=2L:2358158-2431617;t=AGAP004707-RA

Confirmed OK with Ensembl as well. Thx


⚠ Cioos National CKAN Sitemap has degraded performance

In 8743553, Cioos National CKAN Sitemap (https://catalogue.cioos.ca/sitemap/sitemap-1.xml) experienced degraded performance:

HTTP code: 200
Response time: 5420 ms

Resolved: Cioos National CKAN Sitemap performance has improved in 2345eab after 50 minutes.


 It would be a lot better if there was a standard way to define a deployment target, maybe even with a constructor.

In Terraform and in Typescript?


List the PackageIdentifier of the package to be added to automation
zafaco.Breitbandmessung
Details about the application
https://download.breitbandmessung.de/bbm/latest.yml

There is not a single update of the application till now. I doubt if it will ever be updated.

@SpecterShell There is not a single update of the application till now. I doubt if it will ever be updated.

It is common for some applications 🙃


Ensure priority scheduling

An annotation, deprecated in Kubernetes 1.16 and no longer functional,
was used to ensure priority scheduling. Use priorityClassName to achieve
same result.
Signed-off-by: Steven Dake<EMAIL_ADDRESS>Please ensure your pull request adheres to the following guidelines:

[X] For first time contributors, read Submitting a pull request
[X] All code is covered by unit and/or runtime tests where feasible.
[X] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[X] All commits are signed off. See the section Developer’s Certificate of Origin
[X] Provide a title or release-note blurb suitable for the release notes.
[X] Thanks for contributing!

Fixes: #issue-number
- Ensure priority scheduling of CNI agent. Repair a deprecated Kubernetes annotation. The annotation was used to schedule pods at high priority. This deprecation, which occurred in Kubernetes 1.16, results in unexpected behavior.

@sayboras @christarazi @gandro,
Hi gang.
This PR needs manual intervention from a maintainer to  run the workflow. Would someone be kind enough to ping a maintainer if you yourselves don't have ACLs?
Cheers,
-steve

Three maintainers were randomly selected to run the workflow as this was my first commit to this GitHub organization. Would someone be kind enough to see: https://github.com/cilium/cilium/pull/18667#issuecomment-1049576022
@danwent @lizrice @vadorovsky
Cheers,
-steve

Thank you @sayboras I noticed a maintainers file in the repo on a rebase, so I pinged 3 at random.
Cheers,
-steve

Thanks for squashing and apologies for the delay. Please let us know via comment when push to a PR to address requested changes, this unfortunately slipped my review queue due to the lack of new comments since you pushed.
Changes approved, I will run the test suite now.

/test

Marking ready to merge. All tests have passed (L4LB XDP is skipped due to this PR not changing any related code).


Deprecated class warnings when starting Nautobot

Environment

Python version: 3.9
Nautobot version: 1.4.5
nautobot-circuit-maintenance version: 0.6.0

Expected Behavior
No warnings.
Observed Behavior
When I start Nautobot and run the post_upgrade command I can see a lot of warning messages saying class XYZ is deprecated.
06:21:09 WARNING Class CustomFieldModelForm is deprecated, and will be removed in a future Nautobot release. Instead of deriving CircuitImpactForm from CustomFieldModelForm, please migrate your code to inherit from class CustomFieldModelFormMixin instead. - nautobot.utilities.deprecation - forms - /usr/local/lib/python3.9/site-packages/nautobot_circuit_maintenance/forms.py:34
06:21:09 WARNING Class AddRemoveTagsForm is deprecated, and will be removed in a future Nautobot release. Instead of deriving CircuitImpactBulkEditForm from AddRemoveTagsForm, please migrate your code to inherit from class TagsBulkEditFormMixin instead. - nautobot.utilities.deprecation - forms - /usr/local/lib/python3.9/site-packages/nautobot_circuit_maintenance/forms.py:53
06:21:09 WARNING Class CustomFieldModelForm is deprecated, and will be removed in a future Nautobot release. Instead of deriving CircuitMaintenanceForm from CustomFieldModelForm, please migrate your code to inherit from class CustomFieldModelFormMixin instead. - nautobot.utilities.deprecation - forms - /usr/local/lib/python3.9/site-packages/nautobot_circuit_maintenance/forms.py:62
06:21:09 WARNING Class CustomFieldFilterForm is deprecated, and will be removed in a future Nautobot release. Instead of deriving CircuitMaintenanceFilterForm from CustomFieldFilterForm, please migrate your code to inherit from class CustomFieldModelFilterFormMixin instead. - nautobot.utilities.deprecation - forms - /usr/local/lib/python3.9/site-packages/nautobot_circuit_maintenance/forms.py:73
06:21:09 WARNING Class AddRemoveTagsForm is deprecated, and will be removed in a future Nautobot release. Instead of deriving CircuitMaintenanceBulkEditForm from AddRemoveTagsForm, please migrate your code to inherit from class TagsBulkEditFormMixin instead. - nautobot.utilities.deprecation - forms - /usr/local/lib/python3.9/site-packages/nautobot_circuit_maintenance/forms.py:104
06:21:09 WARNING Class CustomFieldModelForm is deprecated, and will be removed in a future Nautobot release. Instead of deriving NoteForm from CustomFieldModelForm, please migrate your code to inherit from class CustomFieldModelFormMixin instead. - nautobot.utilities.deprecation - forms - /usr/local/lib/python3.9/site-packages/nautobot_circuit_maintenance/forms.py:116
06:21:09 WARNING Class AddRemoveTagsForm is deprecated, and will be removed in a future Nautobot release. Instead of deriving NoteBulkEditForm from AddRemoveTagsForm, please migrate your code to inherit from class TagsBulkEditFormMixin instead. - nautobot.utilities.deprecation - forms - /usr/local/lib/python3.9/site-packages/nautobot_circuit_maintenance/forms.py:127
06:21:09 WARNING Class CustomFieldFilterForm is deprecated, and will be removed in a future Nautobot release. Instead of deriving RawNotificationFilterSetForm from CustomFieldFilterForm, please migrate your code to inherit from class CustomFieldModelFilterFormMixin instead. - nautobot.utilities.deprecation - forms - /usr/local/lib/python3.9/site-packages/nautobot_circuit_maintenance/forms.py:147
06:21:09 WARNING Class AddRemoveTagsForm is deprecated, and will be removed in a future Nautobot release. Instead of deriving NotificationSourceBulkEditForm from AddRemoveTagsForm, please migrate your code to inherit from class TagsBulkEditFormMixin instead. - nautobot.utilities.deprecation - forms - /usr/local/lib/python3.9/site-packages/nautobot_circuit_maintenance/forms.py:180

I think this happens for all Nautobot 1.4.x versions.
Steps to Reproduce

Install plugins
Run the post_upgrade command.

Don't fret! These are just warnings.

@chadell yes this is a duplicate.
@jathanism we should try to go back and update plugins to use the new pattern. Can be misinterpreted and cause undue concern when updating to v1.4. The update would either require dropping support or conditional imports.

fixed with new cookiecutter updates


Set index default replicas=0, shards=1

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Breaking default configuration change

What is the current behavior? (You can also link to an open issue here)
Default shards=5 and replicas=1. This is a suboptimal and storage intensive default.

What is the new behavior (if this is a feature change)?
Default shards=1 and replicas=0.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
A minor one. If users programmatically create Marqo indexes, and don't explicitly set these values, they will get an unexpected index configuration.

Have unit tests been run against this PR? (Has there also been any additional testing?)
Tests:

unit tests: https://github.com/marqo-ai/marqo/actions/runs/5527339268
cuda tests: https://github.com/marqo-ai/marqo/actions/runs/5527340765

Related Python client changes (link commit/PR here)
n/a

Related documentation changes (link commit/PR here)
TODO

Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added / updated (for bug fixes / features)

We also have a branch, where default_shards=2, replicas=0:
pandu/default_shards_update_2_shards
running tests:

unit tests: https://github.com/marqo-ai/marqo/actions/runs/5548834505
API tests: https://github.com/marqo-ai/marqo/actions/runs/5548845201

Closed, as this PR is replaced by https://github.com/marqo-ai/marqo/pull/539


Add FlipFlop Index

Can you provide more information about this metric?

Why we should include it?
It's value
Paper details?

Can you provide more information about this metric?

Why we should include it?
It's value
Paper details?

The two papers are https://rmets.onlinelibrary.wiley.com/doi/full/10.1002/met.1732 and https://www.publish.csiro.au/ES/ES21010
It's required for Jive and is used internationally (it's already in Jive, we just need to migrate it across).
@aidanjgriffiths may be able to make a start on it.


m3u video format support for asbplayer website

There is such a wonderful program as Tor Server; it allows you to paste a torrent link, then press the "playlist" button. After that, it gives you an .m3u file that you can watch in a video player. It works in VLC, and I really want to be able to do the same on the asbplayer website because now it says what it is format is not supported

@miroshQa Why did you close the issue?

@miroshQa Why did you close the issue?

Sorry, it was bad of me to close the issue without comments
I closed this issue because I found more problems with this player than the lack of m3u support.
Specifically, I can”t select an audio track and also don”t have sound when playing a local video.
As a result, I launched the video locally in Jellyfin and all the listed problems were solved there
And as for the m3u, I realized that uploading videos before watching is quite a normal option.


adjust to use id attribute

document my patch

There's a compelling case to be made for using ID rather than NAME. The use of name relies on an HTML 4 non-feature. Namely that browsers respect the name attribute on all tags, even though the only non-input tag it was specified for was the  tag.
But now, in HTML 5, it's not even specified for the  tag. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#attr-name
So yes, we should probably stop using it.
However, ID's must be unique on the page. We shouldn't replace broken html with html that is merely broken in a different way.
I think we can do a couple things to help ensure that ids are unique.

Keep a hash of strings that we've already used, and append a number if it's used twice. Issue https://github.com/leff/markdown-it-named-headers/issues/3
Namespace the ids by prepending an ID. Issue https://github.com/leff/markdown-it-named-headers/issues/4

It is my intent to make the next release be the sum of this pull request and these two issues.

Sorry this took so long. Merged. Preparing the release for today.


Add the ability to stream download to stdout

People have been poking me about how to download Xcode because copying curl commands with cookies is kind of annoying. It would be nice if I could just point them at xcodes and let them pipe the output of that into whatever streaming tools want to handle the results.

Hey @saagarjha - first thanks for the tool!
I looked into updates Xcodes to handle your changes on unxip, but a few things came up. 1) aria2 doesn't support standard output, 2) neither does urlsession (The 2 options currently for network).
So we'd have to use regular curl calls - not that it couldn't be possible, just letting everybody know what the option would have to be.

URLSession definitely supports streaming downloads that you can hook up to standard out. The easiest way to do this, if you support Swift Concurrency, is to just use the functions returning an AsyncBytes. Otherwise you can wire up one of the delegate methods to dump the data as it arrives.

Thank you - i have something to learn about! Currently the CLI uses PromiseKit still. There is an ongoing effort to have a single framework(to rule them all) so both CLI and UI use the same code to do most of their features.


Dependency on now-outdated APC cache

https://github.com/silverstripeltd/frisp/blob/master/Frisp/Reader.php#L21-L28
Logs a notice if APC is not installed - which is the case with >PHP7. This means we can't read from the vault nicely (the notice obscures the actual return value) and deployments fail.
I've added APCU into our baseboxes to restore functionality, but this should be replaced with memcached or opcache probably.

APCu is still maintained, so should be an acceptable replacement.
OPcache seems to be purely for op code caching of php files, so can't be used as a replacement. memcached could be used but if you're thinking about various backends, then maybe implementing a PSR-6 cache library would be better..

Not a problem, as it uses APCu, it just looks like the caching library is using APC (without the U)


Replace the objectFromEntries helper function with an objectFromMap one instead, and simplify the data lookup in the AnnotationStorage.getValue method

Replace the objectFromEntries helper function with an objectFromMap one instead
Given that it's only used with Maps, and that it's currently implemented in such a way that we (indirectly) must iterate through the data twice, some simplification cannot hurt here.
Note that the only reason that we're not using Object.fromEntries(...) directly, at each call-site, is that that one won't guarantee that a null prototype is being used.

Simplify the data lookup in the AnnotationStorage.getValue method
Rather than first checking if data exists before fetching it from storage, we can simply do the lookup directly and then check its value.
Note that this follows the same pattern as utilized in the AnnotationStorage.setValue method.

Thanks!


DRILL-4967: Adding template_name to source code generated using freem…

…arker template.

@amansinha100 , could you please review this PR? Thanks!

+1


Typo AZURE_COSMOSEDB_URI and AZURE_COSMOSEDB_KEY

Typo AZURE_COSMOSEDB_URI and AZURE_COSMOSEDB_KEY
AZURE_COSMOSDB_URI
AZURE_COSMOSDB_KEY

@microsoft-github-policy-service agree

Please note: the code uses the AZURE_COSMOSEDB_KEY and AZURE_COSMOSEDB_URI names, so it needs to be corrected everywhere.

https://aka.ms/anzappazurechatgpt
The configuration created by the above deployment also appears to be AZURE_COSMOSEDB_URI and AZURE_COSMOSEDB_KEY.

@jkudo Thank you for looking into this issue. The typo was fixed as part of another PR.
Looking forward to your future contributions


WriteToSubresource fails with E_INVALIDARG

Hi,
I am trying to write to a texture using ID3D12Resource::WriteToSubresource but it fails with E_INVALIDARG. Then I learned from documentation that resource needs to be mapped. Map command also fails with E_INVALIDARG. I create texture using CreateCommittedResource, I have tried various heap flags and initial resource states, but still no success. Any help would be appreciated.
Thanks
Ankit Jain

You can't write directly to textures without using a custom heap pool. It's generally not a good idea unless you're on a UMA device anyway

Anytime you get E_INVALIDARG back from DirectX, your best option is to enable the debug layer and look at the debug output. It will explain why it's not supported in most cases.
https://docs.microsoft.com/en-us/windows/win32/direct3d12/directx-12-programming-environment-set-up


Added support for standalone Eloquent

The trait does not work correctly when using standalone Eloquent. Events are not fired and the class type is not set. The full version of Laravel sets an event dispatcher but that doesn't happen with standalone Eloquent. Therefore, when booting, we check for a dispatcher. If one doesn't exist, it's created and registered with Eloquent.

How can we test this usecase?

Closing due to age

Closing due to age


Autocomplete: Fix Scrollable List Touch

Description
I think this is the last PR about autocomplete close issue and about #4326.
Removed all touch events from autocomplete, because @henon already revert and fixed the popover issue. We don't need anymore about touch events, it already works in mobile.
How Has This Been Tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[ ] I've added relevant tests.

Thanks. I will release a dev nuget for testing


Fix: Quad quoting

double and double quoting...

Sorry...
This subject main stream is https://github.com/gmarik/vundle/pull/148


GCM with IOS image is not showing

Bug Report
Hi i am using GCM to send notification to ios  devices . image i am sending but its not showing in notification only text is coming. even picture is not working . but its working properly on android. please help me.
My payload is like
"registration_ids":["xxxxxxxxxxxxxxxxxxxxxx"],
"notification":{
"title": "Test",
"body":"test",
"image":"http://xxxxxxxxx/sap/public/bc/ui2/logon/img/Airdit.png",
"picture": "http://36.media.tumblr.com/c066cc2238103856c9ac506faa6f3bc2/tumblr_nmstmqtuo81tssmyno1_1280.jpg",
"summaryText": "The internet is built on cat pictures"
Expected Behaviour
Actual Behaviour
Reproduce Scenario (including but not limited to)
Steps to Reproduce
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
(Android) Device Vendor (e.g. Samsung, HTC, Sony...)
cordova info Printout

Sample Push Data Payload
Sample Code that illustrates the problem
Logs taken while reproducing problem

SSL IS MISSING ... YOU NEED HTTPS

Did you solved it?  I'm having this issue too

I believe this is not directly available in IOS and you might need this: https://www.raywenderlich.com/8277640-push-notifications-tutorial-for-ios-rich-push-notifications

This plugin does not support displaying the image in iOS notifications.


Feature Request: allow to pick the color of the tabs

Description of the new feature/enhancement
Hello everybody, I think it is a good idea to give the user the possibility to pick colors of the currently opened tabs. The use case is the following: I use command line git and I work on multiple projects in parallel. This means that I have multiple tabs, each for a different git repo.
I want to be able to differentiate at a quick glance which tab is for which folder/repo/project/whatever and a tab color (if I can set one) is very strong visual cue.
For example, Visual Studio Code has the Peacock extension, which gives you the possibility to color your editors differently, according to the project you are currently working on.
Visual Studio has similarly SolutionColor
Proposed technical implementation details (optional)
What I imagine is that, if the user does a right click on a tab, a menu is shown, with an element called 'Choose a color' or something similar. When the element is clicked,  a simple color picker (ala OneNote) is displayed:

Then there are two possibilities:

the simple one is that the tabs are colored in the selected color and after the application is closed, this information is lost
the more complex one: the application takes note of the current working dir of the shell, belonging to the tab and as long as the shell remains in this folder or a subfolder, the tab is colored in the chosen color. If this is even possible, one can store the folder/chosen color list in the settings and restore the tab colors, after the application is restarted.

If this is interesting to you, I would like to try to implement it. What are your thoughts?
Regards

If the Tabs are to be given Context Menus with Close, Rename options etc - this could be a Sub Menu Flyout

I really like this idea. I'd note that doing this based on the working directory of the child process might just be impossible, but just setting the color isn't a bad idea.
I'm also wary of doing anything to write the settings file currently, so I'd definitely lean towards an initial implementation only setting the color at runtime, and not persisting it. Sure, we'll be back in the business of writing the settings file when we have a proper Settings UI (#1564), but lets just avoid that for now. Maybe later we could add an optional "make this change temporary" checkbox that lets the user persist the changes.
I'd also add that personally, I'd reject any PR if it didn't also include a "choose my own color" option. I hate when I have to pick from an application's palette of colors. It's 2019. There are 16.7 million colors to chose from, not 16. 16 colors can be a good suggestion, but sometimes I just want more than 3 blues 😝
Related:

#1079 - this deals with setting a (temporary) title at runtime through a similar UI
#702 - another request for styling the tab, though not at runtime

I do feel however that this might be something that's better suited for an inevitable extensibility model. Maybe we could incorporate it directly temporarily, then later move to an external extension. It certainly seems to hit on a few good extension requirements:

adding an element (the menu flyout item) to an existing UI element (the tab right-click MenuFlyout)
Changing the styling of an existing UI element (changing the BG of the TabViewItem)
displaying its own UI (the color picker)
possibly writing a setting? We don't really have a design for Theme settings quite yet, but this seems to fall into that category.

It would certainly be a good case study IMO. I'm going to tag it up for that purpose.

This is largely similar to #1337, which had another issue about right-clicking a tab to set its color duped into it, but it puzzlingly has no mention of that functionality.

Yea I see that. Considering we left "add a setting to change the tab title" and "add a menu to change the tab title at runtime" as separate issues, I felt this could stand on its own as well.

Also slightly related: #1868.

Hello folks,
thank you very much for the comments.
@zadjii-msft  Yes, I'm going to implement the simple scenario. I haven't looked at the code, but I assumed that is quite likely that the terminal is not aware where or what the shell, which it is hosting, is doing. No settings involved, you can simply set the color for the session and that is.
Considering that you've mentioned

an inevitable extensibility model

I take it that you currently do not have a plugin or similar system in place, correct?
Also, agreed - there must be an option to pick your own color (maybe you can talk to the OneNote guys about this - this is where the screenshot comes from 😉  )
@DHowett-MSFT I searched for
is:issue is:open tab colors
and not for
is:issue is:open tab color
This is why I did not see #1337, sorry 🤦♂ .
I'm going to try to drop you a PR next week, it is Hactoberfest and all :)
Regards

WinUI includes a colour picking control, you would have to handle opening a dialog with the control in for any custom colour.

Just wondering: Do you guys think it makes sense for the 16 initially offered colors to be the configured palette colors of the given terminal?
This is probably by far not the best set of 16 colors per se, but gives a more consistent overall appearance, and are colors that users can mentally connect to existing contexts within the terminal. They would also auto-follow the user's preference regarding the color palette, including more exotic ones such as Solarized, on a per-tab basis.
To second zadjii, I agree that there should be a way to pick any of the 16M colors. Probably even offer a shorthand for several LRU ones.

@egmontkob That's certainly where I'd start with this feature, though I'm not really qualified to be a UX designer 😜

Me neither :stuck_out_tongue_winking_eye:

@egmontkob  I think eventually you want the Tab colour to be stored in the settings, but they want to implement it first without making it persist.
I don't think you need to store more than the one colour, so adding 16 colours to every profile's settings, is probably overkill, and not useful

@egmontkob  Ok I get you know.  You want the default colours offered to be pulled from the profile.

I don't want it, I threw this in as an idea :)

Hi everybody,
so I'm working on this at a glacial pace, but I've ran into a problem. I've created a menu flyout and I set it as as a context flyout of the tab as follows:
_tabViewItem.ContextFlyout(tabContextFlyout)
If I try to right click the tab or click the split button to choose a tab profile, if I'm debugging, I'm getting the following exception:
Exception thrown at 0x00007FFADCEDA839 (KernelBase.dll) in WindowsTerminal.exe: WinRT originate error - 0x80070490 : 'Element not found.'.
Exception thrown at 0x00007FFADCEDA839 in WindowsTerminal.exe: Microsoft C++ exception: winrt::hresult_error at memory location 0x000000ED0594B380.
But if I try to run the program without the debugger, I can see the menu flyouts displayed properly. Do you have any tips whether or not this exceptions could be avoided?
Overall I have terrible experience building and running the project :(

Ugh, that one drives us crazy. We haven't figured out what causes it, but it may be helped by #1896 (in PR at #3027.)

It turns out that #3027 didn't fix this, so I'll see if we can't get a followup filed on the MUX team.

Alright @DHowett-MSFT thank you very much for reponding and checking :)

Hello again @DHowett-MSFT,
so I was quietly working on this and did some progress:

But now I've noticed that you've mentioned the issue in #3327 . The first question I have is: how does the work I did align with #3327 ? Should I drop everything, or put it on hold or simply continue?
If you want me to continue I would like to get some help/directions :)

If you have multiple colored tabs, I'm not sure how to signify which is the selected one. I cannot set the other tabs to transparent, since I want to see the colors on a cursory glance. I've played with the idea to make the selected tab bigger via RenderTransform, but I think it looks kinda ugly.
For now I've set the transparency to the unselected tabs to very high, but this has some issues as well

Ideally I would put the 'Choose a color'/'Clear Color' menu items in a single sub-menu item. The problem is that if I do that, the app crashes randomly when I open the tab menu and since I cannot open the menu flyout in the debugger anyway, I have no idea what is going on. Is the current menu structure ok for you?

there is some weird behavior when I set the color of a tab (the first tab is an exception) and I add new tabs, see for yourself:

Any idea what this is maybe?

the one thing that is currently completely open is the picking of a custom color, but this should not be that difficult.

Regards

@gbaychev I love this! It looks so nice.
To answer your questions:

#3327 is more about theming the application -- I don't think it detracts from your work here.
A user should be able to have a base theme and then set custom individual tab colors on top of it.
Design for selected tabs: I'm interested in seeing what @cinnamon-msft has to say here. I like how it looks in the video.
Choose/clear -- perhaps it should be a button/color in the color picker that opens up? Sorry about the crash, and the issue with it eating it during debugging. I can't tell exactly whose fault that one is, but it's somewhere between Microsoft.UI.Xaml (the open-source Xaml) and Windows.UI.Xaml (the Windows internal one)
Weird behavior for not-first tabs: I wonder why that is... How are you changing the TabItem?

With a bit of architectural work, you can also close #1912. :smile:
Thanks for looking at this! Feel free to submit a draft pull request if you want to get some early feedback on your implementation, by the way: It's a lot easier to talk about code!

Finally getting down my inbox - this is incredible work. I'd be really excited to look through a draft PR for this.
IMO we could probably ship this without having a better solution for the "selected tab"'s appearance. I think with the graying out that the TabRow does already, and the fact that the user has to set this color at runtime, the user already knows what color they think the tab is when it's selected vs when it's not.
I agree with @DHowett-MSFT - let's put the "Clear Color" button on the color picker below the "Select custom color" button.
I'd be happy to take a look into the weirdness surrounding the non-first tabs. I'm really excited about this feature, so I'm happy to help :)

The clear colour option could be a swatch with a line diagonal in it.  This is how clear is represented in other applications from Corel and Adobe.

I agree that it is very hard to signify the current tab with custom tab colors, and it can leave the UI looking pretty ugly. The windows terminal has a great UI, and I wouldn't want that to be ruined.
Here's what I propose:

This is a screenshot of Firefox containers. You can see with the orange bar that you can color specific tabs based on these containers. It's very clear for color coding tabs, and it doesn't interfere with the UI. Additionally, it's clear which tab is currently selected.

That looks even better! It also looks a lot more Windows-esque which makes sense for this terminal.

This looks really promising!  I just raised a feature-request (https://github.com/microsoft/terminal/issues/3687)  that suggested using the theme mechanism for this (so as to have a better chance of ending up with consistent text/background colors) but I'd be very happy with this as a solution!

Hello folks,
thank you very much for the kind feedback and suggestions.
I just want to give you a heads up that - no, I'm not dead and I did not give up on this feature. But I have my job and private stuff I need to take care of, so I think you understand.
I'm going to try to submit a work in progress PR next week, so that you can take a look at.
What is the current situation:

I need to move the clear color menu element to the color selection flyout
I need to implement the selection of the custom color

I've already thought about the Firefox way of highlighting the selected tab, as @ShiromMakkad suggested, but the problem is I'm not sure how to implement it.
If I try to create a custom TabViewItem, the midl compiler throws its hands in the air, because there are some attributes in the TabViewIteml.idl, which are defined in a header, which I have no access to (see here). I have no idea what happens if I simply redefine them.
I also tried to use a Gradient Brush with a very sharp gradient to emulate this effect, but it looks terrible.
Maybe a solution would be to paint the frame of the whole window in the tab's color, see for example the tabs of the stash in Path of Exile:
. Do you notice how the frame of the stash is also painted green?
As for the question of @DHowett-MSFT (how do I change the tab item) - I simply push some colors in the resource dictionary of the TabViewItem (e.g. TabViewItemHeaderBackground) and switch the visual state using the VisualStateManager, so that the changes are reflected immediately. Even if I remove the visual state code, the weird issue persists.
Another question, the branch of my repo is based on your master branch. Is this correct, or I should've taken another branch?
I think this is all for now.
Best regards

Glad to hear you're not dead 😜
So, in my opinion, it's probably better to get this checked-in in it's current state, and continue to iterate on the design in future releases. We can work with @teap and other XAML folks to help us style it as an underline/overline on the tab later, but it's probably best to get the fundamentals there now.

PR is dropped, as promised.


Can't train with fp16 on Nvidia RTX3060

training with fp16 doesn't work for me on a RTX3060, I'll look into fixing it, but for future reference here is the full stacktrace
torch version 1.9.0
INFO:torch.distributed.distributed_c10d:Added key: store_based_barrier_key:1 to store for rank: 0
INFO:torch.distributed.distributed_c10d:Rank 0: Completed store-based barrier for 1 nodes.
THCudaCheck FAIL file=/pytorch/aten/src/THC/THCCachingHostAllocator.cpp line=278 error=710 : device-side assert triggered
terminate called after throwing an instance of 'std::runtime_error'
what():  NCCL error in: /pytorch/torch/lib/c10d/../c10d/NCCLUtils.hpp:158, unhandled cuda error, NCCL version 2.7.8
ncclUnhandledCudaError: Call to CUDA function failed.
RuntimeError: CUDA error: device-side assert triggered
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.

maybe problem in too new torch version, have you tried 1.8.1+cu111 ?


Workaround Crowdin bug where integer yaml keys are not preserved

When downloading in-context localisation files, integer keys in YAML files are not preserved. This is only an issue in the file topics/content/en/programming-challenges-structure-difficulties.yaml, which uses the difficulty number as the key.
As a work around, we can use the string value of the integer as the key, i.e. "0" instead of 0

Turns out it still fails even with forced string keys, if they are integers. Instead, we will need to modify the keys to [a-zA-Z] identifiers


can not recognize '.pyx' file (python C extensions)

VSCode Version: Code 1.14.2 (cb82febafda0c8c199b9201ad274e25d9a76874e, 2017-07-19T23:26:08.116Z)
OS Version: Linux x64 4.4.0-89-generic
Extensions:

Extension
Author (truncated)
Version

python
don
0.7.0

Steps to Reproduce:

Reproduces without extensions: Yes/No

@ChainGank please file an issue against the python extension here: https://github.com/DonJayamanne/pythonVSCode/issues Thanks!


Fix NodePort when endpoint is in host netns

Previously, the reverse DNAT translation for a reply from a local
NodePort endpoint was done only in bpf_lxc via the
CILIUM_CALL_IPV{4,6}_NODEPORT_REVNAT tail call.
This was breaking a case when a NodePort endpoint was running in the
host netns (bpf_lxc is not attached to endpoint in the host netns).
Therefore, a reply from such endpoint was never rev-DNAT xlated.
Fix this by performing the xlation from bpf_netdev's to-netdev (egress).
Fix #10402.

test-me-please

Coverage decreased (-0.002%) to 45.525% when pulling 400e8c2d2f11bc84bd327bb40de7d34bc8fead66 on pr/brb/fix-nodeport-hostnetns into 3486b3f737f6fb2a374dcc12ce4e7e8f99ee323c on master.

test-me-please

test-me-please

test-me-please

Marking as wip, as the case when endpoint is remote still failing.

test-me-please

test-me-please

test-me-please

Discussed during the sig-datapath meeting: a new flag will be introduced to enable svc endpoints in host netns. Depending on the flag value, svc rev-DNAT xlation will take place in bpf_lxc (if disabled), or in bpf_netdev (if enabled). This is to avoid perf penalties for users who don't have endpoints in host netns, as for each outbound packet a CT lookup is done on the fastpath of bpf_netdev to-netdev.

this PR has been marked as a draft PR since it had a WIP label. Please click in "Ready for review" [below vvv ] once the PR is ready to be reviewed. CI will still run for draft PRs.

@brb Is this PR still relevant? I see that the issue that it should fix has had more recent activity, but this PR has been stale for over six months.

@joestringer We are planning to continue to work on this feature in the v1.10 cycle, so let's keep it open.

Superseded by https://github.com/cilium/cilium/pull/17504.