AsyncOAuthFlow run_installation missing team_name and enterprise_name fields in returned Installation

Reproducible in:
pip freeze | grep slack
python --version
sw_vers && uname -v # or `ver`

The slack_bolt version
slack-bolt==1.1.4
reproduced on fresh checkout of main
Python runtime version
Not relevant for this bug but Python 3.6.9.
OS info
N/A
Expected result:
See non-async OAuthFlow.run_installation
Actual result:
See AsyncOAuthFlow.run_installation
The fields team_name and enterprise_name are not pulled out of the request for use in the Installation.
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

@jwelch92 Thanks a lot for taking the time to report this!
Yes, you are right. This is a bug in AsyncOAuthFlow. We will be fixing this issue early next week. If it is urgent for you, a workaround is to have your own AsyncOAuthFlow subclass and override the method.

@jwelch92 Thanks a lot for taking the time to report this!
Yes, you are right. This is a bug in AsyncOAuthFlow. We will be fixing this issue early next week. If it is urgent for you, a workaround is to have your own AsyncOAuthFlow subclass and override the method.

@jwelch92 Thanks a lot for taking the time to report this!
Yes, you are right. This is a bug in AsyncOAuthFlow. We will be fixing this issue early next week. If it is urgent for you, a workaround is to have your own AsyncOAuthFlow subclass and override the method.

Thanks @seratch! I ended up working around it for now but I will update as soon as this is fixed and released. I uncovered another unrelated issue while working on this so I'll file a separate ticket.

@jwelch92 Thanks a lot for taking the time to report this!
Yes, you are right. This is a bug in AsyncOAuthFlow. We will be fixing this issue early next week. If it is urgent for you, a workaround is to have your own AsyncOAuthFlow subclass and override the method.

Thanks @seratch! I ended up working around it for now but I will update as soon as this is fixed and released. I uncovered another unrelated issue while working on this so I'll file a separate ticket.


Known top-level properties does not block compilation if not defined in the resource schema

Using properties such as sku, identity, kind on a resource will be treated as warning instead of error if it's not defined in resource type swagger specs.
Additionally, if a user uses a property that is not defined, a warning message has been extended with a link to place collecting user reports on type inaccuracies.
Fixes #3000
Fixes partially #949 #3494
Contributing a feature

[x] I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
[x] I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
[x] I have appropriate test coverage of my new feature

Thank you for getting this done @miqm -- unblocking some critical scenarios!


[Doc-enhancement][Update-channeldata-in-personal-conversation][]

Docs Build status updates of commit 5215957:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/bot-v3/bot-conversations/bots-conversations.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/bot-v3/bot-conversations/bots-conversations.md
83
46
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Hi @v-habibaumme , please help me understand what is the next action required to complete this update?

@v-npaladugu - Could you please remove the below line from documentation:
Doc section for ref : https://docs.microsoft.com/en-us/microsoftteams/platform/resources/bot-v3/bot-conversations/bots-conversations#teams-channel-data
UI

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/bot-v3/bot-conversations/bots-conversations.md
83
45
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit a9a4d73:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/bot-v3/bot-conversations/bots-conversations.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Deploy

Deploy

Grr, it turns out a commit was missing from https://github.com/artsy/force/pull/10055. Waiting for that to cycle and will then merge this.


No longer works on SceneBundles

Sorry if this is a simple mistake but this crate used to work in bevy 10 for SceneBundles, I can't seem to get it to load a scene in 11.2
I have a simple SceneBundle, I've registered the type TestCarScene, the save.ron file does save the component correctly however when calling load_from_file("./data/save.ron") it no longer renders the scene. Am I missing something simple? I have regeneration systems for other visual components such as meshes however I swear the scenebundle use to just work out of the box.
#[derive(Component, Default, Reflect, Debug)]
#[reflect(Component)]
pub struct TestCarScene;

pub fn add_test_car(mut commands: Commands, object_assets: Res<ObjectAssets>) {
    commands.spawn((
        SceneBundle {
            scene: object_assets.free_car.clone(),
            transform: Transform::from_xyz(2.0, 0.03, 3.0)
                .with_rotation(Quat::from_euler(
                    EulerRot::XYZ,
                    (0.0_f32).to_radians(),
                    (180.0_f32).to_radians(),
                    (0.0_f32).to_radians(),
                ))
                .with_scale(Vec3 {
                    x: 0.10,
                    y: 0.10,
                    z: 0.10,
                }),
            ..Default::default()
        },
        Save,
        TestCarScene,
    ));
}

Can you show me a minimal test case, or a minimal output save file?
I'm seeing these components in SceneBundle:
#[derive(Default, Bundle)]
pub struct SceneBundle {
    /// Handle to the scene to spawn
    pub scene: Handle<Scene>,
    pub transform: Transform,
    pub global_transform: GlobalTransform,

    #[cfg(feature = "bevy_render")]
    pub visibility: Visibility,
    #[cfg(feature = "bevy_render")]
    pub computed_visibility: ComputedVisibility,
}

Are all of these components present in your save output? Is Handle<Scene> a registered type?

So I had forgotten that I forked this repo and added .pipe(remove_component::) to the save_into_file function. Trying it again I get the error:
Type 'bevy_render::view::visibility::ComputedVisibilityFlags' did not register ReflectSerialize
With .pipe(remove_component::, and manually adding         "bevy_render::view::visibility::ComputedVisibility" to the ron the error goes away however the component isn't added and doesn't show up in bevy-inspector-egui. Don't know if ComputedVisibilityFlags is the culprit or if it's silently failing somewhere else?
Doesn't seem anything has changed in SceneBundle between 0.10 and 0.11 but I am keen on getting this to work, most of what I'm saving with this plugin are SceneBundle objects, any pointer in the right direction would be greatly appreciated!

Similar issue occuring with DynamicScenes here

There is a lot of components in Bevy that derive Reflect but aren't necessarily serializable or registered types.
From what I'm seeing in Bevy 11.2 code (Visibility logic seems to have changed entirely on latest), both ComputedVisibility and ComputedVisibilityFlags are registered types (see bevy_render::view::ViewPlugin). But ComputedVisibilityFlags is a custom bit flag struct which I imagine requires custom de/serialization code, which it doesn't seem to have. This would explain the issue you're experiencing.
With the latest version of this crate, you can pass a SceneFilter (inside a SaveFilter) which is then passed to the DynamicSceneBuilder directly:
pub fn save_into_file_on_event<R: SaveIntoFileRequest + Event>() -> SavePipeline {
    // Note: This is a single system, but still returned as `SystemConfigs` for easier refactoring.
    filter::<With<Save>>
        .pipe(save)
        .pipe(file_from_event::<R>)
        .pipe(into_file_dyn)
        .pipe(finish)
        .run_if(has_event::<R>)
        .in_set(SaveSet::Save)
}

For example:
pub fn filter_without_visibility<Filter: ReadOnlyWorldQuery>(entities: Query<Entity, Filter>) -> SaveFilter {
    let mut scene = SceneFilter::default();
    scene.deny::<ComputedVisibilityFlags>();
    SaveFilter {
        entities: EntityFilter::allow(&entities),
        scene,
    }
}

You can use this to avoid ComputedVisibilityFlags BEFORE scene serialization (you couldn't do this with the old remove_compnent method as it serialized, and then dumped the data -- it was awful 😛), which I think would bypass the error about ComputedVisibilityFlags not being serializable.
Then on load side, to be 100% safe, I'd recommend just checking all entities with a Visibility component, and then inserting a full VisibilityBundle into them with the initial value based on the desired visibility.
Theoretically, this would guarantee that the loaded visibility data is identical to runtime visibility data, and so everything else should work.

Thanks for this, I've tried your suggestion scene.deny::<ComputedVisibility>(); as ComputedVisibilityFlags seems to be a private struct, however on load I get the following error with a panic
Entity {some entity} does not exist
Encountered a panic in exclusive system Pipe(Pipe(Pipe(Pipe(moonshine_save::load::from_file<std::path::PathBuf>::{{closure}}, moonshine_save::load::unload<bevy_ecs::query::filter::Or<(bevy_ecs::query::filter::With<moonshine_save::save::Save>, bevy_ecs::query::filter::With<moonshine_save::load::Unload>)>>), moonshine_save::load::load), moonshine_save::load::insert_into_loaded<moonshine_save::save::Save>::{{closure}}), moonshine_save::load::finish)!
Encountered a panic in system bevy_app::main_schedule::Main::run_main!
Panic occurs in insert_into_loaded()
I'm not really sure how to debug this.

If you're getting missing entity panics there, it suggests the EntityMap isn't being populated correctly. I can't debug this on my end since I don't have a repro case.
I'm concerned your workaround of using get_entity_mut is just hiding a bigger problem. In a default load pipeline, insert_into_loaded just inserts a Save component into all loaded entities (anything that is loaded is implicitly marked for save).
So if it's causing a panic, it implies you're trying to process entities that aren't loaded. How those entities got inside your EntityMap... I can't know.
I'd suggest debugging to see what exactly is inside the loaded EntityMap at the end of load:
pub fn load(
    In(result): In<Result<Saved, LoadError>>,
    world: &mut World,
) -> Result<Loaded, LoadError> {
    let Saved { scene } = result?;
    let mut entity_map = EntityMap::default();
    scene.write_to_world(world, &mut entity_map)?;
    Ok(Loaded { entity_map }) // <-------------
}

You can compare the entities inside the EntityMap with the entities in your saved data to see which entities are not spawning despite being flagged as loaded, which might give us some clue as to why it's happening.

You're right it's not a solution by any means I'm closing this issue and debugging seperately as it's probably beyond the scope of this crate, I'll let you know if I find anything interesting though. Thanks for the help!


[MetricsAdvisor] Implement DimensionKey.GetHashCode

Currently we are delegating to Dimension.GetHashCode, which is not a good hash function.

DimensionKey won't be an IEquatable anymore in the new proposed design, so there's no reason to implement GetHashCode.


1.2.1 Updates

Changes:

Adds more currencies.
Adds extra space above and below the pricing chart, to give users more space to access settings.
Adds a separate editor_element.js to remove a unnecessary timeout on published sites.

looks good to me :+1:


Unable to run in Windows 11 -

Host
Tell us about your Host OS (the machine you're building burrito apps on)
Host OS: MacOS 14.2.1 (23C71)
Host CPU: arm64 (Apple M1 Max)
Please run zig version in your Burrito project directory and write the version here: 0.13.0
Please run elixir -v in your Burrito project directory and write the version here: Elixir 1.16.2 (compiled with Erlang/OTP 26)

Target
Host OS: Windows 11
Host CPU: x86_64
Host LibC and Version (eg. gnu/musl x.y.z ...)

I have cross compiled a Phoenix application to Windows/Linux and Mac targets. The Linux and Mac targets work as expected, but when running the Windows version the application halts with the following error:
Unable to load emulator DLL
(C:\Users\*\AppData\Local\.burrito\*_*_erts-14.2.2_2.3.0\erts-14.2.2\bin\beam.smp.dll)

Not being an OTP/Windows expert, I'm not entirely sure what the error is telling me, I can confirm that the .dll file is in that location, but i'm guessing that's not the issue.
I am using the pre-compiled ERTS builds currently.

Hmm, running the example CLI app built on my MacOS M1 machine results in a runnable binary for me... can you post any more of the logs when trying to run this exe?

I'm closing this issue to keep things tidy in the project page. If you are still experiencing this error, provide more log output, or try the example_cli project in the repo.


add owner, change version

[
{
"msg": "Leaves other than image are changed, Changes found: 3, image changed: 2"
}
]
[
{
"msg": "path ci-app/app-repo/config/base/deployment.yaml not in any of the prefixes ["apps/"]"
}
]
fatal: external diff died, stopping at ci-app/app-repo/config/base/deployment.yaml


Code snippets of TeamsJs V2 not working for getLocation and showLocation API

Code snippets of TeamsJs V2 not working for getLocation and showLocation API,
getLocation :
It has incorrect closing brackets, using the code giving error like there is no callback function for getLocation and output() seems to be an irrelevant method for this snippet. Please replace with below code.
import {location} from "@microsoft/teams-js"
let locationProps = {"allowChooseLocation":true,"showMap":true};
if(location.isSupported()) {
microsoftTeams.location.getLocation(locationProps, (error, location) => {
// If there's any error, an alert shows the error message/code
if (error) {
if (error.message) {
alert(" ErrorCode: " + error.errorCode + error.message);
} else {
alert(" ErrorCode: " + error.errorCode);
}
}
console.log(JSON.stringify(location));
});
}
else {/*Handle case where capability isn't supported */}
showLocation:
Using the code giving error like there is no callback function for showLocation and output() seems to be an irrelevant method for this snippet. Please replace with below code.
import {location} from "@microsoft/teams-js"
let location = {"latitude":17,"longitude":17};
if(location.isSupported()) {
microsoftTeams.location.showLocation(location, (error, result) => {
if (error) {
if (error.message) {
alert(" ErrorCode: " + error.errorCode + error.message);
} else {
alert(" ErrorCode: " + error.errorCode);
}
}
});
}
else {/*Handle case where capability isn't supported */}

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 37c38166-ea97-76c3-3c8a-ba32cd9a8f53
Version Independent ID: 44bfd3b4-9b6a-f33e-3cb2-cf88fda01b84
Content: Integrate location capabilities - Teams
Content Source: msteams-platform/concepts/device-capabilities/location-capability.md
Service: msteams
GitHub Login: @surbhigupta
Microsoft Alias: surbhigupta

Hello @surbhigupta12 - Please help to update the documentation.


Fix warning when running phpunit

This is just a "fix" to remove the following warning.

PHP Warning:  Declaration of Sofa\Eloquence\Tests\ParentModel::save() should be compatible with Illuminate\Database\Eloquent\Model::save(array $options = Array) in /Users/lukasoppermann/Code/testelo/tests/MetableTest.php on line 627

Coverage decreased (-0.2%) to 93.387% when pulling 3973f017acc6faa8c8de932399ba7253418957ca on lukasoppermann:fix-test-warning into 9f2f32c9d36ffbd1a0d0ee88d6bf9e81c207ec44 on jarektkaczyk:5.3.

Hey @jarektkaczyk can you merge this one?


add project Code-space- jump-game project

add project code-space-jump-game-project.
issue no. here:  #283
Email id used to regsiter for VSoc'24
Email id<EMAIL_ADDRESS>Description
add project code-space-jump-game-project
Type of PR

[ ] Bug fix
[ x] Feature enhancement
[ x] Documentation update
[ x] Security enhancement
[ ] Other (specify): _______________

check in issue by entering [X] in boxes
Screenshots / Videos (if applicable)
https://github.com/user-attachments/assets/28b1bada-2d12-4164-9283-80d95fe61220
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist

[x ] I have performed a self-review of my code.
[x ] I have read and followed the Contribution Guidelines.
[x ] I have tested the changes thoroughly before submitting this pull request.
[x ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ x] I have commented my code, particularly in hard-to-understand areas.
[ x] I have followed the code style guidelines of this project.
[ x] I have checked for any existing open issues that my pull request may address.
[ x] I have ensured that my changes do not break any existing functionality.
[ x] Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.
[ x] I have read the resources for guidance listed below.
[ x] I have followed security best practices in my code changes.

check in issue by entering [X] in boxes
Additional Context
[Include any additional information or context that might be helpful for reviewers.]
Contribution Guidelines
Thank you for considering contributing to our project! To ensure smooth collaboration and effective contribution management, please adhere to the following guidelines:
Issue Creation

Limit on Issues:

Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.

Contribution Levels

Basic Contributions:

This project is primarily focused on documentation. Most of the setup has been completed, so contributors will generally need to work on basic code tasks, such as writing tests.
For these tasks, issues will be assigned the Easy label.

Acknowledging Hard Work:

If a contributor puts in significant effort on a task, the issue will be upgraded to Medium. This is our way of recognizing and appreciating extra effort.

Feature Additions and Component Work:

Contributors working on new features or components using JSX/TSX will be assigned a level based on the complexity and quality of their work.
The more complex and valuable the contribution, the higher the level assigned.

Level Definitions

Easy:

Tasks are straightforward, such as fixing minor bugs, writing tests, or making simple documentation updates.

Medium:

Tasks require more effort, such as addressing complex bugs, improving existing features, or making substantial documentation improvements.

Hard:

Tasks are highly complex and involve significant new feature development, major refactoring, or extensive contributions to the project’s core components.

We look forward to your contributions and appreciate your effort in helping us improve the project!

a lot of bug in game


Minor refactorings

Small changes, which I thought make sense.

Happy to see you here @gzsombor !
I didn't expect you followed this project. Thanks for your help and your contribution :)


Filling Table Columns: UTMs & Albers

Describe the Task
Performing spatial overlays on all record entries of the activity_incoming_data table to populate meta data columns. Related to ticket #147.
Race condition

[ ] Fix database locking issue when multiple inserts are run simultaneously.

Filling table columns

[ ] UTM Northing
[ ] UTM Easting
[ ] Albers X
[ ] Albers Y

addressed in ticket #346 , #347 & #348

addressed in ticket #346 , #347 & #348


repost: release-v22.12.0

For posterify: workflow failed because the PR branch was deleted before the workflow is complete, so it couldn't diff the PR branch and the main branch. Retried in https://github.com/nodejs/bluesky/pull/13 and opened https://github.com/nodejs/bluesky/pull/14 to document it


AzureADB2C Client Credentials Grant with Client Assertion as Opposed to ClientSecret (static)

Hello Team
My issue is related to the experience of the OP. I have a requirement to provide API to our consumers. The intention is to secure the API using AzureAD B2C - Client Credential Grant flow.
I have created a custom policy on B2C tenant that provides the access token. Things work fine with the clientId and Secret authentication method.
I now want to secure the OAuth2 conversation further by allowing the client to use the signed client_assertion as opposed to static client secret using their protected key. I have uploaded the public portion of the key into the relevant app registration.
Unfortunately, consuming the /token endpoint with the signed client_assertion results in an error.
REQUEST
https://.b2clogin.com/.onmicrosoft.com/b2c_1a_demo_clientcredentialsflow/oauth2/v2.0/token
grant_type=client_credentials&scope=https%3A%2F%2Fapi%2F.default&client_id=d5339984-e6c7-457a-9ef9-21fb6e3e6c59&client_assertion_type=urn%3Aietf%3Aparams%3Aoauth%3Aclient-assertion-type%3Ajwt-bearer&client_assertion=eyJhbGciOiJo
RESPONSE
HTTP/1.1 400 Bad Request
{"error":"invalid_request","error_description":"AADB2C99027: Policy 'B2C_1A_Demo_ClientCredentialsFlow' does not contain a AuthorizationTechnicalProfile with a corresponding ClientAssertionType.\r\nCorrelation ID: 5eb76fa5-c919-4877-a722-0d38408e18c6\r\nTimestamp: 2023-01-19 07:38:25Z\r\n"}
Can someone please tell me if B2C is intended to support client assertions? Metadata JSON on the policy returns only the following two authentication methods:

"token_endpoint_auth_methods_supported": [
    "client_secret_post",
    "client_secret_basic"
  ]

Is it possible to include private_key_jwt as a supported authentication method using custom policy configuration? Is it possible to configure the AuthorizationTechnicalProfile for the policy with a corresponding ClientAssertionType
I hope that I have explained the problem well enough.

@chawlaiam
It would be great if you could add a link to the documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!!

Hello @AjayBathini-MSFT,
I used the guidance here to implement client credentials grant flow on my b2c tenant: https://learn.microsoft.com/en-us/azure/active-directory-b2c/client-credentials-grant-flow?pivots=b2c-custom-policy
The only difference is that I want to use dynamic client_assertion to validate the client as opposed to the static client_secret.
Please do let me know in case you need further information. Thanks!

@chawlaiam
Thanks for your feedback! We will investigate and update as appropriate.

@chawlaiam
Thank you for your feedback!
I'd recommend working closer with our support team via an [Azure support request] (https://docs.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request). Or you can leverage our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.
[Teams Q&A forum] (https://docs.microsoft.com/en-us/answers/topics/46488/office-teams-windows-itpro.html) for technical questions about the configuration and administration of Microsoft Teams on Windows.
[Microsoft Teams Community forum] (https://answers.microsoft.com/en-us/msteams/forum?sort=LastReplyDate&dir=Desc&tab=All&status=all&mod=&modAge=&advFil=&postedAfter=&postedBefore=&threadType=All&isFilterExpanded=false&page=1)
Thank you for your time and patience throughout this issue.


ValidationBehavior: Added IsNotValid property

Description of Change
Very often it's needed to have the "inversed" result value of validation. (Especially in binding).
For example, if I wish to show a label with an error message if the validator failed.
Currently, I have to use the "inverse bool" converter. Yes, it's a working solution, but why we cannot simplify it? All the more so it's a common case.
API Changes
Added:

bool ValidationBehavior.IsNotvalid { get; set; }

Behavioral Changes
None
PR Checklist

[ ] Has tests (if omitted, state reason in description)
[ ] Has samples (if omitted, state reason in description)
[X] Rebased on top of main at time of PR
[X] Changes adhere to coding standard
[ ] Updated documentation

@pictos done


Add listing for precompiled Windows binaries

They're fixed on wasm-bindgen's CI, so let's download/install them!

Looks like this ran into the same bug I fixed in the wasm-pack test PR: https://ci.appveyor.com/project/ashleygwilliams/wasm-pack-071k0/build/1.0.213#L256

Oh actually that looks like it's missing a .exe for windows

ping @alexcrichton looks like this is still failing on appveyor - lemme know if i can help!


Favicon

The current favicon is white and hard to see in many cases, we should switch it to be black.


Update metadata to include website, source, issues

Description
Updates the charm metadata to include links to website, source and issues.
Also adds the required field display-name, and some slight rewording for summary and description.
Checklist

[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have made corresponding changes to the documentation.
[ ] I have added tests that validate the behaviour of the software.
[ ] I validated that new and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.
[ ] I have bumped the version of any required library.

It looks good if it works :)

If it works is the key :laughing:
I'm having some difficulty figuring out exactly how Charmhub works, so this is kinda my (second) testing ground.


Refactor file structure and naming convention proposal

Some file and component refactoring which is also a suggestion for a naming/folder organisational convention:

following an "As local as possible, as global as needed" approach: components get only moved into a more global/outer folder if they are used on that level
views of react-router paths going into the views folder
each view can have it's own folder - which in return can have a local components folder
ideally only one component per file
no index.ts files, besides the one root index file (makes file navigation more confusing and I don't see convincing reason to use it)
files and folders which export a component/view are written UpperCamelCase, with the same name as actual exported component/view
other files (like types.ts, helpers.ts etc) and folders (like providers, utils etc) are written in lowerCamelCase

@vahidbazzaz @flisowna please let me know what you think :)

For some reason CircleCI builds fail, even though locally the tests are green and the build succeeds.
Will look into that later today after some other tasks.

@spaudanjo Thanks for the changes in the file structure and naming conversion. I tried to run it locally, but got the following error, which seems to be because of forceConsistentCasingInFileNames.:
module "/Users/vahid/Projects/boxtribute/boxtribute/react/src/views/Boxes/components/BoxesTable" Already included file name '/Users/vahid/Projects/boxtribute/boxtribute/react/src/views/Boxes/components/BoxesTable.tsx' differs from file name '/Users/vahid/Projects/boxtribute/boxtribute/react/src/views/boxes/components/BoxesTable.tsx' only in casing.   The file is in the program because:     Imported via "./components/BoxesTable" from file '/Users/vahid/Projects/boxtribute/boxtribute/react/src/views/Boxes/Boxes.tsx'     Matched by include pattern 'src' in '/Users/vahid/Projects/boxtribute/boxtribute/react/tsconfig.json'ts(1261) tsconfig.json(27, 5): File is matched by include pattern specified here.

Yes, this after I reconfigured git locally with git config core.ignorecase false but apparently now both upper and lower case folders are checked in :D
I quickly try to fix this.


Cannot create symlink with existing directory as second argument to ln

Your Windows build number:  Microsoft Windows [Version 10.0.17763.379]

What you're doing and what's happening:

$ # somewhere under /mnt/c (DriveFs)
$ mkdir foo
$ ln -s somefile foo ### ISSUE IS HERE ###
ln: failed to create symbolic link 'foo': Invalid argument
$ ln --version
ln (GNU coreutils) 8.31
Copyright (C) 2019 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Mike Parker and David MacKenzie.
$ /my/old/ln -s somefile foo # OK
$  /my/old/ln --version
ln (GNU coreutils) 8.26
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Mike Parker and David MacKenzie.

What's wrong / what should be happening instead: ln should create a symlink to somefile in foo. Instead if fails with Invalid argument.

Strace of the failing command, if applicable:  https://gist.github.com/Oberon00/a3c59298e5b8f88bd3b136c121eb0785

Notice that the new ln first does symlinkat("somefile", AT_FDCWD, "foo") = -1 EINVAL (Invalid argument) and then immediately goes on to error handling. Probably it doesn't like EINVAL.
The old ln first does a stat("foo", {st_mode=S_IFDIR|0777, st_size=4096, ...}) = 0 and then proceeds with symlink("somefile", "foo/somefile") = 0, so it never sees the EINVAL.

Can't repro here. Possibly #1475 #2898 #3611.

The coreutils I'm using is from Arch Linux https://www.archlinux.org/packages/core/x86_64/coreutils/ (via https://github.com/yuk7/ArchWSL). If you have a new enough glibc, you should be able to download the package from the archlinux.org link and just use the ln binary.

The coreutils I'm using is from Arch Linux

[....redacted...] Of course it is.
That EINVAL in your strace(1) is incorrect on its face so made me look. On Arch in a VM, the ln(1) 8.31 sequence is:
symlinkat("somefile", AT_FDCWD, "foo")  = -1 EEXIST (File exists)
openat(AT_FDCWD, "foo", O_RDONLY|O_PATH|O_DIRECTORY) = 3
symlinkat("somefile", 3, "somefile")    = 0

Small test case below. glibc doesn't matter because those are just unadulterated syscalls.
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>

int main(int argc, const char *argv[])
{
    mkdir("foo", 0644);
    symlinkat("somefile", AT_FDCWD, "foo");
    return 0;
}

On Real Linux, and with WSL 18860 using LxFS, that yields an EEXIST alright. No surprise there.
mkdir("foo", 0644)                      = 0
symlinkat("somefile", AT_FDCWD, "foo")  = -1 EEXIST (File exists)

On WSL with DrvFS , the test case yields EISDIR for me.
mkdir("foo", 0644)                      = 0
symlinkat("somefile", AT_FDCWD, "foo")  = -1 EISDIR (Is a directory)

Which is wrong, pedantically. I never did get an EINVAL, so a reasonable assumption is something moved between your 17763 and my 18860 (I don't have a '783 handy to check). Either way that unexpected EISDIR/EINVAL looks like it is tripping ln(1) 8.3, contrast the EEXIST which ln sees coming.

Interestingly, this is the latest commit to GNU coreutils ln, at the time of this writing: coreutils/coreutils@3e0dff3925b5e521cae468087950e85b60002d1c
So it seems Solaris also returns EINVAL here.

Great find, thanks. Looks from the code like EISDIR on 18860 (assuming I've got that right) will still trip however. Patch or no patch that's a time bomb.
At base, construct is fragile. ln(1) is throwing bad inputs at the function and then trying to read tea leaves. Some FUSE filesystem on Real Linux™ might return who knows what. [Often programmers will point at the man page or posix, but that doesn't help your customer or your employer if your program doesn't work on a filesystem enough people like.]
Anyway, academic. That DrvFS returns something different than LxFS isn't coherent. Hopefully it can be fixed up to return EEXIST like ext4 on Real Linux.

This sort of "breaks" autoconf.
AS_INIT Generate code to detect whether ln -s is working like this and falls back to cp -pR when detection fails. Currently using a directory name as the second argument without trailing slash always results in "Is a directory" error.

always results

On 21387 the EISDIR bug still exists on WSL1 with drvfs with my repro. I was not able to reproduce the EISDIR on WSL2 9p (or ext4 by def), or on WSL1 wslfs.

Thank you for the clarification. It's interesting that there's no error on wslfs since it's supposedly just drvfs under the hood.

What is the resolution for this?  I upgraded my WSL1 distribution from Ubuntu 20.04 to Ubuntu 22.04 and now I am seeing build failures due to the following autoconf failure:
checking whether ln -s works... no, using cp -pR
I see that /usr/bin/ln has changed from coreutils 8.30 (Ubuntu 20.04) to coreutils 8.32 (Ubuntu 22.04) and that triggered this bug.  If this is fixed when using wslfs how do I switch to that?

We're having the same issue as raymod2, if anyone has a pointer to a workaround that would be much appreciated.

This was reported over 5 years ago and still hasn't been fixed!  And now MSFT is closing this ticket for lack of "activity"?


Incompleted copy to destination drive

Hello everybody.
I have this problem, I have tested the mad max plotter. I plotted all the phases without problems, but the copy to the destination drive did not complete.
I have a SO Ubuntu 20.04
32 Gb mem
Intel I5 10400 (6c/12Th)
Tmp drive: 2x1 TB NVMe WD 750 black (RAID 0)
Dst drive: HDD 10 TB Seagate
TMP Drive
ls -lh /mnt/ssdtemp/
total 102G
-rw-rw-r-- 1 dtanel dtanel 102G Jun 11 12:41 plot-k32-2021-06-11-11-54-09f2ddb22a5afb2297a202c8d6761e27ff280ab88f7b7cec22efc6a5428574c9.plot
DST Drive
ls -lh /media/dtanel/hdd1plot/
total 90G
-rw-rw-r-- 1 dtanel dtanel 90G Jun 11 12:47 plot-k32-2021-06-11-11-54-09f2ddb22a5afb2297a202c8d6761e27ff280ab88f7b7cec22efc6a5428574c9.plot.tmp
Log plot
Multi-threaded pipelined Chia k32 plotter - a75f2b3
Final Directory: /media/dtanel/hdd1plot/
Number of Plots: 1
Process ID: 23210
Number of Threads: 12
Number of Buckets: 2^7 (128)
Pool Public Key:   928a308d319b9144c66258e504afc5513e0af5da995b4a805fe1a2dca092e37d162d4402e95ac9cf06701d1dfc2654a6
Farmer Public Key: 8f81d7a136514c4e2445573387623c3bf13c7610d963e39815ecb0bda98c5ffc95e627ab3e642f155d0f85c4ca12e1f8
Working Directory:   /mnt/ssdtemp/
Working Directory 2: /mnt/ssdtemp/
Plot Name: plot-k32-2021-06-11-11-54-09f2ddb22a5afb2297a202c8d6761e27ff280ab88f7b7cec22efc6a5428574c9
[P1] Table 1 took 22.6755 sec
[P1] Table 2 took 194.611 sec, found<PHONE_NUMBER> matches
[P1] Table 3 took 226.645 sec, found<PHONE_NUMBER> matches
[P1] Table 4 took 277.144 sec, found<PHONE_NUMBER> matches
[P1] Table 5 took 272.3 sec, found<PHONE_NUMBER> matches
[P1] Table 6 took 261.374 sec, found<PHONE_NUMBER> matches
[P1] Table 7 took 200.384 sec, found<PHONE_NUMBER> matches
Phase 1 took 1455.15 sec
[P2] max_table_size =<PHONE_NUMBER>
[P2] Table 7 scan took 15.8862 sec
[P2] Table 7 rewrite took 31.5876 sec, dropped 0 entries (0 %)
[P2] Table 6 scan took 46.9775 sec
[P2] Table 6 rewrite took 72.0085 sec, dropped 581323951 entries (13.5368 %)
[P2] Table 5 scan took 45.2337 sec
[P2] Table 5 rewrite took 69.105 sec, dropped 762055776 entries (17.7443 %)
[P2] Table 4 scan took 44.564 sec
[P2] Table 4 rewrite took 68.0175 sec, dropped 828874387 entries (19.2993 %)
[P2] Table 3 scan took 44.2719 sec
[P2] Table 3 rewrite took 67.5064 sec, dropped 855043784 entries (19.9083 %)
[P2] Table 2 scan took 44.1058 sec
[P2] Table 2 rewrite took 67.3264 sec, dropped 865567187 entries (20.1532 %)
Phase 2 took 623.373 sec
Wrote plot header with 268 bytes
[P3-1] Table 2 took 53.0664 sec, wrote<PHONE_NUMBER> right entries
[P3-2] Table 2 took 47.4078 sec, wrote<PHONE_NUMBER> left entries,<PHONE_NUMBER> final
[P3-1] Table 3 took 67.2131 sec, wrote<PHONE_NUMBER> right entries
[P3-2] Table 3 took 49.8141 sec, wrote<PHONE_NUMBER> left entries,<PHONE_NUMBER> final
[P3-1] Table 4 took 67.579 sec, wrote<PHONE_NUMBER> right entries
[P3-2] Table 4 took 50.1526 sec, wrote<PHONE_NUMBER> left entries,<PHONE_NUMBER> final
[P3-1] Table 5 took 68.728 sec, wrote<PHONE_NUMBER> right entries
[P3-2] Table 5 took 51.1536 sec, wrote<PHONE_NUMBER> left entries,<PHONE_NUMBER> final
[P3-1] Table 6 took 71.8238 sec, wrote<PHONE_NUMBER> right entries
[P3-2] Table 6 took 53.9046 sec, wrote<PHONE_NUMBER> left entries,<PHONE_NUMBER> final
[P3-1] Table 7 took 59.4985 sec, wrote<PHONE_NUMBER> right entries
[P3-2] Table 7 took 62.4516 sec, wrote<PHONE_NUMBER> left entries,<PHONE_NUMBER> final
Phase 3 took 704.305 sec, wrote<PHONE_NUMBER>7 entries to final plot
[P4] Starting to write C1 and C3 tables
[P4] Finished writing C1 and C3 tables
[P4] Writing C2 table
[P4] Finished writing C2 table
Phase 4 took 63.9863 sec, final plot size is<PHONE_NUMBER>44 bytes
Total plot creation time was 2846.85 sec
Started copy to /media/dtanel/hdd1plot/plot-k32-2021-06-11-11-54-09f2ddb22a5afb2297a202c8d6761e27ff280ab88f7b7cec22efc6a5428574c9.plot
The copy to the destination drive was never completed.
Can you help me?
Thank you.

slow drive?

did you wait for process to finish?

In the initial test use this command and the copy failed:
./build/chia_plot -p $$$ -f $$$ -n 1 -r 12 -t /mnt/ssdtemp/ -d /media/dtanel/hdd1plot/ >> $(date '+%Y-%m-%d_%H_%M_%S').log &
Now, I tested with 3 plots and it works fine. Complete copy finished.
./build/chia_plot -p $$$ -f $$$ -n 3 -r 12 -t /mnt/ssdtemp/ -d /media/dtanel/hdd1plot/ >> $(date '+%Y-%m-%d_%H_%M_%S').log &
I don't know why it failed with 1 plot.
Thank you.

hard to say what caused it now..

Hello everybody.
Yesterday I have a new problem in my 3 plotting PCs.
I execute chia-plotter with this parameters:
./build/chia_plot -p  $$$ -f $$$ -n -1 -r 12 -t /mnt/ssdtemp/ -d /media/dtanel/hdd1plot/ >> $(date '+%Y-%m-%d_%H_%M_%S').log &
PC1 Chia-rig1
In my tmp drive I have two completed plots:
plot-k32-2021-06-13-03-45-0bbb733e706a27dd4341630c869cfa5950498e69e8fb824d72251fdc09df142a.plot
plot-k32-2021-06-13-04-29-00196bd4c2087ec5ec2743a425666e44e1b158668dc7ed49b00229843be2cd82.plot
In my dst drive I have 1 tmp copy plot:
plot-k32-2021-06-13-03-45-0bbb733e706a27dd4341630c869cfa5950498e69e8fb824d72251fdc09df142a.plot.tmp
Log
Copy to /media/dtanel/hdd1plot/plot-k32-2021-06-13-03-45-0bbb733e706a27dd4341630c869cfa5950498e69e8fb824d72251fdc09df142a.plot failed with: fwrite() failed
PC2 Chia-rig2
In my tmp drive I have a lot of tmp plot.
In my destination I have five finished plot.
Log:
[P4] Starting to write C1 and C3 tables
[P4] Finished writing C1 and C3 tables
[P4] Writing C2 table
[P4] Finished writing C2 table
Phase 4 took 67.5566 sec, final plot size is<PHONE_NUMBER>51 bytes
Total plot creation time was 2665.42 sec
Started copy to /media/dtanel/hdd1plot/plot-k32-2021-06-13-06-36-45a69c082a1d81d574367272839e9958dc93903e5a577dc5f82083f03d3bb89c.plot
Crafting plot 6 out of -1
Process ID: 2505393
Number of Threads: 12
Number of Buckets: 2^8 (256)
Pool Public Key:   928a308d319b9144c66258e504afc5513e0af5da995b4a805fe1a2dca092e37d162d4402e95ac9cf06701d1dfc2654a6
Farmer Public Key: 8f81d7a136514c4e2445573387623c3bf13c7610d963e39815ecb0bda98c5ffc95e627ab3e642f155d0f85c4ca12e1f8
Working Directory:   /mnt/ssdtemp/
Working Directory 2: /mnt/ssdtemp/
Plot Name: plot-k32-2021-06-13-07-20-31528aa4c28eec0399f0350c03859dee8bd7b2f452a0c2012da23ac5f1cf5b34
[P1] Table 1 took 23.0707 sec
[P1] Table 2 took 191.008 sec, found<PHONE_NUMBER> matches
[P1] Table 3 took 219.563 sec, found<PHONE_NUMBER> matches
Copy to /media/dtanel/hdd1plot/plot-k32-2021-06-13-06-36-45a69c082a1d81d574367272839e9958dc93903e5a577dc5f82083f03d3bb89c.plot finished, took 453.479 sec, 228.838 MB/s avg.
[P1] Table 4 took 252.086 sec, found<PHONE_NUMBER> matches
[P1] Table 5 took 245.407 sec, found<PHONE_NUMBER> matches
[P1] Table 6 took 239.395 sec, found<PHONE_NUMBER> matches
[P1] Table 7 took 187.277 sec, found<PHONE_NUMBER> matches
Phase 1 took 1357.84 sec
[P2] max_table_size =<PHONE_NUMBER>
[P2] Table 7 scan took 16.5879 sec
[P2] Table 7 rewrite took 32.108 sec, dropped 0 entries (0 %)
[P2] Table 6 scan took 39.8226 sec
[P2] Table 6 rewrite took 67.3877 sec, dropped 581240858 entries (13.5336 %)
[P2] Table 5 scan took 38.521 sec
[P2] Table 5 rewrite took 65.1205 sec, dropped 762006260 entries (17.7421 %)
[P2] Table 4 scan took 38.0791 sec
[P2] Table 4 rewrite took 63.6104 sec, dropped 828860632 entries (19.2985 %)
[P2] Table 3 scan took 37.6976 sec
[P2] Table 3 rewrite took 63.0329 sec, dropped 855132754 entries (19.9097 %)
PC3 Chia-rig3
In my tmp drive I have a lot of tmp plot.
In my destination I have five finished plots.
Log:
Phase 3 took 709.825 sec, wrote<PHONE_NUMBER>5 entries to final plot
[P4] Starting to write C1 and C3 tables
[P4] Finished writing C1 and C3 tables
[P4] Writing C2 table
[P4] Finished writing C2 table
Phase 4 took 64.4214 sec, final plot size is<PHONE_NUMBER>36 bytes
Total plot creation time was 2887.24 sec
Started copy to /media/dtanel/hdd1plot/plot-k32-2021-06-13-06-29-6a7291d6bd5e1bc3c617ca2a0396f0fc5f884e5c8e460321963022dcc7625b0c.plot
Process ID: 33432
Number of Threads: 12
Number of Buckets: 2^7 (128)
Pool Public Key:   928a308d319b9144c66258e504afc5513e0af5da995b4a805fe1a2dca092e37d162d4402e95ac9cf06701d1dfc2654a6
Farmer Public Key: 8f81d7a136514c4e2445573387623c3bf13c7610d963e39815ecb0bda98c5ffc95e627ab3e642f155d0f85c4ca12e1f8
Working Directory:   /mnt/ssdtemp/
Working Directory 2: /mnt/ssdtemp/
Plot Name: plot-k32-2021-06-13-07-17-3c67c16e452d366d7ff8991b57ac5bdaf3dcd63b2029c4ae4fa5b191c47dbda6
[P1] Table 1 took 25.0174 sec
[P1] Table 2 took 203.805 sec, found<PHONE_NUMBER> matches
Copy to /media/dtanel/hdd1plot/plot-k32-2021-06-13-06-29-6a7291d6bd5e1bc3c617ca2a0396f0fc5f884e5c8e460321963022dcc7625b0c.plot finished, took 457.088 sec, 227.072 MB/s avg.
[P1] Table 3 took 239.325 sec, found<PHONE_NUMBER> matches
[P1] Table 4 took 278.849 sec, found<PHONE_NUMBER> matches
[P1] Table 5 took 274.319 sec, found<PHONE_NUMBER> matches
[P1] Table 6 took 262.886 sec, found<PHONE_NUMBER> matches
[P1] Table 7 took 201.373 sec, found<PHONE_NUMBER> matches
Phase 1 took 1485.61 sec
[P2] max_table_size =<PHONE_NUMBER>
[P2] Table 7 scan took 16.317 sec
[P2] Table 7 rewrite took 33.8206 sec, dropped 0 entries (0 %)
[P2] Table 6 scan took 47.076 sec
Thank you


Some images are not being displayed in the gallery

I'm experiencing a weird problem with a few images that are not being displayed, like this one. They don't show up in the gallery, but when you open them in the viewer they do appear.
I started debugging the code and found the line where the image is set.
item.style.backgroundImage = `url(${url})`

It turns out that if you add quotes around the url variable, the problem is gone and the images display correctly. Like this:
item.style.backgroundImage = `url("${url}")`

Do you know why this happens? Is it safe to create a pull request to address this?
Thanks.

Hi @alejost848 good job 👍
I think the problem is the url contains (, ) characters which if you escape them with %28 and %29 respectively like this one should works fine. Anyway It seems normal url encode function (like encodeURI) not handle these characters so I think we should handle this case.
Yes, a pull request would be appreciated.
Thanks


Effects History View for Account Page

Added a tab to the account page linking to a view with a log of the user's effects history. The log is organized into a table in reverse chronological order and able to be filtered by effect type ('account', 'signer', 'trade', 'trustline'). It displays the type of effect, the action (ie for account created, it would be created), a description of the effect, and the date (with ledger sequence number for further reference). Here is a gif:

I did my best to maintain the styling of the current codebase and include only necessary code to create the additional view.
***Note: Referencing #80. ***

While gifs are cool for showing off, they're terrible at describing what was done since I have to watch a 20 second thing to just see a small 1 second glimpse of something. I suggest using many static images when showing something. Only use gifs when you want to show something off but have something to hide (kinda shady, but thats what gifs are great for)

Overall:

Reduce code duplication
Absolute timestamps
More efficient fetching of effects

My apologies!! Appearing shady was not my intention. I figured that a video/gif would be cool and act as proof that the actions described worked simultaneously and weren't hardcoded. Below are some statics highlighting the features of the table. I'll follow up with the feedback you've provided above in the next few days. Thanks!
Overall View Screenshot
Here you can see the entirety of the effects history log. The main body is scrollable, and the header is static. The checkboxes allow you to filter between the different types. The main effect type category is bolded on the left for easy scalability and the sub type is to its right. After that you have a description of the effect along with data and ledger sequence number beneath it. Most people unfamiliar with Stellar won't necessarily understand the significance of ledger sequence numbers, so that is why I decided for it to go beneath the date and in smaller font.

Addition of tab in the account links heading
I decided it would be logical to include a link to the history in the account heading. At first I thought maybe this table should be with the account balance, however some effects have nothing to do with balance, so I figured the history table should be entirely seperate.

Trade History
Here are some examples of trade history. Trade history utilizes the already implemented asset card and shows a simple visual of what currency was exchanged and for what amount.

Account History
Account history has many different sub effects.  These are all represented in the screenshot below.

Trustline History
Here are the main trustline effects. Again, I utilize the asset card for a nice visual.

Signer History
I decided that for signer effects, the most useful information would be the key (pk) being used to update and the weight of the key.

Filtering of History Log
Here is an example of filtering. As you can see, the trade and account effects are checked and those are the events that are displayed.

"Ledger sequence #12345" could be reduced to "Ledger #12345". Since sequence already implies number, the word sequence is redundant and we can save space
I think the UI could be improved to be clearer but it's mergeable at this point. Perhaps I'll grind on how I could improve the UI. Perhaps there could even be multiple tables! But for now, lets just go with this current 1.0 UI. I now realize that the RippleTrade UI isn't as great as I imagined it to be. Thank you for helping me test this!

Good job on the screenshots though!

Iris, I've gone through most of the changes you requested. However, still unsure about loading the effects. One way may be to load it when they first login. That way, it is cached and loaded by the time the user navigates to the history page. Then, I can have a listener that dynamically adds effects as they come in. That is sort of what I had originally.
Another idea I had was to load X amount at a time and display these page by page. This method is used by StellarChain.io and steexp.com and many other websites with tables. Loading 10 is pretty fast and once they are loaded, they can be cached.
Unless I am missing something, it appears the only way to get a substantial amount of information about any one effect is to do followup api calls for the individual effect. Thus, for 10 effects, I have to do 1 + 10 * 2 = 21 api calls. If there is a way around this, then loading would be quite trivial.
Thanks!

Smoothed out most of the errors above. Still working on an efficient and quick way of loading the table data. Right now I am thinking about putting it in a table that displays 8 results (looks good with current formatting) per page. Probably won't fix the remaining bugs until tomorrow evening and then I'll update the PR. Here is a screenshot of the current table design. Let me know if this is sort of what you were visualizing and if you think it fits the current design scheme.
Table with Pages

Oh, oops. I mean it's good to load 200 transactions all at once. But I think it should only fetch details once we actually open the history page. I think a big long list is better than pagination because then it's searchable. But the pagination is good if we only show it for big transaction histories.
Additionally, can we show hour:minute TZ on the timestamps? I think that'd be useful

This is amazing! Good job!

Thanks, but still a few changes!! One moment, forgot that this pushes straight to the PR

No problem. It's good to see work in progress

All ready for review again! Here are the fixes in version 2:
Time added

Now we have absolute date and time. I agree this looks better and makes more sense for a financial log.
AssetEffectCard Component merged with AssetCard2
Here I just took the meat of the Effect Card and put it in AssetCard2. This is some 6-8 lines of code. Then I added a check at the end for a isEffect property. If true, this loads the Effect Card. This works because the two cards have the same structure, but different styling.
EffectCard renamed HistoryTableRow
Makes more sense.
More Efficient Table Loading
First, I moved most of the table loading out of the account loading/signin function. Here is how the table now loads:

User signs in and a "skeleton" of the last 200 effects are loaded
User navigates to the History view and the most recent 7 effects are loaded and displayed. I chose 7 because that is how many are displayed on table at one time.
Right after the first 7 are loaded, the rest are loaded and added to the table in batches.

This significantly improved the table loading experience. Instead of waiting 3-5 seconds for everything to load, the user waits 0.3-1 seconds for the first "page" to load and then they can begin interacting with the table. Usually it is only another 1-3 seconds or the rest of the table to load.

Once the table is loaded, it begins "listening" for new effects. These effects are added to the table.

Since the loading process saves the effect history, and since new effects are saved as well, the user can instantaneously filter through the history log, and will never have to wait again for the loading during this session. Also, it would now be easy to add a search bar in future versions.
Known Issues

Firefox does not do the overflow-y scrolling. Thus instead of a max 500 height Y scroll, it is just one long table.

A warning for setState of an unmounted component when changing a trustline and then navigating back to the history view to watch the effect history update.

I wasn't paying attention and pushed my Secret Key in the last commit. Nevertheless, that account has 75 lumens and was my testing account. If someone finds it, buy yourself something nice :)

You could always go back in time to change the history. Though you might want to use the Stellar Laboratory to perform an account merge.

It's all good, that was a throw away account.

Let me know if there is anything else I should change or anything to redesign. Thanks!

Well, I cut a couple hundred lines of code and then broke something. I'll fix this tomorrow.

@irisli so the test that fails is the loading of the trade history on https://stellarterm.com/#exchange/.
This page won't even load on the live website for me; the website had a 404 error. I tested this on multiple devices and got the same result.
So, I think my code may be fine after all.

Yeah, the new horizon changes broke StellarTerm. Don't worry about the tests

Okay, I scanned it and it all looks fine.
I'm going to manually change the code so that we don't use bluebird. It's doable without bluebird I believe.

Hm, the feature is still glitchy and doesn't load properly. I'm going to have to fix it

Ok, I'll check it out!

What sort of glitchiness?

Hey, I am halfway through rewriting it to fit into the existing code. I'll commit it and then you can work from my stopping point

I think for the first version, we won't do streaming

Ok sounds good. Streaming was an extra layer of difficulty

Ok. The stuff is in the history tab. The stuff now loads properly and progressively.
Stuff I changed:

Changed date ordering
Removed EffectCard custom styles

The whole layout of history row needs to be redone. The current way it's laid out is too messy and is just a blob of information.
I think it's fine if a row takes up more vertical space. It should be more clear to understand. Perhaps we don't even have assetcards and it'll only show up when the user overs over the asset name.


toJSON()

net.jiniguru.me_issue_42_crash_d3d31fa38f494bb8a4671cb4c734180e_36f6ce82ebbd11e790f156847afe9799_0_v2.txt
I am facing this issue on distribution build. not even Development and Simulator.
Whenever I was try to convert Glossy object to Dictionary (.toJSON()). I am using "  pod 'Gloss', '~> 0.7.4'" version. I couldn't update swift version for some other issue . Please help

this issue may be from you as well? https://github.com/hkellaway/Gloss/issues/314
as mentioned there, if you’re using nested key paths that was causing a crash in certain versions including 0.7.4 (#135). that feature was removed in 0.8.0. if that’s your issue, perhaps try removing nested key paths and using 0.8.0 or turning off optimization
im no longer actively supporting Swift 2.x fyi, and so am not troubleshooting further. hope that helps.


More sanitized error message when subdomain is already registered

Suggested error message: Subdomain is already taken.

Hey @samweaver, I can do this, I need some help with navigating to that file.

Sorry for the confusion but it seems that this issue has been fixed: https://github.com/pluralsh/plural-cli/blob/e1f2779850fdad785b013e75efd64b3e9de38424/pkg/manifest/manifest.go#L151-L156


Proposal: Update ToggleSwitch Toggle UI

Proposal: Update ToggleSwitch's Toggle UI for consistency
Summary
There is an consistency effort across apps runnign on Windows as well as Fabric to align as much of the unnecessary differences as possible. This is one of them.
Windows design evaluated this size and this is more balanced with the text and also makes it feel less swipable (they are going after 'tappable' model) due to its size.
Rationale

Web and app ecosystems are a mix of styles
Styles are emerging to enforce purpose and function
New design follow this trend, thus our updates should also follow

Scope

Capability
Priority

Developers are able to use WinUI2.2* package and without any work, get the new Windows visual style.
Must

Developers have flexibility to style the size of ToggleSwitch without retemplating. (This is to be a new GH item.)
Should

Developers and end users experience control update that feel coherent with the same controls used by Fabric, Edge, and Xbox.
Should

*Timing here is not a commitment, but to follow the release cycle. Just using the next version #.
Design details and visuals
This impacts only ToggleSwitch. Update the width of the Toggle icon to 40px (today it is 44px).
Visual Comp
Important Notes

Note on flexibility: Edge allows ToggleSwitch size to be adjustable up to 7 sizes.

Open Questions

Why are Edge creating 7 different sizes and how are they using them?
Is it necessary to align this with text and have a smarter model?

I assume you mean the Width of the control, as it is 20px high

I assume you mean the Width of the control, as it is 20px high

@mdtauk , Yes, correct.

Added a couple of open issues.

Added a couple of open issues.

@chigy  That 7 sizes point is curious...
https://explore.fastdna.net/components/toggle/
I came across this Microsoft project which has a Toggle control with a Density property with values of:

-3
-2
-1
0
1
2
3

Perhaps this is the same framework Edge has chosen to use?

Added a couple of open issues.

@chigy That 7 sizes point is curious...
https://explore.fastdna.net/components/toggle/
I came across this Microsoft project which has a Toggle control with a Density property with values of:

-3
-2
-1
0
1
2
3

Perhaps this is the same framework Edge has chosen to use?

@mdtauk , I have no idea.

Status update: Reviewed with WinUI team and there was no immediate concern with the design's plan here if the work is merely to update existing toggle to have this new size. However I need to look more deeper into the scalability option (do we need it, if so how do we scale, etc.?) before making a formal pitch to the WinUI team.

@chigy the scalability option?  You mean the Density?  At the moment WinUI has the CompactDensity ResourceDictionary, and so any adjustments to the ToggleSwitch could be handled there.
As for offering more density options, this would likely be an option for the future, and would cover more than just one control.

@chigy the scalability option? You mean the Density? At the moment WinUI has the CompactDensity ResourceDictionary, and so any adjustments to the ToggleSwitch could be handled there.
As for offering more density options, this would likely be an option for the future, and would cover more than just one control.

@mdtauk , by scalability option, I meant to make this control more scalable. Today, if you want to change a text and that to impact the size of control, dev has to do all the work to change. While this wasn't raised as problematic afaik, when user scales text size, some controls do not scale the icons together with them and that's something we are aware. I'm just saying I need to look at more broadly into this before making a call.

Will the border around the ToggleSwitch control be updated to 1px, as with the borders on the other XAML controls?

Will the border around the ToggleSwitch control be updated to 1px, as with the borders on the other XAML controls?

Yeah it'll be updated, see the list here: https://github.com/microsoft/microsoft-ui-xaml/issues/835

@kaiguo  Thank you


Precommit hook for .all-contributorsrc fails on Windows because of space in path to node binary

cross-env version: master
node version: 9.4.0
npm (or yarn) version: 5.6.0
os: Microsoft Windows [Version 10.0.15063]

What you did:
git checkout https://github.com/kentcdodds/cross-env
cd cross-env
npm install
npm run validate
node_modules\.bin\all-contributors.cmd # npm run add-contributor didn't work see #168
git add .all-contributorsrc README.md
git commit -m "docs(README): add contributor"

See #168
What happened:
husky > npm run -s precommit (node v9.4.0)

25l[08:46:38] Running tasks for **/*.+(js|json|less|css|ts) [started]
[08:46:38] Running tasks for .all-contributorsrc [started]
[08:46:38] Running tasks for **/*.+(js|json|less|css|ts) [skipped]
[08:46:38] → No staged files match **/*.+(js|json|less|css|ts)
[08:46:38] C:\Program Files\nodejs\node.exe C:\Users\iki\code\cross-env\node_modules\kcd-scripts\dist\index.js contribut
ors generate [started]
[08:46:38] C:\Program Files\nodejs\node.exe C:\Users\iki\code\cross-env\node_modules\kcd-scripts\dist\index.js contribut
ors generate [failed]
[08:46:38] → C:\Program could not be found. Try `npm install C:\Program`.
[08:46:38] Running tasks for .all-contributorsrc [failed]
[08:46:38] → C:\Program could not be found. Try `npm install C:\Program`.
25hC:\Program could not be found. Try `npm install C:\Program`.
25h
husky > pre-commit hook failed (add --no-verify to bypass)```

Reproduction repository: https://github.com/kentcdodds/cross-env
Problem description: The precommit hook for .all-contributorsrc fails on Windows, because it does not quote path to node binary and fails when there's space in the path.
Suggested solution: Quote path to node binary properly.

Ah, yes, this is a problem in kcd-scripts and should definitely be fixed. Thanks for the report!

Actually, I think this is a problem in lint-staged 🤔

Could you try this? Make a change to the .all-contributorsrc file (any change at all, doesn't matter), then run:
cmd /C "set DEBUG=lint-staged:* && git commit -am stuff"

This will print out a bunch of debug information. Paste all the output here. Thanks!

@kentcdodds I set DEBUG=lint-staged:*, updated .all-contributorsrc and run git commit -am stuff, but got exactly the same result as above, no other messages were printed. The same with DEBUG=*. Is there anything else I can try?

Thanks for digging! I'm not sure why that didn't work! You might consider diving into your node_modules and adding some console.logs in places to figure out what's going on. I'm not sure what the problem is and without a windows machine it's hard for me to do much digging :-/
Good luck! And thanks again for anything you can help with!


IE 11 support

IE version 11 and Edge
It does not work on Internet Explorer when testing on localhost:4200. But works on production hosted site.
It does not work on Edge for both local host and production site
But it works in Edge: 80
Angular version: 9.0.6
I am getting the error
SCRIPT1002: Syntax error
vendor.js (46943,1)

"swiper": "^5.3.6"
The version of ngx-swiper-wrapper I am using is
"ngx-swiper-wrapper": "^9.0.1",
It works when using ngx-swipper-wrapper: 8.0.2 but it breaks my view layout as some feature that are in 9.0.1 are not in the version 8.0.2.
Is it something I am missing?

Same issue after upgrading to Angular 9. There are multiple threads with no proper solution, at least not for Angular that I could find.
Swiper
Swiper Issue just Closed
Another Issue
On React

@Cuberice Yeah... the Dom7 issue, seems like the author of the package should do this in their end.
But in any case please let me know if you have found a solution

@Cuberice  Yeah... the Dom7 issue, seems like the author of the package should do this in their end.
But in any case please let me know if you have found a solution

I also wan't to know when there is a solution

same issue. with the version
"ngx-swiper-wrapper": "^9.0.1"
 "@angular/core": "~9.0.6"

People i find a solution, reading the github page i see the demo on stackblitz and i analized the code and see thri thing that i miss in my project
1 install swiper npm i<EMAIL_ADDRESS>2 install types swiper  npm i<EMAIL_ADDRESS>3 copy this lines in tsconfig.json
... "lib": [       "es2018",       "dom"     ],     "paths": {       "ngx-swiper-wrapper": [         "dist/lib"       ]     }...
and dont forget "target": "es2015"

@jhonnathanH does it work on Microsoft Edge for you?

People i find a solution, reading the github page i see the demo on stackblitz and i analized the code and see thri thing that i miss in my project
1 install swiper npm i<EMAIL_ADDRESS>2 install types swiper npm i<EMAIL_ADDRESS>3 copy this lines in tsconfig.json
... "lib": [ "es2018", "dom" ], "paths": { "ngx-swiper-wrapper": [ "dist/lib" ] }...
and dont forget "target": "es2015"

This didn't help me, I had downgrade to version 8.0.2.

@aakici did the downgrade help you, how did you solve the issue?

@Teebo I just downgrading to version 8.0.2 and that's it. It solved my issue with IE11.

@aakici OK I see, have you tested it on edge as well?

I didn't have any issues with Edge and it is still working after downgrade.

@aakici OK I see, thank you

So downgrading is a work arround, but it's not the solution

@jhonnathanH does it work on Microsoft Edge for you?

you're right, now it fails in EDGE, if I change es2015 to es5 .. EDGE works fine but...  IE11 fail. I do not know what else to do.

@jhonnathanH yes this is very peculiar, I am not sure how to solve this one

According to https://github.com/nolimits4web/swiper/issues/3199#issuecomment-531185060 I've succeed to config angulars webpack to transpile dom7 to es5.

npm i @angular-builders/custom-webpack
in angular.json:

...

      "architect": {
        "build": {
          "builder": "@angular-builders/custom-webpack:browser",
            "customWebpackConfig": {
              "path": "./extra-webpack.config.js",
              "mergeStrategies": {
                "externals": "replace"
              }
...

extra-webpack.config.js:

const path = require("path");
module.exports = (config, options) => {
    config.module.rules.push({
      test: /\.(js|jsx)$/,
      use: {
        loader: 'babel-loader',
        options: {
          presets: ['@babel/preset-env']
        }
      },
      include: [
        path.resolve(__dirname, "node_modules/swiper"),
        path.resolve(__dirname, "node_modules/dom7"),
        path.resolve(__dirname, "node_modules/ssr-window"),
      ]
    })
    return config;
  };

@vltansky bro you a star! That worked good

@vltansky 's solution also worked for me! Thanks!
In my case, the "customWebpackConfig" had to be under "options" object in order to work as intended.
Angular 9.1.9
ref: https://github.com/just-jeb/angular-builders/tree/master/packages/custom-webpack#for-example

@vltansky 's solution also worked for me! Thanks!
In my case, the "customWebpackConfig" had to be under "options" object in order to work as intended.
Angular 9.1.9
ref: https://github.com/just-jeb/angular-builders/tree/master/packages/custom-webpack#for-example

You're right, "customWebConfig" have to be under "options". I've updated the instructions. Thanks.

People i find a solution, reading the github page i see the demo on stackblitz and i analized the code and see thri thing that i miss in my project
1 install swiper npm i<EMAIL_ADDRESS>2 install types swiper npm i<EMAIL_ADDRESS>3 copy this lines in tsconfig.json
... "lib": [ "es2018", "dom" ], "paths": { "ngx-swiper-wrapper": [ "dist/lib" ] }...
and dont forget "target": "es2015"

this is works for me


[FormControl] setFocused when disabled && visuallyFocused !== undefined

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Check out the following code:
 const [_focused, setFocused] = React.useState(false);
 const focused = visuallyFocused !== undefined ? visuallyFocused : _focused;

 if (disabled && focused) {
   setFocused(false);
 }

I'm not sure this is the right way to go about "lose focus if disabled", because if visuallyFocused == true, the setFocused will cause infinite updates.
The reason why I'm addressing it because I'm having problems with React's "update limit" where an error is thrown when passing <TextField focused disabled />, and these lines seem to be the cause of the problem (given this line in InputBase.js).
As for a solution, maybe somehow call onBlur if disabled && visuallyFocused !== undefined?
Your Environment 🌎

Tech
Version

Material-UI
v4.10.0

React
16.13.1

It sounds like you shouldn't be mixing both.

@oliviertassinari Fair enough, but making an app crash because of passing a certain combination of props, without providing a descriptive error, doesn't seem very good to me. It's not a far reached scenario passing both focused and disabled as true, even if it's not logical and/or happens by mistake.

We wouldn't encourage providing focused in the first place. It was added to support a requirement from the Date Range Picker.

@oliviertassinari Yet, it is still possible, and in my opinion also highly valuable in scenarios where a high level of advanced control of component state is needed.


mouseover values for ImageView

I have a much used ImageView application which displays live feeds from detectors. My users are asking for the image value to be displayed in the status bar when hovering with the mouse. For applications based directly on PlotWindow, I've been using some trick which I probably found in the docs,
    def __init__(self, parent=None, **kwargs):
        # List of information to display at the bottom of the plot
        posInfo = [
            ('X', lambda x, y: x),
            ('Y', lambda x, y: y),
            ('Data', self._getActiveImageValue)]

        super(CustomPlotWindow, self).__init__(parent=parent, position=posInfo, **kwargs)

    def _getActiveImageValue(self, x, y):
        """Get value of active image at position (x, y)

        :param float x: X position in plot coordinates
        :param float y: Y position in plot coordinates
        :return: The value at that point or '-'
        """
        image = self.getActiveImage()
        if image is not None:
            data, params = image[0], image[4]
            ox, oy = params['origin']
            sx, sy = params['scale']
            if (y - oy) >= 0 and (x - ox) >= 0:
                # Test positive before cast otherwisr issue with int(-0.5) = 0
                row = int((y - oy) / sy)
                col = int((x - ox) / sx)
                if (row < data.shape[0] and col < data.shape[1]):
                    return data[row, col]
        return '-'

but ImageView sets position=False in its constructor. Is there some smart way to accomplish mouseover values, other than overriding the whole ImageView constructor?

I found ImageViewMainWindow. It looks to provide the data on the toolbar. Does it fit your needs?

Else, I think it would be better to stop using constructor attributes and provide the same feature as a proper getter/setter. But a small fix as your requested makes sens. I think we have to ask feed back from @t20100 first.

I found ImageViewMainWindow. It looks to provide the data on the toolbar. Does it fit your needs?

Is that a silxclass?

I ended up doing the same hack as above, and in the ImageView constructor I did this,
self._positionWidget = tools.PositionInfo(plot=self, converters=posInfo)
self.statusBar().addWidget(self._positionWidget)

Then since it's a live viewer, where the image might change while the mouse is still, this gets done repeatedly,
self._positionWidget.updateInfo()

Else, I think it would be better to stop using constructor attributes and provide the same feature as a proper getter/setter.
Exactly!

ImageViewMainWindow was initially an example of using ImageView.
And, yes it's better not to use constructor parameters and add getter/setters, it's more Qt-ish and more versatile.
I'll look at that.

To me it is fine to compose your GUI with the widgets you need (rather than a widget with everything and then disabling what you don't need), but we can add getter for retrieving the PositionInfo widget of PlotWindow and allowing to update it's "converters" and to toggle its visibility.
Also it would be good to have a smarter PositionInfo which automatically updates when the data changes (probably as a mode that can be turned off).


bug covidTracker dashboard: indic2_france.jpeg is not automatically updated since november, 29

hi,
on the covidTracker dashboard, in "Saturation hospitalière", the graph is no longer updated since november, 29.
The corresponding graph is: images/charts/france/indic2_france.jpeg

Same for https://github.com/CovidTrackerFr/covidtracker-data/blob/master/images/html_exports/france/dc_new_bar.html, maybe related.


Proposal: accept mainClass property from  application.mainClass reference

Problem
Configure jpackage task using application.mainClass property like
tasks.jpackage {
    mainClass = application.mainClass
}

then the application is failed to launch with error
pure virtual method called
terminate called without an active exception
Error: Can not detect and load a main class "extension 'application' property 'mainClass'"
Cause: java.lang.ClassNotFoundException: extension 'application' property 'mainClass'

investigation
Because Gradle 8.x deprecated an application convention,  and mainClassName = 'java.class.name' String syntax is replaced to
application.mainClass = 'java.main.class'  by application plugin and it can be referenced by application.mainClass.
JavaApplication#getMainClass returns Property<String>, but jpackage plugin does not accept Property object.
similar case that works well in Gradle
You may know that JavaExec task can take a property in similar syntax such as
tasks.register('debug', JavaExec) {
    mainClass = application.mainClass
    classpath = sourceSets.main.runtimeClasspath
    debug true
}

JavaExec class in Gradle project source defines parameters like
  public JavaExec() {
        ObjectFactory objectFactory = getObjectFactory();
        mainModule = objectFactory.property(String.class);
        mainClass = objectFactory.property(String.class);

gradle source code

then it can accept the syntax.
Here is a proposal to change internal variables from String to Provider<String>,  and change references to object.get().
User side solution
User can avoid a problem when using jpackage
mainClass = application.mainClass.get()

rather than a way  JavaExec accepts.

That's definetly not a plugin issue. Plugin expects string here. How this string is produced is totally up to the build script.


Not working on python 3.9.0

since when i updated on python 3.9.0 both keys are not working, please update for latest version of python

I think you need to download Python from Microsoft Store..
tc of the version though..


Cannot read property 'dispose' of undefined when switching branches

Refs https://github.com/microsoft/vscode/issues/122245
I've seen this a few times when switching branches via the status bar, both going into a branch that has a PR and going back to main

GH PR Extension Version: v2021.4.39423
Version: 1.56.0-insider (user setup)
Commit: 13f1afffab09548c10ddb3bc5d5db52587876ad8
Date: 2021-04-28T04:52:06.990Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042

I haven't been able to reproduce this yet but just checked in a possible fix, let me know if you still see it


New error while building the image

no main manifest attribute, in application.jar
The command '/bin/sh -c java -Djarmode=layertools -jar application.jar extract' returned a non-zero code: 1

Closed with the use of mvn spring-boot:build-image. (Pull Request #52)


Improve role based views (backend)

Reduce redundancy in code regarding role based permissions and views

make a Role type
create dict of what's allowed by role

@rmarow there was some more details discussion about this somewhere, can you please link to it?

https://github.com/nsidc/usaon-vta-survey/pull/157#discussion_r1347907442

Something we should consider is representing this access dictionary in the database. Perhaps that's another iteration down the road, but imagine:

permission
role

create_response_objects
respondent

create_response_objects
admin

create_new_survey
admin

Then if one day an admin decides that respondents should be able to create new surveys, they can add a new record.


Touch up code for Learn Guide

Hi -- I was asked to review the Adafruit Learn Guide for your board. I made some small changes in the text and in the code to simplify it. I don't have the board so I couldn't test my changes. Could you review and suggest anything you don't want to change? I'll update the Learn Guide with the latest version once this is merged. Thanks.

Remove "Scott Shawcroft" copyright
Explicate preset values.
Use board.STEMMA_I2C(), which is available on all boards with a STEMMA connector.
Remove unused initial_time variable.
Use a triple-quoted string for the help message instead of multiple print() statements.
Use multiple args for print() statements instead of + str(...).

Hi @dhalbert
I'm ok with all the changes but need to keep the initial_time variable for RDS to work correctly. I tested it on the board and RDS data does not show up without initial_time. This is used to check received RDS data. Please let me know if this makes sense. Thanks!
So we can leave the code as below for initial_time.
rds = tinkeringtech_rda5807m.RDSParser() initial_time = time.monotonic()  # Initial time - used for RDS timing toggle_frequency = (     5  # Frequency at which the text changes between radio frequnecy and rds in seconds ) rdstext = "No rds data"

Ah, you are right. My earlier comment does not make sense. For some reason I thought that the initial_time variable was indeed used. I approve of all the changes.

Yes, just tried it and it worked. Thanks Dan for your time taking a look. Hope you get a board and play around with it! I personally have a soft spot for FM radio since I built my first crystal set as a kid :)

I just ordered a board!


Require capitalize from titles

Closes #13

tests are red, otherwise looks good

@gotbahn PTAL

Public Transport Accessibility Level

Please take another look I learned it from @jeniamoroz


set up redux actions and reducers for fetching class data from the BE

Description
Pair Programmed: @seanmp3 @mark-escosura
Set up redux to fetch class data from the backend. Fixed reducer to use our thunk action instead of hardcoded dummy data, created thunk action to fetch all classes, dispatch our action to fetch classes in the appropriate component.
Fixes # n/a
Loom Video
(https://www.loom.com/share/3a063533bb3144ce965e31a36404330c)
Redux Implementation
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have removed unnecessary comments/console logs from my code
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings
[x] No duplicate code left within changed files
[x] Size of pull request kept to a minimum
[x] Pull request description clearly describes changes made & motivations for said changes

Great work
Your code looks organized and clean


Doesn't work with factories

When running factories, the data will be empty:
<?php

namespace Database\Seeders\Pages;

use App\Pages\Entities\Page;
use Illuminate\Database\Seeder;
use Illuminate\Database\Eloquent\Model;

class PagesTableSeeder extends Seeder
{
    /**
     * Run the database seeds.
     *
     * @return void
     */
    public function run()
    {
        Model::unguard();

        factory(Page::class, 500)->create();

        //Page::forgetCache();

        dd(Page::all());
    }
}

this will return an empty collection even though there's rows in the database.

If this issue still exists, I would love to consider a PR for a fix :)


Refresh Needed in IE11 to Show Changes

Chrome seems to be fine, but you often need to refresh IE11 in order to show changes in the app.

We'll schedule in 1.0.2 to test on the windows VCL lab Edge version next week as part of the 1.0.2 dev cycle and assess.


⚠ API - Lens has degraded performance

In 0db78e1, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 502
Response time: 410 ms

Resolved: API - Lens performance has improved in 842b00d after 6 minutes.


Document the GitHubRelease v1 task

Related: https://github.com/microsoft/azure-pipelines-tasks/tree/master/Tasks/GitHubReleaseV1

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3b12d2c4-f871-1d14-0c16-91e58fb1130b
Version Independent ID: 6b9e1d67-f303-7445-e573-830309ba49a4
Content: GitHub Release task - Azure Pipelines
Content Source: docs/pipelines/tasks/utility/github-release.md
Product: devops
Technology: devops-cicd-tasks
GitHub Login: @vijayma
Microsoft Alias: vijayma

@gldraphael Thank you for the feedback.
This issue was previously reported under https://github.com/MicrosoftDocs/azure-devops-docs/issues/5996 and has been assigned to the author for review.
Please refer there for further updates.


Add or logical expression

There was a mistake: and operator was introduced two times

Thanks for noting!


fr_CA doesn't fall back on fr

I don't know if it's a bug or an enhancement, but no matter what I do (set the local to fr without a country code, even create a strings_fr_ca.arb as a temporary solution), nothing works. According to i18n.dart, it should be a default behavior to fallback to the default language without a country code, right?
[✓] Flutter (Channel stable, v1.5.4-hotfix.2, on Mac OS X 10.14.5 18F132, locale en-CA)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.2.1)
[✓] Android Studio (version 3.4)
[✓] Connected device (1 available)

$flutter clean solved it! :P


feat: add lazyCompilationBackend options

Support customizing lazyCompilationBackend port and allow HTTPS
Fixes #14053, #14205

What kind of change does this PR introduce?
Feature.
Adds a new property to allow passing options to the lazyCompilationBackend. This allows the consumer to configure a port (requested in #14065) and HTTPS (requested in #14205)

Did you add tests for your changes?
I did not. Looks like there are no existing tests for this experimental feature.
If I could get feedback on the proposed changes, I will gladly add tests.

Does this PR introduce a breaking change?
No. The new property backendOptions is optional.

What needs to be documented once your changes are merged?
Lazy Compilation documentation would need to be updated to include the new property

Sorry about the force push. Needed to fix my commit email.

Sorry about the force push. Needed to fix my commit email.

Feel free to force push as often as you like. It's your PR

@alexander-akait do you mind providing some guidance on this PR. Thank you kindly.

@alexander-akait don't know why my build is failing? Seems to pass sometimes?

Random fail

@alexander-akait should I force push to retry? Or is there another way to rerun the build?

Try to force push

Looks like I have some code coverage issues: 🤷  Any guidance would be appreciated.

@alexander-akait Is there anything I can do to move this forward?

@alexander-akait 🙏


Add IdentityMap middleware to datamapper

This closes #1930
Please let me know if you have better name of middleware.

Thanks


Navigation between questions during correction : A possiblity to iterate over all questions from all students  with one button

During correction, once arrived to the last question, the right button is disabled. I think it could be great if it would permit go back to the first question. Likewise with the student navigation.
A nice thing would be that when arrived to the last question, the next page would be the first question of the next student.
Likewise when arrived to the last student : the next page would be the first student at the next question.
To be clearer, I made this diagram :

@arnobl  What do you thing regarding usability.
If you agree I could implement it

I do not know. It may be interesting but the fact that 'next student' moves to the next question at a moment is disturbing.
When moving to the next question using the button 'next question', I suggest to rename the button accordingly. Same thing for the button 'next question' that at the end moves to the next student.

done with keyboard shortcut only


Check for updates

Describe the bug
Even thought 2.12.1 is out, version 2.12.0 didn't suggest it upon opening (as it usually does) - and yes, this is selected within File->Preferences->General.
Also, when clicking 'check for updates within File->Preferences->General, it spins for a while and gives a timeout error (shown below).
Thanks!

Thanks for reporting. 2.12.0 (and earlier versions), should now correctly indicate that a new version is available.
The timeout issue may be web proxy related. Looking into it.

Confirmed! Thanks!

Fixed in 2.12.4. Thanks!

Thanks!


[azcore] Create clients directly from a pipeline

Feature Request
It would be helpful for the Track 2 SDKs to expose the ability for a client to be created directly from a pipeline for a few main reasons
In a large transfer AzCopy job, with repeated TokenCredentialPolicies we have experienced customers hitting client_request_loop errors due to refreshing the token too many times. https://github.com/Azure/azure-storage-azcopy/issues/1957 My understanding is that there are too many BearerTokenPolicies and they try to refresh all approximately around the same time close to the expiry. The AAD endpoint thinks the same client is refreshing the token and limits us thinking we are choosing not to use the refreshed token.
One potential way to share a pipeline would be to use the existing NewXXXClient method on an existing client, but this is problematic for a couple reasons

A customer may only want multiple BlobClients (in the context of Azure Storage) so creating the ContainerClient is not useful
Customer logic could be generic and apply across multiple services (ex: AzCopy has generic logic for blob, file share, datalake services)
It is inconvenient to carry around multiple credential types and have repeated switch statements to create any given type of client based on the credential type.

Regarding the too many refreshes, I've separated that into https://github.com/Azure/azure-sdk-for-go/issues/20044

Per discussion, there is no longer a need for this functionality.


Allow turning circuits into operators

I still need to add a couple of unit tests, etc. and but I thought it made sense to submit an early PR to check if the approach meets your expectations.
You can check examples/custom_operator.py to see how the new feature is supposed to be used.

Hi Juan, thanks for your contribution! This is a really high quality PR - it's well linted, and the unittests are coming along well. Let me know when you have finished, and I'll do a short code review before merging.

Thanks! :) I would say the main functionality is there and it could be reviewed.
I am not sure if you would like to document the feature in this very same PR. But maybe it is a good idea that you review the code/approach before that.

Hmm, I'm not sure why Travis/Codecov didn't pick up this pull request. Let me see if I can trigger a build manually, and then I'll merge

Yes, I noticed that too. In my experience, circleci behaves a lot better than travis

Very odd. I have downloaded it locally, tested it, and checked the coverage, so I am happy to perform the merge now.


User menu is enabled but not being displayed on navbar

Laravel version: 8.*
Current Behavior
User menu is enabled but it's not being displayed

Expected Behavior

Hi @arthurmgb , the usermenu will not be displayed if you do not have an authentication scaffolding installed, since It check if any user is authenticated before displaying anything. Have you installed some authentication scaffolding and running the database migrations for Laravel? If not, please take a read to step 3 of Installation and the suggested links...

Thank you, it worked after jetstream installation.


LMB dragging operations trigger unwanted node graph panning

A couple (probably) related issues here :

When dragging a nodule to the edge of the node graph panel, going too far and over a second open node graph will trigger a panning of that second graph. That panning will continue until the user does an action in the continuously panning graph (most likely press F key to reframe to the lost node graph).
When dragging a parameter from one node editor to another one to create a connection (LMB), when passing over a node graph will also trigger the same panning.

Seems like the panning zone is sensitive to actions triggered by other panels while it should only respond to actions triggered by the panel it belongs to.

Thanks for the bug report Mathias - I've fixed it in #1322.


updating video intelligence sample to 0.21.1-alpha

FYI, https://github.com/GoogleCloudPlatform/google-cloud-java/issues/2348

@lesv Tests all pass now, you can review.


[784] Show trn number in heading on trainees edit

Context
If a trainee has been assigned a trn number it is now visible on the trainees edit page.
Changes proposed in this pull request

Added a view component
Added the trn number and status tag to the component
Added record header to trainee layout
Fixed spec description to make tests more consistent

Guidance to review

Boot up the server and navigate to trainees/?/edit
Check the trn number is visible if the trainee has been assigned one (e.g a QTS awarded record)
Check the trn number is not visible if the trainee has not been assigned one (e.g a draft record)

 Ensure we show TRN in heading on trainees#edit

 Ensure we show TRN in heading on trainees#edit


chore(stable): Update stable to 4.9.4

:tada: This PR is included in version 4.9.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Live

Test PR

Docs Build status updates of commit fe53abd:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Test PR


Harvester: support mcm

Hello, I am a serverless review bot on flows.network. Here are my reviews of code commits in this PR.

review it

Hello, I am a serverless review bot on flows.network. Here are my reviews of code commits in this PR.

Commit 1
This patch introduces changes across multiple files for the Harvester product. The changes involve adding support for MCM, updating dashboard metrics, and making tweaks to several files.
One potential problem is that some sections of code have been commented out rather than entirely removed, which could cause confusion and unexpected behavior during future development. Another potential issue is that several changes have been made to related files, which may require additional testing to ensure nothing has been broken.
Overall, the changes appear to be focused on improving the functionality of the product, and the code modifications seem appropriate.


[2pt] Update README.md and INSTALL.md to talk about dev-v2 branch

We recently added dev-v2 branch, but at this point it is NOT the default branch. dev is still the default branch. We need to update the documentation to mention this.

During the WIP of the dev-v2 branch (pre-merge to dev), I updated the README.md and INSTALL.md.  Once we change to the full V<IP_ADDRESS> series (workable), adjust these two files again.


NonViewComponent attribute documentation

Fixes #23963
This is a documentation for the use of the NonViewComponent Attribute([NonViewComponent]).
Internal Preview URL.

Hi @Maniizzle ... Kirk is out for the seasonal holiday but will return soon. I know that you're working with him on this, so I'll assign this to him. He'll get back to you when he returns in '22.

Thank you @guardrex

Sure thing .... and the build should start working again soon. You can see ☝ that we have some 😈 GREMLINS 😈 at the moment having some holiday fun with us here! 😆 ... They'll get those little guys out at some point, then this will build out and show you if there are any real build warnings/errors.

hahahaha.. I saw the  😈 GREMLINS 😈. They are really having fun

@Rick-Anderson ... I've been periodically trying that on my patch PR, too. No 🎲🎲 yet.

I'm monitoring the internal bug. I'll keep you posted.

@Maniizzle Be sure to check What's New early in February, where you'll see yourself listed as a valued contributor for January.


Add text field that is compatible with older SFOS versions

Fixes #81
Please review

I took a look on wayback machine, and yes, description must have been added after sep 2020 https://web.archive.org/web/20200925155838/https://sailfishos.org/develop/docs/silica/qml-sailfishsilica-sailfish-silica-textfield.html/

This is working fine: The Settings page of SailfishOS:Chums-GUI 0.4.0-1 opens on SFOS 3.2.1.


Enable custom Python optimizer in C# MeanVarianceOptimizationPortfolioConstructionModel

Description

The bug was raised because, when trying to use C# MeanVarianceOptimizationPortfolioConstructionModel.cs from a Python
algorithm, there wasn't a constructor that accepted a portfolio optimizer as a PyObject. Additionally, there wasn't also a Python Wrapper to wrap that portfolio optimizer.

Add PortfolioOptimizerPythonWrapper.cs
Add constructor in MeanVarianceOptimizationPortfolioConstructionModel.cs that accepts portfolio optimizer as a PyObject
Add regression and unit tests to cover the changes

Related Issue

Closes #6758
Motivation and Context

With this change users will be able to use custom Python optimizer's in C# MeanVarianceOptimizationPortfolioConstructionModel
Requires Documentation Change

This change does not require updates to documentation
How Has This Been Tested?

There was created regression algorithms in both C# and Python, that inherited from MeanVarianceOptimizationFrameworkAlgorithm, but had a custom optimizer
Different unit tests were created asserting the behavior of the modified constructor, from MeanVarianceOptimizationPortfolioConstructionModel, with distinct potential argument combinations

[x] Bug fix (non-breaking change which fixes an issue)
[x] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

🥇 Awesome!