These are the initial groundwork for the shape functionality.

In response to #275
Soliciting feedback.
Right now I have envisioned it as we have a set dictionary of supported shapes, right now spheres (redundant, yes, but they are useful for testing) and ellipsoids, located in src/shapes.ts. These classes each should have their own static validation method that can be called in src/dataset.ts and a method that generates the input for 3dmol.addCustom. During rendering in src/structure/viewer.ts, the viewer loads these methods and pushes a new instance to the viewer. If shapes are being used, we do not render the corresponding sphere, but this can be switched on/off.
Changes have been made to the following files:

src/dataset.ts: adding shape parameters to the Structure, validating the shape parameters when validating the structure
src/3dmol/index.d.ts: adding CustomShapeSpec and addCustom for 3dmol
src/structure/options*: button to turn shape on/off
src/structure/viewer.ts: function to add shapes to the viewer, disabling sphere style when shapes are wanted

As of now it is not working. You'll see in the ellipsoid class in src/shapes.ts I've put in some dummy coordinates to see if 3dmol will render a simple cube, but to no avail. Would appreciate feedback and input on 1) general plan of attack and 2) why it is not rendering

A couple of code comments. Regarding why it is not rendering, the code seems to be missing an update of this.shape_ whenever the user updates the checkbox, did you try forcing shapes to be true? (I would remove this checkbox altogether anyway).
If that does not help, I would check that 3Dmol shape rendering works in a standalone example, using https://codepen.io/luthaf/pen/JjmvKVe as a stating point for example.

I did try forcing this._shape=true in the constructor (while also overriding the options), but to no avail. I tried the codepen, but was also having issues getting it to compile (not confident on that interface).
I'd like to keep the checkbox, it can sometimes be important to render the shapes or their centers, depending on what you're looking for.
Any other thoughts on why it isn't rendering?

Try removing this._shape and using this.options.shape.value instead, this should removing the need to synchronize with HTML manually

I've given another pass and... it works! There's still some small things to work out in the code, but @Luthaf can you take a look at the general changes and see how you feel? I had to rebase on #283 , because it turns out there were some issues with us templating the addCustomShape into the 3dmol file from earlier.

So the changes I added broke a lot of things, so I had to revert here and there to get things up and running (I couldn't find a way forward with the changes as is).

Something that would make this (even) more useful is to give the possibility of specifying multiple shapes, and then choosing which shape to show. This would allow one to use this to visualize properties - polarizability, forces, etc. A "scale" slider would then also be very useful but it can come later. Thoughts?

More updates! Now we can support multiple shapes for a given dataset, with a drop-down to select them. Was a pain to implement, but I think it came out quite nicely. Ready for another look-over!

Hey @Luthaf , I handled most change requests, leaving one or two questions along the way. The remaining API iron-out is whether shapes should be passed through the frames or no -- how much of a hang-up is this? Full stop or open for discussion?

The remaining API iron-out is whether shapes should be passed through the frames or no -- how much of a hang-up is this? Full stop or open for discussion?

I would like to get this right before merging, but I'm willing to help implement it when we converge on the API design!
Other than that, this PR also needs some documentation in https://github.com/lab-cosmo/chemiscope/blob/master/docs/src/tutorial/input-reference.rst, with a short example for each shape kind.
We also need to reach some consensus on the quaternion convention, but then the code looks ready to go!

Note for myself: check what happen when the users switches between different structures with different set of shapes (i.e. different shape names).

@Luthaf I've made the switch in the python API, let me know thoughts. I added docs and clarity on quaternions. Should be ready for next review.

I tried the code locally, and it runs quite nicely!
A problem occurs when trying to load a file with different shape names in each structure, and switching to a structure where the previous shape is not defined (here a small file demonstrating this: multiple-shapes.txt)
!(current_shape === undefined)
_construct@http://localhost:8080/chemiscope-app.min.js:53236:393
Wrapper@http://localhost:8080/chemiscope-app.min.js:53232:473
AssertionError@http://localhost:8080/chemiscope-app.min.js:53577:80
innerOk@http://localhost:8080/chemiscope-app.min.js:52712:15
ok@http://localhost:8080/chemiscope-app.min.js:52731:11
_addShapes@http://localhost:8080/chemiscope-app.min.js:219093:54
_updateStyle@http://localhost:8080/chemiscope-app.min.js:219063:18
load@http://localhost:8080/chemiscope-app.min.js:218713:14
_showInViewer@http://localhost:8080/chemiscope-app.min.js:217934:20
show@http://localhost:8080/chemiscope-app.min.js:217717:14
./src/index.ts/DefaultVisualizer/this.map.onselect@http://localhost:8080/chemiscope-app.min.js:212338:28
./src/map/map.ts/_createPlot/<@http://localhost:8080/chemiscope-app.min.js:215294:18
emit@http://localhost:8080/chemiscope-app.min.js:69404:17
./node_modules/plotly.js/src/lib/events.js/init/plotObj.emit@http://localhost:8080/chemiscope-app.min.js:114817:16
emitClick@http://localhost:8080/chemiscope-app.min.js:93491:31
click@http://localhost:8080/chemiscope-app.min.js:93496:16
clickFn@http://localhost:8080/chemiscope-app.min.js:136496:20
onDone@http://localhost:8080/chemiscope-app.min.js:89897:41
mouseupListener@http://localhost:8080/chemiscope-app.min.js:216324:26

We could decide this is an invalid file, and check that all structures have the same set of shape, or we could handle the case when loading a new structure. I would tend toward the first solution, and we can always lift the restriction later if needed.

I would say to make this invalid to avoid the nan disaster of partially-defined features, what do you think?

Just to say I tried it and (with errors) it works. Just a few superficial comments:

it would be nice to have an example that demonstrates ALL functionalities, not just the ellipsoids
I strongly suggest that we should allow to display the shapes in addition to the atoms. must think of a good UI for that
IDK if it's intended, but all structures are shown with ellipsoids, even when there are none defined (e.g. for the default examples)

I would say to make this invalid to avoid the nan disaster of partially-defined features, what do you think?

yes, making it invalid sounds good!

I just squashed all commits from this PR in a single one, and removed the example file. Here it is for posterity:
sample_ellipsoids.json.txt

I've done a bunch of cleanup, a couple of remaining questions/discussion points:

giving non-normalized quaternions for the orientations renders weirdly. Should we warn/error on them?

chemiscope.write_input(
    "1.json",
    frames=[frame],
    properties={
        "foo": [1.2],
        "bar": [1.5],
    },
    shapes={
        "cubes": [
            [
                {"kind": "custom", "vertices": CUBE_VERTICES},
                {
                    "kind": "custom",
                    "vertices": CUBE_VERTICES,
                    "orientation": [1, 0, 0, 0],
                },
                {
                    "kind": "custom",
                    "vertices": CUBE_VERTICES,
                    "simplices": CUBE_SIMPLICES,
                    "orientation": [0.1, 0.2, 0, 0],
                },
            ],
        ]
    },
)

the file above is still a bit weird w.r.t. shading and light. Is this a convention issue for the order of simplices?

Still TBD for me: adding more validation of the input JSON on the JS side.

I've done a bunch of cleanup, a couple of remaining questions/discussion points:

giving non-normalized quaternions for the orientations renders weirdly. Should we warn/error on them?

chemiscope.write_input(
    "1.json",
    frames=[frame],
    properties={
        "foo": [1.2],
        "bar": [1.5],
    },
    shapes={
        "cubes": [
            [
                {"kind": "custom", "vertices": CUBE_VERTICES},
                {
                    "kind": "custom",
                    "vertices": CUBE_VERTICES,
                    "orientation": [1, 0, 0, 0],
                },
                {
                    "kind": "custom",
                    "vertices": CUBE_VERTICES,
                    "simplices": CUBE_SIMPLICES,
                    "orientation": [0.1, 0.2, 0, 0],
                },
            ],
        ]
    },
)

the file above is still a bit weird w.r.t. shading and light. Is this a convention issue for the order of simplices?

Still TBD for me: adding more validation of the input JSON on the JS side.

I added a test for quaternion normalization -- I honestly have no idea why the cubes look weird.

The code is now in good shape IMO. Are you also happy with it @rosecers? If so, we could merge this, wait for a couple of weeks to let any remaining issues surface (and try to figure out what's happening with the cubes) and then release version 0.6 of chemiscope!

The code is now in good shape IMO. Are you also happy with it @rosecers? If so, we could merge this, wait for a couple of weeks to let any remaining issues surface (and try to figure out what's happening with the cubes) and then release version 0.6 of chemiscope!
EDIT: I'll fix the remaining issue in the Python code

Sounds good!

Do you think we could also complete the color-by-property PR? I think the
two would go together VERY well.
On Fri, 21 Jul 2023 at 09:58, Rose K. Cersonsky @.***>
wrote:

The code is now in good shape IMO. Are you also happy with it @rosecers
https://github.com/rosecers? If so, we could merge this, wait for a
couple of weeks to let any remaining issues surface (and try to figure out
what's happening with the cubes) and then release version 0.6 of chemiscope!
EDIT: I'll fix the remaining issue in the Python code
Sounds good!
—
Reply to this email directly, view it on GitHub
https://github.com/lab-cosmo/chemiscope/pull/282#issuecomment-1645801351,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIREZY7OOLKC6HO5Y5YPQTXRKRLRANCNFSM6AAAAAAX5DTVBA
.
You are receiving this because you commented.Message ID:
@.***>

Since the idea was that the new master student would work on the color-by-property branch, that would push the release quite a bit further. I'd be fine to do a v0.6.1 or v0.7 with color-by-property while making the shapes available to everyone sooner.

OK makes sense.
On Mon, 24 Jul 2023 at 02:53, Guillaume Fraux @.***>
wrote:

Since the idea was that the new master student would work on the
color-by-property branch, that would push the release quite a bit further.
I'd be fine to do a v0.6.1 or v0.7 with color-by-property while making the
shapes available to everyone sooner.
—
Reply to this email directly, view it on GitHub
https://github.com/lab-cosmo/chemiscope/pull/282#issuecomment-1647491881,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIREZ7Z7MPQN66NDQCHPIDXRYZXRANCNFSM6AAAAAAX5DTVBA
.
You are receiving this because you commented.Message ID:
@.***>


Added rate parameter to hazard function call

Call to hazard was missing rate param, lam

Noted with thanks. Right, i didn't consider other than the constant hazard function.  I had extracted the block inside the for loop to incorporate in an actual online process to ingest data one sample at a time in real time.
I'll look at making a hazard function factory that takes whatever params are needed for a given hazard function and returns a function with the right signature for partial et al.


Make 0-bootstrap IAM bindings merge(..) a deep-merge

When identity provided as  bootstrap_user is used in other IAM permissions, it looses its permissions defined in local.iam_user_bootstrap_bindings which breaks bootstrap deployment.
The merge we had works as long as IAM principals are distinct across the merged maps, if they are provided in multiple ones, we need to concat manually the lists.
I do not like how the code looks, so open to any ideas how to improve that. Also, I don't understand why we do not take any authoritative bindings from local.iam_principal_bindings, but I kept this as it was.

Checklist

I applicable, I acknowledge that I have:

[x] Read the contributing guide
[x] Ran terraform fmt on all modified files
[ ] Regenerated the relevant README.md files using tools/tfdoc.py
[ ] Made sure all relevant tests pass

Wiktor this is working as idended: from our point of view there should be no user-level permissions at the org level. We also never saw this fail in 3 years of using FAST.
Can you give a specific use case you're trying to address? I'm a bit wary of hurting legibility to address a problem we've never faced.


Trim Stack Trace

Related issue:
https://github.com/freechipsproject/chisel3/issues/845
This is what the trimmed stack trace looks like (using the example from the issue). I only trimmed the top and bottom of the stack. Not sure about how the middle part should be filtered.
[info] [0.003] Elaborating design...
[error] chisel3.core.Binding$ExpectedChiselTypeException: reg type 'chisel3.core.UInt@3400978d' must be a Chisel type, not hardware
[error]         ...
[error]         at NeedChiselType.$anonfun$delays$1(ChiselExceptionTest.scala:8)
[error]         at scala.collection.generic.GenTraversableFactory.fill(GenTraversableFactory.scala:90)
[error]         at NeedChiselType.<init>(ChiselExceptionTest.scala:8)
[error]         at NeedChiselTypeTop$.$anonfun$code$1(ChiselExceptionTest.scala:17)
[error]         at chisel3.core.Module$.do_apply(Module.scala:51)
[error]         at chisel3.Driver$.$anonfun$elaborate$1(Driver.scala:94)
[error]         at chisel3.internal.Builder$.$anonfun$build$2(Builder.scala:317)
[error]         at scala.util.DynamicVariable.withValue(DynamicVariable.scala:58)
[error]         at chisel3.internal.Builder$.$anonfun$build$1(Builder.scala:315)
[error]         at scala.util.DynamicVariable.withValue(DynamicVariable.scala:58)
[error]         at chisel3.internal.Builder$.build(Builder.scala:315)
[error]         at chisel3.Driver$.elaborate(Driver.scala:94)
[error]         at chisel3.Driver$.execute(Driver.scala:185)
[error]         at chisel3.Driver$.execute(Driver.scala:264)
[error]         at NeedChiselTypeTop$.delayedEndpoint$NeedChiselTypeTop$1(ChiselExceptionTest.scala:17)
[error]         at NeedChiselTypeTop$delayedInit$body.apply(ChiselExceptionTest.scala:16)
[error]         at scala.Function0.apply$mcV$sp(Function0.scala:34)
[error]         at scala.Function0.apply$mcV$sp$(Function0.scala:34)
[error]         at scala.runtime.AbstractFunction0.apply$mcV$sp(AbstractFunction0.scala:12)
[error]         at scala.App.$anonfun$main$1$adapted(App.scala:76)
[error]         at scala.collection.immutable.List.foreach(List.scala:389)
[error]         at scala.App.main(App.scala:76)
[error]         at scala.App.main$(App.scala:74)
[error]         at NeedChiselTypeTop$.main(ChiselExceptionTest.scala:16)
[error]         at NeedChiselTypeTop.main(ChiselExceptionTest.scala)
[error]         ... (Stack trace trimmed to user code only, rerun with --full-stacktrace if you wish to see the full stack trace)

Type of change: feature request

Impact: no functional change?
This PR changes Driver.execute so that it catches ChiselException and returns ChiselExecutionFailure instead of letting them fall through. This affected DontTouchSpec which was looking for a binding exception to be thrown. not sure about what other affects this may have.

Development Phase: implementation
Release Notes

Can one of the admins verify this patch?

ok to test

I thought I had admin powers to start Jenkins... Apparently not...

ok to test

Guess I don't have the power either 🙁

This looks really good. Once change I would suggest (and I'm soliciting opinions here) is that I would trim the bottom to be the first element on the stack in the user code within the context of Chisel.
For example, I would further trim the above to:
[info] [0.003] Elaborating design...
[error] chisel3.core.Binding$ExpectedChiselTypeException: reg type 'chisel3.core.UInt@3400978d' must be a Chisel type, not hardware
[error]         ...
[error]         at NeedChiselType.$anonfun$delays$1(ChiselExceptionTest.scala:8)
[error]         at scala.collection.generic.GenTraversableFactory.fill(GenTraversableFactory.scala:90)
[error]         at NeedChiselType.<init>(ChiselExceptionTest.scala:8)
[error]         at NeedChiselTypeTop$.$anonfun$code$1(ChiselExceptionTest.scala:17)
[error]         ... (Stack trace trimmed to user code only, rerun with --full-stacktrace if you wish to see the full stack trace)

I think the trimming should look for the Builder (kind of the entry point for Chisel) and then trim until it finds the first piece of user code there. We're trying to give stack traces of stuff within Chisel code so I would ignore anything outside of the context of Chisel elaboration by default

ok to test

I think Jenkins has its own idea of who are  the admins. I'll try to update it.

@ucbjrl Could we make it so all reviewers can ask Jenkins to rebuild?

The existing GitHub pull request builder Jenkins plugin is being deprecated. I'll check out its replacement to see if there's a way to use GitHub teams to determine authorization.

In response to @jackkoenig comment on the trimmed stack trace, I don't agree that Builder should be the start point, the test harness itself should definitely remain included in the stack trace, that tells you specific line where the test failed in your Spec file. I'd suggest that you eliminate any lines whose address starts with at scala. except possibly the first one, since these lines are generally the guts of the scala libraries (collections in particular) and rarely have any direct consequence in the failure. Eliminating these lines would be a meaningful list of top to bottom

@chick, assuming Chisel still returns error, then ScalaTest or the chisel testers should still throw their own exceptions that include the stack trace of the invocation of the test? Perhaps I should try my proposal and see how it looks with the testers...
My proposed trimming removes 21 out of the 25 lines in @albertchen-sifive's originally proposal. I'm not sure what your proposed trimming would look like, but an alternative approach preserving some of the user invocation could trim further to something like:
[info] [0.003] Elaborating design...
[error] chisel3.core.Binding$ExpectedChiselTypeException: reg type 'chisel3.core.UInt@3400978d' must be a Chisel type, not hardware
[error]         ...
[error]         at NeedChiselType.$anonfun$delays$1(ChiselExceptionTest.scala:8)
[error]         at scala.collection.generic.GenTraversableFactory.fill(GenTraversableFactory.scala:90)
[error]         at NeedChiselType.<init>(ChiselExceptionTest.scala:8)
[error]         at NeedChiselTypeTop$.$anonfun$code$1(ChiselExceptionTest.scala:17)
                ...
[error]         at NeedChiselTypeTop$.delayedEndpoint$NeedChiselTypeTop$1(ChiselExceptionTest.scala:17)
[error]         at NeedChiselTypeTop$delayedInit$body.apply(ChiselExceptionTest.scala:16)
                ...
[error]         at NeedChiselTypeTop$.main(ChiselExceptionTest.scala:16)
[error]         at NeedChiselTypeTop.main(ChiselExceptionTest.scala)
[error]         ... (Stack trace trimmed to user code only, rerun with --full-stacktrace if you wish to see the full stack trace)

I really think we should find a way to remove the 10 lines from chisel3.Driver.execute the outer Module.do_apply because it's mostly worthless for the user

@jackkoenig Looking over things I am fine using your trimming strategy. I think it's nice if you can see the test where things originated, but I agree as little as possible of the Driver.execute stuff should be seen. I think it's been done here, but as little as possible of the scalatest stuff should show. IntelliJ grays out all this junky stuff, but not seeing it all would be better


docs(setup): adds a little language to Install Halyard...

...to make it clearer what exactly Halyard is.

Per #1277


decoding of HEVC operation point descriptor.

this version treats the HEVC Profile Tier Level information (the sets of 96 bits) opaquely - a future update will dissect these

I would recommend for (size_t j = 0; j < _ES.size(); j++) because you iterate over an array index and an index is always of type size_t in C++. In the two loops. The alert is perfectly valid. If a malicious user injects an XML text with 256 or more subsections, your code will loop forever with uint8_t because it loops back from 255 to 0 and never reaches size().
You may say that this would be an invalid table and you are right. But the art of hacking is to find the right invalid input which fools code which does not correctly check its input to make it do something dangerous or damaging (here, a denial of service).
I am pleasantly surprised by the quality of GitHub code scanning. This is part of their effort to improve the security of open source code. And it seems to work!


Use curl-config to find curl

On BSDs headers will be in /usr/local/include which
is not added to the include path automatically.
This is a rebased version of #1237
Closes #1237

Thanks!

Thanks for having merged this pull request !


Adding support for jagged arrays as inputs to TFTensor

Adding a possible solution for #33. I've used the current implementations from the Accord.NET Framework as a base without many modifications. As such, it can be the case that those implementations could have been more optimized for the particular use case here, namely, to simply convert from Jagged to Multidimensional arrays such that they could be given as inputs to TFTensor.
Being the sole author and writer of those relevant lines, I license them under the MIT license as the rest of the TensorFlowSharp project.

Ops, I've ended up touching the formatting of some white lines in the committed files. I will try to fix those when I have some time again.

ok, will wait.

Formatting restored.

Thanks!


fix(source-material): fix false path traversal error when importing epub

:tada: This PR is included in version 1.0.0-alpha.24 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


How to require Handlebars runtime (only) with Node.JS?

Since my templates are precompiled so I want something like require("handlebars-runtime") instead of full Handlebars module as usual. But I didn't find any document for it.
I found other packages support it on npmjs, but still want to check this one first.
Thanks,

require('handlebars/runtime') should do the trick. Please let me know if it does not.


Bubbles

Bubbles are like Tooltips, but support HTML within.
http://blazecss.com/components/bubbles/

To be considered:

should it be possible to display/hide the bubble programaticaly?
should bubble be displayed/hidden automatically on hover


UseMetricsAllEndpoints() call fails with NullReference exception

Repro steps:

In ConfigureServices method do:

var metrics = AppMetrics.CreateDefaultBuilder().Build();
services.AddMetrics(metrics);
services.AddMetricsTrackingMiddleware();

In Configure method do:

app.UseMetricsAllMiddleware();
app.UseMetricsAllEndpoints();
Result: in output:

Exception thrown: 'System.ArgumentNullException' in App.Metrics.AspNetCore.Core.dll
An exception of type 'System.ArgumentNullException' occurred in App.Metrics.AspNetCore.Core.dll but was not handled in user code
Value cannot be null.

Expected result:
/metrics endpoint is available

Workaround: use BuildWebHost for registering MetricsEndpoints
WebHost.CreateDefaultBuilder(args)
                ...
                .UseMetricsWebTracking()
                .UseMetricsEndpoints()
                .UseStartup<Startup>()
                ...
                .Build();

@ivlevkonstantin in your ConfigureServices method you are missing services.AddMetricsEndpoints() in the same way services.AddMvc() is required to app.UseMvc().
But yes the WebHost extensions are there to simplify configuration and allow keeping metrics/health, being "infrastructure" concerns, out of the way from your more application specific configuration.
I've kept the IApplicationBuilder and IServiceCollection extensions there for when more control is needed, but yes this approach is more tedious as apposed to using the WebHost extensions.

This issue was moved to AppMetrics/AspNetCore#8


Revisit js-yaml fork?

This seems like an ill-advised commit https://github.com/prose/js-yaml/commit/683086716c4b2c26c50767d7d964e4de5478d43d

If I remember correctly, this was done because Jekyll would read a value like lights: off as lights: false, which was causing problems... I think I remember this being a Jekyll issue where it was not handling these according to the YAML spec. Possible that's changed by now.

Background here: https://github.com/nodeca/js-yaml/pull/79
This was a temporary hack to get around Jekyll not following YAML 1.2. Not sure if this has been updated in Jekyll yet.


ENG-1592 - docs: Notification setup docs

Wow! This is seriously solid @blinktag! Great job!
@Dosplatos - yes please - reorg as you see fit!


🌱 Support CAPI ClusterResourceSet

many end users are now using operator to manage their components, it would be great for the tenant cluster enable OLM by default, then all of the tenant cluster can manage operators by default.
Hope we can leverage the cluster api to deploy some addon components like olm etc.
This is a requirement in https://github.com/kubernetes-sigs/multi-tenancy/issues/1475
@Fei-Guo ^^

Hey @gyliu513 thanks for filing this issue. Because this project is based on CAPI methodologies and interfaces we should be able to piggy back on the ClusterResourceSet type that is exposed via CAPI, this currently supports mode: "ApplyOnce" which will apply the addon/extra resources once the cluster comes up and we're able to address the control plane. This should accomplish what you are looking for once CAPN is up to date.
Links:

https://cluster-api.sigs.k8s.io/tasks/experimental-features/cluster-resource-set.html
https://github.com/kubernetes-sigs/cluster-api/blob/master/docs/proposals/20200220-cluster-resource-set.md

/kind feature

@gyliu513 so we can keep this issue open and make sure we track this I'm going to retitle this and purpose it towards testing that ClusterResourceSet's from CAPI work CAPN's design. wdyt?

/remove-kind feature

@christopherhein sounds good, thanks!

/retitle 🌱 Support CAPI ClusterResourceSet

@christopherhein Awesome! Any document that I can refer? Thanks!

@gyliu513 check out - https://github.com/kubernetes-sigs/cluster-api-provider-nested/issues/105#issuecomment-860072112 for a walkthrough, the README is still getting updated, check out https://cluster-api.sigs.k8s.io/tasks/experimental-features/cluster-resource-set.html for setting up CAPI with this deployed and the linked proposal for how it works.

/remove-lifecycle stale
/lifecycle frozen


Docker support?

Hi what an amazing paper.
Would it be possible for some one to write docker-file for this?
TIA

Unfortunately, I don't have much experience with docker and may not be able to help with this.


trace: dmesg: Add KernelLogEntry.from_dmesg_output() classmethod

Allow building a list of KernelLogEntry from a full dmesg output, in addition to
building just one entry using KernelLogEntry.from_str() .

Updated with a generator function instead of returning a list


https://raw.githubusercontent.com/MicrosoftLearning/AZ-140-Configuring-and-Operating-Microsoft-Azure-Virtual-Desktop/master/Instructions/Labs_EntraID/07_LAB_15_01_Create_custom_session_host_images_by_using_image_templates_StandAlone.md

Module: 00
Lab/Demo: 07
Task: 08
Step: 05
Description of issue
Exercise 1/Task 8/Step 5:  After making the required changes to the Subnet, there is no 'Add' option only (Save or Cancel) - presumably should change 'Add' to 'Save'.

updated
rgds
Marcin


Passing data through to loadProps

I have a use case where I need to get the request object inside of loadProps if I am on the server. Is there any way to pass down something through the AsyncProps component? How do you propose adding this?
I am doing renderProps.params.token = req.session.token above loadPropsOnServer for now.

I am doing renderProps.params.token = req.session.token above loadPropsOnServer for now.

I believe it's right way

There's definitely not a "right way" yet.
But ... mutating objects is the wrong way.
Maybe a route prop?
function createRootRoute(token, routes) {
  return <Route token={token} routes={routes} component={App}/>
}

I would have to wrap my routes in a function and pass them the request
object. would be more work to get the request object into them, but it
would feel "right". (I have them all in separate files and have the main
routes file import the child routes) But that would mean importing my
routes inside of the middleware, so that they get the request, which also
feels hacky, and pretty annoying.
I do also think mutating an object is a huge hack too... Hmm. I might be
overthinking this since I'm not at my computer though.
On Sat, Jan 16, 2016 at 18:09 Ryan Florence<EMAIL_ADDRESS>wrote:

There's definitely not a "right way" yet.
But ... mutating objects is the wrong way.
Maybe a route prop?
function createRootRoute(token, routes) {
return
}
—
Reply to this email directly or view it on GitHub
https://github.com/rackt/async-props/issues/43#issuecomment-172267753.

But that would mean importing my routes inside of the middleware

Seems fine to me, they're just descriptors of your routes.

@zackify @ryanflorence
What do you mean "mutating" ?
I thought params prop in AsyncProps exactly for such situations... May be i'm mistaken and it's only for params from routing.
I just consider params like any params that we can pass to loadProps function... routing params in particular

I need this on every route I have, it would be a lot nicer if it could be
passed down the same way params are. And by mutating I'm talking about
modifying the renderProps object.
On Sat, Jan 16, 2016 at 19:37 Rodion<EMAIL_ADDRESS>wrote:

@zackify https://github.com/zackify @ryanflorence
https://github.com/ryanflorence
What do you mean "mutating" ?
I thought params prop in AsyncProps exactly for such situations... May be
i'm mistaken and it's only for params from routing.
I just consider params like any params that we can pass to loadProps
function... routing params in particular
—
Reply to this email directly or view it on GitHub
https://github.com/rackt/async-props/issues/43#issuecomment-172279515.

@zackify got it...
yeah... we could send extra data something like:
export function loadPropsOnServer({ components, params, payload }, cb) {
and on client side just payload prop
on then invoke loadProps with this payload
Component.loadProps(params, payload, (error, props) => {

Yeah. Or params could just become an object with params as the required
key, and you could pass payload too.
On Sat, Jan 16, 2016 at 20:55 Rodion<EMAIL_ADDRESS>wrote:

@zackify https://github.com/zackify got it...
yeah... we could send extra data something like:
export function loadPropsOnServer({ components, params, payload }, cb) {
and on client side just payload prop
on then invoke loadProps with this payload
Component.loadProps(params, payload, (error, props) => {
—
Reply to this email directly or view it on GitHub
https://github.com/rackt/async-props/issues/43#issuecomment-172284205.

@zackify yeah... agree

@zackify You're taking your app state and ramming it into router state, where it doesn't belong. You need your own abstraction for dealing with app state. Pass props, put the token on context, redux, etc.
But to be clear, you're mixing app and router state in the wrong direction.

I know it is a rare use case. I haven't found a good way to get around the
issue I'm having right now.
On Sat, Jan 16, 2016 at 21:50 Ryan Florence<EMAIL_ADDRESS>wrote:

@zackify https://github.com/zackify You're taking your app state and
ramming it into router state, where it doesn't belong. You need your own
abstraction for dealing with app state. Pass props, put the token on
context, redux, etc.
But to be clear, you're mixing app and router state in the wrong direction.
—
Reply to this email directly or view it on GitHub
https://github.com/rackt/async-props/issues/43#issuecomment-172285910.

Heh, it's not rare. We've been talking about this since the router first showed up.
If we make a few changes to Async Props, you could use the Router's createElement prop and pass the token to every element when the router creates them.

Oh okay, that would be cool!
On Sat, Jan 16, 2016 at 22:01 Ryan Florence<EMAIL_ADDRESS>wrote:

Heh, it's not rare. We've been talking about this since the router first
showed up.
If we make a few changes to Async Props, you could use the Router's
createElement prop and pass the token to every element when the router
creates them.
—
Reply to this email directly or view it on GitHub
https://github.com/rackt/async-props/issues/43#issuecomment-172286214.

If you want to take a stab at it:

AsyncProps uses createElement here: https://github.com/rackt/async-props/blob/master/modules/AsyncProps.js#L208

You would need to check for props.createElement and use it somewhere in here: https://github.com/rackt/async-props/blob/master/modules/AsyncProps.js#L108-L113

Or something like that ...

If you want to take a stab at it:

AsyncProps uses createElement here: https://github.com/rackt/async-props/blob/master/modules/AsyncProps.js#L208

You would need to check for props.createElement and use it somewhere in here: https://github.com/rackt/async-props/blob/master/modules/AsyncProps.js#L108-L113

Or something like that ...

Awesome, will try my hand at this tomorrow.

Note the loadContext addition :)
loadPropsOnServer(renderProps, loadContext, cb)
// and
<AsyncProps {...renderProps} loadContext={loadContext}/>
// and finally
Component.loadProps = ({ params, loadContext }, cb) => {}

@ryanflorence haha I was just about to make a PR for this, that's exactly how I expected it to work. Thanks a lot


Can't install due to broken dependency

One of the dependencies from this boilerplate seems to use<EMAIL_ADDRESS>which had a backdoor added by an attacker (See: https://github.com/dominictarr/event-stream/issues/116 )
The boilerplate can't be installed because this version got deleted from yarn and npm.

Hello,
Sorry for me also yarn or npm can install packages .... nothing wrong ...
Thanks

error https://registry.yarnpkg.com/event-stream/-/event-stream-3.3.6.tgz: Extracting tar content of undefined failed, the file appears to be corrupt: "Unexpected end of data"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Event stream has found with malicious code source .

Looked into it and raised a  PRQ https://github.com/w3tecch/express-typescript-boilerplate/pull/137

Adding the following in package.json has fixed it for me,
"resolutions": {
"**/event-stream": "^4.0.1"
},


Json Reference Loop Problem - Possible Solution

For a long time the people talk about the reference loop problem when serializing a json, would it not be possible to implement a solution where the referenced objects of the first layer are used as search objects for the lower layers and when it encounters an equal object put a null from that point forward? I know that there are problems with performance and etc. of doing searches to solve a simple problem, is it simple or are there other problems in doing this?

@Alissonerdx I'm not sure this is the right forum for that conversation. I'm going to close this issue now.


chore(deps): update dependency @cyclonedx/cdxgen-plugins-bin to v1.6.9

This PR contains the following updates:

Package
Update
Change

@cyclonedx/cdxgen-plugins-bin
patch
1.6.7 -> 1.6.9

Release Notes

cyclonedx/cdxgen-plugins-bin (@cyclonedx/cdxgen-plugins-bin)
v1.6.9
Compare Source
osquery arm64
Full Changelog: https://github.com/CycloneDX/cdxgen-plugins-bin/compare/v1.6.8...v1.6.9
v1.6.8
Compare Source
What's Changed

Update dosai and osquery by @prabhu in https://github.com/CycloneDX/cdxgen-plugins-bin/pull/27

Full Changelog: https://github.com/CycloneDX/cdxgen-plugins-bin/compare/v1.6.7...v1.6.8

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


GetAll paging?

This library looks great and excited to look into it more.
With GetAll, is there a paging function, i.e. only returns 25 items at a time, or would that be something we would just add inside the route action?

Awesome, thanks!


Vimeo player not working with airplay

Expected behaviour

Vimeo provider should show airplay button on Safari

Actual behaviour

Vimeo provider does not show airplay button on Safari

Steps to reproduce

Enter https://plyr.io/#vimeo on Safari
Airplay button is not displaying

Environment

Browser: Safari
Version: 16.1
Operating System: MacOS
Version: 13.0.1

Console errors (if any)

this.media.webkitShowPlaybackTargetPicker is not a function. (In 'this.media.webkitShowPlaybackTargetPicker()', 'this.media.webkitShowPlaybackTargetPicker' is undefined) if you manually display the button

Link to where the bug is happening

https://plyr.io/#vimeo

Sorry, AirPlay is only supported for HTML5 video, currently. Vimeo (and YouTube) would need to add an API method for this to be possible. I'll add a note in the docs to cover this.

@sampotts we've added support for this to the Vimeo player. A {method: 'remotePlaybackPrompt'} message can be sent to the player to trigger it.
I'll have an update for the player api library shortly, and then I am happy to submit a pull request here to add support, if that is something you'd be open to merging.


[feature] Context menu actions

A few things are missing from the log filtering that I think would be a pretty big QoL feature

copy log timestamp

currently viewable, but hard to copy if you want to compare something

copy log ID

could be useful for future features

scroll to log

see the context around a log item

Didn't address the 3rd bullet point, but did address the title. We'll split this work into a separate PR.


UML cardinality indicates that at least one eligibility criterion is required for every StudyDesignPopulation and every StudyCohort

The 1..* cardinality on the criteria relationship between PopulationDefinition and EligibilityCriterion indicates that at least one eligibility criterion is required for every instance of classes that inherit the relationship from PopulationDefinition (i.e., StudyDesignPopulation and StudyCohort). Is this correct or are any of the following scenarios possible?:

The same eligibility criteria apply to all cohorts in a study population, so the criteria are only defined at the study population level.
Each cohort has a unique set of eligibility criteria, so the criteria are only defined at the cohort level.

@dih-cdisc : changed in UML and uloaded new population view to Github.
No CT changes necessary. Only corresponding changes to API, Rule (v4.0) and probably IG needed.

IG => UML update + specification that criteria should be either defined at study population level or at study cohort level.

API updated

@dih-cdisc : should it not be criterionIds instead of criteriaIds in the API?


WIP: epl-sup-tree plugin

Resolve #9. Creates epl-sup-tree plugins.

[x] application tree graph
[x] OTP applications list
[x] selecting node -> node info
[x] toggling specific OTP applications on graph
[ ] better graph rendering on route change
[ ] show loader when no data to display yet
[ ] better side panel (applications list, node info) styling

@arkgil I'm working towards merge. It's feature complete and only need styling and some polish. If you can check it out and give me some review it would be awesome.
If I'll have enough time should be merged by Friday.

I tried it and it looks great. I appreciate you are trying to stick to one palette of colours across all views.
Thank you so much!

If you have any idea how can I make it better, let me know.

Amazing!

@michalslaski @arkgil Looking for your review. How it feels and how it works for you?


[async] error: component not found for job

We are sporadically seeing the error 'component not found for job ' in the dev console when loading dashboards with Global Async turned on. The charts never loads. When searching through the network requests, we can see that the api request to async_event does in fact return the correct job and we can follow the result_url in that api response to the data of the missing chart. It does not make a call to the explore_json/data api for that chart.
Just a shot in the dark: My thoughts are possibly a race condition between loading of the ui components and the return of the api response? It seems to always be the first charts that return from async_result api (and usually in a separate request from the others that do end up loading)
Expected results
Charts to load properly
Actual results
Chart never loads, and error 'component not found for job ' warning in console.
Screenshots

How to reproduce the bug

Turn on Global Async
Create dashboard/charts
load dashboard
reload dashboard after cache
may need to refresh a couple of times and wait for a chart to continuously have the spinning loader / the error in the console show up. it is very sporadic

Environment
(please complete the following information):

superset version:  master 9fa52d3
python version: 3.8
node.js version: 12

postgres backend
redis cache storage
redis async storage
Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

FYI @robdiciuccio - I saw you were in charge of the async feature commits

@rwspielman can you test the fix in #13350 to see if that resolves your issue?


cds-upgrade-buildlog*

Hi @rlindner81,
is it possible that mtx-tool previously wrote the cds-upgrade-buildlog in all cases (error/failed)?
After running the upgrade, you will get a resulting status and a log file for each tenant. In case of an unsuccessful upgrade, consult the associated log file for details.
they're now missing for me, mtx-tool 0.7.10 + mtxs
Thanks, Andre

Hi @andre68723, that's a known issue. Unfortunately cds-mtxs does not provide the same functionality that cds-mtx did.
With cds-mtxs, this information is written to log files on the running cf instances, but it's not exposed through a rest API, so I cannot consume it easily with the mtx-tool.
It's technically still possible to get the information with the following approach:
# get tenant upgrade logs for instance 0
cf ssh <mtx-cds-app> -i 0 -c 'tar cfz - app/logs/*.log' | tar xfz - -C temp
# get tenant upgrade logs for instance 1
cf ssh <mtx-cds-app> -i 1 -c 'tar cfz - app/logs/*.log' | tar xfz - -C temp

... etc. for all instances
You need a unix shell for this, i.e., it works out-of-the-box on Mac and Linux, but might need some extra finagling on Windows.
I want to automate this approach in mtx-tool at some point, but have not had the time too look into it yet. If someone wants to work on it, PRs are welcome...


chore: release 1.6.5

:robot: I have created a release *beep* *boop*
1.6.5 (2021-12-13)
Bug Fixes

iterator cannot be looped (022ca72)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/keq-request/keq/releases/tag/v1.6.5 :sunflower:


Template for searching a list of items.

Implementation of a popup that has 2 windows.
The top one should have enough space for input to be shown, and the bottom one should have all the search results.
Fuzzy finding will be implemented through one of these repositories:

fuzzy-matcher
skim
fuse-rust

This has been implemented here.


hey 1000hz

Can't put validation on select fields of form please help as soon as possible

If you use disabled atribute in first option element
You shoud add something like that:
jQuery('form[data-toggle="validator"] select').on('change', function(event) {
    event.preventDefault();
    jQuery(this).find('option[disabled]').remove();
});

Some of Blackberry phones has problem with validation of disabled option elements.
And we need to remove this disabled element after user choice.

Hi! If i use Bootstrap-select http://silviomoreto.github.io/bootstrap-select, validation does not work.

Hi,
Any update on how to make validation work for:
Bootstrap-select http://silviomoreto.github.io/bootstrap-select,

Hi,
For triggering the validation when you are using bootstrap-select you should use something like that:
$('.select').on( 'hide.bs.select', function ( ) {
    $(this).trigger("focusout");
});


Enable analytics for the production deploys only

With the current site setup, all deploys (this includes previews), generate analytics. They shouldn't -- analytics should only be enabled for the production deploy.
Reference:

SEO, Analytics and site-local search.

Related:

#2181

/cc @nate-double-u @caniszczyk

The snippet code added in the context of the following issue, has contributed to supporting the fix of this issue in the context of GA4:

#2181


renamed server setting .specs => .resources for consistency with frontend

In your notebook server settings, the jupyterfs.resources key will now take the same json dict of filesystem resource specifications as the resources key in the jupyter-fs frontend settings

Also, it looks like Azure fixed (https://github.com/actions/virtual-environments/issues/1335) the DNS shit on its OSX hosts (after they rebroke it after fixing it last time). Now all of the CI tests are magically working again! Yaaaay

@timkpaine I still need to do a little bit of testing on this, so don't pull it in right away

Did some testing. As of the latest commit to this PR, the server side settings work, but there seem to be issues with merging the fronted/server extension settings. So that needs fixing before we pull this PR in

Fixed the issue with merging resources specified on the server-side and resources specified in the frontend options. At least for the basic case.
I think there may still be some issues when auth is enabled, so still need to do some more testing. Specifically, I need to make sure everything works as expected with all of the combinations of auth/no auth on server-side and/or frontend specified resources

added a couple more commits to fix some issues with having both server and frontend side config together, and fixed an issue with the jupyter-fs icon in the jlab settings panel.
Also added a simple changelog


Timing Rust examples in release mode

Currently the Rust bench marks are taken in debug mode, ie:
cargo run -- 1000

Running in release mode will optimize the program to be faster and give a better idea of the numbers people would see in a released program.
cargo run -r -- 1000

I'd done this for the mock_data generation piece, but forgot to do it for this one. Will make the updates to the docs too and close this once it's done 👍🏽

Will be fixed by #17


Update trimming step in bpipe_dna.stages

Use cutadapt instead of sed to perform trimming (big improvement in terms of speed).

Hi Deyan,
that looks way more readable, thanks! I would actually rename stages though at this point, since cutadapt is then no longer only used in the "cutadapt" stage. Maybe something along the lines of
trim -> cutadaptFlanking
cutadapt -> cutadaptAdapter  ?

Finally got around to this, thanks Deyan! It really is way faster too!


Fixed collection of tags (',' vs. ', ')

Fixed the collection of grabbing tags from the config file. When more than a single tag was defined, it was not possible to separate them by a "," or ", " as the creator was splitting them differently and therefore I got sanitizing errors.
I harmonized the extraction and also trimmed the outcome. Now it's possible to either use "," or ", " as a separator.

@Horizon0156 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

Contributor License Agreement
Contribution License Agreement
This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@microsoft-github-policy-service agree

Hello @Horizon0156, thank you for the PR!
will it be possible to add minimal unit tests for this case, in order to verify that existing config files will work as expected?
Best regards

Hello @Horizon0156, thank you for the PR! will it be possible to add minimal unit tests for this case, in order to verify that existing config files will work as expected? Best regards

Sure, here we go. I added theories to test both variants. API Tags without a whitespace after the separator (tag1,tag2,api-tag1) and those with a whitespace (tag1, tag2, api-tag1)
In addition, I slightly modified the generation of your test data to simulate a real string input like it would be parsed from the yaml file. All tests are passing now.

Hello @Horizon0156, thank you for the PR! will it be possible to add minimal unit tests for this case, in order to verify that existing config files will work as expected? Best regards

Sure, here we go. I added theories to test both variants. API Tags without a whitespace after the separator (tag1,tag2,api-tag1) and those with a whitespace (tag1, tag2, api-tag1)
In addition, I slightly modified the generation of your test data to simulate a real string input like it would be parsed from the yaml file. All tests are passing now.

Thank you for tests and improvements, one comment was left: regarding moving tagNames generation in tests to use the same approach as apiTagNames.

Thank you for contribution!


Update README.md

Added a link to our lecture and tutorials about the scientific and software background of this data generator.

I proposed some changes (typos) and would not put it under the topic usage.
If you agree pleas merge

Thank you for your corrections.


Support download from maven central mirror

Support download from maven central mirror
From https://github.com/os72/protoc-jar-maven-plugin/issues/61
Part of issue #55

@os72 for now, could the url used to download protoc be updated to use https://repo.maven.apache.org/maven2/
I have made the change locally and Protoc still seems to work as expected.

Ack, yes

@os72, could this change be included in 3.7.0 release? Many thanks!

https://maven.apache.org/guides/mini/guide-mirror-settings.html

See also https://github.com/os72/protoc-jar-maven-plugin/issues/68

Released <IP_ADDRESS>


Designer is missing verticalContentAlignment property on top-level AdaptiveCard

The "verticalContentAlignment" property is supported on the top-level AdaptiveCard element, yet in the Designer, the Designer doesn't expose that property.

This is somewhat related to #2366... until #2366 is fixed, applying the verticalContentAlignment property in the designer won't result in any visual difference. But it's part of the schema, so the property should be assignable.

Fixed: https://github.com/Microsoft/AdaptiveCards/commit/2cb96cd07553279ac0b2648c4b65188399b0af3c

Fixed in master: https://github.com/Microsoft/AdaptiveCards/pull/2369


support Dockerfile ARG & --build-arg =

** FEATURE REQUEST?**: yes
support of Dockerfile ARG injection into the build
https://docs.docker.com/engine/reference/builder/#arg
What do you expect
a list of Name/values we can inject into the build so DockerFile can use them to set
environment values. we like to use this to insert build information like git tags/sha1/buildhost/buildtime etc. this allows fast tracing what/which software build is running using plain environment variables
mostly used in CI pipelines where docker images have :latest tag until some more integration testing has been done , and final version tags are assigned to the released "latest" image.
at that point , the environment includes all build details for reference.
 Also I'm using ARG before and after the FROM.
Take a look in the example at Readme.  https://github.com/spotify/dockerfile-maven#example


Moonraker Update Manager

running a voron install with spoolman. I was wondering if it was possible to manage updates for spoolman via klipper (maybe moonraker)?

Maybe we can copy and past the update commands into a script and use that script in moonraker.conf ?
Will try it tomorow 🙂

Maybe we can copy and past the update commands into a script and use that script in moonraker.conf ? Will try it tomorow 🙂

Have you had any success with it?
I guess we need the following in moonraker?
(Assuming it is cloned as a git repo)
[update_manager Spoolman]
type: git_repo
path: ~/Spoolman
origin: https://github.com/Donkie/Spoolman.git
managed_services: Spoolman
install_script: scripts/install_debian.sh

Warning! I haven't tested this!

It's unfortunately not that simple, since you also need to built the web client frontend. Just cloning the git repo isn't sufficient.
I will look into how this could be done properly

Maybe we can copy and past the update commands into a script and use that script in moonraker.conf ? Will try it tomorow 🙂

Have you had any success with it?
I guess we need the following in moonraker?
(Assuming it is cloned as a git repo)
[update_manager Spoolman]
type: git_repo
path: ~/Spoolman
origin: https://github.com/Donkie/Spoolman.git
managed_services: Spoolman
install_script: scripts/install_debian.sh

Warning! I haven't tested this!

Hi,
Sorry I had a problem with the laptop running klippy I had to change it,as all components are soldered on mainboard which doesn't power up anymore I had to reinstall everything (no backup 😁)

It's unfortunately not that simple, since you also need to built the web client frontend. Just cloning the git repo isn't sufficient.
I will look into how this could be done properly
Edit: I saw now you try to run the install shell script. However the install_script field doesn't work like that in Moonraker unfortunately, so it will not work anyway.

The install script isn't fully unattented and installs everything instead of updating, that's why it will not work, is that right ?
To update directly from moonraker we need to update the git repo and rebuild the client front-end. Does it need to be done with pdm ?

No, the install_script line isn't executing any shell code at all if I understand correctly.
Neverless, I have pushed some commits to automate building the client and packaging it in a way so that Moonraker would be able to update it using the "web" type. So this will come soon :)

No, the install_script line isn't executing any shell code at all if I understand correctly.
Neverless, I have pushed some commits to automate building the client and packaging it in a way so that Moonraker would be able to update it using the "web" type. So this will come soon :)

Thanks 😉
I will try as soon as it comes, let us know 😊

This is now added in the latest update :)
Add this to your Moonraker.conf (update path accordingly):
[update_manager spoolman]
type: web
channel: stable
repo: Donkie/Spoolman
path: ~/Spoolman

So the Spoolman update works in the Mainsail Update Manager?


docs/guide/input-multiple-models: added a note on avoiding validating…

… the same input data with the same rules more than once

Q
A

Is bugfix?
yes/no

New feature?
yes/no

Breaks BC?
yes/no

Tests pass?
yes/no

Fixed issues
comma-separated list of tickets # fixed by the PR, if any

Merged. Thanks!


cmake: Set PYTHON_EXECUTABLE env var with kconfig

In order to be able to invoke Python from Kconfig files,
set the path to the Python executable (which can be python,
python3, py -3, etc) as an environment variable so that
Kconfig shell invocations can use it like:
config MY_OPTION
string "My option string"
default "$(shell,$(PYTHON_EXECUTABLE)
$(ZEPHYR_BASE)\scripts\script.py)"
Signed-off-by: Carles Cufi<EMAIL_ADDRESS>

Codecov Report

Merging #11437 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11437   +/-   ##
=======================================
  Coverage   48.37%   48.37%
=======================================
  Files         265      265
  Lines       42192    42192
  Branches    10137    10137
=======================================
  Hits        20412    20412
  Misses      17703    17703
  Partials     4077     4077

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39551cf...14fbc5b. Read the comment docs.


Superset 3.0 - Example charts throw SQLite Error - no such table: main.FCC 2018 Survey

I have deployed Apache Superset 3.0 using Helm charts. The Helm chart version is superset-0.10.11, and the app version is 3.0.1. I've configured Superset to load example data (loadExamples set to true), but I'm encountering an issue on the dashboard with the error message 'no such table: main.FCC 2018 Survey' while opening one of the example charts.
Below is the stack strace from app pods.
2023-11-01 14:46:36,834:WARNING:superset.connectors.sqla.models:Query SELECT country_live AS country_live
FROM main."FCC 2018 Survey"
GROUP BY country_live
LIMIT 1000
OFFSET 0 on schema main failed
Traceback (most recent call last):
  File "/app/superset/connectors/sqla/models.py", line 1214, in query
    df = self.database.get_df(sql, self.schema, mutator=assign_column_label)
  File "/app/superset/models/core.py", line 611, in get_df
    self.db_engine_spec.execute(cursor, sqls[-1])
  File "/app/superset/db_engine_specs/base.py", line 1535, in execute
    raise cls.get_dbapi_mapped_exception(ex) from ex
  File "/app/superset/db_engine_specs/base.py", line 1533, in execute
    cursor.execute(query)
sqlite3.OperationalError: no such table: main.FCC 2018 Survey

How to reproduce the bug

Install Apache Superset Helm chart with version 0.10.11 and set loadExamples to true
Login to Superset to app and open FCC New Coder Survey 2018 chart

Expected results

It should load chart data

Actual results

It throws error - no such table: main.FCC 2018 Survey

I also hit this issue on latest chart 0.10.14.
If you go to Settings / Database connections and do Test connection on examples database you will see an SQLite-related error saying it's not a secure source.
Per #17551 I added the following into my values.yaml:
configOverrides:
  allow_sqlite_for_examples: |
    PREVENT_UNSAFE_DB_CONNECTIONS = False

This made connection test pass, however I was still getting no such table errors.
When I exec into superset pod I see that superset_home/examples.db file has size of zero. I suspect that superset-init-db pod that according to logs seems to be setting up all the example tables is not writing to the same file superset pod is reading from...

I think this is some regression in helm setup.
The superset load_examples command that populates examples.db is executed in superset_init.sh script which is only run by init job. Init job spawns superset-init-db which creates examples.db but only in its own file system, so the file dies with it as pod exits.
Workaround: Manually exec into superset pod and run superset load_examples inside it to populate examples.db.
I think the proper solution here is not to use SQLite in k8s setup at all and populate examples into Postgres (by reusing existing DB or creating a new one), but this is a bit beyond what I feel comfortable contributing.

I could replicate this issue with version 3.0.1 and on master using Docker. The Docker stack uses Postgres as meta database, so I don't think the issue relates to the Helm chart or SQLite.
Steps to reproduce:

git clone and checkout master / 3.0.1
TAG=3.0.1 docker-compose -f docker-compose-non-dev.yml up
navigate to Datasets / FCC 2018 Survey
get the error:

Error: column "rsrc_pluralsight" does not exist
LINE 122:        rsrc_pluralsight AS rsrc_pluralsight,
                 ^
HINT:  Perhaps you meant to reference the column "FCC 2018 Survey.rsrc_pluralsght".

pinging to get some eyes on the issue @rusackas, @sfirke, @john-bodley

@sebastianliebscher I think there's a typo from your full-text search, i.e., you're missing an i from sight:
$ git checkout 3.0
Switched to branch '3.0'
Your branch is up to date with 'apache/3.0'.
$ git grep rsrc_pluralsight
superset/examples/configs/datasets/examples/FCC_2018_Survey.yaml:- column_name: rsrc_pluralsight

@craig-rueda do you have any insights with regards to the Helm charts issue?

@john-bodley I intentionally full-text searched for rsrc_pluralsght (without the i) because that's what an unchanged/unconfigured Superset 3.0.1 / master errors out when navigating to the FCC 2018 Survey dataset. I literally just git cloned and docker composed up Superset and got this error message with the typo.

https://github.com/apache/superset/pull/26380

@michael-s-molina  I am still facing the the same issue. I have installed Superset 3.1.0 using helm chart superset-0.12.0. I am getting no such table error for all the charts. I went inside the superset pod to see examples.db file but it's not there. After running superset load_examples within pod I can see examples.db file and charts are getting loaded. Did we miss something while fixing this issue?

@iamrohit07 I think there ended up being two problems discussed in this issue.  I don't think anything has been done to address the missing examples database.  It seems that issue was introduced with this PR: https://github.com/apache/superset/pull/25003.
I've been trying to configure the examples to load into the main database but it looks like the example loading code has some dependencies on specific schema names.  Hopefully someone with more knowledge of the code can help figure out how to get examples loaded into a database that isn't local to a container so they will work in environments like Kubernetes.

Hi @iamrohit07. As @tsndqst correctly pointed out, this seems like a different issue than the original one no such table: main.FCC 2018 Survey which was fixed by https://github.com/apache/superset/pull/26380. Please open a new issue and tag @dpgaspar which was the author of https://github.com/apache/superset/pull/25003.

Hi @iamrohit07. As @tsndqst correctly pointed out, this seems like a different issue than the original one no such table: main.FCC 2018 Survey which was fixed by #26380. Please open a new issue and tag @dpgaspar which was the author of #25003.

I think this issue correctly summarizes the symptoms of the issue.  #26380 may have fixed an existing issue but I think this issue is still valid.  In other words, if @iamrohit07 makes a new issue it will probably have the same summary as this one.

We're trying to get to a sustainable Issues backlog, and it's extremely helpful when Issues cover one reproducible bug, which would preferably be fixed by one PR. When issues contain two bugs and multiple PRs, it gets confusing, long discussion threads ensue, and tend not to get closed (we're currently tidying up antique issues and are seeing a lot of this).

Re-opening the issue...

@dpgaspar Could you please take a look at this. I am not able to access any of the charts and getting no such table error.

I am getting precisely the same error with the most current Superset chart. I enabled loadExamples but all the Dashboards and Charts return no such table errors

@dpgaspar Could you please take a look at this. I am not able to access any of the charts and getting no such table error. When I exec into superset pod, I can see that superset_home/examples.db file has zero size. When I run superset load_examples within pod, examples.db file gets recreated and then I am able to access all the charts.

This helped me. I cleaned superset: removed docker images, volumes and after running docker-compose up with fresh 3.1.1 version I logged into container using command docker exec -it superset_app /bin/bash and invoked command superset load_examples.
This recreated examples db.

@dpgaspar Could you please take a look at this. I am not able to access any of the charts and getting no such table error. When I exec into superset pod, I can see that superset_home/examples.db file has zero size. When I run superset load_examples within pod, examples.db file gets recreated and then I am able to access all the charts.

In my case the problem was with volumes. Both superset-app and superset-init have to have access to the same volume:
`

superset_home:/app/superset_home
`
If not superset init populates examples db in separate space not under superset_app.

I have the same problem "Error: no such table" since January. Currently, I am deploying version 3.1.1 and it's the same behavior: init-db job runs fine, and if I test the connection to DB is fine. It seems that init-db loads all the examples in the postgresql instance, while the superset pod is loading from a local sqlite (which cannot find, because none created it). So, yes, if I run superset load_examples, the local .db is created and superset can visualize the examples.
Can you verify that this is how it works? Is it normal to function this way?

IMHo both pod's should use same volume and same superset_config.py and what is value for SQLALCHEMY_EXAMPLES_URI - if its commented out then pod would use sqllite by default:
`

SQLALCHEMY_EXAMPLES_URI = (
f"{DATABASE_DIALECT}://"
f"{EXAMPLES_USER}:{EXAMPLES_PASSWORD}@"
f"{EXAMPLES_HOST}:{EXAMPLES_PORT}/{EXAMPLES_DB}"
)

`

AFAIK the default examples uri should be set to the postgres included in the chart. The examples should be loading via the init pod, which could possibly be failing to run to completion. Check the logs there to see if there's a failure

AFAIK the default examples uri should be set to the postgres included in the chart. The examples should be loading via the init pod, which could possibly be failing to run to completion. Check the logs there to see if there's a failure

I guess you are referring to me.
No init pod is failing.
However, I would like to try whatever your are proposing, but can you be more specific?
What is the exact variable I need to define? default examples uri should be set to the postgres included in the chart
AFAIK I changed nothing related to the postgres that comes by default and superset is able to connect to it.


cri: selinux relabel /dev/shm

Address an issue originally seen in the k3s 1.3 and 1.4 forks of containerd/cri, https://github.com/rancher/k3s/issues/2240
Even with updated container-selinux policy, container-local /dev/shm
will get mounted with container_runtime_tmpfs_t because it is a tmpfs
created by the runtime and not the container (thus, container_runtime_t
transition rules apply). The relabel mitigates such, allowing envoy
proxy to work correctly (and other programs that wish to write to their
/dev/shm) under selinux.
Tested locally with:

SELINUX=Enforcing vagrant up --provision-with=shell,selinux,test-integration
SELINUX=Enforcing CRITEST_ARGS=--ginkgo.skip='HostIpc is true' vagrant up --provision-with=shell,selinux,test-cri
SELINUX=Permissive CRITEST_ARGS=--ginkgo.focus='HostIpc is true' vagrant up --provision-with=shell,selinux,test-cri

Signed-off-by: Jacob Blain Christen<EMAIL_ADDRESS>

LGTM

/ok-to-test

Should we also reliable resolvconf and the other shared files?

Should we also reliable resolvconf and the other shared files?

@crosbymichael good question. I have no reports of folks needing to write to /etc/resolv.conf and /etc/hosts in-container in k3s or rke2. Is there a common-ish use-case for such that I am not aware of? If not, I am content to leave it alone until someone needs it.

ok, i think its fine as these are not in /run

@crosbymichael it looks like the containerd/cri unit tests caught something that I missed: https://github.com/containerd/cri/pull/1605/files#diff-17a83af23eb8f578286e12d2b7537efb119bbb6a046235b59fc10b3f0ac04fa5


Add Writable support for INDArrays

Issue Description
Priority: low
Feature request: add "Writable" support for INDArray (ND4J) arrays so that transforms can output INDArrays and they can be consumed by downstream DataVec processes, serialized, etc.
Example usage: BOW-style transforms of text fields, as per https://github.com/deeplearning4j/DataVec/pull/271. Right now, we do such transforms by converting a text field to a list of (integer) writables, as in StringListToCategoricalSetTransform.
As discussed with @AlexDBlack, it would probably be more efficient to do BOW as a single INDArray, rather than a .List`.
Version Information
All versions of DataVec.
Contributing
Not an immediate blocker for me on field work, so likely won't get to it soon.

Superseded by https://github.com/deeplearning4j/DataVec/issues/289 (we have NDArrayWritable but need to add support for it in Schema and TransformProcess)


Layout/EmptyComment auto-correct incorrectly removes entire line

Expected behavior
Given the contrived example file example.rb:
def a_method #
  true
end

Rspec.describe Class do
  it 'will to a test' do #
    expect(true).to eq true
  end
end

When running rubocop example.rb --only Layout/EmptyComment --auto-correct
I expect two warnings for the two empty comments, and for them to be removed from the end of the two lines.
Actual behavior
The lines with the empty comments are completely removed from the source:
  true
end

Rspec.describe Class do
    expect(true).to eq true
  end
end

And the output of the Rubocop execution:
$ rubocop example.rb --only Layout/EmptyComment --auto-correct
Inspecting 1 file
E

Offenses:

example.rb:1:14: C: [Corrected] Layout/EmptyComment: Source code comment is empty.
def a_method #
             ^
example.rb:2:1: E: Lint/Syntax: unexpected token kEND
(Using Ruby 2.5 parser; configure using TargetRubyVersion parameter, under AllCops)
end
^^^
example.rb:6:26: C: [Corrected] Layout/EmptyComment: Source code comment is empty.
  it 'will to a test' do #
                         ^
example.rb:7:1: E: Lint/Syntax: unexpected token kEND
(Using Ruby 2.5 parser; configure using TargetRubyVersion parameter, under AllCops)
end
^^^

1 file inspected, 4 offenses detected, 2 offenses corrected

RuboCop version
$ rubocop -V
0.53.0 (using Parser <IP_ADDRESS>, running on ruby 2.3.5 x86_64-darwin15)

It looks like this cop isn't accounting for empty comments next to code at all. The auto-correction is assuming that the line is going to be blank which is what is causing the issue.


fix a misguide in Readme.md

I use the guild in the Readme, and failed the build
repository {
    jcenter()
}

it actually should be
repositories {
    jcenter()
}
``

Good catch!


Add support for Chrome on iOS user agent

@davidism this fixes https://github.com/pallets/werkzeug/issues/1334.
I couldn't find any tests covering the user agent parser, but happy to add tests if necessary.
>>> from werkzeug import UserAgent
>>> user_agent = UserAgent('Mozilla/5.0 (iPhone; CPU iPhone OS 10_3 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko) CriOS/56.0.2924.75 Mobile/14E5239e Safari/602.1')
>>> print(user_agent.browser)
chrome

LGTM


CT doesn't build if OpenSSL is built with krb5 support

If OpenSSL is not built with OPENSSL_NO_KRB5 including openssl/ssl.h eventually includes krb5/krb5.h. This defines integer constants TRUE and FALSE as macros.
These then prevent various .cc files compiling because they conflict with our enum definition of Status, which also tries to declare TRUE and FALSE.
This affects Fedora 22 using the system OpenSSL.

Those are enums that aren't util::Status, as I recall? I keep meaning to replace them with util::Status (possibly with the help of StatusOr<>, in many cases)...

Yes, the Cert class has a different status enum. Making it a c++11 enum might also fix this but a lot of unqualified references would need fixing up.

Hmmmm. That won't work though will it? The macros will still substitute numeric values and it won't compile.

No, the macros are mean, and will reach through the nice enum class syntax... :cry:
There's also things like this:
https://github.com/google/certificate-transparency/blob/master/cpp/util/json_wrapper.h#L7

I've looked at this more and getting rid of Cert::Status will improve readability quite a bit. e.g there are places that test for error by doing if (x != Cert::FALSE && x != Cert::TRUE). Using StatusOr will also remove some result pointer args.
It will also improve portability so I think I'll probably work on this.

I've reviewed deleting Cert::Status and I think it's too big a change to do in one step, both in terms of review size and the chance of introducing subtle bugs because of the required logic changes. I think it should be done in stages.
Files affected:
cpp/client/async_log_client.cc
cpp/client/ct.cc
cpp/client/ssl_client.cc
cpp/log/cert.cc
cpp/log/cert.h
cpp/log/cert_checker.cc
cpp/log/cert_checker.h
cpp/log/cert_checker_test.cc
cpp/log/cert_submission_handler.cc
cpp/log/cert_test.cc
cpp/log/ct_extensions.cc
cpp/log/ct_extensions_test.cc
cpp/log/frontend_test.cc
cpp/server/handler.cc

I wholeheartedly embrace having many, many, many small changes that I can review easily. :smiley:

Now that Cert::Status has been removed the build process gets a bit farther. However Fedora is using GFlags 2.1, which appears to have changed namespace to gflags by default, though it is configurable via cmake.

Yay. That was the last hurdle. I now have it building on Fedora 22 and all the tests pass.


Add filters to update system

See https://github.com/terrapkg/packages/issues/59

Fix by fe4b5fe (Can filter with sth like anda update -l nightly=1 labels)


runBeforeMainModule is an empty array

Do you want to request a feature or report a bug?
report a bug
What is the current behavior?
runBeforeMainModule is an empty array. I noticed that runBeforeMainModule config was removed from metro-bundler in this commit Make the runBeforeMainModule config param to RN repo and make it absolute. runBeforeMainModule is passed into Server instance in react-native local-cli.
const options = {
      assetExts: defaultAssetExts.concat(assetExts),
      assetRegistryPath: ASSET_REGISTRY_PATH,
      blacklistRE: config.getBlacklistRE(),
      extraNodeModules: config.extraNodeModules,
      getPolyfills: config.getPolyfills,
      getTransformOptions: config.getTransformOptions,
      globalTransformCache: null,
      hasteImpl: config.hasteImpl,
      maxWorkers: args.maxWorkers,
      platforms: defaultPlatforms.concat(platforms),
      postMinifyProcess: config.postMinifyProcess,
      postProcessModules: config.postProcessModules,
      postProcessBundleSourcemap: config.postProcessBundleSourcemap,
      projectRoots: config.getProjectRoots(),
      providesModuleNodeModules: providesModuleNodeModules,
      resetCache: args.resetCache,
      reporter: new TerminalReporter(terminal),
      runBeforeMainModule: config.runBeforeMainModule,
      sourceExts: defaultSourceExts.concat(sourceExts),
      transformCache: TransformCaching.useTempDir(),
      transformModulePath: transformModulePath,
      useDeltaBundler: false,
      watch: false,
      workerPath: config.getWorkerPath && config.getWorkerPath(),
};

packagerInstance = new Server(options);

However, runBeforeMainModule is not passed into bundle options.
In shared/output/bundle.js module, runBeforeMainModule is not included when packagerClient.buildBundle is called.
// shared/output/bundle.js
function buildBundle(packagerClient: Server, requestOptions: RequestOptions) {
  return packagerClient.buildBundle({
    ...Server.DEFAULT_BUNDLE_OPTIONS,
    ...requestOptions,
    isolateModuleIDs: true,
  });
}

In Server/index module, runBeforeMainModule is also not included when  this._bundler.bundle(options) is called.
async buildBundle(options: BundleOptions): Promise<Bundle> {
    const bundle = await this._bundler.bundle(options);
    const modules = bundle.getModules();
    const nonVirtual = modules.filter(m => !m.virtual);
    bundleDeps.set(bundle, {
      files: new Map(
        nonVirtual.map(({sourcePath, meta}) => [
          sourcePath,
          meta != null ? meta.dependencies : [],
        ]),
      ),
      idToIndex: new Map(modules.map(({id}, i) => [id, i])),
      dependencyPairs: new Map(
        nonVirtual
          .filter(({meta}) => meta && meta.dependencyPairs)
          .map(m => [m.sourcePath, m.meta.dependencyPairs]),
      ),
      outdated: new Set(),
    });
    return bundle;
  }

If the current behavior is a bug, please provide the steps to reproduce and a minimal repository on GitHub that we can yarn install and yarn test.
What is the expected behavior?
Shouldn't this._opts.runBeforeMainModule merged into options when this._bundler.bundle(options) is called in buildBundle function of Server module？
Please provide your exact metro-bundler configuration and mention your metro-bundler, node, yarn/npm version and operating system.

Thanks for reporting!
The commit that you pointed is in fact causing this issue. I'm going to add a fix for it.
In the meantime, as a workaround, can you try to add a require('InitializeCore'); call at the beginning of your bundle entry point?

@rafeca Tried to work around the issue but could not figure it out.
What do you mean by bundle entry point exactly?

Shortly after posting I saw "react-native run-ios --device" runs:
node /.../node_modules/react-native/local-cli/cli.js bundle --entry-file index.js --platform ios --dev true --reset-cache --bundle-output /.../ios/build/Build/Products/.../main.jsbundle --assets-dest /.../ios/build/...

So bundle entry point is index.js, sorry for that noise.
Adding require('InitializeCore'); did not work around this issue even though I did see a change in the generated main.jsbundle file.

Adding require('InitializeCore'); did not work around this issue even though I did see a change in the generated main.jsbundle file.

Did you add it before any other require in that file? What error message are you getting?

Yes, added it before any other require in the file.
Error message I am getting is:
"ReferenceError: Can't find variable: process"

require('InitializeCore') doesn't appear to work

oh, just realized that if you're using import syntax, you'll need to also import InitializeCore (import Foo from 'InitializeCore';), since imports are hoisted before the require statements. Is this the case?

That was the case. That resolved it! Thanks so much!


Validate geowave <-> geotools naming restrictions

In the ingest framework the namespace should be validated, and useful error messages returned if it isn't a valid table name (well, table name prefix) in accumulo.  Common errors involve using characters like "-"

i.e. validate ingest framework / also in the geoserver plugin (namespace validation)

The layer name restrictions are inherited mostly from OGC service restrictions - and mostly from WFS (and the XML representations).   The most restrictive / lowest common denominator (so probably what we want to limit against) is the NCName ( http://www.w3.org/TR/xmlschema-2/#NCName ) requirement - something like this: http://xerces.apache.org/xerces2-j/javadocs/xerces2/org/apache/xerces/util/XMLChar.html#isValidNCName(java.lang.String) might be the easiest (and I think we already have a Xerces dependency)


How to open tooltip?

I created constant
public static final String CRON = "0 15 10 ? * MON-FRI";

But desired tooltip did not opened.
What keys to press on my Mac OS?
Thanks

you have to hover over the expression with the mouse, then the tooltip will apear

Does it support yml files?
cleanupOldRecords: '0 0 3 * * SAT' # every Saturday at 3 am
Not opening on hover -IntelliJ IDEA 2020.2 (Ultimate Edition) Build #IU-202.6397.94, built on July 27, 2020


Add flag to skip TLS checks against the Kubernetes API server's certi…

Sometimes working with Kubernetes we want to skip TLS verification.
Helm allows us to do it providing the flag --kube-insecure-skip-tls-verify.
I've added a boolean configuration property kubeInsecure which helps to skip TLS certificate checks for Helm operations such as upgrade, install and so on.
This small improvement simplifies the usage of the plugin in a CICD environment.

THx for the contribution. I'll release 6.10 maybe next week.

Released with 6.10.0.


sysprof: 3.30.2 -> 3.32.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/sysprof/versions.
meta.description for sysprof is: '"System-wide profiler for Linux"'.

Checks done (click to expand)

built on NixOS
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 3.32.0 with grep in /nix/store/bn5alg92f2m37ygaank0midp6smxcysw-sysprof-3.32.0
directory tree listing: https://gist.github.com/33dd62531f29727592e339435eb59083
du listing: https://gist.github.com/ae63419b1f884737b830595e83fbb94c

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)
2 package rebuild(s)
2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
gnome-builder
sysprof

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/bn5alg92f2m37ygaank0midp6smxcysw-sysprof-3.32.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A sysprof https://github.com/r-ryantm/nixpkgs/archive/b8ec4aa331995f55e9e69a90e6203607fb2e8ed5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bn5alg92f2m37ygaank0midp6smxcysw-sysprof-3.32.0
ls -la /nix/store/bn5alg92f2m37ygaank0midp6smxcysw-sysprof-3.32.0/bin

cc @lethalman @jtojnar @hedning @worldofpeace for testing.

part of #57027


OS Class Bugs on Linux

Godot version:
3.2.3 stable
OS/device including version:
KaOS (Arch Linux)
Issue description:
Using shell open produces error telling the user the path to the project doesnt exits:
OS.shell_open("<godot_executable_path> -d --path <project_folder_path>")

Using Shell execute ignore passed arguments
OS.execute(OS.get_executable_path(),PoolStringArray(["-d","-w","--resolution 720x480"]),false)

placing OS.get_cmd_args() after the OS.execute, produces [--args]
Steps to reproduce:
Mentioned above.
Minimal reproduction project:
N/A

Steps to reproduce:
Mentioned above.
Minimal reproduction project:
N/A

I can't reproduce the issue so I'd say a minimal project is not "not applicable".
In particular, OS.execute(OS.get_executable_path(),PoolStringArray(["-d","-w","--resolution 720x480"]),false) works fine and will chain load the current project (so have terminal handy to killall godot :)).

ps: try to reproduce as a plugin (tool mode)

Or provide a project that demonstrates what the issue is exactly, as asked by the template...

done


loadBalancer server cache status time properties not correct

Bug report

With the first time serverList update, server stats information accessTime and connectionTime is not update properly.

There might be an issue with time settings on your machine. Try running System.currentTimeMillis() and see what you get; if your time settings are fine, please report an issue directly to https://github.com/Netflix/ribbon as this area belongs to the core library implementation and not Spring Cloud integration.


Writing NaN differs from nodejs Buffer

Hello,
I was recently attempting to swap out nodejs' Buffer with this one on a fork of another project, so I could use it in a non-node environment, when I noticed an inconsistency between nodejs' Buffer and this library when dealing with NaN
Here's a sample (using most recent npm install of 'buffer'):
const AltBuffer = require('buffer/').Buffer;

const alt_buf = new AltBuffer(8);
const node_buf = new Buffer(8);

alt_buf.writeDoubleLE(NaN, 0);
node_buf.writeDoubleLE(NaN, 0);

in node 6.x, 8.x, and 9.x, the resulting buffer objects are different
Node's (native) Buffer:
00 00 00 00 00 00 f8 7f
buffer library's Buffer:
01 00 00 00 00 00 f0 7f - bytes 0 and 6 are different
That's probably not supposed to happen, right?

Don't use new Buffer(8).
Use Buffer.alloc(8).
The results are different because you are accessing uninitialized memory.

To test this properly, use alloc() to get zeroed out memory. But this does indeed look like a bug.
var B = require('buffer/').Buffer
var assert = require('assert')

var b1 = B.alloc(8)
b1.writeDoubleLE(NaN, 0)

var b2 = Buffer.alloc(8)
b2.writeDoubleLE(NaN, 0)

assert.deepEqual(b1, b2)

Spent some time digging down, and it leads to the ieee754. Created a PR trying to fix the bug, feel free to put down any comment.

@geastwood Thank you for digging into this and finding the root cause. I left a comment on your PR.


bump versions

as noted in https://github.com/aheckmann/gridfs-stream/issues/74 this library remains functional, but loading an old version of gridfs-stream with mongodb@2 breaks stuff

closing in favor of #4


libnftnl: fix version script with lld 17+

Description of changes
Fixes an issue discovered via the Nixpkgs LLVM Workspace project.
https://github.com/RossComputerGuy/nixpkgs-llvm-ws/runs/26297692474
Can be tested by building pkgsLLVM.libnftnl.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Love to see it, a lot of PR's are like this one with pkgsLLVM. Pretty much the no. 1 most common issue.

Love to see it, a lot of PR's are like this one with pkgsLLVM. Pretty much the no. 1 most common issue.

patching the linker to change behavior seems almost preferable to having to litter the code and waste time fixing all of these


Failed to legalize operation onnx.Expand

In Shark e2e model, we are seeing issue as
Failed to legalize operation onnx.Expand. Will add more detail

@kumardeepakamd worked on supporting it (https://github.com/llvm/torch-mlir/commit/29569713f3878226a6c1054a183dc227934dbe69)

This is being blocked because onnx's shape inference cannot seem to propagate constant data through identity ops.

@zjgarvey We have, through the onnxruntime EP, the following models passing numerics (thus passing the whole e2e pipeline):

gcvit_base
gcvit_small
gcvit_tiny
gcvit_xtiny
gcvit_xxtiny

All the others fail due to numerical mismatches, but none of them fails at legalization of the Expand op.

I have a fix for this in the test suite. Working on getting it up today. See also #825

closing this issue as we don't see this anymore. if we come across any other issues like this, we open new issue


Can't set pan/balance of an SQ5 Matrix 3 output

The "Pan/Bal level to output" action on an SQ-5 has matrixes 1/2, but it's missing 3.  This seems to be because the choices list populated for that action cuts off the "all faders" list at 19, when it should be 20.
From what I can tell, tho, the list is also overinclusive as well as underinclusive.  The SQ MIDI Protocol document v3 does say you can control pan/balance of FX sends output in the table -- but by v5 those entries are gone (and it isn't especially clear this would even make sense).  So that entire choices list needs some rejiggering.

Matrix 3 was added to the choices, and FX sends were removed from choices, in 809f86b28353c7a35daa0d77ed57460c8d9f7cbb.
No estimate yet on when this will be in a release.  My local tree is down to about a thousand lines of relatively-spaghetti code needing cleanup still, as I've massaged more and more of the existing code into a sane state.  Unfortunately these last bunches of lines are some of the most difficult to understand, so they'll be nearly hardest to get through.

@jswalden I did some work on this module last year for someone and man. I’d love to get into the mind of the original author.

@josephdadams You and me both.
In fairness, this module was copied from yet another one, and that one hasn't really been touched in approximately years, so it goes a long ways back.  And I gather from the state of it that pre-Companion v3 modules were significantly less isolated and the resulting dependencies were much more confusing, which makes it worse!
I would say that you should look at the current state of the code to see the level/degree of change.  (Even just the source-to-sink assignment code is waaaaaay more understandable than it used to be.)  But from what (little) you've touched in it, I gather that setLevel and fadeLevel were probably the most perplexing bits of it for you, so you might as well wait a tad longer since those portions are hopefully getting replaced Real Soon Now.

Fix the QU next. 😂

Heh.  Fork and adapt (to get mildly political...repeal and replace?  :sweat_smile:) could easily be your best bet!


Added Cookie Policy, Terms of service, Copyright page

Done with the changes that you said, I added the files in policies folder and linked with index.html file too.
Kindly check and please let me know if any issues are there @swaraj-das
fixes: #578 #577 #576

@neeru24 Use the same color palette across all the pages for consistency same as the color of return policy page.

@neeru24 Use the same color palette across all the pages for consistency same as the color of return policy page.

I have applied the same color palette across all the pages for consistency, matching the color scheme of the return policy page. I have completed the changes and created three files. Kindly merge my work and assign me Level 3.


Errors

The error handling by ked could be drastically improved to point out positions of errors and which line they are one, etc.

The stuff is in place for this to happen so once I get to the actual creation of errors I'll be able to add this in