ci: add github actions for linting & type-checking

Problem
When contributors open PRs, there are no basic checks that help with streamlining review.
Changes
Add GitHub Actions to automatically check if the code builds and passes the linter.

@Nutlope Cool to merge this in?

@Nutlope Can you update the repo settings to recommend PRs be up to date with the base branch?

@privatenumber done!


Expansion Panel don't expand when pressed

Page URL
https://api.flutter.dev/flutter/material/ExpansionPanelList-class.html
Page source
No response
Describe the problem
When I tapping on each panel, the expected behaviour is for it to expand, but does nothing.
Expected fix
On line 67, you need to remove the not operator.
e.g.
_data[index].isExpanded = isExpanded;
Additional context
No response

Hi @cory-brown
This is a known issue and has been fixed by https://github.com/flutter/flutter/pull/132837. You can check it on master API docs: https://master-api.flutter.dev/flutter/material/ExpansionPanelList-class.html.
Closing as fixed on master. The fix should be landed to stable API docs soon.


Automated cherry pick of #8207: fix: qcloud set hostname for instance

Cherry pick of #8207 on release/3.4.
#8207: fix: qcloud set hostname for instance

/lgtm
/approve


Union to intersection

Adding documentation changes to the UnionToIntersection PR #98 before merging to master.

:tada: This PR is included in version 3.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


error: Microsoft Visual C++ 14.0 is required. in python 3.6.0

when i pip install pyzmq, it showed that error. but it's perfect in python 3.5.2.
how can I install it? or could u fix it with a update?
Thanks very much. Waiting for answer

I need to upload wheels for Python 3.6, but haven't yet. I will do it this week.

I've uploaded the 3.6 wheels, so it should work, now.

hi guys, i had same issue  when install mysql-python module
kindly, to share the solution here .


building pytorch wrapper

Hello,
I'm trying to build pytorch wrapper on Windows without success.
I followed the instructions (from: ) and built project using makefile.
However when I use python build.py command I get following error:
LINK : fatal error LNK1181: cannot open input file '.\Release_nv_wavenet_ext.obj'
I'm using:
-Windows 10
-Python 3.6
-Cuda 9.0
-1060 GTX
-Latest version of Pytorch
I'm not an expert so any help would be appreciated.

After some investigation I found out that this error probably results because of spaces I have in paths which cl.exe does not support.
This is a question for somewhere else therefore I'm closing this thread.


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v4.16 to before v5.15.5",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=93286261de1b46339aa27cd4c639b21778f6cade",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=8823ea27fff6084bbb4bc71d15378fae0220b1d8"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "93286261de1b46339aa27cd4c639b21778f6cade",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "8823ea27fff6084bbb4bc71d15378fae0220b1d8",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "x86/hyperv: Fix NULL deref in set_hv_tscchange_cb() if Hyper-V setup fails\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.15.5 by commit 8823ea27fff6084bbb4bc71d15378fae0220b1d8, it was introduced in version v4.16 by commit 93286261de1b46339aa27cd4c639b21778f6cade. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1002309


Upgrade to ISCE2 2.6.3

Fixes numpy incompatibility and removes annoying Stanford license printout!!!
I have confirmed that all tests pass in new environment build, and interferograms are produced as expected.

This might also resolve https://github.com/ASFHyP3/hyp3-isce2/issues/20 (we will have to see if there are still conflicts when installing Python 3.10).


LightFM MetaData Embedding layer implementation in Pytorch

Has anyone done something like the metadata embeddings used in LightFM and make it work? I understand in a very high level way how they are created in LightFM. How ones we have the item features embeddings for each item/user, they are added to create a "compused representation" and then used to perform the matrix multiplication. but I'm having some trouble thinking around how this can be implemented using the Pytorch embedding layers.

I had a branch that implemented this: https://github.com/maciejkula/spotlight/tree/hybrid_models
Feel free to mine it for inspiration; I hadn't been able to find an API that felt clean enough.

I had a branch that implemented this: https://github.com/maciejkula/spotlight/tree/hybrid_models
Feel free to mine it for inspiration; I hadn't been able to find an API that felt clean enough.

Does this implementation has equivalent performance to lightfm?

@aptlin haven't tested the branch out but: https://github.com/cemoody/simple_mf/blob/master/notebooks/01 MF model.ipynb might be of interest


Decide on a (or a small number of) model export formats we want to support

To make these models useful for serving we should have some export support.

Here are two suggestions:

PMML : which adds support for predictive models as well as Kmeans, as shown in Spark's documentation
protobuf: tensorflow supports exporting models into protobuf, moreover, tensor-serving supports deploying these saved models in production. So this format is worth supporting to cover the deep learning models.


Validation: fix missing descriptions #11

Global effort to fix validation errors
The Content & Learning team is fixing build validation errors on docs.microsoft.com. This effort will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. I’d very much appreciate your timely review and feedback on these changes I’ve suggested. Thanks!

Hi @adegeo, this PR is ready to be reviewed and merged.


Static Resource Paths Aren't URL Encoded In Route Handler

Describe the bug
When serving assets with spaces in their name, they get redirected back to the SPA index.html page instead of being served up. This appears to be because the assets in the browser are URL encoded and the static handler is not URL encoding the file names and therefore saying it "doesn't handle it".
Example: URL for an asset is http://orchestrator.default.<IP_ADDRESS>.sslip.io:8080/assets/Destiny Logo.png, gets redirected back to index.html
Example: URL for an asset (no space), http://orchestrator.default.<IP_ADDRESS>.sslip.io:8080/assets/destinylogo.png gets served up just fine.
Quinoa recognizes the asset:
Quinoa is scanning directory: /linux-repos/orchestrator/src/main/webui/src
Quinoa is scanning directory: /linux-repos/orchestrator/src/main/webui/src/assets
Quinoa is watching: /linux-repos/orchestrator/src/main/webui/src/assets/Destiny Logo.png
Quinoa is watching: /linux-repos/orchestrator/src/main/webui/src/assets/destinylogo.png
Quinoa copies it to the build directory just fine:

Quinoa version
2.0.8
Quarkus version
3.2.2.Final
Build / Runtime
Angular
Package Manager
NPM
Steps to reproduce the behavior

Create a Quinoa Angular app and put a static asset with spaces in the name in src/main/webui/src/assets/
Create an angular app which serves up the image, e.g.

Run ./gradlew quarkusDev, notice that it works just fine because ng serve is watching the files with URL encoded file names for the route handler
Run ./gradlew clean quarkusBuild -Dquarkus.knative.deploy=true and go to the deployed instance, notice that the file isn't displayed due to a redirection back to index.html
Change file to not have spaces and repeat 3 & 4 but this time Step 4 shows the image.

Expected behavior
Static assets with spaces in their name are served up properly.

Good catch.  Definitely gotta be a bug.

@alex-lmco did you research where the bug is occurring in the code?

@melloware I did not beyond looking at Quinoa seemingly using a Static Handler for it here.  I don't know the internals of Quinoa or Quarkus too well and wrote the issue here.  I don't know if it's actually a Quarkus bug under the hood.

Can you also post your application.properties settings for Quinoa as well?

Here you go, I included all the http, vertx, and resteasy reactive properties too since they're kinda relevant.
quarkus:
  http:
    enable-compression: true
    cors:
      ~: true
      origins: /.*/
# snip
  vertx:
    prefer-native-transport: true
  resteasy-reactive:
    path: /api/
  quinoa:
    enable-spa-routing: true
    package-manager-command:
      build-env:
        NODE_ENV: development
"%dev":
  quarkus:
    http:
      port: 3000
"%prod":
  quarkus:
    quinoa:
      package-manager-command:
        build-env:
          NODE_ENV: production
# snip

OK I found it and PR'ed a fix


change background on new post page to make it look like the rest

This is now done! I restyled the input fields to be a bit sleeker, but if we get a design at any time of a better looking version I can now easily implement it!


Create a custom level editor as a second tab within the level editor tab.

The custom level editor is for editing level files which represent a full static level. Each template in these level files is a setroom template with the coordinates the room should appear at; any other room is ignored.
This editor does not show any level files with the same name as a vanilla level file so that those aren't accidentally modified in a way that could break them.
There have also been a few fixes for the regular editor:

Save file icons are updated upon saving.
Fixed scroll wheel in the "Full Level View".

Looks like you've added a ton of new instance variables defined outside of __init__ which is an anti-pattern and causing pylint to fail

Most of those were pre-existing so I was kinda confused. I guess I can just add all of them to the init.
I wasn't sure if there was a reason they were left out, but if it's an anti-pattern causing the linter to fail, that's a good enough reason for me to add them.

Resolved those issues.


Write more docs than just the README

There's a lot of implicit knowledge here, I should get this written down.

This is probably far more relevant on the diesel page but thought would check if wanted to add a bit of documentation on the set up required for diesel, in particular the set up of postgresql? I know I had to play around a bit to get it going and thought I could share that to help future contributors... What do you think?

Sure!
On Jan 27, 2017, 22:51 -0500, Dylan Maccora<EMAIL_ADDRESS>wrote:

This is probably far more relevant on the diesel page but thought would check if wanted to add a bit of documentation on the set up required for diesel, in particular the set up of postgresql? I know I had to play around a bit to get it going and thought I could share that to help future contributors... What do you think?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub (https://github.com/rust-lang-nursery/thanks/issues/6#issuecomment-275825110), or mute the thread (https://github.com/notifications/unsubscribe-auth/AABsipsOi9gTptia95YGCoPSyiACqc8Lks5rWrswgaJpZM4LiQHe).

Alright well I will whip something together and let me know what you think :smiley:


Enhancing the contributing.md file

Sorry for making this as a feature issue though the is that the contributing.md file needs an update and enhanced version of itself.

@kayhantolga please do review the PR generated #403.


[FLINK-26231][state/changelog] Fix ChangelogStateBackendHandle constructor

What is the purpose of the change
In ChangelogStateBackendHandleImpl constructor, materializationID and persistedSizeOfThisCheckpoint are mixed up.
Verifying this change
Added ChangelogStateBackendHandleTest
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? no

No worries @Myasuka :)
I've rebased and updated the PR, PTAL.

Thanks for the review,
I'll merge the PR as soon as CI passes (private build passed before).

Build failure unrelated (pulsar); the failed phase succeeded in private branch build, merging.


Update to Bevy 0.14.0-rc.2

Also runs cargo fmt and clippy fixes because my IDE did that automatically. Hope you don't mind :)

Closing in favor of https://github.com/FraserLee/bevy_sprite3d/pull/22


Config can read map and assign itself a mapping function

Users should not be required to apply interpolation functions, so we would like to make the Config class more clever. The method apply is dynamically assigned. When using points, the apply will be map_point, while using regular binning, the apply will be map_regbin. When using log-binning, we will first convert the positions to log space.
Like:
setattr(self, 'apply', self.map_point)

This will make the functionality of Config and Plugin completely de-coupled.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

25 of 37 (67.57%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 77.285%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

appletree/config.py
25
37
67.57%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
1395

Relevant Lines:
1805

💛  - Coveralls

@xzh19980906 There is a mess. But the most important file is appletree/config.py. I think the functionality of ti the most important thing, other files are already covered in autotest.


fix precheck output

Please provide a description of this PR:
cc @craigbox

@zirain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
c9927e96b4d27766f795a8f7c357a36440dbcfdc
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zirain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
2405703d9c50a6a196018be0a9de0f536d77e6d1
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


[Don't Merge] resolve conflict when refactor-dev merge master

Coverage decreased (-30.3%) to 53.653% when pulling 06e5e53370d2fe7d6c32e64b38faad96af62610c on canwan/resolve-conflict into b6e0784aa89f893fe8b575f522a25f2df7165426 on master.


Make streams-explorer configuration in Helm chart easier

Add extra section for config:
config:
  KAFKACONNECT_url: http://localhost:8083
  KAFKACONNECT_url: http://localhost:8083

The corresponding environment variables with the SE_ prefix are generated then.
Additionally, we could provide .Values.settings that allow passing the whole settings.yaml  as a string. The helm chart then creates a ConfigMap ( with the settings.yaml as content) that is mounted as a volume to the chart.

I think it would be nice to support actual yaml here, rather than using strings, so that it would be possible to copy sections from backend settings.yaml to Helm values.yaml and vice versa


Export more for header

export more items needed for dynamic header
remove build mode that is no longer needed

Probably because whatever stackoverflow I copied that from used React.Component and it worked 😂 I can update to FunctionComponent

I tried changing this to both React.FunctionComponent and JSX.Element and they both presented a slew of type errors in my React app that is rendering this - are you ok to leave as React.Component for now since that seems to play nicely for whatever reason?

Haha, yep gotcha. Maybe ReactNode is the correct typing for a component - I know that's what you'd use if you want a component to have children, but I'm not sure if that is correct here either. If this works, no worries.
I've approved, feel free to rebase and merge at your leisure, or change it if you want.

@blessedcoolant will you take a look when you have a chance please?


v2.3.2 not working in Mac?

Looks like install from v2.3.1 still work, but update to v2.3.2 will not work.
v2.3.2

v2.3.1
**

**

Please find EXTIONSION\server\bin\macOS\lua-language-server, try run it manually.

the same problem.

I reinstalled the lastest vsCode app, and the lua-language-server(2.3.1) , it worked well.
So the reinstalled way is the god.

2.3.2 requires VSCode 1.54 instead of VSCode 1.53 in 2.3.1.
The lasted VSCode is 1.58, please try to update your VSCode.

Works now, thanks.


Trigger adding extra <View /> disrupts flex layout.

Related to #41
zeego version: 1.6.2
Trying to create a grid layout where every item has a context menu with the following code:
<Animated.ScrollView
  contentContainerStyle={{
    gap: 8,
    flexWrap: "wrap",
    flexDirection: "row",
  }}
>
  {psalmen.map(psalm => (
    <ContextMenu.Root key={psalm.nummer}>
      <ContextMenu.Trigger>
        <TouchableOpacity
          className="aspect-square grow basis-16 items-center justify-center rounded bg-tertiary/20 p-4 dark:bg-tertiary/70"
          onPress={() => onPressPsalm(psalm)}
        >
          <Text className="font-bold text-dark-blue text-2xl dark:text-white">
            {psalm.nummer}
          </Text>
        </TouchableOpacity>
      </ContextMenu.Trigger>
      <ContextMenu.Content>
        {psalm.verzen.map((vers, idx) => (
          <ContextMenu.Item
            key={`vers-${vers.nummer}-${idx}`}
            onSelect={() => onVersPress(vers)}
          >
            <ContextMenu.ItemTitle>{getVersTitle(vers, false)}</ContextMenu.ItemTitle>
            <ContextMenu.ItemIcon
              ios={{
                hierarchicalColor: "red",
                name: isFavorite(vers) ? "heart.fill" : undefined,
              }}
            />
          </ContextMenu.Item>
        ))}
      </ContextMenu.Content>
    </ContextMenu.Root>
  ))}
</Animated.ScrollView>

The result of this code is this:

Screenshot 1
Screenshot 2

As seen in the screenshots the items in the grid are taking up the full with of the container which is (I think) a result of <ContextMenu.Trigger /> adding an extra <View /> to the tree.
Any suggestions on how to resolve this or maybe a different approach?

Did you try adding style to the trigger?

Yeah I tried that but that makes the whole square dissapear.

Perhaps we could add asChild to it

That would be great!

could you try making a custom trigger using the create() function that just returns your touchable? this would mirror the asChild behavior

Still invisible
const ContextMenuTrigger = ContextMenu.create(TouchableOpacity, "Trigger");

<Animated.ScrollView
  contentContainerStyle={{
    paddingTop: 172 + insets.top,
    paddingBottom: 172 + insets.bottom,
    paddingHorizontal: 24,
    gap: 8,
    flexWrap: "wrap",
    flexDirection: "row",
  }}
>
  {psalmen.map(psalm => (
    <ContextMenu.Root key={psalm.nummer}>
      <ContextMenuTrigger className="aspect-square grow basis-16 items-center justify-center rounded bg-tertiary/20 p-4 dark:bg-tertiary/70">
        {/* <TouchableOpacity
      // className="aspect-square h-full w-full grow basis-16 items-center justify-center rounded p-4"
      onPress={() => onPressPsalm(psalm)}
    > */}
        <Text className="font-bold text-dark-blue text-2xl dark:text-white">
          {psalm.nummer}
        </Text>
        {/* </TouchableOpacity> */}
      </ContextMenuTrigger>
      <ContextMenu.Content>
        {psalm.verzen.map((vers, idx) => (
          <ContextMenu.Item
            key={`vers-${vers.nummer}-${idx}`}
            onSelect={() => onVersPress(vers, 1)}
          >
            <ContextMenu.ItemTitle>{getVersTitle(vers, false)}</ContextMenu.ItemTitle>
            <ContextMenu.ItemIcon
              ios={{
                hierarchicalColor: "red",
                name: isFavorite(vers) ? "heart.fill" : undefined,
              }}
            />
          </ContextMenu.Item>
        ))}
      </ContextMenu.Content>
    </ContextMenu.Root>
  ))}
</Animated.ScrollView>

Screenshot

that’s weird…and if you use pressable?

are you sure it can receive className here?

Like this?
const ContextMenuTrigger = ContextMenu.create(
  ({ children }: MenuTriggerProps) => (
    <TouchableOpacity className="aspect-square grow basis-16 items-center justify-center rounded bg-tertiary/20 p-4 dark:bg-tertiary/70">
      {children}
    </TouchableOpacity>
  ),
  "Trigger"
);

Screenshot

that’s weird…and if you use pressable?

Same behaviour

@nandorojo Here's a repro: https://github.com/Joehoel/zeego-repro


It is works in vue 3?

@superdiazzz Yes it does. One could also infer this from the name. If you are unsure, just try it out?


⚠ Bofrost.es has degraded performance

In b5578c0, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1724 ms

Resolved: Bofrost.es performance has improved in aec1a5e after 9 minutes.


Output per-class probabilities for each nucleus (type_prob)

Dear authors,
I would like to output the per-class probabilities for each nucleus. After running the inference on a tile, the ['type_prob'] field in my output json contains a scalar (e.g. 0.999999996742671), which I assume it is the probability of the predicted class (i.e. the max probability of the softmax across all classes) for that nucleus.
How do I run the inference to output the per class probabilities for each nucleus? (In the Readme it says that "the default configuration doesn't output this"; I am not clear how do I set a different configuration).
Regards,
Luca

The class probability of each nucleus in the ['type_prob'] is not the pixel-wise softmax output. It is the proportion of that nucleus pixels belonging to the assigned type.
https://github.com/vqdang/hover_net/blob/842964dc5d26ffe196d236d16fad16643a103850/models/hovernet/post_proc.py#L179
By default, the inference will run a model w/o typing, so set the flag
https://github.com/vqdang/hover_net/blob/842964dc5d26ffe196d236d16fad16643a103850/run_tile.sh#L3
should do the work.

Thank you for your reply! Sorry, I actually realized I didn't explain my question well. I was hoping to to measure how confident is the model about a nucleus type prediction.
For example, say we have 4 classes (or instance types): "Tumor", "Immune", "Fibroblast", "Other".
For a given nucleus, I would be interested in evaluating the probability of each class (with 4 classes this could be a 4D vector of probabilities, such as [0.85, 0.1, 0.03, 0.02]).
However, given that the model is performing semantic segmentation, I was thinking I could get the pixel-wise softmax output, so to derive the probability distribution of the class labels for each pixel.  Could you point me to where in the code I could access this?
Does it make sense? Would really appreciate your help.
Thanks!
Luca

You will need to change how the output is aggregated
https://github.com/vqdang/hover_net/blob/842964dc5d26ffe196d236d16fad16643a103850/models/hovernet/run_desc.py#L183-L194
to return probabilities for caching
https://github.com/vqdang/hover_net/blob/842964dc5d26ffe196d236d16fad16643a103850/infer/wsi.py#L529-L534
to change the caching array to match with above
https://github.com/vqdang/hover_net/blob/842964dc5d26ffe196d236d16fad16643a103850/models/hovernet/post_proc.py#L109-L112
to retrieve the correct channels corresponding to the above
https://github.com/vqdang/hover_net/blob/842964dc5d26ffe196d236d16fad16643a103850/models/hovernet/post_proc.py#L161-L181
to retrieve pixel-wise probabilities per instance and add them to output dictionary.


bash-it emits bashdb error without bashdb installed

Just pulled from master and now I'm seeing this error when launching bash:
bash: /usr/share/bashdb/bashdb-main.inc: No such file or directory
bash: warning: cannot start debugger; debugging mode disabled

I'm on Red Hat Enterprise Linux Server release 7.3 (Maipo).
bashrc.txt
bash_profile.txt
bash-itplugins.txt

It looks like this is related to this line: https://github.com/Bash-it/bash-it/blob/master/lib/preexec.bash#L122
shopt -s extdebug > /dev/null 2>&1

References:

https://gitlab.com/gnachman/iterm2/issues/4160
https://github.com/rcaloras/bash-preexec/issues/6
https://serverfault.com/questions/745837/bash-to-start-missing-debugger-after-update-to-4-2

Skimming through these, it looks like this error is caused by the above line on specific versions of Bash. The issues describe it in the context of iTerm2, which uses a similar preexec integration script.
Not sure how to fix it - the above links contain a couple of potential workarounds, but I don't have a system to test this...

I can test if a solution can be sussed out from those threads. The only clear workaround I see is checking if bashdb is installed in the preexec_install() function before setting the DEBUG trap on L130.
Installing a VM with CentOS 7.2 and then bash-it exhibits the same behavior.

It looks as though another potential could be that a failed check for bashdb could run shopt -u extdebug to disable the external debugger.

Please see Season of Code for a description of how the DEBUG trap and PROMPT_COMMAND are being employed in this code to emulate zsh's preexec hook. The page notes that a PS0 variable patch that simplified this was accepted into Bash 4.4.
How should bash-it handle this?

Check for Bash 4.4 and use a PS0 implementation only
Check for Bash 4.4 and use PS0 implementation with fallback to DEBUG/PROMPT_COMMAND
DEBUG/PROMPT_COMMAND only (current solution)

Additionally, I am not sure that the current implementation is working as expected. It looks as though the preexec_invoke_exec hook is being executed three times after the command is invoked.
preexec_invoke_exec.txt

I have this issue on KDE Neon
Linux saturn 4.15.0-76-generic #86-Ubuntu SMP Fri Jan 17 17:24:28 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
What's the best way to remove this?

I have this issue on KDE Neon
Linux saturn 4.15.0-76-generic #86-Ubuntu SMP Fri Jan 17 17:24:28 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
What's the best way to remove this?

hey @nshiell
are you still experiencing this bug?

Hi, I get this on CentOS 7 using Bash 4.2.46(2)-release using the latest version of bash-it.

Same here, on Mac:
./blah.sh: /opt/homebrew/Cellar/bash/5.2.15/share/bashdb/bashdb-main.inc: No such file or directory
I believe the issue was:
#!/bin/bash
set -euo pipefail
I changed it to
#!/bin/bash
and the shebang worked.


Debug docs failure

Intermediate result: no models works, ACC causes the segmentation fault.

should we pin the package to an older version of Documenter / Literate which used to work? i don't know if it's urgent to debug this, since users will anyways read the docs online most of the time

We can try, but locally I do not have this error, so I am not sure where it comes from.

The culprit is in this block:
using Plots
import DisplayAs
fig = plot(leg=(0.4, 0.3))

sice the examples are now "settled" i would not mind if we just remove the DisplayAs stuff. (in fact, on my screen it renders much better without DisplayAs).  the main issue comes from collecting old PR previews but that is covered by the github action.

I think it is rather a problem with Plots because Polyhedra does not use DisplayAs. But this needs to be confirmed.


Feature Request: Draw like notes app ipad or like goodnotes

Oftentimes when drawing in excalidraw whether in obsidian or in the web, I cannot go 5 minutes without going back to goodnotes due to the inconsistent strokes, random glitching in certain areas of the drawing, lagging, or the text simply coming out as unreadable. Generally these issues get worse the longer I take notes. I don't know exactly why this is happening, but the implementation of drawing in the ipad pro is horrible. I would be using this as my only way of taking notes, but I simply cannot due to the problems stated above.

Lags, sloppy ink - #5192


Feature/#1029 add option to xhtml formatter

Types of Changes
Prerequisites
Please make sure you can check the following two boxes:

[x] I have read the CONTRIBUTING document
[x] My code follows the code style of this project

Contribution Type
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue, please reference the issue id)
[x] New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have added tests to cover my changes
[x] All new and existing tests passed

Description
Add new option emptyTagsToSelfClosing for XhtmlMarkupFormatter

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Ekaterina Bainova seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Improve discoverability of options which are directly related to using packages on NixOS

Problem
Some options, typically programs.<name>.enable, but also for example virtualisation.virtualbox.host.enable, or even services.<name> directly relate to installing or using a package in NixOS.
I wished that when searching for steam in https://search.nixos.org/packages, I would be directly informed that to install this on NixOS, I actually need to use the option programs.steam.enable.
Proposal
One option is to add the information in longDescription, similarly to how solaar indicates the appropriate option.
Another option would be to add a dedicated meta entry such as relatedOptions to point to all the options which are very relevant to then package, and to make it visible in  https://search.nixos.org/packages.
What do you think? Any better idea?
Issues
https://github.com/NixOS/nixpkgs/issues/221698 steam
https://github.com/NixOS/nixpkgs/issues/196280 partition-manager
https://github.com/NixOS/nixpkgs/issues/12756 evolution
https://github.com/vlinkz/nix-software-center/issues/26
PRs
https://github.com/NixOS/nixpkgs/pull/122424 solaar
https://github.com/NixOS/nixpkgs/pull/222390 steam
https://github.com/NixOS/nixpkgs/pull/222397 partition-manager
https://github.com/NixOS/nixpkgs/pull/222403 virtualbox
https://github.com/NixOS/nixpkgs/pull/222405 docker
https://github.com/NixOS/nixpkgs/pull/222406 podman

This a stop gap solution, long term we should add an extra meta attribute that we can validate that it still exists, that holds this information.


Health check

Hi. Will it work with rocketcaht 5+ ?
I got health status like this
{"ok":true,"jira":{"name":"*****","error":""},"confluence":{"name":"","error":"confluence not configured"}}
I'm 100% sure this account is ok, I'm using it for rocketchat jira integration. So what else it could be?
Thanks.

Hello.
Yeah, it works with Rocket.Chat 5+, just checked it on 5.0.5 and have no any problem.
You should examine  application and rocket logs, and carefully check you configuration.
I have updated the instructions, see README.md, it should helps.

@pru-mike
thanks for reply, where in config I can set token ? (rocket couldn't save webhook w\o token ((
"{"ok":true,"jira":{"name":"jirocket","error":""},"confluence":{"name":"","error":"confluence not configured"}}"
ok":true,"jira":{"name":"jirocket","error":""},
what does mean this error? login error or connection?

It's in "rocketchat / token",  ses in example
This error means "no error", it's empty :)
I thought "ok: true" is self explanatory, but maybe it is not

thanks a lot)

well. it was permissions issue )
now everythink work's greate!)
thanks !


python310Packages.pysma: 0.7.2 -> 0.7.3

Description of changes
Update to latest upstream release 0.7.3

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 201911 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.sma
python310Packages.pysma
python39Packages.pysma


Minimized libraries?

Why you don't use minimized versions of js/css libraries (jquery, angular, bootstrap, etc)?

Yeah, it was mostly a convinience while developing the product. A build
script would be really helpful to minimize the entire project into one
html, css and JS file.
On 25 October 2015 at 07:52, DJXAKEP<EMAIL_ADDRESS>wrote:

Why you don't use minimized versions of js/css libraries (jquery, angular,
bootstrap, etc)?
—
Reply to this email directly or view it on GitHub
https://github.com/ziahamza/webui-aria2/issues/165.


Sign Windows zips

Signing of the windows zip was broken during the arcade conversion. Signing.props is imported by the Arcade Sign.proj. However, it doesn't import Directory.Build.props which defines InstallersOutputPath. ArtifactsDir is  defined so let's use that instead.
I'll do a quick check of the other artifacts we expect to be signed.

cc @johnbeisner This should resolve the issue we spoke about. I hope to get this in over the weekend so you have a build to work with on Monday.


Wait for the async broker port listener close operations to complete at shutdown

Motivation
The main motivation for making this change to shut down port listeners synchronously in BrokerService.close is to reduce test flakiness.
While investigating the flaky test MessageIdTest, these type of exceptions were seen in logs:
Caused by: java.util.concurrent.RejectedExecutionException: Task org.apache.pulsar.metadata.impl.AbstractMetadataStore$$Lambda$669/1529307342@2f790c2a rejected from java.util.concurrent.ThreadPoolExecutor@ad9a9ac[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 9]
        at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2063) ~[?:1.8.0_275]
        at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:830) ~[?:1.8.0_275]
        at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1379) ~[?:1.8.0_275]
        at java.util.concurrent.Executors$DelegatedExecutorService.execute(Executors.java:668) ~[?:1.8.0_275]
        at org.apache.pulsar.metadata.impl.AbstractMetadataStore.receivedNotification(AbstractMetadataStore.java:128) ~[pulsar-metadata-2.8.0-SNAPSHOT.jar:2.8.0-SNAPSHOT]
        at org.apache.pulsar.metadata.impl.ZKMetadataStore.process(ZKMetadataStore.java:320) ~[pulsar-metadata-2.8.0-SNAPSHOT.jar:2.8.0-SNAPSHOT]
        at org.apache.zookeeper.MockZooKeeper.lambda$setData$16(MockZooKeeper.java:728) ~[testmocks-2.8.0-SNAPSHOT.jar:3.5.7]
        at com.google.common.util.concurrent.MoreExecutors$DirectExecutorService.execute(MoreExecutors.java:321) ~[guava-30.1-jre.jar:?]
        at org.apache.zookeeper.MockZooKeeper.setData(MockZooKeeper.java:683) ~[testmocks-2.8.0-SNAPSHOT.jar:3.5.7]
        at org.apache.pulsar.metadata.impl.ZKMetadataStore.put(ZKMetadataStore.java:207) ~[pulsar-metadata-2.8.0-SNAPSHOT.jar:2.8.0-SNAPSHOT]
        at org.apache.bookkeeper.mledger.impl.MetaStoreImpl.asyncUpdateLedgerIds(MetaStoreImpl.java:106) ~[managed-ledger-2.8.0-SNAPSHOT.jar:2.8.0-SNAPSHOT]
        at org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl.lambda$null$1(ManagedLedgerImpl.java:472) ~[managed-ledger-2.8.0-SNAPSHOT.jar:2.8.0-SNAPSHOT]
        at org.apache.bookkeeper.mledger.util.SafeRun$1.safeRun(SafeRun.java:32) ~[managed-ledger-2.8.0-SNAPSHOT.jar:2.8.0-SNAPSHOT]
        ... 6 more

It seems that this problem could occur when the test code is able to access the broker instance that is already terminated.
Modifications
To understand the modifications:
The original solution was to wait up to 10 seconds until the port listeners were closed.
A change was requested to add a new setting for this. After adding this, another change was requested to combine these operations in a way that the existing brokerShutdownTimeoutMs setting would also apply to the closing of the port listeners.
This solution for this adds BrokerService.closeAsync and PulsarService.closeAsync methods so that it's possible to combine the closing of the ports to the close operation that uses brokerShutdownTimeoutMs setting.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@merlimat  I have revisited the solution by adding closeAsync methods so that it's possible to wait for shutdown using the existing brokerShutdownTimeoutMs setting. PTAL

/pulsarbot run-failure-checks

@eolivelli I have made the change to closeAsync so that it doesn't throw checked exceptions.
I took another look at MessagingServiceShutdownHook logic and unfortunately I didn't find a way to simplify the logic. There the intention is to run the shutdown in a background thread so that the actual shutdown can continue if the shutdown takes longer than the timeout. Although the code might look bad, there isn't a real alternative. Catching Exceptions is necessary to catch also possible runtime exceptions that could happen at shutdown. You can try to suggest a better way, I tried and simply didn't find one. :)

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@merlimat Please review this PR since it has changed since you approved it.

/pulsarbot run-failure-checks

@sijie @merlimat I have continued the work started in this PR in another PR . Please review #10199 since it will also help improve CI stability when the asynchronous tasks of broker shutdown can be controlled in tests. This prevents problems which are caused by too many brokers being active at the same time. This could currently happen when previous brokers are asynchronously shutting down.


Cannot change account password

Bug report
Issue Description
Unable to change account password because "passwords do not match", even though they do.
Preconditions
Please provide as detailed information about your environment as possible.
1. framework Version: 1.1.2 and master

Steps to reproduce
It is important to provide a set of clear steps to reproduce this bug.If relevant please include code samples.

sign up for a new account
log in
edit profile
change password & submit

fixed in default theme but still issue persists in velocity theme.

fixed


Support enumConstants extracting

Sometimes it is required to extract enumConstants of the particular enum class. In Java, it is possible via the java.lang.Class#getEnumConstants method. It is proposed to add the same feature to jacodb.

There already exists extension JcClassOrInterface.enumValues but with bug


Can't Get it to work with React-Native

I've setup a websocket server on my local machine and could get it to work with some events on a blade webpage. I am trying to connect to the server using React-Native and can't get that to work.
I've used Pusher as a client to connect to my local server using ngrok.
Here is my code:
    let pusher = new Pusher("SomeRandomAppKey", {
        wsHost       : 'a731f023.ngrok.io',
        wsPort       : 6001,
        disableStats : true,
    });

    pusher.connection.bind('state_change', function(states) {
        console.log("Channels current state is " + states.current);
    });

The console log shows that the connection status is unavailable.
any one been through react-native integration with this package before.
Thanks

I'm using react-native, pusher and laravel-echo with success.
Have you imported Pusher from 'pusher-js/react-native'?

@masterix21 Could you show your configuration please? The Echo initialisation and joining/listening to a channel incluiding the pusher part? Or where did you find the solution? I'm having a hard time finding the way to do it with this stack "rn+echo+pusher" because i want to "listen" and interact with the server i did using laravel-websockets package

`
import React from 'react';
import PusherNative from 'pusher-js/react-native';
import Echo from 'laravel-echo';
import { PROTOCOL } from '../config/passport';
export default (host, token) => {
let options = {
encrypted: true,
key: YOUR_KEY,
wsHost: YOUR_HOST,
wsPort: YOUR_PORT,
disableStats: true,
authEndpoint:  YOUR_URL +'/broadcasting/auth',
logToConsole: true,
auth: {
headers: {
'Authorization': 'Bearer ' + token,
},
}
};
let PusherClient = new PusherNative(options.key, options);

/*
PusherClient.connection.bind( 'initialized', () => console.log('PusherClient::initialized', arguments));
PusherClient.connection.bind( 'connecting', () => console.log('PusherClient::connecting', arguments));
PusherClient.connection.bind( 'connected', () => console.log('PusherClient::connected', arguments));
PusherClient.connection.bind( 'error', () => console.log('PusherClient::error', arguments));
PusherClient.connection.bind( 'unavailable', () => console.log('PusherClient::unavailable', arguments));
PusherClient.connection.bind( 'failed', () => console.log('PusherClient::failed', arguments));
PusherClient.connection.bind( 'disconnected', () => console.log('PusherClient::disconnected', arguments));
*/
return new Echo({
broadcaster: 'pusher',
client: PusherClient,
...options
});
};
`

@masterix21 Thank you for the quick response! I'm still struggling to make it work, first of all, i'm still trying to make it work without authentication (i don't have a Bearer token) is that really required?
I have the simple channel:
Broadcast::channel('chat', function ($user) {
return $user;
});
And in the laravel project which is the server with the websockets running, using VueJS, i am successfully connecting by a simple Echo.join('chat')
What about csrf_token? Do i need any kind of auth?
In the RN part i used your code in a barebone project trying to get feedback in the console but nothing happens.

Your "simple" channel is an authorized channel: it means that you must have a bearer token.
From Laravel docs:

Private and presence broadcast channels authenticate the current user via your application's default authentication guard. If the user is not authenticated, channel authorization is automatically denied and the authorization callback is never executed.

@masterix21 Alright i got the auth part now, and it does "event":"pusher:connection_established"
but it doesn't do the event "pusher":"subscribe" so there's no communication although the connection was successful 😢

This is how i use the code of my past comment:
import echo from 'FILE_WITH_CODE_OF_PAST_COMMENT';

let client = new echo(YOUR_HOST, YOUR_ACCESS_TOKEN);

client.join('YOUR_CHANNEL').listen('YOUR_EVENT', () => console.log(arguments));

Yes i got that right, still no luck 😞
Thank you for your help! I will continue to search for a solution.

I have same problem I can't connect react native app to channel

Edit
I have found solution now
my code is
import React, {
Component
} from 'react';
import {
Platform,
StyleSheet,
Text,
View
} from 'react-native';
import PusherNative from 'pusher-js/react-native';
import Echo from 'laravel-echo';
const instructions = Platform.select({
ios: 'Press Cmd+R to reload,\n' + 'Cmd+D or shake for dev menu',
android: 'Double tap R on your keyboard to reload,\n' +
'Shake or press menu button for dev menu',
});
type Props = {};
export default class App extends Component  {
constructor(props) {
super(props);
let options = {
  encrypted: false,
  key: 'anyKey',
  wsHost: 'host',
  wsPort: '6001',
  disableStats: true,
  authEndpoint:  'host' +'/broadcasting/auth',
  logToConsole: true,

};
let PusherClient = new PusherNative(options.key, options);

let echo = new Echo({
  broadcaster: 'pusher',
  host: 'host:6001',
  client: PusherClient,

});
echo.channel('DemoChannel').listen('WebSocketDemoEvent', (e) => {
console.log(e)
});
}
render() {
return (
<View style = {
styles.container
} >
<Text style = {
styles.welcome
} > Welcome to React Native!

<Text style = {
styles.instructions
} > To get started, edit App.js

<Text style = {
styles.instructions
} > {
instructions
}
  </View>
);

}
}
const styles = StyleSheet.create({
container: {
flex: 1,
justifyContent: 'center',
alignItems: 'center',
backgroundColor: '#F5FCFF',
},
welcome: {
fontSize: 20,
textAlign: 'center',
margin: 10,
},
instructions: {
textAlign: 'center',
color: '#333333',
marginBottom: 5,
},
});

If i do client.join('chat').whisper('typing', this.state.user) and it works! I don't know why the other methods like here, joining, leaving, listen, listenForWhisper don't work 😩

If i do client.join('chat').whisper('typing', this.state.user) and it works! I don't know why the other methods like here, joining, leaving, listen, listenForWhisper don't work 😩

It's because Presence and Private channels need an authentication. Just add this to your api.php or web.php in routes directory:
Broadcast::routes(['middleware' => ['jwt.verify']]); if you are using JWT or just Broadcast::routes(['middleware' => ['auth:api']]);
It should work :)

@masterix21 I am using the same setup as you mentioned above in react native and using pusher and laravel echo. I am keep getting "App key websocketkey not in this cluster. Did you forget to specify the cluster?" with code 4001.

I managed to fix the issue by changing localhost IP address i.e <IP_ADDRESS> to my computer local IP address.

@chiragparekh

I managed to fix the issue by changing localhost IP address i.e <IP_ADDRESS> to my computer local IP address.
Managed to solve mine using with these code block:

/**Note: I am using homestead and on my homestead file I add these lines
This will allow me to let me access my local machine within the network,
and I can also access this via the emulator (Android)*/

networks:
    - type: "public_network"
      bridge: "en1: Wi-Fi (AirPort)"

/**In your App.js*/
import Pusher from 'pusher-js/react-native';
import Echo from 'laravel-echo';

/**In your App.js, function App()*/
useEffect(() => {

        Pusher.logToConsole = true;

        let PusherClient = new Pusher('{YOUR_KEY}',{
            cluster: 'mt1',
            wsHost: '{YOUR_HOST}',
            wsPort: '6001',
            enabledTransports: ['ws'],
            forceTLS: false
        });

        let echo = new Echo({
            broadcaster: 'pusher',
            client: PusherClient
        });

        echo.channel('home').listen('NewMessage', (e) => {
            alert()
        });

    })

@chiragparekh

I managed to fix the issue by changing localhost IP address i.e <IP_ADDRESS> to my computer local IP address.
Managed to solve mine using with these code block:

/**Note: I am using homestead and on my homestead file I add these lines
This will allow me to let me access my local machine within the network,
and I can also access this via the emulator (Android)

- ssh into your homestead and do `ifconfig ` and get the `eth2` ip address, that would be your access.

*/

networks:
    - type: "public_network"
      bridge: "en1: Wi-Fi (AirPort)"

/**In your App.js*/
import Pusher from 'pusher-js/react-native';
import Echo from 'laravel-echo';

/**In your App.js, function App()*/
useEffect(() => {

        Pusher.logToConsole = true;

        let PusherClient = new Pusher('{YOUR_KEY}',{
            cluster: 'mt1',
            wsHost: '{YOUR_HOST}',
            wsPort: '6001',
            enabledTransports: ['ws'],
            forceTLS: false
        });

        let echo = new Echo({
            broadcaster: 'pusher',
            client: PusherClient
        });

        echo.channel('home').listen('NewMessage', (e) => {
            alert()
        });

    })

@jafar-albadarneh
did you resolved your issue
The console log shows that the connection status is unavailable.

@jafar-albadarneh
did you resolved issue of websocket.


Small opimizations

[FixInsight Optimization] xxHash32.pas(133): O805 Inline marked routine 'TxxHash32.RotateLeft32' comes after its call in the same unit
[FixInsight Optimization] xxHash64.pas(123): O805 Inline marked routine 'TxxHash64.RotateLeft64' comes after its call in the same unit
Impementation is too late to get inlined by compiler.
-Tee-

Thanks for this.
Can you please create a pull request?

I am leaving to holiday, so can't promise right now.


MY RESOURCE GROUP AND SUBSCRIPTION IS NOT SHOWING EVEN THOUGH I HAVE SIGNED IN AND SO I CANNOT DEPLOY MY APP TO THE WEB

Does this occur consistently?
Repro steps:

Version: 0.8.4
OS: win32
OS Release: 10.0.18362
Product: Visual Studio Code
Product Version: 1.86.2
Language: en

Hi, can you give more information about the issue you are facing? Are there any errors? Including screenshots will help a lot.

Hi, can you give more information about the issue you are facing? Are there any errors? Including screenshots will help a lot.

Thank you so much, it has been resolved


Cannot call a function returning a value

Description
Aim
Trying to call a function like this:
fn bar() -> bool {
    true
}

fn main() -> pub bool {
   bar();
   true
}

Expected behavior
no error
Bug
I get an error: error: Expected type (), found type bool
To reproduce
try to nargo prove the provided snippet
Environment

OS: mainframe

For nargo users

noir-lang/noir commit cloned: latest master
Proving backend

[X] default
[ ] wasm-base

Still exists in 0.3.2

This is correct behaviour; the bar function returns a boolean but it is not being used. This can be fixed by:
fn bar() -> bool {
    true
}

fn main() -> pub bool {
   let _k = bar();
   true
}


On Field delete corresponding text boxes not updating correctly

To Reproduce:

Click Edit
Delete existing phone number
The label says email but the text box still holds the phone number.

So seems like the problem here is that when you delete a field, only the field is deleted, but the values for the fields remain in the same index. Basically:
State 1:
Field A: Value A
Field B: Value B
Field C: Value C
deleting field B gives
State 2:
Field A: Value A
Field C: Value B
... if that makes sense. I'll take a look into this.


tests/recurrent/end-to-end.js to ts

Description

Converted https://github.com/BrainJS/brain.js/blob/master/tests/recurrent/end-to-end.js to ts
Motivation and Context

issue
How Has This Been Tested?

It is a test file
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Author's Checklist:

[x] My code focuses on the main motivation and avoids scope creep.
[x] My code passes current tests and adds new tests where possible.
[x] My code is SOLID and DRY.
[ ] I have updated the documentation as needed.

Reviewer's Checklist:

[ ] I kept my comments to the author positive, specific, and productive.
[ ] I tested the code and didn't find any new problems.
[ ] I think the motivation is good for the project.
[ ] I think the code works to satisfies the motivation.

Please merge latest commit from master

Hi @mubaidr , I have merged recent master commits, can you please verify ?

You have merged master of dhairyagada, please pull master of origin i.e. github.com/BrainJS/brain.js

Hey @mubaidr ,  I am trying to fetch and merge the original repository https://github.com/BrainJS/brain.js.git, but it is showing me that my repo is already up to date. Can you guide me on how do I merge it?
What I did earlier was -
git remote add upstream https://github.com/BrainJS/brain.js.git
git fetch upstream
git checkout master
git merge upstream/master

NVM, there is no conflict with the master branch.

this PR added eslint errors to the repo (they are fixable by running with the --fix flag).

@JCMais Fixed the errors. 👍🏼


Provide a more helpful error message when to few bytes were received

We have a debug check for the semi-common error of mislabeling a
field/expression to a type which is too small. We originally added these
because the value would actually deserialize successfully, but to the
wrong value. We didn't add checks for the "too few bytes" case, as it
would have errored anyway and seemed less common.
However, the error message received when one does make this mistake is
not terribly helpful. We can add an additional check in debug mode to
give a bit more information when someone does make this mistake.
We should see if we can provide some more general improvements to an
error generated by DeserializationError in the future. Including the
column name would go a long way, but is a bit larger in scope.
Fixes #696.

You have a typo in the commit message, it should be "too few", not "to few" ;-)
Not sure if you really care about that but eh...

I do. I'll amend when I merge. :)


Update dependencies

Closes #27

Codecov Report

Merging #28 (f6851ee) into master (c29eafe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   93.04%   93.04%
=======================================
  Files          34       34
  Lines        3970     3970
  Branches      426      426
=======================================
  Hits         3694     3694
  Misses        205      205
  Partials       71       71


Failed to import - types

I've patched an npm module and would like to use my fork in deno. However, I have an issue where the type declarations generated by esm.sh do not seem to have a matching path as / is omitted for type definitions.
Is there a misconfiguration on my side?
Failing module type import - wrong namespace generated

GitHub: https://github.com/jamescqcampbell/ts-retry

import { retryAsync } from<EMAIL_ADDRESS>
Module is exported correctly:
/* esm.sh -<EMAIL_ADDRESS>*/
export * from<EMAIL_ADDRESS>
i.e.
<EMAIL_ADDRESS>
But type defs are then only exported at:
<EMAIL_ADDRESS>

Which then resolves to the wrong types in deno.
Additional info

esm.sh version: 135

i think it's a resoving bug of esm.sh, i will look into it

seems v136 works correctly, but it has not not been deployed yet

i will add a fixpatch for v135 tmr


How to solve this red error when using PyCharm

Hi, guys,
I am learning this repo and using PyCharm.
But I meet a problem that there is a red error when checking the code in PyCharm, although the code seems to run normally.
It shows like this,

Could please tell me how to fix this?
Your answer and idea will be appreciated!

Hi, guys,
I am learning this repo and using PyCharm.
But I meet a problem that there is a red error when checking the code in PyCharm, although the code seems to run normally.
It shows like this,

Could please tell me how to fix this?
Your answer and idea will be appreciated!

Because pycharm could not find config file, actually config is used in playground. This error doesn't matter, so you could ignore this.


Adding RenderTransform

I was going to play with Granular a bit by adding RenderTransform. I see that there is some support already or am I mistaken?

Matrix and Transforms classes are implemented, but the RenderTransform and LayoutTransform are not implemented yet.
I've actually started playing with the implementation of RenderTransform but I haven't finished it yet.


Use Travis CI configuration from master

The travis config has been updated again on master and release-2.x. I don't think this is necessary anymore.


Incorrectly indented code in steps 12 through 89 of the Learn Intermediate CSS by Building a Picasso Painting project

Describe the Issue
I came across this forum topic where the user was confused about opening/closing tags for div elements.  After looking at step 12 of the project, I noticed the starting code for step 12 (the solution for step 11) added an indentation of 4 spaces not needed for the
.  Also, the  has too much indentation.
Affected Page
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-intermediate-css-by-building-a-picasso-painting/step-12
Incorrect code
Instead of the starting code looking like:

Expected behavior
It instead should look like:

This affects all the remaining steps through step 89 (the final step).  This will be an easy but tedious task to fix all the steps.
Screenshots
No response
System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
No response

I discovered this issue and would love to help fix it!

Here is the markdown file https://github.com/freeCodeCamp/freeCodeCamp/blob/93b3151cca51becd237c3a58083f99a02b5059fb/curriculum/challenges/english/14-responsive-web-design-22/learn-intermediate-css-by-building-a-picasso-painting/60b69a66b6ddb80858c51582.md
this issue requires changing the seed contents, especially these lines
https://github.com/freeCodeCamp/freeCodeCamp/blob/93b3151cca51becd237c3a58083f99a02b5059fb/curriculum/challenges/english/14-responsive-web-design-22/learn-intermediate-css-by-building-a-picasso-painting/60b69a66b6ddb80858c51582.md#L45-L52
be careful and don't delete --fcc-editable-region--
Additional context
Please make sure you read our guidelines for contributing, we prioritize contributors following the instructions in our guides. Join us in our chat room or the forum if you need help contributing, our moderators will guide you through this.
Sometimes we may get more than one pull requests. We typically accept the most quality contribution, followed by the one that is made first.
Happy contributing.

@emcode93 issues are not assigned, feel free to open a PR
@hrittik2002 don't trust PR titles, there isn't such a folder, the steps are in curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting
Please read the contributing guidelines at contribute.freecodecamp.org

@Sboonny you have linked only one step, but this issue is for all the steps between 12 and 89

thank you @ieahleen, I have edited my original comment

This would be much easier to fix using the Challenge Editor.  @ieahleen created an issue to have instructions for using it added to the How to Work on Practice Projects guide.


Custom mappings in the SDK for targets, including renaming and basic expressions

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/63
Originally created by @aaronsteers on 2021-03-26 21:14:38

@DouweM demonstrated in Demo Day on 2021-03-26 a fully serverless data pipeline running on Gitlab CI and the "reverse ETL" or "ETL-P" (P for publish) approach. The demo showcased a column-name remapping setting and I'd like to consider making that a standard feature in the SDK.
I also think it would be valuable as we are implementing this spec if we had a simple expression language to use for small conversions. For instance, if a target expects data rounded to a specific decimal point, or in a specific data format, a field concatenation or string split into multiple fields.
We can use DBT for this, but then we have to land the data locally and transform it.

There are use cases where it would be much more efficient to stream directly from a source to a target without landing it first in the data repository.
There are also small tweaks and customizations that a SaaS target may require, which don't in themselves warrant a dedicated DBT transform.

SimpleEval
One option which is built for safety and looks robust enough for these types of inline transformations is the simpleeval library: https://pypi.org/project/simpleeval/
Examples from the website:
Simple math:
>>> s = SimpleEval()

>>> s.eval("1 + 1")
2

>>> s.eval('100 * 10')
1000

Variables and nested property access:
>>>  simple_eval("foo.bar", names={"foo": {"bar": 42}})
42

Applications for Targets
Given an input row and a mapping dict, we could either append the contents of record with the provided mapping transformations, or we could replace the entire record dict with the output of those transformations. (This could be determined by the target developer.
Applications for Taps
This could be an alternative to the interim pipeplinewise-transform-field plugin, if provided to a tap that supports it, certain transformations could be expressed directly by the user in config as post-preocessing mapping transformations. When provided, these transformations could nullify or hash records without having to pass the data through a separate process.
Applications for Meltano config
It was mentioned in our post conversation that there may be a similar issue or feature request for meltano.yml config, allowing users to perform basic transformations within the yaml expressions similar to how environment variable expansion today allows them to pass in variables from the environment rather than hard coding them.

View 12 previous comments from the original issue on GitLab


[Azure Search] Fixing deadlock in Search when using POST

Fixes https://github.com/Azure/azure-sdk-for-net/issues/6254
See individual commits for details. Also improves some documentation for the searchFields parameter.
FYI @Yahnoosh @jadrefke @natinimni @shmed @ishansrivastava90 @updixit

Failure in the Linux build looks unrelated to my changes:
Failed   UpdaterShouldRunOneAtATime
Error Message:
 Assert.AreEqual failed. Expected:<00>. Actual:<0>.
Stack Trace:
   at Azure.Storage.Common.Test.TokenCredentialTests.UpdaterShouldRunOneAtATime() in /home/vsts/work/1/s/sdk/storage/Azure.Storage.Common/tests/TokenCredentialTests.cs:line 65

Results File: /home/vsts/work/1/s/sdk/storage/Azure.Storage.Common/tests/TestResults/_fv-az619_2019-05-16_00_40_23_307.trx

Will merge once CIs pass

@dsgouda @AlexGhiondea Test failure in the CI build is unrelated to my change. Any idea what's wrong?

Tests passed. @dsgouda or @AlexGhiondea -- please merge so we can push this hotfix to NuGet. Thanks!

Forgot to link to the relevant Swagger PRs: https://github.com/Azure/azure-rest-api-specs/pull/5963 https://github.com/Azure/azure-rest-api-specs/pull/5928

@AlexGhiondea Please approve

@AlexGhiondea Yes, that's the only missing one. The test coverage ensures this.


tests: drivers: gpio: Add nrf54h20dk/nrf54h20/cpuppr targets

Add overlays for cpuppr targets in gpio_basic_api and gpio_api_1pin.

Placing a NACK until we can remove the TOML files.

@57300 any news here?


Three Minor fixes

Fix assert, fix spelling, add more diagnostics.

Fixes issue #448

Codecov Report

Merging #451 into master will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master     #451   +/-   ##
=======================================
  Coverage   17.54%   17.54%
=======================================
  Files         213      213
  Lines      122901   122901
  Branches    11839    11839
=======================================
  Hits        21557    21557
  Misses     100485   100485
  Partials      859      859

Flag
Coverage Δ

#2017
17.54% <66.66%> (ø)
:arrow_up:

#Debug
17.54% <66.66%> (ø)
:arrow_up:

#Release
?

Impacted Files
Coverage Δ

src/TraceEvent/Symbols/SymbolReader.cs
0% <0%> (ø)
:arrow_up:

src/TraceEvent/TraceEvent.cs
64.07% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9404c7...1f80550. Read the comment docs.


No browser page load data

I found that there was no browser page load data when I used angular-applicationinsights. However, data from activity by page name was shown perfectly. Are there any ways to show browser page load using angular-applicationinsights?
Kind regards,
Yui

Currently not at the moment. Page load times are something planned for being added however.

@khaines great to hear that you are planning this for the future, and thanks for the plugin in general.
Do you have any idea when roughly you are planning to work on this? Or do you have some pointers as to what the issue is with page load times so we could look into adding this ourselves in the meantime? Thanks!

Hopefully soon, as my time frees up. I'm always open to contributions if someone wants to add a missing feature before I can get to it. Really the pointer about why page load times aren't tracked in this module is that there is no code doing that job. Angular has some events that are fired when the view is transitioned (both start and finish) and one of those events is used to track the view data. These could probably be a good basis for load time tracking.

Okay, thanks. We might struggle but we'll try to have a look at it ourselves and see how we go. Will send it through if we get anywhere, but can't promise anything. :)

I see that the source has a duration parameter but it's missing in dist.  Still a work in progress?

@bfelda Yes, work is still in progress. Unfortunately project was not supported for a long time. But now we changed the owner. So I hope that work will be continued. If you'd like to be a contributor, it will be cool.

@bfelda I've added the 'duration' parameter in dist. Welcome to use it.

Seems it has some bugs with duration parameter for UI router navigation. Need to check it more carefuly.

I've fixed all evil bugs with UI router. The task is done.


Ignoring metrics in the sensu server

I would like to use an alternative rabbitmq consumer process for the metrics being collected by sensu clients. Is there a way to configure sensu server to ignore all events of type 'metric'?

@afrozl Sensu is already designed to route metrics (or any other event data) to external consumers via Handlers.
Perhaps if you could provide more context we may be able to provide a more helpful response. In the interim, we're going to go ahead and close this issue as a "won't fix".
#monitoringlove


Flux Networks and Refined Storage

Issue description:
Try making a Herculean Flux Storage. Says i dont have the Basic Flux Storage, see screenshots http://i.imgur.com/x1CbXWm.png
http://i.imgur.com/QSftBN2.png
It's like Refined Storage can't see the item are there :)
Link to the mod https://minecraft.curseforge.com/projects/flux-networks
What happens:
What you expected to happen:
Steps to reproduce:

Make a Herculean Flux Storage

...
Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge: <IP_ADDRESS>5
Refined Storage: 1.2.11

Does this issue occur on a server? [yes/no] No
If a (crash)log is relevant for this issue, link it here:
[pastebin/gist/etc link here]

Works now dont use Ore Dict on the patterns :)


method to delete the temp junk

call method on the videohashobject to delete the temp files created by the instance.

delete_storage_path() on instances of the VideoHash class should delete these files.


Create a config model view (api) package under model-integration

This is to avoid having to install config-mode and dependencies
in the container at startup as a consequence of wanting model-integration
there to make TensorFlow available.
@hmusum I resolved to go the other way instead

👍


Fix markdown not rendering html properly

Related to #3408

For some reason, my DCO is not passing

Commit sha: 7353b4b, Author: Lucas Santos, Committer: GitHub;
Expected "Lucas Santos<EMAIL_ADDRESS>but got "Lucas Santos<EMAIL_ADDRESS>


buck2_re_client server and config?

Hi - I can a config section for buck2_re_client in the code, and traced the various components like perform_cache_upload  but it's not clear to me what that cache protocol looks like. Is this code usable in the open source release?

This should be mostly working, you can see some of the support for it here: https://github.com/facebookincubator/buck2/tree/main/remote_execution/oss
This is using the remote execution apis described here: https://github.com/bazelbuild/remote-apis/blob/main/build/bazel/remote/execution/v2/remote_execution.proto. AIUI, there are several open source implementations of the server components of that api (e.g. https://github.com/buildbarn/bb-remote-execution).
It doesn't look like there's an example or documentation yet about how to set that up in the open source release, but I think you can expect that that will be coming soon.

It mostly works, but there are a few patches and configuration steps needed:

We are still in the process of splitting file vs directory artifacts, which is a requirement for the Bazel RE API.
We use SHA1, which only BuildBarn supports.
There is some configuration in the RE settings that needs passing which we currently hardcode to our internal API.

So we have done a small build using BuildBarn, and expect to have instructions on how to do real builds in the next month or so, but for the moment, it's probably infeasible to do so.

I can see an example here now https://github.com/facebook/buck2/tree/main/examples/remote_execution/engflow so I think the issue can be closed.
One thing I haven't figured out is how to just use a shared action cache without a remote executor. Running without engine_address throws an error.
Jobs: In progress: 78. Finished: 42. Cache hits: 0%. Time elapsed: 2.2s

^ the Cache hits is always zero - I assume that's because there is no local cache?

Yep, the shared action cache currently requires the remote executor. We are looking at whether a local shared executor might be a good idea, e.g. #105


Implement collectors (Closes #60)

Implements collectors from #60

Will implement context menus when they release fully

Feel free to pull from the reformat branch & change the target branch :)


5.2 breaks ternary operator style

All my code suddenly failed to pass standard due to a change in standard 5.2 concerning the ternary operator:
const a = true ?
  1 :
  2

standard: Use JavaScript Standard Style (https://github.com/feross/standard)
  index.js:1:17: '?' should be placed at the beginning of the line.
  index.js:2:6: ':' should be placed at the beginning of the line.

The ternary (? :) and the 'blocks must not be padded' rules have been part of standard even though they haven't been enforced consistently due to eslint bugs and ditching jscs at one point. We temporarily lost enforcement of this rule. But now that we can enforce them again, this is basically bugfix, so it went out in a minor, not major version.
Sorry that this broke your tests -- hopefully this won't happen again. I don't think we have any more of these types of changes to release. See https://github.com/feross/standard/issues/248 for more discussion.

Understood, thanks.

Just wondering what the reasoning behind this is. For example:
var foo = (bar === 'test')
  ? baz()
  : quux()

If you don't look at lines 2 and 3, you don't know that foo will be assigned either baz() or quux(). Instead, it looks like the statement ends there and foo is a boolean.
My personal preference would be:
var foo = (bar === 'test') ?
  baz() :
  quux()

which bears a lot of similarity to e.g.
var foo = bar + 'test' +
  baz() +
  quux()

(You could obviously put everything on one line, but imagine longer statements ...)


Format downloaded OpenAPI specs with JSON.stringify, not Prettier

We currently format JSON output using Prettier, but this is running into some "out of memory" problems that are going to be tricky to address.
I'm not sure we will be able to fix a long-standing Prettier bug, and we don't currently have any way to increase our memory in GitHub Actions beyond 7GB
This switches to using JavaScript's JSON.stringify instead. This will result in a different, but still well-formatted output. As you can see from the "dry run" workflow run on push, it doesn't run out of memory.
Fixes #252.

Asking @wolfy1339 and @nickfloyd a review to have more eyes on this.


Help needed?

So I used to play Moongate (Materia Magica) and other MUDS years ago, and miss it. I've been looking around at MUD server systems and they are all antiquated except this one.
I'm no node guru, but I've done plenty of Javascript (and some Node.js development). I started reading the documentation (which is very nice BTW), but was disappointed to see it ends abruptly at Areas.NPC's.
What is the current state of this framework? How can I help as a beginner to the project? Any "easy" issues I could work on?

I was heavy at work implementing features for the past month so this week I'm going to be updating documentation this week to hopefully be up to date with all the features. Then back to work on features again for the v1.0.0 milestone. I'm always open to outside help so feel free to poke through the open issues and see if there's anything you want to work on

Hi! Thanks for responding. Right now the MUD is at v0.5.0 and is about halfway to a viable release.
As you mention, the documentation is unfinished and is the current task at hand. Given that, I'd suggest reading through the codebase, cloning it down and booting up a copy of the MUD to play around with a bit. As far as low-hanging issues, the ability to set and get player preferences (autoloot, brief descriptions, etc.) is the only low-hanging fruit I can think of right now but I think @shawncplus might have more suggestions.
Another way to help might be to try to extend and customize the framework, since the end goal is for building a game on top of the base engine to be super easy. Then, if you run into trouble, open an issue and document your experience.

Awesome, I got it running last night and might have found a bug when in combat, after the match was over the server crashed. How do you all debug? I have Visual Studio Code setup with Ubuntu LTS.

Personally I just use node --inspect ./ranvier with NIM https://chrome.google.com/webstore/detail/nim-node-inspector-manage/gnhhdgbaldcilmgcpfddgdbkhjohddkj?hl=en

Debugging? What's that?
Just kidding. I usually just go through the stack trace, but maybe I should use this NIM thing. I also have VS Code with some linters set up.

Also, feel free to join the contributor's Slack team via https://ranviermud.signup.team/ for real-time chatter.


Can’t update plugin

Describe The Bug
When I try to update the myQ plugin via the Homebridge web UI, I get an error. I'm able to update other plugins, homebridge UI, as well as the Raspberry Pi without issue, but am seeing this error with only this plugin update. I see the below error:
USER: homebridge
DIR: /usr
CMD: sudo -E -n npm install -g<EMAIL_ADDRESS>npm ERR! Cannot read properties of undefined (reading 'isStream')
npm ERR! A complete log of this run can be found in: /home/homebridge/.npm/_logs/2023-08-22T04_23_04_678Z-debug-0.log
Logs
0 verbose cli /usr/bin/node /usr/bin/npm
1 info using<EMAIL_ADDRESS>2 info using<EMAIL_ADDRESS>3 timing npm:load:whichnode Completed in 3ms
4 timing config:load:defaults Completed in 6ms
5 timing config:load:file:/usr/lib/node_modules/npm/npmrc Completed in 1ms
6 timing config:load:builtin Completed in 2ms
7 timing config:load:cli Completed in 8ms
8 warn config global-style This option has been deprecated in favor of --install-strategy=shallow
9 timing config:load:env Completed in 2ms
10 timing config:load:project Completed in 2ms
11 timing config:load:file:/home/homebridge/.npmrc Completed in 0ms
12 timing config:load:user Completed in 1ms
13 timing config:load:file:/usr/etc/npmrc Completed in 0ms
14 timing config:load:global Completed in 0ms
15 timing config:load:setEnvs Completed in 3ms
16 timing config:load Completed in 26ms
17 timing npm:load:configload Completed in 26ms
18 timing npm:load:mkdirpcache Completed in 1ms
19 timing npm:load:mkdirplogs Completed in 0ms
20 verbose title npm install<EMAIL_ADDRESS>21 verbose argv "install" "--global"<EMAIL_ADDRESS>22 timing npm:load:setTitle Completed in 3ms
23 timing config:load:flatten Completed in 10ms
24 timing npm:load:display Completed in 13ms

Config
No response
Homebridge UI Version
4.50.5
Homebridge Version
1.6.1
Node.js Version
18.17.1
Operating System
Official Homebridge Raspberry Pi Image
Environment Info

[ ] Using Docker?
[ ] Using Hyper-V?
[ ] Using hb-service?

Raspberry Pi Model
Raspberry Pi 4 B

Hi @ericdhkim
Can you use the terminal within the homebridge ui to run this command (to install/update the plugin)
npm install -g<EMAIL_ADDRESS>
and try and post the full output of what it shows there?
Ta

Edit - added sudo to the command

I got the same error and same error log (exact same error code about isSteeam)

@ericdhkim
dunno if you found a solution to this by now.
I wonder if a node update would help.
Can you run this from the homebridge terminal?
sudo hb-service update-node 18.18.1

and once this finishes (and homebridge restarts etc) trying to update the plugin may succeed?

Yeah so I did update to 18.18.1 and even uninstalled the plugin and tried to install again from the UI but getting the same error

have the same problem.
when trying to update from UI it stops downloading around 26%.
Using the terminal also stops downloading the package.

Had similar issue.
sudo reboot fixed the issue

I was in my homebridge ui today and had issues updating to 4.51.0 (which I eventually fixed with rebuild command) when I noticed that my node version actually wasn’t on 18.18.1. When I tried the command again, I got an error that it couldn’t update

I also am getting the same error when trying to update.
Ubuntu 22.04
Homebridge v1.6.1
Homebridge UI v4.51.2
nodejs v20.5.1
Was getting the same error on nodejs v18 before updating (updating didn't fix issue).
Let me know if I can provide more information to assist.

I also am getting the same error when trying to update.
Ubuntu 22.04 Homebridge v1.6.1 Homebridge UI v4.51.2 nodejs v20.5.1
Was getting the same error on nodejs v18 before updating (updating didn't fix issue).
Let me know if I can provide more information to assist.

Hi, were you able to resolve this issue?
Thank you.


Post GA of v7 - Update 5.1 pointer to try v6

As per below

should either be replaced to a try v7 or should similarly point to a generic messages similar to  change made https://github.com/PowerShell/PowerShell/pull/9775/

/cc @SteveL-MSFT

@PowerShell/powershell-committee reviewed this, we agree that this needs to be updated in Windows PowerShell by the time PS7 comes out.  Thanks!


Issue with some voices with google text to speech

Voice :  en-GB-Studio-B
Error :

{
  "error": {
    "code": 400,
    "message": "`\u003cmark\u003e` tags are not currently supported by Studio voices.",
    "status": "INVALID_ARGUMENT"
  }
}

Got it
Error Explanation: The error message states that " tags are not currently supported by Studio voices," leading to an INVALID_ARGUMENT status. This suggests that while you are using valid SSML syntax, the specific voice you selected does not support this feature .
Feature Limitation: As of now, Studio voices, despite being generally available since February 26, 2024, do not implement support for  tags. Users have reported similar issues and have suggested filing a feature request for this capability

Yes, this is a known issue. From the TalkingHead README: "The used [Google] voice must support SSML and <mark> tags that are needed to get word-level timestamps. Currently, Google supports SSML and <mark> tags when using Standard, Wavenet, Neural2, News, or Casual voice types."


Return cloned linode object when cloning

Coverage increased (+0.008%) to 71.529% when pulling be16b9de03652ec543b9b406ad5d496219a04eb4 on eatonphil:fix-clone into 9e934fff40861af9966512b13ed61eadf2bfd410 on linode:develop.


Polish Diacritical issue

Typing polish diacritical causes the peer who recieves it to lose connection with the one who sent it. The reciever can no longer get any updates from the peer who sent the diacritical letter (he can communicate with other peers, though)
I guess there's an overall encoding issue somewhere, Brackets DevTools shows: Uncaught SyntaxError: Unexpected string at index.html:1
I hadn't any ideas on the Issue name, please rename it to something that fits better when we know what is the real problem.

Can you post the diacritical that causes this, so I can reproduce?

It happened on ś, here are all that are in PL: śćźżńłóąńę

Please also test special german letters ä,ö,ü and ß.

Ah, I know what this is. Diacriticals don't increase character length, which I was assuming was the same as byte length. This should already be fixed in the next major version.

Yes, that was the issue.


Search and Archive twig page

Hi,
Can you please add a Search & Archive twig template.
Thanks Jake.

Great idea @JakeHenshall — want to put together a PR?


Android Native ScrollView clips content

The Android Native ScrollView is clipping content to the content size of it's immediate first child. This content is intended to overflow into the surrounding region.  This is especially apparent if the first child has a Margin and places things inside that margin.
Basic example:
<App>
	<NativeViewHost>
 		<ScrollView>
			<StackPanel>
				<Panel Color="#CCC" Width="100" Height="100">
					<Panel Alignment="Bottom" Anchor="50%,0%" Color="#F00" Height="20"/>
				</Panel>
			</StackPanel>
 		</ScrollView>
	</NativeViewHost>
</App>

The red bar is not shown. If you remove the ScrollView the bar will be shown.

@nekronos To you, since you've worked on these recently.
The clipping isn't to the ScrollView itself, which might be understandable, but to the bounds of the content. You can see this in the below example:
<App>
	<NativeViewHost>
		<ClientPanel>
			<Panel Color="#FEE">
				<ScrollView>
					<StackPanel Margin="20">
						<Panel Color="#AAA" Height="200">
							<Circle Alignment="TopLeft" Anchor="50%,50%" Width="40" Height="40" Color="#0F0"/>
						</Panel>
					</StackPanel>
				</ScrollView>
			</Panel>
		</ClientPanel>
	</NativeViewHost>
</App>

The circle is clipped despite being completely within the bounds of the ScrollView. It's just not within the bounds of the first child, the StackPanel.


Add Malaysian holidays

The following holidays still need to be added

Isra and Miraj in Malaysia
NUZUL AL-QUARAN DAY
The Sultan of Pahang Hol in Pahang
Birthday of SPB Yang di Pertuan Agong
Birthday of the Sultan of Kedah in Kedah
Birthday of the Raja of Perlis
Hijri New Year Awal Muharram or Maal Hijrah
The Sultan of Johor Hol
Muhammad's Birthday

The following holidays are hardcoded and must be changed

Thaipusam Holiday

Pull Request Test Coverage Report for Build 997518804

205 of 205 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 98.662%

Totals

Change from base Build 969552366:
0.003%

Covered Lines:
5084

Relevant Lines:
5087

💛  - Coveralls

Great.. thank you very much! 👍

@jusce17 I'll have a review of the code plus the TODOs soon; most of the work is done, I just need to finish it up and make sure I didn't mess up anything (well, anything obvious).
@dr-prodigy This one isn't done -- as per the original post, it's not ready for primetime.  Not sure if you can reopen.

Ciao Maurizio,
Ooops ... forgot all about this. Will see if I have time this weekend to work on it; nothing lost by merging it (other that the holidays are incorrect, so not great from a QA workflow perspective) and will fish it out from there and proceed.

One more thing: I was waiting for #498 to be merged as to make development easier an make the new work compatible with it, but I see it isn't merged and that there are no comments as to why. Any way to can look into it and preferably merge it? I will wait for it before working on fixing Malaysian holidays.


Introduce Builder in Overlay

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Use case
A common requirement in UI is the following:
I want to have some widgets which are "above" or "independant" of my "pages".
Usually this is a AppBar, Drawer or BottomSheet.
Currently, doing this is rather unwieldy. To accomplish this feat, we have to do the following:

remove all our Routes from MaterialApp
put a central Page into the MaterialApp.home parameter
add our top level widgets to the central page
add a new Navigator as child of our top level widgets, with all our Routes

If we then want to control our pages in our top level widgets, we additionally have to keep a GlobalKey<NavigatorState> around somewhere in that page to which all top level widgets need to have access to, because they arent inside of the BuildContext of our nested Navigator.
Another requirement, not as common but still not uncommon is that we might want to have some kind of proxy widget that does nothing but redirect, for example an authentication guard or a deep link handler. These obviously need access to the Navigator but have to live in a central spot, so not inside of a Page. As a result, we need a GlobalKey<NavigatorState>.
Proposal
I think that this could possibly be solved a bit more elegantly.
If Overlay would provide a builder parameter,
with the signature Widget Function(BuildContext context, Widget child) builder, which is then used here as follows:
return widget.builder(context, _Theater(...));

(or similar; builder would probably be nullable), then we could gain several simplifications.
The builder would be passed through Navigator all the way up to MaterialApp.
This means we can now insert top level Widgets which have access to navigation through context. This eliminates the need for a GlobalKey that has to be passed to all top level Widgets which need navigation and it also eliminates the need for a second nested Navigator in many cases.
I believe this could simplify many apps which have the usual bottom navigation bar structure and benefit many other applications as well. From what I can tell, this also wouldnt be a particularly complex change.
The only point I can come up with that would be important to solve would be what this parameter is called.
Preferrably, it would replace the current MaterialApp.builder parameter, meaning, in MaterialApp.builder, we would from now on have access to the Navigator which was previously not the case. In case this is a breaking change, the parameter could have an alternate name and the existing builder could persist. However, if this isnt a breaking change, I believe there might be no benefit to have both builders, and the new one could simply replace the old one.
This change cannot be provided by a package in a simple manner, as the package would have to uproot the entire MaterialApp, Navigator and Overlay.

I don't understand what this is asking for.

The builder would be passed through Navigator all the way up to MaterialApp.

What does this mean? The Navigator doesn't know about MaterialApp and cannot pass anything to it.

This means we can now insert top level Widgets which have access to navigation through context.

If the widget lives above the navigator, how does it gain access to the navigator via context? Context lockups only happen upwards.

What does this mean? The Navigator doesn't know about MaterialApp and cannot pass anything to it.

Apologies, I formulated this slightly confusingly.
I mean something like the following:
Overlay declares a builder, which is called with the _Theater
Navigator declares a builder, which is passed to Overlay
MaterialApp passes its builder to Navigator instead of consuming it.
Why do I think this would be useful?
By inserting a Builder below Overlay but above its children, we can create UI elements which have access to Navigator and Overlay in their BuildContext and can appropriately use them, while also having a lifetime that is not bound to any Route (or any OverlayEntry). Such UI components are commonly components like BottomNavigationBar or global AppBars which need to navigate, but live not inside any given Route.
I do not have extensive framework knowledge, but I dont think this should be causing any issues with BuildContext.

If the widget lives above the navigator

As I have clarified above, the Widget would not live above the Navigator, it would neither live above the Overlay but below it.
The important difference is that it lives above the OverlayEntrys.

I'm pretty agnostic to the exact implementation, but I'd like to just throw in a strong +1 to this feature request.
Right now it's extremely painful to include an app bar or navigation bar in my app that does not get rebuilt/animated on page transition (and is thus above the navigator).
If my app bar is under the navigator, it can call pop, but it gets animated along with pages.
If my app bar is above the navigator, it doesn't get animated with the pages, but I have to do a complicated song and dance with a global key and some other nonsense to get a valid reference to my navigator.
Here's the Flutter idiomatic (from what I've seen) way to handle navigation right now (if you're using Nav 2 and not 1 or GoRouter-just the proliferation alone of "official" choices is a big hit to dev ex). This is copied from my current production app:
// Global key. Ewww.
final GlobalKey<NavigatorState> _navKey = GlobalKey();

class HomePage extends StatelessWidget {
  const HomePage({super.key});

  @override
  Widget build(BuildContext context) {
    // I forget exactly why, but without this Flutter keeps trying to pop
    // from MaterialApp's navigator instead of this one.
    return WillPopScope(
      onWillPop: () async {
        return !await _navKey.currentState!.maybePop();
      },
      child: Navigator(
        key: _navKey,
        pages: [
          ...
        ],
        onPopPage: (route, dynamic result) { ... },
      ),
    );
  }
}

To elaborate a bit, I have written a very awful hack that represents the behaviour I want.
The demo can be found on this gist:
https://gist.github.com/clragon/18038b16e9bbdc5e14d4a6e5840517d1
In there I have abused visitChildElements and proxies to lift the NavigatorState and OverlayState above the builder of MaterialApp artificially.
With the proposed change of this github issue, such a hack would be unnecessary.
here is a demo video of the result:
https://github.com/flutter/flutter/assets/11785085/c8bfd788-277d-412b-bd00-622dac2ee761
We have a bottom bar that is outside of our Navigator,
without needing 2 Navigators nested inside of each other
and without passing any GlobalKey to our bottombar.
Produced with the following code:
  @override
  Widget build(BuildContext context) => MaterialApp(
        initialRoute: '/1',
        routes: {
          '/1': (context) => const Page(index: 1),
          '/2': (context) => const Page(index: 2),
          '/3': (context) => const Page(index: 3),
          '/4': (context) => const Page(index: 4),
        },
        builder: (context, child) => Proxy(
          child: child!,
          builder: (context, child) => Scaffold(
            body: child!,
            bottomNavigationBar: const NavBottomBar(),
          ),
        ),
      );
}

and
    return BottomNavigationBar(
      useLegacyColorScheme: false,
      currentIndex: _index,
      onTap: (index) {
        switch (index) {
          case 0:
            Navigator.of(context).pushNamed('/1');
            setState(() => _index = 0);
            break;
          case 1:
            Navigator.of(context).pushNamed('/2');
            setState(() => _index = 1);
            break;
          // and so on
      },

note the Proxy widget.
Because this is a dirty hack and not a real implementation, this only works in release mode.
BottomNavigationBar has an assert that checks for a Overlay runtime type and ProxyOverlay does not fulfill that, even though it has the same interface.
The overall change necessary to allow us to create shouldnt be as complicated as this hack though;
I believe it would look something like this:
in overlay.dart
constructor:
   const Overlay({
     super.key,
     this.initialEntries = const <OverlayEntry>[],
     this.clipBehavior = Clip.hardEdge,
+    this.builder, // of type `TransitionBuilder?`
   });

build method:
+   builder ??= ((context, child) => child!);

-   _Theater(
+   return builder(context, _Theater(
       skipCount: children.length - onstageCount,
       clipBehavior: widget.clipBehavior,
       children: children.reversed.toList(growable: false),

in navigator.dart
constructor:
   const Navigator({
     super.key,
     this.pages = const <Page<dynamic>>[],
     this.onPopPage,
     this.initialRoute,
     this.onGenerateInitialRoutes = Navigator.defaultGenerateInitialRoutes,
     this.onGenerateRoute,
     this.onUnknownRoute,
     this.transitionDelegate = const DefaultTransitionDelegate<dynamic>(),
     this.reportsRouteUpdateToEngine = false,
     this.clipBehavior = Clip.hardEdge,
     this.observers = const <NavigatorObserver>[],
     this.requestFocus = true,
     this.restorationScopeId,
     this.routeTraversalEdgeBehavior = kDefaultRouteTraversalEdgeBehavior,
+    this.builder, // of type `TransitionBuilder?`
   });

build method:
                  child: Overlay(
                   key: _overlayKey,
                   clipBehavior: widget.clipBehavior,
                   initialEntries: overlay == null ?  _allRouteOverlayEntries.toList(growable: false) : const <OverlayEntry>[],
+                  builder: widget.builder,
                 ),

in app.dart
build method:
         child: Navigator(
           clipBehavior: Clip.none,
           restorationScopeId: 'nav',
           key: _navigator,
           initialRoute: _initialRouteName,
           onGenerateRoute: _onGenerateRoute,
           onGenerateInitialRoutes: widget.onGenerateInitialRoutes == null
             ? Navigator.defaultGenerateInitialRoutes
             : (NavigatorState navigator, String initialRouteName) {
               return widget.onGenerateInitialRoutes!(initialRouteName);
             },
           onUnknownRoute: _onUnknownRoute,
           observers: widget.navigatorObservers!,
           reportsRouteUpdateToEngine: true,
+          builder: widget.builder,
         ),

also build method:
     Widget result;
-     if (widget.builder != null) {
-       result = Builder(
-         builder: (BuildContext context) {
-           return widget.builder!(context, routing);
-         },
-       );
     } else {

(Since the builder would be passed to the Navigator, I am not sure how this could would play out.)
I have simplified the necessary changes strongly, but I think it should demonstrate the points of code that would be touched by this.
With all of these changes, it would then be possible to do the exact same thing as shown in my gist but without the weird hacky Proxy widget.
BottomNavigationBar isnt the only target application for such a change.
Many widgets that passthrough a child but apply various navigation tasks or showing other widgets in the overlay at the very root of the application could be achieved very easily and cleanly. In my own application I have a bunch of Widgets which could benefit from this. For example a widget that redirects based on deeplinks, or a widget that shows overlays based on hovering over a URL or a widget pushing a route based on server status.
I hope this explains the idea @goderbauer

After thinking about it some more, I have come to the conclusion that my example is dangerous and flawed;
Lifting the OverlayState is conceptually okay only as long as we do not add widgets that have an actual size.
A BottomBar that needs access to OverlayState therefore would never work, because it assumes that it is inside of an Overlay and therefore within the boundaries of its Stack and so can place OverlayEntrys on top of itself. This is not the case with a builder wrapped around _Theater.
I dont think it would make sense to introduce such a feature when its possible to easily use it wrongly.
Lifting only the NavigatorState might be acceptable (meaning, our builder parameter is resolved inside of NavigatorState and not passed further down to OverlayState). This would still achieve alot of the things I wanted, namely we could remain only needing one Navigator and we could naivgate via BuildContenxt.
Though it would also mean that if we want an Overlay to be accessible in our wrapper widgets we would have to add an extra one.


Increase and make timeouts configurable

Increase the timeout on patch requests to update module configuration to 5 minutes, as server side validation of changes can take a while.
Make request timeouts globally configurable with --section-api-timeout.

I'm going to merge this PR now, and put up a separate PR that refactors timeouts to use context.Context.

I'm going to merge this PR now, and put up a separate PR that refactors timeouts to use context.Context.