Web GUI binding to Virtual IPs after update

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
I setup HAProxy on a virtual IP on a trusted interface. It ran for some time until I updated to 24.7.5_3-amd64. Now the Web GUI is binding to the virtual IP before HAProxy can.
To Reproduce
Steps to reproduce the behavior:

Leave Web GUI on port 443
Create a Virtual IP on trusted interface
Set HAProxy to bind to that Virtual IP:443

Expected behavior
HAProxy should be able to bind to the Virtual IP as it should be free from the Web GUI.
Describe alternatives you considered
If I move the Web GUI to port 8443 it binds to the trusted interface's IP and the Virtual IP, but at least HAProxy can start.
Screenshots
N/A
Relevant log files
I can't get HAProxy to give me any logs. Not sure why. All I get is a failed to start in the system logs.
Additional context
The trusted interface is a VLAN (150 we'll say) and the virtual IP is in the same subnet so it's on that same interface.
Environment
OPNsense 24.7.5_3-amd64

I'm not sure why it worked before, but using the "Deny service binding" checkbox seems to fix this issue. I misunderstood the help text. Marking as closed.


fix(operator): use Deployment counter in workloadInstance

Signed-off-by: odubajDT<EMAIL_ADDRESS>

closed in favor of https://github.com/keptn/lifecycle-toolkit/pull/434


Hot Reload

Hello,
I see hot reload has recently be added to trame (2.3.0+)
Is hot reload integrated behind the scenes and activated with a passed argument or does the main.py file need to be updated in this cookiecutter?
Thanks

The cookiecutter should definitely be updated to better support hot reload out of the box. (use classes instead of closure)
But in general, hot reload can be activated with just an arg (--hot-reload)

Thanks that works great.
Is there any way to hot reload the HTML/layout?

Yes, you just need to tight the UI definition into a function and have that function being called. We have that "on_server_reload" hook that will had a button in the footer (when using the vuetify UI stuff). But you can make your own "dev reload" button...
You can see an example here.

Got it. thanks again


Fixed spurious CloneException errors in planning stack.

Due to OpenRAVE weirdness, we are forced to throw a CloneException if a robot is cloned from a self-colliding configuration.  We also clone at the beginning of some of our planning operations.
This means that calling a planning method while a robot is in self-collision can create a CloneException, which is generally not expected or handled in code that is calling a planning method.  It is also not clear to calling code that this is actually a failure within a planner, and it breaks MetaPlanner logic.
In this PR, ClonedPlanningMethods will catch CloneExceptions and wrap them as ClonedPlanningErrors instead, which inherit from PlanningError and are thus handled correctly throughout the planning stack as a form of planning failure.

I am concerned that letting meta-planners catch CloneException as a PlanningError will mask deeper issues. All ClonedPlanningMethods will fail if the start configuration is in self-collision. There are only a handful of LockedPlanningMethods, which are all fast heuristic planners, so it is unlikely that any non-trivial planning calls will succeed.
I'd rather fail fast by letting the CloneException bubble up to the user, instead of silently ignoring most of the motion planners in a Sequence. What is the motivation for this change in behavior?

The motivation for this is that no one actually handles CloneException anywhere right now.  It's simply not something you expect to happen when making an opaque planning method call.
If I put the robot into collision, and tell it to plan to another place, I don't expect to have to catch a CloneException to determine that I gave it an invalid starting location.  I expect a PlanningError, because it failed to plan.
Note that the only reason we can get a CloneException right now is a situation in which no planner can succeed.  LockedPlanningMethods are also going to fail.  So I see no reason that we shouldn't be handling it the same way as any other error that makes planning fail.

I see your point. I was missing the obvious (in hindsight) fact that a LockedPlanner would also fail because the robot starts in self-collision. I will merge this once Travis is happy.

@mkoval bump.

Travis is happy. Merging.


license?

Hi. I am starting to learn C programming and found your project while looking for easy simplified examples to learn from. Would you consider adding a permissive license to your project, to allow learning from the code you created, so I (and others) can maybe use similar algorithms to yours in our projects? Your game really looks nice and great to learn from!

Hi LifeCANvs,
Thanks for your interest in my project! I've added an MIT license, so feel free to use and learn from the code. If you have any questions, just let me know. Also, I encourage you to take a look at this repo, which is also a simple game written in C.

Hi. Thank you so much for adding the MIT license, allowing anyone - me and others - to learn from your work, and build upon it!
Also, thanks for your advice and kind offer of further support, I really appreciate it :)


Shouldn't ask to add not existing files to the chat

Issue
Hi,
if it knows that new files must be created than it shouldn't ask to add them to the chat:

Version and model info
Aider: 0.40.0
Model: Claude Sonnet 3.5

Thanks for trying aider and filing this issue.
This doc may be helpful:
https://aider.chat/docs/troubleshooting/edit-errors.html

I would expect Aider to ask to include these files:
Add these files to the chat?
and if I have the --yes option enabled, it will even do it automatically.

Are those files part of your git repo? If you do git ls-files do they show up?

No.
another example from a moment ago

I thought that /add creates a file if it doesn't exist.
But for me something is missing here.
There is a text: I'll wait for your approval to proceed
But there is no any place to put y
but I must admit that he made the format method very nicely because extracted all the data from the Document class, which is not part of the code because it is from the Spring AI package
But this is a completely different story, how to make sure that if something changes in the public library, he will know about it. For example, a new field will be added to the Document class, how will it know about its existence? Do you expect it will be possible to add code from outside the project repository to the repomap?
Aider v0.40.7-dev
Models: openrouter/anthropic/claude-3.5-sonnet with diff edit format, weak model openrouter/anthropic/claude-3-haiku
Git repo: .git with 35 files
Repo-map: using 2028 tokens

Aider only works with the code in your repo. It can't see code outside the repo.

Ok, I understand this.
but what about the problem that the user must accept adding a file but the question about adding a file does not appear?

That was just the LLM talking to you, not aider itself. I think the LLM was a bit confused about the exact way aider works.

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


Fix: Twipsy rollover wasn't centered for SVG elements.

Twipsy was only checking for offsetHeight and offsetWidth to center
the popover. However, SVG elements don't have an offsetHeight or an
offsetWidth. Use getBBox() for their height and width instead.

Unfortunately getBoundingClientRect is buggy in ie when zooming - so i'm not crazy about using this for default calculating size.
That said, in 2.0 i just moved the position calculate to it's own method called getPosition which you can easily override now:
$.fn.twipsy.Constructor.prototype.getPosition = myFunction

Awesome, that override will be great! Thanks for looking at this :-)


Write to a Stream rather than a File, avoid left over temp files

I have cherry-picked from two of @justincbeck’s commits
(https://github.com/justincbeck/simple_xlsx_writer/compare/1cd6b4ba...36c72963) and added a bit to make the tests pass again. Now, when generating the XLSX file, there is no longer any left over temp files in the export folder.
I see (just now) that you have discussed this (“the Jussi Pasenan patch”) in https://github.com/harvesthq/simple_xlsx_writer/issues/2. In the last commit of this pull request, I have changed the implementation so that you pass a String (export path) to Serializer.new, which in turn creates the Tempfile and finally copies the generated file into the mentioned export path.

Closing due to inactivity.


WIP: c-with-prep: comment out patches in the specfile

so that packit can create them and can be used during build
this is a short-term solution, we aim to go towards patch metadata
TODO:

[ ] needs to point to the base commit (e.g. rpm-4.14.2 base)

Long term todo:

we need to apply patches with the patch program b/c git-apply and patch use different algorithm (try c8s of rpm)

this is a short-term solution, we aim to go towards patch metadata

Is it possible to use metadata also in this case and use present_in_specfile=False to indicate that we are commenting on out those? With those information provided, we might be able to uncomment the correct line when going backwards.
Or that was what you want to do later?

the problem is that implementing patch metadata is really tricky b/c it needs to be done on RPM macros level

When building drpm converted by this version I got:
+ cd drpm-0.4.1
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ /usr/bin/cat /builddir/build/SOURCES/0001-drpm-0.4.1-base.patch
+ /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch
The next patch would create the file CMakeLists.txt,
which already exists!  Assume -R? [n]
Apply anyway? [n]
1 out of 1 hunk ignored
The next patch would create the file COPYING,
which already exists!  Assume -R? [n]
Apply anyway? [n]
1 out of 1 hunk ignored
The next patch would create the file LICENSE.BSD,
which already exists!  Assume -R? [n]
Apply anyway? [n]
1 out of 1 hunk ignored
The next patch would create the file doc/CMakeLists.txt,
which already exists!  Assume -R? [n]
Apply anyway? [n]
1 out of 1 hunk ignored

......(some more ignore messages).....

The next patch would create the file test/refseqfile-copy.txt,
which already exists!  Assume -R? [n]
Apply anyway? [n]
1 out of 1 hunk ignored
error: Bad exit status from /var/tmp/rpm-tmp.IjgEUe (%prep)
RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.IjgEUe (%prep)
Child return code was: 1
EXCEPTION: [Error()]
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/mockbuild/trace_decorator.py", line 93, in trace
    result = func(*args, **kw)
  File "/usr/lib/python3.6/site-packages/mockbuild/util.py", line 776, in do_with_status
    raise exception.Error("Command failed: \n # %s\n%s" % (command, output), child.returncode)
mockbuild.exception.Error: Command failed:
 # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/drpm.spec

When building drpm converted by this version I got:
...
The next patch would create the file test/refseqfile-copy.txt,
which already exists!  Assume -R? [n]
Apply anyway? [n]
1 out of 1 hunk ignored
error: Bad exit status from /var/tmp/rpm-tmp.IjgEUe (%prep)

Thank you, I just tried it on "rpm" and sent the PR here. We basically need PACKIT-531 to resolve it (metadata + apply patches in source-git using patch).

When building drpm converted by this version I got:
...
The next patch would create the file test/refseqfile-copy.txt,
which already exists!  Assume -R? [n]
Apply anyway? [n]
1 out of 1 hunk ignored
error: Bad exit status from /var/tmp/rpm-tmp.IjgEUe (%prep)

Thank you, I just tried it on "rpm" and sent the PR here. We basically need PACKIT-531 to resolve it (metadata + apply patches in source-git using patch).

It's happening also on master so I use d1054e6403bbe01d7074b3bcbb4d6cf25a27dfaa now

@dhodovsk yup, exactly the same use case - I had to git reset --hard HEAD^^
I pushed the tagging changes, so this should be good to merge, I am going to create several test cases (real conversions) now and continue working on the patch/git-apply problem.

=== 1 failed, 2 passed in 89.62 seconds ===
The test failure is coming from rpm that the patches cannot be applied.

Merging, feel free to review still


Formant Document With Volar something happens seem wrong!

1、Volar formats an HTML tag with many attributes in as few lines as possible. Look at bellow:

the code left(prettier) looks better, the code right(volar) looks bad.
大白话：左边的看起来更好，右边的看起来有点糟。
2、When enter some enters or spaces, then format with volar, it seems not come into force?

大白话：键入几个enter键，也就是换行，发现这几个换行经过volar的格式化之后，竟然没有去掉？

Duplicate of #1174


The exported Word document cannot be opened on mobile

The exported Word document can be opened on computer,but not mobile

me too

me too

In the mobile browser, the exported BLOB object is empty

在手机浏览器中，导出的 BLOB 对象为空

Is it solved?

i have met the same problem.

Even if generated on computer then transfered to mobile it is still empty word file. Using ios word app.


tools/gopls: document link disable not working

I am using gopls with VSCode and have the following setup in settings:
"go.languageServerExperimentalFeatures": {
    "documentLink": false,
  }

but still I see links to the documents

What version of Go are you using (go version)?

$ go version go1.14.2 darwin/amd64

gopls version information
golang.org/x/tools/gopls 0.4.0
<EMAIL_ADDRESS>h1:G4+YP9kaV4dJb79J5MobyApxX493Qa6VoiTceUmxqik=

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"

What did you do?

What did you expect to see?
I expected the links to be disabled

documentLink refers to the feature that makes links that appear in strings or comments clickable. There is no setting to control the links to the documentation that appear on hover (other than "gopls": { "hoverKind": "NoDocumentation" }, which would remove all documentation as well as the links).

@stamblerre thanks for the response! This release of gopls has been very stable and feature packed 🙌 ! Thanks again to everyone who made this possible!

Glad to hear that it's working for you, @shreyu86! Thank you for the kind words!
I'll leave this issue open to see if we can add another configuration to remove the links on hover.

Sorry for the delay on this, @shreyaskarnik! I just realized we do have that configuration, actually.
Does adding the following your settings.json resolve the issue?
"gopls": {
	"linkTarget": ""
}

Looks like that worked. Closing this issue.

Thanks @stamblerre that worked!


[json-language-features] Fix json/schemaAssociations parameters documentation

The json/schemaAssociations documentation is not accurate in stating
that the only supported parameter is an object in { pattern: uri }
format. It also supports the structure defined by SchemaConfiguration
interface from "vscode-json-languageservice".
Also updated the server code to match that.

This PR fixes #106060

The json/schemaAssociations message is for the associations that come from the jsonValidation contribution point in vscode,
More associations can come the user settings. There you can have the schema.
See the Settings section in the readme.

The json/schemaAssociations message is for the associations that come from the jsonValidation contribution point in vscode,
More associations can come the user settings. There you can have the schema.

What is used in vscode is one thing but I'm talking about what this endpoint supports specifically.
Those are handled at https://github.com/microsoft/vscode-json-languageservice/blob/a5d6dfbfb6032fdfa5901c3e21409581e0d10f0a/src/jsonLanguageService.ts#L75-L75 and so also support schema object.

That's the API of the service (vscode-json-languageservice)
The readme is for the server.
The server listens to the (LSP) configuration and schema association messagse (see here) and then configures the service with the sum of all configurations. (see here)

That's the API of the service (vscode-json-languageservice)

Here is what the server does: https://github.com/microsoft/vscode/blob/183d11a642b121c3023d3f1c9f2470263c1452bc/extensions/json-language-features/server/src/jsonServer.ts#L271
It just passes json/schemaAssociations provided schemas as is to the service. That means the service will handle the schema property if it was provided by the user.
I also know about schemas passed through initialize request but that doesn't change the handling of json/schemaAssociations itself.

Ok I see, that was not intentional.
First we had the map, then (since a few releases) the array. You can see from the map code that we haven;t supported schema.
I want to leave it at that, and will make a code change to not simply copy the array.

I'm not against making that code more explicit but I don't see any reason to limit it to not pass schema property.
It's more consistent if it's supported both from that place and initialize request.
BTW. Also, semi-related, the schemas passed through initialize request require url property while those passed through json/schemaAssociations an uri property. That is inconsistent. It's always a URI really.

Yes, the uri/url inconsistency is unhappy, it has historical reasons. As the url is part of user settings, change it is not trivial and could result in more confusion that clarity.

I added the ISchemaAssociation.schema to the spec, after all. You are right, it's more consistent and makes it easier to configure the LS with schemas.
1b960248d60ae4c1b6af855f675b6749d24e4f31


Add way to upgrade from old forwarder

@democrazyfi we need to unsubscribe from old forwarder and then we need to also do step 3 of the subscription flow when upgrading. otherwise new forwarder wont take effect for incoming assets and the old forwarder address will still have perms


Angularjs explained in brief

Angularjs is mostly suitable if one needs to build a dynamic web applications.Angularjs provides some of the features such as two-way data binding,dependency injection,directives and testing.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Angularjs is mostly suitable if one needs to build a dynamic web applications.Angularjs provides some of the features such as two-way data binding,dependency injection,directives and testing.


Update _base.scss

Edits for sticky footer

@betyonfire the nice thing about using Jekyll is that you can just push sass and markdown changes and the css and html compile automatically for the site. I pulled your changes and it looks like the sticky footer problem is fixed!! Thanks so much. I knew it was something simple but also knew that you could figure it out and fix it faster than I could.


sidecar: functions with isra * are ignored

Use retsnoop -e 'sys_sendto' -a ':net/ipv4/.c' -S -T -l -vv
cat /proc/kallsyms | grep udp_send_skb
ffffffff9e2b5630 t udp_send_skb.isra.49
nm vmlinux | grep udp_send_skb
ffffffff816b45e0 t udp_send_skb.isra.49
GCC has optimized udp_send_skb to udp_send_skb.isra. 49
Cause in DWARF debug information, udp_send_skb inline, so not hook
run log:
Function udp_send_skb.isra. 49 'doesn't match any allow glob, skipping.

Yes, this is a problem and it would be nice to solve this. Do you have a proposal on how to do this?

I'm not familiar with this piece, and I don't know how to solve it for the time being.

yeah, let's keep this issue open. I see in DWARF that for those .isra and .const functions, there is DWARF entry with no DW_AT_inline attribute, but somehow currently sidecar doesn't even encounter them, so they might be outside of requested CU in DWARF or something like that. We'll need to understand this and see how we can use that to our advantage.


Fails to parse typings

import warnings
from typing import Callable, TypeVar, Union, Any, Iterable
from inspect import signature, Parameter
from functools import reduce, partial, wraps
from inspect import getmodule
from logging import getLogger

def curry(_callable: Callable[..., R]) -> Union[R, Callable[..., Any]]:
    """
    Creates a function that accepts arguments of func and either invokes func returning its result,
    if at least arity number of arguments have been provided, or returns a function that accepts
    the remaining func arguments, and so on.
    """

    _signature = signature(_callable)
    required_params = set()

    for name, parameter in _signature.parameters.items():
        if parameter.kind is Parameter.VAR_POSITIONAL:
            raise TypeError('Curry can not be applied on a function with var positional parameters (*args)')
        if parameter.kind is not Parameter.VAR_KEYWORD and parameter.default is Parameter.empty:
            required_params.add(name)

    @wraps(_callable)
    def curried(*args, **kwargs) -> Union[R, Callable[..., Any]]:
        bound = _signature.bind_partial(*args, **kwargs)
        if required_params - set(bound.arguments.keys()):
            return partial(curried, *args, **kwargs)
        return _callable(*args, **kwargs)

    return curried

Fails with:
SyntaxError: Error parsing Python code: Got unexpected token: Colon at Location { row: 8, column: 20 }

Hello @iddan thank you for reporting this issue. This was indeed one of the open issues. I'll take a look at it.

This code can now be parsed, but it does not work, since we lack a warnings, inspect, logging, typing and functools module.

Should this project include pure python libs?

I don't know. There is the ourobouros library, which would be nice to share.

Can this be merged now?

Was the PR merged?

Yes.


Hit the Like button 😄

Is there an existing issue for this?

[X] I have searched the existing issues

I'm submitting a ...

[ ] bug report
[X] feature request
[ ] support request --> Contact me over mail for support https://github.com/MShawon

Description
Maybe it will be a good idea if some workers(maybe 1 out of 10) hit the like button also so we can increase in more ways the engagement rate/growth and prove to youtube that is human act and not a bot.
What do you think? 🤔
Environment
- OS : Windows 11
- Python : EXE without Python
- Script version : 1.7.6

config.json
not required for this.

You need to log into google accounts to be able to like videos (and logged in views are better for the algorithm anyways), and MShawon said in older Issues why he wont implement that. You should use another view bot for this, or write one yourself

Afterwards I realized that you have to be logged in to an account. So i will close this.


default CAP identifier, source and expire offset configuration

default source configuration
offset expiry day configuration
is_template is true for the one derived from alert template

@flavour Please merge this

@flavour Please merge this

I recommend that you explain the urgency rather than repeating your request for merge - although it seems unclear how you would be dependent on a merge?

@flavour thanks for the review...I have applied the suggestions

Also, please always rebase/compress when fixing PRs - thanks!


kenc: bump to 0.0.2

cc @xiang90

v vs no v, is this being read by semver somewhere and leaving it off is required?

That's a good question for @hasbro17, who made the image.

@dghubble no there's no requirement. I can easily update the image tag with the v prefix if that's the required convention here. Let me know if that's preferred.
Since I wasn't too familiar with the "to v or not to v" question, I (kind of arbitrarily) kept the image tag the same as the release tag on GitHub https://github.com/coreos/kenc/releases/tag/0.0.2


Use quay.io/wantedly/locust image

WHY
We created quay.io/wantedly/locust image, instead of Dockerfile contained in this repository.

LG :+1:
waiting for CI


Use Sitecore's new protobuf features in place of packages.

At some point (possibly v10+) Sitecore added ProtoBuf support so that items could be imported into the databases from the filesystem without packages. This plugin should utilize this new feature so that in v10.3.0+, packages no longer are needed to be installed and items are instead deployed through the nuget package as ~/App_Data/items/x.dat files.
https://www.flux-digital.com/blog/creating-custom-items-resources-sitecore-cli-4-0/

Feature finished, currently will only be included in versions 10.3.0+


CIS v2 scan on a hardened cluster fails when v2 charts are dpeloyed

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

On a cluster - CIS 1.5 hardened - Deploy CIS v2, OPA, Logging, monitoring and istio charts

The CIS 1.5 hardened cluster scan when run, shows 2 tests - 5.1.5 and 5.3.2 as failures.

following namespaces break test 5.1.5

kubectl get serviceaccounts --all-namespaces -o json | jq -r '.items[] | select(.metadata.name=="default") | select((.automountServiceAccountToken == null) or (.automountServiceAccountToken == true))' | jq .metadata.namespace
"cattle-gatekeeper-system"
"cattle-logging-system"
"cattle-monitoring-system"
"dashboard-shells"
"default"
"fleet-system"
"istio-system"
"kube-system"

Expected Result:
The charts should comply with hardening steps
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): master-head - commit id: 8fd81a9b4
Installation option (single install/HA): Single node

Logged an issue for fleet here - https://github.com/rancher/fleet/issues/94

On CIS scan, on a downstream cluster with project network isolation activated, the scan fails at 5.3.2:
With error message “Ensure that all Namespaces have Network Policies defined (Scored)”
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): Rancher v2.4.8
Installation option (single install/HA): Install/HA
k8s 1.18.10 on
both upstream and downstream clusters on-prem, RKE.

On add of a network policy “default-allow-all” in all namespaces 5.3.2 it will pass.
But, it will disable project network isolation policies.
CIS scan should pass at this point, as network policies are all in namespaces, because of the Project Network Isolation.

Rancher project network isolation enabled on the downstream cluster.
Leads to network policies being defined in all namespaces:
$ kubectl get networkpolicies -n test-ns
NAME         POD-SELECTOR   AGE
hn-nodes     <none>         373d
np-default   <none>         373d

“np-default” ensures project network isolation, it allows communication with workloads in system project and the own project.
$ kubectl get networkpolicies np-default -o yaml -n test-ns
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  creationTimestamp: "2019-11-11T08:21:23Z"
  generation: 1
  labels:
    cattle.io/creator: norman
    field.cattle.io/projectId: p-zb96b
  name: np-default
  namespace: test-ns
  resourceVersion: "605999"
  selfLink: /apis/networking.k8s.io/v1/namespaces/test-ns/networkpolicies/np-default
  uid: 56cbc761-6ed1-4410-ac13-ce178ab052a5
spec:
  ingress:
  - from:
    - namespaceSelector:
        matchLabels:
          field.cattle.io/projectId: p-zb96b
    - namespaceSelector:
        matchLabels:
          field.cattle.io/projectId: p-qpxm5
  podSelector: {}


Environment Variable CS2_PORT never used

The environment variable CS2_PORT should be used in script entry.sh.
"${STEAMAPPDIR}/game/bin/linuxsteamrt64/cs2" -dedicated -port "${CS2_PORT}" \
...

Worked for me after setting CS2_PORT to another port number.

Good spot! Will get that fixed now.

Good spot! Will get that fixed now.

Thanks for the feed back, @galinette-34. New version has been pushed to Docker Hub.


Design the hero section

add transparent images, use better fonts etc and make the landing page attractive
take references from these and make sure to keep it responsive... if the design is not very good, it'll be rejected

@Luson045  can you please assign this to me

@shibasarkar done, but try to complete it by the end of tomorrow

ok thank you

@Luson045 I have a confusion , can you tell me that I need to fork the repo again or just work on my existing one
?

work on the existing one @shibasarkar and please keep this in mind , please dont submit any basic html css design, make it look a little professional

ok

@Luson045 should I add navbar acordinly hero-section or only modify the hero-section?

@Luson045  is this ok

Looking great but green is not matching with the logo right?@shibasarkar

Yeah better 👍🏻

@Luson045 I think we need to use a single color palate or single framework for style enhancement also the basic HTML structure are not decorated well

@Luson045 can you help me
how do I create new PR

in your local repo copy the changes somewhere in your pc,  delete this pr cancel the changes you made and the fetch the latest code and update it accordingly

@shibasarkar

try to implement this theme

@shibasarkar first complete the redesign of home page..
It's not responsive, the above portion on the text is not coming in Android..
Also the design still don't look very appealing. Work on it.


Decide how to handle restricted, digitised items on wc.org/works

If you look at https://wellcomecollection.org/works/szr9mdzq, you'll see the item is available online with a "View" button, but clicking that button takes you to a 500 "Something unexpected happened" error page.
This is because we've combined the Sierra physical work and the digitised METS work, but the e-bib that links them is suppressed:

If the e-bib is suppressed, then we can't create a IIIF Presentation manifest for this item (in this case, because we can't serve this book online). Hence the error message.
This covers ~2.5k items, and it's a bad experience for users.
We should decide how to handle this properly.
Possible solutions

Unsuppress e-bibs for restricted items. This means we'd be able to create a IIIF Presentation manifest, but users still wouldn't be able to see the images. If they clicked "View", they'd get an error message "You're not allowed to see this item". e.g. https://wellcomecollection.org/works/hjfpwdjs/items
Pros:

People can tell the item is digitised
Opens the door to making restricted digitised items available behind login at some future date

Cons:

Disappointment that you can't see the thing once you click the button

Hide the "View" button on wc.org/works. If the e-bib is suppressed (for whatever reason), we don't link the METS item to the Sierra work, and we don't show the "View" button on the works pages.
Pros:

Nobody will get confused about a missing item

Cons:

It may be less obvious to staff when something is digitised

Jonathan's decision: if an e-bib has been suppressed, we shouldn't be making the METS file associated with it on the site, and the "View" button shouldn't be there.
If the e-bib is suppressed and the item is restricted, that's a different situation we don't currently handle.


Feature Request: Brute Force

I realize that the V2 dose not work with the original EvilCrowRF .ino I tried flashing the https://github.com/joelsernamoreno/EvilCrow-RF/blob/main/EvilCrowRF/EvilCrowRF.ino but web interface will not see anything as far as options. Nothing will work. I just want to know if there will be a brute force option for the V2 like the other one has?

Waiting on a flipper zero. This device is not worth the stress. No Coffey for you.


"native" method to access Data rather than casting

I noticed that the library was casting Data to NSData to access a subrange but there's support for that without having to bridge.
Random note: When I run the tests, the first couple of randomly generates images fetch fine but the rest fails and the tests do not fail because of that. It looks to me like that expectation.fulfill() is called too early

Thank you, really nice enhancement @JanGorman


修改了组管理文档中一些英文释义的错误

修改了deleteAccounts中的address[]和很多接口中address的释义

tips: the commits should use English.

Should I close this pr. then change commits' message to english?

Should I close this pr. then change commits' message to english?

No. you can use git rebase -i master, then reword or fixup, then git push -f xx xx

Should I close this pr. then change commits' message to english?

No. you can use git rebase -i master, then reword or fixup, then git push -f xx xx

I changed


Debugger running will disable full screen toggling with F11

Environment data

VS Code version: 1.30.1
OS and version: Windows_NT x64 10.0.17134
Python version (& distribution if applicable, e.g. Anaconda): 2.7.15

Description
As the title, when the debugger is launched, F11 will not work as expected, while Zen mode(ctrl + k, w) works well,

Hey @ChenghaoZHU, it seems likely that this issue is with VS Code itself and not the extension. We don't control the wider UX of VS Code (we just simply add elements to it).
You may want to open this issue in the VS Code repo.

Hey @ChenghaoZHU, it seems likely that this issue is with VS Code itself and not the extension. We don't control the wider UX of VS Code (we just simply add elements to it).
You may want to open this issue in the VS Code repo.

Got it, thanks for your reply.


Updates README.md plugin list with lasso-clean-css

I've created a clean-css plugin for use with the Lasso.js module bundler, and added a reference to it in the plugin list section of the clean-css documentation in this PR.

:+1: There you go!

Thanks!


binaries?

hi,
Are you planning to distribute binaries? That would help those who are without rust installed on their machine.
It could make those interested easier to check.
Regards,
Tamás

We have Ploutos, our reusable package workflow for Rust projects available to build binaries. They would then be published on our package repository so you can install them as described here.
Would that work for you? We'll aim to get this sorted for the next release.

I came here for the same reason. Adding a reference to this from README, or dropping an INSTALL into the repo that mentions this would solve this issue for me.

hi @AlexanderBand yes, that seems fine.
As long as a deb package is produced it seems all fine to me.


added scripting section

added dyon link
added gluon link
added ketos link

Thank you, that's agood idea.


Implement graph structure

Pull request details
Describe the changes made in this pull request
Creates structures for assets and flows in the graph.
Creates a MetaGraph using those structures.
Stores the basic data from assets and flows in this graph.
The margin was changed from the default (92) to 100 to allow the ternary operators (x ? y : z). Otherwise the formatter will split into an if-else and make the coverage decrease.
List of related issues or pull requests
Closes #106, closes #105, closes #118
Collaboration confirmation
As a contributor I confirm

[x] I read and followed the instructions in README.dev.md
[x] The documentation is up to date with the changes introduced in this Pull Request (or NA)
[x] Tests are passing
[x] Lint is passing

/run-benchmark

/run-benchmark

Hi @datejada, thanks for the review. I plan to create separate PRs.
Wrt to this PR, I made changes to the margin in the JuliaFormatter that affects other files. Do you want me to create a separate PR for that to simplify checking this one? I would prefer, but let me know otherwise.


chore: add jest-watch-typeahead (optional)

The type of this PR is: enhancement
#minor

This PR includes a new dependency - totally up to the repo bosses if we want to merge it or not. It adds jest-watch-typeahead which gives a preview to the jest --watch command when typing a file or test name pattern. It's straightforward to use and i have found it convenient in the past.  Again, no pressure to adopt it if we don't want to.

o nice!


Add Nix build files.

To do:

[x] Add Haskell dev shell dependency to be able to run benchmarks.
[x] Add Hyperfine dev shell dependency for convenient repetition of benchmarks.
[x] Add instructions for running benchmarks with dev shell.

Can the "nix" usage be moved to a separate file, and linked, to avoid 2 semi-identical sections? Can be NIX.md, and linked at the end of the "usage" section.

Sure thing, I'll get on that now.


adding pytest-testrail and related adjustments in corgi ui tests

added pytest-testrail to tests. so I can run auto-tests and define test case ids in testrail to mark tests with results automatically

The circleci error is not related to my fixes: PermissionError: [Errno 13] Permission denied: '/app/report.html'

I kicked the CI to see if the error mentioned above reproduces deterministically and it seems to. I then tried kicking a fresh CI run on master and the error doesn't reproduce there. I'm wondering if the annotation of the test with @pytestrail.case("C624697") could be causing this somehow (though, test_create_new_job_button_is_displayed  is also annotated in a similar way and it doesn't fail)? @m1yag1 - Have you seen something like this before by chance?


Version numbers get added to file names

To break caching, I have version numbers at the end of the css and javascript files:
<link rel="stylesheet" href="css/reset.css?v=1.0">

When saving, this is added to the end of the filename.

Thanks for heads up!
Temporary fix:

Open chrome://extensions/
DevTools Autosave Options
Replace ^file:// with ^file://[^?]+.

Hi, i have the same issue.
I'm working in a ruby / rails environnement and my files get ?body=1. The temporary fix is not working as i use a routes to my local domain (as explained in issue #7).
ENOENT, no such file or directory '***/site.layout.css?body=1'

Could you give me your routes.js, Resource RegExp and "Post to" URL from Options?

'***/site.layout.css?body=1'

*** — is it actual path of you just blacked out the actual path?


PhantomJS 2.0 hangs on specific web site

URL: http://www.barnesandnoble.com/
Tried both on windows and Suse
This happens randomly but the strange this is that even putting onResourceError, onError and onResourceTimeout I get nothing ... no feedback
Any ideas please?

Thank you for submitting this ticket!
This issue tracker primarily serves as the tool to report and track bugs, defects, and development tasks.
For the general question, code review request, build problem, or other related discussion, please post it to either:

the official PhantomJS users mailing-list
Stack Overflow (with phantomjs tag)

If you have not read it yet, please check also a few tips on Effective Q&A.


New .jar release

Hi!
Will you make a new .jar release of the latest version with the amazon billing fix?

Hi @shurikb1,
this Friday

Ok, thanks.


Update SF to 9.0CU3

Description
Hello, this is the update to SF 9.0CU3
https://github.com/microsoft/service-fabric/blob/master/release_notes/Service_Fabric_ReleaseNotes_90CU3.md
Thank you @darinegan

@darinegan Hi!
Did you had some time to review this? It might become critical for us in the oncoming days.
Thank you 😄

@Kassoul / @nicolas-garcia apologies for my delay and thank you for your patience. This PR is approved, merged and pushed to Chocolatey.org; currently pending review.


Unpin python on RTD

Pinning python to 3.5 introduced new problems.
Despite the default python being 3 here and also in our RTD preferences (dashboard->advanced), RTD seems to still use py2 per default...
Anyway, going back to py2 is the easiest for now, I might come back to this when I have more time.

Indeed, I think execfile does not exist on Python 3.
For debugging the doc build on Python 3, I would definitely recommend building locally (i.e., with make html from the docs directory).

For debugging the doc build on Python 3, I would definitely recommend building locally (i.e., with make html from the docs directory).

I did, but my local builds still complete (with many warning but now errors: execfile seems to be simply ignored...).
I'll remove the execfile, but I'm still skeptical that this will work (py3 support is relatively recent in py3)


Register the FLAIR or T2 to the T1w space

Coregister FLAIR and/or T2 into the T1w space, and add this option as derivatives for fmriprep.

Thanks for proposing this. I think it makes sense to do this unconditionally on FLAIR and T2w images.
Some options for registration:

FreeSurfer uses bbregister after surface reconstruction to align T2/FLAIR to the T1.
mri_robust_register has the following example in its documentation:

EXAMPLE 4
	Robust cross modal registration:

	mri_robust_register --mov movT2.mgz --dst dstT1.mgz --satit --iscale
	--mapmov T2_to_T1.mgz --lta T2_to_T1.lta --cost ROBENT --entradius 2
	--entcorrection --weights T2_to_T1_weights.mgz

	Registers a T2 image to T1 using robust entropy with correction mode
	and box radius 2 (= side length of 5 for boxes).
	Look at results with:

	freeview dstT1.mgz T2_to_T1.mgz T2_to_T1_weights.mgz:colormap=heat

ANTs has antsIntermodalityIntrasubject.sh which implements something like this.

I suspect the biggest concern most of the time is going to be changes in neck position throwing off the cost function, which all three of these methods should handle reasonably well. There are also histogram-matching techniques, but those work better on skull-stripped brains, which adds complexity.
I would probably start by, outside of fMRIPrep, giving each of these a try and seeing whether any is obviously better or worse than the others.
Related: poldracklab/fmriprep#474

This sounds good to me! Thanks for listing the potential methods. Since my data set only has T2 but not FLAIR, I am wondering if there is any open sources data set that I can try all three methods with? I assume the comparison is mostly by eye on this step?
Thanks again Chris!

I would check OpenNeuro. If you have datalad, you can search all of it pretty easily:
datalad install -r ///openfmri
find openfmri -name '*FLAIR.nii*'

(I actually just ran it to check, and it looks like ds000221 and ds000244 are good candidates. And a lot have T2w, as well, if you want to try some more datasets.)
And yes, this is basically by eye.

Thanks! I will follow up when I am done with this step.

Hi @wanjiag,
We are collecting both T1w and T2w data for all our fMRI studies. We are using HCP to pre process our data. Recently I started to use fMRIprep to pre process our structural and TASK data.
I found out we don't see T2w outputs after running fMRIprep. I only see T1w outputs like following
sub-500_desc-preproc_T1w.nii.gz
sub-500_from-MNI152NLin2009cAsym_to-T1w_mode-image_xfm.h5
sub-500_from-T1w_to-fsnative_mode-image_xfm.txt
sub-500_from-T1w_to-MNI152NLin2009cAsym_mode-image_xfm.h5
sub-500_space-MNI152NLin2009cAsym_desc-preproc_T1w.nii.gz
Do you thing it's possible to get T2w outputs like T1w's ?
Thank you
Best Regards
Sameera


Revert pull #219 "Workaround: Invalidate cache of the main page on load"

First of all, please read CONTRIBUTING.md

[x] Complete Mattermost Contributor Agreement
[x] Execute npm run prettify to format codes
[x] Write about environment which you tested

Ubuntu Linux

The problem we were hitting should have been resolved on the server side! No workaround needed anymore.
This reverts commit 58dfda760ea933d4708041c0dfe4b50de7b1ea21.
Revert "Fix error handler which showed an error on reload, as the cancel event was triggered after the cacheInvalidated property has been set to true"
This reverts commit 93263aea3a4160b7b0954f5e17e74dce5ba4b42d.
Revert "Workaround for bad cache handling in mattermost platform, fixes #212"
This reverts commit 61bf5344bfac076397a27503ee8153da5c9565fe.

Big thanks @jnugh!
Would someone help test the PR on Windows and OS X?
It would take a little time to test, but this PR would be very important to verify. Any help is much appreciated!
The following steps should cover the test:

Set up a v3.2 or v3.3 Mattermost instance
Download the appropriate desktop version for this PR below:

Windows 64-bit
Windows 32-bit
OS X

Log in to the server created in step 1 and make at least one post to a channel.
Try to use the /away command - you should get an error message below the input box Command with a trigger of 'online' not found
Upgrade the Mattermost instance to v3.4 using the upgrade guide.
 The app should detect that the server version has changed and automatically reload.
Try to use the /away command - your status should be successfully changed to "away" and a system message posted You are now away.

I just saw the test steps. What we didn't think about, is that this reload feature will be part of 3.4.
So when we have a v3.2 or v3.3 Mattermost instance it will not trigger the reload. This will work for an 3.4->3.5->3.6 upgrade.
Didn't think about this :disappointed:.
So this should more be deactivated if server version was >= 3.4 or something...

I'm not sure what is the point of the test. The automated reloading is the feature of Mattermost Server, so it should work regardless of web browsers, including the desktop app. And in the test steps, the app uses v3.2 or v3.3 JS until step 6, so I feel the reloading never works.
By this PR, the app would work well like web browsers in almost case. Do we have to test this carefully now?

Sorry for the confusion here -- both of you are correct.
Since we are reverting #219, I think we're okay taking this without further testing.
I did do a smoke test on the artifact and things seem to work as expected.


feat(next13-zustand-bulma): add storybook

Type of change
Add Storybook.
Summary of change
I just ran npx storybook@next init, the locked the versions in package.json and committed.
Checklist

[x] These changes follow the contributing guidelines
[x] Changes for this new starter kit are being pushed to an integration branch instead of main
[x] All dependencies are version locked
[x] This fix resolves #993
[x] I have verified the fix works and introduces no further errors

I think we should get rid of the default stories folder and assets since that won't be included in the final kit.

Done in 6193c25

Also, what are your thoughts on adding the accessibility addon to this kit? I added it for the next-chakra ui kit and really like it

Sounds great, added in 6193c25


Support groups without password authentication

Presently the chart only supports groups where password authentication is used.
This removes the limitation so that groups can be used with any authentication type. My specific use case is to enable groups with certificate authentication. However, I've also found it beneficial to be able to set groups with no authentication which has been helpful for testing.

This PR has been open awhile and I can see that there are now some conflicts.
However I'd be grateful for a review before taking the time to resolve these? @losipiuk or @mosabua are you able to help here please?

I haven't renamed this value for backwards compatibility. Should this also be renamed?

No, backward compatibility is more important.

Great, I will leave as-is. Is this good to merge?

I think this broke auth.passwordAuthSecret since the  file-authentication-volume never gets created now.

@jkoelker  - Do you have a reproducer config you can share?
With auth.passwordAuthSecret set I've tested that if I have auth.groups and / or auto.passwordAuth then the secret is created and accessible in the coordinator.

@huw0 yep, here's a redacted version from my deployment:
  server:
    config:
      authenticationType: PASSWORD
  auth:
    passwordAuthSecret: trino-password-authentication
  additionalConfigProperties:
    - "internal-communication.shared-secret=shared-secret"
  ingress:
    enabled: true
    annotations:
      traefik.ingress.kubernetes.io/router.entrypoints: websecure
    hosts:
      - host: trino.my.cloud
        paths:
          - path: /
            pathType: Prefix
    tls:
      - secretName: trino-cert
        hosts:
          - trino.my.cloud

Adding the secret mount in will get it to work:
  coordinator:
    secretMounts:
      - name: trino-password-authentication
        secretName: trino-password-authentication
        path: /etc/trino/auth

ok, so I see the issue that setting config.authenticationType to PASSWORD then password-authenticator.properties refers to a password file that does not exist.
However, the password file is not present because no passwords are configured. Therefore, how are you using password authentication?

However, the password file is not present because no passwords are configured. Therefore, how are you using password authentication?

You just create a secret with a key password.db and the content and set the auth type. I personally use a sealed secret, so the contents are not in plain text anywhere other than on the cluster.
I think the fix is to just add Values.auth.passwordAuthSecret to the or condition that guards volume addition on the coordinator.

The fix you've suggested reverts to the previous behaviour and I'd be happy to raise a PR that does this (since this is after all my breakage!)
However this does not seem like an ideal fix?
The passwordAuthSecret sets the name of a secret that is managed by Trino. I'd expect this to be immutable, especially if paired with something like argocd?
Therefore should it not be the case that you maintain a separate secret outside of the trino chart?
In which case a better fix would be to modify password-authenticator.properties within the configmap-coordinator?
Either this should take a configurable path to the password file or when using a custom secret this file should be omitted and instead set through coordinator.additionalConfigFiles?

I'm not sure that's really the intention of passwordAuthSecret, there's no reason it has to be maintained by this chart, and I would advocate that not having the chart maintain it should be the preferred method of setting up password auth, as you can put the password.db in a sealed secret, which then makes it safe(er) to commit to source control, otherwise you end up having the raw password.db, potentially exposing the hashes.
This is the pattern in many other charts that have some sort of auth secret that they end up using, you can either let the chart manage it (like if you're just testing things out), or you can set the secret name where the chart will refer to, so an external service will manage the auth, which is much more suited for real world deployments.
Either way, I think it should just be documented, and if the choice is made that this chart must manage the secret insecurely, it should be strongly reccomended to not use password auth then.

@jkoelker does the fix here solve this for you?

I believe it will as i stated prior that adding the secret to the or condition would work. Do note that the linked commit also introduces a new requirement that the secret contain the group.db, which previously it did not. I would recommend either preserving the current and previous behavior, or introducing a new Values.auth.groupsAuthSecret, which users could set to the same secret if they so chose to have both files managed in the same manor.

Great - raised as #143


Feature(MapSingleObject): Allows to map on a single object instead of collection only

Allows to map on a single object instead of collection only

Coverage remained the same at 100.0% when pulling 1085601a788b4a882fa929fdb5d4e983b1ed4d30 on feature/Map-Single-Object-And-Refactoring into df023b75eb9b00c586d58be7689aaad9c058501d on master.

Coverage remained the same at 100.0% when pulling 1085601a788b4a882fa929fdb5d4e983b1ed4d30 on feature/Map-Single-Object-And-Refactoring into df023b75eb9b00c586d58be7689aaad9c058501d on master.

Coverage remained the same at 100.0% when pulling 1085601a788b4a882fa929fdb5d4e983b1ed4d30 on feature/Map-Single-Object-And-Refactoring into df023b75eb9b00c586d58be7689aaad9c058501d on master.

Coverage remained the same at 100.0% when pulling 086526241dd2ea0d2b67b6e2f12aefb1ff9264ed on feature/Map-Single-Object-And-Refactoring into df023b75eb9b00c586d58be7689aaad9c058501d on master.

Coverage remained the same at 100.0% when pulling 086526241dd2ea0d2b67b6e2f12aefb1ff9264ed on feature/Map-Single-Object-And-Refactoring into df023b75eb9b00c586d58be7689aaad9c058501d on master.

Coverage remained the same at 100.0% when pulling 086526241dd2ea0d2b67b6e2f12aefb1ff9264ed on feature/Map-Single-Object-And-Refactoring into df023b75eb9b00c586d58be7689aaad9c058501d on master.

Coverage remained the same at 100.0% when pulling c9e8231ebbaa4317709dff30e31ad5dc6db5e437 on feature/Map-Single-Object-And-Refactoring into df023b75eb9b00c586d58be7689aaad9c058501d on master.

Coverage remained the same at 100.0% when pulling 4a476a58edeaf2609082b7ce7c6a07814a0132fd on feature/Map-Single-Object-And-Refactoring into df023b75eb9b00c586d58be7689aaad9c058501d on master.

Coverage remained the same at 100.0% when pulling 4a476a58edeaf2609082b7ce7c6a07814a0132fd on feature/Map-Single-Object-And-Refactoring into df023b75eb9b00c586d58be7689aaad9c058501d on master.

Coverage remained the same at 100.0% when pulling 520f5fb6427b874914f414510104882a33e6f985 on feature/Map-Single-Object-And-Refactoring into df023b75eb9b00c586d58be7689aaad9c058501d on master.

Coverage remained the same at 100.0% when pulling 520f5fb6427b874914f414510104882a33e6f985 on feature/Map-Single-Object-And-Refactoring into df023b75eb9b00c586d58be7689aaad9c058501d on master.

Coverage remained the same at 100.0% when pulling 520f5fb6427b874914f414510104882a33e6f985 on feature/Map-Single-Object-And-Refactoring into df023b75eb9b00c586d58be7689aaad9c058501d on master.

@ludovicthomas This PR might interest you. I improved usability as already discussed. Tested with our Falcor implementation, it's fully backward compatible. No need for a review but I won't refuse a pass if you have some time :)

Coverage remained the same at 100.0% when pulling 2499f0c573a7eacd7953f96bf108fc17aca76736 on feature/Map-Single-Object-And-Refactoring into df023b75eb9b00c586d58be7689aaad9c058501d on master.

Coverage remained the same at 100.0% when pulling 2499f0c573a7eacd7953f96bf108fc17aca76736 on feature/Map-Single-Object-And-Refactoring into df023b75eb9b00c586d58be7689aaad9c058501d on master.

A bit late for feedback, but nice work! Thanks for the update.


Error w/ certain queries in Apache Hive

Hi,
I have an Apache Hive connection that throws an error only when I run certain queries. For example, if I run a common SELECT FROM WHERE query, it runs just fine. When I add ORDER BY, I get the following error message:
**Query execution failed
Reason: SQL Error [1] [08S01]: Error while processing statement: FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.mr.MapRedTask**
Any idea why this would be happening? Thanks!

try putting your query in a sub query and then using an order by outside of that.
Also this isn't a dbeaver question its a hive question so you'd find better support on another forum.

There isn't any activity about this ticket very long time. It will be closed. However, if you think that it is actual just let us know.


Restore configurability of traces

Restore configurability that a number of traces had lost:

ChainDB
DnsSubscription
BlockFetchDecision
ForgeState
Forge
Mempool

Add configurability for the BlockchainTime trace (off by default).

the function tracerOnOff has hardcoded "MinimalVerbosity" and is not taking into account the verbosity level as set in the configuration (line 908 of Tracers.hs)
would it be possible to also pass in the TracingVerbosity to this function?

Yes, that deviation of the original, obvious tracerOnOff semantic is very unwelcome.
I think that needs to be fixed, but it's probably out of scope for this PR.
cc @Jimbo4350

bors r+

the function tracerOnOff has hardcoded "MinimalVerbosity" and is not taking into account the verbosity level as set in the configuration (line 908 of Tracers.hs)
would it be possible to also pass in the TracingVerbosity to this function?

Yes, that deviation of the original, obvious tracerOnOff semantic (which used to match its name) is very confusing and counterproductive.
I think that needs to be fixed, but it's probably out of scope for this PR.
cc @Jimbo4350

The current tracerOnOff mechanism will remain as is for now. The recent refactor has made things significantly clearer and we have more refactoring planned for this module.


group empty directories

[ ] group empty directories (compact folders that only contain a single folder into one node in the file tree)

This feature does not exist.
Originally posted by @cseickel in https://github.com/nvim-neo-tree/neo-tree.nvim/issues/211#issuecomment-1079934404

Lol, this sounds so Java.

this would be very nice

I just pushed this to main. It's on by default for the "buffers" source only. To enable it for the "filesystem" source, add this option:
    require("neo-tree").setup({
      filesystem = {
        group_empty_dirs = true,
      }
    })

Thanks for implementing this feature! Not sure why but can we render collapsible directories earlier as well. Please see the demo where directory lua and only subdirectory axie are rendered as nested directories initially, but become lua/axie (expected behaviour) after toggling the neo-tree.
https://user-images.githubusercontent.com/62098008/165684916-08fe787e-c66e-4807-b10e-cb8dc406a0e4.mp4

The problem there is that those folders are being lazy loaded and the grouping only runs on a on the set of folders being loaded in a particular scan, which is just the one level for a lazy load.
I think what I should do is that when a folder is opened that contains nothing but a single sub folder, I should keep loading children until I get to the end of what should be collapsed so I can group the set of dirs in one go.

Ok, this is fixed. I did not end up trying to look ahead and pre-group folders, I feel like that would be a dangerous can of worms I don't want to get into.
It was surprisingly difficult to get this right. What it does now is that as you drill down into a folder that should be grouped, it just adds that extra level onto the current folder.

Thanks for the fix! I think a great part of this feature would be to reduce keystrokes when expanding directories, so having to press <CR> to expand multiple times is not ideal (nvim-tree doesn't have this issue). Totally understand if it'll be too buggy tho!

@axieax But then it will be inconvenient to create a folder/file in the middle level.

But then it will be inconvenient to create a folder/file in the middle level.

Oh that's true, although it shouldn't be too many extra steps with #269. I feel like navigation of nested folders is a more common use case than adding a file/folder within a middle level, especially since once this file/folder is added, group_empty will no longer be needed, so adding future files/folders won't require this much expansion.

Thanks for the fix! I think a great part of this feature would be to reduce keystrokes when expanding directories, so having to press <CR> to expand multiple times is not ideal (nvim-tree doesn't have this issue). Totally understand if it'll be too buggy tho!

I'm mostly concerned with performance issues. Right now I only fetch one level at a time and lazy load everything else. Pre-grouping requires pre-fetching recursively and then I have to deal with those users that have performance issues because they have 10,000 folders in their project, or who knows what other issue affecting their performance.
The deciding factor for me is that I don't actually like the feature for the "filesystem" source myself, so I don't want to do anything risky with it. Someone else could try to take it on and I'd entertain a PR. I mainly did it because I wanted the feature for the "buffers" source which doesn't need any lazy loading at all.

@axieax But then it will be inconvenient to create a folder/file in the middle level.

That could be confusing at first, but you can always input the new file/folder name with ../file.txt and it will work even after the grouping happens.


Fix linting issue from usage of deprecated zipkin variable

Fixing a linting issue from using a deprecated variable from zipkin.
Error: SA1019: zipkin.ZipkinTracingEnabled is deprecated: Use IsTracingEnabled for checking the current state.  (staticcheck)

To check if zipkin tracining is enabled, zipkin.IsTracingEnabled() can be used. During the setup (SetupZipkinTracingFromConfigTracing() -> SetupZipkinTracing()) it is set to true:
https://github.com/knative-sandbox/eventing-kafka-broker/blob/fc17e7686e3fe8d2e071402d5ff6e2aaacf6572a/vendor/knative.dev/pkg/test/zipkin/util.go#L150

/assign @pierDipi @matzew @aliok

/test channel-reconciler-tests-ssl

/test unit-tests
/test upgrade-tests
/test reconciler-tests-namespaced-broker

/retest-required


startup ordering is wrong

Its wrong ordering in README

start nats server
start cmd
run nats cli

not really. at the moment the service only connects to the NATS public demo server, so you can't use your own server yet.
and since I've been running an instance of this service myself, running your own instance is not necessary as long as there's at least one available.


Vacuum delta table based on version numbers

Currently, the vacuum command uses time internal to determine the version history to be retained in the delta table.  But this approach does not work when different rows in a table can version (get changes) at different times.  For e.g. some rows may update daily versus others may update monthly.  When the requirement is to keep x number of history versions for each row then time-internal based history retention is not ideal.  Instead, there should be the capability to retain history based on the number of past versions that get applied to all rows in a table irrespective of the time-interval.

If you have to maintain a fixed number of versions per key/unique-row-id (i.e. fine-grained versioning), then full table (i.e., coarse-grained) versioning is not the right mechanism to use for that purpose. This is because The absolutely traditional way to have fine-grained control on the history of a key/row is to use SCD Type 2 and Type 3 operations. There you explicitly maintain all the historical values


tablet view in not showing sidebar menu please check this issue

@HitenKash
We fixed this issue and released v1.3.0!


yarn start后报错

The build failed because the process exited too early. This probably means the system ran out of memory or someone called kill -9 on the process.

“This probably means the system ran out of memory or someone called kill -9 on the process.”

哦哦，应该是内存不够的原因了，🙇

在自己电脑上构建好，再上传服务器


chore: Fix DEP0148 warning message

ERROR  (node:69269) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at<EMAIL_ADDRESS>Update this package.json to use a subpath pattern like "./*".
(Use node --trace-deprecation ... to show where the warning was created)
Node: v16.11.1
NPM: 8.0.0
It is compatible with Node v12 as this state: https://github.com/postcss/postcss/issues/1455#issuecomment-722502548

Awaiting merge of another pull request about node version: https://github.com/nuxt-community/sanity-module/pull/278


03 has hardwired location

the 3rd hackfest lab has a hardwired location (-l eastus), perhaps make a LOCATION=xxx  similar to the approach used for resource group and cluster name?

For the time being, we are sticking to eastus.


Devstack mounts not quite right

I don't think the way we're mounting paths inside the devstack workload is correct.
Currently, the workload provides the option of mounting a host devstack directory inside the guest.  There are a couple of problems with this.

The mounting doesn't work very well due to #50.  stack.sh fails for me when I try to create a devstack-xenial workload that mounts my host's devstack directory.  I think it fails as the guest cannot write to the devstack directory.
The devstack directory should be local to the guest as it contains guest local settings.

Also, what we should really be sharing is /opt/stack, as far as I can tell.  Doing so would allow users to edit OS code on the host but deploy it in a guest.  At least I hope it would.  Please correct me if I'm wrong.
How about we change things a little bit.

Get rid of the devstack mount.
Always clone devstack and create the local.conf as we currently do.
Then we exit with a message, i.e., we don't actually run stack.sh inside the cloud-init file at all.  Instead we print out a message explaining what do to, e.g.,

devstack initialised with a default local.conf

[[local|localrc]]
HOST_IP=<IP_ADDRESS>
ADMIN_PASSWORD=secret
DATABASE_PASSWORD=$ADMIN_PASSWORD
RABBIT_PASSWORD=$ADMIN_PASSWORD
SERVICE_PASSWORD=$ADMIN_PASSWORD

To start devstack with these defaults type

$ ccloudvm run INSTANCE-NAME "cd devstack && ./stack.sh"

To start with a custom local.conf

$ ccloudvm copy local.conf devstack/local.conf
$ ccloudvm run INSTANCE-NAME "cd devstack && ./stack.sh"

To access horizon point your host's browser at http://<IP_ADDRESS>:55580.
If you're using proxies ensure that <IP_ADDRESS> is in your no_proxy settings.

Of course, there's one problem with the above proposal.  $ ccloudvm copy local.conf devstack/local.conf isn't actually implemented.  This is bug #5.  Should be easy to add though.

@ganeshmaharaj Any thoughts on all this?

Also we could only print out
To access horizon point your host's browser at http://<IP_ADDRESS>:55580.
If you're using proxies ensure that <IP_ADDRESS> is in your no_proxy settings.

If the user is using local IP addresses for the guest VM.

@markdryan the repos inside /opt/stack are populated by devstack's stack.sh and OS users until now expect that to be completely throwaway (in the sense, they never expect to have a copy of repos in their host's /opt/stack). I am sure they can keep a clone on their host if they choose to, but i am not a 100% sure of all the assumptions devstack scripts operate upon which might/might not mess up the contents of /opt/stack. I can check with other users and see if they would have some preference on this.
About the issue of not able to write into the devstack repo, i thought it worked for me, but i can check on my side to see if i hit any other issues. We could also mount the basedir of the devstack repo and that should let us write to devstack folder if that is an issue.

@markdryan after our conversation, maybe best to avoid mounting devstack itself, instead copy the local.conf to devstack and then initiate stack.sh post copy.

Fixed by PR #80


chore: release 1.0.1

:robot: I have created a release *beep* *boop*
1.0.1 (2019-06-26)
Bug Fixes

docs: link to reference docs section on googleapis.dev (#119) (90a009f)

This PR was generated with Release Please.

Release is at https://github.com/googleapis/nodejs-projectify/releases/tag/v1.0.1

The release build has started, the log can be viewed here. :sunflower:

:egg: You hatched a release! The release build finished successfully! :purple_heart:


Fix broken fragment links

Fixes a whole bunch of broken fragment links. These fixes are baseed on new reports from hyperlink, which correctly check fragment links in a new version.
I'll PR an update to the new version when the master branch has fewer errors, since it's a build blocker

The problem is that the link checker in its current form is failing the build on errors, and some errors come from external repositories. So I need to get those externals in line before we can enable the blocking behavior. I think I'm pretty close though

I think I got it now. I'll rebase and fix whatever has been introduced while this branch was alive

Rebase successful. And all links and fragment check are passing :D

I bypassed the problem with the external dependencies linking to the wrong place by adding a sort of redirect map for the fragment links I knew there were problems with. This means those specific wrong links will be fixes as part of the readme processing.
I'm outputting on the console when I fix an actual broken link with that map. In the ideal case we would pick these warnings up and start opening pull requests against the repositories in question so we could get the entire ecosystem in line with correct links

Why this fragment generation broke?

@montogeek there was a regression in hyperlink a while back when I added the switch to only check internal links. That also disabled the fragment checks, even though I thought I had test cases for it. The new version brings them back

@montogeek want to take a look at the code or fine if i merge this? Looks good to me

@Munter Sorry, I don't understand how it is related to these changes in the hashes : from #module-hot-webpack-specific- to #modulehot-webpack-specific.

I think we broke it in the rebuild branch :/

Yeap or another thought i have is that we break it when generate on different dep versions on different systems or node versions

@montogeek 	I'm pretty sure one of the changes we made on the rebuild branch change the way the fragments were generated. And because of the bug in hyperlink we never noticed the regression. Hopefully this should at least be an informed choice going forward, as it would explode with errors if we change the slugification of fragments now


SideQuest is unfree, not MIT

Describe the bug
The SideQuest (version 0.10.11) package is marked as MIT licensed. This is not the case for versions 0.10.5 and above, which are unfree and do not have source code available.
To Reproduce
Steps to reproduce the behavior: N/A
Expected behavior
SideQuest should be marked as unfree. In addition, it may be worthwhile to add a sidequestFree package with 0.10.4.
Screenshots
N/A
Additional context
https://old.reddit.com/r/OculusQuest/comments/gdd9dy/a_sad_update_about_sidequest_we_cannot_remain/
https://github.com/the-expanse/SideQuest/compare/v0.10.4...master
Notify maintainers
@joepie91 @rvolosatovs
Metadata
N/A
Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: sidequest
# a list of nixos modules affected by the problem
module:

relevant: #94946 (by @afreakk), #87225

Things have changed:
New Repo:
https://github.com/SideQuestVR/SideQuest
Announcement to OpenSource:
https://old.reddit.com/r/sidequest/comments/icmxsn/sidequest_update_with_loads_of_new_features_3/
License is MIT again. Probably the issue can be closed?


Fix: iframe video autoplay

Closes #x
Objectif(s)

:tada: This PR is included in version 1.15.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Browser hangs on large files

Should probably utilise a Web Worker to perform the minification in a separate thread.

I've done some experimenting on my own minifier-in-a-browser (https://github.com/tom-sherman/yet-another-js-online-minifier)
Turns out that only some of the freeze up is caused by the minification, the rest is caused by just pasting large amounts of text into an input.
In my version, I solved the freezing issue completely by doing two things:

Offload the minification to a worker. I used terser for minification but should work just as well with uglify.
Use CodeMirror for the input

CodeMirror sidesteps the paste-jank by virtualising all of the code lines and only rendering to the DOM those that are on screen.

Sorry for the late reply. This seems like a great idea. If you'd like to submit a pull request, I'd be happy to merge it.


Segment shapes do not coincide with the wing (resp. fuselage)

This is only an issue as soon as the branch for #392 gets merged. Then, the wing and the fuselage get lofted with globally interpolated guide curves, while the segments get lofted with locally interpolated guide curves. It would be better if the loft of the segments where a subgeometry of the wing (resp. fuselage).

Are there any estimates about when this will be implemented? We just started to support guide curves in our application and this is currently our main issue^^

Just a note on the possible implementation:
The sections that are interpolated cut the fuselage surface at iso lines. Thus, you just have to trim the fuselage surface at the correct iso parameters to get the segment surface.

To Do

[ ] move static function curvesToSurface from CTiglBSplineAlgorithms to separate class CTiglCurvesToSurface
[ ] Implement CTiglMakeLoft::makeLoftWithoutGuides() using CTiglCurvesToSurface rather than BRepOffsetAPI_ThruSections
[ ] Abstract makeLoft... functions of CTiglMakeLoft, so that the b-splines parameters at the profiles (and guides) are provided, regardless of the algorithm ("without guides" vs." Coons Patches" vs. "Gordon surfaces").
[ ] cut the lofts at the profile parameters to obtain the segment lofts of a wing resp. fuselage


Register 7, 8, 9

Hi
In SM these registers are configurable. I don't have any heater to force it -maybe something must be also set in config to be working ;)
Can you try look what happens when you "force DHW heating" or "fast DHW" in Smart Home mobile app -this option enables electrical heater in DHW and it changes Register 7 value from 0 to 1, but in my case after few seconds it is disabled.
In Modbus register description in York there is info that 0 is invalid, 1 = Forced On, and 2 = Forced Off... but from mobile Smart Home App values are 0 or 1 and never have 2.
If moved this (and also register 8 and 9) to switch than the code looks like this (and we can ignore off value in this check except write_lambda -but it can be assumed as 0 means off not value 2):
  # Register: 7
  - platform: modbus_controller
    modbus_controller_id: "${devicename}"
    name: "Forced Water Tank Heater On/Off"
    id: "${devicename}_forced_water_tank_heating_on_off"
    icon: mdi:fire-alert
    address: 0x7
    register_type: holding
    entity_category: config
    lambda: "return x == 1;"
    on_turn_on:
      then:
        - lambda: |-
            uint16_t value = 1;
            ESP_LOGI("Register 7", "Set forced water tank Heater ON");
            esphome::modbus_controller::ModbusCommandItem set_payload_command = esphome::modbus_controller::ModbusCommandItem::create_write_single_command(${devicename}, 0x7, value);
            ${devicename}->queue_command(set_payload_command);
    on_turn_off:
      then:
        - lambda: |-
            uint16_t value = 0;     // Documentation says 2 but values from phone app makes 0 (according to documentation its invalid, but documentation can be wrong...)
            ESP_LOGI("Register 7", "Set forced water tank Heater OFF");
            esphome::modbus_controller::ModbusCommandItem set_payload_command = esphome::modbus_controller::ModbusCommandItem::create_write_single_command(${devicename}, 0x7, value);
            ${devicename}->queue_command(set_payload_command);

I do not have the app (Airwell has an issue at their side an say they are working on it) and also do not have a electrical heating element for DHW. So I am afraid that I am not able to test it right now

So maybe wait to confirm by others before implemented it ;) -I left decision for you ;) if yes I prepare pull req. ;), No we wait ;)

I've tested today this. After enabling in heatpump controller (unfortunetly this is only available on heatpump itself -not via modbus -for officially registers) than after switch on Forced Water Tank Heating and Forced Tank Buffer Heater working as expected, also when this is set by Mobile app smart home these values are set and don't revert after few seconds and on original controller there also icon showing that heater is enabled.
So only available testing is enable TBH / IBH on original controller service menu. Without that after setting value few moments later it is reverted.
To disable it is needed to send value 2 to this register, but when register is read and function is off then read value is 0 ;) (sending 0 to turn off doesn't work).
So I thiunk we can make this update ;)
PS. for parameters 210 I see in york sm that bits 6, 8 and 14 could be read/only...  -but I'm not sure -so i think we wait to see if time shows true ;)

Add pull request for setting Forced Electrical Heater for these Registers: 7, 8, 9 ? or we wait to future request from users?
For tests it must be enabled on wired controller that installation is equipped with electrical heater, after that on wired controller there icons for electrical heater are displayed, and can be set, also on mobile app this button Force Water Heating changes this value -Force Water Heating means "turn on electrical heater".
it's a pity that the manufacturer did not provide for forced heating of the DHW, omitting the dT5s without electric heaters to heat the DHW water;)

This is an interesting topic as I'd like to control with Home Assistant when the internal backup heater is turned on and off. I played around with setting register 9 according to your example and seems to work with a few restrictions.
The first thing I noticed is I need to enable the "master" DHW switch although I don't have DHW by the heatpump. In some online manual I found the following passage: "If AUTO mode is on for room heating or cooling, the BACKUP HEATER cannot be selected
The BACKUP HEATER function is invalid if only ROOM HEATING MODE is enabled". I think that means you need to have both ROOM + DHW modes activated. Otherwise I cannot force backup heater on via the menu, I cannot change the menu entry from OFF to ON when DHW is disabled. I mean the following menu setting:

The second thing I noticed is that after forcing the IBH off by sending value 2, there is a cooldown of 5 minutes until you can force it on again. (You can send value 1 immediately and the register will save it, but the relais only clicks after 5 minutes)

Yeah this is a bit of a difficult one. That logic that happens is, of course, implemented in the heatpump self and the goal of this ESPHome config is not to replace the logic in the heatpump, but to be an addition to it.
That is for example the main reason why I think that automations should not be implemented in this ESPHome config, but should be done for example in Home Assistant if a user wants that.

the one for register 9 is interesting here.
personally I don't use IBH, it's disabled by the mentioned dip-switch in the screenshot above.
but AHS is enabled, and I think the same logic could/should be applied here.
However I want to disable AHS outside the boundaries of the ranch.
number.heatpump_ambient_temperature_trigger_for_ahs
number.heatpump_ambient_temperature_for_enabling_hydraulic_module_auxiliary_electric_heating_ibh

both have a range from -15 to 10. (I think both default to -5, this is a question in the yaml)
But according to the manual my heatpump should be able to produce enough heat at -25, therefor -15 doesn't make any sense.
I actually only want to rely on, I think,
number.heatpump_temperature_return_difference_for_enabling_the_hydraulic_module_auxiliary_ibh
which I prefer to set to 10
So it might would make sense to be able to turn it off, once turned on. I know the logic should be done by the controller, but those settings are actually limited.

the one for register 9 is interesting here. personally I don't use IBH, it's disabled by the mentioned dip-switch in the screenshot above. but AHS is enabled, and I think the same logic could/should be applied here.
However I want to disable AHS outside the boundaries of the ranch.
number.heatpump_ambient_temperature_trigger_for_ahs
number.heatpump_ambient_temperature_for_enabling_hydraulic_module_auxiliary_electric_heating_ibh

both have a range from -15 to 10. (I think both default to -5, this is a question in the yaml) But according to the manual my heatpump should be able to produce enough heat at -25, therefor -15 doesn't make any sense.
I actually only want to rely on, I think, number.heatpump_temperature_return_difference_for_enabling_the_hydraulic_module_auxiliary_ibh which I prefer to set to 10
So it might would make sense to be able to turn it off, once turned on. I know the logic should be done by the controller, but those settings are actually limited.

OK.
I've checked in my manual for YORK Monoblock 9kW
Register 237: T4_AHS_o (umber.heatpump_ambient_temperature_trigger_for_ahs) default -5, min: -5 max: 30 -so only max is higher
Register 233: t4_ibh_on (heatpump_ambient_temperature_for_enabling_hydraulic_module_auxiliary_electric_heating_ibh) default, min, max same as Register 237.
So this min value could be manufacturer depended value...
I think -15 isn't bad value -heatpump efficiency drops a lot in that temp.
Personaly I don't use AHS nor IBH. My heatpump is directly connected to minibuffer (only 100l) and also i've connected Electric Heater in buffer, Gas boiler and coal-wood stove. And own logic for control. HeatPump is only on Heat or cool manual set.


Can't generate a DID with gaiax onboard and existing key

Can't generate a DID with gaiax onboard and existing key
root@walt-id-ssi-kit:/app# bin/waltid-ssikit gaiax onboard
walt.id SSI Kit 1.SNAPSHOT (running on Java 19.0.2+7)

> Gaia-X onboarding wizard:

>> Loading services...
>> Key generation
>>> Enter RSA key file to import or "generate" to create a new key [generate]: certs/privkey.pem
Importing RSA key from: certs/privkey.pem
File exists: true, is file: true
lateinit property pubKey has not been initialized

lateinit property pubKey has not been initialized

I'm using waltid/ssikit:latest on docker.
privkey.pem is a plain text base64 lets encrypt key generated with certbot.

$ cat privkey.pem
-----BEGIN PRIVATE KEY-----
...
-----END PRIVATE KEY-----

$ export KEY=$(cat privkey.pem)

$ curl --location "http://localhost:7000/v1/key/import" --header 'Content-Type: text/plain' --data "${KEY}"
{
    "details": [],
    "status": 500,
    "title": "lateinit property pubKey has not been initialized",
    "type": null
}


System.ComponentModel.Win32Exception in PackageExplorer\MefServices\UIServices.cs:266

Error in NuGet Package Explorer
System.ComponentModel.Win32Exception in PackageExplorer\MefServices\UIServices.cs:266
The network path was not found.
View on Bugsnag
Stacktrace
PackageExplorer\MefServices\UIServices.cs:266 - PackageExplorer.UIServices.OpenFolderDialog(string title, string initialPath, out string selectedPath)
PackageViewModel\PackageViewModel.cs:839 - PackageExplorerViewModel.PackageViewModel.ExportExecute()
PackageViewModel\Commands\RelayCommand.cs:133 - PackageExplorerViewModel.RelayCommand.Execute(object parameter)
:0 - PackageExplorer.App.Main()

View full stacktrace
Created automatically via Bugsnag

An error linked to this issue has been marked as fixed in Bugsnag
System.ComponentModel.Win32Exception in PackageExplorer\MefServices\UIServices.cs:266


feat: adding hadoopfs sample

This sample submits a Hadoop FS command to a Dataproc cluster (-ls, -du, etc.)

This might be blocked by: https://github.com/GoogleCloudPlatform/java-docs-samples/issues/294

Also, PTAL at compilation errors https://source.cloud.google.com/results/invocations/a9a7e2a9-3dc4-4fd8-9c19-a263c0258db0/targets/cloud-devrel%2Fjava%2Fjava-docs-samples%2Fjava8%2Fpresubmit/log

Ping

The compilation error will exist until https://github.com/googleapis/java-cloud-bom/issues/626 is resolved and an update to the libraries bom is released.

Well, this is still broken in many ways - please also fix your exception handling.
https://google.github.io/styleguide/javaguide.html#s6.2-caught-exceptions

What's the status on this?

The required BOM update has been released.

This passes tests, but has some lint issues.

#
# dataproc
#

[ERROR] src/main/java/CreateClusterWithAutoscaling.java:[16] (sizes) LineLength: Line is longer than 100 characters (found 115).
[ERROR] src/main/java/CreateClusterWithAutoscaling.java:[40,36] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - com.google.cloud.dataproc.v1.*.
[ERROR] src/main/java/CreateClusterWithAutoscaling.java:[43,1] (imports) CustomImportOrder: Extra separation in import group before 'java.io.IOException'
[ERROR] src/main/java/CreateClusterWithAutoscaling.java:[119,14] (naming) AbbreviationAsWordInName: Abbreviation in name 'autoscalingPolicyURI' must contain no more than '2' consecutive capital letters.
[ERROR] src/main/java/SubmitHadoopFSJob.java:[19,36] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - com.google.cloud.dataproc.v1.*.
[ERROR] src/main/java/SubmitHadoopFSJob.java:[24,1] (imports) CustomImportOrder: Extra separation in import group before 'java.io.IOException'
[ERROR] src/main/java/SubmitHadoopFSJob.java:[31,14] (naming) AbbreviationAsWordInName: Abbreviation in name 'SubmitHadoopFSJob' must contain no more than '2' consecutive capital letters.
[ERROR] src/main/java/SubmitHadoopFSJob.java:[37,22] (naming) AbbreviationAsWordInName: Abbreviation in name 'submitHadoopFSQuery' must contain no more than '2' consecutive capital letters.
[ERROR] src/main/java/SubmitHadoopFSJob.java:[42,12] (naming) AbbreviationAsWordInName: Abbreviation in name 'hadoopFSQuery' must contain no more than '2' consecutive capital letters.
[ERROR] src/main/java/SubmitHadoopFSJob.java:[46,22] (naming) AbbreviationAsWordInName: Abbreviation in name 'submitHadoopFSJob' must contain no more than '2' consecutive capital letters.
[ERROR] src/main/java/SubmitHadoopFSJob.java:[47,67] (naming) AbbreviationAsWordInName: Abbreviation in name 'hadoopFSQuery' must contain no more than '2' consecutive capital letters.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[18,36] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - com.google.cloud.dataproc.v1.*.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[28,1] (imports) CustomImportOrder: Extra separation in import group before 'java.io.ByteArrayOutputStream'
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[28,1] (imports) CustomImportOrder: Wrong lexicographical order for 'java.io.ByteArrayOutputStream' import. Should be before 'org.junit.runners.JUnit4'.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[29,1] (imports) CustomImportOrder: Wrong lexicographical order for 'java.io.IOException' import. Should be before 'org.junit.runners.JUnit4'.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[30,1] (imports) CustomImportOrder: Wrong lexicographical order for 'java.io.PrintStream' import. Should be before 'org.junit.runners.JUnit4'.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[31,1] (imports) CustomImportOrder: Wrong lexicographical order for 'java.util.UUID' import. Should be before 'org.junit.runners.JUnit4'.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[32,1] (imports) CustomImportOrder: Wrong lexicographical order for 'java.util.concurrent.ExecutionException' import. Should be before 'org.junit.runners.JUnit4'.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[34,1] (imports) CustomImportOrder: Import statement for 'junit.framework.TestCase.assertNotNull' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[35,1] (imports) CustomImportOrder: Import statement for 'org.hamcrest.MatcherAssert.assertThat' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[38,14] (naming) AbbreviationAsWordInName: Abbreviation in name 'SubmitHadoopFSJobTest' must contain no more than '2' consecutive capital letters.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[40] (indentation) Indentation: 'member def modifier' has incorrect indentation level 4, expected level should be 2.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[42] (indentation) Indentation: 'member def modifier' has incorrect indentation level 4, expected level should be 2.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[43] (indentation) Indentation: 'member def modifier' has incorrect indentation level 4, expected level should be 2.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[44] (indentation) Indentation: 'member def modifier' has incorrect indentation level 4, expected level should be 2.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[45] (indentation) Indentation: 'member def modifier' has incorrect indentation level 4, expected level should be 2.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[47] (indentation) Indentation: 'member def modifier' has incorrect indentation level 4, expected level should be 2.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[49] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[50] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[51] (sizes) LineLength: Line is longer than 100 characters (found 104).
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[53] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[55] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[57] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[58] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[59] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[61] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[63] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[64] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[66] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[69] (indentation) Indentation: 'try' has incorrect indentation level 8, expected level should be 4.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[72] (indentation) Indentation: 'try' child has incorrect indentation level 12, expected level should be 6.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[73] (indentation) Indentation: 'try' child has incorrect indentation level 12, expected level should be 6.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[75] (indentation) Indentation: 'try' child has incorrect indentation level 12, expected level should be 6.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[76] (indentation) Indentation: 'try rcurly' has incorrect indentation level 8, expected level should be 4.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[77] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[80] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[81,17] (naming) AbbreviationAsWordInName: Abbreviation in name 'submitHadoopFSJobTest' must contain no more than '2' consecutive capital letters.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[82] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[83] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[85] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[86] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[88] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[91] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[94] (indentation) Indentation: 'try' has incorrect indentation level 8, expected level should be 4.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[96] (indentation) Indentation: 'try' child has incorrect indentation level 12, expected level should be 6.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[98] (indentation) Indentation: 'try' child has incorrect indentation level 12, expected level should be 6.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[99] (indentation) Indentation: 'try rcurly' has incorrect indentation level 8, expected level should be 4.
[ERROR] src/test/java/SubmitHadoopFSJobTest.java:[100] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
[ERROR] src/test/java/CreateClusterWithAutoscalingTest.java:[21,36] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - com.google.cloud.dataproc.v1.*.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check (default-cli) on project dataproc: You have 59 Checkstyle violations. -> [Help 1]

That might be too many files to review - by a long shot.

Why don't you start a new PR?


stepper motor minpulse width

Hello.
I'm making an OAT.
The firmware is up to date on the MKS Gen L V2.1 board.
I'm going to use the motor as the Close loop motor I had.
It works with the same input as A4988.
So I tested it, but it didn't move, so I checked it.
Result. Minimum pulse width is too small to be recognized.
I tried to modify the source, but I don't know where to modify it.
Thank you for your help.

We use libraries to drive the steppers. AccelStepper is a widespread library and I would be surprised if this is a problem. Did you #define NEW_STEPPER_LIB or not?


[Exposure Request] Table 38 "Purchase Header" - RecreateTempPurchLines

Please make function RecreateTempPurchLines in table 38 "Purchase Header" externally available.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 42916.


[Improve Scroll] Detect end of page

When velocity tries to scroll to an element, and the page is not long enough for the element to reach the top of the page, the scroll abruptly stops when the page reaches the end, in practice discarding the final easing. Example: http://jsbin.com/xopiyeweto/1/edit?html,css,js,console,output
The proposal is for velocity to detect when the page is not long enough, and in those cases adjust the scrolling amount so that the end of the animation matches the end of the page reaching the bottom of the screen.

The issue with scrolling down is that you might be loading more content as it scrolls - with scrolling up you already know that it can get as far as 0 and no further.
Not sure if this wants an optional bounds check (default on), or if it should be totally left up to the user.
Anyway, using bounding box, check target.bottom against container.bottom and container.height and then fiddle the numbers...

I would say the cases where extra content is loaded are fewer than the cases where you want to scroll to an element on a normal page which might be at the end. The idea is that this case is covered by default, as a general rule.

Content changing length is probably more of a situation for progress callbacks to change - will think about this a bit more, but seems like a good plan for v2 :-)

For version 2 scrollTop and scrollLeft will be properties, and will use units including % which will take into account the visible height and the total height (so 0% is top to the top, and 100% is bottom to the bottom).

You can supply a % to scrollTop as well as a simply px value, which lets it animate to the correct pixel value semi-automatically.


[1.4.x] backport #6114, #6125, #6128, #6129, #6130

Instead of opening individual backport commits for #6114, #6125, #6128, #6129, #6130, this commit merges all of them.

When I backport, I normally chery-pick individual commits inside a pull request like https://github.com/sbt/sbt/pull/6114/commits/f3b3148c5898d13593cc0531fd618346ad38731d.
Is using merge-commit an alternative technique?

I don’t think it makes a big difference but it’s less labor to do git cherry-pick -m1 $MERGE_COMMIT. It’s also easier to find which commit to cherry-pick because you can search the git log for the original pr number rather than a commit hash.

Cool. That's a TIL for me! I think it's a good tradeoff since manual cherry picking is labor intensive and error prone. I don't care so much about the history on 1.4.x.. I guess the only thing I'd miss would be the calculation of contributor.


Add Forgot Password

I want to add forgot password so that if the user didnt remember the password he will get a link to containing to token to reset the password

@17arindam I'll reopen this issue after Auth is developed


Add /order endpoint similar to SOR but returns a transaction

Add /order endpoint + lambda. This takes a SorRequest and returns a SorOrderResponse which is a transaction (to + data + value) the user can immediately post to chain.
The benefit of this is we can return a batchSwap or relayer transaction the user can immediately post to chain without needing to know how to assemble it themselves from the SOR return data.
This will allow Cowswap to handle join/exit swaps with Balancer without having to re-code their solver to convert a SOR response to different transaction types.
Todo:

[x] Full testing with dev account
[x] Add more unit tests
[x] Add E2E tests

Added E2E tests for orders and they are working correctly.

Added ability to specify slipapge and a different recipient for your order.