Update finagle-core, util-core to 20.8.0

Updates

com.twitter:finagle-core
com.twitter:util-core

from 20.7.0 to 20.8.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.twitter" } ]

labels: library-update, semver-minor

Codecov Report

Merging #252 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   91.35%   91.35%
=======================================
  Files           9        9
  Lines         162      162
  Branches        5        3    -2
=======================================
  Hits          148      148
  Misses         14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 992f755...46a3e1c. Read the comment docs.


Modify TFRecords for Stage 2

Allow multiple instances of the same image to be stored in TFRecords so that we can sample the 64 by 64 image at the same time as the 256 by 256 image

Merged in #34


visibility issues after #12337

After picking up #12337, I can't get our visibility overrides going.
For context, we don't have Envoy as a git submodule and instead it we fetch it via bazel as a tarball using http_archive.
Doing something like:
ADDITIONAL_VISIBILITY = [
  '@foo//pinterest:__subpackages__'
]

in our extensions_build_config.bzl fails with:
ERROR: /private/var/tmp/_bazel_rgs/6fea2029bf5452e6659bcb3f721f95cc/external/envoy/BUILD:18:14: invalid package name '@foo//pinterest:__subpackages__': must start with '//'

cc: @lizan @alyssawilk

In case it wasn't clear from the initial description, I am trying to get our filters to see core extensions, e.g.:
/Users/rgs/code/envoy-pinterest/pinterest/filters/http/copy_header/BUILD:10:17:
in cc_library rule //pinterest/filters/http/copy_header:copy_header_lib: Target
'//pinterest/filters/http/copy_header:copy_header_lib' violates visibility of target
'@envoy//source/extensions/filters/http/common:pass_through_filter_lib'.

I'll look into this later today. With some workable solution in envoy-filter-example.
In general ``//source/extensions/filters/http/common:pass_through_filter_lib` should be public though.

If we can't figure out a solution by EOD, we could merge #12451 to workaround this in the meanwhile.

We still need to make the pass through filter public visible, will send a PR shortly.

Regardless of the fix here we definitely want the pass through filter to be public I'd think (see #12463).


Demo app fails to build --prod with UglifyJs error

Bug Report or Feature Request (mark with an x)
- [ x ] bug report -> please search issues before submitting
- [ ] feature request

OS and Version?

Node / Npm or Yarn Version
macOS Sierra
Output from: node --version= v6.11.1,
Output from: yo --version = 2.0.0
Output from: yarn --version = 0.27.5
Targeted Angular version
4.x.x
Repro steps.
Generate a new library go to the demo and run ng build --prod
The log given by the failure.
ERROR in main.dd7e42304148e7406ffc.bundle.js from UglifyJs
Unexpected token: name (LibComponent) [main.dd7e42304148e7406ffc.bundle.js:18445,6]

Desired functionality.
It should build.
Mention any other details that might be useful.
This error appears mentioned in quite a few places on Github. Note https://github.com/webpack/webpack/issues/2972 which would suggest that at compile angular-cli / webpack is using my-ngx-library.js and not the umd bundle.
This really is a great fully featured generator and really needed, but this is blocking me. Every library module I have created with the generator suffers from this. I am not sure what the problem is atm.

I think it maybe related to the module being linked https://github.com/babel/babel-loader/issues/149

Actually it doesn't seem to be that.
I have pushed the templated generated library to here https://github.com/justingrayston/generated-ngx-library-test and also created a distribution repo here https://github.com/justingrayston/generated-ngx-library-test-dist
If I make sure the package isn't linked, and yarn add git+https://github.com/justingrayston/generated-ngx-library-test-dist.git the package is added and you can see in node_modules. It still fails to build with the --prod flag.

Hi @justingrayston,
Thanks for reporting this issue 👍 , and for your investigations.
There was a bug in distributed package.json of built library when targetting Angular >=4: the es2015version of the JS bundle was referred to under "module" instead of the es5 one.
I've just released v3.1.0 with that fix (among others)
To get rid of the error in your existing libraries,  simply:

re-rerun the generator once updated or manually edit the gulpfile.jsas show in fd0d366dc8c370c7ac12fa8ea2b9f139e59ffc49
-re-build or re-publish your library, it should correctly set the module to use in package.json

Enjoy!

Thanks Tine!
On Sat, 12 Aug 2017, 16:45 Tine Kondo<EMAIL_ADDRESS>wrote:

Hi @justingrayston https://github.com/justingrayston,
Thanks for reporting this issue 👍 , and for your investigations.
There was a bug in distributed package.json of built library when
targetting Angular >=4: the es2015version of the JS bundle was referred
to under "module" instead of the es5 one.
I've just released v3.1.0
https://github.com/tinesoft/generator-ngx-library/releases/tag/v3.1.0
with that fix (among others)
To get rid of the error in your existing libraries, simply:

re-rerun the generator once updated or manually edit the gulpfile.jsas
show in fd0d366
https://github.com/tinesoft/generator-ngx-library/commit/fd0d366dc8c370c7ac12fa8ea2b9f139e59ffc49
-re-build or re-publish your library, it should correctly set the
module to use in package.json

Enjoy!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tinesoft/generator-ngx-library/issues/65#issuecomment-321988964,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFCHMCAE2QUZ6VTb2YJLcRerLanrfr23ks5sXciIgaJpZM4OzZoo
.


Laravel 5.4 Shift

This pull request includes the changes for upgrading to Laravel 5.4. Feel free to commit any additional changes to the shift-3762 branch.
Before merging, you should:

Checkout the shift-3762 branch
Review all pull request comments for additional changes
Run composer update (if the pre-commands fail, add --no-scripts)
Thoroughly test your application

If you would like more help with your upgrade, check out the human services from Laravel Shift. And if you want to level-up your Git skills, check out Getting Git.

ℹ Laravel 5.4 added new middleware to handle whitespace in request data. This may affect the data your application received. Read this post on Laravel News for more detail to see if you need to modify your application.

❌ Shift could not upgrade the following project files since they differed from the default Laravel version. You will need to compare these project files against the default Laravel 5.4 versions and merge any changes:

[ ] resources/assets/js/bootstrap.js

⚠ Laravel 5.4's testing layer has been re-written. Instead of upgrading your tests, Shift installed the Laravel BrowserKit Testing package. This will allow you to test the Laravel 5.4 upgrade with your existing tests.
Once you have verified the upgrade, you can use the Laravel 5.4 Tests Shift to upgrade your tests to the new Laravel 5.4 testing layer.

❌ Support for later, send, and queue on the Mail facade has changed in Laravel 5.4. You should update your project to use Mailables.
Shift found potential uses of these methods in:

[ ] app/Basket/Notifications/EmailLocationNotificationService.php
[ ] app/Basket/Email/EmailApplicationService.php

❌ The container's make method no longer accepts a second parameter in Laravel 5.4. This typically indicates a code smell and you should construct the object in another way.
Found potential uses of the second parameter in:

[ ] app/Http/Controllers/SettlementsController.php
[ ] app/Http/Middleware/Download.php

❌ Shift could not upgrade the following configuration files since they differed from the default Laravel version. You will need to compare these configuration files against the Laravel 5.4 configuration files and merge any changes:

[ ] config/database.php
[ ] config/mail.php

ℹ In Laravel 5.4, the date cast creates a Carbon object which calls startOfDay. If you need to preserve the time portion of the date, you should use the datetime cast or convert your column to a datetime. Review the documentation on Attribute Casting for more details.

ℹ Laravel 5.4 no longer includes the ability to customize the PDO "fetch style". Now PDO::FETCH_OBJ is always used. If you need to customize the fetch style, check the Database section of the Upgrade Guide for more details.

❌ Shift found a dependency for Guzzle. Laravel 5.4 requires Guzzle 6.0 or higher. Please ensure your version meets this requirement.

⚠ Per the Upgrade Guide, you should run php artisan view:clear and php artisan route:clear after upgrading all packages to flush the view and route cache.

ℹ If you are running MySQL prior to version 5.7.7, you may receive a specified key was too long error. You can either upgrade your MySQL or review this post for code to resolve this issue.

❌ Shift detected the Forms and HTML package by the Laravel Collective. The recommended version is 5.4.* for Laravel 5.4. You should review your laravelcollective/html dependency to ensure it is compatible. Review the Installation Docs for more details.

ℹ If you have manually upgraded your app from previous versions of Laravel, you should run the Laravel Linter to ensure your app is fully upgraded to the latest version of Laravel.

When synchronising a merchant, an error is pushed to the log:
[ ] local.ERROR: InstallationSynchronisationService failed Non existing class [] []


Enhancements to testsuite error output.

This includes several changes to the testsuite error reporting in theory to help make it easier to see differences when the test output changes. The key change is to add a Myers diff with a little colored output to highlight the differences. Here is an example:

The rest of the changes here are various refactorings to try to clean up the diffing code.  It ended up being far more changes than I was intending, but I did try to split things into commits to separate them.

r? @alexcrichton
(rust-highfive has picked a reviewer for you, use r? to override)

Nah this is great, thanks!
FWIW I tend to not review changes to the test suite too too closely so I haven't exactly taken a super close look at this. Most of this is already exercised during the test suite itself and we can of course fix issues as they arise though!
@bors: r+

:pushpin: Commit 16b5402fd7f22bfaec73ba9063fc63a4fbf3b370 has been approved by alexcrichton

:hourglass: Testing commit 16b5402fd7f22bfaec73ba9063fc63a4fbf3b370 with merge 40df0f17b504fc036f5d4619a5071bb14abd602b...

:sunny: Test successful - checks-actions
Approved by: alexcrichton
Pushing 40df0f17b504fc036f5d4619a5071bb14abd602b to master...


Allow clicking on story to set it as read

In Google Reader, you can click an unread story, this will bring it to the top of the page, and set it as read. (Clicking a read story does nothing.)
Can you please add this to NewsBlur? It's pretty jarring being unable to do this.

Sure, the List view does exactly this.


Support IO operations for KORE pipeline

do not review yet

Use case:
f.k:
require "domains.k"

module F-SYNTAX
imports STRING
syntax Stmt ::= "run" | "read" "(" String ")" | "print" "(" K ")" | "output"
endmodule

module F

imports F-SYNTAX
imports K-IO
imports INT

configuration <T>
  <k> $PGM:K </k>
  <stdin/>
  <stdout/>
//<stderr/>
</T>

rule <k> print(S:String) => .K ...</k>
     <stdout>
       ...
       `.List => ListItem(S) ListItem("\n")`
     </stdout>

rule <k> read(Sort:String) ... </k>
     <stdin>
       `.List => ListItem(#parseInput(Sort, " \n\t\r"))`
       ListItem(#buffer(_:String))
       ListItem(_)
       ListItem(#istream(_:Int))
     </stdin>

rule <k> read(_) => V ... </k>
     <stdin>
       ListItem(V:K) => .List
       ...
     </stdin>
     when isStream(V) =/=K true

rule run => read("Int") ~> output ~> read("Int") ~> output ~> read("String") ~> output

rule I:Int ~> output => print(Int2String(I))
rule S:String ~> output => print(S)

endmodule

1.f:
run

kompile:
$ kompile --kore f.k

krun with real IO on:
$ krun --kore --smt none --io on 1.f <<<"1 2 abc"
1
2
abc

<T> <k> .::K </k> <stdin> ListItem ( #buffer ( "" ) ) ( ListItem ( "on" ) ListItem ( #istream ( 0 ) ) ) </stdin> <stdout> ListItem ( #ostream ( 1 ) ) ( ListItem ( "on" ) ListItem ( #buffer ( "" ) ) ) </stdout> </T>

krun with real IO off (e.g., --search or --debugger mode)
$ krun --kore --smt none --io off 1.f <<<"1 2 abc"
<T> <k> .::K </k> <stdin> ListItem ( #buffer ( "" ) ) ( ListItem ( "off" ) ListItem ( #istream ( 0 ) ) ) </stdin> <stdout> ListItem ( #ostream ( 1 ) ) ( ListItem ( "off" ) ListItem ( #buffer ( "1\n2\nabc\n\n" ) ) ) </stdout> </T>

Note that the output is stored in <stdout> cell.

@dwightguth please review.
This is an initial tryout to see if I correctly understood your requirement. Please see the above use case.
Note that my mental model is to have a minimal IO support enough to pass all the tutorial tests, since I think we will have to have a better design of IO in the end.
There are several notes and issues:

Instead of $noIO, I used an explicit $IO flag which has a value either on or off. The initial reason is that there was an issue regarding BuiltinList append operation ($noIO somehow became KItem which is not compatible with BuiltinList) which seems not trivial to fix. But I think the current form seems not that bad, so we can go with this for now. Let me know if you really want to keep the original $noIO style flag.
As we discussed, for now, an user is required to write two explicit rules for read operation (see the above usage), which was implicitly done by the java backend in KIL pipeline. We have to discuss how and where to implement this feature.
For now, I disabled <stderr>, since the current design would result in duplicating several rules for each <stdout> and <stderr>. Indeed, stderr was not supported in KIL pipeline, nor used in tutorials.
I used InitialConfigurationProvider.getStdinBuffer to get stdin buffer when real IO is disabled (e.g, --search or --debugger). The problem is that the method is parameterized with tty.stdin, but I have no idea how to support tty in KORE pipeline. So, for now, I simply ignore the value. Could you please support tty in KORE pipeline so that I can use that information, or tell me how to implement it.
Also, I made it as a public static method, and used it KRun.java, which may be a bad design; let me know if you have a better idea.
There is an issue regarding injection in KORE pipeline. I suspect it is not implemented yet. Since the #write builtin hook function returns an injected KSequence.EMPTY (.K), it simply doesn't work with the current KORE pipeline. We will have to discuss how to implement it. For now, if you want to run the above use case, we will need to the following (unsafe) change:

diff --git a/java-backend/src/main/java/org/kframework/backend/java/builtins/BuiltinIOOperations.java b/java-backend/src/main/java/org/kframework/backend/java/builtins/BuiltinIOOperations.java
index 6194b12..3cf7ddd 100644
--- a/java-backend/src/main/java/org/kframework/backend/java/builtins/BuiltinIOOperations.java
+++ b/java-backend/src/main/java/org/kframework/backend/java/builtins/BuiltinIOOperations.java
@@ -109,7 +109,8 @@ public class BuiltinIOOperations {
     public Term write(IntToken term1, StringToken term2, TermContext termContext) {
         try {
             fs.get(term1.longValue()).write(term2.byteArrayValue());
-            return KLabelInjection.injectionOf(KSequence.EMPTY, termContext);
+            return KSequence.EMPTY;
         } catch (CharacterCodingException e) {
             throw new IllegalArgumentException(e);
         } catch (IOException e) {

looks okay but it needs testing. you need to create a version of IMP++ for kore somewhere inside k-distribution/tests and wire it into ktest.  You probably won't be able to get all the tests passing because we don't currently support superheat/supercool in KORE, but you will have to at the very least add tests for both execution and search.

@dwightguth please review again.
As you suggested, a new regression test is created, which essentially IMP (not IMP++) plus IO operations. I failed to make IMP++ work due to several orthogonal issues such as parsing problem of List{Stmt,""} and <threads> cell issue. I think that should be handled separately.
Regarding the injection issue, I will make a separate pull request.

looks okay just a few more minor things.
@grosu btw we get composable configurations for free from this too!

Jenkins: test this please

You can merge if you want.


Add Ruby 3.2 to the build and test with gem versions.

See previous commit dd89d66 for example for Ruby 3.1

Dropped 2.7 from the GitHub actions due to not building with the latest RSpec.

Resolved by #36


Can't find module

https://i.imgur.com/8gHLUm8.png

I've got this problem, too

Just write npm init -y && npm i ddos-stress instead of npm install -g ddos-stress


Work with withdrawals on Plutus level

Describe the feature you'd like
At the moment toCardanoTxBody ignores the field txWithdrawals although it would be great to be able to work with withdrawals.
Also testing framework in emulator ignores this fields and always sets it to empty list for TxInfo.
So we can not test the scripts that rely on this feature.
Describe alternatives you've considered
No response

I suppose it's similar to #93.
Citing @koslambrou (can you confirm it please?):

This is something that should be part of the transaction creation library plutus-ledger-constraints. However, we're planning a complete rewrite of this library. Thus, attaching metadata to transactions would be done in this rewrite.

Yeah, it looks similar. Only asks for other fields.
To solve this problem I had to create the fork of toCardanoTxBody.
I wonder for a quick fix can we pass some auxiliary arguments to set up the fields that are missing on Plutus TX
(stake withdrawal, certificates, metadata)?


restic: Use ExecStopPost instead of ExecStartPost for the backupCleanupCommand?

Wouldn't it make sense to use ExecStopPost instead of ExecStartPost for the restic backupCleanupCommand?
That way the backupCleanupCommand can also run when the backup service failed for some reason.
@otavio

It does make sense. Could you prepare a PR?

Thanks for the fast answer.
Since I'm pretty new to NixOS, I can try. :)
Is it simply changing postStart to postStop here?
https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/backup/restic.nix#L315

Yes, it'd use in all cases.

Yes. PR rules need to be followed.

No worries. You can use the nixpkgs clone to test in your machine. Also restic has regression tests.

Sorry, I'm too busy right now and this is pretty low on my priority list.
So I think I won't do that.
Maybe at some point in the future ...


Conditions on enum does not work for SyncTables

Hi, I've had a little trouble with enums recently.
On server-side, I have an entity MyEntity with a property Status of enum type StatusType.
On mobile-side, same thing.
When I get entities with GetSyncTable<BookEntry>().ToListAsync() everything is correctly retrieved. I can also do a .Where(e => e.Status == StatusType.Something) after.
However, I could not, at all, put a condition on this enum like this : GetSyncTable<BookEntry>().Where(e => e.Status == StatusType.Something).ToListAsync().
This returns an empty list. No matter what I tried (add JsonConverter, use int values, etc.) I could not make this comparison successful. If you have any info on this I'll gladly try anything you have, but I think this is a bug from the library.
Thanks for this amazing library.

Given your query we will send a GET to /tables/bookentry?$filter=(Status eq 'Something')
In my quick test, I made an enum like so:
public enum StatusType {
    Good = 1,
    Fair,
    Poor
}

Then added a status property on my table.
Running the filter I got a GET to $filter=Status eq 'Good' and an array of results back as expected.
I did notice if the casing is wrong, the server throws an error, can you see what happens if you execute the query directly via PostMan/Fiddler/etc?

I did the check and I'm guessing I'm on the wrong project actually.
I'm using the sync tables, and the issue completely goes away when I use GetTable<> instead of GetSyncTable<>. GetSyncTable<>, on the other hand, did not make any call.
Sorry for the inconveniance, I'll declare it on the sqlitestore project instead.

Aaaaand I'm rushing too much, Sync tables are also on this project. My bad.

Sorry I misread your post and totally missed you were taking about sync tables. Let me take another look.

Yeah, that was not really explicit, I thought it was server-related. Seems not to be the case.

OK, the way the .Net backend serializes enums (By default) is with CamelCasing.   I believe this is what you are hitting.
So if you enums are StatusType.Fair = 1, the server sends "fair" to the client, and the client atm just save that into the local db.
Then when you execute a local query using the same enum, it tries to find Status = 'Fair' and not Statue = 'fair'.
One fix is to tell the server to not use camel case on your enum [JsonConverter(typeof(StringEnumConverter))] should do it.
Otherwise, your local query could do something like q.where(r => r.Status.toString().toLower() == StatusType.Fair.toString().toLower().  (Which is obv much uglier)'
Need to look at better fixes long term.

Thanks for the quick answer. That might explains everything indeed.
The fix you offer seems the best, however I'm concerned about the current entries. For all users, without a synchronization they will still have the issue locally, won't they ?
I think I'll stick with the second solution. Even if it's uglier, at least I don't have a regression for users. In the meantime, I will implement the JsonConverter and I'll remove the ugly hack later on, when users will have synchronized all of their entries.
Again, thanks for you quick answers and feedback (and fixes !), you're the best.

Regarding the [JsonConverter(typeof(StringEnumConverter))], this does not seem to work, even if I add the converter with CamelCase
(I do this like that : config.Formatters.JsonFormatter.SerializerSettings.Converters.Add(new StringEnumConverter { CamelCaseText = true });)

CamelCaseTest should be false for this fix.  The response from the server should use the exact casing of the Enum as its defined.  (CamelCaseText = true is the default the .Net backend sets up for you)  My very quick test worked ok, if the server response isn't updating, can you let me know what version of the backend nugets you are using?
Like you mentioned, the above is really only a good solution for a new app that isn't in the wild, since any synced data will not get adjusted until that record changes in the future.
The proper fix is we need to see if the cilent's Linq to SQL translation can let you control how the resulting SQL statement is generated for an Enum.

CamelCaseText = false does not seem to work either.
My version of Microsoft.Azure.Mobile.Server is 0.1.508.
The project is part of the Azure App Services

My testing was on the Mobile Service .Net side, I didn't try on the newer Mobile App side.  I'll need to play around with it to see how you override the serialization correctly there.

Hi Guys. I also hit this problem when filtering with an enum value. Any fix ETA for this bug or is there a workaround?

Putting the "[JsonConverter(typeof(StringEnumConverter))]" attribute on the enum itself (not the property using the enum) will work for sending them in PascalCase to the client.


Update README.md

Pre-Submission Checklist

[x] Your pull request targets the master branch of freeCodeCamp/study-group-directory.
[x] You have only one commit (if not, squash them into one commit).

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Update or Correct an existing group entry
[ ] Add a new group entry

Checklist:

[ ] Tested changes locally.
[ ] Automated build tests (Travis and Netlify) pass
[x] Addressed currently open issue (replace XXXXX with an issue number in next line)

Relates to #39
Description

Minor updates to readme, mainly to direct people to new contributing.md.
NOTE: link wont work till #186 is merged.

@johnkennedy9147 Great update to the readme. Thanks!


Fix deprecated plugin syntax.

This makes the test build with rustc 1.0.0-nightly (b63cee4a1 2015-02-14 17:01:11 +0000) for me.

Hm… when I look at this, I don't quite understand, why this has been added in the first place. There is no need for plugins in the module at all, there are only macros.

Ah you're right, it can just be removed. But it looks like the build is failing otherwise anyway..

Ok, I sat down fixing the rest of the issues. Thus closing in favour of #94.


Unable to recover wallet with 12 word phrase

Hi,
I have a new phone and have been able to recover my BCH wallet but not my BTC wallet despite having the 12 word phrase. I still have the old phone so can hopefully create a new wallet and send to that if necessary, but hoping there’s a better way?
The error message I’m getting says to check the password of the recovery phrase, the derivation path or the wallet service URL. Any help appreciated

Closing this as the same 12 words for BCH account worked for BTC...not sure what the other 12 words I had were for!

@helpmerecoverplease
we have developed our own hardware for fixing BITCOIN recovery phrase with superfast speed
and if you still has problem I can help you run it. you can find my contact details on my profile
or you can send me message in telegram: @johnjames333


Add /api-docs to make them easier to find

This PR adds a top level /api-docs page that will simply list all the available API documentations available from the language SIGs. It's a convenience page, saving a few clicks, since I found myself multiple times to look for an API doc and then going docs.opentelemetry.io -> Languages -> that language -> API Docs
Preview: https://deploy-preview-5190--opentelemetry.netlify.app/api-docs/

/fix:all

@svrnm seems there's a build error somewhere


Code fixes don't respect formatting settings from EditorConfig

This is really great, thanks @filipw!
After some experimentation however, it seems like .editorconfig settings aren't being passed through to analyzers, is that right? Using roslynator, omnisharp.json settings appear to be passed through to the analyzer and affect diagnostics and code actions, but not .editorconfig settings.
Example:
// Program.cs
public class Program
{
   public string Something { get; set; }
}

# .editorconfig
root = true
[*.cs]
indent_size = 3

// omnisharp.json
{
   "FormattingOptions": {
      "EnableEditorConfigSupport": true,
      "IndentationSize": 2
   },
   "RoslynExtensionsOptions": {
      "EnableAnalyzersSupport": true,
      "LocationPaths": [
         "C:/Users/Nick/.omnisharp/roslynator"
      ]
   }
}

If I now Format Document, OmniSharp-roslyn correctly sets the indent to 3 (as specified by .editorconfig). However, if I move the cursor to the beginning of line 2 there is a "Fix formatting" code action available from roslynator, and running this sets the indent back to 2 (as specified by omnisharp.json).
Removing the "IndentationSize" line entirely from omnisharp.json results in roslynator using the default of 4.
Similar things occur with newlines, where roslynator applies omnisharp.json preferences and O#-roslyn applies .editorconfig preferences.
Originally posted by @nickspoons in https://github.com/OmniSharp/omnisharp-roslyn/pull/1526#issuecomment-511246649

@nickspoons thanks for the issue. The Fix formatting code fix is actually from Roslyn (https://github.com/dotnet/roslyn/blob/master/src/Features/Core/Portable/Formatting/FormattingCodeFixProvider.cs) not from Roslynator.
But it is a nice find - thanks.
All the options are flown correctly to the analyzers but, basically, we run the editorconfig provider before the omnisharp.json-formatting provider which causes all formatting settings to be lost. This doesn't affect internal OmniSharp formatting endpoints, as on those endpoint editorconfig is re-applied again on invoke, but it affects "3rd party" formatting invokers like this code fix.
This only affects formatting rules, other editorconfig options such as naming conventions are not affected and a respected in analyzers, code fixes and refactorings correctly.
I opened #1559 to remedy that.

Brilliant, thanks so much @filipw!


ly install conflict with python-ly binary name in arch distro

in arch distro, ly install the executable binary 'ly' is conflict with pyhon-ly. they both use the executable binary name 'ly'.  who is the first to use the name?

python-ly was first submitted to AUR on 2015-03-10.
ly-git was first submitted to AUR on 2017-05-24 and
ly was first submitted to AUR on 2018-09-23.
This should hopefully answer your question

python-ly was first submitted to AUR on 2015-03-10.
ly-git was first submitted to AUR on 2017-05-24 and
ly was first submitted to AUR on 2018-09-23.
This should hopefully answer your question

python-ly was first submitted to AUR on 2015-03-10.
ly-git was first submitted to AUR on 2017-05-24 and
ly was first submitted to AUR on 2018-09-23.
This should hopefully answer your question

thanks very much for your told. i hope arch commity, ly official, or pyphon-ly can solve this simple conflict.

python-ly was first submitted to AUR on 2015-03-10.
ly-git was first submitted to AUR on 2017-05-24 and
ly was first submitted to AUR on 2018-09-23.
This should hopefully answer your question

thanks very much for your told. i hope arch commity, ly official, or pyphon-ly can solve this simple conflict.

python-ly was first submitted to AUR on 2015-03-10.
ly-git was first submitted to AUR on 2017-05-24 and
ly was first submitted to AUR on 2018-09-23.
This should hopefully answer your question

thanks very much for your told. i hope arch commity, ly official, or pyphon-ly can solve this simple conflict.

python-ly was first submitted to AUR on 2015-03-10.
ly-git was first submitted to AUR on 2017-05-24 and
ly was first submitted to AUR on 2018-09-23.
This should hopefully answer your question

thanks very much for your told. i hope arch commity, ly official, or pyphon-ly can solve this simple conflict.

This has nothing to do with the AUR or Arch Linux. This is simply an unfortunate choice of name which conflicted with an existing project that is now over 14 years old (that project started some time in 2008).
@nullgemm I would strongly suggest renaming the binary (to e.g. something like lydm) so that it doesn't conflict with the well-established project.


Auto requires active model serializers 7. Fixes #7

Removes explicit dependency need for active model serializers inside of rails apps.

:+1:


winch: Aarch64 sub and mul

I just filled in some todo! for sub and mul on aarch64. I copied the file tests from x86. It should be fairly straight forward, but of course there is a chance I missed something obvious.
@saulecabrera You mentioned fuzz testing being your main approach now. I wasn't sure how to do that, but would happily go run some if you can point me in the right direction.

You mentioned fuzz testing being your main approach now. I wasn't sure how to do that, but would happily go run some if you can point me in the right direction.

Yeah, unfortunately you won't be able to get local fuzzing working for  aarch64 working since it will at least require support for call, which we don't have yet. It shouldn't be to complex to get going though with all the recent work that we've done for supporting function calls and trampolines.

@saulecabrera Fixed. Sorry for the late responses on these. My notifications were still going to my old work email. Fixed now.

Thanks for the fixes! There's a failure in the updated sub tests for x64, because the output doesn't match (as expected), you should be able to fix that by running WINCH_TEST_BLESS=1 cargo run -- test inside the winch directory.

Yeah, sorry my bad. Totally thought I ran that a second time. Fixed now.


Suggestion: setting global: 'window' instead of {}

I have found this demo you made to be tremendously helpful for my project that combines the AWS backend stack + Phaser front-end. Thank you very much!
I have one suggestion for a small part of your code that might be able to help others in a similar boat as me.
In your vite.config, you defined global: {}.
While this is necessary for AWS Authenticator to work properly and works fine for building this app, I noticed this would cause building my app with Phaser to crash because Phaser.js has, somewhere in its lines, a declaration that involves global.somethingsomething.
I managed to get around this issue by declaring global: 'window' .
It took me a couple of hours of searching the internet to figure this out. I am pretty new to this space, maybe that is why and this is glaringly obvious to the pros out there, but I thought this might save some poor souls who are noobs like me :)

Hi @jaybhum, thank you for reporting this! I think you are right and it should make more sense if global is set as window. I now pushed the change to main branch.


Handoff should ignore segments that are dropped by drop rules

Fix #5868.

Hey @QiuMM - do you think you'll have a chance to come back to this one? Thanks!!

@gianm @jihoonson sorry for the late because I'm busy with my work, I'll update this pr on this weekend.


Configurable timeouts

Is it possible to support configurable scanner timeout and client RPC timeouts?
These would be equivalent to hbase.client.scanner.timeout.period and hbase.rpc.timeout respectively in the in Java HBase client. This would allow for fine tuning scans (and other requests) to prevent scanner leases from expiring prematurely.
Also, what are the current values for these timeouts?

AFAIK, scanner timeout values are configurable on the server side: https://github.com/apache/hbase/blob/branch-2.0/hbase-common/src/main/resources/hbase-default.xml#L597
I don't see any relevant fields in ScanRequest (https://github.com/apache/hbase/blob/branch-2.0/hbase-protocol/src/main/protobuf/Client.proto#L289) or Scan (https://github.com/apache/hbase/blob/branch-2.0/hbase-protocol/src/main/protobuf/Client.proto#L246) that would allow the client to specify the timeout.
So the problem you are trying to solve is how do you renew or automatically recover from scanner failure (due to timeout or regionserver going down). That is tricky due to partial results returned by hbase, meaning if half of a row is returned, the challenge is to restart request from the second half of the row and continue on scanning. It looks like hbase already has some logic to handle case like this (https://github.com/apache/hbase/blob/branch-2.0/hbase-protocol/src/main/protobuf/Client.proto#L295 and https://issues.apache.org/jira/browse/HBASE-5974), but I haven't spent much time on researching the nuances.


Add priorities

You should be able to gove priority to certain tasks.
Red - Important
Orange - Mildly important
Blue - Low importance

Hi, @lionirdeadman ! Not sure if this app needs priorities. But I will think about it...


Added missing plugins to the types

What's Changing and Why
As mentioned by @SaliZumberi during a discussion on #689, I noticed we were missing a few plugins from the core typings for typings versions 3.1+. This PR adds those plugins and the typings associated
What else might be affected
This should be a minor release as it doesn't break any functionality
Tasks

[x] Add tests
[ ] Update Documentation
[x] Update jimp.d.ts
[ ] Add SemVer Label

:rocket: PR was released in v0.9.7 :rocket:


Maintenance: compatibleArchitectures field not available in all AWS Regions

Summary
In #1372 we have introduced two new fields to our public layers: compatibleArchitectures and license. This new field however caused the release process to fail due to one of the fields not being accepted in some regions.
To proceed with the release I have applied an hot-fix, however we should dedicate time to understand what are the implication of this field not being supported.
Why is this needed?
Because the compatibleArchitectures is not supported in some AWS regions (eu-south-2, eu-central-2, ap-southeast-4) and we are unsure of what are the implications.
Which area does this relate to?
Automation
Solution
No response
Acknowledgment

[X] This request meets Lambda Powertools Tenets
[ ] Should this be considered in other Lambda Powertools languages? i.e. Python, Java, and .NET

Future readers
Please react with 👍 and your use case to help us understand customer demand.

As the commits linked above show, I ended up temporarily commenting out the parameter in the layer stack.
Let's discuss options in the coming weeks.

Python folks had similar problems with my recent changes here. They used aspects to traverse the nodes and fix the compatibleArchitectures field based on the region.
I will apply same fix to our layer package.

Aside from the immediate fix, do we have a reliable way of keeping track of when the field will be available? Or do we have to keep our eyes peeled on the what's new channel to see when it gets announced?

We will revisit the issue once we start working on #1374. I will block it for now.

The Python team has worked around this limitation by modifying the region matrix from this:
matrix:
  region:
    [
      "af-south-1",
      "eu-central-1"
    ]

to this:
matrix:
  include:
    - region: "af-south-1"
       has_arm64_support: "true"
    - region: "ap-east-1"
       has_arm64_support: "true"

With the new has_arm64_support  key passed as a parameter like this:
npx cdk deploy --app cdk.out --context region=${{ matrix.region }} --parameters HasARM64Support=${{ matrix.has_arm64_support }} ...

Then, in the CDK application, the parameter is converted to a set of CfnConditions which are in turn used to modify the construct in charge of publishing the layer using Aspects. See here for example.
We should look into adopting the same solution so we can forget about the issue for good.


Documentation missing important details

The bouncer add-on DOCS.md would greatly benefit from a few content changes.
It's not clearly documented that the user must input the API url and key information to local_api_credentials.yaml for this to work correctly.
Instructions about how to edit the config file would likely be useful considering the user base this tool is being promoted to, as files in .storage are inaccessible from the standard HA file editor and Cloudsec Terminal doesn't come with nano or vim preinstalled. If I'm not missing something, most users will need to install the Terminal & SSH add-on to edit these config files.
The documentation also neglects to mention steps telling users how to enable the online API. While having that might extend beyond the scope of this add-on, if these docs are being shared in community forums as the official resource about how to use Crowdsec in HA, editing this into something more closely resembling a start-to-finish "Getting Started" guide would be recommended.

The critical documentation issue about where the user needs to supply API information is fixed in #12.
Ideally the program should edit these config files automatically without the need for user intervention, but this works as a temporary solution in the meantime.

Thanks @he2ss, that is helpful and something I overlooked. The way these docs were written, I assumed I needed to update the YAML directly to get this working. I can update my PR to reflect this new knowledge, as doing it inside the UI is going to be significantly easier for most users..

Yep, I can will be helpful. Thanks @gunnaraas !

This issue can be closed thanks to @gunnaraas.


Error: Request Signature did not match

where am i getting the APP_SECRET from

For details about APP secret refer to https://developers.facebook.com/docs/development/create-an-app/app-dashboard/basic-settings/#app-secret
You can get your app secret and use that in the server to validate the payload https://developers.facebook.com/docs/whatsapp/flows/guides/implementingyourflowendpoint#validate-payloads
PLEASE NOTE: Never use the private keys for your production accounts outside the system. We advise to create temporary keys for testing purposes.


Using 'typings' in the "Working with React and TypeScript" tutorial

Hi,
I am an beginner using typescript und I am following the Working with React and TypeScript. To install the type definitions, I do this:
typings install react --ambient --save

What the tutorial expects (with tsd) is the file typings/react/react.d.ts (it is referenced from the source files).
But the whole "typings/react" folder does not appear.
So how is this done correctly?
Thanks!

Well, one has to change the reference path at the top of the files to something like:
///

Great, glad you figured it out! I'd recommend using tsconfig.json to point to that file, see https://github.com/typings/typings#maindts-and-browserdts


Allow setting-less controls

In WordPress 4.5, controls no longer have to be tied to a setting.
We need to allow that behavior in Kirki as well

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/32424813-allow-setting-less-controls?utm_campaign=plugin&utm_content=tracker%2F2030945&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F2030945&utm_medium=issues&utm_source=github).

On the other hand, why implement it?
The fact that it's there doesn't mean necessarily that it has to be implemented...
The only valid use-case I case see for this in Kirki is for controller fields.
By "controller" fields I mean simply controls whose only role is to show or hide other controls using the [required] argument.
But even in that case, we NEED a setting in order to understand if the value is what we're after in order to show/hide the dependent fields.
So... really I see no reason why we should do it.
In case of controller fields it's pretty simple to just delete the setting on save with something like this:
add_action( 'customize_save_after', function() {
    remove_theme_mod( 'my_setting' );
});


Testing and Linting

Setting up testing and linting.
To test use npm run test. I added a simple test.
To check linter use npm run lint.
Check .eslintrc for the linting rules, maybe we should add more or change some.

closes #9


Change the log level for the Batch class to WARN so that we see error

codes from Firehose. Also got rid of an unused import in
FirehoseProcessor and did some inlining; unfortunately this changes the
log line of the metric, but now's the time to make this change while I'm
working on dashboards.

Coverage remained the same at 100.0% when pulling 49d9d1253994937033006a809ec99f7abb72c1ea on ChangeLogLevelForBatchClass into f9681266da65fc983be58ce64af24a38455c0412 on master.


Pneumonia Detection from X-Ray

Deep Learning Simplified Repository (Proposing new issue)
:red_circle: Project Title : Pneumonia Detection from X-Ray
:red_circle: Aim : The aim is to create a DL model which will detect the pneumonia from the given X-ray images.
:red_circle: Dataset : https://www.kaggle.com/datasets/paultimothymooney/chest-xray-pneumonia
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Email ID :
Participant ID (if applicable):
Approach for this Project :
What is your participant role? (Mention the Open Source program)

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

I am Esha and I would like to take up this issue
My GitHub: https://github.com/ESHA1101
Email ID<EMAIL_ADDRESS>Approach: this project is mainly based on image processing and knowledge on pneumonia and how it shows in x rays. I will formulate a few algorithms based on the latter and will check the accuracy using each algorithm. The model that gives the best accuracy will be chosen.
I am a participant of ssoc 2022

We'll start the journey after completing those formalities. Till then, stay tuned with Deep Learning Simplified.
Thanks and regards.

@ESHA1101 updates please.

Updates please @ESHA1101

Hey, @abhisheks008  I would like to work on this issue,
Full name : Piyush Bhujbal
GitHub Profile Link : https://github.com/PiyushBL45t
Email ID<EMAIL_ADDRESS>Approaches for this Project :-

Read the images.
Perform analysis of data.
Check for reshaping and implement changes if needed.
Create model architecture for the image dataset.
Create image data for preprocessing.
Make predictions.
Check the accuracy and loss parameter for the model.
Make live detection using OpenCV if possible.

What is your participant role: contributor at SWOC 3.0

Assigned @PiyushBL45t

I would like to work on this under SSoC. Please assign me this project.

@abhisheks008 I'm working on my previously create issues. I want to work on this one too. Could you please me this as well?

No, a contributor can not be assigned to more than one issue.
@nk-droid

Hi, @abhisheks008, I would like to work on this issue and I will complete it for the Social Summer of Code. Please assign me this issue.

Sure @PiyushBL45t. Let the previous PR merged.


Get the system tests passing

Right now they're failing with a permissions issue on the test bucket:
https://circleci.com/gh/GoogleCloudPlatform/gcs-resumable-upload/899
@stephenplusplus I kinda forget how all this is set up 😆

Done! I just had to remove the BUCKET_NAME env var in Circle.


Minor update to json-rpc.md

Removed sync account example it will be deprecated soon.
removed dups In the following sections we will show how to use Sui's JSON-RPC API.....
use proper headers instead of rpc method name

FYI @Romainua

FYI @Romainua

LGTM, will check in doc and check all output and methods


Product Description

Product Description
High Level Overview

Problem Statement

Moments of Charm

Product Sketches

Hey @irm1005-itec1005-fall-2023/flexfusion - please review and correct this post - I think all of the text is in HTML comments so not visible - I also can't see the image for some reason.


Patch 1: Added the carousel in 'Services are Available In' section.

🚀 Pull Request
Description
A clear and concise description of the changes introduced in this pull request.

Related Issue
If this pull request addresses an issue, link to it here (e.g., Closes #123).

Type of Change
What kind of change does this pull request introduce?

[ ] 🐛 Bug fix
[ ] 🚀 New feature
[ ] 📄 Documentation update
[ ] 🛠 Code improvement/refactor
[ ] 🖼 UI/UX update
[ ] Other (please specify)

Screenshots (if applicable)
Add screenshots or screen recordings to demonstrate the new feature or fix.

Checklist
Please ensure the following tasks are complete before submitting the pull request:

[ ] I have tested my changes and ensured they work as expected.
[ ] I have added any necessary documentation or comments.
[ ] I have checked the existing issues and pull requests to avoid duplicates.
[ ] I have starred this repository.
[ ] I have reviewed my code for best practices and readability.
[ ] I have included any relevant tests (if applicable).

Additional Context
Add any other relevant information or context about the pull request here.

Hey @NumlStudentSE  , your changes are not visible, and Netlify has not generated your deploy preview. Please pass all the checks by Netlify.


Find Required Reason API usage in Flutter Plugins and create Privacy Manifest if applicable

Introduced in Xcode 15, Apple is now flagging specific APIs as needing a “Required Reason” to use. All usages of “Required Reason” APIs MUST be outlined in a Privacy manifest. A Privacy manifest is a document outlining how your app/SDK collects and uses a user’s data.
This is also time sensitive (https://developer.apple.com/news/?id=z6fu1dcu).

Starting in fall 2023, when you upload a new app or app update to App Store Connect that uses an API (including from third-party SDKs) that requires a reason, you’ll receive a notice if you haven’t provided an approved reason in your app’s privacy manifest. And starting in spring 2024, in order to upload your new app or app update to App Store Connect, you’ll be required to include an approved reason in the app’s privacy manifest which accurately reflects how your app uses the API.

https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api?language=objc
https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_data_use_in_privacy_manifests?language=objc
https://developer.apple.com/videos/play/wwdc2023/10060/
We'll probably want to also add testing to scan for Required Reason APIs, so they get caught when added.
We could also build tooling around this to try and warn plugin authors.

I've audited flutter/packages, and the only thing I found was NSUserDefaults.
That raises a very tricky question about how we want to handle this in the ecosystem:

shared_preferences itself is just a wrapper around the API, it doesn't know how/why it's being used. So we can't do the manifest at that layer. (Technically currently there's only one possible reason that could be given, so we could, but I don't expect that to continue to be true.)
If an app is just using shared_preferences themselves, the app developer can list the reason.
But if a package the app is using (even transitively) is using shared_preferences for some package-internal state, then only the developer of that package knows how/why it's being used.

It seems like we'll either need to:

leave this up to app developers to deal with (e.g., via finding the transitive usage and asking developers to list the reasons in their READMEs), which isn't going to be a good experience, or
build a system for arbitrary pub packages to declare privacy manifests, and for the tool to bundle them all together.

@stuartmorgan Looking at the documentation, it says If you use the API in your third-party SDK’s code, then you need to report the API in your third-party SDK’s privacy manifest file, which makes it sound like just having the code for it (even if you don't actually use it) may be enough to flag it.
So perhaps, even though shared_preferences is just wrapper, we should do the privacy manifest at the plugin layer.

So perhaps, even though shared_preferences is just wrapper, we should do the privacy manifest at the plugin layer.

But we literally don't know at that layer what data is being stored is or how it's being used.
I've filed a request for a new reason describing the wrapping/delegation case. We'll see what Apple says about how to handle it.

As a plugin author, where/how do I declare the privacy manifest? A plugin isn't a typical iOS 3rd party SDK, so it isn't clear to me that the approach described here works for a plugin.  I would like to add the manifest at the plugin level (different from userdefaults, I do know why I use a file system API) so that the user of my plugin package doesn't have to do this. Any insights are appreciated!

So I just now received an email from someone at Apple inquiring that I would sync up a Flutter plugin I maintain to this new manifest (linking to https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_data_use_in_privacy_manifests?language=objc).
Not sure how they even got hold of my contact. Any guidance as to how to proceed here?

@creativecreatorormaybenot Please see https://github.com/flutter/flutter/issues/131940 as referenced just above.

Hello I created a binary analyzer and these are the "required reasons API" symbols found in Flutter xcframework binaries:
Used symbols in binary ./Flutter.xcframework/ios-arm64_x86_64-simulator/Flutter.framework/Flutter: fstat, fstatfs, lstat, mach_absolute_time, NSURLContentModificationDateKey, stat, statfs, statvfs
Used symbols in binary ./Flutter.xcframework/ios-arm64/Flutter.framework/Flutter: fstat, fstatfs, lstat, mach_absolute_time, NSURLContentModificationDateKey, stat, statfs, statvfs


Installation procedure / instructions

This relates to my JOSS review openjournals/joss-reviews#2743
Installation instructions should include minimum versions for required packages (and indeed python) where applicable, and should be provided as a requirements.txt file (https://pip.pypa.io/en/stable/user_guide/#requirements-files). Thse files make installation of the required packages via pip or anaconda very straighforward.
The JOSS review criteria says that "ideally" installation can be handled via "handled with an automated package management solution.. Creating a package that included regenens.py as an executable would make make installation of the code more straightforward. (Even if the package is not uploaded to something like pip, being able to install through this approach would be helpful).

The following pull request contains a number of commits related to setting up the automated installation
https://github.com/EpistasisLab/regens/pull/18
Within that are some of the more important commits:
https://github.com/EpistasisLab/regens/pull/18/commits/6189d18958b3516eb12e62f6ea07952c3fcb0821 shows removing files that are now downloaded from figshare.com.
https://github.com/EpistasisLab/regens/pull/18/commits/ea64ccddbdefb6e290c10202bb31b0a51c8b9cb0 shows modifying regens.py to be the main function for setuptools.
https://github.com/EpistasisLab/regens/pull/18/commits/c3d5d31d7f678f2921d2bbfc911aee87f2c68f51 shows an early incomplete version of setup.py
Other commits entail me trying things that mostly didn't work. They're less important.
This commit includes the majority of other changes to setup.py and changes to the yml file that automates pypi updates
https://github.com/EpistasisLab/regens/commit/8cfbe54c90767460a9827a68d03e59780287d727
The following pull request includes a number of commit hashes that contributed to writing the new installation instructions. I won't list them because I edited the readme directly, and they're not particularly organized.
https://github.com/EpistasisLab/regens/pull/19
The following commits entail changing some links that make the installation instructions a little bit easier to follow:
https://github.com/EpistasisLab/regens/commit/a29f4fc658f043874848567d63c81c5cb828f37e
https://github.com/EpistasisLab/regens/commit/8319813c5f91fc678d2029d18a679a64da8e3eef
https://github.com/EpistasisLab/regens/commit/94489e837214539d61ed92c12fd07fbaf154577e
https://github.com/EpistasisLab/regens/commit/8d17524f6f806a790ab90c62050a858b83c9a7f4
https://github.com/EpistasisLab/regens/commit/0dea489dfefa86014076d52f545056b94ef6bf97
https://github.com/EpistasisLab/regens/commit/6040a4d12666e556f8738a85474577a589dfabc9
https://github.com/EpistasisLab/regens/commit/9ebfac42ac5ec569874702674638c3287f01438d

These commits are related to updating the pypi to its final version:
https://github.com/EpistasisLab/regens/commit/087b9da37939d7782a229854c35bfbc3d1e8b5f2
https://github.com/EpistasisLab/regens/commit/b4a93097c7085c205b6dc36a0737f093a34a71fb
Please feel free to reopen the issue if these changes have not adequately addressed your concern!


v2.19.0 IE Error

Hey!
Using version 2.19.0 seems to throw an error in Internet Explorer:
SCRIPT1003: Expected ':'
Going back to version 2.18.2 doesn't seem to have this problem.
Maybe the fix can be something related to this previous issue:
https://github.com/glenjamin/webpack-hot-middleware/issues/165
Thanks!

Yep, this is the same problem as 165 - a PR which used new syntax.
I've updated the linter and fixed the issue, and released as 2.19.1.


reddit ripper sometimes fails to parse urls

Ripme version: 1.7.69
Java version:
Operating system:

Exact URL you were trying to rip when the problem occurred: https://www.reddit.com/r/bigbrothernsfw
Please include any additional information about how to reproduce the problem:

Expected Behavior
Parses markdown to get urls
Actual Behavior
Sometimes fails to parse markdown leading to urls like https://imgur.com/a/DVuYxRu](https://imgur.com/a/DVuYxRu

Looks like you messed up the very final link's code: https://imgur.com/a/DVuYxRu](https://imgur.com/a/DVuYxRu


Fix typo

@eltociear : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Have a user driven mechanism to enrich a model to a model card

Modify "Add ressources" modal to display Document instead of Artifacts.
Add provenance to model to link Document selected for enrichment.
Get the results in the model and update it, should be done automaticaly by refreshing like the call equations to amr

@blanchco Please tweak the '+ Add Resources' button link to say 'Enrich model description'. This will bring up the same modal where the user can select a document and get back the model card. Later, we will add another button to get back extracted variables metadata and align them with the model (will be a different issue). Thanks!

Button name change has been done in https://github.com/DARPA-ASKEM/terarium/pull/1916.  Will continue to work on provenance linking


Add support to change server selected from definition

This solves #28

This is fantastic! Thank you @sunkan
Could you also implement the alternative ways of setting the server as you described in #28? I really like this idea!

I've update the pull-request with support for the alternative syntax and added test.
I don't know if the code is the cleanest due to the fact typescript/javascript is not my primary language so let me know if there are some changes you want me to make

No that looks great! Thank you so much @sunkan. Could you maybe just run npm run prettier and we're ready to merge!


KeepAlive Auto config does not respect the inbound header

$subject as the  http client change the connection header from closed to keepAlive regardless of the config
[2021-01-22 16:30:45,488] TRACE {http.tracelog.downstream} - [id: 0x65725019] REGISTERED
[2021-01-22 16:30:45,489] TRACE {http.tracelog.downstream} - [id: 0x65725019, correlatedSource: n/a, host:/<IP_ADDRESS>:9090 - remote:/<IP_ADDRESS>:60802] ACTIVE
[2021-01-22 16:30:45,490] TRACE {http.tracelog.downstream} - [id: 0x65725019, correlatedSource: n/a, host:/<IP_ADDRESS>:9090 - remote:/<IP_ADDRESS>:60802] INBOUND: DefaultHttpRequest(decodeResult: success, version: HTTP/1.1)
POST /passthrough HTTP/1.1
Host: localhost:9090
User-Agent: curl/7.64.1
Accept: */*
connection: Close
Content-Length: 5
Content-Type: application/x-www-form-urlencoded
[2021-01-22 16:30:45,495] TRACE {http.tracelog.upstream} - [id: 0x81540b81, correlatedSource: 0x46007eac, host:/<IP_ADDRESS>:60746 - remote:localhost/<IP_ADDRESS>:9092] DEREGISTER
[2021-01-22 16:30:45,495] TRACE {http.tracelog.upstream} - [id: 0x81540b81, correlatedSource: 0x46007eac, host:/<IP_ADDRESS>:60746 - remote:localhost/<IP_ADDRESS>:9092] UNREGISTERED
[2021-01-22 16:30:45,496] TRACE {http.tracelog.downstream} - [id: 0x65725019, correlatedSource: n/a, host:localhost/<IP_ADDRESS>:9090 - remote:/<IP_ADDRESS>:60802] INBOUND: DefaultLastHttpContent(data: PooledSlicedByteBuf(ridx: 0, widx: 5, cap: 5/5, unwrapped: PooledUnsafeDirectByteBuf(ridx: 181, widx: 181, cap: 1024)), decoderResult: success), 5B
hello
[2021-01-22 16:30:45,497] TRACE {http.tracelog.downstream} - [id: 0x65725019, correlatedSource: n/a, host:localhost/<IP_ADDRESS>:9090 - remote:/<IP_ADDRESS>:60802] READ COMPLETE
[2021-01-22 16:30:45,507] TRACE {http.tracelog.upstream} - [id: 0x81540b81] REGISTERED
[2021-01-22 16:30:45,508] TRACE {http.tracelog.upstream} - [id: 0x81540b81, correlatedSource: 0x65725019, host:/<IP_ADDRESS>:60746 - remote:localhost/<IP_ADDRESS>:9092] OUTBOUND: DefaultHttpRequest(decodeResult: success, version: HTTP/1.1)
POST /hello/ HTTP/1.1
Accept: */*
Content-Type: application/x-www-form-urlencoded
host: localhost:9092
user-agent: ballerina
connection: keep-alive
content-length: 5
[2021-01-22 16:30:45,509] TRACE {http.tracelog.upstream} - [id: 0x81540b81, correlatedSource: 0x65725019, host:/<IP_ADDRESS>:60746 - remote:localhost/<IP_ADDRESS>:9092] OUTBOUND: DefaultLastHttpContent(data: PooledSlicedByteBuf(ridx: 0, widx: 5, cap: 5/5, unwrapped: PooledUnsafeDirectByteBuf(ridx: 181, widx: 181, cap: 1024)), decoderResult: success), 5B
hello
[2021-01-22 16:30:45,509] TRACE {http.tracelog.upstream} - [id: 0x81540b81, correlatedSource: 0x65725019, host:/<IP_ADDRESS>:60746 - remote:localhost/<IP_ADDRESS>:9092] FLUSH
[2021-01-22 16:30:45,512] TRACE {http.tracelog.downstream} - [id: 0xff53a390, correlatedSource: n/a, host:localhost/<IP_ADDRESS>:9092 - remote:/<IP_ADDRESS>:60746] INBOUND: DefaultHttpRequest(decodeResult: success, version: HTTP/1.1)
POST /hello/ HTTP/1.1
Accept: */*
Content-Type: application/x-www-form-urlencoded
host: localhost:9092
user-agent: ballerina
connection: keep-alive
content-length: 5
[2021-01-22 16:30:45,524] TRACE {http.tracelog.downstream} - [id: 0xff53a390, correlatedSource: n/a, host:localhost/<IP_ADDRESS>:9092 - remote:/<IP_ADDRESS>:60746] INBOUND: DefaultLastHttpContent(data: PooledSlicedByteBuf(ridx: 0, widx: 5, cap: 5/5, unwrapped: PooledUnsafeDirectByteBuf(ridx: 180, widx: 180, cap: 512)), decoderResult: success), 5B
hello
[2021-01-22 16:30:45,525] TRACE {http.tracelog.downstream} - [id: 0xff53a390, correlatedSource: n/a, host:localhost/<IP_ADDRESS>:9092 - remote:/<IP_ADDRESS>:60746] READ COMPLETE
[2021-01-22 16:30:45,526] TRACE {http.tracelog.downstream} - [id: 0xff53a390, correlatedSource: n/a, host:localhost/<IP_ADDRESS>:9092 - remote:/<IP_ADDRESS>:60746] OUTBOUND: DefaultFullHttpResponse(decodeResult: success, version: HTTP/1.1, content: CompositeByteBuf(ridx: 0, widx: 12, cap: 12, components=1))
HTTP/1.1 200 OK
content-type: text/plain
content-length: 12
server: ballerina
date: Fri, 22 Jan 2021 16:30:45 +0530, 12B
Hello World!
[2021-01-22 16:30:45,527] TRACE {http.tracelog.downstream} - [id: 0xff53a390, correlatedSource: n/a, host:localhost/<IP_ADDRESS>:9092 - remote:/<IP_ADDRESS>:60746] FLUSH
[2021-01-22 16:30:45,534] TRACE {http.tracelog.upstream} - [id: 0x81540b81, correlatedSource: 0x65725019, host:/<IP_ADDRESS>:60746 - remote:localhost/<IP_ADDRESS>:9092] INBOUND: DefaultHttpResponse(decodeResult: success, version: HTTP/1.1)
HTTP/1.1 200 OK
content-type: text/plain
content-length: 12
server: ballerina
date: Fri, 22 Jan 2021 16:30:45 +0530
[2021-01-22 16:30:45,544] TRACE {http.tracelog.upstream} - [id: 0x81540b81, correlatedSource: 0x65725019, host:/<IP_ADDRESS>:60746 - remote:localhost/<IP_ADDRESS>:9092] INBOUND: DefaultLastHttpContent(data: PooledSlicedByteBuf(ridx: 0, widx: 12, cap: 12/12, unwrapped: PooledUnsafeDirectByteBuf(ridx: 135, widx: 135, cap: 512)), decoderResult: success), 12B
Hello World!
[2021-01-22 16:30:45,550] TRACE {http.tracelog.upstream} - [id: 0x81540b81, correlatedSource: 0x65725019, host:/<IP_ADDRESS>:60746 - remote:localhost/<IP_ADDRESS>:9092] READ COMPLETE
[2021-01-22 16:30:45,551] TRACE {http.tracelog.downstream} - [id: 0x65725019, correlatedSource: n/a, host:localhost/<IP_ADDRESS>:9090 - remote:/<IP_ADDRESS>:60802] OUTBOUND: DefaultFullHttpResponse(decodeResult: success, version: HTTP/1.1, content: CompositeByteBuf(ridx: 0, widx: 12, cap: 12, components=1))
HTTP/1.1 200 OK
content-type: text/plain
date: Fri, 22 Jan 2021 16:30:45 +0530
server: ballerina
content-length: 12
connection: close, 12B
Hello World!
[2021-01-22 16:30:45,552] TRACE {http.tracelog.downstream} - [id: 0x65725019, correlatedSource: n/a, host:localhost/<IP_ADDRESS>:9090 - remote:/<IP_ADDRESS>:60802] FLUSH
[2021-01-22 16:30:45,558] TRACE {http.tracelog.downstream} - [id: 0x65725019, correlatedSource: n/a, host:localhost/<IP_ADDRESS>:9090 - remote:/<IP_ADDRESS>:60802] CLOSE
[2021-01-22 16:30:45,558] TRACE {http.tracelog.downstream} - [id: 0x65725019, correlatedSource: n/a, host:localhost/<IP_ADDRESS>:9090 - remote:/<IP_ADDRESS>:60802] INACTIVE
[2021-01-22 16:30:45,559] TRACE {http.tracelog.downstream} - [id: 0x65725019, correlatedSource: n/a, host:localhost/<IP_ADDRESS>:9090 - remote:/<IP_ADDRESS>:60802] UNREGISTERED
[2021-01-22 16:32:45,587] TRACE {http.tracelog.downstream} - [id: 0xff53a390, correlatedSource: n/a, host:localhost/<IP_ADDRESS>:9092 - remote:/<IP_ADDRESS>:60746] CLOSE
[2021-01-22 16:32:45,589] TRACE {http.tracelog.downstream} - [id: 0xff53a390, correlatedSource: n/a, host:localhost/<IP_ADDRESS>:9092 - remote:/<IP_ADDRESS>:60746] INACTIVE
[2021-01-22 16:32:45,590] TRACE {http.tracelog.upstream} - [id: 0x81540b81, correlatedSource: 0x65725019, host:/<IP_ADDRESS>:60746 - remote:localhost/<IP_ADDRESS>:9092] READ COMPLETE
[2021-01-22 16:32:45,591] TRACE {http.tracelog.downstream} - [id: 0xff53a390, correlatedSource: n/a, host:localhost/<IP_ADDRESS>:9092 - remote:/<IP_ADDRESS>:60746] UNREGISTERED
[2021-01-22 16:32:45,592] TRACE {http.tracelog.upstream} - [id: 0x81540b81, correlatedSource: 0x65725019, host:/<IP_ADDRESS>:60746 - remote:localhost/<IP_ADDRESS>:9092] INACTIVE
[2021-01-22 16:32:45,608] TRACE {http.tracelog.upstream} - [id: 0x81540b81, correlatedSource: 0x65725019, host:/<IP_ADDRESS>:60746 - remote:localhost/<IP_ADDRESS>:9092] CLOSE
[2021-01-22 16:32:45,610] TRACE {http.tracelog.upstream} - [id: 0x81540b81, correlatedSource: 0x65725019, host:/<IP_ADDRESS>:60746 - remote:localhost/<IP_ADDRESS>:9092] UNREGISTERED

Hop by hop headers are not allowed to passthrough. Hence behavior is correct

Hop by hop headers are not allowed to passthrough. Hence behavior is correct


Adding SECURITY.md

This Pull Request adds missing files to document SECURITY.md file. This files are required as part of the process to migrate kpack into CNB.
See for more details.
Fixes #1135

Based on this comment the idea is to keep this PR open and merge it after the migration to buildpack community org repo is executed


Fixed: Latest Article from blog Card in home page

#294 Fixed: Latest Article from blog Card in home page is completed please check and merge it.
@mdazfar2

@coderKrysio resolve your conflict and update sync fork

conflict resolved

if everything is working alright, please assign me the issue first and then merge accordingly

Hey @mdazfar2 Program Manager this side
Add hacktoberfest label to issues and hacktoberfest-accepted to Merged PRs also i dont think this PR is worth level 1 add level 2 label
Also make sure you add Hacktoberfest labels to only quality PRs.


Tests for #3 / #5

Thanks for the PR.  If you could merge this into your branch I'll merge that into master on my end. Thanks again.

Actually I swapped out speclj for clojure.test, so I'll close this PR, merge yours, and port the tests here into master in my repo.  Thanks again!


Expose OcBuildTimeout to overwrite the default value

/kind feature

Which functionality do you think we should add?
Fix the reason behind the flake https://github.com/openshift/odo/issues/2877. Actually one user found the same issue on his setup (Odo version : v1.1.3) and shared the detail analysis
User says:
I can confirm that the problem is the build timeout in odo.

I have modified the odo client, cloning the github repo, modified the file pkg/occlient/occlient.go and
 increase the value from the variable OcBuildTimeout in line 99 to 15 (default was 5), and the build
 finished successfully, injecting the resulting image name into the deploymentconfig.

diff --git a/pkg/occlient/occlient.go b/pkg/occlient/occlient.go
index 6e59dd646..637016acc 100644
--- a/pkg/occlient/occlient.go
+++ b/pkg/occlient/occlient.go
@@ -95,8 +95,8 @@ type CreateArgs struct {

 const (
        failedEventCount                = 5
-       OcUpdateTimeout                 = 5 * time.Minute
-       OcBuildTimeout                  = 5 * time.Minute
+       OcUpdateTimeout                 = 15 * time.Minute
+       OcBuildTimeout                  = 15 * time.Minute
        OpenShiftNameSpace              = "openshift"
        waitForComponentDeletionTimeout = 120 * time.Second

I believe the timeout in the default value is reached due to the amount of maven packages the build
 needs to download, and since our connection is not the fastest, the build reach this timeout and
exits.

Perhaps you can add an option in the future where the user can define the timeout value for the build
 in slow or low processing environments.

Why is this needed?
Now its clear that the issue not with the current odo backend code rather its an environment specific issue (I mean slow env or slow network), however we should expose a key that would overwrite the default build time out in case of slower environment. Also revisit the default OcBuildTimeout value.

ping @mik-dass

We can add this as a preference odo preference OpenShiftBuildTimeout 15

We can add this as a preference odo preference OpenShiftBuildTimeout 15

:+1:


podman: 1.6.2 -> 1.6.3

Motivation for this change
The slirp4netns change is needed for proper rootless containers to work.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

do you mind changing the outputs of podman to:
outputs = [ "out" "man" ];

That breaks the build (also after changing $bin to $out). I'll take a look at that later.

I think there's debug symbols pointing back to the compiler, if you grep the binary, you will find a store path to go

1.7.0 is already in master.


ReferenceError: exports is not defined

When trying to execute an node 'express' application I have the following issue:

var app = exports = module.exports = {};
^
ReferenceError: exports is not defined
at /Users/mathk/git/expresstest/node_modules/express/lib/application.js:37:19
at Object.exports.runInContext (vm.js:44:17)
at sbRequire (/Applications/LightTable.app/Contents/Resources/app/plugins/Javascript/node/ltnodeclient.js:99:10)

To reproduce:
$ mkdir test
$ node init
$ nam install express --save
Create a file app.js:
var express = require('express');
var app = express();

app.get('/', function (req, res) {
  res.send('Hello World!');
});

app.listen(3000, function () {
  console.log('Example app listening on port 3000!');
});

Then add a new connection in LT using the app.js.
Environment:
LT: 0.8.1
OS: OSX 10.11.3
Node: 5.6.0 ( Tested with 4.3.1 and 0.12.7 as well)

Previously reported as LightTable/LightTable#2146.

@mathk Is your third step an npm command?

yes that is a typo sorry


Support to assign license for group

Motivation
I'd like to fix the https://github.com/hashicorp/terraform-provider-azuread/issues/745 issue

Hi @kenchan0130, thanks for this and your other contributions to the SDK. At this time, I am not merging any further PRs here as I am going to deprecate this project imminently. We (HashiCorp) recently released a Microsoft Graph SDK that is now being used exclusively in the Terraform AzureAD provider instead of this SDK.
I encourage you to take a look at https://github.com/hashicorp/go-azure-sdk/tree/main/microsoft-graph. Many of the same paradigms have been implemented in the new SDK, with many improvements, and because the new SDK is auto-generated, it has massively more coverage.
For this use case, the new SDK has an AssignLicense() method in the microsoft-graph/groups/stable/group package, which implements this functionality.
As such, I'm going to close this PR, as the AzureAD provider has migrated to the new SDK and is no longer using this project. Thanks again!


Bots & Services, v1

I think a lot of us have been thinking about how to do bots on Rotonde, so I figured I would share what I've come up with thus far. Most things here feel obvious, but even the obvious benefits from documentation.

These are fairly straightforward to implement. You can post automatically whenever you are on your computer with Beaker (I think this is how poemexe got its first start).
You can also make use of dat's command-line interface to share over dat. I posted a guide on how to use this method for bots.
The caveat is that it requires a server of sorts, but I think that the majority of botmakers can accept this for the moment being. (Otherwise I have an experimental project that could be used, but I digress.)
Interactive Bots & Services
What's really interesting is building interactive bots and services ontop of Rotonde. The way to currently do that, as I see it, is to scrape the network. I'll outline out my thoughts on these matters so far.
I made a bot of this type called greeter, which says hi to you when you greet it!
See the code, follow at dat://1bd0f36ba074263a0dc3f0bcb504c59742b30f8c2d3e15b87cbe9cb04afdf575
Components
Crawler
The crawler grabs all of the known network's dat urls and stuffs them into a list. The list is then shared over as a dat, for everybody to use.
Currently The Rotonde List can be used for this, but the best solution would be to combine the Rotonde List (for finding people that are currently completely unconnected, new converts from Twitter etc) and an automated scraped list (for people that have joined and are connected, but aren't in the list).
(Rotolist by @aeonofdiscord is such a crawler. I based my own crawler  off of its code, many thanks to aeon for a good start!)
Scraper
The scraper gets all messages from the network using the crawler generated list and puts it all into a file. The file has one network message per line, for easy parsing. E.g.
for line in scraped:
  message = JSON.parse(line)
  if message.target == bot.dat:
     // do things

The Service
I think the two preceeding components will be pretty much present in any kind of p2p service or interactive bot, but now it becomes more speculative.
The service's portal.json can be shared in the manner outlined in my guide.
My current thoughts for a basic structure are the following:

Scrape network with scraper
Find messages with target=<bot.dat>
Check if message sender has bot.dat in portal.port
Execute message command
Reply with a whisper

Even better is to put this functionality in a client-side module. Using the scraped files this should now be possible.
The first service I wrote was a mention service, as discussed in #46. Its current incarnation is as a bot, but I think this would be a good fit for the client-side idea.
See the code, follow at dat://acf76768f02665825ccf7e205268833e096fc232a8cb933c0c12ee03bdd25ccd/
Scraped files
I maintain a list of the scraped network at dat://cb0fb0216c962b434e87fce98a5293e53595c136eac3f21b0c926a3a0d8a529c
Its content is as follows:
Messages
dat://cb0fb0216c962b434e87fce98a5293e53595c136eac3f21b0c926a3a0d8a529c/scraped.txt
each line has a json object containing a rotonde message as per the Specs, but with the addition of a key called source, attributing the message to the instance that created it
format <rotonde message object><newline>
Network
dat://cb0fb0216c962b434e87fce98a5293e53595c136eac3f21b0c926a3a0d8a529c/network.txt
each line has a dat portal as scraped from the network using my scraper. note: some of these don't work
format <portal.name><space><dat://..><newline>
Metadata
dat://cb0fb0216c962b434e87fce98a5293e53595c136eac3f21b0c926a3a0d8a529c/metadata.txt
each line contains a dat's portal.json, albeit with the feed set to an empty array
format <dat://...><space><stringified portal.json><newline>
The scraper itself can be found here and bugfixes, patches and similar PRs are very welcome! I would also love to see other people with bigger and better machines start scraping Rotonde!
Discussion
There are many concerns and ideas around this area, such as how to implement services in the future using Beaker's intents, declining being scraped by using a kind of robots.txt, and many more.
Known issues
dat-node occasionally breaks when closing utp connections using archive.close().
dat-node remember to call both archive.close() and archive.leave(), otherwise you will leak memory. (At least I did, I have an open issue where I'll look into it more.

Okay, I'm onto this.


[DOCFIX] Update use case links

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4841/
Test PASSed.

cherry-picked the PR from master, close this PR then


Add installer script

Fixes #68
Provide installation script and accompanying files for conda constructor installer build.

@constantinpape,
This is not ready for review.
I am waiting for micro-sam to be released as public conda package to finish this.
I am certain you can create a nicer image for thumbnails and backgrounds.

I am waiting for micro-sam to be released as public conda package to finish this.

The PR is already merged, see https://github.com/conda-forge/staged-recipes/pull/23374.
So it should be available by tomorrow. I will also work on a new release then, so that we have all the recent changes available.

I am certain you can create a nicer image for thumbnails and backgrounds.

I created a (first version of a) logo yesterday. You can use that:
https://github.com/computational-cell-analytics/micro-sam/blob/master/doc/images/micro-sam-logo.png

Hi @paulhfu ,
micro_sam is on conda-forge now: https://github.com/conda-forge/micro_sam-feedstock
I will work on a new release to include all the recent changes in the evening.

Hi @constantinpape,
This is somehow not working yet. Solving the environment is taking forever as soon as I am adding a package besides the micro_sam package. I tried on ubuntu and windows.
I will have to look a bit deeper. Also, I think setting mamba as the conda solver is not working. Maybe doing the detour over an env.yaml file is a better solution.

It is working when I create the env first manually with mamba and then build the installer from that.

It is working when I create the env first manually with mamba and then build the installer from that.

Ok, that sounds like a viable solution.

Hi @paulhfu ,
the CI issues are fixed now, so the tests here pass again. Let me know if this is ready to fully review.

Hi @constantinpape,
There are no artifacts produced and I also did not test the CI script yet.
Hope to finish with it tonight. I will let you know.

Hi @constantinpape,
There are still issues with creating a conda env in the workflow script. It seems that the windows workflow gets a bit further than the others. I will continue later with that.
(unrelated to this PR) but one thing I noticed, is that the file .github/workflows/doc_env.yaml is treated as workflow file.

Hi @paulhfu ,

There are still issues with creating a conda env in the workflow script. It seems that the windows workflow gets a bit further than the others. I will continue later with that.

Ok! Let me know if you are stuck somehow, or if I can help in any way.

(unrelated to this PR) but one thing I noticed, is that the file .github/workflows/doc_env.yaml is treated as workflow file.

Good point, I will fix it!

(unrelated to this PR) but one thing I noticed, is that the file .github/workflows/doc_env.yaml is treated as workflow file.

I fixed that in #105

Hi @constantinpape,
The Windows and Linux CI installers work fine.
I tried for some time now to get the macos CI installer to work.
It seems that I cannot install mamba via conda because libarchive is reluctant to install properly.
I did a detour using micromamba now which I can install with brew. But conda constructor has its issues with that.
Envs do not seem to be at the location where they are expected.
I will continue fixing this last issue.

I fixed the conda issue now. With release 0.1.1.post1 all the annotator commands work.
So the conda package should be ready for building the installer from it now.

I will continue fixing this last issue.

:+1:

Hi @constantinpape, this is ready for review now. The build of all installers is working fine.
Some notes:

I could not make the windows installer include the startmenu shortcut on Windows. I activated appending the Path variable, so the CLI should be available.
Macos installer looks a bit weird, but it is the only way that worked. Mamba installation over conda was not possible. Micromamba worked if installed with brew but was not accepted by constructor as a solver. Therefore mamba is installed over micromamba and constructor is called with mamba.
I could only test the windows and the ubuntu installer.

I could not make the windows installer include the startmenu shortcut on Windows. I activated appending the Path variable, so the CLI should be available.

Ok, having the start menu would be fairly important so that this can be used by "non-computational" users. But let's tackle this in a follow-up after I (and students) had a chance to tackle the current version.

Macos installer looks a bit weird, but it is the only way that worked. Mamba installation over conda was not possible. Micromamba worked if installed with brew but was not accepted by constructor as a solver. Therefore mamba is installed over micromamba and constructor is called with mamba.

Whatever works :).

I could only test the windows and the ubuntu installer.

Ok! I will test all three installers with students once it's merged and then see if there are any other issues or required changes to the installers themselve.

I was able to generate the startmenu on the machine that builds the installer. But constructor does not seem to pick up on it and it does not include it into the installer. I left the files which are necessary for the start menu in here for future work on it.
Documentation on menuinst is a bit tentative and it is also only supported for windows but it is mentioned, that it might also work on Macos and Ubuntu. I think that would also be worth a quick test.

I was able to generate the startmenu on the machine that builds the installer. But constructor does not seem to pick up on it and it does not include it into the installer. I left the files which are necessary for the start menu in here for future work on it.
Documentation on menuinst is a bit tentative and it is also only supported for windows but it is mentioned, that it might also work on Macos and Ubuntu. I think that would also be worth a quick test.

Ok, maybe we could open an issue on this in constructor to ask for help.
For now I will go ahead and merge it, so that we can test it here.
I will give you feedback as soon as we had a chance to test it! (Or let you know if any other issues arise.)


edit Portainer license info so that GitHub recognizes it

Hello! 👋
(CCing @dankohn who has requested this work so that the license will appear correctly in
https://landscape.cncf.io/selected=portainer)
GitHub uses a library called Licensee to identify a project's license
type. It shows this information in the status bar and via the API if it
can unambiguously identify the license.
This commit modifies a few of Portainer's docs so that Licensee is able
to recognize the repository's license type. It updates LICENSE so that
it contains only the text of the zlib license. It also moves the info
concerning 3rd-party software to a new "Licensing" section in the
README.
Collectively, these changes allow Licensee to successfully identify the
license type of Portainer as zlib.
For comparison purposes, here is the output that I get when I run Licensee locally on Portainer's remote repo:
$ licensee detect https://github.com/portainer/portainer
License:        Other
Matched files:  LICENSE
LICENSE:
  Content hash:  673eab1e0c6a41c7033245807db496235bc88703
  License:       Other
  Closest licenses:
    MIT similarity:   73.98%
    NCSA similarity:  67.66%
    Zlib similarity:  65.22%

And here is the output that I get when I run Licensee on the update-license branch of my local Portainer clone:
$ licensee detect ../portainer/
License:        zlib License
Matched files:  LICENSE
LICENSE:
  Content hash:  0e4bcdef920fc4997ebe96a2908a30b08fdc9b09
  Attribution:   Copyright (c) 2018 Portainer.io
  Confidence:    100.00%
  Matcher:       Licensee::Matchers::Exact
  License:       zlib License

Thanks @eirinikos :+1:

Thanks @deviantony !

Shouldn't you at least contact the original copyright holder before changing the license? ;)

@crosbymichael Just to be clear, we're not trying in any way to diminish your work or, in fact, to change the license. We saw this request as a reformatting so that GitHub would correctly understand that it is under the zLib license.

The original code is MIT as well as original license that should be in LICENSE (we could have edited it to be parsed via github).  I wouldn't care and would have said no problem, re-license the entire thing if you want, but no one even asked.  You know I'm pretty chill ;)


Tech Talk

I read someone that there was a talk given on this but now I can't find it for the life of me. Does anybody have a link?

I gave the talk this past Thursday and you can find the recording here.
I'll put a link in the README too in case other people look for it.