Adding StatefulDoFnRunner to DirectRunner demonstrates unstability

Added a new test that uses 2 keys, in this PullRequest that test fails most of the time. So its not a specific issue with the larger cache or the cache GC. As the small test only uses 2 values.

@rezarokni Can you please send link to the commit with the 2 key test?

Its pushed into this PR.
https://github.com/rezarokni/beam/commit/c471563392c1efbab3a101e8000747bc22b04f1e
Super interesting, I just tried adding a bunch more keys, so on the first OnTimer all state for all keys is available. However for the next OnTimer call, only the state for some of the keys remains, the other is wiped. One odd item is that datakey value is also cleared. That should only be done via the GC. But checking in my code again, was a while since I looked at this bit.

Hm, what you describe is exactly what should have been fixed by the PR apache#9190 (cherry-picked in this branch).

It appears to be working for the first key but not the rest. Although that could just be test artifact. Will try and find time to look through the 9190 either later this week or next.

Hm, I think I know the cause. If you apply this patch
diff --git a/runners/direct-java/src/main/java/org/apache/beam/runners/direct/WatermarkManager.java b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/WatermarkManager.java
index d8da1125da..f518aff4a9 100644
--- a/runners/direct-java/src/main/java/org/apache/beam/runners/direct/WatermarkManager.java
+++ b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/WatermarkManager.java
@@ -329,6 +329,12 @@ public class WatermarkManager<ExecutableT, CollectionT> {

     @VisibleForTesting
     synchronized void updateTimers(TimerUpdate update) {
+      if (!Iterables.isEmpty(update.getCompletedTimers())
+          || !Iterables.isEmpty(update.getSetTimers())
+          || !Iterables.isEmpty(update.getDeletedTimers())) {
+        System.err.println(
+            " *** timer update " + update + " at input watermark " + currentWatermark.get());
+      }
       NavigableSet<TimerData> keyTimers =
           objectTimers.computeIfAbsent(update.key, k -> new TreeSet<>());
       Table<StateNamespace, String, TimerData> existingTimersForKey =

You will notice something like this in case of failed test:
 *** timer update TimerUpdate(key=org.apache.beam.runners.local.StructuralKey$CoderStructuralKey@212804, setTimers=[TimerData{timerId=processTimer, namespace=Window([1999-12-25T00:00:00.000Z..2000-01-24T00:00:00.000Z)), timestamp=2000-01-01T00:15:00.500Z, domain=EVENT_TIME}], completedTimers=[TimerData{timerId=processTimer, namespace=Window([1999-12-25T00:00:00.000Z..2000-01-24T00:00:00.000Z)), timestamp=2000-01-01T00:15:00.000Z, domain=EVENT_TIME}], deletedTimers=[]) at input watermark 294247-01-10T04:00:54.775Z
 *** timer update TimerUpdate(key=org.apache.beam.runners.local.StructuralKey$CoderStructuralKey@212804, setTimers=[TimerData{timerId=__StatefulParDoGcTimerId, namespace=Window([1999-12-25T00:00:00.000Z..2000-01-24T00:00:00.000Z)), timestamp=2000-01-24T00:00:00.000Z, domain=EVENT_TIME}], completedTimers=[TimerData{timerId=processTimer, namespace=Window([1999-12-25T00:00:00.000Z..2000-01-24T00:00:00.000Z)), timestamp=2000-01-01T00:15:00.500Z, domain=EVENT_TIME}], deletedTimers=[]) at input watermark 294247-01-10T04:00:54.775Z

The timer processTimer was set up when the watermark was actually already at MAX_TIMESTAMP and the bundle already contained fired GC timer.
There is currently no simple workaround in user code. It can be solved in runner code, because runner knows the actual input watermark and can act accordingly. This way I solved it in apache/#8774
The only solution in user code, would be to create a hook in DirectRunner that will push back an already fired timer if some element being processed in current bundle causes a timer being setup for any time between current input and output watermark. That is pretty large refactoring I'm afraid.

Kenn have found the issue. This comment describes why it breaks for multiple keys: https://github.com/apache/beam/pull/9190/files#r313977188
Will fix that in the PR apache#9190 and then backport it here.

@rezarokni So, the test failures seem to be unrelated to a bug Kenn found, but I managed to get the tests passing (all but BiTemporalCacheTest) by changing Create to TestStream transform. That is strange and suggest, that there is still something wrong in DirectRunner that causes timers to behave incorrectly when using Create transform on input. Will look into that. Don't know what is happening with the BiTemporalCacheTest, though. The commit that fixed the other tests was https://github.com/rezarokni/beam/pull/2/commits/d31115592a5777a533627369b8a1dad02b818a80

Hm commit https://github.com/apache/beam/pull/9190/commits/aa94c344c03449b6b9680b83aee9a53c422d297e should reveal the failure in DirectRunner validatesRunner, but it seems to pass the test. Although the conditions should be somewhat similar to what happens in BiTemporalJoin. Mistery continues.

FYI raised https://issues.apache.org/jira/browse/BEAM-8090.
Kenn has some thoughts on this that he will explore.

Have started to validate these tests with different runners, so far its not reproducing outside of the DirectRunner. But will need to do more tests.
FYI for the commands, for others that may want to try things out:
To test in different runners:
Flink:
./gradlew :runners:flink:1.8:validatesRunnerStreaming --tests "**"
Dataflow:
You will need to set Command Line params for your Dataflow project, but same as above


Tutorial groups: Fix the contrast in the tutorial group rows in the dark mode

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Client

[ ] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
[x] I strictly followed the client coding and design guidelines.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[ ] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[ ] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[ ] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.
[ ] I translated all newly inserted strings into English and German.

Motivation and Context

When the tutors attempt to display all the tutorial groups, they face an issue with poor readability of the links in the corresponding rows due to low contrast in dark mode. This problem arises because the rows are highlighted in a cyan/blue color, making the clickable links (the titles of the tutorials) barely visible.
Description

The same color and contrast used to highlight elements in the left sidebar are also applied to the rows of the tutorial groups for tutors (Discussed with Ramona). By doing this, we maintain consistency in the coloring scheme and avoid hardcoded colors in the client. Additionally, we have removed the hovering effect when users hover over a row, as the row itself is not clickable, which was confusing for users. We keep the hovering effect for the clickable link (title of the tutorial).
Steps for Testing

Prerequisites:

2 Students
2 Tutorial Groups

Log in to Artemis
Navigate to Course Management
Select a Course
Navigate to Tutorials
Create a new Tutorial Group
Select the first student (Student X) as a tutor
Create another new Tutorial Group
Select the second student (Student Y) as a tutor
Log in to Artemis again as Student X
Navigate to Course
Click on Tutorials and show all Tutorial Groups
Verify that the row for the group that you are tutor for has the same contrast as the sidebar
Verify that the name of the tutorial is now easy to read in dark and light mode
Verify that there is no any hovering effect for the row, but for the name of the tutorial

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Screenshots

Before the fix:

After the fix:

Summary by CodeRabbit

Style

Updated styling for tutor and non-tutor roles in the tutorial groups table.

New Features

Enhanced the tutorial groups table by conditionally applying classes based on the user's tutor status.

This is also a dark mode issue related to tutorial groups. Do you want to fix this in this PR as well? #6448

This is also a dark mode issue related to tutorial groups. Do you want to fix this in this PR as well? #6448

Yes, thanks for pointing it out. I can fix that as well.

This is also a dark mode issue related to tutorial groups. Do you want to fix this in this PR as well? #6448

Yes, thanks for pointing it out. I can fix that as well.

After today's dev meeting, I talked to Ramona about this issue and she thought that since it is not super urgent to fix this, I will fix and create another PR for this towards the end of this week. Is it okay for you?


Android Client -> Master

update

Coverage remained the same at 81.818% when pulling 355b9695e213364ca13c1e345b796e22ec453cec on android-client into 183d3ccb057259b82ce7b476f0c6ecda7f8699de on master.

This doesn't do anything


Added Circular Linked List

Added traversal of Circular Linked List

Please Merge this PR of Circular Linked List as this project doesn't contain Circular Linked List.


'Not Showing X further errors and warnings' includes suggestions in count

VSCode Version:
OS Version:

Steps to Reproduce:

Install typescript@next
Select this as your workspace typescript version
Open the attached file as javascript manyUnused.txt. You should see ... suggestions on each of the consts.
Open problems panel

Bug
The problems panel shows none of the suggestions but still says Not showing 87 further errors and warnings

Does this issue occur when all extensions are disabled?: Yes

@mjbvz I see following

Problems panel shows the existing markers in the system. It seems there is a marker with message Not Showing 89 further errors and warnings. Hence it is shown.
Not sure what is the bug here

Not sure what is the bug here

the bug is that the suggestions are not shown in the error list. yet, the list says it is not showing them and 89 errors.
I  think this count should filter the suggestion diagnostics.

with https://github.com/Microsoft/vscode/issues/49687 we have made this of severity info


page_cache: eliminate PageWriteGuard

Since my #4994 , the page cache doesn't support mutating pages anymore.
The remaining role of PageWriteGuard is that of a fill handler. We can use FnOnce closures (or in an aysnc  future: a Future) for that.
So, make the change now.

I don't know, the new interface doesn't feel very nice to me. I think the PageWriteGuard was a fine approach. Was the motivation just to simplify things? I like that this is less lines of code, but other than that I'm not sure it's really simpler.

Motivation is the first point in https://github.com/neondatabase/neon/pull/5111
The second point in #5111 is addressed by my https://github.com/neondatabase/neon/pull/5122 which is stacked on top of this PR here.

FTR, as the remove_mapping function can stay sync, this PR isn't really required.  (originally I wanted to make remove_mapping async in #5023 but Christian asked me if it's really needed to be async).
Also, personally I prefer the approach to just set the counter to 0 to this PR, like suggested in https://github.com/neondatabase/neon/pull/5111.

Also, for the eventual switch to io-uring, having an owned buffer handle is required. PageWriteGuard is fit for that purpose. So, let's leave it and close this PR.


don't depend on github.com/xi2/xz

https://github.com/cilium/cilium/actions/runs/8180037886/job/22367286109?pr=31077 says:
The third party dependencies below are not allowed under the CNCF's IP policy:
  - github.com/xi2/xz (XZ)

cilium-cli indirectly depends on github.com/xi2/xz through github.com/mholt/archiver, which is used by sysdump to archive / unarchive. should be pretty straightforward to implement the same functionality with the standard libraries.

Should be fixed by https://github.com/cilium/cilium-cli/pull/2382


Please create templates for Bug, Improvement and Merge Request

Please create templates for Bug, Enhancement and Merge Request. Examples can be find in https://github.com/ansible/ansible/tree/devel/.github repository.

done


set autoReset default prop to true on ContextMenuItem component

Details
There are 2 usages in the app:

one for Copy to clipboard

one for context menu items
These are context menu actions:

Download
Copy URL to clipboard
Copy email to clipboard
Copy to clipboard
Copy link
Mark as unread
Edit comment
Delete comment

Except Mark as unread, set autoReset to true
Fixed Issues
$ https://github.com/Expensify/App/issues/12319
PROPOSAL: https://github.com/Expensify/App/issues/12319#issuecomment-1298066973
Tests

Login with any account
Go to any chat
Receive or send an attachment and hover it.
Click  "Download" icon in context menu to download attachment
Verify that icon is changed to checked and after about 2s, changed back to download icon.
Try clicking to "Download" icon again without clicking outside
Verify that attachment is downloaded again

[x] Verify that no errors appear in the JS console

QA Steps

Login with any account
Go to any chat
Receive or send an attachment and hover it.
Click  "Download" icon in context menu to download attachment
Verify that icon is changed to checked and after about 2s, changed back to download icon.
Try clicking to "Download" icon again without clicking outside
Verify that attachment is downloaded again

[ ] Verify that no errors appear in the JS console

PR Review Checklist
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots
Web
https://user-images.githubusercontent.com/97473779/200079870-3f2a4170-b26a-4d80-af0e-b6482f61803e.mov
Mobile Web - Chrome
https://user-images.githubusercontent.com/97473779/200079699-02dd7463-cf3e-4690-9a97-1b21062e6c80.mp4
Mobile Web - Safari
https://user-images.githubusercontent.com/97473779/200079746-73cea4e5-b2d4-4cb6-9f71-9f2704d252b1.mp4
Desktop
https://user-images.githubusercontent.com/97473779/200079573-9ed7237a-618a-486e-9c0e-74762970edfa.mov
iOS
https://user-images.githubusercontent.com/97473779/200079646-c8ce85e8-fad4-423d-8265-1ec9816afcf6.mp4
Android
https://user-images.githubusercontent.com/97473779/200079487-a461707a-3059-4489-ac91-daaef56f7d3e.mp4

Screenshots
Web
https://user-images.githubusercontent.com/9059945/200829224-299180d9-2f0d-4364-9516-33f3d090daa3.mov
Mobile Web - Chrome
https://user-images.githubusercontent.com/9059945/200829299-7f66be89-4016-4063-a581-525a79d7e042.mp4
Mobile Web - Safari
https://user-images.githubusercontent.com/9059945/200834055-a3fcb56e-3e7b-4c07-9334-a706ba74bd72.mov
Desktop
https://user-images.githubusercontent.com/9059945/200834027-a8f82dc5-d85f-497b-99e0-a79236db4fa8.mov
iOS
https://user-images.githubusercontent.com/9059945/200834161-698e1588-4d85-4e47-849e-c37edd3a8530.mov
Android
https://user-images.githubusercontent.com/9059945/200829331-bf2e19c8-b84f-4e75-b40e-49ccf785c17d.mp4

PR Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

I think you are wrong Melvin:

🚀 Deployed to staging by @iwiznia in version: 1.2.26-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
failure ❌

🚀 Deployed to staging by @iwiznia in version: 1.2.26-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @yuwenmemon in version: 1.2.26-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Improve documentation about the default command keybindings

If focus is in the tree, Tab first selects the "Edit Headline" icon. Only afterwards does Tab select the body.
If focus is in the body, neither Tab nor Enter change focus. Insert they insert a character.

@edreamleo

If focus is in the tree, Tab first selects the "Edit Headline" icon. Only afterwards does Tab select the body.

I can't change this behavior, but I could perhaps make the 'edit' icon command on the nodes to be absent by default... Not sure yet what to think about this... I'll think about it. :)

If focus is in the body, neither Tab nor Enter change focus. Insert they insert a character.

As it should, hehe, :) this is for the command to 'Focus on body', not to be executed when focus is on the body (Otherwise how would someone type an enter or a tab in the editor?)
Please provide a screenshot (Shift+Windows Key+S) to drag and click. and the paste directly in here to illustrate which source you are reading those keybindings from so that I can understand exactly where those come from.
(You referred in another issue about a 'keybinding list', a 'readme' and lastly a 'webpage'. All three for which I'm unsure if it's from the leojs repo, or Leo's repo, or some other webpage)

@boltex I think we agree about what is happening. This issue is only concerned with the description of the  and  keys.
In vs-code, in the description of LeoJS, in the "Keybindings" section, the entry for "Focus on Binding" is misleading.

As you say, the <tab> and <enter> binding has effect only if the focus is in the outline. But the entry implies that these two bindings apply everywhere.
This is a minor point, but it actually confused me the first time!
I suggest splitting the "Focus on Body" line into two lines:

Focus on Body (in any pane):  Alt-D or Ctrl-G
Focus on Body (only in Outline Pane): Tab or Enter

Clear?

@boltex

You referred in another issue about a 'keybinding list', a 'readme' and lastly a 'webpage'. All three for which I'm unsure if it's from the leojs repo, or Leo's repo, or some other webpage.

Imo, this question is moot. I have already closed #127 because the desired web page already exists, namely:
https://github.com/boltex/leojs
More specifically, this section: https://github.com/boltex/leojs?tab=readme-ov-file#keybindings

@boltex Note that the links to the readme above are in the master branch.  I think that's good enough.

@edreamleo The PR is now merged in the dev branch.

@boltex Thanks :-)


Multi-Room Music (MRM) setup issue

Hello AVS-Team,

When I used the MRM function based on AVS1.12, I found that SampleApp reported an error when
running:
2019-03-21 01:26:29.773 [  1] E
CapabilitiesDelegate:capabilityMapIncorrectlyFormed:reason=interfaceTypeNotAvailable
2019-03-21 01:26:29.774 [  1] E
CapabilitiesDelegate:registerCapabilityFailed:reason=capabilityNotDefinedCorrectly
2019-03-21 01:26:29.774 [  1] E
DefaultClient:initializeFailed:reason=unableToRegisterCapability,capabilitiesDelegate=MRM

AlexaClientSDKConfig.json add:
"mrm": {
"amazonId": "xxxxxx",
"audioPlayerDeviceName": "hw:0,2",
"audioPlayerSampleRate": 48000,
"audioPlayerOffsetDurationNs": 0,
"clockNominalDriftPpm": "0.0",
"clockDriftTolerancePpm": "20.0",
"audioClockSystemClockDriftPpm": "0.0"
},
"capabilitiesDelegate":{
"endpoint": "https://api.amazonalexa.com",
"overridenCapabilitiesPublishMessageBody": {
"envelopeVersion":"20160207",
"capabilities":[
{
"type":"AlexaInterface",
"interface":"WholeHomeAudio",
"version":"1.1"
}
]
}
},

Maybe there is something wrong with the configuration. Do you have the configuration instructions of
MRM? Or how to set up the MRM so that it works properly? Do you have a reference manual?

Thanks!

I have solved the above problem.  Need modify:
+/// Device Capability Framework - MRM interface type
+static const std::string MRM_CAPABILITY_INTERFACE_TYPE = "AlexaInterface";
+/// Device Capability Framework - MRM interface name
+static const std::string MRM_CAPABILITY_INTERFACE_NAME = "WholeHomeAudio";
+/// Device Capability Framework - MRM interface version
+static const std::string MRM_CAPABILITY_INTERFACE_VERSION = "1.1";
But how to set up a bedroom or living room ?

Hi @xurenjun, if you have set this up correctly, then when running and connected to AVS your MRM-capable devices should be available to create groups in your Alexa companion app in the SmartHome->Groups->MRM Groups section.  Let us know if that does not seem to work.

Thanks  @dhpp   I`m not found "SmartHome->Groups->MRM Groups section". But when I setup MRM groups via Alexa APP, I found some problems:
When the two platform devices are running, I can see the two online devices on the APP side:

But when I choose renjun xu1, renjun, xu2 becomes Device Unreachable:

when I choose renjun xu2, renjun, xu1 becomes Device Unreachable:

I see some errors in the log, but I'm not sure if this is the cause？

I see some errors in the log, but I'm not sure if this is the cause？

Hi @xurenjun thank you for sending us the log. We are currently looking into it and will let you know once we have more information on this.

Hi @xurenjun,
Instead of GitHub, a direct channel between your company and Amazon is more suitable for the contents of your question. I am closing this issue and we are looking forward to continue working with you when you reach us through the other channel.
Regards,


Crash on idle

Hyprland Version
Hyprland, built from branch main at commit e68c07d8096ee5f83e29508c8762279ab80a924b dirty (renderer: don't render window on other mons during anim in).
Date: Sun Mar 17 02:05:26 2024
Tag: v0.37.1-6-ge68c07d8
flags: (if any)
System Information:
System name: Linux
Node name: arch
Release: 6.8.1-arch1-1
Version: #1 SMP PREEMPT_DYNAMIC Sat, 16 Mar 2024 17:15:35 +0000
GPU information:
0b:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 22 [Radeon RX 6700/6700 XT/6750 XT / 6800M/6850M XT] [1002:73df] (rev c0) (prog-if 00 [VGA controller])
os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo
plugins:
Bug or Regression?
Bug
Description
When going idle (with hypridle btw.) whole desktop crashes (very) randomly. To the point that is hard to reproduce.
How to reproduce
hyprctl dispatch dpms off
Crash reports, logs, images, videos
I took liberty of uniq because that same line repeats...

cat .cache/hyprland/hyprlandCrashReport1330.txt | uniq
--------------------------------------------
   Hyprland Crash Report
--------------------------------------------
I tried so hard, and got so far...

Hyprland received signal 11 (Segmentation fault)

Version: e68c07d8096ee5f83e29508c8762279ab80a924b
Tag: v0.37.1-6-ge68c07d8

System info:
	System name: Linux
	Node name: arch
	Release: 6.8.1-arch1-1
	Version: #1 SMP PREEMPT_DYNAMIC Sat, 16 Mar 2024 17:15:35 +0000

GPU:
	0b:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 22 [Radeon RX 6700/6700 XT/6750 XT / 6800M/6850M XT] [1002:73df] (rev c0) (prog-if 00 [VGA controller])

os-release:
	NAME="Arch Linux"
	PRETTY_NAME="Arch Linux"
	ID=arch
	BUILD_ID=rolling
	ANSI_COLOR="38;2;23;147;209"
	HOME_URL="https://archlinux.org/"
	DOCUMENTATION_URL="https://wiki.archlinux.org/"
	SUPPORT_URL="https://bbs.archlinux.org/"
	BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
	PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
	LOGO=archlinux-logo

Backtrace:
	#0 | Hyprland(_Z12getBacktracev+0x66) [0x6503407c42a6]
		getBacktrace()
		??:?
	#1 | Hyprland(_ZN13CrashReporter18createAndSaveCrashEi+0x6c8) [0x650340785118]
		CrashReporter::createAndSaveCrash(int)
		??:?
	#2 | Hyprland(_Z25handleUnrecoverableSignali+0x48) [0x650340717c38]
		handleUnrecoverableSignal(int)
		??:?
	#3 | /usr/lib/libc.so.6(+0x3c770) [0x795c31949770]
		??
		??:0
	#4 | /usr/lib/libc.so.6(+0x157437) [0x795c31a64437]
		absolutePath(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
		??:?
	#5 | /usr/lib/dri/radeonsi_dri.so(+0x8317f8) [0x795c264317f8]
		??
		??:0
	#6 | /usr/lib/dri/radeonsi_dri.so(+0x832440) [0x795c26432440]
		??
		??:0
	#7 | /usr/lib/dri/radeonsi_dri.so(+0x838a5a) [0x795c26438a5a]
		??
		??:0
	#8 | /usr/lib/dri/radeonsi_dri.so(+0x59747f) [0x795c2619747f]
		??
		??:0
	#9 | /usr/lib/dri/radeonsi_dri.so(+0x236406) [0x795c25e36406]
		??
		??:0
	#10 | Hyprland(_ZN13CHyprRenderer9endRenderEv+0x87) [0x65034085c317]
		CHyprRenderer::endRender()
		??:?
	#11 | Hyprland(_ZN13CHyprRenderer13renderMonitorEP8CMonitor+0x6b4) [0x650340851594]
		CHyprRenderer::renderMonitor(CMonitor*)
		??:?
	#12 | Hyprland(_Z13handleWrappedP11wl_listenerPv+0x5b) [0x6503407cdbfb]
		handleWrapped(wl_listener*, void*)
		??:?
	#13 | /usr/lib/libwayland-server.so.0(wl_signal_emit_mutable+0x7e) [0x795c3238401e]
		??
		??:0
	#14 | /usr/lib/libwayland-server.so.0(wl_event_loop_dispatch_idle+0x23) [0x795c32385a23]
		??
		??:0
	#15 | /usr/lib/libwayland-server.so.0(wl_event_loop_dispatch+0xfd) [0x795c32385b3d]
		??
		??:0
	#16 | /usr/lib/libwayland-server.so.0(wl_display_run+0x27) [0x795c323862d7]
		??
		??:0
	#17 | Hyprland(main+0x7ee) [0x6503406fed3e]
		main
		??:?
	#18 | /usr/lib/libc.so.6(+0x25cd0) [0x795c31932cd0]
		??
		??:0
	#19 | /usr/lib/libc.so.6(__libc_start_main+0x8a) [0x795c31932d8a]
		??
		??:0
	#20 | Hyprland(_start+0x25) [0x650340714bc5]
		_start
		??:?

Log tail:
[LOG] Registered signal for owner<PHONE_NUMBER>40: 650342683b78 -><PHONE_NUMBER>40 (owner: layerSurface)
[LOG] Registered signal for owner<PHONE_NUMBER>40: 6503433a9288 -><PHONE_NUMBER>a8 (owner: layerSurface)
[LOG] Registered signal for owner<PHONE_NUMBER>40: 6503433a9298 -><PHONE_NUMBER>10 (owner: layerSurface)
[LOG] Registered signal for owner 650343df8710: 650342683b88 -> 650343df8890 (owner: CPopup Head)
[LOG] LayerSurface 650342683ab0 (namespace hyprpaper layer 0) created on monitor DP-1
[ERR] BUG THIS: No CWLSurface for surface in damageSurface!!!
[WARN] Orphaned wlr_surface 6503433a8fa0 in setPreferredScaleForSurface
[WARN] Orphaned wlr_surface 6503433a8fa0 in setPreferredTransformForSurface
[ERR] BUG THIS: No CWLSurface for surface in damageSurface!!!
[WARN] Orphaned wlr_surface 6503433a8fa0 in setPreferredScaleForSurface
[WARN] Orphaned wlr_surface 6503433a8fa0 in setPreferredTransformForSurface
[LOG] LayerSurface 650342683ab0 mapped
[LOG] Registered signal for owner<PHONE_NUMBER>20: 6503433a92b8 -><PHONE_NUMBER>68 (owner: CWLSurface)
[LOG] Registered signal for owner<PHONE_NUMBER>20: 6503433a9278 -><PHONE_NUMBER>d0 (owner: CWLSurface)
[LOG] CWLSurface<PHONE_NUMBER>20 called init()
[LOG] LayerSurface 6503427fe990 unmapped
[LOG] Framebuffer created, status 36053
[LOG] Callback 6503433ddea0 -> 6503433dde98, CWLSurface removed.
[LOG] Callback 6503433ddf08 -> 6503433ddf00, CWLSurface removed.
[LOG] CWLSurface 6503433dde30 called destroy()
[LOG] LayerSurface 6503427fe990 destroyed
[LOG] Callback 650343d2aff8 -> 650343d2aff0, CPopup Head removed.
[LOG] Callback 6503433de0b0 -> 6503433de0a8, layerSurface removed.
[LOG] Callback 6503433ddf78 -> 6503433ddf70, layerSurface removed.
[LOG] Callback 6503433ddfe0 -> 6503433ddfd8, layerSurface removed.
[LOG] Callback 6503433de048 -> 6503433de040, layerSurface removed.
[LOG] Cleanup: destroyed a layersurface
[LOG] Registered signal for owner 6503433ddc50: 6503433a2468 -> 6503433de088 (owner: layerSurface)
[LOG] Registered signal for owner 6503433ddc50: 650342a5cbb8 -> 6503433ddf50 (owner: layerSurface)
[LOG] Registered signal for owner 6503433ddc50: 6503433a2478 -> 6503433ddfb8 (owner: layerSurface)
[LOG] Registered signal for owner 6503433ddc50: 6503433a2488 -> 6503433de020 (owner: layerSurface)
[LOG] Registered signal for owner 650343d2ae50: 650342a5cbc8 -> 650343d2afd0 (owner: CPopup Head)
[LOG] LayerSurface 650342a5caf0 (namespace hyprpaper layer 0) created on monitor DP-2
[ERR] BUG THIS: No CWLSurface for surface in damageSurface!!!
[WARN] Orphaned wlr_surface 6503433a2190 in setPreferredScaleForSurface
[WARN] Orphaned wlr_surface 6503433a2190 in setPreferredTransformForSurface
[ERR] BUG THIS: No CWLSurface for surface in damageSurface!!!
[WARN] Orphaned wlr_surface 6503433a2190 in setPreferredScaleForSurface
[WARN] Orphaned wlr_surface 6503433a2190 in setPreferredTransformForSurface
[LOG] LayerSurface 650342a5caf0 mapped
[LOG] Registered signal for owner 6503433dde30: 6503433a24a8 -> 6503433dde78 (owner: CWLSurface)
[LOG] Registered signal for owner 6503433dde30: 6503433a2468 -> 6503433ddee0 (owner: CWLSurface)
[LOG] CWLSurface 6503433dde30 called init()
[LOG] LayerSurface 650343ca5c80 unmapped
[LOG] Framebuffer created, status 36053
[LOG] Callback 650343394dd0 -> 650343394dc8, CWLSurface removed.
[LOG] Callback 650343394e38 -> 650343394e30, CWLSurface removed.
[LOG] CWLSurface 650343394d60 called destroy()
[LOG] LayerSurface 650343ca5c80 destroyed
[LOG] Callback 650343e02438 -> 650343e02430, CPopup Head removed.
[LOG] Callback 650343394fe0 -> 650343394fd8, layerSurface removed.
[LOG] Callback 650343394ea8 -> 650343394ea0, layerSurface removed.
[LOG] Callback 650343394f10 -> 650343394f08, layerSurface removed.
[LOG] Callback 650343394f78 -> 650343394f70, layerSurface removed.
[LOG] Cleanup: destroyed a layersurface
[LOG] Callback 650343df06f0 -> 650343df06e8, CRenderbuffer removed.
[LOG] Callback 650343d45fa0 -> 650343d45f98, CRenderbuffer removed.
[ERR] Couldn't commit output DP-2
[LOG] Hyprctl: dispatcher dpms : off
[backend/drm/legacy.c:180] connector DP-2: drmModePageFlip failed: Device or resource busy

I am plagued with the same issue. Also I'm running into a problem where one of my monitors does not turn on after dpms off and I have to replug it to get it working again, this used to happen before but not as often as with the recent releases.
My backtraces differ from crash to crash:
Backtrace:
	#0 | Hyprland(_Z12getBacktracev+0x62) [0x55a0da714162]
		getBacktrace()
		??:?
	#1 | Hyprland(_ZN13CrashReporter18createAndSaveCrashEi+0x5d7) [0x55a0da6d4337]
		CrashReporter::createAndSaveCrash(int)
		??:?
	#2 | Hyprland(_Z25handleUnrecoverableSignali+0x4c) [0x55a0da651e4c]
		handleUnrecoverableSignal(int)
		??:?
	#3 | /usr/lib/libc.so.6(+0x3c770) [0x70912385a770]
		??
		??:0

Backtrace:
	#0 | Hyprland(_Z12getBacktracev+0x4a) [0x59da4774718a]
		getBacktrace()
		??:?
	#1 | Hyprland(_ZN13CrashReporter18createAndSaveCrashEi+0x720) [0x59da47708820]
		CrashReporter::createAndSaveCrash(int)
		??:?
	#2 | Hyprland(_Z25handleUnrecoverableSignali+0x44) [0x59da4769f084]
		handleUnrecoverableSignal(int)
		??:?
	#3 | /usr/lib/libc.so.6(+0x3c770) [0x77750d16e770]
		??
		??:0
	#4 | /usr/lib/libwayland-server.so.0(wl_list_insert+0x18) [0x77750dc2bc38]
		??
		??:0
	#5 | /usr/lib/libwayland-server.so.0(wl_signal_emit_mutable+0x3e) [0x77750dc2bfde]
		??
		??:0
	#6 | /usr/lib/libwlroots.so.13032(wlr_output_schedule_frame+0xa) [0x77750dc9195a]
		??
		??:0
	#7 | /usr/lib/libwayland-server.so.0(wl_signal_emit_mutable+0x7e) [0x77750dc2c01e]
		??
		??:0
	#8 | /usr/lib/libwlroots.so.13032(+0x717cf) [0x77750dca97cf]
		??
		??:0
	#9 | /usr/lib/libwayland-server.so.0(+0xb9ba) [0x77750dc2d9ba]
		??
		??:0
	#10 | /usr/lib/libwayland-server.so.0(wl_resource_destroy+0xc9) [0x77750dc2f7a9]
		??
		??:0
	#11 | /usr/lib/libffi.so.8(+0x7596) [0x77750d090596]
		??
		??:0
	#12 | /usr/lib/libffi.so.8(+0x400e) [0x77750d08d00e]
		??
		??:0
	#13 | /usr/lib/libffi.so.8(ffi_call+0x123) [0x77750d08fbd3]
		??
		??:0
	#14 | /usr/lib/libwayland-server.so.0(+0x8ada) [0x77750dc2aada]
		??
		??:0
	#15 | /usr/lib/libwayland-server.so.0(+0xd180) [0x77750dc2f180]
		??
		??:0
	#16 | /usr/lib/libwayland-server.so.0(wl_event_loop_dispatch+0xa2) [0x77750dc2dae2]
		??
		??:0
	#17 | /usr/lib/libwayland-server.so.0(wl_display_run+0x27) [0x77750dc2e2d7]
		??
		??:0
	#18 | Hyprland(main+0x7eb) [0x59da4768651b]
		main
		??:?
	#19 | /usr/lib/libc.so.6(+0x25cd0) [0x77750d157cd0]
		??
		??:0
	#20 | /usr/lib/libc.so.6(__libc_start_main+0x8a) [0x77750d157d8a]
		??
		??:0
	#21 | Hyprland(_start+0x25) [0x59da4769c115]
		_start
		??:?

@RisaI do you have in your config...
misc {
        mouse_move_enables_dpms = true
        key_press_enables_dpms = true
}

?

@grappas only key_press_enables_dpms = true

I had a bunch of random freezes with the latest version, and latest Nvidia drivers, but turns out for me that swayidle and swaylock were the ones causing the issue. Perhaps that's worth checking.
I'm still working on testing hypridle and hyprlock, to see if the crashes return.

No crashes so far. Closing for now.

No crashes so far. Closing for now.

Which version you using?

-git


Pyinstaller Error

Pyinstaller Error in version 0.4.0:
Traceback (most recent call last):
File "lt1.py", line 8, in
File "PyInstaller\loader\pyimod03_importers.py", line 540, in exec_module
File "curl_cffi_init_.py", line 39, in
ImportError: DLL load failed while importing _wrapper:

Please see if this section in the README helps.

Please see if this section in the README helps.

Yes, I tried to package the program with this command: pyinstaller -F .\example.py --hidden-import=_cffi_backend --collect-all curl_cffi, but the problem still persists。

Could you please share more details so that I can try compile on my laptop?


Calorie Counter - Step 45: single/double quote order shouldn't matter

Describe the Issue
The test is expecting the double quotes for the inner string. It should allow for both.
"input[type='text']"

or
'input[type="text"]'

Tests:
https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-form-validation-by-building-a-calorie-counter/63c2164c0df38a382062c4af.md
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-form-validation-by-building-a-calorie-counter/step-45
Your code

Expected behavior
Allow any order for the quotes.
Screenshots
No response
System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
Forum: https://forum.freecodecamp.org/t/learn-form-validation-by-building-a-calorie-counter-step-45/719651

i see another issue with the same step where it accepts .length() as valid. (I can fix this and the original issue together)


In-App Message created from a non-UI thread on Android

Version(s) of SDK bug appears: 3.0.0-beta.1
Current Behavior
I have tested in-app messages by sending some test to my phone :
The message is displayed in my test, but I got a dangerous error message on the Logcat

It seems that the Banner (or Dialog) is created from a non-UI Thread
Steps to Reproduce
Phone Model :
OnePlus 5T - Android 10
Huawei P20 - Android 10
OnePlus 6T - Android 11
App Target :
Send an in-app Example Banner or Example Welcome

    const val targetSdkVersion = 32
    const val compileSdkVersion = 32

Expected Behavior
The Overlay should be created from UI Thread

Hey @petitTrung, thanks for bringing this to our attention. We are working on a fix and will be rolling it out soon.

Hey @petitTrung, closing the loop here. I believe this was fixed and rolled out but the issue never got closed. Feel free to reopen if you still face it.


"Run query" button should be disable meanwhile a query is in process.

Observation: I tried clicking the "run query" button multiple times while a query was processing, Meanwhile it processed the empty queries and resulted in "Query not entered!" multiple times.
It can be annoying for the user when a query takes much time to process and the user keeps clicking the button.
Recommendation: "Button should be disabled until the previous query is being processed".
"Procedure": I throttled the browser to 3G, and run a single query, and clicked the "run query" button multiple times.

Hi @KamleshKumar427
You are right.I tried the same approach and observe this, its quite annoying.

What if the "run query" button is only clickable when the query box is not empty. This could prevent showing error when clicking multiple times. Additionally, this could allow execution a faster query while a slower query is still running though I'm not sure if this would work because I was not able to test it. Even after throttling, the first query would return faster than I could run a second one.

Hello, @AhmarZaidi good observation to run multiple queries simultaneously.
Since PostgreSQL is able to handle 100+ clients at a time, But for that, I guess PostgreSQL opens multiple sessions.
Therefore I am not sure whether a single session can run multiple queries or not.
I will confirm it and then will let you know.

This wouldn't be appropriate as it would block multiple queries being submitted. Client picks an available connection from a pool of open connections to submit other queries. Here's an example of a first query that takes longer to process than the second query. Second query made returns first.


<RT-1.2>Set MED and configure BGP policy

Explicitly specify MED Value and configure BGP Policy

Pull Request Functional Test Report for #2634 / 87dbdce8c9a7fbd04f0cac19f3997b354001eaec
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

RT-1.2: BGP Policy & Route Installation
720bd461
Log

Cisco 8000E

RT-1.2: BGP Policy & Route Installation
718dfad4
Log

Cisco XRd

RT-1.2: BGP Policy & Route Installation
5b556a58
Log

Juniper cPTX

RT-1.2: BGP Policy & Route Installation
4cf5009c
Log

Juniper ncPTX

RT-1.2: BGP Policy & Route Installation
6083ae4c
Log

Nokia SR Linux

RT-1.2: BGP Policy & Route Installation
65f7a0d4
Log

Openconfig Lemming

RT-1.2: BGP Policy & Route Installation
dd5070f5
Log

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

RT-1.2: BGP Policy & Route Installation

Cisco 8808

RT-1.2: BGP Policy & Route Installation

Juniper PTX10008

RT-1.2: BGP Policy & Route Installation

Nokia 7250 IXR-10e

RT-1.2: BGP Policy & Route Installation

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 52.141%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1668

Relevant Lines:
3199

💛  - Coveralls


🐛📧 — Fix small email validation bug.

Description

I can't use my 100% valid email address with Franz, meaning that the email validation is incorrect and doesn't follow the appropriate standards.
Motivation and Context

I can't change my email to<EMAIL_ADDRESS>the same that I use for GitHub, through the Franz application.

However, if I login and change it through the website I don't have an issue. It also updates within the application.

How Has This Been Tested?

I tested the regex on https://regex101.com. There might be more email addresses incorrectly marked as invalid but I'm not sure how Franz should be rewritten to allow them all to work as they should. As far as I know, the best practice is just to check if it has a @ and looks somewhat sane, then just send a confirmation email to check if it actually works.
Here's a relevant talk on email validation (Apologies for the bad audio):
https://www.youtube.com/watch?v=xxX81WmXjPg
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project (run $ yarn lint).

@adlk we should probably use validator.isEmail from https://www.npmjs.com/package/validator instead!

@DominikGuzei good idea! It also works well with @Snuggle's email.
https://runkit.com/adlk/5cf81bf9d403d1001a9d8106

I have not a clue how to import libraries within this project but I've given it a try! :blush:
Could I please ask how to test this outside of CI, since I don't know if this is correct or not. :two_hearts:

Running npx lerna bootstrap updated the package-lock.json with a couple dependencies (Including validator.js). Should all of this be committed? Why did it add a dependency called "@meetfranz/theme"?

Thanks for the update @Snuggle your code looks good but i need to make some minor changes to make it work 👍 i will create a separate branch since i cannot commit to yours 😉

@DominikGuzei I just turned on "Allow edits from maintainers." I didn't realise that was off. :stuck_out_tongue:

Thanks @Snuggle, it's already done now but for next time 😉

We will add you as contributor to the changelog 🥇

Thanks! ♥


Add ability to permit/deny access to GOV.UK Forms on a per user basis

What problem does the pull request solve?
Currently Signon is used to manage whether a user has access to GOV.UK Forms. If we wanted to remove a users access, we would do that via Signon. To be able to migrate away from Signon, we need a way to restrict access to a user from within our service. (Note this is not about deleting a user). Only super admins will be able to remove or restore access.
We've done this by adding a has_access attribute on the User model to avoid any double negative confusion that may result from reusing the disabled attribute from Signon. A before_action is then used to show denied users a dropout page.
Trello card: https://trello.com/c/p8b7WDYn

Reading through the code it looks like the content on the super admin edit user pages and access denied pages is all good 👍🏻
Screenshots can be helpful 😄


test: add test comments to header file

for iperf we may need customerize the ports in test farm.
so add an test Anchor commnets here for each replacement
Signed-off-by: Hake Huang<EMAIL_ADDRESS>

Hi @hakehuang, are you able to redefine NX_IPERF_TCP_RX_PORT and NX_IPERF_UDP_RX_PORT in project settings for testing purpose?

Hi @hakehuang, are you able to redefine NX_IPERF_TCP_RX_PORT and NX_IPERF_UDP_RX_PORT in project settings for testing purpose?

yes, we can. But modify project is not good for portable, as we plan to port this application to different IDE, set the marco in line maybe more portable friendly.

Hi @hakehuang, are you able to redefine NX_IPERF_TCP_RX_PORT and NX_IPERF_UDP_RX_PORT in project settings for testing purpose?

yes, we can. But modify project is not good for porting, as we plan to port this application to different IDE, set the marco in line maybe more portable friendly.

How about adding those definitions in nx_user.h as per https://docs.microsoft.com/en-us/azure/rtos/netx-duo/chapter2#configuration-options?

How about adding those definitions in nx_user.h as per https://docs.microsoft.com/en-us/azure/rtos/netx-duo/chapter2#configuration-options?

@TiejunMS, as these configuration is not netx stack related, it is pure the iperf related, so I would prefer to keep the code as is.

@TiejunMS any more comments on this PR. Thanks in advance.


Fix the caching is not supported on this batch system error (resolves #931)

resolves #931

@hannes-ucsc

Commit message is too long.

@arkal, please remove needs work label when you think this is ready to review.

@hannes-ucsc it's ready

Jenkins, test this please.

Jenkins, test this please.

The build triggered by https://github.com/BD2KGenomics/toil/pull/932#issuecomment-224394775 hung. See #953 for follow-up.

Build failure tracked in #906.
Commit message is still too long. Look at where GitHub wraps it on this page. We can't have that. Sorry.

@arkal

Hahaha i thought you were joking (sarcastically) about the lack of a "message" in the commit since the "title" is self explanatory. I'll fix this now

@hannes-ucsc i implemented the suggested changes


Not really an issue

Good Day.
I wonder if im allowed to use this script for my own needs?
If so: Would you please tell me, where i can create my own contract address?
Thanks in Advance and Best Regards from Germany.

Sure it is under MIT license, feel free to do anything with the source code.


Flagger Linkerd Canary Split is not seen on Data Plane

I went through the Flagger/Linkerd demo  and it is working fine if you look at the control plane, but the data plane does not look right. I documented it here. I am not sure how to debug this further and whether this is a known issue or a new problem. I have this running on minikube and you can run this same demo on minikube by cloning this repo and running it. I needed at least 3CPUs and in my setup I had 6GB of memory for minikube.

I think the NGINX headers could be the problem, if you look at the docs, the port is hardcoded https://docs.flagger.app/tutorials/linkerd-progressive-delivery#linkerd-ingress

I figured out the issue with Ingress, I documented here in the thread with Linkerd community... https://discourse.linkerd.io/t/configure-traffic-split-with-nginx-ingress-controller/1003/18


Docker image fails to build with Python 3.10

I'm trying to build the binwalk Docker image, and it seems to be failing:
$ sudo docker build -t binwalk https://github.com/ReFirmLabs/binwalk.git
Sending build context to Docker daemon  49.89MB
Step 1/13 : FROM python:3-buster AS build-and-install
 ---> 9fb898c38240
Step 2/13 : ENV PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/src/app/bin     DEBIAN_FRONTEND=noninteractive
 ---> Using cache
 ---> 2dcdf7235932
Step 3/13 : COPY . /tmp
 ---> Using cache
 ---> a54f21c91897
Step 4/13 : WORKDIR /tmp
 ---> Using cache
 ---> f4c1f945cd2f
Step 5/13 : RUN set -xue     && apt-get update -qy     && apt-get -t buster dist-upgrade -yq --no-install-recommends -o Dpkg::Options::="--force-confold"     && ./deps.sh --yes     && python3 setup.py install && binwalk -h > /dev/null     && apt-get -yq purge *-dev git build-essential gcc g++     && apt-get -y autoremove     && apt-get -y autoclean     && echo "en_US.UTF-8 UTF-8" >> /etc/locale.gen     && echo "LANG=en_US.UTF-8" >> /etc/default/locale     && echo "LANGUAGE=en_US:en" >> /etc/default/locale     && echo "LC_ALL=en_US.UTF-8" >> /etc/default/locale     && locale-gen
 ---> Using cache
 ---> 6ba603d19180
Step 6/13 : FROM build-and-install AS unit-tests
 ---> 6ba603d19180
Step 7/13 : RUN pip install coverage nose     && python3 setup.py test     && dd if=/dev/urandom of=/tmp/random.bin bs=1M count=1 && binwalk -J -E /tmp/random.bin
 ---> Running in 0994d1bfcc2e
Collecting coverage
  Downloading coverage-6.2-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (215 kB)
Collecting nose
  Downloading nose-1.3.7-py3-none-any.whl (154 kB)
Installing collected packages: nose, coverage
Successfully installed coverage-6.2 nose-1.3.7
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
WARNING: You are using pip version 21.2.4; however, version 21.3.1 is available.
You should consider upgrading via the '/usr/local/bin/python -m pip install --upgrade pip' command.
running test
Traceback (most recent call last):
  File "/tmp/setup.py", line 330, in <module>
    setup(
  File "/usr/local/lib/python3.10/site-packages/setuptools/__init__.py", line 153, in setup
    return distutils.core.setup(**attrs)
  File "/usr/local/lib/python3.10/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/usr/local/lib/python3.10/distutils/dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "/usr/local/lib/python3.10/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/tmp/setup.py", line 302, in run
    retval = nose.core.run(argv=['--exe','--with-coverage'])
  File "/usr/local/lib/python3.10/site-packages/nose/core.py", line 301, in run
    return TestProgram(*arg, **kw).success
  File "/usr/local/lib/python3.10/site-packages/nose/core.py", line 118, in __init__
    unittest.TestProgram.__init__(
  File "/usr/local/lib/python3.10/unittest/main.py", line 100, in __init__
    self.parseArgs(argv)
  File "/usr/local/lib/python3.10/site-packages/nose/core.py", line 179, in parseArgs
    self.createTests()
  File "/usr/local/lib/python3.10/site-packages/nose/core.py", line 193, in createTests
    self.test = self.testLoader.loadTestsFromNames(self.testNames)
  File "/usr/local/lib/python3.10/site-packages/nose/loader.py", line 481, in loadTestsFromNames
    return unittest.TestLoader.loadTestsFromNames(self, names, module)
  File "/usr/local/lib/python3.10/unittest/loader.py", line 220, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/local/lib/python3.10/unittest/loader.py", line 220, in <listcomp>
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/local/lib/python3.10/site-packages/nose/loader.py", line 454, in loadTestsFromName
    return LazySuite(
  File "/usr/local/lib/python3.10/site-packages/nose/suite.py", line 53, in __init__
    super(LazySuite, self).__init__()
  File "/usr/local/lib/python3.10/unittest/suite.py", line 22, in __init__
    self._tests = []
  File "/usr/local/lib/python3.10/site-packages/nose/suite.py", line 106, in _set_tests
    if isinstance(tests, collections.Callable) and not is_suite:
AttributeError: module 'collections' has no attribute 'Callable'
The command '/bin/sh -c pip install coverage nose     && python3 setup.py test     && dd if=/dev/urandom of=/tmp/random.bin bs=1M count=1 && binwalk -J -E /tmp/random.bin' returned a non-zero code: 1

This appears to be an issue brought on by Python 3.10, in which the deprecated aliases to Collections Abstract Base Classes from the collections module were removed.
I believe the bug should be fixed in the upstream nose library, but it appears to be unmaintained.  :-/
--
EDIT 1/20 for typo

FWIW, my PR #454 switches tests to use pytest instead, which is very much maintained.


Having 5 hours+ generating GDS

Link to my wokwi project
I build a flipflop based register file and it is generating its GDS for almost 5 hours and 21 minutes until now.

It looks like a yosys is having problems with a logic loop:
https://github.com/Talha-Ahmed-1/tinytapeout_flop_regfile/runs/8058049296?check_suite_focus=true#step:8:219
not sure why tbh. I looked at your design and couldn't see a problem.
Thanks for letting me know

Is there any chance for me to submit this design in tinytapeout.

I've started a discussion in the discord forum: https://discord.com/channels/1009193568256135208/1009193744504987749/1013910369233809429

try to find a loop in your wokwi design

ok the loops are here:

change them for the flip-flop standard cell and see if that helps

Does this implementation of flop failed in comb loop again?

I suggest you try and see what happens!
Matt
On Mon, 29 Aug 2022 at 23:56, Talha Ahmed @.***> wrote:

[image: image]
https://user-images.githubusercontent.com/52505840/187305877-11bcd912-a6f4-4760-b59a-ff3d02a2dbd7.png
Does this implementation of flop failed in comb loop again?
—
Reply to this email directly, view it on GitHub
https://github.com/mattvenn/wokwi-verilog-gds-test/issues/5#issuecomment-1230903928,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE223HTTIKTUDHXV5IPD2TV3UWXDANCNFSM573RBQNA
.
You are receiving this because you were assigned.Message ID:
@.***>

--
Matthew Venn
web mattvenn.net twitter @matthewvenn https://twitter.com/matthewvenn


chore(deps): update common-dev-assets digest to 25d44f7

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
27ef988 -> 25d44f7

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.4.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add control flow / utility functions to the workflow engine

This PR adds the following functions to the workflow engine:

Name
Description

foreach
Run a task for each of the elements in a list.

http
Invoke simple http requests.

switch
output a value based on the value of an expression.

while
Run a task until a condition evaluates to true.

fail
A function that always fails; which can be used to short-circuit a workflow.

Additionally, this PR...

adds (optional) server version information to the fission version command
updates the builder env and environment proxy to conform with the Fission health checking.

Before merging:

[ ] Finalize foreach + example
[x] Add example while

I'm pretty excited about this one 😀 I'd love to see some examples.

Bringing the output discussion into the comments here. I think we need to give users some way to run "map", i.e. run a task on each element of an array and collect the output into another array.  That doesn't have to be a builtin, but there needs to be a way for the user to implement that.

@erwinvaneyk I see lots of code commits, but can we have a discussion before merging this to make sure these new builtins actually solve the problem they're intended to solve?

@soamvasani sure, I am not merging this until your and Madison's 👍

Updating from slack conversation @erwinvaneyk's adding a flag to collect output of tasks in foreach.

I run this branch to solve some other problems on 0.2 and I couldn't make workflow send body as json to function (it does on 0.2 successfully and flask can parse request and return json response without any problem).
This is what I did extra for forcing to pass json but still not working:
....
  helloworld:
    run: task
    inputs:
      content_type: 'application/json'
      default:
        hello: "Hey"
        world: "universe"
      headers:
        "Content-Type": "application/json"

It sends binary value after whatever I do: b'\n\x1c\n\nworld\x12\x0e\n\x06string\x12\x04universe\n\x1a\n\thello\x12\r\n\x06string\x12\x03universe'

Hey @thenamly - I have been working on this problem offline. the content type (indeed one of the last issues that needs to be resolved before 0.3.0 release). Same goes for the forcing of the content-type. Will update the branch later today.


Fixed identation +

The description for the pull request above (i have my keyboard):
hi!
after change the generator's spec last time, i realized i messed up the identation. it was ugly, really, and everyone should be anoyed about how the code was generated.
So i fixed it.
Plus, i refactored #tableize.singularize for just #undescore. (#tableize does #undescore.pluralize :P so it was doing the job twice)


Entity Not Defined

Mô tả lỗi / Describe the bug
When I add the sensor to the Energy Dashboard it returns the error, Entity not defined"
Logs
No error in logs
Ảnh chụp / Screenshots

Server (thông tin máy chủ đang chạy HA):

OS: Proxmox 7.1
HA platform: HAOS
HA Version: 2022.9.5

Integration (thông tin phiên bản Integration đã cài đặt):

Installation method: HACS
Version: v.2.1.0

Thông tin thêm
Thêm những thông tin khác ngoài các thông tin kể trên.

Hi @Builder-DE-TH, đó là thông tin của entity cũ từ phiên bản trước mà bạn chưa xóa.
Lỗi này xảy ra do bạn không gỡ thiết bị cũ hoàn toàn trước khi cài đặt EVN phiên bản mới nhất.

Thanks for this.
How do I make sure I have the old version deleted?
Where are the files that need to be deleted?

Well,
You can try adding a new sensor entity into the energy dashboard with the id (your customer id here)_econ_total_new.
Unfortunately, please pay attention that adding sensors into Energy dashboard is currently not supported for all regions in Vietnam, so the data might be messed up, or even not available.
This feature is in experimental process (with crossed fingers).

OK.
I tried adding the new sensor but that didn't work.
I deleted the old version incorrectly but I deleted 2.1.0 correctly and the new sensor (and old ones) are still showing up in the energy dashboard dropdowns.
I didn't know that the energy dashboard was experimental at the moment.
Will I open a feature request to remove them upon deleting?

Sure @Builder-DE-TH, that would be great.


Blueprints (CIP-0057) as build artifacts

Still TODO:

[x] Add a new aiken address to easily compute the address of a given validator.
[ ] Amend the CIP-0057 PR to reflects changes adopted while implementing this.
[ ] Update the website's user guides

:round_pushpin: Draft basic Blueprint schema type definition.
This doesn't include validations yet. Let's start simple
and try to get some basic schema generated already.

:round_pushpin: Refactor build steps to generate blueprints instead
The blueprint is generated at the root of the repository and is
intended to be versioned with the rest. It acts as a business card
that contains many practical information. There's a variety of tools
we can then build on top of open-source contracts. And, quite
importantly, the blueprint is language-agnostic; it isn't specific to
Aiken. So it is really meant as an interop format within the
ecosystem.

:round_pushpin: Refactor test collection to use the new CheckedModules method
And also, caught a little issue regarding the filtering of test cases.

:round_pushpin: Move UPLC dump into separate function + log event.
Compiling aiken-lang/stdlib 43d8e740ffdf5febc59e51b7f0d5f8506115340c (examples/hello_world/build/packages/aiken-lang-stdlib)
Compiling aiken-lang/hello_world 1.0.0 (examples/hello_world)
Generating project's blueprint (examples/hello_world/plutus.json)
Exporting UPLC (examples/hello_world/artifacts)

:round_pushpin: Add title to blueprint's validators
And use it to prefix UPLC artifacts' names.

:round_pushpin: Add title and description to exported types in the blueprint
This also fixes a bug where the documentation of record constructor arguments would be dropped after type-checking. Took me a while to pinpoint.

:round_pushpin: Refactor blueprint & handle annotated schemas
This also now introduce two levels of representable types (because it's needed at least for tuples):
Plutus Data (a.k.a Data) and UPLC primitives / constants (a.k.a Schema).
In practice, we don't want to specify blueprints that use direct UPLC primitives because there's little support for producing those in the ecosystem. So we should aim for producing only Data whenever we can. Yet we don't want to forbid it either in case people know what they're doing. Which means that we need to capture that difference well in the type modelling (in Rust and in the CIP-0057 specification).
I've also simplified the error type for now, just to provide some degree of feedback while working on this. I'll refine it later with proper errors.

:round_pushpin: Allow testing blueprint generation from Aiken programs
This is quite something, because now we have a testing pipeline that
can also be used for testing other compiler-related stuff such as the
type-checker or the code generator.

:round_pushpin: Support tuples in blueprint generation.

:round_pushpin: Add support for generics in the blueprint generation.

:round_pushpin: Fix nested generics and phantom-types, and handle list special case
List of pairs are actually encoded as 'map'.

:round_pushpin: Handle opaque single-variant-single-field special case.

:round_pushpin: Fix help on unknown::module error.

:round_pushpin: Improve error reporting for the blueprint generation.
Actually link schema error to source code with a span and a label. This is easily done and provides some extra context.

:round_pushpin: Use IndexMap throughout
In an ideal world, I should have handlded that directly at the conflicting commit in the rebase, but this would have bubbled up through all commits... which I wasn't really quite keen on going through. So here's an extra ugly commit that comes and 'fix the rebase'.

:round_pushpin: Replace 'assets' with generated blueprints.

:round_pushpin: Better use of From/Tryfrom within the blueprint module.

:round_pushpin: Define serde's Serialize/Deserialize for Program
This will be useful to re-use this behavior in other structure that contains a Program without having to manually serialize or deserialize the entire structure.

:round_pushpin: Implement serde's Deserialize for blueprints.
Here's a trick though: I got lazy (a bit) and did not write a full deserializer for Schema because this is busywork and not at all necessary at this stage. Instead, I've made the blueprint parameterized by a generic type ; which represents the type of the underlying blueprint's schema. When deserializing from JSON, we can default to 'Value' to get a free deserializer. Since all we're interested about is the program and the metadata (purpose and title) of a validator, it works nicely.
Serialization however expects a Blueprint, and most of the functions operates over a Blueprint anyway.

:round_pushpin: Implement new command: address
This calculates a validator's address from validators found in a blueprint. It also provides a convenient way to attach a delegation part to the validator if needs be. The command is meant to provide a nice user experience and works 'out of the box' for projects that have only a single validator. Just call 'aiken address' to get the validator's address.
Note that the command-line doesn't provide any option to configure the target network. This automatically assumes testnet, and will until we deem the project ready for mainnet. Those brave enough to run an Aiken's program on mainnet will find a way anyway.

Errors preview:

@rvcas I've addressed your comments and added a new command aiken address to fill the gap that this change was introducing:

// Adding an extra `mint` validator to the file...


TypeError: Cannot read property 'properties' of undefined

I clone three-seed and follow the instructions and get the following result:
npm install
npm WARN deprecated<EMAIL_ADDRESS>Package no longer supported. Contact<EMAIL_ADDRESS>for more info.

><EMAIL_ADDRESS>install /Users/ep/Documents/_ThreeJS_Projects/bm-font-ex/node_modules/fsevents
> node install

node-pre-gyp WARN Tried to download(404): https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.2.4/fse-v1.2.4-node-v67-darwin-x64.tar.gz
node-pre-gyp WARN Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v67 ABI, unknown) (falling back to source compile with node-gyp)
  SOLINK_MODULE(target) Release/.node
  CXX(target) Release/obj.target/fse/fsevents.o
In file included from ../fsevents.cc:6:
../../nan/nan.h:1064:44: warning: 'ToString' is deprecated: Use maybe version [-Wdeprecated-declarations]
      v8::Local<v8::String> string = from->ToString(v8::Isolate::GetCurrent());
                                           ^
/Users/ep/.node-gyp/11.2.0/include/node/v8.h:2537:3: note: 'ToString' has been explicitly marked deprecated here
  V8_DEPRECATED("Use maybe version",
  ^
/Users/ep/.node-gyp/11.2.0/include/node/v8config.h:326:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated(message)))
                            ^
../fsevents.cc:63:6: warning: field 'async_resource' will be initialized after field 'lockStarted' [-Wreorder]
   : async_resource("fsevents:FSEvents"), lockStarted(false) {
     ^
^[[A2 warnings generated.
  SOLINK_MODULE(target) Release/fse.node
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreServices.framework/CoreServices.tbd and library file /System/Library/Frameworks//CoreServices.framework/CoreServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork.tbd and library file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList are out of sync. Falling back to library file for linking.
  COPY /Users/ep/Documents/_ThreeJS_Projects/bm-font-ex/node_modules/fsevents/lib/binding/Release/node-v67-darwin-x64/fse.node
  TOUCH Release/obj.target/action_after_build.stamp
npm WARN<EMAIL_ADDRESS>No repository field.
npm WARN<EMAIL_ADDRESS>No license field.

npm start
> webpack-dev-server --mode development

/Users/ep/Documents/_ThreeJS_Projects/bm-font-ex/node_modules/webpack-cli/bin/config-yargs.js:89
				describe: optionsSchema.definitions.output.properties.path.description,
				                                           ^

TypeError: Cannot read property 'properties' of undefined
    at module.exports (/Users/ep/Documents/_ThreeJS_Projects/bm-font-ex/node_modules/webpack-cli/bin/config-yargs.js:89:48)
    at Object.<anonymous> (/Users/ep/Documents/_ThreeJS_Projects/bm-font-ex/node_modules/webpack-dev-server/bin/webpack-dev-server.js:84:40)
    at Module._compile (internal/modules/cjs/loader.js:722:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:733:10)
    at Module.load (internal/modules/cjs/loader.js:620:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
    at Function.Module._load (internal/modules/cjs/loader.js:552:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:775:12)
    at startup (internal/bootstrap/node.js:300:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:826:3)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `webpack-dev-server --mode development`
npm ERR! Exit status 1
npm ERR! ```

Try updating the project to 0.3.2, I've updated the stale packages.


Lock screen issue

Hi!
I don't want my app logic is available when screen is locked.
But when somebody is calling and screen is locked  - I want it to be visible.
I've reached this logic. Before call logic - my app doesn't work in background mode. Then somebody is calling and app is locked - I see calling screen , can answer. But after call my app becomes available in lock mode.
How can it be fixed?
Thanks

@rekonvald you can use the method ConnectycubeFlutterCallKit.setOnLockScreenVisibility(isVisible: true) for enabling/disabling lock screen visibility for your app after finishing call and navigation to your app.

no activity for a long time, so closing


JAR file with minimal content is identified as multiple maven packages

Describe the bug
Not sure if this is strictly a bug (it's more dodgy-data), but I felt it was worth raising, as it caused confusion.
A local build had created some intermediate JARs which only contained a single file: META-INF/MANIFEST.MF with placeholder created/modified dates.
When scanned, the JAR was identified as matching multiple different maven packages.
After investigating, it seems that the issue is that there are JAR files in the (OSS?)index that have matching contents & modified dates.
These JAR files seem to be related to failed releases.
Identifiers
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)

Version of dependency-check used
The problem occurs using version 7.4.0 of the cli
Log file
https://gist.github.com/andy-may-at/4e9234c02d5676e0942d691ab7d00346
To Reproduce
Steps to reproduce the behavior:
I've created a repo with example jar & example output
git clone https://github.com/paulsamuels/cve-false-positive-example
cd cve-false-positive-example
dependency-check --scan reproduces-issue.jar

Expected behavior
Jar to not be identified as any known package
Additional context
Evidence & additional detail in https://github.com/paulsamuels/cve-false-positive-example
README of that repo is reproduced below:
I'm pretty sure that the root cause of this is twofold:

Some index of .jar files contains the hashes of broken/incomplete releases that had almost nothing in their .jar files (I'm guessing the OSSIndex)
A local build produces some .jar files with matching content

Not sure if this is something that needs to be 'fixed' in dependency-check, but thought it was worth sharing
Repository contents

reproduces-issue.jar - a JAR that reproduces the issue when scanned
dependency-check-report.html - an example scan report
jar-with-different-modified-dates.jar a JAR which is identical apart from modified/created dates & does not reproduce the issue (has different MD5/SHA1/SHA256)

Steps to reproduce

Found with dependency-check CLI 7.4.0 installed on M1 Mac

> git clone https://github.com/paulsamuels/cve-false-positive-example
> cd cve-false-positive-example
> dependency-check --scan reproduces-issue.jar

The generated report identifies the jar as being multiple maven packages.
How the issue was found:

A java build ends up producing some .jar files that only contain a META-INF/MANIFEST.MF file

That file only contains the content:

Manifest-Version: 1.0

Both the file & it's parent META-INF directory have created+modified dates of 1 February 1980 at 00:00
A dependency check is run that scans the .jar
(Issue found in dependency-checker 7.4.0 CLI installed via homebrew)
The dependency-check output reports (with highest confidence) that the .jar is an instance of a lot of other java packages:

Identifiers
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)
<EMAIL_ADDRESS>(Confidence:Highest)

The identified packages seem to exist in the Sonatype OSSIndex, but have not been published to Maven Central.
They smell like failed releases.
Other evidence
A .jar file with content that has the same Manifest file content (but different modified dates) does not get identified as these maven packages
e.g. jar-with-different-modified-dates.jar

Thank you for the very detailed write-up. This is an odd one - the best solution is going to be for us to basically ignore that SHA1:
<suppress base="true">
   <notes><![CDATA[
   FP per #5118
   ]]></notes>
   <sha1>5b8f86fea035328fc9e8c660773037a3401ce25f</sha1>
   <cpe regex="true">.*</cpe>
</suppress>

Fixed via https://github.com/jeremylong/DependencyCheck/issues/5122


feat: add crlfmt configuration

Describe your changes
Adding the crlfmt formatter, a gofmt-style formatter for Go code that enforces the CockroachDB Style Guide.
Issue ticket number and link

Checklist before requesting a review

[x] I have successfully tested installation of the package.
[x] I have successfully tested the package after installation.

Screenshots

Oh, interesting.
I generated the version by running the following command:
go list -f '{{.Version}}' -m github.com/cockroachdb/crlfmt@master

To verify it works, I created a temp registry release, containing only the package above. You can see the release files here: https://github.com/rail/mason-registry/releases/tag/crlfmt
Then to verify it installs correctly I added the following entry in the lazy setup:
  {
    "williamboman/mason.nvim",
    opts = {
      registries = {
        "github:rail/mason-registry@crlfmt",
        "github:mason-org/mason-registry",
      },
    },
  },

So far it works as expected. I wonder how CI is different. 🤔

Yeah installation of the package will work fine, it's just how mason.nvim gathers available versions for it (CI runs in "strict" mode which will cause installation to fail early if the provided version is not available upstream). Upstream in this case is the https://proxy.golang.org/ API: https://proxy.golang.org/github.com%2Fcockroachdb%2Fcrlfmt/@v/list, which returns nothing (compared to e.g. https://proxy.golang.org/golang.org%2Fx%2Ftools%2Fgopls/@v/list).

Yes! Tagged versions are very much preferred than tracking HEAD

Here we go
$ curl https://proxy.golang.org/github.com%2Fcockroachdb%2Fcrlfmt/@v/list
v0.1.0

Thank you very much!


throttle events

resolves ACM-8455
the magic of the asm UI architecture is that if there's change in kube, it will be automatically and instantly reflected in the ui. The downside of this is if the UI is monitoring lots of resources and events happen all at once-- or if a resource is thrashing it's results or both
to fix this problem, if an event passes into the throttler:

if that policy hasn't ever had an event, the event it just sent on--the magic lives on
however if the same policy sends another event within 10 seconds, the throttle holds onto it
if after 10 seconds nothing more happens, that event is sent on
however if lots of events happen. we use standard deviation to see if the compliance is thrashing (a big sd = thrashing)
a. if thrashing, the compliance is set to noncompliant
this event is then sent if it doesn't match the compliance in the event queue---iow client doesn't know the current state of the compliance

there is a policy thrasher in eventUtils.ts:
that is accessed through event.ts:
import { WatchEvent, ServerSideEventData, thrashEvents, purgeEvents, throttleEvents } from '../lib/eventUtils'
export function startWatching(): void {
ServerSideEvents.eventFilter = eventFilter
for (const definition of definitions) {
void listAndWatch(definition)
}
// thrashEvents(cacheResource) <<<<<<<<<<<<<< uncomment me
}
Signed-off-by: John Swanke<EMAIL_ADDRESS>

ok, how about this:

The UI shows the resource is thrashing--- instead of indicating Compliant/NonCompliant we add Fault or Error to indicate a thrashing policy-- I bet that would have helped out in your case and would definitely help out here since all the field can report is 7.5gb of background data over an hour
To be cautious I would start with just policy -- it seems important that the bug mentions policy a lot and that's the. kind of thing that was made to change a lot

and 4. are bugs that can bee fixed


Application Tracker complete

Application Tracker correctly shows which sections are complete. Submission is blocked unless all necessary sections are complete.

Looks good accessibility-wise, except the existing contrast issues.
Need to merge and put on GCcollab before I can do a more in-depth review with a tester.


Please Specify Licence

Hi folks, what licence is this? MIT? BSD? Want to verify if ok to actually use this code for all purposes without issue. Appreciate it.

Done. You can use it however you wish

Thank you for the quick response and making the emoji picker available for possible use.

I see https://github.com/woody180/vanilla-javascript-emoji-picker/commit/6339ae9d013e618b53d56f8c49931f91b557fc41#diff-c693279643b8cd5d248172d9c22cb7cf4ed163a3c98c8a3f69c2717edd3eacb7 but this file is no longer in master.
Thanks!

Done. LICENSE file is included


How to run?

How do you run this bot? Where in Python?
cd [bot path] don't do anything
python.exe ]bot path] just returns syntax errors
Then how?

I'm stuck in pip install requirements.txt, t will just say pip is not an internal command

Install pip on your system, then?

If you properly follow the instructions, this should run without issue on any system that has Python3.4 installed.


chore(deps): update module github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper to v1.10.4

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.10.2 -> v1.10.4

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper
v1.10.4
Compare Source
Bug Fixes

bug keep statefile(#564) (2f66c32)

v1.10.3
Compare Source
Bug Fixes

Update packages (#563) (76d8e3e)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Parsing error for font

Hi @mattdesl - I'm receiving the following error when requiring my font-file and trying to load it into my scene:
events.js:85
      throw er; // Unhandled 'error' event
            ^
Error: Parsing file /[...]/webgl-experiments/assets/fonts/[font].ttf: Unexpected character '

Is this what you mean in your notes by "fails with some fonts" or "is not yet very stable or well-tested"?  Any ideas on how I can get passed this for now?
Thanks!

Ah - so update on this.  It works with your files from fontpath-test-fonts - so it's likely a problem with the ttf/otf I'm trying to use.  Even still though, if this experiment fares well for me, I will need to work on getting my font into the page, and would love your help if at all possible.

You may have figured it out already but it seems like the fonts from fontpath-test-fonts are already parsed json files. If you'd like to parse an "in the wild" ttf, it looks like you will want to parse it with [fontpath] (https://github.com/mattdesl/fontpath-test-fonts/blob/master/build.sh#L16). However, it seems like that is a wrapper around freetype2 which is a wrapper around a native library.
opentype looks to be a JS solution however I'm not entirely confident on its compatibility with fontpath.


simgrid: 3.28 -> 3.29 + python + clean

This commit makes nixpkgs simgrid in sync with NUR-Kapack's.

use latest SimGrid release
enable the python binding (in new output "python")

Here is the detailed history of changes in NUR-Kapack that led to this commit.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.
[x] Checked that closure size did not increase.

Thanks for the reviews! I just pushed 02c1160b7056cf5a to apply them.

Superseded by #157617.


Addition of Imperal Gallons for UK users

In the UK, we measure fuel consumption in imperial miles per gallon, but use litres to fill. The existing conditional statement will only allow imperal gallons if the fuelUnit == gal. This may work in most parts of the world, however for us strange brits using litres this results in iffy readings. This is a corrective fix to resolve this.
Has been tested against manual conversions - any feedback appreciated.

Hi, thanks for the PR.
I’ve not looked at this in quite a while but doesn’t the application already take into account the difference between Imperial and US gallons? When I wrote this I did it with imperial gallons in mind (I’m English) but last year a bug was brought to light where mpg was not being calculated correctly when the user’s fuel unit was Gal (US).
The consumption converter doesn’t distinguish “mpg” and “mpg(Imperial)” because for the sake of conversion it checks the user’s specific fuel unit before converting. “mpg” is an interchangeable term.
Can you illustrate the issue you were seeing please?

Hi JoshStark - cheers for getting back to me.
Yes, so the issue can be easily shown in this little code snippet here
if ('mpg' === consumptionUnit) {             const fuelUnitAsGallons = ('gal' === fuelUnit ? fuelUnitConversion.toGallons() : fuelUnitConversion.toGallonsUS());             return Math.round((distanceUnitConversion.toMiles() / fuelUnitAsGallons) * 100) / 100;         }
Setup as a UK user, my consumptionUnit is mpg, but my fuel unit is litres not gal. As such, the lambda expression evaluates to using fuelUnitConversion.toGallonsUS(), resulting in the incorrect result.
One possible (and better for integration long term) alternative solution I thought of after submiting the PR is to instead expand the condition of the lambda statement to be either 'gal' OR 'l'. This would achieve the same goal.
eg have soemthing like
const fuelUnitAsGallons = ('gal' === fuelUnit || 'l' === fuelUnit ? fuelUnitConversion.toGallons() : fuelUnitConversion.toGallonsUS());
Or even better
const fuelUnitAsGallons = ('gal (US)' === fuelUnit ? fuelUnitConversion.toGallonsUS() : fuelUnitConversion.toGallons());
This would be better. Opinions would be good though, and hopefully I've explained this error properly.

Ah, now I see. I hadn’t taken into account litres. I think your second suggestion is the best option. If you update the PR to make the statement as such I don’t see why I can’t accept it.

No worries, thanks for taking the time to make the change.

No worries. That looks good.


datepicker does not support date range neither a method to change Min/Max Date

datepicker does not support the feature to select a range between two dates.
In the previous version (pickadate plug in) it works better than this all new writen datepicker plugin.
It does not even have a Method to change the initial options, and, for examaple, to change the MinDate and MaxDate options on change the start/end date input fields.
Also the possibility of pick only months isnt possible.
Thanks

Yes there is something wrong with the Library... if I try to use Dropdown, it does not work anymore either!
I think we started from an old or outdated Version!