Busy waiting

in src\JsonRpc\OutputHandler.cs there is a tight loop plus a Delay/Sleep() which looks quite inefficient to me. I've prepared a pull request for this, you might want to look into.
There is a similar one in src\JsonRpc\InputHandler.cs at private async void ProcessRequestQueue(), but I'm afraid I'm to dumb to understand, what is done there. So could you please evaluate, if you could probably change the  ConcurrentQueue<> to a BlockingCollection<> plus a CancellationTokenSourcehere as well?
Thanks
Martin

The call to Delay / Sleep only happens when the Queue has been drained.  If there are still pending requests / responses in the queue then there will no wait.  The intent is to avoid having a few threads constantly running in circles waiting for events to be received.  If there is a better implementation, I'm totally open to using alternatives.

The intent in ProcessRequestQueue is to avoid processing requests strictly in serial.  IRequestProcessIdentifier allows the implementer to decide what can be done in parallel, and what must be done in serial.
For example a text change event will almost always be blocking, as it will affect any of the next requests that happen.  However something like autocomplete, or signature help are not bound in that way.  This way those requests can be served back to the editor as fast as possible.
Strictly speaking the protocol says all requests must respond in order received, but this allows an implementer the ability to bypass some of that for endpoints that don't affect the overall solution.
Note: I haven't started a real integration some of these implementations will likely change.

(1) on "The call to ...": I only agree partly. The queue is almost always empty or seldom contains one item, so assuming a configured delay of 50ms, the old consumer thread burns some cycles, only to check the queue is empty, waits 50ms, repeat and drains the battery. Now assume a unit of work arrives in the middle of the 50ms delay, then for 25ms plus thread switching time nothing happens, except delay. The new code should not burn CPU cycles, if there is nothing to do. And it has no lag besides task switching time. If the queue is longer than one item, all work is done at top speed, just as before.
Thanks for accepting my fix.

(2) on "The intent in ...": Before I feel confident enough to offer you a change, could you please verify/comment on these statements:

In general: all units of work are scheduled in parallel and started in parallel, except ...
... an item in _queue marked as Serial waits for all previously scheduled units of work to be finished, plus ...
... processing the queue items blocks on the finishing of such a Serial item.

If all of this is true, I propose this algorithm, assuming item.start returns something awaitable:
let waitables = new list of waitable objects
loop forever
  let item = blocking dequeue
  if item is Serial then
    wait-for-all waitables
    waitables.clear
    wait-for item.start
  else
    waitables.add item.start

(2) it's now working on my machine, but I think it needs more testing.

However that will breakdown if the queue is empty, and there has been no serial item.  I haven't had enough tests in that specific area to really say for sure what would work and what wouldn't yet.

Yes, a memory leak, you are right. However I don't think it would be a breakdown:. The q sits on it's blocking dequeue, all tasks are started but no one is waiting for then. I'm preparing a fix for that: in the else clause there could be some housekeeping that removes the completed tasks from the waitables list. That would not be perfect, but performant.
But: This leads to another question: Could you please make up your mind, how an item's task exception could be handled (i.e. here, in the InputHandler and in the OutputHandler)? I guess they are ignored now, aren't they, and this is an opportunity for trouble? I suggest an error service (IHandleExceptions : void Post(int id, Exception)) injected to all relevant components.
Regading tests. In my branch on that https://github.com/Lercher/csharp-language-server-protocol/tree/inputhandler-refactoring, I've factored out the scheduling component and added some tests for it.

Done. It's not perfect, if many items would be added simultaneously, there can be a memory peek, but it drops quickly on the next add/dequeue cycle. So an IDE exercising the language server in a "normal" way would keep the list short. If it turns out to be problematic, we could reduce the infinite timeout on the dequeue operation to something reasonable to do the housekeeping on idle times.

An additional issue of the original code was, that with the typical pauses, a language-server client makes, the first two long-running parallel work items and probably some more afterwards would effectively be serialized, depending on the timing of pauses and handler processing time.
The pull request (#11) is prepared now, I did some integration testing with vscode and I'm confident enough to publish it. Best regards, Martin.

Merged. Closed.


fix: add esm type declarations

Fixes #746
Not the cleanest solution, but it works.
Tested with both AxiosStatic and AxiosInstance.

Hey @paescuj, I decided to migrate out from webpack to a newer bundler, microbundle was my current decision. Would you mind testing the microbundle branch to see if its working too?

I'll let this open until the fix is merged

https://github.com/arthurfiorette/axios-cache-interceptor/pull/764


openstack/clientconfig/requests.go: make sure tls config is generated before creating authenticated client

Previously the openstack.AuthenticatedClient call would create provider and use it to create an authenticated client without the required TLS configuration.
Now the function creates a provider client and updates the HTTPClient before calling Authenticate to setup the client with authentication tokens.

Thanks for the reviews, everyone.
It's been almost 4 years since I first started working with TLS and OpenStack authentication. I recall that there were handful of edge cases that were reported, but once it was working with Terraform, I took it for granted and set it aside in my head. From reviewing this implementation with Terraform's, I think this should be good to go, but my memory is a little fuzzy on those edge cases.
If any are identified, just open a PR and I'm happy to merge.

Thanks for the reviews, everyone.
It's been almost 4 years since I first started working with TLS and OpenStack authentication. I recall that there were handful of edge cases that were reported, but once it was working with Terraform, I took it for granted and set it aside in my head. From reviewing this implementation with Terraform's, I think this should be good to go, but my memory is a little fuzzy on those edge cases.
If any are identified, just open a PR and I'm happy to merge.


Add CocoaPod support

This would make it a lot easier to add to client projects.

That sounds an entirely reasonable suggestion!

Added

@ashleymills Thank you!


Car interface

Player interface for car is not working, doesnt change anything if it is enabled or not.

The car interface requires a sufficiently large device screen, with a landscape screen height exceeding 600 dip


Serde Name Style

serde should follow a comment name styles, include:

struct fields enum type
struct fields enum value
struct field visitor type
new struct filed vistior type
struct visitor
new struct visitor
map/slice vistior
...

Rules

Make sure those types will not conflict with user types

So let's add a serde prefix for all internal types, make sure they are unique and not exported.

Make sure all types are easy to recognize

type Test struct {
	B string
	b string
}

We will use _ to distinguish serde part and user part, and use Pascal style in the part
so we will got a following types:
serdeStruct_Test
serdeStructEnum_Test
serdeStructEnum_Test_B
serdeNewStruct_Test
serdeNewStrcutFiled_Test

Always keep original struct name and type name

type Test struct {
	B string
	b string
}

type test struct {
	B string
	b string
}

we should keep original name so that we will not mess up B and b:
serdeStruct_Test
serdeStruct_test
serdeStructEnum_Test_B
serdeStructEnum_Test_b

Use map/slice's type as their name:

map[A]B => serdeMap_A_B
[]A => serdeSlice_A

type Test struct {
	B map[int]int
	b string
}

We will got these types:
serdeMap_int_int

Added into docs 4b2dc4afb16722c1a0e78c766dd106c3843f774d


LuckPerms BungeeCord no folder creating.

So today i have started my bungeecord server and i added it some plugins (LuckPerms for BungeeCord)
i started my servers and luckperms did not made folders and did not started on my server so i wasn't able to use it.
BugeeCord version :1.7.10 - 1.8
LuckPerms Version : LuckPerms-Bungee-5.0.136

The BungeeCord version you mention is not a valid one.
If you want to use BungeeCord, that supports 1.7.10, use Travertine

Hi, i have changed my BungeeCord version to the latest (1.8 - 1.15) but it still does the same error

You still don't provide a valid BungeeCord version.
Also... What error? We can't read minds nor see your server console, so you have to actually provide some information to us.


maybe: add S.maybeToNullable

Closes #189

Ooh you did that quick! :)
Maybe add a mention about the Nullable pseudotype somewhere?


People join with non-existing group

I deleted a rank. When a player who used to have that rank rejoined, they still had that rank which no longer existed, and therefore had no permissions until an admin was able to come on and give them the default rank
Can you update LP to make it so that if someone joins with a rank that doesn't exist, it removes that rank from them, and if that's their only rank, it'll give them the default group? Thanks!

Remove the rank globally from all players with bulkupdate. The wiki page should have an example on exactly that.
And removing nonexisting groups is a terrible idea. There are several use cases where that would completely break everything.


OpenSslEngine.setEnabledProtocols fails to enable protocols that are currently disabled

Netty Version: master (I know... :frowning: )
The OpenSslEngine.setEnabledProtocols() will not allow the user to enable a protocol that has already been disabled.  For example, netty (by default) disables SSLv3. If you wish to enable SSLv3 you should be able to call OpenSslEngine.setEnabledProtocols() including SSLv3 as one of the parameters of the array.  Unfortunately this does not work.
The reason has to do with the implementation of the method.
It does the following:

Determine which protocols to disable
Enable all protocols
Disable each protocol from step 1 above.

The problem is step 2 above does not work. I have no idea what SSL.SSL_OP_ALL actually does, but it doesn't do what the comment expects.
Solution:
Expose SSL_clear_options to netty via a new native method clearOptions() then use clearOptions in setEnabledProtocols
Pull Requests to follow.  Will need one for netty-tcnative and netty.

https://www.openssl.org/docs/manmaster/ssl/SSL_CTX_set_options.html

SSL_OP_NO_SSLv3, SSL_OP_NO_TLSv1, SSL_OP_NO_TLSv1_1, SSL_OP_NO_TLSv1_2, SSL_OP_NO_DTLSv1, SSL_OP_NO_DTLSv1_2
These options turn off the SSLv3, TLSv1, TLSv1.1 or TLSv1.2 protocol versions with TLS or the DTLSv1, DTLSv1.2 versions with DTLS, respectively. As of OpenSSL 1.1.0, these options are deprecated, use SSL_CTX_set_min_proto_version and SSL_CTX_set_max_proto_version instead.

Looks like we should investigate using SSL_CTX_set_min_proto_version and SSL_CTX_set_max_proto_version instead.

@blucas - Thanks for reporting. I'll submit a PR for tcnative and Netty.

@blucas - Your approach described sounds reasonable.

@normanmaurer - On a related note I wonder if we should be more careful about SSL_OP_ALL. See https://github.com/bagder/curl/blob/master/lib/vtls/openssl.c#L1730 and http://daniel.haxx.se/blog/2012/01/27/sloppily-using-ssl_op_all/.

@Scottmitch - On another related note (but outside the scope of this issue), it might be worth adding a setEnabledProtocols method to SslContextBuilder so that users do not have to call that method on the SslEngine implementation directly.

it might be worth adding a setEnabledProtocols method to SslContextBuilder

sgtm

Fixed by https://github.com/netty/netty/pull/4737


Add rollback changeset reference for SQL changelogs

name: Add rollback changeset reference for SQL changelogs
about: Add rollback changeset reference for SQL changelogs
title: ''
labels: Status:Discovery
assignees: ''

Environment
Liquibase Version:
Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>
Liquibase Extension(s) & Version:
Database Vendor & Version:
Operating System Type & Version:
Pull Request Type
Closes #1335.

[ ] Bug fix (non-breaking change which fixes an issue.)
[x] Enhancement/New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
Code to introduce referencing another changeset in a rollback statement in a SQL changelog file.
Current Behavior
Liquibase currently doesn't have any behavior to allow for referencing another changeset in a SQL rollback statement.
Desired Behavior
The new code would allow for this functionality, using either;
--rollback changeSetId:create-table-demo changeSetAuthor:atzawada changeSetPath:src/main/resources/testCreate.sql

if the changeset being referenced is in a different changelog file, or:
--rollback changeSetId:create-table-demo changeSetAuthor:atzawada

if the changeset is in the same changelog file.
Fast Track PR Acceptance Checklist:

[x] Build is successful and all new and existing tests pass
[ ] Added Unit Test(s)
[ ] Added Integration Test(s)
[ ] Documentation Updated

Thanks @atzawada for creating this enhancement request.
Here’s what happens next:
A member of the Liquibase team will take a look at your contribution and may suggest
changes, additional tests, or provide other feedback. The PR will be prioritized
according to our development and testing capacity.
We’ll let you know when it’s ready to move to the next step or if any changes are needed.
If you have any unit tests or integration tests to add that would be great.

What is the hold up on this PR?  Can I help?  Because I am interested in this functionality.

@awhitford-cip The hold up is that we are fortunate to have a high volume of community requests and are continually working on how best to address them. Some folks are also right now on much needed vacation, but we will review.

Hi @kataggart, @awhitford-cip, completely understand the difficulty getting to this with the high volume of PRs coming in. Still willing to help get this in if there are changes that need to be made.

For this PR, I tested if rollback reference works with a changeset on the same changelog and with one in another changeset. Both work just fine. Theres a couple behaviors that called my atention and think is good to share and be aware about:
-You cant reference  a changeset from a changelog that isnt in the same root changelog as the call.
-Liquibase reads the changelogs in order, so if you have a changeset with a rollback changeset reference on changelog1.sql and have the reference changeset on changelog2.sql, liquibase will fail with "changeset doesnt exists"
Test Environment:
Java 8
Windows 10
Postgres 13 conatiner

@awhitford-cip @atzawada This is now available in 4.16 that released on Friday.


Improve use bow when walking animations. ( 2nd try )

Follow: https://github.com/webaverse/app/pull/2903
Hello @avaer , sorry that, I found I made a big mistake/regression in the final codes of that old PR https://github.com/webaverse/app/pull/2903
So the result is not the same as the video I posted in that old PR.
This maybe why you feel "the top is stiff" https://github.com/webaverse/app/pull/2903#pullrequestreview-968549619
Now in this PR, I fixed the mistake/regression, made some more improvements, and made it compatible with z-targeting branch.
Old PR wrong result, top very stiff:
https://user-images.githubusercontent.com/10785634/171775146-061af342-8be0-448b-b195-3a21c2819dda.mp4
This new PR:
https://user-images.githubusercontent.com/10785634/171775273-865233a2-9018-4449-bb02-1b4535153541.mp4
How about this new result, is it still stiff or ok?

https://github.com/webaverse/app/pull/2903#pullrequestreview-968549619

I also think the slow walk draw system is easy to break (e.g. do naruto run while drawing the bow and it will run in place).

I prevented do naruto run while drawing in the PR, now should the very same slow walk logics as crouch.
And I'll request art assets of bow with running, so should not need do slow walk at all afterwards.
But for this PR, I want focus on bow with walking first, is it ok?

Keep in mind the most important part of this is the mouse aim. It's not shown in any of these demos.


[No QA] Remove front-end workaround for authWrites issue

Details
Not sure how this slipped through, but this is a front-end hack that was bypassing an back-end problem, that I fixed in https://github.com/Expensify/Web-Expensify/pull/42771. This is on HOLD for that in the meantime.
Fixed Issues
n/a - found when investigating https://github.com/Expensify/App/issues/43196
Tests
None.

[x] Verify that no errors appear in the JS console

Offline tests
None.
QA Steps
None.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@johnmlee101 tagged you for review since you were auto-assigned for https://github.com/Expensify/Web-Expensify/pull/42771

whats the latest here?

whoops, forgot about this one. We can proceed now

@johnmlee101 no rush, but this is ready for review + merge any time now

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Updated README

I wanted to update your README to make it easier to find useful information. I also added some descriptions for all the parameters in kegman.json all in one section. Please review this section to see if any are incorrect. There are still some things I wasn't sure about that I've put ??? next to so if you could confirm and/or answer those that would be great.
You can see what the new README looks like here: https://github.com/steveham3/openpilot

Thank you for merging.  I'm hoping you can still answer the questions I put ??? next to.  If you answer them here and re-open this PR I'll updated it for you:
Is there a way to see when features were added before 0.6.6?
Can you confirm the units for xbarBP0, xbarBP1, xbarMax, ACLminSpeed, CruiseDelta, CruiseEnableMin, cameraOffset, leadDistance?
Can you explain what enabling epsModded does?
Can you explain if tuneGernby does anything else besides enabling the live tuning script?

Hi Steve, appreciate the effort in tidying up the readme.
Before 0.6.6 my github got wiped so, no unfortunately.
i believe all the units are:
leadDistance is in m
cameraOffset in m
CruiseEnableMin in km/h
ALCminSpeed in m/s
CruiseDelta in km/h
leadDistance in m
epsModded is for modded cars (currently only civics) which uses a more suitable steerRatio, Kp, Kf, and Ki for modded steering.
tuneGerby is defunct - but should be left as default which is 1
Thanks again for your great efforts!

A couple more questions:
Is liveParams defunct as well?  Doesn't your fork freeze the steerRatio?  Or does this this only happen if steerRatio is -1?
I'm still not sure what leadDistance is.  Someone on Discord said it was for Accords and Insights only and was the distance of when to resume from a stop

Just following up with the previous questions so I can finalize the last changes

liveParams is defunct.  It still freezes steerRatio so that it doesn't change from the setting in kegman.json.  STOPPING_DISTANCE is for all cars.  LeadDistance is only for Bosch vehicles..


[WIP] Update org settings to differentiate between full members and members.

#14409
Testing Plan:
GIFs or Screenshots:

The first commit looks good; though I'd use models: as the prefix.
For the second commit, I think the ALLOWED_TO names are awkward.  I could consider doing names like POLICY_MEMBERS_ONLY for that concept.
But I'm also not sure that the common variables in the second commit are next helpful; I'll need to think about it more.

I think probably the second commit's approach is net helpful; it'll be useful for features like add_emoji_by_admins_only that we do plan to have a simple "what set of users can do this" model and it'll be helpful to have common fields for the ones that are simple (bot_creation_policy is not).

@timabbott I have made the change in first commit message and have also changed the variable names in second commit.
I agree that it may be not be useful for all the settings to have common values but it may be helpful for some of the some settings that will have same choices.

I merged the first commit.  For the second, can you rename PERMISSION_TYPES to COMMON_PERMISSION_TYPES?  I think that feels more readable.

I merged the second commit as b66a67272f6c294f65f860e8303aa12fe104eede, after renaming that variable to COMMON_POLICY_TYPES, since that felt more readable to me.

For the last commit, I don't like the readability of can_perform_action("create_stream_policy).  How about user_profile.has_permission("create_stream_policy")?
I'm not sure the rewrite in events.py improves readability.

I have made the change of can_perform_action to has_permission.
Regarding the change of events.py, I have made these changes as after we will add the new members to more settings, this will avoid duplication of code, but yeah I agree that the previous code had better readability.
Should I remove the change in events.py for now and start working on adding the new member option and then may be we can figure out the way to avoid duplication and have nice readability.

@timabbott I have renamed can_confirm_action to has_permission.
I have also changed variable names in events.py for more readability.
Maybe we can just leave the events.py change for now and start working on adding new members option to settings one by one and while doing it I can look at other ways to avoid duplication in events.py.

@timabbott I have made changes.

@timabbott I have made the changes as told by you.

@timabbott any more changes needed?

Yeah, this finally looks good, merged, thanks @sahil839!


automate ocp-64907 :: validate custom property operations on cluster

Automation test case : OCP-64907
The test purpose is to validate custom property operations on cluster - such as adding, deleting, editing custom property to an existing cluster.
Depends on this PR.

/test rosa-sts-advanced-optional-presubmit

/test rosa-sts-advanced-optional-presubmit

/lgtm

Re-run after adding a new function - ReadTerraformTFVars()

/lgtm

/approve


NetworkIndicator component documentation

resolves #5

Preview readme: https://github.com/ConsenSys/rimble-web3-components/tree/ml-network-indicator-documentation/packages/NetworkIndicator


refactor: Remove usages of reactable from TimeTable

SUMMARY
The goal is to replace all uses of reactable-arc library with DataTable from superset-ui (which uses react-table under the hood) and keep the UI/UX mostly unchanged. The reason for that is that reactable-arc has been unsupported for 2 years now, uses deprecated lifecycle methods and is incompatible with Typescript.
This PR replaces reactable-arc in TimeTable component.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:

After:

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

From the screenshot, wondering why the sparkline isn't expanding to 100% width (?)

@mistercrunch Thanks for pointing that out! A style prop for spark column wasn't passed correctly which caused it to have larger width than it should have. Fixed now. I updated the PR summary with the new screenshot.


Event is truncated when title contains a "#" character

When the title contains a hash character (#) the iCal version of the event is truncated.
See codepen:
https://codepen.io/anon/pen/NooReL?editors=1111

@dougauerbach sorry for the late reply, I haven't check this repo for a while.
But indeed, I fix it, so now it is not truncated when contains # character.
https://github.com/jojoee/add2calendar/commit/9732913c3cd4d40bef8a00a7db65ebbc0a69d9e7


pass quota_name property to mixer

By passing the quota_name property to mixer, I was able to see rate limiting kick in when running the bookinfo demo. Unfortunately it didn't work quite as expected. It seemed that not only the service that was configured to rate limit (ratings), but also other services (for example, when I refreshed the UI, it said that "reviews are not available" which implies the review service also was rate limiting). After another refresh, there appeared some strange message on the screen about quota (unfortunately I didn't capture it), and then after that it seemed totally broken. The productpage service was returning an internal error:
INTERNAL:unable to resolve config: 1 error occurred:

* unresolved attribute target.service

Here is the short script to run the demo to test rate limiting:
# setup
cd istio
source ./istio.VERSION
kubectl apply -f ./kubernetes/istio-install
cd demos/apps/bookinfo
kubectl create -f <(istioctl kube-inject -f bookinfo.yaml)
export GATEWAY_URL=$(kubectl get po -l infra=istio-ingress-controller -o jsonpath={.items[0].status.hostIP}):$(kubectl get svc istio-ingress-controller -o jsonpath={.spec.ports[0].nodePort})
istioctl create -f route-rule-all-v1.yaml
istioctl replace -f route-rule-reviews-v3.yaml

# test ratelimit
kubectl apply -f ../../mixer-config-quota-bookinfo.yaml
while true; do curl -s -o /dev/null http://$GATEWAY_URL/productpage; done

# point browser to $GATEWAY_URL/productpage and instead of ratings (stars) you should see message "Ratings not available"

Spinning this up so I can dig into mixer logs, I'll report back my findings.

This change is correct, it's most of what we need to get rate limiting working. After this change rate limiting will still not work, but because of a bug in the mixer (the mixer filters the manager sets in the proxy do not always set target.service; when it's missing we fail to resolve our config and return an internal error).

closing in favor of #555


Split up "Pass in a Value from Another Stack" section

There should be 2 sections.
SAME APP DIFFERENT STACKS
Same environment: just pass and use the object directly.
Different environments: build a complete ARN manually and use the ARN to import.
DIFFERENT APPS:
This section, but mostly to be rewritten once https://github.com/awslabs/aws-cdk/pull/1546 lands.

Done: https://docs.aws.amazon.com/cdk/latest/guide/use_cfn_template.html


LOAD DATA LOCAL INFILE no effect

LOAD DATA LOCAL INFILE '/xx/xx.csv' INTO TABLE table_name fields terminated by ',' IGNORE 1 LINES
Data can be inserted successful when run this command in mysql console, but no effect when i use the conn.query_drop method to do the same thing as below.
conn.query_drop( r"LOAD DATA LOCAL INFILE '/xx/xx.csv' INTO TABLE table_name fields terminated by ',' IGNORE 1 LINES")?;
Nothing to be inserted, the table is still empty.
Does LocalInfileHandler must be configured when using load data local infile to import data to mysql?

Hi.
Looks like the docs are a bit outdated, namely, the default value for the local_infile_hanler is none.
So yeah, you should configure the handler.

Got it, thanks for your reply.


feat(@ngtools/webpack):  prevent build failure in case of custom locale

Fix for the issue #9772 . It will allow to use custom locale at build time. Locale data corresponding to custom locale can be registered using registerLocaleData in application module.

I signed it!

@rahulbhooteshwar the error in CI is a flake. It's not caused by your PR and you can ignore it. Next time you push changes it should go away.
@ocombe can you weigh in on this topic?

Instead of the console usage, can you push the warning onto this._warnings so that the compilation system will direct the output to the configured location.

Ah yes that's probably better!

@ocombe I tried to incorporate changes suggested .  If we return null  in case of custom locale  causes another compiler error in my test application as following (My application i.e. testLocale is using custom-locale no-no):
ERROR in ./src/main.ts Module not found: Error: Can't resolve '@angular/common/locales/no-no' in 'F:\dev\testLocale\src'
I think it has something to with the comment mentioned in the angular_compiler_plugin.ts file :

it looks for the entry module  import, which will be replaced.

// If we have a locale, auto import the locale data file.       // This transform must go before replaceBootstrap because it looks for the entry module       // import, which will be replaced.       if (this._normalizedLocale) {         this._transformers.push(registerLocaleData(isAppPath, getEntryModule,           this._normalizedLocale));       }

@ocombe  Thank you for taking time in reviewing and suggesting the best possible fix.
I have incorporated changes suggested.

@ocombe  I also need to modify test case in build-locale.ts  for the following line.
.then(() => expectToFail(() => ng('build', '--aot', '--locale=no-locale')));
I will be doing the change and will also amend the commit logs to comply with guidelines.

Just a small change to the text of the warning and it should be good

@filipesilva  can you please check the continuous-integration/travis-ci/pr job failure. I am unable to get it!!

@ocombe apologies ! I amended last commit log  without thinking that it will dismiss your review/approval. Please approve and take it forward  again.


Increase space between paragraphs

Currently, we often use \medskip, \bigskip, \[1.5ex], or \[2ex] in slides. It would significantly simplify the source for slides and, thus, their creation and maintenance, if the standard space between paragraphs could be increased to a useful value. Hence, an empty line in the source would be sufficient to have such space.

Please check what happens for \begin{center}...\end{center} (also itemize, enumerate) environments. Ideally, they do not add any extra space then compared to a simple line without any environment.

I set the parskip to 1.5ex for the whole document including minipages and tcolorboxes. (See commit from above) Is this amount of parksip ok?

Do you have an example illustrating the parskip between different elements?

You should be able to see it in the committed PDF file.

Looks good in general, but seems to have some undesired side-effects.

Titles in mydefinition/example/note use more space now.

The contents listing consumes also more space.

Would be good if you could check the demo document side-by-side with the old version to study other side effects and find a solution.

I don't see any difference between the version with (left) and without the new parskip (right). I just set the parskip for the content of the tcolorbox and not for the title.

Should they just have the same parskip as before (no parskip)? (right)

Maybe you have made other changes on the branch causing the effect then? Or is it really different behavior on my machine?

Yes.

I think this comes from the \strut in front of the title which is used to get a uniform title height. Technically, the title should be centered, but when there are no letters that go below the baseline (like in "A Test"), it looks as if is de-centered.
With \vphantom{/} (left) instead of \strut (right) it looks a little more condensed:

The linespacing could be reset directly before the toc is generated in \AtBeginSection. In this case we would additionally need something like a \lectureoverview-command to create the lecture overview at the end also with zero line spacing which is now manually created in the example file.

Done


Limit body buffering to avoid resource exhaustion

This PR implement a limit for body buffering in order to avoid resource exhaustion using a very large body (see #7). The default limit is 10MB (which should be enough for non-uploads requests), but it's configurable.

Awesome, although you should specify the new option in the .traefik,yaml file
https://github.com/acouvreur/traefik-modsecurity-plugin/blob/19cdb477b8cee1966ad95278d168ae90a93df663/.traefik.yml#L8-L9
And probably add a documentation about it, the default value and the reason inside the readme.
Thank you very much for this!

Done! :+1:
(this is the first time I see the code for a traefik plugin)
I took the liberty of adding a new section in the README, named "Configuration", showing both the configuration parameters. I also added the configuration for maxBodySize inside the docker-compose files and the traefik YAML.
Let me know if you have any comment :-)


fix netcdf

Fix NetCDF Fortran. If a field has size 0 in one dimension it will be ignored before writing in NetCDF format.
Adds an example (copy paste) how to set the archive in NetCDF. Proper test of the examples should be integrated at a later stage.
Fixes #15

launch jenkins

launch jenkins

launch jenkins


Download cool files

Commit:
Hi,
Is there a way I can download the cool files that are uploaded already?
Thank you very much for all the great works help.
Best regards,
Lee

No, unfortunately that's not possible at the moment.
We could look into making that available for local installations but the size of the files available on our public site would make this an expensive option to have.


UI doesn't always update when DataVariable type changed

Updating a DataVariable type doesn't always cause the linear view to update, requiring the user to navigate away from the address and back to force a refresh.

This should be fixed now. 1.2.1951


Added ?runcode command (for now only python support only)

Resolves #192
Overview
Please bullet point the changes you have made below:

Added on-the-fly code running using ?runcode
Currently only python supported (python, py)
Looking to add more languages in the future (Possibly a few days )

issue has not been accepted for development.
code has no tests.
Issue has been found to be a solution to a non-issue with minor advantages, external dependency also attached to it which is always a sensitive subject.
Basic coding conventions are not used, suggestion to learn modern standards (eg no var, meaningful short descriptive variable names.
code is laced with console outputs (not ready for deployed code).
A lot of things here can be considered code smell.


Test data

We need some test data in the format described in
https://github.com/UtrechtUniversity/autumn-fair/blob/main/docs/SummerFAIR_schema_proposal_V03.pdf
It should follow the file folder structure for experiment data and should contain some columns in the right format according to the description in the PDF.

Done


weex-vue-render的a标签不支持flex布局

0.2.0 版本的weex-vue-render默认对a标签应用了如上图所示的样式，不支持flex布局。
div标签的样式默认是支持flex的。

This PR/issue doesn't received response since Weex migrated to Apache two years ago and this repository is no longer active yet.
Feel free to ask question in new repository and thanks for your contribution.

This issue is outdated for a long time and will be closed now. You can create a new one if you still have questions.


Use greenkeeper

greenkeeper.io sends us PRs to update npm dependencies :heart_eyes:

@greenkeeperio-bot is configured.


Allow to preload layers datas

layer by layer
with an automatic refresh (back or front?)

Duplicate of #133


Ambiguous wording 'defaults to latest pipeline successful across all stages' in Download step doc

Ambiguous wording - version: string  # the pipeline run number to pick the artifact, defaults to latest pipeline successful across all stages;
resources:        # types: pipelines | builds | repositories | containers | packages
  pipelines:
  - pipeline: string  # identifier for the resource used in pipeline resource variables
    project: string # project for the source; optional for current project
    source: string  # name of the pipeline that produces an artifact
    version: string  # the pipeline run number to pick the artifact, defaults to latest pipeline successful across all stages; Used only for manual or scheduled triggers

https://docs.microsoft.com/en-us/azure/devops/pipelines/process/resources?view=azure-devops&tabs=schema#define-a-pipelines-resource
Does the 'latest' refer to time of the last build or the last successful pipeline number?
We had a strange issue when a 'bad' pipeline would would finish later than the next 'successful' one and hence the release pipeline (deployment) would only download the 'bad' pipeline artifact as a resource. We were under impression that latest version (build number) should be used. This can lead to similar problems if some builds are delayed.

@websolut -- thank you for your feedback and question.  Please consider these resources:

Azure DevOps Services
Azure DevOps on Stack Overflow

@juliakm -- please look into this issue.

@juliakm @WilliamAntonRohm Is there an update on this topic?


ARROW-11472: [Python][CI] Remove temporary pin of numpy in kartothek integration build

Follow-up on https://github.com/apache/arrow/pull/9396

@github-actions crossbow submit test-conda-python-3.7-kartothek-latest test-conda-python-3.7-kartothek-master


V1.0.2rc

Codecov Report

Merging #61 (817e412) into master (343e87f) will decrease coverage by 0.10%.
The diff coverage is 31.70%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   53.38%   53.28%   -0.11%
==========================================
  Files         177      177
  Lines        8719     8758      +39
==========================================
+ Hits         4655     4667      +12
- Misses       4064     4091      +27

Impacted Files
Coverage Δ

apps/gsekit/configfile/handlers/config_instance.py
17.85% <0.00%> (-0.33%)
:arrow_down:

apps/gsekit/adapters/base/adapter.py
37.28% <14.28%> (-1.46%)
:arrow_down:

...eline_plugins/components/collections/configfile.py
23.86% <36.66%> (+0.95%)
:arrow_up:

apps/gsekit/constants.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 343e87f...817e412. Read the comment docs.


First go test

Summary
We need a way to run tests with go in order to verify our code!
Key Points

[x] This is a breaking change
[x] New or existing documentation is updated

Description
You can now run make test and see the tests pass in github actions
Does this close any open issues?
#271
How to verify this

If this PR shows all tests passing, it works!

Dependency
This is forked off of #270

LGTM


Feature gift > Make windows install easier

Context
Actually, on windows, the install process is not that easy as it requires some manual actions. It would be very convenient to be able to install ytt within a single command line, even on Windows.
Therefore I created a chocolatey package which is still under moderation process, but it's usable.
Installation guidelines
To install Carvel ytt, run the following command from the command line or from PowerShell with Admin privileges
choco install ytt --version=0.30.0
ytt --help

You're done.
NB
As long as the chocolatey moderation process has not ended, the version has to be provided. When the moderation process will be ok, the install process will be even easier:
choco install ytt
ytt --help

... then to upgrade:
choco upgrade ytt

Feedbacks welcome
Please feel free to provide me any feedback 👍 , hopefully you'll like this modest 🎁
meme for :laughing:

Thanks @adriens. We greatly appreciate the ytt Chocolatey package.
Something we discussed in our last community meeting was establishing more definitions around our release processes for Carvel tools. One thing that came up is what Windows package manager (e.g. Chocolatey, Scoop, or winget) to use to support all Carvel tools. Potentially even defining a single repository for all of them.
We would greatly appreciate any suggestions you have for Windows users in terms of installing Carvel tools.

One thing I am noticing though is that choco uninstall ytt is not working as expected:
ERROR: The term '?$tools' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
ytt uninstall not successful.
Error while running 'C:\ProgramData\chocolatey\lib\ytt\tools\chocolateyUninstall.ps1'.
 See log for details.
ytt not uninstalled. An error occurred during uninstall:
 ytt uninstall not successful.

Chocolatey uninstalled 0/1 packages. 1 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Failures
 - ytt (exited -1) - Error while running 'C:\ProgramData\chocolatey\lib\ytt\tools\chocolateyUninstall.ps1'.
 See log for details.

Hi @danielhelfand , thanks a lot for your feedback, I'll try to answer both questions:

Carvel Tools on Windows
choco uninstall process

Carvel tools on windows
Yes, it totally makes sense, in fact I also asked my self I should not rather  provide a Carvel tools package that embeds all cli. S I started to implement choco packages for each of them (a global and meta version should be created hence) :

[x] kapp, see choco install kapp --version=0.34.0
[x] vendir  see choco install vendir --version=0.14.0
[x] kbld, see choco install kbld --version=0.27.0
[x] imgpkg, see choco install imgpkg --version=0.2.0
[ ] kapp-controller
[ ] other tools still in bêta

They all are in the Ready to revienw status mode, awaiting for official release step.
From my point of view, it would totally make sense to package all them within a single installer as :

they all target the same topic
are very little (in terme of disk space), hence not impacting the final user

In fact, I wanted to respect your philosophy that was : one repo, one tool. I could prepare an automated build that would come and grab binaries on each repo to prepare the Chocolatey build.
In could be even easier for me if you :

were preparing for me a zip file, somewhere as a release asset, that I would come and grab to build. I would even force the hash to be checked to put more security
for windows, were renaming tools with their shot name, ie: ytt-windows-amd64.exe to ytt (no symbolic links in Windows)

Just le me know what your preferences are and I'll integrate with them 😸
Uninstall failing
Yes, indeed, I'm aware of that, I discovered it recently. I have patched it but as long as the current version is in the Ready status, I cannot push a new version (I call <IP_ADDRESS>). The last digit is related to installer related issue on the same version of a package.... 'cause the installer itself can have bugs/evolutions too 😆
The moderation process takes a long these days, we have to be patient.
I have also discovered an another issue see https://github.com/adriens/chocolatey-ytt/issues/4
I'll work on it and apply the patch on all others.
Conclusion
Please let me know about what you think about the global "Carvel Tools" zip release as a Github Asset 🙏

Uninstall process totally fixed see https://github.com/adriens/chocolatey-ytt/issues/4

Here is the current status of chocolatey package for ytt :

[ ] Relased of reject of 0.30.0 waiting since November 14th
[ ] Pushing <IP_ADDRESS> to choco central
[ ] Being officially moderated by choco central
[ ] Enjoy the totally operational package

Thanks for the detailed write up, @adriens. We'll be sure to consider Chocolatey packages as part of the broader discussion of our release process. And thanks for putting these initial packages together.

Hi guys, ytt now is officially released on Choco central !
Now, things are as easy as :

Install : choco install ytt
Upgrade : choco upgrade ytt
Uninstall : choco uninstall ytt

Hopefully you'll enjoy, other good news are coming 🎆

@adriens Thanks for the gift. We (@pivotal-dean and I) like the idea of having a single chocolatey repo to install all the tools.

In could be even easier for me if you :
were preparing for me a zip file, somewhere as a release asset, that I would come and grab to build. I would even force the > hash to be checked to put more security
for windows, were renaming tools with their shot name, ie: ytt-windows-amd64.exe to ytt (no symbolic links in Windows)
Just le me know what your preferences are and I'll integrate with them

We are currently iterating on defining a suitable release process for the team. We are hesitant in introducing an additional step to distribute windows binaries differently from the other OS's.
What about instead of us having to provide a zip file with all the binaries inside it, instead a 'helper script' uses a 'version' file containing a map of the binary name -> version. This file could be used to programmatically download the necessary binaries.
for e.g.
version file contents:
ytt: SHA256, v0.31.0
kapp: SHA256, vx.y.z
...

would construct the following url for ytt:
https://github.com/vmware-tanzu/carvel-ytt/releases/download/v0.31.0/ytt-windows-amd64.exe
You could also then verify the downloaded contents with the sha in the version file.

@adriens Thanks for the gift. We (@pivotal-dean and I) like the idea of having a single chocolatey repo to install all the tools.

In could be even easier for me if you :
were preparing for me a zip file, somewhere as a release asset, that I would come and grab to build. I would even force the > hash to be checked to put more security
for windows, were renaming tools with their shot name, ie: ytt-windows-amd64.exe to ytt (no symbolic links in Windows)
Just le me know what your preferences are and I'll integrate with them

We are currently iterating on defining a suitable release process for the team. We are hesitant in introducing an additional step to distribute windows binaries differently from the other OS's.
What about instead of us having to provide a zip file with all the binaries inside it, instead a 'helper script' uses a 'version' file containing a map of the binary name -> version. This file could be used to programmatically download the necessary binaries.
for e.g.
version file contents:
ytt: SHA256, v0.31.0
kapp: SHA256, vx.y.z
...

would construct the following url for ytt:
https://github.com/vmware-tanzu/carvel-ytt/releases/download/v0.31.0/ytt-windows-amd64.exe
You could also then verify the downloaded contents with the sha in the version file.

Hi,

What about instead of us having to provide a zip file with all the binaries inside it, instead a 'helper script' uses a 'version' file containing a map of the binary name -> version. This file could be used to programmatically download the necessary binaries.

yes, totally agree, it looks much more elegant.
For now I'm respecting package philosophy : one package for one software. I appreciate the fact when the packager makes no constraint on the main software developer. In addition to this, I can easily automate the build and release process without having to ask you to modifiy your release process 👍
I will put effort on this according to the frequency of your releases 😸 .

Hi,

What about instead of us having to provide a zip file with all the binaries inside it, instead a 'helper script' uses a 'version' file containing a map of the binary name -> version. This file could be used to programmatically download the necessary binaries.

yes, totally agree, it looks much more elegant.
For now I'm respecting package philosophy : one package for one software. I appreciate the fact when the packager makes no constraint on the main software developer. In addition to this, I can easily automate the build and release process without having to ask you to modifiy your release process 👍
I will put effort on this according to the frequency of your releases 😸 .

Btw, I've submitted the v0.31.0  which is under moderation process : https://github.com/adriens/chocolatey-ytt/issues/5

Btw, I've submitted the v0.31.0  which is under moderation process : https://github.com/adriens/chocolatey-ytt/issues/5

The work to include these Chocolatey packages is being discussed and tracked in this issue. Closing this one.

I'll implement the CI for kapp this week-end.

Thanks @adriens

I'll implement the CI for kapp this week-end.

I am taking this to mean you are going to do something similar for https://github.com/adriens/chocolatey-kapp that you did for https://github.com/adriens/chocolatey-imgpkg (using appveyor)?
As previously discussed with you, @cari-lynn and I (with your help) are planning on combining the carvel tools into a single repo to contain all the chocolatey files (https://github.com/vmware-tanzu/carvel/issues/220). So, we think we might have to re-purpose some of this automation work in this new mono-repo (or potentially re-implement this automation using github actions)
Let's continue this discussion in this issue https://github.com/vmware-tanzu/carvel/issues/220

@danielhelfand

One thing that came up is what Windows package manager (e.g. Chocolatey, Scoop, or winget) to use to support all Carvel tools.

FYI, I've packed ytt for winget, so users can now do winget install Carvel.ytt, see, https://github.com/carvel-dev/ytt/discussions/829
I've also created PR with Carvel docs updated, see https://github.com/carvel-dev/carvel/pull/629


Create pb file

Hi,
I'm a newbie with tensorforce and tensorflow. I need a pb file to export my trained model but when i use agent.save model i get only 4 files: .data, .index, .meta and a file named checkpoint with no extension. How can i get the pb file from these?

I'm not sure, best to look up how the tf.train.Saver functionality relates to pb files, or how alternatively one can store a TensorFlow model as pb instead of the Saver format. Won't be able to look into this, but let us know if you found a solution.

I found some methods to convert the files saved by tensorforce to a pb file but i need the name of the output node, how can i get it?

Would you mind sharing, for the sake of completeness (if someone else comes across this issue)?
Two ways to get the name of the output node: First, use summaries to store the graph and then investigate in TensorBoard (might be quite messy, there are lots of operations). Second, use print(...) statements to get the name in code, e.g. the fetched tensors here. While it's quite straightforward to get the name, I can't exactly remember the name-scopes etc, so one of these solutions is probably easiest.

My research involves embedding trained neural networks into hardware so I'll add my approach for anyone trying to achieve the same thing. I am exploring the possibility of migrating from OpenAI baselines to Tensorforce given the many difficulties in extending the OpenAI code base.
There are a few approaches to obtain the pb file. If you can modify the code  as @AlexKuhnle mentioned adding a print statement will get you the tensor name probably the quickest. I added mine right after here.
Another approach is to analyze your checkpoint file and or Tensorboard. If you have a checkpoint you can use this script to convert the checkpoint to a pb file. Now however this will be the entire graph which you most likely do not want. You only want the trained network. Once you have the full pb graph you can use Tensorflows summarize_graph tool which will identify all the possible input and output nodes. For my example (I am using this network with this agent) the input node was ppo/state-state which is easy to cross reference with Tensorboard. The output node is more difficult as there are hundreds. Depending on your network your output will typically be the mean of a distribution if deterministic or a sample. Knowing this we have an idea where the output code will be, in my case for PPO using the beta distribution. As we can see in the return a condition operation is used to return whether it is deterministic or not. In the image below we can see the corresponding Tensorboard translation. The select node selects the output depending on the condition (which ends up being the ppo/deterministic placeholder). The output (also confirmed by the print statement) is ppo/actions-and-internals/action/sample/add_1:0 (please correct me if I'm wrong, I did test it and it appears to be correct). Now that we have our input and output nodes we can use another tool, freeze_graph to convert all placeholders to constants and prepare our graph for deployment. Freezing the graph will extract the subgraph so you can minimize the file size.
Now unfortunately with Tensorforce this isn't that straight forward (if we want to optimize the graph as small as possible). As we can see from Tensorboard, there are additional operations that depend on the output of the Select operation. Therefore we can't simply specify the node before the Select statement as the output node. Our goal for deployment is to have a deterministic graph and we want to remove all the unnecessary sampling operations. Currently this isn't possible without additional postprocessing, you need to use the graph containing the non-deterministic operations and use the additional input ppo/deterministic set to true to force the deterministic output.
There are two fixes for this. Do this post processing using Tensorflows graph transforms to rewire the graph, or modify the distribution code so its possible to specify an output node that has the deterministic value (this is probably less of a pain and less error prone, rewiring graphs can be dangerous). Hope this gets you in the right direction.

I think I've been looking into similar things, how to best extract the right subgraphs from TensorFlow architectures -- after all, this is one of the main motivations for TensorForce's full-tf design (blogpost). If you're keen discussing / potentially collaborating on such a feature for TensorForce in general, that would be very welcome, best message me on Gitter then. :-)

Hi @AlexKuhnle, having flexible network architectures and the beta distribution led me here, I'm currently doing some benchmarks right now. If I end up migrating over to Tensorforce I will certainly hit you up to collaborate on this.


Create update login.js

issue #1089
modified code to handle cases where fields are left empty, which should prevent the Null Pointer Exception.

which issue it solves

i have added the issue no.

@sanjay-kv  sir kindly add the level and label also


get_flarelist_from_datacenter not working

@hannahc243 @hayesla
It seems that the function get_flarelist_from_datacenter() is not working for me.
First of all, in my fork I had to replace the third line of the code: from stixdcpy.net import Request as jreq has been replaced with from stixdcpy.net import JSONRequest as jreq.
Then, at line 51 it fails with the error 'TypeError: scalar 'Time' object is not iterable.'. It fails inside jreq.fetch_flare_list, so it may be an issue with the version I have.
I tried to use pandas datetime and it seems to work with jreq.fetch_flare_list (this is what I used to use for automatic spectral fitting). However, then if I use pandas datetime, the code fails at line 39 since it has not the same format as Time().
The current version I have for stixdcpy is 2.2. With which version did you write and test this code?

Ok, I got the problem. If one downloads stixdpcy using pip install stixdcpy (as it is also written in Hualin's tutorial), this function does not work.
To make this package working, one has to install stixdcpy via the Github repo.
I think this issue can be already closed, but at least we have written this down.


runtime: improve runtime.overLoadFactor calculation

runtime.overLoadFactor could use some improvement.
First, a bug: uintptr is 32 bits wide on a 32 bit system, so calculating uintptr(1<<B) can overflow when B >= 32. That's Go 1.9 material, and I'll send a CL shortly. Maybe even 1.8.2, given the devastating result (infinite loop) and simplicity of fix. Marking 1.8.2 for discussion.
Second, an improvement: We should rewrite this to use integer arithmetic and pay more careful attention to potential overflow. That should probably wait for Go 1.10.
Exposed by CL 40854 when working with a hint of 1 << 62. CL 40854 will also help with the bug, once it is correctly implemented.

Keith points out that the bug can't occur in 1.8, and the initial fix is in, so setting to 1.10 to use int calculations.

This was fixed by https://golang.org/cl/54655.


SOF build broken since commit f30f08a3ce75

Describe the bug
Since that commit, cloning a fresh Zephyr tree with SOF and trying to build it, e.g. for MTL, now results in:
/tmp/west/modules/audio/sof/app/prj.conf:20: warning: attempt to assign the value 'n' to the undefined symbol HAVE_AGENT
/tmp/west/modules/audio/sof/app/prj.conf:37: warning: attempt to assign the value 'n' to the undefined symbol DEBUG_MEMORY_USAGE_SCAN
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:1: warning: attempt to assign the value 'y' to the undefined symbol METEORLAKE
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:2: warning: attempt to assign the value 'y' to the undefined symbol IPC_MAJOR_4
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:5: warning: attempt to assign the value 'n' to the undefined symbol INTEL_DMIC
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:6: warning: attempt to assign the value 'n' to the undefined symbol INTEL_DMIC_NHLT
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:7: warning: attempt to assign the value 'n' to the undefined symbol INTEL_SSP
/tmp/west/modules/audio/sof/appParsing /tmp/west/zephyr/Kconfig
Loaded configuration '/tmp/west/zephyr/boards/xtensa/intel_adsp_ace15_mtpm/intel_adsp_ace15_mtpm_defconfig'
Merged configuration '/tmp/west/modules/audio/sof/app/prj.conf'
Merged configuration '/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf'
Merged configuration '/tmp/west/modules/audio/sof/app/debug_overlay.conf'
/boards/intel_adsp_ace15_mtpm.conf:8: warning: attempt to assign the value 'n' to the undefined symbol INTEL_ALH
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:9: warning: attempt to assign the value 'y' to the undefined symbol COMP_SRC
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:10: warning: attempt to assign the value 'y' to the undefined symbol COMP_SRC_IPC4_FULL_MATRIX
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:11: warning: attempt to assign the value 'y' to the undefined symbol COMP_DRC
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:27: warning: attempt to assign the value 'y' to the undefined symbol ZEPHYR_NATIVE_DRIVERS
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:36: warning: attempt to assign the value 'y' to the undefined symbol ZEPHYR_DP_SCHEDULER
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:41: warning: attempt to assign the value 'y' to the undefined symbol INTEL_MODULES
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:42: warning: attempt to assign the value 'y' to the undefined symbol LIBRARY_MANAGER
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:45: warning: attempt to assign the value 'y' to the undefined symbol AMS
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:49: warning: attempt to assign the value 'y' to the undefined symbol L3_HEAP
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:50: warning: attempt to assign the value '"mtl"' to the undefined symbol RIMAGE_SIGNING_SCHEMA
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:52: warning: attempt to assign the value 'n' to the undefined symbol FORMAT_CONVERT_HIFI3
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:53: warning: attempt to assign the value 'y' to the undefined symbol PCM_CONVERTER_FORMAT_S16_C16_AND_S16_C32
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:54: warning: attempt to assign the value 'y' to the undefined symbol PCM_CONVERTER_FORMAT_S16_C32_AND_S32_C32
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:55: warning: attempt to assign the value 'y' to the undefined symbol PCM_CONVERTER_FORMAT_S16_C32_AND_S24_C32
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:56: warning: attempt to assign the value 'y' to the undefined symbol PCM_CONVERTER_FORMAT_S24_C24_AND_S24_C32
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:57: warning: attempt to assign the value 'y' to the undefined symbol PCM_CONVERTER_FORMAT_S24_C32_AND_S24_C24
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:58: warning: attempt to assign the value 'y' to the undefined symbol PCM_CONVERTER_FORMAT_S16_C32_AND_S16_C32
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:65: warning: attempt to assign the value 'y' to the undefined symbol COMP_VOLUME_WINDOWS_FADE
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:66: warning: attempt to assign the value 'y' to the undefined symbol COMP_UP_DOWN_MIXER
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:67: warning: attempt to assign the value 'y' to the undefined symbol COMP_CHAIN_DMA
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:68: warning: attempt to assign the value 'y' to the undefined symbol SAMPLE_KEYPHRASE
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:73: warning: attempt to assign the value 'y' to the undefined symbol SOF_LOG_LEVEL_INF
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:74: warning: attempt to assign the value 'y' to the undefined symbol ZEPHYR_LOG
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:79: warning: attempt to assign the value 'y' to the undefined symbol LL_WATCHDOG
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:82: warning: attempt to assign the value 'n' to the undefined symbol TRACE
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:83: warning: attempt to assign the value 'y' to the undefined symbol COMP_KPB
/tmp/west/modules/audio/sof/app/boards/intel_adsp_ace15_mtpm.conf:84: warning: attempt to assign the value 'y' to the undefined symbol COMP_ARIA
error: Aborting due to Kconfig warnings

To Reproduce
mkdir /tmp/test
cd /tmp/test
west init
west update
west update sof
west build -d build -b intel_adsp_ace15_mtpm modules/audio/sof/app/

Expected behavior
Building should succeed
Impact
An existing installation stopped working
Logs and console output
see above
Environment (please complete the following information):

Linux
Zephyr SDK 0.16.3
west update as of today, Zephyr commit 89db200117aa4d0604060d65318dcc0ab30b073d

Let me route to @nashif for commit f30f08a3ce75

you need
 west config manifest.project-filter -- +sof

see https://docs.zephyrproject.org/latest/develop/manifest/index.html#inactive-and-optional-projects-modules


Create Common Workflow Cookbooks

Add a collection Cookbooks to address common workflows, such as:
Selecting Nodes/Edges
Applying layouts
Etc.
Possibly mirror Cytoscape main documentation?

Covered by several tutorials in https://github.com/cytoscape/cytoscape-automation


Release to NuGet

Releasing to NuGet is trivial with NuGet Package Explorer. However, such releases require a NuGet private key. Since this is not my own project anymore, we should figure out how to release under a Reactor-banner to NuGet, i.e., I or @smaldini could perform the action.

I can have a look but you're welcome to use a new one adapted for the project. We don't have another AFAIK.
Sent from my iPhone

On 4 Jun 2016, at 4:23 pm, David Karnok<EMAIL_ADDRESS>wrote:
Releasing to NuGet is trivial with NuGet Package Explorer. However, such releases require a NuGet private key. Since this is not my own project anymore, we should figure out how to release under a Reactor-banner to NuGet, i.e., I or @smaldini could perform the action.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

The release works. https://www.nuget.org/packages/Reactor.Core/


Rename Extendability to Extensibility in HowTo6

Travis had a warning:
[09:20:03] [MENU_CHECK] MISSING   page: /howto6/extendability has no category/parent, but is also not a category. Please check the page!
Hope this will solve it.

No - it is much more complicated than that. Have to change the whole branch.
I'll delete this pull request!!!!


Feature/responsive country page

Responsive country page:

[x] Timeline and dropdowns in timeline (created a mixin to fix the dropdowns inside the scroll)
[x] GHG emissions graph width, legend, dropdowns, split buttons, ...
[x] Climate vulnerability sections, text, cards
[x] NDC Overview responsive sections, text, split buttons
[x] NDC-SDG Linkages split buttons, text, linkages cards, tooltip
[x] Tablet specific changes and margins

Mobile:
https://app.zeplin.io/project/598b1dc89689e51e1cd1b5ce/screen/5a0038393637f65c213fe849
Tablet:
https://app.zeplin.io/project/598b1dc89689e51e1cd1b5ce/screen/5a5dc4dc461834cc5fba1352
Need to check in IE. I couldn't manage to do it yet

I've fixed the merge conflicts and included a couple of changes after a quick conversation with @faustoperez, thanks!


BWC version 1.3.7

Signed-off-by: Suraj Singh<EMAIL_ADDRESS>Description
Adds 1.3.7 bwc version which was added in 1.x as part of https://github.com/opensearch-project/OpenSearch/pull/4701. The existing PRs on 2.x are failing due to this.
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Closing in favour of https://github.com/opensearch-project/OpenSearch/pull/4709


The make process does not work on rhel7 or centos7

On such a server, you will get the error:
$ make
Using gold linker...
Building _release/inotify-info...
---- inotify-info.cpp ----
g++: error: unrecognized command line option ‘-Wimplicit-fallthrough=2’
make: *** [_release/inotify-info.o] Error 1
The g++ version is
$ g++ --version
g++ (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)
Is it possible to update the make process so that it can cover platforms?
Thanks
Richard

We had this bug 10 entered previously:
The core issue there, we think, would be this:

statx() was added to Linux in kernel 4.11; library support was added in glibc 2.28.

and

the Centos 7 kernel is still 3.10 and glibc on 2.17

So I think we're going to run into more issues than just getting it to compile.

From this chart:
distrowatch centos
It looks to me like we would need CentOS 8.5 or higher to support statx().


[MINT-2499] Added query to evaluate task list status and exposed to graphql

MINT-2499
Description

Added GQL resolver for task list status by model plan
Added SQL query to evaluate

How to test this change

Inject the following model plan test data and validate corresponding task list statuses via postman responses on getting model plan data

-- Test 1: All sections are READY
INSERT INTO model_plan (id, model_name, status, created_by)
VALUES ('00000000-0000-0000-0000-000000000001', 'Test Plan 1 - All Ready', 'PLAN_DRAFT', '00000001-0001-0001-0001-000000000001');

INSERT INTO plan_basics (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000001', 'READY', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_beneficiaries (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000001', 'READY', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_participants_and_providers (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000001', 'READY', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_ops_eval_and_learning (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000001', 'READY', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_general_characteristics (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000001', 'READY', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_payments (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000001', 'READY', '00000001-0001-0001-0001-000000000001');

-- Test 2: All sections are IN_PROGRESS
INSERT INTO model_plan (id, model_name, status, created_by)
VALUES ('00000000-0000-0000-0000-000000000002', 'Test Plan 2 - All In Progress', 'PLAN_DRAFT', '00000001-0001-0001-0001-000000000001');

INSERT INTO plan_basics (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000002', 'IN_PROGRESS', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_beneficiaries (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000002', 'IN_PROGRESS', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_participants_and_providers (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000002', 'IN_PROGRESS', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_ops_eval_and_learning (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000002', 'IN_PROGRESS', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_general_characteristics (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000002', 'IN_PROGRESS', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_payments (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000002', 'IN_PROGRESS', '00000001-0001-0001-0001-000000000001');

-- Test 3: All sections are READY_FOR_REVIEW
INSERT INTO model_plan (id, model_name, status, created_by)
VALUES ('00000000-0000-0000-0000-000000000003', 'Test Plan 3 - All Ready for Review', 'PLAN_DRAFT', '00000001-0001-0001-0001-000000000001');

INSERT INTO plan_basics (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000003', 'READY_FOR_REVIEW', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_beneficiaries (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000003', 'READY_FOR_REVIEW', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_participants_and_providers (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000003', 'READY_FOR_REVIEW', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_ops_eval_and_learning (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000003', 'READY_FOR_REVIEW', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_general_characteristics (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000003', 'READY_FOR_REVIEW', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_payments (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000003', 'READY_FOR_REVIEW', '00000001-0001-0001-0001-000000000001');

-- Test 4: All sections are READY_FOR_CLEARANCE
INSERT INTO model_plan (id, model_name, status, created_by)
VALUES ('00000000-0000-0000-0000-000000000004', 'Test Plan 4 - All Ready for Clearance', 'PLAN_DRAFT', '00000001-0001-0001-0001-000000000001');

INSERT INTO plan_basics (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000004', 'READY_FOR_CLEARANCE', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_beneficiaries (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000004', 'READY_FOR_CLEARANCE', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_participants_and_providers (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000004', 'READY_FOR_CLEARANCE', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_ops_eval_and_learning (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000004', 'READY_FOR_CLEARANCE', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_general_characteristics (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000004', 'READY_FOR_CLEARANCE', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_payments (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000004', 'READY_FOR_CLEARANCE', '00000001-0001-0001-0001-000000000001');

-- Test 5: Mixed statuses - default to IN_PROGRESS
INSERT INTO model_plan (id, model_name, status, created_by)
VALUES ('00000000-0000-0000-0000-000000000005', 'Test Plan 5 - Mixed Statuses', 'PLAN_DRAFT', '00000001-0001-0001-0001-000000000001');

INSERT INTO plan_basics (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000005', 'IN_PROGRESS', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_beneficiaries (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000005', 'READY_FOR_REVIEW', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_participants_and_providers (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000005', 'READY_FOR_CLEARANCE', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_ops_eval_and_learning (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000005', 'READY', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_general_characteristics (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000005', 'IN_PROGRESS', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_payments (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000005', 'READY', '00000001-0001-0001-0001-000000000001');

-- Test 6: READY_FOR_REVIEW and READY_FOR_CLEARANCE mixture - Should result in READY_FOR_REVIEW
INSERT INTO model_plan (id, model_name, status, created_by)
VALUES ('00000000-0000-0000-0000-000000000006', 'Test Plan 6 - Ready for Review and Clearance', 'PLAN_DRAFT', '00000001-0001-0001-0001-000000000001');

INSERT INTO plan_basics (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000006', 'READY_FOR_REVIEW', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_beneficiaries (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000006', 'READY_FOR_REVIEW', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_participants_and_providers (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000006', 'READY_FOR_CLEARANCE', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_ops_eval_and_learning (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000006', 'READY_FOR_REVIEW', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_general_characteristics (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000006', 'READY_FOR_CLEARANCE', '00000001-0001-0001-0001-000000000001');
INSERT INTO plan_payments (id, model_plan_id, status, created_by) VALUES (gen_random_uuid(), '00000000-0000-0000-0000-000000000006', 'READY_FOR_REVIEW', '00000001-0001-0001-0001-000000000001');

PR Author Checklist

[ ] I have provided a detailed description of the changes in this PR.
[ ] I have provided clear instructions on how to test the changes in this PR.
[ ] I have updated tests or written new tests as appropriate in this PR.
[ ] Updated the Postman Collection if necessary.

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
When approving a PR, provide a reason why you're approving it

e.g. "Approving because I tested it locally and all functionality works as expected"
e.g. "Approving because the change is simple and matches the Figma design"

Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@OddTomBrooks If it's not too much work, would you be able to add that test SQL in the PR description as seed data in scripts/dev db:seed? That might make it easier to test different cases on the FE and validate changes as well!
If it'd be a headache don't worry about it, but might be a smoother approach than the manual SQL!

I think I will have some time this sprint after a few other PRs. If it's ok, let's use the manual data for this PR and let me see if I can add a data driven component to inject seed data for testing on future PRs.

@OddTomBrooks When using the SQL in the PR description I seem to get an error when trying to run the Get Model Plan postman query:
{
    "errors": [
        {
            "message": "tracking date not found for id 00000000-0000-0000-0000-000000000001",
            "path": [
                "modelPlan",
                "opSolutionLastModifiedDts"
            ]
        }
    ],
    "data": null
}

Guessing this might be due to manually inserted data missing some fields? Did you get this when you tested locally, or perhaps I've got something configured incorrectly

When I tested locally for this data I ran it through a copy of the SQL query in the console. I looked into this a bit and there is an issue with evaluating the operational solution tracking date due to malformed testing data. A workaround is to exclude the opSolutionLastModifiedDts parameter from the model plan query on Postman. This is fine because the corresponding logic has been vetted already and is not relevant to test data.

@OddTomBrooks I think there might be some merge conflict here -- looks like one of the resolvers is being re-declared in the same scope.
Otherwise, I tested locally (and removed what looked to be the older version of the resolver) and things seem to work!

@OddTomBrooks I think there might be some merge conflict here -- looks like one of the resolvers is being re-declared in the same scope.
Otherwise, I tested locally (and removed what looked to be the older version of the resolver) and things seem to work!

How strange. Not sure how the merge issue happened but it's fixed now.


Failure to find remote ref for a specific PR

When running nixpkgs-review on this particular PR:
nixpkgs-review pr 260719

I'm running into the following error:
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/260719/head:refs/nixpkgs-review/1
fatal: couldn't find remote ref pull/260719/head
https://github.com/NixOS/nixpkgs/pull/260719 failed to build: Failed to fetch ('master', 'pull/260719/head') from https://github.com/NixOS/nixpkgs. git fetch failed with exit code 128
$ git worktree remove -f /home/ath/.cache/nixpkgs-review/pr-260719/nixpkgs
fatal: '/home/ath/.cache/nixpkgs-review/pr-260719/nixpkgs' is not a working tree
Failed to remove worktree at /home/ath/.cache/nixpkgs-review/pr-260719/nixpkgs. Please remove it manually. Git failed with: 128

The important bit seems to be:
fatal: couldn't find remote ref pull/260719/head

Other PRs, also those created later, work just fine. I don't see anything particularly special about that PR. I already tried nuking my nixpkgs and re-cloned it, but it didn't change anything.
Any idea what could cause this? Some GitHub bug where this ref wasn't created?

Looks like a github bug to me. I don't think there is anything I can fix in nixpkgs-review to counter that.

Alright, thanks! I'll close this for the moment then & we can revisit / report this to GH if it happens again.


feat: transaction time histogram metric

Changes proposed in this pull request

adds histogram metric to telemetry service and uses for new outgoing_payment_completion_time_ms metric
adds visualizations to grafana in new "Transaction Time Development" dashboard (will merge into other dashboards when its finalized): https://rafikitelemetry.grafana.net/d/ddpy9febd69s0d/transaction-time-development?orgId=1

Context

Checklist

[ ] Related issues linked using fixes #number
[ ] Tests added/updated
[ ] Documentation added
[ ] Make sure that all checks pass
[ ] Bruno collection updated

Some notes on the graphs...

It was difficult to generate even a small amount of data to populate the graphs. Just ran the bruno open payments flow a number of times for the one pictured in the pr body. More data would have been nice to validate the usefulness of the graphs (two distributions and transactions per second in particular).
heavily inspired by this grafana blogpost. https://grafana.com/blog/2020/06/23/how-to-visualize-prometheus-histograms-in-grafana/ That can serve as some example for what the distribution graphs might look like with more data. In particular the distributions over time.
the "Shorter than 500ms" metric might be useful if there is some threshold we want to target for transaction time. otherwise we can probably just get rid of that one. similar information is show in the quartile group.

@mkurapov @JoblersTune please also review the queries in the dashboard if you can https://rafikitelemetry.grafana.net/d/ddpy9febd69s0d/transaction-time-development?orgId=1

Some notes on the graphs shared in the pr body:

I wasnt really able to generate a large, meaningful amount of data for these graphs. Just ran the bruno open payments flow a number of times. More data would have been nice to validate the usefulness of the graphs (two distributions and transactions per second in particular).
heavily inspired by this grafana blogpost. https://grafana.com/blog/2020/06/23/how-to-visualize-prometheus-histograms-in-grafana/ That can serve as some example for what the distribution graphs might look like with more data. In particular the distributions over time.
the "Shorter than 500ms" metric might be useful if there is some specific threshold we care about. Most but not all completed under 500ms locally, which is why I picked it. Otherwise we can probably just get rid of that one. The quartiles kind of show similar info.

Is there a reason you're using rate(outgoing_payment_completion_time_ms_count[1m])  instead of just rate(transactions_total[1m]) ?
In terms of the interval, I'd probably go with maybe 5m instead, but it's much of a muchness. It just smooths things out more. But it depends if we want to look and see general trends or if we want to look and see anomalies.

Some notes on the graphs shared in the pr body:

I wasnt really able to generate a large, meaningful amount of data for these graphs. Just ran the bruno open payments flow a number of times. More data would have been nice to validate the usefulness of the graphs (two distributions and transactions per second in particular).
heavily inspired by this grafana blogpost. https://grafana.com/blog/2020/06/23/how-to-visualize-prometheus-histograms-in-grafana/ That can serve as some example for what the distribution graphs might look like with more data. In particular the distributions over time.
the "Shorter than 500ms" metric might be useful if there is some specific threshold we care about. Most but not all completed under 500ms locally, which is why I picked it. Otherwise we can probably just get rid of that one. The quartiles kind of show similar info.

Is there a reason you're using rate(outgoing_payment_completion_time_ms_count[1m])  instead of just rate(transactions_total[1m]) ?
In terms of the interval, I'd probably go with maybe 5m instead, but it's much of a muchness. It just smooths things out more. But it depends if we want to look and see general trends or if we want to look and see anomalies.
If we used transactions_total we'd get something more like this

I agree that  transactions_total is probably better. I was focusing on the new metric I created so I hadn't really considered that existing one. transactions_total at 5m intervals looks better - will update to that.


Convert sync handler to env variables

Continuation of this issue: https://github.com/rancher/rancher/issues/34875

Add all settings from sync handler (currently 4) as env vars.
Remove the settings sync handler: https://github.com/rancher/rancher/blob/release/v2.6/pkg/controllers/managementuser/settings/controller.go

Are there any concerns regarding updating of a downstream agent when one of these environment variables is changed? For example if I spin up a local and a downstream cluster, and helm upgrade ... --set env.CATTLE_SERVER_VERSION=v2.5.9, will the cluster agent be redeployed because it's deployment depends on the variable?

You can check this method. https://github.com/rancher/rancher/blob/5c2933173bc07a1cd260d6e07fd9459243afc45d/pkg/controllers/management/clusterdeploy/clusterdeploy.go#L184
I don't think it will reploy agent if you just change the env variable. We only redeploy acccording certain conditions above. ^^ If you upgrade rancher it will redeploy agent since agent image changes and that will trigger cluster-agent upgrade.

Setting up something to discuss.

Root cause
What was fixed, or what changes have occurred
Settings are no longer synced downstream, and instead passed from the local cluster to the cluster-agent deployment template as environment variables.
The following settings are used to trigger a redeployment:

server-version
install-uuid
ingress-ip-domain

Areas or cases that should be tested
Changing server-version, install-uuid, or ingress-ip-domain in the local cluster triggers a redeployment of the downstream agent. Likewise, changing any other setting should not trigger a redeployment of the downstream agent.
What areas could experience regressions?
N/A
Are the repro steps accurate/minimal?
Deploy a downstream cluster, and then edit one of the settings, either through API or externally (i.e. kubectl, lens, etc.). The cluster agent should be redeployed.

on 2.6-head (78b25c3) I've tested the following:
example of how to change one of these vars: go to <your_server_ip>/v3/settings/<your_variable> -> edit -> send request

update install-uuid (random name) -> cattle-cluster-agent pod is redeployed -- pass
update ingres-ip-domain (to nip.io) -> cattle-cluster-agent pod is redeployed -- pass

validate that new domain propagates to downstream resources by deploying a new ingress using the auto-generated name -- pass

update a setting that is not one of the 3 mentioned in the comment above -> no redeployment of any agent pod(s) -- pass

some variables are protected, and give a 405 with message is readOnly because its value is from environment variable, other variables allow an edit through the API and the cluster agent is not restarted

note: from what I could find, there isn't a way to update the server-version through the UI, so instead I did an update of the local cluster and used a newer version from there, which also resulted in an update to the downstream cluster agent -- pass


Make 'bits' an accessible property of BinaryValue

Prevents using of constructs like len(BinaryValue.binstr)

this looks good. Got any tests for the change?
If you merge imphil:travis-lcci-image then travis will start passing again.

something easy like this seems worth adding:
diff --git a/tests/test_cases/test_cocotb/test_cocotb.py b/tests/test_cases/test_cocotb/test_cocotb.py
index 1982cff..9780323 100644
--- a/tests/test_cases/test_cocotb/test_cocotb.py
+++ b/tests/test_cases/test_cocotb/test_cocotb.py
@@ -632,6 +632,13 @@ def test_binary_value(dut):
     """

     vec = BinaryValue(value=0,bits=16)
+    dut._log.info("Checking accessing bits")
+    if vec.bits != 16:
+        raise TestFailure("bits aren't getting set correctly")
+    vec.bits = 17
+    if vec.bits != 17:
+        raise TestFailure("bits aren't getting updated correctly")
+
     dut._log.info("Checking default endianess is Big Endian.")
     if not vec.big_endian:
         raise TestFailure("The default endianess is Little Endian - was expecting Big Endian.")

@oligu as @forensicgarlic a testcase for this would be good, else it will wait for me to write one and then merge it.

My second comment has a simple test case. Would you want something more than that, @stuarthodgson ?

@stuarthodgson just pinging this issue again, anything more than the test I included above necessary?

I agree with @eric-wieser  that the naming bits is confusing, but is part of the constructor and hence should stay for backward-compat reasons. Having the same name all over the class is at least consistent.

Since we didn't hear back from @oligu I've opened #713 superseding this PR and adding the tests.
@oligu if you are still around I'd be happy if you could have a look at the updated PR and comment on it. Thanks!


Add to status field

Note on 2/18 from Zoe:
"If it's possible, it would be great to add to the dropdown list in the status box:

Prospective Enslavement
Formerly Enslaved"

A question: where should the new additions go? (By the way, it's completely ok to re-order the list in the answer.)
Desired additions...

'Prospective Enslavement'
'Formerly Enslaved'

Existing Menu...

'Indentured Servant'
'Servant'
'Slave'
'Captive'
'Threatened Enslavement'
'Indenture, Court-Ordered'
'Indenture, Parental'
'Indenture, Voluntary'
'Free'
'Unclear'
'Other'

Order identified by Lin on 2/19:
'Indentured Servant'
'Servant'
'Slave'
'Captive'
'Threatened Enslavement'
'Indenture, Court-Ordered'
'Indenture, Parental'
'Indenture, Voluntary'
'Prospective Enslavement'
'Formerly Enslaved'
'Free'
'Unclear'
'Other'

implemented in commit 84354c85a19a098ec8fd05e3f969595340699dcd


Upgrading to PyQt6

This GUI is currently built using PyQt5 however this is not supported on Apple Silicon (the M1 chip). Apple Silicon support is only available from PyQt6.2 so we need to upgrade the GUI framework.

@AdinaRahim I will work on this on the gui_windows_setup branch.

Done.


Pass through missing span factories

Solves the issue of missing span factories not being passed through, thus enabling anything that relies on Spans to correctly work when used with Multitenancy extension

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Invalid global ID: null when using optional arg.globalIdList

Hi @hayes!
I'm trying to use the global ID list in my arguments with nullable items:
    categoryIds: arg.globalIDList({
      description:
        "A list of category IDs to filter transactions by. If provided, only transactions assigned to one of these categories will be returned.",
      for: CategoryNode,
      required: {
        items: false,
        list: false,
      },
    }),

The use-case here is that I also want to find transactions that have categoryId: null. When pothos intercepts my query, it throws a Invalid global ID: null error - defined here.
I think we need a check before decoding the base 64 to ensure the encoded value is defined. If it isn't and the list accepts nullable items, we should return null instead.
What do you think?

fixed here: https://github.com/hayes/pothos/commit/0f5cfa95036c3f5727a72885bd11cf35d48b8728
thanks for the report!


Make AssetHub as DOT reserve

We need this as a part of issue https://github.com/galacticcouncil/hydration-node/issues/857
What we want for now:

DOT can be sent to hdyra.
And DOT can be sent to AH from hydra.

The main use case is AssetHub is the main hub for every assets, so there will be many transacitons where we want to use DOT as fee.
TODO: once the draft PR is ready, we should adjust/close PR https://github.com/galacticcouncil/hydration-node/pull/885

Work is done here: https://github.com/galacticcouncil/hydration-node/pull/911

We still need to do this but

[ ] make sure treasury DCA works
[ ] XCM UI works


release-2.3: fix hub dry run for helm subscription not able to get secret and configmap properly

Signed-off-by: Mike Ng<EMAIL_ADDRESS>for https://github.com/stolostron/backlog/issues/23541

/lgtm

@xiangjingli please take another I had to make it fix to make sure the NS value weren't populated before overriding it with the channel NS value.

/lgtm