Length check is not unicode-compatible

I’m using str.length to check the string length and I won’t change anything if the string length is equal to the limit. But this has a bug:
limit("😒😒", 4); // Result: 😒😒

This is because "😒😒".length === 4 which is wrong. Javascript’s String.prototype.length is not unicode-aware and returns the wrong length. This should be fixed ASAP.

Solved by https://github.com/sallar/limit-string-length/commit/ae1e2688b00bedd0d766b840142d93948a3feae4


CSIP #12 to #16

The revision history does not state that the CSIP interrupt ID was changed from 12 to 16 on 29th August 2022. This is an important change and should be explicitly stated.

Can you also clarify whether the CSIP in its new location behaves any differently to other local interrupts (number 17 upwards) or is it now really just another local interrupt that happens by convention to be called CSIP?
Thanks.

I updated the revision history to state CSIP interrupt ID was changed from 12 to 16.
leaving this issue open to discuss your second question.   My understanding is that all the interrupts on the CLIC behave the same and the CLIC Interrupt ID ordering recommendations are just conventions for software compatibility, but we should probably add more text to clarify that.

copying JamesKenneyImperas comment from commit to here and reopening this issue for easier tracking in TG meetings
:
This is a minor point, but I think it would help readability if a consistent and precise name was used to describe interrupts with id 16 and above in this specification.
In this section, they are referred to as "external interrupts". In section 3.2, they are referred to as "local interrupts". In section 3, they are referred to as "local external interrupts".
Thanks.

Closed with https://github.com/riscv/riscv-fast-interrupt/commit/1dc8432d6bf28b584deae84437d61f51c5f53f01


Restrict manifest v3 to 128.0 (Fixes #280)

Fixes #280
This adds two additional checks to our manifest.json parser.

If a manifest.json has manifest_version: 3, require that strict_min_version exists and is greater than or equal to 128.0b1.
If a manifest.json has manifest_version: 3 don't allow the applications key.

cc @jobisoft

I added 128.0b1 as an actual usable app version:

Not sure there is such a thing as "b1" at all? I thought betas had internal version the same as release, intentionally so.

Not sure there is such a thing as "b1" at all? I thought betas had internal version the same as release, intentionally so. A letter is only present on Daily versions.

How do we solve this?
In our past communication, we said (as an example) 128.0 is greater than 128.0a1. And indeed, I cannot install an add-on in 128 Daily with "strict_min_version": "128.0".
I can however install an add-on in 127 Beta with "strict_min_version": "127.0". So it appears the order is
*.0a1 < *.0 <= *.0b1 (probably because it is just like *.0)
Is that correct? Based on my test with "strict_min_version": "127.0", we then should be fine with enforcing a min version of 128.0 for Manifest V3, as that will exclude Daily, but include Beta, which is what I want.
Does that sound sensible?

Its a two second change so let me know if it should be 128!

Its a two second change so let me know if it should be 128!

Yes, it must be 128.0 as minimum requirement. Thanks!

Okay changes are up. Any final reviews before this is good to merge?

Will test it on stage, and merge it up after. Thanks!


Fix TOML parser

looks like tomllib was only introduced in 3.11, and I'm struggling with it on 3.12
Let's use the older toml library for now

Done :)

merging this since it's broken


get wrong field type from a TEXT column

Env:

OceanBase Community Edition 3.1.1 and 3.1.2-OceanBase CE
oblogproxy: prebuilt rpm from https://github.com/oceanbase/oblogproxy/releases/tag/v1.0.0

Get UNKOWN type from a TEXT column, not sure it's caused by which component.

Field type value is 252 for TEXT column.


HTML export improvements

Dunno if this is still maintained, but I made use of it today so thought I'd contribute back.
The main goal was some more functional HTML output. Blurring out the QR codes makes it easier to take a picture of a single code on the screen, and putting them in a grid makes it easier to find the ones you're looking for without lots of scrolling.
While I was adding that, I noticed the code was a bit of a mess so I cleaned it up some. Whitespace is now consistent, files are not getting opened and closed inside a loop, and there's less repetition.
This worked nicely for me to grab my tokens, thanks!

Dunno if this is still maintained, but I made use of it today so thought I'd contribute back.
The main goal was some more functional HTML output. Blurring out the QR codes makes it easier to take a picture of a single code on the screen, and putting them in a grid makes it easier to find the ones you're looking for without lots of scrolling.
While I was adding that, I noticed the code was a bit of a mess so I cleaned it up some. Whitespace is now consistent, files are not getting opened and closed inside a loop, and there's less repetition.
This worked nicely for me to grab my tokens, thanks!

Thanks a lot  - the change was reviewed and added to the code.


BibFormat: outdated_caches() fix

Fixes outdated_caches() query that, by filtering out record not
modified since the last bibreformat run, was implicitly skipping
those records that were, by whatever reason, not reformatted in
the past.

Signed-off-by: Samuele Kaplun<EMAIL_ADDRESS>

Closed by #3725.


Cannot download ppc64le binaries

I am trying to download IBM Spectrum Computing Cloud Pak Technical Preview. But it seems there is a problem with download link from the following URL  https://epwt-www.mybluemix.net/software/support/trial/cst/programwebsite.wss?siteId=548&h=&tabId=1091&p=

Hi @regiscely. Thanks for reporting this.  I tried just now and got the following error
Error 400: Invalid path /web/prelogin was requested

Do you also get this error?

Yes, I get the same error

Use this temporary link until the main one is repaired.
https://www-01.ibm.com/marketing/iwm/iwm/web/dispatcher.do?source=swerpsw-pak-3

The main link has been restored.


ng-click not working within a label

See next plunker that illustrates the issue: http://plnkr.co/edit/D9HD1AaTz2dIwRyfMUmP?p=preview

Greetings @mark-veenstra!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

This is part of Ionic's fastbuttons implementation, necessary for speedy ionic form directives. In your case, you'd want to use data-tap-dsiabled="true" like so:
http://plnkr.co/edit/9dqT2JUWv6RzzQlqvUzD?p=preview


Reference topic for Rolling Upgrade

Please review the first draft

@Arau FYI Please do not merge to 2.6.0 release branch - thank you

@hubvu fyi updated to merge into 2.7.0-docs branch first

Merging to the 2.7.0 branch as this is a legacy PR


throw error on circular dependencies?

I'd like to add this to my CI pipeline, and have it automatically kick back if there are any circular dependencies. It doesn't seem possible currently to throw when circulars are found, but am I reading the docs wrong?

If you're running madge -c src it will exit with a non-zero status code if circular dependencies are found which should break your CI pipeline.


Update package name and namespace

Azure.Search -> Azure.Search.Documents or equivalent

We don't have namespaces in JS, so does this mean we want to change the package name? Since nightly already published to @azure/search that name is spent up to version 11 now.

Yes -- the package name. That is unfortunate... I don't suppose there is anything we can do there, correct?

My understanding is we could delete it but it would be forever gone at that point.
Details: https://docs.npmjs.com/unpublishing-packages-from-the-registry
For now we can deprecate it and link to the new name when it is released.

Current candidate: @azure/search-documents
/cc @bterlson do you like this name?

My only real concern is that we'll have @azure/search there forever at this point. Should we just use it since we already burned it?
If we really do want to align here, then @azure/search-documents is fine by me!


Proper Way to Handle Missing Tables?  I get "no such table" error

Because CreateTable() only registers a table and doesn't actually put anything in the database, if I try to use Query() or Table() methods to access data on the table, I get the error "no such table".
Is there a method to actually create an empty table without putting any data in it?
If not, the only work-around I can think of is to try to access the table as soon as its registered and check for an error.  If there's an error, assume the table doesn't exist and then make it by sticking in a dummy object and then deleting the dummy object to make the table empty. Seems ugly. Would definitely like to be able to call a simple library method to truly create missing tables.

CreateTable should indeed be creating empty tables. If your code is short, would you mind sharing it? It sounds more like you have a race condition and you're not calling CreateTable before your other database operations.
It's important that you do this before doing any other work in the DB. Your init code (for new databases) should always be something like:
var db = new SQLiteConnection ("foo.db");
db.CreateTable<Thing> ();

Ok.... Well now when I test that code premise, it's working the way you described.  O_o   I have no idea what I did before that was causing the problem.  And it seems like maybe I do have some kind of race condition. But I can't fathom how.  The first thing I'm doing always is calling CreateTable() before I try to query it.

I seem to be having a race condition with the same thing but using the async connection. I'm using it on Xamarin. I've tried with the lazy loading and now with a simpler version.
I'm using Xamarin Forms with Android and sqlite-net-pcl 1.6.292
This is how I create the database connection:
public class Database
{
    public SQLiteAsyncConnection Connection { get; }
    private const SQLiteOpenFlags Flags =
        SQLiteOpenFlags.ReadWrite |
        SQLiteOpenFlags.Create |
        SQLiteOpenFlags.SharedCache |
        SQLiteOpenFlags.ProtectionNone;
    public Database(string databasePath)
    {
        Connection = new SQLiteAsyncConnection(databasePath, Flags);
    }
}

Nothing special there other than the fact that I am using the SQLiteAsyncConnection
I am registering this Database class in my DI container as a singleton. Example:
services.AddSingleton(sp=> new Database("foo.db3"));

I have created a DatabaseManager (also as singleton) simply to create the tables.
public class DatabaseManager
{
    private readonly Database _database;

    public DatabaseManager(Database database)
    {
        _database = database;
    }

    public async Task TryCreate()
    {
        await TryCreateTable(typeof(StreamData));
        await TryCreateTable(typeof(EventData));
    }

    private async Task TryCreateTable(Type tableType)
    {
        if (_database.Connection.TableMappings.All(m => m.MappedType.Name != tableType.Name))
        {
            await _database.Connection.CreateTablesAsync(CreateFlags.None, tableType).ConfigureAwait(false);
        }
    }

    private async Task Close()
    {
        await _database.Connection.CloseAsync();
    }
}

One problem I have is that I cannot await the TryCreate() because I am on a syncrhonous context (e,g: on Android's void OnCreate method)
To provide even more details, this is the Init method I call from Android's OnCreate that will make the DI registrations, will resolve the database manager and create the database tables.
public static class Startup
{
    public static IServiceProvider Init(string databasePath)
    {
        var serviceProviderOptions =
            new ServiceProviderOptions
            {
                ValidateOnBuild = true,
                ValidateScopes = true
            };

        var serviceProvider =
            new ServiceCollection()
                .AddSingleton(sp=> new Database(databasePath));
                .AddSingleton<DatabaseManager>();
                //etc.
                .BuildServiceProvider();

        var databaseManager = serviceProvider .GetService<DatabaseManager>();
        databaseManager.TryCreate().Wait(); // wrapping this on Task.Run(async () => await databaseManager.TryCreate()).Wait(); does not help either

        return serviceProvider;
    }
}

Now, I am testing this in paralell with xUnit. When the tests run at the same time, one or both fail. When I run them independently, they succeed
SQLite.SQLiteException : no such table: EventData

Each test calls the Init and creates a new database. Immediately there are operations against it.
It seems there is a race condition and by the time the test hits the database, the tables haven't been yet created
Tests here:
public class Tests
{
    private MyService_sut;
    private IRepository _repository;

    public Tests()
    {
       //it generates a new database for each Fact
        var databasePath = $"{Guid.NewGuid()}.db3";

        var serviceProvider = Startup.Init(databasePath);
        _sut = serviceProvider.GetService<MyService>();
        _repository= serviceProvider.GetService<IRepository>();

        WhenAsync().GetAwaiter.GetResult();
    }

    protected override async Task WhenAsync()
    {
        await _sut.DoSomethingThatWritesInDatabase();
    }

    [Fact]
    public async Task Then_It_Should_Have_Saved_An_Item()
    {
        var items= await _repository.GetItemsFromDatabase();
        items.Should().HaveCount(1);
    }

    [Fact]
    public async Task Then_It_Should_Be_Whatever()
    {
        var items= await _repository.GetItemsFromDatabase();
        items.First().Should().BeAssignableTo<ItemWhatever>();
    }
}

Any advice would be much appreciated!

I created the issue and added a public repo to reproduce the problem https://github.com/praeclarum/sqlite-net/issues/947


Using our own shapefiles instead of osm data

How should I go about using my own road, POI and polygon data instead of the OSM pbfs.

A lot of the queries and processing assumes that the data is coming from OSM. If you'd like to serve tiles from alternate sources, you might want to take a look at TileStache.


Can't have VsCode breakpoints to work in SSR endpoints

Describe the bug
Me failed to get stepped debugging SSR code of the default (vite-based, created in the way recommended on the SvelteKit site) project in VsCode. Many settings in 'vite.config.js' & 'launch.js' were tried.
Reproduction
Any project with SSR endpoints
Logs
No response
System Info
System:
    OS: Windows 10 10.0.22000
    CPU: (4) x64 Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz
    Memory: 1.27 GB / 11.90 GB
  Binaries:
    Node: 16.16.0 - C:\Program Files\nodejs\node.EXE
    npm: 8.17.0 - D:\MyProjects\JS\SVELTEKIT\pokemon-tutorial\node_modules\.bin\npm.CMD
  Browsers:
    Chrome: 104.0.5112.102
    Edge: Spartan (44.22000.120.0), Chromium (104.0.1293.70)
    Internet Explorer: 11.0.22000.120
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.64
    @sveltejs/kit: next => 1.0.0-next.445
    svelte: ^3.44.0 => 3.49.0
    vite: ^3.0.0 => 3.0.9

Severity
serious, but I can work around it
Additional Information
No response

I don't think this is something we can "fix", this sounds more like a usage question, therefore turning this into a discussion.


touchosc: <IP_ADDRESS> -> <IP_ADDRESS>

Description of changes
Release notes: https://hexler.net/touchosc/releases#<IP_ADDRESS>
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 193537 run on x86_64-linux 1

1 package built:

touchosc

Thank you!


Logical database management CRD

Please add CRD to manage logical databases in a cluster. This probably should be followed by decomposition of role and user CRD-s as well

Thanks for the #497 reference
I think users and roles should be decomposed into separate CRD-s

@laurivosandi well you can continue on the discussion! :D for sure we read everything and every time we can we talk about this issue, also you can join the bi-weekly meeting if you would like to talk more directly and provide your reasons!
I'm closing this since it's not considered an issue yet
Regards!


Use implementation of copytree that works on both Linux and Mac witho…

…ut issues

Coverage decreased (-0.6%) to 87.667% when pulling 0fd7791e9bc4e5e902886885f416796c2d0328e1 on mjgorman:LinuxZipFix into d6a06f2d3233fc1777dd993f1e42b384f0d24439 on Miserlou:master.

Excellent, thanks!


fix(package): artificial change

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@64be8f8). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master      #2   +/-   ##
========================================
  Coverage          ?   98.9%
========================================
  Files             ?     130
  Lines             ?    5731
  Branches          ?     763
========================================
  Hits              ?    5668
  Misses            ?      63
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64be8f8...a2be2ef. Read the comment docs.


fix: update package

update package version to resolve errors

:tada: This PR is included in version 1.0.0-alpha.4 :tada:
The release is available on:

npm package (@release-v1 dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


match the missing '>' in java generics

@yx91490 Hi, bro, please don't merge anything to master branch, dev instead

@yx91490 Hi, bro, please don't merge anything to master branch, dev instead

sorry, but I can't found dev branch in this repo? do you mistake it with dolphinscheduler repo?

@yx91490 Hi, bro, please don't merge anything to master branch, dev instead

sorry, but I can't found dev branch in this repo? do you mistake it with dolphinscheduler repo?

Oh,yes, I mistake it, let's reopen this issue


Mismatch in prop names

This should be Database:
https://github.com/berenddeboer/cdk-rds-sql/blob/2ee7dd1e969bb7b0d7291faa0d6b66f49c34498b/src/role.custom-resource.ts#L58
As that is what the handler expects:
https://github.com/berenddeboer/cdk-rds-sql/blob/2ee7dd1e969bb7b0d7291faa0d6b66f49c34498b/src/handler.ts#L214
Otherwise, an error is thrown:
{
    "errorType": "error",
    "errorMessage": "database \"root\" does not exist",
    "code": "3D000",
    "length": 89,
    "name": "error",
    "severity": "FATAL",
    "file": "postinit.c",
    "line": "921",
    "routine": "InitPostgres",
    "stack": [
        "error: database \"root\" does not exist",
        "    at Parser.parseErrorMessage (/var/task/index.js:22772:98)",
        "    at Parser.handlePacket (/var/task/index.js:22613:25)",
        "    at Parser.parse (/var/task/index.js:22537:34)",
        "    at Socket.<anonymous> (/var/task/index.js:22813:44)",
        "    at Socket.emit (node:events:513:28)",
        "    at addChunk (node:internal/streams/readable:315:12)",
        "    at readableAddChunk (node:internal/streams/readable:289:9)",
        "    at Socket.Readable.push (node:internal/streams/readable:228:10)",
        "    at TCP.onStreamRead (node:internal/stream_base_commons:190:23)"
    ]
}

I think this is fixed now.


[GIT-GUI] unicode problem in commit input box

I have problem with unicode character when write unicode text.

Hey, this is the issue tracker for the git-scm.com website, not Git itself. If you still want to discuss this issue, you should reach out to the community.


Fix crashes with dmabufs not from external kernel modules

In particular, when software rendering, it is entirely possible to have
a dmabuf that did not come from an externally loaded kernel module. As a
result, the owner field is NULL, and checking the owner's name
segfaults.
Tested on the Asahi Linux kernel, where software rendering is used.

Looks good, thanks!


[bugfix] only filterable columns should show up in FilterBox list

Also fixing issue where controls override for mapStateToProps would not be applied

Coverage increased (+0.2%) to 69.269% when pulling b64e10e3659b38700ffa33576786e0841166ce67 on mistercrunch:filterable into 56bcbb0f8e022434b7e0fc32be9e4cb650c1eeba on apache:master.

Coverage increased (+0.2%) to 69.269% when pulling b64e10e3659b38700ffa33576786e0841166ce67 on mistercrunch:filterable into 56bcbb0f8e022434b7e0fc32be9e4cb650c1eeba on apache:master.

Coverage remained the same at 69.175% when pulling 0c2cac2f2862d119b0dc805d037700e3c48cdf1a on mistercrunch:filterable into 49ab09101b00e4981b35875dda4d7da154222bd0 on apache:master.

Coverage remained the same at 69.175% when pulling 0c2cac2f2862d119b0dc805d037700e3c48cdf1a on mistercrunch:filterable into 49ab09101b00e4981b35875dda4d7da154222bd0 on apache:master.

Coverage remained the same at 69.175% when pulling 0c2cac2f2862d119b0dc805d037700e3c48cdf1a on mistercrunch:filterable into 49ab09101b00e4981b35875dda4d7da154222bd0 on apache:master.


v2.2.1

Goal
2.2.1 (2022-02-21)
Bug fixes

Fix middleware panic on nil *http.Request
#212

Design

Changeset
Added checks for nil pointer in parsing RawData from Event.
Testing
Added unit tests for handling nil http.Request inside Event's RawData.

We also need to update the version in v2/bugsnag.go


fix(rt): fix readFully when using ktor 2.0

this change fixes reading bytes content under ktor 2.0

Issue #

awslabs/aws-sdk-kotlin#480
Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing this MR for now as Jetbrains said they will fix the binary incompatibility themselves.
See https://youtrack.jetbrains.com/issue/KTOR-3630


Adding dummy python wrapper (when Epsagon is disabled)

:tada: This PR is included in version 1.56.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


black screen , android tv

Environment

OS: Windows 10 2H21
scrcpy version: V1.18
installation method: Windows Release
device model: TCL Android TV
Android version: Android Pie 9

Describe the bug
UI Only showing in scrcpy , i do adb wireless with my android tv anything was fine mouse & keyboard but when i play a video on youtube or goes to HDMI inputs nothing shows only a black screen but when i click at settings button or trying to down or up the volume the ui shows without the video ( like backgroud ) on scrcpy only but in tv is fine

That's expected. The video may not be captured due to hardware restrictions (either DRM or just due to the architecture).

but when I use live app,It not work for me(black screen without UI)
I guess it not work on SurfaceView(or TextureView?)
but it working fine on my phone.

with magiconnect is possible to take a screenshot.


OIDC update to support HTTPS identity provider on plain socket Helidon

Related to #3590
Adds support for https enforcement for IDP redirects.

Please create a backport for 2.x for milestone 2.5.1, thanks

@Verdent FYI


Add a combinator for converting an Option<Future> into a Future<Option>

Consider the following code, where bar is an async function:
let foo = Some(24);

foo.map(|foo| bar(foo))

The end result of this is an Option<impl Future>. In order to await or poll() this future, it needs to be matched on or unwrapped, which may be messy or undesired.
I propose a combinator to the tune of into_future(), with a public API like this:
trait OptionExt<F> {
    fn into_future(self) -> IntoFuture<F>;
}

struct IntoFuture<F>(Option<F>);

impl<F: Future> Future for IntoFuture<F> {
    type Output = Option<F::Output>;
}

This may also be useful for Result.

Discussed this in https://github.com/rust-lang/futures-rs/issues/2581, however Rust std wasn't extended with impl IntoFuture for Option<Fut> :cry:

Ah, I see.


Add parameter top_k to RetrievalMAP

What does this PR do?
Fixes #1491

Before submitting

[x] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?
Make sure you had fun coding 🙃

@lucadiliello please review :)

I will do a last review of the failing tests tomorrow before merging.

Since we are left only with RetrievalMRR without support for top_k parameter, should we add support for it in this PR?

Since we are left only with RetrievalMRR without support for top_k parameter, should we add support for it in this PR?

@lucadiliello Feel free to do so :)


i think Hawk.remove() should use "sql  like "

count1 = db.delete("hawk", "hawk_key='" + key + "'", (String[])null);
remove() Need to know all of the key ，but we use Key name like article_{id} In the majority situation ,so Cannot be easily removed , O(∩_∩)O 在线翻译凑出来的，凑合看吧

👍 Sqlite is no longer supported in new version due to main reason. Therefore closing this issue.


Trix/master/sa option

Coverage remained the same at 81.185% when pulling 27f8c09fdb79e8d89f864b8fa93aa185cf1f94bc on trixirt:trix/master/sa-option into b742dfe553c47d382a14764b8233d0f6b8493dd9 on OPAE:master.


ReadFile / WriteFile

Add ReadFile and WriteFile.
There are also some helpers to simplify synchronous use, I plan to add Task helpers later, they are a little bit more involved in quantity of code.
Also I didn't add CreateFile2 Or GetOverlappedResultEx so store apps can only use the synchronous read/write.

On my local (Win10) test machine all overlapped read/writes are asynchronous but it doesn't seem to be the case on appveyor and it's a possibility documented on MSDN so i'll cover it in the tests.
The downside is that it's possible that the Overlapped tests don't test anything really linked to overlapped IO.
But it still act as living documentation of the code and works on some machines so I'll let it there for now.
Ideally the code should be ported to using Pipes instead of files so we can control whenever the IO terminate or not. I'll create an issue for that.

Looks pretty good. But I'll be interested in reviewing your responses to my comments prior to merging.

LGTM. Merge when ready. :)


call-automation-server-recording-javascript-sample

Purpose

...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

need to created PR pointing to moirf
/
communication-services-javascript-quickstarts repo. So closing it.


publishing views error

When running the command:  php artisan weblog:publish --views
I receive the following error:
 [ErrorException]
 Invalid argument supplied for foreach()

However, this command works correctly:
 php artisan vendor:publish --provider="GeneaLabs\LaravelWeblog\Providers\LaravelWeblog" --tag="views"

What version of Laravel are you running? (Asking for the other issues as will)

Laravel Framework version 5.2.36

I think this was only an issue with 0.1.0, seems to work fine in master branch. Can you give it a go and let me know (reopen if it still doesn't work for you)?


pip search error

[dev] [mav@maverick-nano ~/var/build/libnice]$ pip search meson
ERROR: XMLRPC request failed [code: -32500]
RuntimeError: PyPI's XMLRPC API is currently disabled due to unmanageable load and will be deprecated in the near future. See https://status.python.org/ for more information.

pip search has been disabled by pip team.  no replacement except to go search manually on pypi.org.


add SGS STAS-PLUS for OCM-Online Model

Thank you for contributing to the IoT Plug and Play Models repository
:memo: Please review this checklist before submission

[x] :eyes: The models submitted in this PR follow the DTDL Naming Guidelines for contributing to this repository.
[x] 🕵I have validated the models locally using the dmr-client command line tool.
[x] ❗ I understand once the PR is approved, the models are considered immutable: any edits will require to submit new files.
[x] ✨ When creating a new top level dtmi:namespace, I have completed the PR Info Template below.

:zap: PR validation steps are described in the tools Wiki.
PR Info Template
When submitting models to the repository we ask that you provide as much of the following meta information around your models and related devices as possible. This info will be used to improve the IoT Plug and Play ecosystem.
👇: Please replace the markdown comment examples with your own values.
Company Info

GuangZhou ShineTech Intelligent Technology Co., Ltd. .

IoT Plug and Play Device Info

It is a IOT gateway device that uses azure IOT SDK to send and receive messages.

Model Submission Goals

Device certification.

Code Owners & Reserved Names

Indicates GitHub alias entries to be added to the repo CODEOWNERS for the incoming model namespace. The codeowner is expected to be involved in subsequent DTDL model submissions against the same namespace.

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact<EMAIL_ADDRESS>with any additional questions or comments.

Can you update the PR info template?
-- I updated it


Content of all tabs of a UITabContainer become visible when showing the UIWindow that contains UITabContainer

Describe the bug
When you call "show" on a UIWindow containing a UITabContainer, the contents of all tabs become visible.
To Reproduce
Steps to reproduce the behaviour:

Run the reproducible example below
Close the UIWindow object
Click the UIButton object to show the window again

Expected behaviour
I expected that only the content of the last selected tab to become visible.
Screenshots
If applicable, add screenshots to help explain your problem.
Platform and software (please complete the following information):

OS: Ubuntu 24.04 LTS, Linux Kernel 6.8.0-40-generic x86_64
Pygame GUI version: pygame_gui        0.6.12
Pygame version: pygame-ce         2.5.0

Reproducible example:
import pygame as pg
import pygame_gui as pgg

SHAPE = (800, 600)
pg.init()
pg.display.set_caption('Quick Start')
clock = pg.time.Clock()
manager = pgg.UIManager(SHAPE)
window_surface = pg.display.set_mode(SHAPE)
background = pg.Surface(SHAPE)
background.fill(pg.Color('#000000'))

class MyWindow(pgg.elements.UIWindow):
    def on_close_window_button_pressed(self):
        self.hide()

btn = pgg.elements.UIButton(pg.Rect(32, 32, 120, 24), 'Show window')
win = MyWindow(pg.Rect(32, 64, 320, 480), manager, 'Janela')
tabs = pgg.elements.UITabContainer(pg.Rect(0, 0, 320, 480), manager, win)
for i in range(4):
    tab = tabs.add_tab(f"Tab{i}", f"tab{i}")
    lab = pgg.elements.UILabel(
        pg.Rect(16, 16+24*i, 120, 32), f"Label for Tab {i}",
        manager, tabs.get_tab_container(tab))

is_running = True
while is_running:
    time_delta = clock.tick(60)/1000.0
    for event in pg.event.get():
        if event.type == pg.QUIT:
            is_running = False
            break
        if event.type == pgg.UI_BUTTON_PRESSED:
            win.show()
        manager.process_events(event)
    manager.update(time_delta)
    window_surface.blit(background, (0, 0))
    manager.draw_ui(window_surface)
    pg.display.flip()
pg.quit()

From the source code, in elements/ui_window.py
def show(self):
"""
In addition to the base UIElement.show() - show the _window_root_container which will
propagate and show all the children.
"""
super().show()
if self._window_root_container is not None:
self._window_root_container.show()
The function show() you are calling from the UIWindow class describes in the function commentary that this function will show all the children from that container. Practically, it does what it says it does, so another function should be created for these cases.

Possible solution.
Kill the window and recreate it again.
import pygame as pg
import pygame_gui as pgg
SHAPE = (800, 600)
pg.init()
pg.display.set_caption('Quick Start')
clock = pg.time.Clock()
manager = pgg.UIManager(SHAPE)
window_surface = pg.display.set_mode(SHAPE)
background = pg.Surface(SHAPE)
background.fill(pg.Color('#000000'))
class MyWindow(pgg.elements.UIWindow):
def on_close_window_button_pressed(self):
self.hide()
btn = pgg.elements.UIButton(pg.Rect(32, 32, 120, 24), 'Show window')
win = MyWindow(pg.Rect(32, 64, 320, 480), manager, 'Janela')
tabs = pgg.elements.UITabContainer(pg.Rect(0, 0, 320, 480), manager, win)
for i in range(4):
tab = tabs.add_tab(f"Tab{i}", f"tab{i}")
lab = pgg.elements.UILabel(
pg.Rect(16, 16+24*i, 120, 32), f"Label for Tab {i}",
manager, tabs.get_tab_container(tab))
is_running = True
while is_running:
time_delta = clock.tick(60)/1000.0
for event in pg.event.get():
if event.type == pg.QUIT:
        is_running = False
        break
    if event.type == pgg.UI_BUTTON_PRESSED:
        #check that we clicked the right button
        if event.ui_element == btn:
            #destroy the window
            win.kill()
            #recreate it again
            win = MyWindow(pg.Rect(32, 64, 320, 480), manager, 'Janela')
            tabs = pgg.elements.UITabContainer(pg.Rect(0, 0, 320, 480), manager, win)
            for i in range(4):
                tab = tabs.add_tab(f"Tab{i}", f"tab{i}")
                lab = pgg.elements.UILabel(
                    pg.Rect(16, 16+24*i, 120, 32), f"Label for Tab {i}",
                    manager, tabs.get_tab_container(tab))

    manager.process_events(event)
manager.update(time_delta)
window_surface.blit(background, (0, 0))
manager.draw_ui(window_surface)
pg.display.flip()

pg.quit()


implement sentry

add permission to "send events to improve..." to at the end of the installation

Before beginning, I have some ideas how to incorporate sentry into SCT.
Maybe at the next meeting, we could talk more about it.

I will start by adding reporting to selected error.
If we like what we see we can add it to all error, or not!
We could also add reporting to the log.error() level and above, but that might spam our sentry server. Limiting the reporting to log.critical() might make more sense. Also critical is not used at all right now in the sct, that would be a nice way of integrating good logging practice and we would know that everything critical would be reported to us (is the user agreed at installation time of course).

log.error() sounds good. We'll change the strategy if we get flooded

To put in the request for agreement
Sanitizing Data¶
Before we sent the information to our servers:

* We remove all keys which resemble password, secret, or api_key within stacktrace contexts, HTTP bits (such as cookies, POST data, the querystring, and environment), and extra data.

* We removes all stacktrace context variables, it ensures none or your local scoped information is available to our server.


WolfRPG added new encryption

sorry my english is bad
WolfRPG added new encryption ver Ver3.310
so i testing that using editor 3.334(last released version) can't unpacking .wolf
can you support for that encryption?

I have added experimental support for the new encryption.
As it is currently primarily adopted IDA code, I have not created a new release.
Once the code has been cleaned up and properly tested, it will be included in the next release.


Add Docker compose file and the env to the repo

Please add the Compose and env files of the docker to the repo, so that it will be easy to clone the entire project and run the docker compose-up command to run the application.
I'm raising a PR for the same.
Is there any particular reason why your team didn't add compose and env files along with the repo?

https://github.com/akto-api-security/akto/pull/76

Thank you so much for the contribution! The changes have been merged 👍

Please assign this to me, So that it will be easy for to track later @Ankita28g

Done. Happy hackfesting 🎉

Thank you so much for the contribution! The changes have been merged. ❤


[Feature Request]: Support read from / write to AWS Glue catalog tables backed by AWS S3 data

What would you like to happen?
Overview
Glue catalog is a serverless metadata storage (databases, tables, schemas, partitions, connectors, etc). More: https://docs.aws.amazon.com/glue/latest/dg/glue-connections.html
It would be cool to have Beam supporting smth like:
GlueIO.write()
      .withClientConfiguration(awsClientConfiguration)
      .withDatabaseName("my_glue_db")
      .withTableName("my_glue_table")
      .withIOType(org.apache.beam.sdk.io.FileIO.class)
      .withIOConfig(... configs for FileIO / JdbcIO / ... )
      .withSchemaUpdateStrategy(ADD_NEW_COLUMNS | DISABLED)

Other existing implementations

For AWS S3-backed tables Spark on AWS EMR supports writing to a Glue table in a similar way it does for Hive Metastore tables:

df.write.saveAsTable("glue_db.glue_table")

Trino supports Glue catalog too - https://trino.io/docs/current/connector/hive.html - in a similar fashion Spark does - using it as a replacement for metadata of tables which are stored in some filesystem.

AWS Glue job (which is AWS fork of Spark) supports other types of storages: Mongo, RDS, etc

Flink seems to have it as work-in-progress: https://github.com/apache/flink-connector-aws/pull/47

Notes on possible implementation
Beam has HCatalogIO implementation - https://beam.apache.org/documentation/io/built-in/hcatalog/ - but it does not seem to be a good place for GlueIO:

it is highly coupled with Hive dependencies
it can not run on Java 11: https://github.com/apache/beam/issues/21299
Potentially GlueIO can support more storage types besides file systems - adding such into GlueIO can be easier
HCatalogIO currently doesn't have any machinery for AWS auth, coders, etc

Issue Priority
Priority: 2 (default / most feature requests should be filed as P2)
Issue Components

[ ] Component: Python SDK
[X] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[X] Component: IO connector
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

@psolomin Do you have specific use cases in mind?
Reading tables from the Glue meta store sounds like a useful integration! I'm not to sure about writing though, it feels a bit like that would conflict with the purpose of Glue preparing that data itself ... not sure though, I haven't used Glue much.
On the practical side, I'd expect more and more S3 backed tables catalogued in Glue to migrate to Iceberg / Hudi rather than using the fold Hive format. Beam not having support for these newer table formats might limit the value of such an IO.
I've been thinking about working on an IcebergIO for Beam, but unfortunately won't have time for it in the near future.

@mosche

Do you have specific use cases in mind?

Yeah, let me name some:

read from a Glue table backed by files in AWS S3 - FileIO will actually read files Glue catalog points to
read from a Glue table backed by AWS RDS (SQL) table - JdbcIO will actually read a table Glue catalog has

Writing is more tricky cause in that case Beam will need to edit Glue catalog objects

Glue preparing that data itself

"Glue" is actually multiple things: catalog (similar to Hive Metastore), Glue jobs (AWS proprietary version of serverless Spark), Glue crawlers, etc. For now this feature request is about Glue catalog only.

Iceberg

That one will be very useful, yes. Trino, Flink and Spark already have Iceberg support. Adding support for Iceberg will be more value added, I would say. And, as I remember, Iceberg can work without catalog or Hive metastore, and use table locations where both data & metadata is stored.

@psolomin fyi https://github.com/apache/beam/issues/20327

My Java / Maven is a bit rusty, but as far as I can tell, version 1.6.0 of org.apache.iceberg:iceberg-core has support for a catalog_type of Glue.  I'm probably being a bit too naive here: would a simple dependency bump give support?


tooltip don't work

tooltip don't work
v3.8.24
JSFiddle

I'm also having this issue.
<EMAIL_ADDRESS><EMAIL_ADDRESS>It's like flickering everytime I hover to any object.

Same problem.
Any update on this?
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Same issue
<EMAIL_ADDRESS><EMAIL_ADDRESS>

So I copied the source code of vsTooltip.vue into a new component, linted it and replaced all warnings and errors like using == instead of === and it just... works?
Maybe its due to webpack having trouble transpiling == ?

We change the component with the suggestions and some details should work as expected, please notify if there is any problem

@luisDanielRoviraContreras
<EMAIL_ADDRESS><EMAIL_ADDRESS>the tooltip still flicks every time when I hover to any object.

Still not working.

it works for me, please can do an example or a gif to see the problem better

You can check here
https://jsfiddle.net/jsinh0001/cqavtm13/

Hello,
same issue here, tooltip is flashing half a second, and disapear.

Still not working on 3.8.61...

Same Issue for,
Still waiting for a fix

On the component vsTooltip.vue, if you remove the updated() hook it works
updated () {
   let nodes = this.$refs.convstooltip.childNodes.length
   if (nodes === 1) {
     // this.activeTooltip = false  //Comment this line
   }
},

And it works, that's how i fixed it anyway

Hello,
I'm currently using vuesax on our project. I'm trying to implement vuesax components, and I have a question
Why you dont export the components for using? Because this is not a good solution to change on node_modules/vuesax. Anyone have more solution to this?
Many thanks

On the component vsTooltip.vue, if you remove the updated() hook it works
updated () {
   let nodes = this.$refs.convstooltip.childNodes.length
   if (nodes === 1) {
     // this.activeTooltip = false  //Comment this line
   }
},

And it works, that's how i fixed it anyway

I tried your suggestions, it worked. Thanks!

I have also discovered that tooltip only works if it contains two child nodes.
Following Snippet works:
<vs-tooltip>
    <vs-button>Buttom</vs-button>

</vs-tooltip>

The DOM does update with only one child node, but it looks like it's set to display: none; until you add a second node.
Tested in 3.11.13

Could we just remove this updated hook?... It serves no purpose except to annoy us..
In the meantime just wrap components within html nodes
<vs-tooltip>
    <vs-button>Buttom</vs-button>
</vs-tooltip>


Two restarts required to install Insiders update

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.64.0-insider
OS Version: Windows 11

Steps to Reproduce:

Click 'Restart to Update' in VS Code Insiders
VS Code Insiders closes and reopens
:bug: click on Help menu, see that VS Code is still 'Downloading update' and 'Installing update'. Then I get to 'Restart to update' again

(@joaomoreno the working areas document says you own install/update--please accept my apologies if I got the assignment wrong)

This happens if a second update becomes available after you already have a notification for a first update. It's a known long standing issue that we decide to to address due to its challenges. Whent he notification shows up for your first update, it is already partially applied, so giving it up is really not an option. So, we force you to update to that. Then, you'll get the notification for the second one. 😢


Typo in readme

This is useful for auomating acceptance testing for devices that can only be accessed physically.

Fixed in #6


Fixed iff typo from all over the project

Also did a search and replace on "True if" to "<c>True</c> if"
Have fun reviewing :P

Thanks for creating the pull request.
iff is not a typo, it is a short for "if and only if"
At this point we only accept bug fixes.
Alan


x/website: Incorrect step to modify PATH environment variable

What is the URL of the page with the issue?
https://go.dev/doc/install
What is your user agent?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Screenshot

What did you do?
I copied this command and ran it on a Scaleway instance
What did you expect to see?
I expected all my Go binaries to be accessible via my PATH
What did you see instead?
Instead the Go binaries I installed were not accessible via my PATH. The go binaries that I installed were saved to /root/go/bin so I had to modify my path via:
export PATH=$PATH:/root/go/bin

to access those binaries. Can this step be modified to account for cases where the Go bin directory is not at /usr/local/go/bin

Related Issues and Documentation

x/website: documentation no longer suggests to add $GOPATH/bin to the user's PATH #54510 (closed)
x/website: The Go installation docs should mention the option to add $GOBIN to $PATH #66043 (closed)
Go installer and/or https://go.dev/doc/install instructions fail to add `$HOME/go/bin` to PATH #64977 (closed)
x/website: #45967 (closed)
doc: installation instruction do not tell people to add $HOME/go/bin to their $PATH #19613 (closed)
doc/install: mention how to update environment variables before testing the installation #24756 (closed)
doc: Install from source doc at golang.org/doc inconsistent with install output #21534 (closed)
cmd/go: go install should warn when installing outside PATH #35912
x/build/cmd/release: macOS installer doesn't add /usr/local/go/bin to PATH when installing Go 1.14 #44723 (closed)
installed go for first time $GOHOME not defined, go not in path #34132 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

The Go install paths might differ because of different Linux distributions and user configurations. The doc just shows an example.

The installation is only about the go toolchain itself, any binaries you install may be in a different location, see #42823


Beta u16 Calculator and UXEnhancer

I am trying out your beta calculator from the link you provided in the issues section of that repo. Server.exe doesn't recognize the calculator. Is there a beta UX to go with the calculator? If not, I am in no rush to dive into Artistas or new lifestyles so the 20 Sept calculator is fine.

Connection to the server is intentionally turned off and needs some testing and updating.
I plan to release an update for calculator and UXEnhancer within the next week.

Thanks! I am not a big fan of the lifestyles so the people can wait. (Forever lol)
Maybe not the place to ask but is there a Patreon or Ko-fi?


How to handle updates and other message types

When ADT is flowing inbound how do you match encounters. Example: A01 is sent that creates an encounter record in FHIR. An A03 is sent for the patient discharge. Does Azure  know to update the correct encounter ID  or does it create a new encounter ID record? If I were to search via FHIR for that patients encounters, would I see one response or two?
So far I created a another template for A03’s, but I see two encounters after sending the A03. How would this work for updates and other transaction types. I am assuming we would have to query the “lastupdated” value in resource to filter?
Thank you,
Brandon

When generating FHIR resources, each FHIR resource has its own ID generation template. For example, this is an ID generation template for Encounter, where the converter tries to fetch PV1.19.1 and PV1.19.4 as the input to compute the ID for Encounter. If these two components are not available, the converter uses the whole PV1.19. So no matter where the Encounter is generated (ADT A01 or A03), if they have the same PV1.19.1 and PV1.19.4, or the same PV1.19, they will have the same ID. Otherwise different IDs are generated. If current ID generation logic does not meet your scenario, you can update the ID generation template or create your own ones.

Thank you,
Is that only for the lucid template. looks like I am still using the handlebars version. Do you recommend moving to lucid setup

Yes, that logic is available only in Liquid templates. We recommend moving to Liquid if you want to use that feature.

Ahh that makes sense. Ok i will start moving that change. Can I simply point my current injestHL7 to the ACR for liquid templates. Or do i have to rebuild the injest platform to re configure?
Thank you,
Brandon

You will need to reconfigure your pipeline. The Liquid engine can be used either as a command line tool, or the $convert-data operation in the FHIR server. See the documentation: Azure API for FHIR: https://docs.microsoft.com/en-us/azure/healthcare-apis/convert-data FHIR Server for Azure: https://github.com/microsoft/fhir-server/blob/main/docs/ConvertDataOperation.md

Ok I ran the deployment script but it doesn't ask anywhere about connecting my current ingest to the liquid template. How do I connect my mllp to https connector to route correctly to the liquid converter, instead of the handlebars app? I think those instructions are missing somewhere. When I call $convert-data it only converts it, its not adding the bundle to the server.


Question: Why do you replace the line breaks with a space?

I saw in the code that you are replacing the line breaks with spaces, but what is the reason, can you explain with an example?

Hi, it's a workaround because the compose text field has a lot of issues with rich text.
Replacing line breaks with spaces is fixing two issues (One fixed by removing line breaks and one fixed by adding spaces).

If I'm going to work with ParagraphStyle and I added two paragraphs for example, compose will add line break by default between paragraphs, so if I have line break on the string as well, we will have two line breaks, but we should only have one. That's why I'm removing the line breaks. Demo text \n second paragraph => <ParagraphStyle>Demo text</ParagraphStyle> <ParagraphStyle>second paragraph</ParagraphStyle>
For adding spaces after the end of each paragraph. It's a workaround to fix a bug in Compose selection when we have multiple paragraphs. If I don't add spaces the last letter of each paragraph is not going to be selectable.

I hope it's clear.

I hope that with the new BasicTextField2 things will become easier.
I will close this issue, feel free to reopen it if you still have more questions.


proposal: deprecate Expr::Wildcard

Is your feature request related to a problem or challenge?
Expr::Wildcard and Expr::QualifiedWildcard are expressions that reference all columns. But it seems redundant that we don't need a special expr type to do that. This issue proposes to remove these two expr kinds.
Describe the solution you'd like
Wildcard (*) can be expanded to concrete column lists when it appears. This manner seems viable in the three most common use cases I can come up with:

(1) generate plan from SQL AST. Some scenarios already acted like this. E.g., select * from table will generate a projection with all fields, rather than a wildcard expr.
(2) from LogicalPlanBuilder and (3) from DataFrame. In some aspects, these two entrances are the same. And both are strong typed (or strong schema-ed), which allows us to expand the wildcard immediately using the schema from current stage.

Besides this, Expr::Wildcard is not properly handled in the codebase, because it's not a "first class" expr. Take some functions as examples:

expr_to_columns: from the correctness aspect, it should also count columns referenced by Expr::Wildcard and Expr::QualifiedWildcard.
create_physical_name: this function requires all the wildcards to be expanded before calling it.

And I find another issue that related to Wildcard: https://github.com/apache/arrow-datafusion/issues/5473. The solution is to add an optimizer rule that expands all wildcards. This proposal is going to do something similar but in a more eager way.
Describe alternatives you've considered
No response
Additional context
Since Expr is widely used, we may need several versions to deprecate it (depending on the compatibility rule). We may ship this change step by step before fully removing these two variants

change all the internal usage of wildcards (most of them are in aggr expr I suppose)
change the public interface that may generate wildcard. Like https://github.com/apache/arrow-datafusion/issues/5473
mark Expr::Wildcard and Expr::QualifiedWildcard as #[deprecated]
fully remove them

@waynexia  -- I agree with your points about Expr::Wildcard being confusing. I didn't quite understand your proposal to change the public interface that may generate wildcard, specifically how someone would express "select all the columns" when building expressions programmatically 🤔
Concretely, what would be the equivalent to the following?
ctx.table("alltypes_plain")
        .await?
        .select(vec![count(Expr::Wildcard)])

BTW we

Concretely, what would be the equivalent to the following?

That's the point 👍 For select * from table we can simply omit the projection. But this doesn't work for count(*). I was thinking about letting "nothing" to represent the wildcard, similar to pandas or substrait. But this is a little bad as we have to use Option<Expr> instead of overload count(). An alternative is to add a specific count() variant for count(*), like count_all(). But whatever this API looks like, we must change the outer usage because the schema is unavailable for an independent count() method. Wildcard helps to postpone the expanding, and we have to do it immediately if it's removed.
The lucky thing is Expr::Wildcard is not that generic. So we only handle a few cases about it (or maybe the count(*) is the only case? I have this feeling but I am not sure about it).

BTW maybe we could improve the situation by adding more documentation to the Expr::Wildcard

Makes sense, I'll add it first.


Remove warning message for mixing return and yield in DoFn

The issue this warning message points to (https://github.com/apache/beam/issues/22969) has been resolved showing it was an issue with Python 2 and not with beam. I propose to remove this warning message to reduce log spam.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

This still causes the issues if you use Python 3. Not sure what you mean here.
This is why we have this  https://beam.apache.org/documentation/programming-guide/#pardo:

Ah I think I misunderstood the resolution of the bug thread. Apologies. I'll close the PR.


Android Build Failed

FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring project ':webview_cookie_manager'.

Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
Namespace not specified. Specify a namespace in the module's build file: C:\Users\Name\AppData\Local\Pub\Cache\hosted\pub.dev\webview_cookie_manager-2.0.6\android\build.gradle. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

 If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.

Having the same problem

same

same

What went wrong:
A problem occurred configuring project ':webview_cookie_manager'.

Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

 If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.

What went wrong:
A problem occurred configuring project ':webview_cookie_manager'.

Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

Is there a solution?


New Key in Table 480 Dimension Set Entry

Hi,
we need to have a new key in table 480 Dimension Set Entry.
The key should be:
Dimension Code,Dimension Value Code,Dimension Set ID
The key should be used in Codeunit 408 Dimension Management in function GetDimSetIDsForFilter.
Without this key we experience performance issues.

Thanks in advance

This issue appears to have been resolved!


Add support for negative delay

Hi,
I've been playing with this extension for a while, but it seems that it's not possible to use it for negative audio delay. Which is, at least for me, the only reason I'd need an extension like this - to fix the audio delay added by streaming audio to wireless speakers.
E.g. this extension seems to work fine for me, but for YouTube only. I was looking for something more general to use with any video. https://chrome.google.com/webstore/detail/youtube-audiovideo-sync/mknmhikmjljhpccebpnplhicmcfjkgbk
Positive audio delay seems to work fine. Would it be difficult to amend this extension, so that you can set both positive and negative audio delay?
Thanks!
BR,
Jiri

This was originally inspired by that project and targeted YouTube to get approval easier.
It might be possible to add a video delay, (which would come across as negative delay) will look into it

Unforunately no, the way that the original extension did it was to maintain a very janky connection between the video and audio by detaching them, the goal of this extension was to do it natively without that jank connection.
rendering the video via proxy with delay causes ungodly amounts of frame flashes that are just jarring

Sure, I thought it won't be that easy. Thank you!


Write more useful types in .types test outputs

#42149 and #42284 improved what we display to users when presenting complex type aliases, but this had the downside of making hundreds of .types test outputs mostly useless, as numerous test outputs would now report T : T for the type of a type alias, when we were actually using those results to validate the expected type.
This changes the type writer we use to generate .types tests to compare the stringified type to the name of the type alias and, if they match, to re-stringify the type without using its name (by passing TypeFormatFlags.InTypeAlias to typeToString).
This change makes over a thousand individual tests across over 427 .tests files useful again.

With this change in place, how are PRs like the above ones tested/verified to still be working in the future? The two linked PRs are all code changes + .types files, where people noted the improvement, but there doesn't seem to be a file that is sorta-kinda "what the user sees".

The type we use for what the user sees can be verified when it's used in other places. The user never sees SomeType when hovering over type SomeType = ... in the editor, because we also ignore the type alias when generate the quick info.
We also could leverage fourslash tests for things like verifying quickinfo as well. Traditionally, the .types tests are for us to verify the correct types are being produced, not for reporting what the user sees in the editor.


Add a clear option to [POTIONTICK], just like [POTIONSELF] does

Feature Request
Is Your Feature Request Related to a Problem? Please Describe.
The power potiontick has a clear option, which allows for potioneffects to be removed instead of applied. Having the same option for power potionself would allow for the creation of items, that heal you of some potioneffects. (Same thing was possible before by having the duration 1 tick or so, but that would simplify it.)
Describe the Solution You'd Like
Add the option clear to the power potionself with the options true or false

done


Shift + Split Editor Button split down rather than to the right

Solves #926

@MinusGix Hey! Hope you're doing great!
I was able to implement part of the expected functionality. Currently the split icon changes when shift is pressed and the split command is handled appropriately. However, I haven't been able to effectively capture the updated value of is_shift_down from EditorTabHeader.
I added the key_up function to  KeyPressData and event handlers for Event::KeyUp (I call key_up in such handlers), but the value of is_shift_down never updates to false, despite the fact the key_up is called.
Something interesting tho', is the fact that EditorTabHeader effectively gets the value of is_shift_down when key_down is called. I think I'm missing something, but I don't really know what that may be. Any clue will help me a lot (I'm almost done implementing the feature :'v)


How to sync project to automatically create the Python folder?

The README instructions says

After that sync your project.
Now, in your android folder, you'll have additional python folder created.

How do you "sync your project"? Where should this python directory be located?
Attempt 1
I opened up the android directory in Android Studio, then in Android Studio I clicked on File > Sync Project with Gradle Files. However, no python directory was created inside the android directory.
Attempt 2
From vscode, I build and ran my Flutter app by running Run > Start Debugging. I can see debug messages about Chaquopy installing pip packages (I have configured this in build.gradle) but still no python directory created anywhere.
I did recall seeing a python directory sometime before I got Chaquopy properly setup, (before attempts 1 and 2 above) and had deleted it. Perhaps there is a cache somewhere that says that this python directory has been created before, and there is no need to create it again?
Hope someone can help me, thank you.

The README instructions says

After that sync your project.
Now, in your android folder, you'll have additional python folder created.

How do you "sync your project"? Where should this python directory be located?
Attempt 1
I opened up the android directory in Android Studio, then in Android Studio I clicked on File > Sync Project with Gradle Files. However, no python directory was created inside the android directory.
Attempt 2
From vscode, I build and ran my Flutter app by running Run > Start Debugging. I can see debug messages about Chaquopy installing pip packages (I have configured this in build.gradle) but still no python directory created anywhere.
I did recall seeing a python directory sometime before I got Chaquopy properly setup, (before attempts 1 and 2 above) and had deleted it. Perhaps there is a cache somewhere that says that this python directory has been created before, and there is no need to create it again?
Hope someone can help me, thank you.

Were you able to Sync Project with Gradle Files successfully? Cuz when I tried to do that, I got an error
`sh
Build file 'D:\flutter_chaquopy\android\app\build.gradle' line: 5
An exception occurred applying plugin request [id: 'com.chaquo.python']

Failed to apply plugin 'com.chaquo.python'.
Failed to find plugin com.android.tools.build:gradle

Try:

Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Exception is:
org.gradle.api.plugins.InvalidPluginException: An exception occurred applying plugin request [id: 'com.chaquo.python']
`

I thought it might be due to my version, but I double checked the versions
7.5 for gradle and 15.0.1 for chaquopy. And according to the official website, they seem compatible.

please use the latest version, and update here. Closing the issue for now.


Bugfix: add compara patch required for wheat cultivars

Description
Compara has included wheat cultivars protein trees in e106 and this has flagged a requirement to increase the column of one of our tables.
Use case
To avoid clashes with the default protein trees, we prefix the name of these with wheat_cultivars_. As it usually happens, the largest value was 31 characters long (lucky us!). We have increased it to 50 just in case we have larger prefixes in the future, but this should be long enough to "never" have this issue again :crossed_fingers:
Benefits
We can now produce new varieties gene trees without concerns on this matter.
Possible Drawbacks
None.
Testing
This patch has been successfully applied to all Compara production pipelines and databases in e106 without raising any incompatibilities or issues.

Coverage increased (+0.03%) to 82.352% when pulling 860acd12bcc052c902adc9a98ac7c23907c75e9d on JAlvarezJarreta:release/106 into 6b62d08399444a59df7f77fe00bc8a91afc7ccf2 on Ensembl:release/106.

@sgiorgetti, I might be wrong but I run the updates with the ensembl-test script and I think it is enough for the patch to be in ensembl-compara repository, release/106 branch (which it is). Let me know if not where would you want it (we had some patches in previous releases and these are not in this repository either).

@JAlvarezJarreta sorry ... getting older and multi-tasking is getting more and more problematic.
The patch file "patch_105_106_b.sql" is missing in the master branch of ensembl-compara repository. And the problem there is similar to the one for ensembl repo: both master branches have already bumped up for 107.

I don't think it is an age-related issue, but if it is, I'm getting older too :sweat_smile: But you are right, forgot about that important step, sorry! It should be all good know :+1:


-config parameter is ignored

Describe the bug
valetudopng just ignores Specified -config parameter and tries to use config.yml in the current directory.
To Reproduce

Go to /mnt/data/valetudopng/
Try to run ./valetudopng -config not_exist
See how valetudopng starts using config file "config.yml" and not trying to use config file "not_exist" (which does not exist and should produce error)

Expected behavior
valetudopng should use -config parameter if it is specified.
Screenshots/Outputs
[root@rockrobo ~]# /mnt/data/valetudopng/valetudopng -config not_exist
2023/10/10 15:38:38 Failed to read configuration file: open config.yml: no such file or directory

[root@rockrobo ~]# cd /mnt/data/valetudopng
[root@rockrobo valetudopng]# ls
config.example.yml                     valetudopng
config.yml                             valetudopng_v1.0.8_linux_armv7.tar.gz
[root@rockrobo valetudopng]# /mnt/data/valetudopng/valetudopng -config not_exist
2023/10/10 15:38:44 [MQTT consumer] Connected
2023/10/10 15:38:44 [MQTT producer] Connected
2023/10/10 15:38:44 [MQTT consumer] Subscribed to map data topic

@erkexzcx Yes, I'm trying to host valetudopng on the robot itself because I don't have persistent server with supported CPU, I have a tiny aarch64 server running Manjaro and Home Assistant - could you please release binary for aarch64 too?

@erkexzcx  - just to keep issues clean - is valetudopng compatible with valetudo-re 10.0.7 or valetido-re 10.0.10?


[LD-1335] Rectify the Revenue numbers on Apollo API Docs

Description:
Reference Jira: https://apollopde.atlassian.net/browse/LD-1335
Reference Slack thread: https://apolloio.slack.com/archives/C018JE2DPFF/p1713891812240259?thread_ts=1711769506.332969&cid=C018JE2DPFF
Changes:

Changed hardcoded value for annual revenue to ###.#

Before:
"annual_revenue_printed": "345.6M",
"annual_revenue": 345600000.0,
After:
"annual_revenue_printed": "###.#",
"annual_revenue": ###.#,
Make sure you've checked off all these things before submitting:

[ ] This pull request isn't for a company's fork, it's intended for the upstream Slate shared by everybody.
[x] This pull request is submitted to the master branch.
[ ] If it makes frontend changes, this pull request has been tested in the latest version of Firefox, Chrome, IE, and Safari.
[ ] If it is an API related fix, the shell and python code have been tested


[Graph][Benchmark] Update benchmark function

The old benchmarking function did not clear the l2 cache, so repeated runs are biased.
This is especially prevalent in tuning for parallel-k parts, which always selects k_parts=1 due to l2 cache hits, even when it is not the fastest implementation.

Hi Allan,
The PR looks good to me. But before merging, it is better to have some demos on the improvement of the accuracy on the selection of parallel k when we clear the L2 cache.

After some further investigation, it appears that the clearing of the l2 cache is not the greatest contributor, but the usage of torch.cuda.Event, which I assume to be more accurate than time.time().
Here is my benchmarking script for reference: https://gist.github.com/Aalanli/b81d1a751a78ea72b491d872aa993f9e

I just removed the torch dependencies.


local variable 'new_results' referenced before assignment (cache manager issue)

Hello there,
I got this error
Traceback (most recent call last):
  File "/home/smalldog/FlashRAG/examples/methods/run_exp.py", line 473, in <module>
    func(args)
  File "/home/smalldog/FlashRAG/examples/methods/run_exp.py", line 20, in naive
    result = pipeline.run(test_data)
  File "/home/smalldog/FlashRAG/flashrag/pipeline/pipeline.py", line 83, in run
    retrieval_results = self.retriever.batch_search(input_query)
  File "/home/smalldog/FlashRAG/flashrag/retriever/retriever.py", line 70, in wrapper
    for query, doc_items, doc_scores in zip(query_list, new_results, new_scores):
UnboundLocalError: local variable 'new_results' referenced before assignment

when running command
python run_exp.py --method_name 'naive' \
                  --split 'test' \
                  --dataset_name 'nq' \
                  --gpu_id '0,1,2,3'

In the config, I am using hf, I think fschat has same error, haven't tested on vllm yet.
framework: hf # inference frame work of LLM, supporting: 'hf','vllm','fschat'

i think when query_list is already a list (normally), the code will not go inside the if statement if isinstance(query_list, str): to create the var new_results.

Sorry, this is a minor bug we introduced when modifying the cache process recently, and we have fixed it. See commit 82770111d0969100b654546bb18626c1a2fdf520.


HBASE-26702 Make ageOfLastShip, ageOfLastApplied extend TimeHistogram instead of plain histogram.

Cc @Apache9

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

-0 :warning:
yetus
0m  8s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m  4s
branch-2 passed

+1 :green_heart:
compile
0m 18s
branch-2 passed

+1 :green_heart:
shadedjars
7m  5s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 19s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 53s
the patch passed

+1 :green_heart:
compile
0m 19s
the patch passed

+1 :green_heart:
javac
0m 19s
the patch passed

+1 :green_heart:
shadedjars
6m 47s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 18s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 29s
hbase-hadoop2-compat in the patch passed.

25m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4098/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4098

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux fbb179d5b428 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / f637a60bdd

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4098/1/testReport/

Max. process+thread count
342 (vs. ulimit of 12500)

modules
C: hbase-hadoop2-compat U: hbase-hadoop2-compat

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4098/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 24s
branch-2 passed

+1 :green_heart:
compile
0m 29s
branch-2 passed

+1 :green_heart:
checkstyle
0m 16s
branch-2 passed

+1 :green_heart:
spotbugs
0m 35s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 48s
the patch passed

+1 :green_heart:
compile
0m 30s
the patch passed

+1 :green_heart:
javac
0m 30s
the patch passed

+1 :green_heart:
checkstyle
0m 12s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 20s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
0m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

33m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4098/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4098

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux b323db565e6d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / f637a60bdd

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
95 (vs. ulimit of 12500)

modules
C: hbase-hadoop2-compat U: hbase-hadoop2-compat

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4098/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
12m 28s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
5m 27s
branch-2 passed

+1 :green_heart:
compile
0m 20s
branch-2 passed

+1 :green_heart:
shadedjars
8m 21s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 22s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  5s
the patch passed

+1 :green_heart:
compile
0m 20s
the patch passed

+1 :green_heart:
javac
0m 20s
the patch passed

+1 :green_heart:
shadedjars
8m  4s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 35s
hbase-hadoop2-compat in the patch passed.

42m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4098/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4098

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7934c045b8ba 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / f637a60bdd

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4098/1/testReport/

Max. process+thread count
201 (vs. ulimit of 12500)

modules
C: hbase-hadoop2-compat U: hbase-hadoop2-compat

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4098/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Remove _ prefix from record accessor names under shelley/impl.

Post the move away from using lenses, some of the record accessor names remained prefixed with _.

[ ] Replace _ prefixed names with better names
[ ] Add DEPRECATED standalone functions for those that are being used downstream to avoid any breakage

This is related to #2927 and its corresponding PR #3045 with some code overlap.
List of data types that would need to be addressed with removal of _ prefix in record accessors.

Cardano.Ledger.Shelley.Delegation.Certificates.Delegation
Cardano.Ledger.Shelley.EpochBoundary.SnapShot
Cardano.Ledger.Shelley.EpochBoundary.SnapShots
Cardano.Ledger.Shelley.LedgerState.DPState.DState
Cardano.Ledger.Shelley.LedgerState.DPState.PState
Cardano.Ledger.Shelley.LedgerState.Types.AccountState
Cardano.Ledger.Shelley.LedgerState.Types.UTxOState
Cardano.Ledger.Shelley.PParams.ShelleyPParamsHKD
Cardano.Ledger.Shelley.PoolParams.PoolMetadata
Cardano.Ledger.Shelley.PoolParams.PoolParams
Cardano.Ledger.Shelley.Tx.TxRaw
Cardano.Ledger.Shelley.TxBody.TxBodyRaw
Cardano.Ledger.Shelley.TxBody.(pattern ShelleyTxBody)

Starting with just UTxOState (across downstream repositories too)

DState and PState next.

Closing this, as all the points here now appear to have been addressed.


minor: Enable fzf sort

Improves search result order of the (fuzzy) matches.
Example
Before (with --no-sort):

After:

Thanks! I actually already did this but forgot to push to merge it and release it. Haha


test_forward_compatibility@compatibility is flaky

A recent failure in main: https://github.com/neondatabase/neon/actions/runs/3563254362/jobs/5986129088
main seems failing:passing about 50:50 at the moment, each failure is unique in its flakiness.

__________________________ test_forward_compatibility __________________________
[gw0] linux -- Python 3.9.2 /github/home/.cache/pypoetry/virtualenvs/neon-_pxWMzVK-py3.9/bin/python
subprocess.CalledProcessError: Command '['/tmp/neon-previous/bin/neon_local', 'pg', 'start', '--tenant-id', '325bbf12962a84e96cf57bcde7b95c22', '--pg-version', '14', '--port=15068', 'main']' returned non-zero exit status 1.

The above exception was the direct cause of the following exception:
test_runner/regress/test_compatibility.py:170: in test_forward_compatibility
    check_neon_works(
test_runner/regress/test_compatibility.py:311: in check_neon_works
    cli.pg_start("main", port=pg_port)
test_runner/fixtures/neon_fixtures.py:1661: in pg_start
    res = self.raw_cli(args)
test_runner/fixtures/neon_fixtures.py:1356: in raw_cli
    raise Exception(msg) from subprocess.CalledProcessError(
E   Exception:             Run ['/tmp/neon-previous/bin/neon_local', 'pg', 'start', '--tenant-id', '325bbf12962a84e96cf57bcde7b95c22', '--pg-version', '14', '--port=15068', 'main'] failed:
E                 stdout: Starting new postgres (v14) main on timeline 88760b3450f4dfb8bdca11cafed67536 ...
E   Extracting base backup to create postgres instance: path=/tmp/test_output/test_forward_compatibility/compatibility_snapshot/repo/pgdatadirs/tenants/325bbf12962a84e96cf57bcde7b95c22/main port=15068
E   Starting postgres node at 'host=<IP_ADDRESS> port=15068 user=cloud_admin dbname=postgres'
E
E                 stderr: command failed: pg_ctl failed, exit code: exit status: 1, stdout: waiting for server to start.... stopped waiting
E   , stderr: pg_ctl: could not start server
E   Examine the log output.
E
E
E   Stack backtrace:
E      0: control_plane::compute::PostgresNode::pg_ctl
E                at ./control_plane/src/compute.rs:453:13
E      1: control_plane::compute::PostgresNode::start
E                at ./control_plane/src/compute.rs:493:9
E      2: neon_local::handle_pg
E                at ./control_plane/src/bin/neon_local.rs:675:17
E      3: neon_local::main
E                at ./control_plane/src/bin/neon_local.rs:109:21
E      4: core::ops::function::FnOnce::call_once
E                at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/core/src/ops/function.rs:248:5
E         std::sys_common::backtrace::__rust_begin_short_backtrace
E                at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/sys_common/backtrace.rs:122:18
E      5: std::rt::lang_start::{{closure}}
E                at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/rt.rs:145:18
E      6: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
E                at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/core/src/ops/function.rs:280:13
E         std::panicking::try::do_call
E                at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/panicking.rs:492:40
E         std::panicking::try
E                at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/panicking.rs:456:19
E         std::panic::catch_unwind
E                at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/panic.rs:137:14
E         std::rt::lang_start_internal::{{closure}}
E                at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/rt.rs:128:48
E         std::panicking::try::do_call
E                at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/panicking.rs:492:40
E         std::panicking::try
E                at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/panicking.rs:456:19
E         std::panic::catch_unwind
E                at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/panic.rs:137:14
E         std::rt::lang_start_internal
E                at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/rt.rs:128:20
E      7: main
E      8: __libc_start_main
E      9: _start
------------------------------ Captured log setup ------------------------------
2022-11-28 09:26:30.699 INFO [neon_fixtures.py:2706] get_test_output_dir is /tmp/test_output/test_forward_compatibility
2022-11-28 09:26:30.699 INFO [neon_fixtures.py:2727] test_output_dir is /tmp/test_output/test_forward_compatibility
------------------------------ Captured log call -------------------------------
2022-11-28 09:26:30.700 INFO [test_compatibility.py:203] Copying snapshot from /tmp/test_output/test_create_snapshot/compatibility_snapshot_pg14 to /tmp/test_output/test_forward_compatibility/compatibility_snapshot
2022-11-28 09:26:31.461 INFO [neon_fixtures.py:1319] Running command "/tmp/neon-previous/bin/neon_local start"
2022-11-28 09:26:31.462 INFO [neon_fixtures.py:1320] Running in "/tmp/test_output/test_forward_compatibility/compatibility_snapshot/repo"
2022-11-28 09:26:32.185 INFO [neon_fixtures.py:1347] Run success: Starting etcd broker using "/usr/local/bin/etcd"
etcd started, pid: 14666
Starting pageserver at 'localhost:15060' in '/tmp/test_output/test_forward_compatibility/compatibility_snapshot/repo'.
pageserver started, pid: 14686
Starting safekeeper at '<IP_ADDRESS>:15063' in '/tmp/test_output/test_forward_compatibility/compatibility_snapshot/repo/safekeepers/sk1'.
safekeeper 1 started, pid: 14726
Starting safekeeper at '<IP_ADDRESS>:15065' in '/tmp/test_output/test_forward_compatibility/compatibility_snapshot/repo/safekeepers/sk2'.
safekeeper 2 started, pid: 14745
Starting safekeeper at '<IP_ADDRESS>:15067' in '/tmp/test_output/test_forward_compatibility/compatibility_snapshot/repo/safekeepers/sk3'.
safekeeper 3 started, pid: 14769

2022-11-28 09:26:32.186 INFO [neon_fixtures.py:1319] Running command "/tmp/neon-previous/bin/neon_local pg start --tenant-id 325bbf12962a84e96cf57bcde7b95c22 --pg-version 14 --port=15068 main"
2022-11-28 09:26:32.186 INFO [neon_fixtures.py:1320] Running in "/tmp/test_output/test_forward_compatibility/compatibility_snapshot/repo"
2022-11-28 09:26:32.402 INFO [neon_fixtures.py:1355]             Run ['/tmp/neon-previous/bin/neon_local', 'pg', 'start', '--tenant-id', '325bbf12962a84e96cf57bcde7b95c22', '--pg-version', '14', '--port=15068', 'main'] failed:
              stdout: Starting new postgres (v14) main on timeline 88760b3450f4dfb8bdca11cafed67536 ...
Extracting base backup to create postgres instance: path=/tmp/test_output/test_forward_compatibility/compatibility_snapshot/repo/pgdatadirs/tenants/325bbf12962a84e96cf57bcde7b95c22/main port=15068
Starting postgres node at 'host=<IP_ADDRESS> port=15068 user=cloud_admin dbname=postgres'

              stderr: command failed: pg_ctl failed, exit code: exit status: 1, stdout: waiting for server to start.... stopped waiting
, stderr: pg_ctl: could not start server
Examine the log output.

Stack backtrace:
   0: control_plane::compute::PostgresNode::pg_ctl
             at ./control_plane/src/compute.rs:453:13
   1: control_plane::compute::PostgresNode::start
             at ./control_plane/src/compute.rs:493:9
   2: neon_local::handle_pg
             at ./control_plane/src/bin/neon_local.rs:675:17
   3: neon_local::main
             at ./control_plane/src/bin/neon_local.rs:109:21
   4: core::ops::function::FnOnce::call_once
             at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/core/src/ops/function.rs:248:5
      std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/sys_common/backtrace.rs:122:18
   5: std::rt::lang_start::{{closure}}
             at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/rt.rs:145:18
   6: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/core/src/ops/function.rs:280:13
      std::panicking::try::do_call
             at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/panicking.rs:492:40
      std::panicking::try
             at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/panicking.rs:456:19
      std::panic::catch_unwind
             at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/panic.rs:137:14
      std::rt::lang_start_internal::{{closure}}
             at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/rt.rs:128:48
      std::panicking::try::do_call
             at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/panicking.rs:492:40
      std::panicking::try
             at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/panicking.rs:456:19
      std::panic::catch_unwind
             at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/panic.rs:137:14
      std::rt::lang_start_internal
             at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/std/src/rt.rs:128:20
   7: main
   8: __libc_start_main
   9: _start
---------------------------- Captured log teardown -----------------------------
2022-11-28 09:26:32.602 INFO [neon_fixtures.py:1319] Running command "/tmp/neon-previous/bin/neon_local stop"
2022-11-28 09:26:32.603 INFO [neon_fixtures.py:1320] Running in "/tmp/test_output/test_forward_compatibility/compatibility_snapshot/repo"
2022-11-28 09:26:33.314 INFO [neon_fixtures.py:1347] Run success: Stopping pageserver with pid 14686 gracefully...
pageserver stopped
Stopping safekeeper 1 with pid 14726 gracefully...
safekeeper 1 stopped
Stopping safekeeper 2 with pid 14745 gracefully...
safekeeper 2 stopped
Stopping safekeeper 3 with pid 14769 gracefully...
safekeeper 3 stopped
Stopping etcd with pid 14666 immediately...
etcd stopped

Interesting.
2022-11-28 09:26:32.272 GMT [14881] LOG:  starting with zenith basebackup at LSN 0/AB18AF8, prev 0/0
2022-11-28 09:26:32.272 GMT [14881] FATAL:  cannot start in read-write mode from this base backup

error in pg.log can only mean (IMV) that basebackup was taken not from the tip of the timeline (prev_lsn is not maintained then). However, this shouldn't be the case, and basebackup request confirms it
2022-11-28T09:26:32.195122Z  INFO handle_basebackup_request{tenant_id=325bbf12962a84e96cf57bcde7b95c22 timeline_id=88760b3450f4dfb8bdca11cafed67536 lsn=None prev_lsn=None full_backup=false}: taking basebackup lsn=0/AB18AF8, prev_lsn=0/0 (full_backup=false)
2022-11-28T09:26:32.204912Z  INFO handle_basebackup_request{tenant_id=325bbf12962a84e96cf57bcde7b95c22 timeline_id=88760b3450f4dfb8bdca11cafed67536 lsn=None prev_lsn=None full_backup=false lsn="0/AB18AF8"}: timeline.pg_version 14
2022-11-28T09:26:32.224773Z  INFO handle_basebackup_request{tenant_id=325bbf12962a84e96cf57bcde7b95c22 timeline_id=88760b3450f4dfb8bdca11cafed67536 lsn=None prev_lsn=None full_backup=false lsn="0/AB18AF8"}: basebackup complete

So I don't understand. Let's see if it repeats.

@arssher This happened again, see: https://neon-github-public-dev.s3.amazonaws.com/reports/pr-3315/release/3903582277/index.html#suites/0fbaeb107ef328d03993d44a1fb15690/d7e5d24ebc8f1c75/
Review result: clearly unrelated to the PR #3315.
pg logs:
2023-01-12 15:34:55.341 GMT [13873] LOG:  starting with zenith basebackup at LSN 0/AA31D80, prev 0/0
2023-01-12 15:34:55.341 GMT [13873] FATAL:  cannot start in read-write mode from this base backup

Again with #3419: https://neon-github-public-dev.s3.amazonaws.com/reports/pr-3419/release/3994470974/index.html#suites/0fbaeb107ef328d03993d44a1fb15690/ad2c872528d2ee46/

And again in #3703 https://neon-github-public-dev.s3.amazonaws.com/reports/pr-3703/debug/4348163542/index.html#suites/0fbaeb107ef328d03993d44a1fb15690/35839f6f0e5d9c3c/

And again
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-3759/debug/4356441932/index.html#categories

I got it three times with https://github.com/neondatabase/neon/pull/3703 I guess it may have changed some timings to make failure more probable.
I quickly looked at the code and things looked sketchy -- seems that we get invalidlsn in basebackup in non-init mode, not sure is it okay now or not. @knizhnik do you remeber what is the last iteration with that prev-lsn?

AFAIR we don't maintain prev_lsn for non latest point. So this invalid prev_lsn is ok in case of backup from the past, but basebackup request at lsn=None (latest) should have valid prev_lsn, and test failure violates that.

Once more: https://neon-github-public-dev.s3.amazonaws.com/reports/pr-3790/debug/4384985320/index.html#suites/0fbaeb107ef328d03993d44a1fb15690/9b2e4975b3ace73d/ -- similar to what I've reported earlier.

Still reproduces on main:
2023-03-14 11:28:25.181 GMT [69087] LOG:  starting with zenith basebackup at LSN 0/AB409C8, prev 0/0
2023-03-14 11:28:25.182 GMT [69087] FATAL:  cannot start in read-write mode from this base backup

https://neon-github-public-dev.s3.amazonaws.com/reports/main/debug/4415125743/index.html#suites/0fbaeb107ef328d03993d44a1fb15690/fff19da993142560/

Once more: https://neon-github-public-dev.s3.amazonaws.com/reports/main/debug/4435279198/index.html#suites/0fbaeb107ef328d03993d44a1fb15690/ffe215e81a4c7b99/
2023-03-16 09:13:17.918 GMT [70801] LOG:  starting with zenith basebackup at LSN 0/AB30FC8, prev 0/0
2023-03-16 09:13:17.918 GMT [70801] FATAL:  cannot start in read-write mode from this base backup

Will not be reporting this anymore since we have already confirmed updating the binaries did not change the situation.

This failure looks different from the above:
2023-03-20 14:22:49.737 GMT [65445] LOG:  starting with zenith basebackup at LSN 0/AB898D0, prev 0/AB89890

https://neon-github-public-dev.s3.amazonaws.com/reports/pr-3837/debug/4469175202/index.html#suites/0fbaeb107ef328d03993d44a1fb15690/a70289fb8c99e914/

I'm suspicious on this comment:
https://github.com/neondatabase/neon/blob/main/pageserver/src/tenant/metadata.rs#L61
Does this mean if we restart pageserver with some data in memory not flushed, we lose prev_record_lsn? CC @SomeoneToIgnore

What I think happens here:

Flushing of frozen layer (flush_frozen_layer) doesn't prevent further data writes (which is good). So when it is completed and metadata file is updated (update_metadata_file), last_record_lsn could have gone farther, and so prev_record_lsn for the fresh disk_consistent_lsn is not available. In test_create_snapshot we timeline_checkpoint the pageserver and terminate the compute soon, so normally test passes, but small amount of WAL always has a chance to be generated in the middle -- xl_running_xacts, VACUUM, etc, in which case it fails.
So, after pageserver restart (in this test, when we start prepared snapshot) prev_record_lsn is invalid.
Now, generally it shouldn't be a problem, because if there is a range of WAL committed after checkpoint on pageserver,  pageserver will (re)consume it soon from safekeepers. Normally, compute on start runs sync-safekeepers to learn the real end of committed WAL and carries this LSN in the basebackup request, forcing waiting if needed. However, there is a bug in neon_local: ComputeControlPlane::new_node sets uses_wal_proposer=false which disables sync-safekeepers -- basebackup request has None lsn, so pageserver returns what it currently has. I'll fix that.


fix(wmg): Genes Selector parse comma with hints

Definition of Done (from ticket)
QA steps (optional)
Known Issues

#2389


For the real training dataset

How can you get the real training dataset？
Which dataset you use

RENOIR, same as the paper.


Pagination helpers

There are some pagination improvements I'd love to try out: https://github.com/apollographql/apollo-client/pull/6465

TypePolicies.t needs fleshed out
Bindings needed for pagination helpers

PR: #32

Should be available in the next release


Android network monitor properly notifies when back online

Coverage increased (+5.8%) to 73.202% when pulling eaf8f8de95bf0ca82b35a6218b070ed1e9831c8b on edaniels:net_fix into 25cb36ea284db27b0566fdb2e1d6220e2960dc6a on mongodb:master.

Coverage increased (+5.8%) to 73.202% when pulling eaf8f8de95bf0ca82b35a6218b070ed1e9831c8b on edaniels:net_fix into 25cb36ea284db27b0566fdb2e1d6220e2960dc6a on mongodb:master.


Add Datum based arithmetic kernels (#3999)

Which issue does this PR close?

Closes #527
Closes #3999
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

divide_dyn will now return NaN for division by zero
Decimal arithmetic is always checked and sets the precision and scale automatically
Temporal arithmetic is always checked

how well covered is this code

The existing tests of the dyn kernels which now call into this logic should give fairly good coverage, definitely could be improved though. Happy to do as a follow on

add_wrapping

This was an attempt to encourage the checked logic by default, I can change it back if you feel strongly

Filed tickets #4480 #4481


Better separation of floating windows with different border color

Would be possible to support the active floating window's shadow with different border color in all applications? It would help to separate the floating state in dark mode.
I tried with this signal without luck:
yabai -m signal --add app='^Finder$' event='window_title_changed' \
    action='yabai -m query --windows --window $YABAI_WINDOW_ID | jq "if .floating == 1" | xargs -I{} yabai -m config active_window_border_color 0xffD9742B'

Thank you.

Try to run the code in your signal outside of a signal and look at its output, that should help you spot the issue. Your jq script is invalid.

Closing this as borders are no longer a thing.


What are the coordinates of the points in the cube?

get_udf  calculates the udf values of the points uniformly distributed within the cube. But exactly what are the specific coordinates of these points?
I use Open3D to calculate the UDF values of points within the (0,1) cube, but the results are completely different from those of Cumesh2SDF.Maybe the range of the cube in Cumesh2SDF is not from 0 to 1?

I think I found the answer. If the cube resolution is R, then the coordinates of field points are distributed between 1/(2R) and 1-1/(2R)


pass arbitrary header to run-psgi-request

An application might requires an API-KEY in the header of the request. AFAIK currently the only thing we can pass to the header of a test-request is the 'http_cookie'. We should be able to pass arbitrary key-value pairs.
Maybe it could accept something like
header => {
   :key(value),
}

and then the http_cookie could be part of it.

isn't this done?