clinfo hangs, opencl apps hang

I have a RX 5600XT running on Ubuntu 20.04 - no screens attached. Installed ROCm from the repositories, version 3.10.0 as per documentation. Not sure what I am missing...
Running clinfo does not finish, it hangs forever:
Number of platforms                               1
  Platform Name                                   AMD Accelerated Parallel Processing
  Platform Vendor                                 Advanced Micro Devices, Inc.
  Platform Version                                OpenCL 2.0 AMD-APP (3212.0)
  Platform Profile                                FULL_PROFILE
  Platform Extensions                             cl_khr_icd cl_amd_event_callback
  Platform Extensions function suffix             AMD

  Platform Name                                   AMD Accelerated Parallel Processing
Number of devices                                 1
  Device Name                                     gfx1010
  Device Vendor                                   Advanced Micro Devices, Inc.
  Device Vendor ID                                0x1002
  Device Version                                  OpenCL 2.0
  Driver Version                                  3212.0 (HSA1.1,LC)
  Device OpenCL C Version                         OpenCL C 2.0
  Device Type                                     GPU
  Device Board Name (AMD)                         Navi 10 [Radeon RX 5600 OEM/5600 XT / 5700/5700 XT]
  Device Topology (AMD)                           PCI-E, 04:00.0
  Device Profile                                  FULL_PROFILE
  Device Available                                Yes
  Compiler Available                              Yes
  Linker Available                                Yes
  Max compute units                               18
  SIMD per compute unit (AMD)                     4
  SIMD width (AMD)                                32
  SIMD instruction width (AMD)                    1
  Max clock frequency                             1780MHz
  Graphics IP (AMD)                               10.1
  Device Partition                                (core)
    Max number of sub-devices                     18
    Supported partition types                     None
    Supported affinity domains                    (n/a)
  Max work item dimensions                        3
  Max work item sizes                             1024x1024x1024
  Max work group size                             256
  Preferred work group size (AMD)                 256
  Max work group size (AMD)                       1024

# Hangs forever here

Same as sample apps like the square app. Compiles, starts and then hangs forever:
info: running on device Navi 10 [Radeon RX 5600 OEM/5600 XT / 5700/5700 XT]
info: allocate host mem (  7.63 MB)
info: allocate device mem (  7.63 MB)
info: copy Host2Device

# Hangs forever here

rocminfo:
ROCk module is loaded
Able to open /dev/kfd read-write
=====================
HSA System Attributes
=====================
Runtime Version:         1.1
System Timestamp Freq.:  1000.000000MHz
Sig. Max Wait Duration:<PHONE_NUMBER>3709551615 (0xFFFFFFFFFFFFFFFF) (timestamp count)
Machine Model:           LARGE
System Endianness:       LITTLE

==========
HSA Agents
==========
*******
Agent 1
*******
  Name:                    Intel(R) Pentium(R) CPU G4560 @ 3.50GHz
  Uuid:                    CPU-XX
  Marketing Name:          Intel(R) Pentium(R) CPU G4560 @ 3.50GHz
  Vendor Name:             CPU
  Feature:                 None specified
  Profile:                 FULL_PROFILE
  Float Round Mode:        NEAR
  Max Queue Number:        0(0x0)
  Queue Min Size:          0(0x0)
  Queue Max Size:          0(0x0)
  Queue Type:              MULTI
  Node:                    0
  Device Type:             CPU
  Cache Info:
    L1:                      32768(0x8000) KB
  Chip ID:                 0(0x0)
  Cacheline Size:          64(0x40)
  Max Clock Freq. (MHz):   3500
  BDFID:                   0
  Internal Node ID:        0
  Compute Unit:            4
  SIMDs per CU:            0
  Shader Engines:          0
  Shader Arrs. per Eng.:   0
  WatchPts on Addr. Ranges:1
  Features:                None
  Pool Info:
    Pool 1
      Segment:                 GLOBAL; FLAGS: KERNARG, FINE GRAINED
      Size:                    7828540(0x77743c) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Alignment:         4KB
      Accessible by all:       TRUE
    Pool 2
      Segment:                 GLOBAL; FLAGS: COARSE GRAINED
      Size:                    7828540(0x77743c) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Alignment:         4KB
      Accessible by all:       TRUE
  ISA Info:
    N/A
*******
Agent 2
*******
  Name:                    gfx1010
  Uuid:                    GPU-XX
  Marketing Name:          Navi 10 [Radeon RX 5600 OEM/5600 XT / 5700/5700 XT]
  Vendor Name:             AMD
  Feature:                 KERNEL_DISPATCH
  Profile:                 BASE_PROFILE
  Float Round Mode:        NEAR
  Max Queue Number:        128(0x80)
  Queue Min Size:          4096(0x1000)
  Queue Max Size:          131072(0x20000)
  Queue Type:              MULTI
  Node:                    1
  Device Type:             GPU
  Cache Info:
    L1:                      16(0x10) KB
  Chip ID:                 29471(0x731f)
  Cacheline Size:          64(0x40)
  Max Clock Freq. (MHz):   1780
  BDFID:                   1024
  Internal Node ID:        1
  Compute Unit:            36
  SIMDs per CU:            4
  Shader Engines:          4
  Shader Arrs. per Eng.:   2
  WatchPts on Addr. Ranges:4
  Features:                KERNEL_DISPATCH
  Fast F16 Operation:      FALSE
  Wavefront Size:          32(0x20)
  Workgroup Max Size:      1024(0x400)
  Workgroup Max Size per Dimension:
    x                        1024(0x400)
    y                        1024(0x400)
    z                        1024(0x400)
  Max Waves Per CU:        80(0x50)
  Max Work-item Per CU:    2560(0xa00)
  Grid Max Size:<PHONE_NUMBER>(0xffffffff)
  Grid Max Size per Dimension:
    x<PHONE_NUMBER>(0xffffffff)
    y<PHONE_NUMBER>(0xffffffff)
    z<PHONE_NUMBER>(0xffffffff)
  Max fbarriers/Workgrp:   32
  Pool Info:
    Pool 1
      Segment:                 GLOBAL; FLAGS: COARSE GRAINED
      Size:                    6275072(0x5fc000) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Alignment:         4KB
      Accessible by all:       FALSE
    Pool 2
      Segment:                 GROUP
      Size:                    64(0x40) KB
      Allocatable:             FALSE
      Alloc Granule:           0KB
      Alloc Alignment:         0KB
      Accessible by all:       FALSE
  ISA Info:
    ISA 1
      Name:                    amdgcn-amd-amdhsa--gfx1010
      Machine Models:          HSA_MACHINE_MODEL_LARGE
      Profiles:                HSA_PROFILE_BASE
      Default Rounding Mode:   NEAR
      Default Rounding Mode:   NEAR
      Fast f16:                TRUE
      Workgroup Max Size:      1024(0x400)
      Workgroup Max Size per Dimension:
        x                        1024(0x400)
        y                        1024(0x400)
        z                        1024(0x400)
      Grid Max Size:<PHONE_NUMBER>(0xffffffff)
      Grid Max Size per Dimension:
        x<PHONE_NUMBER>(0xffffffff)
        y<PHONE_NUMBER>(0xffffffff)
        z<PHONE_NUMBER>(0xffffffff)
      FBarrier Max Size:       32
*** Done ***

Hi @stylesuxx
We are not officially supporting Navi series of cards. Hence can not comment on this.
Please have a look @ https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation-Guide.html#hardware-and-software-support-information


Allow for entire modules to be marked as "bonus"

E.g. "Dev-ops".
Closes #18

@mattstauffer I‘m working on this issue.


dialog-window: can not change the paddingTop from

the function _positionDialog in dialog-window.jsx has the following logic:
if (this.props.repositionOnUpdate || !container.style.paddingTop) {
    container.style.paddingTop = ((containerHeight - dialogWindowHeight) / 2) - 64 + 'px';
}

I think it's impossible to have the condition test to be false, as the container.style.paddingTop cannot be set from outside.

You can set the padding-top style from the outside if you were to modify the LESS/CSS. Assuming you do not do that, after the dialog has been mounted, the condition will evaluate to true since the padding-top style is not set as part of the default styling. After it has been mounted, updates will trigger a recalculation if this.props.repositionOnUpdate is true. So, the calculation will be run at least once unless you have styling that sets the padding-top of .mui-dialog-window or .mui-dialog-window.mui-is-shown.


fix(createGlobalState): do not mix global states

Description

In previous configuration states of two global states could get mixed together via globalState variable because useState remembers the initial store.state
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

[x] Read the Contributing Guide
[x] Perform a code self-review
[ ] Comment the code, particularly in hard-to-understand areas
[ ] Add documentation
[ ] Add hook's story at Storybook
[x] Cover changes with tests
[x] Ensure the test suite passes (yarn test)
[x] Provide 100% tests coverage
[x] Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
[x] Make sure types are fine (yarn lint:types).

How the states can be mixed ? I dont get it

@seloner try to run the test case without the fix :)

Also in the current implementation there is no clean up when the hook is unmounted
There is an open pull request from that
https://github.com/streamich/react-use/pull/1078/files

That's a separate issue I think, and in my usecase with the object map I handle it outside of hook


PowerToys Run errors

Microsoft PowerToys version
<IP_ADDRESS>
Installation method
GitHub
Running as admin
Yes
Area(s) with issue?
PowerToys Run
Steps to reproduce
2024-07-09.txt
✔ Expected Behavior
调出快速运行界面
❌ Actual Behavior
报错
Other Software
没有

/dup https://github.com/microsoft/PowerToys/issues/33504


Clicking something in File System doesn't unfocus/deselect node in SceneTree; Risky delete key operation.

Godot version:
Godot master d89dc5794
OS/device including version:
Windows 10 Pro
Issue description:
Clicking something in File System doesn't unfocus/deselect node in SceneTree. The issue occurs when you press something like delete key. Popup to delete both selected node and file appears.
Update: In 3.2.1, both are still selected but only one(last selected) shows delete confirmation dialog. So, it seems like a regression.
Steps to reproduce:

Click a node in SceneTree.
Click a file in File System(notice node is still selected).
Press Delete Key.

Minimal reproduction project:
Any project.

Fixed in 9b637fa
File delete confirmation only appears when file dock is focused (in which case scene tree doesn't get the Delete).


CSUB-61: Improvements around LLVM test coverage

Description of proposed changes:
Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

Note: excluding mock.rs and tests.rs dropped our line coverage report to about 62%


Unable to set empty retentionPolicy parameters for bicep diagnostic setting resource

When I try to deploy the diagnostic setting with empty parameters for rentention policy days and enabled I am getting an error "Request content is not well formed or supported".

Do you have a correlation ID for the error? I don't think this is the ARM Deployments service itself throwing the error, but this Insights Resource Provider specifically. I would recommend opening a support case for this particular issue to get a better sense of what is happening.
Separately, there are a lot of conditional statements in the is resource declaration. Can you experiment with hardcoding specific combinations of properties to narrow down precisely which property is causing the problem.

the correlation-request-id': '6fd1ecc4-d538-487c-87b1-ae808d5df17e'
Yes I know there are a lot of conditional statements in the is resource declaration because I am creating a module to reuse it. I experimented and the issue only happens when I don't set a value for the retentionPolicy parameters days and enabled. If I set a value it works fine.


Update de.js

Fix "nachmittags" and "den ganzen Tag lang"

Tests pass, so everything's merged in. Thanks for all the work on this! It'll go out with the next deploy.


Polish up layered_test_check

Move method out of the class that could be useful for future thing.  Booleanify the return value just in case. Add test cases to get coverage to 100%

@cpennington


Refactor StringLiteral vs. TemplateLiteral

Refactor StringLiteral vs. TemplateLiteral

StringLiteral is now always a string literal; no more BasicStringLiteral
TemplateLiteral now contains all CoffeeScript string interpolations (" and """ and even ''' which transpiles to a template literal), though occasionally returns StringLiteral when there is no interpolation.

Fixes #289

Important to check for CoffeeScript double-quoted strings via TemplateLiteral before regular double-quoted strings via StringLiteral.

Bonus feature (separate first commit): add support for template literals as object keys (by wrapping in brackets).

Nice!


how to convert onnx

you say “This model was converted into ONNX by PINTO0309 (Katsuya Hyodo)”，Which project should I to choose specifically？

Please use the same thread for the same topic.

Please use the same thread for the same topic.

do you mean this ：https://github.com/PINTO0309/PINTO_model_zoo/blob/main/115_MoveNet/PINTO_Special/barracuda_gathernd_split/README.md ？

Please use the previous thread, not here.


socialMinerBaseUrl is set to localhost

In line 36 of chat.html, socialMinerBaseUrl is set to localhost, meaning the sample code will only work if ran on socialminer server.
socialMinerChat.init(window.location.protocol + "//" + window.location.host, "........

@sylvesterlenihan Can I close this issue?
I don't see any problem here.

Yes, You can close issue...


OCUserBundle creation

Creation of an authentication system.

Install and Use of FOSUserBundle.
This bundle will allow visitors to login and/or register.
Possibility to edit your profile.
Before this bundle, you were able to add, edit and delete Tricks freely. Now, you need to be connected to do so.

Time Estimate : 2 days.

For this issue, here is the list of changes:

Created OCUserBundle with the command line.
Deleted defaultController.php and other files not needed for this website.
Created User Entity and Repository.
I'm using FOSUserBundle. Installed it with composer.
Chose Gravatar for the profile pictures (will be used for the comments).
Modified the User Entity to use FOSUserBundle and Gravatar.
Modified OCUserBundle.php to use FOSUserBundle.
Added the Bundle in composer.json autoload PSR-4.
Updated the Database to add the new table: fos_user.
Copied the default views of FOSUserBundle in app/Resources/FOSUserBundle/views to override them and modified them to match the layout of the website.

Now you can register, login, edit your profile and change your password. If you want to add, modify or delete tricks, you have to be logged in. Buttons are only visible when logged in.
Done in : 2 days.


Create slsnowglobe

Swaps snowglobe menu

Hey, sorry never done this before; Let me know if there's anything I need to fix up:)

At a glance this looks fine. For what it's worth, I think this would be better as a contribution to the menu-swapper-extended hub plugin for instance, as that plugin already offers numerous more niche swaps, and has the code framework to easily add more.

Config file is unnecessary

At a glance this looks fine. For what it's worth, I think this would be better as a contribution to the menu-swapper-extended hub plugin for instance, as that plugin already offers numerous more niche swaps, and has the code framework to easily add more.

This is how I'd prefer to have it. If you're able to give me some insight as too how; I'd be more than happy too

PR to https://github.com/raiyni/menu-swapper-extended

Okay, PR'd to menu-swapper-extended. Thanks


Fix status update

Fixes #93

Useless assignment to local variable

Seems like a false alert to me, the pr object is updated through pass by reference in the caller's code.

Quick summary of our conversation:

refactor the min calculation
check out all the r.Log and see if they can just be log.
refactor the initializeStatus to be closer to the format of the one in the helm controller: https://github.com/fluxcd/helm-controller/blob/e25d6894bfdc547101e60dbaf739f99ab4f005ef/controllers/helmrelease_controller.go#L184
same for submitStatus

3 and 4 should fix the problem we're seeing at the linting phase.
@maruina could pick this up in @nebojsa-prodana 's absence


fix: do not use colon character in types for windows support

This removes the use of : in the types files for Windows compatibility.

I guess it would only affect users reaching into the types by reference node_modules/@fastly/js-compute/types/fastly:kv-store? Strictly speaking that is public API though. But most users probably get the index.d.ts reference right?

I've moved back to a fix from fix!commit as I'm fairly sure this is non-breaking for most users. But please correct me if I've missed something here.


E2E smoke test for AnVIL CMG dev (mock managed access setup)

Similar to the one we made for the HCA Explorer.
Let meet to go the initial script.

Supersed by https://github.com/DataBiosphere/data-browser/issues/3626.


[engsys] update devcontainer.json

Move "settings" and "extensions" inside customizations/vscode as suggested at https://containers.dev/supporting

Be careful if being asked to rebuild codespaces because it's desctructive!

/check-enforcer override


Improve quickstart tutorial

Our current Quickstart tutorial was too concise when explaining how to quickstart an agent, and too lengthy when explaining how to do other things.
I have divided the current agent.md into two files: quickstart.md which only explains how to get a local agent and how to use it, and agent.md which contains the info that I have still not migrated.
In a future PR I will add the second part - in a separate file - explaining how to use the registry to upload and download agents.

This PR assumes that #642 and #641 are both fixed, otherwise, commands in the docs will not work (though, to be fair, they are not working now)


refactor: autoHide should be a widget shared behavior, not a component one

The way autoHide is written is "broken".
It's acknowledging that the React Components are aware of the node they are mounted to (container). While they should not know about it.
It complexifies the implementation of the autoHide feature for nothing nad restrict us to use it on widgets that are bound to react only.
We should move this decorator as a "widget" decorator (shared behavior). And maybe do the right thing => move the decorator call outside of the widget.

I've been thinking about that and what we discussed yesterday. I still feel it weird and counter-intuitive that this behavior will hide the component parent and not the component itself (moving it to a widget behavior does not change that).
For me all the containers we define as attributes of the widgets are placeholder where we will add our widgets. The only exception is the searchBox widget that can use the container directly if it's an input, but this is a special case and not the norm.
A usual generated markup is currently like this (react intermediate divs omitted for brievety).

Foo

bar

Header

Foo

bar

Footer

If we want to continue the BEM way and remove all styling from the widgets, we will have to remove the display:none inline styling that we are currently doing on the autoHide decorator. This means adding a ais-hidden with display:none to the element we want to hide.
If we keep following what the code is currently doing, we will add the class to the parent element, the
. This is what feels broken to me. In every other widget we're only manipulating the inner HTML nodes (wrapping them, adding classes), and never the parent one. Why should this one acces elements outside of its scope?
If I call an hideWhenNoResults: true I would expect the widget to be hidden, not it's container. The same way that by setting a template.header I expect a header to be added to the widget, not to its parent. Or by setting a cssClasses.root I expect the class to be added to the inner root element, not its parent.
I'm not saying hiding the parent element is a bad idea, I'm saying that is not currently consistent with all our other widgets. We can choose one way or the other, but we have to stay consistent and make it clear in the doc so our users know what to expect when they specify a container

@vvo makes me think that maybe if we want to provide such tool on the widget, maybe we should have the render and other methods for the lifecycle be more like function (return something + no side effects) in order to make them composable. Right we can't do that, since we have no about what's going in those methods.
@pixelastic interesting but I don't have a favorite yet :P

:+1: @pixelastic

Moved the autoHide feature discussion to #303 to avoid us talking too much different things. This one is really only about refactoring and option name change.

@bobylito I guess we should be able to do high order widgets like we do for components. You could wrap a widget and have a render method that call the underlying one when necessary. Dunno if that's possible.

Hard for now I think. We don't have much control over the output, which is not the case when using React.

:horse: CLOSING BOT SAYS:

This is old and not done, reopen if you have the need and want to fix it


Support hide export button dynamically

Only support hiding & showing

Coverage increased (+0.07%) to 37.883% when pulling 1101c11da96c481009aac312a89cc694f17edd2b on qingweibinary:qingwei/hide_button_dynamically into 6074b6c124e8f8acffb5982e2add63a2a51b69f6 on binary-com:master.


peek stdout / stderr of a running trial in the web portal

Thanks for pointing this out. Showing trial's stdout/stderr on web portal is an appealing feature. In the current version, web portal shows each trial's log path, you can get the log path by clicking the plus sign in the trial job table, then access that path on your machine (local machine or remote machine). This feature will be supported in future.

Hi, I am new here.
I would love to work on a MS project. Can I please solve this bug.
Thanks

@suhailsinghbains , it would be great, thanks. Before implementing, could you give a proposal about how to support this feature, the design choice?

How do I re-create this bug in my local machine.

@suhailsinghbains , this is not a bug but a feature. In the current version, webui only shows trial log's uri, e.g., directory path. Sometimes, users want directly get log file's content from webui instead of only uri.

In latest version of nni, we have support show log content in web portal.


Add Option for Debug Mode in Run-AlPipeline

I will get issues sometimes in my Run-AlPipeline on the Run Test Functions in my CI pipelines.  I will rerun the pipeline again, and the error won't show up.  I was wondering if we could add the parameter -debugMode from Run-TestInBCContainer into Run-AlPipeline so that I could catch these issues.

You can add this parameter to Run-AlPipeline:
    -RunTestsInBcContainer { Param([Hashtable]$parameters) Run-TestsInBcContainer -debugMode @parameters }

Then Run-Tests should run with DebugMode.

Thank you. That solution for me.


Applicant - Job Poster Icons

Please name the task using the following information: Applicant/Manager/Admin/Sitewide - Name. Assign this task to the appropriate person and give it the "Task" label.
Description
Update the job objects on the job poster index to include iconography that matches the mockup below.

Required for Completion
Add/remove others as necessary for this specific task.

[x] Accessibility Check
[x] Browser Compatibility Check

Looks good though the 2 icons are taking up different widths right now, so the text is a little offset. I think it would look better if the text aligned like in the design above.


Is this repo being maintained?

Thanks for providing the bindings. I was wondering if this is being maintained and if there is a process to make sure that it gets updated often.

Thanks for providing the bindings. I was wondering if this is being maintained and if there is a process to make sure that it gets updated often.

this is a community contributed project so anyone's welcome to create PRs. "maintained" is a vague term in my opinion.


add the current set of core and recommended lints to the readme.md file

We should consider adding the current set of core and recommended lints to the readme.md file. This can be generated from the files in lib/, and we could have a CI process to ensure that the readme is kept up-to-date.
Minimally we could have the rule name and a link to its docs (ala https://dart.dev/tools/linter-rules#avoid_print). It would also be nice to be able to include a 1-liner for docs about the rule, but I don't believe there's any convenient place to get that currently (like from a /tools/metadata subdir in the sdk for example).

I love this idea, but consider linking to https://dart.dev/lints/ since that's more guaranteed to work no matter what structure we go with in the future as we rework lint documentation.


Suggest use FindOrFail(), firstOrFail() on models

For example, I see that in Role.php
public static function findByName($name)     {         return Role::where('name', $name)->first();     }
Would it be better to use firstOrFail() so that an exception is thrown at this point if the user asks for a non-existent Role name?
Similarly in other methods such as TeamRepository find() method
public function findByName($name)     {         return $this->model->where('name', $name)->first();     }
Would it be better to use firstOrFail() ?
Just a suggestion, keep up the good work!
thx

Switched to fail versions in 1.9.12 thanks for the suggestion


Fix minor typo in ListViewExample.js

s/_renderSeperator/_renderSeparator/

By analyzing the blame information on this pull request, we identified @geirman and @javache to be potential reviewers.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

@facebook-github-bot shipit

I cannot do that @javache, because @eronisko does not have an active CLA on file.

Something went wrong when importing this pull request. Please cc someone from the team at fb to help with importing this.

Ah, good catch. Guess I don't spell so good ;)
@eronisko make sure you sign the CLA so we can ship this

CLA signed.

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot shipit

I cannot do that @javache, because @eronisko does not have an active CLA on file.

Something went wrong when importing this pull request. Please cc someone from the team at fb to help with importing this.

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.


rocmPackages_{5,6}.miopen: fix test builds by linking gtest

Description of changes
At HEAD neither rocm 5.x or rocm 6.x versions of miopen succeed in building when buildTests = true, because gtest isn't included in buildInputs or correctly linked. Simply putting it in buildInputs isn't sufficient apparently, so this PR includes a patch to CMakeLists.txt.
It seems most of the tests for the rocm 5.x version pass, though overall the build fails due to non-passing tests (I am new in the rocm world so it's possible I'm holding it wrong). For rocm 6.x, there is an LLVM undefined symbol error (see #299156) that I think just means the derivation for that version of MIOpen is completely broken right now. I haven't managed to resolve it yet, and will leave #299156 open to track it, renaming as appropriate.
Even if the tests don't pass I'd argue that having them buildable is strictly better than not. I also split it into two commits in the unlikely case there's desire to backport the 5.x fix to stable.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I have never used substitueAll so far, so bare with me. The way I read this you are replacing two instances of gtest_mainwith<EMAIL_ADDRESS><EMAIL_ADDRESS>and then with ${gtest}/lib/libgtest.so ${gtest}/lib/libgtest_main.so
Have you considered using substituteInPlace with the --replace-fail argument to go from gtest_main to ${gtest}/lib/libgtest.so ${gtest}/lib/libgtest_main.so in one step?

Have you considered using substituteInPlace with the --replace-fail argument to go from gtest_main to ${gtest}/lib/libgtest.so ${gtest}/lib/libgtest_main.so in one step?

You're right, in this case that would be more straightforward and maintainable. I've updated both commits, PTAL.

Actually, I see at HEAD in MIOpen the line is
target_link_libraries(${TEST_NAME} GTest::gtest GTest::gtest_main MIOpen ${Boost_LIBRARIES} hip::host $<BUILD_INTERFACE:roc::rocblas>)

the substitution proposed will silently succeed, I think, but yield something broken. Maybe adding a leading space before "gtest_main" and the replacement patterns would guard against this.

Actually, I see at HEAD in MIOpen the line is
target_link_libraries(${TEST_NAME} GTest::gtest GTest::gtest_main MIOpen ${Boost_LIBRARIES} hip::host $<BUILD_INTERFACE:roc::rocblas>)

the substitution proposed will silently succeed, I think, but yield something broken. Maybe adding a leading space before "gtest_main" and the replacement patterns would guard against this.

That sounds like a good change to me.

I applied your patch, PTAL.

Result of nixpkgs-review pr 300079 run on x86_64-linux 1

8 packages marked as broken and skipped:

rocmPackages.migraphx
rocmPackages.mivisionx
rocmPackages.mivisionx-cpu
rocmPackages.mivisionx-hip
rocmPackages_6.migraphx
rocmPackages_6.mivisionx
rocmPackages_6.mivisionx-cpu
rocmPackages_6.mivisionx-hip

3 packages failed to build:

rocmPackages_5.mivisionx (rocmPackages_5.mivisionx-hip)
rocmPackages_5.mivisionx-cpu
rocmPackages_5.mivisionx-opencl

14 packages built:

python311Packages.torchWithRocm
python311Packages.torchWithRocm.cxxdev
python311Packages.torchWithRocm.dev
python311Packages.torchWithRocm.dist
python311Packages.torchWithRocm.lib
python312Packages.torchWithRocm
python312Packages.torchWithRocm.cxxdev
python312Packages.torchWithRocm.dev
python312Packages.torchWithRocm.dist
python312Packages.torchWithRocm.lib
rocmPackages.miopen (rocmPackages.miopen-hip ,rocmPackages_6.miopen ,rocmPackages_6.miopen-hip)
rocmPackages_5.migraphx
rocmPackages_5.miopen (rocmPackages_5.miopen-hip)
rocmPackages_5.miopen-opencl

From what I can tell these changes looks good. I'm currently running nixpkgs-review and it failed building libjpeg-turbo because some patch doesn't apply, but I don't see how that is related to this change.

It is not. This if fixed here: https://github.com/NixOS/nixpkgs/pull/300257

They are not related.
LGTM from my side. I approved this two weeks ago and I don't have commit bit.


Guide on how to contribute?

1: Will Astrid take pull requests, or is there some other intended method to bring code in?
2: Documentation seems sparse, but there's no way of telling what will be changed while the in-code docs are being written by a different contributor. Is there some way of allocating work for who-writes-what documentation?
3: Although I'm personally used to using LibGDX by going onto Github and browsing the source when something isn't clear to me, I know most users of that similar library use the wiki. Is the wiki for Astrid intended to fill a similar purpose, that is, the main source for documentation?
4: Is there an IRC channel already? I'm on #astrid on irc.freenode.net ; give me a nick to make the channel's owner and I will see if I can.

Hi @tommyettinger
Welcome to Astrid. You are one of the first contributors to the project outside myself, so most of the questions don't have really good answers yet. If you would like to help me figure out answers

Yes, Astrid will take pull requests. I figure we might as well use github the way it's intended. Do you have any other ideas?

Right, there's hardly any documentation. I've started a blog but there's not much in it yet.
http://blog.craftworkgames.com/

As for allocating work, currently I'm just managing my task list with a Trello board.  Do you have any thoughts on managing this with multiple people?
https://trello.com/b/egogxXto/astrid-game-framework

I think the wiki for LibGDX is very good. It must've taken a long time to put it together though. I would like something similar for Astrid, although, at the moment there's nothing. My plan was to do regular blog posts while building the framework and collect it all together into a wiki in the future.

I'll join the channel now and take a look.


today doesnt update selected date

hi,
in date picker dialog the today buttons doesn't change the selected date

Hi there,
please check out the new version and if it's ok or not just let me know😀🤗

thanks for your fast response the today button still doesn't call onDateChanged

can u please specifically share me ur code?

yes, as you can see i have a Log in onDateChanged , but its not being fired on today button clock
imagine datePicker starts with today date, I change it to tomorrow till here its ok it has tomorrows date, but when I click on today button the dialog shows today's date but the Log is not fired to set the variable again

           PersianDatePickerDialog(
                rememberPersianDatePicker,
                Modifier.fillMaxWidth(),
                onDismissRequest = { detailState.showDialogDate = false },
                onDateChanged = { year, month, day ->

                    Log.e("onDateChanged","$year $month $day")

                    val gSelectedDate = LocalDate.of(
                        rememberPersianDatePicker.getGregorianYear(),
                        rememberPersianDatePicker.getGregorianMonth(),
                        rememberPersianDatePicker.getGregorianDay()
                    )

                    detailState.selectedDate = gSelectedDate

                })

tnx again, pls check out new version and let me know if it's ok

Its fixed now
thank you for your great effort in this project, keep up the good work !

Its fixed now thank you for your great effort in this project, keep up the good work !

good to hear, please give a start. tnx 😀❤


Workspace - Unable to save new workspace name

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.73-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:

Go to staging.new.expensify.com
Sign up with a new Gmail account (random email without +)
On onboarding purpose, choose Manage my team's expenses
Select organization size
Select an accounting
Complete the onboarding
Go to workspace settings > Profile
Click Name
Edit the name and save it

Expected Result:
The new workspace name is saved successfully
Actual Result:
The new workspace name is not saved. It reverts to the previous name and RBR shows on Profile tab
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/fb5877fb-5ba6-4933-8e47-6ddb994ce84c
View all open jobs on GitHub

I see Invalid currency in custom unit rate.

It seems like the workspace currency is empty

Likely coming from https://github.com/Expensify/App/pull/52164/files

Yea, we're now passing an empty string as the currency here

This is fixed in staging
https://github.com/user-attachments/assets/7b2bb1b2-5116-45bf-b0fb-ceaa51bd99f2


How to annotate lists?

Hi:
I am trying to get this code to show in a list format in the document description:

1MIN  (one minute)
1HR   (one hour)
3HR   (three hours)

but at the time of generating the json, I miss the (*).

the problem is that swagger allows for markdown but go doc formatter has its own rules around this stuff, and they don't always agree.
I think you can achieve what you want by adding more spaces in front of the list items so that go thinks it's a pre-formatted block in the comments. For that it will need to be preceded with a blank line and followed by a blank line.
When going the route of documents and you want precise control over how things look, it's a good idea to get very familiar with the intricacies of godoc. https://goswagger.io/use/spec.html#parsing-rules
Another option would be to use the swagger:operation annotation instead of the swagger:route one.
That one allows you to put yaml which might be a better bet to get markdown formatting to work

I will give it a try. Thank you!


Add unicode support to extra_var parsing

Connect #232.
Cause of the problem: Unicode string is hard-converted to byte string, which will lead to value overflow if the string contains non-ascii characters.
Think there are still more to be done for tower-cli internationalization. For example, # -*- coding: utf-8 -*- header is missing all across our code base.

Coverage decreased (-0.04%) to 98.365% when pulling b34bbb1ac61da2eb0bdcb848a419bc487de993d2 on jangsutsr:issue232 into 0b2a22deb917227be5834fcb3437af5f075007b7 on ansible:master.

Changes Unknown when pulling 9649e7dbca6cd1a5f09b89e98e9b25ea7353ffe0 on jangsutsr:issue232 into ** on ansible:master**.


Update annnotations on gist:hasAccuracy

The skos:definition should not be limited to magnitudes. A measuring instrument or a measurement event could also have an accuracy.
Current:
gist:hasAccuracy
	a
		owl:ObjectProperty ,
		owl:FunctionalProperty
		;
	rdfs:range gist:Magnitude ;
	skos:definition "Relates a magnitude to the accuracy of its numeric value."^^xsd:string ;
	skos:example "Temperature accurate to tenth of a degree C; length accurate to the nearest centimeter."^^xsd:string ;
	skos:prefLabel "has accuracy"^^xsd:string ;
	skos:scopeNote """A typical way to use accuracy is to have it represent 2 standard deviations of the distribution of measurement errors. With this convention, when the measurement method is well-calibrated (has an average error of zero) and its errors have a normal distribution, there is a 95% chance that the actual error in measurement, in either direction, is less than the accuracy.

Note that the unit of measure of the accuracy has to be compatible with the unit of measure of the original magnitude (e.g. something measured in meters could have a accuracy in terms of millimeters or any other unit that measures distance)."""^^xsd:string ;
	.

Proposed:
gist:hasAccuracy
	a
		owl:ObjectProperty ,
		owl:FunctionalProperty
		;
	rdfs:range gist:Magnitude ;
        gist:domainIncludes gist:Magnitude ;
	skos:definition "Relates a resource such as a magnitude to the accuracy of its numeric value."^^xsd:string ;
	skos:example "Temperature accurate to tenth of a degree C; length accurate to the nearest centimeter."^^xsd:string ;
	skos:prefLabel "has accuracy"^^xsd:string ;
        skos:scopeNote "Could also apply to measurement events (activities) or measuring instruments." ;
	skos:scopeNote """A typical way to use accuracy is to have it represent 2 standard deviations of the distribution of measurement errors. With this convention, when the measurement method is well-calibrated (has an average error of zero) and its errors have a normal distribution, there is a 95% chance that the actual error in measurement, in either direction, is less than the accuracy.

Note that the unit of measure of the accuracy has to be compatible with the unit of measure of the original magnitude (e.g. something measured in meters could have a accuracy in terms of millimeters or any other unit that measures distance)."""^^xsd:string ;
	.

[like]  Michael J. Sullivan reacted to your message:

From: Rebecca Younes @.>
Sent: Tuesday, August 13, 2024 8:00:26 PM
To: semanticarts/gist @.>
Cc: Subscribed @.***>
Subject: [External] : [semanticarts/gist] Update annnotations on gist:hasAccuracy (Issue #1146)
The skos:definition should not be limited to magnitudes. A measuring instrument or a measurement event could also have an accuracy.
Current:
gist:hasAccuracy
a
owl:ObjectProperty ,
owl:FunctionalProperty
;
rdfs:range gist:Magnitude ;
skos:definition "Relates a magnitude to the accuracy of its numeric value."^^xsd:string ;
skos:example "Temperature accurate to tenth of a degree C; length accurate to the nearest centimeter."^^xsd:string ;
skos:prefLabel "has accuracy"^^xsd:string ;
skos:scopeNote """A typical way to use accuracy is to have it represent 2 standard deviations of the distribution of measurement errors. With this convention, when the measurement method is well-calibrated (has an average error of zero) and its errors have a normal distribution, there is a 95% chance that the actual error in measurement, in either direction, is less than the accuracy.
Note that the unit of measure of the accuracy has to be compatible with the unit of measure of the original magnitude (e.g. something measured in meters could have a accuracy in terms of millimeters or any other unit that measures distance)."""^^xsd:string ;
.
Proposed:
gist:hasAccuracy
a
owl:ObjectProperty ,
owl:FunctionalProperty
;
rdfs:range gist:Magnitude ;
gist:domainIncludes gist:Magnitude ;
skos:definition "Relates a resource such as a magnitude to the accuracy of its numeric value."^^xsd:string ;
skos:example "Temperature accurate to tenth of a degree C; length accurate to the nearest centimeter."^^xsd:string ;
skos:prefLabel "has accuracy"^^xsd:string ;
skos:scopeNote "Could also apply to measurement events (activities) or measuring instruments." ;
skos:scopeNote """A typical way to use accuracy is to have it represent 2 standard deviations of the distribution of measurement errors. With this convention, when the measurement method is well-calibrated (has an average error of zero) and its errors have a normal distribution, there is a 95% chance that the actual error in measurement, in either direction, is less than the accuracy.
Note that the unit of measure of the accuracy has to be compatible with the unit of measure of the original magnitude (e.g. something measured in meters could have a accuracy in terms of millimeters or any other unit that measures distance)."""^^xsd:string ;
.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/semanticarts/gist/issues/1146__;!!ACWV5N9M2RV99hQ!MzfRcdYrBbHYj2aJRMi19xfDp5vT03x1GTUqiMKIipLh1w6C-M2F3oDLGp8BztU3_bXSKzPLqG4b15zz9J1fO1OtJr1KdeI$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOMYTHZD3FOHHIW6SEFIEODZRJQVVAVCNFSM6AAAAABMO6QQZKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3DIMJRHE3DKOA__;!!ACWV5N9M2RV99hQ!MzfRcdYrBbHYj2aJRMi19xfDp5vT03x1GTUqiMKIipLh1w6C-M2F3oDLGp8BztU3_bXSKzPLqG4b15zz9J1fO1OtekniO24$.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Fix with #1149.

Is there an example of an instance of an "accuracy" magnitude in the style of "plus or minus 5%" ?

Is there an example of an instance of an "accuracy" magnitude in the style of "plus or minus 5%" ?

No, but that is an interesting idea. We do have something similar in the operators ontology. See the properties:

hasTargetValue
hasPercentVariation
hasAbsoluteVariation

Regarding "This is an abstract superproperty, not intended for use in triples" I suppose this means that we should create our own subproperty based on this – correct? And in the use-case of a precision of "plus or minus 5%" what exactly would that subproperty reference (i.e. its rdfs:range)? Some sort of Magnitude? Blank node? Or something else?
M

From: Michael Uschold @.>
Sent: Wednesday, September 11, 2024 3:25 PM
To: semanticarts/gist @.>
Cc: Michael J. Sullivan @.>; Comment @.>
Subject: [External] : Re: [semanticarts/gist] Update annnotations on gist:hasAccuracy (Issue #1146)
Is there an example of an instance of an "accuracy" magnitude in the style of "plus or minus 5%" ?
No, but that is an interesting idea. We do have something similar in the operators ontologyhttps://urldefense.com/v3/__https://github.com/semanticarts/operators-ontology__;!!ACWV5N9M2RV99hQ!I7OtTR8UEY0jAfKogMvJH8dhOblmMymd_VVCs20gWzqSy7nDqsvTlRUSfLoUVj14m74tpGTfQir50jjEXLHLChcvD0dDzhU$. See the properties:

hasTargetValue
hasPercentVariation
hasAbsoluteVariation

—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/semanticarts/gist/issues/1146*issuecomment-2344532877__;Iw!!ACWV5N9M2RV99hQ!I7OtTR8UEY0jAfKogMvJH8dhOblmMymd_VVCs20gWzqSy7nDqsvTlRUSfLoUVj14m74tpGTfQir50jjEXLHLChcvSgN6mdM$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOMYTH3O6MCJWLM7IM5W6G3ZWCKI7AVCNFSM6AAAAABMO6QQZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBUGUZTEOBXG4__;!!ACWV5N9M2RV99hQ!I7OtTR8UEY0jAfKogMvJH8dhOblmMymd_VVCs20gWzqSy7nDqsvTlRUSfLoUVj14m74tpGTfQir50jjEXLHLChcv-yPYTXY$.
You are receiving this because you commented.

The second scopeNote is far more technical and detailed than is the norm for gist.  I read it several times, I have a math background, and I still can't work out exactly what it means or how to make use of it. If this information is likely to be useful to gist users, I propose to use rdf:seeAlso to a link that has a good explanation. In the meantime, here is my proposal:
gist:hasAccuracy
	a
		owl:ObjectProperty ,
		owl:FunctionalProperty
		;
	rdfs:range gist:Magnitude ;
        gist:domainIncludes gist:Magnitude ;
	skos:definition "Relates a resource such as a magnitude to the accuracy of its numeric value."^^xsd:string ;
	skos:example "Temperature accurate to tenth of a degree C; length accurate to the nearest centimeter."^^xsd:string ;
	skos:prefLabel "has accuracy"^^xsd:string ;
        skos:scopeNote "Could also apply to measurement events (activities) or measuring instruments." ;
	skos:scopeNote "Note that the unit of measure of the accuracy has to be compatible with the unit of measure of the original magnitude (e.g. something measured in meters could have a accuracy in terms of millimeters or any other unit that measures distance)."^^xsd:string ;
	.

I agree that the original is too technical. Do you think "compatible" needs to be elaborated on or is it self-explanatory enough?


The Python 3.90 environment in visual studio 2019 cannot install packages on the Internet

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a61810c3-c215-1b07-3bc8-17af0b6676ad
Version Independent ID: dd1701c0-9117-29ba-bbd2-413949e305da
Content: Python environments window reference - Visual Studio
Content Source: docs/python/python-environments-window-tab-reference.md
Product: visual-studio-windows
Technology: vs-python
GitHub Login: @JoshuaPartlow
Microsoft Alias: joshuapa

@Q-yl -- thank you for your feedback.  Please provide additional context for your intended task.  Meanwhile, consider these resources:

Visual Studio on Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit


Stuck on Step 4

@muelmx & @Loizz can you help me figure out how to build / run the GUI from the current release? I can't figure out where to extract it.

Hi, actually you just need to download  the release zip unzip (right click -> extract I guess) and run App/DeepdreamGui.exe


setting the ColorColumn highlight group should be buffer-local

At the moment the value of the ColorColumn highlight group is set to red (or the value specified with g:docile_color_column) globally.
That means opening a vim help file (even by just calling :help <term>) the highlight group will be changed for the whole vim session.
This should be changed to only affect the current buffer.
The commands and mappings already are buffer local. And unfortunately it seems that the highlight groups can not easily be made buffer local (at least I didn't see an option for the highlight command). But the current behaviour is very intrusive.

I see what you mean. I never use ColorColumn except when editing help files (nor have I met anyone that did), so I just overlooked that use case. Possibly I could save off the original and then reset it on BufLeave. I hate doing that kind of thing, but if highlight doesn't have a local option, I don't know what other choices there are (other than just removing that feature maybe).

I don't think reacting on BufEnter and BufLeave won't be a full solution either as it still changes the ColorColumn of all other active windows. But actually I don't know of any other workaround.

This is the issue that makes me think removing the option (mentioned in the other issue) might be best way to go. I don't know how to solve this one, so it might be better to just not interfere with it and let people set that color themselves. I'll do some research before I do that though just to make sure.


Identify headers with a default model, and then model them.

Headers that extend HeaderKey.Default should have a case class that models them as something more than a String.  This task involves:

Enumerating such headers, with link to relevant RFC.
For each one, interpreting the RFC into a case class and writing the parser.

This, like the recent middleware reform, will be a source of good first issue tickets.

The way headers are registered is under review in the more ambitious #1143, but the parsers themselves will still be useful even if they move before 1.0.

I'll gladly take this one if you don't mind

I would be inclined to tackle one at a time, which one are you looking to take on first?

Okay so let me start with AcceptPatch!
Dnia czw., paź 25, 2018 o 16:39, Christopher Davenport<EMAIL_ADDRESS>napisał:

I would be inclined to tackle one at a time, which one are you looking to take on first?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

I can take Access-Control-Max-Age

I'm going to take Access-Control-Allow-Headers.
I don't know what is the status with the Accept-Patch as there is a comment from 2018; if there is no progress there, I could take it.
Also, maybe we could create a small table with columns: header, modeled/done, PR link, for an easier tracking? If you think it's a good idea, I can create it as a comment in this issue and afterwards it could be updated.

I will pick Access-Control-Allow-Methods. Haven't seen any comments for picking it.

A table would be great, I was trying to
Tackle these in alphabetical order but I haven’t had time lately

@amitrai48 Sounds great!
I converted the list above to a checklist.  I'll try to keep that current as they're claimed.  It's possible I missed some: if you get there, and it doesn't extend HeaderKey.Default, please come back for another!

Hi all, I would like to pick Content-Language.

I would like to pick Access-Control-Expose-Headers.

This got cleaned up in the Header remodel.  A few that had a default model disappeared, but we can handle those on a case-by-case basis.


Enhancements ~ Optimize images, Enhance Speech2Text Plugin, Support Custom CSS in Chainlit

Optimize images 3ec64c05931a18bb46432f4b45ab475599b56fe6
Enhance Speech2Text Plugin with Whisper Model Selection 834209c80b8698fac98150bae0e86d915a149fd3
Support Custom CSS in Chainlit Configuration for TaskWeaver UI 282c73838dabd2c4e33f20a8831121f588ed82b3

@microsoft-github-policy-service agree
On Fri, Apr 5, 2024 at 10:06 PM microsoft-github-policy-service[bot] <
@.***> wrote:

@yesbhautik https://github.com/yesbhautik please read the following
Contributor License Agreement(CLA). If you agree with the CLA, please reply
with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of
intellectual property rights to my Submissions and I am not making
Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work
for my employer (or my employer has intellectual property rights in my
Submissions by contract or applicable law). I have permission from my
employer to make Submissions and enter into this Agreement on behalf of my
employer. By signing below, the defined term “You” includes me and my
employer.

@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement Contribution License Agreement
This Contribution License Agreement (“Agreement”) is agreed to by the
party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its
affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is
effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable
or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft
and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or
distributing code or other content to any
Project, including but not limited to communication on electronic
mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf
of, the Project for the purpose of
discussing and improving that Project, but excluding communication
that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material
Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement
before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now
or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions
is entirely Your original work.
Should You wish to Submit materials that are not Your original work,
You may Submit them separately
to the Project if You (a) retain all copyright and license information
that was in the materials as You
received them, (b) in the description accompanying Your Submission,
include the phrase “Submission
containing materials of a third party:” followed by the names of the
third party and any licenses or other
restrictions of which You are aware, and (c) follow any other
instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include
Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a
contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your
employer has intellectual
property rights in Your Submission by contract or applicable law, You
must secure permission from Your
employer to make the Submission before signing this Agreement. In that
case, the term “You” in this
Agreement will refer to You and the employer collectively. If You
change employers in the future and
desire to Submit additional Submissions for the new employer, then You
agree to sign a new Agreement
and secure permission from the new employer before Submitting those
Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the
Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive,
royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly
display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all
of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the
Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive,
royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or
the combination of the
Submission with the Project to which it was Submitted to make, have
made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the
Project.
Other Rights Reserved. Each party reserves all rights not
expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without
limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are
legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your
original work (except as You may
have disclosed under Section 3). You represent that You have secured
permission from Your employer to
make the Submission in cases where Your Submission is made in the
course of Your work for Your
employer or Your employer has intellectual property rights in Your
Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You
represent and warrant that You
have the necessary authority to bind the listed employer to the
obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless
You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE
WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED
UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO,
ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of
any facts or circumstances of which
You later become aware that would make Your representations in this
Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to
Projects and information about
contributions may be maintained indefinitely and disclosed publicly,
including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the
laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal
courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in
which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County,
Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire
agreement between the parties, and
supersedes any and all prior agreements, understandings or
communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may
be assigned by Microsoft.

—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/TaskWeaver/pull/284#issuecomment-2040230733,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APIH3MZPVTELPHGN3SP7MADY33HJLAVCNFSM6AAAAABFZOOBRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGIZTANZTGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Best Regards,
Bhautik Bavadiya https://www.youareunique.co.in/
Founder & CEO
Email: @.***
Phone: +91 63535 86391 <+916353586391>
Organization: YesbhautikX https://www.yesbhautikx.co.in/
[image: GitHub] https://github.com/yesbhautik
[image: Twitter] https://www.twitter.com/yesbhautik
[image: LinkedIn] https://www.linkedin.com/in/yesbhautik
[image: Instagram] https://www.instagram.com/yesbhautik
[image: Whatsapp] https://wa.me/916353586391
This e-mail may contain confidential and/or legally privileged information
and is meant for the intended recipient only. If you have received this
e-mail in error and are not the intended recipient, kindly notify us at
@.* & @.*** and then delete this e-mail
immediately from your system. You are also hereby notified that any use,
any form of reproduction, dissemination, copying, disclosure, modification,
distribution and/or publication of this e-mail, its contents or its
attachment/s other than by its intended recipient is strictly prohibited
and may be unlawful.

@Jack-Q  Please take a look at this PR.

Thanks for the contribution, but why do we need to reduce the image size? wondering that this action will lead to the quality loss?

Thanks for the contribution, but why do we need to reduce the image size? wondering that this action will lead to the quality loss?

No Quality loss for sure. Also reduced image size can optimize application.

@Jack-Q Please take a look at this PR.

Why taking long time for small PR clearance?


No tests found

I've read the other closed issues #64 and #51 on this. I suspect this is a similar cause with treesitter changes, but I haven't been able to figure out a resolution.
This is the minimal reproduction configuration I have using lazy.nvim.
repro.lua
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
	vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
	vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
	"folke/tokyonight.nvim",
	"LazyVim/LazyVim",
	{
		"nvim-neotest/neotest",
		dependencies = {
			"nvim-neotest/nvim-nio",
			"nvim-lua/plenary.nvim",
			"nvim-treesitter/nvim-treesitter",
			"nvim-neotest/neotest-go",
		},
		opts = {
			adapters = {
				["neotest-go"] = {
					-- Here we can set options for neotest-go, e.g.
					-- args = { "-tags=integration" }
					recursive_run = true,
				},
			},
		},
	},
}
require("lazy").setup(plugins, {
	root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

vim.cmd([[
command! NeotestSummary lua require("neotest").summary.toggle()
command! NeotestFile lua require("neotest").run.run(vim.fn.expand("%"))
command! Neotest lua require("neotest").run.run(vim.fn.getcwd())
command! NeotestNearest lua require("neotest").run.run()
command! NeotestDebug lua require("neotest").run.run({ strategy = "dap" })
command! NeotestAttach lua require("neotest").run.attach()
command! NeotestOutput lua require("neotest").output.open()
]])

Loading this test file, I get to tests found for NeotestFile and NeotestSummary.
repro_test.go
package main

import (
	"regexp"
	"testing"
)

func Hello(msg string) (string, error) {
	return msg, nil
}

func TestFail(t *testing.T) {
	t.Error("Fail :(")
}

// TestHelloName calls greetings.Hello with a name, checking
// for a valid return value.
func TestHelloName(t *testing.T) {
	name := "Gladys"
	want := regexp.MustCompile(`\b` + name + `\b`)
	msg, err := Hello("Gladys")
	if !want.MatchString(msg) || err != nil {
		t.Fatalf(`Hello("Gladys") = %q, %v, want match for %#q, nil`, msg, err, want)
	}
}

// TestHelloEmpty calls greetings.Hello with an empty string,
// checking for an error.
func TestHelloEmpty(t *testing.T) {
	msg, err := Hello("")
	if msg != "" || err == nil {
		t.Fatalf(`Hello("") = %q, %v, want "", error`, msg, err)
	}
}

$ nvim --version
NVIM v0.9.5
Build type: Release
LuaJIT 2.1.1710088188

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "
/Users/christopherhoffman/.homebrew/Cellar/neovim/0.9.5/share/nvim"

Run :checkhealth for more info

$ nvim -u repro.lua repro_test.go

The lockfile for lazy.
{
  "LazyVim": { "branch": "main", "commit": "70bc8803306ba26a6362d489751da48633c1164c" },
  "lazy.nvim": { "branch": "main", "commit": "83493db50a434a4c5c648faf41e2ead80f96e478" },
  "neotest": { "branch": "master", "commit": "e07fe8241112274aae9947b98d255763738a1d52" },
  "neotest-go": { "branch": "main", "commit": "6a2f996d89fe4631942e035b1c114544ee045043" },
  "nvim-nio": { "branch": "master", "commit": "ed70af8ad9d4dafdb55539ed2b4454aac2a2a0c3" },
  "nvim-treesitter": { "branch": "master", "commit": "c28396de30b92a5af049037c2bd543a932a37a78" },
  "plenary.nvim": { "branch": "master", "commit": "f7adfc4b3f4f91aab6caebf42b3682945fbc35be" },
  "tokyonight.nvim": { "branch": "main", "commit": "fbe3a27378fdd51a8ddd04f57012455436916a62" }
}

I, too, had experienced the annoying 'No tests found' :anger:. And on top of that, it took me two days to just build the mental model of how the plugin, treesitter, etc work together to identify tests, and I was able to find the root cause for my issue.
In the end, for me, it was another adapter being used instead of go (neotest-zig), which meant it didn't find the test case name, but as you are showing above you're not registering the neotest-zig adapter.
What I really found useful is inspecting the debug logs that neotest emits. I will share what I did in case it helps you too:

Change the neotest plugin opts to include the log level:"nvim-neotest/neotest",
-- other key/vals ...
opts = {
  level = vim.log.levels.DEBUG,
  adapters = {
    ["neotest-go"] = {
      -- Here we can set options for neotest-go, e.g.
      -- args = { "-tags=integration" }
      recursive_run = true,
    },
  },
},

Find out where neotest writes its plugins (source). I ran the command::lua vim.print(pcall(vim.fn.stdpath, "log"))
-- my output: /home/asfaltboy/.local/state/nvim/neotest.log

restart neovim, and tail the log in another shell:tail -f /home/asfaltboy/.local/state/nvim/neotest.log

In your neovim session, try and run neotest's run command.

If you can't identify the cause outright, please share the logs

I followed the directions to set the log level in the reproduction script and invoked a test run. I didn't get much of any logs except a loading error. Obviously neotest is available to the neovim context since it is the thing invoking the require for itself. I'm not sure where to go from this. This all started after an upgrade of neotest which had the nio update.

ERROR | 2024-04-23T15:51:23Z-0500 | ...an/.repro/plugins/neotest/lua/neotest/lib/subprocess.lua:76 | Failed to initialize child process Vim:Error invoking 'nvim_exec_lua' on channel 3:
Error executing lua: [string "<nvim>"]:1: module 'neotest' not found:
	no field package.preload['neotest']
	no file './neotest.lua'
	no file '/opt/homebrew/share/luajit-2.1/neotest.lua'
	no file '/usr/local/share/lua/5.1/neotest.lua'
	no file '/usr/local/share/lua/5.1/neotest/init.lua'
	no file '/opt/homebrew/share/lua/5.1/neotest.lua'
	no file '/opt/homebrew/share/lua/5.1/neotest/init.lua'
	no file './neotest.so'
	no file '/usr/local/lib/lua/5.1/neotest.so'
	no file '/opt/homebrew/lib/lua/5.1/neotest.so'
	no file '/usr/local/lib/lua/5.1/loadall.so'
stack traceback:
	[C]: in function 'require'
	[string "<nvim>"]:1: in main chunk
stack traceback:
	[C]: in function 'rpcrequest'
	...an/.repro/plugins/neotest/lua/neotest/lib/subprocess.lua:61: in function <...an/.repro/plugins/neotest/lua/neotest/lib/subprocess.lua:54>
	[C]: in function 'xpcall'
	...an/.repro/plugins/neotest/lua/neotest/lib/subprocess.lua:54: in function 'init'
	...ffman/.repro/plugins/neotest/lua/neotest/client/init.lua:374: in function '_start'
	...ffman/.repro/plugins/neotest/lua/neotest/client/init.lua:188: in function '_ensure_started'
	...ffman/.repro/plugins/neotest/lua/neotest/client/init.lua:200: in function <...ffman/.repro/plugins/neotest/lua/neotest/client/init.lua:199>
	...man/.repro/plugins/neotest/lua/neotest/consumers/run.lua:38: in function 'get_tree_from_args'
	...man/.repro/plugins/neotest/lua/neotest/consumers/run.lua:68: in function 'func'
	...stopherhoffman/.repro/plugins/nvim-nio/lua/nio/tasks.lua:168: in function <...stopherhoffman/.repro/plugins/nvim-nio/lua/nio/tasks.lua:167>

I was able to come back and spend some time on this. Digging through the code a bit, it looks like the suggested config for enabling the more detailed logging was wrong.
"nvim-neotest/neotest",
-- other key/vals ...
opts = {
  level = vim.log.levels.DEBUG,
  adapters = {
    ["neotest-go"] = {
      -- Here we can set options for neotest-go, e.g.
      -- args = { "-tags=integration" }
      recursive_run = true,
    },
  },
},

needed to be
"nvim-neotest/neotest",
-- other key/vals ...
opts = {
  log_level = vim.log.levels.DEBUG,
  adapters = {
    ["neotest-go"] = {
      -- Here we can set options for neotest-go, e.g.
      -- args = { "-tags=integration" }
      recursive_run = true,
    },
  },
},

After adjusting this I do see more details, but they really are not anything more enlightening than what the original logs contained. For some reason the spawned nvim subprocess isn't not getting the lua module paths setup correctly and is not able to load neotest in the subprocess neovim editor. I'll be trying to look at this more, but I haven't changed anything about this unless lazy.nvim is somehow broken in subprocess neovim.

After getting dead ended at the rpcrequest failure to load neotest module, I decided that it maybe has something to do with the reproduction config and launching neovim with the explicit config file. Sure enough that appears to have been the problem with the reproduction config. One of the things I did trying to get this working did fix the problem in my main configuration. The main configuration has been unchanged since this problem began.
I believe this was caused by Homebrew actually. I encountered a problem trying to install neovim HEAD with homebrew where the compile couldn't find the lpeg library even though Homebrew is managing the library and explicitly setting it for the compile. After a bit of searching for why, I stumbled upon this comment which advice from another thread to try reinstalling lpeg from Homebrew.
Running brew reinstlal lpeg and having it rewrite the bottle and the compile succeeded. This is basically the only tooling change that actually happened. I didn't even remove and reinstall the stable neovim. It seems this all came down to an errant issue with Homebrew and managing the lpeg linkage. I'm a bit puzzled why nothing spit out library load failures, but testing is working again. It seems the upgrade to neotest was just coicidental to probably a closely timed upgrade in Homebrew.


create React native CLI and cocopods

Description
I am trying to setup the environment for starting using react native cli and when being install cocopods dependencies i got this error message.
✔ Downloading template
✔ Copying template
✔ Processing template
✔ Installing Ruby Gems
✖ Installing CocoaPods dependencies (this may take a few minutes)
error Framework build type is static library
[Codegen] Generating ./build/generated/ios/React-Codegen.podspec.json
Analyzing dependencies
Fetching podspec for `DoubleConversion` from `../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec`
[Codegen] Found FBReactNativeSpec
Fetching podspec for `RCT-Folly` from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec`
[Codegen] Found rncore
Fetching podspec for `boost` from `../node_modules/react-native/third-party-podspecs/boost.podspec`
Fetching podspec for `glog` from `../node_modules/react-native/third-party-podspecs/glog.podspec`
Fetching podspec for `hermes-engine` from `../node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec`
[Hermes] Using the release tarball from Maven Central
[!] CDN: trunk Repo update failed - 2 error(s):
CDN: trunk URL couldn't be downloaded: https://cdn.jsdelivr.net/cocoa/Specs/0/9/9/libevent/2.1.11/libevent.podspec.json Response: SSL connect error
CDN: trunk URL couldn't be downloaded: https://cdn.jsdelivr.net/cocoa/Specs/0/9/9/libevent/2.1.12/libevent.podspec.json Response: SSL connect error
✖ Installing CocoaPods dependencies (this may take a few minutes)
error Looks like your iOS environment is not properly set. Please go to https://reactnative.dev/docs/environment-setup?os=macos&platform=android and follow the React Native CLI QuickStart guide for macOS and iOS.
info Run CLI with --verbose flag for more details.

React Native Version
0.72.4
Output of npx react-native info
✔ Downloading template
✔ Copying template
✔ Processing template
✔ Installing Ruby Gems
✖ Installing CocoaPods dependencies (this may take a few minutes)
error Framework build type is static library
[Codegen] Generating ./build/generated/ios/React-Codegen.podspec.json
Analyzing dependencies
Fetching podspec for `DoubleConversion` from `../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec`
[Codegen] Found FBReactNativeSpec
Fetching podspec for `RCT-Folly` from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec`
[Codegen] Found rncore
Fetching podspec for `boost` from `../node_modules/react-native/third-party-podspecs/boost.podspec`
Fetching podspec for `glog` from `../node_modules/react-native/third-party-podspecs/glog.podspec`
Fetching podspec for `hermes-engine` from `../node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec`
[Hermes] Using the release tarball from Maven Central
[!] CDN: trunk Repo update failed - 2 error(s):
CDN: trunk URL couldn't be downloaded: https://cdn.jsdelivr.net/cocoa/Specs/0/9/9/libevent/2.1.11/libevent.podspec.json Response: SSL connect error
CDN: trunk URL couldn't be downloaded: https://cdn.jsdelivr.net/cocoa/Specs/0/9/9/libevent/2.1.12/libevent.podspec.json Response: SSL connect error
✖ Installing CocoaPods dependencies (this may take a few minutes)
error Looks like your iOS environment is not properly set. Please go to https://reactnative.dev/docs/environment-setup?os=macos&platform=android and follow the React Native CLI QuickStart guide for macOS and iOS.
info Run CLI with --verbose flag for more details.

Steps to reproduce

install homebrew
install node js v 20
install watchman
install ruby 3.2.1
install cocopods 1.13
init react-native application

Snack, screenshot, or link to a repository
https://snack.expo.dev/9L00P7K0-

Issues against the CLI should be opened on
https://github.com/react-native-community/cli/issues

CDN: trunk URL couldn't be downloaded: https://cdn.jsdelivr.net/cocoa/Specs/0/9/9/libevent/2.1.11/libevent.podspec.json Response: SSL connect error

This specific issue is related to your local setup. You either have a proxy that is blocking you, the time in your system is wrong, or you have a wrong root certificate installed.

It's working now. I think that the issue on IPS Egypt with CDN jsdelivr was Blocked. then I opened the VPN and re-installed the dependencies.
Thanks


docs: customize envoyproxy dualstack

docs: customize envoyproxy dualstack
What's Changed

Added documentation for customizing EnvoyProxy IP family configuration
Added note about cluster requirements for DualStack networking

thanks @juwon8891, added a comment
can you also update the same doc in v1.2/ and latest/

@juwon8891 can you address the CI failures

@juwon8891 can you address the CI failures

I resolved problem!


[Accessibility Labels] Localise accessibility labels and update texts accordingly.

Details

We currently only translate some accessibilityLabels and accessibilityHints in the App. This is due to us using them to query particular elements in automated testing. With this PR, those texts are localized according to user language and the tests make use of the translateLocal function to get the text value for anchoring to elements.
Fixed Issues

$ https://github.com/Expensify/App/issues/14763
PROPOSAL: https://github.com/Expensify/App/issues/14763#issuecomment-1480239853
Tests

For tests:

Run npm test locally.
Ensure all test cases pass.

Since the tests are working properly, it is implied implicitly that the accessibility labels are translated properly on the app as well. So no need to verify each and every label.

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Same as above.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: https://expensify.slack.com/archives/C01GTK53T8Q/p1679927477520439

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos
Since we're only adding a translation function to the existing values and not any text visible directly on the app and the tests are working properly, I believe that videos for the same are not required. Let me know if you disagree.

@dangrous @parasharrajat One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Ah okay cool. I think we should go ahead and remove those accessibilityHints from the icons - since a hint is described as An accessibility hint helps users understand what will happen when they perform an action on the accessibility element when that result is not clear from the accessibility label. in the react native docs, it doesn't make sense to me to say the name of the icon, which doesn't add any information.
If that breaks any tests, let me know; we can probably figure out how to re-identify those elements...

What do you think about using this? Is that easy? (I haven't done much with E2E tests before)
Though I'm wondering - if we use that here, should we use it for all of the other tests too?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/dangrous in version: 1.2.91-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.91-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Mouse Without Borders: support send ctrl+alt+delete to windows server

Description of the new feature / enhancement
support send ctrl+alt+delete to windows server when server screen locked.
Scenario when this would be used?
target server machine's screen locked.
Supporting information
No response

Is there a solution for this? I need to send Ctrl+Alt+Delete to unlock the login screen on one of my hosts.


Empty lines are collapsed inside list items

This input:
 * Foo

    ~~~ c
    Line 1

    Line 2
    ~~~

 * Bar

Gets rendered to:

Foo
Line 1

Line 2

Bar

Notice how the two empty lines inside the codeblock have been collapsed to one. This can be irritant especially with codeblocks.
This is because Hoedown collapses multiple empty lines when collecting a listitem's nested content. I don't know why this is done. Would there be any side effects if we made it keep empty lines?

New code doesn't present this problem.


Allow for lazy initialization

recalculate always causes a reflow. In complex DOM environments, this reflow can be very expensive and delays the initial render of the content.
Introduce an option lazyInitialization, which delays the adding of listeners until the next idle callback (or next tick if the browser does not support requestIdleCallback). This optimizes the first paint experience
See #371

Thanks for this.
What would be the drawbacks of using this option? I suppose you could experience a flash between before/after SimpleBar has finished initialising?

I actually did not notice any UI flash with this option, even when bumping up the delay to 5000ms to make it really apparent. I can play around with it some more in other environments

I'm asking this because if there is no drawback, then I don't see a reason to have this as an option and this could be enabled by default.
However if in some scenarios this can have undesired effects yes this makes sense to be an option.
I think if you see a flash that would be on an environment where you don't have floating scrollback (so not on mac OS with floating scrollbars enabled or on mobile devices).

@Grsmto There is some flashing on Windows. I moved the hideNativeScrollbars function outside of the delay. This shouldn't force reflow because we are only writing properties in this function

I think we should leave it as an option for now in case it breaks someone later. There are a lot of edge cases that I may not have seen


Rule Proposal: prefer-pure-render-mixin

I didn't see anything like this already, but I think it would be very useful. I'll write the rule doc here as an explanation.
Rule Details
The following patterns are considered warnings
var Hello = React.createClass({
  render: function() {
    return
Hello {this.props.name}
;
  }
});

The following patterns are not considered warnings
import PureRenderMixin from 'react-addons-pure-render-mixin';
var Hello = React.createClass({
  mixins : [PureRenderMixin],
  render: function() {
    return
Hello {this.props.name}
;
  }
});

// Backwards compatible with pre 0.14 React versions
var PureRenderMixin = require('react').addons.PureRenderMixin;
var Hello = React.createClass({
  mixins : [PureRenderMixin],
  render: function() {
    return
Hello {this.props.name}
;
  }
});

It is probably possible to do something more intelligent than just checking for the presence of the mixin, but it would guarantee that anyone checking in components without the mixin would at least break the build.

Duplicate of #240

Duplicate, as said by @Daniel15 :)


Container shadow cause performance issues

If there is a Container widget with boxShadow in the Listview, the Listview will drop frames when rendering the Container. This problem will only occur when the application page is run for the first time
Flutter Doctor:
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 2.8.1, on Microsoft Windows [Version 10.0.16299.15], locale zh-CN)
[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[√] Chrome - develop for the web
[√] Android Studio (version 2020.3)
[√] VS Code (version 1.63.2)
[√] Connected device (2 available)

• No issues found!

This problem is probably related to blurRadius. When I remove this attribute, the listview becomes smooth

Hi @rs5173
Can you please provide your flutter doctor -v and a minimal complete reproducible code sample?
Thank you

I tried to reproduce this problem through a simple Demo, but I found that if the UI is simple, this problem will not appear. So I uploaded a more complicated demo. The test device I used is Pixel 2xl. When the application is run for the first time, when the listview slides to a widget with a shadow effect, the UI will have very obvious frame drop. After that, run the application again. No frame drop
demo.zip

I tried to reproduce this problem through a simple Demo, but I found that if the UI is simple, this problem will not appear. So I uploaded a more complicated demo. The test device I used is Pixel 2xl. When the application is run for the first time, when the listview slides to a widget with a shadow effect, the UI will have very obvious frame drop. After that, run the application again. No frame drop
demo.zip

flutter doctor -v
[√] Flutter (Channel stable, 2.8.1, on Microsoft Windows [Version 10.0.19043.985], locale zh-CN)
    • Flutter version 2.8.1 at D:\FlutterSDK
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 77d935af4d (2 weeks ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at D:\AndroidSDK
    • Platform android-31, build-tools 30.0.2
    • Java binary at: D:\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 2020.3)
    • Android Studio at D:\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[√] IntelliJ IDEA Community Edition (version 2020.1)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2020.1.2
    • Flutter plugin version 46.0.3
    • Dart plugin version 201.7846.93

[√] VS Code
    • VS Code at C:\Users\Administrator\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.25.0

[√] Connected device (3 available)
    • Pixel 2 XL (mobile) • 805KPBF1850805 • android-arm64  • Android 11 (API 30)
    • Chrome (web)        • chrome         • web-javascript • Google Chrome 92.0.4515.107
    • Edge (web)          • edge           • web-javascript • Microsoft Edge 91.0.864.48

• No issues found!

flutter doctor -v
[√] Flutter (Channel stable, 2.8.1, on Microsoft Windows [Version 10.0.19043.985], locale zh-CN)
    • Flutter version 2.8.1 at D:\FlutterSDK
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 77d935af4d (2 weeks ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at D:\AndroidSDK
    • Platform android-31, build-tools 30.0.2
    • Java binary at: D:\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 2020.3)
    • Android Studio at D:\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[√] IntelliJ IDEA Community Edition (version 2020.1)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2020.1.2
    • Flutter plugin version 46.0.3
    • Dart plugin version 201.7846.93

[√] VS Code
    • VS Code at C:\Users\Administrator\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.25.0

[√] Connected device (3 available)
    • Pixel 2 XL (mobile) • 805KPBF1850805 • android-arm64  • Android 11 (API 30)
    • Chrome (web)        • chrome         • web-javascript • Google Chrome 92.0.4515.107
    • Edge (web)          • edge           • web-javascript • Microsoft Edge 91.0.864.48

• No issues found!

Hi @rs5173, could you please specify the changes I need to make in the demo project shared above inorder to see the difference in performance?

In the product_list.dart file, delete the blurRadius attribute in the _Product and _MoreProduct Widget. After reinstalling, run the application for the first time, and the listview will not drop frames

Thanks for the info @rs5173, When I run your app for first time with no changes (with blurRadius), I don't see any frame drops the app is running consistently at 60 fps verified on Xiaomi k20 pro (Android 11), Can you some a video recording of the frame drops that you are seeing along with the timeline trace?  Please follow this guide to proceed.
Also, would it be possible for you to verify it on another device to make sure this is not something device-specific?

flutter doctor -v
mahesh@Maheshs-MacBook-Air-M1 demo % flutter doctor -v
[✓] Flutter (Channel stable, 2.8.1, on macOS 12.1 21C52 darwin-arm, locale en-GB)
    • Flutter version 2.8.1 at /Users/mahesh/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 77d935af4d (3 weeks ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 60.1.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.63.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.32.0

[✓] Connected device (4 available)
    • Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555                     • android-arm64  • Android 11 (API 30)
    • iPhone 13 Pro (mobile) • 0FA2FB93-2A89-4FDB-8293-DF66188F1E54 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-0 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.1 21C52 darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 96.0.4664.110

• No issues found!


Move to rubocop-hq?

I've recently created https://github.com/rubocop-hq to serve as the new home of RuboCop and related projects. I'd love to see guard-rubocop live under the same organization as RuboCop itself.
You're an owner there, so if you like the idea you can just handle the move yourself.

@yujinakayama Thank you for transferring the repository to https://github.com/rubocop-hq!


Customise EBS volume size between environments

We needed to increase the volume size in production as part of the Aptly migration.
Aptly has more packages in Carrenza than in AWS and required a larger EBS volume to achieve feature parity.

@sarahseewhy I see you're also seeing a fail around docs. I'm just working on fixing this at the mo thought I'd let you know in case you are too. Feel free to ping me if you want to collaborate on it.

@kevindew cheers! It was also my mistake –– I forgot to run the automatic generate terraform docs script. I'll fix it now.