Initial set of Charts to deploy the Alvearie Clinical Ingestion Pattern

This commit includes an initial set of charts to deploy the Alvearie
Clinical Ingestion pattern.
There is a main chart that deploys the whole framework (including its
components) and an extra couple of charts used to deploy IBM FHIR and a
NiFi Registry backed by a Github repository.
The Alvearie Clinical Ingestion pattern chart deploys the following
related services:

IBM FHIR: A FHIR server to store medical data
Kafka: For clinical ingestion messaging
NiFi: To deploy the ingestion flows
NiFi Registry: To deliver the ingestion flows to be used in NiFi
Zookeeper: Dependency needed by Kafka & NiFi

The corresponding documentation with instructions is included.
The added documentation pages are pretty standalone. There is a sentence
reference in the main clinical-ingestion/README.md that leaves the
existing instructions as-is for those who may already have the service
dependencies, and introduces and references the Helm Chart for those who
don't.

README for nifi-registry and fhir both have copy/paste references
nifi-registry has:
Install the helm chart with a release name fhir:
and
To uninstall/delete the ingestion deployment:
fhir just has the reference to 'ingestion' in the uninstall text

Good catch, fixed both - thanks!

Overall looks great, most of my comments are nits or questions. A few important comments though.

Thanks..

Two comments I can't add in-line:
1. What are the tgz files? Are they static versions of fhir/kafka/nifi/nifi-registry/zookeeper that will need upkeep? Is there any way to pull them on-demand instead of ship them?

Those are the chart's dependencies, some exist in external chart repositories, but the ones we created here don't yet, so I am including all here in an effort to save that download step. We could eventually push our charts to some repo and have them all be downloaded, but I don't see us changing them too often, so maybe we could continue including them.

2. The last image (nifi-import-latest.png) ideally should be updated to show the official Registry/Bucket/Flow Name, once those exist. (This is my concern with relying on screen caps)

Yeah, I actually have that in my TODOs for once we have that out there. I added that pic there temporarily to give a feeling for what it would look like. I think once you push the flows out there and we screenshot the right bucket/flow names (and with the wording select the latest version) I don't see that changing very often, hence the concern for using screen caps should be minimized, and I think it provides good value.


Defective implicit children codemod

Sebastian,
The implicit children codemod has the following defects . Any workarounds you can suggest ?

We have a repo with 1000's of components . The codemod adds children to all components whether it should really have children or not . We have only 10% of the components in our repo with children and 90% without any children.

Our codebase still heavily uses class components whereas the codemod works only for functional components

The codemod adds children to all components whether it should really have children or not .

The codemod is intended to ease migration, not for correctness. If you want to stop relying on implicit, children, do not use this codemod.

Our codebase still heavily uses class components whereas the codemod works only for functional components

Class components did not have implicit children


How to install boarding into Ubuntu Server 14.04 without Heroku?

Please write some install info with Ubuntu Server in Readme.md ,
Thank you.

I can't give any instructions on that, basically you need a standard Rails setup without a database or anything special.


Landmarks location on face / map of landmarks

Congratulations on your great work and thanks for sharing it.
Is there any reference to the location of the landmarks on face (or a map of the landmarks) generated with dense_flag = True (the estimated 38k points)?
Something like dlib in this image? https://pyimagesearch.com/wp-content/uploads/2017/04/facial_landmarks_68markup.jpg
When dense_flag = False, the location of the points is the same as the dlib, right?
I appreciate the attention.

With dense_flag = False, the outputted 68 landmarks ought to be consistent with Dlib.

With dense_flag = False, the outputted 68 landmarks ought to be consistent with Dlib.

When dense_flag = False, the location of the points is the same as the dlib, right?

I'd like only to point out that the orientations x and y axis of the point clouds produced by 3DDFA are reversed, so you might need to keep that in mind to avoid inconsistencies1.
1 I've only verified this statement for the 68 landmarks, therefore I'm not sure about the other output types

Here's what I figured out. 3DDFA uses an orthographic camera model (source: 3DDFA paper, equation 4)(see last section of these notes). So the transformation steps from a 3d mesh in BFM's system of coordinates should be the following:

3d rototranslation to allow for pose
orthographic projection
scaling (used to allow for apparent size change due to prospective, that the orthographic projection can't account for)
transformation to image coordinates (array convention). This involves:

inverting the y axis
scaling everything by the spatial resolution of the sensor
translating both x and y by half the image size so that the origin is in the upper left corner

The relevant sections of the code seem to be TDDFA.recon_verts() and similar_transform(). It seems that the scaling is done not with respect to the image size, but to the bounding box size. Moreover, the z axis is scaled by the average of the scale factors used of the x and y axis.
However, I'm not sure of my conclusions and it's not clear to me why the scaling is done in this manner.
Finally, even though I did my fair share of digging into the code, I wasn't able to figure out the following:

are images rescaled before being fed into TDDFA?
what are the assumed physical and pixel sizes of the image sensor?

It's not much, admittedly, but hopefully this can help you get a better grip on this paper😉

Hello! I have some question about the z axis. I'd like to know does the Z coordinate represent the depth information of the landmarks?
Looking forward to your reply!

With dense_flag = False, the outputted 68 landmarks ought to be consistent with Dlib.

Hi, how can i get 68 landmarks?

Congratulations on your great work and thanks for sharing it.
Is there any reference to the location of the landmarks on face (or a map of the landmarks) generated with dense_flag = True (the estimated 38k points)?
Something like dlib in this image? https://pyimagesearch.com/wp-content/uploads/2017/04/facial_landmarks_68markup.jpg
When dense_flag = False, the location of the points is the same as the dlib, right?
I appreciate the attention.

Hi, could you tell me how can i get 68 landmarks?

I want to get dense landmarks location of a particular facial region example chin region? For this I think I need mapping information but I dont see any, is there any mapping information there for this?


Calling a function inside a query results after many calls in a memory leak

Inside the following example I have a function call GetHours to C# code. The tQuery is a EF query.
When running this continuously the memory keeps growing. When removing the GetHours the memory usage stays the same.
return (from q in tQuery 		select new ModelX() 		{ 			Guid = q.Guid, 			LastRun = q.LastRun, 			LastCompleted = q.LastCompleted, 			Hours = this.GetHours(q.LastCompleted) 		}).ToList();

Duplicate of #13048


IPython console: 'cls' and 'clear' magic commands are not working

From<EMAIL_ADDRESS>on 2010-12-27T17:38:41Z
What steps will reproduce the problem?

Open the basic spyder console
Try to use the clear and cls commands in the interpertor.
The esc key doesn't clear the line either. What is the expected output? What do you see instead? I would expect for the clear command to clear the specified data, for the cls command to clear the shell, and for esc to clear the line. However, esc does nothing and a NameError exception is generated for cls and clear. What version of the product are you using? On what operating system? Spyder 2.05
Windows XP
Pythonxy <IP_ADDRESS>

Original issue: http://code.google.com/p/spyderlib/issues/detail?id=513

From<EMAIL_ADDRESS>on 2010-12-27T14:41:27Z
However, the commands all work in the context menus.

From pierre.raybaut on 2011-04-24T07:38:09Z
This issue was closed by revision 5caf333cb9e6 .

From pierre.raybaut on 2011-01-07T08:44:31Z
'cls' and 'clear' are IPython magic commands so they are not expected to be recognized in a standard Python interpreter. However the 'cls' magic command was not working even in an IPython interpreter, hence the new Issue title (it was printing an unknown character - line feed - instead of actually clearing the console).
Regarding the Esc shortcut, there is nothing standard about it and the Spyder's shortcut for clearing the current line is Shift+Esc.
Summary: IPython console: 'cls' and 'clear' magic commands are not working
Status: Accepted
Owner: pierre.raybaut

From pierre.raybaut on 2011-01-07T11:05:40Z
This issue was closed by revision 5caf333cb9 .
Status: Fixed


Add IT_CERT_LINUX type to bundle spec

Similar to the CLOUD_TERMINAL resource, but there are no permissions that need to be set so there are no required attributes.

Per offline discussion, we will only be documenting this internally, so it does not make sense to publish it to the public spec.


Support for a-animation component in A-Frame

Currently, attempting to change the active clip using a-animation in a-frame causes gltf2 models to revert to the TPose. It would be wonderful if we could do this:
<a-animation>              attribute="animation-mixer"              to="clip: newClip; loop: newLoopValue; crossFadeDuration: newDuration: etc."              begin= "namedEmit"  </a-animation>

I'm not sure what <a-animation/> does with strings, it's more for tweening...
Have you tried using event-set?
<a-entity animation-mixer event-set__click="animation-mixer.clip: run"></a-entity>

I'm not sure I understand the issue what you're describing. Are you saying you see the TPose between when the walking clip ends and the idle clip begins? or the model goes to TPose after the idle clip ends, and you want it to freeze in the last frame of the idle clip? could you describe the behavior you get, and the behavior you want, and/or create a demo?

between the two animations

https://socialvr.vreen.live/dev
if you open two instances and walk around you see the tpose

if its needed i can make a smaller example

Having a difficult time loading that example, yeah something simpler would be best. Here's one I've made, cycling between idle and run animations:
https://aframe-animation-crossfade-yxktsdzbpn.now.sh/
Note that I'm setting a bit of a crossfade on the two clips:

<a-entity position="0 1 0"
  animation-mixer="clip: Idle; crossFadeDuration: 0.5;"
  gltf-model="src: url(xbot.gltf);">
  </a-entity>

If you have no crossfade, it's possible you'll see the T-Pose between clips, probably depending on how the model is keyframed...  my model here does have a T-Pose, but it's not shown between clips. Hopefully that example is enough to help but feel free to add details if not!

awesome the crossFadeDuration: 0.5 fixed it for me!
thx a lot!


Update README for tented case

The current README indicates the middle, bottom and switch layers  for a case.  Yet, there is a tented version, which when I enter in the Sculpteo  site, indicates  slightly  different dimensions than what the info  says. I assume  its right  since I can not adjust the  2nd dimension as  it auto-adjusts when I enter the 153.7 dimension data  in.
It is not clear if the top layer is ALSO needed, or it that is only for the TENTED version middle layer.

Done


 Here, we expose field values too. The result looks like:
parameter logic [11:0] AES_CTRL_SHADOWED_RESVAL = 12'h c0;
parameter logic [5:0] AES_CTRL_SHADOWED_MODE_RESVAL = 6'h 20;
parameter logic [2:0] AES_CTRL_SHADOWED_KEY_LEN_RESVAL = 3'h 1;
parameter logic [0:0] AES_CTRL_SHADOWED_FORCE_ZERO_MASKS_RESVAL = 1'h 0;

Here, AES_CTRL_SHADOWED is a hwext register, which has fields MODE,
KEY_LEN and FORCE_ZERO.

@Jacob-Levy: I think this is what you need?

Looks good now!
Will remove my temp pkg file and rename to _RESVAL.


Text and argv handling

What was added:

help message - if argv is help or something else or even nothing you will got help message
text handling - only chars in base29 table are acceptable, other chars are deleted, '\n' become a space
text file opening - now you can open file with text within and search this text in Library
README.md editing - for obvious reasons

Thanks a lot for this! I made some comments on your commits, and once we discuss/resolve those, I plan to merge this in.

Thanks for fast answer! I'll change something according to your comments and add some other things of mine.
PS I kind of not related to github specific, if I'll commit something new it be needed to do new pull request or not?

New commits will be included in the current pull request. The pull request
is for that entire branch, so not just for state of the branch when you
made it in the past.
On Mon, Jun 20, 2016 at 12:37 PM Wisketchy Dobrov<EMAIL_ADDRESS>wrote:

Thanks for fast answer! I'll change something according to your comments
and add some other things of mine.
PS I kind of not related to github specific, if I'll commit something new
it be needed to do new pull request or not?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/cakenggt/Library-Of-Pybel/pull/2#issuecomment-227197008,
or mute the thread
https://github.com/notifications/unsubscribe/ABWEjdnMmKr0IY7lwIfNgUHR3fv8E0biks5qNsHKgaJpZM4I5Kby
.

Nice!
Well, there are changings.

Typo in the commit name, meh.
Here it is, brand new main()

Great :3


SyntaxError: Non-ASCII character '\xc2' on line 165

Hi!
I am receiving an error when trying to run the script.
File "tiktok-bot.py", line 164
SyntaxError: Non-ASCII character '\xc2' in file tiktok-bot.py on line 165, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details
Any help is appreciated!

Hello! Here's an easy fix for your problem : open the script in a text editor, and on line 164, delete the copyright icon and save the file. Now run the script, it should work. Try it and let me know!


Allow to enforceEx making partial instantiated alias

I've got an idea from https://github.com/D-Programming-Language/phobos/pull/298#issuecomment-3602761 .
enforceEx!SomeException is a little long than the frequency of its use.
This change allows to make alias enforceEx!SomeException enf; and to use enf(condition, "message");.

Merged.


Add a callback to subscribe and unsubscribe with response

It would be useful to have a callback or promise with the result of subscribe/unsubscribe action... can it be added?

native library doesn't provide me callback, so assume it is successful all the time..

That's what i'm going to do :)


SSLError: hostname "xyz.com" doesn't match either of '*.abc.com' error in 0.4.5 version

I am getting SSLError: hostname ... doesn't match either of ... error when verify=False provided in "Create Session" keyword.
This is working perfectly in 0.3.8 version.

Thank you, could you provide a sample testcase and stack trace, of this issur, this will give an idea how to debug further

@chetand24 Any updates?

This is something to do with certificate not proper or not available in server for host.
Create Session    ${SERVICE_NAME}    ${REQUEST_HOST}    verify=${verify_certificate}     auth=${auth}
If certificate is having any issue in server I provided "verify=False" which was working fine in 0.3.8 but when I switch to 0.4.5 I am getting error.

Did you verified ${verify_certificate} having boolean values?
If any issues with server with it return ${true} or ${false}?

@chetand24 any updates


Force async routes

Libraries like prisma may extend the promise return type, e.g PrismaPromise and it cannot be unwrapped into a real promise, making the return type incorrect.

This could also be resolved by correctly unwrapping every T extends Promise type inside ts-json-schema-generator. Probably a fix there would be a better idea.

Tests with a fully syncrhonous route is necessary because sync handlers require done() call


feat(publishing): add documentation about publishing

Added documentation about publishing based on personal experience

Codecov Report

Merging #525 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #525   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          55     55
  Lines         569    569
=====================================
  Hits          569    569

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 162128a...4590cb1. Read the comment docs.


[test-framework] Adding support for component dependencies

Added Component interface, which is now implemented by all components

Separate component registries for local and kubernetes

Updated the dependency Tracker to initialize all dependencies of
a component before initializing the component, itself.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nmittler
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nmittler, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fix ZwiftApp process detection loop

Since the 1.1.11 launcher update or 1.56 game update, the entrypoint script loops waiting for ZwiftApp.exe to be started.
It used to work but for some reason it doesn't anymore.
I could reproduce the issue locally as well as with the netbrain/zwift image.
Using pgrep -f finds the process correctly now.

Good job 👍


async_mode error running digits-devserver

Hello -- I've researched related issues and posts related to the below error.  In particular, I have run sudo pip install -r requirements.txt, but the error persists.
I'm running digits 5.1-dev on Ubuntu14.04 and Caffe 0.15.3.
Error message:
sudo ./digits-devserver
  ___ ___ ___ ___ _____ ___
 |   \_ _/ __|_ _|_   _/ __|
 | |) | | (_ || |  | | \__ \
 |___/___\___|___| |_| |___/ 5.1-dev

Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/home/exx/12TB/image_recognition/DIGITS/digits/__main__.py", line 66, in <module>
    main()
  File "/home/exx/12TB/image_recognition/DIGITS/digits/__main__.py", line 51, in main
    import digits.webapp
  File "digits/webapp.py", line 25, in <module>
    socketio = SocketIO(app, async_mode='gevent')
TypeError: __init__() got an unexpected keyword argument 'async_mode'
Exception KeyError: KeyError(139774545760816,) in <module 'threading' from '/usr/lib/python2.7/threading.pyc'> ignored

You need to install the requirements :
pip install -r requirements.txt

Yes, I have done that (please see my issue description), and requirements installed successfully, but the error persists.

It might be a conflict between certain versions of packages. Flask and gevent ?

This looks problematic:
Found existing installation: Flask-SocketIO 0.6.0
    Not uninstalling Flask-SocketIO at /usr/lib/python2.7/dist-packages, owned by OS
  Running setup.py install for Flask-SocketIO

Which installation of Flask-SocketIO are you picking up?
# mine comes from /usr/lib/
$ python -c 'import flask_socketio; print flask_socketio.__file__'
/usr/lib/python2.7/dist-packages/flask_socketio/__init__.pyc

# which is provided by a deb package
$ dpkg -S /usr/lib/python2.7/dist-packages/flask_socketio
python-flaskext.socketio: /usr/lib/python2.7/dist-packages/flask_socketio

# and my installed version is 2.6
$ apt-cache policy python-flaskext.socketio
python-flaskext.socketio:
  Installed: 2.6-1ppa1
  Candidate: 2.6-1ppa1
  Version table:
 *** 2.6-1ppa1 500
        500 http://ppa.launchpad.net/luke-yeager/digits/ubuntu xenial/main amd64 Packages
        500 http://ppa.launchpad.net/luke-yeager/digits/ubuntu xenial/main i386 Packages
        100 /var/lib/dpkg/status
     2.6-1 500
        500 file:/usr/local/repo ./ Packages
        500 http://sqrl.nvidia.com/data/repos/machine-learning.debian/xenial/7.0-devel+cuda8.0  Packages

Thanks for your prompt replies!
@LucMioulet:  When I tried sudo pip uninstall flask or sudo pip uninstall gevent, It fails with Not uninstalling Flask at /usr/lib/python2.7/dist-packages, owned by OS.  Not sure how to proceed there.
@lukeyeager:  I have identical outputs for your first two commands, but the third reveals an older version:
apt-cache policy python-flaskext.socketio
python-flaskext.socketio:
  Installed: 0.6.0-2
  Candidate: 0.6.0-2
  Version table:
 *** 0.6.0-2 0
        100 /var/lib/dpkg/status

It looks like the problem is not being able to uninstall the older version of flask.

Here's what I'd do:
sudo apt-get install virtualenv

# create a venv that can use python packages installed with apt-get
virtualenv --system-site-packages venv

# activate the venv
source venv/bin/activate

# try installing the requirements again
pip install -r requirements.txt

I think that will let you install the newer version of Flask-SocketIO into your virtual environment.
Otherwise, you can remove the flask-socketio deb package (note: this will probably force the removal of your old digits package, too):
sudo apt-get remove python-flaskext.socketio

@lukeyeager:  The first strategy did not successfully uninstall flask-socket-io, but I am now in a virtualenv.  The second strategy ran successfully, and when I reran sudo pip install -r requirements.txt, I have the following output:
sudo pip install -r requirements.txt
Requirement already satisfied (use --upgrade to upgrade): Pillow>=2.3.0,<=3.1.2 in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 1))
Requirement already satisfied (use --upgrade to upgrade): numpy>=1.8.1,<=1.11.0 in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 2))
Requirement already satisfied (use --upgrade to upgrade): scipy>=0.13.3,<=0.17.0 in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 3))
Requirement already satisfied (use --upgrade to upgrade): protobuf>=2.5.0,<=2.6.1 in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 4))
Requirement already satisfied (use --upgrade to upgrade): six>=1.5.2,<=1.10.0 in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 5))
Requirement already satisfied (use --upgrade to upgrade): requests>=2.2.1,<=2.9.1 in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 6))
Requirement already satisfied (use --upgrade to upgrade): gevent>=1.0,<=1.1.0 in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 7))
Requirement already satisfied (use --upgrade to upgrade): gevent-websocket==0.9.3 in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 8))
Requirement already satisfied (use --upgrade to upgrade): Flask==0.10.1 in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 9))
Requirement already satisfied (use --upgrade to upgrade): Flask-WTF>=0.11,<=0.12 in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 10))
Requirement already satisfied (use --upgrade to upgrade): wtforms>=2.0,<=2.1 in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 11))
Requirement already satisfied (use --upgrade to upgrade): Flask-SocketIO==2.6 in /usr/local/lib/python2.7/dist-packages (from -r requirements.txt (line 12))
Requirement already satisfied (use --upgrade to upgrade): setuptools>=3.3,<=20.7.0 in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 13))
Requirement already satisfied (use --upgrade to upgrade): lmdb==0.87 in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 14))
Requirement already satisfied (use --upgrade to upgrade): h5py>=2.2.1,<=2.6.0 in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 15))
Requirement already satisfied (use --upgrade to upgrade): pydot>=1.0.28,<=1.0.29 in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 16))
Requirement already satisfied (use --upgrade to upgrade): psutil>=1.2.1,<=3.4.2 in /usr/local/lib/python2.7/dist-packages (from -r requirements.txt (line 17))
Requirement already satisfied (use --upgrade to upgrade): matplotlib>=1.3.1,<=1.5.1 in /usr/lib/pymodules/python2.7 (from -r requirements.txt (line 18))
Requirement already satisfied (use --upgrade to upgrade): scikit-fmm>=0.0.9 in /usr/local/lib/python2.7/dist-packages (from -r requirements.txt (line 19))
Requirement already satisfied (use --upgrade to upgrade): Werkzeug>=0.7 in /usr/lib/python2.7/dist-packages (from Flask==0.10.1->-r requirements.txt (line 9))
Requirement already satisfied (use --upgrade to upgrade): Jinja2>=2.4 in /usr/lib/python2.7/dist-packages (from Flask==0.10.1->-r requirements.txt (line 9))
Requirement already satisfied (use --upgrade to upgrade): itsdangerous>=0.21 in /usr/lib/python2.7/dist-packages (from Flask==0.10.1->-r requirements.txt (line 9))
Requirement already satisfied (use --upgrade to upgrade): python-socketio>=1.4 in /usr/local/lib/python2.7/dist-packages (from Flask-SocketIO==2.6->-r requirements.txt (line 12))
Requirement already satisfied (use --upgrade to upgrade): python-engineio>=0.9.2 in /usr/local/lib/python2.7/dist-packages (from Flask-SocketIO==2.6->-r requirements.txt (line 12))
Requirement already satisfied (use --upgrade to upgrade): pyparsing in /usr/lib/python2.7/dist-packages (from pydot>=1.0.28,<=1.0.29->-r requirements.txt (line 16))
Requirement already satisfied (use --upgrade to upgrade): python-dateutil in /usr/lib/python2.7/dist-packages (from matplotlib>=1.3.1,<=1.5.1->-r requirements.txt (line 18))
Requirement already satisfied (use --upgrade to upgrade): tornado in /usr/lib/python2.7/dist-packages (from matplotlib>=1.3.1,<=1.5.1->-r requirements.txt (line 18))
Requirement already satisfied (use --upgrade to upgrade): nose in /usr/lib/python2.7/dist-packages (from matplotlib>=1.3.1,<=1.5.1->-r requirements.txt (line 18))
Requirement already satisfied (use --upgrade to upgrade): markupsafe in /usr/lib/python2.7/dist-packages (from Jinja2>=2.4->Flask==0.10.1->-r requirements.txt (line 9))
Cleaning up...

which looks good.  However, when I run sudo ./digits-devserver, I now have this output:
The gevent-socketio package is incompatible with this version of the Flask-SocketIO extension. Please uninstall it, and then install the latest version of python-socketio in its place.

This is why you're seeing that error:

Upgrading to Flask-SocketIO 1.x and 2.x from the 0.x releases

If you wish to continue using gevent, then uninstall gevent-socketio from your virtual environment, as this package is not used anymore and may collide with its replacement, python-socketio.
https://flask-socketio.readthedocs.io/en/latest/#upgrading-to-flask-socketio-1-x-and-2-x-from-the-0-x-releases
To remove the troublesome deb package:
sudo apt-get remove python-gevent-socketio

Alternatively, you can start with a clean virtualenv and install all the requirements from scratch:
# shut down and remove the old venv
deactivate
rm -rf venv

# make and activate a new one (without the --sytem-site-packages flag)
virtualenv venv
source venv/bin/activate

# install only what you need
pip install -r $CAFFE_ROOT/python/requirements.txt
pip install -r $DIGITS_ROOT/requirements.txt

@lukeyeager:  The first approach returns
sudo apt-get remove python-gevent-socketio
[sudo] password for exx:
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package python-gevent-socketio

I tried the second approach, too, with sudo, and I'm getting the same cannot uninstall, belongs to OS messages as below.  The end result is the same The gevent-socketio package is incompatible with this version of the Flask-SocketIO extension. Please uninstall it, and then install the latest version of python-socketio in its place. message as before.
Thank you for your support -- I'm looking forward to trying DIGITS 5.0.

Oops, the package name is actually python-socketio.

That worked -- thank you, @lukeyeager.

Hello,
I also have the same problem, so the server won't start

I already check the requirement and its already satified

I get the same error. What is the resolution for the issue?

I am working on Ubuntu 14.04


Progress reporting revisionv5

This is early in the hacking of revising the progress reporting system. The initial goal of this approach was to have one ProcessObject variable with the progress. This should allow all the different types of progress reporting to work together.
The progress reporting in the Multithreaders was commented out. After looking at the code a little I am wonder is much of progress reporting in the multithreads should be replaced by a separate progress reporting object.

Can this PR be finished before 5.1RC2 (scheduled sometime next week)?

It wasn't clear to me if we were converging on the approaches used here.
I can plan to work on in Monday and Tuesday, but I will likely take a little more time to finish the details.
I was unaware of any rescheduling for the RCs, I had been wondering about the plan.

The enum refactoring was causing compile problems in a lot of places, and its PR was the big blocker for RC2. With that now merged, we can make the next release soon. This doesn't have to make it into RC2, but we should have one improvement to progress reporting as part of 5.1 final.

@dzenanz With the pool multi-threader, when the number of work units>1, the invoking thread does only one job then it waits for ALL other jobs. For the current default of 4x work load factor, the first quarter of progress is frequent, but then the main thread will not produce anymore progress events as it is just waiting.
This is an odd implementation in the Pool threader, which remove the invoking thread from being a worker thread after only 1 job. This will not use all the cores with more that one for the load factor.

This uses all the cores, but indeed the invoked thread only executes the first work unit. The other work units are executed by the thread pool, which by default has as many threads as there are CPU cores.
What we could do instead of simply waiting for other threads, is wait with a timeout, then check/report progress e.g. by invoking filter->pixelsCompleted(0);, then wait again.

This uses all the cores, but indeed the invoked thread only executes the first work unit. The other work units are executed by the thread pool, which by default has as many threads as there are CPU cores.

Indeed, I was able to confirm this by setting ITK_GLOBAL_DEFAULT_THREADER=POOL, and ITK_GLOBAL_DEFAULT_NUMBER_OF_THREADS=2 then observing 3 threads and 300% CPU usage. That is good that it is using all the thread, but it is using more resources that I expect. In a cluster environment, this could get your processes kill by using too many resource.
@lassoan
This behavior of the invoke thread in the thread pool sheds new light on the progress reporting behavior reported in discourse.

This uses all the cores, but indeed the invoked thread only executes the first work unit. The other work units are executed by the thread pool, which by default has as many threads as there are CPU cores.

Indeed, I was able to confirm this by setting ITK_GLOBAL_DEFAULT_THREADER=POOL, and ITK_GLOBAL_DEFAULT_NUMBER_OF_THREADS=2 then observing 3 threads and 300% CPU usage. That is good that it is using all the thread, but it is using more resources that I expect. In a cluster environment, this could get your processes kill by using too many resource.
@lassoan
This behavior of the invoke thread in the thread pool sheds new light on the progress reporting behavior reported in discourse.

What we could do instead of simply waiting for other threads, is wait with a timeout, then check/report progress e.g. by invoking filter->pixelsCompleted(0);, then wait again.

@dzenanz The other option is to have the invoking thread participate in the work. This would have consistency behavior with TBB and the Platform multi-threaders. What ever is decided here I think we should do it in a subsequent patch.
This patch is about ready for review and testing.

@lassoan It's not needed to test this patching Slicer yet, as similar to #1571 only a the UnaryGeneratorImageFilter base class, and the MedianImageFilter have resorted the fine grain progress reporting.
I'd like to get some consensus of approval for these approaches before restoring granular progress reporting to more filters. And some agreement that the progress reporter should be added back to most of the filters where is was removed from in 4611871c.

Any strong objects to the name TotalProgressReporter? The "Total" comes from the concept that the totalNumberOfPixels is the total size from all threads, not just the local size.
Also its member function name remains CompletedPixels for similarity to the ProgressReporter. However, there is nothing in the progress classes which is specific to pixels, it could be mesh vertices, or number of indexes in an array. If we which to generalize it now is the time.

The class name is fine. CompletedPixels is better than most general name, as this will be used the most in image filters. General name would make this un-intuitive for the common case.

This PR is ready for review and envaluation.

Thank you very much @blowekamp and @dzenanz. I've rebuilt Slicer using this branch and progress reporting worked nicely with all the filters I tried!

@dzenanz @thewtex It looks like with the rc3 schedule in a couple days we should try to get this PR in today?

Yes, merge immediately if CI comes back green.

It looks like the ITK Python build issue is not related.

I am trying to compile my project with 5.1 RC3 on macOS Catalina and I am getting the following error:
FAILED: Bin/libSimpleITKExplicit-0.9.1.dylib
: && /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -Wmost -Wno-four-char-constants -Wno-unknown-pragmas -mfpmath=sse -Wno-inconsistent-missing-override    -O3 -DNDEBUG -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -mmacosx-version-min=10.10 -dynamiclib -Wl,-headerpad_max_install_names -compatibility_version 1.0.0 -current_version 1.0.0 -o Bin/libSimpleITKExplicit-0.9.1.dylib -install_name @rpath/libSimpleITKExplicit-0.9.1.dylib SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/SimpleITKExplicit_autogen/mocs_compilation.cpp.o SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/Explicit/src/sitkExplicitITKComposeImageFilter.cxx.o SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/Explicit/src/sitkExplicitITKDefaultPixelAccessor.cxx.o SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/Explicit/src/sitkExplicitITKDefaultVectorPixelAccessor.cxx.o SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/Explicit/src/sitkExplicitITKImageBase.cxx.o SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/Explicit/src/sitkExplicitITKImage.cxx.o SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/Explicit/src/sitkExplicitITKImageRegion.cxx.o SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/Explicit/src/sitkExplicitITKImageSource.cxx.o SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/Explicit/src/sitkExplicitITKImageToImageFilter.cxx.o SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/Explicit/src/sitkExplicitITKImportImageContainer.cxx.o SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/Explicit/src/sitkExplicitITKInPlaceImageFilter.cxx.o SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/Explicit/src/sitkExplicitITKLabelMap.cxx.o SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/Explicit/src/sitkExplicitITKVectorImage.cxx.o SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/Explicit/src/sitkExplicitITKVectorIndexSelectionCastImageFilter.cxx.o SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/Explicit/src/sitkExplicitITKImageConstIterator.cxx.o SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/Explicit/src/sitkExplicitITKImageRegionConstIterator.cxx.o SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/Explicit/src/sitkExplicitITKImageScanlineConstIterator.cxx.o SIMPLView/SIMPL/SimpleITKExplicit/CMakeFiles/SimpleITKExplicit.dir/Explicit/src/sitkExplicitITKImageScanlineIterator.cxx.o  -Wl,-rpath,/Users/Shared/DREAM3D_SDK/ITK-5.1-Release/lib  /Users/Shared/DREAM3D_SDK/ITK-5.1-Release/lib/libITKCommon-5.1.1.dylib  /Users/Shared/DREAM3D_SDK/ITK-5.1-Release/lib/libitksys-5.1.1.dylib  /Users/Shared/DREAM3D_SDK/ITK-5.1-Release/lib/libITKVNLInstantiation-5.1.1.dylib  /Users/Shared/DREAM3D_SDK/ITK-5.1-Release/lib/libitkvnl_algo-5.1.1.dylib  /Users/Shared/DREAM3D_SDK/ITK-5.1-Release/lib/libitkvnl-5.1.1.dylib  /Users/Shared/DREAM3D_SDK/ITK-5.1-Release/lib/libitkv3p_netlib-5.1.1.dylib  /Users/Shared/DREAM3D_SDK/ITK-5.1-Release/lib/libitknetlib-5.1.1.dylib  /Users/Shared/DREAM3D_SDK/ITK-5.1-Release/lib/libitkvcl-5.1.1.dylib  -lm  -lm && :
Undefined symbols for architecture x86_64:
  "itk::ProcessObject::IncrementProgress(float)", referenced from:
      itk::ComposeImageFilter<itk::Image<double, 2u>, itk::VectorImage<double, 2u> >::DynamicThreadedGenerateData(itk::ImageRegion<2u> const&) in sitkExplicitITKComposeImageFilter.cxx.o
      itk::ComposeImageFilter<itk::Image<double, 3u>, itk::VectorImage<double, 3u> >::DynamicThreadedGenerateData(itk::ImageRegion<3u> const&) in sitkExplicitITKComposeImageFilter.cxx.o
      itk::ComposeImageFilter<itk::Image<float, 2u>, itk::VectorImage<float, 2u> >::DynamicThreadedGenerateData(itk::ImageRegion<2u> const&) in sitkExplicitITKComposeImageFilter.cxx.o
      itk::ComposeImageFilter<itk::Image<float, 3u>, itk::VectorImage<float, 3u> >::DynamicThreadedGenerateData(itk::ImageRegion<3u> const&) in sitkExplicitITKComposeImageFilter.cxx.o
      itk::ComposeImageFilter<itk::Image<int, 2u>, itk::VectorImage<int, 2u> >::DynamicThreadedGenerateData(itk::ImageRegion<2u> const&) in sitkExplicitITKComposeImageFilter.cxx.o
      itk::ComposeImageFilter<itk::Image<int, 3u>, itk::VectorImage<int, 3u> >::DynamicThreadedGenerateData(itk::ImageRegion<3u> const&) in sitkExplicitITKComposeImageFilter.cxx.o
      itk::ComposeImageFilter<itk::Image<long, 2u>, itk::VectorImage<long, 2u> >::DynamicThreadedGenerateData(itk::ImageRegion<2u> const&) in sitkExplicitITKComposeImageFilter.cxx.o
      ...
  "itk::ProcessObject::SetThreaderUpdateProgress(bool)", referenced from:
      vtable for itk::ComposeImageFilter<itk::Image<double, 2u>, itk::VectorImage<double, 2u> > in sitkExplicitITKComposeImageFilter.cxx.o
      vtable for itk::ComposeImageFilter<itk::Image<double, 3u>, itk::VectorImage<double, 3u> > in sitkExplicitITKComposeImageFilter.cxx.o
      vtable for itk::ComposeImageFilter<itk::Image<float, 2u>, itk::VectorImage<float, 2u> > in sitkExplicitITKComposeImageFilter.cxx.o
      vtable for itk::ComposeImageFilter<itk::Image<float, 3u>, itk::VectorImage<float, 3u> > in sitkExplicitITKComposeImageFilter.cxx.o
      vtable for itk::ComposeImageFilter<itk::Image<int, 2u>, itk::VectorImage<int, 2u> > in sitkExplicitITKComposeImageFilter.cxx.o
      vtable for itk::ComposeImageFilter<itk::Image<int, 3u>, itk::VectorImage<int, 3u> > in sitkExplicitITKComposeImageFilter.cxx.o
      vtable for itk::ComposeImageFilter<itk::Image<long, 2u>, itk::VectorImage<long, 2u> > in sitkExplicitITKComposeImageFilter.cxx.o
      ...
```

Any ideas what I might be needing to link against?

Please create a new issue in ITK/SimpleITK as appropriate. I see you built libSimpleITKExplicit-0.9.1.dylib which is an old version of a SimpleITK library. Some explanation is needed to what you are doing in the new issue.


React/RCTConvert.h file not found

It throws RCTConvert.h not found at first line of color-grabber.
Manually linked the library, using react-native 0.60.3.
Any ideas?

Same error for me with same version of react native

Have not tried 60+ yet for this but you need to either give these instructions a try:
https://github.com/react-native-community/cli/blob/master/docs/autolinking.md#how-can-i-disable-autolinking-for-unsupported-library
or, I think to fix though, a RCTARKit.podspec file needs to be added to the root and who knows what else to make autolinking work. I dunno if PRs are even being looked at here anymore.

Any updates??? I am using react native 60 and I have the same problem!

The reason of this error for me was because I did react-native link react-native-arkit and then try to link manually. I did it form scratch and link it manually and now it is working!

Try code-matt's fix here: https://github.com/react-native-ar/react-native-arkit/pull/208
And see my comment about modifying the Podfile: https://github.com/react-native-ar/react-native-arkit/pull/208#issuecomment-592971819

I have the same issue.
Any updates?

@RixBai i am sorry, this repo is currently not maintained und untested with current react-native versions.
maybe give https://github.com/viromedia/viro/ a try

Oh, Gotcha @macrozone
Thanks for letting me know.

@RixBai i updated the readme with the information :-)


Add rounded-pill for semi-circle ends

Duplicate of https://github.com/twbs/bootstrap/pull/27339?

Thanks but there's already a PR open for this.


Use actual files for our internal tests

Currently most of out internal tests use files which are generated on the fly with steps like:
    Given a file named "features/apples.feature" with:
      """
      .... some content
      """

This is quite a pain to work with, since the content is plain text:

You don't get autocompletion in the IDE
You don't get syntax highlighting
Indenting can be a pain, specially if you are mixing php code and feature code

I think we could implement a step like
    Given I use file "features/arguments/apples.feature"

What this would do is, instead of creating a file on the fly from the feature content, copy this actual file which would be stored in the repository (under the features\examples folder, so in this case the file would actually be in features/examples/features/arguments/apples.feature) to the temporary folder used to run the tests
Advantages:

Autocompletion and syntax highlighting in the IDE for the example files
Easy indenting in the example files

Disadvantages:

Makes the tests more difficult to review at a glance
Could make it more difficult for users who are looking into tests for guidance

In my case I think that the advantages overcome the disadvantages. I think that reviewing can still be easy since you will have the example files in any PR, and that these tests are mostly internal and not really useful for users who are not developing Behat. Good naming of the example files (for example testSnippetRegexOutputWithSimpleText.feature) would help a lot
What do you think?
(I don't propose to change all our tests to this new format, at least not initially, this would initially be used only for new tests)

Another advantage is that it will probably make our tests more readable. Now a lot of the detail is lost in the details of the generated files

Thanks for raising this - I found this quite painful too on my last PR. I ended up developing with my feature file provisioning a FeatureContext.php that just did require /path/to/my/wipFeatureContext.php so that I could get autocompletion / autoformatting etc and then only inlined the content back into the feature file at the very end. But that didn't solve the similar issue with the content of the .feature inside the .feature (and that really upset PHPStorm - if I tried to autoformat it broke the file completely so it took longer than it should have to tidy everything for commit).
I wonder if we should go one step further, and consider provisioning each feature as a standalone directory (e.g. with the FeatureContext, any .feature files, behat.yml etc all in the same place), rather than copying anything - so the behat is bascially just telling it what working directory & command to run, and then making assertions.
Advantages:

Same as your idea
Ability to run the "inner" behat process direct from the CLI - making it easier to do things like see colour output, step/trace through with Xdebug for more complex debugging, etc.
Possibly easier to review than copying files at runtime, as you'd at least be able to look at a whole directory rather than following references to files.
Possibly easier for a new/external user to see the whole example as a working behat directory?

Disadvantages:

Same as your idea, we'd still lose the current advantage that the feature / code and expected behaviour are all in one place
Could be more difficult for the common case that we need to run the same feature file with different FeatureContexts, or the same FeatureContext with different features. Although could often work round that by passing a filename / tag / environment variable to the behat command that we run for each test.

Or - an opposite idea - if the pain is mostly only when adding a new feature, maybe we could add steps / tooling so that it's easy to work with standalone files while the work is in progress, then merge them together into a single .feature file in the current style before committing/merging.... Which might get some of the advantages without any of the disadvantages... Not sure if that's a good idea though.

I much prefer your first suggestion. Rector does something similar, with "self-contained" folders with config and fixtures. Let me think how that could be implemented effectively

Note that the code for those should probably be in a fixtures folder, not in features/examples, otherwise we would have to configure the suite to exclude the whole examples folder from the discovery of .feature files (so that they are not registered in the Behat suite itself)

@acoulton @stof I create this PR, please let me know what you think https://github.com/Behat/Behat/pull/1544


Update Code Editor

Resolves #66
Update Mini Map
Update Collapse label
remove the following props
modalTitle="Body"
modalButtonTooltip=""

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.41%. Comparing base (4f3e308) to head (37cbe80).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   76.39%   76.41%   +0.02%
==========================================
  Files          61       61
  Lines        1995     1997       +2
  Branches      504      506       +2
==========================================
+ Hits         1524     1526       +2
- Misses        413      469      +56
+ Partials       58        2      -56

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[WIP] Run doctests

Run code inside docstrings to make sure examples are in sync with actual code.
Use with pytest --rootdir tests/ --doctest-modules xclim
Lots of failing tests. You can add stuff into the namespace using xclim/conftest.py

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #xyz

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[ ] HISTORY.rst has been updated (with summary of main changes)
[ ] bumpversion (minor / major / patch) has been called on this branch
[ ] Tags have been pushed (git push --tags)

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Other information:

I won't have much time to put into this before Friday. @tlogan2000 Is it critical to fix this for the next release ?

Pull Request Test Coverage Report for Build 1765

8 of 17 (47.06%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 89.213%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

xclim/conftest.py
8
17
47.06%

Totals

Change from base Build 1764:
-0.3%

Covered Lines:
2291

Relevant Lines:
2568

💛  - Coveralls

I moved all the test configuration to tests/conftest.py and one needs to use --rootdir tests/ in the pytest command so they are read. Also, I fixed the failures of the tests pytest tests (ouf).
However,  I have no idead why pytest doesn't run all the doc tests? Raw python -m doctest works as expected, but pytest skips a lot of them.

@Zeitsperre Will you be able to hook this up in the Travis tests ?

@Zeitsperre @huard I did add a line in tox.ini to add them to the Travis tests, but did it in the doc context, which doesn't have pytest, I forgot...

I don't see the doctests output in the travis build. I'm trying to fiddle with the config, but don't really know what I'm doing.

Tests are run inside the xarray master environment to avoid import errors. This would be ready to merge, with the caveat that not all doctests are collected by pytest. I've tried to diagnose why, but no luck so far. I'll open another issue to fix the doctest collection.


Fix brops intermittent test failures

All around Pid start/registration/stop behaviour in bprops_eqc test. The deps stuff will need updating again when PRs merged that take us off tags and back onto branches for this dev cycle

+1 as well, fixes the problem tests

Squashed merge? Or keep the messy history?

+1 to squash


As an Industry Reporter I want to review and confirm my emissions and compliance report subtotals/totals so that they are accurate

Description:
Derived from Reporting User Story Mapping Miro Board
Acceptance Criteria:
Given
When
Then
Development Checklist:

[ ] Checklist item
[ ] Checklist item
[ ] Checklist item
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

@suhafa would you agree that this step will occur via the emissions summary page and the compliance summary page?
Or do we think there needs to be a more explict "review" step? This isn't really captured in our current wireframes, so I may icebox or close this ticket.

@patriciarussellCAS it will occur via the emissions summary/compliance summary pages, so a 'review' step may be redundant. Feel free to close this ticket if nothing else comes to mind @patriciarussellCAS


addHealthyTaskCountAlarm/addUnhealthyTaskCountAlarm doesnt seem to work

Version
5.3.0 and 5.10.2
Steps and/or minimal code example to reproduce
            this.myDashboard.monitorFargateApplicationLoadBalancer({
                fargateService: myFargate.fargateService,
                applicationLoadBalancer: myFargate.applicationLoadBalancer,
                applicationTargetGroup: myFargate.targetGroup,
                addHealthyTaskCountAlarm: {
                    healthy: {
                        alarmNameOverride: `${this.MyVariable}-ECS-healthy`,
                        alarmDescriptionOverride: 'asdfasdf',
                        minHealthyTasks: 6,
                        comparisonOperatorOverride: ComparisonOperator.GREATER_THAN_OR_EQUAL_TO_THRESHOLD,
                        treatMissingDataOverride: TreatMissingData.NOT_BREACHING,
                        actionsEnabled: true,
                        actionOverride: new SnsAlarmActionStrategy({ onAlarmTopic }),
                        datapointsToAlarm: 8,
                        evaluationPeriods: 10,
                        period: Duration.seconds(60)
                    }
                }
			})

Expected behavior
Add healthy and unhealthy (dashboard + alarm)
Actual behavior
Can't get the healthy and unhealthy.  Get only the CPU, memory and min/maxAutoScaling.
Other details
No problem with addCpuUsageAlarm, addMemoryUsageAlarm, minAutoScalingTaskCount and minAutoScalingTaskCount .  Maybe a dont use the right method..

You can close this issue.  Maybe adding some warning when some value are "null".  My loadbalancer was empty, but fail without notice.


focusmaster dispatcher causes crash if there is no master

This concerns the new feature implemented in #941 , which is exactly what I need. But when there is no master, it causes Hyprland to crash. I would have expected it to simply do nothing in this case (since there is nothing to focus on an empty workspace).
Context:
I implemented a handler script to focus the master window whenever a window closes, works fine except when the master window itself closes... boom..
(by the way, I wonder if such focusmasteronclose functionality might perhaps be desirable to implement in Hyprland itself using a boolean setting)
Version: Running on the git d0e47d9 .
Relevant log portion:
[LOG] Hyprctl: dispatcher layoutmsg : focusmaster
[WARN] Disabling TextInput on no IME!
[LOG] Window 745aa190 unmapped (class foot)
[LOG] Unregistered late callbacks XDG
[LOG] Callback 745aa1b8 -> 745aa1b0, XDG Window Late removed.
[LOG] Callback 745aa358 -> 745aa350, XDG Window Late removed.
[LOG] Callback 745aa490 -> 745aa488, XDG Window Late removed.
[LOG] Callback 745aa5c8 -> 745aa5c0, XDG Window Late removed.
[LOG] Callback 745aa560 -> 745aa558, XDG Window Late removed.
[LOG] Callback 745aa4f8 -> 745aa4f0, XDG Window Late removed.
[LOG] Callback 745aa630 -> 745aa628, XDG Window Late removed.
[LOG] Callback 745aa428 -> 745aa420, XDG Window Late removed.
[LOG] Framebuffer created, status 36053
[LOG] On closed window, new focused candidate is 0
[LOG] Destroying the SubSurface tree of unmapped window 745aa190
[LOG] Callback 745a7730 -> 745a7728, Subsurface removed.
[LOG] Callback 745a7660 -> 745a7658, Subsurface removed.
[LOG] Callback 745a76c8 -> 745a76c0, Subsurface removed.
[LOG] Callback 745a65d8 -> 745a65d0, SurfaceTreeNode removed.
[LOG] Callback 745a6640 -> 745a6638, SurfaceTreeNode removed.
[LOG] Callback 745a6570 -> 745a6568, SurfaceTreeNode removed.
[LOG] SurfaceTree Node removed
[LOG] Callback 745aa7d0 -> 745aa7c8, Toplevel removed.
[LOG] Callback 745aa768 -> 745aa760, Toplevel removed.
[LOG] Callback 745aa838 -> 745aa830, Toplevel removed.
[ERR] Error in getAppIDClass: basic_string: construction from null is not valid
[LOG] Window 745aa190 destroyed, queueing. (class )
[LOG] Callback 745aa220 -> 745aa218, XDG Window removed.
[LOG] Callback 745aa288 -> 745aa280, XDG Window removed.
[LOG] Callback 745aa2f0 -> 745aa2e8, XDG Window removed.

I hope this gives sufficient data to pinpoint the problem.

I forgot the instructions to reproduce the problem (without my script), just open a terminal and run:
$ (sleep 10 && hyprctl dispatch layoutmsg focusmaster) &
$ disown
$ exit

it concerned a bunch of others too. Fixed in 349afa0e7a5a8f60404772ae76ab0dc6fe4117ff


after package, upload images to "public" folder, but it can't visit the image url .just 404.

Describe the feature
before package folder tree:
public
--images
---a.jpg
---b.jpg
after package folder tree:
public
--images
---a.jpg
---b.jpg
I can visit image a.jpg, b.jpg.
via frontpage upload image c.jpg:
public
--images
---a.jpg
---b.jpg
---c.jpg
c.jpg can't be visit, just 404.
why?
Additional information

[ ] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[X] Read the contribution guide.
[X] Check existing discussions and issues.

Nuxt doesn't support updating the public folder after building it.
If you need this you could probably implement it yourself using useStorage and the fs storage driver.

Nuxt doesn't support updating the public folder after building it.
If you need this you could probably implement it yourself using useStorage and the fs storage driver.

thank you for answer!


Improve performance of content searches

Short description
This pr improves the performance when performing a content search.
In general, the search was fairly optimized and the biggest changes could be made to pages.
Related issue: #943
Proposed changes

Prefetch some attributes for pages, events and pois
Make use of cached data when searching pages

On a side note, I wondered why only public pages get filtered. Wouldn't it make sense to allow searching through all pages of the page tree?
This can be especially confusing in the archived pages view, where pages with e.g. status: Draft are visually indistinguishable from other pages, but are not taken into account when searching.

Okay, I just committed your suggestions, which removed the public filter.


Issue/412 a11y

This PR addresses issue https://github.com/epimorphics/ukhpi/issues/412 by increasing contrast for search location results, as well as when they are being focused. Also increased contrast for compare location dropdowns
Before:

After:

please see comment on style choice in the location selection css

Should be fixed now, re-requested review 👍


Make listLanguages() include additional bundled languages

If I download a custom package of hljs with some "other" languages included, listLanguages() does not print those other languages as options available for syntax highlighting.

listLanguages() has no choice but to list all the languages that are bundled with the file, there's no separate registry or something. And I just checked by downloading a custom file and it lists all the languages I have selected. Could you check again, just to make sure?

Works good for me too.


build: Remove JSON helper

See https://github.com/liftedinit/alberto/pull/116 and https://github.com/liftedinit/gwen/pull/35

The other PRs passed their CI and have been merged. Merging this one now.


fix: use join for check-by-address path

closes #7051
use Url::join to ensure the url is /path

Can you pls rebase https://github.com/foundry-rs/foundry/pull/7064


apply manager driver pattern

fixes #4 #3 #2

https://github.com/elbgoods/laravel-trashmail-rule/releases/tag/0.2.0


Video divs row wrapper

When the video divs have been created could you append them all to a single div with the class of row please? Or we could get Georgie to create this div first and give it an ID, and then you can target that to append the videos to?

This has been done dynamically.


Fix naming conflict * breaking change *

fixes #468
NOTE: this breaks the former API, renaming all instances of "Clipboard" and "ClipboardAction" to "ClipboardJS" and "ClipboardJSAction", respectively

This is really an FYI working version for the latest versions of Chrome.
It breaks the current API, but I see no other alternative at this point.

Hey @rivy! I decided to make a fix on the build level: https://github.com/zenorocha/clipboard.js/commit/750cf124d7fa60902f25f7496fe7cf0323fed280
Thanks for your help!


CyclicVoltammatry and ECMS

Hey @kkrempl , this PR contains implementation to your review of #8. It also contains new readers for two other potentiostat files as well as PVMassSpec, which would be cool for you to take a look at if you have time. An idea could be to leave this pull request open as we do a bit of work on ECMSMeasurement.
One thing I'd like a second opinion on is the way MID ValueSeries are made accessible as e.g. "M2", even if the data acquisition software saves them as e.g. "2_amu" instead. That's done, like probably too many things, by adding to __getitem__ . I worry that complicates inheritance. I am however reluctant to change the names of the ValueSeries since I think it's a nice property of ixdat if it respects the original names even while adding accessibility via standard names (same storry for potential and current in ECMeasurement). Another way to do this would be to make a ReferenceSeries which is like a DataSeries but doesn't have a copy of the data but just the standard name and a pointer towards the DataSeries with the original name and the data. What do you think?

I'll push now the most recent changes to this branch now as well, so you can use the PR to give a look at all the new code in the present pip-installable v0.0.10
I'll refrain from any edits except maybe documentation for a bit so it stays current.

@kkrempl, glad to hear!
With regards to grab, did you experience anywhere where it didn't do the desired behaviour of returning unmodified data by default?

@kkrempl, glad to hear!
With regards to grab, did you experience anywhere where it didn't do the desired behaviour of returning unmodified data by default?
No, with the change to include_endpoints=False I have not had any problems so far.


Readme

What should we say here? This is our home page :)
Also, our repo description (short one liner).

Once upon a time...
In the beginning...
Long ago...
For as long as humans have been around, we have told stories. Creating new worlds, whether it be a galaxy far, far away or a mysterious forest bordering the kingdom, we have used the power of story to explore the fantastic and unknown. The best stories inspire us to create something new; to go deeper into the dark, enchanted wood and discover our own monsters ready to be challenged--if we are courageous enough to do so...
this is all I got so far...maybe this will get our minds rolling on some content


model-design

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
submitting assignment
What did you learn from the changes you have made?
database architecture
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
some mentioned in the assignment files.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[x] I can confirm that my changes are working as intended

Assignment marked.

Hi, All of your HW are missing.

Hi Sidra,
Hope you are doing well, I am really sorry I had totally forgotten about
this. Made a pull request just now. Extra details are in the pull request
message.
Thank you for your time. Again, sorry about the inconvenience.
On Thu, Oct 10, 2024 at 10:14 PM Sidra Bushra @.***>
wrote:

Hi, All of your HW are missing.
—
Reply to this email directly, view it on GitHub
https://github.com/hoseinaliyari/sql/pull/1#issuecomment-2406405238, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BKTFCN2B35776CSDRCUNCG3Z24YADAVCNFSM6AAAAABPBFLVCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBWGQYDKMRTHA
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


[windows] fix proxy settings

What does this PR do?
Mirrors behavior of https://github.com/DataDog/datadog-agent/blob/cbf8ea5e9478452892755f8e7d3bd1eccaee7a63/pkg/legacy/converter.go#L183-L185
url.Parse("") is valid.
Motivation
Customers were reporting no metrics being sent.

I have the same PR, but with additional checks for ""; this can be closed.

Superseded by #1529, closing


feat(astyle): Add support for astyle

Added the support for astyle formatter

do I also need to edit the readme? this is my first pr here, so if anything is not right can you please point it out to me, thanks for your time

Thanks for the PR!
The list of formatters in the README is autogenerated, so you don't have to edit it manually.


feat: added pageDescriptionOverrides and fixed notion page head description

Added pageDescriptionOverrides to override page descriptions (for SEO purposes)
Fixed notion PageHead to include all descriptions

! Depends on https://github.com/transitive-bullshit/nextjs-notion-starter-kit/pull/186

Note that you can override the default description by using a notion text property on a page named "Description".
I'm trying to favor solutions which use notion as the source of truth for things like this, as opposed to the config (but it's not always possible).


Need option to change the default SOCKS port for Orbot

Hello,
can you please add an option to specify the SOCKS port to use when connecting through Orbot?
This is needed because many Samsung devices already use TCP port 9050 for some Samsung service; it is simple enough to modify this setting in Orbot, there's an option in the GUI, but it is not possible to change the default in ChatSecure.
Thanks,
Silla Rizzoli

Yes, we will expose the proxy settings value. Also, we are adding a way for apps to query Orbot to ask for the current port values.

Great, thanks!
In the meantime, I've been trying to do it myself, as a kind of learning project, but I couldn't get ChatSecure to run in Eclipse; following the instructions did help some, however I had to add many libraries manually to get eclipse to let me try to run the project; when I try to run it, however, I get this error:
[2015-05-18 21:03:12 - Dex Loader] Unable to execute dex: Multiple dex files define Lcom/kenai/jbosh/AbstractAttr;
[2015-05-18 21:03:12 - ChatSecure] Conversion to Dalvik format failed: Unable to execute dex: Multiple dex files define Lcom/kenai/jbosh/AbstractAttr;
Can you help me solve this problem?
Thanks,
Silla Rizzoli

Did you follow the instructions in the README.md file?
You have to get all the submodule projects using:
git submodule update --init
and then you need to import all of those projects into Eclipse.

Yes, I did that, I just got it to work, I had to uncheck all the .jar files in the project, clean and rebuild everything.
Thanks!


Question about EnsureIndex

Hi,
Should we call EnsureIndex before insert or after insert or is it the same?
Regards,

Is best to call it once when you connect to the LiteDB, it doesn't need to be call it every single time when you perform write.

Hi! With the objective of organizing our issues, we are closing old unsolved issues. Please check the latest version of LiteDB and open a new issue if your problem/question/suggestion still applies. Thanks!


hasHms() doesn't work properly

Summary

Version
8.3.1

Affected OS
Android

OS Version
10

Current behavior
I am testing hasHms method on HUAWEI MatePad T (AGS3-W09) and it returns false. But I have HMS Core and don't have Google mobile services. hasGms also returns false, as expected.
Expected behavior
hasHms() should return true

I think this may be the same root cause as #1300 - please examine that one for the pointer to proguard rules and try it out. End result of that was a note in the documentation (#1302 ) with issue left open pending the addition of an actual proguard rules file we may direct people to include in their build.gradle

I tried to enable proguard and added this rule: -keep class com.google.android.gms.common.** {*;} but hasHms() still returns false on Huawei device with HMS.

Alright, I added such rule in proguard-rules.pro: -keep class com.huawei.hms.api.** {  *;  } (also tried: -keep class com.huawei.hms.api.HuaweiApiAvailability {  *;  } and did changes to enable proguard:

But hasHms() doesn't work (returns false). Tested with release build.

Most unexpected. Perhaps the classes changed. I don't have a Huawei device, so apart from the general direction I've given with regard to how to tweak Proguard class retention (to make sure classes are still there in release even if only used via reflection) I won't be able to offer more.
If there's a PR needed to repair it, you'll have to post that, then we can release and merge. That it works in debug is very suspicious to me though - that makes me think there is still something going on with proguard and how it's configured in your project

I am facing the same issue. Any solution for it?


Error while working with custom dataset

I am getting response properly for queries while using BNP dataset. But while created my own custom dataset I'm receiving " AttributeError: Can only use .str accessor with string values! " error.
Data set:
title,paragraphs
Builder,"['Built by Shah Jahan, a Mughal Emperor and son of Jahangir','More than 20000 labourers were put in task and it took 14 years to build it']"
For whom,"['Taj Mahal is tomb of Mumtaj Mahal, wife of shah jahan','Mumtaj Mahal died while giving birth to her 14th child']"
location,"['Taj mahan is situated in Agra which is 4 hours drive from Delhi', 'One can reach Taj Mahal by road or Train']"
remarks,"['Taj Mahal is built with white marbels from rajasthan','it is one of the seven wonders of world']"
This is the Code-
`df = pd.read_csv('./data/gokul.csv', converters={'paragraphs': literal_eval})
df = filter_paragraphs(df) #error
#instantiate cdQA pipeline
cdqa_pipeline = QAPipeline(reader='./models/bert_qa.joblib')
cdqa_pipeline.fit_retriever(df=df)`
error is in line filter_paragraphs(df)

removed "df = filter_paragraphs(df)" and its working


DP-2472 Revert "diff commit (#10)"

This reverts commit e7a11f0407b7f8d3d10a5c41e3782acd5e2c2b08.
https://bighealth.atlassian.net/browse/DP-2472
It will add the changes that Luca reverted back so that we can move forward with the Android CC changes.
Thanks for opening a PR!
Since this is a volunteer project and is very active, anything you can do to reduce the amount of time needed to review and merge your PR is appreciated.
The following steps will help get your PR merged quickly:
Update the documentation
If you've added new functionality, update the README.md with an entry for your prop or event.
The entry should be inserted in alphabetical order.
Update the changelog
After you open the PR, update the CHANGELOG.md file with an entry pointing to your PR.
Provide an example of how to test the change
If the PR requires special testing setup provide all the relevant instructions and files. This may include a sample video file or URL, configuration, or setup steps.
Focus the PR on only one area
Testing multiple features takes longer than isolated changes and if there is a bug in one feature, prevents the other parts of your PR from getting merged until it gets fixed.
If you're touching multiple different areas that aren't related, break the changes up into multiple PRs.
Describe the changes
Add a note describing what your PR does. If there is a change to the behavior of the code, explain why it needs to be updated.

@ruby-bighealth all of those typos and comments come directly from the react native video player main fork. The only changes in our branch that come from us were from 3 years ago.


Update dns.js

added compatibility with dnscrypt-proxy2 client.
(Error when dns is not first parameter. for example GET /dns-query?ct=&dns=blah)

Hi Kirill,
Thanks for the PR. I'll fix the dns_decode_level bug, but I think it would be more efficient to accommodate extra query arguments in the NGINX config itself, rather than looping through them in NJS. Eg:
# proxy pass to the dohloop upstream
proxy_pass http://dohloop/dns-query?dns=$arg_dns;

Are the other arguments that dnscrypt-proxy2 sends relevant to the DoH gateway?
Thanks,
Mark

Hey!
I'm not completely sure. Still reading docs & sources.
At this moment I try to figure out:
upstream prematurely closed connection while reading response header from upstr[...] , request: "POST /dns-query?body_hash=fc3f9e09b65a7ce1e47b02b299[...]" (only 1 arg: body_hash)

Hey!
I'm not completely sure. Still reading docs & sources.
At this moment I try to figure out:
upstream prematurely closed connection while reading response header from upstr[...] , request: "POST /dns-query?body_hash=fc3f9e09b65a7ce1e47b02b299[...]" (only 1 arg: body_hash)

When you send a POST through DoH, the raw packet is sent inside the body, it looks like they are just sending a hash of it in the URI as an argument. I don't know why it would fail though... I've tested a similar thing with curl...
curl -vv -k https://lb01/dns-query?body_hash=blah --data-binary @/var/nginx/dns.packet

Can u share this 'dns.packet', i will test from my side

Sure. I had to gzip for github.
It's just a capture from a firefox DoH request for detectportal.firefox.com
dns.packet.gz

Sure. I had to gzip for github.
It's just a capture from a firefox DoH request for detectportal.firefox.com
dns.packet.gz

In that way everything is normal =\


NodePort issues with mysql service

I am having issues connecting to a mysql pod/service via an external client using an exposed NodePort, my steps to reproduce are exactly the same as #29548
Creating a PeerAuthentication with mtls mode DISABLE fixes the issue accessing the service via the NodePort, but it has created a separate issue with other sidecars being able to communicate with the mysql pod, I assume this is because auto mTLS is enabled internally. Previously I was on version 1.7.4 and didn't experience this issue, is this a change in 1.8.0+? In the docs for Peer Authentication (https://istio.io/latest/docs/reference/config/security/peer_authentication/#PeerAuthentication-MutualTLS-Mode) it states that PERMISSIVE mode accepts both plain text and mTLS, but that doesn't seem to be the case or am I just misunderstanding?

Thank you!!
apiVersion: networking.istio.io/v1beta1
kind: DestinationRule
metadata:
  name: plaintext
spec:
  host: "mariadb.mariadb.svc.cluster.local"
  trafficPolicy:
    tls:
      mode: DISABLE

should get things working. I am trying to figure out if this a bug or a limitation in the auto mtls that we need to document/warn about and will update

or you could also just remove the selector from PeerAuthentication

Thanks @howardjohn I'll try that out over the next few days. Out of interest has something fundamentally changed from 1.7.x as I haven't run into this kind of problem prior to upgrading to 1.9.1?


Postgress Support

Describe the feature
Add support for Postgresql on Minimig

This is being worked on PR #35

on Released on version


new feature: add log method

It would seem obvious that a logger should have a log method, but our logger does not. We should alias log to the info log level.
(caused issues like this https://github.com/adobe/aio-cli-plugin-app/pull/341)

loggers log, and features creep
saw some logs and went to sleep


Fix IntegerExtension:isPowerOfTwo

isPowerOfTwo fails due to Integer underflow when called on -9223372036854775808 (-2^63), the min value of Int64.

Closed by #22.


Made TF Saliency Map Attack More General

Addressing issue #37 by making jsma_tf attack generalized to accept data of any shape. We should eventually write a new tutorial for data of some other shape; maybe CIFAR-10. I have tested this on data of different shapes.

@rfeinman thanks for the PR, but please make sure your code passes PEP8 tests next time (I fixed the errors for this time)
Will run a few more tests before merging

Apologies - I will follow this new req in the future. The while statement in 246-247 should also be adjusted so that the 'and' comes before the line break.

No worries Reuben, we only recently implemented the pep8 compliance checks in #73


⚠ Bofrost.nl has degraded performance

In 6576e0a, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1685 ms

Resolved: Bofrost.nl performance has improved in c22cf10 after 6 minutes.


[VL] Allow to enable or disable huge page allocation feature in Velox

After rebasing our codebase to the Velox upstream, we encountered a performance regression issue specifically when running TPCH workloads. By analyzing system metrics, we observed both CPU kernel% and average disk I/O utilization are higher than usual.

Metric
10/15 main
10/16 rebase

avg %user
73.683813
64.057788

avg %system
14.410994
21.049894

avg %iowait
1.436360
1.331901

avg disk util
37.034717
58.454064

time more than 90%
0.181594
0.308127

total read (G)
655.194033
1067.343783

total write (G)
1910.835353
1986.147310

perf hotspot from TPCH Q21 shows that the kernel is busy with huge page memory allocation and memory compaction. This led us to suspect that using huge pages for allocating large contiguous memory regions was main reason of the performance regression. Additionally, the eviction of page cache appeared to be a downstream consequence, resulting in higher disk I/O utilization.

we could override the flag here?
https://github.com/oap-project/gluten/blob/main/cpp/velox/compute/VeloxBackend.cc#L51-L53

/Benchmark Velox

@marin-ma can you please update the pull request description for background of this change?

/Benchmark Velox

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_3483_time.csv
log/native_master_10_19_2023_a9324e620_time.csv
difference
percentage

q1
40.15
40.32
0.172
100.43%

q2
24.61
24.36
-0.247
98.99%

q3
41.23
40.92
-0.314
99.24%

q4
37.39
33.60
-3.786
89.87%

q5
69.13
70.38
1.248
101.81%

q6
9.49
8.94
-0.550
94.20%

q7
87.49
102.14
14.652
116.75%

q8
84.55
104.41
19.853
123.48%

q9
120.69
156.04
35.348
129.29%

q10
55.11
72.84
17.732
132.18%

q11
19.88
22.07
2.187
111.00%

q12
28.35
34.28
5.931
120.92%

q13
49.19
72.13
22.937
146.62%

q14
18.75
25.22
6.476
134.55%

q15
34.15
40.39
6.239
118.27%

q16
16.28
18.59
2.311
114.19%

q17
100.10
105.84
5.742
105.74%

q18
145.33
217.17
71.840
149.43%

q19
17.27
27.16
9.890
157.26%

q20
32.11
40.56
8.457
126.34%

q21
225.86
335.44
109.574
148.51%

q22
14.01
17.06
3.049
121.76%

total
1271.13
1609.87
338.740
126.65%

Good work! Thanks @marin-ma


[#687] fix: disallow empty string for post data

Related to #687

Description
Fixes #687. Don't allow the creation of empty triggers, which were resulting in error logs since there is nothing to execute.
Test plan
Try to create a trigger without setting an URL and a postData, should not be possible.
Remarks
This should be changed when we implementing receiving emails as a functionality of the trigger, but for now makes no sense allowing to create a trigger that does nothing.

Tests failing.


Add Example of Serving Dynamic js & css files.

Make an example that shows how one would load a dynamic javascript or css file.  For example:
Let's say I want to load the minimal amount of external resources and then if a person moves to a specific page I add on javascript or css files that the new page will need.

Is it done?


Image is not appearing completly

The image is not displayed fullyю Only their outlines are displayed please help.

Issue is solved. I used wrong url.  from response obj in ImgePicker method. It must be an origURL


Add title to DwC-A distribution

To be compliant with the best practices of DCAT, a distribution of a dataset should also have I title. I opted for "Darwin Core Archive of title of dataset". I made an attempt here to include the necessary code in the DCAT feed generator, but this has not been tested.

Thanks for this contribution Peter. It has been added to the issue queue for the next release: https://github.com/gbif/ipt/projects/2

No compilation errors?

To be seen when work begins on the next release. No release date has been set yet.

Suggested fix has now been included in master - see https://github.com/gbif/ipt/commit/441000b13c5bc52c1ad7a48e4c40cb31a28ad72d Closing this pull request now. Thanks again.


Add deployment modal for model registry

JIRA: RHOAIENG-8396
Description

When you deploy a model based on a model registry, the following modal will show:

If anything wrong with the project, the corresponding error message will pop up:

Otherwise, the current KServe modal or InferenceService modal will pop up depending on the project's serving platform. The name will be pre-filled as {modelName} - {versionName}:

There is a helper text if the model registry version contains a prompt model format:

The data connections part will be decided by the model artifact URI.
If there are more than 1 matches, we don't pre-select the data connection:

If there is only one match, we pre-select the recommended data connection:

If there is no match, we pre-select the new data connection field:

The path will always be pre-filled based on the URI parsing result:

How Has This Been Tested?

Create project A, B and C
For project A, make it an unsupported serving platform (or don't select a serving platform if both platforms are supported)
Go to Model registry page, choose one model registry and click on Deploy on the version action
Choose project A, check the error message
For project B and C, make the serving platform selected (or make your cluster only support one platform)
Choose project B, check if the name field is auto-filled
Check the data connection field is pre-selected as New data connection and path field is pre-filled
Create one matching secret in project B and 2 matching secrets in project C ("matching" means the secret has the same bucket, endpoint and region as the model registry version artifact URI you are going to deploy with)
Choose project B again, check the data connection field is pre-selected as Existing data connection and the only matching data connection is labeled and pre-selected
Choose project C, check the data connection field is pre-selected as Existing data connection and both data connections in the dropdown menu are labeled as recommended, but neither is pre-selected

Test Impact

Add a unit test to test the util function that shows the error message when choosing the project.
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[x] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

Thanks for the work @DaoDaoNoCode! Just a few comments -

Can you stretch the modal width in the first image to the same width as the other modals?
Regarding the pre-filled model name, I can't see what happens if a version has been deployed multiple times. The ideal behavior is if the name has already been used within the selected project, add a postfix such as ‘-2’, ‘-3’ to differentiate it.
Regarding the helper text to the prompt model format - the helper text will only show up after a model server is selected, and the model framework dropdown is available.
For data connection, when there is no match and the new data connection is selected by default - a warning is missing, check details in the mockup

Can you stretch the modal width in the first image to the same width as the other modals?
Regarding the pre-filled model name, I can't see what happens if a version has been deployed multiple times. The ideal behavior is if the name has already been used within the selected project, add a postfix such as ‘-2’, ‘-3’ to differentiate it.
Regarding the helper text to the prompt model format - the helper text will only show up after a model server is selected, and the model framework dropdown is available.
For data connection, when there is no match and the new data connection is selected by default - a warning is missing, check details in the mockup

Based on the comments above, I updated the following:

For your first comment, I updated the size of the initial modal

For the second comment, I found it's a little bit hard from the technical side to implement what you requested. We will need to fetch all the models in that project and it's hard to decide the postfix number (e.g. There are model-1, model-3 and model-4, what should the auto-generated number be? model-2 or model-5?). I prefer we keep it as it is now, and if the name is duplicated, the server will always prompt an error when the user submits the model. (cc @mturley Might need your input here)
For the third comment, I updated the helper text to make it only show when there are items in the dropdown menu.

No items in the menu:

Items in the menu:

For the fourth comment, I updated the alert:

@yih-wang Let me know what you think, thanks!

@DaoDaoNoCode All the changes look good. Thanks for the rapid work!
Regarding the auto-generated deployment name, my primary concern is to avoid duplicate names and prevent user frustration from seeing duplicated names error continuously. If the original proposal doesn't work, we can implement a workaround by adding a timestamp as postfix to each name. So we'll have a format like [modelname-versionname-yyyymmddhhmmss], which should effectively eliminate duplicates as well.

LGTM, thanks @DaoDaoNoCode !


Train ACT with aloha_mobile_wipe_wine dataset. Error: No module named 'aloha_scripts'

can not find this file: aloha_scripts.constants
Thank you

https://github.com/MarkFzp/mobile-aloha
aloha_scripts is in this repo, but I dont know exactly how to use it

can not find this file: aloha_scripts.constants
Thank you

终端运行export PYTHONPATH=$PYTHONPATH:"./"，然后执行python训练代码
或者 python源码中添加
import sys  # 添加python环境
sys.path.append("./")


Ability for common index model fields to be stored in secondary indicies

Coverage decreased (-0.03%) to 46.447% when pulling 239d53efb907efa717d6c3c696ff6fa72fe7d7eb on rfecher:commonindexmodel into b800896700cee9283e2fc240c28026081c32eff1 on locationtech:master.

Coverage decreased (-0.03%) to 46.447% when pulling 239d53efb907efa717d6c3c696ff6fa72fe7d7eb on rfecher:commonindexmodel into b800896700cee9283e2fc240c28026081c32eff1 on locationtech:master.

Coverage decreased (-0.03%) to 46.447% when pulling 239d53efb907efa717d6c3c696ff6fa72fe7d7eb on rfecher:commonindexmodel into b800896700cee9283e2fc240c28026081c32eff1 on locationtech:master.

Coverage decreased (-0.03%) to 46.447% when pulling 239d53efb907efa717d6c3c696ff6fa72fe7d7eb on rfecher:commonindexmodel into b800896700cee9283e2fc240c28026081c32eff1 on locationtech:master.

Coverage decreased (-0.03%) to 46.447% when pulling 239d53efb907efa717d6c3c696ff6fa72fe7d7eb on rfecher:commonindexmodel into b800896700cee9283e2fc240c28026081c32eff1 on locationtech:master.


PHP: Guzzle

Hey folks, thanks for making this cool script!
PHP users generally don't use Curl, it's a mess, but Guzzle is massively popular. Could you pop a template in for that?

Hey! We already support Guzzle, and it's also the default! 👍 https://github.com/readmeio/oas-to-snippet/blob/16f308d41bfa0008f488c29809b897b5bf4ddd4c/src/supportedLanguages.ts#L184
You can try it out with the following code:
const Oas = require('oas');
const { oasToSnippet } = require('@readme/oas-to-snippet');

const oas = new Oas.default({
  openapi: '3.0.0',
  info: {
    title: 'spec',
    version: '1.0.0',
  },
  servers: [{ url: 'https://httpbin.org' }],
  paths: {
    '/': {
      get: {
        parameters: [],
        responses: {
          200: {
            description: 'desc',
          },
        },
      },
    },
  },
});

const { code } = oasToSnippet(oas, oas.operation('/', 'get'), {}, {}, 'php');
console.log(code);

This outputs:
<?php
require_once('vendor/autoload.php');

$client = new \GuzzleHttp\Client();

$response = $client->request('GET', 'https://httpbin.org/');

echo $response->getBody();

Lmk if you have any other questions!

Noticed that our README didn't note that we supported Guzzle so I've resolved that in https://github.com/readmeio/oas-to-snippet/commit/a40c1d0774e9e0cdd2a65ae4afab82b0eb43a1ca. Thanks!


Fix Root path on unix Operating system

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.
The proposed fix does fix an immediate problem (namely the specified root path of a tar archive not being respected on a unix system). However I feel the correct solution would be to use path's as they are used on the operating system running and doing the conversion at the last point before writing it to the file. This would remove a lot of similar hacks.
This PR resolves #580

close PR, as the proposed fix causes Issues


Pinpoint dashboard for webflux service not displaying springboot downstream service

Prerequisites
Please check the FAQ, and search existing issues for similar questions before creating a new issue.YOU MAY DELETE THIS PREREQUISITES SECTION.

[x] I have checked the FAQ, and issues and found no answer.

What version of pinpoint are you using?
master/v1.7.3/v1.7.2 etc.
Describe your problem**
A clear and concise description of what is not working.
What have you done?
Steps you have taken to trigger the problem, for example:

Launched '...' with agent
Tried tracing '...' (see agent log below)
Collector outputs trace log (see collector log below)
No trace shows up in the web UI (see web log below)

Screenshots
If applicable, add screenshots to help explain your problem.
Logs
If applicable, please attach agent/collector/web DEBUG log that includes the part where you have encountered the problem. In case of agents, including the start-up log may be of great help.
Additional context
We have incorporated pinpoint java agent in our application (ServiceA)  which is using webflux and webclient for downstream calls, there are two downstream services 1. Spring Webflux application (ServiceB)  2. Spring boot application (ServiceC) ,
both of them have implemented pinpoint.
We are able to see  (ServiceB) in ServiceA's pinpoint dashboard but not able to see ServiceC
we are able to see incoming calls in ServiceC pinpoint transactions (but not able to see ServiceA in the ServiceC's pinpoint dashboard)

2020-05-21 10:49:33 DEBUG AFTER com.fasterxml.jackson.databind.ObjectMapper  args:(ClaimsHolder) result:{"iss":"lms-service","Client-Id":"CBS_GATEWAY"}
2020-05-21 10:54:34 DEBUG AFTER com.fasterxml.jackson.databind.ObjectMapper  args:(ClaimsHolder) result:{"iss":"lms-service (ServiceC) ","Client-Id":"CBS_GATEWAY"}
Logs in pinpoint in cbs-gateway-xml (ServiceA)

@Ashukla81992
Spring WebFlux is supported from version 2.0.2.
Please apply version 2.0.2.

Ya I am working with 2.0.2 only

@jaehong-kim I am using version 2.0.2
and if we are using aync call that is not using the response then we are not able to see the downstream.
but if we are using the response we are able to see the downstream on the dashboard

@jaehong-kim Please update on this?

@emeroad Please help to resolve this.

There is not enough information to solve the problem.
Please reproducing a bug and provide it.

@Ashukla81992 Can you please recreate a bug.

@emeroad
Below is the code,
in case of Check1 things are working and I am able to see downstream on Pinpoint dashboard
but in case of Check2 it is not working and we are not able to see anything on Pinpoint  dashboard
public Mono work(final XXml value, String category) throws Exception {
        Mono<?> responseDtoMono = xRequestProcessor.processRequest(value);

String o ;
responseDtoMono = responseDtoMono.map(t -> {
ResponseDto responseDto = (ResponseDto)t;
if (Check1.equals(category))) {
if (Objects.nonNull(responseDto) && Objects.nonNull(responseDto.getResponse())
&& StringUtils.isNotEmpty(responseDto.getResponse().getObjectString())) {
o = responseDto.getResponse().getObjectString();
            } else if (Check2.equals(category)) {
                if (Objects.nonNull(responseDto) && Objects.nonNull(responseDto.getResponse())
                        && StringUtils.isNotEmpty(responseDto.getResponse().getObjectString())) {
                    o = responseDto.getResponse().getObjectString();
                }
            }
            return new BasicValidationResult(true,null);
        }).doOnCancel(new Runnable() {
            @Override
            public void run() {
            }
        });
        if (Check2.equals(category)) {
            responseDtoMono.subscribe(rr -> {
                log.debug("Got response={} async", rr);
            });
            return Mono.just(new BasicValidationResult(true,null));
        }
        return responseDtoMono.map(t -> {
            Result vr = (Result) t;
            return vr;
        });
    } else {
        return Mono.just(new BasicResult(true, null));
    }

}

@emeroad Can you please help, As we are blocked due to this issue.

Sorry. It is too difficult to find the problem with the above code.
Please provide a working spring boot sample project

@emeroad This is a case of async call from web Client, where we are doing fire and forget call.
In case, when we are expending result as an when it comes after an async call, things are working fine

@emeroad Please help here.


feat: add knudsen calculation

I add a small util that returns the calculation for the knudsen number at a skimmer at a distance d from the source.
This Knudsen number is computed through basic assumptions (a spherically symmetrical expansion).
Source '''Pauly, Hans. Atom, Molecule, and Cluster Beams I: Basic Theory, Production and Detection of Thermal Energy Beams. Vol. 1. Springer Science & Business Media, 2000.'''

Codecov Report

Merging #6 (97e9f85) into main (4ec2a1c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   69.82%   69.82%
=======================================
  Files           5        5
  Lines         401      401
=======================================
  Hits          280      280
  Misses        121      121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec2a1c...97e9f85. Read the comment docs.


Rebooting for the first time after a vm installation on qemu does not boot

The installation finishes seemingly successfully, then this happens with no way to go around it. I did not select LUKS during the installation and the type is desktop. (see picture attached)
Tried with the most recent ISO and the one from August.

Resolved in Matrix. SeaBIOS is not supported.


Azata Hero Never Surrender Cause All Spellbooks Added

As title says ,  I used sword saints merged azata mysticbooks , when i use lv7 spell hero never surrender I will get all spellbooks added to my charactor

And i test skald and bard will cause this problem.
My game version is 1.1.7f

Duplicate of https://github.com/vikigenius/SpellbookMerge/issues/12


Follow the change of tab interface for UI test

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes
The id of tab interface was changed with this commit (red-ui-tab-link-buttons).  So I followed the change for UI test.
https://github.com/node-red/node-red/commit/a4eb8e11c3df0805ef347eb14ba4c77674638b47
Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage increased (+0.05%) to 73.907% when pulling 11569d80564c60475883f84b4e83f505e48881c4 on node-red-hitachi:uitest-debugtab into f5e212ff1e11b851669e91903d06d2f4a4f7f916 on node-red:0.19.


Edge fails miserably

OS: Windows 10 PRO
Browser: Microsoft Edge 44.18362.449.0
Peer: meething-qvdev.herokuapp
Date: 4/22 1100 pst
Opened 2 tabs to test audio recording. Navbar appeared, no round circle on bottom left
Error messages:

I've tackled some EDGE problems in the past - so I'll try to take a stab on it, as it looks like it's coming from my MutedVideoStream - old ass EDGE not supporting Canvas.captureStream - have to make an ugly polyfill or find other solution for it.- dropping a video element inside the canvas and tie the canvas and video together could work, lol, as old Edge still supports MediaElement.captureStream, something like this:
 // video polyfill for EDGE prior 79(?)
function polyfillVideo(videoElement) {
  const canvas = document.createElement('canvas')
  renderVideoFrame(canvas, videoElement)
  const videoStream = videoElement.captureStream(60)
  return videoStream
}

function renderVideoFrame(canvas, videoElement) {
  const ctx = canvas.getContext('2d');
  ctx.drawImage(videoElement, 0, 0, canvas.width, canvas.height)
  setTimeout(() => renderVideoFrame(canvas, videoElement))
}


Date column coercion bug

Originally posted by @ehsen in https://github.com/datapane/datapane/discussions/50:
I have a pandas dataframe with date column in 'd-m-Y' format, the date column is string not datetime. But when I create datapane report it automatically converts my date to ISO format. Similarly I have another column with int datatype, datapane also converts it into ISO date (which is very weird).
Can you please tell me how can I fix this.

Hi @ehsen - thanks for raising the issue - yes we're actively working on improving our date cocercion support right now and should have a much improved process rolled out shortly.

Hi @ehsen - thanks for raising the issue - yes we're actively working on improving our date cocercion support right now and should have a much improved process rolled out shortly.

closed in c36a4eb

closed in c36a4eb


Set app page title to "NLP Sandbox PHI Deidentifier"

Why was this moved back to in review? I thought we finished this in: https://github.com/nlpsandbox/phi-deidentifier-app/pull/3

@cascadianblue This issue has never been closed so I moved it back to Review. Thanks for the update.