Fix incorrect report total amount after resolving duplicates

Details

When resolving duplicate transactions, the total amount is incorrect. This PR fix it.
Fixed Issues

$ https://github.com/Expensify/App/issues/46449
PROPOSAL: https://github.com/Expensify/App/issues/46449#issuecomment-2257481619
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Go to workspace chat
Submit two same expenses
Click on the expense preview in the main chat
Click on the first expense
Go offline
Click Review duplicates
Click Keep this one on the second expense
Click Confirm on the confirmation page
Go back to the expense report
Verify the total amount is the same as the selected expense amount
Go back to the main chat
Verify the report preview amount is the same as the selected expense amount
Go back to LHN
Verify the total amount of LHN last message is the same as the selected expense amount

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/44965876-3e45-4f0a-a294-3b4502873ba8

Android: mWeb Chrome

https://github.com/user-attachments/assets/e1a6031f-898c-4860-a80c-3e86fdac89a9

iOS: Native

https://github.com/user-attachments/assets/29376bd1-25b1-4bf5-9073-c475f91caf0a

iOS: mWeb Safari

https://github.com/user-attachments/assets/a1b5621d-77e0-4774-8d8f-59ea2e31a7a8

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/a5c1b276-4370-4f66-869b-2b95b80a054d

MacOS: Desktop

https://github.com/user-attachments/assets/f12ad533-8b96-4db2-8df2-86969f6fc265

@akinwale mind helping us move this forward? Thank you!

I'll review today.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/162d1269-c0eb-4d45-9286-d57b3b890737

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.17-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add Jest 23 docs

Summary
Adds Jest 23 docs to the website

Do we need to build it as other versions?

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7922488). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #6254   +/-   ##
=========================================
  Coverage          ?   64.11%
=========================================
  Files             ?      220
  Lines             ?     8500
  Branches          ?        3
=========================================
  Hits              ?     5450
  Misses            ?     3049
  Partials          ?        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7922488...86c5cb9. Read the comment docs.


[Bug] Error when running controller.py

When I run the controller.py script, I get the following error (I just removed the exact folder locations):
PS [...]\StadiaWireless> python controller.py
<IP_ADDRESS>
Connecting to: <IP_ADDRESS>:80
Traceback (most recent call last):
  File "[...]\StadiaWireless\controller.py", line 112, in <module>
    asyncio.run(main())
  File "[...]\Python\Python310\lib\asyncio\runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "[...]\Python\Python310\lib\asyncio\base_events.py", line 646, in run_until_complete
    return future.result()
  File "[...]\StadiaWireless\controller.py", line 109, in main
    async with serve(handler, '<IP_ADDRESS>', port):
  File "[...]\Python\Python310\lib\site-packages\websockets\legacy\server.py", line 1070, in __aenter__
    return await self
  File "[...]\Python\Python310\lib\site-packages\websockets\legacy\server.py", line 1088, in __await_impl__
    server = await self._create_server()
  File "[...]\Python\Python310\lib\asyncio\base_events.py", line 1505, in create_server
    raise OSError(err.errno, 'error while attempting '
PermissionError: [Errno 13] error while attempting to bind on address ('<IP_ADDRESS>', 80): an attempt was made to access a socket in a way forbidden by its access permissions```

Looking online, it looks like Python isn't requesting admin privileges but requires them; however, I am not well versed in python scripting, so I'm not sure how to achieve this. And yes, I am running my terminal in admin mode.

Note: I'm running Windows 11 22H2 at the moment.

Edit: I believe Windows 11 requires admin privileges for more actions than previous Windows versions; this may be the underlying reason. It also seems that there are python modules designed to request admin priviledges out there.

This is rather an issue with the port 80 already being used. Ensure that nothing is running on port 80 or change it to some other port such as 3000 or 8000.
Note: You'll also need to change how it stores the IP into ip.js and add a :port_number at the end of it

So after some testing; this does indeed seem to be the case!
Again, I'm not too familiar with python; but I imagine there is some form of try/get error handling; in which case it might be interesting to include the following:

Step through a list of possible ports,
If a port fails, move on to the next one,
Once a port is found to be free and usable, modify the ip.js directly to include the selected value OR have the list of possible ports stored in the ip.js file, and have it look through the ports until it finds the correct one.

I released a new update this morning. Could you check if it is working?

I get the following error message; which I guess is because the port it's trying to use is still not available?
 * Serving Flask app 'server' (lazy loading)
 * Environment: production
   WARNING: This is a development server. Do not use it in a production deployment.
   Use a production WSGI server instead.
 * Debug mode: off
An attempt was made to access a socket in a way forbidden by its access permissions

The latest release should fix this.


Allowing to affect the current team to go back from other products

Summary
When you switch to boards, there is not an easy way to affect the current team.
The simplest option is to change the store using the selectTeam action from
redux, but that doesn't affect the local storage with the last team. That
implies that when you switch from Channels to Boards in one team, then you
switch to another team, and you go back to Channels again, it use the
"lastTeam" from the localstorage to go to the last viewed team, that is not
the currently selected one (the one that you selected in Boards).
This fix honor the current store information (if it is there) to build the
destination of the "Channels" link, pointing to the right team.
Ticket Link
Focalboard-GH-3498
Related Pull Requests
https://github.com/mattermost/focalboard/pull/3499
Release Note
Fixes navigating back from Boards in a different team.

@jespino Strange we don't seem to have this problem. Are you using the team sidebar or is there another way to switch teams from within boards?

@jespino Strange we don't seem to have this problem. Are you using the team sidebar or is there another way to switch teams from within boards?

You don't have that problem because you can't switch teams inside playbooks, playbooks doesn't use the teams sidebar, but in boards you can go to boards and switch teams, that "switch" action should be respected from mattermost channels, but it is not respected now, because you just use the / route, that brings you back to the last team. For playbooks, makes sense, for boards it's broken.

You don't have that problem because you can't switch teams inside playbooks

@jespino Actually try us out on community and you can see we do have the team sidebar and it works fine. I don't actually see a way to switch teams within boards though. (the team sidebar disappears) I assume you are in the process of adding that?

@crspeller yes, we are adding that, looks like I have locally a older version of playbooks, so I'm not seeing locally the sidebar, I have to take a look about how you are doing it.

@crspeller actually, after investigating it I discover that in your code you are modifiying the localStorage to update the "user_prev_team" key to store the current team when you change it. That is exactly what I was trying to avoid with this PR, but for consistency sake, I did that change to in Focalboard and now is working, but as suggested in the comment in playbooks code, we should provide a better way to handle that from the suite architecture POV.


Does this library supports BLE 5.1 or higher?

Question
Does this library implements communication with BLE 5.1 (or higher)?
Thanks,

am wondering the same ^^^

Yes, the 5.x standard has full support for bluetooth low energy


Raise ecto query errors in MySQL and Postgres

@michalmuskala is doing this in his mongo adapter and we should do the same, otherwise users are stuck with errors like these that do not emit the query:
https://github.com/drewolson/scrivener/blob/master/lib/scrivener.ex#L153
@michalmuskala can you please give us a hand in here and do this change for pg/mysql too?

Sure, I'll take a look at this once the embedding is finished.


Run bundle update

This updates numerous dependencies to the latest versions available in
the Gemfile.
A couple of these updates (activesupport / kramdown) remove versions
with known vulnerabilities.
I've tested this locally by building the example site with
create-test-site.sh - looks like it still works nicely.

I think it's probably best to close this as it's a few months old now. If someone wants to run a fresh bundle update and raise a new PR that's fine. Or we could work through dependabot's PRs.


Added iconic character

This one looks good. I haven't gone through each entry with a fine tooth comb, but I think it's good enough 😉 . Merging.


HTML email support

I'm looking to take charge, are you working on it yet?

No, not working on it. I appreciate contributions.


Latest Docker for Mac - apparent change to port forwarding breaks TCP liveness checks

This long-standing part of our container liveness checks seems to be broken on Docker for Mac from at least beta 14 onwards:
new Socket(ipAddress, port).close();

The original behaviour of this was to simply verify that the relevant TCP port was listening, catching an IOException if the container was not listening yet. However, now Docker for Mac seems to be running its own perpetually listening TCP proxy that accepts the connection regardless of whether there is actually a listening process inside the container.
e.g. outside of testcontainers, this demonstrates the behaviour:
$ docker run -p 8080 -d alpine:latest sh -c "yes | nc -l -p 8080"   # real listening process inside container
$ docker run -p 8080 -d alpine:latest sh -c "yes > /dev/null"   # port mapped, but not listening

$ docker ps
CONTAINER ID        IMAGE               COMMAND                  CREATED              STATUS              PORTS                     NAMES
c77d07ba926c        alpine:latest       "sh -c 'yes | nc -l -"   About a minute ago   Up About a minute   <IP_ADDRESS>:32822->8080/tcp   small_mirzakhani
871c2c80ceaf        alpine:latest       "sh -c 'yes > /dev/nu"   6 minutes ago        Up 6 minutes        <IP_ADDRESS>:32821->8080/tcp   tender_raman

$ lsof | grep LISTEN
[.. snip ..]
com.docke 1481 rnorth   11u    IPv4 0x90cfe27e6cde7eb3         0t0      TCP *:32821 (LISTEN)
com.docke 1481 rnorth   13u    IPv4 0x90cfe27e6a3ab7ab         0t0      TCP *:32822 (LISTEN)

This seems to make the current wait check too dumb!
I'd be keen to know if others are experiencing this.
I suspect the fix should include opening an inputstream and verifying that the first read doesn't indicate end-of-stream, but I'd like to do some checking to be sure that this doesn't have unintended consequences.

Scratch that idea as a potential fix - as I suspected, it only works where the container process has something to send and doesn't wait for data from the client first.

Brief update: doing the equivalent of docker exec <id> cat /proc/net/tcp might potentially be a solution for checking whether the container is listening on a port, but for test cases at least it's impeded by gliderlabs/docker-alpine#143. It seems that a netcat process in the container (as used for simulating a simple running server in the testcontainers test suite) does not expose listening port data in the TCP socket table for some reason.

Should be fixed in a later DfM beta, as per this post: https://forums.docker.com/t/port-forwarding-of-exposed-ports-behaves-unexpectedly/15807/2

Current recommended workaround for this issue is to implement a custom service-specific WaitStrategy that checks the service is correctly running. e.g. use an actual client library for the service to check, such as in 64d3451.

@rnorth got bitten by this issue. Looks like it's not fixed in the latest release of DfM. Do you have any ideas what to do with it?

Ah, interesting @bsideup. The workaround (that IIRC @outofcoffee has used) is a service-specific wait strategy. e.g. to change the test from 'is the socket listening?' to 'does the socket talk HTTP?'
It's frustrating. Your workaround is very clever; I'd tried something similar but not as elegant 😆
I think bringing this into TC and making it the default might be a hack too far, but perhaps there's some merit in making it available so people can opt-in..? I like the principle of us doing the hard/dirty work so that users don't have to 😄

@rnorth doing it right now (bash-based port check in Docker for Mac environment), will send PR soon


ARROW-12671: [C++] Add OpenTelemetry to ThirdpartyToolchain

As discussed on the mailing list, this is a proof-of-concept that integrates OpenTelemetry for (distributed) tracing. This supports the following:

OTel is used as a header-only library by default.
Optionally, Arrow will link to OTel and configure it based on an environment variable.

No other instrumentation is added; this just sets up the build, and then we can consider what to instrument (FlightRPC, query engine, etc.) and also integrate more backends (Jaeger, OTLP, etc.).

ML link for discussion: https://lists.apache.org/thread.html/re0db1b4d7a82f4cdb7bfab4bdd3620a9b3813a22626800d9772ccbda%40<dev.arrow.apache.org>

I've enabled the OTLP build, with caveats:

It will not work with bundled gRPC/Protobuf since OTel appears not to declare a dependency on gRPC from its Protobuf module. (I need to replicate and report upstream, though I'm having issues getting OTel to build in general right now.)
Even though we enable only the OTLP HTTP exporter here, we still need gRPC because the upstream build always depends on both.
I haven't actually wired up the exporter for use yet.
I'll also get it building against "system" OTel next (assuming you specify it via CMAKE_PREFIX_PATH, since we don't have Conda/vcpkg/system package manager packages).

@lidavidm Do you have an example somewhere? I am happy to help try to spin things up and see where I get stuck (my success there wouldn't block this PR in any way)

Example of which part in particular? For this PR, you can just try checking it out and building with -DARROW_WITH_OPENTELEMETRY=ON

I don't have that right now, unfortunately - the other issue is that if we had such a C++ application then this would be moot (you would just link and configure OTel yourself), here I'm trying to just target the case of the Python/R bindings and for local development.
I could strip all this out and maybe leave only the OStream exporter for local development, but that doesn't really help (say) people trying to analyze the R TPC-H benchmarks since they won't be able to get the data in any usable form.

Now this can build against a system-installed OTel, and you can enable the OTLP HTTP exporter (I checked that this works for me, thanks for the pointers).

What is left to do on this?

Tests are passing here, so we just need a reviewer, we should check that nightlies pass.

@github-actions crossbow submit -g nightly

Most of the nightly failures look unrelated, however, the Almalinux/Amazon Linux/CentOS builds are failing because of "Installed but unpackaged file(s) found", so I need to fix that:
Checking for unpackaged file(s): /usr/lib/rpm/check-files /root/rpmbuild/BUILDROOT/arrow-7.0.0.dev103-1.el8.x86_64
error: Installed (but unpackaged) file(s) found:

RPM build errors:
   /root/rpmbuild/BUILD/apache-arrow-7.0.0.dev103/cpp/build/opentelemetry_ep-install/include/opentelemetry/baggage/baggage.h
…snip…

(Autobrew and vcpkg are failing on default. Note that the vcpkg error looks like the one we saw during 6.0.0 verification: I would guess we're both building vcpkg and installing it as a dependency, and then using the headers of one but linking against the other.)

Most of the nightly failures look unrelated, however, the Almalinux/Amazon Linux/CentOS builds are failing because of "Installed but unpackaged file(s) found", so I need to fix that:
Checking for unpackaged file(s): /usr/lib/rpm/check-files /root/rpmbuild/BUILDROOT/arrow-7.0.0.dev103-1.el8.x86_64
error: Installed (but unpackaged) file(s) found:

RPM build errors:
   /root/rpmbuild/BUILD/apache-arrow-7.0.0.dev103/cpp/build/opentelemetry_ep-install/include/opentelemetry/baggage/baggage.h
…snip…

(Autobrew and vcpkg are failing on default. Note that the vcpkg error looks like the one we saw during 6.0.0 verification: I would guess we're both building vcpkg and installing it as a dependency, and then using the headers of one but linking against the other.)

Sorry for the trouble @kou, but do you know what's going on with the RPM build error? It appears opentelemetry_ep-install gets left behind in /root/rpmbuild/BUILDROOT/arrow-7.0.0-0.dev20211101.el8.x86_64/root/rpmbuild/BUILD/apache-arrow-7.0.0/ and so rpmbuild complains, but I can't figure out what is responsible for cleaning up the rest of the build files (ninja clean on my local machine doesn't actually delete them)

https://github.com/ursacomputing/crossbow/runs/4193651802?check_suite_focus=true#step:8:1827 shows ninja install runs steps for opentelemetry_ep. This may be related. Generally, ninja install doesn't need to run steps for opentelemetry_ep.

Hmm, indeed, thanks for spotting that. I'll take a further look.

@github-actions crossbow -g submit almalinux-8-amd64 centos-8-amd64

@github-actions crossbow submit almalinux-8-amd64 centos-8-amd64

@github-actions crossbow submit -g nightly

@github-actions crossbow submit almalinux-8-amd64 centos-8-amd64

It looks like things are generally passing here - any objections?

I think I've addressed all feedback here (thanks Kou for the detailed review!). Any other comments?

I'm curious: why are gRPC and protobuf required?

This PR configures the OTLP exporter so we can dump collected data somewhere where we can analyze it. The OTLP exporter talks to the OTLP collector over either HTTP or gRPC, using Protobuf payloads, so at least Protobuf and one of cURL and gRPC is required. We only enable the HTTP protocol, but the upstream CMake config currently doesn't differentiate between whether you have gRPC enabled or not when generating Protobuf stubs, so gRPC is unconditionally required. (See https://github.com/open-telemetry/opentelemetry-cpp/issues/1045.) I think this may have just been fixed.

It would be nice to make gRPC at least optional, as it's a rather heavy dependency.

The fix https://github.com/open-telemetry/opentelemetry-cpp/commit/eca856df5c2f3e73bd57a7d84d7476ca62f40e80 is in v1.1.0 so we should be able to remove the gRPC dependency in ARROW-14957.


fMRI prep error on magnitude1 fieldmap in /extra_data folders despite .bidsignore file including /extra_data folder

What happened?
I tried to run fMRI prep, but it failed and gave the following output: fMRIPrep failed: The 'mag_files' trait of a _CheckRegisterInputSpec instance must be a list of from 1 to 2 items which are a pathlike object or string representing an existing file, but a value of ['/project/3033003.02/bids/sub-001/ses-mri02/extra_data/sub-001_ses-mri02_acq-fieldmap_magnitude1.nii.gz', '/project/3033003.02/bids/sub-001/ses-mri02/fmap/sub-001_ses-mri02_acq-fieldmap_magnitude1.nii.gz', '/project/3033003.02/bids/sub-001/ses-mri02/fmap/sub-001_ses-mri02_acq-fieldmap_magnitude2.nii.gz'] <class 'list'> was specified.
indicating that it is not allowed to have more than two magnitude fieldmaps in the bidsfolder per sub-ses.
An extra magnitude1 fieldmap is present in the /extra_data folder as result of a skullstripping step. This /extra_data folder should be ignored, as indicated in de .bidsignore file, but fMRI prep still fails.
Please find the .bidsignore file below:

What command did you use?
# Run step 4. Run preprocessing with FMRIPREP (-f: fmriprep)
        if args.fmriprep is True:
            # If specific session specified create json file to filter bids input for fmriprep
            if sessions:
                # Adapt default fmriprep bids queries to include session numbers and create json file to filter bids input for fmriprep
                query={
                    "fmap": {"datatype": "fmap", "session": sessions},
                    "bold": {"datatype": "func", "suffix": "bold", "session": sessions},
                    "sbref": {"datatype": "func", "suffix": "sbref", "session": sessions},
                    "flair": {"datatype": "anat", "suffix": "FLAIR", "session": sessions},
                    "t2w": {"datatype": "anat", "suffix": "T2w", "session": sessions},
                    "t1w": {"datatype": "anat", "suffix": "T1w", "session": sessions},
                    "roi": {"datatype": "anat", "suffix": "roi", "session": sessions}
                    }
                filterfile = Path(dirs['log']).joinpath("bids_filter_fmriprep.json")
                with filterfile.open('w') as filtfile:
                    json.dump(query,filtfile,indent=4)

            # Build command
            if sessions:
                cmd = f"fmriprep_sub.py {dirs['bids']} -o {os.path.join(dirs['deriv'],'fmriprep')} -m 40000 -p {subject} -a ' --output-spaces MNI152NLin6Asym:res-2 --bids-filter-file {filterfile}' -q ' -e {dirs['log']} -o {dirs['log']}'"
            else:
                cmd = f"fmriprep_sub.py {dirs['bids']} -o {os.path.join(dirs['deriv'],'fmriprep')} -m 40000 -p {subject} -a ' --output-spaces MNI152NLin6Asym:res-2' -q ' -e {dirs['log']} -o {dirs['log']}'"

            # Add --force option if requested, otherwise only the newline character, and write the command to the jobfile
            if args.force is True:
                cmd = cmd + " -f\n"
            else:
                cmd = cmd + "\n"
            jobfile.write(cmd)

What version of fMRIPrep are you running?
23.1.0
How are you running fMRIPrep?
Singularity
Is your data BIDS valid?
Yes
Are you reusing any previously computed results?
No
Please copy and paste any relevant log output.
Error file:

You are using fMRIPrep-23.1.0, and a newer version of fMRIPrep is available: 23.1.4.
Please check out our documentation about how and when to upgrade:
https://fmriprep.readthedocs.io/en/latest/faq.html#upgrading
(node:29970) Warning: Closing directory handle on garbage collection
(Use `node --trace-warnings ...` to show where the warning was created)

Output file (last sentence):

240109-13:22:24,479 nipype.workflow CRITICAL:
	 fMRIPrep failed: The 'mag_files' trait of a _CheckRegisterInputSpec instance must be a list of from 1 to 2 items which are a pathlike object or string representing an existing file, but a value of ['/project/3033003.02/bids/sub-001/ses-mri02/extra_data/sub-001_ses-mri02_acq-fieldmap_magnitude1.nii.gz', '/project/3033003.02/bids/sub-001/ses-mri02/fmap/sub-001_ses-mri02_acq-fieldmap_magnitude1.nii.gz', '/project/3033003.02/bids/sub-001/ses-mri02/fmap/sub-001_ses-mri02_acq-fieldmap_magnitude2.nii.gz'] <class 'list'> was specified.

Additional information / screenshots
No response

Sorry for not responding sooner, and I'm not on my computer so I'm not prepared to look at this in detail.  If you have things that you're ignoring that interfere with fmriprep's logic, ignoring them won't help. It'll just stop the validator telling you about them.

Sorry for not responding sooner, and I'm not on my computer so I'm not prepared to look at this in detail.  If you have things that you're ignoring that interfere with fmriprep's logic, ignoring them won't help. It'll just stop the validator telling you about them.

Thanks for your reply! For now I just work around this issue by moving these files to a different folder in the derivatives. Would there be another way to let fmriprep ignore these files?

@lianneremie , did you fill your fieldmap json files with IntendedFor to tell which functional images need to be corrected?
I am thinking about this discussion.
But perhaps the error you received is triggered before this filtering happens.
Anyway, I would recommend to have your dataset BIDS compatible if possible to start with, and to always move this folder  extra_data somewhere else (for instance in sourcedata/ folder).

@julfou81 My dataset is BIDS compatible, my folder looks like this:

The .bidsignore file is directly under the /bids folder, but indeed I think it is only used for the bidsvalidator at the start of fmriprep.
The extra_data folders is subject-session specific, so I think it should stay where it is as it also contains other data (like QSM files). Or do you still suggest another location?
I do not use IntendedFor fields (as this gave problems earlier) but I link by functional scans to the fieldmaps using the B0fieldIdentifier and B0fieldSource fields. This might be the problem, as the B0fieldIdentifier tag is still there in the magnitude1 image within the extra_data folder.

ok, I forgot that extra_data/ was part of the BIDS specification. Indeed, you should not need to remove it then.
How does your bids-filter file looks like?
Yes, maybe removing the B0FieldSource in the json files in the extra_data/ folder will help?

Okay, catching up on all of this:

.bidsignore does not make a dataset valid; it hides invalid bits from the validator. This is for the purpose of adding yet-to-be-standardized features to your dataset so that you don't have to contort the dataset by hiding your regular data in sourcedata/ or similar. It is use-at-your-own-risk, though, and surprising behavior of BIDS Apps is one of the risks.
I don't understand why scans.tsv or perf/ are being ignored. Both of these are in BIDS, so ignoring them would be concerning if I were reviewing a dataset. On the other hand, fMRIPrep won't do anything with these, so they're fine here.
extra_data/ is not part of the BIDS specification, and I would hope that data could be labelled more informatively in a way that is actually queryable (and hence excludable from queries). If they're just additional runs of fieldmaps, then you could still include them in fmap/ but use acq- or run- or similar to distinguish them from other fieldmaps. Your BIDS filter file could include the known good acquisition/run.
B0FieldIdentifier is meant to be used to identify scans that are used to create a single fieldmap estimate. If two scans are not meant to be used together, they should have different identifiers.


Message#getCategory()

General Troubleshooting

[X] I have checked for similar issues on the Issue-tracker.
[X] I have updated to the latest JDA version
[X] I have checked the branches or the maintainers' PRs for upcoming bug fixes.

Expected Behaviour
Message#getCategory() calls Message#getGuildChannel() while getGuildChannel() throws an exception when the message isn't from a guild, but the docs states that getCategory() should return null.
Document of Message#getCategory()

Source code of Message#getCategory()
Source code of Message#getGuildChannel()
Code Example for Reproduction Steps
public class MessageEvent extends ListenerAdapter
{
	@Override
	public void onMessageReceived(MessageReceivedEvent event)
	{
		event.getMessage().getCategory();
	}
}

Code for JDABuilder or DefaultShardManagerBuilder used
JDA jda = JDABuilder.createDefault(args[0]).addEventListeners(new MessageEvent()).enableIntents(GatewayIntent.MESSAGE_CONTENT).build();

Exception or Error
java.lang.IllegalStateException

Fixed in 5.0.0-beta.13


Sonyliv & Hotstar

Hi there,
First of all thanks  for the amazing work that you guys are doing its really appreciated,  would like to ask is it possible to have a sonyliv & hotstar  addon  that works  out of india...? at least the shows  ?  the zee5 add on  works perfect and its amazing
Thanks a lot  once again,
and keep up tha amazing work

I guess this seems probably impossible because the cdn of SonyLIV and Tata Sky are georestricted
@iMro0t  could try something with vpn or @Taburientelp1 probably you yourself can work with Indian VPN

This is not possible due to geo-restriction. You can use "some kind" of services to bypass that.


No indication of number of learning credits a workshop takes

Summary
When registering for a workshop there is no indication of how many learning credits a project takes when registering for it. It would be nice if this information was presented in the workshop information.
Severity
High

Updated learning credits rules explicitly in home tab. Thanks for bringing up this suggestion.


axocover should not automatically update settings.json

I have the following issue:

I am on my master branch

This is how my settings.json file looks
{
  "TestRunner": "",
  "TestPlatform": "x86",
  "TestApartmentState": "STA",
  "TestAdapterMode": "Integrated",
  "IsRedirectingFrameworkAssemblies": true,
   ...
}

I switch to an old topic branch where the settings file looks different (i.e. IsRedirectingFrameworkAssemblies) is missing.

{
  "TestRunner": "",
  "TestPlatform": "x86",
  "TestApartmentState": "STA",
  "TestAdapterMode": "Integrated",
   ...
}

Now the file is instantly under pending changes because axocover added the new setting. Trying to switch to another branch fails because settings.json has been modified.
I think axocover should only persist changes into settings.json after making a change to settings tab.

 There was a mistake in the implementation. Now I fixed it, so it should work properly.


main.py instantly closes after opening

installed reqs etc updated python still closes

C:\Users\becky\Downloads\Twitch-Account-Creator-main (1)\Twitch-Account-Creator-main\main.py:26: DeprecationWarning: firefox_profile has been deprecated, please use an Options object
profile = webdriver.FirefoxProfile()
now i get that

The deprecation warning is not an issue, the program uses a version of selenium where it still works

Which version?

The version in the requirements.txt file, if you followed the installation instructions you should have the correct version


Support base > 3

Hi Mikhail,
I just released monad-control and already got my first bug report :-) about the package not building on older GHCs.
The attached patch lets transformers-base build from ghc-6.12.3 onwards.
It would be great if you can create a <IP_ADDRESS> release with this change.
Thanks,
Bas

Done, thanks for the patch.


fix(chat): add tooltip for conversation settings icon (Issue #2842)

Description:
Tested on staging env in mobile device: there is proper tooltip on model icon click (ok), but there is no tooltip on conversation setting (need to be implemented)

Issues:

Issue #2842

UI changes

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review

/deploy-review


[Bug]: badger as sampling store not work

What happened?
Error starting "storage factory of type badger does not support sampling store"
badger storage not implement SamplingStoreFactory interface -> no method CreateLock
Steps to reproduce
docker run --rm --env SAMPLING_STORAGE_TYPE=badger --env SAMPLING_CONFIG_TYPE=adaptive jaegertracing/all-in-one:1.51.0
Expected behavior
work with badger as sampling store
Relevant log output
No response
Screenshot
No response
Additional context
No response
Jaeger backend version
v1.51.0
SDK
No response
Pipeline
No response
Stogage backend
badger
Operating system
Linux
Deployment model
Docker
Deployment configs
No response

Should've been solved by #4834 -- cc @slayer321

@saletnik Implemented CreateLock method, earlier while working on the #4834 I totally missed Implementing that , I think as there was not lock required for badgerdb that was the reason I missed it.
@yurishkuro I have create a new PR with the changes  PTAL

now it is working
Thank you


Specify tag to jupyter/scipy-notebook image

close #115
scipy.misc.bytescale method does not exists in  jupyter/scipy-notebook:latest docker image, because latest image contains scipy 1.6.3. scipy.misc.bytescale module was deprecated when v1.0.0 was released.
I specified tag to jupyter/scipy-notebook image.
https://hub.docker.com/layers/jupyter/scipy-notebook/387f29b6ca83/images/sha256-d4953b52e6a53736aab92b5f82a764f71f8592851a54dff513e0c82ba1cc6c02?context=explore
import sys
sys.version
# '3.5.2 |Continuum Analytics, Inc.| (default, Jul  2 2016, 17:53:06) \n[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)]'

import scipy
scipy.__version__
# '0.17.1'

This tag was added here:
https://github.com/jupyter/docker-stacks/pull/344

thanks a lot @yuji38kwmt


tutorial updates and permission url fixed

Questions:

cant assign groups to labs, now have to go to lab and create new lab to associate with groups. I don't know much about how the labs work, just wondering can we have multiple groups in one lab? for example in a huge lab, we have several small groups working on different sub-areas, could that be a case in science?
wondering if it's better to add a dialog box when deleting the group “type i am sure i want to delete the group” or stuff like this, since deleting a group could have a huge impact if it's mistakenly happened.

Hi Mingze,
It's a great idea with the warning dialog. I believe we have to revisit labs and groups to make it clearer and change how a lab is associated with a group, as the current workflow is a little hard to understand.


Presentation (This Thursday)

We Present for our class this Fri.
If possible we would like to present at our normal time on Thursday.
Our Classes End Next week.
Will this work?

Was the normal time 3pm?

Yes

ok that will work. Thursday at 3pm!


[request for assist]:  what is the gpu arc required

currently, i am using gpu arch compute_89. however it throws below error during build
 nvcc fatal   : Unsupported gpu architecture 'compute_89'

my cmake version is 3.27.6
cuda toolkit version is
Cuda compilation tools, release 11.7, V11.7.99
Build cuda_11.7.r11.7/compiler.31442593_0

Hey @cliff0412,
We support CUDA Toolkit version 12.0 or newer.
https://github.com/ingonyama-zk/icicle/tree/main/icicle#readme

it compiles successfully after upgrade to v12.

it compiles successfully after upgrade to v12.

Great to hear! Thanks for helping us improve the documentation.


Service executes before any wifi devices exist

From what I understand, the Beaglebone Debian behavior on startup has apparently changed such that this service runs before the WiFi devices exist. This may only be true for USB, but that appears to be a common scenario.
Here is the link to the Beaglebone Google Group where I've been documenting my travails.
Anyway, I will shortly offer a pull request that I believe should fix the problem.

I'm having the same issue
root@lasersaur:~/wifi-reset# systemctl status wifi-reset.service
● wifi-reset.service - Wireless Network Reset
   Loaded: loaded (/lib/systemd/system/wifi-reset.service; enabled; vendor preset: enabled)
   Active: failed (Result: exit-code) since Tue 2019-07-09 09:34:25 UTC; 3min 28s ago
  Process: 669 ExecStart=/bin/bash /opt/wifi-reset/wifi-reset.sh (code=exited, status=1/FAILURE)
 Main PID: 669 (code=exited, status=1/FAILURE)

Jul 09 09:29:34 lasersaur systemd[1]: Starting Wireless Network Reset...
Jul 09 09:33:55 lasersaur bash[669]: ifdown: unknown interface wlan0
Jul 09 09:34:25 lasersaur bash[669]: ifup: unknown interface wlan0
Jul 09 09:34:25 lasersaur systemd[1]: wifi-reset.service: Main process exited, code=exited, status=1/FAILURE
Jul 09 09:34:25 lasersaur systemd[1]: Failed to start Wireless Network Reset.
Jul 09 09:34:25 lasersaur systemd[1]: wifi-reset.service: Unit entered failed state.
Jul 09 09:34:25 lasersaur systemd[1]: wifi-reset.service: Failed with result 'exit-code'.


Issues getting started

Summary
I had a few problems getting started. Long time since i've used yarn or done any serious ts work.
Opening up the repo, I notice not all packages are listed in the README. Not sure why.
Using nix, there's a dev environment. I would assume this means I can skip the "setup" step in the README.
But I can't see local imports
$yarn test
➤ YN0000: [@cardano-sdk/cardano-services]: Process started
➤ YN0000: [@cardano-sdk/cardano-services]: Error: Jest: Got error running globalSetup - /home/waalge/clones/cardano/cardano-js-sdk/packages/cardano-services/test/jest-setup/jest-setup.ts, reason: [TSError: test/jest-setup/jest-setup.ts:1:28 - error TS2307: Cannot find module '@cardano-sdk/util-dev' or its corresponding type declarations.

Doing yarn install does not resolve this.
The readme says I can run
$nix run .#config-update
warning: Git tree '/home/waalge/clones/cardano/cardano-js-sdk' is dirty
error: flake 'git+file:///home/waalge/clones/cardano/cardano-js-sdk' does not provide attribute 'apps.x86_64-linux.config-update', 'packages.x86_64-linux.config-update', 'legacyPackages.x86_64-linux.config-update' or 'config-update'

I don't remember how nixstd works wrt this, if I ever did know.
Steps to reproduce the bug
.
Actual Result
.
Expected Result
.
SDK version
69e4fe9f69a5354208d3f02c9829b4a0feb689b1
Environment type

[X] Node.js
[ ] Browser
[ ] Browser Extension
[ ] Other

Environment details
nixos devshell

I'm not aware of anyone using nix for cardano-js-sdk dev environment. We're using nix for deployments

The README currently suggests it's supported, and nix comes with a devshell.
Happy to help try fix that. Alternatively can it be removed?
In anycase is there an obvious reason why local dependencies aren't being found?

Just tested it from devshell. yarn install && yarn build && yarn test seems to do the job

Closing due to no activity, assuming the solution worked

The readme still says you can use nix

@waalge if you’re not using direnv to enter the devshell, you can first run:
❯ nix develop .#x86_64-linux.local.envs.main

and then, inside that shell:
❯ yarn install && yarn build && yarn test

@michalrus direnv or otherwise, the README is still out-of-date :shrug:


Structured BundleRoles

How Roles Work Now

Each Bundle definition (optionally) stores an enumerated set of Roles, by that name.

These must be python enums, i.e. instances of EnumMeta.

Each BundleInstance has an (optional) value from this enumeration named role.
Signal members of those bundles have source and destination attributes, which use roles to set port directions.

Proposal

BundleRole becomes a custom type
Each Bundle definition stores a set of them, which would most commonly be created from a Roles function:

@h.bundle
class MyBundle:
  Host, Device = h.Roles(2)

# Or

@h.bundle
class MyBundle:
  Host, Device = 2 * h.Role()

Calling a Role is a shorthand to generate a BundleInstance with that role. E.g.:

@h.module
class HostModule:
  my_bundle_port = MyBundle.Host()

The generated BundleInstances would be port-visible by default. An optional visibility argument would override this.

Sets of roles, tentatively called RoleSets, can be created from Python enums (EnumMeta). This would be the primary means of sharing them between Bundle definitions

class HostDeviceEnum(Enum):
  Host = auto()
  Device = auto()

HostDevice = h.Roles.from_enum(HostDeviceEnum)

@h.bundle
class AnotherBundle:
  roles = HostDevice

@h.bundle
class YetAnotherBundle:
  Roles = HostDevice # Capital R also works

The naming convention for roles would be that of typical Python classes, i.e. camel-case.

At various points they "look like"

(a) Constructors for Bundle instances,
(b) Class attributes,
(c) Enum variants

Each has a different recommended, idiomatic naming convention. The one that I'd prefer to "stick" (mentally) is probably (a), for creation of bundle instances with each role.

Outlook: after v2.0


Option system improvements

This PR aims to tackle several outstanding issues regarding the option system. To start with, issue #1105 has been resolved. This PR is currently WIP and I'll mention the other issues that have been addressed here as I get to them.
Edit: This PR now addresses issue #625 as well.

@philippjfr I think it is ready to review/merge once the tests pass. Even if it isn't perfect, it addresses the two issues mentioned and I can fold any subsequent feedback into my next PR which is also about the options system and a bit more involved.

Looks good, glad this is getting validated (again?).


Make tests not depend on exact thread name of 'main' thread

This is important because the thread name could be something other than
main.
So long as it is a string that's close enough
Fixes #27

LGTM :shipit:

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

LGTM LGTM

@colinsurprenant thanks thanks


In-app Archives of Nethys SRD Search Tool

Unfortunately, adding direct AONSRD hyperlinks within distributed Foundry mods (even if not for profit) is disallowed by the CUP license.
However, something to serve this purpose is still highly desirable.
I suggest: A Search Tool, similar to Search Anywhere.
It would ideally work to allow users within FVTT to search AONSRD from within the app, the query opening in a new browser tab utilising AONSRD's already-existing Search functions.
The benefits of this is that it would provide are all fundamentally to do with community solidarity, and ease of transition to Starfinder in Foundry for folks coming from elsewhere.
Being the official SRD for Paizo ttrpgs, AON is the device that everyone uses and trusts as a first port of call (outside of the actual books themselves). To keep this connection would make it very comfortable for people wanting to get into Starfinder from elsewhere, and teach good habits to anyone experiencing SF via FVTT as their first.
Additionally, if an Entity's accuracy in an SF compendium were ever called into question then the ability to search it up on AON for clarification quickly and in-app would be very useful.
This kind of thing happens multiple times per session, in my experience. I'm very proficient in the use of the books themselves but not everyone is going to have them, or the time to learn them back to front.

 [FEAT] In-app Archives of Nethys SRD search tool


[Bug]: Node 22 punycode and fs.Stats is deprecated error message

💭 Describe the feature
punycode

Deprecated since: v7.0.0

Source Code: lib/punycode.js
The version of the punycode module bundled in Node.js is being deprecated. In a future major version of Node.js this module will be removed. Users currently depending on the punycode module should switch to using the userland-provided Punycode.js module instead. For punycode-based URL encoding, see url.domainToASCII or, more generally, the WHATWG URL API.
💡 Proposed Solution
Please replace with Punycode

I'm currently using this as a workaround for Node 22.2
NODE_OPTIONS="--no-deprecation" npx czg

Could u provide node version and start up error message

Thanks for reviewing, let me know if you want/need more information.
(node:91890) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
    at node:punycode:3:9
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:398:7)
    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:337:10)
    at loadBuiltinModule (node:internal/modules/helpers:96:7)
    at Module._load (node:internal/modules/cjs/loader:1037:17)
    at Module.require (node:internal/modules/cjs/loader:1271:19)
    at require (node:internal/modules/helpers:123:16)
    at /xxxxxxx/node_modules/czg/lib/index.js:104:268891
    at /xxxxxxx/node_modules/czg/lib/index.js:1:663
    at /xxxxxxx/node_modules/czg/lib/index.js:104:285695
<EMAIL_ADDRESS>
❯ node --version
v22.2.0

Upstream node-fetch error, I'll see if there is a way to deal with it.
https://github.com/node-fetch/node-fetch/issues/1797
https://github.com/openai/openai-node/issues/527

Thank you for pointing out the issue with this node@22 version.
I have currently released a pre-release version 1.9.4-beta.1 for testing.
I plan to conduct tests over the weekend.
During this period, you can try it out and discover more issues. Thanks again.
npm install -g czg@next

Thank you for the quick response!  This resovled my issue.


Pcjco provider manager

Fix search filter with M3U source
Fix call to verify_url()
Sync with 1.5.9

This PR could be deleted as https://github.com/ozankaraali/QiTV/pull/21 is more up-to-date

As your request, I am closing this PR and keeping #21 for now, thanks! @pcjco


Xtransformer Predict - Threshold

Hello,
Is there a way to filter predictions with threshold probability (such as predict a label if only > 0.7 probability score)?

@jiong-zhang Please let me know if any thoughts.

I found threshold parameter and there is one for each model(matcher, ranker, indexer). Is this correct one to assume that if I want models to predict more confident labels, let's not say predict only if probability of last layer is > 0.6?
Is there relevance of threshold during the training?


Investigate unexpected sumstats+metadata submission by external user

An external user seems to have been able to create a sumstats + metadata submission for a publication (https://www.ebi.ac.uk/gwas/depo-curation/submissions/661e2936d222f50001984929), even though there was already curated data for the publication in the curation database, and a metadata-only submission already existed (https://www.ebi.ac.uk/gwas/depo-curation/submissions/62823f4e28d70900018e63e1). This should not occur, because the presence of an existing metadata submission should cause a study to appear as CLOSED FOR SUBMISSION and therefore prevent any new metadata submissions.
This is a possible loop-hole in the process, which needs further investigation.
Relevant background:

The original metadata-only submission was created by Lizzy in 2022.
The author later made a sumstats-only submission and attempted to add additional studies to the pre-filled template, which is impossible, therefore their submission was INVALID.
The author emailed to ask us to add the additional studies to the Catalog.
I (@eks-ebi) unpublished the original curated studies using the curl command, in order to edit the metadata-only submission and add the new requested studies.
We deleted the invalid sumstats-only submission in order to allow the changes to the metadata-only submission to be imported into the curation app: see goci #1286
I could not import the updated metadata-only submission at first, and asked @sajo-ebi to manually change the publication status, in order to enable the import. I'm not sure from the notes in goci #1286  whether any action was done at this point, or whether the import was re-enabled simply by waiting overnight.
The next day, I was able to import the updated metadata-only submission.
It seems that at some point after the status was changed (if it was) and before I actually imported the updated metadata-only submission, the author created the new sumstats + metadata submission.

@sajo-ebi will add details of investigation

@sajo-ebi We discussed this morning that since there is no clear explanation for this situation, we can go ahead and clean up the two submissions. I have now saved a copy of the sumstats, so I am ready for you to delete the author’s submission: 661e2936d222f50001984929.

@eks-ebi the submission '661e2936d222f50001984929' has been deleted

Thanks @sajo-ebi !

I'll leave the ticket open for you to add any details from the investigation

I investigated the DB & code couldn't find any scenario where the user can create two submissions, the logs are not there to determine what exactly happened


unexpected caching when queryKey is undefined

Describe the bug
When running useQuery with no queryKey (ie queryKey = undefined), cached result is shared with all queries having queryKey = undefined! This is especially confusing because it happens even when useQuery is enabled: false.
I understand it is technically the same queryKey, but I would expect caching to be disabled when queryKey is undefined.
Shouldn't undefined be an invalid?
(type is currently (string | number)[] | undefined)
Your minimal, reproducible example
👉 CodeSandbox
Steps to reproduce

make two queries without queryKey
execute the first, disable the second
see both have the same value

Expected behavior
Skip caching when no queryKey is supplied
-or-
prevent queryKey: undefined. (like we are required to use queryKey: [1] and not queryKey: 1)
(Might already be blocked in v5? not sure)
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform

MacOs 14.2.1
Chrome 120

Tanstack Query adapter
react-query
TanStack Query version
4.28.0 (also happens in codesandbox using v5.17
TypeScript version
4.9.5
Additional context

queryKey is most definitely required on useQuery:
https://github.com/TanStack/query/blob/96cdb28d311772774323c05a75372ed05eedfde8/packages/react-query/src/types.ts#L24
We don't guard against any input that isn't valid typescript

@TkDodo - I think it might be a problem with ^4.x.x, I only get a typescript error in v5.
Maybe patch v4 to prevent undefined queryKey?

can you show a typescript playground please ?

you are right, this doesn't error:
useQuery({
    queryKey: undefined
})

but this does:
useQuery(undefined)

https://www.typescriptlang.org/play?ssl=7&ssc=20&pln=7&pc=1#code/JYWwDg9gTgLgBAbzgVwM4FMCKz1QJ5wC+cAZlBCHAOQACMAhgHaoMDGA1gPRTr2swBaAI458VOJ05wYeMOlQAuOADcALACh1aLKLwAKBOrjG4I3HgDS6PEuSMAJuhLBG6e+sIBKTduzm9do7OrvbeQA

I love not being wrong. :p
it should be as simple as making queryKey non-optional, no?


Mark account.build_storage_slots as optional

account.build_storage_slots is only returned if the builds scope has been granted. This can cause a MissingFieldException in GW2APIClient when trying to use the v2/Account endpoint with an API key that doesn't have the builds scope.

If you have an immediate use case, please let me know and I'll try to get a trimmed-down release out quicker.

Don't worry, I switched to an API key that has the builds scope in order to workaround this issue, so it's not important.

On another note, I'm sorry that you had to dive into the DSL without basically any documentation. The project is not exactly easy to work with for new contributors yet.

It was pretty easy actually! All I had to do was search for build_storage_slots and I just looked at other nullable properties to figure out how to make it nullable.


Is is possible to run this without Google Cloud?

The project seems to rely on Google Cloud. Is it possible to self-host it outside Google's infrastructure, or is it tied to Google?

It's somewhat tied to GCP right now. The app itself can run in any Python 3 WSGI container, but it uses Google Cloud Datastore (via ndb) and Cloud Tasks. It shouldn't be too hard to migrate from Tasks to a different task scheduler, eg Rabbit, but migrating from Datastore to a different database would take some work. Definitely doable though!
I haven't put much work into supporting alternatives because it's designed to be a single-instance service, not something that users install and run. I'm open to it though, PRs are welcome!

@kuba-orlik What are you imagining?

Understood! PRs are welcome. And there are lots of other POSSE options and projects! Many of us in chat have experience here, feel free to jump in and ask.

Yeah, I've got that part. But I was more thinking along the lines of on-premise (say, on Hetzner VPS) or in another cloud provider etc.
Please, share a summary of the chat here if you found a solution.

I prefer hosting on a VPS, as that makes it the easiest to switch providers.
This idea is slowly cooking in my head, will report here when there's some progress :)

@kuba-orlik is your idea to migrate Bridgy away from Google Cloud Datastore and Tasks? Or something else?
I don't plan to migrate https://brid.gy/ itself away, but if you hope to make it support both somehow, and you want to track that in this issue, I'm open to that! Otherwise, I'm inclined to close this.

My idea is to have an option in the code that would enable someone to self-host another instance of bridgy without relying on the Google Cloud infrastructure.
This issue is not about migrating the brid.gy instance itself to that hypothetical new configuration

Ah, sorry, sure! I meant migrating the code, not the literal https://brid.gy/ instance.
We'd also ideally want these self-hosted instances to be private, ie not allow signups from the general public.
Happy to leave this issue open to track this idea!


fix: phone regex

A space followed by a plus signe is not a word boundary since both characters are non-word.
Old behavior My number: +421 900 000 000 -> My number: +[REDACTED PHONE] 000
New behavior My number +421 900 000 000 -> My number: [REDACTED PHONE]
cc: @samsucik

Somewhere in the depths of my mind the question "is it time for tests already" might have appeared but the rational part of the brain didn't allow it to go further than this post, which is where its short life has happily concluded.

I'd also do it later @mrshu, mainly due to the need to setup the whole CI in case we introduce the tests.


Fixed typo: 'Colletion' => 'Collection'

Fixed typo: Colletion => Collection, in two locations.

@krizalys,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Thanks for fixing this!


Can't set multiple Set-Cookie headers in an action

What version of Remix are you using?
1.6.3
Are all your remix dependencies & dev-dependencies using the same version?

[X] Yes

Steps to Reproduce

Have your client reach out to a remix route that as an action like so:

import type { ActionArgs } from "@remix-run/node";
import { createCookie, json } from "@remix-run/node";

import { AUTH_COOKIE, AUTH_EXP_COOKIE } from "app/cookies"

export const setCookie = (key: string, value: any) => {
  const createdCookie = createCookie(key, {
    path: "/",
    sameSite: "lax",
  });
  return createdCookie.serialize(value);
};

export async function action({ request }: ActionArgs) {
  return json(
    {},
    {
      headers: {
        "Set-Cookie": await setCookie(AUTH_COOKIE, ""),
        // @ts-expect-error
        "Set-Cookie": await setCookie(AUTH_EXP_COOKIE, ""),
      },
    }
  );
}

Call endpoint
Check response headers in dev tools and see there is only 1 Set-Cookie header:

Expected Behavior
See 2 Set-Cookie headers
Actual Behavior
Only seeing 1 Set-Cookie header

this was already brought up a while back after not working with redirect, but someone mentioned it wasn't working in loaders and now i'm seeing similar behavior in an action, so I figured i'd create a new issue:
https://github.com/remix-run/remix/issues/231#issuecomment-1218371334

nvm fix is to create a new Headers() instance and add them that way:
  const authCookieHeaders = new Headers();
  authCookieHeaders.append("Set-Cookie", await setCookie(AUTH_COOKIE, ""));
  authCookieHeaders.append("Set-Cookie", await setCookie(AUTH_EXP_COOKIE, ""));

  return json(
    {},
    {
      headers: authCookieHeaders,
    }
  );

nvm fix is to create a new Headers() instance and add them that way:
  const authCookieHeaders = new Headers();
  authCookieHeaders.append("Set-Cookie", await setCookie(AUTH_COOKIE, ""));
  authCookieHeaders.append("Set-Cookie", await setCookie(AUTH_EXP_COOKIE, ""));

  return json(
    {},
    {
      headers: authCookieHeaders,
    }
  );

This throws a type error in TypeScript

@MattyBalaam can you post your full code. Also i'm on typescript 5.2.2 if that makes a difference


Create C/C++ RNDF visualizer

We need to create a small program that can output a SVG/PNG image from a RNDF file.

I am working using the code from art Texas's project, since it is fairly basic and does what we need for this project.

I hacked something with the Texas project

It exports to .ppm format (I can open it using eog command on ubuntu). Is that ok? We need SVG for a particular reason? @basicNew

I don't know if it is worth it, what I did was to clean some dependencies (adapt some ROS nodes) and work from the available code, so it is just a hacked tool. I don't feel like it should have its own space, but it is not a strong opinion.

Also, it can be a starting point for the gazebo plugin, or not, it will depend on the other options that we studied last week. I think that where we put this code is going to be related to that. This code uploads all the RNDF to a graph, so we can use that graph for the Gazebo visualization.

I don't have a strong opinion either, so I'm fine if you want to create a tools dir in this repo and push it there. qq: can I get the binary (or source + build instructions)? It would be really useful for me to have it :).

I will add a lovely README, I used CMake because I am too lazy to make a Makefile, but even then it should be fairly easy to compile.


TB: Redefine trigger condition for protectors

The Coq formalization revealed that as currently implemented, read accesses did not always commute.
Indeed starting from a lazily initialized Active protected tag, applying a foreign read then a child read produces Frozen, but child read then foreign read triggers UB (because the child read initializes before the Active -> Frozen).
This reformulation of when protectors trigger fixes that issue:

instead of Active + foreign read -> Frozen and Active -> Frozen when protected is UB
we do Active + foreign read -> if protected { Disabled } else { Frozen }

There is already precedent for transitions being dependent on the presence of a protector (Reserved + foreign read -> if protected { Frozen } else { Reserved }), and this has the nice side-effect of simplifying the protector trigger condition to just an equality check against Disabled since now there is protector UB iff a protected tag becomes Disabled.
In order not to introduce an extra if, it was decided that Disabled -> Disabled would be UB when protected, which was not the case previously. This is merely a theoretical for now because a protected Disabled is unreachable in the first place.
The extra test is not directly related to this modification, but also checks things related to protectors and lazy initialization.

Thanks!
@bors r+

:pushpin: Commit 2081b6bbbf1bd482292adbee545b6089bb345281 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit 2081b6bbbf1bd482292adbee545b6089bb345281 with merge 300b3d258cee582547ef4421af06ee5bca9e8101...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 300b3d258cee582547ef4421af06ee5bca9e8101 to master...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 300b3d258cee582547ef4421af06ee5bca9e8101 to master...


<EMAIL_ADDRESS>decompress error

PS C:\Users\Ahsan.Husain> scoop install twilio
Installing 'twilio' (5.22.5) [64bit] from 'twilio-scoop' bucket
twilio-win32-x64.tar.xz (42.2 MB) [===========================================================================] 100%
Checking hash of twilio-win32-x64.tar.xz ... ok.
Extracting twilio-win32-x64.tar.xz ... ERROR Exit code was 2!
Failed to extract files from C:\Users\Ahsan.Husain\scoop\apps\twilio\5.22.5\twilio-win32-x64.tar.
Log file:
~\scoop\apps\twilio\5.22.5\7zip.log
Please try again or create a new issue by using the following link and paste your console output:
https://github.com/twilio/scoop-twilio-cli/issues/new?title=twilio%405.22.5%3A+decompress+error
PS C:\Users\Ahsan.Husain> twilio login
twilio : The term 'twilio' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling
of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1

twilio login

  + CategoryInfo          : ObjectNotFound: (twilio:String) [], CommandNotFoundException
  + FullyQualifiedErrorId : CommandNotFoundException

PS C:\Users\Ahsan.Husain> scoop install twilio
WARN  Purging previous failed installation of twilio.
ERROR 'twilio' isn't installed correctly.
Removing older version (5.22.5).
'twilio' was uninstalled.
Installing 'twilio' (5.22.5) [64bit] from 'twilio-scoop' bucket
Loading twilio-win32-x64.tar.xz from cache
Checking hash of twilio-win32-x64.tar.xz ... ok.
Extracting twilio-win32-x64.tar.xz ... ERROR Exit code was 2!
Failed to extract files from C:\Users\Ahsan.Husain\scoop\apps\twilio\5.22.5\twilio-win32-x64.tar.
Log file:
~\scoop\apps\twilio\5.22.5\7zip.log
Please try again or create a new issue by using the following link and paste your console output:
https://github.com/twilio/scoop-twilio-cli/issues/new?title=twilio%405.22.5%3A+decompress+error

Hi Ahsan!  I was just wondering how you solved this.  I am going through the same thing.


Unexpect behavior at sendEmail

Using the sendEmail action, it is only possible to sendEmail if the input parameters to, cc, bcc and replyTo are filled in. I believe that only the "to" input parameter is necessary, right?
Sending only "to" parameter, I have this following exception.

Hi @johnesthomas even though cc, bcc, replyTo are "optional", they should be pass in as an empty list if there is nothing for those values.

Very strange then, the email is only sent successfully when all these fields are filled in.

Just to enure that my understanding is correct. You are passing as empty list for "cc", "bcc" and "replyTo"?

Exactly, when I fill in these items, the email is sent successfully, if I don't enter any value, the email is not sent.

Is the replyTo list an empty list that you are passing over?

Yes, since all these parameters require a text list, I'm just passing an empty text element home.

This is indeed strange because, the unit test sendEmail_Ext_test1 is scenario that matches your case and it is showing up as pass. For sendEmail_Ext_test1, cc, bcc and replyTo are all empty list. See line 105 to 119 of the unit test case and you will notice that.

Hi Paul, before I was passing an empty element within each list, that's why the error was happening. But now, I had to create a local variable of the text list type and pass it through the lists that are mandatory. I believe that the ideal would be to just remove the mandatory nature of these fields. Thanks for the support!


Add iteration statements

Add for, while, etc. Statements that could iterate a object(arrays, objects that implement some function).

I think that an approach with tail recursive functions could be useful also. These recursive functions will be found by the compiler, classified, and transformed into a for loop or while for better performance.

I think that an approach with tail recursive functions could be useful also. These recursive functions will be found by the compiler, classified, and transformed into a for loop or while for better performance.


feat: signal handling

What type of PR is this?

Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

need a waitgroup for scheduler, to wait for all tasks before shuttind down?


should be able to change headers

I heard people coming back to webrat just because capybara does not have a good way to change headers.
we should allow people do do something like:

browser.headers['Content-Type'] = 'application/pdf'

+1


initial implementation for motion photos

Support for playing embedded content (motion photos)
reference: https://github.com/LibrePhotos/librephotos/issues/797

For those that don't have motion photos, you could download some samples from here

Awesome, it works. But it should probably go back to showing the image when pausing as this is the functionality in google photos and there should be some kind of indication that it is a motion photo in the list. But looks good enough to merge :+1:


merge package template from arlac77/npm-package-template

package.json

chore: update package.json from template

.gitignore

chore(git): update .gitignore from template

Coverage remained the same at 92.308% when pulling e4bd026c99b8548db0f4c1783b8baed1cd629b2b on template-sync-1 into cb32c0b7fa4274ea6389d184e6acdb44fc13a403 on master.

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #200   +/-   ##
======================================
  Coverage    92.3%   92.3%
======================================
  Files           2       2
  Lines          13      13
======================================
  Hits           12      12
  Misses          1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb32c0b...e4bd026. Read the comment docs.


fix(40469): "Convert to named function" refactoring is not suggested for non-arrow function expressions

Fixes #40469

@gabritto You might be interested in this too.

@jessetrinity could you review these changes?


Consider returning success/fail/timeout for SpanProcessor shutdown and force_flush

See https://github.com/open-telemetry/opentelemetry-specification/pull/878
This is a SHOULD rather than MUST, but I think it makes sense.

🤦 https://github.com/open-telemetry/opentelemetry-ruby/blob/bf79274f463012d3a3dda2343d2628d4b1a1cd84/sdk/lib/opentelemetry/sdk/trace/export/simple_span_processor.rb#L55-L62


[Suggestion] Adding an option to display a faint ring on the edge of an aura.

Is it possible to add an option to automatically display a colorable outer edge/ring for aura effect? I would like to see this become an option as my Paladin states that while it is convenient that the active auras add his protection bonus to the others automatically, he noticed that unless he calls it out, people forget about it and end their turns way more often outside his aura range.
After he told me that I started noticing it to that even if there is an icon added to the token of a player if they got the aura effecting them its often overlooked.
I know there is an option to add effects that flash and glow, but we choose not to use these as too many effects make some of the players nauseous. So having a range indicator appear whenever the aura is active would be nice. Especially since I have it toggled to prevent lag to only activate auras during combat.
Describe the solution you'd like
Option to display a range indicator like a ring on the outer edge of the aura, that clearly displays during combat where the aura ends. Preferably defaulting to the color associated with the players set color or as a color selection in the option of each aura.
Describe alternatives you've considered
I considered a version of this where the entire area is opacity colored, but that is too distracting. A slightly opaque outer edge coloration seems the best solution to me.
Additional context
mostly good for Paladins in DnD or some magic items that are emitting an aura on the map or monsters with aura effects etc.

This is 100% on my to-do list


Sharing plans - revise add contributor and add collaborator procedures and wording for instructions

User are confused about the difference between Collaborators and Contributors.
In the short term, we should improve wording of on-screen explanatory text to make this difference clearer.
In the long term, we should improve the workflow for adding Contributors and Collaborators. Is this difference worth two separate workflows? Who makes use of the information Collaborator vs Contributor? Most Contributors are likely to be Collaborators as well and may want to view/edit the plan. Note that neither Collaborators nor Contributors are listed on the full download (including the cover sheet) of the plan.
Please complete the following fields as applicable:
What version of the DMPRoadmap code are you running? (e.g. v2.2.0)
latest
Expected behaviour:
In DMPonline, there are two separate tabs, one for adding Contributors and a Share for inviting collaborators with varying rights (edit, read-only, etc).
In DMPTool, there is one tab called Collaborators, with two different buttons, one for 'Add contributor' and another for 'Invite collaborators'.
Users are expected to read instructions and understand the subtle difference between these two categories, Contributor vs Collaborator.
Actual behaviour:

Users add Contributors
When they Share plan/Invite collaborators, they expect to see them listed to be listed under Contributors. In effect they expect a single list of people who have access to the plan.

The process of adding a collaborator is also prone to errors, at least on DMPonline.
It works smoothly for collaborators who already have a user account.
When collaborators who haven't already got user accounts on DMPonline/DMPTool get the notification message 'A Data Management Plan in DMPTool/DMPonline has been shared with you', they are taken through to the 'create an account' procedure. Users tend to type manually their organisation name rather than select from drop-down list and get error message 'The name you entered was not one of the listed suggestions'.
In the short run we could improve the wording to say, for example, 'Please select one of the listed organisations. If your organisation is not listed, select Other'.
In the long run, we should revise the whole procedure for adding Contributors/Collaborators.
Steps to reproduce:
DMPonline: add contributors via the Contributors tab, add collaborators via Share plan tab
DMPTool: go to Collaborators tab and follow 'Add contributors' and 'Invite collaborators' procedures
FAO DMPonline team:
This is relevant to Salesforce case 00027086. Note: the case came via Unidesk so you won't be able to see the bulk of the correspondence if you don't have access to Unidesk. Read the summary notes.

Well this is how we revised it:

hide the tab of contributor
for every collaborator, look for a contributor with the same email, and show its rights in column "Contribution"


Reset apollo client store cache on logout

@dominik-zeglen What do we do with this one?

@dominik-zeglen Bump


OSASINFRA-3547: CVO: disable console on platform OpenStack

What this PR does / why we need it:
We don't have a working Ingress on the HCP OpenStack platform.
We want to disable the console since it won't work anyway for now.

/test e2e-openstack

/hold
for now hold, I had to cherry-pick a commit from another PR

/cc davidvossel

/cc MaysaMacedo

/test unit

/test e2e-azure
/test e2e-aws

This didn't work :/

error: unable to parse image registry.build02.ci.openshift.org/ci-op-sc9mrq1s/stable@sha256:d89ad259f7945ed76d508070d1bbc90db5f552ed91f0d2004fd79d8f8064807d: cannot retrieve image configuration for manifest sha256:58211411e89c8af4cc6fb9d8a068c8ba7d02a4f0971e9a4006ef9adeaa98daac in manifest list sha256:d89ad259f7945ed76d508070d1bbc90db5f552ed91f0d2004fd79d8f8064807d: received unexpected HTTP status: 504 Gateway Time-out

/retest

This didn't work for me locally. Let's see what CI says, just in case.


Are there any cases which cannot move from a subscription to other subscriptions?

Hello guys,
As I wrote in the title, are there any cases impossible to move?
I am in Korea, and Korean MS said, a movement would be impossible in special cases?
I am wondering if it is real..
please let me know.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b69d95cf-9933-cc22-7167-45d5fcb7be86
Version Independent ID: 5ba63189-2a5f-0e2d-fb92-84e2b842b1dd
Content: Move a Windows VM resource in Azure - Azure Windows Virtual Machines
Content Source: articles/virtual-machines/windows/move-vm.md
Service: virtual-machines-windows
GitHub Login: @cynthn
Microsoft Alias: cynthn

@teseus Thanks for the feedback! We are currently investigating and will get back on this.

@cynthn Can you please check and add your comments on this.

@teseus Please check this document that has details on Move operation support for resources. This has the details if the resource is supported or not for move operation across subscriptions and resource group.


Changing ?Sized related trait bounds is not detected

Steps to reproduce the bug with the above code
git clone https://github.com/diesel-rs/diesel
cd diesel/diesel
cargo semver-checks --baseline-rev v2.0.4 --only-explicit-features --features postgres --features sqlite --features mysql --features extras --features with-deprecated --manifest-path .

Actual Behaviour
No breaking change is reported:
     Cloning v2.0.4
     Parsing diesel v2.1.1 (current)
     Parsing diesel v2.0.4 (baseline)
    Checking diesel v2.0.4 -> v2.1.1 (minor change)
   Completed [   0.150s] 39 checks; 39 passed, 6 unnecessary

Expected Behaviour
Cargo semver-checks should report a major breaking change. A trait function added a ?Sized bound to it's where clause.
Documentation:

2.1.1
2.0.4

Relevant function signature:
2.0.4:
    fn push_bound_value<T, U>(
        &mut self,
        bind: &'a U,
        metadata_lookup: &mut DB::MetadataLookup,
    ) -> QueryResult<()>
    where
        DB: Backend + HasSqlType<T>,
        U: ToSql<T, DB> + 'a;

2.1.1:
    fn push_bound_value<T, U>(
        &mut self,
        bind: &'a U,
        metadata_lookup: &mut DB::MetadataLookup,
    ) -> QueryResult<()>
    where
        DB: Backend + HasSqlType<T>,
        U: ToSql<T, DB> + ?Sized + 'a;

Note the added ?Sized bound in the newer version. From caller side this is a non-breaking change as it only extends the set of allowed values. For existing implementations outside of diesel of the given trait this is a breaking change as it requires updating the function signature. It also might break an implementation that assumes that U is Sized.
Generated System Information
Software version
cargo-semver-checks 0.22.1
Operating system
Linux 6.4.7-200.fc38.x86_64
Command-line
/home/weiznich/.cargo/bin/cargo-semver-checks semver-checks --bugreport

cargo version
> cargo -V
cargo 1.68.0 (115f34552 2023-02-26)

Compile time information

Profile: release
Target triple: x86_64-unknown-linux-gnu
Family: unix
OS: linux
Architecture: x86_64
Pointer width: 64
Endian: little
CPU features: fxsr,sse,sse2
Host: x86_64-unknown-linux-gnu

Build Configuration
No response
Additional Context
No response

Thanks, this is awesome! Especially appreciate the details on how this might be breaking and for whom, which will be super helpful writing the diagnostic message this should show.


Invalid version (double separator '-'): 1.1.1-beta-b: python3dist(sysmontask) = 1.1.1-beta-b

RPM build errors:
    Invalid version (double separator '-'): 1.1.1-beta-b: python3.9dist(sysmontask) = 1.1.1-beta-b
    Invalid version (double separator '-'): 1.1.1-beta-b: python3dist(sysmontask) = 1.1.1-beta-b

Hello. Can't package this awesome app because of such little thing and RPM consider this as error. Please refuse to use such
custom suffixes and non-canonical tag versions and stick with semver.

Hi,
Is this due to the version name defined in setup.py?
For building the package is it like you are cloning the repo and building or the build process directly use the repo URL?
Or is do I have to change on my side to properly work this out?

Is this due to the version name defined in setup.py?

The problem comes from here https://github.com/KrispyCamel4u/SysMonTask/blob/master/setup.py#L15
If we replace '1.1.1-beta-b' -> '1.1.1-beta.b' for example then it's Okay and no error during build.
I guess this RPM specific error due to autogenerators and such.

So it depends on the changes on the git repo right?
If that is the case I will make changes to the repo.

Yep. If we could have instead of 1.1.1-beta-b something like 1.1.1-beta2 in setup.py then no problem and seems like this correct way for versioning for such pre-releases according to semver.

Is this due to the version name defined in setup.py?
The problem comes from here https://github.com/KrispyCamel4u/SysMonTask/blob/master/setup.py#L15

I have changed it from 1.1.1-beta-b to 1.1.1-beta2


Add troubleshooting guide for failed DB migration. closes #479

Detailed information:
Encountered an issue when installing the project locally where the database failed to migrate. Added information for resolving this issue to the troubleshooting guide.
Closing issues:
List all issues the pull request solve:

#479

Test plan (required)

[x] The PR contains new PyTest unit/integration tests for any function or functional added. (N/A)
[x] The PR changes existing PyTest unit/integration tests to keep all tests up to date. (N/A)
[x] The PR does not lead to degradation in unit test coverage.
[x] Project parts affected by changes in this PR was tested manually on your local (using Postman or in any other way). List everything you've tested below:

Doc files

Codecov Report
Base: 72.33% // Head: 72.33% // No change to project coverage :thumbsup:

Coverage data is based on head (8f8150c) compared to base (5cb2a4a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             docs     #480   +/-   ##
=======================================
  Coverage   72.33%   72.33%
=======================================
  Files          82       82
  Lines        2639     2639
  Branches      315      315
=======================================
  Hits         1909     1909
  Misses        695      695
  Partials       35       35

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


FEAT: Clearer icon for skipped status

During demo at Scientific Python Developers Summit 2023, some people expressed desire to replace the orange "skipped" icon with a gray one, so one can easily distinguish it from "failed" status.
Another idea is to use emojis, example:
👍
🤔
😱

Touched up formatting and icons a bit, live at https://scikit-hep.github.io/repo-review (URL likely changing soon).


Status Online with iGrill Turned Off

this is awesome - thanks all
i have noticed though when i turn off the igrill v2 that the status shows "online" and stays like that with all probes retained...
im watching the mqtt flow of info via mqtt explorer and dont see the status change
then when i turn it back on - the status stays but the probe info updates
cant get it to get to offline when i turn the igrill off
is there something i need to do differently?

The status MQTT topic is used to keep track of whether or not ESP32 device is connected to the MQTT server. If you unplug the ESP32 it will change to offline.
If you are wanting the temp probes to reset to a blank value you can just unplug the temp probes from the iGrill before turning it off.

Yeah right so it's not so much if the esp has a Bluetooth connection. More
if the esp is on or not...
There isn't a sensor to detect Bluetooth connection or not? (Ie igrill is
on or off)
On Fri, 14 Apr 2023, 12:17 pm Logan McKenna, @.***>
wrote:

The status MQTT topic is used to keep track of whether or not ESP32 device
is connected to the MQTT server. If you unplug the ESP32 it will change to
offline.
If you are wanting the temp probes to reset to a blank value you can just
unplug the temp probes from the iGrill before turning it off.
—
Reply to this email directly, view it on GitHub
https://github.com/1mckenna/esp32_iGrill/issues/28#issuecomment-1507835509,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA24DYMHIJT2LL6YA65QPD3XBCXTXANCNFSM6AAAAAAW4Y4YKY
.
You are receiving this because you authored the thread.Message ID:
@.***>

I normally unplug/plug my esp in when using the iGrill, but it does make sense to add in a sensor for when the iGrill is connected/disconnected. I'll work on getting the code updated and let you know when there is a branch ready for you to test and confirm its working correctly.

I just pushed a the statusUpdates branch that should resolve this for you.
The code now

Creates a separate esp32 sensor with some info system attributes
Creates a sensor to track connectivity with the iGrill
Probe connection/disconnection now will automatically add/remove the probes from mqtt as they are connected/disconnected making the HA UI experience nicer. (only applies if you use the default temp probe retain setting).

When you get a chance try pulling the branch and let me know how it works on your end.


Initial code migration from anoncreds-rs branch

@ianco FYI: all of the AATH ACA-Py to ACA-Py tests pass on for this PR.

@ianco FYI: all of the AATH ACA-Py to ACA-Py tests pass on for this PR.

Thanks for the info!  This is basically a non-destructive PR so that's good news.  There are still a couple of unit tests failing and I need to "hook in" the anoncreds stuff so it gets initialized on startup (and also review the unit test coverage of the new code) before this PR is finalized ...

I think this PR is ready to merge.  It adds the new "anoncreds" code and is non-destructive (demo, unit and integration tests still run).
I still need to hook up the anoncreds code to aca-py startup and inventory the unit tests in the new anoncreds package but I think I can do that in the next PR.

We need to hold off on this until we get the 0.11.0 release completed, so I moved this back to Draft. Reviews are welcome though!!

We need to hold off on this until we get the 0.11.0 release completed, so I moved this back to Draft. Reviews are welcome though!!

OK sounds good.  I'll keep working on this PR in the meantime ...

Added a few comments regarding unit test scope, I think we need to add some but not go overboard.  I suggest:

updating the routes unit tests (adding tests for the main routes)
adding unit tests for the main issuer, holder and verifier classes

There are already a few tests for the registries, and there are existing tests elsewhere in aca-py similar to the ones we need to add for aca-py, that whoever is going to be working on the unit tests can use as a model.

Question for @dbluhm @andrewwhitehead @swcurran ...
For the V20 credential Format enum (which is defined here:  https://github.com/hyperledger/aries-cloudagent-python/blob/main/aries_cloudagent/protocols/issue_credential/v2_0/messages/cred_format.py#L31) ...
... I had initially thought of adding a new Enum for ANONCREDS (in addition to INDY) but after some noodling in the code I now think the INDY enum should depend on which wallet type is selected (askar vs askar-anoncreds).
If askar (the existing code) (or if running wallet type indy although this is deprecated):
        INDY = FormatSpec(
            "hlindy/",
            V20CredExRecordIndy,
            DeferLoad(
                "aries_cloudagent.protocols.issue_credential.v2_0"
                ".formats.indy.handler.IndyCredFormatHandler"
            ),
        )

If askar-anoncreds:
        INDY = FormatSpec(
            "hlindy/",
            V20CredExRecordIndy,
            DeferLoad(
                "aries_cloudagent.protocols.issue_credential.v2_0"
                ".formats.anoncreds.handler.AnonCredsCredFormatHandler"
            ),
        )

@dbluhm  are there differences in the attachment when using the new anoncreds library?

We opted to continue using the existing indy format, at least initially. I think it makes sense to eventually phase out any use of "indy" as a stand in for "anoncreds" but I think that's a later problem.

The fun in this is that if the AnonCreds in W3C format comes in soon enough, perhaps we can just use W3C format for everything…

The fun in this is that if the AnonCreds in W3C format comes in soon enough, perhaps we can just use W3C format for everything…

Is this going to affect the wire protocol (agent-to-agent messages) or just the payload to the issue credential api?

We opted to continue using the existing indy format, at least initially. I think it makes sense to eventually phase out any use of "indy" as a stand in for "anoncreds" but I think that's a later problem. There are no differences in the attachment when using the anoncreds library.

This is good.  The api format won't be affected by the switch from askar to askar-anoncreds then.