Global events from AdyenCheckout are not emitted

Dear Adyen Frontend Team,
When I updated the library from version 4.2.3 to 4.3.0 I have noticed that the next configuration is not emitting the global events anymore:
const checkout = new AdyenCheckout({
    onSubmit: () => {}, // Global configuration for onSubmit
    onReady: () => {},
    onSelect: () => {},
    onChange: () => {},
    onSubmit: () => {},
    onError: () => {},
    onAdditionalDetails: () => {}
});

checkout.create('dropin').mount('#dropin');

Then I had to do this workaround:
const checkout = new AdyenCheckout();

checkout.create('dropin',{
    onSubmit: () => {}, // Global configuration for onSubmit
    onReady: () => {},
    onSelect: () => {},
    onChange: () => {},
    onSubmit: () => {},
    onError: () => {},
    onAdditionalDetails: () => {}
}).mount('#dropin');

Additional context
We have seen that there were some props changed from the main config to the create function.
Is it on propose that the events are not emitted anymore in AdyenCheckout but yes on checkout.create() or it was a bug?
Thanks,
Emilian

Hello, I had the same issue a few days ago, see here

Thanks, I have didn't seen the ticket as was closed.
Cheers🍺  @bitbytebit1

Hi @emidev98,
Happy to see this was clarified already (thanks @bitbytebit1!). Since we noticed this confusion popped up a couple times, we just added a link to the migration guide to v4 in our release notes which hopefully will help others in the future with this issue. Thanks for reaching!


Update CHANGELOG with missing entry.

That would be #3458, which had been included in the metrics section (instead of semantic conventions) of the CHANGELOG.

Thanks @carlosalberto!


Prevent non mc from grabbing mc only timeslot

Resolves #298

Pull Request Test Coverage Report for Build 2222

13 of 13 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 96.315%

Totals

Change from base Build 2218:
0.2%

Covered Lines:
575

Relevant Lines:
597

💛  - Coveralls


Transmute k8s microservice install

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #1   +/-   ##
=======================================
  Coverage   78.77%   78.77%
=======================================
  Files           9        9
  Lines         179      179
  Branches       28       28
=======================================
  Hits          141      141
  Misses         36       36
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9505b81...fbec2fe. Read the comment docs.


v4 circular textwrap

Please: I have a dynamic forced bubble layout operating on d3 v4. Is there a chance to see d3plus beautiful textwrap functionality in there?
I was able to tweak d3plus missing reference to d3.scale.ordinal by creating
d3.scale = {}; d3.scale.ordinal = d3.scaleOrdinal;
right before loading d3plus.org/js/d3plus.js.
Now text wrapping performs nice and smooth, but when i add a call to resize(true) the following error comes up:

TypeError: tspans.enter(...).append(...).text(...).style(...).attr is not a function

https://jsfiddle.net/cocomooo/5k26pnhd/1/
I also tried d3plus-text but could not get it to work with d3 v4. To me it seems d3plus-text is still far away from what the d3plus textwrap() does?

The d3plus-text module is pretty close to the current featureset of the 1.0 function. It actually already has better wrapping detection, but no circle wrapping yet.
Once we've got that baked in, you should be good to go. The d3plus v2 modules are meant to be used with d3 v4, and I have no current plans of porting the original d3plus v1 codebase over to d3 v4. Therefore, I'm closing this issue in favor of https://github.com/d3plus/d3plus-text/issues/5


Fix dependencies, provide missing requires

This fixes the issues described in the issues ticket: https://github.com/thegorgon/sinatra-sprockets/issues/1

Also, commit rights pretty plz? I want to write out some tests for this! It's good stuff.

Dead PR, closing.


Provide link to admin in the standard header

I don't completely understand it: do you offer to show the admin link for all the users? (Is that safe?)
Or, mb, it should be shown only for specific users (for admin, eg)?

I don't completely understand it: do you offer to show the admin link for all the users? (Is that safe?)

Yes, the link is for everyone - just because the link is there doesn't mean that they can log in :)

Added in PR #55.


Nomination envelope gossiping can be optimized

In the nomination protocol a node sends envelopes with the statement including:
X - set of votes the node nominated
Y - set of confirmed votes

The candidate set Z is not included because it can be rebuilt from X and Y - and regardless Z is only used for balloting. X and Y are only allowed to grow and they never shrink. The protocol rule for determining which message is the latest one is simple: the message with the largest set of X and Y is the newest message for that node - hence why there is no timestamping of nomination envelopes in SCP. In addition the old set must be a subset of the new set.
A node only emits an envelope when its set has changed. For example, if it accepted a new nomination from another node then its internal Y will increase and the node will then create a new envelope and gossip it.

In light of this we have an optimization opportunity:

If there was an older envelope queued for gossiping while a new one has just been queued up then we should cancel sending the old envelope. The new envelope is a superset and can safely replace the old one.

Note that SCP uses a leader selection algorithm for each nominating round for a slot, therefore the possibility of this being a performance issue during regular operation is very unlikely. However, if there saw network outage at the node then after recover a sudden influx of envelopes will cause the nodes to emit many envelopes itself . This is why it's important to cancel all the old envelopes that were queued up.

In addition to what was said, we also must ensure that the node is never starved (DDoS'ed) of sending envelopes. If the node's internal X and Y set grows we must ensure an envelope is sent. We don't want to end up in a situation where gossiping of an envelope is constantly pre-empted by the creation of new envelopes, and therefore an envelope never ends up being sent (DDos).


Unable to cast object of type '...FacadeSegment' to type '...Subsegment'

Getting a cast error in Lambda execution; we're using a simple flow within a controller (Microsoft.AspNetCore.Mvc.ControllerBase):
_recorder.BeginSubsegment(nameof(MyController));
try {
...
}
catch (Exception ex)
{
_logger.LogError(ex, ...);
return Ok(CreateErrorResponse(...);
            }
finally {
_recorder.EndSubsegment();
}

Docs indicate that we need to call the .End* method for every .Begin* method; so I put the .End* call in a C# finally block to ensure it always gets invoked, even if an error gets caught and execution returns early.
Here _logger is the standard MS ILogger:
private readonly ILogger _logger;
Amazon.XRay.Recorder.Core.Exceptions.EntityNotAvailableException: Failed to cast the entity to Subsegment.  ---> System.InvalidCastException: Unable to cast object of type 'Amazon.XRay.Recorder.Core.Internal.Entities.FacadeSegment' to type 'Amazon.XRay.Recorder.Core.Internal.Entities.Subsegment'.    at Amazon.XRay.Recorder.Core.AWSXRayRecorder.PrepEndSubsegmentInLambdaContext()    at Amazon.XRay.Recorder.Core.AWSXRayRecorder.ProcessEndSubsegmentInLambdaContext(Nullable1 timestamp)
at Amazon.XRay.Recorder.Core.AWSXRayRecorder.EndSubsegment(Nullable1 timestamp)    --- End of inner exception stack trace ---    at Amazon.XRay.Recorder.Core.Internal.Context.TraceContextImpl.HandleEntityMissing(IAWSXRayRecorder recorder, Exception e, String message)    at Amazon.XRay.Recorder.Core.AWSXRayRecorderImpl.HandleEntityNotAvailableException(EntityNotAvailableException e, String message)    at Amazon.XRay.Recorder.Core.AWSXRayRecorder.EndSubsegment(Nullable1 timestamp)
`
The next line on this log dump references the _logger.LogError(ex, ...); line in the code block above.

Hi, looks like the BeginSubsegment is failing to either create a subsegment or load it in the context. As a result, when EndSubsegment expects a subsegment to be present, it finds the root FacadeSegment instead.
Can you make sure that nameof(MyController) is not returning an empty string or null? Do you see any logs related to failure to begin a subsegment?


twitter changed domain name to x.com

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
USA
Provide a description that is worded well enough to be understood
twitter changed it primary domain to x.com. so copied video address will be x.com.
video download with x.com url failes, but works if replace 'x' with 'twitter'
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
% yt-dlp -vU
[debug] Command-line config: ['-vU']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [ff0779267] (zip)
[debug] Python 3.11.9 (CPython x86_64 64bit) - Linux-6.7.12-amd64-x86_64-with-glibc2.38 (OpenSSL 3.2.2-dev , glibc 2.38)
[debug] exe versions: ffmpeg 6.1.1-4 (setts), ffprobe 6.1.1-4
[debug] Optional libraries: Cryptodome-3.11.0, brotli-1.1.0, certifi-2023.11.17, mutagen-1.46.0, requests-2.31.0, sqlite3-3.45.3, urllib3-1.26.18, websockets-10.4
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests
[debug] Loaded 1810 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)

 % yt-dlp --output %(title).30s.%(id)s.%(ext)s https://x.com/i/status/1793243998351483249
[generic] Extracting URL: https://x.com/i/status/1793243998351483249
[generic]<PHONE_NUMBER>351483249: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic]<PHONE_NUMBER>351483249: Extracting information
ERROR: Unsupported URL: https://x.com/i/status/1793243998351483249

 % yt-dlp --output %(title).30s.%(id)s.%(ext)s https://twitter.com/i/status/1793243998351483249
[twitter] Extracting URL: https://twitter.com/i/status/1793243998351483249
[twitter]<PHONE_NUMBER>351483249: Downloading guest token
[twitter]<PHONE_NUMBER>351483249: Downloading GraphQL JSON
[twitter]<PHONE_NUMBER>351483249: Downloading m3u8 information
[info]<PHONE_NUMBER>024683008: Downloading 1 format(s): http-632
[download] Destination: Bin Xie - Chinese EV BYD model.1793239547024683008.mp4
[download] 100% of  451.65KiB in 00:00:00 at 2.34MiB/s

Duplicate of #9923
Update to nightly:
# To update to nightly from stable executable/binary:
yt-dlp --update-to nightly

# To install nightly with pip:
python3 -m pip install -U --pre "yt-dlp[default]"


Use filepath.join for OS-agnostic path.

Description
I noticed that when running tests on my Mac, the following test was failing:
Uploader Test
/Users/omaciel/go/src/github.com/omaciel/edge-api/pkg/services/files/uploader_test.go:26
  S3Uploader
  /Users/omaciel/go/src/github.com/omaciel/edge-api/pkg/services/files/uploader_test.go:101
    S3Uploader
    /Users/omaciel/go/src/github.com/omaciel/edge-api/pkg/services/files/uploader_test.go:131
      UploadFile
      /Users/omaciel/go/src/github.com/omaciel/edge-api/pkg/services/files/uploader_test.go:157
        UploadFile should return error when sourcePath does not exists [It]
        /Users/omaciel/go/src/github.com/omaciel/edge-api/pkg/services/files/uploader_test.go:195

        Expected
            <string>: failed to open file "/var/folders/f8/d3hhm54d0lx8n395gr4_kq3w0000gn/T//uploader-1676754900455641000.target-file", open /var/folders/f8/d3hhm54d0lx8n395gr4_kq3w0000gn/T/uploader-1676754900455641000.target-file: no such file or directory
        to contain substring
            <string>: /var/folders/f8/d3hhm54d0lx8n395gr4_kq3w0000gn/T//uploader-1676754900455641000.target-file: no such file or directory

        /Users/omaciel/go/src/github.com/omaciel/edge-api/pkg/services/files/uploader_test.go:206

The issue seems to be related to how os.Tempdir works on Linux versus on a Mac, where the Mac version of golang returns an / at the end of the generated directory, but the Linux version doesn't. filepath.Join() should handle the separator in a more OS-agnostic way.
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[x] Refactor

Here's a live example: https://go.dev/play/p/DxYbo9TSc9O

Codecov Report
Base: 53.88% // Head: 53.88% // No change to project coverage :thumbsup:

Coverage data is based on head (79a8398) compared to base (9fe3e32).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1901   +/-   ##
=======================================
  Coverage   53.88%   53.88%
=======================================
  Files          70       70
  Lines        9932     9932
=======================================
  Hits         5352     5352
  Misses       4106     4106
  Partials      474      474

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Use Jake exclusively for fetching and running CMake

Static linking is finally done with CMake, we should use Jake only for retrieving prebuilt binaries and running CMake if none exists.

I've decided to remove Jake and all JS-related stuff completely.
This repository should focus on CMake, precompiled libraries will be fetch inside https://github.com/aisouard/node-libwebrtc


I have my dataset in the format that 3D Gaussian Splatting and NerfStudio accept. That is a folder with an images subfolder and camera params of those images saved in a json file. How do I change them in the format that PixelSplat accepts?

i have my dataset in the format that 3D Gaussian Splatting and NerfStudio accepts. That is an image folder with camera parameters of those images saved in a json file. How do I change them in the format that PixelSplat accepts?

Hi @Shahid1Malik, sorry for the late reply, I've been busy with several deadlines previously.
To run on your own dataset, the straightforward way is to convert your data into similar torch files so that you can easily reuse the data loader.
To convert data to torch files, refer to how we converted the DTU dataset at  https://github.com/donydchen/mvsplat/blob/main/src/scripts/convert_dtu.py. We have also had more discussions regarding this convert script. Please refer to https://github.com/donydchen/mvsplat/issues/28.
If the camera parameters are in the format that 3D Gaussian Splatting and NerfStudio accept, my best guess is that they are obtained via COLMAP. If so, you can refer to https://github.com/donydchen/mvsplat/issues/1 for instructions on converting the COLMAP data.
After successfully building the torch files, the most important thing is to confirm that the camera parameters are correctly formatted. You can find more related discussions at https://github.com/donydchen/mvsplat/issues/23#issuecomment-2085190160.

i have converted a subset of real10k using your convert.py script. However the torch file generated is 47 MB. when i feed it for evaluation, the  testing doesnt work, it appears like it does not find or accept the torch file. What could be the problem here. Help would be much appreciated.

i have converted a subset of real10k using your convert.py script. However the torch file generated is 47 MB. when i feed it for evaluation, the testing doesnt work, it appears like it does not find or accept the torch file. What could be the problem here

Hi @Shahid1Malik, several reasons can lead to these issues. Below, I provide some potential solutions to help you debug.

make sure the torch data is correctly loaded; you can do it by printing the self.chunks right after https://github.com/donydchen/mvsplat/blob/main/src/dataset/dataset_re10k.py#L83

if you are running the testing, make sure that the scenes exist in the eval index file (e.g., assets/evaluation_index_re10k.json); you can confirm it at https://github.com/donydchen/mvsplat/blob/main/src/dataset/view_sampler/view_sampler_evaluation.py#L54


Update Fruitties to Kotlin 2.0.10

Update to Kotlin 2.0.10

https://kotlinlang.org/docs/whatsnew20.html

Update Room to 2.7.0-alpha06

https://developer.android.com/jetpack/androidx/releases/room#2.7.0-alpha06
https://developer.android.com/kotlin/multiplatform/room#defining-database

Update Gradle wrapper distributionUrl=https://services.gradle.org/distributions/gradle-8.7-bin.zip
Update other plugins and libraries (no code changes)

@kkuan2011 could you please take a look at this change?


New Left-Menu Issue - Not able to create direct menu item instead of nested menu

Bug Report
I have a custom module that does not have a nested menu but instead opens directly from the main menu item. It is working fine until 1.3.3 but as I fetched new updates from the master, I got the new menu with it with breaking changes
Issue Description
As checked in menu generation code, It found to be hard-coded that only the dashboard will have a direct link
Bagisto Version

[x] master branch (This one)
[ ] 1.3.3
[ ] 1.3.2
[ ] 1.3.1
[ ] 1.3.0

Steps To Reproduce
Menu Config:
return [
[
'key' => 'customModule',
'name' => 'Custom Module',
'route' => 'custom.admin.index',
'sort' => 2,
'icon-class' => 'any-icon',
]
];
Expected Result
It is supposed to be dynamic as it is previously, all menu hierarchy was created by menu config.

Hi @suyashcyber94,
Currently, the master version is unstable due to the new admin UI theme and we are working on this.
I recommend you to not use master currently.


[Discussions]Do we need to add a document for this template?

Usually, people must add a doc to introduce the integration, so I think a doc is also necessary. and I'm writing an integration, I found this template doesn't have a doc folder.

Yeah it's true I need to improve the documentation. I'll be on holiday soon so I think I'll take some time to update how this is structured and documented

Enjoy your holiday!


Issue with index for loading initial slide when using map function

// When I use index={2} here, the slider shows as Active-dot the third slide, but renders content from the first slide.
  renderContent() {
      return (
       <Swiper loop={false} index={2}>
          {this.renderAlbums()}
        </Swiper>
      );
    }

Image:

If I use the same index={2}, without MAP, but with hard-code - It renders as Active-dot the third one, and renders the content from the third slide. Which is correct. When using this:
   renderContent() {
     <Swiper loop={false} index={2}>
        <View><Text>Page 1</Text></View>
        <View><Text>Page 2</Text></View>
        <View><Text>Page 3</Text></View>
      </Swiper>
      );
    }

import React, { Component } from 'react';
import { View, Text } from 'react-native';
import Swiper from 'react-native-swiper';

class AlbumList extends Component {
  state = { albums: ['Page 1', 'Page 2', 'Page 3', 'Page 4'] };

  renderAlbums() {
    return this.state.albums.map(album =>
      <View><Text>{album}</Text></View>
    );
  }

// When I use index={2} here, the slider shows as Active-dot the third slide, but renders content from the first slide.
  renderContent() {
      return (
       <Swiper loop={false} index={2}>
          {this.renderAlbums()}
        </Swiper>
      );
    }

/* If I use the same index={2}, without MAP, but with hard-code - It renders as Active-dot the third one, and renders the content from the third slide. Which is correct. When using this:
   renderContent() {
     <Swiper loop={false} index={2}>
        <View><Text>Page 1</Text></View>
        <View><Text>Page 2</Text></View>
        <View><Text>Page 3</Text></View>
      </Swiper>
      );
    }

*/
  render() {
    return (
        <View>
          {this.renderContent()}
        </View>
    );
  }
}

export default AlbumList;

same problem for me:
<Swiper index={this.state.swiperPosition} loop={false} showsPagination={false} loadMinimal>    {this.state.imagePosts.map((i, k, arr) => this._renderImage(i, k, arr))} </Swiper>

+1 using map statement

+1. cant imagine what the hell causes this.

Same for me

i am having the same issue anyone solved it...?

After a bit of investigation I discovered that, for ScrollView, which is rendered for iOS, contentOfsset is undefined.
onLayout = (event) => {

    ...
   // At this point, this.state.width and this.state.height equal values from Dimensions.get('window')
    if (width !== this.state.width || height !== this.state.height) {
      state.offset = offset   <---- This never happens
    }
    this.setState(state)
}

So, for my case, when swipers width equals to Dimensions.get('window').width, a quick hack to fix is would be to simply set width={myWidth - 1} as swiper prop, which will allow to set offset inside onLayout. But a better way would be to check whether this.state.offset is defined

where i have to change this thing in node modules?


[WIP] Allow customization of the browser local storage usage threshold

CATEGORY
Choose one

[ ] Bug Fix
[x] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
This change allows customization of the threshold for when the browser local storage usage notification appears.
The default setting is that the notification appears when 90% of 5MB local storage is used but in our deployment some users are seeing this warning regularly despite the browser being fully responsive so we'd like to be able to tweak the threshold.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
The notification looks like this:

TEST PLAN

Validated the the override works as expected and that it falls back to the original values when no override is specified.

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS

Once #8060 is finished with testing and review, then this PR should be unneeded.
Since your deployment seems to have rather large amounts of data/sql lab tabs, i think the PR above is probably the best path forward. If you wanted to test it yourself as well that'd be much appreciated

Agreed. I'll close this and take a look at #8060.


Ubuntu 14 error when Compiling GLFW:  /usr/bin/ld: cannot find -lpthreads

Newer version of gcc under Ubuntu 14  will use "-pthread" to link to pthread library, however, the older version of gcc uses "-lpthreads". It seems that cmake still uses "-lpthreads".
I solve this issue from a clean Ubuntu 14 installation by make this commands:
sudo apt-get install xorg-dev build-essential libglu1-mesa-dev libc6-dev
sudo apt-get install g++ libboost-dev cmake make git doxygen

Do you mean 14.04 or 14.10?

It works fine with -lpthread on 14.x and 15.x.


Creating a minimum viable version of the sitrep dashboard

Merging not ready yet - will prepare a future PR for this.


[zh-ch] Mention kubernetes/websites everywhere in the same way

Related to https://kubernetes.slack.com/archives/C0191RDKHU1/p1680549820387879

/lgtm

Thanks.
/lgtm
/approve


Referencing a template file from _file results in build error

Describe the bug
When using typescript, I import a file that exist in the template, from a source file in a lession it works, but fails to build.
Link to a StackBlitz project which shows the error
https://github.com/noam-honig/play-with-tutorial-kit/tree/demo-reference-to-file-in-template
Steps to reproduce
Here's my code:
https://github.com/noam-honig/play-with-tutorial-kit/tree/demo-reference-to-file-in-template
In essence, I took the basic template, replace vite to support react and typescript.
Added a file:
src\templates\default\other-function.ts
export function otherFunction() {
  alert("other function ");
}

Added a file:
src\content\tutorial\1-basics\1-introduction\1-welcome\_files\test.ts
import { otherFunction } from "./other-function";
export function test() {
  otherFunction();
}

It works well when I developer, but it fails build.
There are valid use cases, where I want my user to focus on a specific file, while using code in other files of the project that exist in the template, without seeing them in each lesson
Expected behavior
I wish it would build :)
Screenshots
No response
Platform

TutorialKit version: 0.1.2
OS: wsl windows
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context
No response

I've used exclude: ['src/content'] to avoid these errors. I'm not sure if it's even possible to fix this properly for typescript.
https://github.com/AriPerkkio/tutorial-vite-plugin/blob/1f161a22bd80c9529ceeac8080dfb27f3db8a318/tsconfig.json#L12


Skeleton for the mirroring client

This PR introduces configuration, a MirroringTable with a simplistic implementation of some requests and an AsyncTableWrapper, which enables that implementation.

@googlebot I fixed it.

@googlebot I fixed it.

@googlebot I consent.


error in logs of metric pod and no metric usage data collected

G'day y'all. I've since found a solution but sharing it here to have a reference of the error message in case someone else comes across it.
What happened:
After deploying using helm I would get following error in the logs of the metric pod. Limited metric usage data was available.
oc logs -p splunk-connect-for-kubernetes-splunk-kubernetes-metrics-abcdef [ ... ] 2020-07-03 07:33:27 +0000 [error]: #0 Unexpected error raised. Stopping the timer. title=:metric_scraper error_class=Net::HTTPBadResponse error="wrong status line: \"\\x15\\x03\\x01\\x00\\x02\\x02\"" [ ... ]

What you expected to happen:
have usage metrics and _dims populated
How to reproduce it (as minimally and precisely as possible):
helm install splunk-connect-for-kubernetes -f splunk-connect_v2.yml https://github.com/splunk/splunk-connect-for-kubernetes/releases/download/1.4.1/splunk-connect-for-kubernetes-1.4.1.tgz
have useRestClientSSL: true in the YAML values file on a cluster that uses SSL for the kube api
Anything else we need to know?:
Environment:
Openshift 3.11
Splunk Connect for Kubernetes 1.1.4

The hex characters in the error message are a result of SSL being in place while the API is called without SSL
Change useRestClientSSL from false to true in the splunk-kubernetes-metrics section of your values file and redeploy using helm
Here's the link to the template to see where the setting goes: https://github.com/splunk/splunk-connect-for-kubernetes/blob/develop/helm-chart/splunk-connect-for-kubernetes/values.yaml
useRestClientSSL: false
to
useRestClientSSL: true

You should now receive a complete set of metrics


Feat: Adding underline.html for Support to the Marks of Type Underline

In the ongoing efforts to enhance our application's rich text editing capabilities, we've integrated the Tiptapy module, a powerful tool designed for converting JSON representations from Tiptap into HTML. This integration aims to leverage Tiptapy's robust framework to streamline the rendering process of our rich text content, ensuring a seamless user experience.
During the integration process, we encountered a limitation concerning the rendering of underlined text. The Tiptapy module, as initially integrated, did not support converting JSON data that represents underlined text into the corresponding HTML markup. Recognizing the importance of underlined text in conveying emphasis and structure within textual content, this feature's absence was notably felt.
To address this gap and enrich our application's text formatting capabilities, I have developed and introduced a new template file named underline.html. This template is specifically designed to support marks of the type underline, enabling the Tiptapy module to accurately render underlined text as per the JSON data received from Tiptap.
The addition of underline.html expands our application's formatting options, offering users the flexibility to underline text, thereby enhancing the expressiveness and readability of the content they create.
Implementation Details

Created a new template file underline.html within the templates/marks directory.
The template defines HTML markup for rendering underlined text, utilizing the <u> tag to wrap the designated content.
Integrated the underline.html template with the Tiptapy rendering process, ensuring that JSON data specifying underlined text is correctly translated into HTML.

Testing and Verification

Conducted thorough testing within our project environment to confirm that the underline.html template functions as intended, successfully rendering underlined text according to the JSON specifications provided by Tiptap.
All existing tests related to the Tiptapy module and text rendering were run to ensure compatibility and stability. The introduction of underline.html has not impacted the module's existing functionalities.

Conclusion
The addition of the underline.html template significantly enhances our application's text formatting capabilities by enabling the rendering of underlined text. This feature not only aligns with the objectives of leveraging Tiptapy for rich text editing but also addresses a crucial user need for diverse text formatting options. I look forward to seeing this enhancement integrated into our project, further enriching the user experience.

I invite the team to review this pull request, test the added functionality, and share any feedback or suggestions. Your input is invaluable as we strive to make our application more versatile and user-friendly.

Thanks @Raksantos.
underline mark is released in<EMAIL_ADDRESS>


Support Custom field on cart for Dovetech Data Instance Mode

Setting the value read from the cart if present

@DownChapel  you mentioned something else would be needed. Could you please expand on that?


Custom node_modules fail to render with googlebot and legacy browsers if they use es2015 or later syntax

Bug report
Next.js applications that use packages using recent ES6 builtins, like include crash when google bot wants to render them. Google bot uses chrome 41 that is missing some built-ins that are available in node and are more and more popular within JS community, especially universal packages.
Bug can be reproduced with https://github.com/sheerun/with-apollo The app is available at https://sheerun-with-apollo.now.sh/ though you need to deploy it by yourself if you want to test it with https://www.google.com/webmasters/tools/googlebot-fetch-details
The error happens when app imports https://github.com/sheerun/awesome-includes package I've created that uses [].includes internally (there are other npm packages that do similar things). Apollo has nothing to do with this bug (though it used some builtins before that caused similar crash).

The workaround is to transcompile final bundles for production build and embed builtins in within them. I wrote targets-webpack-plugin to fix this but I suspect it'll be too heavy to embed within next.js by default as it uses babel for generating imports for used builtins  +rollup for actually injecting builtins, which can cause high memory usage. I hope next.js team will find more lightweight solution.
As shown in reproduction I use newest available next.js 7.
This is continuation of #3205 which only partially fixed the problem.
EDIT: I think ideally next.js would have webpack plugin that discovers builtins used by application and its dependencies and injects their shims into common javascript bundle.

Thank you for taking the time to do this.  I too hope next.js team could provide a built in solution to reduce the chances that google isn't actually indexing our sites because of something like this that is so easy not to notice.

Closing this in favor of #706 and #3056


Validate community marketplace

As a follow-up of https://github.com/openstack-k8s-operators/install_yamls/pull/814

recheck

/ok-to-test

/hold

/unhold

/retest-required


ValueError: cannot reshape array

Dear all,
I want to use VGG16 model with Theano backend on CPU.  When I load the model I get an error as below

I have updated keras (version 1.0.0) and theano (2.0.9) version. Any suggestions?

Can you share the settings in your $HOME/.keras/keras.json file and also the values for num_channel, img_rows and img_cols.
I tried the following code snippet and it works:
from keras import applications
from keras.layers import Input

image_input = Input(shape=(3, 224, 224))
model = applications.vgg16.VGG16(include_top=True, weights='imagenet', input_tensor=image_input)
model.summary()

Thank you for your reply.
Its working for me too.


Social links '.nuxt.dev' are not being redirected

Hi,
I'm new to nuxt.
While starting a new app I tried to reach the github repository and stumbled upon the following error at the original URL :
Error 1000 Ray ID: 7bc962e84ec8d61d • 2023-04-23 22:01:39 UTC
DNS points to prohibited IP
This might not be a code issue, but I noticed that the social links are different from Nuxt official website.
I noticed that these URLs should be redirected but it does not seems to be effective.
Here are the occurences of https://github.nuxt.dev  within the repo :

Sorry about this, it's now fixed! It was a DNS issue


pistache:x64-windows build failure

Host Environment

OS: Windows x64
Compiler: Visual Studios 2019

To Reproduce
Steps to reproduce the behavior:
vcpkg install pistache
Failure logs
Computing installation plan...
The following packages will be built and installed:
pistache[core]:x64-windows
Detecting compiler hash for triplet x64-windows...
Could not locate cached archive: C:\Users\Admin\AppData\Local\vcpkg\archives\8d\8d0e6ada36d58e3456c7b7db067b037b7bb74dc0.zip
Starting package 1/1: pistache:x64-windows
Building package pistache[core]:x64-windows...
CMake Error at ports/pistache/portfile.cmake:2 (message):
pistache currently only supports Linux platform.
Call Stack (most recent call first):
scripts/ports.cmake:136 (include)
Error: Building package pistache:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: pistache:x64-windows
Vcpkg version: 2020.11.12-nohash
Additionally, attach any relevant sections from the log files above.
.\vcpkg update
Using local portfile versions. To update the local portfiles, use git pull.
No packages need updating.
git pull
warning: Pulling without specifying how to reconcile divergent branches is
discouraged. You can squelch this message by running one of the following
commands sometime before your next pull:
git config pull.rebase false  # merge (the default strategy)
git config pull.rebase true   # rebase
git config pull.ff only       # fast-forward only
You can replace "git config" with "git config --global" to set a default
preference for all repositories. You can also pass --rebase, --no-rebase,
or --ff-only on the command line to override the configured default per
invocation.
Already up to date.

@ishaantantra ,Thanks for posting this issue,Currently pistache does not support the windows platform, if you have a need, you can contact the official pistache staff.

The pistache currrently only support linux on official, please report an issue to Upstream instead.


source venv/bin/activate fails on windows

How do I setup the environment on windows?  The documentation seems not specify how to run "source venv/bin/activate" on windows and "source venv/bin/activate" returns:
The term 'source' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
I also tried:
venv\bin\activate.bat

I tried venv\Scripts\activate.bat and that seemed to work.  Maybe update the documentation to include the windows version.


WIP: Feature/ifu 922 d10 prep - intermediate review requested

IFU-922
We are preparing the site to be d10 compatible
What was done
So far, updating modules and removing unneeded modules using upgrade_status for info

This thing was fixed

How to install

Make sure your instance is up and running on correct branch.

git checkout UHF-0000_insert_correct_branch
make fresh

Run make drush-cr

How to test

[ ] Check that this feature works
[ ] Check that code follows our standards

Designers review

[ ] This PR does not need designers review
[ ] This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

Link to other PR

This has been covered also here: https://github.com/City-of-Helsinki/drupal-infofinland/pull/275


Syntax highlighting not updated when scrolling

Scrolling doesn't update highlighting, so the colors stay in the same position regardless of the text being shown.
Tested using psedit v0.0.3

This was resolved in 0.0.4


First version of Jenkins Declarative Pipeline

added seed job for Declarative Pipelines,
added sample Jenkinsfile

This PR depends on #46


Declare Catogory as an abstract

Create a separate app

This application will be used for general purposes, for Categorising, tagging or even using different templates


Ability to update cached images on hosts

Currently, there is no way to force Rancher to pull the latest version of an image from DockerHub if a latest version image is already on the host.
Ideally, there would be some kind of mechanism or option to pull a latest version of an image so that when we start the container (or containers from a service) it could pull a new latest before it runs.

I would add that its an issue with private registries as well.

:+1:  for this!

#1277

I was about to post a similar request but I wonder though if this is a good idea. I would think that for production ops, we would want to be pretty explicit about the version of the container that we use. So using the explicit release version for the container we're interested should be enough to get the latest image on all the hosts.
It would certainly be convenient to have some sort of universal 'pull' request that would fetch all the latest images on all the hosts, but I wonder if thats actually a good idea?

Here is a use-case for this:
As I am building my rancher stack and testing out each container I run into a problem with one of my docker builds for a container. I make a change to the Dockerfile, re-build it, push it to our registry and re-create it in rancher using the same image.
Now, I could just create a new tag every time I make a change, but since this is still experimental I am re-building the containers.
Another use-case: We want to just have a general "Development" version of a container that can be used at any time to have the latest development version of the service container from our develop branch. I cannot just "refresh" my rancher stack to pull a newly updated image.

Yep, that's the exact same scenario that drove me to this PR. I wanted to iterate on a container without having to tag and modify the build scripts each time I made a small change. I think it would be nice to have some sort of command that I could tell rancher to pull down the latest image. I'm just raising the question that if this is easy to do, that it might encourage less than best-practice from users of rancher. To be clear, not raising an objection to the feature, I want it as well, just surfacing the question intended/desired behavior from an ops stack.
Using their api it's not too hard to write a script that iterates through each of the hosts registered with docker and issue a docker pull for the image in question.
In the end I just ended up build a rake task that builds and tags the container and updates the version automatically. Kind of the best of both worlds - deploying a specific version but still pretty easy to iterate.

+1 for this too. I'm using private repositories and if i tag an image as "latest", I'd assume that rancher would check if the image is updated every time a container is created. Without it, I'd have to tag every image during CI builds, and I guess i'd have to change the rancher-compose.yml file (this is getting dirty) to reference the new tag.
Without the "latest" check, automating pushes and continuos deployment becomes very tricky

While I expect we'll implement an optional way to do this, and can see the convenience value for development, it is definitely a concern that this is a terrible thing to encourage for production use.
Using latest means (short of comparing sha256-sums) you're going to have no idea what version is deployed on a particular container, whether they all match, or have an easy way to go back to the previous revision when things go bad.  It's also a slow asynchronous action that might fail, now in the critical path of starting a container.  When it does fail that now has to be surfaced somewhere as a partial-success (or the deploy fails, but then DockerHub downtime becomes a denial of service on your Rancher.)

@vincent99 The issue is that as of now, with rancher-compose I can't specify a image version to override the one in the yaml file, so I'd have to create a bash script that creates a new docker-compose.yml every time i want to make an updated deploy.
If it helps, the people of Tutum suggest using versioning (i agree that it's a more secure/safe way), but in case the service uses a image:latest, the node will pull it before each new deploy (not before each start, just when a redeploy is issued)

We will have support for templates/variable substitution in the compose.yml file soon: https://github.com/rancher/rancher/issues/1272
Right, I meant critical path of "creating" a container, not "[re]starting".  Do they special-case only "latest"?  That seems bizarre, people use things like "beta" too.  Maybe something like not matching  /^v?[0-9.]+$/ would be more reasonable but I still don't like the idea of the behavior being implicit magic vs an explicit checkbox.
Another way to accomplish this is polling (or web hook triggers) to run docker pull on images you care about periodically (or when they change).  That gets you updated images on the hosts you care about, so you could run it only in dev.  And it works with anything, without requiring any integration into Rancher.  We built a toy version of this at the last DockerCon hackathon: https://github.com/rancher/sherdock

Yes, we definitely need this, thanks.

+1

+1

Tested with build from master - Sep 18 and rancher-compose version - v0-4-0-rc2
Following options are now supported and functional (for details of how these options work refer to - #1955 )

rancher-compose pull [--cached] [SERVICE...]
rancher-compose upgrade --pull ...
io.rancher.container.pull_image=always

Issues seen when testing these options are tracked in different tickets.

I know this is a VERY OLD thing, which was working perfectly until a while ago when I updated to the latest stable version of rancher... images are getting cached in my hosts... and updating to image:latest yields the same old cached image.. effectively breaking our dev process, tagging works fine but that triggers builds on prod and is LESS than ideal.
using v2-beta

Please file a new issue with the used versions and used config so we can take a look.


Markdown Anchor Link

Hi,
There is minor issue with title links in Readme.md file imported on OpenExchange.
Ex, link to a title :
2. [Simple Http Client Sample](#Simple-Http-Client-Sample)

.... content ...

## Simple Http Client Sample

On OEX, users are redirected to the main page.
I think, it could be fixed by adding a tag  on each title, ex:

Simple Http Client Sample

Lorenzo.

#143 issue is set up for this problem, task in the process

#143 issue is set up for this problem, task in the process

@Lena-Ev I think this was incorrectly marked as a duplicate of #143. Please reopen it.

We'll check!

done^ check pls on this app:
https://openexchange.intersystems.com/package/Config-API#Prerequisites


Negative balance on an account

I have made many transactions in quick succession. Now I have a negative balance on an account.
I haven't changed anything since then and could also make the Stronghold file available if the individual transactions need to be traced.

I managed to reproduced quite easily the issue by processing several sending , without waiting for the update on the account.
Nevertheless after some time, when you got a timeout on firefly and you need to connect again with pin code, the balance is correctly set to 0.

Yes, after restarting the wallet, everything is fine again.
Nevertheless, the wrong display should be prevented.

This should be fixed in the next version. If you experience balance problems in the next version, please reopen this issue.


Add use case examples to README

It'd be nice to add a full example workflow, e.g. posting messages about opened and merged pull requests to a Slack channel.

Hi!
Coming from https://github.community/t5/GitHub-API-Development-and/GitHub-Actions-get-the-PR-ID-that-started-it/m-p/18444#M812
My use case is this: since GitHub notifications is kinda messy and it's hard to notice that something's happened, I want to be able to send a message on Slack when a PR is open. The message should, at last, include the link to the PR, and maybe the title too.

As explained on the link, maybe we could create an action that sets env variables based on the contents of the GITHUB_EVENT_PATH file, and use those variables as arguments for your action.
Maybe something like MY_VAR "json.path[0].to.relevant.content", this would use jq to get the specified contents of the file and set the value to MY_VAR env variable. Then in I'd use $MY_VARV as inputs of this image.

@mrcasals Makes sense. Yeah, I'm working on a way to allow flexible event object access via the arguments to this GitHub Action. So the arg could be something like New pull request opened: ${pull_request.title}, and the Action would automatically parse the argument and attempt to substitute the event object value for ${pull_reqeust.title}.
Does that make sense? Let me know your thoughts.

There's a GitHub action for this:
action "On review submission" {
  uses = "actions/bin/filter@c6471707d308175c57dfe91963406ef205837dbd"
  args = "action submitted"
}

https://github.com/actions/bin/tree/c6471707d308175c57dfe91963406ef205837dbd/filter

May I ask if this issue is still valid?

What happened to this issue?
The linked issue about needing env var support is still valid, yet was closed in favor of this.


examples: Update NI-Scope to demonstrate PinGroup usage

[x] This contribution adheres to CONTRIBUTING.md. (Required)
[x]  Automatically post PR comments with images for G code changes? (Recommended for small changes)

What does this Pull Request accomplish?

Update the NI-Scope example to reserve the session using a pin group by grouping existing pins.

Why should this Pull Request be merged?
To demonstrate obtaining connections at both the individual pin and pin group levels when reserving the session using a pin group:

Obtain connections using individual pins.
Obtain connections using pin groups.

What testing has been done?

Manually ran the measurement and verified it from both InstrumentStudio and TestStand.

I've created the ni_measurementlink_generator and ni_measurementlink_service locally and validated the example. I'll keep the PR open until we have the pre-release ready (Joel will assist in creating it) and can test the changes with the latest packages. Kindly consider reviewing the changes.

@dixonjoel I've validated this example with the latest pre-release and it's working fine in both InstrumentStudio and TestStand. Hence, I'm merging this PR and we're good to add this example in the pre-release.


Add Talon encoder wrapper with simulation

This will allow for simulating the shooter as far as the robot is concerned.

I hear CTRE have implemented simulation for encoders for 2021, so we should look into using that instead.


Remove toolkit styles and components from search page

https://trello.com/c/v8J4QAoc/238-2-review-search-page-changes

Live search maintains its jQuery-ness, but with updated object refs for DMGOVUKFrontend. Removing jQuery can be handled separately from DS3.
The clear filters script doesn't appear to be doing anything, as on the page, clicking the clear filters link just reloads the page. So I got rid of it.
As far as I can tell, the toolkit option select was only used on the search page, so I've got rid of that import too.

My review checklist
I've:

[ ] looked at the code
[ ] tested locally
[ ] run functional tests locally


Der and flexible api

Hello from Axant Srl
We added support to deserialize der encoded rsa keys.
Also added the ability for the user to specify other load_functions
Also we reached 100% code coverage on the file jwt/jwk.py
EDIT: Also, the user can now specify the password by private_password keyword argument in jwt_from_pem and jwt_from_der
Best regards,
Vincenzo

note: a test fails with
python-jwt/jwt/jwt.py:71:5: C901 'JWT.decode' is too complex (16)

but we didn't touch it

@CastixGitHub I've just merged this PR and another one commit from #34 ( https://github.com/axant/python-jwt/commit/b5a2304d16585554ced629bbea973a637befb19a ). Thank you very much for your contributions!

@CastixGitHub I've just merged this PR and another one commit from #34 ( https://github.com/axant/python-jwt/commit/b5a2304d16585554ced629bbea973a637befb19a ). Thank you very much for your contributions!


Spaces and subfolders

Hi,
I have to be honest.... I'm struggling with this one.
I have no problem pushing into a space,  but I can't seem to get anywhere trying to push 'view' creatin in a sublevel (folder of a space)
Taking your test installation, my_first_dbt, and my_second.....
These create in the space 'dbt'
What needs to be changed to get 'my_second....'   to be created into dbt.reports 'folder' ?
It must be something simple I'm missing?
Thanks
Paul.

Hi @spireitepaul , thank you for giving dbt a try on dremio.
There is no such thing as a CREATE SCHEMA in dremio for the time being.
So  the space structure must be created beforehand
I was hoping to see santa claus put this feature in dremio v20...
A way to offer that is to create a web API based version of the adapter.
Hoping to have time for the adapter in early february.
Best regards from french west coast !

Hi Fabrice,
I thought that was pretty much the case.
So, in the dbt_project, I had
+schema: no_schema for model/example.
and for model/example2
+schema: sublevel1
I had a battle also with trying to overwrite the schema as I found that I was getting a generated schema name of no_schema_sublevel1, when I just wanted sublevel1 for model/example2
For the record of anyone else looking, in the macros directory OF THE PROJECT  created a get_custom_schema.sql file containing.
_{% macro generate_schema_name(custom_schema_name, node) -%}
{{ custom_schema_name }}

{%- endmacro %}_
which achieved what I wanted.

Hi @spireitepaul ,
the documentation might need to be more explicit, I will try to rewrite it.
In the last chapter, there is a link to the custom schema and database macros I propose to use in combination with the 'environment' notion.


Adds a custom log4js format function to log sql query from POST requests

Tokens in log4js are not provided with request/response for context, using a custom format function allow to access them.
In the case of express logger token functions receive request/response for context so it uses a custom token.
SQL_QUERY_BODY_LOG_MAX_LENGTH = 2000 might seem a bit arbitrary but it tries to match which is considered a sane max length for a GET query string. That means that we won't log more than we might log during a GET request with a lengthy query string.
Closes #206

@rafatower Do you think this is enough to close #206?
@luisbosque please, let me know if this is a problem for ES.
Thanks :smile:

Looks good to me

:+1:


Add a CloseCode Enum

I was looking for an Enum containing definitions of the standard close codes, and couldn't find one. Is this something that could be provided to users? I think an IntEnum would be a good way to implement this.
It seemed like this library would be the correct place to implement such an Enum for Python users.
References

https://www.rfc-editor.org/rfc/rfc6455.html#section-7.4.1
https://developer.mozilla.org/en-US/docs/Web/API/WebSocket/close
https://github.com/Luka967/websocket-close-codes
https://learn.microsoft.com/en-us/dotnet/api/system.net.websockets.websocketclosestatus?view=net-8.0

In practice, this would mean turning https://github.com/python-websockets/websockets/blob/main/src/websockets/frames.py#L55-L73 into an Enum and making it a public API, similar to Opcode.

There's a problem, though: extensions can use arbitrary close codes in the 2xxx range and applications can use arbitrary close codes in the 4xxx range, as explained in https://www.rfc-editor.org/rfc/rfc6455.html#section-7.4.2. This cannot be represented with an Enum. How did you plan to handle these cases?

I was thinking about these as similar in use to http.HTTPStatus in the standard library.
They don't cover all possible cases, but they provide self-describing names for the standard codes so that user code is clearer and has few magic numbers that can be prone to typo errors.
So in this case, the actual close() methods would still all take int, but if you as a user explicitly want to use one of these standard codes or compare against them, you have a nice clear, safe way to do that with an IntEnum.
For example:
# before:
close(1002)

# after:
close(WebsocketCloseStatus.ProtocolError)

# before
if status == 1002:

# after
if status == WebsocketCloseStatus.ProtocolError:

For example, in the Django Channels library, I saw a magic 1000 that could be replaced with a more self-describing IntEnum:
https://github.com/django/channels/blob/7e7b71a405db1dbc7509f290b1b158bd07b74c1b/channels/worker.py#L12
User applications can also have these kinds of situations. These applications might also define Enums for custom errors in the 4xxx, but that is out of the scope of something standardized. In these cases they might mix usages of the standard websocket codes with their own Enums.

The difference is that HTTP error codes cover all possible cases and HTTP libraries crash if they get a code that they don't recognize.

In other words, I'm not convinced by:
@property
def close_code(self) -> CloseCode | int:
    """Return a CloseCode or, if not recognized, an int."""

This doesn't look like a convenient API for the caller.

To be clear: I recognize that the problem is valid but I don't think that the proposed solution is an improvement over the current situation.

In other words, I'm not convinced by:

@aaugustin I also do not think any APIs should change and would not advocate for this change. I was thinking that this Enum/IntEnum would be used exclusively by end users when referencing these common codes as shown in https://github.com/python-websockets/websockets/issues/1335#issuecomment-1508392907
To me, this is similar to how most HTTP libraries still use an int for their API for status codes, here's an example from httpx:

https://github.com/encode/httpx/blob/4b5a92e88e03443c2619f0905d756b159f9f0222/httpx/_models.py#L445-L448

But httpx still defines an IntEnum for end users to use when setting/checking the ints that used in the API:

https://github.com/encode/httpx/blob/4b5a92e88e03443c2619f0905d756b159f9f0222/httpx/_status_codes.py#L4

But HTTP status codes are still useful for users of the library to avoid magic numbers when possible.
So, to be clear I would only be advocating for defining an Enum/IntEnum (probably an IntEnum given this is explicitly not exhaustive) in this library. None of the APIs would need to change because, as you show, given that it's not exhaustive. I agree that CloseCode | int is not a useful type.

The difference is that HTTP error codes cover all possible cases and HTTP libraries crash if they get a code that they don't recognize.

Is this true? The HTTP libraries I've seen use int in their APIs and I've always assumed they would pass back the exact int sent over the wire. I suppose we could try sending something like 209 to httpx/requests/http.client.

The difference is that HTTP error codes cover all possible cases and HTTP libraries crash if they get a code that they don't recognize.

I tried out a quick Flask/HTTPX application and non exhaustive HTTP status codes are supported.
# server.py
from flask import Flask

app = Flask(__name__)

@app.route("/")
def hello_world():
    return "
Hello, World!
", 209

# client.py
import httpx

response = httpx.get("http://<IP_ADDRESS>:5000")
print(response)
print(response.status_code)

flask --app server run

py .\client.py
<Response [209 UNKNOWN]>
209

I'm still skeptical about this. Overall, WebSocket close codes are much less important than HTTP status codes.
In ten years of maintaining this library, I never came across any situation where the WebSocket close code matters 🤷
In practice, all you care about is that the connection dropped. Maybe you'll reopen it. The details are only for debugging.

No problem, definitely understand. I trust your judgement. Thanks for considering. 😄

Maybe you could tell me a bit more about why you wanted this Enum? What's your use case?

I sketched a pull request. Now the question is -- to what extent would it make sense to use this enum in the internal implementation?

PR looks great!

to what extent would it make sense to use this enum in the internal implementation?

My personal opinion is to use them wherever they improve readability. I would personally default to using the Enums unless there was some compelling reason not to since to they express intent, are less prone to small typos, and are self documenting.
But there is no reason you have to use them everywhere.


Stairs generator

Feature branch: None
Since it is failry common to have large stretches of incline of varying degrees, it would be nice to be able to define two points and have stairs laid automatically based on the incline and a palette.
Pro:

[fill me]

Con:

[fill me]

Moved to https://github.com/avdstaaij/gdpc/issues/28


Added simple custom JavaDocs for the tests produced by Fuzzer

Description
It provides the first phase of JavaDocs and suggests the unification with the other JavaDocs
Fixes #601
Type of Change

New feature (non-breaking change which adds functionality)

@onewhl could you please make a review?


Update to the new version of animation player

[x] Upgrade to R2021c
[x] Closing the animation player when clicking outside of it
[x] Display the animations as an overlay on the center of page
[x] Put a black-transparent overlay on the whole page when playing an animation

I have just started a test here:

https://github.com/cyberbotics/webots-competition-organizer-template/blob/master/.github/workflows/build_animation.yml
https://cyberbotics.github.io/webots-competition-organizer-template/


Remove Control Character from Bluebeam.Revu.21

Resolves #152700
Related to microsoft/winget-cli#4436

Microsoft Reviewers: Open in CodeFlow

Waivered in https://github.com/microsoft/winget-pkgs/pull/148432

Automatic Validation ended with:

Installation failed with exit code -1978335226
2024-05-08 13:43:20.767 [CLI ] ShellExecute installer failed: 1603

Automated error analysis suggests 1603 may mean Install successful but system restart may be required.
Automated error analysis suggests -1978335226 may mean Install successful but system restart may be required.
(Automated response - build 880.)


Test VM for open calls

Summary
Build a QEMU VM open call devs can use to test basic interaction between their services and the platform infra.
Intended outcome
An open call dev can download the VM image, spin it up and have a basic KITT4SME cluster instance ready for testing within minutes. They should be able to deploy an AI service as documented in the deployment tutorial.
How will it work?
Pack a subset of the whole cluster orchestration and mesh infra in the VM, plus the FIWARE core and DBs (platform infra services) and leave all the rest out. Follow the cluster bootstrap procedure to build the VM after having installed Ubuntu (server) 20.04.

Created a vagrant vm box from ubuntu2004 base box.
Uploaded in vagrant cloud available in path:  kitt4sme/single_node_cluster
Proposed configuration (any other vagrant user preferred configuration based on vagrant docs will do):
Vagrantfile:
# encoding: utf-8
# -*- mode: ruby -*-
# vi: set ft=ruby :

VAGRANTFILE_API_VERSION= "2"

require 'yaml'

current_dir    = File.dirname(File.expand_path(__FILE__))
config_file    = YAML.load_file("#{current_dir}/config.yaml")
vagrant_config = config_file['settings']

Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
    config.vm.box = vagrant_config['box']
    config.vm.define vagrant_config['name']
    config.vm.hostname = vagrant_config['name']
    config.vm.network vagrant_config['network'], ip: vagrant_config['ip']
    config.vm.provider vagrant_config['provider'] do |v|
        v.gui = vagrant_config['gui']
        v.name = vagrant_config['name']
        v.memory = vagrant_config['memory']
        v.cpus = vagrant_config['cpus']
    end
end

config.yaml:
---
settings:
  provider: 'virtualbox'
  box: 'kitt4sme/single_node_cluster'
  gui: false
  name: 'kitt4sme'
  network: 'public_network'
  ip: '<IP_ADDRESS>'
  memory: 8192
  cpus: 4

The ip has to be changed and a replacement of 'public_network' to 'private_network' maybe needed according to the desired deployment
Place Vagrantfile and config.yaml in same directory and from this directory execute the command:
vagrant up

The vagrant box will be downloaded and the vm will be created on the host.
Currently supported providers:

Virtualbox

Future providers to support:

Hyper-V
Libvirt

@tassosgeo good stuff!!


[BEAM-6028] Share docker image name along with shared task

This fixes 42984a821b3e73aee2966d11d7fb436b5ff22b68, which refactored the Dataflow runner build scripts to share a common buildAndPushDockerContainer task. However the task internally uses a dockerImageContainer variable which was not shared between projects and incorrectly duplicated: the generated name has an embedded timestamp, which will be re-evaluated per-project.
This change refactors the projects to also share a single dockerImageContainer property.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
 I had assumed that these tests were using the same Docker container and so we could just build and upload them once in a shared task.
Are there real differences in the container images such that they should be kept separate?

@boyuanzz let me know if you have concerns about this change or whether it needs changes. I believe it is ready for review and merge.


Remove rating objects to reflect API responses more closely

Followup to conversation on our ruby gem: https://github.com/Yelp/yelp-ruby/pull/41
The clientlibs should be as close as possible to the actual API response so the Rating response object is being removed. The various names for the rating image url are added directly to the Business and Review objects.

:shipit:


Describe LoongArch macros

There is an ongoing discussion about predefined macros happening on their GitHub: https://github.com/loongson/LoongArch-Documentation/pull/28
GCC and LLVM recently added support for this architecture. But I think, it should be added after the changes will be merged.
cc @xen0n

Update: PR is merged and updated documentation is available at https://loongson.github.io/LoongArch-Documentation/LoongArch-toolchain-conventions-EN.html.


Career Mode: Pretty "advance a certain number of levels" screen

This may be duplicated by #1144. I can't tell if there should be two screens.

There is now a chalkboard screen which shows the player advancing through the game.


I found a broken link

@ZeynaInsa I can't really tell where you found that broken link. I'll close this issue, but feel free to file a new one if you can point me to the page where the link needs fixing.


RFC

If we can find enough common ground a spec of some kind with Serverless for config etc would be nice

everyone is just doing their own thing


[release-0.41]Increase memory for validation of container disk

What this PR does / why we need it:
This fix is for newer versions of golang(1.14+) which seems to allocate more memory for exec.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
Fix: Kubevirt build with golang 1.14+ will not fail on validation of container disk with memory allocation error

/retest

/approve

/retest

/retest

/hold
@xpivarc i see that the test test_id:5004 failed on every run for the job pull-kubevirt-e2e-k8s-1.18 on the latest commit, could you take a look, please?

/hold
@xpivarc i see that the test test_id:5004 failed on every run for the job pull-kubevirt-e2e-k8s-1.18 on the latest commit, could you take a look, please?

I think it should be in QUARANTINE, see https://github.com/kubevirt/kubevirt/pull/5908

@itamarh FYI

Hm, could also be a flake according to ci search: https://search.ci.kubevirt.io/?search=test_id%3A5004&maxAge=336h&context=1&type=bug%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job
@fgimenez do you know?

Hm, could also be a flake according to ci search: https://search.ci.kubevirt.io/?search=test_id%3A5004&maxAge=336h&context=1&type=bug%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job
@fgimenez do you know?

Nevermind.

/override pull-kubevirt-e2e-k8s-1.18

/unhold

@dhiller Thanks!

@dhiller @xpivarc Sorry guys, I had this https://github.com/kubevirt/kubevirt/pull/5895 PR going on to try to see if 5004 passed, therefore I removed the quarantine tag. Eventually I wanted to  get the quarantine back, merge the PR, and see the the periodics don't fail for 14 days. I didn't noticed that this PR got approved and merged. Therefore immediately merged this https://github.com/kubevirt/kubevirt/pull/5908.
Sorry for the inconvenience. I should /hold such PRs from now on.

/retest


Load custom CSS after all to be more customizable

Load user's custom CSS after default framework CSS to be more customizable. For example when you want change system whole fonts if custom CSS load after all it is too easy to customize while if you load user's CSS before all it is hard and you need more complicate css selector

Is any problem exist? Can I help?

select2 will has css style problem. #5456

bug: Fixed by adding $appendCss param to css method

You can refer to this: https://github.com/Hanson/rainbow

Thanks for your response. It is good idea, but is my idea has a problem?

On Fri, Nov 12, 2564 BE at 11:44 Taha Moghaddam @.***>
wrote:

Thanks for your response. It is good idea, but is my idea has a problem?
What happens man? What can I do fo yo sir?但還是很開心啊俯ㄧˇ—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/z-song/laravel-admin/pull/5461#issuecomment-966907517,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVPSACHU36AWDK7DUH2LS2LULTEGBANCNFSM5HOHOXFA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Love


Move tooling to LLVM 18

We should move our tooling to LLVM 18 as soon as it is available in homebrew.
Related PR in homebrew: https://github.com/Homebrew/homebrew-core/pull/165206
In nixpkgs LLVM 18 is already available.

Also try to revert #1344 after moving to LLVM 18.


Error StatusCode 401 Unauthorized

I got this error:

but i got the key and i can use the engine da vinci in playground

Any Luck on this issue?

Nope, I totally changed the way to use NLP models on unity.


Sometimes the UI doesn't go hide

On Nexus 7 2nd edition with Lollipop.
When the app starts the UI hides just fine although if I press and hold the power button, the UI reappear and sometimes when clicking very fast on the screen doesn't go away.

Not sure if it is relevant to your problem, but i call immersiveMode on the native app activate event. I have bumped to cases when pressing the home button to go to the homescreen and then going back to the app shows the UI bars and they remain visible until the immersiveMode is called again.

Yea that's what I do too and it works in any other case, although for some strange reason when you hold the power button, the menu that appears does not trigger deactivate/activate every time. Not sure if it is a bug in Air, Android or the ANE  itself.

I just tested it, yes indeed the UI bars appear and stay.
I doubt it is and AIR bug as it seems the app does not get deactivated at all when the power off prompt appears. It continues to run in foreground.
I have encountered the same sticky UI bars on other apps (i guess non AIR). As far as i remember when the screen is touched they disappear. Not sure this is forcefully done by the developers encountering the same "bug"... It may be quick fix for you though if you don't feel like debugging the ANE.
If i get some free time the upcoming week i will look in it.

I was thinking that too although wouldn't that mean calling immersiveMode every time the user clicks or at least having to check if the UI is up on every touch, unless maybe there is a way to detect the user pressed the power button.

The ANE will try to maintain the current full screen mode using the system events listed on the Android developer website, but I would also recommend calling AndroidFullScreen.immersiveMode(); (or whichever mode you're using) again in your Event.ACTIVATE handler to ensure the correct mode is maintained, which should resolve 90% of the issues you're seeing. We're currently looking into the best way to better integrate this functionality into the ANE directly.
We haven't currently been able to identify a specific cause for the intermittent power menu issue because it doesn't necessarily affect all devices or OS versions. One theory is that it's caused by changes made to Android by handset manufacturers, but if anyone has a better idea, please let us know!

Yes, definitely I am calling again every time Event.ACTIVE is dispatched, although the problem is that holding the power button does not Deactivate/Activate the view, it's almost like nothing ever happened, we have noticed the same issue with Facebook Friends Request overlay not dispatching Activate/Deactivate, we have fixed that one easily by calling immersiveMode again as soon as the user closes the overlay, but with the power button no event at all is ever dispatched.
We have tried this on Note 4, Nexus 7 and Nexus 9 with Lollipop, they all seem to behave identically.

We've found a likely solution to this issue, overriding the Android Activity's onWindowFocusChanged to reset the UI visibility, but haven't yet found a way to implement this in an ANE context; you would normally override this in your app's own Activity class... which AIR apps don't have access to.

In my opinion onWindowsFocusChanged should always dispatch an activate/deactivate on the NativeApplication, maybe it's a bug in Air that can be reported and hopefully fixed?

Please vote for https://bugbase.adobe.com/index.cfm?event=bug&id=3976714

This issue has now been resolved; see https://github.com/mesmotronic/air-fullscreen-ane/releases/tag/v1.3.0


issue #2 | @rebeccahongsf | add border radius to category and filter

Ready for review
Summary

Resolve #2

Steps

Checkout branch
Run npx serve .
Inspect browser and confirm that the category cards and filter select input has a border-radius of 5px
Review code

Nice Thanks! One last thing! can we toss this same radius on the clear button too?

Nice Thanks! One last thing! can we toss this same radius on the clear button too?

Thanks for the speedy review @jwu910.
Looks like the Clear button could use some styling as well. Any thoughts on this?

ho ho ho thanks!


Support passing a swift-log Logger instance

We need to start differentiating between "logging" for which we'll use swift-log's interface, and "UI", which in the context of a CLI is the text that's part of the product experience and that's oriented towards communicating progress/actions to the developer that ran a command.
Noora components fall in the "UI" group, but I think it'd be beneficial to also log what the components do so that the logs can be used later on for debugging purposes.

Hello, I would like to take this up. New to the repository so might need some guidance here :)

Hi @VaishaliDesai 👋🏼
Sure, that'd be amazing. The plan here is to support passing an instance of Logger, to each function in the Noorable protocol. For example:
func singleChoicePrompt<T: CaseIterable & CustomStringConvertible & Equatable>(
        title: TerminalText?,
        question: TerminalText,
        description: TerminalText?,
        collapseOnSelection: Bool
        logger: Logger
    ) -> T

And then use it in implementing each component to leave a trace of what happened. For example, in the above case it can be:
logger.info("Prompted the user to select an option for the question '\(question)'")
...
logger.info("Option '\(option)' selected for the question '\(question)'")

That way, consumers of this package can pass a Logger instance and provide a nice debugging experience to their users.
Let me know if you have any questions ;)

Amazing, makes sense, thanks a lot. I’ll work on it :)

nit: I'd consider for the logger not to be required.


[1.19.2] Incompatibility with any mod including MixinExtras 0.2.0

Combat-Next requests a version dependency on MixinExtras that doesn't seem to include newer versions of the library,
which breaks it with any other mod that includes these versions.
[2012月2023 17:57:02.452] [main/ERROR] [net.minecraftforge.jarjar.selection.JarSelector/]: Failed to select jars for [ResolutionFailureInformation{failureReason=VERSION_RESOLUTION_FAILED,
identifier=ContainedJarIdentifier[group=com.github.LlamaLad7, artifact=MixinExtras],
sources=[
SourceWithRequestedVersionRange{source=[Mod File: D:\Program Files\PCL\.minecraft\versions\testing-1.19.2-Forge_43.3.5\mods\combat_next-1.19.2-1.0.1-all.jar], requestedVersionRange=[0.1.1,0.2), includedVersion=0.1.1},
SourceWithRequestedVersionRange{source=[Mod File: ], requestedVersionRange=[0.2.0,), includedVersion=0.2.0}
]}]

Fixed in 1.19.2-1.0.2.