LibWebView: Fix ProcessAndClient template deduction causing build error

Problem
The compiler is unable to deduce template arguments during aggregate initialization of ProcessAndClient, causing build failures in HelperProcess.cpp.
Solution
Explicitly specify the ClientType template parameter when constructing ProcessAndClient in the Process::spawn() function. This allows proper template argument deduction without requiring changes to the struct definition.

Non-maintainer LGTM. Fixed build issue for me on the latest commit on master

Please wrap your commit messages at 72 characters.
Also, but mainly out of curiosity, what compilers are you two using?

I have updated my commit message to wrap at 72 characters.
This was using Clang on MacOS following the instructions from the documentation.
Here was the original error logs:
./Meta/ladybird.sh run ladybird
ninja: Entering directory `/Users/mike/Projects/ladybird/Build/ladybird'
[0/2] Re-checking globbed directories...
[5/27] Building CXX object Ladybird/WebContent/CMakeFiles/webcontentservice.dir/__/HelperProcess.cpp.o
FAILED: Ladybird/WebContent/CMakeFiles/webcontentservice.dir/__/HelperProcess.cpp.o
/opt/homebrew/bin/ccache /usr/bin/c++  -I/Users/mike/Projects/ladybird -I/Users/mike/Projects/ladybird/Userland/Services -I/Users/mike/Projects/ladybird/Userland/Libraries -I/Users/mike/Projects/ladybird/Build/ladybird/Lagom -I/Users/mike/Projects/ladybird/Build/ladybird/Lagom/Userland/Services -I/Users/mike/Projects/ladybird/Build/ladybird/Lagom/Userland/Libraries -I/Users/mike/Projects/ladybird/Userland -I/Users/mike/Projects/ladybird/Build/ladybird/Ladybird/WebContent/.. -O2 -g -DNDEBUG -std=c++2b -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk -fcolor-diagnostics -Wall -Wextra -fno-exceptions -ffp-contract=off -Wcast-qual -Wformat=2 -Wimplicit-fallthrough -Wmissing-declarations -Wsuggest-override -Wno-invalid-offsetof -Wno-unknown-warning-option -Wno-unused-command-line-argument -Werror -fconstexpr-steps=16777216 -Wmissing-prototypes -Wno-implicit-const-int-float-conversion -Wno-user-defined-literals -Wno-vla-cxx-extension -Wno-unqualified-std-cast-call -fstack-protector-strong -fstrict-flex-arrays=2 -Wno-maybe-uninitialized -Wno-shorten-64-to-32 -fsigned-char -ggnu-pubnames -fPIC -O2 -g1 -Wno-expansion-to-defined -MD -MT Ladybird/WebContent/CMakeFiles/webcontentservice.dir/__/HelperProcess.cpp.o -MF Ladybird/WebContent/CMakeFiles/webcontentservice.dir/__/HelperProcess.cpp.o.d -o Ladybird/WebContent/CMakeFiles/webcontentservice.dir/__/HelperProcess.cpp.o -c /Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp
In file included from /Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:11:
In file included from /Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Application.h:19:
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:79:12: error: no viable constructor or deduction guide for deduction of template arguments of 'ProcessAndClient'
    return ProcessAndClient { Process { type, client, move(core_process) }, client };
           ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:45:41: note: in instantiation of function template specialization 'WebView::Process::spawn<WebView::WebContentClient, WebView::ViewImplementation &>' requested here
        auto result = WebView::Process::spawn<ClientType>(process_type, move(options), forward<ClientArguments>(client_arguments)...);
                                        ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:119:12: note: in instantiation of function template specialization 'launch_server_process<WebView::WebContentClient, WebView::ViewImplementation &>' requested here
    return launch_server_process<WebView::WebContentClient>("WebContent"sv, candidate_web_content_paths, move(arguments), view);
           ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 1 argument, but 2 were provided
struct Process::ProcessAndClient {
                ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 0 arguments, but 2 were provided
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:79:12: error: no viable constructor or deduction guide for deduction of template arguments of 'ProcessAndClient'
    return ProcessAndClient { Process { type, client, move(core_process) }, client };
           ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:45:41: note: in instantiation of function template specialization 'WebView::Process::spawn<ImageDecoderClient::Client>' requested here
        auto result = WebView::Process::spawn<ClientType>(process_type, move(options), forward<ClientArguments>(client_arguments)...);
                                        ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:130:12: note: in instantiation of function template specialization 'launch_server_process<ImageDecoderClient::Client>' requested here
    return launch_server_process<ImageDecoderClient::Client>("ImageDecoder"sv, candidate_image_decoder_paths, arguments);
           ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 1 argument, but 2 were provided
struct Process::ProcessAndClient {
                ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 0 arguments, but 2 were provided
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:79:12: error: no viable constructor or deduction guide for deduction of template arguments of 'ProcessAndClient'
    return ProcessAndClient { Process { type, client, move(core_process) }, client };
           ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:45:41: note: in instantiation of function template specialization 'WebView::Process::spawn<Web::HTML::WebWorkerClient>' requested here
        auto result = WebView::Process::spawn<ClientType>(process_type, move(options), forward<ClientArguments>(client_arguments)...);
                                        ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:141:12: note: in instantiation of function template specialization 'launch_server_process<Web::HTML::WebWorkerClient>' requested here
    return launch_server_process<Web::HTML::WebWorkerClient>("WebWorker"sv, candidate_web_worker_paths, move(arguments));
           ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 1 argument, but 2 were provided
struct Process::ProcessAndClient {
                ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 0 arguments, but 2 were provided
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:79:12: error: no viable constructor or deduction guide for deduction of template arguments of 'ProcessAndClient'
    return ProcessAndClient { Process { type, client, move(core_process) }, client };
           ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:45:41: note: in instantiation of function template specialization 'WebView::Process::spawn<Requests::RequestClient>' requested here
        auto result = WebView::Process::spawn<ClientType>(process_type, move(options), forward<ClientArguments>(client_arguments)...);
                                        ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:161:12: note: in instantiation of function template specialization 'launch_server_process<Requests::RequestClient>' requested here
    return launch_server_process<Requests::RequestClient>("RequestServer"sv, candidate_request_server_paths, move(arguments));
           ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 1 argument, but 2 were provided
struct Process::ProcessAndClient {
                ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 0 arguments, but 2 were provided
4 errors generated.
[6/27] Building CXX object Ladybird/WebWorker/CMakeFiles/webworkerservice.dir/__/HelperProcess.cpp.o
FAILED: Ladybird/WebWorker/CMakeFiles/webworkerservice.dir/__/HelperProcess.cpp.o
/opt/homebrew/bin/ccache /usr/bin/c++  -I/Users/mike/Projects/ladybird -I/Users/mike/Projects/ladybird/Userland/Services -I/Users/mike/Projects/ladybird/Userland/Libraries -I/Users/mike/Projects/ladybird/Build/ladybird/Lagom -I/Users/mike/Projects/ladybird/Build/ladybird/Lagom/Userland/Services -I/Users/mike/Projects/ladybird/Build/ladybird/Lagom/Userland/Libraries -I/Users/mike/Projects/ladybird/Userland -I/Users/mike/Projects/ladybird/Build/ladybird/Ladybird/WebWorker/.. -O2 -g -DNDEBUG -std=c++2b -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk -fcolor-diagnostics -Wall -Wextra -fno-exceptions -ffp-contract=off -Wcast-qual -Wformat=2 -Wimplicit-fallthrough -Wmissing-declarations -Wsuggest-override -Wno-invalid-offsetof -Wno-unknown-warning-option -Wno-unused-command-line-argument -Werror -fconstexpr-steps=16777216 -Wmissing-prototypes -Wno-implicit-const-int-float-conversion -Wno-user-defined-literals -Wno-vla-cxx-extension -Wno-unqualified-std-cast-call -fstack-protector-strong -fstrict-flex-arrays=2 -Wno-maybe-uninitialized -Wno-shorten-64-to-32 -fsigned-char -ggnu-pubnames -fPIC -O2 -g1 -Wno-expansion-to-defined -MD -MT Ladybird/WebWorker/CMakeFiles/webworkerservice.dir/__/HelperProcess.cpp.o -MF Ladybird/WebWorker/CMakeFiles/webworkerservice.dir/__/HelperProcess.cpp.o.d -o Ladybird/WebWorker/CMakeFiles/webworkerservice.dir/__/HelperProcess.cpp.o -c /Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp
In file included from /Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:11:
In file included from /Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Application.h:19:
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:79:12: error: no viable constructor or deduction guide for deduction of template arguments of 'ProcessAndClient'
    return ProcessAndClient { Process { type, client, move(core_process) }, client };
           ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:45:41: note: in instantiation of function template specialization 'WebView::Process::spawn<WebView::WebContentClient, WebView::ViewImplementation &>' requested here
        auto result = WebView::Process::spawn<ClientType>(process_type, move(options), forward<ClientArguments>(client_arguments)...);
                                        ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:119:12: note: in instantiation of function template specialization 'launch_server_process<WebView::WebContentClient, WebView::ViewImplementation &>' requested here
    return launch_server_process<WebView::WebContentClient>("WebContent"sv, candidate_web_content_paths, move(arguments), view);
           ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 1 argument, but 2 were provided
struct Process::ProcessAndClient {
                ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 0 arguments, but 2 were provided
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:79:12: error: no viable constructor or deduction guide for deduction of template arguments of 'ProcessAndClient'
    return ProcessAndClient { Process { type, client, move(core_process) }, client };
           ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:45:41: note: in instantiation of function template specialization 'WebView::Process::spawn<ImageDecoderClient::Client>' requested here
        auto result = WebView::Process::spawn<ClientType>(process_type, move(options), forward<ClientArguments>(client_arguments)...);
                                        ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:130:12: note: in instantiation of function template specialization 'launch_server_process<ImageDecoderClient::Client>' requested here
    return launch_server_process<ImageDecoderClient::Client>("ImageDecoder"sv, candidate_image_decoder_paths, arguments);
           ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 1 argument, but 2 were provided
struct Process::ProcessAndClient {
                ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 0 arguments, but 2 were provided
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:79:12: error: no viable constructor or deduction guide for deduction of template arguments of 'ProcessAndClient'
    return ProcessAndClient { Process { type, client, move(core_process) }, client };
           ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:45:41: note: in instantiation of function template specialization 'WebView::Process::spawn<Web::HTML::WebWorkerClient>' requested here
        auto result = WebView::Process::spawn<ClientType>(process_type, move(options), forward<ClientArguments>(client_arguments)...);
                                        ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:141:12: note: in instantiation of function template specialization 'launch_server_process<Web::HTML::WebWorkerClient>' requested here
    return launch_server_process<Web::HTML::WebWorkerClient>("WebWorker"sv, candidate_web_worker_paths, move(arguments));
           ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 1 argument, but 2 were provided
struct Process::ProcessAndClient {
                ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 0 arguments, but 2 were provided
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:79:12: error: no viable constructor or deduction guide for deduction of template arguments of 'ProcessAndClient'
    return ProcessAndClient { Process { type, client, move(core_process) }, client };
           ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:45:41: note: in instantiation of function template specialization 'WebView::Process::spawn<Requests::RequestClient>' requested here
        auto result = WebView::Process::spawn<ClientType>(process_type, move(options), forward<ClientArguments>(client_arguments)...);
                                        ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:161:12: note: in instantiation of function template specialization 'launch_server_process<Requests::RequestClient>' requested here
    return launch_server_process<Requests::RequestClient>("RequestServer"sv, candidate_request_server_paths, move(arguments));
           ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 1 argument, but 2 were provided
struct Process::ProcessAndClient {
                ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 0 arguments, but 2 were provided
4 errors generated.
[7/27] Building CXX object Ladybird/AppKit/CMakeFiles/ladybird_impl.dir/__/HelperProcess.cpp.o
FAILED: Ladybird/AppKit/CMakeFiles/ladybird_impl.dir/__/HelperProcess.cpp.o
/opt/homebrew/bin/ccache /usr/bin/c++  -I/Users/mike/Projects/ladybird -I/Users/mike/Projects/ladybird/Userland/Services -I/Users/mike/Projects/ladybird/Userland/Libraries -I/Users/mike/Projects/ladybird/Build/ladybird/Lagom -I/Users/mike/Projects/ladybird/Build/ladybird/Lagom/Userland/Services -I/Users/mike/Projects/ladybird/Build/ladybird/Lagom/Userland/Libraries -I/Users/mike/Projects/ladybird/Ladybird/AppKit -I/Users/mike/Projects/ladybird/Build/ladybird/Ladybird -I/Users/mike/Projects/ladybird/Userland -O2 -g -DNDEBUG -std=c++2b -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk -fcolor-diagnostics -Wall -Wextra -fno-exceptions -ffp-contract=off -Wcast-qual -Wformat=2 -Wimplicit-fallthrough -Wmissing-declarations -Wsuggest-override -Wno-invalid-offsetof -Wno-unknown-warning-option -Wno-unused-command-line-argument -Werror -fconstexpr-steps=16777216 -Wmissing-prototypes -Wno-implicit-const-int-float-conversion -Wno-user-defined-literals -Wno-vla-cxx-extension -Wno-unqualified-std-cast-call -fstack-protector-strong -fstrict-flex-arrays=2 -Wno-maybe-uninitialized -Wno-shorten-64-to-32 -fsigned-char -ggnu-pubnames -fPIC -O2 -g1 -Wno-expansion-to-defined -fobjc-arc -Wno-deprecated-anon-enum-enum-conversion -MD -MT Ladybird/AppKit/CMakeFiles/ladybird_impl.dir/__/HelperProcess.cpp.o -MF Ladybird/AppKit/CMakeFiles/ladybird_impl.dir/__/HelperProcess.cpp.o.d -o Ladybird/AppKit/CMakeFiles/ladybird_impl.dir/__/HelperProcess.cpp.o -c /Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp
In file included from /Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:11:
In file included from /Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Application.h:19:
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:79:12: error: no viable constructor or deduction guide for deduction of template arguments of 'ProcessAndClient'
    return ProcessAndClient { Process { type, client, move(core_process) }, client };
           ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:45:41: note: in instantiation of function template specialization 'WebView::Process::spawn<WebView::WebContentClient, WebView::ViewImplementation &>' requested here
        auto result = WebView::Process::spawn<ClientType>(process_type, move(options), forward<ClientArguments>(client_arguments)...);
                                        ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:119:12: note: in instantiation of function template specialization 'launch_server_process<WebView::WebContentClient, WebView::ViewImplementation &>' requested here
    return launch_server_process<WebView::WebContentClient>("WebContent"sv, candidate_web_content_paths, move(arguments), view);
           ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 1 argument, but 2 were provided
struct Process::ProcessAndClient {
                ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 0 arguments, but 2 were provided
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:79:12: error: no viable constructor or deduction guide for deduction of template arguments of 'ProcessAndClient'
    return ProcessAndClient { Process { type, client, move(core_process) }, client };
           ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:45:41: note: in instantiation of function template specialization 'WebView::Process::spawn<ImageDecoderClient::Client>' requested here
        auto result = WebView::Process::spawn<ClientType>(process_type, move(options), forward<ClientArguments>(client_arguments)...);
                                        ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:130:12: note: in instantiation of function template specialization 'launch_server_process<ImageDecoderClient::Client>' requested here
    return launch_server_process<ImageDecoderClient::Client>("ImageDecoder"sv, candidate_image_decoder_paths, arguments);
           ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 1 argument, but 2 were provided
struct Process::ProcessAndClient {
                ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 0 arguments, but 2 were provided
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:79:12: error: no viable constructor or deduction guide for deduction of template arguments of 'ProcessAndClient'
    return ProcessAndClient { Process { type, client, move(core_process) }, client };
           ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:45:41: note: in instantiation of function template specialization 'WebView::Process::spawn<Web::HTML::WebWorkerClient>' requested here
        auto result = WebView::Process::spawn<ClientType>(process_type, move(options), forward<ClientArguments>(client_arguments)...);
                                        ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:141:12: note: in instantiation of function template specialization 'launch_server_process<Web::HTML::WebWorkerClient>' requested here
    return launch_server_process<Web::HTML::WebWorkerClient>("WebWorker"sv, candidate_web_worker_paths, move(arguments));
           ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 1 argument, but 2 were provided
struct Process::ProcessAndClient {
                ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 0 arguments, but 2 were provided
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:79:12: error: no viable constructor or deduction guide for deduction of template arguments of 'ProcessAndClient'
    return ProcessAndClient { Process { type, client, move(core_process) }, client };
           ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:45:41: note: in instantiation of function template specialization 'WebView::Process::spawn<Requests::RequestClient>' requested here
        auto result = WebView::Process::spawn<ClientType>(process_type, move(options), forward<ClientArguments>(client_arguments)...);
                                        ^
/Users/mike/Projects/ladybird/Ladybird/HelperProcess.cpp:161:12: note: in instantiation of function template specialization 'launch_server_process<Requests::RequestClient>' requested here
    return launch_server_process<Requests::RequestClient>("RequestServer"sv, candidate_request_server_paths, move(arguments));
           ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 1 argument, but 2 were provided
struct Process::ProcessAndClient {
                ^
/Users/mike/Projects/ladybird/Userland/Libraries/LibWebView/Process.h:68:17: note: candidate function template not viable: requires 0 arguments, but 2 were provided
4 errors generated.
[12/27] Building CXX object Lagom/Userland/Libraries/LibWebView/CMakeFiles/LibWebView.dir/WebContentClient.cpp.o
ninja: build stopped: subcommand failed.


Rename directory

As a user of VZCode, I want to be able to rename a directory.
Implementation detail: all the children of the renamed directory will need to be updated.
Related to

#105
#150
#173

Start in src/client/Sidebar/DirectoryListing.tsx line 42

Similar to work done in https://github.com/vizhub-core/vzcode/pull/216

Closed in https://github.com/vizhub-core/vzcode/pull/567


cartographer offline mode with single threaded run

Hello,
I am running a cartographer with offline mode ( cartographer online and offline mode )
so, basically I give a bag file and other configuration file as an input of cartographer offline mode.
operation itself seems not to have any problem but the problem is that
It is using only a single thread like picture below ( Only a CPU4 is maximally running, and the other is not operating intensively like CPU4 )
Is there any suggestion that I can fully utilize the other CPUs?

@Howonjung do you find any solution for this?

@AchmadFathoni  I just downloaded the latest cartographer version and built. and it worked!


Add helper to register IHttpContextAccessor

Added helper extension method to register IHttpContextAccessor with correct lifetime. Added tests as well.
Resolves #946

/cc @davidfowl

Nice @henkmollema !


This api no longer works 😭

Unfortunately the api no longer works due to abuse of market via bots.
The devs blocked unauthorized access to the websockets.
I heard they will create new api for developers soon 🙂, but I don't know any information about it.
If you know any information, updates about this, we can discuss about it in this thread.

Is there any news about new API?

No idea, I haven't played the game for a long time..


Yes

Checklist

[ ] I ran npm test locally and it passed without errors.

[ ] I only edited the _data/pixels.json file.

[ ] I entered the username in the pixels.json that I'm also using to create this pull request.
[ ] I acknowledge that all my contributions will be made under the project's license.

Hey @WhiteSpike I moved your pixel to 44, 1 because the coordinates you tried to grab were already taken. Feel free to open another PR if you'd like another position instead. Thank you for contributing!


new slack alert route in alertmanager laa-fala

What:
This relates to ticket:
https://waffle.io/ministryofjustice/cloud-platform/cards/5c7cf79250a7240211d7b89f

As per @alkar suggestion - in ticket https://waffle.io/ministryofjustice/cloud-platform/cards/5c7e4abffa9ad9029d060a9f will try to add some yaml anchoring to reduce repetition.

Sorry - somehow got into some kind of conflict with master

Also my comment re anchor points -will leave for time being as part of much bigger change (own ticket) at some point in future (as per discussion with Mitch)


Upgrade realm-core to v13.15.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.958%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3158

Relevant Lines:
3550

💛  - Coveralls


Fix "Oakland" not showing up in breadcrumbs properly

This is related, breadcrumbs are using the last scope in the state chain to render the label, so controllerAs syntax doesn't work. Also, because we are using directives with isolated scope, when a state sets the breadcrumb parameters, these parameters don't get inherited to child scopes.
https://github.com/ncuillery/angular-breadcrumb/issues/102

After digging into this a bit more, I've come up with a hacky fix. I think the real solution is to replace angular-breadcrumb with something else. I don't think it means our use case because it depends on state getting inherited through the scopes. We've explicitly avoided scope inheritance by using controllerAs syntax and directives with isolate scope.


Vite refresh sometimes happens before octane --watch's refresh

Vite Plugin Version
0.8.0
Laravel Version
10.21.0
Node Version
18.17.1
NPM Version
9.6.7
Operating System
Windows (WSL)
OS Version
11
Web browser and version
116.0.5845.141
Running in Sail?
No
Description
I'm running Octane / Swoole with octane:start --watch and Chokidar.
Both the Vite dev server and Octane correctly handle file changes. The problem is that it's always toss up as to which one will execute first. Which means that sometimes Vite refreshes before Octane and the latest changes aren't seen. I'm needing to save files twice to work around this.
It'd be good if we could add an optional delay to Vite to ensure Octane has a chance to reload its workers first.
Steps To Reproduce

Create an Octane app and a Blade view that uses Vite
Install Chokidar and run octane:start --watch
Run npm run dev
Make changes to the Blade file and save. Check if the browser reflects those changes. Rinse and repeat. Eventually you'll be served stale content (i.e. content from before the Octane workers have restarted)

Hey @binaryfire,
The Laravel Vite plugin already supports this for refreshing on Blade changes. The docs are at https://laravel.com/docs/10.x/vite#blade-refreshing-on-save. Note that this doesn't apply to Vite's hot module replacement, but it sounds like you're specifically looking to delay the Blade refresh.


[identity] Release beta for AzurePipelinesCredential

Packages impacted by this PR
@azure/identity
Describe the problem that is addressed by this PR

Mark the api for OIDC token to be preview for the preview release

Checklists

[x] Added impacted package name to the issue description
[x] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.


5.1.4 tikv restart in many testcases after start cpu profiling

Bug Report

What version of TiKV are you using?

[2022/02/11 22:07:30.025 +00:00] [INFO] [lib.rs:86] ["Release Version:   5.1.3"]
[2022/02/11 22:07:30.025 +00:00] [INFO] [lib.rs:86] ["Edition:           Community"]
[2022/02/11 22:07:30.025 +00:00] [INFO] [lib.rs:86] ["Git Commit Hash:   937df38124b977518eb2b932d7ced8be5d4eb163"]
[2022/02/11 22:07:30.025 +00:00] [INFO] [lib.rs:86] ["Git Commit Branch: heads/refs/tags/v5.1.4"]
[2022/02/11 22:07:30.025 +00:00] [INFO] [lib.rs:86] ["UTC Build Time:    Unknown (env var does not exist when building)"]
[2022/02/11 22:07:30.025 +00:00] [INFO] [lib.rs:86] ["Rust Version:      rustc 1.53.0-nightly (16bf626a3 2021-04-14)"]
[2022/02/11 22:07:30.025 +00:00] [INFO] [lib.rs:86] ["Enable Features:   jemalloc mem-profiling portable sse protobuf-codec test-engines-rocksdb cloud-aws cloud-gcp"]
[2022/02/11 22:07:30.025 +00:00] [INFO] [lib.rs:86] ["Profile:           dist_release"]
What operating system and CPU are you using?

Steps to reproduce

test plan : 603473
testbed: endless-oltp-tps-603473-1-940
testcase: [oltp_rel_008_001] , down one tidb during running sysbench read only workload.
What did you expect?
No tikv restart.
What did happened?
Tikv restart.
Logs before restart:
[2022/02/11 21:57:28.872 +00:00] [INFO] [mod.rs:389] ["write report successfully"]
[2022/02/11 22:00:35.945 +00:00] [INFO] [util.rs:544] ["connecting to PD endpoint"] [endpoints=http://tc-pd-2.tc-pd-peer.endless-oltp-tps-603511-1-612.svc:2379]
[2022/02/11 22:00:35.947 +00:00] [INFO] [] ["New connected subchannel at 0x7f06344b1fb0 for subchannel 0x7f04757b8700"]
[2022/02/11 22:07:17.775 +00:00] [INFO] [profiler.rs:296] ["starting cpu profiler"]
[2022/02/11 22:07:17.775 +00:00] [INFO] [mod.rs:326] ["start profiling 10 seconds with frequency 99 /s"]
[2022/02/11 22:07:30.025 +00:00] [INFO] [lib.rs:81] ["Welcome to TiKV"]
[2022/02/11 22:07:30.025 +00:00] [INFO] [lib.rs:86] ["Release Version:   5.1.3"]
[2022/02/11 22:07:30.025 +00:00] [INFO] [lib.rs:86] ["Edition:           Community"]
[2022/02/11 22:07:30.025 +00:00] [INFO] [lib.rs:86] ["Git Commit Hash:   937df38124b977518eb2b932d7ced8be5d4eb163"]
[2022/02/11 22:07:30.025 +00:00] [INFO] [lib.rs:86] ["Git Commit Branch: heads/refs/tags/v5.1.4"]
[2022/02/11 22:07:30.025 +00:00] [INFO] [lib.rs:86] ["UTC Build Time:    Unknown (env var does not exist when building)"]
[2022/02/11 22:07:30.025 +00:00] [INFO] [lib.rs:86] ["Rust Version:      rustc 1.53.0-nightly (16bf626a3 2021-04-14)"]
[2022/02/11 22:07:30.025 +00:00] [INFO] [lib.rs:86] ["Enable Features:   jemalloc mem-profiling portable sse protobuf-codec test-engines-rocksdb cloud-aws cloud-gcp"]
[2022/02/11 22:07:30.025 +00:00] [INFO] [lib.rs:86] ["Profile:           dist_release"]

/type bug
/severity critical

/assign sticnarf

@mayjiang0203 Can you provide the coredump of the crashed TiKV? From the log I cannot confirm the source of the crash.

/found automation

/found automation

/found automation

Core dump can be get from minio by testbed test-infra-testground / archive / endless-oltp-tps-604008-1-64 /tc-tikv-0

I can read the core dump now. It sigfaults in the _Unwind_Backtrace of libgcc_s.so.
This is probably a result of combining https://github.com/tikv/tikv/issues/10906 and not robust unwind implementation from libgcc.
There is little we can do to relieve the bug in the v5.1.x. But I hope you can test the master TiKV to see if the issue still exists (master has upgraded the rust toolchain to fix the incorrect debug info bug). @mayjiang0203

@mayjiang0203 @sticnarf
What do you think we change the severity to major instead of critical.

@cfzjywxk @mayjiang0203 I think this should not be critical.

Can be closed because https://github.com/tikv/tikv/pull/12480 has been merged.


babel/traverse, popper installation issues

git clone .. followed by npm install gives this error:
npm ERR! 404 Not Found - GET<EMAIL_ADDRESS>- Not found
npm ERR! 404
npm ERR! 404  '@babel/traverse<EMAIL_ADDRESS>is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)

Also, a big plus of bootstrap 5 is using popper 2, but it seems that it's trying to install popper 1.
bootstrap 5 beta 2 is out, and they've indicated it's pretty close to final.  Can you bump all the dependencies please?

Hey Tacman, you can expect an update soon. What node + npm version are you using? So far we weren't able to re-create your issue locally. Thanks.

node -v && npm -v
v14.15.1
7.5.3

However, it seems to be working now, I must have upgraded something since then, or there was a temporary glitch on that particular package.


Like button doesn't work

Almost always when i click like button on someone else's profile, it doesn't set as liked

Hello there and thanks for your report! It is a duplicate of this issue https://github.com/howlrapp/howlr-app/issues/3 and it should hopefully be fixed in the next release. I say "hopefully" because we really have a hard time reproducing this issue, however we found an obvious mistake that could lead to that kind of behaviour, and fixed it.


Pr/show suv maxmin rect ellip roi tool

Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Shows max and min for rectangle and elliptical roi tools. Max and Min values are passed to calculateSuv when meanStdDevSuv is created.

What is the current behavior? (You can also link to an open issue here)
Max and min SUV are not shown nor stored within meanStdDevSuv.

What is the new behavior (if this is a feature change)?
Max and min SUV are now stored and shown for rectangle and elliptical roi tools.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No changes should be required by users.

Other information:

@dxlin Hi! Have you had any success with the changes in this PR? Looks like a very important addition!


feature: #1765 reduce transferred torrent data

Can you add a clamp to the 100 first torrents for this ? It would take care of the issue that other person had when there are like 1000+ torrents

Can you add a clamp to the 100 first torrents inside of this PR too ? I think the scope is similar and It would take care of the issue that other person had when there are like 1000+ torrents

I think that won't be necessary if we use https://www.mantine-react-table.com/docs/examples/virtualized

Can you add a clamp to the 100 first torrents inside of this PR too ? I think the scope is similar and It would take care of the issue that other person had when there are like 1000+ torrents

Will add virtualized scrolling in a follow up PR (this PR aims to reduce network usage, not client rendering performance).


Unable to access memos site after upgrading to 0.12.2

Describe the bug
Deployed environment: docker image
Self-hosted memos site work normally on 0.12.1 version
However, after upgrading to 0.12.2 with newer docker image.
Unable to access the memos website.
The page showed the error messages: (hide my site name with example)
RelativeTimeFormat@[native code]
LEe@https://memos.example.net/assets/index-9ec6bc6e.js:310:279645
Mr@https://memos.example.net/assets/Memo-fa8710c9.js:9:8336
zM@https://memos.example.net/assets/index-9ec6bc6e.js:83:19539
jk@https://memos.example.net/assets/index-9ec6bc6e.js:85:3141
C7@https://memos.example.net/assets/index-9ec6bc6e.js:85:39789
SK@https://memos.example.net/assets/index-9ec6bc6e.js:85:39717
bT@https://memos.example.net/assets/index-9ec6bc6e.js:85:39570
iA@https://memos.example.net/assets/index-9ec6bc6e.js:85:35935
v7@https://memos.example.net/assets/index-9ec6bc6e.js:85:34884
v7@[native code]
T@https://memos.example.net/assets/index-9ec6bc6e.js:70:1555
H@https://memos.example.net/assets/index-9ec6bc6e.js:70:1917
After rolling back to older image 0.12.1, all error disappeared. .
Steps to reproduce

Upgrade to new docker image 0.12.2
Enter the site on browser.
The page showed the error message pasted in the description.

Screenshots or additional context
No response

I got same issue , my error message as below.
Unexpected Application Error!
invalid language tag: "hant"

LEe@https://memo.example.com/assets/index-9ec6bc6e.js:310:279618
Mr@https://memo.example.com/assets/Memo-fa8710c9.js:9:8334
zM@https://memo.example.com/assets/index-9ec6bc6e.js:83:19538
jk@https://memo.example.com/assets/index-9ec6bc6e.js:85:3139
s7@https://memo.example.com/assets/index-9ec6bc6e.js:85:2351
Uw@https://memo.example.com/assets/index-9ec6bc6e.js:85:1893
I7@https://memo.example.com/assets/index-9ec6bc6e.js:85:47348
C7@https://memo.example.com/assets/index-9ec6bc6e.js:85:39789
SK@https://memo.example.com/assets/index-9ec6bc6e.js:85:39717
bT@https://memo.example.com/assets/index-9ec6bc6e.js:85:39568
iA@https://memo.example.com/assets/index-9ec6bc6e.js:85:35933
Kw@https://memo.example.com/assets/index-9ec6bc6e.js:85:36737
Wa@https://memo.example.com/assets/index-9ec6bc6e.js:83:3279
Mn/<@https://memo.example.com/assets/index-9ec6bc6e.js:85:34263

After reading the reply from @den13501 , I suspect the issue is generated related with languages configuration.
Hence I switched back to English on 0.12.1, then upgrade to 0.12.2 with newer image.
No error showed this time and the site is loaded normally.
Then I switched back to traditional Chineses, all are OK now.

Thanks for information, this solution is worked.


[containers/Dockerfile.base] FROM fedora:31 -> fedora:32

I'm currently building/testing packit-service[-worker] with it.

@jpopelka
it was already configured in
https://github.com/packit/packit-service/pull/717
but workers were failing so was reverted back in
https://github.com/packit/packit-service/pull/751
so not sure if it will work without additional troubleshooting and fixes

Thanks

@sakalosj tests in https://github.com/packit/packit-service/pull/826 are passing so we're free to give this a try. Will you give me your blessing?

@sakalosj tests in packit/packit-service#826 are passing so we're free to give this a try. Will you give me your blessing?

Yes, my son. :)


Add Unknown Coin

Added Unknown Coin
I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Bump

Token Address: HrurWc98nGZ5nqZcGDUbr8mrmV6QseWGTPdTN5mwYPUH
Token Name: Unknown Coin
Token Symbol: UNK
Logo: "https://raw.githubusercontent.com/solana-labs/token-list/main/assets/mainnet/HrurWc98nGZ5nqZcGDUbr8mrmV6QseWGTPdTN5mwYPUH/logo.png",
Link to the official homepage of token: officialnameunknown.com/nfts
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):


[Bug] Can't submit in leetcode.com

leetgo debug
Leetgo version info  :
1.4.5
commit: 19a7eb1ba0bc2a376043a1afb5ad4660b046dafe
built at: 2024-04-04T02:09:03Z
goos: windows
goarch: amd64

Home dir             : C:\Users\admin.config\leetgo
Project root         : C:\Users\admin\leetcode
Working dir          : C:\Users\admin\leetcode\rust
Project config file  : C:\Users\admin\leetcode\leetgo.yaml
Project configuration:
author: Jones
language: en
code:
  lang: rust
  python3:
    blocks:
    - name: beforeMarker
      template: |

        from bisect import bisect_left, bisect_right
        from collections import Counter, defaultdict, deque
        from copy import deepcopy
        from functools import cache, cmp_to_key, lru_cache, reduce
        from heapq import heapify, heappop, heappush, heappushpop, heapreplace
        from itertools import accumulate, chain, count, pairwise, zip_longest
        from math import ceil, comb, floor, gcd, inf, isqrt, log2, perm, sqrt
        from operator import xor
        from pprint import pprint
        from string import ascii_lowercase
        from typing import List, Optional
  rust:
  blocks:
    - name: beforeCode
      template: |
        use std::cmp::Reverse;
        use std::collections::*;
        use std::mem::swap;
leetcode:
  site: https://leetcode.cn
  credentials:
    from: cookies
contest:
  open_in_browser: false
editor:
  use: custom
  command: "code"
  args: "{{.CodeFile}} {{.DescriptionFile}}"

Full configuration   :
author: Jones
language: en
code:
  lang: rust
  filename_template: '{{ .Id | padWithZero 4 }}{{ if .SlugIsMeaningful }}.{{ .Slug }}{{ end }}'
  separate_description_file: true
  blocks:
    - name: beforeCode
      template: |
        use std::cmp::Reverse;
        use std::collections::*;
        use std::mem::swap;
  modifiers:
    - name: removeUselessComments
  go:
    out_dir: go
    modifiers:
      - name: removeUselessComments
      - name: changeReceiverName
      - name: addNamedReturn
      - name: addMod
  python3:
    out_dir: python
    blocks:
      - name: beforeMarker
        template: |2
          from bisect import bisect_left, bisect_right
          from collections import Counter, defaultdict, deque
          from copy import deepcopy
          from functools import cache, cmp_to_key, lru_cache, reduce
          from heapq import heapify, heappop, heappush, heappushpop, heapreplace
          from itertools import accumulate, chain, count, pairwise, zip_longest
          from math import ceil, comb, floor, gcd, inf, isqrt, log2, perm, sqrt
          from operator import xor
          from pprint import pprint
          from string import ascii_lowercase
          from typing import List, Optional
    executable: python.exe
  cpp:
    out_dir: cpp
    cxx: g++
    cxxflags: -O2 -std=c++17
  rust:
    out_dir: rust
  java:
    out_dir: java
leetcode:
  site: https://leetcode.cn
  credentials:
    from: cookies
    browsers: []
contest:
  out_dir: contest
  filename_template: '{{ .ContestShortSlug }}/{{ .Id }}{{ if .SlugIsMeaningful }}.{{ .Slug }}{{ end }}'
  open_in_browser: false
editor:
  use: custom
  command: code
  args: '{{.CodeFile}} {{.DescriptionFile}}'

Debug log
No response
Description
lc test last -Ls --site us
● running test locally question=make-the-string-great
● building file=src/1544.make-the-string-great/solution.rs
● Case 1:    Passed
● Case 2:    Passed
● Case 3:    Passed
● submitting solution<EMAIL_ADDRESS>⣻ Submitting solution...● retry url=https://leetcode.com/problems/make-the-string-great/submit/ attempt=0 error="[403 Forbidden] <empty>"
⣾ Submitting solution...● retry url=https://leetcode.com/problems/make-the-string-great/submit/ attempt=1 error="[403 Forbidden] <empty>"
⣾ Submitting solution...● retry url=https://leetcode.com/problems/make-the-string-great/submit/ attempt=2 error="[403 Forbidden] <empty>"
× failed to submit solution err="failed to submit solution: [403 Forbidden] <empty>"

Something strange here, ● submitting solution<EMAIL_ADDRESS>seems like it doesn't recognize my username
I tried changing my cookies but the problem persists.

Since you're using cookies, have you configured all three env vars – LEETCODE_SESSION, LEETCODE_CSRFTOKEN, and LEETCODE_CFCLEARANCE – to access leetcode.com ?

Yes of course.
I created a function like this in pwsh to differentiate between us and cn.
function us{
    $env:LEETCODE_SESSION="eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJfYXV0aF91c2VyX2lkIjoiNDMzOTYzOSIsIl9hdXRoX3VzZXJfYmFja2VuZCI6ImFsbGF1dGguYWNjb3VudC5hdXRoX2JhY2tlbmRzLkF1dGhlbnRpY2F0aW9uQmFja2VuZCIsIl9hdXRoX3VzZXJfaGFzaCI6ImY4MjBmNmM..."
    $env:LEETCODE_CSRFTOKEN="w31CEXc7nkdUDuSPdHLnhdKoYV7Rgia..."
    $env:LEETCODE_CFCLEARANCE="ntOKjS2Rz9PsrvzQoDujserauLAU3MYGlyqhjpcDyjc-1712317600-<IP_ADDRESS>..."
}

I tried logging back in (of cource .com) and replacing the three envs with new ones but still can't submit.
If you can't reproduce the issue, maybe there's something wrong with my browser. I will test it a few times and give feedback.

Sorry, I can't reproduce on my side, either by setting cookies env var or by fetching cookies from browser automatically. Could you try using feching cookies from browsers automatically?


Create Schema Kit

Got it. My spidey sense tells me that this is probably a different kind of node. Maybe a util node that takes a JSON object and produces a schema for it? Let's not add this bit to the fetch node.

@dglazkov in https://github.com/breadboard-ai/breadboard/pull/1253#discussion_r1542111797

Or maybe add another node to the JSON kit?

I considered it, though it can be used with any value, not exclusively JSON. And I can forsee wanting to add more schema manipulation nodes.
This somewhat comes back to what I mentioned ages ago about being able to declare and include standalone nodes.
I also have a feeling this relates to the node logic signature definition ponderings.

It's JSON Schema, so it makes sense to put it in JSON kit.


What should return to go be during inferencing?

I understand, during training, at each time step, the transformer is fed the "return to go"
During inference, how would we compute the return to go which would need to be computed before each action?
Do we do "desired reward"/episode_length?

From my understanding, after setting an initial target reward for the entire episode, for each reward we get after performing a step, we do
new_target_reward = target_reward - received_reward_from_env
Is this correct?

In general there isn't a single way to pick RTG and it depends on the environment. You would probably sweep this value for experiments.
After every step you subtract the received reward, correct.

Multi-Game Decision Transformers (https://arxiv.org/abs/2205.15241) looks into learning the RTG like a value function, removing the need to specify it manually.


Feature Request: sync status indication or loading bar

I have a suggestion for a feature:
Some way of notifying the user of the current sync status (like % complete) so the user knows when all of the files are finished syncing.
I have > 20 GB on my google drive, and it includes data and figures that are large files. When I am working on my linux machine it would be nice to know when all my changes on my other machines are available
Thank you for your time! I really enjoy google-drive-ocamlfuse! It really helps me out :)

yeah, a status of the current files being uploaded/download would be enough I think


Error when attempting to read results.json file for .NET project

Hi, I'm utilizing the pipeline scan .jar from pipeline-scan-LATEST.zip to run a pipeline scan of a .NET project. I can see the uploaded artifact after the scan has been run that's named "results.json", and opening the file reveals some issues that were found. This step is working fine, but when I try to use this action with the generated results.json file I get the following error:
Cannot read property 'TestResults' of undefined
Surprisingly, the log statement immediately preceding the error above is:
Pipeline Scan results file found and parsed - validated JSON file
"TestResults" predictably does not appear in my results.json file, but glancing through the source code for this action I can't find any mention of "TestResults" either. My best guess is that this is coming from Converter.ts line 159, but I'm not super familiar with TypeScript/JavaScript so it's all greek to me. Any ideas?
For reference, here is the raw results.json output:
https://pastebin.com/ixQaJeHe

I had to use master instead of a tag to get the action to work

I unfortunately don't have access to the original results json file anymore. I managed to resolve this issue somehow but it's been so long I can't remember what I did... Safe to say it's probably something I was doing wrong unless anyone else has seen this exact sequence of logs before.


bevy_render: delegate buffer aligning to RenderResourceContext

WebGL2 has different uniform / texture aligning requirements than wgpu. This PR moves uniform / texture aligning code to RenderResourceContext. Current aligning behaviour for wgpu should be preserved.

Looks good to me!


libraduls source?

Where does the raduls library come from? I didn't see it mentioned in the README or elsewhere in the repo so I was hoping you could point me where I can get the source for it.

RADULS is our radix-sorter (https://github.com/refresh-bio/RADULS ). Nevertheless, in AGC we use its non-public variant (in-place radix sort). We plan to publish this variant in some time. Nevertheless, we have to work on it a bit.

V.3.1, which should be ready in 1-2 weeks, will support M1/M2 CPUs as well as other ARM-based machines.


Suggestion: Dealing with ServiceProvider instance type with .boxed()

Hey! I've been experimenting with teloc for a while now as I'm surveing crates enabling Hexagonal Architecture in Rust.
In the context of leveraging IoC pattern that teloc implements, I faced the inefficiency of having to modify over and over the type alias for ServiceProvider instance.
This is an issue affecting every crate exploiting Rust generics support, but I came across an interesting pattern that the axum fellows implemented to deal with it.
In axum, HTTP routes are implemented composing generic type, leading to big types that only the compiler will eventually know. To make building routes developer-friendly, they provide a .boxed() method returning a BoxRoute that erases the big generic type.
References are available here:

Router
boxed() method

Do you think this might be implementable in teloc as well? It would make declaring containers much more ergonomic, imho.
Anyhow, keep up the good work! 💪

Thanks for the issue!
I know this way with using type aliases is inefficient, but there are two tradeoffs:

Type-level computations, so rustc won't compile when you request for a non-existent dependency. In this case we need to store all the types we have in the ServiceProvider instance, because otherwise rustc cannot satisfy which types are stored in the ServiceProvider.
Runtime resolves. In this case we can write something like BoxedServiceProvider, but rustc cannot help us at compile time.

As you can see, teloc uses first approach, so if it is changed to the second, it will be a completely different library. The only way to get out of both tradeoffs is with global type inference. With global type inference, it will be possible to write ServiceProvider type alias like type Provider = ServiceProvider<_>;, but it will never be in the Rust.
In axum case boxing is possible due to Router need only one method call, while ServiceProvider need many methods: resolve::<Type1>(), resolve::<Type2>(), etc.
But, we can combine both approaches. But, user must writing something by yourself yet:
trait MyProvider: Resolver<Dep1> + Resolver<Dep2> + /* list all dependencies you need in the app */ { }
impl<P> MyProvider for P where P: Resolver<Dep1> + Resolver<Dep2> + /* ... */ { }
type MyProvider = Box<dyn MyProvider>;

Then you can call all .resolve() method for the types you listed in the trait MyProvider. Pros: human readability, compiler checks. Cons: you have to change MyProvider signature every time when you add/remove dependency that used from the top-level.
There are possible simplification by adding a macro:
define_resolver![MyProvider => Dep1, Dep2, Dep3];
fn create() -> MyProvider { ... }
fn use(provider: MyProvider) { ... }

I think this is the most efficient way, and I can't think of something better. What do you think about it, @leonardoarcari?

Now that's super interesting! Thanks for the great explanation and the extremely reasonable workaround. Such a solution is very close to another crate I was evaluating (shaku), which unfortunately does not support dyn dependencies implemented by the same concrete struct.
This is my first language with such a strong macro system and I'm always amazed by how powerful it can be!
Thanks! 🙂


Issues in Upgrade scenario

Steps:
setup CE using master branch (1.9 release in master branch)
do basic acceptance
git checkout develop
git pull --recurse-submodules
Actual result:
Fetching submodule jenkins
Fetching submodule mcloud
Fetching submodule reporting
Fetching submodule reporting/minio-storage
Fetching submodule selenoid
Fetching submodule sonarqube
Already up to date.
Submodule path 'jenkins': checked out 'acf8517ef3b2662512e68ebcdf0ec4b25b19df9d'
**error: unable to create file configuration/stf-proxy/ssl/.gitkeep: Permission denied
error: unable to create file configuration/stf-proxy/ssl/ssl.crt.original: Permission denied
error: unable to create file configuration/stf-proxy/ssl/ssl.key.original: Permission denied**
Submodule path 'mcloud': checked out '6063a89d5f0874d50cb7e0f684c9301dd9291704'
Submodule path 'reporting': checked out '08d9aa0b878e645435ece4b4c594d89c6755e240'
Submodule path 'selenoid': checked out '70047cfb5e2dc9cd284468c2fc10c9dbeac4b453'
Submodule path 'sonarqube': checked out '24d9e874c9c5721f048e62ad45dfcdc86510a4e1'

Expected: no error messages during git pull

closing as can't reproduce. potentially it might be due to the ssl configuration on v1.9 but better to retest again.


Storyboard integration doesn't work with Share Extensions

Hello,
I've tried to use Typhoon storyboard integration with the Share Extension that I'm working on at the moment and as extension doesn't have AppDelegate it doesn't seem to work properly. Probably that will be the case with all extensions supported by new iOS as they are not normal apps and have different lifecycle.
Manual injection as described on this page: https://github.com/appsquickly/Typhoon/wiki/Activating-Assemblies#instructing-typhoon-to-inject-a-pre-obtained-instance works as expected, but adds a bit of noise to the view controllers (works well as a workaround).
To give a bit more context what was already discussed here is the link to twitter: https://twitter.com/cakper/status/599245416442507264
And sample project created to demonstrate the problem: https://github.com/cakper/TestExtensionApp
https://github.com/cakper/TestExtensionApp/blob/master/Podfile.lock contains versions of the Typhoon and Cocoapods used
Thank you, Kacper :)

Sorry, haven't tried iOS extensions yet..
How UIStoryboard instance is created in the extension? Manually, with ``[UIStoryboard storyboardWithName:bundle:]```? Or it's created by iOS automatically?
if automatically, how iOS know storyboard name? Using value for special key in Info.plist?

Hello Alex,
Storyboard instance is created by extension automatically. It is using NSExtension -> NSExtensionMainStoryboard entry from extension Info.plist file.

Ok, I'll add support for that soon then
Отправлено с iPhone

18 мая 2015 г., в 20:32, Kacper Gunia<EMAIL_ADDRESS>написал(а):
Hello Alex,
Storyboard instance is created by extension automatically. It is using NSExtension -> NSExtensionMainStoryboard entry from extension Info.plist file.
—
Reply to this email directly or view it on GitHub.

Nice, Thanks ;)

Hey, @cakper. Can you test latest code with :head version of Typhoon?

Hello, @alexgarbarev - sure - I'll have a look in a sec

Hi @alexgarbarev
So we had a look at it and it doesn't work as expected. After going though Typhoon code what we found is that in swizzleSetDelegateMethodOnApplicationClass is replaced with your implementation that calls [self loadInitialFactory]; which is fine, but the problem is that setDelegate is never called (because app is not instantiated) and in result the initial factory is never loaded.
Trying to think about right place to inject with factory initialisation for extension - what do you think about swizzling storyboardWithName in UIStoryboard and calling load there?

Hi @cakper
Injection for storyboard doesn't work?
Now, about the code. I appreciate your attention to code and good suggestions.
There is two files you would like to check.
TyphoonStartup.m
There is loading initial factory and trying to inject into AppDelegate if possible.
Loading initial factory done on +(void)load method, using TyphoonInitialAssemblies key in Info.plist (or using [AppDelegate initialFactory] - not this case)
Initial factory loaded at very start of application startup and released after application did finish launching ( at UIApplicationDidFinishLaunchingNotification notification on iOS)
TyphoonInitialStoryboardResolver.m
This class is designed to provide storyboard integration at application startup. As you suggested, it uses swizzling of storyboardWithName method. Inside this method, I'm checking for initial factory which must be provided by TyphoonStartup class - if initial factory exists TyphoonStoryboard will be created instead of UIStoryboard (as class cluster).

Now, back to the problem.
I guess next reasons:

Initial factory was not created (missing TyphoonInitialAssemblies in the plist)
Initial factory was created, but released before UIStoryboard creation

If you have spare time, you can try to debug using information from above and make pull request with fix, I haven't so much time to play with iOS extensions now. (Will fix later)

Hello

There is loading initial factory and trying to inject into AppDelegate if possible.
I think problem here is that swizzleSetDelegateMethodOnApplicationClass doesn't work at all because there is no AppDelegate in the Share extension.

I did try to run loadInitialFactory later manually and then it works fine (so it loads Assemblies from the plist file without any problems and is injecting everything fine. So the I still think our ultimate problem here is that there is not AppDelegate for the extension target. Did you try to play with the sample project I've provided?

@cakper We'll get to this ASAP. Meanwhile if you want to tackle this yourself, it sounds like simply a matter of:

Find the correct hook point
Copy the same approach that TyphoonStartup uses for AppDelegate

We'll happily accept a pull request for this.

I'll fix that issue. I hope I'll have time at today's evening

@cakper You was totally right. The reason was: TyphoonStartup loads initialFactory only when Application Delegate class exists.
Now fixed and released as 3.1.8. Thanks for catching that!


coding mistake?

i get this error when i do (python spg.py)
Traceback (most recent call last):
File "spg.py", line 32, in
import os, platform, wget
ImportError: No module named wget
i dunno how to fix this and i cant download wget

Use python -m pip install wget and then execute the script


CADEOS.io ADE令牌合同已更改为   “ cadeositoken”。

项目背景：
CADEOS.io-去中心化的CAD.FILES和项目管理平台
官方公告：
https://twitter.com/CadeosI/status/1068175488659714048
项目团队背景：
https://www.linkedin.com/in/guillermo-galindo-saeta-749a2557
https://www.linkedin.com/in/jesús-moya-galindo-bb24861a
https://www.linkedin.com/in/javier-saeta-hidalgo
项目基本信息：
如今，对企业家和创造者的最大限制之一是昂贵的软件许可，并且借助CADEOS.io，我们希望通过消除分散式软件的问题来为每个人提供便利。在直观和用户友好的环境中，我们将使创建过程和产品发布变得负担得起且非常容易。
通过标记各种项目，我们的用户可以看到他们的想法和努力已成功实施。我们的平台将为那些因市场壁垒而停滞不前的聪明人带来机会。
从最初的草图到制造过程，用户都可以在我们的产品生命周期管理器（PLM）平台中监视设计状态。工厂，供应商和所有相关的第三方都将能够在我们的平台上查看您的报价请求（RFQ），并发送每个组件的制造价格。
借助CADEOS.io，您可以使用我们的分散式CAD软件来设计任何机械和电子组件，并在成千上万寻求最佳创意的投资者的注视下在我们的社区中进行推广。
CADEOS.io平台将托管来自数千个不同品牌的大型组件库，并将负责提供尽可能广泛的资源，以简化产品的组成。
通过创建您的供应商组合，您将获得最佳建议，并与全球任何行业的最佳专业人员直接交流。每个区域都有自己的交流渠道和聊天室。
通过在动态用户配置文件中进行的每次创建，您将为所有产品，3D模型，3D打印机零件，电子方案等增加价值，从而有利于投标和销售，这将在CADEOS.io平台上取得成功。您的工作将永远不会丢失或遗忘，并且会不时地使用我们的代币ADE重新估价。
媒体出版物：
https://koreos.io/News/412220
https://medium.com/cadeos-io
https://www.stateofthedapps.com/dapps/cadeos
https://t.me/cadeos
https://marketcap.one/es/m/ADE
可交易的交易所：
https://token.store/eos/trade/cadeositoken-ade-eos
https://newdex.io/trade/cadeositoken-ade-eos
https://findex.pro/trade/cadeositoken_ADE-eosio.token_EOS
https://eosdaq.com/exchange/ADE_EOS
https://mydex.win/
Project background:
CADEOS.io - DECENTRALIZED CAD.FILES & PROJECT MANAGEMENT PLATFORM
Official announcement:
https://twitter.com/CadeosI/status/1068175488659714048
Project team background:
https://www.linkedin.com/in/guillermo-galindo-saeta-749a2557
https://www.linkedin.com/in/jesús-moya-galindo-bb24861a
https://www.linkedin.com/in/javier-saeta-hidalgo
Project basic information:
Today one of the biggest constrains for entrepreneurs and creators are the expensive software licenses and, with CADEOS.io, we want to facilitate this process to everyone by getting rid of the problem with our decentralised software. We will make the creation process and product launch affordable and very easy within an intuitive and user friendly environment.
By tokenising all kind of projects our users can see their ideas and effort successfully implemented. Our platform would will bring an opportunity to those brilliant minds that are stopped by the market barriers.
From the first sketch to the manufacture process, the users can monitor the state of your design in our Product Lifecycle Manager (PLM) platform. Factories, suppliers and all the 3rd parties interested will be able to review your Request for Quotation (RFQ) in our platform and send the manufacture price for each component.
With CADEOS.io you can design any mechanical and electronic component with our decentralised CAD software and promote it in our Community, under the watchful eye of thousands of investors looking for the best idea.
CADEOS.io platform will host a large gallery of components from thousands of different brands and will be responsible of providing the most extensive resources as possible for an easy product composition.
By creating your portfolio of suppliers you will have the best advice and direct communication with the best professionals in any industry around the world. Each area will have their own communication channels and chatrooms.
With every creation within your dynamic user profile, you will add value to all your products, 3D models, 3D printer parts, electronic schemes, etc., favouring the bids and sales which will be a success in CADEOS.io Platform. Your work will never be lost or forgotten and will be revaluated from time to time with our token ADE.
Media publications:
https://koreos.io/News/412220
https://medium.com/cadeos-io
https://www.stateofthedapps.com/dapps/cadeos
https://t.me/cadeos
https://marketcap.one/es/m/ADE
Tradeable exchanges:
https://token.store/eos/trade/cadeositoken-ade-eos
https://newdex.io/trade/cadeositoken-ade-eos
https://findex.pro/trade/cadeositoken_ADE-eosio.token_EOS
https://eosdaq.com/exchange/ADE_EOS
https://mydex.win/

https://medium.com/cadeos-io/cadeos-io-call-to-every-exchanges-to-change-ade-token-contract-account-to-cadeositoken-6c048a9e811b

https://medium.com/cadeos-io/cadeos-io-call-to-every-exchanges-to-change-ade-token-contract-account-to-cadeositoken-6c048a9e811b


BVLinearGradient problem on expo web

PROBLEM DESCRIPTION
I have a problem with BVLLinearGradient in my project. After installing all the necessary dependencies, the project works fine on mobile, but on the web the charts are not displayed, and a warning message appears in the console:

`WARNING in ./node_modules/react-native-linear-gradient/common.js:7:15
export 'requireNativeComponent' (imported as 'requireNativeComponent') was not found in 'react-native-web/dist/index' (possible exports: AccessibilityInfo, ActivityIndicator, Alert, Animated, AppRegistry, AppState, Appearance, BackHandler, Button, CheckBox, Clipboard, DeviceEventEmitter, Dimensions, Easing, FlatList, I18nManager, Image, ImageBackground, InteractionManager, Keyboard, KeyboardAvoidingView, LayoutAnimation, Linking, LogBox, Modal, NativeEventEmitter, NativeModules, PanResponder, Picker, PixelRatio, Platform, Pressable, ProgressBar, RefreshControl, SafeAreaView, ScrollView, SectionList, Share, StatusBar, StyleSheet, Switch, Text, TextInput, Touchable, TouchableHighlight, TouchableNativeFeedback, TouchableOpacity, TouchableWithoutFeedback, UIManager, Vibration, View, VirtualizedList, YellowBox, findNodeHandle, processColor, render, unmountComponentAtNode, unstable_createElement, useColorScheme, useLocaleContext, useWindowDimensions)
5 |
6 | /* $FlowFixMe */
7 | export default requireNativeComponent('BVLinearGradient');
|               ^
8 |
9 | export type Point = $ReadOnly<{| x: number, y: number |}>;
10 |
web compiled with 1 warning`

PROJECT CONFIGURATION
My project is very simple, I used the typescript expo template and added what I needed. This problem occurs with or without the template.
Here is my package.json :
{
  "name": "my-app",
  "version": "1.0.0",
  "main": "node_modules/expo/AppEntry.js",
  "scripts": {
    "start": "expo start",
    "android": "expo start --android",
    "ios": "expo start --ios",
    "web": "expo start --web"
  },
  "dependencies": {
    "@expo/webpack-config": "^19.0.0",
    "expo": "~49.0.15",
    "expo-status-bar": "~1.6.0",
    "react": "18.2.0",
    "react-dom": "18.2.0",
    "react-native": "0.72.6",
    "react-native-chart-kit": "^6.12.0",
    "react-native-gifted-charts": "^1.3.12",
    "react-native-linear-gradient": "^2.8.3",
    "react-native-svg": "13.9.0",
    "react-native-web": "~0.19.6"
  },
  "devDependencies": {
    "@babel/core": "^7.20.0",
    "@types/react": "~18.2.14",
    "typescript": "^5.1.3"
  },
  "private": true
}

Here is the main file :
import { StyleSheet, View } from "react-native";
import { BarChart } from "react-native-gifted-charts";

export default function App() {
  const barData = [{ value: 15 }, { value: 30 }, { value: 26 }, { value: 40 }];

  return (
    <View style={styles.container}>
      <BarChart data={barData} />
    </View>
  );
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    backgroundColor: "#fff",
    alignItems: "center",
    justifyContent: "center",
  },
});

I've already looked at the issues on the git but none of the proposed solutions work.
I hope to find a solution, this library is what I'm looking for.

I am also not able to use these charts in expo-web

Apart from Expo-Web, does it work fine on the mobile app (i.e. Android and iOS with ExpoGo)?

I believe the library doesn't support web apps as stated here https://github.com/Abhinandan-Kushwaha/react-native-gifted-charts/blob/master/README.md


Add update on class fields

Target Live Date: asap

[x] This has been reviewed and approved by the team
[x] I have run npm test locally and all tests pass.
[x] I have added the appropriate type-something label.
[x] I've staged the site and manually verified that my content displays correctly.

CC: @petele

Whoops!
There were 1 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/updates/2018/12/class-fields.md#L214 - Consider adding a "was this page helpful?" widget to your page: https://developers.google.com/web/resources/widgets#helpful

:+1:


Move API keys to a backend

Create a backend to proxy API requests between the client and Airtable (recommend putting under ~/server or similar

[ ] Pick a backend. I have experience with node.js/ express to set up a quick proxy server.
[ ] Move the API keys out of /web/.env into the server directory
[ ] Figure out if it's possible to host the server on the same netlify app

Privacy reasons: We want to protect our database and limit access to sensitive columns such as user contact information. Related #13

Would love to get help on this one, but please sync up with @tuttiq and myself first.

I think the MVP for this might be a node function, hosted on Netlify functions feature. Just a wrapper to send requests to Airtable using the API key.
On a more long term solution, I was thinking about migrating from Airtable to a proper backend + database.
I could work on the side to spin up a quick Ruby on Rails server with a basic API and migrate the data from Airtable to MySQL or Postgres. This can be done easily with Rails scaffolding and hosted for free on Heroku.
Let me know any thoughts!

Oooh, might be cool to have it all inside Netlify for simplicity. I was watching some of casidoo's tweets on some fancy features inside Netlify. Heroku is great too. Up to you.


Fixed inhereting color for rubble and above cave walls

Added two options for inhertTileColor.

OVERLAY which this is useful for making rocks/rubbles blend. the other one is
UNDERLAY meant for grass/ferns as it takes the color from green tile color under a path(need this option for grass in front of houses/paths/ or any other overaly).
I also removed inheretingColor for ground tiles without rgb so there isn't a blend if there isn't a ground tile color. Doesn't add tile color blending to objects above cave walls.

Before blending fix, notice the tan rocks turning green

After blending fix,

There aren't many rock ids currently but #30 fixed that. Below are some pics with inheretingColor working with the mapped rocks. Rocks shown below are not textured in this PR.
Smoother look in desert mine

notice how the same rock object above the cave walls are textured and the ground ones are textured/blended

Before

After

Thanks for the PR! I think it is fairly solid. Perhaps it needs a little bit more testing, but I think it's good enough to merge with the copyright notice fixed.

Thanks! Yea I actually went to 2-3 caves and looked at ground so far so good. For a future PR we can fix Above Cave wall blending and the cave faces as they have no color. I think I saw a method in RL api to pull the model color tile.getRenderable().getModel().getFaceColors1(). Anyways I'll save that for later.

This PR would fix a huge number of issues i've run into with textured objects.


Accept function in collection data

Hello, I'm trying to port a code from pure d3 to Number Picture, it's all going great! But I did hit one wall, and that's about dynamic data for the Collection type, in my original d3 source I have this snippet:
p.enter()
  .append("g")
  .attr("transform", (_, i) => "translate(0, " + yScale(i - 1) + ")")
  .selectAll("rect")
  .data(d => d3.range(Math.min(d.size, 120)).map(_ => d))
  // ^^^ Dynamic data generation based on datum `size`, a pictogram
  .enter()
  .append("rect")

This what I'm trying to do with Number Picture:
    <Collection data={queues}>
      <Group y={props => yScale(props.index)}>
        <Collection data={props => d3.range(Math.min(props.datum.size, 120)).map(_ => d)}>
          <Rect x={props => xScale(props.index)} y={0} width={10} height={10} />
        </Collection>
      </Group>
    </Collection>

Since d3 accepts functions on data I think it's a good idea to support here too. Or there is another way to accomplish this that I'm missing?
Thanks.

@wilkerlucio would it be possible to create an example fiddle with some example data so I can have a look at it: https://fiddle.jshell.net/finnworks/fbjs3jkt/

Sure, well, I don't know how to create using Number Picture at this time, this is the farthest I could get: https://fiddle.jshell.net/5mLorn7y/ (trying to use the data as a function, so this example doesn't work but might be a start point if you wanna dive in).
Here is a working example of the same demo, using raw d3: https://codepen.io/wilkerlucio/pen/mMZWyN

You're right I agree thats an important feature. I'll work on having it in the next release

Ok its fixed in v0.4.2 and on npm
https://fiddle.jshell.net/5mLorn7y/3/


Polymorphism

Hi guys,
Please, can you tell me how to make the scope of my queries with the package using polymorphism relationship?
Like how to set the type (tenant class) and the id (tenant id).
Thanks in advance!

Hi everyone,
Same question as @igortrinidad. Is there a way to do this already?

Sorry, I don't understand your question. Do you have an example?

Hi Caled,
Well we use the polymorphism that laravel provide to us, in some table we have messageable_id and messageable_type (it's the class of the model), so i'd like to know if the package could make the scope based on this two points (id and type) in the queries...
Cause we could have two or more id's that doesn't mean the same entity, could be some id of client, and manager whatever...
But till now we're doing this by hand actually...

Hmm I see.
In theory, you could set this up. I can't tell you what the logic would be to decide what values to use, as that's specific to your app, but you can set two "tenants":
Landlord::addTenant('messagable_id', $whatever);
Landlord::addTenant('messagable_type', $whatever);

Does that help?

Woww that's awesome!
I never thought about it...  oO
Thanks for your attention and to keep the project!

No problem. Good luck!


Remove Toolkit::Crash Reporting from skiplist

Coverage remained the same at 25.455% when pulling 0e1c7146dd80913c9e7fd329f45c16272a76754a on calixteman:no_prio_toolkit_crash into 25e4519c18aa3fa1e8cdfaee2baa7c5f1e2dbbaf on mozilla:master.


feat: xregion aws ecr auth

Description
Cross-region ECR auth provider
What this PR does / why we need it:

Fixes an issue where region-specific creds are not used. Adds region to the ECR client cfg for call to get AuthZ tokens. Maps retrieved creds to ECR registry host.
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #678
Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[X] Does the affected code have corresponding tests?
[ ] Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
[ ] Does this introduce breaking changes that would require an announcement or bumping the major version?
[ ] Do all new files have appropriate license header?

Post Merge Requirements

[ ] MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Test results show that multi-region ECR creds are used to resolve artifacts, regardless of successful image signature verification.
time="2023-04-11T13:31:38Z" level=info msg="received request POST /ratify/gatekeeper/v1/mutate "
time="2023-04-11T13:31:38Z" level=info msg="start request POST /ratify/gatekeeper/v1/mutate"
time="2023-04-11T13:31:38Z" level=info msg="mutating image <AWS_ACCOUNT_ID>.dkr.ecr.us-west-2.amazonaws.com/pause:3.1"
time="2023-04-11T13:31:38Z" level=debug msg="no digest provided for reference <AWS_ACCOUNT_ID>.dkr.ecr.us-west-2.amazonaws.com/pause:3.1. attempting to resolve..."
time="2023-04-11T13:31:38Z" level=info msg="mutating image <AWS_ACCOUNT_ID>.dkr.ecr.us-east-2.amazonaws.com/pause:3.1"
time="2023-04-11T13:31:38Z" level=debug msg="no digest provided for reference <AWS_ACCOUNT_ID>.dkr.ecr.us-east-2.amazonaws.com/pause:3.1. attempting to resolve..."
time="2023-04-11T13:31:38Z" level=debug msg="mutation: execution time for image <AWS_ACCOUNT_ID>.dkr.ecr.us-east-2.amazonaws.com/pause:3.1: 69ms"
time="2023-04-11T13:31:38Z" level=debug msg="mutation: execution time for image <AWS_ACCOUNT_ID>.dkr.ecr.us-west-2.amazonaws.com/pause:3.1: 145ms"
time="2023-04-11T13:31:38Z" level=debug msg="mutation: execution time for request: 145ms"
time="2023-04-11T13:31:38Z" level=info msg="received request POST /ratify/gatekeeper/v1/verify "
time="2023-04-11T13:31:38Z" level=info msg="start request POST /ratify/gatekeeper/v1/verify"
time="2023-04-11T13:31:38Z" level=info msg="verifying subject <AWS_ACCOUNT_ID>.dkr.ecr.us-west-2.amazonaws.com/pause@sha256:fcaff905397ba63fd376d0c3019f1f1cb6e7506131389edbcb3d22719f1ae54d"
time="2023-04-11T13:31:38Z" level=debug msg="cache miss for subject <AWS_ACCOUNT_ID>.dkr.ecr.us-west-2.amazonaws.com/pause@sha256:fcaff905397ba63fd376d0c3019f1f1cb6e7506131389edbcb3d22719f1ae54d"
time="2023-04-11T13:31:38Z" level=info msg="Resolve of the image completed successfully the digest is sha256:fcaff905397ba63fd376d0c3019f1f1cb6e7506131389edbcb3d22719f1ae54d"
time="2023-04-11T13:31:38Z" level=info msg="verifying subject <AWS_ACCOUNT_ID>.dkr.ecr.us-east-2.amazonaws.com/pause@sha256:fcaff905397ba63fd376d0c3019f1f1cb6e7506131389edbcb3d22719f1ae54d"
time="2023-04-11T13:31:38Z" level=debug msg="cache miss for subject <AWS_ACCOUNT_ID>.dkr.ecr.us-east-2.amazonaws.com/pause@sha256:fcaff905397ba63fd376d0c3019f1f1cb6e7506131389edbcb3d22719f1ae54d"
time="2023-04-11T13:31:38Z" level=info msg="Resolve of the image completed successfully the digest is sha256:fcaff905397ba63fd376d0c3019f1f1cb6e7506131389edbcb3d22719f1ae54d"
{
  "isSuccess": false,
  "verifierReports": [
    {
      "isSuccess": false,
      "name": "notaryv2",
      "message": "an error thrown by the verifier: failed to verify signature, err: plugin unsupported due to nil verifier.pluginManager",
      "artifactType": "application/vnd.cncf.notary.signature"
    }
  ]
}
time="2023-04-11T13:31:38Z" level=debug msg="verification: execution time for image <AWS_ACCOUNT_ID>.dkr.ecr.us-east-2.amazonaws.com/pause@sha256:fcaff905397ba63fd376d0c3019f1f1cb6e7506131389edbcb3d22719f1ae54d: 99ms"
time="2023-04-11T13:31:38Z" level=debug msg="verification: execution time for image <AWS_ACCOUNT_ID>.dkr.ecr.us-west-2.amazonaws.com/pause@sha256:fcaff905397ba63fd376d0c3019f1f1cb6e7506131389edbcb3d22719f1ae54d: 239ms"
{
  "isSuccess": false,
time="2023-04-11T13:31:38Z" level=debug msg="verification: execution time for request: 239ms"
  "verifierReports": [
    {
      "isSuccess": false,
      "name": "notaryv2",
      "message": "an error thrown by the verifier: failed to verify signature, err: plugin unsupported due to nil verifier.pluginManager",
      "artifactType": "application/vnd.cncf.notary.signature"
    }
  ]
}


[Docs] Unable to navigate on Chrome

I'm unable to expand submenus in the docs using
Chrome Version 75.0.3770.100 (Official Build) (64-bit)
macOS Mojave 10.14.4

I have no problems using Safari. No errors in the console.

Hi Erick. I have the same Chrome (Version 75.0.3770.100 (Official Build) (64-bit)) on Mac - no any issues.

For some reason, I had javascript disabled on the website...


ActiviModel.save() failed with: "Query Error: error occurred while decoding: Null"

Description
I'm new to sea orm and currently using sea-orm 0.8.0, postgresql(12.9)  for testing purpose.
I have create a simple table company:
CREATE TABLE company
(
	id bigserial PRIMARY KEY,
	name text NOT NULL,
	phone text,
	description text
);

with a company.rs
use sea_orm::entity::prelude::*;

#[derive(Clone, Debug, PartialEq, DeriveEntityModel)]
#[sea_orm(table_name = "company")]
pub struct Model {
    #[sea_orm(primary_key)]
    pub id: i64,
    pub name: String,
    pub phone: String,
    pub description: String,
}

#[derive(Copy, Clone, Debug, EnumIter, DeriveRelation)]
pub enum Relation {}
impl ActiveModelBehavior for ActiveModel {}

Then I use the ActiveModel to save it:
        // add
        let company = company::ActiveModel {
            id: NotSet,
            name: Set("test company".to_owned()),
            phone: Set("13189780860".to_owned()),
            description: NotSet,
        };
        let ret = Api::save(&db, company).await?;

...
impl Api {
    async fn save(
        db: &DbConn,
        company: company::ActiveModel,
    ) -> anyhow::Result<company::ActiveModel> {
        Ok(company
            .save(db)
            .await
            .with_context(|| format!("save company error"))?)
    }
}

It failed with error:  Query Error: error occurred while decoding: Null
The record is inserted into the database!
Steps to Reproduce
Not sure.
Expected Behavior

Record added.
No error

Actual Behavior

Record added with error

Reproduces How Often
Every time in my test case.
Versions
sea-orm:
├── sea-orm v0.8.0
│   ├── sea-orm-macros v0.8.0 (proc-macro)
│   ├── sea-query v0.24.6
│   │   ├── sea-query-derive v0.2.0 (proc-macro)
│   │   ├── sea-query-driver v0.1.1 (proc-macro)
│   ├── sea-strum v0.23.0
│   │   └── sea-strum_macros v0.23.0 (proc-macro)

postgresql: 12.09, ubuntu amd64.
I'm using on Macos Monterery 12.3.1
Additional Information

Hey @tubzby, welcome! I think you need to update your Model as follows:
#[derive(Clone, Debug, PartialEq, DeriveEntityModel)]
#[sea_orm(table_name = "company")]
pub struct Model {
    #[sea_orm(primary_key)]
    pub id: i64,
    pub name: String,
    pub phone: Option<String>,        // Nullable
    pub description: Option<String>,  // Nullable
}

Because both columns could be NULL and it's why you need to wrap it with Option<T>.

@billy1624 Fixed, thanks!

Welcome :D


Featuretools Entity Support

This Epic tracks all issues related to supporting Woodwork Integration into Featuretools' Entity class.
Notes here: https://alteryx.quip.com/eXVAAL5JZ1qW/Featuretools-Woodwork-Integration
Design doc here: https://alteryx.quip.com/Oa4aA6h0Rf2k/Woodwork-DataTable-Integration-Design-Document

Replaced with featuretools label.


Fix crypto TV ideas

Nothing shows as of 20/05

https://www.tradingview.com/markets/cryptocurrencies/ideas/

I meant close #573 instead of #578


How to create a embedded proxy similar to browsermob-proxy

@jekh
We are starting browser-mob by following:-
package example.tests;
import net.lightbody.bmp.BrowserMobProxyServer;
public class Sample {
public static void main(String args[]){
	ProxyServer server = new ProxyServer(4444);
	server.start();
	server.seleniumProxy();
}

}
server.seleniumProxy(); - Here we are creating seleniumProxy(). Is it possible to create normal proxy similar to following:-

./browsermob-proxy --port 9090
curl -X POST http://localhost:9090/proxy

I don't completely understand your question. However, it looks like you're starting the proxy correctly. I would recommend using the browsermob-core-littleproxy module instead of the legacy module (see the examples in the README.md file). Still, what you're doing is correct and should work. Both the Java code and the command-line/standalone mode code you pasted looks right.
Are you encountering a specific error or problem? Perhaps you could restate your question another way?

We tried using browsermob-core-littleproxy as well. But the result is same.
Our issue is, when we create the proxy using the below steps, all our http requests in our tests are passed via proxy and we are able to get the har.
./browsermob-proxy --port 9090
curl -X POST http://localhost:9090/proxy

But when we do the same using JAVA (embedded)
public static void main(String args[]){
ProxyServer server = new ProxyServer(4444);
server.start();
server.seleniumProxy();
}
the http requests are not passed via proxy. har is empty.
Please note that in both the cases we are not setting the proxy as capabilities.
We use sauce connect from sacue lab which will send the request via proxy if we configure it accordingly.
Refer http://sauceio.com/index.php/2013/09/sauce-labs-and-yes-the-browsermob-proxy/
Are we missing anything here?

what i understand is you are trying to start browsermob proxy from a java program instead of command line.
you just need to do this  with your main method.
BrowserMobProxy proxy = new BrowserMobProxyServer();
proxy.start(0); //or you can assign your desired port if you like  proxy.start(8888);
// get the JVM-assigned port and get to work!
int port = proxy.getPort();
you really dont need server.seleniumProxy();
Once the proxy is started, you can use REST commands issued from a java program or from a curl to get the har logs.

Please note that in both the cases we are not setting the proxy as capabilities.

@samuelalexanderg - If you're not using the selenium Proxy object that server.seleniumProxy() returns, then calling seleniumProxy() will not do anything useful. The purpose of that method is to return a Proxy object that you can use when configuring selenium. If you're not using selenium, you need to configure your browser or HTTP client to use BMP using the configuration mechanism provided by your browser/HTTP client/testing framework. See the README file for more information.
You seem to be using the embedded mode version of BMP, which is fine; but when you use the embedded mode, you need tell BMP to capture HAR content, retrieve the HAR, etc. in your code. You can't use REST calls to control BMP if you start BMP from java code. There are examples of capturing HAR data in embedded mode in the README.
I'm not familiar with Sauce Labs so I can't speak to how to configure their systems to use a proxy. But what @mediga said is correct and sounds like a good starting point for you.
Hope that helps!

I'm going to close this issue since the question has been answered.


add k8s 1.29 in e2e

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.17%. Comparing base (f0c45cf) to head (fa6713b).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   50.17%   50.17%
=======================================
  Files          19       19
  Lines        1164     1164
=======================================
  Hits          584      584
  Misses        517      517
  Partials       63       63

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


MIL-7: Evaluation of Tools and Processes in Milestone 1 Group Review

What's up?
Milestone 1 is a reflection on the work we have done thus far. Therefore we will add an 'Evaluation of Tools and Processes' to the Milestone 1 report to reflect on different software tools and development processes we have used.

One member from each subteam should contribute to the evaluation. This way we can have an overarching evaluation for Milestone 1.

To Do

[x] Evaluate your team's tools and development processes in Milestone md

Deadline
4.11.2022 @22.00
Additional Information
No response
Reviewers
@serdarakol @BElifb @kostanya

Let's reference the general issue #226.

Evaluation for frontend tools which are VS code, Javascript, React.js, Node.js, Bootstrapt and Docker are added.

Evaluation for backend tools (VSCode, Django & Rest framework, Postman, PostgreSQL) added.
Please review and add anything you see missing. @BElifb @mustafa-cihan @kostanya

@mumcusena I reviewed mobile tools. It is nice and clear.
@BElifb and @kostanya please review your teams tools. After that we can close the issue.

I've just checked and I can say that frontend section looks fantastic.

We could possibly mention that we had a hard time with authentication  (tokens to be specific). But this might not be the right place mention it. Other than that backend section looks superb!

Milestone I is completed, no further action is taken. Closing the issue.


"findRule" method cannot find babelOption even it is there

babel option is deep inside use, method "findRule" cannot get that option

i don't have a good idea, hope you have

I think , this is because the webpack config for nuxt.js changed
https://github.com/nuxt/nuxt.js/blob/840ccb4bdfa3751217a7b41726b3e8f11db229bb/packages/webpack/src/config/base.js#L249


cleancss sanitize.css > TypeError: Cannot read property '0' of null

Well, nevermind, apparently sanitize.css's .css file isn't even valid...
https://github.com/10up/sanitize.css/blob/master/sanitize.css#L26-L47

:+1: That's surprising indeed.

Ah nevermind, apparently it is CSS4 syntax or something and you need to use the dist version. My bad. :)


Lack of keccak hash funtion in standart crypto lib

Used forked crypto lib.
Cleaned linter warnings.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d98e6e1). Click here to learn what that means.
The diff coverage is 63.63%.

@@          Coverage Diff           @@
##             master   #14   +/-   ##
======================================
  Coverage          ?   50%
======================================
  Files             ?     1
  Lines             ?    30
  Branches          ?     0
======================================
  Hits              ?    15
  Misses            ?    14
  Partials          ?     1

Impacted Files
Coverage Δ

vanity.go
50% <63.63%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d98e6e1...26d0520. Read the comment docs.


Escape broken links for contoso.com

https://dev.azure.com/msft-skilling/Content/_workitems/edit/173987

None of these changes are necessary (and some are undesirable). So I'll close the PR without taking the changes.
If you have only "contoso.com" (without quotes) in the content, then that doesn't render as a hyperlink (so there can't be a broken link). So no need to escape ANY case like that.
If you see L"" (or variants of that), then that's example C++ source code representing a wide character string. So if you put backticks inside the quote marks, then you're breaking that example (backticks were never intended to be part of the example string, and will render it syntactically incorrect). There's no need to escape uris or urls that are inside quotes.
I've confirmed that none of these examples are being rendered in the web page as hyperlinks. So there's nothing to change here.


Add existing geometry

Lots of the files are just converting things to f32. Main work was in the Geometry and Buffer classes.

Looks like we have some conflicts here now. it's only formatting changes and assert-to-expect changes. I can help sort it out.

Not surprising there's conflicts. I wouldn't be surprised if there's a lot more once the other PR is merged onto this one

GitHub has a bug where any PRs that were already open when we changed the build requirement to v12-v14 still expect the old builds which will never run.

Good to merge!


Stop calculating cyclomatic complexity for methods which have Macro c…

…onditions
Fixes #98
We skip cyclomatic complexity for methods which contain Macro::If/Macro::For nodes. Because macros usually can't be splitted out into multiple methods.
/cc @Blacksmoke16

:100: Will this also cover like {% unless condition %}?

Yes, unless is transformed to if node


Update Dockerfile - version bump.

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Versions bump.
Implemented by @radoslawc. PR created by @kmadejek-samsung in order to start processing CLA authorization.
Does this PR introduce a user-facing change?:

NONE

/ok-to-test

/easycla

/approve

/approve
/lgtm


Postbox Theme

Postbox Email Client Theme
Hello,
I created a postbox theme using Dracula Color Palette. The screenshot does not clearly portray all the colors but after utilization, users surely can see all the colors being used.
This is the link to my git repo.

Hey, very cool! ✨
I just sent you an invitation to join the organization.
I also cloned your repository for Dracula's organization, so you can go ahead and delete or archive yours:

Your repository.
New repository.

Thanks for building this! 🎉

It's live on the website now! https://draculatheme.com/postbox
@arukshpatel you can go ahead and remove your repository now.
Congrats on this new theme 🎉 🎉 🎉


Check alt key for shortcuts.

Summary
This PR resolves https://github.com/andrewnguonly/Lumos/issues/188.

To do: Explore bringing back tool tips for shortcut keys.


Authentication error: undefined

Storage Explorer Version: <1.17
Build Number: 20201211.10
Platform/OS: Windows 10
Architecture: x64
Regression From:  Was working previously and still works on Linux.
Bug Description
When I try to connect using a connection string that worked previously and still works on Linux, the connection seems to work. However, when I try to open the Tables, I get an error message "Authentication error: undefined".

Steps to Reproduce
See above
Expected Experience
I see the tables
Actual Experience
Error message: Authentication error: undefined
Additional Context
Nothing unusual.

@maeehart Does this constantly reproduce? Have you tried this in 1.17.0 and does it work there? Also could you share the connection string after redacting your credentials (e.g. account key, etc.)?

It reproduced constantly for some days. No matter if I reinstalled Storage explorer or what. Al the time, the connection string worked on Linux.
Now, a couple of days ago it started working without me having to do anything. Cannot reproduce the problem anymore, so I will close.


Add period and capitalized letter for formatting

The first list item in the 'Folder structure' section of README.md file didn't have a capitalized sentence at the beginning and didn't have a period at the end like the other list items.

Thanks


Enabling Blue box to support compute on Power

Following are the changes made to Ursula to support compute on Ubuntu 15.04, ppcle64

Added upstart scripts to run the services on Ubuntu 15.04
Added tasks to load upstart service scripts to target node and also reload the systemctl deamon
Added a task to turn off SMT mode on Power machine.
Enabled power compute node communication with the rabbit MQ by allowing the ports
Provided cacert in "library/keystone_user.py" to resolve SSL issues on Power node.
Skipped "apt-repos" role execution on Power compute node, as supported(Ubuntu 15.04 and ppc64le) binaries for the repositories are not avaible at http://repo.openstack.blueboxgrid.com/ubuntu/

Please validate and let us know the review comments

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

outside of the code review itself, there is work to be done in the commits. There is a merge commit in the mix, plus a "initial commit" that really doesn't provide good context for the change itself.
Many of these commits look like they could be squashed together, to form more logical sets of change that each can be applied or reverted independently without disruption.

Can we move the Upstart to Systemd conversion into a separate PR so each change is isolated to a single topic.

Power changes have been requested through https://github.com/blueboxgroup/ursula/pull/1522/files and merged to the master


ruff check --diff writes summary message to stdout instead of stderr

When running ruff check --diff the diff and summary message ("Would fix 2 errors") is written to standard output.
$ ruff check --select F,W,RUF015 --no-cache example.py --diff 2> /dev/null
--- example.py
+++ example.py
@@ -1,10 +1,9 @@
 from typing import List

-import os

 def sum_even_numbers(numbers: List[int]) -> int:
     """Given a list of integers, return the sum of all even numbers in the list."""
     return sum(num for num in numbers if num % 2 == 0)

 x = range(10)
-list(x)[0]
\ No newline at end of file
+list(x)[0]

Would fix 2 errors.

I presumed this would cause problems with displaying or applying the patch but it turns out it does not since the number of lines is specified in the diff.
e.g.
You can use ydiff for a pretty diff and the summary is separate:
$ ruff check --select F,W,RUF015 --no-cache example.py --diff | ydiff -s
--- example.py
+++ example.py
@@ -1,10 +1,9 @@
 1 from typing import List                                                           1 from typing import List
 2                                                                                2
 3 import os
 4                                                                                3
 5 def sum_even_numbers(numbers: List[int]) -> int:                                  4 def sum_even_numbers(numbers: List[int]) -> int:
 6     """Given a list of integers, return the sum of all even numbers in the list>  5     """Given a list of integers, return the sum of all even numbers in the list>
 7     return sum(num for num in numbers if num % 2 == 0)                            6     return sum(num for num in numbers if num % 2 == 0)
 8                                                                                7
 9 x = range(10)                                                                     8 x = range(10)
10 list(x)[0]                                                                        9 list(x)[0]

Would fix 2 errors.

Or you can use git apply to apply the diff:
 $ ruff check --select F,W,RUF015 --no-cache example.py --diff | git apply -

As far as I can tell, this is not an issue. Feel free to chime in if it affects your use-case!


Bump webgl_generator and webgl_stdweb versions

Closes  #467

Ugh, the build keeps timing out on nightly

should we add a travis_wait to the cargo test command?

Oh, do you think that would fix it?

Hum, interesting - just reading the docs! https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received

Done! At last! Sorry for my slowness! 🤦♂


[ACLs] Prevent data collectors from seeing each other's LOIs

This PR hard codes this behavior for surveys by default. As follow-ups, we'll want to 1) add restriction server side and 2) allow survey organizers to control whether data collectors can see each other's data.
Tested manually on Pixel 7, Android 14, API 34.
Towards #2374
@lecrabe @rfontanarosa @jcqli  FYI

@shobhitagarwal1612 RFAL!