Wrong color index exported (COLOR_0, COLOR_1)

I have a gltf with COLOR_0 and COLOR_1.
I import it in blender and then export it in glTF (default parameter).
Issues:

On Blender 3.3.1, COLOR_1 and COLOR_1 are swapped on export
On Blender 3.4.0, there is only one channel exported (and it has the data of COLOR_1), even if I use both channels in the shader graph in shading tab.

(both channels have different data, so an easy repro is to simply export-reload to see the difference in shading tab).

On Blender 3.3.1, COLOR_0 is the rendered vertex color slot, the other one is COLOR_1.
There was some refactoring on how vertex color are exported between 3.3 and 3.4.
Now, only rendered vertex color are exported as vertex color COLOR_0, and others (so, not rendered, are exported as _COLOR_x .
Maybe linked to #1740

On Blender 3.3.1, COLOR_0 is the rendered vertex color slot, the other one is COLOR_1.

But that's not what the exporter is doing, it definitely exports COLOR_1 data in COLOR_0 slot instead, on both 3.3.1 and 3.4.
This line shows 1 instead of 0, I know nothing about the API but maybe it should be active_color_index or something else. The doc about render_color_indexmentions fallback for rendering but it's a bit vague for me.
In any case, I didn't even fiddle with the blender shader graph, it's the default glTF one:

Loading a glTF, exports it and reloading it shows a different result so there is definitely a bug to me, or I'm missing something.

As for #1740, the @emackey 's main argument on exporting a single channel was This has caused some confusion among artists. But that's not because there was multiple color channels! It was because COLOR_0 and COLOR_1 were swapped during export.
Also, the current solution doesn't even fix #1740 as it will export COLOR_1 instead (named as COLOR_0).
To me the best solution is simply to export all the channels in the same order as inside blender (the glTF import works perfectly in that regard).

After import, the second color layer Col.001 is the default attribute for rendering (render_color_index == 1). The importer just needs to make sure the first one is always the default.

It would help indeed.

The problem is you can't control the order

I'm a bit confused, aren't the "color attributes" section in blender ordered, similarly to UVs?
I thought it was handled similarly to UV sets.
Is there any reasons why the following code wouldn't work?
I just tested it and it worked fine (3.4.0, both channels exported with correct order).
(I don't know much about python or blender internal color handling, so I won't claim it's a good solution, but I'm wondering)
diff --git a/gltf2_blender_gather_primitives_extract.py b/gltf2_blender_gather_primitives_extract.py
index c12a6bdf..0e7aa82a 100644
--- a/gltf2_blender_gather_primitives_extract.py
+++ b/gltf2_blender_gather_primitives_extract.py
@@ -165,12 +165,11 @@ class PrimitiveCreator:

                 continue

-            if self.blender_mesh.color_attributes.find(blender_attribute.name) == self.blender_mesh.color_attributes.render_color_index \
-                and self.blender_mesh.color_attributes.render_color_index != -1:
+            if self.blender_mesh.color_attributes.find(blender_attribute.name) >= 0:

                 if self.export_settings[gltf2_blender_export_keys.COLORS] is False:
                     continue
-                attr['gltf_attribute_name'] = 'COLOR_0'
+                attr['gltf_attribute_name'] = 'COLOR_' + str(self.blender_mesh.color_attributes.find(blender_attribute.name))
                 attr['get'] = self.get_function()

             else:
@@ -539,10 +538,10 @@ class PrimitiveCreator:
     def get_function(self):

         def getting_function(attr):
-            if attr['gltf_attribute_name'] == "COLOR_0":
-                self.__get_color_attribute(attr)
-            elif attr['gltf_attribute_name'].startswith("_"):
+            if attr['gltf_attribute_name'].startswith("_"):
                 self.__get_layer_attribute(attr)
+            elif attr['gltf_attribute_name'].startswith("COLOR_"):
+                self.__get_colors_attribute(int(attr['gltf_attribute_name'].split("_")[-1]), attr)
             elif attr['gltf_attribute_name'].startswith("TEXCOORD_"):
                 self.__get_uvs_attribute(int(attr['gltf_attribute_name'].split("_")[-1]), attr)
             elif attr['gltf_attribute_name'] == "NORMAL":
@@ -553,9 +552,7 @@ class PrimitiveCreator:
         return getting_function

-    def __get_color_attribute(self, attr):
-        blender_color_idx = self.blender_mesh.color_attributes.render_color_index
-
+    def __get_colors_attribute(self, blender_color_idx, attr):
         if attr['blender_domain'] == "POINT":
             colors = np.empty(len(self.blender_mesh.vertices) * 4, dtype=np.float32)
         elif attr['blender_domain'] == "CORNER":
@@ -877,4 +874,4 @@ class PrimitiveCreator:
                 self.attributes[attr['gltf_attribute_name']]["data_type"] = gltf2_io_constants.DataType.Vec2
             else:
                 self.attributes[attr['gltf_attribute_name']]["component_type"] = gltf2_blender_conversion.get_component_type(attr['blender_data_type'])
-                self.attributes[attr['gltf_attribute_name']]["data_type"] = gltf2_blender_conversion.get_data_type(attr['blender_data_type'])
\ No newline at end of file
+                self.attributes[attr['gltf_attribute_name']]["data_type"] = gltf2_blender_conversion.get_data_type(attr['blender_data_type'])

I just created a PR with @scurest suggestions here #1767

@stephomi We want to export the rendered layer as COLOR_0, even if this is not the first in the loop/list

The rendered layer is the one with active icon
We also have to be careful because we are looping on attributes, and it may not follow the order of color attributes

Thanks, the fix will at least resolve https://github.com/KhronosGroup/glTF-Blender-IO/issues/1740

We also have to be careful because we are looping on attributes, and it may not follow the order of color attributes

Afaik I was only taking the index in the color attributes (self.blender_mesh.color_attributes.find(blender_attribute.name))

We want to export the rendered layer as COLOR_0, even if this is not the first in the loop/list

Ok got it, so basically it has nothing to do with how the channel is used in the shader graph.
I would have expected a similar behaviour than with the UVs though (re-export all the channels by default, whether used or not)

Also, not sure if it's by design, but the addon doesn't re-import the custom attribute, for example _COL.001 is ignored.
Also, the data is incorrect as it's flagged as "U16" but in reality there is float inside.
Either it should be flagged as F32 data or it should be correctly converted to u16 here.
I can read the data back if I filter with stuffs starting with _COL., but it's probably best if it uses blender_mesh.color_attributes instead.

Thanks, the fix will at least resolve #1740

Aims of the proposition 1740 is to export COLOR_0 only if vertex color are really used in shader graph. It still not the case yet

Also, not sure if it's by design, but the addon doesn't re-import the custom attribute, for example _COL.001 is ignored.

Import of custom attributes is not implemented yet

Also, the data (of _COL.001) is incorrect

You are right. Additional Vertex Color are named based on layer name, not _COLOR*
This should be fixed on #1770


Added primary contents for Bengali Language

This PR is to initiate Bengali localization based on

Issue to https://github.com/kubernetes/test-infra/pull/25137
Issue to https://github.com/kubernetes/org/pull/3235

This PR includes

Readme-bn.md
content/bn/ directory
[Updated] config.toml
[Updated] content/bn/OWNERS
[Updated]content/bn/_common-resources/index.md
[Updated] content/bn/docs/_index.md
[Created] some files to work in future [WIP]

Created content/bn/docs/contribute/localization.md
Created content/bn/docs/home/_index.md
Created content/bn/docs/setup/_index.md
Created content/bn/docs/tutorials/hello-minikube.md
Created content/bn/releases/_index.md

/check-cla

Hello @mitul3737 , thank you so much for initiating this discussion. Please could you sign the CLA & make sure you add it in your variables while pushing the commit.

/easy-cla

/easycla

@divya-mohan0209  done with the CLA

@mitul3737 Thanks for signing the CLA
I'm not sure if you're saying that this PR is ready for review. It looks to me if it is still quite a way short, so I will mark it as a draft.

@sftim  . Yes, we need to work a lot now. Can you please create e dev branch for Bengali documentation under the Kubernetes Website? For example,  dev-1.23-bn.1


adding a chatbot

@gauravsingh1281 can you assign me this task.
I want to add a chat box to this website, which is which will be fine to the website solving user requirements.

hello PA, can I also contribute to this issue?


Update Readme "Authentication on an Endpoint"

The part of "Authentication on an Endpoint" saying...
// Users must have 'Member' role.
app.use("/post", protectedRoute(['Member']), postRouter);

// Users must have BOTH 'Member' and 'Commenter' roles.
app.use("/comment", protectedRoute(['Member', 'Commenter']), commentRouter);

// Users must have EITHER 'Member' or 'Verified' role.
app.use("/vote", protectedRoute(['Member', 'Verified'], { requireAllRoles: false }), voteRouter);

should actually be a part of the "Authorization on an Endpoint" section and the part in "Authorization on an Endpoint" is not necessary when checking "Composite" roles. Instead, it can be shown how to do different actions based on role or based on permission (non-composite role).

Fixed


Update chapter code to vulkano 0.34

I updated just the chapter code to vulkano 0.34. Code reviews would be very appreciated. Also, the graphics pipeline example runs slow on my machine, not sure why.

Thank you very much! How do you think should we proceed with updating the rest of the book?


Enabling unroll and jam in matmul

see related issue (#770)

Found a way to make it work, will push solution soon.

Solution was to record which loop to unroll during the lowering from krnl to affine, and once we have affine-only code in that pass, we look into the list of loop to unroll to perform that operation.
Because I need some global state (record loop to unroll during the pattern matching, perform the unrolling in the pass once all patterns have matched), I had to add locks to protect adding a new list in the map <function -> list>.
I would rather be able for the pattern to access a "current list" that is added to the state of the patterns, but I did not know how to do that. If anyone knows, I would love to hear about it.

I also had to transform the scalar reduction variable into a private array (of size of the unrolling factor) to legally perform the unroll and jam.

@AlexandreEichenberger is it ready to merge so that we can enjoy the optimization for GEMM?

Jenkins Linux ppc64le Build #624 [push] Enabling unroll and jam ... started at 00:03

Jenkins Linux amd64 Build #1486 [push] Enabling unroll and jam ... started at 22:59

Jenkins Linux s390x Build #1484 [push] Enabling unroll and jam ... started at 23:59

Jenkins Linux s390x Build #1484 [push] Enabling unroll and jam ... passed after 42 min

Jenkins Linux amd64 Build #1486 [push] Enabling unroll and jam ... passed after 53 min

Jenkins Linux ppc64le Build #624 [push] Enabling unroll and jam ... passed after 56 min


add functionality to clear out DLL

In testing and in a use case, one runs up against the max number of DLLs loaded into R when compiling models/algorithms in a loop. Would be good to provide a user-facing function that will clear out the old DLLs.
However, note Perry's comment:
"resetFunctions does not clear out the DSL because I believe that would make previously compiled algorithms crash when called, if their DSL has been viciously disappeared."

Just checking on this in relation to code like we have in test-mcmc, i.e.
dyn.unload(getNimbleProject(Rmodel)$cppProjects[[1]]$getSOName())
dyn.unload(getNimbleProject(Rmcmc)$cppProjects[[2]]$getSOName())
Are you suggesting something more like
nimbleUnload(Cmcmc, entireProject = TRUE)
where the 2nd argument says to dyn.unload everything, or if FALSE only the first part would be unloaded?

Yes, I think that's what I would like.
On Fri, May 6, 2016 at 2:36 PM, perrydv<EMAIL_ADDRESS>wrote:

Just checking on this in relation to code like we have in test-mcmc, i.e.
dyn.unload(getNimbleProject(Rmodel)$cppProjects[[1]]$getSOName())
dyn.unload(getNimbleProject(Rmcmc)$cppProjects[[2]]$getSOName())
Are you suggesting something more like
nimbleUnload(Cmcmc, entireProject = TRUE)
where the 2nd argument says to dyn.unload everything, or if FALSE only the
first part would be unloaded?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/nimble-dev/nimble/issues/140#issuecomment-217564574

we built clearCompiled a while ago to address this issue


3 0 stable

@sawangupta92 - Please look into the CR issues. Also, build is failing can you also look into this.


feat(sidenav): add fullscreen mode

r: @jelbourn
This PR introduces a fullscreen mode for sidenav, so sidenav spans the whole viewport.

LGTM; @hansl should take a look


Log transform for US$ variables

Here's the variables I think we should log transform, all representing income/wages/etc.
VERSIONS = {
...
    'log_transform_feats': '''INTP OIP PAP RETP SEMP SSIP SSP WAGP PERNP
                            PINCP'''.split(),

Only issue is that some of these variables can be negative (for losses). So I guess the transformation for those should be x = log(x - min(x)) or something?
Once we figure that out it should be easy to put this into get_dummies.

I think in my pre-pummeler attempt at this I did sign(x) * log(x + 1*sign(x)) or something. log(x - min(x)) isn't shaped very nicely if min(x) is, say, -915,729,293.

don't understand... 1+sign(x)?
I just looked through the codebook more carefully. Most (all?) of these are truncated below ("Rounded & bottom-coded") so I think something like my solution actually makes sense. Sure, it won't be a normal distribution, but if we're featurizing using KDE than it'll just have a weird bump in the lower tail. Of course my solution doesn't work  when x = min(x) so I guess now I'm proposing:
log(x - min(x) + 1)

I was a little off before: what I want is sign(x) * log( |x| + 1 ), which maintains both sign information and magnitude information. Doing log(x - min(x) + 1) is weird because it conflates very-negative incomes with slightly-negative incomes, while the amount that moderate incomes are conflated depends on what the min is.

OK, finally went through case-by-case using the sampled data. Here are the only two monetary variables that I found that can actually be negative:

INTP (Interest, dividends, and net rental income) has a bunch of true zeros ("None"). Only 0.2% were negative.

SEMP (Self-employment income) is same as INTP, with even more true zeros. Again only 0.2% were negative (correlated with INTP?)

So maybe we just do categorical variables for whether INTP/SEMP are non-zero? But I still don't know what transform to use for positive / negative. Here are our two proposals, neither looks great:

Update: forgot about PERNP, which can also be negative. Or have true zeros (no earnings)?
Also what's RACNUM =  Number of major race groups represented
1..6 .Race groups
mean?

IIRC RACNUM is the flag for how many racial groups the person has indicated, with RAC1P the first race, RAC2P the second, etc.


Refactor UpdateTopologyManager assert method

Hi~
I was reading this part of code. I was wondering if we could use guava Preconditions.checkArgument or Preconditions.checkState instead of assertTrue method. I'll send a PR for this.

merged #1613 and closed

Try to do the same in ByteAmount


Supports RSA pubkey JWK-to-pem related functions

Supports RSA pubkey JWK-to-pem related functions (for https://github.com/place-labs/jwks)

Add the following LibCrypto bindings

bio_new file
rsa_set0_key
pem_write_bio_rsa_pub_key

@stakach yep I found out that it was blocking the thread too, on the JWKS lib itself I've changed it to writing reading directly from nonblocking IO.


Advertisment vs Advertisement

The schema: https://github.com/anansi-project/comicinfo/blob/main/schema/v2.0/ComicInfo.xsd
Has the page type as: "Advertisment" (no e)
Our code has: "Advertisement" (with e)
I noticed the issue when loading an archive with the schema's value (no e), and the application crashes on save (as below).
It is a simple change and I can create a pull request - but then all old archives with the old spelling could similarly crash.
A cleaner approach might be to default the old value to the new one silently, but it would require an archive save to fix permanently in the archive's xml file.
Thoughts?
Traceback (most recent call last):
File "/home/michael.fitzurka/Projects/comictagger/comictaggerlib/taggerwindow.py", line 2063, in fileListSelectionChanged
self.loadArchive(fi.ca)
File "/home/michael.fitzurka/Projects/comictagger/comictaggerlib/taggerwindow.py", line 2081, in loadArchive
self.actualLoadCurrentArchive()
File "/home/michael.fitzurka/Projects/comictagger/comictaggerlib/taggerwindow.py", line 610, in actualLoadCurrentArchive
self.pageListEditor.setData(self.comic_archive, self.metadata.pages)
File "/home/michael.fitzurka/Projects/comictagger/comictaggerlib/pagelisteditor.py", line 275, in setData
item = QListWidgetItem(self.listEntryText(p))
File "/home/michael.fitzurka/Projects/comictagger/comictaggerlib/pagelisteditor.py", line 287, in listEntryText
text += " (" + self.pageTypeNames[page_dict['Type']] + ")"
KeyError: 'Advertisment'
Traceback (most recent call last):
File "/home/michael.fitzurka/Projects/comictagger/comictaggerlib/taggerwindow.py", line 2063, in fileListSelectionChanged
self.loadArchive(fi.ca)
File "/home/michael.fitzurka/Projects/comictagger/comictaggerlib/taggerwindow.py", line 2067, in loadArchive
self.clearForm()
File "/home/michael.fitzurka/Projects/comictagger/comictaggerlib/taggerwindow.py", line 748, in clearForm
self.pageListEditor.setData(self.comic_archive, self.metadata.pages)
File "/home/michael.fitzurka/Projects/comictagger/comictaggerlib/pagelisteditor.py", line 271, in setData
self.listWidget.itemSelectionChanged.disconnect(self.changePage)
TypeError: 'method' object is not connected
Aborted (core dumped)

Well this is definitely a problem that we crash on invalid data. But I believe it's actually a bug in the schema.
The schemas for this format have never been 100% accurate. You can check to see what ComicRack puts out, as it invented the format.

Downloaded the app and you are correct, the value from ComicRack is Advertisement with an "e".
I submitted a pull request to change their specs: https://github.com/anansi-project/comicinfo/pull/20.
I'll make a fix here to stop the crash on an invalid value, but not change the Advertisement value itself.

Awesome! Thanks for the work you're putting in

Merged


Reduce dependencies only to necessary ones.

I have been working on #81 and the debug process using LLDB/GDB on the Java/JNI code is a little bit difficult due to the dependencies that we have right now, this can also increase build speed.
It may be a good time to reduce the dependencies we don't use, and leave the ones we want for the app to work.
On the Java side we have:

RNWebSocket which is unused right now.

On the JavaScript side I don't know much but if we can reduce it would be good too.

this issue was resolved in the PR #125


Webpack 5 error

when call:
docusaurus start
it throws:
Module not found: Error: Can't resolve 'path' in './node_modules/@redocly/openapi-core/lib/config'
BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default. This is no longer the case. Verify if you need this module and configure a polyfill for it.
docusaurus version:
2.0.0-alpha.75

you need to polyfll node apis for webpack 5
check this https://gist.github.com/sibelius/24f63eef7f43b15dc73c4a0be11bbef8

I fixed polyfills in latest PR #40 but I'm getting this error now:
TypeError: Cannot read property 'split' of undefined
error building locale=en
Error: Failed to compile with errors.
    at /Users/rohitgohri/Projects/personal/redocusaurus/node_modules/@docusaurus/core/lib/webpack/utils.js:198:24
    at /Users/rohitgohri/Projects/personal/redocusaurus/node_modules/webpack/lib/MultiCompiler.js:550:14
    at processQueue (/Users/rohitgohri/Projects/personal/redocusaurus/node_modules/webpack/lib/MultiCompiler.js:488:6)
    at processTicksAndRejections (internal/process/task_queues.js:79:11)

Might be related to https://github.com/facebook/docusaurus/issues/3515 maybe as I'm using yarn workspaces now. Still investigating.

Fixed in v0.4.0


chore(docs): explicit actions after upgrading to 1.3.0

:tada: This PR is included in version 1.3.1-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


install python wrapper failed at make -j4

I got thru the instructions for installing python wrapper all the way to make -j4. It says
make: *** No targets specified and no makefile found.  Stop.
indeed, there is no makefile in the build or any sub directories.
where are you suppose to exec this command?

Hi @bhomass , if you start in librealsense root and follow the instructions, then  when reaching 'make -j' stage would put you:
--| .        .        .     .     .     . (librealsense root dir)
....| .github
....| build
.     .     .     .   .   .|.   here
...
....| include
....| src
....| scripts
...

you mean the build subdirectory? I am in that exact location, and make -j4 gives me that error about no makefile. Should I have a makefile there by this stage? There are some .cmake files though. But make command is not using them.

@bhomass did you do following before make in the build folder cmake ../ -DBUILD_PYTHON_BINDINGS=bool:true ?

yes, I did. It completes with no error. The response is as follows
-- Info: REALSENSE_VERSION_STRING=2.12.0
CMake Warning at CMakeLists.txt:576 (message):
Using libuvc!
-- pybind11 v2.2.1
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/bruceho/workspace/librealsense/build
But still no makefile created. The directory listing is
CMakeCache.txt			cmake_uninstall.cmake		log.txt				tools
CMakeFiles			config				realsense2Config.cmake		wrappers
CMakeScripts			examples			realsense2ConfigVersion.cmake
cmake_install.cmake		librealsense2.xcodeproj		third-party

[Realsense Customer Engineering Team Comment]
hi @bhomass,
would like to check some basic for this topic,
what's your OS? Ubuntu? version?
thanks.

@TonyFaith no, I just mean you need to create a different build directory for the wrapper code (such as python_build), which is distinct from the build directory you may have used to build the repo at the root level. If you didn't try building at root level, then nothing to worry about.
@customer-engineering I have OSX, but my problem and solution is unrelated to which OS.


benchmarks: update build_web_compilers and default to dart2js -O3

merging on red as this is a trivial change and travis is broken at head :sob:


Banana cream pies reveal identity

Description
See title
Reproduction

Give a mask to an Urist without an ID so they get an unknown identity
Throw a banana cream pie at him
The popup will say "Urist McHands ..."

Screenshots

Additional context
It should use the Name function in Content.Shared.IdentityManagement instead.
Good for a beginner PR.

I'll fix

Also that is a weird asf LOC, cream-pied-component-on-hit-by-message-others

Has to do with this I think #18540

I'll fix

I wont fix.

I'll fix

I can take this one on if @Brandon-Huu is no longer working on it

I can take this one on if @Brandon-Huu is no longer working on it

Yeah, do that.


Attachment

What?

Support sending attachments.
Fix undefined index errors

Why?

Because this is supported by the REST API
Because they are optional.

This is awesome - thanks @morrislaptop !
I'll tag a 0.5.2 release once this is merged 👍


can't work

An exception was raised while handling an update
update = {
"update_id": 856662397,
"message": {
"chat": {
"id": 915625592,
"type": "private",
"last_name": "L",
"first_name": "S",
"username": "wangxun0712"
},
"text": "where is china",
"group_chat_created": false,
"entities": [],
"new_chat_members": [],
"new_chat_photo": [],
"message_id": 5,
"delete_chat_photo": false,
"caption_entities": [],
"date":<PHONE_NUMBER>,
"supergroup_chat_created": false,
"photo": [],
"channel_chat_created": false,
"from": {
"is_bot": false,
"username": "wangxun0712",
"first_name": "S",
"last_name": "L",
"id": 915625592,
"language_code": "zh-hans"
}
}
}
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/telegram/ext/_application.py", line 945, in process_update
await coroutine
File "/usr/local/lib/python3.8/site-packages/telegram/ext/_handler.py", line 135, in handle_update
return await self.callback(update, context)
File "bot.py", line 33, in prompt_handle
r = chatgpt.get_chat_response(prompt)
File "/usr/local/lib/python3.8/site-packages/revChatGPT/revChatGPT.py", line 54, in get_chat_response
response = json.loads(response)
File "/usr/local/lib/python3.8/json/init.py", line 357, in loads
return _default_decoder.decode(s)
File "/usr/local/lib/python3.8/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/local/lib/python3.8/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 3 (char 2)

I switched the code to GPT-3.5 engine. Try it now


Add ability to  query status of timer. Add on and off output branches for switch status

Add support for querying status of timer and adds 2 additional outputs for on and off branches when querying status.
See diff in README.md for more details.
[{"id":"560543a2.a90d04","type":"ui_countdown_timer_switch","z":"880ac413.166","name":"","label":"Test countdown","group":"a74f3b0c.e3d6f8","order":2,"width":0,"height":0,"countdowns":["5","10","15","30"],"onvalue":"true","onvalueType":"bool","offvalue":"false","offvalueType":"bool","topic":"","outputState":"true","showDropdown":false,"x":360,"y":680,"wires":[["ffd8db79.ca527"],["f5dbbe6e.47c008","18193021.33bd3"],["e334eec2.009198","18193021.33bd3"]]},{"id":"3ef70fe.5206df","type":"inject","z":"880ac413.166","name":"","props":[{"p":"payload"},{"p":"countdown","v":"1","vt":"num"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"true","payloadType":"bool","x":170,"y":700,"wires":[["560543a2.a90d04"]]},{"id":"35037617.166cca","type":"inject","z":"880ac413.166","name":"Timer Status","props":[{"p":"topic","vt":"str"},{"p":"payload"},{"p":"state","v":"timerState","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"status","payload":"{\"value\":\"test\",\"another\":true,\"number\":2}","payloadType":"json","x":150,"y":660,"wires":[["560543a2.a90d04"]]},{"id":"f5dbbe6e.47c008","type":"change","z":"880ac413.166","name":"On State","rules":[{"t":"set","p":"display","pt":"msg","to":"On","tot":"str"}],"action":"","property":"","from":"","to":"","reg":false,"x":560,"y":680,"wires":[["582f1be9.62d4fc"]]},{"id":"e334eec2.009198","type":"change","z":"880ac413.166","name":"Off State","rules":[{"t":"set","p":"display","pt":"msg","to":"Off","tot":"str"}],"action":"","property":"","from":"","to":"","reg":false,"x":560,"y":720,"wires":[["582f1be9.62d4fc"]]},{"id":"582f1be9.62d4fc","type":"ui_text","z":"880ac413.166","group":"a74f3b0c.e3d6f8","order":3,"width":0,"height":0,"name":"","label":"Timer State","format":"{{msg.display}}","layout":"row-spread","x":770,"y":680,"wires":[]},{"id":"ffd8db79.ca527","type":"change","z":"880ac413.166","name":"Event","rules":[{"t":"set","p":"display","pt":"msg","to":"payload","tot":"msg"}],"action":"","property":"","from":"","to":"","reg":false,"x":550,"y":640,"wires":[["582f1be9.62d4fc"]]},{"id":"1c9e68a1.8bb577","type":"inject","z":"880ac413.166","name":"Timer Status","props":[{"p":"topic","vt":"str"},{"p":"payload"},{"p":"countdown","v":"3","vt":"num"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"status","payload":"{\"value\":\"test\",\"another\":true,\"number\":2}","payloadType":"json","x":150,"y":620,"wires":[["560543a2.a90d04"]]},{"id":"18193021.33bd3","type":"debug","z":"880ac413.166","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","statusVal":"","statusType":"auto","x":550,"y":760,"wires":[]},{"id":"a74f3b0c.e3d6f8","type":"ui_group","name":"Charts","tab":"2599019.36845fe","order":1,"disp":false,"width":"12","collapse":false},{"id":"2599019.36845fe","type":"ui_tab","name":"Home","icon":"dashboard","order":1,"disabled":false,"hidden":false}]

Hi, thanks for the PR. Please target it to the new dev branch. Please also make sure 'insertSpaceAfterFunctionKeywordForAnonymousFunctions' is disabled.

Requested changes made.
Is there a standard eslint or prettier config for either this node, or node-red in general?


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210720153745917 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210720153745917 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.552%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
26727

Relevant Lines:
56924

💛  - Coveralls


Glimpse fails if plugins are duplicated and re-loaded

I'm running Mighty Moose which creates a subfolder in bin and stores its own copies of binaries, including Glimpse binaries.
When starting up, Glimpse is recursing into that folder to look for plugins and finds the duplicate binaries. An exception is thrown (below) and the Glimpse client doesn't appear in the browser. This is v0.86.
To reproduce, create a subfolder in bin and copy Glimpse.Core into that folder.
Should Glimpse ignore duplicate plugins?
Cheers,
Robin
2011-12-02 14:26:43.6647|ERROR|Glimpse.Core.Module|Exception during PostRequestHandlerExecute|System.ArgumentException--An item with the same key has already been added.--   at System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
at System.Collections.Generic.Dictionary2.Insert(TKey key, TValue value, Boolean add)    at System.Collections.Generic.Dictionary2.Add(TKey key, TValue value)
at Glimpse.Core.Module.ProcessData(HttpContextBase context, Boolean sessionRequired)
at Glimpse.Core.Module.PostRequestHandlerExecute(HttpContextBase context)
at Glimpse.Core.Module.OnPostRequestHandlerExecute(Object sender, EventArgs e)

This looks like it would be a problem. We are using MEF scan through the DLL's looking for plugins. When it finds any it then adds them as plugins. I can see how in the scenario you have described this would cause issues and since its not a case we are protecting against, you are getting the error. Let me look into this and get back to you on it.

@robinminto - thanks for the excellent bug report.
This is certainly something we can fix. Let me see where we can work it
into the release cycle.
Thanks,
Nik
On Fri, Dec 2, 2011 at 9:30 AM, robinminto <
<EMAIL_ADDRESS>
wrote:

I'm running Mighty Moose which creates a subfolder in bin and stores its
own copies of binaries, including Glimpse binaries.
When starting up, Glimpse is recursing into that folder to look for
plugins and finds the duplicate binaries. An exception is thrown (below)
and the Glimpse client doesn't appear in the browser. This is v0.86.
To reproduce, create a subfolder in bin and copy Glimpse.Core into that
folder.
Should Glimpse ignore duplicate plugins?
Cheers,
Robin
2011-12-02 14:26:43.6647|ERROR|Glimpse.Core.Module|Exception during
PostRequestHandlerExecute|System.ArgumentException--An item with the same
key has already been added.--   at
System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
at System.Collections.Generic.Dictionary2.Insert(TKey key, TValue value, Boolean add)   at System.Collections.Generic.Dictionary2.Add(TKey key, TValue value)
at Glimpse.Core.Module.ProcessData(HttpContextBase context, Boolean
sessionRequired)
at Glimpse.Core.Module.PostRequestHandlerExecute(HttpContextBase context)
at Glimpse.Core.Module.OnPostRequestHandlerExecute(Object sender,
EventArgs e)

Reply to this email directly or view it on GitHub:
https://github.com/Glimpse/Glimpse/issues/149


Proposal: preview builds (Netlify or Zeit)

As a contributor I want to see a preview of the changes in my PRs and branches using Netlify or Zeit.
Reference: https://github.com/DanielRuf/website/pull/1

Netlify +1

@juanpicado let's check what we need to use this.
I guess we have to setup the Netlify integration including for PRs and then test on a separate branch.

Sure, let me know whether I can help with some step of this.

https://github.com/verdaccio/website/pull/270


IDE User should experience minimal delay when collapsing nodes.

This task is automatically imported from the old Task Issue Board and it was originally created by Michael Mauderer.
Original issue is here.

Why
As IDE user
**I want ** to be able to collapse groups of nodes with minimal delay
**So that ** I have a smooth experience of working with the IDE
Acceptance Criteria
Scenario:
Given I have an open project in the IDE
When I select some nosed and press ctrl+g
Then the new node should be created and the visualisation should be visible instantly.

Notes:
This user story is written aspirational, and delays should be as minimal as possible, but might not be instant in the end. The actual threshold for acceptance will need to be decided while investigating possible improvements.
Tasks:

[X] Analyze what happens in the engine when collapsing node

Comments:
Attached is VisualVM profiling snapshot file that shows what happens when nodes in the default project get collapsed. Collapsing took `457ms` on my Mac.

304ms is compilation from which 285ms is parsing
80ms to analyzeModule & sendModuleUpdate
70ms taken by the actual execution of the Enso program

One attached image shows the time dominated by compilation. The other one shows the deserializing section. (jaroslavtulach - May 16, 2022)

**Jaroslav Tulach** reports a new **STANDUP** for yesterday (2022-05-16):
Progress: Collapsing nodes slowness is on the engine side dominated by parsing - evidence uploaded. Fun with benchmarks for https://github.com/enso-org/enso/pull/3440 - learning to debug them. At the end confirming AtomBenchmarks are unstable - evidence uploaded to https://www.pivotaltracker.com/n/projects/2539304/stories/182199750 It should be finished by 2022-07-31.
Next Day: Focus on summarizing dynamic drop-downs thoughts. Continue performance work. (Enso Bot - May 17, 2022)

	@dmitry_bushev pointed out that subsequent invocations of something in the JVM are more representative than the first one. How could I forget! As such I decided to repeat my experiment three times. Collapse nodes, undo, collapse nodes, undo, collapse nodes. This `.nps` file is from the 3rd collapsing. Results:
- It takes just `155ms` - e.g. everything gets faster compared to the first invocation
- `133ms` is related to compiling
   - `122ms` of that clearly belongs to the parser
   - `org.enso.compiler.Compiler.runImportsAndExportsResolution` compiler phase takes `11ms`
- the JSON serialization is not even visible - compared to the previous experiment - looks like the first invocation initialises some data structures and that takes time
- `10ms` took by `org.enso.compiler.PackageRepository$Default.getLoadedModules`
- actual execution of the program took `12ms`: `org.enso.interpreter.instrument.job.ProgramExecutionSupport$.runProgram()` (jaroslavtulach - May 17, 2022)

Following approach is being used to obtain the data:
```
ENSO_JVM_OPTS=-Dcom.sun.management.jmxremote.authenticate=false\ -Dcom.sun.management.jmxremote.ssl=false\ -Dcom.sun.management.jmxremote.port=9090  /Applications/Enso.app/Contents/MacOS/Enso
```
and then, from another terminal invoke following command to start collecting the data:
```
/Applications/Enso.app/Contents/Resources/enso/runtime/graalvm-ce-java11-21.1.0/Contents/Home/bin/java -jar /Applications/Enso.app/Contents/Resources/enso/runtime/graalvm-ce-java11-21.1.0/Contents/Home/lib/visualvm/platform/modules/org-netbeans-modules-sampler.jar 9090 output_sample.npss
```
when an experiment is done, press enter to obtain `output_sample.npss`. Analyze the file in `/Applications/Enso.app/Contents/Resources/enso/runtime/graalvm-ce-java11-21.1.0/Contents/Home/bin/jvisualvm`. (jaroslavtulach - May 17, 2022)

**Jaroslav Tulach** reports a new **STANDUP** for yesterday (2022-05-17):
Progress: Benchmarking to find a regression, talking about interop (Time, Date & Array) It should be finished by 2022-07-31.
Next Day: Write down dynamic drop-downs thoughts. Continue performance work. (Enso Bot - May 18, 2022)

Closing as will raise as more detailed tickets as needed.


Fix t.compile for Granite20b

What does this PR do?

Code change looks fine to me.

https://github.com/huggingface/optimum-habana/pull/1185


Integrate deployment of Kai into Konveyor Operator

We want to integrate Kai into Konveyor in an experimental feature gate manner.
Goals:

Konveyor Operator is able to deploy Kai onto the cluster
Deployment of Kai is disabled by default, we want a user to manually opt-in to deploying Kai
Kai images may be overridden so someone opting to deploy Kai may specific the image path/tag for the kai image to use
An exposed endpoint is available to reach the Kai service
Authentication/Authorization requirements comply with Konveyor Hub expectations, i.e. same auth flows that work to with the Hub protect the Kai service
The IDE plugin is able to specify and use the coordinates of the Kai endpoint Konveyor Hub is serving
The IDE plugin is able to authenticate as expected with a protected Kai endpoint reusing credentials from Konveyor

Related to https://github.com/konveyor/operator/pull/374

I'm working on the enhancement now, and https://github.com/konveyor/operator/pull/374 should be ready for review shortly


Update details.md

Pull Request

Description:

Related Issue:

Closes #XXXXX

Hello. I have made some updates to Update details.md file. If you think it is eligible to be merged, please accept it and merge.


fix upgrade org.apache.hadoop:hadoop-common to 3.2.4

What happened？
There are 7 security vulnerabilities found in org.apache.hadoop:hadoop-common 2.8.0

CVE-2017-15713
CVE-2018-8009
CVE-2022-25168
CVE-2022-26612
CVE-2022-25168
CVE-2018-11765
CVE-2017-7669

What did I do？
Upgrade org.apache.hadoop:hadoop-common from 2.8.0 to 3.2.4 for vulnerability fix
What did you expect to happen？
Ideally, no insecure libs should be used.
How can we automate the detection of these types of issues?
By using the GitHub Actions configurations provided by murphysec, we can conduct automatic code security checks in our CI pipeline.
The specification of the pull request
PR Specification from OSCS

run buildall

run buildall

This is only used in integration tests. Do we need to pick this code?


Upgrade to Stylelint v15

This change:

requires at least Stylelint v15
removes all deprecated rules (see https://stylelint.io/migration-guide/to-15#deprecated-stylistic-rules)
enables the new rule declaration-property-value-no-unknown: true (see https://stylelint.io/migration-guide/to-15#added-declaration-property-value-no-unknown-rule)

This prevents stylelint from screaming at us whenever we're doing a pnpm update in any of our projects related to the deprecated rules. However, as Stylelint itself writes in their migration guide: The rules were still working fine, they'll just be removed in v16.
I decided to remove all deprecated rules alltogether since the error output looks like this before the actual stylelint-related issues are actually listed, which is significantly way more noise than I prefer:

WDYT @apfelbox @21christiansc

I guess we'd need to evaluate something like stylelint-prettier (see https://stackoverflow.com/a/54757106/2690438) and see if it's sufficient.


memory leak in adapter node with unresolved promises

Describe the bug
Rendering a page that depends on a never-solving promise leaks memory.
Svelte seems to keep handlers around for the resolution of promises even after the page has been fully rendered and served to the client, preventing the js engine from freeing the associated memory.
Reproduction
https://github.com/lovasoa/sveltekit-memory-leak-bugreport
+page.svelte

{#await c.waitForMe()}

loading...

{:then x}

loaded {x}!

{:catch error}

{error.message}

{/await}

const.js
class MyClass {
    constructor() {
        this.x = neverSolve();
    }
    async waitForMe() {
        const x = await this.x;
        return x+1;
    }
}

function neverSolve() {
    return new Promise(()=>{});
}

export default new MyClass;

Logs
No response
System Info
System:
    OS: Linux 6.2 Ubuntu 22.04.3 LTS 22.04.3 LTS (Jammy Jellyfish)
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-11390H @ 3.40GHz
    Memory: 1.03 GB / 15.36 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 16.20.2 - /usr/bin/node
    Yarn: 1.22.19 - /usr/bin/yarn
    npm: 8.19.4 - /usr/bin/npm
    pnpm: 8.6.3 - /usr/bin/pnpm
  Browsers:
    Chrome: 116.0.5845.187
  npmPackages:
    svelte: ^4.0.5 => 4.2.0

Severity
annoyance

@dominikg , are you sure this belongs to sveltekit ? When I look at the code generated by svelte, it looks like it comes from there.

https://svelte.dev/repl/251d77ae3761440b95abde98df3a2d78?version=4.2.0
/* App.svelte generated by Svelte v4.2.0 */
import { create_ssr_component, escape, is_promise, noop } from "svelte/internal";

const App = create_ssr_component(($$result, $$props, $$bindings, slots) => {
	const p = new Promise(() => {

		});

	return `${(function (__value) {
		if (is_promise(__value)) {
			__value.then(null, noop);
			return ``;
		}

		return (function (x) {
			return ` ${escape(x)} `;
		})(__value);
	})(p)}`;
});

export default App;

I'm not an expert, but the __value.then(null, noop) seems problematic to me. Doesn't it prevent deallocating __value even long after the component has been rendered ?

If we don't do that, any rejecting promise that's unhandled will (in recent versions of Node) crash the whole server. I don't know that we have another option than to try to handle it in some way.

any updates here?


Chat - Line marked as unread disappears after a period of time when deleting a non-final message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open any report
Send about 4 message
Hover on last message and mark as unread
Hover on last message and delete message, Observe that the line mark unread is deleted as soon as the message disappears
Hover the first message and mark as unread
Hover on first message and delete message, Observed that the line mark unread is deleted after a period of time when the message disappears

Expected Result:
Line mark unread is always deleted as soon as the message disappears
Actual Result:
When deleting a non-final message, the line mark unread of that message disappears after a period of time
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/d7098a9c-da13-4d3f-8852-3d7c85194751
https://github.com/Expensify/App/assets/78819774/4e27f127-9698-4928-b2dd-4cc05caeb9d3
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691414998516269
View all open jobs on GitHub

reproduced, but this is pretty minor 🙃

Team discussion led to consensus that we're not really considering this a bug, and we're redesigning unread markers anyways: https://github.com/Expensify/App/issues/15212


terminal

how to change from powershell to cmd

see https://github.com/platformio/platformio-atom-ide-terminal/issues/554#issuecomment-400147777

@koladeore please close


Enable multipart files to support additional headers

New Pull Request Checklist

[x] I have read the Documentation
[x] I have searched for a similar pull request in the project and found none
[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
[x] I have added the required tests to prove the fix/feature I am adding
[x] I have updated the documentation (if necessary)
[x] I have run the tests and they pass

Pull Request Description
Enables adding additional headers (outside Content-Type) to files in multipart requests (akin to Golang's multipart support)

Unfortunately this repo doesn't seem to be maintained anymore but I'd love to merge your PR into our fork, (dio_http)[https://github.com/dart-tools/dio_http] .
Just added 2 small change requests
Edit: Also can you add the test commit to your main commit so you only have one commit? thanks

Hi, I faced the issue with the Interceptor while requesting APIs.
I hope to see if your package dio_http does catch the Interceptor issue with onRequest and onError callback functions.
I just solved it by using the http package to catch the issue that Interceptor does not catch 401 error with the onError function. And I think the way I did is not the right answer... it occurs too many callback functions..😭

@seunghwanly can you create an issue on https://github.com/dart-tools/dio_http with a code sample of what is not working with the interceptor?

@seunghwanly can you create an issue on https://github.com/dart-tools/dio_http with a code sample of what is not working with the interceptor?

I have adjusted dio_http and found it worked well.. thank you very much!! 😭
Would you mind what was the issue with the interceptor in dio package?? What was the problem..?

Edit: Also can you add the test commit to your main commit so you only have one commit? thanks

If you choose to merge, a squash n merge will do exactly that. That said, I have squashed under the dart-tools-squash branch on my PR, if you want to use that.


Update README.md

Hi, please watch the video and where you use the green "Code" button found on the repository and download the zip file. Doing this way not only will not work, but will expose your secret authentication token to the public.
Please be more cautious, thank you.


Thinking Sphinx and CircleCI

I'm having trouble getting specs that run Thinking Sphinx 3.2.0 to work on CircleCI. The first Sphinx spec passes, and all subsequent specs fail. All Sphinx specs are passing locally.
The app I'm using is running Rails 5.1, Ruby 2.3.1, RSpec 3.8.
My Sphinx support file for RSpec looks like this:
module SphinxHelpers
  def index
    ThinkingSphinx::Test.index
    # Wait for Sphinx to finish loading in the new index files.
    sleep 0.25 until index_finished?
  end

  def index_finished?
    Dir[Rails.root.join(ThinkingSphinx::Test.config.indices_location, '*.{new,tmp}*')].empty?
  end
end

RSpec.configure do |config|
  config.include SphinxHelpers, type: :feature

  config.before(:suite) do
    # Ensure sphinx directories exist for the test environment
    ThinkingSphinx::Test.init
    # Configure and start Sphinx, and automatically
    # stop Sphinx at the end of the test suite.
    ThinkingSphinx::Test.start_with_autostop
    ThinkingSphinx::Deltas.suspend!
  end

  config.after(:suite) do
    ThinkingSphinx::Test.stop
    ThinkingSphinx::Deltas.resume!
  end
end

Instead of a before(:each) setting for acceptance specs, I'm calling index in a before block on the specs where sphinx: true.
Example:
describe 'Product Search', type: :feature, sphinx: true do
  before { index }

  describe 'Product search from /products' do
    before(:each) do
      visit '/products'
      click_link 'Filter'
    end

    it 'finds all the products when no filters are selected', js: true do
      click_button 'Run Filters'
      expect(page).to have_content('2 products found for: All Products')
    end
  end
end

My current CircleCI config installs sphinxsearch:
      - run:
          name: Install sphinx dependencies
          command: sudo apt-get install sphinxsearch

And runs the tests through this command:
      - run:
          name: run tests
          command: |
            mkdir /tmp/test-results
            TEST_FILES="$(circleci tests glob "spec/**/*_spec.rb" | circleci tests split --split-by=timings)"

            bundle exec rspec --format progress $TEST_FILES

Are there any additional steps that need to be taken to get Thinking Sphinx to run on CircleCI?
Any help would be greatly appreciated!

Hi Kayla,
I've not used TS with CircleCI yet, so I'm not entirely sure what the cause of the problem might be. Can you elaborate on the failing tests - in what way are they failing? Can they not connect to Sphinx? Can they connect but aren't returning the correct results? Or is it some other issue?

Hi @pat
Thanks for your response!
The tests are failing in the same way they do without indexing (as if I commented out the before {index} block, so I don't think they're connecting to Sphinx at all. I am not getting any errors that specifically refer to Sphinx.
For example, the spec I referenced in my original comment fails with a message like this:
  1) Product search from /products finds all the products when no filters are selected
     Failure/Error: expect(page).to have_content('2 products found for: All Products')

expected to find text "2 products found for: All Products" in "All Products Search Results Filter 0 products found for: All Products There are no products"

Hmm. It sounds like Sphinx is running, and TS can talk to it, but the records aren't ending up in the database. Can you add :verbose => true as an argument to ThinkingSphinx::Test.index and see if that provides any clues? (The test output will get very noisy 😅).
And I'm guessing you've got use_transactional_fixtures set to false, given the tests work fine locally… 🤔 Feels all rather mysterious to me, hoping those verbose indexer output logs provide a clue or two!

What a great tip, I didn't know about that option on ThinkingSphinx::Test.index. And yes, use_transactional_fixtures is set to false.
Here's the output for one of the specs (they're all pretty similar):
Sphinx 2.2.11-id64-release (95ae9a6)
Copyright (c) 2001-2016, Andrew Aksyonoff
Copyright (c) 2008-2016, Sphinx Technologies Inc (http://sphinxsearch.com)

using config file '/home/circleci/repo/config/test.sphinx.conf'...
indexing index 'refinery_products_product_core'...
ERROR: index 'refinery_products_product_core': sql_fetch_row: Out of sort memory, consider increasing server sort buffer size.
total 0 docs, 0 bytes
total 0.004 sec, 0 bytes/sec, 0.00 docs/sec
indexing index 'refinery_recipes_recipe_core'...
collected 0 docs, 0.0 MB
total 0 docs, 0 bytes
total 0.002 sec, 0 bytes/sec, 0.00 docs/sec
indexing index 'refinery_community_post_core'...
collected 0 docs, 0.0 MB
total 0 docs, 0 bytes
total 0.002 sec, 0 bytes/sec, 0.00 docs/sec
indexing index 'desk_article_core'...
collected 0 docs, 0.0 MB
total 0 docs, 0 bytes
total 0.001 sec, 0 bytes/sec, 0.00 docs/sec
skipping non-plain index 'refinery_products_product'...
skipping non-plain index 'refinery_recipes_recipe'...
skipping non-plain index 'refinery_community_post'...
skipping non-plain index 'desk_article'...
total 3 reads, 0.000 sec, 0.0 kb/call avg, 0.0 msec/call avg
total 21 writes, 0.000 sec, 0.0 kb/call avg, 0.0 msec/call avg
rotating indices: successfully sent SIGHUP to searchd (pid=12516)

So perhaps it's something to do with ERROR: index 'refinery_products_product_core': sql_fetch_row: Out of sort memory, consider increasing server sort buffer size.? Do you see any clues?

Yeah, I think that error message is the cause as well.
From previous reports (1, 2) it looks like changing the database settings should help. Granted, I'm a little surprised this is cropping up given its in the test environment and I wouldn't expect much data, but perhaps the resources given to databases on CircleCI environments are super-limited? Or are you loading up a significant amount of records into the database for these tests?

@pat - Thanks for those links! I'll try adjusting the database settings in the ways those articles suggest. I'm a little surprised too, it could be something related to CircleCI database environments. Less than 5 records should be created for each test that uses sphinx.
Our database is already setting sort_buffer_size to 2750000 for tests (though I'm not sure when that setting was made or why)
I'll let you know how it goes! Thank you for your help!!

This issue's been dormant for a while, so I'm going to close it just to keep things tidy - but if there's further questions around this topic, still feel free to comment here, and we can re-open if required :)

Ah, it does seem to be very similar. I don't mind if it stays here.
And just to clarify: are you using Thinking Sphinx v3.2.0 or v5.0.0? Also: I know you said the stacktrace comes from the let, which is probably not the cause, but can you share the trace anyway, along with the error? There may be clues in there that help (because right now, I have no idea what the problem is! 😅)

Thank you again for your response

I am currently running thinking-sphinx (5.0.0)

locally  - RSpec

344 examples, 4 failures

on CI - I have series of different failures

12 failures that match the below Trackback

6  failures that match the below Trackback

failures that match the below Trackback

6  failures that match the below Trackback

Thanks for those details Erin. It looks like some further digging for details is required.
Firstly: those failing tests - is the missing content something that's driven by Sphinx? I'm presuming so. And so: can you confirm the data is being indexed reliably? The note about using ThinkingSphinx::Test.index :verbose => true in the early discussion in this thread could be a good place to start. It does mean that your test output will get quite noisy though - if there's a test that's always failing in CI, I would recommend creating a new branch, and having CI run just that branch (with the verbose indexing) to see if the issue can be found more directly.
Also, you mentioned some tests fail locally for you - is there any overlap between tests that fail on CI that are search related, and that also fail on your own machine?


Radio buttons validated even if checked value is disabled

I think current behavior for validating radio-buttons is wrong.

create two radio-buttons with same name
select one of them
disable it
try to validate a form

Expected result: form not valid due to selection of disabled element.
Current result: form is valid.
Problem is: not checked :disabled attribute for radio buttons.
I think that string:
this.findByName( element.name ).filter( ":checked" )
should be changed to this:
this.findByName( element.name ).filter( ":checked" ).not( ":disabled" )
in two places inside source file.
I have tested this change and now everything works in a right way.
I think this change should be applied into source code of this repo.

Wouldn't it just be best to use your own validator?

I like this validator and just pointed to its wrong (as I believe) behavior (and even how to improve it).
I cannot understand why validator should use values from disabled radio-buttons, when it not uses such values in case of text inputs.

Is there a reason you can't uncheck the radio button at the same time it's disabled? That would communicate to users more clearly that they can't select that option and need to pick another.


test: various enhancement to e2e UX

only call os.Exit in top level TestMain. This ensures proper cleanup
add usage flag to e2e. This enables easier discovery of arguments
Move GCP args to flags. The env var remains as a default but this allows easier discovery and usage of flags
Add parallel flag to e2e. The test.parallel flag defaults to GOMAXPROCS which is undesirable for expensive e2e tests where a cluster is created per thread. Override the test.parallel flag with our parallel flag.

Not sure why it's timing out, tried reproducing locally and didn't see this. going to retry
/retest


README TUTORIAL switch to master from stable

Description of the PR
In the readme when you click the tutorial it redirects you to stable documentation but we should be using master as stable is no longer in use
Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)
Changed from stable to master in the readme file
Semver Classification

[x] This PR only includes documentation or non-code changes.
[ ] This PR fixes a bug and does not change the (intended) framework interface.
[ ] This PR adds methods or properties to the framework interface.
[ ] This PR removes or renames methods or properties in the framework interface.

This change is wrong. Even though this library is in development mode because it has been written for d.js v12 since day one, and that stable was long since broken by d.js's instability; it's still correct for these links to point to stable because that's where stability will be when klasa v1.0.0 and d.js v12.0.0 are released as stable. We aren't going to change things for now in all of these random places to have to track down all of these places to revert these types of changes when things will inevitably change in the future.

Oh i see


Use swift-lmdb instead of copying LMDB source

This is tracked by rdar://139431575 as a part of https://github.com/swiftlang/vscode-swift/issues/562
Adds swift-lmdb as a dependency and removes the copied lmdb source so that IndexStoreDB uses the same version of lmdb as swift-docc. This enables SourceKit-LSP to use swift-docc as a dependency to fulfill documentation requests on behalf of the VS Code Swift extension.

@swift-ci please test

Please test with following PRs:
https://github.com/swiftlang/swift/pull/77624
@swift-ci please test

swiftlang/swift-lmdb#8
@swift-ci please test

Please test with following PRs:
https://github.com/swiftlang/swift/pull/77624
https://github.com/swiftlang/swift-lmdb/pull/8
@swift-ci please test Windows platform


[BUG] download-requirements.py script fails when executed in AlmaLinux docker container

Describe the bug
The script fails when executed in the almalinux 8.4/8.5 container (e.g. for offline mode).
2022-06-01T07:12:30.7047743Z [command]/usr/local/bin/docker run --entrypoint /bin/bash --rm -v /tmp/build/epi-cli:/shared almalinux:8.4 -c /usr/libexec/platform-python /shared/build/prepare_scripts_almalinux_8_4_x86_64/download-requirements.py /shared/build/offline_requirements_almalinux_8_4_x86_64 almalinux-8
2022-06-01T07:12:31.7780172Z 2022-06-01 07:12:31,772 [INFO]: Info summary:
2022-06-01T07:12:31.7787688Z --------------------------------------------------
2022-06-01T07:12:31.7790749Z OS Arch: x86_64
2022-06-01T07:12:31.7796031Z OS Type: almalinux-8
2022-06-01T07:12:31.7798841Z Script location: /shared/build/prepare_scripts_almalinux_8_4_x86_64
2022-06-01T07:12:31.7801213Z Directories used:
2022-06-01T07:12:31.7806338Z - files:              /shared/build/offline_requirements_almalinux_8_4_x86_64/files
2022-06-01T07:12:31.7809597Z - grafana dashboards: /shared/build/offline_requirements_almalinux_8_4_x86_64/grafana_dashboards
2022-06-01T07:12:31.7814046Z - images:             /shared/build/offline_requirements_almalinux_8_4_x86_64/images
2022-06-01T07:12:31.7816353Z - packages:           /shared/build/offline_requirements_almalinux_8_4_x86_64/packages
2022-06-01T07:12:31.7820107Z Repos backup file: /var/tmp/enabled-system-repos.tar
2022-06-01T07:12:31.7822611Z Log file location: /download-requirements.log
2022-06-01T07:12:31.7824779Z Retries count: 3
2022-06-01T07:12:31.7828366Z --------------------------------------------------
2022-06-01T07:12:31.8157247Z 2022-06-01 07:12:31,776 [INFO]: PyYAML not found, trying to install python3-pyyaml package...
2022-06-01T07:12:45.4626343Z 2022-06-01 07:12:45,461 [INFO]: Done.
2022-06-01T07:12:45.6691546Z 2022-06-01 07:12:45,667 [INFO]: Installing base packages...
2022-06-01T07:12:45.9192930Z 2022-06-01 07:12:45,917 [WARNING]: No such command: config-manager. Please use /usr/bin/dnf --help
2022-06-01T07:12:45.9194248Z It could be a DNF plugin command, try: "dnf install 'dnf-command(config-manager)'"
2022-06-01T07:12:45.9194641Z
2022-06-01T07:12:46.1441818Z 2022-06-01 07:12:46,140 [WARNING]: No such command: config-manager. Please use /usr/bin/dnf --help
2022-06-01T07:12:46.1443108Z It could be a DNF plugin command, try: "dnf install 'dnf-command(config-manager)'"
2022-06-01T07:12:46.1443545Z
2022-06-01T07:12:46.3888182Z 2022-06-01 07:12:46,385 [WARNING]: No such command: config-manager. Please use /usr/bin/dnf --help
2022-06-01T07:12:46.3896750Z It could be a DNF plugin command, try: "dnf install 'dnf-command(config-manager)'"
2022-06-01T07:12:46.3897316Z
2022-06-01T07:12:46.3898375Z 2022-06-01 07:12:46,385 [ERROR]: Retries count reached maximum, command: `dnf config-manager --dump-variables`
2022-06-01T07:12:48.1116348Z ##[error]The process '/usr/local/bin/docker' failed with exit code 1
2022-06-01T07:12:48.1173838Z ##[section]Finishing: download requirements

This bug was introduced in the following PR #3154.
How to reproduce
Steps to reproduce the behavior:

execute epicli prepare --os almalinux-8 --arch x86_64
docker run -it -v /path/to/shared/directory/:/shared almalinux:8.4 / almalinux:8.5
execute /usr/libexec/platform-python /shared/build/prepare_scripts_almalinux_8_x86_64/download-requirements.py /shared/build/offline_requirements_almalinux_8_x86_64 almalinux-8 in the container

Expected behavior
The script should execute without any issues.
Config files
Environment

Cloud provider: [AlmaLinux 8.4 docker container]
OS: [AlmaLinux 8.4, 8.5]

epicli version: [2.0.1dev]
Additional context

DoD checklist

Changelog

[ ] updated
[x] not needed

COMPONENTS.md

[ ] updated
[ ] not needed

Schema

[ ] updated
[ ] not needed

Backport tasks

[ ] created
[ ] not needed

Documentation

[ ] added
[ ] updated
[ ] not needed

[ ] Feature has automated tests
[ ] Automated tests passed (QA pipelines)

[ ] apply
[ ] upgrade
[ ] backup/restore

[ ] Idempotency tested
[ ] All conversations in PR resolved

Fixed in PR #3169


gauge server crashes in vs code

Expected behavior
gauge server should not crash
Actual behavior
getting gauge server crashed error.
Kindly find below attached screenshot.

Steps to reproduce

create a dotnet project gauge init dotnet
open in vs-code
gauge run specs
remove all existing implemented method from implementation file
remove scenarios and steps from spec file

Gauge version
Gauge version: 1.0.6.nightly-2019-08-01
Commit Hash: 2bc49db

Plugins
-------
dotnet (0.1.2.nightly-2019-08-12)

This issue has been verified and found fixed.
Tested version: Gauge version: 1.0.7.nightly-2019-08-29


Update copyright info

bump copyright to 2022

Where ?
Usually all files contain a copyright notice on top of the file. It says
// Copyright (c) 2019 - for information on the respective copyright owner
2019 -   means starts in 2019 and is ongoing.
@jseitter do you think this is not correct ?
Are there any files where the notice is different ?

found it at least in blechc --version
./blechc --version Blech Compiler 0.5.3+0  Copyright (C) 2019-2020 see blech-lang.org

I found it will be release in a minute.

Blech Compiler 0.7.2+0  Copyright (C) 2019-2022 see blech-lang.org

@jseitter you should update to the latest release it fixes several bugs.

@jseitter fixed. Thanks for the hint. Older version will not be updated.


Update step_03.ngdoc to clarify

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Updates documentation to clarify the controller naming convention for first time users of angular.js
What is the current behavior? (You can also link to an open issue here)
Not as clear as it could be
What is the new behavior (if this is a feature change)?
Improved documentation
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements

[X] The commit message follows our guidelines
[ ] Fix/Feature: Docs have been added/updated
[ ] Fix/Feature: Tests have been added; existing tests pass

Other information:
Due to me messing up my previous PR with a commit from a work account, i closed that PR and opened a new one.  Please reference comments about that at the link below
https://github.com/angular/angular.js/pull/16740#issuecomment-432678128

Merged :tada: Thx, @joej164 👍
(Note: While merging, I noticed the commit message did not follow our guidelines, so I tweaked it.)


Add common libs for yql plugin. Ydb git part.

Do you have any description or github issue for it?
Could you please link it?

https://github.com/ydb-platform/ydb/issues/9398


Cannot register pages in specified folder

Hello, I am unsure why this problem exists.
my code is:
searchTarget: Learn, Improve my wellbeing, Make progress, Manage my energy, Be mindful, Contribute, Share, Strive, Love my family, Love myself
searchType: dvField
datasetName: 👩🎓 Learning, 👩 Wellbeing, 📈 Progress, 💡 Energy, 🌸Mindfulness, 🎁 Contribute, 📬 Share, 💯 Strive, 💕 Family, 💜 Self-love
folder: + Day Notes
startDate: 2021-05-15
fitPanelWidth: true
line:
    title: Daily Questions Summary
    lineColor: magenta, red, orange, green, cyan, blue, purple, indigo, black, grey
    showLegend: true
    legendPosition: right
    yMax: 10

I am trying to achieve this so my data is read from a Day Note and translated across to the tracker.
The section in my day note looks like this:
- #❓/👩🎓 | Learn:: 1
- #❓/👩 | Improve my wellbeing::  2
- #❓/📈 | Make progress:: 3
- #❓/💡 | Manage my energy:: 4
- #❓/🌸 | Be mindful:: 4
- #❓/🎁 | Contribute:: 5
- #❓/📬 | Share:: 6
- #❓/💯 | Strive:: 7
- #❓/💕 | Love my family:: 7
- #❓/💜 | Love myself:: 8

I create pages in the specified day note folder, shown on line 7 in the Tracker Example, using the data from my Day Note just above, yet i receive this: https://gyazo.com/5dfea46876248dacb4ea349b5ae87357
Sorry for your time, I just have no idea what I'm doing wrong.

It's ok to ask me any question about the plugin.
I am not sure what exactly happen in your vault.
Maybe your notes does not exist in the folder?
or the date format of the note does not match the settings?
I copied your data above and made a test project here like this.

Please put the folder 'case' under your vault to see the result and do some comparison.

Will close this issue.
If you still have problem using the plugin, welcome to reopen this issue.


Cannot Compile On Windows

Hello,
I am a applied mathematician. I wanted to compile and give a try your interesting project but the compiling process fails on Windows due to Termion library. I am new to Rust and dont have any experience on it. Can somebody help me, please?

Same

There is a windows compatible version of Termion here:
https://gitlab.redox-os.org/Jezza/termion/-/tree/windows-support

I couldn't get termion to work, but this is only my second day with Rust.
Instead I switched the terminal to use crossterm:
https://github.com/bitRAKE/Noq/tree/windows


spice simulations not found

When running sky130/spice_models.py
ERROR, library file /home/jmatres/sky130/sky130/spice/sky130_fd_sc_hd.spice, section definition sky130_fd_sc_hd__a2111o_1 not f
ound

i think you may want to repackage the spice file from an installed version of the pdk (either thru https://anaconda.org/LiteX-Hub/open_pdks.sky130a or https://github.com/efabless/volare).
Some critical files are being added for the spice integration, see https://github.com/RTimothyEdwards/open_pdks/tree/master/sky130/custom/models

perfect Proppy! I'll do that
where can I find some examples on how you do layout parasitic extraction?
@simbilod

See example
https://gist.github.com/proppy/964fa4b9277c3baf9e731872bbad93e4
@smartalech

it would be great to add examples on spice simulations
https://github.com/mkghub/skywater130_fd_pr_models
@mkghub

Maybe we can add some demos from bigspicy
https://github.com/Vlsir/bigspicy
@growly


docs: Make runtime use qemu-lite in dev guide

Updated the developer guide to ensure when the developer builds the
runtime that they have it pre-configured to use qemu-lite, since this
matches the OBS packaged runtime behaviour.
Fixes #89.
Signed-off-by: James O. D. Hunt<EMAIL_ADDRESS>

Hi @egernst, @klynnrif - ptal.


NIFI-8135 allow CHOICE data types in conversion of Records to Java Maps

Summary
NIFI-8135 allow CHOICE data types in conversion of Records to Java Maps
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[x] Build completed using mvn clean install -P contrib-check

[x] JDK 17

Licensing

~[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy~
~[ ] New dependencies are documented in applicable LICENSE and NOTICE files~

Documentation

~[ ] Documentation formatting appears as expected in rendered files~

Is this meant for both 1.x and 2.x? Can you update the Jira with 1.latest and/or 2.latest to indicate where you'd like to see this merged? Please and thanks! I'll give it a try on main in the meantime :)

@mattyb149 certainly 2, 1 as well if it doesn't break things (I think it should be OK). Jira ticket updated


✨ [Feature request]: Revamp Playlist Page

Is your feature request related to a problem? Please describe.
Today the playlist page is full of cards. The current playlist page is cluttered with numerous cards that don't give an appealing look. Additionally, the plays are not sorted or categorized, causing a mix-up of all the plays.
Describe the solution you'd like.
We need to categorize the plays logically.
Describe alternatives you've considered.
T.B.D
Screenshot / Screenshare
No response
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

If this issue is still available,i would like to work on it,please assign it to me


removed the TODO file

do you need that TODO file? the TODO.md file stays where it is

You are correct, it's redundant. We can remove it


Fix minor issues

Hi! I found your project mentioned on the zio resources page (1). I had some minor problems in getting everything up and running. This changes should help the next person the get faster up to speed.
Thanks for providing this example project.

BTW... thanks a lot for the comments and PR!

Oh, didn't saw that you already merge this. I'll open an other PR to respond to your comment about defs in traits.


fitz throwing ModuleNotFoundError: No module named 'frontend'

The problem has to do with fitz and PyMuPdf. While PyMuPdf does have a fitz module, there's also another package called fitz that can cause this problem of import conflicts.
By completely removing both fitz and PyMuPdf and installing ONLY PyMuPdf we can solve it.


[Feat]: Redirect and scroll to Add profile markdown in GitHub.

What feature?
I have an idea when Add your profile link is clicked on website, it should automatically scroll to the Add your profile section.
This url will scroll to the section in markdown. https://github.com/shyamtawli/devFind#how-to-add-your-profile-

[X] I agree to follow this project's Code of Conduct

PR attached: #288

Nice Idea @07prajwal2000
I will review and merge the PR.


✏ Create show details screen skeleton loader

Resources 🔗
https://www.npmjs.com/package/react-loading-skeleton

This might also be a cood time to consolidate these components in a placeholder directory.

Closed by #499


webdriver path error

i a using linux subsystem windows 10 and trying to install eagle eye. As soon i launch .py, there comes up the error. If anyone can help,
==> Enter the persons name to find on FB: xxxx
==> How many jitters, higher is better [max 100]: 90
==> Opening Webdriver
C:/Users/xxxx/Documents/linux/EagleEye/geckodriver/geckodriver.exe does not exist - install a webdriver
although the geckodriver.exe is in the path place. pleassse help

https://askubuntu.com/questions/870530/how-to-install-geckodriver-in-ubuntu


Take release id and tag name from client_payload

This PR adds an additional check to allow the repository_dispatch event to call this action for migration.
From the repository_dispatch event, it takes release_id and tag_name from the client_payload object which is then passed to the publish API.
Additionally, it also changes the error messaging to showing appropriate error message returned from the server.

released version is 0.5.0


[ENHANCEMENT] Kubernetes-native Elemental CloudInit objects

Stories:

[x] https://github.com/harvester/harvester/issues/4709
[x] https://github.com/harvester/harvester/issues/3902
[x] https://github.com/harvester/harvester/issues/4710
[x] https://github.com/harvester/harvester/issues/4708

@connorkuehl
Based around prior validation and additionally that:

https://github.com/harvester/harvester/issues/5240

Will be in 1.4.0 milestone.
And that manual test docs have been merged in:

https://github.com/harvester/tests/pull/1100

And that:

https://github.com/harvester/harvester/issues/5110
has been created to track.

I'll go ahead and close this out :smile: :+1:
Thanks for the awesome feature and docs!


Publish Download and Citations Data

We've got some great data that we should definitely share: download numbers for almost all of the larger packages (except Julia) listed on OpenSustain.tech. Here is a very prototypical playground for playing with the dataset. Just open the notebook in colab and you will see first ideas interactive plots that we could use for the blog post.
https://github.com/protontypes/osta/blob/main/packages_insights.ipynb

As discussed in the core meeting, it makes sense to start with a blog post and then work on a paper that we then publish together (ideally with peer review).
We also have citations for many projects, but the data here is often not valid. Maybe we are also able to get this numbers right. At the moment I see 2 problems with the citations numbers:

We do not get citations numbers via OpenAlex from DOIs that are created via Zenodo. (A lot of Open Source projects have a DOI from Zenodo)
Just because an DOI is linked in the README does not mean that the people of the open source project are affiliated with the paper that is been referenced. A possible solution for this problem is mentioned here: https://github.com/protontypes/open-sustainable-technology/issues/819

I started an Overleaf, and then spent ten minutes fiddling with the template before I remembered it really doesn't matter. What matters is the ability, at this point, to get stuff down and to move things around and to just write. We can edit and format later. So, I set up a Google Doc.
https://docs.google.com/document/d/12jn8Xfhkf6IMUa_dhkIO9Qw1VPU0F_pkUgKBQuJ2WkE/edit?usp=sharing
More coming. Feel free to jump in at any point.

There is another indicator that we should investigate to measure the distribution/usage of an open source project: The number of "external" issues opened per time interval by people who are not the maintainer or main contributor of the project. It should be easy to derive such an indicator from the given data.


test(stepper): Fix stepper if to get 100% branch coverage.

Coverage remained the same at 100.0% when pulling 9336961de6270cc328a114a95cde10675c401b22 on dev into d3e0eae2d3736f80488c36601f751e6fef71a738 on master.


Minimap: Settings for background and text opacity

Recreating PR #61021 (PR #61021 cannot be reopened because master has been renamed to main in the meantime)

Continued in https://github.com/microsoft/vscode/pull/132681


Request: GET /api/tenants

This endpoint should return all tenants for the currently logged in landlord

 Get All tenants for a given landlord


[Feature Addition]: Web App for Data Analytics Salary Prediction

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : [Feature Addition]: Web App for Data Analytics Salary Prediction
:red_circle: Aim : The aim is to create a web app for the Data Analytics Salary Prediction project. Use the best existing model in the project folder. Follow the Web App README template for the same.
:red_circle: Dataset : N/A
:red_circle: Approach : Try to create a Flask/Streamlit app for the existing project.
🔴 Reference Project Folder: Brain Tumor Detection

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Participant ID (If not, then put NA) :
Approach for this Project :
What is your participant role? (Mention the Open Source Program name. Eg. HRSoC, GSSoC, GSOC etc.)

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Hey,
Can You Please Assign this issue under SSOC. 2024 Season 3
Akshaykumar
Github:- https://github.com/MRMORNINGSTAR2233
Participation ID:- NA
I am good at flask and can make ml web apps using the best model present and if not this i am good at frontend and make good ml api's that i can integrate this in the frontend make the apps.
can u assign me this @abhisheks008?
Thanks.
Participation Role:- SSOC Season 3

Contributions will start counting from June 1.

Hey,
Can You Please Assign this issue under SSOC. 2024 Season 3
Akshaykumar
Github:- https://github.com/MRMORNINGSTAR2233
Participation ID:- NA
I am good at flask and can make ml web apps using the best model present and if not this i am good at frontend and make good ml api's that i can integrate this in the frontend make the apps.
can u assign me this @abhisheks008?
Thanks.
Participation Role:- SSOC Season 3

Are you planning to implement a Streamlit app or Flask app?
@MRMORNINGSTAR2233

Flask app

Cool go ahead. @MRMORNINGSTAR2233

Hey @abhisheks008 i am done with this within few days ill push it into this bcz of exams it got delayed.

Hey @abhisheks008 i am done with this within few days ill push it into this bcz of exams it got delayed.

No issues.


Review of SOP for Data Quality Approaches within CHoRUS

This PR proposes to add two SOP documents to the validated SOP repository:

Evaluating-Quality-At-Sites.mdx
Evaluating-Quality-Centrally.mdx

These two documents represent the two core approaches to evaluating and updating data extracts based on their quality and characterization within CHoRUS. Sites have been asked to execute the standard OHDSI quality and characterization packages locally, and the Standards Team has held multiple office hour sessions describing these processes and how to execute them effectively. Moreover, the cloud team is busy ingesting data extracts delivered to the MGH central cloud; in addition to producing a processed dataset, these ingestion processes will produce a structured report to return to data sites.

Jared, this is great!
Some suggestions.
For the Purpose section:
Maybe add the sentence: "This SOP defines the multistep process used in CHoRUS Bridge2AI to ensure that released versions of the data are of sufficient accuracy, completeness, and consistency for the development of AI/ML algorithms that help improve recovery from acute illness."
A figure we might use to define the main elements of the process

The steps you describe could refer to their place in the figure.
For an Audience section:
This SOP is meant to inform anyone who seeks to understand the process used to assure the quality of the CHoRUS Bridge2AI dataset and to guide anyone involved in that process about the required resources and activities.
For a Scope section
This SOP is exclusively focused on a high-level description of the data quality process and related activities. Details are provided by links to other documents. It is not focused on the Relevance of the data (prioritizing data elements to include in the dataset) or with assessing coverage of prioritized data elements. But there is overlap between Relevance and the relevance of the data and the data feedback report does include a combination of data quality and coverage of prioritized data elements.

@AEW0330 - implemented your suggestions in the documents in this commit.

Review from Hanieh:

I’m not sure if you are planning to build out a check catalog that you can put in the README, where you can list specific checks and annotate with some metadata. For example, what are the completeness checks and their applications? Which phenotypes will you be checking for, and will that change over time? I know that you have not yet built out the full program and this comment may be a little premature, but I have found that keeping a catalog of checks and assigning unique names to them really facilitates effective communication with network partners and keeping track of the evolution of the network. There are some references in the text, but not sure if they are placeholders. For example, “Format similar to report proposed by Claire, with drilldown on failed checks and additional context.” --- Is this specific to DQ Dashboard or another set of checks?

Great question. We are indeed planning to enhance the representation of DQD checks to include elements like check severity and guidelines (that now exist in the DQD reference website). As we grow, we will plan to add CHoRUS specific checks with names and motivations. I presented some preliminary checks at the Network Data Quality Working Group back in the spring and plan to iterate on those further as I have time.

I did not see any reference or documentation about how thresholds will be set for sites, either individually or as a network, though I may have missed it. The thing that makes data quality in EHR data complex is that many times issues can not be fixed with better ETL, and sometimes the problems reflect a characteristic of the source data. It makes setting thresholds a little challenging. I have also found that running a network DQ program requires adjusting thresholds to tailor to the institution. For example, if a participating institution only has outpatient data, any type of visit distributions requiring inpatient visits will not apply to them. Similarly, community hospitals and academic hospitals may represent data differently and serve disparate populations, which will have implications for phenotypes, follow up, and coding practices at the institutions. If the goal of the DQ reports is to stimulate improvements in data rather than characterizing the source, then more targeted approaches for thresholding will need to be described. It will also be important to determine whether the thresholds will be data driven (e.g., computing outliers based on all-site data) or pre-specified based on standards for the network.

I see it as a combination of both elements. I think for certain checks we will establish consortium-wide thresholds. For instance, we will implement a check to see that datetime values are being used across all tables in OMOP. Datetimes are not required by the model, but are essential for our critical care data context. Even if sites do not have explicit times associated with events, we expect them to fill these fields with a default time, such that no datetime fields are NULL that have an associated date field. Conversely, we will also check how many rows of data include this 'default' time in a datetime column, and we will set site-specific thresholds for this check because we expect the availability of precise time information to vary between sites.

As the DQ program matures, you may want to consider documenting the checks, responses, and characteristics of the data. Data quality metadata :) This is not as important when you are starting, but as more people use the data for research, being able to represent DQ issues may be helpful.

Absolutely. We're storing the entire history of the centrally executed checks in an accessible way so we can retrieve and review them in the future, and we expect to provide data characterization reports with overviews of the data quality history and associated metadata when we provision data sets for downstream analytics. The quality history and associated improvements are crucial to any publication-ready analytic workflows.

Finally, it would be helpful to know who the reports are targeted for --- are you building out reports primarily for ETL analysts, research investigators, network leaders, etc? Different audiences have their own set of requirements and nuances, which will be important to take into account both in presentation and in substance.

Great point. Thus far, we have designed the report to have sections with different audiences. The high-level numbers related to data characteristics are relevant for decision makers, while the more granular details about cohort counts or performance on specific data quality checks are important for ETL engineers. I will plan to update the report with flags per section for intended audience and section purpose :)


golang part of plugin incorrect handle empty (rows=0) results from Clickhouse

need to research howto return "NODATA" instead of "ERROR" when we got empty result from ClickHouse

@bmanth60 JFYI

@Slach I read the PR, but I don't quite understand the fix, is it that there is a nullable and low cardinality type?

the main goal of fix
for most corner cases shall return multiple data frames instead of just one data.Frame
each data.Frame for each exists time series with two fields (time, value)
String fields and complex type fields used as labels
Array(Tuple( which return after apply $macro converts to multiple data.Frames use first field as label, second field as value
also, SQL queries can return nullable values and DateTime64, so I add support for this corner cases
LowCardinality also supported for properly parsing label values
Also, if we return SQL result without a timestamp field
We just return one data.Frame which contains all fields

Interesting, thanks!


(BOLT-486) Plans accept targets via puppetdb

When executing a plan, allow targets to be built from PDB query.

CLA signed by all contributors.


feat: Add EduBlocks support

Mostly based off of #320 but updated for the new EduBlocks.
Adds support for the Machine Learning For Kids EduBlocks extension as an option when selecting "Make" within a project.
Not localized in other languages as not sure how this works.

Awesome - thank you @dalelane!
Let me know if you need anything else.


Add Like Button / Twitter Heart Animation

It would be nice if this library was added. it mimics the Twitter heart animation that's used for liking https://github.com/jd-alexander/LikeButton

Wow awesome
just what I was searching for :+1:

Awesome glad you like it!

can i add it to simple button?

Not sure. Never tried it.


Incorrect description of CompanyName parameter

CompanyName parameter description is incorrect (copied from Import-NAVData)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d9ee4af-c9b5-97bd-2a20-6dd91f781ccb
Version Independent ID: d828c63c-2a4a-9791-96d9-3aa4e0a594d4
Content: Export-NAVData (Microsoft.Dynamics.Nav.Management)
Content Source: businesscentral-ps/Microsoft.Dynamics.Nav.Management/Export-NAVData.md

Thanks for the feedback! The article has been fixed and an update will be published soon.


Some Function Arguments on new lines are listed as not covered

When I have a particularly long function call in Lua I usually split it into multiple lines like this:
print(
    "thing 1",
    "thing 2"
)

When I run the code with luacov some function arguments are shown as no coverage even if the function was called. I have created this simple example.
local function print_things()
    print(
        {1,2},
        "hello",
        45
    )
end

print_things()

When I run this using lua -lluacov test.lua it creates this result:
   local function print_things()
 2     print(
 1         {1,2},
 1         "hello",
           45
 1     )
   end

 1 print_things()

This seems OK except that the line with just 45 has no coverage data.
When I run this using busted with busted -c test.lua it creates this result:
   local function print_things()
 3     print(
*0         {1,2},
 1         "hello",
           45
 1     )
   end

 2 print_things()

This is more of a problem since the {1,2}, line is showing as not covered when it was clearly called.
I am using:

busted 2.0.rc12-1
lucov 0.12.0-1
lua 5.1.2

The first part is working as intended, the bytecode for loading constant 45 is attached to the next line by Lua compiler, and luacov correctly marks the line as empty. The second one is an issue, but I can't reproduce it. Are you sure busted uses the same lua/luacov version?

There is one thing I had forgotten. I compiled LuaRocks to use LuaJIT so that any rocks installed also use LuaJIT.
I configured LuaRocks using:
./configure --lua-suffix=jit --with-lua=/usr

When running without LuaJIT the second problem does not occur.

This should be easy to verify by adding print(package.loaded["luacov.runner"].version, jit and jit.version or _VERSION) to the test script, it should print luacov and lua versions.

The output is:
0.12.0  LuaJIT 2.0.1

That's printed when running the script with busted? What about just lua with -lluacov?

Yes, that was the output with busted. With lua -lluacov I get
0.12.0  Lua 5.1

I see, LuaJIT must be optimizing the load of a constant array there. I don't think luacov can reliably detect this, can you try installing cluacov? Just run luarocks install cluacov and the run luacov the same way, it will pick it up automatically.

When I run luacov with cluacov installed luacov always seg faults.

Alright. Sorry about that. I can't reproduce it though. Could you open an issue at cluacov repo? I'll just need to know your OS and maybe compiler version and I'll probably debug it.

OK, I will work on a bug report for cluacov. Thanks for your help.

Closing this as cluacov handles this issue for me. Please open an issue at cluacov repo if you still have the segfault problem.


HTTP Basic credentials Extraction

Description:
ClientSecretBasicAuthenticationConverter class extracts HTTP Basic credentials from HTTP Header Authorization and URL decodes them after having decode authorization header from Base64. URL decoding is not necessary and causes problems with special characters (e.g. %).
Description of the bug:
ClientSecretBasicAuthenticationConverter class at extraction phase decodes authorization header from Base64 and then decodes decoded credentials from URL (using URL decoder). The second step is not necessary and causes problem with special characters (e.g. %). Spring security libraries do not URL decode client credentials that are being ectracted from HTTP Header Authorization. Spring security libraries only decode authorization header from Base64.
Reproduce:
Use for password at client credentials percent sign, e.g. password<EMAIL_ADDRESS>Expected behavior:
ClientSecretBasicAuthenticationConverter class should not URL decode decoded credentials. Following lines at the previous mentioned class should be either removed or enabled ad hoc (e.g. flag)
	try {
		clientID = URLDecoder.decode(credentials[0], StandardCharsets.UTF_8.name());
		clientSecret = URLDecoder.decode(credentials[1], StandardCharsets.UTF_8.name());
	} catch (Exception ex) {
		throw new OAuth2AuthenticationException(new OAuth2Error(OAuth2ErrorCodes.INVALID_REQUEST), ex);
	}

@periplanomenos Please review Section 2.3.1.  Client Password:

Clients in possession of a client password MAY use the HTTP Basic
authentication scheme as defined in [RFC2617] to authenticate with
the authorization server.  The client identifier is encoded using the
"application/x-www-form-urlencoded" encoding algorithm per
Appendix B, and the encoded value is used as the username; the client
password is encoded using the same algorithm and used as the
password.  The authorization server MUST support the HTTP Basic
authentication scheme for authenticating clients that were issued a
client password.

I'll close this since the current implementation is implemented to spec.


tf.range is not equivalent to np.arange

tensorflow-gpu==1.12.3
The docs state about tf.range:

Equivalent to np.arange

But:
import tensorflow as tf
import numpy as np
tf.enable_eager_execution()

def main():

    s = tf.constant(np.random.rand(20))
    rate = 2.5
    s1 = np.arange(0, tf.shape(s)[0], rate)
    s2 = tf.range(0, tf.shape(s)[0], rate).numpy()

    print(s1)
    print(s2)

if __name__ == '__main__':
    main()

Outputs:
[ 0.   2.5  5.   7.5 10.  12.5 15.  17.5 20.  22.5]
[ 0.   2.5  5.   7.5 10.  12.5 15.  17.5]

@stefan-falk I tried with TF 2.0.0 and the values seem to match. Can you update the TF (1.12.3 is a little outdated) to latest 2.0.0?

@stefan-falk ,
Hi, you can also try 1.15rc3 version. It works fine.Thanks!

@stefan-falk ,
Hi, any update on the issue ?Thanks!

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!

@oanush Sorry for responding so late.I am stuck with 1.12 - I am sure it works with later versions but the example above was run with 1.12. Looking forward for 1.12.4 :P


Use JCommander 1.27 consistently

Well, even 1.27 is three years old. The current version is 1.48 :)


Add exceptions to RBC script for Linux VM

elementnotvisibleexception in selenium

Don't use selenium to grab data anymore. Issue is not relevant


Fix ValueError in dump_bin.py by excluding 'symbol' field from conversion

Fixes #1852
Modify scripts/dump_bin.py to handle the conversion of string 'SH600000' to float correctly.

Exclude 'symbol' field from conversion:

Modify _data_to_bin method to exclude the 'symbol' field from conversion to float.
Add a check to ensure 'symbol' field is not included in the fields to be converted.

Update normalize_data method:

Ensure normalize_data method in scripts/data_collector/baostock_5min/collector.py processes data correctly without converting 'symbol' to float.
Update normalize_baostock method to retain 'symbol' field as a string.

Documentation update:

Emphasize the importance of normalize_data before using dump_bin.py in scripts/data_collector/baostock_5min/README.md.

@microsoft-github-policy-service agree

We would like to understand what the purpose of this change is, I understand that if the data is normalized before dump_bin, the symbol field will not appear.


fix(pulse-plugin): added translations for Pulse plugin (#1562)

Pull Request Test Coverage Report for Build 1702

12 of 26 (46.15%)  changed or added relevant lines in 8 files are covered.
4 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.006%) to 53.521%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/app/pulse/charts/pulse-disk-chart/pulse-disk-chart.component.ts
0
1
0.0%

src/app/pulse/charts/pulse-network-chart/pulse-network-chart.component.ts
0
1
0.0%

src/app/pulse/charts/pulse-cpu-ram-chart/pulse-cpu-ram-chart.component.ts
0
2
0.0%

src/app/pulse/vm-pulse/vm-pulse.component.ts
0
3
0.0%

src/app/pulse/units-utils.ts
2
9
22.22%

Files with Coverage Reduction
New Missed Lines
%

src/app/pulse/units-utils.ts
1
12.82%

src/app/pulse/charts/pulse-network-chart/pulse-network-chart.component.ts
1
22.03%

src/app/pulse/charts/pulse-disk-chart/pulse-disk-chart.component.ts
1
23.73%

src/app/pulse/charts/pulse-cpu-ram-chart/pulse-cpu-ram-chart.component.ts
1
20.93%

Totals

Change from base Build 1701:
0.006%

Covered Lines:
9423

Relevant Lines:
15625

💛  - Coveralls

run tests


[Question] Does the current edge network CNI plugin only support flannel?

Does the current edge network CNI plugin only support flannel?

@slm940208 Thank you for raising issue. in fact, all of cni network solutions(like flannel, calico) are supported in OpenYurt because no modification has been made to Kubernetes.
but use cni network solution directly in cloud-edge scenario, when network connection between cloud and edge offline, if cni network plugin restart for some reason(like node reboot), the edge network settings maybe can not recover because network plugin can not get metadata(like service, endpoints) from cloud.

@slm940208 and for flannel, we have made some optimization in order to solving the above problems. you can dive into the detail design here: https://openyurt.io/docs/user-manuals/network/edge-pod-network/

@rambohe-ch Thank you for your reply. The current community only gives Flannel's modification scheme？

Actually, in the aspect of edge-network, I think we can support calico through raven, see openyurtio/raven#38.
We mention #857 here, because we're checking if calico can run as it is when cloud-edge network breaks.