Enable mTLS for downstream clients

Type of change

Enhancement / new feature

Description
This PR is to introduce functionality so that configuration can be set to make downstream clients require authentication when connecting to Kroxylicious
Additional Context
Current functionality will only set up one way TLS, and from a security standpoint using Kroxylicious in our environments we require mTLS. The downstream SSL builder only loads the key details from the clusters tls configuration and ignores the trust. I've made changes to load the trust if provided and set the client authentication to required in this instance. I make the assumption that if someone is providing the trust configuration for downstream then they must require mTLS
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[x] Write tests
[ ] Update documentation
[x] Make sure all unit/integration tests pass
[ ] Make sure all Sonarcloud warnings are addressed or are justifiably ignored.
[ ] If applicable to the change, trigger the system test suite.  Make sure tests pass.
[ ] If applicable to the change, trigger the performance test suite. Ensure that any degradations to performance numbers are understood and justified.
[ ] Ensure the PR references relevant issue(s) so they are closed on merging.
[ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

NOTE:  You must be a member of @kroxylicious/developers to trigger the system test and performance test suites.  If you are not part of this group, comment on the PR requesting a trigger, tagging @kroxylicious/developers.

This is to address issue https://github.com/kroxylicious/kroxylicious/issues/1561, and also may influence https://github.com/kroxylicious/kroxylicious/issues/1577.

@alanrobinson-dwp thank you for opening the PR.

I make the assumption that if someone is providing the trust configuration for downstream then they must require mTLS

I wonder about this.  Kafka itself defaults to none and lets the user configure required or requested.  I think it would be least surprise if Kroxylicious adopted the same behaviour and used the same defaulting.  This would require a new piece of TLS config (probably clientAuth).  OTOH you could argue from a secure by default standpoint, requested ought to be default, with configuration relaxing it down.
Separately, I think the change should be supported by integration test(s) - probably new tests in io.kroxylicious.proxy.TlsIT would be appropriate.

Hi Keith, thanks for comments and taking a look.
We'd had the same discussions with regards to how the brokers do it and possibly having an extra variable of clientAuth in either of Tls or Truststore record types then mapping up "required" or "requested" with the ClientAuth ENUM - NONE, OPTIONAL, REQUIRE; values but we erred on the lighter touch.
Do you have a preference with regards to your security standpoint? From our viewpoint, secure by default fits our requirements better, but we're happy to go with what suits with Kroxy better.
For the setting, we could add a clientAuth into Tls.java? Perhaps a boolean requiresAuth that will return REQUIRE if trust is != null and clientAuth is not set?

Thanks for the pr @alanrobinson-dwp!
I think secure by default is a good posture, but I'm not entirely sure it a stance a proxy can take unilaterally as one of our goals is to be transparent to clients & brokers (which I take to mean works by default).
I don't know enough about m_tls and its general usage to have a strong view. I do however think defaulting to REQUIRED when a TrustStore is present along with an escape hatch to control the clientTrust property when needed.

For the setting, we could add a clientAuth into Tls.java? Perhaps a boolean requiresAuth that will return REQUIRE if trust is != null and clientAuth is not set?

I'd err towards just exposing the clientTrust enum rather than trying to infer what todo based on other fields. I think thats easier for users to reason about and is closer to how Kafka does it (be that right or wrong) and easier to validate for example user said REQUIRED but didn't provide a trust store - cluster doesn't load. However I'm happy to take direction from others with more experience in dealing with TLS.

Hi @SamBarker @k-wall
We had lots of philosophical conversations yesterday in the office about best way to implement this. I agree it'd be tidier to map config directly to the ClientAuth Enum. I do wonder what Kafka does behind the scenes.
We landed though on following exactly as broker does it (https://kafka.apache.org/090/documentation.html) with "none" being default. Our thinking being that if a team were used to setting "required" or "requested" when speaking with brokers the client properties wouldn't change much when switching to Kroxylicious.
The new way has been added to PR if you wouldn't mind giving some feedback? I'll squash and tidy commits before going any further.
I'm currently getting my head around the TlsIT.java class to look into covering this with an IT test. I've not used these Fluent config builder classes before so just familiarising with that before writing test.
Thanks
Alan

Thanks @alanrobinson-dwp I'll review in my morning!
Building a proxy is a remarkably philosophical exercise. I'm glad to hear that it sounds like you've landed in a similar place to my thinking.

build is failing with
Error:  Failed to execute goal com.mycila:license-maven-plugin:4.6:check (license-check) on project kroxylicious-api: Some files do not have the expected license header. Run license:format to update them. -> [Help 1]

Assuming your branch is up to date with main running the full maven build locally will resolve that.

I've opened https://github.com/alanrobinson-dwp/kroxylicious/pull/1/files 😬
It started off fleshing out the tests in https://github.com/alanrobinson-dwp/kroxylicious/pull/1/commits/a39cbf15e61613951c2daa6fa915af3d20b64b76 which worked on the code here, and meant it was safe to go refactoring.
As @k-wall mentioned we don't want to leek the Netty API into our API, and while your proposal stopped the explicit linkage it didn't actually break the connection. It just coupled us by value. So I changed that by performing the mapping in code that actually knows about Netty.
With that in place I went a bit further and said that we should validate that the configuration makes sense. There is no point in users configuring clientAuth: required and then not supplying a trustStore to validate certificates.
I think the changes ended up being more invasive than you were trying for and certainly more invasive than I intended to be to your work but I think this is what we need. Would love to get everyones thoughts on that PR (merge into this one if your happy with them).

I notice that there is no existing documentation covering how to configure trust on the downstream side.  Let's fix that on a separate PR.  It can document the new configuration introduced by this PR too.  Happy to see this PR merged without a doc update.

Hi @k-wall, thanks for all your comments. I've done a couple of the quicker fixes (Tls redundant classes and simplified the switch). I'll let @SamBarker take a look at the comments around his additions.
I've noticed the commit history is a little messy now, how does this work on the PRs, are they all squashed on merge or do you want me to tidy them up once we're finished before any merge takes place?
I'm still a little stuck on the TlsIT tests and can't see the withClientAuth or withNewClientAuth methods I was expecting to be generated on the Tls record class. Any ideas why this might not be happening?
I've tested the current PR code set on our environments too and looking good so far.
Errors with Caused by: com.fasterxml.jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type io.kroxylicious.proxy.config.tls.TlsClientAuth from String "required": not one of the values accepted for Enum class: [NONE, REQUESTED, REQUIRED] when set and not an expected value.
Also my client can't connect when REQUIRED if it hasn't set it's ssl.keystore.location/password etc

Hi @k-wall, thanks for all your comments. I've done a couple of the quicker fixes (Tls redundant classes and simplified the switch). I'll let @SamBarker take a look at the comments around his additions.
I've noticed the commit history is a little messy now, how does this work on the PRs, are they all squashed on merge or do you want me to tidy them up once we're finished before any merge takes place?

We haven't really a got fixed policy.
When I am working on a PR I tend to squash together commits that fix up trivial stuff, but leave commits separate  once I start working answering review comments (to keep it easy for reviewers to see how I've addressed their comments).
When it comes to merging a PR back to main, I tend to squash down to single commit unless there are significant commits from separate authors.
I think your PR history is okay as it is.

I'm still a little stuck on the TlsIT tests and can't see the withClientAuth or withNewClientAuth methods I was expecting to be generated on the Tls record class. Any ideas why this might not be happening?

Did you see https://github.com/alanrobinson-dwp/kroxylicious/pull/2

I've tested the current PR code set on our environments too and looking good so far.
Errors with Caused by: com.fasterxml.jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type io.kroxylicious.proxy.config.tls.TlsClientAuth from String "required": not one of the values accepted for Enum class: [NONE, REQUESTED, REQUIRED] when set and not an expected value.
Also my client can't connect when REQUIRED if it hasn't set it's ssl.keystore.location/password etc

Errors with Caused by: com.fasterxml.jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type io.kroxylicious.proxy.config.tls.TlsClientAuth from String "required": not one of the values accepted for Enum class: [NONE, REQUESTED, REQUIRED] when set and not an expected value.

We need to enable MapperFeature.ACCEPT_CASE_INSENSITIVE_ENUMS to fix that, personally I think thats a good idea.

Also my client can't connect when REQUIRED if it hasn't set it's ssl.keystore.location/password etc

Thats we are trying to achieve isn't it? Or are do you use platform trust for validating client certs?

I've noticed the commit history is a little messy now, how does this work on the PRs, are they all squashed on merge or do you want me to tidy them up once we're finished before any merge takes place?

I don't generally worry about the git history as an artefact in its own right.  I have stepped through the history of a class or block in IntelliJ to work out what the motivation for a change was, but even then I'm generally focused on the delta rather than the history itself.
Personally I think squash merge looses a lot of detail (that is arguably noise) so I tend to just merge as is but I'm very aware I'm in a minority around this stuff. 😉

Thats we are trying to achieve isn't it? Or are do you use platform trust for validating client certs?

Exactly yeah, so working fine for us now with our requirements. We'd had a pretty rigorous IT Healthcheck on the lead up to Go Live and this was flagged after we were testing connections with different certificates using different CAs between our Client and Proxy. This ticks a big box for us!

@alanrobinson-dwp hopefully we are almost there on this PR.

Could you add an entry to the CHANGELOG.md
Add yourself to the CONTRIBUTORS.md file if you wish.

I'll do one more review once that is done and hopefully merge it straight after.

Thanks @k-wall I've added on change details and rebased. I'd feel a bit of a fraud putting my name on the contributors at the moment haha!
There is another ticket on our board for getting involved with a ciphers change, so maybes after that!

thanks for the contribution @alanrobinson-dwp

Thanks @k-wall I've added on change details and rebased. I'd feel a bit of a fraud putting my name on the contributors at the moment haha!

I appreciate the modesty @alanrobinson-dwp but the change is yours as far as GitHub and I are concerned. I'm very glad you got this organised.

Thanks @k-wall I've added on change details and rebased. I'd feel a bit of a fraud putting my name on the contributors at the moment haha!

I appreciate the modesty @alanrobinson-dwp but the change is yours as far as GitHub and I are concerned. I'm very glad you got this organised.

Absolutely, I feel exactly the same way.


How to Implement the Conv1DTranspose？

You could follow the method here : https://stackoverflow.com/questions/44061208/how-to-implement-the-conv1dtranspose-in-keras


DEP remove run exports

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

These are in the compiler activation scripts.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

The home item is expected in the about section.
The license item is expected in the about section.
The summary item is expected in the about section.
The outputs section contained an unexpected subsection name. target is not a valid subsection name.
The outputs section contained an unexpected subsection name. target is not a valid subsection name.
The outputs section contained an unexpected subsection name. target is not a valid subsection name.
The outputs section contained an unexpected subsection name. target is not a valid subsection name.

@conda-forge-admin rerender

@conda-forge-admin rerender


Instant Display of Large PDF Files: Modifying pdf-js Components for Background Downloading

I have PDF files exceeding 200MB, and pdf-js requires downloading the entire file before displaying the first page, which is time-consuming. How can I modify components/app/pdf to instantly display the page while simultaneously downloading the file in the background?
My pdf files are linearized.

Hi @rocheston, thanks for the question. This will be tricky for a few reasons, one of them being that the PDF app is not very efficient when loading large PDF's currently, even once it has the entire file local. I had planned at some point to add lazy loading to how it loads the pages because as it is now it can get quite slow when it's many pages. As for loading in the background or via streaming, that is another complexity as I am not sure if PDF's can be loaded intermittently, and if they can I imagine it would be something pdf.js would need to support. I don't know enough about PDF's to even say what a "linearized" means in the context of being able to load it this way. I will add this as a feature request and in the mean time if you find anything in the pdf.js docs/repo about how to do this please post it here and I can give further advice on how to integrate the feature.


Double clipboard content on paste

When i paste my clipboard text into the message textfield the text gets pasted twice.

This must be a bug in Electron.
I tried running Yakyak with the "electron-prebuilt" package, which uses Version 0.27.1, by running ./node_modules/electron-prebuilt/cli.js app and it didn't have the double-paste problem.
Then I created a build with deploy.sh, which uses version 0.28.1, and started it and the double-paste problem was there again.
So I changed the Electron version in deploy.sh to 0.27.3 and created a build. The double-pasting problem was gone.
My conclusion is that there's a bug in Electron >=v0.28.0 . So I created a small Electron v0.28.1 project with a page that has a textarea with the same attributes as the message field in Yakyak and pasted something. But I couldn't reproduce the issue. I assume it only happens under certain circumstances.
We can file an issue for Electron once we find out how to create an isolated case that reproduces the problem.
My recommendation for a short-term fix would be to downgrade Electron.

i cannot reproduce please explain how i can reproduce it

I don't have electron installed in my system, and the problem too happens.

@davibe: Just copy some text with Ctrl+C and paste it in to the message field with Ctrl+V. I'm on Linux. Maybe it doesn't happen on your OS. What are you running?
@lw4z: You don't have to explicitly install Electron. It comes bundled with Yakyak.

I use manjaro linux, and i commented because in my package list do not show electron installed.

@lw4z: Did you install yakyak from AUR? If you look at the PKGBUILD you'll see that it doesn't use the "electron" package as a dependency but rather downloads its own copy. This is because Yakyak may not always work with the latest version of Electron but rather with a specific version. The Yakyak PKGBUILD uses the same version as used in deploy.sh.

Ok, I installed from AUR. but my ask is: I need install the package electron from AUR to resolve this problem?

@lw4z: No, installing from AUR will not resolve the problem. The AUR package has the same bug. The problem will be resolved once this issue gets closed. But if you install yakyak from AUR you will automatically get the new releases with your system updates. It will also create a nice shortcut in your menu.

@maxkueng: Ok, thanks for helping.

i use OS X and sometimes i try also on Windows 7 (if i really have to). I could not reproduce this. On Linux I understand things could be more complicated. In general when reporting a bug we need more info on the environment. Unfortunately i don't use Linux but I would love a solution that does not require rolling back electron version as we are already waiting for never releases in order to support more features of the app. If this is an electron bug it needs to be reported there and referenced here.

I've got the same problem. Also running Manjaro as os.

Just to confirm problem on Arch Linux.
Hope will be solved soon

same for me on windows and ubuntu

I also have doubled text pasting, Ubuntu 15.04, 64-bit.

I also put an issue when copying from word.  Possibly related https://github.com/yakyak/yakyak/issues/46

@ivancholakov @gibbz can you please check if one of the two copies of the same content is actually an image instead of pure text ? (you should be able to understand that by selecting and/or dragging it)

I can normally edit  pasted text, if helps.

so it may not be related to #46
thank you @dare023

An image is copied twice as far I can see.

This is fixed in #60.


采用ScheduledExecutorService替代Timer，避免异常捕获时影响其他任务

多线程并行处理定时任务时，Timer运行多个TimeTask时，只要其中之一没有捕获抛出的异常，其它任务便会自动终止运行，使用ScheduledExecutorService则没有这个问题。
Make sure set the target branch to develop
What is the purpose of the change
采用ScheduledExecutorService替代Timer，避免异常捕获时影响其他任务
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.09%) to 54.067% when pulling de5a06479e3f2a2341ce9b34212fbeb552482ba6 on zhenhe:develop into df1d93fc8859377b92ba87c6947911281656f355 on apache:develop.

Codecov Report

Merging #3001 (de5a064) into develop (df1d93f) will increase coverage by 0.04%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #3001      +/-   ##
=============================================
+ Coverage      47.78%   47.82%   +0.04%
- Complexity      4549     4554       +5
=============================================
  Files            552      552
  Lines          36628    36628
  Branches        4844     4844
=============================================
+ Hits           17501    17518      +17
+ Misses         16901    16882      -19
- Partials        2226     2228       +2

Impacted Files
Coverage Δ

...org/apache/rocketmq/store/ha/WaitNotifyObject.java
71.15% <0.00%> (-7.70%)
:arrow_down:

...a/org/apache/rocketmq/logging/inner/SysLogger.java
28.57% <0.00%> (-5.72%)
:arrow_down:

...java/org/apache/rocketmq/logging/inner/Logger.java
52.63% <0.00%> (-3.35%)
:arrow_down:

...ava/org/apache/rocketmq/test/util/VerifyUtils.java
46.26% <0.00%> (-2.99%)
:arrow_down:

...a/org/apache/rocketmq/store/StoreStatsService.java
28.85% <0.00%> (-1.97%)
:arrow_down:

...n/java/org/apache/rocketmq/store/ha/HAService.java
71.47% <0.00%> (-0.66%)
:arrow_down:

.../apache/rocketmq/logging/inner/LoggingBuilder.java
63.76% <0.00%> (-0.16%)
:arrow_down:

...org/apache/rocketmq/store/DefaultMessageStore.java
55.70% <0.00%> (+0.29%)
:arrow_up:

.../main/java/org/apache/rocketmq/common/UtilAll.java
38.31% <0.00%> (+0.32%)
:arrow_up:

...rocketmq/client/impl/factory/MQClientInstance.java
51.67% <0.00%> (+0.72%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df1d93f...de5a064. Read the comment docs.

Submit an issue first and then submit related PR.

Please create an issue first.
Associate the issue number in the pr name, such as this pr: https://github.com/apache/rocketmq/pull/2970

Please create an issue first.
Associate the issue number in the pr name, such as this pr: #2970

Already created，#3001

@odbozhou can you review this pr again ?


Fix operator bundle scripts for v1 CRD schemas.

/lgtm

Ah, yes.
Do we have good a way to test this pipeline locally?

Not that I know of, the appsre job here doesn't seem to hit it.
I also thought we were off jenkins.


Update members.md

Adding member name - Rohith Samudrala

I don't see rohithsamudrala in the list of members (https://whimsy.apache.org/roster/members, requires login) - are you sure you are an Apache Member as described in https://apache.org/foundation/governance/members.html ? What is your Apache id?


Testing: Add tests for getAllLists

Description
There are currently no tests for the getAllLists functionality. Some should be added.
Libraries to use

Jest
Have a look at createContact.test.ts (Code) to see an example how to test

Files involved

src/lists/getAllLists.ts - File to be tested
src/lists/createContact.test.ts

Hello.
Can I do this?


Moved example training and inference notebook location

Describe your changes and why you are making these changes
Currently the training and inference notebook in the examples directory is outdated because we mistakenly put the latest version in sdk/examples. This PR moves it to the right location.
Related issue number (if any)
Checklist before requesting a review

[x] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[x] I have performed a self-review of my code.
[ ] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[ ] If this is a new feature, I have added unit tests and integration tests.
[ ] I have run the integration tests locally and they are passing.
[ ] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[ ] All features on the UI continue to work correctly.
[ ] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

This is incorrect.  Can we keep both files?  They are different examples.

@jegonzal So you want both notebooks in the same directory? What should they be named? Currently they are named roughly the same.

@jegonzal bump

One is more for live presentations and the other is a detailed walk through. Can we name them appropriately and keep both?  @datadawg88 is work some edits to the live presentation version that we will want to merge later this week.

@cw75, you can go ahead and merge this, I think.

@vsreekanti OK I put Will’s new notebook here. Now this directory has 3 notebooks. Which one should we deprecate?

Keep Will's and the existing version that was in that directory. I'd drop this one.


Updating deps

This is big PR. I had to do it in one go since godep was mad with cadvisor and kubernetes both including libcontainer.

cc @rjnagal

@saad-ali can you review this PR?
Rohit might be busy.

Self merging since a release needs to be cut soon.

Way too many files to look at. But I assume you did some manual testing to verify things are still working. If so, LGTM.

LGTM


consolidate supported storage types

needed for:

[ ] https://github.com/ManageIQ/manageiq-ui-classic/pull/8548

I only need the first change, which is low risk. The second one is a clean up that may not be necessary or deemed too risky.
Change:

Rename method supports? to storage_type_supported_for_ssa?
I introduced a conflict with SupportsFeatureMixin in #9447
Make the list of supported storage_type values consistent.
The method above was used in metrics capture Storage.scan and capture_storage_targets
Similar but different lists are found in vm_scan, and Vm.path.

@agrare Regarding the second item:

Is there a reason why those 3 lists of supported storage_type values should be different?
What is the best way to determine the proper list? (I chose to include all)

storage_type
Storage.scan
Vm.path
vm_scan

VSAN

y
y

VMFS
y
y
y

NAS

y
y

NFS
y
y
y

NFS41
y
y
y

ISCSI
y

y

DIR

y

FCP
y

y

CSVFS

y
y

NTFS

y
y

GLUSTERFS
y

y

/cc @nasark

update:

fixed spacing cop
fixed constant/array cop (sorry, took a few tries)
fixed specs to be consistent
fixed typo for storage_type vs store_type

@agrare Do we want:
class Storage
  supports :smartstate_analysis do
    if !ext_management_system&.class&.supports?(:smartstate_analysis) || !storage_type_supported_for_ssa?
      _("Smartstate Analysis cannot be performed on selected Datastore")
    elsif !ext_management_system&.authentication_status_ok?
      _("There are no EMSs with valid credentials for this Datastore")
    end
  end
end

Do you want explicit wording for it?
I'll look to see if we can remove some of these checks if we have a not supports for smartstate

Do you want explicit wording for it?

@kbrock up to you, if we can give a more specific reason why we don't support it without much downside I don't see why not

update

ensured objects created by factory/helper had ems references

Sorry took so many tries, the errors were not always obvious what was breaking the tests.


fix(rules): Introduced the capability to include text lists in custom…

… values using JSON notation

:tada: This PR is included in version 1.6.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


BE-15: Configure AWS S3 Bucket for Image Storage

What's up?
In Meeting #5, we discussed about how to store images related to art items and profile pictures for our application. In practice app we stored images in a local folder called media. This time, we can't do it since frontend and backend are in different folders (and it doesn't seem to be suitable for long-term usage).

Some suggested using multipart/form-data. I remember myself doing some research on that while I was working on practice app last semester. It turned out to be more complex than I thought it would be - and it was not compatible with REST architecture (returning only JSON and so on) (I have some questions marks here - so not really sure). So I decided not to use this not because it is not applicable but because of the learning curve it requires us to jump.
Having examined some of the previous repositories, I decided to use AWS S3 Buckets to store our images since it's also completely suitable for base64 encoding-decoding approach.

We used the concept base64 encoding-decoding a lot in the practice app, but it seems like not all team members are familiar with it. Let me explain the architecture in my mind to have a concrete idea about our design. I hope this depiction will be helpful to understand what's going on with these base64 and S3 concepts:

I hereby declare that this architecture is completely subject to changes and doesn't reflect our final design.
To use AWS S3, both frontend and backend teams need credentials, so please get in contact with me.
I saw some examples of storing images in S3 directly from frontend but I don't know how backend keeps track of the images in such a scenario. So let's just continue with the approach illustrated above.
To Do

[x]  Create an Amazon account.
[x] Create two S3 buckets for development and production.
[x]  Create a user group with necessary permissions to use S3 Bucket.
[x] Create a user and add it to the user group you created.
[x] Generate AWS credentials and add them to the .env file (won't be in the repository, ask me these credentials)
[x] Configure Django backend settings for AWS connection:

[x] Development
[ ] Production

Deadline
13.11.2022 @14:00
Additional Information
No response
Reviewers
Assigning specific people as reviewers, but I strongly suggest @everyone to read  the explanation and have a look at the diagram.
Reviewers: @BElifb @mumcusena

Opened #247 for development integration. I'll be working on the production site later.

Production environment is also configured. Updated docker-compose file so that it reads the credentials from .production.env file. Reviewed and merged - no further action is taken.


Change definition of zeta

We will be moving from
zeta = beta / beta0 s - beta c t
to
zeta = s - beta0 c t
Need to look at:

[x] Drift
[x] Cavity
[x] Acceleration (change reference energy, done in update_p0c)
[x] Implement get_pzeta and update_pzeta
[x] FirstOrderTaylorMap
[x] LinearTransferMatrix
[x] Multipole
[x] RFMultipole
[x] 6D beam-beam
[x] e-cloud
[x] spacecharge (nothing to do, z kick not yet implemented)
[x] Synchrotron radiation (no change needed)
[x] Twiss (nothing needed it seems)
[ ] Import particles from six dump (test_data and examples)
[x] Ducktrack

[x] Particles
[x] Drift
[x] Multipole
[x] RFMultipole
[x] Cavity
[x] FirstOrderTaylorMap
[x] LinearTransferMatrix
[x] 6D beam-beam

[x] xpart ...
[ ] Physics manual
[x] Check against sixtrack
[ ] Modify pymask?
[ ] Modify DA example?
[ ] Adapt xcoll ?
[ ] Check with Andrey
[x] Check speed
[ ] Check long-term behaviour (repeat a DA study?)

We might add particles.tau (and maybe xi) as read-only linked arrays
Or maybe instead get rid of psigma

Done


Lambda Layer Numpy build process?

Can you share the process for building the Lambda layers? I'd like to update the Lambda runtime to a later version.
I used the AWS lambda/python Docker image and used pip to install the packages into a layer using arm64 as the built target. At first I thought this was caused by missing numpy C libraries, but I've verified they are there.
When running the app locally I get 502 error, and looking in the Lambda logs I get an error when calling my Lambda:
[ERROR] Runtime.ImportModuleError: Unable to import module 'AIMessageProcessor': Error importing numpy: you should not try to import numpy from         its source directory; please exit the numpy source tree, and relaunch         your python interpreter from there.
I've seen just a few references to this error, but don't seem to be finding the cause in my case. I figure you might have already won this battle :-)
Kudos to this guy for simplifying the layer build

Yes, here's the process I used to create a layer with the latest Langchain build, boto3 package, and Python3.12 that I will be publishing shortly: Go into Amazon Codebuild. (Pick the runtime you are trying to build the Lambda Layer)[https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html] for. Set the source as none and in the buildspec add the following:
version: 0.2

phases:
  build:
    commands:
      - pip config set global.target ""
      - mkdir -p package/python
      - pip install --target package/python boto3
      - pip install --target package/python numpy
      - pip install --target package/python langchain
      - cd package && zip ../package.zip * -r

artifacts:
  files:
    - 'package.zip'

For the artifact location pick the S3 bucket where you want the created zip file to go. Then just download that zip and use it to create the Lambda Layer.

Hey @KBB99, I could run and created package.zip in S3, then I created the layer successfully using this zip and I associated it to my Lambda function.
version: 0.2

phases:
  build:
    commands:
      - pip config set global.target ""
      - mkdir -p package/python
      - pip install --target package/python boto3
      - pip install --target package/python numpy
      - pip install --target package/python langchain
      - cd package && zip ../package.zip * -r

artifacts:
  files:
    - 'package.zip'

Now I'm coding the lambda function and I'm trying to make these imports:
from langchain import LLMChain, SagemakerEndpoint, prompts
from langchain.llms.sagemaker_endpoint import LLMContentHandler

I'm getting this error when executing the lambda:
Response
{
  "errorMessage": "Unable to import module 'lambda_function': Error importing numpy: you should not try to import numpy from\n        its source directory; please exit the numpy source tree, and relaunch\n        your python interpreter from there.",
  "errorType": "Runtime.ImportModuleError",
  "requestId": "082be2a6-7034-4127-ba34-fc159d77ce88",
  "stackTrace": []
}

Any help would be great !
Thanks :)

Hey @KBB99, I could run your script in AWS CodeBuilder and I created package.zip in S3, then I created the layer successfully using this zip and I associated it to my Lambda function.
version: 0.2

phases:
  build:
    commands:
      - pip config set global.target ""
      - mkdir -p package/python
      - pip install --target package/python boto3
      - pip install --target package/python numpy
      - pip install --target package/python langchain
      - cd package && zip ../package.zip * -r

artifacts:
  files:
    - 'package.zip'

Now I'm coding the lambda function and I'm trying to make these imports:
from langchain import LLMChain, SagemakerEndpoint, prompts
from langchain.llms.sagemaker_endpoint import LLMContentHandler

I'm getting this error when executing the lambda:
Response
{
  "errorMessage": "Unable to import module 'lambda_function': Error importing numpy: you should not try to import numpy from\n        its source directory; please exit the numpy source tree, and relaunch\n        your python interpreter from there.",
  "errorType": "Runtime.ImportModuleError",
  "requestId": "082be2a6-7034-4127-ba34-fc159d77ce88",
  "stackTrace": []
}

Any help would be great ! Thanks :)

The problem was that I using Python3.12. Rig now, I'm using to 3.11, I could fix it and it's working like a charm.

Great to hear @jarrillaga. The layer is runtime specific so the Lambda runtime must match the runtime you used to create it. Please let me know if you have any further questions.


Fix getShopArrayByHostAlias when s_core_shops.hosts has only one line

Fix \Shopware\Models\Shop\Repository::getShopArrayByHostAlias when s_core_shops.hosts has only one line.

1. Why is this change necessary?
Invalid redirect to default shop when the hosts alias field have only one line.
2. What does this change do, exactly?
It fixes the query which tries to search for a shop by host aliases.
3. Describe each step to reproduce the issue or behaviour.
Create a new subshop with a custom domain and put in hostalias just an alternative host (e.g. example.com without www) without any new line. Just "example.com" - not "example.com\n" or similar.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-19564.
Please use this issue to track the state of your pull request.

Thank you for your contribution. This will be released within the next version.


Revert "(QENG-3309) Add support for Cisco wrlinux-7"

This reverts commit 3e36da18e7bfeec2fa92295fa5f9959d45611eb4.
I didn't notice until working on another ticket that this has a mismatched template platform value.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-qe.delivery.puppetlabs.net/job/qe_beaker-hostgenerator_btc-intn/18/

Merging my own PR since this fixes something that should not have been merged in the first place.


GDScript: Allow elements of a parent class in a typed array literal

func _ready():
  var node: Node = $path
  var controls: Array[Control] = [node] # now allowed, but unsafe

This is about array literals. Initially when I made update_array_literal_element_type it was strict, but later some changes were requested to make it usable with untyped code. Currently it is allowed to have weakly typed or variants inside the literal. So just like in other places (assignments, passing to arguments and so on) it makes sense to allow super type to be present in the literal, but with unsafe mark.
Closes #75393.

Could/should a warning for this be added?:thinking: It would allow to preserve the current behavior if that's preferred by someone (error/warn according to preference). And it could be turned off by default to not annoy people who don't care about it.

In theory yes, a warning can be added, but to be consistent it will have to cover more than this specific case.
As I said, currently it is possible to put untyped, weakly typed or variants inside the literal, without any warning. Untyped code or variants is worse than typed with super type. So if there is a warning it should cover it too. And there are other places - assignments, arguments - that have the same logic about untyped/variants/super classes, where they are allowed but marked as unsafe. I don't see why those cases should go warning free if this one does not, nothing special much here.

Thanks!

Not sure if it's due to this or indirect but this seems to fail unit tests on windows now


Provide 'podman' as a build backend

Proposed change
Currently, only docker is available to build images. We should:

Abstract the interface that builds a Dockerfile
Implement docker (via docker-py) as the default implementation
Allow podman to be the second implementation, so we can make sure our design isn't docker specific.

podman supports building Dockerfiles directly, so this should be a fairly minimal change.
Alternative options
We do (1) and (2) in core, but leave (3) to be a plugin.
Who would use this feature?
Anyone who doesn't want to use the docker daemon. There are good technical and social reasons for this.
How much effort will adding it take?
Abstracting the current docker calls behind an interface shouldn't be too much work. Podman is going to be interesting. It seems pretty production ready, but treats running on ubuntu as an extreme second class citizen - I haven't been able to get it to run yet. So that might be more challenging - making the case for keeping the podman build bits in an extension.
Who can do this work?
You'd need some familiarity with the docker python client and Dockerfile.

Are there other backends we should also take a look at (not implement though) to inform how we design the abstraction layer?
👍  on attempting to work towards repo2docker being able to use things that aren't docker!

To begin with I think we should only support things that understand Dockerfiles. Off the top of my head, that is BuildKit, Podman and possibly buildah

See also #560


Handle chunked requests

Implement chunked response handling, following discussion in https://github.com/reactphp/http/issues/232
Todo:

[ ] remove VCS alias

@WyriHaximus I need your help with rebasing this for https://github.com/reactphp/promise-stream/pull/3. In the tests there's currently this for the RequestBodyBufferMiddlewareTest:
public function testExcessiveSizeReturnsError413()
{
    $stream = new BufferStream(2);
    $stream->write('aa');

    $serverRequest = new ServerRequest(
        'GET',
        'https://example.com/',
        array(),
        $stream
    );

    $buffer = new RequestBodyBufferMiddleware(1);
    $response = $buffer(
        $serverRequest,
        function () {}
    );

    $this->assertSame(413, $response->getStatusCode());
}

Now what goes in is NOT a ReadableStreamInterface and therefore returned early before any buffering in https://github.com/reactphp/http/blob/master/src/Middleware/RequestBodyBufferMiddleware.php#L43.
Is that really desired, i.e. should it be possible to construct ServerRequest with a body that doesn't implement Psr7 semantics (and therefore actually is a HttpBodyStream? Hidden bug or feature that I fail to grasp?

@andig Have you seen the documentation for the RequestBodyBufferMiddleware? I think that this middleware should support all valid requests. In a normal stack this will be the incoming streaming request, but another prior middleware handler may also expose a buffered request to this middleware handler.
The following (completely contrived) example should allow request up to 8 MiB:
$middleware = new MiddlewareRunner([
    new RequestBodyBufferMiddleware(16 * 1024 * 1024), // 16 MiB
    new RequestBodyBufferMiddleware(8 * 1024 * 1024), // 8 MiB
});

Small side note: I've also changed mentions of g7 and Psr7Implemention to Psr7 for sake of coding consistency.

@clue

Have you seen the documentation for the RequestBodyBufferMiddleware? I think that this middleware should support all valid requests.

Reading this:

This can be useful if full PSR-7 compatibility is needed for the request handler and the default streaming request body handling is not needed.

I understand the behaviour. It's still totally confusing though that- if you use the RequestBodyBufferMiddleware and send in a react stream with valid body it can be of any size and will not be buffered or rejected.
Shouldn't at least the RequestBodyBufferMiddleware reject non-Psr7 bodies as they are used in the tests?

I'm not sure I follow tbh. Our middleware implementation works around the concept of PSR-7 requests coming in and PSR-7 responses coming out (plus wrapped in promises). This means that there's no such thing as a "non-Psr7 body".
What's special about this implementation is that bodies can be in a streaming state when a ReadableStreamInterface is attached. This allows us to transport bodies of arbitrary sizes without having to store huge bodies in memory.
Does this help?

I'm not sure I follow tbh.

Never mind. I've just noticed that I had to rewrite https://github.com/reactphp/http/pull/235/files#diff-5ff94d7c5e50a34ed39b11c33717c0b9R68 to use a different stream type. I'm probably making this too complicated ;)

@andig Seems you're getting there, keep up the good work :+1:

@andig :tada: https://github.com/reactphp/promise-stream/releases/tag/v0.1.2 :tada:

@andig updated this PR's title to something that reflects what the current code is doing

I've added one more commit to test for 413 in case on known but excessive content length. Still need to have another look at the README.

@andig could you update to ^1.0 || ^0.1.2 since 1.0 has been release earlier today? :tada:

What is the status here @clue and @andig?

Needs review of the last 2 commits


The scan function return in RawStorage in coprocessor_plugin does not meet expectations

Bug Report

What version of TiKV are you using?

What operating system and CPU are you using?

Steps to reproduce

I defined a coprocessor plugin, when I use the scan function in the RawStorage trait, I expect to return KvPair to filter by key, but in fact it only returns Value.
What did you expect?
What did happened?

/severity moderate


Issue #268: Fixed markup error in Nexus installation section

Fixes #268

LGTM, will merge today.

Merged: https://github.com/openshiftio/appdev-documentation/commit/2bfcc35754180aff5794d53122cade1d8516625b


Add a channel to support this project

I think this is a great work! It would be great to know how can people support the maintenance and enhancement of this project.

Hi Chat,
Thank you for proposing this.
The project was created as an open source long time ago by a person who I couldn't contact. I only make ad-hoc maintenance hence I don't feel it would be right to monetise not my work :-)
But I will be more than happy to cooperate with other people (developers) and merge valuable improvements to the main branch.
Best  regards,
Jarek


test: Testing Report

Created IBM test without external provider and updated UAT test to use it instead of the main example
Updated UAT GHA testing workflow to output test report after test runs
Update Prod GHA testing workflows to output test report after test runs

@thogarty Please share the final testing report (screenshot or logs) generated with this code.

@d-bhola, we decided not to do screenshots (not easily viewable) and just have the reviewer look at the latest action runs for the PR.
You can view them here:
https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-fcr-prod-suite.yaml
https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-port-prod-suite.yaml
https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-metal-nimf-suite.yaml
https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-virtualdevice-prod-suite.yaml
https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-prod-suite-all.yaml
https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-uat-suite.yaml

@d-bhola, we decided not to do screenshots (not easily viewable) and just have the reviewer look at the latest action runs for the PR.
You can view them here: https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-fcr-prod-suite.yaml https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-port-prod-suite.yaml https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-metal-nimf-suite.yaml https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-virtualdevice-prod-suite.yaml https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-prod-suite-all.yaml https://github.com/equinix/terraform-equinix-fabric/actions/workflows/terratests-uat-suite.yaml
👍

@srushti-patl , we aren't exposing those examples publicly. They're just for internal testing and don't require the additional context. We only need README.md's and .tfvars.example for published example modules

Is there a way to remove/modify the question marks for better presentation of the test report?

@d-bhola , beyond the scope of this task. We're using third party tools for the heavy lifting and that would require a second fork (we're already using a fork of go-junit-report). If we had more control over the source code I'd be happy to oblige but it's too much effort for too little reward.

@d-bhola , beyond the scope of this task. We're using third party tools for the heavy lifting and that would require a second fork (we're already using a fork of go-junit-report). If we had more control over the source code I'd be happy to oblige but it's too much effort for too little reward.

Ok.👍

Needs rebase


Adding Google Analytics. Fixes #113

Added "-google-analytics-id" option to gedcom2html. If provided it will ad the appropriate GA header to all pages produced.

This change is

Codecov Report

Merging #115 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   91.72%   91.72%
=======================================
  Files          28       28
  Lines        1172     1172
=======================================
  Hits         1075     1075
  Misses         86       86
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f22984...8c2530c. Read the comment docs.


chore: disable the service worker

Also, unregister previously registered workers for good measure.
Related issue https://github.com/syndesisio/syndesis/issues/5602

PR Storybook available here


Implement the missing part of Exchange Header in Transport layer

Problem
Currently, only I Flag (A single bit field indicating that the message was sent by the initiator of the exchange) is implemented in transport layer. Vendor Id is implemented in the Payload part but its flag is implemented in the Packet part, this separation cause the payload header need to be passed throughout the transport stack.

Summary of Changes

Add support for A Flag (1 bit, position 1) and R Flag (1 bit, position 2) in Exchange Header (8 bits)
Move V flag from Packet Header to Payload Header to align with the spec and avoid passing Payload header throughout the transport layer

Fixes #4016

I found the need to pass those flags around quite annoying as well. The issue we had was that the spec required these fields formatted as such.
We should ensure the spec is updated with the new flag format.


'ERROR: Unable to read from webcam. Please verify your webcam settings.'

I would appreciate if anyone could provide assistance regarding this error message. Mediapipe has been installed and the camera being used with the Raspberry Pi 4 is functioning, which was verified by using the following command to test it.
libcamera-still -o test.jpg
The issue however occurs when attempting to run the recognize.py script, which gives me the error:
"ERROR: Unable to read from webcam. Please verify your webcam settings."
I'm unsure if the issue is coming from the use of cv2 and the introduction of the new python library PiCamera2 or something else entirely. The following code seems to be where the error is occurring, but I just don't how to resolve it. Again, I'd greatly appreciated the help if possible.
Continuously capture images from the camera and run inference
while cap.isOpened():
success, image = cap.read()
if not success:
sys.exit(
'ERROR: Unable to read from webcam. Please verify your webcam settings.'
)
Lines(100-106)
where cap seems to instantiated below as cv2:
Start capturing video input from the camera
cap = cv2.VideoCapture(camera_id)
cap.set(cv2.CAP_PROP_FRAME_WIDTH, width)
cap.set(cv2.CAP_PROP_FRAME_HEIGHT, height)
Lines(56-59)

Apparently it's an issue with a newer version of the camera. Someone sent
me a workaround they used, I just haven't had time to look into it with
being on leave and IO. I'll dig up their code when I'm back at work on
Tuesday to post.
On Sat, May 4, 2024, 1:02 PM EGCVants @.***> wrote:

I would appreciate if anyone could provide assistance regarding this error
message. Mediapipe has been installed and the camera being used with the
Raspberry Pi 4 is functioning, which was verified by using the following
command to test it.
libcamera-still -o test.jpg
I'm unsure if the issue is coming from the use of cv2 and the introduction
of the new python library PiCamera2. The following code seems to be where
the error is occurring, but I just don't how to resolve it. Again, I'd
greatly appreciated the help if possible.
Continuously capture images from the camera and run inference
while cap.isOpened():
success, image = cap.read()
if not success:
sys.exit(
'ERROR: Unable to read from webcam. Please verify your webcam settings.'
)
Lines(100-106)
where cap seems to instantiated below as cv2:
Start capturing video input from the camera
cap = cv2.VideoCapture(camera_id)
cap.set(cv2.CAP_PROP_FRAME_WIDTH, width)
cap.set(cv2.CAP_PROP_FRAME_HEIGHT, height)
Lines(56-59)
—
Reply to this email directly, view it on GitHub
https://github.com/googlesamples/mediapipe/issues/383, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAR2C33YXIJQVJTIDFX2WPDZAUPCXAVCNFSM6AAAAABHHADSESVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3TSMJTG42DMNA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thank you very much. Said it a lot, but it is greatly appreciated

Alright maybe this will help :) https://gist.github.com/jeffehobbs/d9cbe007c94517cb758dd5e69413cfd6

where do you have to add this? i'm stuck on the same thing but don't know how to fix it


What is the best way to set a listener for input?

I'd like the Enter key pressing call a function at root.
Usually we use @keyup.enter but the component is 3rd party so we cannot change the source without forking.
What should I do? What are the best practices?

Hi @amorphine,
Sure you can do it. using old way addEventListener to the input. You can get the input using reference. You can try this
const input = this.$refs.autocomplete.$refs.input
document.addEventListener(input, this.someRootMethod, false)


Add yarn application status mapping

Adds a configurable service check for yarn application statuses.
Reason: Customer wants to know when an application is killed.

Putting on hold: Waiting for customer feedback before releasing this feature


Fix max tokens for embedding models

Based on other documentation, the max tokens for embedding models should be 8,192 but not 8,191. Reference: https://learn.microsoft.com/en-us/azure/ai-services/openai/how-to/embeddings?tabs=console

@mrbullwinkle
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@nkgami Let me get back to you on this. We previously had 8192 set everywhere and then were asked by the PG to update to 8191 so the location that still says 8192 was an oversight in that round of changes.
8191 is what is currently stated in OpenAI's docs as well:

https://platform.openai.com/docs/guides/embeddings/embedding-models
With that said I am aware and have tested that if you exceed the token limit both with OAI, and AOAI the error message that is returned says 8192 is the limit, and the 8192 value appears in various code comments in the OpenAI Python library.
It is possible that the issue is with the error message stating 8192, but I haven't been able to track down a definitive answer yet.


async_pipeline is not exposed in the library

Hi team, I want to use async_pipeline and find mii.async_pipeline is not exposed out with the deepspeed-mii package. Can you add this in the code https://github.com/microsoft/DeepSpeed-MII/blob/main/mii/init.py#L6 ?
Thanks

@yaliqin please post MII issues on the MII repository.
You can import with from mii.api import async_pipeline. However, please note that this is only intended for internal use and is very much tailored to work with the inference server in MII.


Add back external test for erigon

:clipboard: Add associated issues, tickets, docs URL here.
Overview
Describe what your Pull Request is about in a few sentences.
Changes
Describe your changes and implementation choices. More details make PRs easier to review.

Change 1
Change 2
...

Testing
Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.86%. Comparing base (db98484) to head (6791744).
Report is 4 commits behind head on merge-upstream-20241022.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                   Coverage Diff                    @@
##           merge-upstream-20241022     #266   +/-   ##
========================================================
  Coverage                    64.86%   64.86%
========================================================
  Files                           54       54
  Lines                         4460     4460
========================================================
  Hits                          2893     2893
  Misses                        1391     1391
  Partials                       176      176

Flag
Coverage Δ

cannon-go-tests
64.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


rename aws-resources-exporter to aws-resource-exporter

/retest

depends on #2

since this is blocking the first successful build master, i'll merge this.
if this is not ok, we can revert and change quay repo accordingly.


improve Dockerfile to use entrypoint in order to get better log when …

…receive any request
Tickets
https://github.com/serengil/deepface/issues/1368
What has been done
With this PR, I have update the Dockerfile to use entrypoint.sh for a better log in order to get easy monitor when the program is running.
How to test
Just run the dockerfile and see if the log is display or not

LGTM


update sbom_with_creator_and_version rule for cdx version >= 1.5

close: https://github.com/interlynk-io/sbomqs/issues/264
update sbom_with_creator_and_version rule for cdx  whose spec version >= 1.5.

@viveksahu26 this change is incorrect. Tools/Components & services are all avaliable since version 1.5 and versions before 1.5 support only Tools.
We should not use cyclonedx versions here but check if the feature is present or not e.g
Populate our internal tools array as folllows

if tools->components present then add to our array
if tools->services present then add to our array
if tools->tools present then add to our array

Yeah got it. Would correct it. Basically, earlier I got bit confused about services that how services can provides tool name, it's version and all. But later read that service is more generalized in terms of tool, Whereas, tool is one of the services. Apart from that, Can you provide CycloneDX SBOMs examples having version 1.5 or 1.6 for testing and all.


grief defender support

Describe the feature
add compatibility with grief defender claims, for example when winter arrives, advancedseasons generates ice on it, still having "ice-growth" denied flag

I second this feature

Added this, however I couldn't test it because it's a paid plugin. Let me know if this works / doesnt work in next update, thanks!


Fix BrokerOuterAPITest#test_register_timeout

Fixes #4977

Codecov Report

Merging #4978 (101b6b3) into develop (86e4354) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4978      +/-   ##
=============================================
- Coverage      43.24%   43.18%   -0.07%
+ Complexity      7723     7722       -1
=============================================
  Files            995      995
  Lines          69066    69066
  Branches        9143     9143
=============================================
- Hits           29871    29824      -47
- Misses         35452    35495      +43
- Partials        3743     3747       +4

Impacted Files
Coverage Δ

...e/rocketmq/remoting/netty/NettyRemotingClient.java
40.21% <0.00%> (-3.52%)
:arrow_down:

...a/org/apache/rocketmq/broker/BrokerController.java
43.84% <0.00%> (-3.52%)
:arrow_down:

...a/org/apache/rocketmq/filter/util/BloomFilter.java
60.43% <0.00%> (-2.20%)
:arrow_down:

...he/rocketmq/broker/processor/PopReviveService.java
38.35% <0.00%> (-1.80%)
:arrow_down:

...ent/impl/consumer/DefaultLitePullConsumerImpl.java
68.75% <0.00%> (-1.25%)
:arrow_down:

.../apache/rocketmq/store/ha/DefaultHAConnection.java
65.86% <0.00%> (-1.21%)
:arrow_down:

...he/rocketmq/client/impl/consumer/ProcessQueue.java
61.00% <0.00%> (-0.92%)
:arrow_down:

...ache/rocketmq/broker/client/ConsumerGroupInfo.java
68.46% <0.00%> (-0.91%)
:arrow_down:

...a/org/apache/rocketmq/store/StoreStatsService.java
39.77% <0.00%> (-0.56%)
:arrow_down:

.../org/apache/rocketmq/store/ha/DefaultHAClient.java
61.53% <0.00%> (-0.52%)
:arrow_down:

... and 10 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


code compiled but i am not getting any output

face_recognition version:
Python version:
Operating System:

Description
Describe what you were trying to get done.
Tell us what happened, what went wrong, and what you expected to happen.
IMPORTANT: If your issue is related to a specific picture, include it so others can reproduce the issue.
What I Did
Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

We can't help if you don't provide any of the required information. There's no way to know what you tried.


windowsservercore-2019 image not updated

Jenkins and plugins versions report

Environment

N/A

What Operating System are you using (both controller, and any agents involved in the problem)?
Windows
Reproduction steps
n/A
Expected Results
windowsservercore-2019 docker image updated
Actual Results
windowsservercore-2019 has not been updated in 3 weeks now (only the jdk11-hotspot-windowsservercore-2019 windows image is being updated)
Anything else?
Not sure if this is to do with something having changed with the build process, or if something is failing with the windowsservercore-2019 image

As Java 17 is now the default since #1724, and as there is no Windows JDK 17 image (cf https://github.com/jenkinsci/docker/tree/master/17), the short tag windowsservercore-2019 isn't updated as there are no (new) windowsservercore images to build with the default JDK 17.

Until/unless Windows JDK17 images is added, you'll have to use the jdk11-hotspot-windowsservercore-2019 windows image (only its tag changes)

Please see https://github.com/jenkinsci/docker/issues/1490#issuecomment-1596957219 : the build process is still not building autoamtically all versions for Windows, but it could be done. Work (help) is required

Reopening until validation with the next Weekly and LTS releases in two days.

All versions are now automatically built, see https://hub.docker.com/r/jenkins/jenkins/tags?page=1&name=windows


Futures trading

I appreciate your effort to develop this library.
Could you please check the document. There are help for future and broker. Could you please add these methods too?
https://mexcdevelop.github.io/apidocs/contract_v1_en/

Unfortunately the futures API does not allow managing of orders, it only allows querying data at the moment (see change log of 2022-07-25). So I don't have any immediate plan to implement this at it can't be fully used.

Thanks.
I will contact them to improve it.

it seems they don't have a plan to support it soon.
i know it is not  a good place to ask, but could you please develop the library for bingx , too?
https://bingx-api.github.io/docs/#/en-us/swapV2/changelog

Yes BingX will probably be added in a few weeks :)


Update Install.zh.md

The TarsWeb sql (TarsWeb/sql/db_tars_web.sql) should be executed in the process of Tras installation,  otherwise, the function of " Interface Debugger" does not work.

部署已经优化了, 一键脚本部署了.


Metrics Rate Limits

Project description:
https://github.com/getsentry/team-sdks/issues/77

Covered by https://github.com/getsentry/sentry-php/issues/1723.


Fix lz4f optimization thread unsafe

Proposed changes
Issue Number: close #9706 , which was introduced by https://github.com/apache/incubator-doris/pull/9566
Make reusing compress/decompress context object thread safe by using thread_local.
Problem Summary:
Describe the overview of changes.
Checklist(Required)

Does it affect the original behavior: (No)
Has unit tests been added: (No Need)
Has document been added or modified: (No Need)
Does it need to update dependencies: (No)
Are there any changes that cannot be rolled back: (No)

The thread_local approach is learned from https://github.com/apache/incubator-doris/pull/7911 by @xinyiZzz . It will be very appreciated if you have a look and check whether the usage of thread_local in this pr is right, @xinyiZzz .

The thread_local approach is learned from #7911 by @xinyiZzz . It will be very appreciated if you have a look and check whether the usage of thread_local in this pr is right, @xinyiZzz .

Sorry I just saw it, I see you have submitted a better solution to replace this pr.
There is no problem with using thread_local, but I suggest adding thread local variables to the ThreadContext class. in the future.

@xinyiZzz , thank you for your suggestion and it's valuable. Yes, a better solution #9741, so this one will be closed.


Not logging in with Github

Type: Bug
Extension Information

Cody Version: 1.46.0
VS Code Version: 1.95.3
Extension Host: desktop

Steps to Reproduce

Expected Behaviour

Logs

I was logged out and now using button "Sign In with GitHub", it opens the browser but it just keeps loading and does not work.
Please help!
Thanks!
 I cannot access https://sourcegraph.com/cody/chat, and I cannot log in either.

think their servers are down. I cannot access https://sourcegraph.com/cody/chat, and I cannot log in either.

Yep, seems that way.

think their servers are down. I cannot access https://sourcegraph.com/cody/chat, and I cannot log in either.

Ok, back to work :)

Close this resolved issue.
Thank you for reporting.


Cow: Watch tcstracking.com.pk

Cow requests the watch of the watch_keyword tcstracking\.com\.pk. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

tcstracking\.com\.pk has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Application to multi-agent environment

Thank you for your great work!
I was wondering if this method can be applied to the environment with multiple agents, something like this. I am just starting in reinforcement learning and for now I see no reason why it couldn't be applied. But, maybe you thought about it?

Yes, there should not be any fundamental limitation when trying to apply to multi-agent environments.


Sleeping for 3 seconds so postgrees serivce have enough time to start-up

Types of change (Check "x")

[*] Bug fix

Related Issue
Fix https://github.com/fga-gpp-mds/2018.1-Cardinals/issues/65

Accepting pull request to fix docker


Error when using different versions of contentlayer and next-contentlayer: Cannot read property 'cwd' of undefined

Build failed on Vercel, with next-contentlayer v0.2.4
Build error log
TypeError: Cannot read property 'cwd' of undefined
Full build log https://gist.github.com/studioprisoner/b111b6abc6320539a7208d7ab1ef9057

Context from Discord:


IntelliSense not working with MSYSY2 clang64

Type: Bug
I am getting the following errors in VSCode on Windows using MSYS2/clang64 compiler:
#include errors detected. Consider updating your compile_commands.json or includePath. IntelliSense features for this translation unit (D:\xxx\xxx.cpp) will be provided by the Tag Parser.C/C++(1696)
and
cannot open source file "cstddef" (dependency of "D:\xxx\gtest\gtest.h")C/C++(1696) when using MSYS2 clang64 environment.
Additionally cstlib, iostream, ... aren't found as well.
Using MSYS2 mingw64 (clang or gcc) everything is working.
Part of my cmake-kits.json
{
"name": "MSYS2 clang64",
"compilers": {
    "C": "C:\\msys64\\clang64\\bin\\clang.exe",
    "CXX": "C:\\msys64\\clang64\\bin\\clang++.exe"
},
"environmentVariables": {
    "CMT_MINGW_PATH": "C:\\msys64\\clang64\\bin"
}

VSCode_test.zip
VS Code version: Code 1.78.2 (b3e4e68a0bc097f0ae7907b217c1119af9e03435, 2023-05-10T14:39:26.248Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Sandboxed: Yes
Extensions (24)

Extension
Author (truncated)
Version

gdb-debug
Dam
1.0.7

vscode-markdownlint
Dav
0.50.0

CppSnippets
har
0.0.15

plantuml
jeb
2.17.5

cortex-debug
mar
1.10.0

language-matlab
Mat
1.1.0

debug-tracker-vscode
mcu
0.0.15

memory-view
mcu
0.0.20

rtos-views
mcu
0.0.6

rainbow-csv
mec
3.7.0

git-graph
mhu
1.30.0

isort
ms-
2022.8.0

python
ms-
2023.8.0

vscode-pylance
ms-
2023.5.50

cmake-tools
ms-
1.15.12

cpptools
ms-
1.15.4

cpptools-extension-pack
ms-
1.3.0

vscode-serial-monitor
ms-
0.9.0

binary-viewer
Qia
1.1.1

bash-debug
rog
0.3.9

shellcheck
tim
0.32.5

cmake
twx
0.0.17

errorlens
use
3.11.0

current-file-path
yos
4.0.0

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
2e4cg342:30602488
pyind779:30671433
f6dab269:30613381
pythonsymbol12:30671437
2i9eh265:30646982
showlangstatbar:30737416
vsctsb:30748421
pythonms35:30701012
03d35959:30757346
pythonfmttext:30731395
pythoncmv:30756943
fixhidewlkth:30730051
pythongtdpathcf:30739705

/extC++

It looks like this is caused by the C++ extension. Please file the issue to the C++ extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!


Create story for the "how are you" Intent

As a chatbot user I want to able able to make chitchat by asking "How are you?" and the bot be able to ask me back how I am.
Acceptence Criterea:

conversation flow as follows:

user: "Wie gehts dir?"
bot: "Super und dir?"
user: "Auch gut, danke!"

bot can has different 4 possible answers, examples:

Super und dir?
Gut, danke! Und dir?
Mir geht es gut, danke der Nachfrage! Und dir?
Alles gut? Und wie geht's dir?

Issues in der Wiki: https://github.com/ID-Start-Winter22/chat-team-11/wiki/🏃♂-Ideation-und-Sprint-1#-issues


174

QUESTION 174
Note: This question is part of a series of questions that present the same scenario. Each question in the series
contains a unique solution that might meet the stated goals. Some question sets might have more than one
correct solution, while others might not have a correct solution.
After you answer a question in this section, you will NOT be able to return to it. As a result, these questions
will not appear in the review screen.
Your company plans to purchase an Azure subscription.
The company's support policy states that the Azure environment must provide an option to access support engineers
by phone or email.
You need to recommend which support plan meets the support policy requirement.
Solution: Recommend a Standard support plan.
Does this meet the goal?
A. Yes
B. No

B

A*


Signed container image support

Hi,
Does cri-containerd support signed container image schemes (like docker content trust, or Simple GPG based signing?
This is very critical for the security sensitive environments.
If this is not there yet, I can rename this issue to RFC and we can discuss how can we implement it in cri-containerd.

Does cri-containerd support signed container image schemes (like docker content trust, or Simple GPG based signing?

@harche We don't support it yet.
The problem is that for Kubernetes, it is still not clear whether we should handle this at the cluster admission phase; kubelet admission phase or container runtime.

@harche But I do think it is good to have this support in cri-containerd.

Hello, could you please let me know if there is any update on that subject? We are currently evaluating how to integrate container integrity in our CI/CD Pipelines and are wondering about different Container Runtime Compatibilities.

@3r1co The problem is that there is no OCI standard for TUF
Right now, there is Docker Content Trust (which uses Notary, an implementation of TUF), but it's Docker-specific
Maybe someone can help us write an OCI standard for TUF?
Cc @justincormack @JustinCappos

"Docker Content Trust" is not Docker specific. But the metadata in Notary is not stored in OCI annotations; I am planning to work on an OCI spec for TUF metadata soon.

Thanks for the clarification, @justincormack! Would love to collaborate on the OCI spec for TUF metadata 👍

any update on this? is it still being pursued? this would be amazing.

https://www.docker.com/blog/community-collaboration-on-notary-v2/
https://github.com/notaryproject/
https://github.com/notaryproject/nv2


test case for double tennis problem

I have added a test case for the double tennis problem. The detailed explanation of this can be found in #834. Please review.

Shouldn't have things like #print  in PRs.


need you help

Hi , I have a question ，I want to achieve this effect(look attachment) . my english is not good ,but i need you  help. thinks

See this: https://github.com/gpolak/LFHeatMap/issues/5

bingo , problem solving , thinks


cmd disable-access and fix doc

Codecov Report
Patch coverage has no change and project coverage change: -1.58 :warning:

Comparison is base (0187d5e) 81.58% compared to head (c5bee00) 80.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1044      +/-   ##
==========================================
- Coverage   81.58%   80.00%   -1.58%
==========================================
  Files         135      138       +3
  Lines       15121    15422     +301
==========================================
+ Hits        12336    12338       +2
- Misses       2226     2524     +298
- Partials      559      560       +1

see 5 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


API Version checking does not support xrpl-py==3.0.0

Issue Description
When upgrading from xrpl-py==2.X.X to xrpl-py==3.0.0, JSON RPC requests to Xahau nodes return a 400: invalid_API_version
Steps to Reproduce

pip install xrpl-py==3.0.0

import xrpl
xrpl.ledger.get_fee(xrpl.clients.JsonRpcClient("https://xahau.network"))

Note, changing the client address to a rippled node does not display the same issue
Expected Result

pip install xrpl-py==2.5.0

import xrpl
xrpl.ledger.get_fee(xrpl.clients.JsonRpcClient("https://xahau.network"))

To use xrpl-py with xahau you will need to use this repo.


Fix Roadmap Link in README

See subject.
Specifically https://github.com/orgs/subconsciousnetwork/projects/1/views/4
I came here from your HN ad and that was the first thing I clicked on, hoping it would help me understand what you're building.

Hey, thanks for catching that! Fixed in #347


Update dependency eslint-plugin-local to v4

This PR contains the following updates:

Package
Type
Update
Change

eslint-plugin-local
devDependencies
major
1.0.0 -> 4.2.1

Release Notes

taskworld/eslint-plugin-local (eslint-plugin-local)
v4.2.1
Compare Source
Bug Fixes

could not run "test" command (8afd7be)

v4.2.0
Compare Source
Features

export type definitions for plugin consumer (e1850fc)

v4.1.1
Compare Source
Bug Fixes

unexpected argument checking for "test" command when running inside ESLint (e9d5adc)

v4.1.0
Compare Source
Features

support string in valid test cases (4529598)

v4.0.0
Compare Source
BREAKING CHANGES

new output format for "test" command (5c086fa)

Features

support --bail and --silent for "test" command (419ae65)
filter test cases with only across multiple rules (63d2b6c)

v3.2.1
Compare Source
Bug Fixes

could not use only function to filter test cases (4720aeb)

v3.2.0
Compare Source
Features

support environment without .git directory (ccfdc88)

v3.1.6
Compare Source
Bug Fixes

broken release pipeline (a49b12c)

v3.1.5
Compare Source
v3.1.4
Compare Source
v3.1.3
Compare Source
v3.1.2
Compare Source
v3.1.1
Compare Source
v3.1.0
Compare Source
Features

support Node.js older than 18.17.0 (860a522)

Others

better type checking (d66d93f)

v3.0.1
Compare Source
Bug Fixes

faulty test command (300a6b6)

Others

run test every commit (996fa64)

v3.0.0
Compare Source
BREAKING CHANGES

support pnpm (ea670fd)

v2.0.0
Compare Source

Configuration
📅 Schedule: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Self-Hosted Renovate Bot. Find all logs here.

 You will not get PRs for any future 4.x releases. But if you manually upgrade to 4.x then Renovate will re-enable minor and patch updates automatically.
If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.


json: in firewall policy ..

A better handling of the json: format for policy rules (i.e. not visible from the user) can be done with a couple of cases switches..

Done in the fortiosapi


Cost increases when using 'crocoddyl.SolverFDDP'

Hi,
I'm using crocoddyl.SolverFDDP(problem) to solve an OCP, but the cost increases at some iterations. Is this solver using line search? If so, how can the cost go increasing?
Looking forward to the reply. Thanks~

The solver handles dynamic feasibility as well. This is in contrast to the classical DDP algorithm. It means that it could increase a little the cost as a trade-off to decrease the infeasibility.
This behaviours can appears in line search procedure, so this is orthogonal. However, answering your question, FDDP performs a rollout of the dynamics, which can be interpreted as nonlinear search.
For more details see: https://arxiv.org/pdf/1909.04947.pdf.
I will close this issue, but do not hesitate to ask further questions if it is needed.


update the database please

There are new radiant rpincrystals in Sumeru. Could you please update the "Radiant Rpincrystals" recorder in database?
BTW, could you please add the recorder about the recipe?

Spincrystal just updated, but what do you mean by recipe recorder?

It is just like what the achievement and spincrystal pages do. We can use this to check which recipes are collected and which are not.

Oh do you mean food recipe?

Yes, food recipe!

Code-wise, it might be the same as the radiant spincrystal page, yeah?

I think so.

Spincrystal just updated, but what do you mean by recipe recorder?

Spincrystal database needs updating still. I have crystals 83 & 84 which arent on your list, plus all the ones on my sumeru music page have names that are not in your database list.


Added Beautiful Login Page.md

Adding Beautiful Code

Sorry @surajsharma14 , we are not collecting data from the users as of now .

Okkk fine but what contribute bro we just needed only accept one pull
request. What we add on that. And please accept kr lena jo tm bolo wohi add
kru
On Mon, 10 Oct, 2022, 4:39 pm Ashish Kumar, @.***>
wrote:

Closed #119
https://github.com/DeveloperAshish8/CodeChamp-s-Website/pull/119.
—
Reply to this email directly, view it on GitHub
https://github.com/DeveloperAshish8/CodeChamp-s-Website/pull/119#event-7553086582,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARGQ2OLMSOCWK7TLSCBGBVDWCP2OHANCNFSM6AAAAAARASSNXA
.
You are receiving this because you were mentioned.Message ID:
<DeveloperAshish8/CodeChamp-s-Website/pull/119/issue_event/7553086582@
github.com>


Uncaught TypeError: Cannot read property 'close' of undefined

Bug Report
Describe the bug
When i add docz to a create-react-app and start the server, it shows a blank page and it gives me this error.
To Reproduce

npx create-react-app my-app && cd my-app
yarn add docz docz-theme-default --dev
Create a basic mdx file
yarn docz dev
A blank page appears
See this error in console:

Uncaught TypeError: Cannot read property 'close' of undefined
    at Object.eval (index.js?e094:72)
    at eval (index.js:230)
    at Object../node_modules/chalk/index.js (vendors.js:554)
    at __webpack_require__ (runtime~app.js:801)
    at fn (runtime~app.js:164)
    at eval (formatWebpackMessages.js?5b63:10)
    at Object../node_modules/react-dev-utils/formatWebpackMessages.js (vendors.js:6800)
    at __webpack_require__ (runtime~app.js:801)
    at fn (runtime~app.js:164)
    at eval (webpackHotDevClient.js?7ef4:23)

Expected behavior
The app should work
Environment

OS: MacOS 10.14.1
Node/npm version: Node 10.14.2/npm 6.4.1/Yarn 1.12.3

If i downgrade to 0.12.17 everything works

I've noticed that the problem appears when using docz with react-scripts and the reason is a different version of 'ansi-styles'.
Currently, you can fix it with addition resolutions to package.json
  "resolutions": {
    "ansi-styles": "^3.2.0"
  }

and run yarn

@pedronauck It's easy to reproduce, yarn add react-scripts in examples/basic.
Changing "chalk" in docz-core from "^2.4.1" to "2.4.1" will fix it.
On local machine it works in this way
when chalk ^2.4.1 yarn install react-scripts dependencies in root node_modules folder and version that different in docz-core dependencies installs into node_modules/docz-core/node_modules. when chalk 2.4.1 yarn do it vise versa

thanks for the tip. is this a fix we should do in docz or in react-scripts? seems like react-scripts is at fault for pinning versions

I had the same issue using yarn, using npm the issue is not there.

TL;DR: I think the issue is docz is referencing the older ansi-styles version from the docz-core node_modules instead of the ansi-styles that comes as a dependency of chalk within the project root node_modules.
I'm not sure if this will help or not @sw-yx, but it appears to be independent of react-scripts. I was able to see the issue in both a fresh create-react-app install as well as another non-CRA app. Further, after digging into chalk I was able to correctly log out ansiStyles.color from a node script calling the same version of chalk. BUT, when doing that same log within the context of the docz webpack build it came back undefined. My initial presumption (haven't confirmed) is the docz-core package leverages an outdated version of ansi-styles via the webpack build process. The issue becomes apparent when comparing /node_modules/ansi-styles/index.js to the docz version: node_modules/docz-core/node_modules/ansi-styles/index.js. Comparing those package's package.json file further highlights the version mismatch and thus the missing color object.

mm. cc @pedronauck

Having the same issue here. Any updates?

I can confirm that it's not related to react-scripts. I'm running a non-CRA app and ran into the same issue while setting up docz.

Running into the same problem with CRA, does anyone know if ejecting CRA solves this?

@schalkventer you dont need to eject at all. just add
"resolutions": {
  "ansi-styles": "^3.2.0"
}

to your package.json and run yarn again

Thanks @sw-yx! 👍

Thank @schalkventer. You saved my time.

@rororofff has funded $2.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

I'm getting the same error.
"resolutions": {
  "ansi-styles": "^3.2.0"
}

didn't help. Using npm not yarn

use yarn please. npm has another issue with peer deps that they acknowledge is their fault.

Ouch, that's impossible :( In my company we moved back from yarn to npm some time ago and for some reasons (internal tools, ci/cd etc) I can't just use yarn.
What's the issue with npm? Maybe I can help.
That's really pity. docz seems to be great and offers exactly what we need...

npm workaround:
npm i<EMAIL_ADDRESS><EMAIL_ADDRESS>docz docz-theme-default

yea its a peer dep thing - https://twitter.com/ReBeccaOrg/status/1098310086269620225 but i didnt know you couldnt use yarn. yarn is just easier to tell people to use :) but yea you can use npm if you pin versions.

@sw-yx  so is this the current solution?
"resolutions": {
  "ansi-styles": "^3.2.0"
}

Closed in the newest release.

@pedronauck has rewarded $1.40 to @pedronauck. See it on IssueHunt

:moneybag: Total deposit: $2.00
:tada: Repository reward(20%): $0.40
:wrench: Service fee(10%): $0.20

npm workaround:
npm i<EMAIL_ADDRESS><EMAIL_ADDRESS>docz docz-theme-default

@ future wanderers: For another project, npm i<EMAIL_ADDRESS>solved it for me.


Aplhabet Game added

PR Description 📜
Fixes #439
Alphabet game added successfully.

Thank you @TusharMinche ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Thank you  @TusharMinche , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Small Makefile cleanup.

add target run_assistant to the phony targets
put source files together in _SRCS groups
add missing run_assistant_file.o to ASSISTANT_O target
do not link with libcurl

Very cool. Thanks a lot!


validation_split_percentage for train split is incorrect?

Hello,
thank you for releasing the code for your great LLM2Vec work!
I think the validation_split_percentage for train split if "validation" not in raw_datasets.keys(): is incorrect, see lines:
https://github.com/McGill-NLP/llm2vec/blob/main/experiments/run_mntp.py#L609
and
https://github.com/McGill-NLP/llm2vec/blob/main/experiments/run_mntp.py#L575
as this (val%)
split=f"train[{data_args.validation_split_percentage}%:]",

needs to be changed to 100% - val% = train%:
split=f"train[{100-data_args.validation_split_percentage}%:]",

unless I don't get the code fully.

Hello @MicPie,
Thanks for your interest in our work. The implementation seems correct to me. Let's say validation_split_percentage is set to 5% (default value), then the first 5% samples are set as validation (Line 567) and next 95% are set as train (Line 575).
The implementation is similar to HuggingFace  RoBERTa MLM script.
Let me know if you have any more queries.

Hi @vaibhavad , sorry you are right, I should have tested before, sorry for the creating the issue.


Use the local installation of openocd in place of the old one of the arduino package #4483

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: nedseb sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Press "Alt+Shift+F" in gdb.ts to lint it.
ERROR: /home/travis/build/Microsoft/pxt/cli/gdb.ts[45, 7]: missing whitespace
ERROR: /home/travis/build/Microsoft/pxt/cli/gdb.ts[45, 42]: missing whitespace
ERROR: /home/travis/build/Microsoft/pxt/cli/gdb.ts[53, 43]: trailing whitespace
ERROR: /home/travis/build/Microsoft/pxt/cli/gdb.ts[58, 24]: trailing whitespace
ERROR: /home/travis/build/Microsoft/pxt/cli/gdb.ts[62, 21]: trailing whitespace
ERROR: /home/travis/build/Microsoft/pxt/cli/gdb.ts[68, 1]: trailing whitespace
ERROR: /home/travis/build/Microsoft/pxt/cli/gdb.ts[83, 1]: trailing whitespace

PR: https://github.com/Microsoft/pxt/pull/4484


{Test} Regenerate test_aro_delete recording file

Description

More background:
https://github.com/Azure/azure-cli/pull/16101#issuecomment-742336610
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

#16101 is not compatible with #16131 because

#16101 was created first, and added some new requests, like GET https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_aro_delete000001/providers/Microsoft.Network/virtualNetworks/dev-vnet/subnets/dev_master000002?api-version=2020-06-01. The CI was ran using 2020-06-01 and passed.

#16131 bumped ResourceType.MGMT_NETWORK to 2020-07-01 and gets merged.

#16101 is merged after #16131, resulting in 2 api-versions for the same resource in different requests:
api-version=2020-06-01:
https://github.com/Azure/azure-cli/blob/85d96b07e386ffa56da5e96541b5caebee607a82/src/azure-cli/azure/cli/command_modules/aro/tests/latest/recordings/test_aro_delete.yaml#L7419
api-version=2020-07-01:
https://github.com/Azure/azure-cli/blob/85d96b07e386ffa56da5e96541b5caebee607a82/src/azure-cli/azure/cli/command_modules/aro/tests/latest/recordings/test_aro_delete.yaml#L816

This causes test_aro_delete to fail:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=648860&view=logs&j=771f6cdf-8d98-5d9b-2fb9-d3a6e9554788&t=0a182f1d-9946-580d-467e-4d4ebd6af32d&l=2628
2020-12-10T07:06:38.2367045Z AssertionError: Can't overwrite existing cassette ('/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/azure/cli/command_modules/aro/tests/latest/recordings/test_aro_delete.yaml') in your current record mode ('once').
2020-12-10T07:06:38.2369298Z No match for the request (<Request (GET) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_aro_delete000001/providers/Microsoft.Network/virtualNetworks/dev-vnet/subnets/dev_master000002?api-version=2020-07-01>) was found.


Better Sequelize error logging

At this time, when there is any error at all in the API application, we record the error in Honeybadger. We capture the Error object's message and stacktrace.
But sometimes, there are custom error objects being thrown. A very common scenario would be Sequelize.
In Honeybadger, I have a generic exception that gets thrown: SequelizeUniqueConstraintError. In honeybager, this error stacktrace and message are not helpful at all:

This is the error message and stacktrace you always get. No matter the endpoint, no matter the unique constraint error. You just get this.

Because this generic error is the 1 exception that is being thrown for all unique constraints that could happen in the app, it's not helpful at all.
Sometimes it's because of a unique constraint I set. Sometimes it's the sequence ID needing reset.
We need to have error handling for Sequelize and other custom errors to better log them.
Here are custom error objects from Sequelize. here is an example dump someone made for reference.
Proposal
For all DB operations that happen, have an error handler. The error handler will catch the error, parse it, and if it finds one of the custom errors from Sequelize, it will cast the error and then log to honeybadger a more detailed error giving the full details of the error.
This will help us to get a much better error logged for an exception because we will get more then just unique exception. Hopefully, we can...

Get the actual error from postgres defining what was unique that failed.
The stacktrace will be more accurate. Right now, we are getting a stacktrace that is just full of sequelize code. It would be great if we can have the stacktrace link to our DB function that we run in our app code so we can find out exactly what query was run in our app code.

Done.


scripts: twister: coverage: deal with multiple function definitions

Keep definitions instead of abort report creation.
The issue is occurs e.g for file zephyr/lib/os/sem.c
which has conditionally multiple definitions of  sys_sem_init function.
As different test can be configured to use different version of that function, gcovr is not able to prepare coverage properly.
It fails with message:
AssertionError: Got function sys_sem_init on multiple lines: 48, 109.
You can run gcovr with --merge-mode-functions=MERGE_MODE.
The available values for MERGE_MODE are described in the documentation.

Unfortunately, that breaks gcovr processing and no report is generated.
Regarding solution, suggested option merge-mode-functions solved the issue.
Possible values are:
https://gcovr.com/en/6.0/manpage.html#cmdoption-gcovr-merge-mode-functions
separate seems to be the most generic, allowing to show different versions of function.
However to benefit from that option, there is needed this change to be released:
https://github.com/gcovr/gcovr/pull/844

please keep only what is in scope of this fix - additional gcovr option --merge-mode-functions=separate

Done as you suggested, thanks ;)

What can I do with those failing UTs?
They are not related to my PR -  tests/lib/thrift/ThriftTest/thrift.ThriftTest.newlib.tlsTransport.


resource_types: Add link to file

:heart: Thank you for your contribution!
Description
Add link to default resource type file
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

[ ] I'm aware of the code of conduct.
[ ] I've created logical separate commits and followed the commit message format.
[ ] I've added relevant test cases.
[ ] I've added relevant documentation.
[ ] I've marked translation strings (for relevant code).
[ ] I've followed the CSS/JS and React guidelines (for relevant code).
[ ] I've followed the web accessibility guidelines (for relevant code).
[ ] I've followed the user interface guidelines (for relevant code).
[ ] I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
[ ] I've NOT included third-party code (copy/pasted source code or new dependencies).

Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

You license your contribution under the same terms as the current repository’s license.
You agree that you have the right to license your contribution under the current repository’s license.

Thanks, ready to merge!


Merge this repo into YarnSpinnerTool/YarnSpinner

The Yarn Spinner Language Server is written in C# and has a close dependency to the Yarn Spinner compiler (YarnSpinnerTool/YarnSpinner). This makes modifying the compiler in ways that affect the language server more complex, since the repos need to kept up to date with each other.
While we're not seeking to create a monorepo for the project (and we deliberately keep sub-projects separate, like we do with YarnSpinnerTool/YarnSpinner-Unity), I feel like the developer experience will be pretty significantly improved by merging this repo with YarnSpinnerTool/YarnSpinner.

This is now done as of YarnSpinnerTool/YarnSpinner@e9156c99e456374c206df7ea7289cdbeffb4ebf6.


Add name property to Icon component

<tap-icon-x></tap-icon-x> → <tap-icon name="x"></tap-icon>

@majidsajadi Please assign this to me

@amir78729
Im not pretty sure that this is the best approach for icon library.
Also I suggest create another repository for the icons since we can publish the icons right now.


How can I make the registration of a CustomeServiceProvider conditional on the tenant?

How can I make the registration of a CustomeServiceProvider conditional on the tenant?
I want to have 2 packages, the second package will be booted if the tenant allows it to boot
But after all the efforts, I couldn't execute conditions like tenancy()->tenant in AppServiceProvider
The method below doesn't answer as if event
TenancyBootstrapped is run before it is necessary to register a service provider
    Event::listen(TenancyBootstrapped::class, function (TenancyBootstrapped $event) {
         $this->app->register(shopServiceProvider::class);
    });

TenancyBootstrapped is run before it is necessary to register a service provider

More likely that it's the other way around

Yes . It run after it .
In fact, how to execute serviceProvider with event? Is it possible at all?

Depends on what the service provider does. What does shopServiceProvider do in your case?

shopServiceProvider It is the second package .I want the ShopServiceProvider to be executed when the tenant has the shop attribute

Please answer what exactly the provider does.


No work

So, I have the latest version of the game when i try to run MCDsavee edit it can't locate the game idky

Your minecraft dungeons save data should be located at %HOMEPATH%\Saved Games\Mojang Studios\Dungeons. Using the latest release everything works perfectly fine so far, so I cannot confirm any general issues