UGP-10031: Back to Browsing

Please always provide the Jira Issue your PR is for, as well as test URLs where your change can be observed (before and after):
Jira ID: UGP-10031
Test URLs:

Before: https://main--exlm--adobe-experience-league.hlx.page/docs/integrations-learn/experience-cloud/solution-categories/content-management
After: https://--exlm--adobe-experience-league.hlx.page/docs/integrations-learn/experience-cloud/solution-categories/content-management

Please fix code quality issues


Migrate openai client and HTTP streaming support from reqwest to hyper

Description
As a follow up to https://github.com/foundation-model-stack/fms-guardrails-orchestrator/issues/247 we need to also support HTTP streaming without using any reqwest related crates. The previously implementation using reqwest_eventsource will need to be replaced. The openai client is the only client to currently use HTTP streaming (rest are gRPC), so it may make sense to port the openai client from reqwest to hyper on its own as part of this issue.
Acceptance Criteria

sensible solution to HTTP streaming support using hyper
openai client uses hyper and whatever replacement streaming implementation in order to source SSE events

closing as the PR is merged


Maybe interesting: Toast, written in Rust

Hi @charleskorn ,
I had a look at this tool, Toast, and it looked somewhat similar to Batect. One major difference seems to be that there is only a single (shared) image across tasks, and that there is no orchestration across containers, limiting its use for tests.
The reason I post it here is to possibly give you inspiration for further developing Batect.
Cheers,
Sebastian

Hey @Byron-TW, thanks for sharing. That tool looks really interesting, I like its use of caching to speed things up. I'll definitely keep it in mind as I develop further features for batect!


How to specify cache_dir for shard lists?

I have a pipeline that looks like
        dataset = wds.DataPipeline(
            wds.ResampledShards(urls),   #  cache_dir='./_mycache'), <-- cache_dir not allowed here
            wds.tarfile_to_samples(),
            wds.shuffle(shuffle_vals[0]),
            wds.decode(wds.torch_audio),
            wds.map(partial(callback, sample_size=sample_size, sample_rate=sample_rate, verbose=verbose, **kwargs)),
            wds.shuffle(shuffle_vals[1]),
            wds.to_tuple(audio_file_ext),
            wds.batched(batch_size),
        ).with_epoch(epoch_len)

How do we turn on caching for lists of shards?  I'm not finding any automatic cache directory, and I unlike wds.WebDataset, wds.ResampledShards doesn't allow for a cache_dir kwarg.

On further inspection, it seems ResampleShards grabs a bunch of shards, untars them all to memory; we train on that group of data for a while, then we throw it all away and get a bunch of new shards, and train on those,..
....and ResampleShards never checks to see if it's already downloaded a shard;
the shard's files stay in memory until they're iterated-over but are then thrown away.
I had imagined that it would cache some set of shards to the local disk to make re-loading faster, but no.
Ready to close this Issue, I suppose.


Invalid Remote Function Snippet Completion after Public Keyword

Description:
public<cursor> public remote function name() {
}

In the above scenario, when we get the completions that particular snippet with the public keyword appears and leads to a syntax error
Affected Versions:
v1.0.0 at least

Closing the issue, since public qualifier is no longer a valid case for remote functions

Closing the issue, since public qualifier is no longer a valid case for remote functions


CI: change python-pyinotify to python3-pyinotify

This PR is an attempt to fix the failing CI GNU tests by removing the python-pyinotify dependency because the package is no longer in ubuntu.

Closing PR as it doesn't work and I currently don't know how to fix the issue.

thanks


Better way to handle completion options

Summary of the new feature / enhancement
There are several user requests to provide tab completion options for various things. Examples include:
https://github.com/PowerShell/PowerShell/issues/16747
https://github.com/PowerShell/PowerShell/issues/3118
https://github.com/PowerShell/PowerShell/issues/10064
https://github.com/PowerShell/PowerShell/issues/14337
Tab completion already includes a couple of options like [bool] RelativePaths and [bool]IgnoreHiddenShares but the current way to set such options is hard to discover and inconvenient to change on the fly.
For people that don't know, you need to modify the TabExpansion2 so both CompleteInput method calls use a hashtable with all the desired options set. There is an options parameter but if you try to set the default value there it gets ignored when you call TabExpansion2 with your tab key.
Proposed technical implementation details (optional)
Add a new variable similar to $PSStyle that contains all tabexpansion options, it could be called $PSTabExpansionOptions.
Another option would be to add 2 commands: Get-TabExpansionOption and Set-TabExpansionOption.

👍 re centralizing tab-completion customizations in principle, but surfacing them (publicly) in PowerShell itself strikes me as the wrong place; instead, they should be surfaced via PSReadLine or via PSES - see also: https://github.com/PowerShell/PowerShell/issues/18942#issuecomment-1384640574

Add a new variable similar to $PSStyle that contains all tabexpansion options, it could be called $PSTabExpansionOptions. Another option would be to add 2 commands: Get-TabExpansionOption and Set-TabExpansionOption.

Is it conceivable we would ever get tab-completion for a subset of native commands? I find it slightly odd that Powershell cannot tab-complete for pwsh. Other candidates would be commands that cmdlets call down to, like the DISM cmdlets. If I use dism.exe, Powershell won't help by tab-completion, even though it knows how to. Hypothetically:
Set-TabExpansionOption -KnownExecutables $true

@Andrew74L, providing tab-completion for an open-ended set of external CLIs is obviously impossible for PowerShell itself (though you could argue that for pwsh itself it should indeed be built in).
Third-party, community-supported projects are the solution - see the posh-cli module (repository is here).

Third-party, community-supported projects are the solution - see the posh-cli module (repository is here).

Thanks Michael

@mklement0 The problem with that approach is that every time a new option is added every interactive host author needs to update their app separately, and for editors that are no longer maintained (like ISE) you just lose the ability to set new options.
In the case of PSReadline it could also cause some confusion if people are running an older version of PowerShell with a new version of PSReadline and see a new feature that is unavailable to them.

PSReadLine is (a) the module that provides the interactive command-line editing experience, and (b) is bundled with PowerShell.
Yes, the fact that you can update PSReadLine independently of PowerShell is problematic (a problem that already affects Windows PowerShell with Set-PSReadLineOption -PredictionSource, for instance).
But I think that would be outweighed by the confusion that controlling the interactive experience in two distinct places, with different syntax would invite.


Overlap plugin not working when dealing with tasks fixed in time

Suppose you have a task that can be moved vertically (between different rows) but not horizontally (inside its own row). The overlap plugin seems not working well with this kind of tasks.
Plunkr: https://plnkr.co/edit/nbNF6GTMyUP13Sq1QElY
EDIT: After further research I discovered that the moveEnd event is not fired for this kind of tasks. I don't have the time now to dig into this but I suspect that this could be the cause.

Thank you ! It's fixed

Wrong fix :(

It's ok now :)


Create workflow that generates openapi doc & raises PR when triggered

Adds event listener that, when triggered, performs Tessera openapi generation and raises a PR against the gh-pages branch if there any changes.
The peter-evans/create-pull-request@v3 action will update the same PR if further changes are made before it is merged.  Once the PR is merged the branch will be deleted automatically.

Looks great, do you have any way to test it before we merge?


feature: allow customizing enum value serialization via annotations

Require the latest Dart SDK
Annotated enums fail without the CFE

Require the latest pkg:analyzer
Enum metadata parsing was just recently added

Require the latest pkg:source_gen
Uses multiple return values to allow generating shared helpers

Deprecates enum helpers in json_annotation
They can now be generated as part of the source, which minimizes
versioning issues with helpers.

Small, but breaking changes to Generator API to return multiple
values

Added addMember API to Context classes to allow helpers to be
generated.

Updated integration test code to include an annotated enum

Updated yaml test code to remove now superfluous convert logic and use
annotated enums instead

Fixes https://github.com/dart-lang/json_serializable/issues/38

Question for reviewers (@natebosch , @jakemac53 )
Should I create another annotation class – JsonEnumValue or similar?

Only using name field from JsonKey others are ignored
Would allow num values (as asked https://github.com/dart-lang/json_serializable/issues/38#issuecomment-400503308)

Just to give some reasoning: Integers are the default representation of enums in many other languages (e.g. C#, Kotlin, TypeScript), and it's also common to serialize enum values as integers, as it is a very efficient format.

@sir-boformer – added JsonValue class which supports String and int values.
@jacob314 – ready for review

@jakemac53 – PTAL


Multiple with postback

HI
I don't know if it is issue and maybe is something wrong with my code but:
I have select with multiple option on aspx page. When I select only one item, after post back this item is still selected. But when I select more than one item, after post back is selected only first item.
Is there any solution to keep all items selected after post back?
BR,
Thomas

See guidelines for contributing. Any chance you can link me to a demo or jsfiddle? Have you been able to reproduce this with a reduced test case?

I have the same issue, any idea how to fix it?


[CI build scripts] Building from forked repo

I've added unnecessary argument '--fork-url' for CI builds from forked repository.
Argument '--changed-repo' stays without changes, so if we want to run build for 'MediaSDK' from fork, we must send these arguments with next values (for example):
--changed-repo="MediaSDK:master:8cb6c52f18dbeedc54eb192faaa00c17b99aceec" --fork-url="https://github.com/dlobanox/MediaSDK.git"

@dlobanox can you write in bug (task) that you improved build-scripts and re-assigne it on me because it needs to make some preparations on my side.


[WIP] Add ability to toggle glass frame scroll motion

Hi,
This PR changes the default glass background behavior to be non-moving.
The old behavior can be enabled again by adding a class to the window, I also added another example for this to the documentation (into the "Glass frame & Color" section), so the difference is directly visible.
Thanks

I just found a video in which it seems like fixed would actually be the correct behavior.
I'll have to install Windows 7 myself to verify but in that case I would make fixed the explicit default and update the example just in case someone needs the other behavior.


TODO fg color is almost the same as bg in diff view

See above - the "TODO" color is almost the same as the diff addition green background.   Thanks for the override example.

On Tue, Apr 18, 2023 at 10:57:16AM -0700, Kai Ting wrote:

yup, just pointing it out FYI, not a big deal. Thanks for the override example.
--
Reply to this email directly or view it on GitHub:
https://github.com/rebelot/kanagawa.nvim/issues/140#issuecomment-1513582112
You are receiving this because you modified the open/close state.
Message ID: @.***>

that is the default implementation for the mentioned highlight group, if
you come up with a good combination of highlights I'll gladly accept a
PR!


2021 Report: KPIs

Establish a process to measure and assess each of the KPIs. These should be described and include:

Who is responsible for the measurement.
What is observed,
What is measured.
When measurement is done.

needs further clarification w/ reviewers

SUPSI have written up about it and their contrib is being integrated in the report.


use https instead of http for uploading a new version to pypi

Prefer https over http, based on:

https://twitter.com/glyph/status/580796504215924736
https://pypi.python.org/pypi/twine

@drslump you're right. Updated!

thanks


Want to include a folder for weird solutions to simple problems.

For example, a complex code to a very easy problem like printing sum of two numbers.
I believe this is a very fun way of learning.

That might be a good personal exercise, maybe won't interest other contributors.


Invisible Plugin in uxp

I have worked on this issue and I could manage to migrate the Invisible CEP extension to UXP. Please take a look and let me know if there is any problem.
@pklaschka @ErinFinnegan

🎉🎉 Thank you!! I can’t wait to look! (I’m on vacation this week.)

🎉🎉 Thank you!! I can’t wait to look! (I’m on vacation this week.)

Great Thanks! Looking forward to it!

@gregbenz Since its just a sample that shows the invisible plugin has loaded, i dont think so that its necessary to use await.

@pklaschka i've fixed the mentioned problems. Please take a look and let me know.

What triggers the the JS to get to plugin.create()? It seems like panels are normally not invoked prior to showing them during a PS session. And when I install a packaged CCX of this example, the alert does not show after PS startup, so it seems it never runs (other than when installed or enabled by CCD). As far as I can see, this plugin ultimately results in just showing a greyed menu item under Plugins once installed under the PS v24.

@gregbenz Since its just a sample that shows the invisible plugin has loaded, i dont think so that its necessary to use await.

Agreed, not critical, but someone might miss that the create method is async.

Agree with @gregbenz comment on async/await for the alert. If it is not consistently showing up in your UI, let's call that out in the README explicitly so people understand the expected behavior of the sample. @ThisIsMrAli

CCD)

I checked it with UXP devtool and it works well, I will check the CCX package too. Thanks for letting me now.

as @gregbenz mentioned,  plugin.create() triggers only the first time that you opened PS after you installed the plugin. I need to find another solution for this. i appreciate any help for this. @gregbenz @amandahuarng

@ThisIsMrAli Pablo and I tested in on our machines and found that for Photoshop - after first installation (whether locally or via CCX), the alert will show up. Please update your manifest to use v5 (and min version field) as shown in the screenshot below.
That should fix the alert not popping up when installing via CCX. We can merge this PR if we update the README to make it clear the entrypoints.plugin.create is called only once upon plugin installation. Therefore, if you want to see the alert again, you'll have to uninstall and reinstall in UDT (or disable then enable again on CCD).

@amandahuarng Thanks Amanda for your help! I have update the manifest to version 5. Since you got a better explanation about the Plugin.create function, would you please update the Readme.md file and merge the request?

@amandahuarng Thanks Amanda for your help! I have updated the manifest to version 5. Since you have got a better explanation about the Plugin.create function, would you please update the Readme.md file and merge the request?

Yes, I've added notes to the README and am merging this sample.


Check for matching field numbers in StartGroup / EndGroup tags

This is a port of https://github.com/bufbuild/protobuf-es/pull/810 from the v2 branch into the main (v1) branch.

Any reason to keep this as a draft?

@timostamm whoops, nope, moved to Ready for Review


Add indeterminate progress

#604

if it's helpful, here's Material's animation stuff that is very smooth:
https://github.com/material-components/material-components-web/blob/master/packages/mdc-linear-progress/_keyframes.scss

integrated this into my project just now and had no issues, works perfectly 🏆
Thank you sir


croc: 10.0.8 -> 10.0.9

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/croc/versions.
meta.description for croc is: Easily and securely send things from one computer to another
meta.homepage for croc is: https://github.com/schollz/croc
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 10.0.9 with grep in /nix/store/x1g8bv7z55yl8gclga7x0xyprqxd9bsq-croc-10.0.9
found 10.0.9 in filename of file in /nix/store/x1g8bv7z55yl8gclga7x0xyprqxd9bsq-croc-10.0.9

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

croc

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/x1g8bv7z55yl8gclga7x0xyprqxd9bsq-croc-10.0.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A croc https://github.com/r-ryantm/nixpkgs/archive/be5293d4257b60719c9db93d703ef00a99ab3a69.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/be5293d4257b60719c9db93d703ef00a99ab3a69#croc

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/x1g8bv7z55yl8gclga7x0xyprqxd9bsq-croc-10.0.9
ls -la /nix/store/x1g8bv7z55yl8gclga7x0xyprqxd9bsq-croc-10.0.9/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

croc

Maintainer pings
cc @HugoReeves @equirosa @SuperSandro2000 for testing.

Result of nixpkgs-review pr 322783 run on x86_64-linux 1

1 package built:

croc


[FEATURE] Changing default search to use "I feel lucky" option

Please Describe The Feature You Would Like To See
I am pushing the boundaries of the original config and struggle to add an argument to search query to switch parameters of the search in a way that "I feel lucky" option is used.
The idea is to type on start page "github", hit enter and get githuib opened even if GitHub is not saved as a link, instead of getting search engine page by default".
In this example I would like to get a query like this "https://duckduckgo.com/?q=!ducky+github" by using "https://duckduckgo.com/?q=!ducky+" as setting for search config. Yet its not giving me the result that I want

That is a great idea! I just tested the queries on my end, and it successfully redirected me to the page.
What I did was:

Update the settings with the duckduckgo query with bang
Write "excalith start page" to prompt area to trigger default search
App launches the duckduckgo and redirects to this github repository

Here is my settings for the default:
"search": {
   "default": "https://duckduckgo.com/?q=!ducky+{}",
}

And also you can define a "Feeling Lucky" shortcut as well
{
   "alias": "dd",
   "name": "DuckDuckGo Feeling Lucky",
   "url": "https://duckduckgo.com/?q=!ducky+{}"
}

They both seem to work on my end. If it does not redirect you to the page, you might need to give permission to redirect. If it redirects to a wrong page, I am not sure if it is related to our query since I tried bunch of different searches with different keywords.
Let me know what happens with the changes I mentioned above
Cheers

I laughed so hard, which led me think if it was an issue on my side :D I would definetely think your config might be wrong if you haven't already tested it in chrome. Just in case, you are using the settings.json for changes, right? Could you try config reset command if you haven't already? Maybe it was your former attempts on Safari. Just a wild guess, and probably you already done that.
The code should replace {}  with the query, it seems it appended your query after the {} somehow. I have to check the code for a possible mistake just in case.

I did try few things: reset, incognito tabs, etc. and getting to the same conclusion. last argument that issue is present on iPhone. If possible, would you try it on your Mac too? whenever you have time...


Use a config file to store chart conversion options

Looks good!  I am on a long summer vacation.  I will be back in mid August and look at details then.


reopening issue for dynamic styling - not resolved

Feature request 🚀

[ ] I will create Pull Request
[x] It's just a suggestion

Expected

Component or something else

reopening https://github.com/zeit-ui/react/issues/313
so I can do custom styling like so
<Avatar className="my-avatar" ... />
.my-avatar {
background: "black";
}

but if I want to do this dynamically for instance to set background to a color based on props how would i do that
please don't just close issues with no explanation - not productive thanks
Examples

Programme (Optional)
Others (Optional)

Here an online example, I'll give you 4 of the simplest solutions.
I mentioned the issue of weight in #240 :

All component styles have a weight of 2, you need weights greater than 2 to override them.
CSS styles have different priority, here are the detailed documents.

You just need to use any style that is higher than your current weight, If you think weight is boring you, Any JSS solution can easily solve this problem. such as styled-jsx, it's easier to add overlay styles:
import { resolve } from 'styled-jsx/css'
const { className, styles } = resolve`
    background: ...
`

const MyAvatar = ({ ...props }) => <Avatar className={className} {...props}>{styles}</Avatar>

got it thanks this is really helpful


ADSError: target port not found   ADS Server not started (6).

OS = "Oracle Linux 7"
Version = 7.5
The application is running in a docker container.
Actually is the application not able to create a connection to the PLC.
Running the same code on Windows everything works fine.
For linux I have to use an additional line in the code
pyads.set_local_address(local_net_id) // xxx.xxx.xxx.xxx.1.1
Communication from Server to PLC over port 48898 is working. Tested with telnet.
Any ideas what could be the reason for the port error?
Each kind of help appreciated.

On Linux you need to add a route to your plc manually.

Already done.
Route is added properly.
The way how I did.

Added the route with the system manager (windows)
Connected to the added PLC and I went to System and added the route manually.

Can you please provide a minimal code example that describes your approach.

is that enough to understand the approach how I want to open the connection?
port=pyads.open_port()
print(port)
pyads.set_local_address(local_net_id)
pyads.close_port()
plc = pyads.Connection(ams_net_id, ads_port)#, ip_address=ip_address)
print(ads_port)
plc.open()
yield plc

Please also post the Traceback.

problem solved. Network issue. The configured network card (virtual) was moved to another host and got another mac address. So the hyper-v server was not working properly and was not able to access the plc through the firewall.

problem solved. Network issue. The configured network card (virtual) was moved to another host and got another mac address. So the hyper-v server was not working properly and was not able to access the plc through the firewall.


Workfiles tool: Select latest workfile after model refresh

Changelog Description
Change selection to first index in workfiles view after refresh.
Additional info
This does now affect only workarea widget, and does not handle actual index data value, only uses first row (can be different index if sorted by names). Probably should be implemented for published workfiles too?
Testing notes:

When context selection changes, first workfile in view is selected.

Thanks - I appreciate the help!


Try fix TestMetricsExport

TestMetricsExport creates a lot of failures on CI lately. Here is a case where exporter never got updated. This means most likely that a previous test already had the backend set as expected but the port was different than the one expected later on.
I guess this happens only in tests and https://github.com/knative/pkg/issues/1672 is not fixed.
This fix makes logic about prometheus reconfiguration correct for testing purposes.
/cc @evankanderson

@markusthoemmes pls review.

@evankanderson pls review.

/assign @evankanderson

failing test seems related. It's the test that's supposed to be fixed, I  guess?

The failing test is in the OpenCensus path, so it's not directly related to this PR. It looks like maybe we missed an export RPC in that test run.

@evankanderson The failing path is due to the timeout where we dont get any records (assuming there is no race there or some bug at the opencensus side). Prometheus has a 10sec delay. Maybe if we are more generous to opencensus this will not happen.

/retest


Can't see full description of blame options in menu

Source:
https://github.com/divmain/GitSavvy/blob/2d41dec240e07434502206407373a9425a3c3631/core/commands/blame.py#L22

This is probably caused by your theme. Could you less up which theme you are using as well as sublime version?

Sublime Text 3 (build 3126)
Theme: https://github.com/equinusocio/material-theme Material Theme

I tested I can not reproduce.
This theme was several themes, which theme do you
I would like to see this setting.
  "color_scheme": "Packages/Material Theme/schemes/Material-Theme.tmTheme",

Also there are many settings, have you sent any of these?

"color_scheme": "Packages/Color Scheme - Default/Monokai.tmTheme",
	"indent_guide_options":
	[
		"draw_normal",
		"draw_active"
	],
	"line_padding_bottom": 2,
	"line_padding_top": 2,
	"material_theme_accent_cyan": true,
	"material_theme_appbar_charcoal": true,
	"material_theme_bullet_tree_indicator": true,
	"material_theme_compact_panel": true,
	"material_theme_compact_sidebar": true,
	"material_theme_contrast_mode": true,
	"material_theme_panel_separator": true,
	"material_theme_small_statusbar": true,
	"material_theme_small_tab": true,
	"material_theme_tabs_autowidth": true,
	"material_theme_tree_headings": true,
	"overlay_scroll_bars": "enabled",

I open an issue for material-theme I think it should be solved there.

https://github.com/equinusocio/material-theme/issues/1070

@equinusocio, this is a issue in you theme. I will close this issue. Please reopen if you feel like we can do anything.

This is a sublime related issue that doesn't recalculate the correct padding :(

Finally fixed with https://www.sublimetext.com/blog/articles/sublime-text-3-point-0

@equinusocio  🎉

I hope so.


kitty: wrap correct executable on macOS

Description of changes
This fixes the kitty wrapProgram step to wrap the
actual kitty executable, which on macOS is inside the App bundle. On macOS, $out/bin/kitty is just a symlink, and wrapping this symlink (instead of the executable in the App bundle) means that the wrapper is not used when starting the application itself (and the wrapper is only used when the bin/kitty executable is used, e.g. from terminal).
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build kitty

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/kitty-term-emulator-how-to-specify-custom-config/45413/1


Update README.md

This will cause failures in older versions of node:
SyntaxError: Unexpected token {

I suppose that instead of mentioning node version compatibility here, you could:

remove destructuring from https://github.com/jyu213/ssh2-sftp-client/blob/master/src/index.js
transpile index.js to output an older version of js before packaging

This was my bad - I forgot to update the README. There are some other things which need to be added as well. I also think that the module requires node 7.5.0 or later due to the use of async/await and the new exists method needs to be documented.


RFC: Add Response.halt() to terminate the RouteHandlerChain

Here is a halt() implementation that lets the ErrorHandler deal with the situation.  That's probably not right but it highlights what I think is a problem with the Response mechanism.  All the send() methods are suspect too - anything that commits from Response.
If you are writing API handlers you likely want them to return a Result object with a status code and an optional message.  Not all of those results are errors, but some are.  For example maybe I want to return:
response.xml().negotiate(request).sendOk("Saved {}", contact.getId());

BUT still close my open DB connection in the filter that should execute afterwards.  I recognize that will work today, but are we allowing people to break stuff by committing within the chain and not warning/failing afterwards.  It would be painful to call checkCommitted() for every possible setter.  In the filter that closes the DB I can set a header which will not be sent to the client because the response was committed in sendOk.
I'm open to suggestions on improving this.  I think we should consider following Spark's request processing loop.  I also think we need to consider a Result class which is returned for unspecified bodies or something like that.

After thinking about it some more, I don't think we need this PR.  Either we send a Result and break the chain or we throw an exception and send an Error.  I'm going to explore revising the send methods.
Perhaps the best solution would be to allow consumers of Pippo to optionally define a subclass of Response.  This way the implementation could be extended without adding a ton of methods to the base Pippo Response class.  Of course if you consider doing that then it would make sense to allow definition of a subclass of Request.


Revert "Fix UnicodeDecodeErrors in the theme update checks service (issue #1090)"

Reverts mozilla/olympia#1091

Reverted following discussion on irc:  19:08 	<jason>	andym: https://github.com/mozilla/olympia/issues/1090 can we back out this change? my attempts to fix it via LC_ALL, LANG settings in uwsgi did not work so I need more time to take a look at what is going on


bgpv1: set running flag in manager

BGP Manager to unset running flag when Stop is called. This is to fix flaky tests where reconcile gets called after Stop, which recreates BGP servers at shutdown stage.
Fixes: #28415

/test


Update issue templates

Codecov Report

Merging #554 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #554   +/-   ##
=======================================
  Coverage   71.90%   71.90%
=======================================
  Files          79       79
  Lines        3107     3107
=======================================
  Hits         2234     2234
  Misses        873      873

Flag
Coverage Δ

#unittests
71.90% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f445399...2aebe9e. Read the comment docs.


Tabs on individual space, property, and theorem pages are sometimes broken.

As discussed in #133 (though the issue seems to be in the main branch)
Going to the main page, https://topology.pi-base.org/
then clicking on the spaces tab, then clicking on an individual space, seems to lead to a situation where the tabs on that space (properties and references) have broken links with an extra slash - leading for example to https://topology.pi-base.org/spaces/S000005//references, which gives a 404.
On the other hand, after landing on the 404 page, if one continues to navigate through the site (including going back in the browser), the tabs seem to be repaired and everything works fine.
Also, direct linking to a space's page seems to avoid this issue, e.g., https://topology.pi-base.org/spaces/S000005/
Finally, the same issue appears to happen with individual Properties and Theorems as well.

I have a hacky solution at #136 to just check for the extra slash and drop it.
What's not clear to me is why sometimes we're linking to /spaces/all/ and sometimes /spaces/all. And why sometimes we successfully redirect /spaces/all/ to /spaces/all and sometims we don't.


[qplex_core.py] Could you please explain more how it works?

Hi, I'm interested in the concept of QPLEX. (Is it from the solver IBM CPLEX right?) I already read 'README.md' but I can't totally figure the 'qplex_core.py' yet.

Could you please explain more about the functions in 'qplex_core.py'.

Could we extend the QPlex to solve as Non-linear Programming (NLP)?

Dear dongsin-kim,
First of all, thanks for your interest. Yep, it's based on IBM CPLEX, but still on an early development.
We tried to make a solver for generic functions receiving a function with different variables and a condition (currently condition is like  ax+by+c*z <= beta). you can check an example at the main.
We encode the number (integer) as binary on severl qbits (as many as precission specified).
And of course you can extend QPlex, it has a MIT license, and if that helps you, we are delighted to know.¨
Regards

Dear gatchan00,
Hello.
Thank you for your reply-! Oh, I see. I am really surprised with your idea.
Maybe, I need more time to look into the code. I hope to keep in touch.
And I hope you have a great day. :-)
Best regards,
Dongsin

You are welcome,
If you need something, just ask for it.
Regards


remove the gap between the shaded header and the article listing

@saeedmb8 Ready for review

:+1:


[Tensorflow] Fix conv2d_transpose for NHWC layout

If "data_format" == "NHWC", the kernel_layout for conv2d_transpose should be "HWOI" rather than "HWIO".

As we can see in frontend about conv2d_transpose
, the kernel_layout for conv2d_transpose was set as "HWOI" when the data_layout='NHWC', while the Tensorflow frontend set the kernel_layout='HWIO' mistankenly.  I submitted this PR to fix it.
@leandron @vvchernov  Please help me review this PR. Thanks!

@jikechao  it would be good to add test cases for this fix

Hello @jikechao! Good fix. It looks like misprinting or thoughtless ctr+c, ctr+v from conv condition. I agree with @yongwww CI test is needed to check it

@yongwww @vvchernov Thanks for your review.
I tried to construct a test case to trigger this bug but failed. By analyzing the source code, I found that the wrong logic statement is in a dead code.  Specifically, when the op_name=='conv2d_transpose' and layout='NHWC', the layout was reset to 'NCHW' in this line. Thus, the condition if attr["data_format"] == "NHWC" always be False.
I deleted the wrong logic in the dead code. Please help me review it again. Thanks!

@echuraev Indeed, this link can't redirect to the highlight place by clicking it directly. As a workaround, you can open this link by copying this link and past it into a new browser window.
I'll add a unit test sooner!

@echuraev CI fixed, could you merge this PR?

@jikechao Thank you for your work :)


Proto refactor

Fix pep8 problems and refactored some of the larger methods.

Parts of this request have been considered and (optionally) included during rewrites and updates. Thanks!


[BQ Storage] Allow using optional minutes in timestamp offset

Fixes #26796
We currently use DateTimeFormatterBuilder's appendOffsetId() to construct our timestamp pattern. However, appendOffsetId() requires minutes. These changes replace that with a custom pattern "+HH:mm:ss" that requires hours but all else is optional. This matches the examples we see in BQ documentation: https://cloud.google.com/bigquery/docs/reference/standard-sql/timestamp_functions#timestamp

retest this please

Caused by: java.lang.IllegalArgumentException: Invalid zone offset pattern: +HH:mm:ss
	at java.time.format.DateTimeFormatterBuilder$OffsetIdPrinterParser.checkPattern(DateTimeFormatterBuilder.java:3341)

Thanks!


variable can't be selected after the flyout closes then shows

Expected Behavior
When I set flyout to be autoclose, and then click the category icon to bring out the flyout, I should be able to click the checkbox next to any variable to display its value in the stage.
Actual Behavior
Currently after the flyout pops out, I can't check any of then checkboxes.
Steps to Reproduce

Set flyout's autoclose to true.
load any project
drag any block off the flyout so that the flyout would collapse.
click any category icon to bring out the flyout.
try to click the checkbox next to any variable.

Operating System and Browser
Windows 10, Ubuntu
Chrome

Auto closing a flyout is not supported in Scratch.


Lh5443 fix uploading checksum time consuming issue

longhorn/longhorn#5443
When after syncing file there is a post-processing function finishProcessing which will get file checksum and write config.
GetFileChecksum may be time consuming and can lead to client timeout if file is large.
This PR move it to a goroutine to make the api return to client first. After calculating the checksum, it will still update the state of syncfile to ready and then Longhorn will automatically do the following job (e.g. transfer file to manager)

Test Result
Phase1

As you can see from POST request, when the upload finished, server responded immediately (waiting: 465ms)
The state was still in-progress
Data source server was still calculating the checksum

Phase2

Data source server finished calculating checksum and saved config file
State became ready

Hi @shuo-wu I have moved the calculating checksum out of lock and squashed all commits into one to make it easy for review.
Thanks
Hi @innobead, I am curious about the codefactor standard. It shows the code is complex but I have no clue how to fix it, any suggestions, thanks!

Hi @innobead, I am curious about the codefactor standard. It shows the code is complex but I have no clue how to fix it, any suggestions, thanks!

@ChanYiLin What CodeFactor suggests does not necessarily mean we need to fix it that way, as it depends on different contexts. However, it can give us an idea of how to improve the code based on the existing style and pattern.

Hi @innobead, I am curious about the codefactor standard. It shows the code is complex but I have no clue how to fix it, any suggestions, thanks!

@ChanYiLin What CodeFactor suggests does not necessarily mean we need to fix it that way, as it depends on different contexts. However, it can give us an idea of how to improve the code based on the existing style and pattern.

You can also follow the CodeFactor suggestions to see what is reasonable to refactor and lower the complexity.

In your case, maybe abstract file checksum validation logics in postProcessSyncFile to a separate method.

feat(#5443): make getting file checksum async in post processing

Suggest avoiding prefixing the issue number with #, this could potentially create a hyperlink to the issue in the project. You can reference how other commit messages add the issue number.
Ref: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

feat(#5443): make getting file checksum async in post processing

Suggest avoiding prefixing the issue number with #, this could potentially create a hyperlink to the issue in the project. You can reference how other commit messages add the issue number.
Ref: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

thanks for the advise, fixed

@Mergifyio backport v1.4.x v1.3.x


'Plagiarism checks': UI bug

Describe the bug
The clean-up button on plagiarism checks results in a bug in the UI (see the screenshot)
To Reproduce

Run a plagiarism check
Clean up
Verify you get the same box as in the screenshot

Expected behavior
Should not have this error in the UI
Screenshots

Which version of Artemis are you seeing the problem on?
7,0,2
What browsers are you seeing the problem on?
Microsoft Edge
Additional context
No response
Relevant log output
No response

Could someone assign this issue to me?

Ive tried to debug the issue, but it seems like it is deeply rooted somewhere else, possibly not even in the Client Side. It seems like the doesnt appear on Modeling Plagiarism Results. I'm not familiar with the backend at all, could someone from the backend double check this?


WIP: Re-order Plugins page

First explain what plugins are and what kinds of plugins exist
Then explain how to use them.
Finally, for the "advanced users", explain how to write them.

@chrisvfritz what do you think?

@LinusBorg I think this change makes perfect sense. Is it still WIP, though?

Is it still WIP, though?

Only insofar as I wanted feedback. I don't have anything more to add.

Great! I'll take the liberty to go ahead and merge it then :)


Multiple Swaps

Is it possible to have multiple swaps in one transaction?
For instance, uusd -> uluna -> uusd? All in one transaction.

Is it possible to have multiple swaps in one transaction?
For instance, uusd -> uluna -> uusd? All in one transaction.

Hello, Kindly chat with one of our support agent on live chat to get a quicker response CLICK HERE.

Terra Network Live Support.
We received your request kindly visit the official website to chat With a live support for further assistanceclick here

Terra Network Live Support.
We received your request kindly visit the official website to chat With a live support for further assistanceclick here

A router contract can wrap multiple swaps in one message. Otherwise multiple messages can be included in one transaction.

Is it possible to have multiple swaps in one transaction?
For instance, uusd -> uluna -> uusd? All in one transaction.

Hello, A support ticket has been opened for you with Support ticket number TB7836HH. You should talk to a Terra money Dev on the LIVE SUPPORT PAGE So that your transaction can be looked into. Thank you. CLICK HERE

Is it possible to have multiple swaps in one transaction?
For instance, uusd -> uluna -> uusd? All in one transaction.

Hello, A support ticket has been opened for you with Support ticket number TA836HH. You should talk to a Terra money Dev on the LIVE SUPPORT PAGE So that your transaction can be looked into. Thank you. CLICK HERE

close this due to no response. feel free to reopen it if you want.


[vcpkg baseline][pangolin] Set CMAKE_DISABLE_FIND_PACKAGE_XX  to ON

Fixes https://github.com/microsoft/vcpkg/issues/17005
The original PR https://github.com/microsoft/vcpkg/pull/17014 main to avoid finding the package automatically, however, it set wrong value there.

My fault, sorry..

@strega-nil, could you please help merge this PR?


Sort the mess in spatial_tools.py

Right now it's a bit our "dumper" module.
Looking at what's inside, I think we could split into:

a robust_stats.py module, that includes nmad, nd_binning, robust_polynomial_fit, robust_sumsin_fit, subsample, and all related subfunctions
move stack_rasters, merge_rasters, merge_bounding_boxes, get_array_and_mask, etc... to geoutils
rename spstats into spatial_stats.py for consistency with robust_stats.py

@erikmannerfelt @adehecq An opinion on this?

I agree on your division! I would like to discuss the robust_stats.py, however, as I interpret "robust" as just another synonym for "good". It would (for me) sound like calling it good_stats.py (as opposed to the bad_stats.py? ;) ). Maybe I'm alone on that opinion? What do you think, @adehecq?
I especially agree on the -> geoutils suggestions.

Maybe there's a better subdivision for that module?
For the naming robust, it is the term widely used in statistics for this kind of methods, from a "simple" NMAD to more complex M-L methods like RANSAC (https://en.wikipedia.org/wiki/Robust_statistics).

Ok to move some of the functionalities to geoutils.
Should it be in georaster directly? Right now, it's mostly just one class and not really a lot of other functions, but this can change.

CLosed with 226


TypeError: Expected object to be categorical, found string when doing g_bwd.set_terminal_states()

Hello CellRank,
I compute the initial state automatically by g_bwd.compute_terminal_states(), but the result is not consistent with the existing knowledge. So we tried to set the initial state manually by g_bwd.set_terminal_states(), but we met TypeError.
Appreciate it if you could help us with this issue.
Thanks!
Best,
YJ

g_bwd.compute_terminal_states()
adata.obs['initial_states']
Name: initial_states, Length: 1906, dtype: category
Categories (1, object): ['Squamous epithelial']

g_bwd.set_terminal_states(labels=['Proliferating'])
~\anaconda3\envs\HYJ_py38\lib\site-packages\cellrank\tl\estimators\terminal_states\_term_states_estimator.py in set_terminal_states(self, labels, cluster_key, add_to_existing, **kwargs)
    112             existing = None
    113
--> 114         states, colors = self._set_categorical_labels(
    115             categories=labels,
    116             cluster_key=cluster_key,

~\anaconda3\envs\HYJ_py38\lib\site-packages\cellrank\tl\estimators\terminal_states\_term_states_estimator.py in _set_categorical_labels(self, categories, cluster_key, existing)
    200             categories = _convert_to_categorical_series(categories, list(self.adata.obs_names))
    201         if not is_categorical_dtype(categories):
--> 202             raise TypeError(f"Expected object to be `categorical`, found `{infer_dtype(categories)}`.")
    203
    204         if existing is not None:

TypeError: Expected object to be `categorical`, found `string`.

TypeError: Expected object to be `categorical`, found `string`.

Versions:
scanpy==1.8.2 anndata==0.7.8 umap==0.5.2 numpy==1.21.5 scipy==1.7.3 pandas==1.3.5 scikit-learn==1.0.2 statsmodels==0.13.1 python-igraph==0.9.9 pynndescent==0.5.5
scvelo==0.2.4  scanpy==1.8.2  anndata==0.7.8  loompy==3.0.6  numpy==1.21.5  scipy==1.7.3  matplotlib==3.5.1  sklearn==1.0.2  pandas==1.3.5
cellrank==1.5.1 scanpy==1.8.2 anndata==0.7.8 numpy==1.21.5 numba==0.55.0 scipy==1.7.3 pandas==1.3.5 pygpcca==1.0.3 scikit-learn==1.0.2 statsmodels==0.13.1 python-igraph==0.9.9 scvelo==0.2.4 pygam==0.8.0 matplotlib==3.5.1 seaborn==0.11.2

...

Hi @hyjforesight ,
.set_terminal_states accepts these types of inputs:

either you supply a categorical pandas.Series where non-NaN values mark the terminal states
or you pass as a dict of e.g. {'prolif1': ['obs_name1', ...], 'prolif2': ['obs_name2', ...]}
or you pass as a dict with 1 key only corresponding to a categorical adata.obs, e.g.,
labels={'clusters': ['Proliferating']} would set 1 set of terminal states (named 'Proliferating') defined by adata.obs['clusters'] == 'Proliferating'

Hello @michalk8
Thanks for the response. I called the labels={'clusters': ['Proliferating'] and error was solved. It was my fault that I was not familiar with the dist operation. Thanks for your help!
Best,
YJ


The logic of joining the network

For example: it requires 2 approvals to enter the network

sequence diagram

1st join: 1 approval
next joins: 2 approvals (if it is too difficult then discard this ticket)
password as an alternative -- think about that


Where to put setup file for CRA

Would you accept a PR for updating the Install documentation with a note where to create the setup file when using Create React App? Or maybe something to be added in Common Issues?
Maybe its not a big problem but i needed some searching before i found issue #1265 and @FezVrasta
comment that helped me in the right direction!
Create a file src/setupTests.js and put setup content inside it.

Mentioned it in this PR: https://github.com/airbnb/enzyme/pull/1396

The thing is that with CRA this config is automatic, so people just have to create the setupTests.js, without any ejection or custom config.


docs(rating): component rating docs

TASK: #1577
Description, Motivation and Context
Following API proposal, we now want to complete documentation on Rating component.
Types of changes

[x] 🧾 Documentation
[x] 📷 Demo

Screenshots - Animations

@andresin87 regarding the issue of the input having value="3" on the readOnly story. I read the spec of the range input, and it seems value here is a string representation of the selected number. We don't have to round the number to the closest integer it seems.
I think @acd02 you checked on a screen reader and it reads out loud the value attribute.
So maybe we could just set the value attribute to 3.5 and it would work well. Screen readers users would have the same value as other users. WDYT ?

@andresin87 regarding the issue of the input having value="3" on the readOnly story. I read the spec of the range input, and it seems value here is a string representation of the selected number. We don't have to round the number to the closest integer it seems.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/range#value
I think @acd02 you checked on a screen reader and it reads out loud the value attribute.
So maybe we could just set the value attribute to 3.5 and it would work well. Screen readers users would have the same value as other users. WDYT ?
Our rating component would look like this (my proposal is to keep the step to 0.5 as our component support half-stars, and not open the prop):
<input type="range" min="0" max="5" step="0.5" value="3.5" />

So in short terms you suggest to udpate the input step to 0.5, right? Just to be sure I understood correctly :sweat_smile:

@acd02 and these are the spec when the input is interactive. In readOnly mode it will display half-stars.

I believe that this method of discussing is not the most practical, @Powerplex . Additionally, the goal of this PR is to add stories, which is not directly related to the internals of the component. Maybe you could create a separate github discussion for this?

@andresin87 @Powerplex @acd02 Here is a proposal PR: https://github.com/adevinta/spark/pull/1636


Cleaned up easter egg 🥚

Hey @KNIF   👋
Thanks a lot for your contribution! Please head over to our discord and share the PR link with us to claim your swags 🎁


Artists with identical names don't belong together

You've solved the Crystal Castles problem (thanks!), but what about cases where
two artists have the same name? It seems to be a surprisingly rare event in
practice, but recently I added an album "The Fence Around My Grave" by Goose
(http://goosemusic.bandcamp.com/) which went into the same folder as "Synrise"
by a different Goose (http://en.wikipedia.org/wiki/Goose_(band)).

It irks me that they're in the same folder since they are from different bands.
Last.fm's approach is to (strangely) merge all artists of the same name, which
I don't like; MusicBrainz has its disambiguation comments. However in my case,
the first Goose isn't in the MusicBrainz database, so there's no disambiguation
comment for them. Could there be something equivalent to %aunique{} for artists?

It's less pressing since the files of each album are still in their own folders
unlike with the Crystal Castles problem, but it would still be a nice feature
to have.

(As a minor aside, the documentation for %aunique{} has a typo in the third
paragraph where it's spelled %auniqe{})

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 20 May 2012 at 12:22

Do not comment here, but on sampsyo/beets#155


Fragments

Coverage decreased (-0.7%) to 97.005% when pulling ce7726065814a24a1809d006e114daf4ba0dcd3e on plusgut:fragments into b14549f1903a61368b3d1b8f52e8ce2ea1e6ffe4 on plusnew:master.


rrdtool: add passthru.perlModule

... so it can be used in perl.withPackages
A bit tricky though, because rrdtool is not in perlPackages
perl.withPackages(p: [ (rrdtool.override{ inherit (p) perl; }) ])

Can you add it to perlPackages?

Can you add it to perlPackages?

It might be a good solution (all the .override{ inherit perl; } would be grouped in one place) , but it should go together with deprecation of direct usage the packages outside perlPackages as perl packages (there are many of them: nix.perl-bingings, net-snmp, dpkg, munin, git, monotone, rxvt, xscreensaver, slimserver, zoneminder, libapparmor, ...)
Or at least perl.withPackages(p: [rrdtool]) and makePerlPath rrdtool should somehow print a warning "please use perlPackages.rrdtool instead".
Now the perl packages without passthru are silently ignored and it is confusing.
For example in the code below nix.perl-packages is silently ignored
https://github.com/NixOS/nixpkgs/blob/89cbf201234ff223a1bd6bfe053c74232f4aa18b/pkgs/tools/package-management/nix-serve/default.nix#L28
(yes, it should also have .override{ inherit (p) perl; } for correctness :))

pkgs.rrdtool may be built without perl module and pkgs.perlPackages.rrdtool with it
like pkgs.boost and pkgs.pythonPackages.boost
https://github.com/NixOS/nixpkgs/blob/276d82476bfdb0ba085909986f5c959c3ef4b904/pkgs/top-level/python-packages.nix#L1171-L1174

At least nix.perl-bindings -> perlPackages.nix looks plausible

Basically the choice is: either to add quick fixes which merely add passthru therefore they break nothing and they cause no rebuild or start doing refactoring which would break the interface.

ping ... @Infinisil? (triage)

Looks good, I can merge after the conflicts are fixed

(needs a rebasing still)


add VALUE Property; PatternNotSupported lost in last pr 120

@Nepitwin pls review.

I would suggest i will do these small name changes and include you to contributor and merge your source code here. Value pattern support is a nice include from you.


Compilation issue with GCC 6.1.1

We migrated from CentOS 6 with gcc4.9 to CentOS 7 with gcc 6.1.1.
While trying to rebuild pbbam for that architecture I ran into issues with gtest.
It looks as if make is somehow trying to change the Dprivate and Dpublic flags and the error results in a redeclared with different access message.
[ 68%] Building CXX object tests/CMakeFiles/test_pbbam.dir/src/test_AlignmentPrinter.cpp.o
In file included from /builddir/build/BUILD/gtest/include/gtest/internal/gtest-port.h:212:0,
                 from /builddir/build/BUILD/gtest/include/gtest/internal/gtest-internal.h:40,
                 from /builddir/build/BUILD/gtest/include/gtest/gtest.h:58,
                 from /builddir/build/BUILD/pbbam-0106cdf0a2c71ed3195d971b6972b6200dfe66f3/tests/src/test_Accuracy.cpp:42:
/software/include/c++/6.1.1/sstream:300:7: error: 'struct std::__cxx11::basic_stringbuf<_CharT, _Traits, _Alloc>::__xfer_bufptrs' redeclared with different access
       struct __xfer_bufptrs
       ^~~~~~
In file included from /builddir/build/BUILD/gtest/include/gtest/internal/gtest-port.h:212:0,
                 from /builddir/build/BUILD/gtest/include/gtest/internal/gtest-internal.h:40,
                 from /builddir/build/BUILD/gtest/include/gtest/gtest.h:58,
                 from /builddir/build/BUILD/pbbam-0106cdf0a2c71ed3195d971b6972b6200dfe66f3/tests/src/test_AlignmentPrinter.cpp:43:
/software/include/c++/6.1.1/sstream:300:7: error: 'struct std::__cxx11::basic_stringbuf<_CharT, _Traits, _Alloc>::__xfer_bufptrs' redeclared with different access
       struct __xfer_bufptrs
       ^~~~~~
[ 69%] Building CXX object tools/pbindex/CMakeFiles/pbindex.dir/src/main.cpp.o
make[2]: *** [tests/CMakeFiles/test_pbbam.dir/src/test_Accuracy.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....

I tried to change the definitions for your gtests
by replacing #define private public with #define private private which resulted in other errors due to access problems.
Subsequently I declared in the CMakeLists.txt PacBioBAM's unit tests as off.
This works but obviously is only a work-around instead of a fix..

--- CMakeLists.txt.o    2017-06-08 09:58:59.889735232 +0200
+++ CMakeLists.txt      2017-06-08 09:59:50.523680131 +0200
@@ -14,7 +14,7 @@

 # list build-time options
 option(PacBioBAM_build_docs    "Build PacBioBAM's API documentation."                   ON)
-option(PacBioBAM_build_tests   "Build PacBioBAM's unit tests."                          ON)
+option(PacBioBAM_build_tests   "Build PacBioBAM's unit tests."                          OFF)
 option(PacBioBAM_build_shared  "Build PacBioBAM as shared library as well."             OFF)
 option(PacBioBAM_build_tools   "Build PacBioBAM command line utilities (e.g. pbindex)"  ON)
 option(PacBioBAM_wrap_csharp   "Build PacBioBAM with SWIG bindings for C#."             OFF)

Yes, this is a serious problem for the pbbam tests, as currently written.
$ git grep 'define private public' | wc -l
35

For VS2012+, we use this trick in tests/CMakeLists.txt:
if(MSVC)
    # VS2012+ pooh-pooh's Derek's "#define private public" trick
    add_definitions(-D_ALLOW_KEYWORD_MACROS)
endif()

Ultimately, we need some refactoring to make the internals testable. Short term, the simplest solution is to make everything explicitly public.

This is batshit crazy. GCC has a -fno-access-control flag which might be a better way to do whatever it is you're trying to do, without redefining C++ keywords.

Alternatively, only redefine private after including all third-party headers, so it only affects your own code and not standard headers like <sstream>. That's still disgusting and crazy, but it might just work.

No, I completely agree. That was purely an admittedly gross hack for testing, from back in the very initial development phases. It just hadn't been removed yet. That said, I'm well aware and it's already on my board to remove it soon.
Thanks for the feedback and apologies about any convenience in the meantime.

Derek

On Sep 27, 2017, at 8:03 AM, Jonathan Wakely<EMAIL_ADDRESS>wrote:
Alternatively, only redefine private after including all third-party headers, so it only affects your own code and not standard headers like . That's still disgusting and crazy, but it might just work.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I have shifted the headers around and the definition of the macro hack, pbbam builds fine for us with GCC 6 and 7 for some time already.
@jwakely Agreed, redefining C++ keywords is iffy, unfortunately there'y no portable -fno-access-control across compilers. Once we got rid of our CMake stuff, we might just switch to using -fno-access-control from Meson, but for now, correct placement of #define private public allows us to build fine.


Update README.md to reflect proper install branch

README.md gives instructions on how to run this code. It does not, however, specify that the "windows" branch needs to checked out first. Please update README.md to reflect this.

This actually is documented here: https://github.com/joerg/LabViewGitEnv/tree/master#3-update-labviewgitenv in the second code line. Do you think it would be better to make this step more explicit?


errors in bash script

[128][mona.goku: DJ-RN]$ bash script/Generate_Ambiguous_HOI.sh
script/Generate_Ambiguous_HOI.sh: line 2: $'\r': command not found
script/Generate_Ambiguous_HOI.sh: line 3: cd: $'Data\r': No such file or directory
script/Generate_Ambiguous_HOI.sh: line 4: $'\r': command not found
script/Download_data.py:45: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if len(sys.argv) is not 3:
^CTraceback (most recent call last):
  File "script/Download_data.py", line 52, in <module>
    download_file_from_google_drive(file_id, destination)
  File "script/Download_data.py", line 40, in download_file_from_google_drive
    save_response_content(response, destination)
  File "script/Download_data.py", line 27, in save_response_content
    f.write(chunk)
KeyboardInterrupt

Thanks for using. Would you mind provide more detailed information on the environment you used?

@Foruck
15856/31773MB
[18986:2271 0:440] 07:15:52 Wed Dec 23 [mona@goku:pts/3 +1] ~/research/code
$ git clone https://github.com/DirtyHarryLYL/DJ-RN.git
Cloning into 'DJ-RN'...
remote: Enumerating objects: 90, done.
remote: Counting objects: 100% (90/90), done.
remote: Compressing objects: 100% (90/90), done.
remote: Total 199 (delta 50), reused 0 (delta 0), pack-reused 109
Receiving objects: 100% (199/199), 5.25 MiB | 7.57 MiB/s, done.
Resolving deltas: 100% (83/83), done.
16100/31773MB
[18986:2271 0:441] 07:16:07 Wed Dec 23 [mona@goku:pts/3 +1] ~/research/code
$ cd DJ-RN/
16185/31773MB
[18986:2271 0:442] 07:16:11 Wed Dec 23 [mona@goku:pts/3 +1] ~/research/code/DJ-RN
$ bash script/Generate_Ambiguous_HOI.sh
script/Generate_Ambiguous_HOI.sh: line 2: $'\r': command not found
script/Generate_Ambiguous_HOI.sh: line 3: cd: $'Data\r': No such file or directory
script/Generate_Ambiguous_HOI.sh: line 4: $'\r': command not found
script/Download_data.py:45: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if len(sys.argv) is not 3:

^CTraceback (most recent call last):
  File "script/Download_data.py", line 52, in <module>
    download_file_from_google_drive(file_id, destination)
  File "script/Download_data.py", line 40, in download_file_from_google_drive
    save_response_content(response, destination)
  File "script/Download_data.py", line 25, in save_response_content
    for chunk in response.iter_content(CHUNK_SIZE):
  File "/home/mona/anaconda3/lib/python3.8/site-packages/requests/models.py", line 751, in generate
    for chunk in self.raw.stream(chunk_size, decode_content=True):
  File "/home/mona/anaconda3/lib/python3.8/site-packages/urllib3/response.py", line 571, in stream
    for line in self.read_chunked(amt, decode_content=decode_content):
  File "/home/mona/anaconda3/lib/python3.8/site-packages/urllib3/response.py", line 766, in read_chunked
    chunk = self._handle_chunk(amt)
  File "/home/mona/anaconda3/lib/python3.8/site-packages/urllib3/response.py", line 719, in _handle_chunk
    returned_chunk = self._fp._safe_read(self.chunk_left)
  File "/home/mona/anaconda3/lib/python3.8/http/client.py", line 612, in _safe_read
    data = self.fp.read(amt)
  File "/home/mona/anaconda3/lib/python3.8/socket.py", line 669, in readinto
    return self._sock.recv_into(b)
  File "/home/mona/anaconda3/lib/python3.8/ssl.py", line 1241, in recv_into
    return self.read(nbytes, buffer)
  File "/home/mona/anaconda3/lib/python3.8/ssl.py", line 1099, in read
    return self._sslobj.read(len, buffer)
KeyboardInterrupt

16324/31773MB
[18986:2271 0:443] 07:16:25 Wed Dec 23 [mona@goku:pts/3 +1] ~/research/code/DJ-RN
$ lsb_release -a
LSB Version:	core-11.1.0ubuntu2-noarch:security-11.1.0ubuntu2-noarch
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.1 LTS
Release:	20.04
Codename:	focal
16324/31773MB
[18986:2271 0:444] 07:16:34 Wed Dec 23 [mona@goku:pts/3 +1] ~/research/code/DJ-RN
$ python
Python 3.8.5 (default, Sep  4 2020, 07:30:14)
[GCC 7.3.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>

$ dos2unix  script/Generate_Ambiguous_HOI.sh
dos2unix: converting file script/Generate_Ambiguous_HOI.sh to Unix format...

fixed the issue.

also, relative addresses in the bash script are wrong
examples:

python: can't open file 'script/Download_data.py': [Errno 2] No such file or directory

tar: Ambiguous_HOI.tar: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now


Lacking NSCameraUsageDescription

Expected Behaviour
Approval from Apple.
Actual Behaviour
Apple warns: "Missing Info.plist key - This app attempts to access privacy-sensitive data without a usage description. The app's Info.plist must contain an NSCameraUsageDescription key with a string value explaining to the user how the app uses this data. "
Reproduce Scenario (including but not limited to)
Following the instructions in this documentation. Always fails.
I can find NSCameraUsageDescription in the Info.plist in the IPA, but it has no effect.
Steps to Reproduce
-"-
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
n/a
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
n/a
Cordova CLI version and cordova platform version
PhoneGap Build cli-7.0.1
Plugin version
6.0.8
Sample Code that illustrates the problem
    <config-file platform="ios" parent="NSCameraUsageDescription" overwrite="true">
        <string>The app needs access to the camera, to be able to read barcodes.</string>
    </config-file>

I also include this to be on the safe side:
<plugin name="cordova-custom-config" />

Logs taken while reproducing problem
n/a

phonegap build has deprecated config-file tag, you can use edit-config now
we should update the docs

That explains it, yet odd that the IPA contains a setting.
If you update I'll verify right away (I need to get an app update out the door today :) ).

Note that the correct way to set this on PhoneGap Build is as follows;
<plugin name="phonegap-plugin-barcodescanner">
  <param name="CAMERA_USAGE_DESCRIPTION" value="To scan barcodes." />
</plugin>

I've updated the docs to reflect this.

Yup. Noted and implemented :).


Fix some html errors

I removed the 404 error from the root that is wrong there and also fixed some html errors with closing tags and attributes

This is awesome!
Thanks a lot!


[Feature] Add Quit to Desktop in the Pause Menu

Describe the feature you'd like to see added
It would be great to add a Quit to Desktop option in the Pause Menu instead of the need to click Retry or Load/Return to Main Menu and then pressing Quit to close the game. It is especially cumbersome when you play the other modes where you have to click out of Extras and then you can close the game. Sure I can use Alt+F4 for a quick close but that just feels too forceful.

This can make you quit the game unintentionally, i don't think is a good idea.

I think it is a good idea for an optional feature.

adding this into the tweaks menu would be better so you would have to open it and then press the Quit button so it wont accidentally happen

Just to clarify my request, I'm not intending it to instantly close the game. I was thinking that upon clicking that option, a YES/NO will appear below to confirm. Preventing players from accidentally closing the game. The YES/NO option is already there in the game. I'm not sure if we can use it for anything else.
Let's be real here, it is cumbersome to close the game. There several menus to click through to just close the game. If this feature request cannot be done, it's fine. I was thinking of ways to improve the quality of life in the game.

dude, press alt+f4, i can't see a good reason to add this unless you want to save .2 seconds of your time ._.

Sorry to had bother you.


[4.x] JGRP-2487 TLS Transport

https://issues.redhat.com/browse/JGRP-2487
This contains some fixes to make SocketFactories that return SSL sockets work in TCP (UDP and TCP_NIO are not supported).
Additionally the GossipRouter CLI has been enhanced to allow SSL configuration, including the ability to set SNI names.
@pruivo can you please add your review.
Once approved, I'll create a forward port for 5.x

OK, I'll take a look tomorrow.

Note that the wildfly-elytron dependency has been added with test scope. JGroups will not depend on it :)

OK, so I've merged your changes with slight modifications. Please look at TLS/SASLTest...


Release notes (still) pick 'closed issues' wrong

https://github.com/epinio/epinio/releases/tag/v0.0.22 lists 'Set flag to fix postgres volume permissions #684' as closed issue, while #684 is on no project or milestone.
We need to get the release notes creation fixed.

Looking at the parameters for the action, at https://github.com/heinrichreimer/action-github-changelog-generator#inputs
it seems that

Name
Description

excludeLabels
Issues with the specified labels will be excluded from changelog

verbose
Run verbosely

might be useful. The first to as a means of preventing the obvious nonsense from getting into the output. The second to get better insight into the operation of the action. Note also that there seem to be no parameters to influence how the action maps labels to sections. Part of the reason I want verbose is the hope that its output will enable us to gain a deeper understanding of the mapping. Enough that we can tailor our labels (text and use) to the needs of the tool. Of course, reading the sources of the action will hopefully help also, and maybe even more.
Proposal. Exclude issues with labels

Label

apparently external cause

chore

devops admin

duplicate

epic

invalid

later

overcome by events

spike

wontfix

Hm. I might be wrong about excluding epics. Seeing when they are closed, not just the subordinate tickets is likely useful.

The underlying tool is https://github.com/github-changelog-generator/github-changelog-generator
Reading its option documentation and re-reading the action I find that the mapping is controlled by the following 6 parameters:

Parameter
Section
Default

breakingLabels
Breaking changes
backwards-incompatible, breaking

enhancementLabels
Implemented enhancements
enhancement, Enhancement

bugLabels
Fixed bugs
bug, Bug

deprecatedLabels
Deprecated
deprecated, Deprecated

removedLabels
Removed
removed, Removed

securityLabels
Security fixes
security, Security

It is not clear if an issue which falls under more than one section as per the mapping is put into all of them, or just the first matching. If the latter, order of searching for match, i.e. priority is unknown.

And everything tagged with a label not found in any of the above likely goes into the general section for "Closed Issues".

The only labels important to us (as we have them) are bug, enhancement, and security.
Just excluding a lot (as done in #735) might help somewhat, keeping the general section down.


Fix typo removable

This my first pr for swarmkit:)

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "typo" git@github.com:riverzhang/swarmkit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

/close


Fixed documentation example, showing toDouble functionality

@goktugyil I noticed this one too, earlier. Super minor.

:grin:


Failed update in Ubuntu 16.04

Cc @oconnor663
On Tue, Mar 13, 2018 at 8:36 AM Voluntary-zcash<EMAIL_ADDRESS>wrote:

[image: screenshot from 2018-03-13 06-31-22]
https://user-images.githubusercontent.com/20147226/37341923-bbc57872-2688-11e8-8d73-4ce7446c869e.png
[image: screenshot from 2018-03-13 06-32-49]
https://user-images.githubusercontent.com/20147226/37341935-c4a0a7b4-2688-11e8-943d-926fbe3cd3a3.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/10872, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA05_xqTquFdkF02I822Zk2uI63LKCYPks5td70wgaJpZM4SomrO
.

I'm having this issue, too. /var/log/apt/term.log contains these lines:
Setting up keybase (1.0.45-20180313160419.f0de728311) ...
/opt/keybase/post_install.sh: line 45: HOME: unbound variable
dpkg: error processing package keybase (--configure):
 subprocess installed post-installation script returned error exit status 1

Thanks!  Turns out this is the same underlying issue as #10873, which should be fixed with #10875.  The fix is in master but we haven't made a new release yet, so it should be fixed on the next upgrade.  Thanks for all the reports.
cc: @oconnor663.

That fix is public now. Let me know if anyone's still seeing these problems.


Update README.md: Linking -> Moving Apps

@vitorgalvao

https://github.com/caskroom/homebrew-cask/commit/07f63d45cbd2a17edc25d069fe3b447d8850c124


autotools-language-server -> autotools_ls

The former doesn't exist.

Thanks! This was fixed in https://github.com/williamboman/mason-lspconfig.nvim/pulls?q=is%3Apr+is%3Aclosed


dev(checks): use zigbuild to run just check task if it is available

Proposed changes

Make it easier for users to run the just check by using cargo-zigbuild if available. This allows users using MacOS m1 (aarch64 darwin) to run the code checks without having to build in a linux environment (running just release to build natively on MacOS m1 for LInux is already possible).
If cargo-zigbuild is not installed, then cargo will be used (this is auto detected in the justfile. The user can also override the setting by using:
just CARGO=cargo check

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[ ] I ran cargo fmt as mentioned in CODING_GUIDELINES
[ ] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

This can be the opportunity to remove the deprecated targets:

docs:
docs-install:


Update OkHttp to 3.5

Upgrade the supported version and make sure there are no breaking changes.

Shelving this until needed.


Aws s3 incorrect handle content-type: application/xml; charset=utf-8

Some aws s3 compatible services return content-type header with charset field and AWSSDK.S3 version less then 3.7.202 incorrect handle response if error occur.
See here https://github.com/aws/aws-sdk-net/issues/3009
Create mr to fix this.

OK will update and release

Done
https://www.nuget.org/packages/FluentStorage.AWS/5.2.3


Class SQLiteCompatibilityUtils is declared in a file named "SqliteCompatibilityUtils.java"

Class SQLiteCompatibilityUtils is declared in a file named "SqliteCompatibilityUtils.java", which makes the build failed.

Same here

Is this in master? @markzhai @Rainer-Lang ? thank you. It's a git issue as I'm not seeing it here.I may need to just force add the file changes.

Sorry for answering so late...
It's the master.
"Error:(13, 8) error: class SQLiteCompatibilityUtils is public, should be declared in a file named SQLiteCompatibilityUtils.java"


next tag: when using platformNativeScriptDynamic AppOptions custom css, 'application.setCssFileName' is undefined

file:///app/tns_modules/nativescript-angular/bundle.all.js:1022:39: JS ERROR TypeError: application.setCssFileName is not a function. (In 'application.setCssFileName(this.appOptions.cssFile)', 'application.setCssFileName' is undefined)

When doing the following:
import { platformNativeScriptDynamic } from 'nativescript-angular';

import { AppModule } from './app.module';

const platform = platformNativeScriptDynamic({cssFile: 'custom-named.css'});
platform.bootstrapModule(AppModule);

tns: 2.4.1
nativescript-angular: next

Hi @NathanWalker,
Generally nativescript-angular@next depends on tns-core-modules@next. Unfortunately applications uses tns-core-modules from its dependency and problem arises, However since the change of tns-core-modules is very small we will release new version by the end of the week. Meanwhile update app's package.json with next as version to tns-core-modules.

@NathanWalker Hi. Does it work for you with --bundle ?
I've reported it here :
https://github.com/NativeScript/nativescript-dev-webpack/issues/587


ascii ordinal not in range for INCO AIR(r) device User Agents.

To Reproduce
from user_agents import parse
parse("Mozilla/5.0 (Linux; Android 4.4.2; INCO AIR® Build/KOT49H) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/<IP_ADDRESS> Mobile Safari/537.36 Instagram 7.7.0 Android (19/4.4.2; 240dpi; 480x854; Inco Air/INCO; INCO AIR®; h3466; mt6582; es_US)")

I think updating the ua-parser library fixes this problem - I just updated from 0.4.1 to 0.6.1 and our test for this now passes.

yep, updating UA parser as per @sdcooke suggestion fixes the issue.


DO NOT MERGE: Camel-JFR for camel-jbang attempt

cc @davsclaus
Just a beginning attempt

@oscerd okay so it works now, you can use --jfr to turn on with default profile, or use --jfr-profile=name to use a profile (default and profile) are the JDK out of box names. But custom can be made.


feat: add overlay view

Hey there, thanks for taking the time to contribute to this project!
I noticed that you didn't provide any comments or explanation with this PR and it came sort of "out of the blue" (meaning, not referencing any previous discussion or similar). Can you share a bit about the motivation and intended uses for this component? What could be done with this implementation that can't already be done using the AdvancedMarker?
I already thought a bit about having an implementation of an OverlayView component, but I didn't yet end up at an idea that was versatile enough to cover all the possible uses of the OverlayView in a good way.
Also, this topic ties into all the other types of overlays the Maps JavaScript API provides, and I would like to work on a good Vision for those as well before settling on a specific implementation.
Implementing this as an example first would be an excellent start. Besides documenting the intended usage of the component, this would also allow us to iterate on the idea and shape it into something that could be added to the library at some point.
Also, please take the time to review our contribution guidelines to understand where I'm coming from with this.


Fix: Opening the same wallet creates additional records

It closes #1330

My thoughts are:

It's scary for the user - a huge ERROR message and then "Incorrect file" all in red - while I only want to open my own wallet. I'm more than sure there will be people not reading anything, but immediately crying that they have lost their wallets and money. It should be just a notification, preferably without the additional pop-up, a heads up more like "hey, are you sure, you already have this wallet opened, it's located [here](a clickable link to this file)". But if someone really wants, he should be able to open it anyway.
Yes, I agree, all the details displayed on the login page are very confusing, it's way too much, and too verbose, but I think we could leave the date, people are opening the wallets for the CEXs, they might want to distinguish them quickly

MAIN WALLET
CREATED: WEDNESDAY, NOVEMBER 15, 2023 AT 18:55, NET ID: 7C8CEF2BFD54447D60C3FFCC5DAF974B24B74605

could be just
MAIN WALLET
CREATED: 2023-11-15 | Main Network

I would not add any hide option. It's just losing precious time, the ROI close to 0. especially for this sentenced-to-death app version.

Thank you @brusherru and @monikasmolarek  for your insightful feedback. Based on your suggestions, here's how I plan to proceed:

Notification message Instead of Error message
I agree with the idea of using a notification modal with Confirm/Cancel options. This approach will be less alarming for users and more in line with a friendly user interface. The validation of this modal can be done on the front end, as Kirill suggested, before sending the data and storing it in files.

Enhancing Wallet Details View
With the shift from an error to a notification, we can remove the error tooltips. This change allows us to focus on improving the wallet details display. I'll add an icon to reveal the wallet file path in Finder and update the wallet item view in the dropdown, enhancing the user experience as Kirill and Monika suggested.

Finally, I'd prefer to have "Hide" and maybe "Rename" buttons there.
I would not add any hide option.

Given that we're moving towards a notification message and not an error-based approach, the need for a Hide/Remove button seems less relevant. I'm not in favor of implementing this in the Settings page or the main unlock page. It might be more appropriate for a separate page post-unlock, to avoid making wrong decisions for the user and to ensure safety. This is something we might consider for a future version of the app, drawing on industry experience to assess its feasibility and safety.
Feel free to correct me, I'm open to further discussions and suggestions.


Add "webapp" alias to RazorPages template.json

Addresses #325

Blocked because SDK upgrade was reverted https://github.com/aspnet/BuildTools/commit/af264ca131f212b5ba8aafbc5110fc0fc510a2be is


test the spin upgrade

do not merge

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-4923.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit da78d99d771e6708d50544536aaed7906df07496.
Access here: https://mattermost-webapp-pr-4923.test.mattermost.cloud

Test server destroyed

/update-branch


feat: [AAP-19536] Add yaml tag support for vaulted data

Resloves: AAP-19536

@lgalis this is to support the Extra Var having an embedded vaulted string.

@hsong-rh Should we try adding e2e tests for this in the eda-qa repo and add a rulebook into the @Alex-Izquierdo sample repo. We should be able to test this with a bad and good credential to count the number of rules that get triggered.


Add kerrgeodesic_gw package to jupyterlab desktop

Good night.
First of all, thanks so much for the desktop version, it's amazing.
I would like to clear a question, in the browser version I use the kerrgeodesic_gw package for my research and I would like to use it also in the desktop version, but the error appears:
"No module named 'kerrgeodesic_gw' "
but I already have it installed, and it runs in the browser version. Do I have to re-install specifically for the desktop version? Because I don't know how to do this. Can you help me?
I have Linix Mint 20.1, Ubuntu 20.04.
Thank you for your attention.

Have you installed the library following this instruction? https://github.com/jupyterlab/jupyterlab-desktop/blob/master/user-guide.md#customizing-the-bundled-python-environment

I've been to this site before, but to be honest I didn't quite understand the step
"Install the application by double clicking the installer file"
For first time I installed the package to use on Sagemath, I installed it from the terminal, I didn't download any package installer.
How can I proceed?

This step refers to installation of JupyterLab Desktop itself, not of the user packages.

The  jupyterlab desktop is already installed, I'm using it perfectly even. The only package I'm not able to use is kerrgeodesic_gw

The jupyterlab desktop is already installed, I'm using it perfectly even. The only package I'm not able to use is kerrgeodesic_gw

Oops. sorry. I meant the step right below the "customizing the bundled python environment". So you can refer to this step https://github.com/jupyterlab/jupyterlab-desktop/blob/master/user-guide.md#installing-new-python-packages . It is about how to install the library on Jupyterlab-Desktop

Thank you very much, it was my lack of attention.
One more thing, this package I use in Sagemath, but it can only be used in versions equal to or greater than 9.3, but jupyterlab comes in version 9.0. Is sagemath in newer versions already available for him?

Thank you very much, it was my lack of attention.
One more thing, this package I use in Sagemath, but it can only be used in versions equal to or greater than 9.3, but jupyterlab comes in version 9.0. Is sagemath in newer versions already available for him?

Which program are you talking about when you said 9.0 or 9.3? It is definitely not Python as the Python's recent version is up to 3.x. And what does him refer to in the last sentence?

I'm talking about Sagemath, it's symbolic computing software that I use. Normally, to use it in the Browser I launch it in the terminal
"sage -n jupyter" or "sage -n jupyterlab"
and both open in the version I use, Sagemath 9.3, but on the desktop it opens in version 9.0.

There should be no difference in terms of package version if you install it from the same source.
I advise you to uninstall the library and re-install it. If it does not solve your problem, you can also uninstall jupyterlab-desktop and reinstall it.

Perfect, I will try to reinstall it.
@hellojinwoo thank you very much for your help and patience. You helped me a lot.

@hellojinwoo  Looks like I closed the problem too soon. lol
I tried to make the changes you suggested and reinstalled jupyterlab, but Sagemath is still on version 9.0 on the desktop.

I would not expect re-installation alone to change the Sagemath version. First, I do not understand why you expect Sagemath to be provided by JupyterLab Desktop - the two should have no connection as far as I know; we do not provide a Sagemath installer with JupyterLab Desktop. JupyterLab Desktop installs a minimal conda environment, which you can change using the selector on the statusbar. If you have installed sagemath to one of your environments you should update it there. You may have several versions installed, and maybe when using JupyterLab Desktop a different version is available because of the path configurations (compared to when you access it normally); in either case I don't believe this is a problem with JupyterLab Desktop at all, but an issue with your local installation.

closing since not a Desktop app issue. please create new issue if you still have problems.


Correction for raw affiliation LIP, UMR 5668 CNRS — ENS Lyon — UCB Lyon — Inria, France

Correction needed for raw affiliation LIP, UMR 5668 CNRS — ENS Lyon — UCB Lyon — Inria, France
raw_affiliation_name: LIP, UMR 5668 CNRS — ENS Lyon — UCB Lyon — Inria, France
new_rors: 02kvxyf05;029brtt94;02feahw73;04msnz457
previous_rors: 02kvxyf05;029brtt94;02feahw73
works_examples: W2132257274
contact: e849b0ed39ad935736aba416e6b5fa95:da3018d2021879e96098cec8511c @ ens-lyon.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Are the instructions to enable sideloading correct?

The instructions refer to turning on the "Enable interaction with custom apps" policy, which allows users to use sideloaded apps. But it doesn't mention the app setup policy to allow "Upload custom apps",which is what actually allows sideloading the app to begin with.
https://docs.microsoft.com/en-us/microsoftteams/app-policies#app-setup-policies

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5e17314b-09a2-197f-da9e-3a50697c182e
Version Independent ID: 5e17314b-09a2-197f-da9e-3a50697c182e
Content: Set up your dev environment for extending Teams apps across Microsoft 365 - Teams
Content Source: msteams-platform/m365-apps/prerequisites.md
Service: msteams
GitHub Login: @surbhigupta
Microsoft Alias: lajanuar

We will look into it and get back to you.

@surbhigupta12 - Could you please help us to update the document-
In the below document section add as 4 point
4. Also the app setup policy to allow Upload custom apps to enable sideloading.
Document-https://docs.microsoft.com/en-us/microsoftteams/platform/m365-apps/prerequisites#prepare-a-developer-tenant-for-testing


New UI, Running is difficult to read

As you can see, it is rather difficult to see the Run area along the top of the window in the new UI while the app is actually running.

It does look quite good when the app is not running, though a background color of some sort to give it shape would be welcome.

Give me two days please

It is now also incompatible with 2023.1, most of the new UI is no longer styled.

It is now also incompatible with 2023.1, most of the new UI is no longer styled.

Not published yet ?
https://plugins.jetbrains.com/plugin/18943-moonlight-dark-theme

The truth is that I haven't published it yet, I had a preview of the color correction but Jetbrains published its new release and I see that there have been certain changes that I have to reconsider and check that everything is correct. I promise to launch it from here to Monday, please be patient. Thanks for the support :)

The time has come, any improvement tip is well accepted. At the moment it is under review by Jetbrains but you can download it extra officially from here.
https://github.com/francmarin98/jetbrains-moonlight-theme/releases/tag/v1.4


Issues importing or logging in

Laravel Version: 5.5
Adldap2-Laravel Version: v7.0.15
PHP Version: 7.0.22

I'm having issues logging in and or importing users.
If I try to import users I only get the user I use within the config files, if I return all users I get all info about the user I logged in as.
If I try logging into any user I get "false" and "true" on the user from the config files.
Is there something I have done wrong in the config files, or is this on the server end?

Seems like I was using wrong base dn.


Default display of hook output on failures

This is kind of related to #689 #699
I understand that helmfile now has a new key for hooks called showlogs which will log the output of a hook.
However, there can be scenarios where you would normally not care about the hook output but only worry about it if the command fails.
For example, one can utilize presync hooks for sanity checks. If the check passes we don't really care about the command output, but if it fails then we want to know which hook in the helmfile failed and why it failed. I think it would be a nice addition to have this enabled by default so that when a hook fails you not only see the failed command (sometimes this can be useless if you're running it through another shell as it will only display /bin/sh) but the actual output as well.
I'm not sure how complicated this would be as we would have to keep the output of the command in a buffer and then decide to display it if the command fails but I think it would be a nice addition to the user experience.
Thanks!

@rajiteh Sounds like a good addition to helmfile!
One thing I'd wanted to note is that showlogs doesn't buffer logs atm. So implementation-wise helmfile will be enhanced to always buffer the logs from a hook so that it can replay the buffer once the hook fails.
Maybe it worth renaming showlogs to something like alwaysShowLogs because it will show logs anyway if a hook is failed?


How to verify GPU is working?

How can I verify that the ToGPU() callback is working as expected?

You could check the GPU memory usage with nvidia-smi. Or check if the data is a CuArray.

It's showing up in nvidia-smi, but the actual training seems to be taking the same amount of time.
My data-loaders are pretty slow though, since they read from disk... maybe that's the reason

Are your data loaders using DataLoaders.jl?

Yes.
GPU: 1 epoch 1:51
CPU: 1 epoch 2:44

Oh yeah it was the file access. After I started caching stuff in memory:
CPU (cached): 13s
GPU (cached): 2s

Yeah I experienced this as well, but I didn't have time to investigate. Seems like we need DataLoaders.jl to play a little better with ToGPU/CuIterator.


IExecutionListener.onStart() running twice when used as annotation in mediumSuite file

TestNG Version: 6.14.3

Note: only the latest version is supported

Expected behavior:
The documentation states that in a testng run, IexecutionListener will be executed only once.
Actual behavior:
When we use IexecutionListener as annotation in test cases and bundle those suites to run using a XML, the onStart() function gets executed multiple times. In a medium suite, it is executed 2 times. In a large suite file, which contains 2 other suites (small and medium), the onStart function is executed 3 times.
Is the issue reproductible on runner?

[ ] Shell
[ ] Maven
[ ] Gradle
[ ] Ant
[X] Eclipse
[ ] IntelliJ
[ ] NetBeans

Test case sample

Please, share the test case (as small as possible) which shows the issue

Sample Test Class
import static org.testng.Assert.assertEquals;

import org.testng.annotations.Listeners;
import org.testng.annotations.Test;
@Listeners(listeners.ExecutionListener.class)
public class TestClass5 {

	@Test
	public void test1() {
		assertEquals(true, true);
	}

	@Test
	public void test2() {
		assertEquals(true, true);
	}

	@Test
	public void test3() {
		assertEquals(true, true);
	}

	@Test
	public void test4() {
		assertEquals(true, true);
	}

}

Sample XML File
<?xml version = "1.0" encoding = "UTF-8"?>
<!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd" >

<suite name="Suite">
	<test name="exampletest3">
		<classes>
			<class name="suite3.TestClass5" />
			<class name="suite3.TestClass6" />
		</classes>
	</test>
	<suite-files><suite-file path="src/test/resources/smallSuite.xml" /></suite-files>
	<suite-files><suite-file path="src/test/resources/mediumSuite.xml" /></suite-files>
</suite>

Sample Output
Start
Start
Start

===============================================
smallSuite
Total tests run: 8, Failures: 0, Skips: 0
===============================================

===============================================
mediumSuite
Total tests run: 8, Failures: 0, Skips: 0
===============================================

===============================================
Suite
Total tests run: 24, Failures: 0, Skips: 0
===============================================

Finish

Sample ExecutionListener:
import org.testng.IExecutionListener;

public class ExecutionListener implements IExecutionListener{

	public void onExecutionStart() {
		System.out.println("Start");
	}

	public void onExecutionFinish() {
		System.out.println("Finish");
	}
}

in which release of testng is this bug fix available?

@cbeust  do you know in which release of testng will this bug fix be available?

@formynet - Please make use of the latest released version of TestNG viz., 7.0.0-beta5


Add "Fishing" to CraftSkill

Hi @MaxNau
Thanks for the great library! I'm currently removing my whole implementation to use yours since it was quite similar.
I'm just wondering if you(or I could make a PR) could add "Fishing" as a "CraftSkill" ?
The reasons is that it's the only skill that is not in it, and even if I understand that you cannot "craft" fish, it prevents a lot of general behavior because there will be no enum that contains all the skills.
like
int character.GetLevel(CraftSkill skill);
or some logic to improve any skill
myBot.Improve(CraftSkill skill);
What do you think?
Note, I saw that you also have TaskSkill, but it's a bit a pain to have to implement twice methods like "GetLevel", once for the crafting skill once for the general skill?

Also, I guess the MapContent.Type should be of type MapContentType that you also already have

Hi @jaytonic ,
Thank you for your positive feedback about the library! I'm glad to hear that it's fitting well with your implementation.
I appreciate your suggestion to add an enum for all character skills. I’ll definitely think about it, and if I see some support from others in the community, I’ll consider moving forward with that change.

Also, I guess the MapContent.Type should be of type MapContentType that you also already have(same for Item.Type)

Thank you for noticing that. I will fix it in the hotfix for 2.4.1 version.
Your input is valuable, and I’m always open to ideas that can enhance the library. If you have any more suggestions or need help, feel free to reach out!

I will add new enum - CharacterSkill that will have all the skills available in the game, since CraftSkill is used as a filter in queries and fishing is not one of the allowed values.

Added CharacterSkill enum in PR #13


[Bug] When the topic name is four-paragraph and the namespace does not exist, the topic can also be produced and consumed normally

Search before asking

[X] I searched in the issues and found nothing similar.

Read release policy

[X] I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.

Version
pulsar:4.0.1
java-sdk:2.9.2
Minimal reproduce step
Producer<byte[]> producer = myClient.newProducer().
topic("persistent://wzjtest-tenant/cluster/test-ns/topic").create();
What did you expect to see?
Not found: Namespace not found
What did you see instead?
Can produce and consume normally
Anything else?
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

Is this related to #23620 or #23594?

java-sdk:2.9.2

It's recommended to use supported versions.


[EXPERIMENTAL] Consumer Offsets: add ability to not wait for fsync

Commit Offsets latency is bounded by the write latency of sending a message to Pulsar.
This patch adds a new parameter offsetsWaitForSync, if you set it to false then the Commit Offsets API will not wait for Pulsar to store the message before sending the confirmation back to the client.
This configuration will give best results for the Kafka client, but it is very dangerous of course

I believe that this feature will be too dangerous.
I am closing this PR