Onboarding Colorado

This is a ticket to track the work being done to onboard Colorado. Keep any notes and info here and then close it out when they go to production.

Transferred first synthetic file to the CO test server

Sent new file with synthesized data.

Set report stream production to send to CO staging

sftp was failing in RS so CO was not receiving the files. It has been fixed. So I will manually transfer a file then the automated transfers will start in AM of 10/14

Set default reporting facility name to CDC PRIME and reporting facility ID as 11D2030855 in production


Suddenly needs to be reloaded nearly every day or two.

I am not sure what is going on but things went from rock solid stable last year to this year I am having to reload the integration nearly every day.

I noticed it was happening more frequently, so I set up an automation to reload it if it is unavailable.
Try something like:
alias: Reload Omnilogic when Unavailable
description: ""
trigger:

platform: state
entity_id:

sensor.knight_home_air_temperature
to: unavailable

platform: time_pattern
minutes: "5"
condition:
condition: state
entity_id: sensor.knight_home_air_temperature
state: unavailable
action:
service: homeassistant.reload_config_entry
target:
entity_id: sensor.knight_home_air_temperature
data: {}
mode: single

I noticed it was happening more frequently, so I set up an automation to reload it if it is unavailable.
Try something like:
alias: Reload Omnilogic when Unavailable
description: ""
trigger:
  - platform: state
    entity_id:
      - sensor.knight_home_air_temperature
    to: unavailable
  - platform: time_pattern
    minutes: "5"
condition:
  - condition: state
    entity_id: sensor.knight_home_air_temperature
    state: unavailable
action:
  - service: homeassistant.reload_config_entry
    target:
      entity_id: sensor.knight_home_air_temperature
    data: {}
mode: single

Thanks!  I was actually thinking about seeing if something like this was possible because it seems to always come back no problem with a reload.   I will give this a shot.
Hopefully they arent rate limiting us or something like that, I increased my poll time from 30s to 1m just in case as well.

Seeing the need for reload on my end very often as well.  Seems to have happened after the great Windows outages over the summer, and guessing Hayward has possibly made some infrastructure changes that have resulted in the stability of what was previously rock solid.

Whatever it is it is a Hayward Cloud issue. I recommend either trying the local integration that is out there or setting up the "auto-reload" script for when it drops off.


ggplot dependency should be optional and only for figure drawing

glfw can be used for imshow directly

glfw can be used for imshow directly

It is used directly. ggplotd is used only to draw plots on the figure canvas.
I propose we deal with this in the same instance as #25. Looking at the vibe.d project as example, I think having library separated to subPackages as there would be a good choice. If we have visualization as separated subPackage, having ggplotd as optional utility though separate configuration seems ok.
Thoughts?

Looks OK. I am not sure about dub bugs. But idea is good


certbot-dns-duckdns is not available for arm64?

Hi,
While I was trying to install certbot-dns-duckdns on Amrbian (Buster, Rock Pi 4B), I got:

error: snap "certbot-dns-duckdns" is not available on this architecture (arm64) but exists on other architectures (amd64)

in respond to

snap install certbot-dns-duckdns

My final target is accessing OMV NAS with help of letsencrypt.
Any solution?
Eugenius.

have you any milestone for this update?

You can now find snap builds for the architectures armhf, arm64 (armv8) and amd64 in the snap store beta channel.

Thank you. It seems it is working.


Backup to Azure, with compression = Y, is set to NO_COMPRESSION

Description of the issue
I execute proc as below.
EXECUTE dbo.DatabaseBackup
@Databases = 'DB',
@URL = 'URL',
@Credential = 'CRED',
@BackupType = 'FULL',
@Compress = 'Y',
@Verify = 'Y'
But execution command is with NO_COMPRESSION
Command: BACKUP DATABASE database TO URL = N'URL'
WITH NO_CHECKSUM,
NO_COMPRESSION,
CREDENTIAL = N''
SQL Server version and edition
Execute SELECT @@VERSION
Microsoft SQL Server 2017 (RTM-CU15) (KB4498951) - 14.0.3162.1 (X64)   May 15 2019 19:14:30   Copyright (C) 2017 Microsoft Corporation  Enterprise Edition: Core-based Licensing (64-bit) on Windows Server 2016 Standard 10.0  (Build 14393: )
Version of the script
Check the header of the stored procedure
--// Version: 2019-06-14 00:05:34
What command are you executing?
EXECUTE dbo.DatabaseBackup
@Databases = 'DB',
@URL = 'URL',
@Credential = 'CRED',
@BackupType = 'FULL',
@Compress = 'Y',
@Verify = 'Y'
What output are you getting?
Command: BACKUP DATABASE database TO URL = N'URL'
WITH NO_CHECKSUM,
NO_COMPRESSION,
CREDENTIAL = N''

I have been doing some testing with this, and I am not able to reproduce it.
Could you please send me a mail with the complete output file.

Hi,
As requested, and the proc that was run.  Note that we run this from a user database, not from master. But that should not make any difference.
Command Executed:
EXECUTE dbo.DatabaseBackup
@Databases = 'ParcelLocator',
@URL = 'https://ie01svsqdbbackups.blob.core.windows.net/smartship3/',
@Credential = 'ie01svsqdbbackups',
@BackupType = 'FULL',
@Compress = 'Y',
@Verify = 'Y'
Query OutPut:
Date and time: 2019-07-16 12:48:50
Server: IE-01-SV-SQ
Version: 14.0.3162.1
Edition: Enterprise Edition: Core-based Licensing (64-bit)
Platform: Windows
Procedure: [MaintenanceNew].[dbo].[DatabaseBackup]
Parameters: @Databases = 'ParcelLocator', @Directory = NULL, @BackupType = 'FULL', @Verify = 'Y', @CleanupTime = NULL, @CleanupMode = 'AFTER_BACKUP', @Compress = 'Y', @CopyOnly = 'N', @ChangeBackupType = 'N', @BackupSoftware = NULL, @CheckSum = 'N', @BlockSize = NULL, @BufferCount = NULL, @MaxTransferSize = NULL, @NumberOfFiles = NULL, @CompressionLevel = NULL, @Description = NULL, @Threads = NULL, @Throttle = NULL, @Encrypt = 'N', @EncryptionAlgorithm = NULL, @ServerCertificate = NULL, @ServerAsymmetricKey = NULL, @EncryptionKey = NULL, @ReadWriteFileGroups = 'N', @OverrideBackupPreference = 'N', @NoRecovery = 'N', @URL = 'https://ie01svsqdbbackups.blob.core.windows.net/smartship3/', @Credential = 'ie01svsqdbbackups', @MirrorDirectory = NULL, @MirrorCleanupTime = NULL, @MirrorCleanupMode = 'AFTER_BACKUP', @MirrorURL = NULL, @AvailabilityGroups = NULL, @Updateability = 'ALL', @AdaptiveCompression = NULL, @ModificationLevel = NULL, @LogSizeSinceLastLogBackup = NULL, @TimeSinceLastLogBackup = NULL, @DataDomainBoostHost = NULL, @DataDomainBoostUser = NULL, @DataDomainBoostDevicePath = NULL, @DataDomainBoostLockboxPath = NULL, @DirectoryStructure = '{ServerName}${InstanceName}{DirectorySeparator}{DatabaseName}{DirectorySeparator}{BackupType}{Partial}{CopyOnly}', @AvailabilityGroupDirectoryStructure = '{ClusterName}${AvailabilityGroupName}{DirectorySeparator}{DatabaseName}{DirectorySeparator}{BackupType}{Partial}{CopyOnly}', @FileName = '{ServerName}${InstanceName}{DatabaseName}{BackupType}{Partial}{CopyOnly}{Year}{Month}{Day}{Hour}{Minute}{Second}{FileNumber}.{FileExtension}', @AvailabilityGroupFileName = '{ClusterName}${AvailabilityGroupName}{DatabaseName}{BackupType}{Partial}{CopyOnly}{Year}{Month}{Day}{Hour}{Minute}{Second}{FileNumber}.{FileExtension}', @FileExtensionFull = NULL, @FileExtensionDiff = NULL, @FileExtensionLog = NULL, @Init = 'N', @DatabaseOrder = NULL, @DatabasesInParallel = 'N', @LogToTable = 'N', @Execute = 'Y'
Version: 2019-06-14 00:05:34
Source: https://ola.hallengren.com
Date and time: 2019-07-16 12:48:50
Database: [ParcelLocator]
State: ONLINE
Standby: No
Updateability: READ_WRITE
User access: MULTI_USER
Is accessible: Yes
Recovery model: FULL
Encrypted: Yes
Differential base LSN:<PHONE_NUMBER>0010300095
Last log backup LSN:<PHONE_NUMBER>0422500001
Allocated extent page count: N/A
Modified extent page count: N/A
Date and time: 2019-07-16 12:48:50
Command: BACKUP DATABASE [ParcelLocator] TO URL = N'https://ie01svsqdbbackups.blob.core.windows.net/smartship3/IE-01-SV-SQ/ParcelLocator/FULL/IE-01-SV-SQ_ParcelLocator_FULL_20190716_124850.bak' WITH NO_CHECKSUM, NO_COMPRESSION, CREDENTIAL = N'ie01svsqdbbackups'
Processed 1338056 pages for database 'ParcelLocator', file 'ParcelLocator' on file 1.
Processed 429 pages for database 'ParcelLocator', file 'ParcelLocator_log' on file 1.
BACKUP DATABASE successfully processed 1338485 pages in 1008.079 seconds (10.373 MB/sec).
Outcome: Succeeded
Duration: 00:16:52
Date and time: 2019-07-16 13:05:42
Date and time: 2019-07-16 13:05:42
Command: RESTORE VERIFYONLY FROM URL = N'https://ie01svsqdbbackups.blob.core.windows.net/smartship3/IE-01-SV-SQ/ParcelLocator/FULL/IE-01-SV-SQ_ParcelLocator_FULL_20190716_124850.bak' WITH NO_CHECKSUM, CREDENTIAL = N'ie01svsqdbbackups'
From: Ola Hallengren<EMAIL_ADDRESS>Sent: Tuesday 16 July 2019 14:02
To: olahallengren/sql-server-maintenance-solution<EMAIL_ADDRESS>Cc: Gerry Bowers<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [olahallengren/sql-server-maintenance-solution] Backup to Azure, with compression = Y, is set to NO_COMPRESSION (#252)
I have been doing some testing with this, and I am not able to reproduce it.
Could you please send me a mail with the complete output file.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/olahallengren/sql-server-maintenance-solution/issues/252?email_source=notifications&email_token=AMUA5XLNZJOMWS7PBCSDVBTP7XBD7A5CNFSM4IEAIEVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2AYSZA#issuecomment-511805796, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMUA5XMOLGO5UK3MVOUYG7TP7XBD7ANCNFSM4IEAIEVA.

It is because the database is encrypted with TDE.
Please see this blog post:
https://blogs.msdn.microsoft.com/sqlcat/2016/06/20/sqlsweet16-episode-1-backup-compression-for-tde-enabled-databases/
You need to specify @MaxTransferSize = 65537, to be able to compress the backup, and in order to do that you also need to switch to a Shared Access Signature.
https://docs.microsoft.com/en-us/sql/relational-databases/backup-restore/sql-server-backup-to-url?view=sql-server-2017

But you can not backup to a URL with MaxTransferSize set, but you can backup to a URL with COMPRESSION.
This;
BACKUP DATABASE [ParcelLocator]
TO URL = N'https://ie01svsqdbbackups.blob.core.windows.net/smartship3/IE-01-SV-SQ_ParcelLocator_FULL_TESTED1.bak'
WITH CHECKSUM,
COMPRESSION,
MAXTRANSFERSIZE = 65537,
CREDENTIAL = N'ie01svsqdbbackups'
Results in this:
Msg 3291, Level 16, State 3, Line 1
URL device type was specified, and a disallowed option MAXTRANSFERSIZE was specified.
Msg 3013, Level 16, State 1, Line 1
BACKUP DATABASE is terminating abnormally.
But this works:
BACKUP DATABASE [ParcelLocator]
TO URL = N'https://ie01svsqdbbackups.blob.core.windows.net/smartship3/IE-01-SV-SQ_ParcelLocator_FULL_TESTED2.bak'
WITH CHECKSUM,
COMPRESSION,
--MAXTRANSFERSIZE = 65537,
CREDENTIAL = N'ie01svsqdbbackups'
Its takes way too long to verify the backup on the URL.
I know you are only look after the SQL Backups, but have you used AZCOPY to copy the backed up db to azure. Would it every be anything you would support as part of the product.
But it painful to get AZCOPY to upload as a page file to blob storage.
Ger
From: Ola Hallengren<EMAIL_ADDRESS>Sent: Tuesday 16 July 2019 14:55
To: olahallengren/sql-server-maintenance-solution<EMAIL_ADDRESS>Cc: Gerry Bowers<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [olahallengren/sql-server-maintenance-solution] Backup to Azure, with compression = Y, is set to NO_COMPRESSION (#252)
It is because the database is encrypted with TDE.
Please see this blog post:
https://blogs.msdn.microsoft.com/sqlcat/2016/06/20/sqlsweet16-episode-1-backup-compression-for-tde-enabled-databases/
You need to specify @MaxTransferSize = 65537, to be able to compress the backup, and in order to do that you also need to switch to a Shared Access Signature.
https://docs.microsoft.com/en-us/sql/relational-databases/backup-restore/sql-server-backup-to-url?view=sql-server-2017
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/olahallengren/sql-server-maintenance-solution/issues/252?email_source=notifications&email_token=AMUA5XPCWKRZPKKN5QKYIMLP7XHLVA5CNFSM4IEAIEVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2A5SFQ#issuecomment-511826198, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMUA5XIL6WJ7CJWXCKVBGPDP7XHLVANCNFSM4IEAIEVA.

But you can not backup to a URL with MaxTransferSize set, but you can backup to a URL with COMPRESSION.

You can back up to URL with COMPRESSION, but you won't get any reduction in size unless you are on SQL Server 2016 and later and set MAXTRANSFERSIZE to a value higher than 65536.
Because of that, I switch to NO_COMPRESSION, if the database is encrypted with TDE, and you have not set MAXTRANSFERSIZE to a value higher than 65536.
To be able to specify MAXTRANSFERSIZE you need to move away from specifying the CREDENTIAL, and use Shared Access Signature instead.

I had a similar issue using SQL Server 2017 with TDE databases, my parameters we similar to:
@databases = 'DBname',
@url = 'URL',
@credential = 'CRED',
@BackupType = 'FULL',
@compress = 'Y',
@verify = 'Y'
@MaxTransferSize = 65537
I got an error : "The value for the parameter @MaxTransferSize is not supported."
This is because:
"There are two types of blobs that can be stored in the Microsoft Azure Blob storage service: block and page blobs. SQL Server backup can use either blob type depending upon the Transact-SQL syntax used: If the storage key is used in the credential, page blob will be used; if the Shared Access Signature is used, block blob will be used."
-- If you use parameter @credential = 'CRED' then page blob will be used. Page blob does not support @MaxTransferSize. (Hence my error)
-- With SQL versions 2016 and later you can use a Shared Access Signature (SAS) intead of an Access Key. @credential is not required with SAS. Then @MaxTransferSize is supported. This is the solution to my issue.
Ref:
https://docs.microsoft.com/en-us/sql/relational-databases/backup-restore/sql-server-backup-to-url?view=sql-server-2017
Also note that:

SAS are not supported in earlier version than SQL2016
It is not possible to compress backups in SQL 2012/2014 when TDE is enabled. You'll need to upgrade to SQL 2016 or later and set @MaxTransferSize > 65536

Hi,
Thanks for the reply.
One thing  though, you say “block blob will be used” is this correct, my understanding is that when you restore from a URL then the backup has to be a page blob, so the backup to the URL would have to have been a page blob?
Even when you use a SAS as the key.
Thanks
Gerry
From: bigbird1212<EMAIL_ADDRESS>Sent: Wednesday 17 July 2019 22:08
To: olahallengren/sql-server-maintenance-solution<EMAIL_ADDRESS>Cc: Gerry Bowers<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [olahallengren/sql-server-maintenance-solution] Backup to Azure, with compression = Y, is set to NO_COMPRESSION (#252)
I had a similar issue using SQL Server 2017 with TDE databases, my parameters we similar to:
@databaseshttps://github.com/databases = 'DBname',
@urlhttps://github.com/url = 'URL',
@credentialhttps://github.com/credential = 'CRED',
@BackupType = 'FULL',
@compresshttps://github.com/compress = 'Y',
@verifyhttps://github.com/verify = 'Y'
@MaxTransferSize = 65537
I got an error : "The value for the parameter @MaxTransferSize is not supported."
This is because:
"There are two types of blobs that can be stored in the Microsoft Azure Blob storage service: block and page blobs. SQL Server backup can use either blob type depending upon the Transact-SQL syntax used: If the storage key is used in the credential, page blob will be used; if the Shared Access Signature is used, block blob will be used."
-- If you use parameter @credentialhttps://github.com/credential = 'CRED' then page blob will be used. Page blob does not support @MaxTransferSize. (Hence my error)
-- With SQL versions 2016 and later you can use a Shared Access Signature (SAS) intead of an Access Key. @credentialhttps://github.com/credential is not required with SAS. Then @MaxTransferSize is supported. This is the solution to my issue.
Ref:
https://docs.microsoft.com/en-us/sql/relational-databases/backup-restore/sql-server-backup-to-url?view=sql-server-2017
Also note that:

SAS are not supported in earlier version than SQL2016
It is not possible to compress backups in SQL 2012/2014 when TDE is enabled. You'll need to upgrade to SQL 2016 or later and set @MaxTransferSize > 65536

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/olahallengren/sql-server-maintenance-solution/issues/252?email_source=notifications&email_token=AMUA5XKEL3D5L5X2DCABKHLP76C4PA5CNFSM4IEAIEVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2GS66Q#issuecomment-512569210, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMUA5XOAGLDN6EVYV43LKL3P76C4PANCNFSM4IEAIEVA.

@gerbowers, please see this:

There are two types of blobs that can be stored in the Microsoft Azure Blob storage service: block and page blobs. SQL Server backup can use either blob type depending upon the Transact-SQL syntax used: If the storage key is used in the credential, page blob will be used; if the Shared Access Signature is used, block blob will be used.
Backup to block blob is only available in SQL Server 2016 or later version. We recommend you to backup to block blob instead of page block if you are running SQL Server 2016 or later version. The main reasons are:
Shared Access Signature is a safer way to authorize blob access compared to storage key.
You can backup to multiple block blobs to get better backup and restore performance, and support larger database backup.
Block blob is cheaper than page blob.
https://docs.microsoft.com/en-us/sql/relational-databases/backup-restore/sql-server-backup-to-url?view=sql-server-2017

Hi Guys,
I got this working, thanks a lot for the help.
Gerry
From: Ola Hallengren<EMAIL_ADDRESS>Sent: Friday 19 July 2019 14:45
To: olahallengren/sql-server-maintenance-solution<EMAIL_ADDRESS>Cc: Gerry Bowers<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [olahallengren/sql-server-maintenance-solution] Backup to Azure, with compression = Y, is set to NO_COMPRESSION (#252)
@gerbowershttps://github.com/gerbowers, please see this:

There are two types of blobs that can be stored in the Microsoft Azure Blob storage service: block and page blobs. SQL Server backup can use either blob type depending upon the Transact-SQL syntax used: If the storage key is used in the credential, page blob will be used; if the Shared Access Signature is used, block blob will be used.
Backup to block blob is only available in SQL Server 2016 or later version. We recommend you to backup to block blob instead of page block if you are running SQL Server 2016 or later version. The main reasons are:
Shared Access Signature is a safer way to authorize blob access compared to storage key.
You can backup to multiple block blobs to get better backup and restore performance, and support larger database backup.
Block blob is cheaper than page blob.
https://docs.microsoft.com/en-us/sql/relational-databases/backup-restore/sql-server-backup-to-url?view=sql-server-2017

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/olahallengren/sql-server-maintenance-solution/issues/252?email_source=notifications&email_token=AMUA5XKYGERFWC77Q75ALD3QAHAMXA5CNFSM4IEAIEVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2LVIVA#issuecomment-513234004, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMUA5XI5PHOIUGBAGJ43XYTQAHAMXANCNFSM4IEAIEVA.


Please implement a SOP frontend

SOP [0] is an interface specification for OpenPGP implementations.  One of the main use cases is plugging implementations into the OpenPGP Interoperability Test suite [1].  The test suite has been very successful in finding bugs in various implementations.  Please join the fun :)
0: https://gitlab.com/dkg/openpgp-stateless-cli
1: https://tests.sequoia-pgp.org/

Hehe don't tell anyone but I already started a prototype ;)

Duplicate of #26

@teythoon thank you for your work and these issues. Overall, the tests are extremely helpful :+1:  also thank you @vanitasvitae for implementing the interface.


Promote PBF as a top-level export format

This modifies the Overpass query to fetch metadata and dependent entities (outside the desired bounding box) in order to make it suitable for importing into an APIDB schema.
As the PBF is often useful enough on its own, it deserves to be a top-level format. This also achieves that.

is this still applicable, or it's replaced by #118 ?

Still applicable (more important to us than #118, which was in response to a comment from @bjohare in #109) but I need to address my comment about query.osm first.

are there any updates on this?

@dodobas sorry, was out of the country.
This PR is ready to go from my perspective.


RimSort: add 1.0.9

Closes #1196

[x] I have read the Contributing Guide.

I think this should fix it, but I may be off track, first time contribution.

Is this ready to be merged?

Is this ready to be merged?

I was waiting to see if @github-actions would post its comment again after this PR had new commits, but it didn't;


Wrong scroll offset after closing

Steps to reproduce:

Make a bottom sheet with enough height to get a scrollbar when open.
Open it and scroll down.
Close it.
Observe that the bottom sheet overflow is wrongly scrolled.

Expected behavior:
The bottom sheet should automatically reset the scroll offset to zero when closed.

I don't think the plugin should handle the scrolling behavior of its content.
Here's how I would solve this issue (⚠dirty code alert⚠):
`
render () {
const contentStyle = {
maxHeight: '100%',
overflow: 'auto'
};
	return (

			<button onClick={() => this.openBottomSheet(true)}>Open bottom sheet</button>
			<SwipeableBottomSheet
			open={this.state.open}
			onChange={this.openBottomSheet.bind(this)}
			fullScreen
			shadowTip={false}
			topShadow={false}
			swipeableViewsProps={{
				onTransitionEnd: () => {
					if(!this.state.open) this.contentElt.scrollTop = 0;
				}
			}}
			>

 this.contentElt = elt}>

					<button onClick={() => this.openBottomSheet(false)}>Close</button>

			</SwipeableBottomSheet>

	);
}`

I use onTransitionEnd method instead of openBottomSheet so that content don't scroll during animation.
Don't forget to set the reference on the content wrapping div.

I think I should have said that the issue happens when scrollOnWindowOverflow: true. When the bottom sheet is closed, it's expected that the little overflow appearing in the bottom of the screen will represent the top of the content. What's currently happening is: if you scroll and then close the bottom sheet, the overflow of the bottom sheet don't show the top of the content anymore.
I can't see how this could be the intended behavior.

After writing this I saw you removed the scrollOnWindowOverflow prop. Would you mind to explain why this should be handled outside of this component? I mean: in what kind of situation would someone ever want the bottom sheet overflowing the top of the screen without automatically becoming scrollable?

I removed the scrollOnWindowOverflow prop because I couldn't find a case where disable it would be useful. It's set to true by default (same as before), and you can still disable it by setting bodyStyle.

I can't see how this could be the intended behavior.

I can still add a prop to force scroll when closing. I'm not sure whether or not the scroll should be animated. No animation might be too abrupt, and an easing scroll might be too flashy.

I added scrollTopAtClose prop (default true) in the last release. You can see it in action here. It should solve the issue.
I also added marginTop prop which should be useful if you need to keep a navbar visible.

@manufont Oh, I thought you had given up on the scroll on window overflow thing. I don't know if you animated the scroll or not but it's feeling good to me. Thanks for your work on this!

How to fix header so that I can control the header swipeable after I opened sheet and scrolled down?

@manufont
Hello, thank you for this beautiful work.
I just have a issue that I am facing when using SwipeableBottomSheet
so, say i have scrollable contents say a list component that has multiple items inside SwipeableBottomSheet
I can scroll down perfectly, but when i try to scroll up the SwipeableBottomSheet is closed as a result, i.e swiping down has occurred.
my question : is there any way in which I can disable the swiping effect on some components inside theSwipeableBottomSheet?


[vp8] macroblock_offset alignment

The change depends on a corresponding driver fix.
Signed-off-by: Dmitry Ermilov<EMAIL_ADDRESS>

@onabiull, @XinfengZhang,
This should be merged together with https://github.com/intel/media-driver/pull/86


Oracle support with gvenzl/oracle-xe image

Description

Use gvenzl/oracle-xe as oracle image
Format code
How to test

Start with Gitpod
Exec sqlplus gitpod/gitpod@//localhost:1521/XEPDB1 after DB ready
Use oracle extension to connect with DB

I added some notes above. Cheers @filiptronicek  🎉


Updated discord CDN location

I think discordcdn.com has been removed. I can only ever access images from cdn.discordapp.com so I've changed it here to get the correct image URL.

Thanks, merged! I'll push an update to hex shortly.


fix: when failure in cache! throws

Codecov Report

Merging #8 (c27647e) into main (2ecb4e4) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   93.18%   93.15%   -0.03%
==========================================
  Files           8        7       -1
  Lines         264      263       -1
==========================================
- Hits          246      245       -1
  Misses         18       18

Impacted Files
Coverage Δ

src/mtables.jl
98.61% <100.00%> (ø)

src/StarAlgebras.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ecb4e4...c27647e. Read the comment docs.


Redundant type casting in generated visit methods of SyntaxRewriter

Description
In the SyntaxRewriter implementation, I noticed that many visit methods are written in the following format:
open func visit(_ node: AttributeListSyntax) -> AttributeListSyntax {
    return Syntax(visitChildren(node)).cast(AttributeListSyntax.self)
}

Since the node argument is already of type AttributeListSyntax, and the visitChildren(node) method returns the same type, the type casting using .cast(AttributeListSyntax.self) appears to be redundant and unnecessary.
Suggested Improvement:
Consider refactoring the generated visit methods to remove this redundant type casting and Syntax wrapping. The improved version would look like:
open func visit(_ node: AttributeListSyntax) -> AttributeListSyntax {
    return visitChildren(node)
}

This simplification would make the codebase cleaner, more readable, and reduce potential points of failure.

Tracked in Apple’s issue tracker as rdar://114400377

So it looks like:

The potential change should be in CodeGeneration/Sources/generate-swift-syntax/templates/swiftsyntax/SyntaxRewriterFile.swift
visit() is not guaranteed to return same type, it has a bunch of overloads. visitChildren(), on the other hand, always returns the same type as the node that's passed into it.

How wrong am I? 🙃

The potential change should be in CodeGeneration/Sources/generate-swift-syntax/templates/swiftsyntax/SyntaxRewriterFile.swift

That's correct. Everything that's located in the generated folder in the main package is generated by CodeGeneration. with SyntaxRewriter coming out of SyntaxRewriterFile.swift.

visit() is not guaranteed to return the same type, it has a bunch of overloads. visitChildren(), on the other hand, always returns the same type as the node that's passed into it.

And you're right about the visit() functions as well; they have various overloads that can return different node types, unlike visitChildren() which is consistent in its return type.

If you find the time, it'd be worthwhile to sift through the CodeGeneration codebase to identify more spots where nodes are being cast to the same type using cast, as, or is. With the changes from issue #2092, we'll be able to notify users if they attempt to cast leaf nodes to other nodes—or even to the same node type. The tricky part is when someone upcasts a node to a base node like Syntax(node) and then downcasts it back to the original node type using Syntax(node).cast(node.Type).


Getting TypeError: Cannot read property 'access_token' of undefined when trying login.js

Expected behavior
Login Successful
Actual behavior
Throws error : TypeError: Cannot read property 'access_token' of undefined
Steps to reproduce the behavior
install teslajs
switch to teslajs/Examples directory
node login.js (with myusername and mypassword as parameters)
error thrown

### Version of the library tested
2.1.41

Thanks for the report.  I've heard that they may have changed the client keys.  I am investigating.

adding this to the requests seems to do the trick:
headers: {
            'User-Agent': 'Mozilla/5.0 (Linux; Android 9.0.0; VS985 4G Build/LRX21Y; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/58.0.3029.83 Mobile Safari/537.36',
            'X-Tesla-User-Agent': 'TeslaApp/3.4.4-350/fad4a582e/android/9.0.0',
        }

Thanks. Actually, manually adding the changes from @DoctorMcKay's PR today seems to fix what ails.

Interesting that adding the headers seems to fix it. I just assumed that it was instead rejecting the x-www-form-urlencoded bodies but I honestly tried both at the same time and it worked, so I didn't dig any deeper.

Maybe part of the new security update is checking the headers more closely.  I am looking over the PR now and will merge if all the tests pass.

PR #96 merged into master.  NPM publish will happen shortly.

Get sample problem now.

@SheldonLaw You will need to provide more specifics if you need help.


Add Laravel Telescope & remove debug bar

Proposed Change

Replace Debugbar with Laravel Telescope

Whats Changed

Pulled in Telescope & removed Debugbar
Updated README to support change

pulled in Telescope into Pingcrm while having a look, thought it might be a useful addition to Ping CRM, understandable if you're not wanting to add any further steps to the installation process. no hard feelings if no plans to merge.
p.s Thanks for all your hard work

I think this is a bit of an overkill.
PingCRM is for showing what intertiajs can do, and having debugbar for that is just the right amount of debug tools in my opinion.

Understandable, have closed the PR.
Thanks,
Taylor

@taylorgoodallau Thanks for your interesting in Inertia, and for this contribution. However, I do think I want to keep this demo app as simple as possible, and the Laravel Debugbar feels like a better fir that way. 👍


Update instances.json5 to add fedi.mint.lgbt

Hi-
I run an instance named Fedimint that we would like to add to the list.
Thanks!

@syuilo any updates on this? Sorry for disturbing you.

🙏

Thanks!


Build with make was broken for OSX

Make command gives this error:
Makefile:855: *** target pattern contains no `%'.  Stop.

I'm on commit 8f39551cf1056a6abf654129ad706965e0f0a3bd.

Fixed in https://github.com/cxxxr/lem/pull/450


Expected/Desired Behavior
The cacheSize parameter is ignored.
Liquibase Version
4.25.1
Database Vendor & Version
Microsoft SQL Server
Liquibase Integration
CLI
Liquibase Extensions
No response
OS and/or Infrastructure Type/Provider
Windows 11
Additional Context
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR (Thank you!)

Hi @Mas2112, thank you for reporting this issue. I found that the same thing was reported a few years ago for MariaDB (#2147) and fixed (#2270).
It's most likely caused by the same thing. Would you be willing to submit a PR to fix it? If so, our team will provide guidance through the process.
Thank you,
Tatiana


Adapt to variable usize length

Issue / Motivation
When I try to send messages between the client app (Rust, WASM, Seed framework) and the backend server (Rust, Windows, Warp framework), the client fails with this error:
'source slice length (4) does not match destination slice length (8)'

WASM in the browser supports only 32bit, so its usize has 4 bytes. Then, when Cocoon tries to call copy_from_slice with the source slice (usize bytes) and the destination slice (fixed 8 bytes in buf, hard-coded in serialization/deserialization functions), it fails because copy_from_slice panics when the slices have different lengths.
Workaround / Fix
This PR adds "dynamic slicing" to respect the real usize size and BE encoding.
Another solution would be probably to change length type from usize to u64 and handle potential serialization/deserializaion errors, but it would be a breaking change so I decided to only fix the current behavior.
Tests

It works in my Seed + Warp project with this PR.
cargo test passes.

Note: To make cargo test works, I had to set the fixed syn version because the latest one brakes borsh and the project doesn't have Cargo.lock.  Related issue in the nushell repo.

Thanks for the repo!
Martin

Hi @MartinKavik!
Thank you for your contribution, appreciate it! I'm thinking about how to cover this case with tests. Also, I wonder whether it is possible to achieve the same result without calling mem::size_of.

Hi @MartinKavik!
Thank you for your contribution, appreciate it! I'm thinking about how to cover this case with tests. Also, I wonder whether it is possible to achieve the same result without calling mem::size_of.

wonder whether it is possible to achieve the same result without calling mem::size_of.

buf[36 + (8 - size_of::<usize>())..Self::SIZE].copy_from_slice(&self.length.to_be_bytes());

could be probably changed to:
let length_bytes = self.length.to_le_bytes();
buf[36..36 + length_bytes.len()].copy_from_slice(&length_bytes);

(I've changed to_be_bytes to to_le_bytes to make the slice boundary computing easier to read / imagine, however it should be doable also with BE with some arithmetic gymnastics.)
and
let length = usize::from_be_bytes(
    buf[36 + (8 - size_of::<usize>())..Self::SIZE]
        .try_into()
        .map_err(|_| Error::TooLarge)?,
);

to:
let length = usize::from_le_bytes(
    buf[36..usize::MAX.to_le_bytes().len()]
        .try_into()
        .map_err(|_| Error::TooLarge)?,
);

(Yeah, my first idea is basically a dummy usize + len to simulate size_of. Also notice from_le_bytes. And I assume it (unfortunately) doesn't fail when we are deserializing the header for too large data.)

Why you don't want to call size_of? I've seen some comments about it in the code but I don't understand it.

Or what's your opinion on changing length type from usize to u64?

wonder whether it is possible to achieve the same result without calling mem::size_of.

buf[36 + (8 - size_of::<usize>())..Self::SIZE].copy_from_slice(&self.length.to_be_bytes());

could be probably changed to:
let length_bytes = self.length.to_le_bytes();
buf[36..36 + length_bytes.len()].copy_from_slice(&length_bytes);

(I've changed to_be_bytes to to_le_bytes to make the slice boundary computing easier to read / imagine, however it should be doable also with BE with some arithmetic gymnastics.)
and
let length = usize::from_be_bytes(
    buf[36 + (8 - size_of::<usize>())..Self::SIZE]
        .try_into()
        .map_err(|_| Error::TooLarge)?,
);

to:
let length = usize::from_le_bytes(
    buf[36..usize::MAX.to_le_bytes().len()]
        .try_into()
        .map_err(|_| Error::TooLarge)?,
);

(Yeah, my first idea is basically a dummy usize + len to simulate size_of. Also notice from_le_bytes. And I assume it (unfortunately) doesn't fail when we are deserializing the header for too large data.)

Why you don't want to call size_of? I've seen some comments about it in the code but I don't understand it.

Or what's your opinion on changing length type from usize to u64?

Or what's your opinion on changing length type from usize to u64?

Yeah, it's close to what is on my mind. The length in the struct is kind of a parsed data and it is used in other places, therefore we cannot easily change it, but we can do a simple trick:
let len64 = self.length as u64;
buf[36..Self::SIZE].copy_from_slice(&len64.to_be_bytes());

Big-endian (BE) should be preserved for backward compatibility for existing users, and here I assume that we give up on 128-bit architecture :) It should work for all 64-, 32- and 16-bit platforms, because we just expand variable to u64 with zeroes, and then convert into bytes.

Or what's your opinion on changing length type from usize to u64?

Yeah, it's close to what is on my mind. The length in the struct is kind of a parsed data and it is used in other places, therefore we cannot easily change it, but we can do a simple trick:
let len64 = self.length as u64;
buf[36..Self::SIZE].copy_from_slice(&len64.to_be_bytes());

Big-endian (BE) should be preserved for backward compatibility for existing users, and here I assume that we give up on 128-bit architecture :) It should work for all 64-, 32- and 16-bit platforms, because we just expand variable to u64 with zeroes, and then convert into bytes.

let len64 = self.length as u64;
I would rather write

let len64 = u64::try_from(self.length).map_err(|_| Error::TOO_LARGE)?; // or at least `.expect("too large data")`

I expect we either can serialize all data or the serialization will fail. Also Clippy doesn't like as for number casting because it can be surprising.
What do you think?

let len64 = self.length as u64;
I would rather write

let len64 = u64::try_from(self.length).map_err(|_| Error::TOO_LARGE)?; // or at least `.expect("too large data")`

I expect we either can serialize all data or the serialization will fail. Also Clippy doesn't like as for number casting because it can be surprising.
What do you think?

I think it's okay to put the expect there because cocoon format just doesn't support something larger than 8 bytes (e.g. putting length in to the new method of the whole 128-bit range on the imaginary 128-bit architecture). Everything else is gonna be serializable. Also it would be hard to modify the function's prototype and pass the error back into many places which don't expect (yeah, don't "expect") any error.

I think it's okay to put the expect there because cocoon format just doesn't support something larger than 8 bytes (e.g. putting length in to the new method of the whole 128-bit range on the imaginary 128-bit architecture). Everything else is gonna be serializable. Also it would be hard to modify the function's prototype and pass the error back into many places which don't expect (yeah, don't "expect") any error.

@MartinKavik ...Just the string inside of expect has to start from the capital letter. Thanks! :)

@MartinKavik ...Just the string inside of expect has to start from the capital letter. Thanks! :)

I think it's okay to put the expect there because cocoon format just doesn't support something larger than 8 bytes

I was thinking more about the cases like my original problem - sending encrypted data from the the platform supporting X bits to the platform supporting Y bits where X > Y (e.g. Windows/Linux -> WASM (64 -> 32).

Code updated and force-pushed, should be ready for another code-review round :)

I think it's okay to put the expect there because cocoon format just doesn't support something larger than 8 bytes

I was thinking more about the cases like my original problem - sending encrypted data from the the platform supporting X bits to the platform supporting Y bits where X > Y (e.g. Windows/Linux -> WASM (64 -> 32).

Code updated and force-pushed, should be ready for another code-review round :)


Streaming to another PC's instance of musikcube

I think I misundestood when I read the project description or maybe it is a feature that I don't know how to use.
I mean is the main way I plan to use musikcube is to use my local instance of it to receive the stream from another PC's instance of musikcube (media server with all the files).
I think similar behavior to the android app but between Windows/Linux instances in different PCs.
Otherwise, how can we use the server? Hope you can clarify.
Thanks and BTW awesome project!

Closing in favor of https://github.com/clangen/musikcube/issues/204


Is there a way to use "app-layout" with spring boot 2?

ERROR when using vaadin 14 + spring boot 2 in Production MODE
IT seems SPRING can´t find CSS file in production.
2019-11-26 16:21:02.035 DEBUG 6944 --- [nio-8080-exec-7] o.s.web.servlet.DispatcherServlet        : GET "/frontend-es6/com/github/appreciated/app-layout/app-layout-styles-lumo.css", parameters={}
2019-11-26 16:21:02.035 DEBUG 6944 --- [nio-8080-exec-7] o.s.w.s.handler.SimpleUrlHandlerMapping  : Mapped to org.springframework.web.servlet.mvc.ServletForwardingController@1d97afdc
2019-11-26 16:21:02.051 DEBUG 6944 --- [nio-8080-exec-7] o.s.web.servlet.DispatcherServlet        : Completed 404 NOT_FOUND
2019-11-26 16:21:02.051 DEBUG 6944 --- [nio-8080-exec-8] o.s.web.servlet.DispatcherServlet        : GET "/frontend-es6/com/github/appreciated/app-layout/left/left-responsive-hybrid.css", parameters={}
2019-11-26 16:21:02.051 DEBUG 6944 --- [nio-8080-exec-8] o.s.w.s.handler.SimpleUrlHandlerMapping  : Mapped to org.springframework.web.servlet.mvc.ServletForwardingController@1d97afdc
2019-11-26 16:21:02.067 DEBUG 6944 --- [nio-8080-exec-8] o.s.web.servlet.DispatcherServlet        : Completed 404 NOT_FOUND
DOES NOT happens when using in DEBUG MODE
2019-11-26 17:32:38.367 DEBUG 6444 --- [nio-8080-exec-2] o.s.web.servlet.DispatcherServlet        : GET "/frontend/com/github/appreciated/app-layout/app-layout-styles-lumo.css", parameters={}
2019-11-26 17:32:38.382 DEBUG 6444 --- [nio-8080-exec-2] o.s.w.s.handler.SimpleUrlHandlerMapping  : Mapped to org.springframework.web.servlet.mvc.ServletForwardingController@e31a27
2019-11-26 17:32:38.601 DEBUG 6444 --- [nio-8080-exec-3] o.s.web.servlet.DispatcherServlet        : GET "/frontend/com/github/appreciated/app-layout/left/left-responsive-hybrid.css", parameters={}
2019-11-26 17:32:38.601 DEBUG 6444 --- [nio-8080-exec-3] o.s.w.s.handler.SimpleUrlHandlerMapping  : Mapped to org.springframework.web.servlet.mvc.ServletForwardingController@e31a27
2019-11-26 17:32:38.679 DEBUG 6444 --- [nio-8080-exec-2] o.s.web.servlet.DispatcherServlet        : Completed 200 OK
2019-11-26 17:32:38.710 DEBUG 6444 --- [nio-8080-exec-3] o.s.web.servlet.DispatcherServlet        : Completed 200 OK

I do have the same issues.
I am working on a multi module spring boot application, where i do have a vaadin-parent, vaadin-app and a vaadin-common module.
As long i am using the debug mode, all is working fine, but if i build and launch with production mode, my css file from vaadin-common are not working anymore. @StyleSheet("frontend://styles/xyz.css")
With the same setup, just removing the app-layout in my main view, replacing by a vaadin VerticalLayout, the css files from the vaadin-common module works just fine.

What vaadin version are you using? Vaadin 14 does not use @Stylesheet any more, instead use @CssImport.

As indicated from another user here: https://github.com/appreciated/vaadin-app-layout/issues/297, I have fix that with a workaround: "UI.getCurrent().getPage().setLocation(...);" instead of "this.getUI().ifPresent(ui -> ui.navigate(...));" in my login page.

closed by fcf8214afdcaabdac1f1732770c70bd35757fb67


containerinstance release

https://github.com/Azure/sdk-release-request/issues/4007

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-arm-containerinstance


Update if block documentation

From the forum: The documentation for the if block with mutator references a "do" statement, but the statement is called "then" in the block. This can be misleading and should be corrected to match the block.

@farxinu Would you mind taking a look at this? It should be a quick fix.

Would this be on the explore site or within the code repository?

This is on explore.

I can't publish the page, but http://explore.appinventor.mit.edu/ai2/support/blocks/control is updated.

@farxinu Thanks. I've pushed the change to the production site.


CommonAssemblyInfo.cs analyzers

CommonAssemblyInfo.cs should start with the <auto-generated/> header and not with the using directives. Otherwise analysers will still analyse the file. AFAIK analysers only check for the <auto-generated /> tag in the leading trivia of the first token.
Currently, StyleCopAnalyzers report SA1512 A single-line comment within C# code is followed by a blank line for the generated CommonAssemblyInfo.cs file.

Fixed in version <IP_ADDRESS>


chore: remove unnecessary core/heapless/hashbrown re-exports from signature_…

ockam/implementations/rust/ockam/signature...crates

#2162
Proposed Changes
Remove unnecessary core/heapless/hashbrown re-exports from signature_core::lib, remove extern crate and make configuration attribute no_std and change the crate's comment.
Remove hashbrown from signature_core's Cargo.toml
Remove import of lib from signature_bbs_plus/examples/readme-source.rs since it is no longer required

Checks

[ ] All commits in this Pull Request are signed.
[ ] All commits in this Pull Request follow the Ockam commit message convention.
[x] I accept the Ockam Community Code of Conduct.
[x] I have accepted the Ockam Contributor Licence Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the ockam-network/contributors repository.

Thanks @jim4067 ! Could you please sign this comment? Then we'll get it merged. Thanks!

Thanks @jim4067 ! Could you please sign this comment? Then we'll get it merged. Thanks!

Hello 👋🏾 @jared-s I've been having some trouble signing the commits. I'll close this PR and try creating a new one, hopefully it will work then.


Fixed memory leak in GroupByUntil and refactored GroupedObservable

Coverage decreased (-0.9%) to 99.104% when pulling 435f9c286593eb063f019b1ffdf0006640cc83e8 on davidwdan:groupByUntil into d3884e59547085d7da2771d476cad17d410f440a on ReactiveX:master.

Coverage decreased (-0.9%) to 99.063% when pulling 7e99a0d107dec9aea24d0dad338c3bf7b4206266 on davidwdan:groupByUntil into d3884e59547085d7da2771d476cad17d410f440a on ReactiveX:master.

Coverage decreased (-1.0%) to 98.968% when pulling c36724db1d466ce10a1cbaa51f63302a8efa70b2 on davidwdan:groupByUntil into d3884e59547085d7da2771d476cad17d410f440a on ReactiveX:master.


Parentheses double when selecting with shift key

Single parentheses double when selecting text in the console input.

You get:
test_str = ''hi''
You can do it multiple times:
test_str = ''''''''''''''''hi''''''''''''''''

I tend to hold shit all the time when in the lab ;-)

Fixed, I think


Fix switching priority mode to focus still shows read chats

Details

The LHN list will update only if the isLoadingApp Onyx is false but this value stuck at true when the onyx updates from the server is the same.
Fixed Issues

$ https://github.com/Expensify/App/issues/34466
PROPOSAL: https://github.com/Expensify/App/issues/34466#issuecomment-1890370378
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Open the app
Go to priority mode settings
Switch the priority mode between Most Recent and #focus multiple times
Verify the LHN list updated correctly (Most Recent should show all chats, #focus should hide read chats)

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/e31daac8-54c0-4deb-b643-95d583427918

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/2c56be91-b021-471e-ad81-7f533557fab4

iOS: Native

https://github.com/Expensify/App/assets/50919443/494f4da5-f1f8-48e8-a498-38fab1d6d0a4

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/5861ddd0-6678-4805-9771-2967334718fb

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/5b41ee8a-c964-4b3a-a6f8-9f7c302f4821

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/40ace34d-c327-4c49-b871-cf7e482a04dc

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/dangrous in version: 1.4.28-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.28-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Add AWS as an Embedder Provider (required for Memory configuration)

In order to configure a Crew with memory=True without a OpenAI API Key, one needs to configure an Embedder provider. Currently, AWS (Amazon Bedrock and Amazon SageMaker) are not supported providers.
Ask

Include AWS in the providers list ('openai', 'gpt4all', 'huggingface', 'vertexai', 'azure_openai', 'google', 'mistralai', 'nvidia').
Support Amazon Bedrock Embedding models
Support Amazon SageMaker Real-time Endpoints

Things to note
Provider aws_bedrock is already supported in llm configuration, e.g.:
semantic_search_resume = MDXSearchTool(
    mdx='./fake_resume.md',
    config=dict(
        llm=dict(
            provider="aws_bedrock", # <=== WORKS!
            config=dict(
                model="anthropic.claude-3-haiku-20240307-v1:0",
                # Optional parameters can be included here.
                # temperature=0.5,
                # top_p=1,
                # stream=true,
            ),
        ),
        embedder=dict(
            provider="aws_bedrock", <=== DOES NOT WORK!
            config=dict(
                model="cohere.embed-english-v3",
                task_type="retrieval_document",
                # Optional title for the embeddings can be added here.
                # title="Embeddings",
            ),
        ),
    )
)

I'll add one more option that's missing, Oracle Cloud

Watching - would very much appreciate this feature

Still relevant

I can confirm this has worked for me, or at least it hasn't failed. deployment_name parameter is unnecessary I think - please let me know if that's not the case. This can be closed for now.
crew = Crew(
  agents=agents_list, tasks=tasks_list,
  verbose=True, memory=True,
  embedder={
    "provider": "aws_bedrock",
    "config":{
      "model": "amazon.titan-embed-text-v2:0",
      "vector_dimension": 1024
    }
  }
)


Fix test-build.sh chains artifacts

Signed-off-by: Luiz Carvalho<EMAIL_ADDRESS>

Failed CI has to do with a yamllint failure. I cannot view more information. I also have not changed any yaml files in this PR.

/retest


Releasing the whole DELIVER dataset

Hi thank you for your beautiful work!!!
I would like to know if you are planning to release the whole DELIVER dataset with all the views.

Hi thanks for your interest.
Based on our project plan, we are sitll working on the other part of the DELIVER dataset.


migrating from asdf to rtx?

Sorry to open an issue just for a question, but how does one go about migrating from asdf to rtx?

I'm not sure there is anything special to document here, you just set it up and start using it using the standard instructions. It will work with existing asdf .tool-versions files.


Handle menu dismiss on tap manually

When tapping on any control e.g. a button within the menu view the menu view auto dismisses, there is no option to handle dismissing the menu manually like in 5.0.3, i would like the menu to remain presented until i want to dismiss it, i have noticed there is Tap gesture on the view which dismisses the view, can this be made optional?

SideMenuManager.default.rightMenuNavigationController?.dismissOnPush = false
SideMenuManager.default.rightMenuNavigationController?.dismissOnPresent = false


resolve: issues (fix #434, fix #421, fix #437)

Please check if the PR fulfills these requirements

[x] It's submitted to right branch according to our branching model
[x] It's right issue type on title
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes/features)
[x] Docs have been added/updated (for bug fixes/features)
[x] It does not introduce a breaking change or has description for the breaking change

Description

fix #434 : When creating a schedule, passing the category property to 'allday' does not create an all-day schedule.
fix #421 : When changing the calendar ID in the default edit popup, the calendar is not reflected.
fix #437 : If a calendar color exists, overwriting the calendar color even if you pass the custom color of the schedule as a property.
fix #452 : fix: resolve handlebar template fuction override

It's an issue with the react wrapper.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Suggestion: isAllDay should't be a settable property of schedule.
If needed for convenience, it should be a computed property (in Vue, not sure what's the JS equivalent)
isAllDay = (options.category && options.category === 'allday')

@mariusa
Even if the category is time, if it is more than one day (24 hours), it is considered as an all-day schedule.
When specifying category as allday, it is better to turn on isAllDay option.

ok to test

ok to test


Req Android / IOS project source code

i have run bazel mobile build generation, but it's generated IPA, APK files as final output, it's not provide xcode or android studio project source code.
can you please provide complete project source code for IOS and Android..!

Glad to hear that you can successfully build the IPAs and APKs.
For the source code, we do provide the source code of our Android and iOS examples in https://github.com/google/mediapipe/tree/master/mediapipe/examples.
Please follow https://github.com/google/mediapipe/blob/master/mediapipe/docs/install.md#setting-up-android-studio-with-mediapipe and https://github.com/google/mediapipe/blob/master/mediapipe/docs/mediapipe_ios_setup.md#creating-an-xcode-project to see how to set up mediapipe with android studio and xcode.

Closing due to lack of recent activity.


Custom dropdown list

Could you please help me how can I create custom component for my dropdown (not Bootstrap and not standard Select). I need to just click the dropdown and find the element inside the element by text (or by any value)
Something like this:
[FindByXPath("//p-dropdown[@optionlabel='countryName']")]
public CustomSelect<Country, _> CountryList { get; private set; }
Go.To<RegisterForm>().
       CountryList.Should.Equal(Country.None).
       CountryList.Set(Country.Ukraine);
Please just a simple example

You can take a look at these examples:

https://github.com/atata-framework/atata-samples/tree/master/ExtJS
https://github.com/atata-framework/atata-samples/tree/master/SalesforceLightning
https://gist.github.com/YevgeniyShunevych/ec74f7ade13d3fdfde17e6a783e23d3e
https://github.com/atata-framework/atata-kendoui/blob/main/src/Atata.KendoUI/KendoDropDownList`2.cs

I still cannot find the inner elements(

Yes, that's right. Great, that you solved that.


Typo in [RELEASE_ARTIFACTS_{artifact_name}_DEFINTIONID] env variable name.

I just wanted to report minor issue, that made me to debug my scripts for extra hours.
Azure DevOps, private Windows agent v2.144.2 - release pipeline.
What's not working?
I noticed there is typo in env variable name [RELEASE_ARTIFACTS_..._DEFINTIONID]. This is turn might introduce challenges writing scripts that depend on this variable.
This incorrect name probably comes from typo in master/src/Agent.Worker/Release/Artifacts/Definition/BuildArtifactDetails.cs - DefintionId property.
Agent and Worker's Diagnostic Logs
2019-02-05T08:46:58.7743992Z ##[section]Starting: Initialize job
2019-02-05T08:46:58.7744967Z Current agent version: '2.144.2'
2019-02-05T08:46:58.7768399Z Prepare release directory.
2019-02-05T08:46:58.7780509Z ReleaseId=29, TeamProjectId=GUID ReleaseDefinitionName=Deploy TestSite1 (process)
2019-02-05T08:46:58.7834847Z Release folder: C:\VSTSAgent_work\r1\a
2019-02-05T08:46:58.7965288Z Environment variables available are below.  Note that these environment variables can be referred to in the task (in the ReleaseDefinition) by replacing "" with "." e.g. AGENT_NAME environment variable can be referenced using Agent.Name in the ReleaseDefinition:
[AGENT_DEPLOYMENTGROUPID] --> [1711]
[AGENT_HOMEDIRECTORY] --> [C:\VSTSAgent]
[AGENT_ID] --> [132]
...
[RELEASE_ARTIFACTS{...}DEFINITIONNAME] --> [publish]
[RELEASE_ARTIFACTS{...}_DEFINTIONID] --> [publish]

@GitHubSriramB
DEFINTION --> DEFINITION, i think we might need to set both, since people might already take dependence on the typo one.

I fully agree this will be breaking for number of people who took dependence on typo. From the other side I would still consider following:

If they spotted typo, they should expect the change and implement their scripts in the way that supports further typo fix.
Is dependence argument strong enough to continue with this incorrect env and take extra technical debt in agent project?

We document the correct one.  We set both.
Yes, we don't break existing customers knowingly.  The extra code is minimal - we set another variable.

@mgrabarz Thanks for reporting this issue. We have added a new variable with correct spelling and maintained the older one for backward compact. The fix is pending deployment.


[BUG] I don't see a sensor.to_do_list to add as an entity

Before submitting a bug

[x] I updated to the latest card version available
[x] I cleared the cache of my browser

Hi! No matter what I tried, I can't see the to_do_list entity. Do I need to define this somewhere?
My configuration.yaml looks like this:

calendar:

platform: todoist
token: !secret todoist_api_token

sensor:

platform: rest
name: To-do List
method: GET
resource: 'https://api.todoist.com/sync/v9/projects/get_data'
params:
token: !secret todoist_api_token
project_id:<PHONE_NUMBER>
value_template: '{{ value_json[''project''][''id''] }}'
json_attributes:

project
items
scan_interval: 30

rest_command:
todoist:
method: post
url: 'https://api.todoist.com/sync/v9/{{ url }}'
payload: !secret todoist_api_payload
content_type: 'application/x-www-form-urlencoded'

Hi! Did you try to restart your HA?

Yeah! I tried everything... I ended up switching to the built-in shopping-cart as a to-do list which suits my needs :-#

And there are no related to Todoist errors in HA logs?

I'm guessing it has to do with this?
https://github.com/home-assistant/core/issues/79216#issuecomment-1354055769

No, I don't think so. This card is using Todoist's Sync API and has nothing in common with HA Todoist integration.

But, maybe, problems with that integration are causing problems with REST sensor used in this card.

I can confirm the same issue with my installation, on 2022.12.0. I've had this card working for a long time. A couple of months ago, it stopped working and I had to update the code to use v9 instead of v8 and it started working again. It has now stopped again as of 3 or 4 days ago. I've incorporated changes from the recent rest command updates, but no change.

Sensor is actually present, but shows a status of unknown since December 22, around 3:25am CST

https://github.com/grinstantin/todoist-card/issues/28#issuecomment-1366041493

I'm closing this issue, if the problem is still present - feel free to open it again.


Re Render when press

Hello!!!
Is an amazing plugin for drag and drop tables!
The only issue that I have found, that when I add a button and I press it, it does the entire re render cycle again, so I am not able to trigger any event without re rendering the entire thing and simulates like if all the rows han been click at the same time.
Greetings!

@lindemann18 大佬怎么解决呢


Player Additions are better.

What is the problem / feature ?

Adding players is awkward and not a good interface.
The lifetime ranking graph could be prettier.

How did it get fixed / implemented ?

Refactored the structure of the JS files in the app to be a bit more separated by application.

Refactored how the application js is loaded so that apps don't leak into each other.

Replaced the current player addition with a much better one.

Modified the Player model so that it allows uploading of a custom icon rather than a preset selection of them.

Modified the graph to be curvey and have points and the data points.

How can someone test / see it ?
Go to the Players link in the header of the site.
Here is a cute animal picture for your troubles...

The migration should be run on a dump of the production database before we deploy this.  Also, I plan to get the tests passing before this is merged.

@eyetoe may also need to do some minor config for nginx to serve /media/  the same way that /static/ is being served.

Tested the migrations on prod dump.  Everything is :green_heart:


A question about FAST.Farm

Dear ,

How shoul I solve this problem?

I have this problem too, but I have eight fans. I had a problem with the eighth one, I removed the eighth one and it worked fine, maybe it was out of bounds

A similar question regarding high Ct was recently asked and answered on our forum: https://forums.nrel.gov/t/fast-farm/1887/451.
Best regards,

I have this problem too, but I have eight fans. I had a problem with the eighth one, I removed the eighth one and it worked fine, maybe it was out of bounds

Dear @Yongbyon
Have you solved the problem? I set X long enough, but I still have the above problem. I'd like to see your fstf file if it's convenient. Thanks!


bug: Nodepool stack needs to use the nodepool logical name

Found an issue where the network and nodepool stacks are using not using the same name for the worker arn.  Correct by using santized name for both.

Codecov Report

Merging #1515 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1515   +/-   ##
=======================================
  Coverage   25.46%   25.46%
=======================================
  Files          97       97
  Lines        5003     5003
=======================================
  Hits         1274     1274
  Misses       3582     3582
  Partials      147      147

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b62da15...00e15f9. Read the comment docs.


update to twin.macro

Hey Paulo, I've just updated Andrew's article - Using Tailwind CSS with Gatsby, React & Emotion Styled Components with twin.macro which is an updated version of tailwind.macro so I thought I should update your starter too as the article is pointing here.

@ben-rogerson thank you sir!
Sorry for letting this linger for so long but I never saw the notification. I'll take a look today and get it merged in shortly.


TimeSeries features

Hi all,
Great library and work!  I was curious if there is a recommended way to get the time series features as a dataframe without running the model?  I am looking to compare with other models.
Thanks,
George

Hi,
If I understand your question correct you want a to access the df_features without running the model?
If so:
Suppose you have your dataframe, df, which contains the columns "ts" and "y"
Run:
from greykite.common.features.timeseries_features import build_time_features_df
df_features = build_time_features_df(
dt=df["ts"],
conti_year_origin=convert_date_to_continuous_time(df["ts"][0])
)

Hi,
Thanks, I think that generates most of the features.  How would I also get the rest of the features I see in the summary_model function.
Thanks,

Hi @ggerogiokas, the build_time_features_df method generates all time-related features, which are not necessarily all included in the forecast model. If you are thinking to get the corresponding feature df given a ForecastConfig, currently we don't have a function to directly extract the built features, but a workaround could be fitting the fastest linear model with cross-validation turned off. You could add
custom=dict(
                fit_algorithm_dict={
                    "fit_algorithm": "linear"
                }
            )

to ModelComponentsParam and add
evaluation_period_param=EvaluationPeriodParam(
            cv_max_splits=0
        )

to ForecastConfig to speed up the fitting process. Then you can get the dataframe from
forecaster.forecast_result.model[-1].model_dict["x_mat"]

Hi @KaixuYang,  thanks for the advice I will try that!


Reading huge files

I have QVD file of 900mb and it wont read it or takes too long.
Is there any way to show a progress bar while reading the file?
Or at least some sort of indicator?

Short Answer:
Of course this library has its limitations in terms of data size. It should be obvious that this library cannot deliver the same performance as a Qlik Sense installation when reading the data. 900mb is a lot, I assume we are talking about several tens of millions of rows, right?
Long Answer:
On the other hand, if you're reading large files it makes sense to track the progress, I agree with you there. One could think about a mechanism similar to pandas. pandas offers the option to read large files chunk by chunk and between reading the chunks you could update a progress bar with tqdm for example.
The problem is the way QVD stores its data. In a QVD file the data isn't stored in a plain tabular format like in a CSV. The cell values are stored in a separate table (Symbol Table) and the actual rows (Index Table) only contains value indices, hence must be decoded. So you would have to read the entire Symbol Table at the beginning in order to be able to decode the rows. The individual rows (Index Table) could then be read in chunks, similar to pandas. So if the problem with the large QVD file is that there are too many rows, then reading chunks helps. However, if the size is (also) due to too many cell values, this approach is only of limited help because the entire symbol table has to be read in at the beginning for decoding anyway.
So what's the shape of your 900mb QVD file? Are there so many rows? I have to check for a way to integrate chunking into the existing major version API. Any suggestions?

I don't have Qlik myself, these files are supplied by my client.
Indeed they are very big, even Sublime Text has trouble opening the csv after conversion.
A slightly bigger .qvd managed to get read and written to a csv. This one has 5.310.170 rows.
Functionally I'd probably like to see a reader that has a pointer-based system so you can trigger reading one or many lines and handle those before the next lines are read. If you add a total amount of rows and current position of the pointer people are free to add their own progress bars.

Sounds like a similar solution like the pandas way. We have to introduce an additional option for specifying the chunk/iteration size:
from pyqvd import QvdTable

itr = QvdTable.from_qvd("path/to/file.qvd", chunksize=100)

for chunk in itr:
    ...

To implement this we would need a class analogous to pandas TextFileReader class, which acts as an iterator and in this case is returned instead of the QvdTable.

I just published a pre-release of a new major version, that contains support for reading QVD files in chunks. This would allow you to display a progress bar, using tqdm for example. See the documentation for details. @falko100 Feel free to check it out and give me some feedback if you want.

@falko100 Otherwise if it's a performance issue, maybe you can profile your program when reading in big files and share the profile information.
Understanding which lines of code take the most time would help in optimizing

This issue is addressed in the (latest version)[https://pypi.org/project/PyQvd/2.2.0/] by introducing a feature for reading QVD files by chunks.


Add Gif in the readme

Three Gif or animations are required to add in readme for allow user to understand the process more easily.

Configure Settings Sync - Show the process of following things.

Welcome Page should be automatically open
Click on the Login with Github and click on Open Link
Write GitHub username and password and allow access to Github Application. [username and password should be blurred in the screen]
Get the success message on the browser
Switch into the vscode and see the connected list of Gist and click on Skip button

Upload Settings - Show the process of following things.

Select on the Sync:Upload Settings
Focus on the Code dialog bar for sync status
Upon upload complete, show the summary details.

Download Settings -  Show the process of following things.

Select on the Sync:Download Settings
Focus on the Code dialog bar for sync status
Upon download complete, show the summary details.

Open for PR.

cc : @mmakarios and @angeliski ( Ref : https://github.com/shanalikhan/code-settings-sync/issues/423 )

Does this still need any more work ? Or are people working on this ?

No one is working
U can send PR
Get Outlook for iOShttps://aka.ms/o0ukef

From: Haseeb Majid<EMAIL_ADDRESS>Sent: Thursday, September 26, 2019 1:59:57 PM
To: shanalikhan/code-settings-sync<EMAIL_ADDRESS>Cc: Shan Khan<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [shanalikhan/code-settings-sync] Add Gif in the readme (#1047)
Does this still need any more work ? Or are people working on this ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/shanalikhan/code-settings-sync/issues/1047?email_source=notifications&email_token=ACC6HHCVBY25ODLLRQB2S3DQLR2Y3A5CNFSM4IYYNPP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7U3N5I#issuecomment-535410421, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACC6HHACF3S3VOBAQERO633QLR2Y3ANCNFSM4IYYNPPQ.


CorrectContraband levels on each type of magboots

About the PR

All magboots, even blood-reds, say they are engineering contraband. I corrected each type of magboots to reflect the appropriate contraband type.
Fixes #30931
Why / Balance

Show the correct contraband type to a user when examining an item.
Technical details

Added a ClothingShoesBootsMagBase that is the parent of all other magboot types, this has no contraband level. Modified each of the other magboot child entities to have the appropriate contraband level.
Media

Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Modified magboots.yml to have a new base/parent entity "ClothingShoesBootsMagBase." This has no contraband parent, and is the parent of all the other magboots types, which now have their own contraband parents set.
Changelog

:cl: Allen

fix: Magboots, Science Magboots, Advanced Magboots, and Blood-Red Magboots now have appropriate contraband types

This should be made abstract. https://github.com/space-wizards/space-station-14/pull/30960/files#diff-561368ee69e714fc0d3399dcaacfe7bfebf482d25e0eae14380066d580e4bd0bR1-R36

I have changed the base entity to be abstract

only thing contraband should be blood-red magboots

You coming back to this?

I've been in vacation an will get back Tuesday and plan on doing it then (unless someone else gets to it first)

I've been in vacation an will get back Tuesday and plan on doing it then (unless someone else gets to it first)

There's a draft PR open for the bloodred magbots but not the rest so it seems fine to me to just wait for the most part

I've been in vacation an will get back Tuesday and plan on doing it then (unless someone else gets to it first)

There's a draft PR open for the bloodred magbots but not the rest so it seems fine to me to just wait for the most part

I removed engineering contraband from the regular Magboots. Now the only contraband magboots are the CE's Advanced Mag Boots (Grand Theft Contraband) and the Blood-Reds (Syndie Contraband).


F1 score and dataset

Hello!I would like to inquire about whether the F1 score in the paper was not imported into the ChamferDistancePython library in GitHub?Also, regarding the ShapeNet dataset and Completion3D dataset mentioned in the paper, could you provide a download link for the dataset? The Completion3D link has expired.Thank you very much!

Thanks for your interest in our work!
Here is the link for F1 and CD: https://github.com/ThibaultGROUEIX/ChamferDistancePytorch
Here is the link for ShapeNet: https://drive.google.com/drive/folders/1P_W1tz5Q4ZLapUifuOE4rFAZp6L1XTJz
Here is the link for Completion3D: http://download.cs.stanford.edu/downloads/completion3d/dataset2019.zip

Thank you very much. Do you use wechat? Is it convenient to leave a contact information?
---Original---
From: "Ark @.>
Date: Sat, Jul 15, 2023 23:22 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [ark1234/CP-Net] F1 score and dataset (Issue #1)
Thanks for your interest in our work!
Here is the link for F1 and CD: https://github.com/ThibaultGROUEIX/ChamferDistancePytorch
Here is the link for ShapeNet: https://drive.google.com/drive/folders/1P_W1tz5Q4ZLapUifuOE4rFAZp6L1XTJz
Here is the link for Completion3D: http://download.cs.stanford.edu/downloads/completion3d/dataset2019.zip
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


admin_bro_1.buildFeature is not a function

Hi! I'm using this module follows documentation, but receive this:
const uploadFeature = admin_bro_1.buildFeature({

TypeError: admin_bro_1.buildFeature is not a function

which modules do you use?
and try to remove node_modules and make sure you have the latest admin bro version

"@admin-bro/express": "^3.0.0",     "@admin-bro/mongoose": "^1.0.0",     "@admin-bro/upload": "^1.0.0",     "admin-bro": "^2.2.4",
Already tried to remove node_modules and install them again.

do you use typescript? can you paste more stacktrace and your code?

Nope, JS.
https://gist.github.com/AlexeyVlasenko/ef03ba7f578ed41c04caceb12afae3c8

can you go there (Documents/Work/Node/app/node_modules/@admin-bro/upload/build/features/upload-file/upload-file.feature.js:146:39) and console log AdminBro.VERSION?

AdminBro version is:  2.9.0

Okay, i'm sorry, that's my fault.
For some reason version of admin-bro wasn't up-to-date.
After upgrading it to 3.2.5 all works. Thanks!

it might not be you fault. I think that it used version from adapter. We will have to update adminbro dependencies everywhere. So leaving this open

mongoose beta has the latest version so closing this one


Add mountNode prop to Popup module

If a React app with SUIR is running in a hidden IFRAME and rendering some or all of its virtual DOM to the parent frame or another frame, then the Popup component should not insert popup elements into the document.body of the React IFRAME, but instead should inject into the frame containing the Popup trigger, or even into some other container as may be more appropriate (due to size or layering concerns between multiple frames).
Adding a mountNode prop to Popup allows developers to specify the appropriate container for a displayed popup element in cases such as the above example.
This PR implements a mountNode prop for Popup, with code very similar to the same prop's implementation in Modal.

Codecov Report

Merging #4362 (7832ab6) into master (49f0056) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4362   +/-   ##
=======================================
  Coverage   99.75%   99.75%
=======================================
  Files         180      180
  Lines        3248     3250    +2
=======================================
+ Hits         3240     3242    +2
  Misses          8        8

Impacted Files
Coverage Δ

src/modules/Popup/Popup.js
98.95% <100.00%> (+0.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f0056...7832ab6. Read the comment docs.


pull daylong sample file from homebank

Excellent news! There is one public full daylong file up on homebank:
https://homebank.talkbank.org/access/Public/VanDam-Daylong.html
Please use it for the test for daylong files. The citation that should go in the README is:
VanDam, M., & Tully, T. (2016, May). Quantity of mothers’ and fathers’ speech to sons and daughters. Talk presented at the 171st Meeting of the Acoustical Society of America, Salt Lake City, UT.
I think the audio can be pulled with:
wget -c robots=off -r -l inf --no-remove-listing -nH --no-parent -R 'index.html*' http://media.talkbank.org/HomeBank/VanDam-daylong/
The transcripts need to be:

downloaded from https://homebank.talkbank.org/data/Public/VanDam-Daylong.zip
unzipped
processed

I don't think we have any official tools to process .cha --> rttm OR .its --> rttm but both will be useful in the future. I propose we focus on the .cha --> rttm now; here's a snippet that could be modified to produce proper rttms:
for j in .cha; do
grep -v "^@" < $j | grep -v "^%" | tr -d "\t" | sed 's/([0-9][0-9])([0-9][0-9]*)/%\1%\2/g' | tr "" "-"  | tr -d "\n" | tr -d "\r" | tr '*' '\n'   | tr ":" "\t" | tr "%" "\t" | tr -s " " | sed 's/^$//' | awk -F'\t' 'NF==4 {print}' >> $j.txt
done
That will produce a file with this shape:
participant phrase onset offset
where phrase is what has been transcribed, onset and offset are in milliseconds. So it is missing some of the other rttm columns.

We have some tools that might do a better job of converting .cha files; they are notoriously strangely formatted (especially with respect to line breaks), such that looking at the raw .cha might miss things. I will find or provide some code that uses the CHATTER program to parse CHA to XML, and then you can pull out values from XML reliably. We've done this for STM format, but maybe not RTTM (but they are quite similar)

to clarify, this is what needs to happen to close this issue:

[ ] add pulling of daylong file with annotation to the initial installation of the VM - @riebling
[ ] add sequence of tests for daylong files to the test routine of the VM - @riebling
[ ] make updates (notably citation information) to the VM readme - @alecristia

combined with issue #23


Update policy.json for recent code change

Signed-off-by: Nathan LeClaire<EMAIL_ADDRESS>

updates godeps as well


docs: Fix simple typo, enviroments -> environments

There is a small typo in is.js.
Should read environments rather than enviroments.

fixed via https://github.com/evdama/is.js/commit/9fc06f7265ca927f543d1b71f17ddebe6b79e890
Want to close this one?


Translate 'Unsupported' in AVS responses to S

@j-mutter @ivanfer for review.
MiGS returns the string "Unsupported" for their AVSResultCode when they don't support AVS. That's not even a code!
This change makes it so that the code gets converted into 'S', which is the code for "Bank does not support AVS" according to the wikipedia page.

Someone did a bad.
:palm_tree:

Ugh, really? ಠ_ಠ

But yeah, :shipit:


Example configs?

Taffybar is running smooth, low cpu, easy install via cabal. Wondering if you could include some more examples in the sample taffybar.hs file. I'm hitting a wall trying to get the battery indicator running. Alternately, or in addition, a list of other taffybar.hs samples elsewhere on github/etc. would be useful as examples. I didn't find any on a quick search but I'm sure they are out there.

I'll try to add more examples.
To help more immediately with the battery widget issue, try something like:
main = do
let battWid = batteryBarNew defaultBatteryConfig 30
defaultTaffybar defaultTaffybarConfig { startWidgets = [battWid], barHeight = 25 }

Tristan, thanks, that's a huge help. Once I figure things out a bit more
I'm happy to help contribute to documentation (if that helps).
Ethan Schoonover
Github/Freenode: altercation - Solarized:
http://ethanschoonover.com/solarized
On Wed, Nov 30, 2011 at 07:48, Tristan Ravitch <
<EMAIL_ADDRESS>
wrote:

I'll try to add more examples.
To help more immediately with the battery widget issue, try something like:
main = do
let battWid = batteryBarNew defaultBatteryConfig 30
defaultTaffybar defaultTaffybarConfig { startWidgets = [battWid],
barHeight = 25 }

Reply to this email directly or view it on GitHub:
https://github.com/travitch/taffybar/issues/7#issuecomment-2961392

Tristan,
That battery config sample results in the following error. I'm not a total hs noob but neither am I proficient, so I would not be surprised if this is some trivial mistake on my end. Regardless, I thought I'd pass this along. My taffybar.hs is available at https://github.com/altercation/es-etc/blob/master/xmonad/taffybar/taffybar.hs
Error follows:
Configuration '/home/es/.config/taffybar/taffybar.hs' changed. Recompiling.
Program reconfiguration successful.
Launching custom binary /home/es/.cache/taffybar/taffybar-linux-x86_64

taffybar-linux-x86_64: connect: does not exist (No such file or directory)

The config works fine with the battery elements removed. I did also try the text only battery widget, same result.

On Wed, Nov 30, 2011 at 09:54:32PM -0800, Ethan Schoonover wrote:

Tristan,
That battery config sample results in the following error. I'm not a
total hs noob but neither am I proficient, so I would not be
surprised if this is some trivial mistake on my end. Regardless, I
thought I'd pass this along. My taffybar.hs is available at
https://github.com/altercation/es-etc/blob/master/xmonad/taffybar/taffybar.hs
Error follows:
Configuration '/home/es/.config/taffybar/taffybar.hs' changed. Recompiling.
Program reconfiguration successful.
Launching custom binary /home/es/.cache/taffybar/taffybar-linux-x86_64

taffybar-linux-x86_64: connect: does not exist (No such file or directory)

The config works fine with the battery elements removed. I did also try the text only battery widget, same result.

Reply to this email directly or view it on GitHub:
https://github.com/travitch/taffybar/issues/7#issuecomment-2971250

As a first guess, does your distro provide the upower daemon?  The
battery widget is currently written in terms of that because I didn't
want to implement the /proc parsing myself.  It seems plausible that
the error could be coming from dbus when it tries to connect.
If your distro provides it but does not install it by default, you
might try to install it.  If you don't have the upower daemon
available, I wouldn't expect it to work (I could throw together a
version that doesn't require the daemon).

Tristan, it does and I had previously installed it, but you nailed it.
Bisecting a driver regression today and I reinstalled this test machine and
my install script doesn't handle upower. I'll work on the dbus/upower end
of things and I'm sure that will solve this issue. Thanks for the pointer.
Ethan

Confirmed, working great. Thanks. Closing this.


add a boom2 CLI

per https://github.com/tarekziade/boom/issues/64
Let's add a boom2 command to generate load on a single endpoint, then deprecate boom1

Let's call the CLI "robusto"

and make it a separate project

won't do. see https://github.com/tarekziade/salvo


Need to truncate titles in DB

Updating an issue with a really long title:
  SQL (1.7ms)  INSERT INTO "issues" ("url", "last_touched_at", "number", "created_at", "updated_at", "repo_id", "title", "html_url", "state") VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9) RETURNING "id"  [["url", "https://api.github.com/repos/fsharp/FAKE/issues/1221"], ["last_touched_at", 2016-04-12 18:34:04 UTC], ["number", 1221], ["created_at", 2016-06-06 22:27:56 UTC], ["updated_at", 2016-06-06 22:27:56 UTC], ["repo_id", 244], ["title", "MSBUILD : error MSB1021: Cannot create an instance of the logger. Could not load file or assembly 'Microsoft.Web.XmlTransform, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified."], ["html_url", "https://github.com/fsharp/FAKE/issues/1221"], ["state", "open"]]

Gives an error
ActiveRecord::ValueTooLong: PG::StringDataRightTruncation: ERROR:  value too long for type character varying(255)
: INSERT INTO "issues" ("url", "last_touched_at", "number", "created_at", "updated_at", "repo_id", "title", "html_url", "state") VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9) RETURNING "id"

Easiest thing i think is to truncate at 254 chars and ad an ellipsis

@schneems We can also make the field text. Postgres does not have performance impact.
Check Tip on this page - https://www.postgresql.org/docs/9.1/static/datatype-character.html

There is no performance difference among these three types, apart from increased storage space when using the blank-padded type, and a few extra CPU cycles to check the length when storing into a length-constrained column. While character(n) has performance advantages in some other database systems, there is no such advantage in PostgreSQL; in fact character(n) is usually the slowest of the three because of its additional storage costs. In most situations text or character varying should be used instead.

For UI, we can use truncate or something.

I'm fine with either method.

I just installed rollbar recently and this is happening quite a bit
131 occurrences: https://rollbar.com/issuetriage/issuetriage/items/3/
ActiveRecord::ValueTooLong: PG::StringDataRightTruncation: ERROR: value too long for type character varying(255) : INSERT INTO "issues" ("url", "last_touched_at", "number", "created_at", "updated_at", "repo_id", "title", "html_url", "state") VALUES ($1,
Status: Active

@GustavoCaso do you have some time to look into making a patch? Any questions about the issue?

@schneems sure let have a look, if there any questions I will let you know.

This was fixed in https://github.com/codetriage/codetriage/pull/478/files


Removal of redundant views and associated routers from web

RLE functionality is no longer required. This PR starts the removal the redundant views, routers and handlers.
Left the RLE list screen so as to not break the existing journey.

CI: No security warnings found

I'm not sure I understand why removing the RLE list screen will break the journey.. I haven't run this but surely we shouldn't select RLE from the PSC type screen?

I'm not sure I understand why removing the RLE list screen will break the journey.. I haven't run this but surely we shouldn't select RLE from the PSC type screen?

This is a quick change I have made the simplest of changes that don't break anything. I don't want to spend too long on it. I was coming it at more from the perspective of sonar and seemed like a quick fix to remove all the screens that we don't have wired up and then our code coverage will improve hopefully.

ok fair enough.

CI: No security warnings found


Add confirm to close dialog. Closes #373.

This pull request adds the dialog that asks a user if they want to close Ambie while sounds are playing.
Closes #373.
Requires localization. Strings are currently hard-coded for the dialog. Update them in DialogService.cs.

Thank you for the contribution :)

Of course! Thank you for the app :)


Accept HTTP_PROXY to specify a fallback server during development

Like proxy in package.json could react-script start also accept the HTTP_PROXY or HTTPS_PROXY environment variables to specify a fallback server during development?
It would be as easy as adding a few lines of code
var proxy = require(paths.appPackageJson).proxy
if (!proxy) {
  proxy = process.env.HTTPS ? process.env.HTTPS_PROXY : process.env.HTTP_PROXY
}

This is useful in situations like mine where some team members don't use dockers and others do, resulting in different proxy urls.
I'm available to create a PR if you deem this acceptable.

Alternatively, so HTTP_PROXY or HTTPS_PROXY has priority over the proxy key on package.json:
var proxy = process.env.HTTPS ? process.env.HTTPS_PROXY : process.env.HTTP_PROXY;
proxy = proxy || require(paths.appPackageJson).proxy

It would actually be better for my situation, but I'm not sure if it makes sense...
Also HTTP_PROXY will interfere with npm outgoing requests, like when installing packages. This can be avoided using the --noproxy flag.

Also interested in this.

👍  also interested for similar reasons

As a workaround, I'm dynamically setting the proxy value in my package.json from an environment variable with a prestart script, but the solution @laginha outlined above would be preferable.

If implemented, this should use different naming from HTTP_PROXY and HTTPS_PROXY which are already meaningful in command-line environments; they commonly refer to a proxy that should be used for all requests by command-line HTTP clients.

@john-matroid How did you set the proxy variable in the prestart script?

Big +1 for this, static proxy package.json makes for annoying process sharing across devs that mostly use remove dev machines that are on different hosts/ips.  Our current hack similar to @laginha suggestion was to change the line in start script:
// Load proxy config
const proxySetting = process.env.PROXY_HOST || require(paths.appPackageJson).proxy;

@john-matroid I'm also interested in your approach of setting the "proxy" value in the package.json dynamically since I was not able to modify it from a pre-executed script or read it from an environment variable. Could you please outline your solution?

@saberone @hobi-mc I use better-npm-run to run a prestart script:
package.json:
"scripts": {
  "prestart": "better-npm-run prestart",
},
"betterScripts": {
  "prestart": "node ./scripts/configure_proxy.js"
},

In configure_proxy.js I rewrite my package.json, dynamically setting the proxy:
const fs = require('fs');

fs.readFile('./package.json', 'utf8', function(err, data) {
  if (err) return console.log(`Error with configure script: ${err}`);

  // parse current package.json into an object
  let parsedData = JSON.parse(data);

  // get the proxy from the environment variable
  let proxy = process.env.REACT_APP_PROXY || 'https://mysite.com';

  parsedData.proxy = proxy;

  // for package.json formatting
  const spacing = 2;
  let dataString = JSON.stringify(parsedData, null, spacing);

  // overwrite the current package.json
  fs.writeFile('./package.json', dataString, err => {
    if (err) console.error(`Error writing file: ${err}`);
  });
});

I would love a cleaner solution / fix here

@john-matroid Thanks for sharing! I would also appreciate a clean solution for this topic since manipulating the package.json results in VCS changes not intended.

Hi @hobi-mc,
We had implemented a "cleaner" solution here if you want to give it a try before waiting for an official feature.
We use proxy feature from CRA to a fixed url in the package.json
"proxy": "http://localhost:4000",
At the same time we run a node express server on port 4000 which proxify (again...) a dynamic URL from env with http-proxy-middleware .
const app = express();
app.use(
    '/api',
    proxy({
      target: process.env.MOCKING_URL,
      changeOrigin: true,
      secure: false,
      ws: true,
      xfwd: true,
    })
  );

So we just have to set MOCKING_URL env and run this server before react-scripts
Far from perfect, but cleaner for us. Hope it can help.

@samuelmartineau Thanks! I agree, this approach is cleaner. I'll give it a try.

I am shocked and appalled that HTTPS_PROXY isn't honored by react-scripts :-1:


Use 38% of opacity on each disabled state

Is your feature request related to a problem? Please describe.

No
Describe the solution you'd like

This issue is there just to ensure that we have 38% of opacity on each disabled state.
Feel free if you have question.

It is already the case. A dimen (vtmn_states_disabled) is created in foundation module which is used in all components.