Firebase Connection Issue

[REQUIRED] Please fill in the following fields:

Unity editor version: 2020.1.0b5.3485
Firebase Unity SDK version: latest
Source you installed the SDK: Unity Package Manager
Problematic Firebase Component: Database
Platform you are using the Unity editor on: Windows
Platform you are targeting: Android

[REQUIRED] Please describe the issue here:
I'm new to Unity Firebase. I followed a tutorial on how to connect the Firebase to Unity and uploaded and imported all the necessary files (the json file and the database package). However I noticed that unlike in the tutorial, I don't have a "Firebase" option in the "Window" tab. I've been told that it doesn't matter so I just ignored it. I wrote a code to write to Unity and whenever I click start I have an error.
The code:
using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using Firebase.Extensions;
using UnityEngine.Events;
using Firebase.Database;
using Firebase;
using Firebase.Unity.Editor;

public class Firebasetest : MonoBehaviour
{
    private FirebaseDatabase _database;
    public UnityEvent OnFirebaseInitialized = new UnityEvent();

    void Start()
    {
        Debug.Log("testing fb");
        FirebaseApp.CheckAndFixDependenciesAsync().ContinueWithOnMainThread(continuation: task =>
        {
            if (task.Exception != null)
            {
                Debug.LogError(message: $"failed to fb with {task.Exception}");
                return;
            }
            Debug.Log("connected fb");
            OnFirebaseInitialized.Invoke();
        });

        _database = FirebaseDatabase.DefaultInstance;
        _database.GetReference("Connection").SetValueAsync("Conncected!");
    }
}

The error:
 Cannot close. Connection has been closed. UnityEngine.Debug:LogError(Object) Firebase.Platform.FirebaseLogger:LogMessage(PlatformLogLevel, String) (at Z:/tmp/tmp.tpC7OdQUHa/firebase/app/client/unity/src/Unity/FirebaseLogger.cs:95) Firebase.LogUtil:LogMessage(LogLevel, String) (at Z:/tmp/tmp.JYnsY9apCV/firebase/app/client/unity/proxy/LogUtil.cs:68) Firebase.LogUtil:LogMessageFromCallback(LogLevel, String) (at Z:/tmp/tmp.JYnsY9apCV/firebase/app/client/unity/proxy/LogUtil.cs:76) Firebase.AppUtilPINVOKE:PollCallbacks() Firebase.AppUtil:PollCallbacks() (at Z:/tmp/tmp.JYnsY9apCV/firebase/app/client/unity/proxy/AppUtil.cs:32) Firebase.Platform.FirebaseAppUtils:PollCallbacks() (at Z:/tmp/tmp.JYnsY9apCV/firebase/app/client/unity/proxy/FirebaseAppUtils.cs:33) Firebase.Platform.FirebaseHandler:Update() (at Z:/tmp/tmp.tpC7OdQUHa/firebase/app/client/unity/src/Unity/FirebaseHandler.cs:208) Firebase.Platform.FirebaseMonoBehaviour:Update() (at Z:/tmp/tmp.tpC7OdQUHa/firebase/app/client/unity/src/Unity/FirebaseMonoBehaviour.cs:45)
Steps to reproduce:
Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)?
What's the issue repro rate? (eg 100%, 1/5 etc)
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
If you have a downloadable sample project that reproduces the bug you're reporting, you will
likely receive a faster response on your issue.

Hi @TheBloop
Just to make sure by latest you mean 6.16.1, since a bug related to realtime database when play in editor was fixed in 6.16.1.
Also, try to reference to Database instance AFTER CheckAndFixDependenciesAsync() is finished, for instance, inside that continuation function.  See the following code.
        FirebaseApp.CheckAndFixDependenciesAsync().ContinueWithOnMainThread(continuation: task =>
        {
            if (task.Exception != null)
            {
                Debug.LogError(message: $"failed to fb with {task.Exception}");
                return;
            }
            Debug.Log("connected fb");

            _database = FirebaseDatabase.DefaultInstance;
            _database.GetReference("Connection").SetValueAsync("Conncected!");

            OnFirebaseInitialized.Invoke();
        });

This quickstart should give you a pretty good idea how to use Firebase API.
Let me know if this helps!
Shawn

Hi @TheBloop
Just to make sure by latest you mean 6.16.1, since a bug related to realtime database when play in editor was fixed in 6.16.1.
Also, try to reference to Database instance AFTER CheckAndFixDependenciesAsync() is finished, for instance, inside that continuation function. See the following code.
        FirebaseApp.CheckAndFixDependenciesAsync().ContinueWithOnMainThread(continuation: task =>
        {
            if (task.Exception != null)
            {
                Debug.LogError(message: $"failed to fb with {task.Exception}");
                return;
            }
            Debug.Log("connected fb");

            _database = FirebaseDatabase.DefaultInstance;
            _database.GetReference("Connection").SetValueAsync("Conncected!");

            OnFirebaseInitialized.Invoke();
        });

This quickstart should give you a pretty good idea how to use Firebase API.
Let me know if this helps!
Shawn

Hi, thank you for your response! I copied the code into mine, still has the same connection issue. However, you did bring up the SDK. I'm not sure how to check what version of SDK my unity is using and I tried looking it up online. I downloaded some files that the Unity site provided to keep the SDK up to date, but I'm not sure how these packages relate to SDK. How can I check what version my SDK is?

Hi @TheBloop , sorry for having let this sit stale for awhile.
First, to figure out which version of the Firebase SDK you have installed. You can look under Assets/Firebase/Editor for files that more or less look like *_version-<version number>_manifest. For example, in this screenshot, you can see that I have 7.0.0 of Auth and Database:

If that doesn't help, you can also look for a file called AppDependencies.xml in the same directory. In there you'll see the version in "Firebase/Core" or firebase-app-unity entries:
<!-- Copyright (C) 2018 Google Inc. All Rights Reserved.

FirebaseApp iOS and Android Dependencies.
-->

<dependencies>
  <iosPods>
    <iosPod name="Firebase/Core" version="7.0.0" minTargetSdk="9.0">
    </iosPod>
  </iosPods>
  <androidPackages>
    <androidPackage spec="com.google.firebase:firebase-common:19.3.1">
    </androidPackage>
    <androidPackage spec="com.google.firebase:firebase-analytics:18.0.0">
    </androidPackage>
    <androidPackage spec="com.google.android.gms:play-services-base:17.5.0">
    </androidPackage>
    <androidPackage spec="com.google.firebase:firebase-app-unity:7.0.0">
      <repositories>
        <repository>Assets/Firebase/m2repository</repository>
      </repositories>
    </androidPackage>
  </androidPackages>
</dependencies>

There are a few things we can try at this point.

The latest version is 7.0.1, which is newer than what you would have been running before. I would recommend trying to upgrade to this and seeing if the problem goes away. You will have to upgrade everything that's in your project (the Unity plugin won't work well with, say, Database at 7.0.1 and Auth at 6.16.1).

It does worry me that you don't have a "Firebase" option under Window. This might indicate that the SDK hasn't been properly imported or that you have some other build error (screenshot attached from MacOS):

Let me know if it comes back after importing a newer SDK.

I'm curious if you have some permissions issue (or you just don't have the Database setup). Make sure that you see something when you click on "Realtime Database" in the Firebase console:

And you can try making the rules (temporarily!) open just to verify:
{
  "rules": {
    ".read": true,
    ".write": true
  }
}

Sometimes you have to re-download your google-services.json file. Follow the instructions here, and make sure that you only have one in your project.

Download the Database quickstart app and configure it to hit your backend (add your google-services.json and make sure you update your package manifest). Let us know if the issue persists like this.

Identifying a project in Firebase is a combination of a SHA-1 and Package ID. If another project matches your SHA-1 and Package ID, you may run into connection issues. Verify that you don't have any other similar projects and try changing your package id/registering another Android app.

It may be a local Firewall setting. Try switching your network (ex: disabling wifi and using cell), and verify that you can reach *.firebaseio.com (or the IP address reported by https://<PROJECT_NAME>.firebaseio.com/.settings/owner.json - whitelisting the IP address is strongly discouraged as it may change without notice).

If none of these work, I think I'll have to see further logs to see if anything is up. And it would definitely help to let us know what the result of step 5 is (testing in the quickstart).
Thanks,
--Patrick


Control simulation using rain settings, adjust params based on feedback

[#173623088]
[#174011341]
Demo:
https://flood.concord.org/branch/update-sim/index.html
Document with description of various params and feedback from the project team:
https://docs.google.com/document/d/16dgy6lXlLpF2XvynTG805Whd1ngQJ214Jl7CPR5o4b0/edit
I ended up manually adjusting heightmap so more of the urban area gets flooded.

True, I haven't notice that, thanks. This lake is only part of the visual layer (topo / street map). It's not water according to our model. I'll ask the project team if anything should happen to it.


no way to install r package enabling multithread in os x?

I am using OS X.
I have brew install gcc --without-multilib. And I have successfully installed multithread c-version and python-version by changing Makefile as indicated in readme.
When it comes to R-package, problems arises.
Firstly, I have to tried to tell R to use g++-4.9 to compile it. I changed xgboost/R-packages/MakeVars by adding line CXX=g++-4.9 but R still used clang++. After a lot of tries, I found that I have to change ~/.R/src/Makevars then R knew to use g++-4.9.
Secondly, even I use g++4.9, I could not enable multithread yet!!
> devtools::install_local('xgboost/', subdir = 'R-package')
Installing xgboost
'/usr/local/Cellar/r/3.2.0/R.framework/Resources/bin/R'  \
  --no-site-file --no-environ --no-save --no-restore CMD INSTALL  \
  '/private/var/folders/31/l4r_sk095c5_1km_j1f2r9rm0000gn/T/RtmpJZpa7x/file3a5bde7faf1/xgboost/R-package'  \
  --library='/Users/fyears/R' --install-tests

* installing *source* package ‘xgboost’ ...
** libs
g++-4.9 -I/usr/local/Cellar/r/3.2.0/R.framework/Resources/include -DNDEBUG -DXGBOOST_CUSTOMIZE_MSG_ -DXGBOOST_CUSTOMIZE_PRNG_ -DXGBOOST_STRICT_CXX98_ -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I../../ -I/usr/local/opt/gettext/include -I/usr/local/opt/readline/include     -fPIC  -g -O2  -c xgboost_R.cpp -o xgboost_R.o
In file included from xgboost_R.cpp:9:0:
../../src/utils/omp.h:13:165: note: #pragma message: Warning: OpenMP is not available, xgboost will be compiled into single-thread code. Use OpenMP-enabled compiler to get benefit of multi-threading
 #pragma message ("Warning: OpenMP is not available, xgboost will be compiled into single-thread code. Use OpenMP-enabled compiler to get benefit of multi-threading")
                                                                                ^
gcc-4.9 -I/usr/local/Cellar/r/3.2.0/R.framework/Resources/include -DNDEBUG -DXGBOOST_CUSTOMIZE_MSG_ -DXGBOOST_CUSTOMIZE_PRNG_ -DXGBOOST_STRICT_CXX98_ -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I../../ -I/usr/local/opt/gettext/include -I/usr/local/opt/readline/include    -fPIC  -g -O2  -c xgboost_assert.c -o xgboost_assert.o
g++-4.9 -I/usr/local/Cellar/r/3.2.0/R.framework/Resources/include -DNDEBUG -DXGBOOST_CUSTOMIZE_MSG_ -DXGBOOST_CUSTOMIZE_PRNG_ -DXGBOOST_STRICT_CXX98_ -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I../../ -I/usr/local/opt/gettext/include -I/usr/local/opt/readline/include     -fPIC  -g -O2  -c ../..//wrapper/xgboost_wrapper.cpp -o ../..//wrapper/xgboost_wrapper.o
In file included from ../..//wrapper/../src/learner/./objective-inl.hpp:17:0,
                 from ../..//wrapper/../src/learner/./objective.h:64,
                 from ../..//wrapper/../src/learner/learner-inl.hpp:15,
                 from ../..//wrapper/xgboost_wrapper.cpp:19:
../..//wrapper/../src/learner/./../utils/omp.h:13:165: note: #pragma message: Warning: OpenMP is not available, xgboost will be compiled into single-thread code. Use OpenMP-enabled compiler to get benefit of multi-threading
 #pragma message ("Warning: OpenMP is not available, xgboost will be compiled into single-thread code. Use OpenMP-enabled compiler to get benefit of multi-threading")
                                                                                ^
g++-4.9 -I/usr/local/Cellar/r/3.2.0/R.framework/Resources/include -DNDEBUG -DXGBOOST_CUSTOMIZE_MSG_ -DXGBOOST_CUSTOMIZE_PRNG_ -DXGBOOST_STRICT_CXX98_ -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I../../ -I/usr/local/opt/gettext/include -I/usr/local/opt/readline/include     -fPIC  -g -O2  -c ../..//src/io/io.cpp -o ../..//src/io/io.o
In file included from ../..//src/io/./simple_fmatrix-inl.hpp:11:0,
                 from ../..//src/io/simple_dmatrix-inl.hpp:20,
                 from ../..//src/io/io.cpp:8:
../..//src/io/./../utils/omp.h:13:165: note: #pragma message: Warning: OpenMP is not available, xgboost will be compiled into single-thread code. Use OpenMP-enabled compiler to get benefit of multi-threading
 #pragma message ("Warning: OpenMP is not available, xgboost will be compiled into single-thread code. Use OpenMP-enabled compiler to get benefit of multi-threading")
                                                                                ^
g++-4.9 -I/usr/local/Cellar/r/3.2.0/R.framework/Resources/include -DNDEBUG -DXGBOOST_CUSTOMIZE_MSG_ -DXGBOOST_CUSTOMIZE_PRNG_ -DXGBOOST_STRICT_CXX98_ -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I../../ -I/usr/local/opt/gettext/include -I/usr/local/opt/readline/include     -fPIC  -g -O2  -c ../..//src/gbm/gbm.cpp -o ../..//src/gbm/gbm.o
In file included from ../..//src/gbm/./gbtree-inl.hpp:12:0,
                 from ../..//src/gbm/gbm.cpp:6:
../..//src/gbm/./../utils/omp.h:13:165: note: #pragma message: Warning: OpenMP is not available, xgboost will be compiled into single-thread code. Use OpenMP-enabled compiler to get benefit of multi-threading
 #pragma message ("Warning: OpenMP is not available, xgboost will be compiled into single-thread code. Use OpenMP-enabled compiler to get benefit of multi-threading")
                                                                                ^
g++-4.9 -I/usr/local/Cellar/r/3.2.0/R.framework/Resources/include -DNDEBUG -DXGBOOST_CUSTOMIZE_MSG_ -DXGBOOST_CUSTOMIZE_PRNG_ -DXGBOOST_STRICT_CXX98_ -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I../../ -I/usr/local/opt/gettext/include -I/usr/local/opt/readline/include     -fPIC  -g -O2  -c ../..//src/tree/updater.cpp -o ../..//src/tree/updater.o
In file included from ../..//src/tree/./updater_refresh-inl.hpp:13:0,
                 from ../..//src/tree/updater.cpp:7:
../..//src/tree/./../utils/omp.h:13:165: note: #pragma message: Warning: OpenMP is not available, xgboost will be compiled into single-thread code. Use OpenMP-enabled compiler to get benefit of multi-threading
 #pragma message ("Warning: OpenMP is not available, xgboost will be compiled into single-thread code. Use OpenMP-enabled compiler to get benefit of multi-threading")
                                                                                ^
g++-4.9 -I/usr/local/Cellar/r/3.2.0/R.framework/Resources/include -DNDEBUG -DXGBOOST_CUSTOMIZE_MSG_ -DXGBOOST_CUSTOMIZE_PRNG_ -DXGBOOST_STRICT_CXX98_ -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I../../ -I/usr/local/opt/gettext/include -I/usr/local/opt/readline/include     -fPIC  -g -O2  -c ../..//subtree/rabit/src/engine_empty.cc -o ../..//subtree/rabit/src/engine_empty.o
g++-4.9 -I/usr/local/Cellar/r/3.2.0/R.framework/Resources/include -DNDEBUG -DXGBOOST_CUSTOMIZE_MSG_ -DXGBOOST_CUSTOMIZE_PRNG_ -DXGBOOST_STRICT_CXX98_ -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I../../ -I/usr/local/opt/gettext/include -I/usr/local/opt/readline/include     -fPIC  -g -O2  -c ../..//src/io/dmlc_simple.cpp -o ../..//src/io/dmlc_simple.o
g++-4.9 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/usr/local/Cellar/r/3.2.0/R.framework/Resources/lib -L/usr/local/opt/gettext/lib -L/usr/local/opt/readline/lib -o xgboost.so xgboost_R.o xgboost_assert.o ../..//wrapper/xgboost_wrapper.o ../..//src/io/io.o ../..//src/gbm/gbm.o ../..//src/tree/updater.o ../..//subtree/rabit/src/engine_empty.o ../..//src/io/dmlc_simple.o -F/usr/local/Cellar/r/3.2.0/R.framework/.. -framework R -lintl -Wl,-framework -Wl,CoreFoundation
installing to /Users/fyears/R/xgboost/libs
** R
** data
** demo
** preparing package for lazy loading
Creating a generic function from function ‘getinfo’ in package ‘xgboost’
Creating a generic function for ‘predict’ from package ‘stats’ in package ‘xgboost’
Creating a generic function from function ‘setinfo’ in package ‘xgboost’
Creating a generic function from function ‘slice’ in package ‘xgboost’
** help
*** installing help indices
** building package indices
** installing vignettes
** testing if installed package can be loaded
* DONE (xgboost)

Here is my solution to install r package:
There is a project that adds openmp support to clang.
brew install gcc --without-multilib # for c++ and python version
brew install clang-omp # for r version

Then, to tell R to use the clang-omp++ and set the flag, I have to modify the ~/.R/Makvars, and I do not know why it ignores xgboost/R-package/src/Makevars:
CC=clang-omp
CXX=clang-omp++
SHLIB_OPENMP_CFLAGS = -fopenmp
SHLIB_OPENMP_CXXFLAGS = -fopenmp
SHLIB_OPENMP_FCFLAGS = -fopenmp
SHLIB_OPENMP_FFLAGS = -fopenmp

Also, I have to change line 9 in xgboost/src/utils/omp.h to:
#include <libiomp/omp.h> /* instead of #include <omp.h> */

Here is the log while installing r package:
> install_local('xgboost/', subdir = 'R-package')
Installing xgboost
'/usr/local/Cellar/r/3.2.0/R.framework/Resources/bin/R'  \
  --no-site-file --no-environ --no-save --no-restore CMD INSTALL  \
  '/private/var/folders/31/l4r_sk095c5_1km_j1f2r9rm0000gn/T/RtmpJZpa7x/file3a5b3498409a/xgboost/R-package'  \
  --library='/Users/fyears/R' --install-tests

* installing *source* package ‘xgboost’ ...
** libs
clang-omp++ -I/usr/local/Cellar/r/3.2.0/R.framework/Resources/include -DNDEBUG -DXGBOOST_CUSTOMIZE_MSG_ -DXGBOOST_CUSTOMIZE_PRNG_ -DXGBOOST_STRICT_CXX98_ -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I../../ -I/usr/local/opt/gettext/include -I/usr/local/opt/readline/include   -fopenmp  -fPIC  -g -O2  -c xgboost_R.cpp -o xgboost_R.o
clang-omp -I/usr/local/Cellar/r/3.2.0/R.framework/Resources/include -DNDEBUG -DXGBOOST_CUSTOMIZE_MSG_ -DXGBOOST_CUSTOMIZE_PRNG_ -DXGBOOST_STRICT_CXX98_ -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I../../ -I/usr/local/opt/gettext/include -I/usr/local/opt/readline/include    -fPIC  -g -O2  -c xgboost_assert.c -o xgboost_assert.o
clang-omp++ -I/usr/local/Cellar/r/3.2.0/R.framework/Resources/include -DNDEBUG -DXGBOOST_CUSTOMIZE_MSG_ -DXGBOOST_CUSTOMIZE_PRNG_ -DXGBOOST_STRICT_CXX98_ -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I../../ -I/usr/local/opt/gettext/include -I/usr/local/opt/readline/include   -fopenmp  -fPIC  -g -O2  -c ../..//wrapper/xgboost_wrapper.cpp -o ../..//wrapper/xgboost_wrapper.o
In file included from ../..//wrapper/xgboost_wrapper.cpp:23:
In file included from ../..//wrapper/../src/io/simple_dmatrix-inl.hpp:22:
In file included from ../..//wrapper/../src/io/./libsvm_parser.h:18:
../..//wrapper/../src/io/./sparse_batch_page.h:139:3: warning: control may reach end of non-void function [-Wreturn-type]
  }
  ^
1 warning generated.
clang-omp++ -I/usr/local/Cellar/r/3.2.0/R.framework/Resources/include -DNDEBUG -DXGBOOST_CUSTOMIZE_MSG_ -DXGBOOST_CUSTOMIZE_PRNG_ -DXGBOOST_STRICT_CXX98_ -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I../../ -I/usr/local/opt/gettext/include -I/usr/local/opt/readline/include   -fopenmp  -fPIC  -g -O2  -c ../..//src/io/io.cpp -o ../..//src/io/io.o
In file included from ../..//src/io/io.cpp:8:
In file included from ../..//src/io/simple_dmatrix-inl.hpp:22:
In file included from ../..//src/io/./libsvm_parser.h:18:
../..//src/io/./sparse_batch_page.h:139:3: warning: control may reach end of non-void function [-Wreturn-type]
  }
  ^
1 warning generated.
clang-omp++ -I/usr/local/Cellar/r/3.2.0/R.framework/Resources/include -DNDEBUG -DXGBOOST_CUSTOMIZE_MSG_ -DXGBOOST_CUSTOMIZE_PRNG_ -DXGBOOST_STRICT_CXX98_ -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I../../ -I/usr/local/opt/gettext/include -I/usr/local/opt/readline/include   -fopenmp  -fPIC  -g -O2  -c ../..//src/gbm/gbm.cpp -o ../..//src/gbm/gbm.o
clang-omp++ -I/usr/local/Cellar/r/3.2.0/R.framework/Resources/include -DNDEBUG -DXGBOOST_CUSTOMIZE_MSG_ -DXGBOOST_CUSTOMIZE_PRNG_ -DXGBOOST_STRICT_CXX98_ -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I../../ -I/usr/local/opt/gettext/include -I/usr/local/opt/readline/include   -fopenmp  -fPIC  -g -O2  -c ../..//src/tree/updater.cpp -o ../..//src/tree/updater.o
clang-omp++ -I/usr/local/Cellar/r/3.2.0/R.framework/Resources/include -DNDEBUG -DXGBOOST_CUSTOMIZE_MSG_ -DXGBOOST_CUSTOMIZE_PRNG_ -DXGBOOST_STRICT_CXX98_ -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I../../ -I/usr/local/opt/gettext/include -I/usr/local/opt/readline/include   -fopenmp  -fPIC  -g -O2  -c ../..//subtree/rabit/src/engine_empty.cc -o ../..//subtree/rabit/src/engine_empty.o
clang-omp++ -I/usr/local/Cellar/r/3.2.0/R.framework/Resources/include -DNDEBUG -DXGBOOST_CUSTOMIZE_MSG_ -DXGBOOST_CUSTOMIZE_PRNG_ -DXGBOOST_STRICT_CXX98_ -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I../../ -I/usr/local/opt/gettext/include -I/usr/local/opt/readline/include   -fopenmp  -fPIC  -g -O2  -c ../..//src/io/dmlc_simple.cpp -o ../..//src/io/dmlc_simple.o
clang-omp++ -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/usr/local/Cellar/r/3.2.0/R.framework/Resources/lib -L/usr/local/opt/gettext/lib -L/usr/local/opt/readline/lib -o xgboost.so xgboost_R.o xgboost_assert.o ../..//wrapper/xgboost_wrapper.o ../..//src/io/io.o ../..//src/gbm/gbm.o ../..//src/tree/updater.o ../..//subtree/rabit/src/engine_empty.o ../..//src/io/dmlc_simple.o -fopenmp -F/usr/local/Cellar/r/3.2.0/R.framework/.. -framework R -lintl -Wl,-framework -Wl,CoreFoundation
installing to /Users/fyears/R/xgboost/libs
** R
** data
** demo
** preparing package for lazy loading
Creating a generic function from function ‘getinfo’ in package ‘xgboost’
Creating a generic function for ‘predict’ from package ‘stats’ in package ‘xgboost’
Creating a generic function from function ‘setinfo’ in package ‘xgboost’
Creating a generic function from function ‘slice’ in package ‘xgboost’
** help
*** installing help indices
** building package indices
** installing vignettes
** testing if installed package can be loaded
* DONE (xgboost)
>

Thanks! I think this is valuable for OSX users. I have created an build instruction doc at https://github.com/dmlc/xgboost/blob/master/doc/build.md
It would be great if you can try to summarize your solution and add instructions here

@tqchen Anyway to check that  xgboost is really using multithread? Any functions like is_using_multithread()? Because you know, maybe xgboost is just ignoring nthread parameter if openmp is not working correctly.
Here is the complete solution. And I suggest you developers pay attention to step 2 and 4 to make some modifications to original files to simplify the steps.

Obtain gcc with openmp support by brew install gcc --without-multilib or clang with openmp by brew install clang-omp. The clang one is recommended because the first method requires us compiling gcc inside the machine (more than an hour in mine)! (BTW, brew is the de facto standard of apt-get on OS X, in case you do not know. So installing HPC separately is not recommended.)

I am not familiar with C/C++, but on my machine, if plaing to use clang-omp in step 3 and/or 4, I have to change line 9 in xgboost/src/utils/omp.h to
#include <libiomp/omp.h> /* instead of #include <omp.h> */`

to make it work, otherwise the following steps would show src/tree/../utils/omp.h:9:10: error: 'omp.h' file not found...
Here are what are inside my machine:
/usr/local/lib/libiomp -> ../Cellar/libiomp/20150227/include/libiomp
/usr/local/include/libiomp -> ../Cellar/libiomp/20150227/include/libiomp
/usr/local/Cellar/libiomp/20150227/include/libiomp/omp.h
/usr/local/Cellar/libiomp/20150227/include/libiomp/omp_lib.f
/usr/local/Cellar/libiomp/20150227/include/libiomp/omp_lib.f90
/usr/local/Cellar/libiomp/20150227/include/libiomp/omp_lib.h

Please check the usage and usage with xcode session in the description of clang-omp. Maybe you could change some settings in Makefile to adapt this things. Again, I am not familar with the C++ system but at least I could make it work by changing the header line when using clang-omp.

Set the Makefile correctly for compiling cpp version xgboost then python version xgboost.
export CC  = gcc-4.9
export CXX = g++-4.9

Or
export CC = clang-omp
export CXX = clang-omp++

Remember to change header if using clang-omp.

Set the Makevars file in highest piority.
The point is, there are three Makevars inside my machine: ~/.R/Makevars, xgboost/R-package/src/Makevars, and /usr/local/Cellar/r/3.2.0/R.framework/Resources/etc/Makeconf, and SHLIB_OPENMP_CXXFLAGS is not set by default!! After trying, it seems that the first one has highest piority (surprising!)
So, add or change ~/.R/Makevars to the following lines:
CC=gcc-4.9
CXX=g++-4.9
SHLIB_OPENMP_CFLAGS = -fopenmp
SHLIB_OPENMP_CXXFLAGS = -fopenmp
SHLIB_OPENMP_FCFLAGS = -fopenmp
SHLIB_OPENMP_FFLAGS = -fopenmp

Or
CC=clang-omp
CXX=clang-omp++
SHLIB_OPENMP_CFLAGS = -fopenmp
SHLIB_OPENMP_CXXFLAGS = -fopenmp
SHLIB_OPENMP_FCFLAGS = -fopenmp
SHLIB_OPENMP_FFLAGS = -fopenmp

Again, remember to change header if using clang-omp.
Then inside R, run
install.packages('xgboost/R-package/', repos=NULL, type='source')
#devtools::install_local('xgboost/', subdir = 'R-package') # you may use devtools

gcc shows no warnings but clang-omp shows with two warnings.

Thanks for the guide! Can you post the warning you get for clang-omp?

@tqchen
Huh, interesting... The second response in this issue showed the log in R yesterday. But today, after I git clone the latest code, I saw the different log now.
R package with clang-omp do not have warnings now!
BTW, c-version has warnings.
$ git clone https://github.com/dmlc/xgboost.git
$ vim xgboost/Makefile  # change to use clang-omp
$ vim xgboost/src/utils/omp.h # change header
$ vim  ~/.R/Makevars # add vars for R
$
$ cd xgboost
$ bash build.sh
clang-omp++ -c -Wall -O3 -msse2  -Wno-unknown-pragmas -fPIC -fopenmp -o updater.o src/tree/updater.cpp
clang-omp++ -c -Wall -O3 -msse2  -Wno-unknown-pragmas -fPIC -fopenmp -o gbm.o src/gbm/gbm.cpp
clang-omp++ -c -Wall -O3 -msse2  -Wno-unknown-pragmas -fPIC -fopenmp -o io.o src/io/io.cpp
clang-omp++ -c -Wall -O3 -msse2  -Wno-unknown-pragmas -fPIC -fopenmp -o main.o src/xgboost_main.cpp
cd subtree/rabit;make lib/librabit.a; cd ../..
clang-omp++ -c -O3 -msse2 -fPIC -Wall -Wextra -Wno-unused-parameter -Wno-unknown-pragmas -pedantic   -o allreduce_base.o src/allreduce_base.cc
src/allreduce_base.cc:138:32: warning: format specifies type 'unsigned long *'
      but the argument has type 'uint64_t *' (aka 'unsigned long long *')
      [-Wformat]
  int n = sscanf(val, "%lu%c", &amount, &unit);
                       ~~~     ^~~~~~~
                       %llu
1 warning generated.
clang-omp++ -c -O3 -msse2 -fPIC -Wall -Wextra -Wno-unused-parameter -Wno-unknown-pragmas -pedantic   -o allreduce_robust.o src/allreduce_robust.cc
clang-omp++ -c -O3 -msse2 -fPIC -Wall -Wextra -Wno-unused-parameter -Wno-unknown-pragmas -pedantic   -o engine.o src/engine.cc
ar cr lib/librabit.a allreduce_base.o allreduce_robust.o engine.o
clang-omp++ -c -Wall -O3 -msse2  -Wno-unknown-pragmas -fPIC -fopenmp -o dmlc_simple.o src/io/dmlc_simple.cpp
clang-omp++ -Wall -O3 -msse2  -Wno-unknown-pragmas -fPIC -fopenmp -o xgboost updater.o gbm.o io.o main.o subtree/rabit/lib/librabit.a dmlc_simple.o -pthread -lm
clang: warning: argument unused during compilation: '-pthread'
clang-omp++ -Wall -O3 -msse2  -Wno-unknown-pragmas -fPIC -fopenmp -fPIC -shared -o wrapper/libxgboostwrapper.so wrapper/xgboost_wrapper.cpp updater.o gbm.o io.o subtree/rabit/lib/librabit.a dmlc_simple.o -pthread -lm
Successfully build multi-thread xgboost
$

ok, that was a thing that I fixed, I will try fix this one as well.

Thanks this is helpful!

Now homebrew install gcc as gcc-5, so makefile has to be changed accordingly to compile xgboost using gcc-5

just to add two cents how I got multithreading to work on OSX and R with macports and gcc-5 (4.9 worked similarly). Similar to what you suggest in https://github.com/dmlc/xgboost/blob/master/doc/build.md#build-xgboost-in-os-x-with-openmp ), with the following:

edit ~/.R/Makevars to add:

CXX=/opt/local/bin/g++-mp-5
CC=/opt/local/bin/gcc-mp-5

CXXFLAGS += -fopenmp
CCFLAGS += -fopenmp

after checking out the xgboost source, add

-lgomp

to the line starting with
PKG_LIBS = ...

in xgboost/R-package/src/Makevars
(this solves the problem Symbol not found: _GOMP_atomic_end I initially had)

build the module using devtools::install_local('xgboost/', subdir = 'R-package') as described in build.md

@andreh7 thx for sharing! Can't figure out what is wrong with Symbol not found: _GOMP_atomic_end, but -lgomp resolves this.

I have a ~/.R/Makevars file
CC=clang-omp
CXX=clang-omp++
SHLIB_OPENMP_CFLAGS=-fopenmp
SHLIB_OPENMP_CXXFLAGS=-fopenmp
SHLIB_OPENMP_FCFLAGS=-fopenmp
SHLIB_OPENMP_FFLAGS=-fopenmp

so I don't understand why open-omp++ is not picked up by R.

@szalmaf try to add CXX1X=clang-omp++ to your ~/.R/Makevars. This will set clang-omp++ compiler for C++11 projects.

Okay, now I am getting this error message:
> devtools::install_local('xgboost/', subdir = 'R-package')
Installing xgboost
'/Library/Frameworks/R.framework/Resources/bin/R' --no-site-file --no-environ --no-save --no-restore  \
  CMD INSTALL  \
  '/private/var/folders/_4/2p2t0cfd33x9dl3cmvcf7b8h0000gn/T/RtmppdNQrm/file186697bd86e/xgboost/R-package'  \
  --library='/Library/Frameworks/R.framework/Versions/3.1/Resources/library' --install-tests

* installing *source* package ‘xgboost’ ...
** libs
clang-omp++ -std=c++11 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/Library/Frameworks/R.framework/Resources/lib -L/usr/local/lib -o xgboost.so ./xgboost_R.o ./xgboost_custom.o ./xgboost_assert.o ../..//amalgamation/xgboost-all0.o ../..//amalgamation/dmlc-minimum0.o ../..//rabit/src/engine_empty.o -fopenmp -lgomp -F/Library/Frameworks/R.framework/.. -framework R -Wl,-framework -Wl,CoreFoundation
ld: library not found for -lgomp
clang-3.5: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [xgboost.so] Error 1
ERROR: compilation failed for package ‘xgboost’
* removing ‘/Library/Frameworks/R.framework/Versions/3.1/Resources/library/xgboost’
Error: Command failed (1)

xgboost/src/utils/omp.h should be xgboost/dmlc-core/include/dmlc/omp.h

Having trouble building xgboost R-package on OSX El Capitan with clang-omp and clang-omp++. Having spent more than a day on this I feel I would definitely benefit from the collective wisdom present here. I followed the directions on xgboost docs and on this thread.
My system: OSX El capitan, with  Revolution R open -3.2.3
Here are my steps:

Downloaded xgboost
brew Install clang-omp
Created and added to ~/.R/Makevars

CC=clang-omp
CXX=clang-omp++
CXX1X=clang-omp++
SHLIB_OPENMP_CFLAGS=-fopenmp
SHLIB_OPENMP_CXXFLAGS=-fopenmp
SHLIB_OPENMP_FCFLAGS=-fopenmp
SHLIB_OPENMP_FFLAGS=-fopenmp

Installed required other missing packages using brew. Specifically cairo and readline.

In R devtools::install_local('~/temp/xgboost/', subdir = 'R-package')

That results in:
devtools::install_local('~/temp/xgboost/', subdir = 'R-package')
Installing xgboost
'/Library/Frameworks/R.framework/Resources/bin/R' --no-site-file --no-environ --no-save --no-restore CMD INSTALL  \
  '/private/var/folders/qy/9q7sjl5s7mz3bv__1dltwh000000gn/T/RtmpoyAklz/file13bf9114e5/xgboost/R-package'  \
  --library='/Library/Frameworks/R.framework/Versions/3.2/Resources/library' --install-tests

* installing *source* package ‘xgboost’ ...
** libs
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c xgboost_R.cc -o xgboost_R.o
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c xgboost_custom.cc -o xgboost_custom.o
clang-omp -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'    -fPIC  -Wall -mtune=core2 -g -O2  -c xgboost_assert.c -o xgboost_assert.o
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c ../..//amalgamation/xgboost-all0.cc -o ../..//amalgamation/xgboost-all0.o
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c ../..//amalgamation/dmlc-minimum0.cc -o ../..//amalgamation/dmlc-minimum0.o
In file included from ../..//amalgamation/dmlc-minimum0.cc:8:
../..//amalgamation/../dmlc-core/src/io/input_split_base.cc:26:22: warning: assigning field to itself [-Wself-assign-field]
  this->align_bytes_ = align_bytes_;
                     ^
1 warning generated.
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c ../..//rabit/src/engine_empty.cc -o ../..//rabit/src/engine_empty.o
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c ../..//rabit/src/c_api.cc -o ../..//rabit/src/c_api.o
clang-omp++ -std=c++11 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/Library/Frameworks/R.framework/Resources/lib -L/opt/X11/lib -L/usr/local/lib /usr/local/lib/libcairo.a /usr/local/lib/libpixman-1.a /usr/local/lib/libfreetype.a /usr/local/lib/libfontconfig.a -lxml2 /usr/local/lib/libreadline.a -o xgboost.so ./xgboost_R.o ./xgboost_custom.o ./xgboost_assert.o ../..//amalgamation/xgboost-all0.o ../..//amalgamation/dmlc-minimum0.o ../..//rabit/src/engine_empty.o ../..//rabit/src/c_api.o -fopenmp -F/Library/Frameworks/R.framework/.. -framework R -Wl,-framework -Wl,CoreFoundation
clang-3.5: error: no such file or directory: '/usr/local/lib/libreadline.a'
make: *** [xgboost.so] Error 1
ERROR: compilation failed for package ‘xgboost’
* removing ‘/Library/Frameworks/R.framework/Versions/3.2/Resources/library/xgboost’
Error: Command failed (1)
> devtools::install_local('~/temp/xgboost/', subdir = 'R-package')
Installing xgboost
'/Library/Frameworks/R.framework/Resources/bin/R' --no-site-file --no-environ --no-save --no-restore CMD INSTALL  \
  '/private/var/folders/qy/9q7sjl5s7mz3bv__1dltwh000000gn/T/RtmpoyAklz/file13bf2ed1a303/xgboost/R-package'  \
  --library='/Library/Frameworks/R.framework/Versions/3.2/Resources/library' --install-tests

* installing *source* package ‘xgboost’ ...
** libs
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c xgboost_R.cc -o xgboost_R.o
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c xgboost_custom.cc -o xgboost_custom.o
clang-omp -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'    -fPIC  -Wall -mtune=core2 -g -O2  -c xgboost_assert.c -o xgboost_assert.o
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c ../..//amalgamation/xgboost-all0.cc -o ../..//amalgamation/xgboost-all0.o
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c ../..//amalgamation/dmlc-minimum0.cc -o ../..//amalgamation/dmlc-minimum0.o
In file included from ../..//amalgamation/dmlc-minimum0.cc:8:
../..//amalgamation/../dmlc-core/src/io/input_split_base.cc:26:22: warning: assigning field to itself [-Wself-assign-field]
  this->align_bytes_ = align_bytes_;
                     ^
1 warning generated.
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c ../..//rabit/src/engine_empty.cc -o ../..//rabit/src/engine_empty.o
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c ../..//rabit/src/c_api.cc -o ../..//rabit/src/c_api.o
clang-omp++ -std=c++11 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/Library/Frameworks/R.framework/Resources/lib -L/opt/X11/lib -L/usr/local/lib /usr/local/lib/libcairo.a /usr/local/lib/libpixman-1.a /usr/local/lib/libfreetype.a /usr/local/lib/libfontconfig.a -lxml2 /usr/local/lib/libreadline.a -o xgboost.so ./xgboost_R.o ./xgboost_custom.o ./xgboost_assert.o ../..//amalgamation/xgboost-all0.o ../..//amalgamation/dmlc-minimum0.o ../..//rabit/src/engine_empty.o ../..//rabit/src/c_api.o -fopenmp -F/Library/Frameworks/R.framework/.. -framework R -Wl,-framework -Wl,CoreFoundation
clang-3.5: error: no such file or directory: '/usr/local/lib/libreadline.a'
make: *** [xgboost.so] Error 1
ERROR: compilation failed for package ‘xgboost’
* removing ‘/Library/Frameworks/R.framework/Versions/3.2/Resources/library/xgboost’
Error: Command failed (1)
> devtools::install_local('~/temp/xgboost/', subdir = 'R-package')
Installing xgboost
'/Library/Frameworks/R.framework/Resources/bin/R' --no-site-file --no-environ --no-save --no-restore CMD INSTALL  \
  '/private/var/folders/qy/9q7sjl5s7mz3bv__1dltwh000000gn/T/RtmpoyAklz/file13bfcf3b43f/xgboost/R-package'  \
  --library='/Library/Frameworks/R.framework/Versions/3.2/Resources/library' --install-tests

* installing *source* package ‘xgboost’ ...
** libs
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c xgboost_R.cc -o xgboost_R.o
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c xgboost_custom.cc -o xgboost_custom.o
clang-omp -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'    -fPIC  -Wall -mtune=core2 -g -O2  -c xgboost_assert.c -o xgboost_assert.o
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c ../..//amalgamation/xgboost-all0.cc -o ../..//amalgamation/xgboost-all0.o
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c ../..//amalgamation/dmlc-minimum0.cc -o ../..//amalgamation/dmlc-minimum0.o
In file included from ../..//amalgamation/dmlc-minimum0.cc:8:
../..//amalgamation/../dmlc-core/src/io/input_split_base.cc:26:22: warning: assigning field to itself [-Wself-assign-field]
  this->align_bytes_ = align_bytes_;
                     ^
1 warning generated.
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c ../..//rabit/src/engine_empty.cc -o ../..//rabit/src/engine_empty.o
clang-omp++ -std=c++11 -I/Library/Frameworks/R.framework/Resources/include -DNDEBUG -I../..//include -I../..//dmlc-core/include -I../..//rabit/include -I../../ -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0 -DDMLC_ENABLE_STD_THREAD=1 -DDMLC_DISABLE_STDIN=1 -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 -DRABIT_CUSTOMIZE_MSG_ -DRABIT_STRICT_CXX98_ -I/usr/local/include -I/usr/local/include/freetype2 -I/opt/X11/include -DPLATFORM_PKGTYPE='"mac.binary.mavericks"'   -fopenmp  -fPIC  -Wall -mtune=core2 -g -O2 -c ../..//rabit/src/c_api.cc -o ../..//rabit/src/c_api.o
clang-omp++ -std=c++11 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/Library/Frameworks/R.framework/Resources/lib -L/opt/X11/lib -L/usr/local/lib /usr/local/lib/libcairo.a /usr/local/lib/libpixman-1.a /usr/local/lib/libfreetype.a /usr/local/lib/libfontconfig.a -lxml2 /usr/local/lib/libreadline.a -o xgboost.so ./xgboost_R.o ./xgboost_custom.o ./xgboost_assert.o ../..//amalgamation/xgboost-all0.o ../..//amalgamation/dmlc-minimum0.o ../..//rabit/src/engine_empty.o ../..//rabit/src/c_api.o -fopenmp -F/Library/Frameworks/R.framework/.. -framework R -Wl,-framework -Wl,CoreFoundation
ld: warning: directory not found for option '-L/opt/X11/lib'
installing to /Library/Frameworks/R.framework/Versions/3.2/Resources/library/xgboost/libs
** R
** data
** demo
** tests
** preparing package for lazy loading
Creating a generic function from function ‘getinfo’ in package ‘xgboost’
Creating a generic function for ‘predict’ from package ‘stats’ in package ‘xgboost’
Creating a generic function from function ‘setinfo’ in package ‘xgboost’
Creating a generic function from function ‘slice’ in package ‘xgboost’
** help
*** installing help indices
** building package indices
** installing vignettes
** testing if installed package can be loaded
Error : .onLoad failed in loadNamespace() for 'xgboost', details:
  call: dyn.load(file, DLLpath = DLLpath, ...)
  error: unable to load shared object '/Library/Frameworks/R.framework/Versions/3.2/Resources/library/xgboost/libs/xgboost.so':
  dlopen(/Library/Frameworks/R.framework/Versions/3.2/Resources/library/xgboost/libs/xgboost.so, 6): Symbol not found: __ZN7xgboost4data10SparsePage6Writer5AllocEPNSt3__110unique_ptrIS1_NS3_14default_deleteIS1_EEEE
  Referenced from: /Library/Frameworks/R.framework/Versions/3.2/Resources/library/xgboost/libs/xgboost.so
  Expected in: flat namespace
 in /Library/Frameworks/R.framework/Versions/3.2/Resources/library/xgboost/libs/xgboost.so
Error: loading failed
Execution halted
ERROR: loading failed
* removing ‘/Library/Frameworks/R.framework/Versions/3.2/Resources/library/xgboost’
Error: Command failed (1)

Any ideas what might be the problem?

seems due to the fact the final linking procedure was not done correctly, not very sure what is the cause

@tqchen Thanks for taking a look. I guess it would take some digging to find out which I probably won't do right now since I already spent a day on it. I was wondering if multi-threading would work if I just downloaded the binaries from CRAN?


feat: add dockerfile inputs

This adds the ability to change the Dockerfile path and/or name.

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


App crashing on login

Hi Sergey,
I’m running with difficulties when opening Traccar manager+
Since a few months, when I hit login button on the Access screen. Apps displays for an instant the gps location and then app crashes.
Hope you could help me,
Regards.
A. Efren H.

Hi, what is your version of Traccar Server?

Hi Sergey
Thank you so much for taking your time to answer me.
I’m using a demo 2 (Canadá) version for now, and iOS 13.6 on an iPhone XR.
I’ve read that reinstalling both apps (yours and oficial manager) worked for others, but not for me.
One more time, thank you for your mail, means more to me than the actual fix.
Regards.
Enviado desde mi iPhone
El 5 ago 2020, a la(s) 6:49 a.m., Sergey Kruzhkov<EMAIL_ADDRESS>escribió:

Hi, what is your version of Traccar Server?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/kruzhkov/traccar-manager-ios/issues/13#issuecomment-669147963, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQKRLP6SE4M2PFSKRD7DXTTR7FBNNANCNFSM4PAZ37UQ.

Hi Efren.
Write your email address. I will send a link for the beta version

Hi Sergey
Yes<EMAIL_ADDRESS>Thank you,
Regards.
Enviado desde mi iPhone
El 18 ago 2020, a la(s) 1:59 p.m., Sergey Kruzhkov<EMAIL_ADDRESS>escribió:

Hi Efren.
Write your email address. I will send a link for the beta version
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/kruzhkov/traccar-manager-ios/issues/13#issuecomment-675656030, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQKRLPZDXPLFEDYDM52FYDLSBLFPHANCNFSM4PAZ37UQ.

I will be grateful for error reports. And proposals for the development of the application.

Thank you Sergey, it would be an honor to me. Yo can count on me to report anything I see.
Regards from Mexico
Enviado desde mi iPhone
El 18 ago 2020, a la(s) 2:21 p.m., Sergey Kruzhkov<EMAIL_ADDRESS>escribió:

I will be grateful for error reports. And proposals for the development of the application.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/kruzhkov/traccar-manager-ios/issues/13#issuecomment-675666461, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQKRLP44ULYT45DC6CWVCQLSBLIDZANCNFSM4PAZ37UQ.

Sergey, I’m sending feedback trough Apple built in tool, are you receiving it?
Regards
Enviado desde mi iPhone
El 18 ago 2020, a la(s) 2:36 p.m., Angel Hernandez<EMAIL_ADDRESS>escribió:
 Thank you Sergey, it would be an honor to me. Yo can count on me to report anything I see.
Regards from Mexico
Enviado desde mi iPhone
El 18 ago 2020, a la(s) 2:21 p.m., Sergey Kruzhkov<EMAIL_ADDRESS>escribió:

I will be grateful for error reports. And proposals for the development of the application.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/kruzhkov/traccar-manager-ios/issues/13#issuecomment-675666461, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQKRLP44ULYT45DC6CWVCQLSBLIDZANCNFSM4PAZ37UQ.

Yes. Thank you Efren.


Expose username for ansible authentications

This builds on https://github.com/ManageIQ/manageiq/pull/13733 so I will keep this WIP until that PR is merged.
This PR changes the ansible userid/password authentication setters and getters to handle the user name as well as the password.
This allows us to move the knowledge of what the default username is for the various authentication types out of the EmbeddedAnsible class and worker and keep them as proper argument default values to the setter methods.

I think this is ready, @jrafanie want to give it another look?


input[type="image"] gets height and width set

All input types get set to 210px wide and 18px high, which means image buttons get squashed ridiculously. Adding the radiused box-shadow border doesn't make much sense for image buttons either.
It may be too much to set those values for the individual input types since there are a number of nonstandard ones that different browsers and platforms support, but Bootstrap could at least reset height and width to auto on input[type="image"], and the fancy border stuff to none.

I think there is already an issue opened for this: #716.  Is that what you are talking about?

Yes, it's the same problem.
Doing a 'mini-reset' after setting styles broadly seemed to be the house style, so I followed it in the patch.
I left the border-radius stuff w/ transition on :focus alone since you normally get a border in that situation and it might as well be consistent with the others.

closing because this is a duplicate.


No camera toggle button appears, and unable to toggle camera face while recording video in version 0.4.3

Can you please follow the standard issue template?


ZeroClipboard creates large invisible barrier and prevents clicking anywhere

Hi,
In one case, where I include ZeroClipboard.js but don't new it up or use it at all...
On invoking a text editor (happens to be a Kendo Editor, but I don't think this issue can be blamed on Kendo) - a large part of my interface suddenly becomes frozen and can't be clicked.
This creates a significant bug, in that the entire interface now doesn't work
I found that the "unclickable barrier" is there because a massive, invisible div "global-zeroclipboard-html-bridge" set to a size of 1026px and 301 height.
I don't know why it appears - the size might be the same size as the TextArea I just put the cursor in.
I've updated to 2.3.1-beta to make sure it's not an older version... and I also include jquery.zeroclipboard - though please keep in mind: in this case, I don't actually invoke or use either of them. They're just being included. There's not even a section of the page that uses zeroclipboard, in ANY WAY. It is completely unused other than being included as a js include.
Now, admittedly, there may be something new in the Kendo Editor widget that "kicks this off" that wasn't there before. In fact that's likely.
But it still seems like a generic issue with ZeroClipboard.
Why would it appear as a massive, impenetrable shape, covering my entire UI, when I haven't even invoked it or newed it up?
More importantly, how can I stop it (without hacking)?

I can't see how this would be possible if you aren't at least invoking the ZeroClipboard.create() method (either directly or indirectly).
You are sure you do not have a snippet something like the following somewhere?
<script>
  jQuery(document).ready(function($) {
    $("body")
      .on("copy", ".zclip", function(/* ClipboardEvent */ e) {
        e.clipboardData.clearData();
        e.clipboardData.setData("text/plain", $(this).data("zclip-text"));
        e.preventDefault();
      });
  });
</script>


Do not exclude "discouraged" entities from Suggester, just don't allow choosing them

I was too quick in my request to exclude discouraged entities from Suggester, since finding them is an important way to tell editors not to create them again (e.g. some Cs which should not be used since our guidelines require using their parent, etc. etc.). If a discouraged entity is not displayed, the editor might easily re-create a new one following the same logic, which is not what we want.
Therefore, instead of excluding them from Suggester, do a different thing:

do not allow choosing them from Suggester (be it by the Play button or Enter);
sort them at the end (nice to have, but not high-priority if this is a can of worms in other respects);
mark them visually (already done I think).

@Ptrhnk : Thanks for reminding me! Sorry that I forgot about this. This is solved, then.


DEL key does not work

Also integrate CTRL + DEL and CTRL+BACKSPACE` for deleting whole word

As part of this, also check Backspace.


docs: fix the version of golangci-lint in the README.md

Description
Fix the version of golangci-lint tool to v1.51.1 in the README
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Added test case and related test data
[ ] Update the functional test

Checklist:

[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I ran golangci-lint

@nunnatsa

Good catch @chetan-rns!
/lgtm


Bug: Uploaded item image not showing on item drawer

Describe the bug
When an item has an image which was uploaded instead of via url, the image does not display on the item details drawer.

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."


My photo is not sent to the server because it is too small, but app didn't warn me

What
I added a new product this morning. I added images to the products (mostly "more images" as I am not able to read the packaging which is in Burmese).
In my "waiting contributions" list on the app, I see that two photos uploads are in error with: exception could not upload picture: status not ok / the photo is too small…
Expected behavior
Either the mobile app should warn me at the moment I add the photo, either it should scale it up a bit.
Why
It's annoying to silently ignore user inputs, it hinders user trust.
Screenshot/Mockup/Before-After
Smartphone model

Device: Huawey LDN-L21
OS: Android 8.0.0
App Version: 4.12.0

Very strange it seems that the images where finally consumed and landed on the product ! Sorry for false alert…


Issue 935

Textpools are not handled correctly when master language does not match current logon language. In this case empty textpools for current language are compared with textpools for maintenance language and all programs are considered to be locally modified.

#935

Thanks for the feedback. Right now I don't have access to any SAP system, fixes will be provided tomorrow.

I moved the language switching functionality to a local static class called lcl_language. The language is now restored in the individual code blocks, so sy-subrc is no longer stored in a local variable. All recent changes on the master branch are also merged into the pull request so there should be no more conflicts.
There seems to be an issue with abaplint not properly handling identation of try...cleanup...endtry blocks. I can provide a workaround, but this will break the meta information stored in the exception object. Therefore, it would make more sense to correct this in abaplint.

Found a workaround: Manually indenting the cleanup statement by adding two additional spaces does the trick. However, this is not a log term fix because this change needs to be re-done after using pretty printer.

thanks!


Slow Startup. Takes up to 30 seconds

Issue Type: Performance Issue
When i start vscode its very slow. It takes 20 - 30 seconds maybe.
Here my Performance Marks
Performance Marks

What
Duration
Process
Info

start => app.isReady
54
[main]
initial startup: true

nls:start => nls:end
1
[main]
initial startup: true

require(main.bundle.js)
62
[main]
initial startup: true

app.isReady => window.loadUrl()
137
[main]
initial startup: true

window.loadUrl() => begin to require(workbench.desktop.main.js)
10715
[main->renderer]
NewWindow

require(workbench.desktop.main.js)
507
[renderer]
cached data: YES, node_modules took 261ms

require & init workspace storage
4
[renderer]
-

init workspace service
39
[renderer]
-

register extensions & spawn extension host
3881
[renderer]
-

restore viewlet
0
[renderer]
-

restore panel
0
[renderer]
-

restore editors
3777
[renderer]
1: workbench.editors.files.fileEditorInput

overall workbench load
3919
[renderer]
-

workbench ready
15387
[main->renderer]
-

extensions registered
15585
[renderer]
-

VS Code version: Code 1.43.1 (fe22a9645b44368865c0ba92e2fb881ff1afce94, 2020-03-18T07:01:20.184Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item
Value

CPUs
AMD Ryzen 5 2600 Six-Core Processor             (12 x 3400)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.96GB (10.02GB free)

Process Argv
C:\Users\daryl\Desktop\altv-server\resources\myresource\client\startup.mjs

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    0	    78	 11692	code main
    0	    14	  1632	   electron-crash-reporter
    0	    75	 12948	   shared-process
    0	   155	 13476	   gpu-process
    0	    25	 13544	   utility
    0	   159	 14096	   window (Startup Performance - Visual Studio Code)
    8	   106	 19984	     extensionHost
    0	   180	 15396	   window (Startup Performance - Visual Studio Code)
    0	    65	 12416	     C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe
    0	     4	 15052	       C:\WINDOWS\system32\cmd.exe /c ""D:\Microsoft VS Code\bin\code.cmd" --prof-startup"
    0	    37	  3472	         electron_node cli.js
    8	    63	  5100	           "D:\Microsoft VS Code\Code.exe" --prof-startup --inspect-brk=24968 --remote-debugging-port=24969 --inspect-brk-extensions=24970 --prof-startup-prefix C:\Users\daryl\prof-cc04 --no-cached-data
    0	    42	  4380	             gpu-process
    0	     6	 12792	     console-window-host (Windows internal process)
    0	    97	 16344	     extensionHost
    0	    50	 14164	       electron_node tsserver.js
    0	   134	 15460	       electron_node tsserver.js
    0	    45	 16216	         electron_node typingsInstaller.js typesMap.js
    0	    66	 19532	   window (Issue Reporter)

Workspace Info
;

Extensions (5)

Extension
Author (truncated)
Version

bracket-pair-colorizer
Coe
1.0.61

prettier-vscode
esb
3.20.0

discord-vscode
icr
3.13.0

discord
Kua
0.0.6

atlv-complete
stu
0.1.3

(2 theme extensions excluded)

This is a duplicate. Unfortunately, I don't recall the exact issue number nor its title :flushed: Anyways, searching for issues with the same labels will likely help you :point_right:
https://github.com/microsoft/vscode/issues?utf8=✓&q=is%3Aopen+label%3Aperf-startup

@deepak1556 we are seeing more of these. If there anything that has changed in electron? @DarylVirtualV What AV software are you using? Do you have an update pending?

I have no AV and no updates

@deepak1556 we are seeing more of these. If there anything that has changed in electron? @DarylVirtualV What AV software are you using? Do you have an update pending?

I have no AV and updates

@jrieken nothing specific I can remember. But lets try this from the beginning.
@DarylVirtualV can you launch code with --disable-extensions --trace and once the window is loaded a popup will appear with path to the trace file, please attach the file here. Thanks!


Temporary manual install of select Azure PowerShell modules

To mitigate outage with Powershell Gallery https://github.com/PowerShell/PowerShellGallery/commit/eddb15751751b66fa5275d906459de5ce5ef2c0b#diff-2cc39b02078342417071f3d41739e494

/adp run net - core - tests

/azp run net - core - tests

/azp run net - template - tests

The template has an actual test-resources.json and a real live test. Core has no live test so the deployment won't happen.

/azp run net - template - tests

/azp run net - template - tests

/azp run net - template - tests

/azp run net - template - tests

/azp run net - template - tests

/azp run net - template - tests

@damirault thanks for this potential mitigation but I'm not sure it is the best option. I'd like to look at other options before we go to maintaining our own copy of the modules in a blob container. I'm going to close this PR and we will use issue https://github.com/Azure/azure-sdk-tools/issues/1051 to track a better longer term story for this problem.

Agreed, this was a temporary quick hack workaround if needed during the outage, not a long term solution.


Link to Security Baselines for Windows 10 is out of date

[Enter feedback here]
In the Default Policies table the Security Baseline section contains a link "For more information, see Security baselines for Windows 10." The link goes to a page for the 1709 baselines & on a page that is no longer maintained.
Security Baselines info has moved to this link - https://techcommunity.microsoft.com/t5/microsoft-security-baselines/bg-p/Microsoft-Security-Baselines
or this https://docs.microsoft.com/en-us/windows/security/threat-protection/windows-security-baselines

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9463e12a-fa6e-18b1-6800-8aff384e1a9b
Version Independent ID: c2d876d9-bc43-52cf-63f0-d4ced60f3c40
Content: Device configuration - Microsoft Managed Desktop
Content Source: microsoft-365/managed-desktop/service-description/device-policies.md
Service: m365-md
GitHub Login: @jaimeo

Fixed.

@ceaton001 - Thank you for submitting feedback.
From our understanding, the issue has been resolved based on this merged commit https://github.com/MicrosoftDocs/microsoft-365-docs/commit/99f63ae.
Thank you for your contribution to make the docs better! Much appreciated!


Andrii Vlasiuk: Component Based Design, 3 weeks

Learning Objectives

Priorities: 🥚, 🐣, 🐥, 🐔 (click to learn more)

There is a lot to learn in this repository. If you can't master all the material
at once, that's expected! Anything you don't master now will always be waiting
for you to review when you need it. These 4 emoji's will help you prioritize
your study time and to measure your progress:

🥚: Understanding this material is required, it covers the base skills you'll
need for this module and the next. You do not need to finish all of them but
should feel comfortable that you could with enough time.
🐣: You have started all of these exercises and feel you could complete them
all if you just had more time. It may not be easy for you but with effort you
can make it through.
🐥: You have studied the examples and started some exercises if you had time.
You should have a big-picture understanding of these concepts/skills, but may
not be confident completing the exercises.
🐔: These concepts or skills are not necessary but are related to this module.
If you are finished with 🥚, 🐣 and 🐥 you can use the 🐔 exercises to push
yourself without getting distracted from the module's main objectives.

1. Rendering Static Pages

recreate an HTML/CSS web page using pure functions components and encapsulated styles

🥚  JSX : you can ...

[ ]  Write elements with JSX syntax

2. Rendering Data

functional React components
render a static page with provided data
component props
splitting components with design in mind

🥚functional React components: you can ...

[ ] Create a React function component (both function definition and arrow function styles)

[ ] Import/export components between files

🥚 Render data: you can

[ ] Use interpolation ({}) to insert JavaScript expressions into JSX
[ ] Render a list using the .map method

🥚 Components and props : you can ...

[ ] create small, reusable components
[ ] how to pass props into React components

🥚 Create reusable components: you can ...

[ ] Nest components within other components

one folder with a main component
sub-components for your convenience (not part of public contract)

3. Stateful Components

VDOM
what is a hook
useState
useEffect (any side-effect)
component lifecycle

🥚VDOM : you ....

[ ]  can differenciate the real dom from the virtual dom
[ ]  know what reconciliation process is ..

🥚 Hook

[ ] simple, just enough for the flavor
[ ] the react docs "rules of hooks"

🥚 use-state
🥚 use-effect
🥚 component lifecycle
4. Events

create components that manage internal state and emit custom events
handling events
build reusable components that take functions as arguments
child components communicating with parent components
passing functions as props

5. Component Structure

splitting components with logic in mind

why create dumb components when hooks can be anywhere?

re-render cycles (all children)

why putting state at lower levels is efficient
why not to use everything in global state

6. Consuming APIs

fetch and use API data in components
async useEffect callbacks

7. Frontend Routing

react router

8. Global State

being careful about what you put in useContext

only move data to context when it's necessary

store and manage global app state shared between components
useContext

shared state, not the same as useState

other state management systems/strategies exist

Week 1
I Need Help With:

As i had before problem with separation concept so still struggling with it and base on it. As well didn't get till the end syntax.

What went well?

I was able to display movie list but cant make it border around it (i meant if movie in the list green and if not red)

What went less well?

I check the code which our couches did wrote in the class. Basically it's clear but its hard little bit  with CSS (children, vertical) when its need to be dynamic like in our home task with the list. Plus i dont have yet in my head how should look completed app in React with more features and components.

Lessons Learned

I need to work on separation. And i think when i will learn React it will be much more easy and faster to create app

Sunday Prep Work

I am study React documentation and @danielhalasz sorry again that missed our online session

I check the code which our couches did wrote in the class. Basically it's clear but its hard little bit  with CSS (children, vertical) when its need to be dynamic like in our home task with the list. Plus i dont have yet in my head how should look completed app in React with more features and components.

you can write me on Slack to discuss these in more detail

@danielhalasz thank you))If i will have some issue i will text you)

Week 3
I Need Help With:

Basically my main problem is i can understand all parts separately but im getting problems when need to put all together

What went well?

I understand better hooks and how i can deal with components

What went less well?

I had some issue with syntax (to much parenthesis) and still can't adapt for React syntax)

Lessons Learned

I need more practise with React and with some basic stuff to be able write more difficult code

Sunday Prep Work

Trying to build chat app in react


Multiple warnings

What Angular MDC version are you using?
angular-mdc/web: ^0.6.2
angular-mdc/theme: 0.0.8
What browser(s) is this bug affecting?
all
What OS are you using?
Ubuntu 17.04
What are the steps to reproduce the bug?
In abular-cli:
"styles": [
        "../node_modules/bootstrap/dist/css/bootstrap.min.css",
        "style.scss"
      ],

style.scss:
@import "~@angular-mdc/theme/material";
What is the expected behavior?
What is the actual behavior?
Multiple warnings
[WARNING in ./node_modules/css-loader?
{"sourceMap":false,"importLoaders":1}!./node_modules/postcss-loader?{"ident":"postcss"}!./node_modules/sass-loader/lib/loader.js?{"sourceMap":false,"precision":8,"includePaths":[]}!./src/style.scss
(Emitted value instead of an instance of Error) postcss-custom-properties: .../src/style.scss:985:3: Custom property ignored: not scoped to the top-level :root element (.mdc-checkbox { ... --mdc-ripple-fg-translate-start: ... })
NonErrorEmittedError: (Emitted value instead of an instance of Error) postcss-custom-properties: .../src/style.scss:985:3: Custom property ignored: not scoped to the top-level :root element (.mdc-checkbox { ... --mdc-ripple-fg-translate-start: ... })
    at Object.emitWarning .../node_modules/webpack/lib/NormalModule.js:117:16)
    at .../node_modules/postcss-loader/index.js:131:24
    at Array.forEach (native)
    at.../node_modules/postcss-loader/index.js:130:31
 @ ./src/style.scss 4:14-186
 @ multi ./node_modules/bootstrap/dist/css/bootstrap.min.css ./src/style.scss](url)

Any other information you believe would be useful?

Hey @TeodorKolev
It's an Angular CLI problem, but it appears they now have an active PR to resolve it. If you check out issue #394, you'll can find a few temporary workarounds to eliminate these annoying messages.
Closing as duplicate


Trying to mimic exec(...)

(I'm using pyo3 0.13.2, Rust 1.48, Python 3.7, on Linux)
I'm embedding Python as a scripting interface within an application. There's an input where the user can enter some code, and it'll run it with a few additional globals present.
I have things mostly working - but when actually running the users code with pyo3's Python::run I get some correct, but initially very confusing, behavior:
fn main() {
    use pyo3::{
        prelude::*,
        types::{PyBytes, PyDict},
    };
    let gil = pyo3::Python::acquire_gil();
    let py = gil.python();
    let locals = PyDict::new(py);
    locals.set_item("dummy_api", 123);
    py.run(
        r#"
print(dummy_api)
eg = 'Confusing!'
def func():
    print(eg)
func()
"#,
None,
        Some(locals),
    )
    .map_err(|e| e.print_and_set_sys_last_vars(py))
    .unwrap();
}

This executes but results in a confusing NameError - the function can't see the eg variable:
Traceback (most recent call last):
  File "<string>", line 6, in <module>
  File "<string>", line 5, in func
NameError: name 'eg' is not defined

Eventually I noticed this sentence in the Python docs about eval:

Remember that at module level, globals and locals are the same dictionary. If exec gets two separate objects as globals and locals, the code will be executed as if it were embedded in a class definition

So the above Rust code is identical to doing either of these:
exec(open("test.py").read(), None, {'a': 123})
exec(open("test.py").read(), globals(), {'a': 123})

Fair enough, all is well so far.
The problem
What I actually want to do is the equivalent to this Python:
exec(code_snippet, {'dummy_api': 123}, None)

however if I do this in pyo3, it cannot find builtins like print - exec does this:

If the globals dictionary does not contain a value for the key builtins, a reference to the dictionary of the built-in module builtins is inserted under that key. That way you can control what builtins are available to the executed code by inserting your own builtins dictionary into globals before passing it to exec().

Whereas pyo3 does not automatically insert the builtins in globals
My questions
This is all a very long way of asking two things:

How would I get access to the __builtins__ to insert it into my dict - only mention in the docs is the unsafe pyo3::ffi::PyEval_GetBuiltins, but I assume there must be a nicer way of doing this
Is it desired behaviour for Python::run to differ from eval like this? If so, while the pyo3 docs are accurate, it might be worth expanding on exactly how the two arguments work exactly, similar to the eval docs

How would I get access to the builtins to insert it into my dict [...]

Ah, can get __builtins__ by just importing __main__
let exec_globals = [
    ("__builtins__", py.import("__main__")?.getattr("__builtins__")?),
    ("dummy_api", ...),
]
.into_py_dict(py);

py.run(&code_string, Some(&exec_globals), None)?;

Yeah, you need to import __main__ to do so.
Maybe it's beneficial to note that in the FAQ section of the guide.


Escobal method

Curve almost matches predictions of table 1 from the paper (but not quite)
How to find passes in practice?

Looks like the code does the right thing, but still it's not clear how to compute a stream of passes.


How to run godep go test with go1.6

When I run godep go test ./... I get missing packages errors for dependencies in my vendor/ directory.  Is there a fix or workaround for this?

godep save -t will vendor test dependencies as well

@smousa what version of godep are you using?

Thanks, that seemed to work @dhawal55


[refactor] add reference path for source file from impala

Proposed changes
Issue Number: close #xxx
Problem Summary:
According to the requirements of the APLv2, the referenced code needs to be marked with the path of the source code.
Checklist(Required)

Does it affect the original behavior: (Yes/No/I Don't know)
Has unit tests been added: (Yes/No/No Need)
Has document been added or modified: (Yes/No/No Need)
Does it need to update dependencies: (Yes/No)
Are there any changes that cannot be rolled back: (Yes/No)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

org.apache.doris.udf.JMXJsonUtil.java and org.apache.doris.monitor.jvm.JvmPauseMonitor are also copied from Impala (branch-4.0 I guess)

org.apache.doris.udf.JMXJsonUtil and org.apache.doris.monitor.jvm.JvmPauseMonitor are also copied from Impala (branch-4.0 I guess)

done


DSP library to Crotex-R5

Is it feasible to transplant the DSP library to Crotex R5 and how to obtain an acceleration library,

@kalisheep CMSIS-DSP relies on CMSIS-Core for DSP intrinsic support on several compilers.
There is not yet Cortex-R support in CMSIS-Core but it is a work in progress in this pull request:
https://github.com/ARM-software/CMSIS_6/pull/45


Incorrect Message Displayed When Sending Sats

The message says "received sats" when I am sending.

This is the message from LN Service/Receiver upon receiving the payment successfully. It uses the successAction protocol. Protocol specification can be found here: LUD-09


How many epochs required for training?

When digging in your code, I found that training is based on a number of total iterations (let's call max_steps). Based on your codes in experiment.py, it is computed as max_steps=conf.total_samples // conf.batch_size_effective.
total_samples is predefined at template.py (e.g. 130_000_000 for ffhq128) and batch_size_effective is set to 128 by default. For this example, max_steps =  1_015_625. As FFHQ128 includes 70,000 samples, a number of required epochs are 1_015_625 / (70_000 / 128)) ~ 1857 (this is such a huge epoch to train :(( )
Might you let me know that I am correct?

Your understanding is correct. Note that the number of "samples" here is comparable to other DDPM on the same dataset. Maybe, the number of epochs is not interpreted the same way when you are dealing with a generative model?

Your understanding is correct. Note that the number of "samples" here is comparable to other DDPM on the same dataset. Maybe, the number of epochs is not interpreted the same way as in a classification model when you are dealing with a generative model?

Hi, may I know your training time in total for your DiffAE on FFHQ256?


Updated PULL_REQUEST_TEMPLATE.md

Checklist

[x] the individual contributor license agreement is signed
[x] commit message follows commit guidelines

Description of change

With moving some GitHub-specific files to .github in 88d909f and jasig/uPortal@f39b5e4, the links in the pull request template ended up broken

Thanks!  :+1:


add transfer validator to v1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

12 of 22 (54.55%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.9%) to 59.375%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/lib/ERC721TransferValidator.sol
5
6
83.33%

src/test/MockTransferValidator.sol
2
4
50.0%

src/clones/ERC721AConduitPreapprovedCloneable.sol
0
3
0.0%

src/clones/ERC721ContractMetadataCloneable.sol
0
4
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.9%

Covered Lines:
534

Relevant Lines:
744

💛  - Coveralls


RQM Load configuration- URL load issue fix

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 2

Complexity decreasing per file
==============================
+ Ginger/GingerCore/ALM/QCCore.cs  -1

See the complete overview on Codacy


Fix broken multi-line log file detection

Turns out, if you want to use the timestamp to detect the start of multi-line log lines, the multi_line_start_pattern config value needs to be the literal string {datetime_format}
See http://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/AgentReference.html

Coverage remained the same at 70.096% when pulling 9a6c88fdb40ec85f6af68dc279ded284488adb94 on gheine into daaccfc78c7a2513c43b5c1565ff430b2b433b88 on master.


Automated fuzzing

Which problem is this PR solving?
Closes #1737.
Short description of the changes
Integrates with Fuzzit for automated fuzzing. Proposed in #1737.
Runs fuzz regression tests in CI every push and PR. Runs full length fuzzing on Fuzzit every push. Uses genetic fuzzer go-fuzz.
Fuzzing targets are:

Zipkin deserialization.
JSON deserialization.
HTTP requests to an agent.

There's a successful test build here:
https://travis-ci.org/bookmoons/jaeger/builds/583020533
The PR build will fail due to missing an API key. If you'd like to sign in to create an account I can add you to the jaeger org. Then setup is like this:

In Fuzzit settings grab an API key.
In repo settings in Travis paste it to envvar FUZZIT_API_KEY.

I get intermittent build failures, even without my changes. Is that a known issue? For the test build I disabled the normal build jobs.

If you'd like to sign in to create an account I can add you to the jaeger org

I'm there, just signed up using my GitHub account.

I get intermittent build failures, even without my changes. Is that a known issue? For the test build I disabled the normal build jobs.

Apparently, everything is working fine except the fuzz step, which is failing because of the missing API Key:

And here's what I see in the logs:

2019/09/10 07:32:46 Please set env variable FUZZIT_API_KEY or pass --api-key. API Key for you account: https://app.fuzzit.dev/settings

Added you to the org.
https://app.fuzzit.dev/orgs/jaeger/settings

Apparently, everything is working fine except the fuzz step, which is failing because of the missing API Key:

OK, good deal. Maybe there's something different about our Travis accounts.
There are some failures without my changes. Different jobs fail on different runs.
https://travis-ci.org/bookmoons/jaeger/builds/582482304
https://travis-ci.org/bookmoons/jaeger/builds/582478457

Pushed an upgrade to the Fuzzit client that gets regression tests running in PRs without an API key.

Sorry for taking so long to look into this... Just wanted to confirm that this is what we should be seeing in Fuzzit:

Pushed an exploratory change to this, that tries to duplicate the fixture from tests. I'm going to let the fuzz job run and see if it still leaks.

Did it work? I see two jobs still in progress, started yesterday "9/30/2019, 11:14:17 AM".
By the way, in case you work at the company behind fuzzit, here's a request for enhancement: add the timezone to the date.

Yeah, that bit did work. Pushing an upgrade to the latest Fuzzit client which also seemed to help.
But the zipkin fuzzer is hitting a different issue. I've been thinking the right way to handle it. Maybe the Fuzzit reporting could be better but it seems to be a leak in the code. I'm attaching a crashing input from a local run. I bet fixing the leak would stop it from hitting Failed, until that can be improved in Fuzzit.
fatal error: runtime: out of memory
crashers.zip
I'll pass along the time zone request to the Fuzzit team.

In that archive the unsuffixed file is the crashing input.

Fuzzit say they like the time zone idea and they'll get on it.

Maybe the zipkin issue isn't a blocker. Getting the other 2 running is probably valuable, and it could be handled over time.

I see this crossdock failure without my changes. Demonstration here:
https://travis-ci.org/bookmoons/jaeger/builds/592400338
There's a successful run of the fuzzing stages by skipping crossdock:
https://travis-ci.org/bookmoons/jaeger/builds/592392023

Proposed approach to the issue: get jaeger set up with the 3 fuzzers. agent and deserialize-json are in good shape. deserialize-zipkin is nonoptimal but it does run for a while and has a chance to catch crashes. A later effort can improve the zipkin fuzzer.
That puts the available fuzzers to use to get some bug discovery happening for you.

I'm OK in starting small and expanding over time. I have to admit that I'm in no position to expand it, though.

OK, I think those fuzzers are a good start.
This build failure seems to happen intermittently in the build history. Here are 2 recent builds that show it:
https://travis-ci.org/jaegertracing/jaeger/jobs/586437160
https://travis-ci.org/jaegertracing/jaeger/jobs/584330120
✗ [endtoend] test_driver→ (services=go) ⇒ Fail: could not retrieve traces from query service
If that's an expected failure I think this is ready for final review. If it's approved the last thing to do is transfer the API key from Fuzzit to Travis. Be sure to pull it from the jaeger org, there's a dropdown at the top, it's easy to land in your user org which has different keys.

Is it sufficient to export the env var FUZZIT_API_KEY? Is that the one the binary looks for?

Yeah that's the one. If you put in Travis settings for the repo then the client can use it.

It's there now.  The crossdock job keeps failing, perhaps more often than it normally does. I'm starting it again once more. In the meantime: would you like to rebase your branch, or would you prefer me to do it via GitHub UI?

@jaegertracing/jaeger-maintainers, this change might affect the stability of the CI jobs. Keep an eye for increased intermittent test failures or failures in the fuzz CI job.

Thanks for merging!


Update docs relative to .app.src file

The docs are currently telling the user to update the .app.src file, while this is not necessary anymore.

duplicate of https://github.com/ninenines/cowboy/issues/894

Thanks. :-)


clone(..., ..., CLONE_VM|CLONE_VFORK|SIGCHLD, ...) returns Invalid Argument

Build 14905. Following test case prints: "clone() returned: Invalid argument" on WSL (Trusty). Function foo() spawns successfully on native Ubuntu. It appears to be a construct used in glibc 2.24, possibly here. Problem looks a lot like #158, which notes clone() progress was made in 14352, but this combination of flags still seems to trip. File under "vote for it on User Voice".
[test case edited Feb 2 2017]
/* clone-test.c */
#define _GNU_SOURCE
#include <sched.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#include <errno.h>
#include <signal.h>

#define STACK_SIZE 16364

int foo(void* arg) {
    printf("child arg: %s\n", (const char*)arg);
    _exit(0);
}

int main(int argc, char *argv[]) {
    void** child_stack = (void **)malloc(STACK_SIZE);
    int ret = clone(foo,
        child_stack + STACK_SIZE,
        CLONE_VM|CLONE_VFORK|SIGCHLD,
        (void*)"hello");
    sleep(1);
    if (ret == -1) {
        printf("clone() returned: %s\n", strerror(errno));
    }
    else {
        printf("clone() okay!\n");
    }
    printf("exiting\n");
}

strace:
execve("./a.out", ["./a.out"], [/* 19 vars */]) = 0
brk(NULL)                               = 0xaaf000
access("/etc/ld.so.nohwcap", F_OK)      = -1 ENOENT (No such file or directory)
mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f33a6640000
access("/etc/ld.so.preload", R_OK)      = -1 ENOENT (No such file or directory)
open("/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=111528, ...}) = 0
mmap(NULL, 111528, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7f33a6609000
close(3)                                = 0
access("/etc/ld.so.nohwcap", F_OK)      = -1 ENOENT (No such file or directory)
open("/lib/x86_64-linux-gnu/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\3\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0P\t\2\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=1864888, ...}) = 0
mmap(NULL, 3967392, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f33a6030000
mprotect(0x7f33a61ef000, 2097152, PROT_NONE) = 0
mmap(0x7f33a63ef000, 24576, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE,
   3, 0x1bf000) = 0x7f33a63ef000
mmap(0x7f33a63f5000, 14752, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS,
   -1, 0) = 0x7f33a63f5000
close(3)                                = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f33a6630000
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f33a6600000
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f33a65f0000
arch_prctl(ARCH_SET_FS, 0x7f33a6600700) = 0
mprotect(0x7f33a63ef000, 16384, PROT_READ) = 0
mprotect(0x600000, 4096, PROT_READ)     = 0
mprotect(0x7f33a6625000, 4096, PROT_READ) = 0
munmap(0x7f33a6609000, 111528)          = 0
brk(NULL)                               = 0xaaf000
brk(0xad4000)                           = 0xad4000
clone(child_stack=0xacef60, flags=CLONE_VM|CLONE_VFORK|SIGCHLD) = -1 EINVAL (Invalid argument)
nanosleep({1, 0}, 0x7fffe12a46d0)       = 0
fstat(1, {st_mode=S_IFCHR|0620, st_rdev=makedev(136, 0), ...}) = 0
write(1, "clone() returned: Invalid argume"..., 35) = 35
write(1, "exiting\n", 8)                = 8
exit_group(0)                           = ?
+++ exited with 0 +++

Given that he answered the other linked thread on clone(), maybe ping @stehufntdev

Thanks for reporting the issue.  There is limited support for the different supported clone flags, but we are currently working through fixes in this area.

@stehufntdev clone(child_stack=0, flags=CLONE_NEWUSER|SIGCHLD) = -1 EINVAL (Invalid argument) with Vivaldi browser

Thanks iz0eyj, I can confirm we do not support user namespaces (CLONE_NEWUSER) but are tracking that work.

@iz0eyj @stehufntdev  By the way, Arch linux does not support user namespaces by default either.  If you install Arch's build of Vivaldi off the AUR, it should in theory work.

@iz0eyj By the way, you might be able to get Vivaldi to launch with "--no-sandbox".  This disables the use of "User Namespaces".

@fpqc many thanks fpqc, Vivaldi is a nice browser and I'm happy to report something to devs.
Now I'm testing Xenial (only a little problem with sudo command solved in 2 min.).

Please be noted locale-gen fails with compressed charmap due to this bug.

Marking this as a duplicate of #851 - see my comment about the incoming fix #851 (comment)

Cool if this is a dup, but note the failure mode here is EINVAL on clone(...,CLONE_VM|CLONE_VFORK|SIGCHLD, ...), not   ENOMEM on vfork() as in #851 et al. You can allocate all the page file size in the world but the above test case fails on EINVAL, at least at the time of writing.

@therealkenc - You're totally right, this is different. I should have read through this more closely before closing. This is missing flag support in the clone system call.

We updated the code to handle clone vfork (i.e. CLONE_VM|CLONE_VFORK|SIGCHLD) the same as vfork so a fix should be out for insider builds soon.  As part of this change we realized we have some differences in vfork and those will be patched up later.

Thanks @stehufntdev! This is confirmed fixed in 15046. I am guessing 15042 as well, but is also not in the release notes. I'm going to try out Yakkety now since this was the major blocker. #555 will need some grease.

Thanks for confirming!  Yes we are still tracking #555.

In build 17666.rs_prerelease.180504-1501 the following clone flags are still unsupported (testcase: clone_syscall.zip):

CLONE_CHILD_SETTID
CLONE_IO
CLONE_NEWCGROUP
CLONE_NEWNET
CLONE_NEWUSER

CLONE_CHILD_SETTID lack of support is preventing Flatpak to install applications.

Please don't do that. Now this issue gets hits on five unrelated clone flags. Listing them does not inform. See also.


Setup Scrum plan

Estimate: 3 hours
Once completed, this issue updates #3.
Remember to talk about Scrum board

I don't think there is too much else to add to this section, so I'm closing the issue. Feel free to make minor edits to the Scrum section in the project plan if something is missing.


Widget added to dashboard demo isn't draggable

Widgets added dynamically to the dashboard demo aren't draggable. The same behaviour is observed when in our code we add an item into an already rendered draggable grid: the new item renders, but isn't draggable.

I have the same Problem. After I click on a Edge of an item I can drag it around.

Fixed in the release today


Is this guide still valid now

If it serves as a develop guide, then I do not expect to see so many missing/empty chapters and it lags behind tikv's documents;
If it aims to provide some implement details for those who are interested in tikv, I hope it contains some up-to-date information like "this feature is implemented in tikv vertion x.x.x and after", "it will be implemented a few version later", "it is not supported after version y.y.y", so that I know whether I need to finish remaining contents;

Hi @dongb0 , thanks for your attention.
It is expected to serve as a guide for TiKV development. But it is far from finished now, and there is a lack of contributors to write the chapters.
That will be much appreciated if you would like to pick some issues, and let us finish this guide together.
And I think your last suggestion is great. When we add or update content of a chapter, we should also refer to the related TiKV version.


Claiming TRX's vote rewards

Hello,
I just want remembering you to implement a method that claim tron rewards (for voting for super representatives) .
Thank you,

Is it VoteAssetContract?

@MrNaif2018  No. VoteAssetContract is for voting TRC10.
https://github.com/opentron/opentron/blob/226282905ccfc043d7209e143eaf43477ee99cca/proto/proto/contract.proto#L151-L153

Fixed by 7e765a547fea1bf041e3f37c2c660b3c4cee4323


Listen on different local IP addresses for each service or cluster

One problem I run into is that because all the connections go through localhost, there are conflicts between the cookies / localstorage of the different sites.  When I login to kubernetes-dashboard or grafana from one cluster, it messes up the login information for another so I have to login again.
It would be nice if I could specify the local address to listen on.
A workaround for this is to have multiple DNS names for localhost and access each site using a different localhost name.  However, this means the little shortcut to launch the browser for a port forward won't work as-is, I would have to tweak the URL after the page opens to replace localhost with an alias.

PR: https://github.com/pixel-point/kube-forwarder/pull/41

#41 was merged