[Doc Improvement][Update Teams app manifest]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
89
13
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit df86f1b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:warning:Warning
View
Details

msteams-platform/toolkit/TeamsFx-manifest-customization.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/codelens.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/deploy-command.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/deploy-manifest.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/hover.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/manifest preview -3.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/manifest preview-1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/pre.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/preview-23.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/select-environment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/update-to-teams.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/validate.PNG
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-manifest-preview.md
:white_check_mark:Succeeded

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
:white_check_mark:Succeeded
View

msteams-platform/TOC.yml

Line 114, Column 13: [Warning: file-not-found - See documentation] Invalid file link: 'toolkit/TeamsFx-manifest-preview.md'.

msteams-platform/toolkit/TeamsFx-manifest-customization.md

Line 50, Column 1: [Warning: file-not-found - See documentation] Invalid file link: 'TeamsFx-manifest-preview.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
4
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-manifest-customization.md
88
4
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
89
13
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 3a93eb5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/codelens.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/deploy-command.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/deploy-manifest.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/hover.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/manifest preview -3.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/manifest preview-1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/pre.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/preview-23.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/select-environment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/update-to-teams.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/validate.PNG
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-manifest-customization.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-manifest-preview.md
:white_check_mark:Succeeded

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
4
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-manifest-customization.md
88
4
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
89
13
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 9928673:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/codelens.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/deploy-command.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/deploy-manifest.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/hover.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/manifest preview -3.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/manifest preview-1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/pre.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/preview-23.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/select-environment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/update-to-teams.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/validate.PNG
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-manifest-customization.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-manifest-preview.md
:white_check_mark:Succeeded

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
4
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-manifest-customization.md
88
4
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
89
13
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 6da705c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/codelens.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/deploy-command.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/deploy-manifest.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/hover.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/manifest preview -3.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/manifest preview-1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/pre.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/preview-23.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/select-environment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/update-to-teams.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/validate.PNG
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-manifest-customization.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-manifest-preview.md
:white_check_mark:Succeeded

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
4
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-multi-env.md
90
29
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
89
13
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 879c8c3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/codelens.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/deploy-command.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/deploy-manifest.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/hover.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/manifest preview -3.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/manifest preview-1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/pre.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/preview-23.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/select-environment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/update-to-teams.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/validate.PNG
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-manifest-customization.md
:white_check_mark:Succeeded

msteams-platform/toolkit/TeamsFx-manifest-preview.md
:white_check_mark:Succeeded

msteams-platform/toolkit/TeamsFx-multi-env.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
4
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-multi-env.md
90
29
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
90
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 0b87cce:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/codelens.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/deploy-command.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/deploy-manifest.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/hover.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/manifest preview -3.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/manifest preview-1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/pre.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/preview-23.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/select-environment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/update-to-teams.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/validate.PNG
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-manifest-customization.md
:white_check_mark:Succeeded

msteams-platform/toolkit/TeamsFx-manifest-preview.md
:white_check_mark:Succeeded

msteams-platform/toolkit/TeamsFx-multi-env.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
4
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-multi-env.md
90
29
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
90
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 99a5e83:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/codelens.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/deploy-command.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/deploy-manifest.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/hover.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/manifest preview -3.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/manifest preview-1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/pre.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/preview-23.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/select-environment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/update-to-teams.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/validate.PNG
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-manifest-customization.md
:white_check_mark:Succeeded

msteams-platform/toolkit/TeamsFx-manifest-preview.md
:white_check_mark:Succeeded

msteams-platform/toolkit/TeamsFx-multi-env.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
4
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-multi-env.md
90
29
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
90
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 0682681:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/codelens.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/deploy-command.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/deploy-manifest.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/hover.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/manifest preview -3.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/manifest preview-1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/pre.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/preview-23.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/select-environment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/update-to-teams.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/teams toolkit fundamentals/validate.PNG
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-manifest-customization.md
:white_check_mark:Succeeded

msteams-platform/toolkit/TeamsFx-manifest-preview.md
:white_check_mark:Succeeded

msteams-platform/toolkit/TeamsFx-multi-env.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Camel 13949

This PR moves the main source code from camel-core to camel-core-engine, and keeps the unit tests in camel-core.
This makes a better separation and makes using camel-core-engine predicable with Maven.
There is some issues reported about this in:
https://issues.apache.org/jira/projects/CAMEL/issues/CAMEL-13949

Squash before merge


Deprecation of kube ui addon

Added a paragraph to point users to kubernetes dashboard, kube-ui is a dead end found that out the hard way.

I signed it!

@jonathan-kosgei ping

Hi, this my first time contributing, what exactly do I need to do?
On Jun 26, 2016 9:15 AM, "johndmulhausen"<EMAIL_ADDRESS>wrote:

@jonathan-kosgei https://github.com/jonathan-kosgei ping
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes.github.io/pull/682#issuecomment-228586374,
or mute the thread
https://github.com/notifications/unsubscribe/AGZuUs7y2UaOdA8Z_yiFWtraTn3uamk5ks5qPhjngaJpZM4I4Rxh
.

Done. Made the changes with the note.

https://github.com/jonathan-kosgei/kubernetes.github.io/blob/master/docs/getting-started-guides/ubuntu-calico.md
On Wed, Jun 29, 2016 at 1:13 AM, johndmulhausen<EMAIL_ADDRESS>wrote:

@jonathan-kosgei https://github.com/jonathan-kosgei There are several
in-line suggestions that need some addressing. Easiest way is to just use
github.com's web interface and make the suggested edits over at
https://github.com/jonathan-kosgei/kubernetes.github.io (click "Edit" on
any file there).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes.github.io/pull/682#issuecomment-229200438,
or mute the thread
https://github.com/notifications/unsubscribe/AGZuUmXS47CT_yihQUyPyLloaOjF8az6ks5qQZyHgaJpZM4I4Rxh
.

@jonathan-kosgei I don't see your changes for John's comments.  Would you update the PR with his suggestions?

@jonathan-kosgei actually I will just merge and fix the issue


Instructional message about post title

Posts Title should have instructions that Titles are required in order to post

@thomasgwatson

still wondering where this one actually is addressed

In:
https://github.com/Hylozoic/hylo-evo/pull/1562
Or do you want a little more? The title placeholder is changed to something
clearer and the post button has a tooltip has an explainer
On Thu, 9 Nov 2023 at 08:25, Tibet Sprague @.***> wrote:

still wondering where this one actually is addressed
—
Reply to this email directly, view it on GitHub
https://github.com/Hylozoic/hylo-evo/issues/1553#issuecomment-1804150825,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHT4AWXCR6U3NC3KUKX6CDYDT7XPAVCNFSM6AAAAAA5ZCP2GGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUGE2TAOBSGU
.
You are receiving this because you were assigned.Message ID:
@.***>

Ah, ok that should be enough

On Nov 9, 2023, at 8:45 AM, Tom Watson @.***> wrote:
In:
https://github.com/Hylozoic/hylo-evo/pull/1562
Or do you want a little more? The title placeholder is changed to something
clearer and the post button has a tooltip has an explainer
On Thu, 9 Nov 2023 at 08:25, Tibet Sprague @.***> wrote:

still wondering where this one actually is addressed
—
Reply to this email directly, view it on GitHub
https://github.com/Hylozoic/hylo-evo/issues/1553#issuecomment-1804150825,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHT4AWXCR6U3NC3KUKX6CDYDT7XPAVCNFSM6AAAAAA5ZCP2GGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUGE2TAOBSGU
.
You are receiving this because you were assigned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/issues/1553#issuecomment-1804184440, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA5HMV4L6MW5ELZCROWX3YDUCB3AVCNFSM6AAAAAA5ZCP2GGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUGE4DINBUGA.
You are receiving this because you commented.


Avoids the default ssh_config files from reading the default OpenSSH configuration files.

Fixes #340.
When specifying an alternative location of OpenSSH configuration,
it is merged into the configurations in the default location since
Net::SSH.start itself loads OpenSSH configurations unless
options[:config] is false.

Changes Unknown when pulling e1c96ed40e5af9425ab84ebed0be0a7c8664dd65 on yugui:feature/alternate-ssh_config into ** on matschaffer:master**.


Better error message for CPU tensors

Given an example like this:
import torch, triton
from triton import language as tl

@triton.jit
def kernel(in_ptr0, out_ptr0, BLOCK_SIZE: tl.constexpr):
    offset = tl.program_id(0) * BLOCK_SIZE
    indices = offset + tl.arange(0, BLOCK_SIZE)
    tmp0 = tl.load(in_ptr0 + indices)
    tmp1 = tmp0 + 1
    tl.store(out_ptr0 + indices, tmp2)

a = torch.randn(128)
b = torch.empty(128)

kernel[(1,)](a, b, 128)

Triton gives the error:
Traceback (most recent call last):
  File "repro.py", line 17, in <module>
    kernel[(1,)](a, b, 128)
  File "/home/jansel/triton/python/triton/code_gen.py", line 971, in __call__
    return self.kernel(*wargs, **kwargs, grid=self.grid)
  File "/home/jansel/triton/python/triton/code_gen.py", line 960, in __call__
    return _triton.runtime.launch(wargs, self.fn.do_not_specialize, cache_key, self.fn.arg_names,
RuntimeError: CUDA: Error- invalid value

I've seen a couple of people get stuck on this.  The problem is a missing device="cuda".  Triton should give a more helpful error message in this case.

https://github.com/openai/triton/blob/master/python/triton/code_gen.py#L968-L972 I can uncomment this :D This was commented because we had users that ran triton kernel with grid size of 0 on CPU tensors and I didn't wanna break backwards compatibility XD

Actually, this is also not clear how the error message would interact with buffers that are on "CPU" but in the Unified memory. Technically these should still be valid to be passed to kernels.

Hrm, we could catch the error when it happens and change the message produced.


Performance: searchService Spawning Process Per Workspace Root leading to ~30-60s Startup Lag

Issue Type: Performance Issue
searchService is spawing a ripgrep process per workspace root that each takes 10-30% CPU. Takes about 30 seconds until VSCode is usable.
I can provide more detailed project configuration privately. As you can see in the status log we have ~27 workspace roots.
This status was taken after reloading with extensions disabled.
https://gist.github.com/hhanesand/aa43b26a98d2bde359a819a71dde461c

I tried Insiders and seemed to experience the same issue but I did not generate a snapshot as I assumed it was of the same cause.

duplicate of https://github.com/microsoft/vscode/issues/98594


The 'chain' in langchain4j is too rigidly implemented, requiring more integration for custom processes, and there isn't a solution provided.[FEATURE]

Is your feature request related to a problem? Please describe.
when i use langchain4j, i want to deal with some user message before do findRelevant but the func `    @Override
public List findRelevant(String text) {
    Embedding embeddedText = embeddingModel.embed(text).content();

    List<EmbeddingMatch<TextSegment>> relevant;
    if (minScore == null) {
        relevant = embeddingStore.findRelevant(embeddedText, maxResults);
    } else {
        relevant = embeddingStore.findRelevant(embeddedText, maxResults, minScore);
    }

    return relevant.stream()
            .map(EmbeddingMatch::embedded)
            .collect(toList());
}`

Describe the solution you'd like
please add the origin text of user message to the func paramters ,just like
`    @Override
public List findRelevant(String text) {
    Embedding embeddedText = embeddingModel.embed(text).content();

    List<EmbeddingMatch<TextSegment>> relevant;
    if (minScore == null) {
        relevant = embeddingStore.findRelevant(originText,embeddedText, maxResults);
    } else {
        relevant = embeddingStore.findRelevant(originText,embeddedText, maxResults, minScore);
    }

    return relevant.stream()
            .map(EmbeddingMatch::embedded)
            .collect(toList());
}`

Describe alternatives you've considered
when i want to fix some user message or translate to anther question ,i can do everythin just i like to do .

I also encountered such a problem in my business, and my solution was to reimplement the interface.

Working on improving this right now, next release should include it.

I also encountered such a problem in my business, and my solution was to reimplement the interface.

yes  i apply the pr to next version

@leojames this is now supported in this PR: https://github.com/langchain4j/langchain4j/pull/538.
There are now many extension points where you could plug in your custom behaviour.
Feel free to reopen this issue if there is something missing.


Replacing IExpirationTrigger with IChangeToken

Updated

Am I the only one that thinks these name changes sound very out of place here? @muratg @Eilon

:watch:


Fix rendering artifacts

Drawing e.g. a line on a pixel boundary causes the line to be drawn half on one side and half on the other side of the pixel. This means that when moving the primitive being drawn, the bounding box to clear must be extended by 0.5 pixels.
Fixes #1178
@wieslawsoltes does this also fix #1098 ?

Does it take into account matrix transformations, DPI and stroke width?

I tested it with stroke width, but good point on the other two - I will investigate...

@kekekeks you were right, this didn't work with scale transforms. Should now be fixed.

I should probably add some unit tests though.

Unit tests added and some faulty logic fixed.


[PIP 86] add doc for initialize function interface

Motivation
add doc for #13205
Documentation

[x] doc

In addition, the following content needs to be added to the "Available APIs" section.

Add a row for the new interface in the table.

Extended Pulsar Function SDK for Java | An extension to Pulsar-specific libraries, providing the initialization and close interfaces in java. | Functions that require initializing and releasing external resources.

Add two headings to streamline with the new interface.

Language-native interface
Pulsar Function SDK for Java/Python/Go

@momo-jun Please have a look

@momo-jun Please have a look

Thank you for making these changes. Looks good to me now.
Hi @nlu90 @merlimat @Anonymitaet, can you please help review this doc PR? Thanks.


chore(sdk): fix lint issues

Checking with @sujankota to see if he wants to take these rather than introducing merge conflicts in #592


2 GPX tracks with diferent color polylines

How can I put in 2 GPX tracks with both a diferent polyline color
Thank You,
Gert

Two options: https://github.com/mpetazzoni/leaflet-gpx#line-styling

Use the GPX Style extension to define the style of each line in the GPX file itself
Use on L.GPX layer for each GPX track on set appropriate polyline_options in each


Need to scan dev packages in composer.lock

Is your feature request related to a problem? Please describe.
There is a few projects i'm working on where its important to be able to scan development packages in composer files (packages-dev array), but dependecy check currently only parses packages in the packages array.
Describe the solution you'd like
A possible flag or argument that could be passed that enables the packages-dev array to be parsed by dependecy check.
Describe alternatives you've considered
A possible work-around is after using checkout, modifying the composer.lock file to rename packages-dev to packages, which will make dependecy check scan it

Likely need to update the composer analyzer to scan the dev dependencies and add a flag to skip the dev dependencies.


Add milliseconds duration to dashboard

fixes #16799

I will also send a same pr to installer.

Installer PR: https://github.com/istio/installer/pull/380

@bianpengyuan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-dashboard-master
7e2b749c9851032b0a5e527be1f05a8d7ad52332
link
/test e2e-dashboard-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-dashboard-master
7e2b749c9851032b0a5e527be1f05a8d7ad52332
link
/test e2e-dashboard-master

istio-unit-tests-master
7e2b749c9851032b0a5e527be1f05a8d7ad52332
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

After proxy SHA update PR: https://github.com/istio/istio/pull/16861 we could update dashboard test to also verify milliseconds metric.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-dashboard-master
7e2b749c9851032b0a5e527be1f05a8d7ad52332
link
/test e2e-dashboard-master

istio-unit-tests-master
7e2b749c9851032b0a5e527be1f05a8d7ad52332
link
/test istio-unit-tests-master

integ-mixer-k8s-presubmit-tests-master
7e2b749c9851032b0a5e527be1f05a8d7ad52332
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The test failure is actually because of some bad change. Dashboard test should pass now.

@bianpengyuan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-presubmit-tests-master
105b939ba1a8163d542b84daa5b587d4328f2458
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio/wg-environments-maintainers Ping, please help to take a look at this. Thanks!

In response to a cherrypick label: new pull request created: #16893


max batch total tokens problem

System Info
text-generation-inference version: 1.0
Information

[ ] Docker
[ ] The CLI directly

Tasks

[ ] An officially supported command
[ ] My own modifications

Reproduction
I use 4*80G A100 to launcher the llama2-70b, it has the information: Setting max batch total tokens to 406560

If the max-total-tokens is 4096, I think the batch size is 406560/4096=99.
But when I test it using text-generation-benchmark, I only set batch size=32, and it has cuda out of memoy.
Expected behavior
solve the problem of cuda out of memory

i met same

The new 1.0.1 image with the same old flags also causes excessive memory usage suddenly:
2023-08-22T17:48:37.505854Z  INFO text_generation_launcher: Args { model_id: "meta-llama/Llama-2-13b-chat-hf", revision: None, validation_workers: 2, sharded: None, num_shard: Some(4), quantize: None, dtype: None, trust_remote_code: false, max_concurrent_requests: 128, max_best_of: 2, max_st
op_sequences: 4, max_input_length: 4096, max_total_tokens: 8192, waiting_served_ratio: 1.2, max_batch_prefill_tokens: 4096, max_batch_total_tokens: None, max_waiting_tokens: 20, hostname: "e3c0c2cc1223", port: 80, shard_uds_path: "/tmp/text-generation-server", master_addr: "localhost", maste
r_port: 29500, huggingface_hub_cache: Some("/data"), weights_cache_override: None, disable_custom_kernels: false, cuda_memory_fraction: 1.0, rope_scaling: None, rope_factor: None, json_output: false, otlp_endpoint: None, cors_allow_origin: [], watermark_gamma: None, watermark_delta: None, ng
rok: false, ngrok_authtoken: None, ngrok_edge: None, env: false }
2023-08-22T17:48:37.505882Z  INFO text_generation_launcher: Sharding model on 4 processes
2023-08-22T17:48:37.505981Z  INFO download: text_generation_launcher: Starting download process.
2023-08-22T17:48:41.519577Z  INFO text_generation_launcher: Files are already present on the host. Skipping download.

2023-08-22T17:48:42.109526Z  INFO download: text_generation_launcher: Successfully downloaded weights.
2023-08-22T17:48:42.109834Z  INFO shard-manager: text_generation_launcher: Starting shard rank=0
2023-08-22T17:48:42.109910Z  INFO shard-manager: text_generation_launcher: Starting shard rank=1
2023-08-22T17:48:42.110558Z  INFO shard-manager: text_generation_launcher: Starting shard rank=3
2023-08-22T17:48:42.110565Z  INFO shard-manager: text_generation_launcher: Starting shard rank=2
2023-08-22T17:48:52.117293Z  INFO shard-manager: text_generation_launcher: Waiting for shard to be ready... rank=0
2023-08-22T17:48:52.117805Z  INFO shard-manager: text_generation_launcher: Waiting for shard to be ready... rank=1
2023-08-22T17:48:52.118175Z  INFO shard-manager: text_generation_launcher: Waiting for shard to be ready... rank=2
2023-08-22T17:48:52.118316Z  INFO shard-manager: text_generation_launcher: Waiting for shard to be ready... rank=3
2023-08-22T17:48:55.958802Z  INFO text_generation_launcher: Server started at unix:///tmp/text-generation-server-3

2023-08-22T17:48:56.021360Z  INFO shard-manager: text_generation_launcher: Shard ready in 13.90970234s rank=3
2023-08-22T17:48:56.057510Z  INFO text_generation_launcher: Server started at unix:///tmp/text-generation-server-0

2023-08-22T17:48:56.072159Z  INFO text_generation_launcher: Server started at unix:///tmp/text-generation-server-1

2023-08-22T17:48:56.074311Z  INFO text_generation_launcher: Server started at unix:///tmp/text-generation-server-2

2023-08-22T17:48:56.120909Z  INFO shard-manager: text_generation_launcher: Shard ready in 14.009652831s rank=1
2023-08-22T17:48:56.121430Z  INFO shard-manager: text_generation_launcher: Shard ready in 14.010060624s rank=2
2023-08-22T17:48:56.123510Z  INFO shard-manager: text_generation_launcher: Shard ready in 14.012808255s rank=0
2023-08-22T17:48:56.218943Z  INFO text_generation_launcher: Starting Webserver
2023-08-22T17:48:56.794558Z  WARN text_generation_router: router/src/main.rs:345: `--revision` is not set
2023-08-22T17:48:56.794580Z  WARN text_generation_router: router/src/main.rs:346: We strongly advise to set it to a known supported commit.
2023-08-22T17:48:57.013516Z  INFO text_generation_router: router/src/main.rs:367: Serving revision 0ba94ac9b9e1d5a0037780667e8b219adde1908c of model meta-llama/Llama-2-13b-chat-hf
2023-08-22T17:48:57.018593Z  INFO text_generation_router: router/src/main.rs:210: Warming up model
2023-08-22T17:49:00.883050Z  INFO text_generation_router: router/src/main.rs:243: Setting max batch total tokens to 347776
2023-08-22T17:49:00.883068Z  INFO text_generation_router: router/src/main.rs:244: Connected
2023-08-22T17:49:00.883074Z  WARN text_generation_router: router/src/main.rs:249: Invalid hostname, defaulting to <IP_ADDRESS>

The shard is 4 and --max-total-tokens 8192  --max-input-length 4096 - the same docker run works perfectly with 0.9.3 with 27G to 30G usage in total across all 4 GPUs. In 1.0.1 it doesn't crash because I have 320G in total GPU memory.
I think in the newer versions there is a default number somewhere or I should set something to avoid this Setting max batch total tokens to 347776 as it explodes right after printing this line.

I would like to correct myself, it seems to be an issue starting 0.9.4. I will live a end-to-end example here:
The cli command to run the docker for 0.9.3 and 0.9.4 with identical flags which is a different between 4x 11300MiB vs. 4x 76020MiB. I believe something happened here to rather simplify setting these max tokens that either doesn't work on all ENVs models, or I am missing something to set with a very low number: https://github.com/huggingface/text-generation-inference/pull/630
With 0.9.3:
docker run \
  --name "${NAME}" \
  --gpus all \
  --shm-size 2g \
  -p $PORT:80 \
  -e HUGGING_FACE_HUB_TOKEN= \
  -v $volume:/data \
  --detach \
  ghcr.io/huggingface/text-generation-inference:0.9.3 \
  --model-id $model_id \
  --num-shard $num_shard \
  --max-total-tokens 8192 \
  --max-input-length 4096

2023-08-22T18:35:50.966384Z  INFO text_generation_launcher: Args { model_id: "meta-llama/Llama-2-13b-chat-hf", revision: None, validation_workers: 2, sharded: None, num_shard: Some(4), quantize: None, dtype: None, trust_remote_code: false, max_concurrent_requests: 128, max_best_of: 2, max_stop_sequences: 4, max_input_length: 4096, max_total_tokens: 8192, waiting_served_ratio: 1.2, max_batch_prefill_tokens: 4096, max_batch_total_tokens: 16000, max_waiting_tokens: 20, hostname: "831e9d857f4c", port: 80, shard_uds_path: "/tmp/text-generation-server", master_addr: "localhost", master_port: 29500, huggingface_hub_cache: Some("/data"), weights_cache_override: None, disable_custom_kernels: false, json_output: false, otlp_endpoint: None, cors_allow_origin: [], watermark_gamma: None, watermark_delta: None, ngrok: false, ngrok_authtoken: None, ngrok_domain: None, ngrok_username: None, ngrok_password: None, env: false }
2023-08-22T18:35:50.966415Z  INFO text_generation_launcher: Sharding model on 4 processes
2023-08-22T18:35:50.966517Z  INFO download: text_generation_launcher: Starting download process.
2023-08-22T18:35:53.722427Z  INFO text_generation_launcher: Files are already present on the host. Skipping download.

2023-08-22T18:35:54.569514Z  INFO download: text_generation_launcher: Successfully downloaded weights.
2023-08-22T18:35:54.569821Z  INFO shard-manager: text_generation_launcher: Starting shard 0 rank=0
2023-08-22T18:35:54.569846Z  INFO shard-manager: text_generation_launcher: Starting shard 1 rank=1
2023-08-22T18:35:54.570439Z  INFO shard-manager: text_generation_launcher: Starting shard 2 rank=2
2023-08-22T18:35:54.570524Z  INFO shard-manager: text_generation_launcher: Starting shard 3 rank=3
2023-08-22T18:36:04.577792Z  INFO shard-manager: text_generation_launcher: Waiting for shard 0 to be ready... rank=0
2023-08-22T18:36:04.577877Z  INFO shard-manager: text_generation_launcher: Waiting for shard 1 to be ready... rank=1
2023-08-22T18:36:04.577948Z  INFO shard-manager: text_generation_launcher: Waiting for shard 2 to be ready... rank=2
2023-08-22T18:36:04.578348Z  INFO shard-manager: text_generation_launcher: Waiting for shard 3 to be ready... rank=3
2023-08-22T18:36:08.252380Z  INFO text_generation_launcher: Server started at unix:///tmp/text-generation-server-3

2023-08-22T18:36:08.280330Z  INFO text_generation_launcher: Server started at unix:///tmp/text-generation-server-1

2023-08-22T18:36:08.280869Z  INFO shard-manager: text_generation_launcher: Shard 1 ready in 13.709866754s rank=1
2023-08-22T18:36:08.281223Z  INFO shard-manager: text_generation_launcher: Shard 3 ready in 13.70945285s rank=3
2023-08-22T18:36:08.302626Z  INFO text_generation_launcher: Server started at unix:///tmp/text-generation-server-2

2023-08-22T18:36:08.329096Z  INFO text_generation_launcher: Server started at unix:///tmp/text-generation-server-0

2023-08-22T18:36:08.380896Z  INFO shard-manager: text_generation_launcher: Shard 2 ready in 13.809521206s rank=2
2023-08-22T18:36:08.380927Z  INFO shard-manager: text_generation_launcher: Shard 0 ready in 13.810307918s rank=0
2023-08-22T18:36:08.478732Z  INFO text_generation_launcher: Starting Webserver
2023-08-22T18:36:09.208451Z  WARN text_generation_router: router/src/main.rs:324: `--revision` is not set
2023-08-22T18:36:09.208471Z  WARN text_generation_router: router/src/main.rs:325: We strongly advise to set it to a known supported commit.
2023-08-22T18:36:09.643493Z  INFO text_generation_router: router/src/main.rs:346: Serving revision 0ba94ac9b9e1d5a0037780667e8b219adde1908c of model meta-llama/Llama-2-13b-chat-hf
2023-08-22T18:36:09.649716Z  INFO text_generation_router: router/src/main.rs:212: Warming up model
2023-08-22T18:36:13.272971Z  INFO text_generation_router: router/src/main.rs:221: Connected
2023-08-22T18:36:13.272993Z  WARN text_generation_router: router/src/main.rs:226: Invalid hostname, defaulting to <IP_ADDRESS>

Tue Aug 22 18:36:46 2023
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 530.30.02              Driver Version: 530.30.02    CUDA Version: 12.1     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                  Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf            Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  NVIDIA A100 80GB PCIe           On | 00000000:08:00.0 Off |                    0 |
| N/A   38C    P0               67W / 300W|  11302MiB / 81920MiB |      0%      Default |
|                                         |                      |             Disabled |
+-----------------------------------------+----------------------+----------------------+
|   1  NVIDIA A100 80GB PCIe           On | 00000000:48:00.0 Off |                    0 |
| N/A   36C    P0               63W / 300W|  11310MiB / 81920MiB |      0%      Default |
|                                         |                      |             Disabled |
+-----------------------------------------+----------------------+----------------------+
|   2  NVIDIA A100 80GB PCIe           On | 00000000:88:00.0 Off |                    0 |
| N/A   36C    P0               64W / 300W|  11310MiB / 81920MiB |      0%      Default |
|                                         |                      |             Disabled |
+-----------------------------------------+----------------------+----------------------+
|   3  NVIDIA A100 80GB PCIe           On | 00000000:C8:00.0 Off |                    0 |
| N/A   36C    P0               63W / 300W|  11270MiB / 81920MiB |      0%      Default |
|                                         |                      |             Disabled |
+-----------------------------------------+----------------------+----------------------+

+---------------------------------------------------------------------------------------+
| Processes:                                                                            |
|  GPU   GI   CI        PID   Type   Process name                            GPU Memory |
|        ID   ID                                                             Usage      |
|=======================================================================================|
|    0   N/A  N/A   1972012      C   /opt/conda/bin/python3.9                  11300MiB |
|    1   N/A  N/A   1972013      C   /opt/conda/bin/python3.9                  11308MiB |
|    2   N/A  N/A   1972015      C   /opt/conda/bin/python3.9                  11308MiB |
|    3   N/A  N/A   1972017      C   /opt/conda/bin/python3.9                  11268MiB |
+---------------------------------------------------------------------------------------+

With 0.9.4:
docker run \
  --name "${NAME}" \
  --gpus all \
  --shm-size 2g \
  -p $PORT:80 \
  -e HUGGING_FACE_HUB_TOKEN= \
  -v $volume:/data \
  --detach \
  ghcr.io/huggingface/text-generation-inference:0.9.4 \
  --model-id $model_id \
  --num-shard $num_shard \
  --max-total-tokens 8192 \
  --max-input-length 4096

2023-08-22T18:32:21.740739Z  INFO text_generation_launcher: Args { model_id: "meta-llama/Llama-2-13b-chat-hf", revision: None, validation_workers: 2, sharded: None, num_shard: Some(4), quantize: None, dtype: None, trust_remote_code: false, max_concurrent_requests: 128, max_best_of: 2, max_stop_sequences: 4, max_input_length: 4096, max_total_tokens: 8192, waiting_served_ratio: 1.2, max_batch_prefill_tokens: 4096, max_batch_total_tokens: None, max_waiting_tokens: 20, hostname: "0da69a223a58", port: 80, shard_uds_path: "/tmp/text-generation-server", master_addr: "localhost", master_port: 29500, huggingface_hub_cache: Some("/data"), weights_cache_override: None, disable_custom_kernels: false, cuda_memory_fraction: 1.0, json_output: false, otlp_endpoint: None, cors_allow_origin: [], watermark_gamma: None, watermark_delta: None, ngrok: false, ngrok_authtoken: None, ngrok_edge: None, env: false }
2023-08-22T18:32:21.740761Z  INFO text_generation_launcher: Sharding model on 4 processes
2023-08-22T18:32:21.740855Z  INFO download: text_generation_launcher: Starting download process.
2023-08-22T18:32:24.992696Z  INFO text_generation_launcher: Files are already present on the host. Skipping download.

2023-08-22T18:32:25.744129Z  INFO download: text_generation_launcher: Successfully downloaded weights.
2023-08-22T18:32:25.744846Z  INFO shard-manager: text_generation_launcher: Starting shard rank=0
2023-08-22T18:32:25.744847Z  INFO shard-manager: text_generation_launcher: Starting shard rank=3
2023-08-22T18:32:25.744848Z  INFO shard-manager: text_generation_launcher: Starting shard rank=2
2023-08-22T18:32:25.744850Z  INFO shard-manager: text_generation_launcher: Starting shard rank=1
2023-08-22T18:32:35.752342Z  INFO shard-manager: text_generation_launcher: Waiting for shard to be ready... rank=3
2023-08-22T18:32:35.752431Z  INFO shard-manager: text_generation_launcher: Waiting for shard to be ready... rank=2
2023-08-22T18:32:35.752475Z  INFO shard-manager: text_generation_launcher: Waiting for shard to be ready... rank=0
2023-08-22T18:32:35.752759Z  INFO shard-manager: text_generation_launcher: Waiting for shard to be ready... rank=1
2023-08-22T18:32:40.814730Z  INFO text_generation_launcher: Server started at unix:///tmp/text-generation-server-3

2023-08-22T18:32:40.845352Z  INFO text_generation_launcher: Server started at unix:///tmp/text-generation-server-1

2023-08-22T18:32:40.856124Z  INFO shard-manager: text_generation_launcher: Shard ready in 15.110481277s rank=3
2023-08-22T18:32:40.858248Z  INFO shard-manager: text_generation_launcher: Shard ready in 15.111926233s rank=1
2023-08-22T18:32:40.861504Z  INFO text_generation_launcher: Server started at unix:///tmp/text-generation-server-2

2023-08-22T18:32:40.890708Z  INFO text_generation_launcher: Server started at unix:///tmp/text-generation-server-0

2023-08-22T18:32:40.956214Z  INFO shard-manager: text_generation_launcher: Shard ready in 15.210237629s rank=0
2023-08-22T18:32:40.956394Z  INFO shard-manager: text_generation_launcher: Shard ready in 15.210305294s rank=2
2023-08-22T18:32:40.958132Z  INFO text_generation_launcher: Starting Webserver
2023-08-22T18:32:41.406346Z  WARN text_generation_router: router/src/main.rs:341: `--revision` is not set
2023-08-22T18:32:41.406362Z  WARN text_generation_router: router/src/main.rs:342: We strongly advise to set it to a known supported commit.
2023-08-22T18:32:41.641062Z  INFO text_generation_router: router/src/main.rs:363: Serving revision 0ba94ac9b9e1d5a0037780667e8b219adde1908c of model meta-llama/Llama-2-13b-chat-hf
2023-08-22T18:32:41.651831Z  INFO text_generation_router: router/src/main.rs:210: Warming up model
2023-08-22T18:32:45.602566Z  INFO text_generation_router: router/src/main.rs:239: Setting max batch total tokens to 348160
2023-08-22T18:32:45.602596Z  INFO text_generation_router: router/src/main.rs:240: Connected
2023-08-22T18:32:45.602606Z  WARN text_generation_router: router/src/main.rs:245: Invalid hostname, defaulting to <IP_ADDRESS>

+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 530.30.02              Driver Version: 530.30.02    CUDA Version: 12.1     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                  Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf            Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  NVIDIA A100 80GB PCIe           On | 00000000:08:00.0 Off |                    0 |
| N/A   38C    P0               67W / 300W|  76172MiB / 81920MiB |      0%      Default |
|                                         |                      |             Disabled |
+-----------------------------------------+----------------------+----------------------+
|   1  NVIDIA A100 80GB PCIe           On | 00000000:48:00.0 Off |                    0 |
| N/A   37C    P0               63W / 300W|  76180MiB / 81920MiB |      0%      Default |
|                                         |                      |             Disabled |
+-----------------------------------------+----------------------+----------------------+
|   2  NVIDIA A100 80GB PCIe           On | 00000000:88:00.0 Off |                    0 |
| N/A   37C    P0               64W / 300W|  76020MiB / 81920MiB |      0%      Default |
|                                         |                      |             Disabled |
+-----------------------------------------+----------------------+----------------------+
|   3  NVIDIA A100 80GB PCIe           On | 00000000:C8:00.0 Off |                    0 |
| N/A   37C    P0               64W / 300W|  76460MiB / 81920MiB |      0%      Default |
|                                         |                      |             Disabled |
+-----------------------------------------+----------------------+----------------------+

+---------------------------------------------------------------------------------------+
| Processes:                                                                            |
|  GPU   GI   CI        PID   Type   Process name                            GPU Memory |
|        ID   ID                                                             Usage      |
|=======================================================================================|
|    0   N/A  N/A   1968614      C   /opt/conda/bin/python3.9                  76170MiB |
|    1   N/A  N/A   1968617      C   /opt/conda/bin/python3.9                  76178MiB |
|    2   N/A  N/A   1968615      C   /opt/conda/bin/python3.9                  76018MiB |
|    3   N/A  N/A   1968613      C   /opt/conda/bin/python3.9                  76458MiB |
+---------------------------------------------------------------------------------------+

There's nothing wrong. After 0.9.4 we're warming up the RAM to prevent explosion during runtime (when you receive enough load).
If you don't want to use all the VRAM you can use --cuda-memory-fraction.

@Narsil
Before 0.9.4 release, I was stress-testing the system by concurrent users and max token lengths. I didn't noticed GPU memory exploding to 7x times.
I don't think there is something wrong, I think there is a flag missing from my docker run to somehow ground the VRAM to a specific amount like before

didn't noticed GPU memory exploding to 7x times.

The warmup assumes worse possible conditions which are max batch size + max PREFILL step :).
Since we've added that we haven't seen any OOM in production anymore, which was happening before on actually stressed models.
Closing since issue seems to be solved.

The warmup assumes worse possible conditions which are max batch size + max PREFILL step :).
Since we've added that we haven't seen any OOM in production anymore, which was happening before on actually stressed models.

Totally makes sense, thanks for this new feature.


编辑器遇到这段代码发生无响应

Issue Type: Bug
禁用所有扩展的情况下
复制下面这段代码到任意一个扩展名为.php的文件里面
if ($output->asset_id != 'ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff') {
continue;
}
编辑器马上卡死
VS Code version: Code 1.25.1 (1dfc5e557209371715f655691b1235b6b26a06be, 2018-07-11T15:43:53.668Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
AMD Ryzen 7 1700X Eight-Core Processor          (16 x 3394)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.93GB (1.11GB free)

Process Argv
D:\Portabel\VSCode\Code.exe

Screen Reader
no

VM
0%

Google translate:
Copy the following code into any file with a .php extension.
if ($output->asset_id != 'ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff') {
                        continue;
                    }

The editor is stuck right away.

Probably same as https://github.com/Microsoft/vscode/issues/46907
@aeschli @alexandrudima What's the best way to debug these hangs while colorizing?

@roblourens  You can use these steps to pin down the problematic regexp.
https://github.com/Microsoft/vscode/issues/40279#issuecomment-361405690

I can reduce it to Searching for (?i)([a-z0-9_\x{7f}-\x{7fffffff}]+)\s*\( in  (ffffffffffffffffffffffffff but I have no idea what the problem with that is.

@roblourens Have you tried https://regex101.com/ -- I have used that successfully to pinpoint catastrophic backtracking.

It seems like it's not catastrophic backtracking. I think I need to debug some more inside oniguruma.

This appears fixed in recent versions, likely the same root cause as #75468


The Protocol Declaration section is incorrect.

The Protocol declaration documentation for the "Name" element currently reads "The name of a valid protocol supported by Azure AD B2C that is used as part of the technical profile. Possible values: OAuth1, OAuth2, SAML2, OpenIdConnect, Proprietary, session management, self-asserted, or None."
However, Self-Asserted and Session Management TP's are both defined with a Proprietary name and corresponding SelfAssertedAttributeProvider or <Type>SSOSessionProvider handlers, respectively.  Only OAuth1, Oauth2, SAML2, OpenIDConnect, Proprietary, or None seem to currently be legal values.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 388cccb2-2f58-b0fb-fc2f-1828e35e431c
Version Independent ID: c3ca0abf-ae09-e109-8376-01c086ba5abc
Content: TechnicalProfiles - Azure AD B2C
Content Source: articles/active-directory-b2c/technicalprofiles.md
Service: active-directory
Sub-service: b2c
GitHub Login: @mmacy
Microsoft Alias: marsma

@dotnetgator Thank you for reaching out. We will investigate and update the thread further.


undocumented ansible_ssh_host required when using CA & Key Generation Strategy

Describe the issue
Deploying a Cluster with the minimal configuration for tls/mutual_tls, the playbook fail
with :
ansible.errors.AnsibleUndefinedVariable: {{ [inventory_hostname, ansible_fqdn, ansible_host, ansible_ssh_host, hostname|default(omit)] | unique }}
during:
Create Openssl Config for SAN Task
To Reproduce
Configure inventory per https://docs.confluent.io/installer

ansible_host for each host to
ssl_enabled: true
ssl_mutual_auth_enabled: true
Run playbook

Expected behaviour
If ssl_custom_certs_remote_src is set to true, then any certificate validation should occur on the remote hosts. Delegating to localhost is not appropriate when this is the case.
Inventory File
all:
  vars:
    ansible_connection: ssh
    ansible_user: asouquieres
    ansible_become: true
    ansible_ssh_private_key_file: ~/.ssh/adam-gcp-nopwd
    ansible_ssh_common_args: -o StrictHostKeyChecking=no
    ssl_enabled: true
    ssl_mutual_auth_enabled: true

zookeeper:
  hosts:
    hostname1:
      ansible_host: <IP_ADDRESS>
kafka_broker:
  hosts:
    hostname2:
      ansible_host: <IP_ADDRESS>
    hostname3:
      ansible_host: <IP_ADDRESS>
    hostname4:
      ansible_host: <IP_ADDRESS>
schema_registry:
  hosts:
    hostname5:
      ansible_host: <IP_ADDRESS>

ksql:
  hosts:
    hostname6:
      ansible_host: <IP_ADDRESS>

kafka_connect:
  hosts:
    hostname7:
      ansible_host: <IP_ADDRESS>

      vars:
        kafka_connect_confluent_hub_plugins:
          - confluentinc/kafka-connect-datagen:0.4.0

control_center:
  hosts:
    hostname8:
      ansible_host: <IP_ADDRESS>

Environment (please complete the following information):
Source OS: MacOs Monterey
Target OS for all HOSTS : Vanilla Ubuntu 20.04 hosted on GCP
CP-Ansible Branch: ansible galaxy latest version
Ansible Version 2.12.3
Workaround :
Add ansible_ssh_host with same information as ansible_host for each host of the inventory

Hi @SouquieresAdam
This is a ansible version specific issue. We only support ansible version 2.11
Please give it a try with 2.11 only.

We'll have this supported from the next patch (7.2.3) and next minor release (7.3)


Status of this project?

What is the status of this project? I only see an initial commit m0 and hardly any coding changes afterwards. Is this project terminated?

@ramondeklein  thanks for interesting. The project and website will be updated in recent week.
The plan is like this:

TensorBase Base Edition: this repo project of TensorBase will become TensorBase Base Edition. It is planned to provide a full Rust implementation in the Base edition, which will increase more engineering flexibility, lower latency and less performance (but still be faster than its peers in the open source world).
TensorBase Frontier Edition: there will be an alpha product of TensorBase Frontier Edition be released in the late of Feb (yeah, it will happen just in this month) as like a free software but without open source license. I will provide a new semi open source license to address the licensing dilemma between bigs and smalls, like recent re-licensing of Elasticsearch.

the alpha site is out although the time is delayed a little:)


CSS and HTML to MUI components

Hi @ypoleto , this is a huge contribution - thank you for revamping the site from traditional CSS to MUI. Looking forward for more contributions from you. Happy Contributing! 💖🤝


Remove docs from branch

Since we are hosting the docs on github, these can be removed from the dev / main branches

Done.


Cross Field Validations

Are cross field validations possible? Eg "either email or phone must be set".

Hey @daniel-sc, thanks for reaching out. Yes, cross field validation is possible and quite simple. There are multiple ways of achieving this, depending on your specific validation strategy.
I am adding a few example. I recommend you open the live demos as they add a few more details.
Option 1: use the any utility
Your specific example can be handled with the any utility function. The any utility function takes a series of functions or expressions, and as long as at least one evaluates to true, it will mark your validation as passing.
There are two possible ways to use any:
Use any to run one of multiple tests
Live Demo: https://codesandbox.io/s/demo-forked-tdj92?file=/src/validate.js
import vest, { test, enforce } from "vest";
import any from "vest/any";

export default vest.create("form_name", (data = {}) => {
  any(
    () =>
      test("email", "Email or phone must be set", () => {
        enforce(data.email).isNotEmpty();
      }),
    () =>
      test("phone", "Email or phone must be set", () => {
        enforce(data.phone).isNotEmpty();
      })
  );
});

Use any to run use different conditions in the same test
Demo: https://codesandbox.io/s/demo-forked-4cydd?file=/src/validate.js
import vest, { test, enforce } from "vest";
import any from "vest/any";

export default vest.create("form_name", (data = {}) => {
  test("email_or_phone", "Email or phone must be set", () =>
    any(
      () => {
        enforce(data.email).isNotEmpty();
        return true;
      },
      () => {
        enforce(data.email).isNotEmpty();
        return true;
      }
    )
  );
});

Option 2: use if/else
If your field depends on a different field's existence or a different simple condition, you could use a basic if/else statement.
In the following example I only validate confirm if password is not empty:
DEMO: https://codesandbox.io/s/demo-forked-z2ur9?file=/src/validate.js
import vest, { test, enforce } from "vest";

export default vest.create("user_form", (data = {}) => {
  test("password", "Password is required", () => {
    enforce(data.password).isNotEmpty();
  });

  if (data.password) {
    test("confirm", "Passwords do not match", () => {
      enforce(data.confirm).equals(data.password);
    });
  }
});

@ealush thanks for the info!
Like it!

Should probably add this as a docs section. Thanks for the good question!

@ealush The live demo seems to be wrong:

@daniel-sc, you are right. I tested email twice but never phone.
Updated the link, and here it is again: https://codesandbox.io/s/demo-forked-ltn8l?file=/src/validate.js

Also, added another example (2.5). Also very useful.


Feat/plugin manager with api

Codecov Report

Merging #278 (1118bca) into feat/servers.url (89c0d08) will increase coverage by 0.16%.
The diff coverage is 97.05%.

@@                 Coverage Diff                  @@
##           feat/servers.url     #278      +/-   ##
====================================================
+ Coverage             86.21%   86.38%   +0.16%
====================================================
  Files                    66       66
  Lines                  3904     3967      +63
  Branches                482      486       +4
====================================================
+ Hits                   3366     3427      +61
- Misses                  537      539       +2
  Partials                  1        1

Impacted Files
Coverage Δ

...s/core/src/managers/pluginManager/PluginManager.ts
90.90% <95.23%> (+0.31%)
:arrow_up:

packages/core/src/types.ts
100.00% <100.00%> (ø)

packages/swagger/src/types.ts
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Handlers not working when app is terminated or killed

Hi, I am adding a video call feature to my app.
I am using firebase handlers to show incoming call notifications. But I can't handle background acceptance and rejection when the app is terminated or killed. Is there any way to do it?

https://github.com/hiennguyen92/flutter_callkit_incoming/blob/master/PUSHKIT.md
Please using Pushkit/VoIP for IOS
For android, please using background firebase receive for show incomming ui

https://github.com/hiennguyen92/flutter_callkit_incoming/blob/master/PUSHKIT.md
Please using Pushkit/VoIP for IOS
For android, please using background firebase receive for show incoming UI

yeah its showing. But what abound the events. I mean if my app is closed and received a incoming call notification and I accept it. The app get open but on accept I can navigate to a new screen

Hi @Usama9999
you can temporarily use
await FlutterCallkitIncoming.activeCalls()

Hi @Usama9999
you can temporarily use
await FlutterCallkitIncoming.activeCalls()

It will return the last call that you accepted.

How do i know if a call is accepted when the app opens on ios, below is the response from await FlutterCallkitIncoming.activeCalls()
{
  "extra": {
    "platform": "ios",
    "user": "abc@123"
  },
  "avatar": "",
  "uuid": "eeb6cbed-cb07-4602-90f4-19f02cac1147",
  "id": "eeb6cbed-cb07-4602-90f4-19f02cac1147",
  "nameCaller": "Hien Nguyenh",
  "type": 1,
  "duration": 30000,
  "appName": "Callkit",
  "handle": "0123456789",
  "normalHandle": 0,
  "ios": {
    "maximumCallGroups": 2,
    "supportsUngrouping": true,
    "maximumCallsPerCallGroup": 1,
    "supportsGrouping": true,
    "handleType": "",
    "audioSessionActive": true,
    "supportsHolding": true,
    "audioSessionPreferredIOBufferDuration": 0.005,
    "supportsDTMF": true,
    "audioSessionPreferredSampleRate": 44100.0,
    "supportsVideo": true,
    "ringtonePath": "",
    "configureAudioSession": true,
    "iconName": "CallKitLogo",
    "audioSessionMode": "",
    "includesCallsInRecents": true
  }
}

did find the solution bro


System.Reflection.TargetInvocationException error when trying to run on Mac from external drive

Hello!
Using Steam, I've installed Cities Skylines on an external drive as I don't have enough internal storage to install it on my computer. I am using Mac and the external drive is formatted as exFAT.
I can't get TMPE to run using this setup, each time I try to enable it I get the following error:
A ModTM:PE <IP_ADDRESS> STABLEcaused an error [ModException]

Details:
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.IO.IOException: Sharing violation on path /Volumes/LaCie/SteamLibrary/steamapps/common/Cities_Skylines/Cities.app/Contents/TMPE.log
  at System.IO.FileStream..ctor (System.String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, Boolean anonymous, FileOptions options) [0x00000] in <filename unknown>:0
  at System.IO.FileStream..ctor (System.String path, FileMode mode, FileAccess access, FileShare share) [0x00000] in <filename unknown>:0
  at (wrapper remoting-invoke-with-check) System.IO.FileStream:.ctor (string,System.IO.FileMode,System.IO.FileAccess,System.IO.FileShare)
  at System.IO.StreamWriter..ctor (System.String path, Boolean append, System.Text.Encoding encoding, Int32 bufferSize) [0x00000] in <filename unknown>:0
  at System.IO.StreamWriter..ctor (System.String path, Boolean append) [0x00000] in <filename unknown>:0
  at (wrapper remoting-invoke-with-check) System.IO.StreamWriter:.ctor (string,bool)
  at System.IO.File.AppendText (System.String path) [0x00000] in <filename unknown>:0
  at CSUtil.Commons.Log.LogToFile (System.String log, LogLevel level) [0x00000] in <filename unknown>:0
  at CSUtil.Commons.Log.Info (System.String s) [0x00000] in <filename unknown>:0
  at TrafficManager.State.SavedGameOptions.Ensure () [0x00000] in <filename unknown>:0
  at TrafficManager.Lifecycle.TrafficManagerMod.OnSettingsUI (.UIHelper helper) [0x00000] in <filename unknown>:0
  at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception

I have a feeling it is similar to this issue:
https://github.com/CitiesSkylinesMods/TMPE/wiki/System.Reflection.TargetInvocationException-TMPE.log-is-denined
So I've tried to use game launch options to change the location of the TMPE log file, similar to what's described here:
https://github.com/CitiesSkylinesMods/TMPE/pull/1151
From that, I tried "/Volumes/LaCie/SteamLibrary/steamapps/common/Cities_Skylines/Cities.app" -LogFile "Volumes/Macintosh HD/Users/mtayloooor/Downloads/output_log.txt" %command% as a Launch Option in Steam, this DOES actually create the output_log.txt file at that location but still the same error message shows.
I've also tried unsubscribing and resubscribing to the mod in Workshop.
Does this sound like I'm on the right track?
I'm a bit stuck. Any help would be appreciated a lot - thank you! :)

Hi,
see #1111

Additionally, it seems that Unity runtime engine (Mono) does not support exFAT drives so there is more errors in the log like this

Additionally, it seems that Unity runtime engine (Mono) does not support exFAT drives so there is more errors in the log like this

thank you, damn. the game seems to run fine on the exFAT drive, it's just TMPE that can't be enabled.
I'm guessing the only solution is to move CS off the exFAT drive? I can't actually do this because I currently only have space available in exFAT :(


Over 18

Add a tickbox saying
I confirm I am over 18
Disable the register button if this isn't ticked.
Default not ticked

Yes


Responsive images for gutenberg editor

We would like to use the great content responsive image functionality (https://github.com/mindkomm/timmy/blob/master/docs/responsive-content-images.md), but we are using the gutenberg editor. I tried it out and there is one problem:
When selecting a defined custom image size in the gutenberg editor, it gets just not recoginzed. I dont see any javascript errors in the console. Just really nothing is happening.

Yeah, honestly I didn’t test this yet with the new editor. We’re using Gutenberg ourselves a lot, but not with the default image block.
I hope I can have a look at this in the next few days, because this is really something that we want to support.

Hey @sque89
I quickly tried it out with a very basic setup of WordPress and Timmy. And for me, changing the size in the editor seems to work for me. So, I have the following questions:

What version of Timmy are you using?
Can you show me your image configuration?
Does this happen with newly uploaded images as well?

Making the image responsive in the frontend isn’t working yet, but that’s another thing to look at.

Hi @gchtr

0.14.1
i tried it with a freshly uploaded image (after creating the image config) and it is working fine

[
        'thumbnail'              => [
            'resize'     => [ 500 ],
            'name'       => 'Thumbnail',
            'post_types' => [ 'all' ],
        ],
        'medium'                 => [
            'resize' => [ 300 ],
            'name'   => 'Medium',
        ],
        'large'                  => [
            'resize' => [ 1024 ],
            'name'   => 'Large',
        ],
        'post'                  => [
            'resize' => [ 1024 ],
            'name'   => 'Post',
        ],

        'featured-row-img-33'    => create_timmy_size('(min-width: 801px) 33.33vw, 100vw'),
        'featured-row-img-50'    => create_timmy_size('(min-width: 801px) 50vw, 100vw'),
        'featured-row-img-66'    => create_timmy_size('(min-width: 801px) 66.66vw, 100vw'),

        'callouts-row-3-desktop' => create_timmy_size('(min-width: 801px) 33.33vw, 1px'),
        'callouts-row-3-mobile'  => create_timmy_size('(max-width: 800px) 100vw, 1px'),
        'callouts-row-4-desktop' => create_timmy_size('(min-width: 1009px) 25vw, 1px'),
        'callouts-row-4-mobile'  => create_timmy_size('(max-width: 1008px) 100vw, 1px'),
        'callouts-row-5-desktop' => create_timmy_size('(min-width: 1009px) 20vw, 1px'),
        'callouts-row-5-mobile'  => create_timmy_size('(max-width: 1008px) 100vw, 1px'),

        'hero'                   => create_timmy_size('100vw'),
        'latest-update'          => create_timmy_size('(min-width: 801px) 16vw, (min-width: 496px) 50vw, 15rem'),
        'event-list'             => create_timmy_size('(max-width: 496px) 100vw, (max-width: 688px) 50vw, (max-width: 1008px) 33vw, (max-width: 1200px) 25vw, calc(1200px / 4)'),
        'staff-row'              => create_timmy_size('240px'),
        'quotes-row'             => create_timmy_size('240px'),
        'timeline'               => create_timmy_size('(max-width: 496px) calc(100vw - 4rem), (max-width: 900px) calc(50vw - 4rem), (max-width: 1200px) 25vw, calc(1200px / 4)'),
        'upcoming-events-row'    => create_timmy_size('240px'),
        'investigation-item'     => create_timmy_size('(max-width: 688px) 100vw, (max-width: 1008px) 50vw, (max-width: 1200px) 33vw, calc(1200px / 3)'),
        'footer-signup'          => create_timmy_size('(max-width: 496px) 1px, (max-width: 33rem) calc(5vw/12), calc((5 / 12) * 33rem)'),
        'media-coverage-row'     => create_timmy_size('12rem'),
        'press-release-row'      => create_timmy_size('(max-width: 801px) calc(100vw - 4rem), (max-width: calc((45rem + 12rem) * (1 + 5 / 7))) calc((7 / 12) * 100vw - 12rem), 45rem'),
        'blog-list'              => create_timmy_size('500px'),
        'news-list'              => create_timmy_size('820px'),

        'container-33-50-100'    => create_timmy_size('(max-width: 496px) 100vw, (max-width: 801px) 50vw, (max-width: 1200px) 33vw, calc(1200px / 3)'),
        'container-33-100-100'   => create_timmy_size('(max-width: 801px) 100vw, (max-width: 1200px) 33vw, calc(1200px / 3)'),
        'container-66-100-100'   => create_timmy_size('(max-width: 801px) 100vw, (max-width: 1200px) 66vw, calc(1200px * (2/3))'),

        'full-25-50-100'         => create_timmy_size('(max-width: 496px) 100vw, (max-width: 801px) 50vw, 25vw'),
        'full-66-50-100'         => create_timmy_size('(max-width: 496px) 100vw, (max-width: 801px) 50vw, 66vw'),
    ]

function create_timmy_size($sizes)
{
    return [
        'resize'     => [ 3000 ],
        'srcset'     => [ [ 375 ], [ 500 ], [ 750 ], [ 800 ], [ 1000 ], [ 1125 ], [ 1500 ], [ 1800 ], [ 2100 ], [ 2400 ], [ 2700 ], [ 3000 ] ],
        'sizes'      => $sizes,
        'show_in_ui' => false,
        'oversize'   => [
            'allow'      => false,
            'style_attr' => false,
        ],
    ];
}

Alright! I assume that new image works, because of the way meta data is handled since since version 0.14.0.
Could you try and run Regenerate Thumbnails in a test environment to check whether this fixes the issue that the image size doesn’t change for existing images?
I’ll still have to look at how to make it work in the frontend.
By the way, cool approach with the create_timmy_sizes() helper function ;).

Regenerating media solved the problem. Perfect, thanks a lot for your time to investigate! I assume this bug can be closed then.
Is there another ticket to track the progress of the actual implementation?
Thanks!

@sque89 I just added a pull request to add support for Responsive Content Images in #29.
You should be able to test it out by loading that branch:
composer require mindkomm/timmy:dev-block-images

I’d be glad to get some feedback on whether this works for you. I had to add some special handling for cases like

When you have both Image Blocks and images in a Classic Editor Block.
When you add an alt text to the image.
If you resize an image manually using the drag handlers or select a preset. In that case, Timmy will keep the width and height attributes that are set on an image by WordPress.

@gchtr comment in the PR

This is fixed with the 0.14.5 release.


Visualize Design Regions with Low Coverage

Is your feature request related to a problem? Please describe.
In NGS diagnostics it is essential to check for design regions lacking coverage which can be caused by faulty probes, bad enrichment or homozygous deletions but also homologies and low complexity regions.
This issue addresses how a visualization of design regions lacking coverage can be displayed to the user and how this enables a quality control for technical validation of a sample.
See also Discussion #529 which deals with the main requirements for diagnostics in a regulated setting on defined subpanels in a whole exome sequencing experiment.
Describe the solution you'd like
VarFish does not offer the direct processing of read alignment data and, thus, this information has to be supplied in the upload, e.g. via a BED, TSV or JSON file.
As a 1st prototype implementation the <20x coverage (a broadly used threshold in germline diagnostics) can be displayed as an table with rows representing genes in a subpanel and columns representing detected coordinates ofinsufficient coverage, e.g.:

Gene
% at 20x
Exons affected

ABC1
95%
E1_2bp_chr1:10-12

ABC2
100%
NONE

ABC3
50%
E2_10bp_chr1:200-210

Describe alternatives you've considered

External enlistment of regions with low coverage as TSV or BED.
Displaying Low Coverage Regions via BED in IGV

Additional context
This quality assessment is directly related to the definition of subpanels within VarFish (#528 ).
This topic was discussed together with Dieter Beule and @holtgrewe on July 5th 2022 together with @your-highness and @selyasar from Labor Berlin.

There is some documentation needed for the ingestion of quality control metrics (#530)

I agree, here is the code in snappy-pipeline that we use.

Resolution Proposal
In the core, operators want to annotate "intepretable" genes with coverage information. We can thus assume that it is sufficient to allow annotating genes that have both an Entrez/NCBI and ENSEMBL gene identifier to be annotated for each case. A future-proof annnotation would allow to store models such as the following.
class CaseGeneAnnotationEntry(models.Model):
    sodar_uuid = models.UUIDField(default=uuid_object.uuid4, unique=True)
    case = models.ForeignKey(Case)
    gene_symbol = models.CharField(max_length=32, null=False, blank=False)
    entrez_id = models.CharField(max_length=32, null=False, blank=False)
    ensembl_gene_id = models.CharField(max_length=32, null=False, blank=False)
    annotation = models.JSONField(default=dict)

We will allow and interpret the following annotation keys:

percentage_at_20x, a number between 0 and 100
level, of ['info', 'warning', 'error']
message, a string to display

We will then display a table on the case page as follows, and color warning rows in yellow and error rows in red.

gene
% at 20x
message

TTN
95%
something

We will need to add support for this in VarFish Server:

Add a corresponding model
Add support for importing it in the importer module, in particular a new REST API endpoint
Display the information on the case overview page

We will further need to add support for uploading a corresponding file with varfish-cli.
Affected Components

VarFish Server
VarFish CLI

Affected Modules/Files

variants
importer

Required Architectural Changes
None
Required Database Changes

New model CaseGeneAnnotationEntry

Backport Possible?
Yes
Resolution Plan

[ ] add model, factories, tests
[ ] add support for importing to importer module with tests
[ ] add displaying the information to the case overview page
see XXX for the corresponding varfish-cli ticket


Typo: Navigating the MTM portal section

In the section:
Typo: Navigating the MTM portal section
In the Section:
Navigating the MTM portal
The MTM portal has two interactive models to navigate between customer data:
Aggregate views were data from all your customers is consolidated in a single list and can be filtered.
"were" should be replaced by "where"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f1d8c451-a643-1109-438c-f40b13ec5980
Version Independent ID: f1d8c451-a643-1109-438c-f40b13ec5980
Content: Multi-tenant customer management for partners - Microsoft Teams
Content Source: Teams/rooms/multi-tenant-management-partner.md
Service: msteams
GitHub Login: @donnah007
Microsoft Alias: v-donnahill

@klstclair thanks again for your help improving Microsoft Docs. This typo has also been fixed.

@scanum this can be closed thank you.


Enhance CI checks

Opening as a draft to socialize and solicit feedback before calling this "done".
This PR enhances CI checks in the following ways:

Break out Format from Test ✅
Add Credo ❌
Add Dialyzer ✅
Add Caching
Expand version matrix (@davydog187 is there is a list of versions you want to shoot to support beyond just the rc?) ✅

Outstanding issues preventing Credo from passing:
Credo
@davydog187 how do you want to handle existing TODO, convert to issues?

We can add all these existing issues to an ignore for now.

The dialyzer error might be highlighting a bug. I threw together a quick unit test for migration.ex to cover this example from the docs: SELECT create_hypertable('conditions', 'time', chunk_time_interval =><PHONE_NUMBER>0) and I get an argument error.
Will investigate and try to include a fix here.

Yes, let's convert the todos to issues and remove from the codebase

All checks pass and caching appears to be working well


copyDatabase path

Is it possible to make a small adjustment in method copyDatabase in sqlite.android.js?
Now a prefilled database must be located in the projects/app folder. If it is at a different location and you pass that relative path when calling copyDatabse you get the error :
"Error: java.lang.IllegalArgumentException: File <path/to/database/db.sqlite> contains a path separator"
That is because in method copyDatabse the name of the database is determined by :
    if (name.indexOf('/')) {         name = name.substring(name.indexOf('/')+1);     }
If instead of 'indexOf' 'lastIndexOf' is used, the database can be located at a different location. It is up to the programmer to pass in the correct path when calling copyDatabase.
I guess for iOS somethng simular should happen, but I can't verify that.

Seems very reasonable.   Sure, add a PR to replace indexOf to lastIndexOf this in both ios and android; and I'll accept it and push it in the next version.  :grinning:


External task comms

Issues affected/resolved
(See https://github.com/blog/1506-closing-issues-via-pull-requests)
Resolves #142
Description:
Adds ability for providers to make requests serviced by other coordinators, with the requests and responses proxied through the providers' coordinator. For example, given a setup where Coordinator1<->ProviderA and Coordinator2<->ProviderB, this will allow ProviderA to use Provider.TaskZ, where the request and response will be proxied through Coordinator1<->Coordinator2. ProviderA never talks to anything other than Coordinator1 and ProviderB never talks to anything other than Coordinator2.
External requests are controlled via the acomm.Request.TaskURL property. Coordinators will proxy based on whether that is present or not.
Additionally, cleaned up the function signature for creating a new acomm.Request as it was getting quite long and disbaled tcp keepalives for coordinators to avoid hanging on shutdown. We'll revisit graceful shutdowns in a separate issue.

This change is

LGTM

Reviewed 34 of 34 files at r1, 3 of 3 files at r2, 3 of 3 files at r3, 6 of 6 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, 1 of 1 files at r7.
Review status: all files reviewed at latest revision, 8 unresolved discussions.

acomm/request.go, line 33 [r1] (raw file):
So a nice thing here could be to do something like http://dave.cheney.net/2014/10/17/functional-options-for-friendly-apis. It probably wouldn't make sense if all the Sets are going to be used, then again maybe...?
`r := NewRequest("sometask")
r.SetResponseHook
// check err
r.SetStreamURL
// check err
// for each option have to call Set* and check error
//vs
r := NewRequest("sometask", SetResponseHook("a url"), SetStreamURL("a different url"))
// or maybe make NewRequest and Set*s chainable?
r := NewRequest("sometask").SetResponseHook("a url")....

acomm/tracker.go, line 407 [r4] (raw file):
why don't you pass r.Body directly to  json.Unmarshal.

acomm/tracker_test.go, line 66 [r4] (raw file):
I take it s.Responses is never closed?

cmd/coordinator-cli/main.go, line 195 [r1] (raw file):
perfect, an example to use in my prev comment:
^
vs
r := acomm.NewRequest(taskName, acomm.SetResponseHook(responseHook), acomm.SetStreamURL(streamURL), acomm.SetArgs(taskArgs)
if r == nil {
    // welp we got an error
}

vs
r := acomm.NewRequest(taskName).SetResponseHook(responseHook).SetStreamURL(streamURL).SetArgs(taskArgs)
if r == nil {
    // welp we got an error
}

the apparent downside is loss of error value, which could be worked around by checking for r.Errored() or something after construction instead of returning nil.

cmd/coordinator-cli/main.go, line 32 [r5] (raw file):

_ -> - saves a key stroke per option. Plus _ in args is eww

coordinator/server.go, line 62 [r4] (raw file):
unwrap this line, its not common in go and a bit confusing, ditto with similar above.

coordinator/server.go, line 33 [r7] (raw file):
This makes more sense in func init() since this change affects the whole package/binary. Maybe we should set it only for the http server used below in the mux?

provider/server.go, line 38 [r4] (raw file):
may be a candidate for api updates...

Comments from Reviewable

Review status: all files reviewed at latest revision, 8 unresolved discussions.

acomm/request.go, line 33 [r1] (raw file):
Hmm. Interesting approach I haven't seen before. Functional options are flexible, but also a bit weird to wrap your head around for people who haven't seen it before. Chaining looks like it'd be tricky to do error handling. @joshie want to weigh in before I make any changes?

acomm/tracker.go, line 407 [r4] (raw file):
json.Unmarshal wants a []byte while http.Response.Body is an io.ReadCloser. Is either read and unmarshal or give the body to a json.NewDecoder and unmarshal. Two steps either way, and in my opinion the former makes it clearer that this all of the data is a single json object to decode.

acomm/tracker_test.go, line 66 [r4] (raw file):
Correct.

cmd/coordinator-cli/main.go, line 195 [r1] (raw file):
Discussion above where the primary comment on this style is.

cmd/coordinator-cli/main.go, line 32 [r5] (raw file):
I actually want to revisit naming style of command line args, json config file fields, and struct json. (e.g. json should be Google style json camelCase, cli fields should be [some style], and some sort of normalization with viper to make the cli fields and config json fields line up). New Issue: https://github.com/cerana/cerana/issues/149

coordinator/server.go, line 62 [r4] (raw file):
Are we just not caring about line length anymore?

provider/server.go, line 38 [r4] (raw file):
Tracker, Request, and Response all could be candidates.

Comments from Reviewable

Review status: all files reviewed at latest revision, 8 unresolved discussions.

coordinator/server.go, line 33 [r7] (raw file):
Setting it on the server would change the results from "no keepalive on outbound requests" vs "no keepalive on inbound requests". Could be that's what we want. There's an issue to take a deeper look at how graceful stuff is being handled with a note about keepalives: https://github.com/cerana/cerana/issues/148

Comments from Reviewable

Review status: all files reviewed at latest revision, 4 unresolved discussions.

acomm/request.go, line 33 [r1] (raw file):
@joshie take a look at another code comment to get some more context/examples. The nice thing about the functional options is that we can get back an error easily, which is a + over chaining.

acomm/tracker.go, line 407 [r4] (raw file):
The problem is that ioutil.ReadAll is a bit of an anti-pattern since it will read all of the incoming message and buffer into memory, which can lead to dos, malicious or by mistake. Which should always be streaming.

coordinator/server.go, line 62 [r4] (raw file):
never really care too much in go world. The stuff you do in filepath.Join helps readability, this here hurts it.

Comments from Reviewable

Review status: 36 of 38 files reviewed at latest revision, 4 unresolved discussions.

acomm/tracker.go, line 407 [r4] (raw file):
Good points. Updated to use a json.Decoder. I'm sure there's other places using ioutil.ReadAll, but that's for another PR.

coordinator/server.go, line 62 [r4] (raw file):
Fair enough. Changed.

Comments from Reviewable

Reviewed 1 of 1 files at r8, 1 of 1 files at r9.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

acomm/tracker.go, line 407 [r4] (raw file):
s/Which/We/ ... Ack on the other possible ioutil.ReadAlls

Comments from Reviewable

Review status: all files reviewed at latest revision, 2 unresolved discussions.

acomm/request.go, line 33 [r1] (raw file):
Option structs!

Comments from Reviewable

Review status: 9 of 38 files reviewed at latest revision, 1 unresolved discussion.

acomm/request.go, line 33 [r1] (raw file):
Refactored to use an options struct. Kept around the setter functions for convenience.

Comments from Reviewable

Review status: 9 of 38 files reviewed at latest revision, 1 unresolved discussion.

acomm/request.go, line 33 [r1] (raw file):
LGTM

Comments from Reviewable

Reviewed 29 of 29 files at r10.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

acomm/request.go, line 52 [r10] (raw file):
why not just make it a struct instead of a pointer then?

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

acomm/request.go, line 52 [r10] (raw file):
So we don't need to copy data around

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

acomm/request.go, line 52 [r10] (raw file):
Do you mean at the function call? If so thats a premature optimisation that likely has no impact (not to mention could lead to more garbage for the GC ;) ).
Having a pointer arg over plain struct leads to confusion because now we have to explain that it's basically read-only where a plain struct doesn't need the doc.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

acomm/request.go, line 52 [r10] (raw file):
I guess. I feel like we usually use pointers almost everywhere there's a struct though.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

acomm/request.go, line 52 [r10] (raw file):
Changed

Comments from Reviewable

Reviewed 29 of 29 files at r11.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable