Auto json/JSONPlugin should detect lists/tuples

When autojson=True bottle detects only dictionaries which are converted to JSON and proper header is set. May be this same behavior should be true for both lists and tuples.
OS: Linux Mint 19.1 Tessa
Bottle: 0.12.17
Test
from threading import Thread
from time import sleep
from unittest import TestCase

import requests
from bottle import Bottle, run

# https://github.com/bottlepy/bottle/blob/0dd195111621b4db5e9b7d5e5852fab3c6270098/bottle.py#L2011
app = Bottle(autojson=True)

@app.get('/dict')
def dict_view():
    return {'result': 1}

@app.get('/list')
def list_view():
    return ["result"]

@app.get('/tuple')
def tuple_view():
    return "result",

t = Thread(target=lambda a: run(app=a), args=(app,))
t.daemon = __name__ != "__main__"
t.start()

url = 'http://<IP_ADDRESS>:8080'

class AutoJSONTestCase(TestCase):
    @classmethod
    def setUpClass(cls):
        # Wait for web-server to start
        sleep(1)

    def test_dict(self):
        response = requests.get(url + '/dict')
        self.assertEqual(response.status_code, 200)
        self.assertEqual(response.headers.get('Content-Type'), 'application/json')
        self.assertEqual(response.text, '{"result": 1}')
        pass

    def test_list(self):
        response = requests.get(url + '/list')
        self.assertEqual(response.status_code, 200)
        self.assertEqual(response.headers.get('Content-Type'), 'application/json')
        self.assertEqual(response.text, '["result"]')

    def test_tuple(self):
        response = requests.get(url + '/tuple')
        self.assertEqual(response.status_code, 200)
        self.assertEqual(response.headers.get('Content-Type'), 'application/json')
        self.assertEqual(response.text, '["result"]')

A REST API should never return lists (JSON arrays) directly, without a surrounding object. There were several security problems related to arrays in the past, and it is considered bad practice for semantic reasons as well. If you are designing your own API, avoid raw lists. Return an object with some context and a results field or something similar. If you are implementing an existing API and do not have a choice, you have to do the JSON part yourself for these routes. The JSONPlugin does not really do anything special. It just sets a Content-Type and returns the result of json.dumps(data). That can be done in two extra lines of code without the plugin.

I understand those two extra lines of code might not be worth reopening the discussion, but for the record Flask dropped their equivalent security feature preventing raw lists JSON serialization.
Rationale was: browsers vulnerable to raw JSON lists are:

are ancient legacy with rare usage, so only applications still supporting those should be concerned about this. The bulk of framework users don't need to be worried nor warned about it.
are vulnerable to worse RCE exploits, so it's not like this feature can provide any safety to such browsers

See:

https://flask.palletsprojects.com/en/latest/security/#json-security
https://github.com/pallets/flask/issues/248
https://github.com/pallets/flask/pull/1671

Also, I can't agree on the point about semantics. For paginated item lists, wrapping response data with a pagination object is a must, but for small item lists a raw list is way more semantic than the widespread{"d": [actual-data]} practice. I feel this practice was widely adopted due to the past relevance of the exploits it prevented, but stayed out of FUD.
That said, I am not pushing for any change in bottle.py, just wanted to note here that this feature is confusing, outdated, somewhat undocumented and definitely not saving any children.


SVG Generator

Related Issue

This issue was related to adding a feature. An SVG generator has been added.

Closes: #1798
Describe the changes you've made
I have added a new project card to script.js
I have added svg-generator.html to the public folder and svg-generator.css to css folder in assets and svg-generator.js to the js folder in assets.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
A clear and concise description of it.
NA
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] New and existing unit tests pass locally with my changes.

Screenshots

@priyaastha nice work done


LXD init fails to parse ceph network config

Required information

Distribution: Debian
Distribution version: 10.4
The output of "lxc info" or if that fails:

Kernel version: 4.19.0-6
LXC version: 4.2
LXD version: 4.2
Storage backend in use: Ceph Octopus

Issue description
This is the same issue as was reported in #7137. When using lxd init to create a new config, it fails to properly parse the LXD cluster config in /etc/ceph/ceph.conf.
Error: Failed to create storage pool 'remote': Failed to run: ceph --name client.admin --cluster ceph osd pool create lxd 32: unable to parse addrs in '[v2:<redacted_ip>:3300/0,v1:<redacted_ip>:6789/0] [v2:<redacted_ip>:3300/0,v1:<redacted_ip>:6789/0] [v2:<redacted_ip>:3300/0,v1:<redacted_ip>:6789/0]'
[errno 22] error connecting to the cluster

Contents of /etc/ceph/ceph.conf:
[global]
	fsid = 6879c73a-af0d-11ea-a390-3a08b21a8a17
	mon_host = [v2:<redacted_ip>:3300/0,v1:<redacted_ip>:6789/0] [v2:1<redacted_ip>:3300/0,v1:<redacted_ip>:6789/0] [v2:<redacted_ip>:3300/0,v1:<redacted_ip>:6789/0]

I'm reasonably certain the ceph client config is correct since it works with the v15 (Octopus) ceph client.
Worth noting that if I use a v12 ceph client I get the same error, so the ceph client LXD is using could be the issue here?
Steps to reproduce

Create ceph cluster (Octopus on Debian 10). Add client config and verify with ceph status.
Run lxd init
Select Remote storage, ceph backend, try to create new pool.

This error does not originate from LXD but from the Ceph client itself.
The LXD snap uses the Ubuntu 18.04 version of the Ceph client which is at version 12.2.13.
You can configure the snap to use an alternative config path of /var/snap/lxd/common/ceph where you could put a config file with a syntax that can be understood by that version.
I'll move that issue and re-title it so we may look at a way for the snap to use the host binaries for ceph/rbd but this may end up being quite tricky to do in a way that works properly on all distros.


Remove the partition info from the consuming segment ZK metadata

Description
For issue: #6029
Do not persist the partition info to the consuming segment ZK metadata because it might not reflect the correct segment partitioning when the data is not partitioned correctly in the stream, or the partitions changed during the consumption. Persisting the partition info could cause segment to be mis-pruned, thus cause wrong result.

@mcvsubbu The segment partition pruning for consuming segment will happen on server side instead of broker side. Yes there will be some overhead, and we need to measure the impact with a high QPS use case.

After some benchmark we found this change might cause some performance degradation for extremely high QPS use cases. Closing this PR and filed #6078 as a work-around without overhead.


test

Hi @dcabanillas I'm not quite sure what you want me to do with this PR? It is not clear what it is for. Can you please explain? Thanks!

Sorry it was an error.
On Fri, Dec 2, 2016, 21:47 Brian Christner<EMAIL_ADDRESS>wrote:

Hi @dcabanillas https://github.com/dcabanillas I'm not quite sure what
you want me to do with this PR? It is not clear what it is for. Can you
please explain? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vegasbrianc/docker-hello-world/pull/5#issuecomment-264558623,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABVg4dd3a9UKOom6A74SaJm-wUncsPPQks5rEIP0gaJpZM4LCtE9
.

No problem and thanks again.


python3 installed in Dockerfile

Needed for python3 chung script

We're entangling the orient docker image with needs of the Filecoin spec here. That's fine as an expedient measure, but let's try to refactor later.


Clarify bit shift hook behavior

INT.shl and INT.shr use shift for implementation. This PR simply adds extra information to docs/hooks.md about how the bit-shifts behave; left shifts are logical while right shifts are arithmetic.

Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

[ ] Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
[ ] Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
[ ] Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
[ ] Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

It's possible to replace both INT.shl and INT.shr with a single hook e.g. INT.shift. First argument is the value, second argument is the amount to shift by (negative shifts right arithmetic, and positive shifts left logical). As it stands now, both hooks use the same underlying Haskell function anyway, just with an extra negation of the second argument.

Combining INT.shr and INT.shl into a single hook is not the direction to go due to potential performance and backend synchronization issues.


Address 0x782A2B258568A85ee429e845E0770d7a4130280C showing 0 boost

Address 0x782A2B258568A85ee429e845E0770d7a4130280C is showing no boost while they are in multiple vaults on arbitrum, but none on ethereum.
REFERENCE: https://api.badger.finance/v2/accounts/0x782A2B258568A85ee429e845E0770d7a4130280C?chain=arbitrum
The API is picking up balances, but the boost file seems to have nothing for them:

Similar issue with address 0x72eA986B93b63bc0e0d146b850003C2e6FF187aC
Showing 0 boost on the api but in the badger-boosts file the data is correct
 "0x72ea986b93b63bc0e0d146b850003c2e6ff187ac": {
            "boost": 10,
            "nativeBalance": 1542.85,
            "nonNativeBalance":<PHONE_NUMBER>4376235,
            "stakeRatio": 0.006242027875169491,
            "multipliers": {
                "0x4591890225394BF66044347653e112621AF7DDeb": 0.009441503440203223,
                "0x60129B2b762952Dfe8b21f40ee8aa3B2A4623546": 0.008064937144835662,
                "0xBA418CDdd91111F5c1D1Ac2777Fa8CEa28D71843": 0.019204000340631987,
                "0xFc13209cAfE8fb3bb5fbD929eC9F11a39e8Ac041": 0.025372154162070584
            }
        },

Fixed - api issue


tests(tools): add tests against kong.tools.http.parse_directive_header()

Summary

Checklist

[x] The Pull Request has tests
[ ] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference
From https://github.com/Kong/kong-ee/pull/9910

Rebased on master and added an extra test


How to use JumpAssist/PcodeInject?

I'm working on a project that involves some jump tables that are giving the decompiler some trouble. I've been reviewing jumptable.cc to figure out how the decompiler recognizes  jumptables, and I saw the 2 common JumpTable models, plus the 2 models used to assist the decompiler -- override and jumpassist.
I've messed with the override scripts, and from what I can tell, right now the info you can feed the decompiler via the "override" namespace is just the indirect jump's location, and the case address & names. The decompiler gets no information about the jump table itself that's being read from, and it seems to confuse it a fair bit on some functions where it can't then recover the jump table.
As such, I wound up looking into the jumpAssist method, and it looks far more powerful, but there's not much documentation about how to use it effectively. I've seen that the JVM JumpTable analyzer seems to add 'switchassist' pcodeops using the pcodeinject library, but documentation on the way both pcodeinject and jumpassist work seems to be sparse.
Is there any chance anyone could give me a quick primer on how I would go about writing a script that would leverage pcodeinject to add jumpassist pcodeops, and how to configure jumpassist fixups in the .cspec file?
Thanks!

Realized some stuff right after posting this that I was missing, namely the extent of documentation in the JVM inject library. Marking as closed.


Resource not found

I have added CTFeedback to my pod file and when I build, this is the error I am getting.
error: Resource "/Users/....../Library/Developer/Xcode/DerivedData/......../Build/Products/Debug-iphonesimulator/CTFeedback/CTFeedback.bundle" not found. Run 'pod install' to update the copy resources script.
I have cleaned, built and even run 'pod install' number of times but not success. Please help me. Thanks

@saintjab
I confirmed the error.
I'm going to fix it.

@saintjab
I mistook testing steps yesterday.
The following steps succeeded today.

Creating Podfile
pod install
Opening MyProject.xcworkspace

Please tell me your Podfile and installed Pods folder of CTFeedback structure.

@rizumita
Thanks for the help. I have tried that but the error is still there though.

@saintjab
Please tell me versions of Xcode and CocoaPods, and contents of Podfile.
If you can create a minimum sample app, give me the sample app files.

@rizumita , sorry for the late reply. Find attached a minimum sample app.
Sample.zip

@saintjab
The error occurred with CocoaPods ver.1.0.0 beta.6 but it didn't ver.0.39.0.
It seems like Incorrect Paths in Copy Pods Resources phase with use_frameworks! · Issue #4500 · CocoaPods/CocoaPods.

@rizumita thanks for the info. I have now downgraded my CocoaPod and its working now. Good work for spotting that.


feat(oci): Implement directory handler pushing

Prerequisite checklist

[x] Read the contribution guidelines regarding submitting new changes to the project;
[x] Tested your changes against relevant architectures and platforms;
[x] Ran make fmt on your commit series before opening this PR;
[ ] Updated relevant documentation.

Description of changes

There are currently two OCI specifications used. The containerregistry
implementation and the opencontainers implementation.
containerregistry was used to interface with registries whilst the
opencontainers specification was used to save data.
As part of pulling, the translation from containerregistry to
opencontainers was already implemented. The reverse is needed for
pushing.
This commit implements two interfaces for interacting with
containerregistry functions related to pushing.
Needs #660 in order to be tested properly and #630 because of a wrong permission inside the oci directory (no write).
Depends-On: #660
Depends-On: #630

I will rebase after the two dependencies are merged. Let me know when they are in.


Updating Raven Notebooks

-changes filenames to match with what is currently in the shared box
-adds if-else statements to run raven based on operating system (Windows)
(Let me know if there is a mistake in this PR because I see that my fork was behind arfc/pride master at the time of creating this)

Got it


Fix Button padding

Fix horizontal padding for Button in code so it match whats defined in Figma.
Doublecheck ToggleGroup.Item has padding has the same padding as Button.

Turns out it was ToggleGroup.Item which had the wrong paddings.


Replace dead G+ link w Internet Archive capture

Fortunately there seems to be at least 1 archive of this post daring to October 2018, and while the last G+ UI hides all comments by default, a relevant comment by Dianne Hackborn acknowledging and explaining the bug is visible in the capture.
Here it is for convenience :
https://web.archive.org/web/20181030095832/https://plus.google.com/+AndroidDevelopers/posts/94jCkmG4jff

Ohhh, nice catch! Big thanks!

Big thanks @Younes-L :) did not know this could be found somewhere online! :) Pity my comment where I identified the bug is gone :(..I think may have it just in my local copy of the G+ takeout..

Welcome x)


docs/guides/06_shared_state.ipynb fails

Steps to reproduce the problem
Run docker compose
Run jupyter notebook
Change the localhost to gateway in cell 2
Change the name to title in cell 4
Run docs/guides/06_shared_state.ipynb
What is the current behavior?
It fails.  The job.logs() returns
'/tmp/ray/session_2023-05-01_13-14-20_727443_1/runtime_resources/working_dir_files/_ray_pkg_f3eb27d45c4a60ff/job_with_state.py:10: DeprecationWarning: Decorator `run_qiskit_remote` is deprecated. Please, consider using `distribute_task` instead.\n  @run_qiskit_remote(state=state_handler)\n/tmp/ray/session_2023-05-01_13-14-20_727443_1/runtime_resources/working_dir_files/_ray_pkg_f3eb27d45c4a60ff/job_with_state.py:16: DeprecationWarning: Decorator `run_qiskit_remote` is deprecated. Please, consider using `distribute_task` instead.\n  @run_qiskit_remote(state=state_handler)\n/tmp/ray/session_2023-05-01_13-14-20_727443_1/runtime_resources/working_dir_files/_ray_pkg_f3eb27d45c4a60ff/job_with_state.py:22: DeprecationWarning: Calling `with serverless: ...` is deprecated. Please, consider using `with serverless.context(): ...`\n  with serverless:\n2023-05-01 13:51:20,265\tWARNING worker.py:1313 -- File descriptor limit 1024 is too low for production servers and may result in connection errors. At least 8192 is recommended. --- Fix with \'ulimit -n 8192\'\n/home/ray/anaconda3/lib/python3.9/site-packages/ray/_private/worker.py:995: UserWarning: len(ctx) is deprecated. Use len(ctx.address_info) instead.\n  warnings.warn("len(ctx) is deprecated. Use len(ctx.address_info) instead.")\nTraceback (most recent call last):\n  File "/tmp/ray/session_2023-05-01_13-14-20_727443_1/runtime_resources/working_dir_files/_ray_pkg_f3eb27d45c4a60ff/job_with_state.py", line 23, in <module>\n    result = get(other_func_with_state(42))\n  File "/home/ray/anaconda3/lib/python3.9/site-packages/ray/_private/client_mode_hook.py", line 105, in wrapper\n    return func(*args, **kwargs)\n  File "/home/ray/anaconda3/lib/python3.9/site-packages/ray/_private/worker.py", line 2380, in get\n    raise value.as_instanceof_cause()\nray.exceptions.RayTaskError(ConnectionError): \x1b[36mray::other_func_with_state()\x1b[39m (pid=907, ip=<IP_ADDRESS>)\n  File "/home/ray/anaconda3/lib/python3.9/site-packages/redis/retry.py", line 46, in call_with_retry\n    return do()\n  File "/home/ray/anaconda3/lib/python3.9/site-packages/redis/connection.py", line 699, in <lambda>\n    lambda: self._connect(), lambda error: self.disconnect(error)\n  File "/home/ray/anaconda3/lib/python3.9/site-packages/redis/connection.py", line 987, in _connect\n    raise err\n  File "/home/ray/anaconda3/lib/python3.9/site-packages/redis/connection.py", line 975, in _connect\n    sock.connect(socket_address)\nOSError: [Errno 113] No route to host\n\nDuring handling of the above exception, another exception occurred:\n\n\x1b[36mray::other_func_with_state()\x1b[39m (pid=907, ip=<IP_ADDRESS>)\n  File "/home/ray/anaconda3/lib/python3.9/site-packages/quantum_serverless/core/decorators.py", line 202, in wraps\n    return func(*args, **kwargs)\n  File "/tmp/ray/session_2023-05-01_13-14-20_727443_1/runtime_resources/working_dir_files/_ray_pkg_f3eb27d45c4a60ff/job_with_state.py", line 18, in other_func_with_state\n    state.set("in_other_job", {"other_k": seed})\n  File "/home/ray/anaconda3/lib/python3.9/site-packages/quantum_serverless/core/state.py", line 89, in set\n    return self._redis.set(key, json.dumps(value))\n  File "/home/ray/anaconda3/lib/python3.9/site-packages/redis/commands/core.py", line 2302, in set\n    return self.execute_command("SET", *pieces, **options)\n  File "/home/ray/anaconda3/lib/python3.9/site-packages/redis/client.py", line 1255, in execute_command\n    conn = self.connection or pool.get_connection(command_name, **options)\n  File "/home/ray/anaconda3/lib/python3.9/site-packages/redis/connection.py", line 1442, in get_connection\n    connection.connect()\n  File "/home/ray/anaconda3/lib/python3.9/site-packages/redis/connection.py", line 704, in connect\n    raise ConnectionError(self._error_message(e))\nredis.exceptions.ConnectionError: Error 113 connecting to redis:6379. No route to host.\n'

What is the expected behavior?
It should run without error.

I wonder if we should rewrite this or add the redis in the docker compose.

Gone in https://github.com/Qiskit-Extensions/quantum-serverless/pull/481


Add support for Microsoft Edge via Edge Diagnostics Adaptor

We at Microsoft has now made it possible to debug Microsoft Edge via Edge Diagnostics Adaptor over the Chrome Debugging Protocol.
It has a protocol.json file which could be fetched from the repo at https://github.com/Microsoft/edge-diagnostics-adaptor/blob/master/protocol.json, or we could add an HTTP endpoint to fetch it from something like /json/protocol directly from the adaptor.
We think it cold be exciting to have this library working with multiple browsers supporting the Chrome Debugging Protocol.
Are you interested in collaboration?

This sounds interesting! I'll play around with the adaptor as soon as I manage to get a Windows 10 box up and running.
Anyway, if the adaptor behaves exactly as the original Remote Debugging Protocol this library should already work with it. The only difference would be the protocol.json, but now it is possible to provide a custom descriptor at initialization. I'll try this as a first step.
Also, related to #17, I was trying to add support for native ES6 promises to the current API; basically a promise is returned when the callback is omitted. I believe that maintaining both paradigms may be useful. This feature is mostly done, I'll merge it soon.

Great! We also released https://github.com/microsoft/edge-diagnostics-launch, which is a node wrapper that fetches the adaptor binary and launches Edge with a given URL. That should make integration even easier.
I'll give the feeding of the protocol.json a spin right away.

Works perfectly. Here's a GIST that shows an example of chrome-remote-interface working with Edge.
https://gist.github.com/auchenberg/355b77886a5b93427d2ff6c592f4b064

Hmm, I don't seem to be able to make it work, while the HTTP API works I cannot connect to the WebSocket. Here's what I tried:

start Edge;

start EdgeDiagnosticsAdapter.exe:
 Edge Diagnostics Adapter
 Could not set ACL to allow access to IE EPM or Edge.
 Error Code: 1332
 You can set the ACL manually by adding Read & Execute permissions for 'All APPLICATION PACAKGES' to each dll.
 Proxy server listening on port 9222...

start chrome-repl and EdgeDiagnosticsAdapter.exe prints:
 DEBUG MESSAGE: Attempting to attach to 64 bit tab
 Connection rejected for: /devtools/page/E8A36086-8AFC-4300-AC94-8322FB2DC812
 [2016-04-24 20:01:41] [error] Handshake ended with HTTP error: 400

I'm trying this in a (64 bit) VM. I get similar results with a 32 bit laptop, the difference is that here I don't get the DEBUG MESSAGE: Attempting to attach to 64 bit tab message.

@cyrus-and I opened an issue on the adapter, https://github.com/Microsoft/edge-diagnostics-adaptor/issues/19

[Cross posting from the Edge adapter issue 19]
@cyrus-and
Hmmm. Honestly not sure what happened here. I believe that error code basically means it couldn't find the builtin name  'ALL APPLICATION PACKAGES' msdn. But that name should exsist on Win10 (and down to Windows 8). If you:

Find the proxy.dll and proxy64.dll
Right click on the dll and properties
Go to the Security panel
Edit
Add..
Make sure you have the location to your local machine name (and not a domain etc.)
Search for ALL APPLICATION PACKAGES (type it in the box)
Check Names this should resolve the name and underline it (if this fails we have a problem!)
Ok OK, OK
Now try it...

Fwiw and this is probably unrelated but the binaries should be somewhere local and not ran from a share.

@auchenberg I finally managed (thanks to @andysterland) to fix this.
After some very brief testing, the support for Edge seems to work properly. :) I'm going to bump a new release and push it on NPM. Let me know if you come across any issues.

Yay 🎉 Big day!
We'll let you know if issues arise. Thanks for the help!


Call AnimatedSampler.builder from Layer.addToScene to update every frame

This approach might have problems that I'm not aware of, but it removes the need to call the protected stopRecordingIfNeeded method and ensures that the builder is called for every frame in which the rastered image changes.

Thanks for the awesome fix!


inconsistency in type inference on union of function types

TypeScript Version:
1.8.10 (seems, that other are affected as well)
Code
//TYPE DOMAIN
type T1 = (arg: string|number) => string;
type T2 = (arg: string) => string;

declare var fn: T1 | T2;

var res = fn('x'); // error TS2349:
                   // Cannot invoke an expression
                   // whose type lacks a call signature.

// VALUE DOMAIN
const f1 = (arg: string|number) => 'x';
const f2 = (arg: string) => 'y';

declare var a: boolean;
const fn1 =  a ? f1 : f2
const fn2 = !a ? f2 : f1

var res1 = fn1('x'); // Success, fn1 inferred as (arg: string|number) => string
var res2 = fn2('x'); // Success, fn2 inferred as (arg: string) => string

Expected behavior:

Code in type domain at least should compile.
In both domains the correct type for the function should be (arg: string) => string and should not be dependent on the order of union members / conditional branches.

Actual behavior:

Code in type domain fails to compile with error TS2349: Cannot invoke an expression whose type lacks a call signature.
In value domain the type is dependent on the order of conditional branches

It would be nice if
string & number = never  // type error

All incomatible primitive types should produce never when intersected.
If never detected in any input place it means type error.
This behavior would allow expressing the following function union type:
type F1 = (a: A1, b: B1, c: C1) => R1
type F2 = (a: A2, b: B2) => R2

type F3 = F1 | F2; // (a: A1 & A2, b: B1 & B2, c: C1) => R1 | R2

thus
string & (string | number) = (string & string) | (string & number) = string | never = string

which allow assigning the correct type for the original issue.

Code in type domain at least should compile.

See #4612

Duplicate #10025

All incomatible primitive types should produce never when intersected.
However, unless --strictNullChecks is enabled, all primitive types are somewhat compatible, as:
const X:string&number = undefined; is valid.
So when --strictNullChecks is enabled string&number = never, else string&number=undefined.

For the "real issue":
Shouldn't UNION of function types work like that:
(A1:T1_1,A2:T1_2,...)=>R1|(A2:T2_1,A2:T2_1,...)=>R2 = (A1:T1_1&T2_1,A2:T1_2&T2_2,...)=>R1|R2

And:

in case the count of arguments differs, the types of the missing arguments is assumed as any:

(A1:T1_1)=>R1|(A1:T2_1,A2:T2_2)=>R2 = (A1:T1_1&T2_1,A2:any&T2_2)=>R1|R2

However,

in case an argument is optional in only one function, it is not optional in result
in case an argument is optional in both functions, it is optional in the result
For the Intersection function type it should be the same, except for the return type:

(A1:T1_1,A2:T1_2,...)=>R1&(A2:T2_1,A2:T2_1,...)=>R2 = (A1:T1_1&T2_1,A2:T1_2&T2_2,...)=>R1&R2

Also, In my opinion, the 'VALUE DOMAIN' - Example from the initial report is working wrong.
// VALUE DOMAIN
interface I1 {
	X:number;
}

interface I2 {
	Y:number;
}
const f1 = (arg: I1|I2) => {

};
const f2 = (arg: I1) => {
	arg.X = 42;
};

var x:boolean = doSomeSomethingAndReturnBoolean();
const fn1 = x?f1:f2;

var res1 = fn1({Y:123}); // compiles, but at runtime fn1 = f2, which expects I1 as argument!!!

I expect, that the resulting fn1 can only be invoked with an I1 as argument, but not an I2, as it may be of type (arg:I1)=>void.


b

@hofuchi Thanks for PR! Sorry, please check latest master about back handler, it is already there You are adding listener within render() that is not correct...

sorry Ignore this


Add District of Columbia into the list of states.

Add "District of Columbia" as a new entry in the list of states on the project details page.
Update the <USStateSelect /> component to include the "District of Columbia" as a selectable option.

Changes merged to main along with https://github.com/pnnl/Quality-Install-Tool/pull/251


@mzikherman - Use moment to format date, instead of new Date

Closes #1105
moment().format() returns a date like: "2017-03-28T10:51:49-04:00"
@sperle does that work for you?

LGTM

🍏

Actually looking at https://getstarted.sailthru.com/audience/managing-users/set-variables-on-users/#Date_andTime_Formats maybe a UNIX date is safer

so I THINK if we do something with time, the var has to end in _time (which
is fine! but then we need to rename that field we're passing). Otherwise,
let's do YYYYMMDD
On Tue, Mar 28, 2017 at 11:39 AM, Charles Broskoski <
<EMAIL_ADDRESS>wrote:

Actually looking at https://getstarted.sailthru.
com/audience/managing-users/set-variables-on-users/#Date_andTime_Formats
maybe a UNIX date is safer
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/artsy/force/pull/1117#issuecomment-289811156, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ALOzKHB5o4vdTAo3E-I9y1xp9Up47QC7ks5rqSmXgaJpZM4MrwLY
.

--
[A.] Sara Perle
Artsy http://artsy.net/ | 401 Broadway, 25th Floor
New York, NY 10013
<EMAIL_ADDRESS>            @saperle <http://twitter.com/saperle>

+1<PHONE_NUMBER>

Ah, yes good call. Will rename the field.

ok @mzikherman i think this is good to go


C++ API throws exception from destructor that cannot be caught

Example:
#include <stdio.h>
#include <stdlib.h>
#include <clingo.hh>

using namespace Clingo;

Logger logger = [](Clingo::WarningCode, char const *message) {
	std::cerr << message << std::endl;
};

int main(int argc, char **argv)
{
    try {
        Control ctl{{argv+1, size_t(argc-1)}, logger, 20};
        {
			Backend backend = ctl.backend();
			//do something invalid
			std::vector<id_t> elements;
			backend.theory_atom(1, 1, elements);
			std::cerr << "finished using Backend" << std::endl;
        }
	std::cerr << "Backend out of scope" << std::endl;
    } catch (...) {
        std::cerr << "caught exception" << std::endl;
    }
    std::cerr << "end" << std::endl;
}

This prints:
finished using Backend
terminate called after throwing an instance of 'std::logic_error'
  what():  Unknown term '1'
Aborted

I made an intentionally invalid call to the backend.  When the Backend goes out of scope its destructor throws an exception, but I'm unable to catch it.
I might be missing something about what I could do differently, but when I search for information related to this I find advice that destructors should not throw exceptions.

gdb showed it going into throw std::logic_error(msg) in this code, called from the Backend destructor:
inline void handle_error(bool ret) {
    if (!ret) {
        char const *msg = clingo_error_message();
        if (msg == nullptr) { msg = "no message"; }
        switch (static_cast<clingo_error_e>(clingo_error_code())) {
            case clingo_error_runtime:   { throw std::runtime_error(msg); }
            case clingo_error_logic:     { throw std::logic_error(msg); }
            case clingo_error_bad_alloc: { throw std::bad_alloc(); }
            case clingo_error_unknown:
            case clingo_error_success:   { throw std::runtime_error(msg); }
        }
    }
}

inline Backend::~Backend() { // NOLINT
    if (backend_ != nullptr) {
        Detail::handle_error(clingo_backend_end(backend_));
    }
}

My colleague @mbalduccini figured out that a cause of the problem is that C+11 defaults all destructors to noexcept(true), and my program can be made to work (throw exception rather than terminating) if clingo.hh is modified to declare noexcept(false) as in:
 ~Backend() noexcept(false);

and also for ~SolveHandle and ~ProgramBuilder for good measure.
As far as I can tell this is still not recommended as it could cause a resource leak, but it's an improvement.

I'll have a look.


Thrown undefined bindings promise does not carry the full stack in the error

Environment
Knex version:0.95.6
Database + version:mysql 5.6
OS:macOS
This is a big issue that ends up wasting a lot of time fishing in production code for a specific query, rendering any error reporting tools next to useless.
I deliberately make this void line to force an uncaught promise:

I then have an uncaught promise handler, which should contain a full stack in the 'reason' object:

But it doesn't, it only goes as deep as builder-interface-augmenter.

And looks like the asyncStackTraces is useless in this situation because the code doesn't even get that far.

@kibertoad thoughts?

@kibertoad I understand you're a busy guy, but just your 5 cents on this would be appreciated.

never mind I just realised why this is an issue, it's due to #2253

reopening because this is still a problem, and the workaround I tried for some reason either never worked or doesn't work anymore. I've moved to postgres dialect and it's still present there. When I run into this issue it can literally wipe hours away while I hunt down the original code due to a useless stack trace. Can this please be elevated to issue number one it's such a huge pain with knex.

this is hugely relevant.
I have the same type of errors all the time and i need to snipe the query each time.
To me it happens every time a wrong column is referenced or a wrong type of input is given, really annoying


Ability to Turn on Guest user/license type greyed out

The article mentions "After the Guest user/license type is turned on". However, the ability to turn on Guest user/license type for Teams is greyed out and shows to be deprecated. This is the only setting I am unable to configure when following these instructions, and I am unable to get the ability to add Guest users in Teams to work.
Please assist. Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6f1d577c-1360-c2c1-a850-9ac6a941ec2f
Version Independent ID: 346e43d4-22e0-2800-b80d-9fbdac324f75
Content: Manage guest access in Microsoft Teams
Content Source: Teams/manage-guests.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: rramesan

@ Thank you for submitting this Feedback.
From my understanding this is a duplicate issue from you and the issue of not being able to add guests to teams has been resolved. The duplicate issue is https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/739#issue-357492670 If the issue is not resolved please re-open this issue.


Use labels instead of separate metrics

Currently there is a separate set of similar metrics for each deployment kind:
k8s_image_availability_exporter_cronjob_*
k8s_image_availability_exporter_daemonset_*
k8s_image_availability_exporter_deployment_*
k8s_image_availability_exporter_statefulset_*
So to monitor missing images I have to use 4 different queries instead of one. Why not simplify it by using a kind label instead?

Hello, @tony2001. Thanks for opening a PR.
This will be a breaking change, but I don't hesitate to accept.

The README.md file should be changed accordingly.
There are prometheus rules in the chart that use metric names in queries.
Could you please sign your commit with the following command? git rebase HEAD~1 --signoff

P.S. This is a surprise for me that we do not have unit tests for metrics. It would be cool if you could add one, but I understand that for this PR it is out of scope.

OK, check it out again pls.

@tony2001 thank you for the contribution.


xcode_backend.sh

Getting the below error message when using this extension on Azure Pipelines if anybody has any idea.
/bin/sh: /Users/runner/fvm/versions/stable/packages/flutter_tools/bin/xcode_backend.sh: No such file or directory
    Command PhaseScriptExecution failed with a nonzero exit code

This is the contents of my Generated.xcconfig
// This is a generated file; do not edit or check into version control.
FLUTTER_ROOT=/Users/runner/hostedtoolcache/Flutter/3.3.9/macos/flutter
FLUTTER_APPLICATION_PATH=/Users/runner/work/1/mobile_ui
COCOAPODS_PARALLEL_CODE_SIGN=true
FLUTTER_TARGET=lib/main.dart
FLUTTER_BUILD_DIR=build
FLUTTER_BUILD_NAME=2022.2.1
FLUTTER_BUILD_NUMBER=81
EXCLUDED_ARCHS[sdk=iphonesimulator*]=i386 arm64
EXCLUDED_ARCHS[sdk=iphoneos*]=armv7
DART_OBFUSCATION=false
TRACK_WIDGET_CREATION=true
TREE_SHAKE_ICONS=false
PACKAGE_CONFIG=.dart_tool/package_config.json

I have even added the below script to the pipeline to create the directory for Flutter FVM.
mkdir -p $HOME/fvm/versions/stable cp -a $(FlutterToolPath)/. $HOME/fvm/versions/stable/

Hi, the issue is related to XCode and how it's configured and not with this extension.
Please read the links, (if these links don't help then Google search or Flutter's Github might)

StackOverflow issue.
Flutter's issue


Show same error message for invalid email & invalid password

https://www.pivotaltracker.com/story/show/149172459
After trying a couple different approaches (including extending out a whole new LoginForm class), I found that there's actually a simple config change for this :)

set USER_SHOW_USERNAME_EMAIL_DOES_NOT_EXIST = False, which turns off specific error messages for invalid email vs. invalid password, and just shows one message ('Incorrect Email and/or Password') instead.

Nice find.


No Joiner in Model File

I've downloaded several whisper model file like sherpa-onnx-whisper-large-v3.tar.bz2 but No Joiner file exist in Model File

That is expected. Please see our doc for usages.
Hint:
https://k2-fsa.github.io/sherpa/onnx/pretrained_models/whisper/large-v3.html


Quark's Tallow not showing as pig drop

Is enabled & working in-game, yet there's no JEI integration.

Quark adds the tallow drop not as part of the loottable but instead injects the drop during the LivingDropsEvent. see here
I'll add the tallow drop in the next update.

Fixed as of version 1.1.4. Release has been submitted to Curseforge.


[release]<EMAIL_ADDRESS>(#6196)

build(release weex): ignore the file path of entries

[release]<EMAIL_ADDRESS>

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[ ] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[ ] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Codecov Report

Merging #6512 into dev will not change coverage.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 230c6ae...c628103. Read the comment docs.


Issue while rotating Image after clicking from camera(AndroidScannerDemo)

While i am rotating image after clicking then it didn't scan and i am not able to go cropping screen. Please provide some solution.

+1


Pyu cities: pre-release missing data

Bug description
Given the large amount of new metadata added for libraries, I decided to do a check between the sample and library tables to make sure we are not missing any library meta information. I'll record here what is missing. I calculated this using the script called prerelease-validation.R present on branch prerelease-validation
Additional context
No response

libraries_without_samples.csv
samples_without_libraries.csv

With todo/reason comments
libraries_without_samples.csv


(...).every is not a function

Hello,
When dataTables runs the hideEmptyColums.js the code keeps breaking at line 257: Uncaught TypeError: api.columns(...).every is not a function.  Anything I can do I my end?
line 145:  perPage     = _cfgItem( 'perPage'),  //is undefined  with no second parameter.
Thanks,
Mark

Can you make some online demo with issue?


Safari support? freezes

"php": "^7.1.3",
"fideloper/proxy": "^4.0",
"laravel/framework": "5.6.*",
"laravel/tinker": "^1.0",
"tcg/voyager": "^1.1"
Safari Version: 11.1

Database Driver & Version:

Description:
I use most browsers to test my code accordingly. I have no issue with chrome, firefox, or even brave. But with Safari I can not create, update or submit any data when logged in on safari. If I log in with both chrome and safari, I can add a post in chrome and save it. If I try to click submit/save when using safari it loading wheel spins endlessly and the data never gets saved.
Not a major issue for me but if I am building for a client who uses safari, it would be a hassle to have to convince them to use another browser
Steps To Reproduce:

create new project with dummy data
login
access the post
enter title, body, etc
click save and the waiting game begins
refresh when you give up on waiting and check database to find no new post

Yes it seems similar. However, I am experiencing this with everything. In their issue they claimed some bread/data modification works in the dev version, in the stable version I am using there is no working forms.
But works in firefox, chrome, and brave.

Indeed #3001 - As soon there is an empty file field in a form, it will not work in Safari. Just try to add a file and it will work.
I am using my own fork and it now works fine with Safari (I have created a pull-request for this). The controller is the same for BREAD, post and pages, I think.

Closing as https://github.com/the-control-group/voyager/pull/3004 was merged.


Serialize with Relationship

I use Relationship in Serialize.
Article Model:
@JsonApi(type = "articles")
public class Article extends Resource {
    public String title;
    public HasOne<Person> author;
}

Person Model:
@JsonApi(type = "people")
public class Person extends Resource {
    public String name;
}

Use Serialize:
Person people = new Person();
people.setId("2");
people.name = "Test2222";

Article article = new Article();
article.title = "Test111";
article.author = HasOne.create(article, people);

Document.of(article);

moshi.adapter(Article.class).toJson(article);

But my result is:
{"data":{"type":"articles","attributes":{"title":"Test111"},"relationships":{"people":{"data": "type": "people", id: "2"}}}}

people.name is not set!

Seems that it works well according to JSON API 1.0. relationships > people is a Resource Linkage not a Resource. BTW, JSON API 1.0 does not support the behavior to create a batch of resource with relationships between them.
And a workaround is to use moshi.adapter(Resource[].class).toJson(new Resource[] { article, people }); and have server support a client generated id. The idea is, add all resources needs to be created to document and use a client generated id to connect each other.


OapFileFormat Errs exposed From the Daylitest for OAP 0.6

case:  "SELECT * FROM  oap_tpcds.store_sales limit 10"
First err
19/01/25 18:09:47 ERROR SparkSQLDriver: Failed in [SELECT * FROM  200oap_tpcds_200.store_sales limit 10]
scala.MatchError: null
	at org.apache.spark.sql.execution.datasources.oap.OapFileFormat.buildReaderWithPartitionValues(OapFileFormat.scala:153)
	at org.apache.spark.sql.execution.FileSourceScanExec.inputRDD$lzycompute(DataSourceScanExec.scala:308)
	at org.apache.spark.sql.execution.FileSourceScanExec.inputRDD(DataSourceScanExec.scala:297)
	at org.apache.spark.sql.execution.FileSourceScanExec.inputRDDs(DataSourceScanExec.scala:326)
	at org.apache.spark.sql.execution.WholeStageCodegenExec.doExecute(WholeStageCodegenExec.scala:605)
	at org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:131)
	at org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:127)
	at org.apache.spark.sql.execution.SparkPlan$$anonfun$executeQuery$1.apply(SparkPlan.scala:155)
	at org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151)
	at org.apache.spark.sql.execution.SparkPlan.executeQuery(SparkPlan.scala:152)
	at org.apache.spark.sql.execution.SparkPlan.execute(SparkPlan.scala:127)

Second err
OapFileFormat.scala:153:
    meta match {
      case Some(m) =>
       ...
       case None => (_: PartitionedFile) => {
        // TODO need to think about when there is no oap.meta file at all
        Iterator.empty
      }

Change "case None" to "case _" and the error disappears.
However, the amount of data is displayed as 0.
SELECT count(1) FROM  200oap_tpcds_200.store_sales
0
Time taken: 0.367 seconds, Fetched 1 row(s)

Actually there is data in the table. If in the Spark 2.3. can query the data.
ORC, Parquet  have no such errs

Hi,
I have used OAP on YARN and encountered this issue (scala.MatchError: null) as well as catalyst complaining it doesn't support DDL statement for creating indexes.
Your suggestion to add spark.sql.extensions org.apache.spark.sql.OapExtensions to spark-default.conf fixed both those issues. I think you should add this to recommended configuration in user guide.

@agaszmurlo thx for ur feedback, @zhixingheyi-tian we should add spark.sql.extensions org.apache.spark.sql.OapExtensions to our user guide


Bounded channel fully deadlocked when sender is forgotten

A blocked sender loosing interest (i.e. kept alive but no longer polling) leads to a full deadlock: other blocked senders are never re-scheduled when messages are dequeued. This behaviour is surprising and quite the footgun since there is theoretically no obligation to poll a future to completion. AFAIK this is also at odd with what other channels do (tokio::mpsc even goes farther and prevents a deadlock if more senders are forgotten than the nominal capacity -- but this is arguably a less likely scenario).
Fortunately the fix looks trivial: use Event::notify_additional instead of Event::notify and get rid of the extra notification currently sent when a sender is unblocked.

Thanks for the report and investigation! I would accept a PR to fix this.

Funnily enough I have just noticed that PR https://github.com/smol-rs/async-channel/pull/16 (which was never merged) does exactly what I suggested above, so in theory the PR already exists :-)
Its motivations were different though, and the original author of this crate was reluctant, commenting that this may not be a clear win performance-wise. I actually agree: performance will be degraded when the channel is hammered by many senders. But I think we should bite the bullet and accept a degradation in performance in such cases for the sake of correctness. AFAIK, flume, postage and tokio all notify one additional sender each time a slot is freed and thus avoid the potential deadlock.
If you prefer a fresh PR with commit messages more focused on the correctness aspect, please let me know.

Also, I failed to mention this but a similar issue exists when receivers are forgotten, and PR https://github.com/smol-rs/async-channel/pull/16 fixes this as well.

So I went ahead with a fresh PR since the old one had conflicts and anyway I wanted to add tests to confirm that it closes this issue.


ROX-16446: scanner v4 vlun updater

Description
Implementation of a workflow for iterating through the supported versions of ACS and retrieve vulnerability data for each version. This workflow allows us to periodically pull the necessary vulnerability information, ensuring that we cover all supported ACS versions
export.go module calls collection of Claircore updaters, is responsible for downloading vulnerability data. Once the updaters have completed their execution, a JSON blob containing the vulnerability data is generated as a result. This process ensures the retrieval and consolidation of up-to-date vulnerability information through the utilization of the Claircore updaters.
The vuln data json will be uploaded to google storage, currently the bucket is stackrox-dev
Checklist

[x] Investigated and inspected CI test results
[ ] Determined and documented upgrade steps

Testing Performed
Run workflow in the CI
Updated vulns by release version: https://console.cloud.google.com/storage/browser/scanner-v4-test?project=stackrox-dev&pageState=("StorageObjectListTable":("f":"%255B%255D"))&prefix=&forceOnObjectsSortingFiltering=false

@daynewlee this PR seems to have broken action lint. Please fix.


refactor/mapped_addr: remove MappedAddr type

Remove the MappedAddr type.
Change the relavent APIs of MappingContext

This change is

Review status: 0 of 7 files reviewed at latest revision, 4 unresolved discussions.

src/main/service.rs, line 33 [r1] (raw file):

use main::{Bootstrap, Connect, ConnectionId, ConnectionInfoResult, ConnectionListener,
           ConnectionMap, CrustError, Event, PeerId, PrivConnectionInfo, PubConnectionInfo};
use nat::util::ip_addr_is_global;

instead of this, should we just do pub use util::ip_addr_is_global() in nat module and use nat::ip_addr_is_global() ? Becasue that will follow the convention of not specifying function names unqualified if it belongs to a different module (and whole utils does not need to be public {yet})

src/main/service.rs, line 268 [r1] (raw file):

            match MappedTcpSocket::start(core, el, 0, &mc, move |_, _, socket, addrs| {
                let hole_punch_addrs =
                    addrs.into_iter().filter(|elt| ip_addr_is_global(&elt.ip())).map(|elt| common::SocketAddr(elt)).collect();

this appear to be a long line - is it not broken by rustfmt ?

src/nat/mapping_context.rs, line 26 [r1] (raw file):

use get_if_addrs::{self, IfAddr};
use igd::{self, Gateway};
use nat::util::ip_addr_is_global;

only until utils - function names must be module qualified.

src/nat/util.rs, line 68 [r1] (raw file):

/// A replacement for `Ipv6Addr::is_global` while we wait for that to enter stable.
pub fn ipv6_addr_is_global(ipv6: &Ipv6Addr) -> bool {
    // NOTE: This function is incomplete and may return false-positives.

TODO is better searchable/noticeable than Note ?

Comments from Reviewable


120 bug fix result data and error message not getting updated on job execution result recor

PR details
What is the purpose of this pull request? (put an "X" next to an item)

[x] Bug fix

What changes did you make? (Give an overview)
closes #120

fyi @DannyCastroVentura - with Nahuel's help i added Log.result() to store whatever good outcome we might have (string or JSON) into the result record's "Result Data" field:

similarly, Log.error() now properly updates "Error Message" on the same object:

both fields I added to the results's list view for easy reference.
so far, Log.result is not used but I can see us pushing in either JSONs for audits or high level success messages (e.g. "deploy successful (4 dataextensions, 3 automations)")


Roll Flutter Engine from 1cdbebee1901 to f8c420018e6e (4 revisions)

https://github.com/flutter/engine/compare/1cdbebee1901...f8c420018e6e
2024-06-07<EMAIL_ADDRESS>Roll Skia from b7f51dfcc342 to ad3c9f203f4e (1 revision) (flutter/engine#53276)
2024-06-07<EMAIL_ADDRESS>Roll Skia from 5fc83884a619 to b7f51dfcc342 (4 revisions) (flutter/engine#53275)
2024-06-07<EMAIL_ADDRESS>Revert "Widen CPU affinity set." (flutter/engine#53274)
2024-06-07<EMAIL_ADDRESS>Roll Skia from e36110f8b451 to 5fc83884a619 (1 revision) (flutter/engine#53273)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Item Collection: Enhance API

Issue Description
The current prop row takes an array of hashes to generate the list and table displays. This is hard to use and inflexible for future enhancements.
Tech Design Considerations:

Support Children API
Support Headers and Subheaders #216
Options between static, single select and multi select rendering

Issue Type

[ ] New Feature
[x] Enhancement
[ ] Bug
[ ] Other

NOTE: This will be a major version bump.

Tech Design for Item Collection Enhancement
Summary
Tech Design Considerations:

Support Children API
-Proposal: Create ItemCollection Item Component.
Support Headers and Subheaders #216
-This needs more design input & will be implemented later.
Options between static, single select and multi select rendering
-Current: Single Select.
-Proposal: add type prop
Handling column layout #213
-Current: calculates what elements are present on the first has provided in the rows props and forces remaining to align
-Proposal: add requiredElements prop. Looping through each child to determine the longest row could be cost/unreasonable if many children are present. Instead allow consumer to provide the expected layout, with the default to show every possible element. At most, 1 start accessory, 8 displays, 1 comment and 1 end accessory will be displayed.

Item Collection API Enhancement

Maintain breakpoint, listStyles, tableStyles, and onChange props
Deprecate rows prop
Add the following props:

Prop
Type
Default
Description
Consideration

children
node
null
The items to flex between an list item or a table row. (Later will also include headers and subheaders)
1 & 2

type
string
static
This indicates what type of lists/tables to render. Options include 'static', 'singleSelect', 'multiSelect'.
3

requiredElements
shape
{ startAccessory: true, displays: 8, comment: true, endAccessory: true }
Required elements of the collection. This allows to consistent formatting and visual expectation.
3

This component will export the following components: ItemCollection.Item, ItemCollection.Display and ItemCollection.Comment. Later will also export ItemCollection.Header and ItemCollection.Subheader.
Item Component
Summary
This component would handle the rendering of a list item or table row for the ItemCollection. By default, this would render an ListItem with an ItemView as the content. Else it will render a TableRow with the element layout (startAccessory, displays, comment, endAccessory). This component would not handle missing element logic, but provides a clean way to represent an item within the item collection.
Additionally, this component will export the ItemView.Display and ItemView.Comment components as Item.Display & Item.Comment.
React Props:
As a replacement to the rows prop, the pieces of the expected row hash will now be their own prop.

Prop
Type
Default
Description

startAccessory
element
undefined
Element to be placed in the start aligned accessory position.

children
array of elements
undefined
Display elements to be presented.

comment
element
undefined
Comment element to be presented.

endAccessory element
undefined
Element to be placed in the start aligned accessory position.

itemViewStyles
element
{ layout: 'oneColumn', textEmphasis: 'default', isTruncated: false, accessoryAlignment: 'alignCenter' }
The styles to apply to the ItemView when represented as a list item. Styles options are layout, textEmphasis, isTruncated and accessoryAlignment.

QUESTION Stephen & I talked and we both felt the use of children in place of ItemView's displays prop would allow for easier implementation. However we could make this displays and match the implementation of ItemView. Opinions??
QUESTION There will be a customProp display which will be passed down by the ItemCollection. Would exposing it be valuable to consumers attempting to construct their own lists/tables. Or should Item strictly be utilized by ItemCollection? My vote would be to only support ItemCollection Item within ItemCollection. Thoughts??

Implementation:
<Item
  startAccessory={ <Accessory />}
  comment={ <Item.Comment />}
  endAcessory={ <Accessory />}
  itemViewStyles={{ isTruncated: true }}
>
  <Item.Display />
  <Item.Display />
  <Item.Display />
</Item>

Header & Subheader Component
There are some design/behavior aspects that need to be considered and will land this work in a separate PR/tech design.
New Proposed ItemCollection Implementation
Basic Construction Overview
<ItemCollection {...ItemCollectionProps}>
  <ItemCollection.Item startAccessory={} endAccessory={} comment={}/>
    <ItemCollection.Display />
    <ItemCollection.Display />
    <ItemCollection.Display />
  </ItemCollection.Item>
  <ItemCollection.Item />
  <ItemCollection.Item />
</ItemCollection>

Actual Example
# Example
import React form 'terra-item-collection';
import ItemCollection from 'terra-clinical-item-collection';

<ItemCollection
  breakpoint="small"
  type="static"
  tableStyles={{ isPadded: true }}
  listStyles={{ isDivided: true }}
  requiredElements={{ startAccessory: true, endAccessory: true, displays: 3, comment: true }}
>
  <ItemCollection.Item
    startAccessory={<IconAlert />}
    comment={ <ItemCollection.Comment text="Faint red rash appeared at 08-05-2016 13:24:00" />}
    endAcessory={<IconInformation />}
    itemViewStyles={{ isTruncated: true }}
  >
    <ItemCollection.Display icon={<IconPerson />} text="Asif Khan" />
    <ItemCollection.Display text="Care Position: Primary" />
    <ItemCollection.Display text="Room 100A" />
  </ItemCollection.Item>
  <ItemCollection.Item
    endAcessory={<IconInformation />}
    itemViewStyles={{ isTruncated: true }}
  >
    <ItemCollection.Display icon={<IconPerson />} text="John Doe" />
    <ItemCollection.Display text="Care Position: Secondary" />
  </ItemCollection.Item>
</ItemCollection>

+1. This looks really good.
The one concern I do have is providing a controlled Single-/MultiSelect-ItemCollection at all. I'm sure I haven't thought through every scenario, but a majority of the scenarios that I have thought of will require the uncontrolled component. It wouldn't necessarily hurt to continue providing controlled components (in addition to uncontrolled), but it may cause confusion among the consumer base unless we can provide documentation that clearly communicates "These are the scenarios in which using the controlled component is possible." I just fear that that list of scenarios will be pretty short (and not justify the cost of development/maintenance/confusion). Maybe we could start with the uncontrolled version and see what consumers ask for?
Regardless, we should develop a canonical example for maintaining selections that people can reference when building their own components. That may just be the current SingleSelectItemCollection (just in a non-released form? I dunno :man_shrugging:).

Updating requiredElements prop to be
{
startAccessoryRequired: PropType.bool,
displaysRequired: PropType.number,
commentRequired: PropType.bool,
endAccessoryRequired: PropType.bool,
}

After some offline discussions with Tyler, I support his suggestion to not offer a single-/multiselect item collection initially. While I can see value in providing built in selection functionality there is a concern that we don't know enough yet to implement it correctly. In this case, not doing something is preferred to doing something wrong. After we gather some more feedback on consumers using the uncontrolled item collection we can revisit this topic to see if a controlled single/multiselect makes sense. Adding components later would be passive. Removing them if we make a mistake or they aren't used would be non passive.

I will be removing the onChange prop until we decide how we want to move forward with offering an internally state-managed Item Collection component.


suggestion trigger

https://github.com/microsoft/vscode-python/issues/8790

It's already supported by VS Code
see https://code.visualstudio.com/updates/v1_28#_semicolon-as-a-commit-character-for-jsts
LS extension should provide list of commit characters for each item. See commitCharacters in https://code.visualstudio.com/api/references/vscode-api#CompletionItem

LS extension should provide list of commit characters for each item. See commitCharacters in https://code.visualstudio.com/api/references/vscode-api#CompletionItem

how can i use it in settings.json?
i want support ".", "(", "[", "=" on trigger suggestion for python

Python extension should add these characters for appropriate completion items.
For example completions for import, print shouldn't be committed with (, but raw_input or open should be.

Python extension should add these characters for appropriate completion items.

i said them but they said the vscode should do this.

For example completions for import, print shouldn't be committed with (, but raw_input or open should be.

now i cant do these anymore

Closing since the Python extension has reopened the original issue.


Compression accept encoding propagation

grpc-accept-encoding information is now propagated through the metadata

Merged with master. PTAL :)

Down to 9 changed files :)

Comments addressed and some bugs fixed. I've tested it manually over modified versions of the interop server/client. I'll extend the interop tests to exercise the accept-encoding metadata after this PR is merged.
PTAL

I've just changed the name of the PR to reflect its current contents. Over time, bits and pieces of the original one got merged. What remains is just the ability for servers to disable certain algorithms.

Ping. I've just merged against master's HEAD.

Seems causing c test failures. Merge issue?

Yes. Fixed now. PTAL.


adding composer

Please install composer to ~/bin/composer so it does not need sudo privileges to update itself.

i update my commit / pr


Automate the branch entry to version increment workflow

Description
Automate the branch entry to version increment workflow
Issues Resolved
Part of: https://github.com/opensearch-project/opensearch-build/issues/1375
Solves: https://github.com/opensearch-project/opensearch-build/issues/2601
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Strange this works on my local
pipenv run mypy .
Success: no issues found in 323 source files

@prudhvigodithi can you explain what you are trying to do here?
I see you are trying to load a yaml and check the matrix.
While figuring out what is missing and add new entries, but not very clear without the data. Thanks.

@prudhvigodithi can you explain what you are trying to do here? I see you are trying to load a yaml and check the matrix. While figuring out what is missing and add new entries, but not very clear without the data. Thanks.

So @peterzhuamazon in order to trigger the version-increment workflow, we the right branch entries, having these branches, for every branch the a job is created and version increment is performed, now every release one has to raise a PR to add this branch entry.
With this PR this branch entry with be auto updated as part of the manifest workflow [AUTO] Updated input manifests PR, so next time we dont need to manually raise a PR for 2.x, 3.x etc.

I see what you mean so if there is any new branches it will update the versions-increment yml workflow so we dont need to manually raise PR.
Thanks.

Codecov Report

Merging #2602 (b3a536b) into main (d502f4a) will decrease coverage by 0.40%.
The diff coverage is 32.14%.

@@             Coverage Diff              @@
##               main    #2602      +/-   ##
============================================
- Coverage     94.41%   94.00%   -0.41%
============================================
  Files           219      162      -57
  Lines          4462     4307     -155
  Branches         29       19      -10
============================================
- Hits           4213     4049     -164
- Misses          243      258      +15
+ Partials          6        0       -6

Impacted Files
Coverage Δ

src/manifests_workflow/input_manifests.py
85.40% <32.14%> (-13.69%)
:arrow_down:

src/system/temporary_directory.py
64.44% <0.00%> (-28.89%)
:arrow_down:

src/system/os.py
93.75% <0.00%> (-6.25%)
:arrow_down:

...jobs/PromoteArtifactsQualifier_actions_Jenkinsfile

...ts/jenkins/jobs/BuildUploadManifestSHA_Jenkinsfile

tests/jenkins/jobs/DetectDockerImage_Jenkinsfile

tests/jenkins/jobs/BuildManifest_Jenkinsfile

src/jenkins/Messages.groovy

tests/jenkins/jobs/BuildFailureMessage_Jenkinsfile

...rtifacts_actions_OpenSearch_Dashboards_Jenkinsfile

... and 50 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thanks @peterzhuamazon, I have also just removed (commit) - '2.3' from the entry as we are already on '2.4', just an overkill to run again for all 2.3 branches

I’m late to this PR, but it needs more work even if it seems to work. Please followup / open issues accordingly.

What is the ruyaml business here? It looks like there’s now more than one way to read and write YML, please consolidate into one.
There are no tests that ensure that the correct values were added to the workflow in the various cases of major/minor/etc., just that the add method was called.

Hey @dblock for the new YAML library ruamel.yaml I have have added useful information https://github.com/opensearch-project/opensearch-build/pull/2602#discussion_r968867762, please check. I can create an issue to migrate to ruamel.yaml

Created a new issue to use ruamel.yaml https://github.com/opensearch-project/opensearch-build/issues/2614
@dblock @peterzhuamazon @gaiksaya @bbarani


Regions plugin: this.handlers is undefined

Wavesurfer.js version(s):
4.1.0
Code needed to reproduce the issue:
Region plugin doesn't load, check example page:
https://wavesurfer-js.org/plugins/regions.html
When calling this.regions.add(options).
Line 199 of regions/index.js registers this event:
        region.on('remove', () => {
            delete this.list[region.id];
        });

Results in TypeError: can't access property "remove", this.handlers is undefined
Last change to observer: https://github.com/katspaugh/wavesurfer.js/commit/590d9ccc96f6c69090849f2e5cfb4587da647ee5
Looks like removing the lazy creation of handlers object broke the regions plugin.
Found this comment in observer.js: * plugins borrow part of this class without calling the constructor
Can we do something about that without breaking existing plugins? Not calling the constructor doesn't sound very good.
Worst case scenario we revert to what we were doing before.

I've also seen this issue, breaks our React app.

same here broke our app.

Proposed fix, assuming we can't change how plugins extend the Observer class (can we?)
In constructor:
this._handlers = {};
Getter:
get handlers() {
	if (!this._handlers) {
		this._handlers = {};
	}
	return this._handlers;
}

And a setter.
Javascript engines should be able to optimize it, the if branch is only executed once?
That or we revert 590d9cc. It was just code cleanup changes. @thijstriemstra

It was just code cleanup changes.

Well, turns out it changed behavior. Can you start out with a unit test that reproduces the bug and go from there?

Change version in package.json to "wavesurfer.js": "4.0.1"
an then force install node modules with
npm i -f or yarn install --force

@thijstriemstra https://github.com/katspaugh/wavesurfer.js/blob/master/src/plugin/regions/index.js#L122
This code just adds the functions of Observer to Region. It doesn't call the constructor so the properties initialized in Observer constuctor aren't added. In the past handlers was initialized outside of the constructor
I don't know WaveSurfer well enough to know why it's done this way. Why doesn't region just do class Region extends Observer?

Same here: broke our app.

The quick start method of including wavesurfer via unpkg is unversioned and updates automatically, and anyone using this has a broken website right now.

anyone using this has a broken website right now.

Only when using the regions plugin. Pull requests to fix this are welcome.

Only when using the regions plugin.

Spoke too soon, it's also affecting wavesurfer.js core, blah.

Or maybe we should revert 590d9cc. It was just code cleanup changes.

@sundayz please do.

4.1.1 was released and fixes this issue.


Adjusting adding tags to a bunch of commands

Type of Change

[x] Bug fix (non-breaking change, fixes #3640 )
[x] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
Add tags to missing commands
A few of the LS commands were internal commands and don't even need tags because they are not indexed.
Also including rebuild of the index for the Find-DbaCommand.
One minor fix in the manifest for spelling on WhoIsActive command.

About only thing that would likely fail on this one is if I missed space or tab issue...or caused it by updating the file via VS Code....but we will see.

If test passes with no hiccup around changing help I will go ahead and merge to prevent conflicts since this PR has so many files in it.


Allow specifying groups for created users

This PR allows specifying the groups which the created user will be added to.
Non-existing groups will be created. By default users will be assigned to the vcap group.
Additionally bosh_sshers and depending on the sudo: property admin and bosh_sudoers are added aswell.
Our usecase for this feature is wanting to limit access to /var/vcap/* for our added user.

I would also ask if you can please provide a test for this new feature in the user_add_test.go test file.
and other comments.

I will close this now because it's been a long time since there has been a response from the requestor. If you decide to address the recommendations then we can reopen. Thanks.


Need ubuntu version upgrade

Related issues:

https://github.com/ainblockchain/ain-blockchain/issues/1144

Ubuntu upgraded to 22.04 for staging, testnet-prod (spring), and mainnet-prod.


2.0.0

New (OOP) approach
import {$Value} from 'comfortable/$Value'
import {$Number} from 'comfortable/$Number'

$Value("abc").isString()

[ ] Update description, tagline, keywords

ComfortableJS uses Object-oriented programming (OOP) approach to build its libraries: Unlike other similar libraries that use the functional programming approach, for example, the popular Lodash library.

oop, oop-in-javascript, object-oriented-programming, oop-principles, object-oriented


Reconnection

Hello,
I am looking at the "reconnecting" event, and it seems like if I disconnect from my wifi (trying to simulate a internet outage scenario), and wait for a little bit,  the session is disconnected with the following message: "Closing: 3001 - Missed 3 "heartbeat" messages".  After this, I tried to call the connect() again, but I get the following error "TwilioError: Participant disconnected because of duplicate identity".
Is there a way to call connect() without the error? Is there a better way to reconnect after missing the 3 heartbeats?  I am basically looking for a way to reconnect after a longer period of network issues.
Thank you!

Thanks for the issue @gauravshrestha!
When a pariticpant loses their network connection, it can take up to 30 seconds for them to actually be removed from the room. I think you are seeing this error because you are trying to reconnect to a room before the participant has been removed.
You do not need to manually try to reconnect when the reconnecting event fires. The twilio.video.js SDK will automatically try to reconnect for you.
If you still want to reconnect to the room, you can try waiting for the disconnected event instead. room.on('disconnected', () => { ... }).

Closing due to inactivity.


C++ Asynchronous Streaming RPC example

Hi everybody,
Could anyone add/post a (simple) example which uses a both streaming and asynchronous RPC?
There are async examples (greeter_async_client & greeter_async_server in helloworld) without streaming; and streaming examples (in routeguide) but synchronous.
I'm having a hard time implementing a simple Server streaming, asynchronous RPC using C++.
Thanks in advance,
Eduardo
Edit:
What I am really seeking is to do something else in the server appart from attending its clients, while keeping an open stream with them (so that I can decide to send them new info when necessary); and that's why I thought a Asynchronous Streaming RPC could solve my problem.

With a synchronous, streaming RPC (routeguide example) I'm not being able to keep the connection opened in the server so that a new data stream can eventually be sent to the client (I need to send them data when received from somewhere else).

With an asyncrhonous, non streaming RPC (helloworld example) I'm being unable to do anything else in the server appart from attending its clients (for example, generating new data to be sent). Here is the HandleRpcs() function included in greeter_async_server example and the while(true) loop with GPR_ASSERT() that stops me from doing anything else

  void HandleRpcs() {
    new CallData(&service_, cq_.get());
    void* tag;  // uniquely identifies a request.
    bool ok;
    while (true) {
      GPR_ASSERT(cq_->Next(&tag, &ok));
      GPR_ASSERT(ok);
      static_cast<CallData*>(tag)->Proceed();
    }
  }

https://github.com/grpc/grpc/issues/6504

#8934 Please take a look at this PR and add your comments there.

Assigning to @vjpai because he has been doing the code review for #8934.

There are more examples now along with a lot more documentation.

There are more examples now along with a lot more documentation.

Can you please point out the examples?

Bump,
@vjpai What examples are you talking about?  The latest grpc tag 1.15 does not provide a c++ async bidi example.  #8934 is the only good example I've seen but it's not done.


Docker Container Updates

Any plans to update the docker container? It appears to still be running 1.6.2, last updated 9 months ago.

An update to the docker hub would be greatly appreciated

Thanks :)


Linker not implemented

Currently the Lotus preprocessor only handles 'use' preprocessor directives and can't link outside the explicitly defined translation unit.

This issue is extensive and requires much effort. If this issue is still relevant then split it into multiple smaller issues. If the issues are smaller they can also easier be linked with different pull requests.


This work is excellent, I want to know if the test code will be released

This work is excellent, I want to know if the test code will be released

@ywj95 you can take a look at mmsegmentation - which has a variety of training scripts/regimes. I do not have too much time to work on the actual testing code right now.

@ywj95 you can take a look at mmsegmentation - which has a variety of training scripts/regimes. I do not have too much time to work on the actual testing code right now.


Add cvmatio version 1.0.27 (suppports istream)

@ruslo : Please hold off on the merge.  Thanks.  I'm looking into a potential problem.


Syntax Highlighting Issues with Svelte Files in Neovim Using Tree-sitter, Possibly Related to Dot Notation

I am experiencing a problem with the syntax highlighting of Svelte files in Neovim when using Tree-sitter. The highlighting works correctly with smaller files but begins to fail when each or if blocks are introduced, especially in lines involving dot notation (e.g., <Card.Title>). This issue persists across different configurations, including setups with LazyVim and AstroVim, indicating it might not be specific to my personal setup. I am using the latest version of Neovim.
Environment Details:

OS: macOS, Darwin 23.4.0, arm64
Neovim Version: Latest
Tree-sitter Version: 0.22.5
Node Version: v21.7.3
Git Availability: Yes
Compiler: Apple clang version 15.0.0

Steps to Reproduce:

Open a larger Svelte file containing each or if blocks.
Observe the syntax highlighting behavior, particularly after line 82 and around lines using dot notation.

Expected Behavior:
Syntax highlighting should remain consistent throughout the file, regardless of the presence of Svelte-specific syntax, control structures, or dot notation usage.
Actual Behavior:
Syntax highlighting fails, losing coloration after specific blocks of code are introduced, particularly those involving dot notation.
Additional Notes:
Attempts to resolve the issue by switching themes (e.g., Rose-pine.nvim) or inspecting with :InspectTree have not been successful. Further investigation and community support are needed to determine if this is a bug with the Svelte parser integration or a compatibility issue with specific configurations.

https://github.com/Himujjal/tree-sitter-svelte/assets/26936893/a623f33b-5dde-4ed7-8205-92a868051bee

I've now found out that it's really due to the HTML dot notation. I changed the imports and tags to CamelCase and everything works as expected. That's pretty bad!

I have the same problem, it makes Neovim unusable for Svelte projects.

The grammar that nvim-treesitter installs is actually https://github.com/tree-sitter-grammars/tree-sitter-svelte and not this one (I also got confused because this repo is the first result when searching on Google)
I have opened a PR on tree-sitter-grammars/tree-sitter-svelte which resolves this issue: https://github.com/tree-sitter-grammars/tree-sitter-svelte/pull/4.
Hopefully, it will be merged quickly because there doesn't seem to be an easy way to override the installation source in nvim-treesitter 🤞

The grammar that nvim-treesitter installs is actually https://github.com/tree-sitter-grammars/tree-sitter-svelte and not this one (I also got confused because this repo is the first result when searching on Google)
I have opened a PR on tree-sitter-grammars/tree-sitter-svelte which resolves this issue: tree-sitter-grammars/tree-sitter-svelte#4.
Hopefully, it will be merged quickly because there doesn't seem to be an easy way to override the installation source in nvim-treesitter 🤞

Hey, oh, good to know, thanks for letting me know. I see you already opened a related issue in the right repo. Thanks for that! Hopefully it will be fixed soon!


transport error

Issue description  In the error log I keep getting "ledger misc error: ledger transport error"
Briefly describe the issue.I downloaded firefly before it could be used with which meant I had to create a 24 word seed, I now want to control firefly with my ledger, it will not do it.
Wallet version1.2.0
Which version of wallet are you using? 1.2.0

wallet version (version number, commit, or branch):

System specification
What is your operating system?  64bit operating system *64 based processor
Mac/Win/Linux (+Version and or Distro if possible)  windows 10 home  os build 19042.1110
Is it a repeatable issue?
Yes
Steps To reproduce the issue
Explain how the maintainer can reproduce the issue.
1.download firefly ,  create profile create 24 word seed
2.create second profile to be controlled by ledger, it will not continue beyond create wallet button
3.
Expected behaviour
Describe what you expect to happen.  it will not go beyond create wallet button
Actual behaviour
Describe what actually happens. nothing happens
Errors
Paste any errors that you see from the Error Log in the Firefly menu or share screenshots of the issue.
Ledger misc error: ledger transport error

Hey @babble-ai, so the problem is that you're unable to create a Ledger profile after creating a software profile? There should be no problem creating an arbitrary amount of different profiles.

Thank you for repllying, yes that is the problem, what do I do.

@babble-ai You could try to uninstall Firefly and delete the folder in C:\Users[username]\AppData\Roaming\Firefly. Then you can reinstall Firefly. But before you uninstall Firefly make sure to have the 24 words of your normal software wallet.
After you Firefly is installed you can try to restore the software wallet and then create a hardware wallet.

Thanks for the reply, yes i did as you wrote, no luck the ledger does connect and tries to make a new wallet, eventually the ledger times out with no new wallet there is also no ledger "help" page.

Have you checked for the latest firmware update of your Ledger? This would be 2.0 for Ledger Nano S and 1.3 for Ledger Nano X

In my ledger live it says that at the top it is synchronized and further down it says the ledger nano s is genuine and that the version is up to date 1.6.1. no mention of a 2.0 there.

Thank you very much, went to the ledger website and downloaded the latest version, proceeded to firefly and was successful in creating a wallet controlled by ledger.

Great! I guess this issue can be closed


Auto-Login Process, Messaging, and Documentation is Confusing

Which version of the AzCopy was used?
10.22.2
Note: The version is visible when running AzCopy without any argument
Which platform are you using? (ex: Windows, Mac, Linux)
Windows
What command did you run?
Note: Please remove the SAS to avoid exposing your credentials. If you cannot remember the exact command, please retrieve it from the beginning of the log file.
azcopy copy and then azcopy login after this because the copy command doesn't work
What problem was encountered?
I am attempting to use auto login, or really, any login, but the process is confusing.  To start, consider what happens when I azcopy login:
INFO: 'azcopy login' command will be deprecated starting release 10.22. Use auto-login instead. Visit https://learn.microsoft.com/en-us/azure/storage/common/storage-use-azcopy-authorize-azure-active-directory#authorize-without-a-secret-store  to know more.

I am on version 10.22.2, so doesn't that mean azopy login is deprecated for me?  The messaging makes it sound like it's going to be deprecated in a future version, but as I understand it, that future version is now.
Additionally, when I visit https://learn.microsoft.com/en-us/azure/storage/common/storage-use-azcopy-authorize-azure-active-directory#authorize-without-a-secret-store the link does not mention Auto-Login or anything about it.  There is no information on this feature or how to enable it.  The only place I see "auto" is in variable names, but this doesn't tell me exactly how this works.
What exactly is auto-login and how do I enable it?
I want to do the same thing I am doing now with azcopy login and use the current (administrative) user to perform key automation tasks to stand up an environment.
How can we reproduce the problem in the simplest way?
enter azcopy login and enjoy the show.
Have you found a mitigation/solution?
Opening the issue here is the best I got. :)  Thank you for any assistance you can provide. 🙏

@nakulkar-msft Please take a look.

Thank you for expressing your concern.
In a nut-shell Auto-Login enables AzCopy commands to authenticate to Azure storage by picking up Azure Active Directory (AAD) credentials from environment variables without the need to explicitly invoke the azcopy login command.
We have a dedicated page [AZCOPY-AUTOLOGIN] (https://github.com/Azure/azure-storage-azcopy/wiki/Improved-login-support-for-AzCopy-commands-(with-in-memory-secret-store)) that comprehensively explains the AUTO-LOGIN feature and addresses various scenarios associated with its usage.
Furthermore, I'd like to clarify that, at present, we have decided not to deprecate AzCopy Login. We have initiated a pull request (PR) to modify the message you encounter during the login process.
As of now you can use both the old azcopy login and  Auto-Login.

Thank you for all your efforts out there @pranavmalik-msft and team.  This is a great product and works really well. 👍


codegen: Respect prepend_enum_name in constified variants.

Fixes #755

r? @fitzgen

@bors-servo r+

:pushpin: Commit da2bc03 has been approved by fitzgen

:hourglass: Testing commit da2bc039c12fcbffe100f570bd6c61314d29dc75 with merge d051a8a2cdf3e16f19eb0017e273b898efd35504...

:sunny: Test successful - status-travis
Approved by: fitzgen
Pushing d051a8a2cdf3e16f19eb0017e273b898efd35504 to master...


Can't execute new scripts

VSCode Version:1.32
OS Version: Windows 10

When I open visual code, I can execute my program, but if I add something, the program will run, like if I hadn't changed anything. It's a big problem because I can't do anything.
(node.js)

Does this issue occur when all extensions are disabled?: Yes/No

Are you running your program via Debug, Tasks or Terminal?

Are you running your program via Debug, Tasks or Terminal?

debug I think, with F5

Please provide steps that explain what you are trying to do.

I have my program in node js, I add something, like "  if (message.content === ... ){scripts}  "
the I press F5
the program (all, not the if) will work well, but like if the if and his script never existed

How does your launch config look like?


Fix issue #20 : add getAvailableCurrencies method for ProviderInterface

we also need to check if the currencies are supported in the main class while calculating the exchange rate.

we also need to check if the currencies are supported in the main class while calculating the exchange rate.

are you talking about CurrencyConverter::convert method ?

Thinking about it, supported currencies also require caching ... I implemented it in the former commit.
I also implemented checking if the currencies are supported in the main class while calculating the exchange rate as you asked for.
What do you think about this last commit ?

+1 man. I like the overall idea. I will weigh in my comments.

Apologies for delays. I will write all my comments this weekend.


[BEAM-14345] Force paranamer 2.8 for Spark Hadoop version tests to avoid issues when using Scala 2.12

Hadoop version tests are failing for Spark 3. The present fix doesn't apply to the respective hadoop configuration. This PR adds it to hadoop configs as well.
// Force paranamer 2.8 to avoid issues when using Scala 2.12
runtimeOnly "com.thoughtworks.paranamer:paranamer:2.8"

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

A tiny quick one
R: @aromanenko-dev
R: @echauchot

Run Java PreCommit


add new launcher icons

add Adaptive and legacy launcher icons

@changanxian Can you review ?

@eri9600 can you review ?

@tschie can you review the last commit (changes in Release.md file)


#293 - remove the guy from campaign

Proposed changes
Remove the dummy content Guy
Checklist

[ ] look at any campaign - see that the guy is gone


New package versions.

This change is

Superseded by https://github.com/cockroachdb/docs/pull/12805


Models with "@" in their name do not resolve as dependencies

The following code examples can be copied into https://microsoft.github.io/monaco-editor/playground.html for verification.
I'm trying to specify dependencies manually via monaco.editor.createModel(), which works fine for dependency outside of organizations, but if a package is defined within a organization, i.e. has a name like @org/packagename and thus contains a @-character, it breaks. To me it looks like this is due to Monaco changing the @-character to %40.
The following code (which does not contain @) works fine:
monaco.editor.create(document.getElementById("container"), {
    model: monaco.editor.createModel(
        "import * as t from 'test';\nt.X.toExponential();\nt.Y; // Error",
        "typescript",
        monaco.Uri.parse("file://root/test.ts")
    )
});

monaco.languages.typescript.typescriptDefaults.setCompilerOptions({
  ...monaco.languages.typescript.typescriptDefaults.getCompilerOptions(),
  moduleResolution: monaco.languages.typescript.ModuleResolutionKind.NodeJs
});

monaco.editor.createModel(
    JSON.stringify({
        name: "test", version: "1.0.0",
        typings: "./lib/index.d.ts"
    }),
    "typescript",
    monaco.Uri.parse("file://root/node_modules/test/package.json")
);

monaco.editor.createModel(
    "export const X = 1;",
    "typescript",
    monaco.Uri.parse("file://root/node_modules/test/lib/index.d.ts")
);

console.log(
    "Works:",
    monaco.editor.getModel("file://root/node_modules/test/lib/index.d.ts").uri.toString()
);

However, on this code (containing a @) it breaks;
monaco.editor.create(document.getElementById("container"), {
    model: monaco.editor.createModel(
        "import * as t from '@org/test';\nt.X.toExponential();\nt.Y; // Error",
        "typescript",
        monaco.Uri.parse("file://root/test.ts")
    )
});

monaco.languages.typescript.typescriptDefaults.setCompilerOptions({
  ...monaco.languages.typescript.typescriptDefaults.getCompilerOptions(),
  moduleResolution: monaco.languages.typescript.ModuleResolutionKind.NodeJs
});

monaco.editor.createModel(
    JSON.stringify({
        name: "@org/test", version: "1.0.0",
        typings: "./lib/index.d.ts"
    }),
    "typescript",
<EMAIL_ADDRESS>);

monaco.editor.createModel(
    "export const X = 1;",
    "typescript",
<EMAIL_ADDRESS>);

console.log(
    "Does not work, but should:",
    monaco.editor.getModel("file://root/node_modules/@org/test/lib/index.d.ts")?.uri.toString()
);

console.log(
    "Does work, but doesnt help:",
    monaco.editor.getModel("file://root/node_modules/%40org/test/lib/index.d.ts").uri.toString()
);

monaco-editor version: 0.21.2
Browser: Chrome
OS: Windows 10
Is this an issue with Monaco or with my approach? Is there a workaround for this problem? Let me know if you need more details.

try to add them whithout the /lib/ subdir, so your index.d.ts whill work here:
<EMAIL_ADDRESS>

try to add them whithout the /lib/ subdir, so your index.d.ts whill work here:
<EMAIL_ADDRESS>

also, I think, it should be
file:///...
instad of
file://

also, I think, it should be
file:///...
instad of
file://

Hi @zerdos, thanks for your response and suggestions! Unfortunately, they did not work in the playground for me, I still get the same issue. As I've mentioned before, I suspect the issue lies somewhere around the fact that monaco changes the @-character to %40 when making the path accessible, which I am unsure on how to work around and why that happens in the first place.

Hi @zerdos, thanks for your response and suggestions! Unfortunately, they did not work in the playground for me, I still get the same issue. As I've mentioned before, I suspect the issue lies somewhere around the fact that monaco changes the @-character to %40 when making the path accessible, which I am unsure on how to work around and why that happens in the first place.

I once had a similar issue. I can't find the original issue but the way to make scope packages to work is to remove @ from the path and replace first / with __. Following code should fix your paths:
const fixedName = name.startsWith('@') ? name.slice(1).replace('/', '__') : name

And the full file path should be: file:///node_modules/@types/${fixedName}

I once had a similar issue. I can't find the original issue but the way to make scope packages to work is to remove @ from the path and replace first / with __. Following code should fix your paths:
const fixedPackageName = name.startsWith('@') ? name.slice(1).replace('/', '__') : name

And the full file path should be<EMAIL_ADDRESS>
@ErkoKnoll i believe this might work using addExtraLib but will fail with editor.createModel

The problem here is that if you don't add it to your models, you will not be able to peek the definition. So for that, you need to add it to both the extra lib and the model.
So after debugging this issue for half a day and trying to come up with a solution, which I didn't, I found out that the problem can basically be tracked down to this method.

So it tries to remove the @types prefix, which it fails to do here because the @ is encoded. I then tried to modify that code so it also strips off %40types/, but then I ended up with two suggestions.

So I basically gave up on this and instead I do not add the @types type definitions to the models. So peek definition and what not works for all unscoped packages but not for scoped packages unfortunately.

I am also having this issue.
code
  editor.createModel(
      source,
      'typescript',
<EMAIL_ADDRESS>    )

// this works
import { createSlice } from '%40reduxjs/toolkit';

// this gives an error
import { createSlice } from '@reduxjs/toolkit';

It's a big deal for me because code written in my editor won't be the same as code written in native VSCode.

A full example that can be pasted in https://microsoft.github.io/monaco-editor/playground.html
monaco.languages.typescript.typescriptDefaults.setCompilerOptions({
    target: monaco.languages.typescript.ScriptTarget.Latest,
    allowNonTsExtensions: true,
    moduleResolution: monaco.languages.typescript.ModuleResolutionKind.NodeJs,
    module: monaco.languages.typescript.ModuleKind.ESNext,
    noEmit: true,
    esModuleInterop: true,
    strict: true,
    jsx: monaco.languages.typescript.JsxEmit.React,
    reactNamespace: 'React',
    allowJs: true,
    isolatedModules: true,
})

monaco.languages.typescript.typescriptDefaults.setEagerModelSync(true);

const instance = monaco.editor.create(document.getElementById("container"), {
    language: 'typescript',
    model: null,
});

monaco.editor.createModel(
    'export const foo = {bar: 123};',
    'typescript',
<EMAIL_ADDRESS>)

const model = monaco.editor.createModel(
    `import {foo} from "@reduxjs/toolkit"

console.log(foo.bar);
`,
    'typescript',
    this.monaco.Uri.parse(`file:///index.ts`)
)

instance.setModel(model)

Changing @ -> %40 works

cc @orta

Any update on this? I also have the same issue

Hi
I've worked trying to understand the problem and finally I found out.
I've submitted PR #3057


Fix a possible crash in the error handling

This fixes crashes in the crypto error handling module:
==1925==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000244 (pc 0x0000021ef338 bp 0x7f555666ecb0 sp 0x7f555666ec90 T3679)
==1925==The signal is caused by a READ memory access.
==1925==Hint: address points to the zero page.
    #0 0x21ef337 in ERR_set_mark crypto/err/err.c:768
    #1 0x22f8d8c in pubkey_cb crypto/x509/x_pubkey.c:44
    #2 0x21587a4 in asn1_item_embed_d2i crypto/asn1/tasn_dec.c:396
    #3 0x2153dbd in asn1_template_noexp_d2i crypto/asn1/tasn_dec.c:606
    #4 0x2153dbd in asn1_template_ex_d2i crypto/asn1/tasn_dec.c:482
    #5 0x215806d in asn1_item_embed_d2i crypto/asn1/tasn_dec.c:347
    #6 0x2153dbd in asn1_template_noexp_d2i crypto/asn1/tasn_dec.c:606
    #7 0x2153dbd in asn1_template_ex_d2i crypto/asn1/tasn_dec.c:482
    #8 0x21599e6 in asn1_item_embed_d2i crypto/asn1/tasn_dec.c:347
    #9 0x21599e6 in ASN1_item_ex_d2i crypto/asn1/tasn_dec.c:114
    #10 0x21599e6 in ASN1_item_d2i crypto/asn1/tasn_dec.c:104

For master and 1.1.0 branch.

merged to all three branches as shown in the commits above.

Aehm, in 1.0.2 this was not strictly necessary, but now when it is committed,
I will send a follow-up patch that removes the "fallback" in ERR_get_state.


Using getProgramAccounts with base58 encoding is no longer valid

Problem
A recent change in Solana has removed support for fetching program accounts with the default base58 encoding: https://github.com/solana-labs/solana/pull/18852 and this change breaks token fetching.
Proposed Change
Update the getProgramAccounts call for user tokens to use the "encoding":"base64" option
cc @armaniferrante

Addressed by https://github.com/project-serum/spl-token-wallet/pull/352.