"Attempt to create nonmanifold mesh" error for TriangulateCDT on some polygons.

When using the new TriangulateCDT that doesn't take a compute type template parameter, some polygons result in an error about creating a non-manifold mesh. These errors disappear when using an explicit compute type of gte::BSNumbergte::UIntegerAP32.
Here are two polygons that exhibit this problem, using double precision for the input type:
Points:
0.20209289058291205, 0.83965099469526228
0.20209236682654186, 0.83965205584045832
0.20209230684758409, 0.83965217735952036
0.20209193307206785, 0.83965293463927093
0.2020917065364263, 0.83965339360687763
0.20209164655746853, 0.83965351512593989
0.20209105940397842, 0.83965470471549097
0.20209099942502062, 0.83965482623455312
0.20209076954373811, 0.83965529198052291
0.20209041388543147, 0.83965601255429534
0.20209035390647367, 0.83965613407335749
0.20209004744156056, 0.83965675497992553
0.20208754708287416, 0.8396561976962954
0.20209026770211216, 0.83965044142588929

Boundary:
0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13

Points:
0.20208523411510296, 0.83966332777155461
0.20208662048756035, 0.83966364431603679
0.20208523411510293, 0.83966332777155461
0.20208513067452474, 0.83966330415341062
0.20208806073825292, 0.83966250884209193
0.20208753572284524, 0.83966352393632171
0.20208806073825289, 0.83966250884209193
0.2020881343533035, 0.83966236651062509
0.20208468229943993, 0.83966092265164638
0.20208614019546703, 0.83966121478929878
0.20208530381118656, 0.83966294583731527
0.20208351970988686, 0.83966254606591495
0.20208322023712552, 0.8396624789617404
0.20208286318159582, 0.83966217602346105
0.2020825274017701, 0.83966189113622602
0.20208235941987907, 0.83966174861457099
0.2020820471840965, 0.83966148370291771
0.20208157402887555, 0.83966108226163882
0.20208083238854183, 0.83966045302829051
0.20207971799980912, 0.8396595075422888
0.20207945912005715, 0.83965928789973998
0.20207894070151083, 0.83965884805548807
0.20207828889711815, 0.83965829504206368
0.20207721612996576, 0.83965738486925257
0.20207928277433304, 0.83965628513729085
0.20208849493616993, 0.83966166933949116
0.20208834809931403, 0.83966195324210235
0.2020884949361699, 0.83966166933949116
0.20208878569899102, 0.8396611071623481

Boundary:
8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24

Hello Aaron.
What is the file version for your Delaunay2.h?
--
Dave Eberly
https://www.geometrictools.com
From: Aaron Barany<EMAIL_ADDRESS>Sent: Thursday, December 10, 2020 5:45 PM
To: davideberly/GeometricTools<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [davideberly/GeometricTools] "Attempt to create nonmanifold mesh" error for TriangulateCDT on some polygons. (#5)
When using the new TriangulateCDT that doesn't take a compute type template parameter, some polygons result in an error about creating a non-manifold mesh. These errors disappear when using an explicit compute type of gte::BSNumbergte::UIntegerAP32.
Here are two polygons that exhibit this problem, using double precision for the input type:
Points:
0.20209289058291205, 0.83965099469526228
0.20209236682654186, 0.83965205584045832
0.20209230684758409, 0.83965217735952036
0.20209193307206785, 0.83965293463927093
0.2020917065364263, 0.83965339360687763
0.20209164655746853, 0.83965351512593989
0.20209105940397842, 0.83965470471549097
0.20209099942502062, 0.83965482623455312
0.20209076954373811, 0.83965529198052291
0.20209041388543147, 0.83965601255429534
0.20209035390647367, 0.83965613407335749
0.20209004744156056, 0.83965675497992553
0.20208754708287416, 0.8396561976962954
0.20209026770211216, 0.83965044142588929
Boundary:
0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
Points:
0.20208523411510296, 0.83966332777155461
0.20208662048756035, 0.83966364431603679
0.20208523411510293, 0.83966332777155461
0.20208513067452474, 0.83966330415341062
0.20208806073825292, 0.83966250884209193
0.20208753572284524, 0.83966352393632171
0.20208806073825289, 0.83966250884209193
0.2020881343533035, 0.83966236651062509
0.20208468229943993, 0.83966092265164638
0.20208614019546703, 0.83966121478929878
0.20208530381118656, 0.83966294583731527
0.20208351970988686, 0.83966254606591495
0.20208322023712552, 0.8396624789617404
0.20208286318159582, 0.83966217602346105
0.2020825274017701, 0.83966189113622602
0.20208235941987907, 0.83966174861457099
0.2020820471840965, 0.83966148370291771
0.20208157402887555, 0.83966108226163882
0.20208083238854183, 0.83966045302829051
0.20207971799980912, 0.8396595075422888
0.20207945912005715, 0.83965928789973998
0.20207894070151083, 0.83965884805548807
0.20207828889711815, 0.83965829504206368
0.20207721612996576, 0.83965738486925257
0.20207928277433304, 0.83965628513729085
0.20208849493616993, 0.83966166933949116
0.20208834809931403, 0.83966195324210235
0.2020884949361699, 0.83966166933949116
0.20208878569899102, 0.8396611071623481
Boundary:
8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/davideberly/GeometricTools/issues/5, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ5SOLNIBKINNNWA4CAFMT3SUF2TRANCNFSM4UV4DVDQ.

Based on the comment, version 4.0.2020.11.30.

I fixed a bug in Delaunay2.h that I introduced for the new interfaces. That file version is 4.0.2020.12.01.

It looks like that fixed it, thanks!

Sorry about that. I am slammed trying to get GTL finished with its extensive unit testing. I want GTE ported (and retired) as soon as possible. Contracting also takes away from my time. Juggling appears not to be one of my skills…
--
Dave Eberly
https://www.geometrictools.com
From: Aaron Barany<EMAIL_ADDRESS>Sent: Thursday, December 10, 2020 6:12 PM
To: davideberly/GeometricTools<EMAIL_ADDRESS>Cc: David Eberly<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [davideberly/GeometricTools] "Attempt to create nonmanifold mesh" error for TriangulateCDT on some polygons. (#5)
It looks like that fixed it, thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/davideberly/GeometricTools/issues/5#issuecomment-742919025, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ5SOLJKZEWBUBEPHGKDQFLSUF5XVANCNFSM4UV4DVDQ.

No problem, the fact that your GTL tests caught this is definitely a good sign as it gets closer to release.


AttributeError: 'OLT' object has no attribute 'items'

Hi,
I am using the latest docker image 'instadeepct/mava:pz-latest'. I am trying to run maddpg on my own custom environment, but I encountered the following problem AttributeError: 'OLT' object has no attribute 'items' below. I then tried to do the same but on pettingzoo/classic/connect_four_v3.py though I encountered the same problem. The flags I specified are below. I noticed that the current environments that are working for me are the parallel environment types. Could this be a problem because I'm using sequential, where ._convert_observations() returns an OLT instead of a Dict[str, types.OLT]?
run_maddpg.py:
FLAGS = flags.FLAGS

flags.DEFINE_string(
    "env_class",
    "classic",
    "Pettingzoo environment class, e.g. atari (str).",
)
flags.DEFINE_string(
    "env_type",
    "sequential",
    "Pettingzoo environment type.",
)
flags.DEFINE_string(
    "env_name",
    "connect_four_v3",
    "Pettingzoo environment name, e.g. pong (str).",
)
flags.DEFINE_string(
    "mava_id",
    str(datetime.now()),
    "Experiment identifier that can be used to continue experiments.",
)
flags.DEFINE_string("base_dir", "/home/app/mava/logs/", "Base dir to store experiments.")

Error:
[evaluator/0]
[evaluator/0] Traceback (most recent call last):
[evaluator/0]   File "/mava/lib/python3.8/site-packages/launchpad/nodes/python/process_entry.py", line 110, in <module>
[evaluator/0]     app.run(main)
[evaluator/0]   File "/mava/lib/python3.8/site-packages/absl/app.py", line 312, in run
[evaluator/0]     _run_main(main, args)
[evaluator/0]   File "/mava/lib/python3.8/site-packages/absl/app.py", line 258, in _run_main
[evaluator/0]     sys.exit(main(argv))
[evaluator/0]   File "/mava/lib/python3.8/site-packages/launchpad/nodes/python/process_entry.py", line 105, in main
[evaluator/0]     functions[task_id]()
[evaluator/0]   File "/mava/lib/python3.8/site-packages/launchpad/nodes/python/node.py", line 72, in _construct_function
[evaluator/0]     return functools.partial(self._function, *args, **kwargs)()
[evaluator/0]   File "/mava/lib/python3.8/site-packages/launchpad/nodes/courier/node.py", line 124, in run
[evaluator/0]     instance.run()
[evaluator/0]   File "/home/app/mava/mava/environment_loop.py", line 582, in run
[evaluator/0]     result = self.run_episode()
[evaluator/0]   File "/home/app/mava/mava/environment_loop.py", line 447, in run_episode
[evaluator/0]     actions = self._get_actions(timestep)
[evaluator/0]   File "/home/app/mava/mava/environment_loop.py", line 362, in _get_actions
[evaluator/0]     return self._executor.select_actions(timestep.observation)
[evaluator/0]   File "/home/app/mava/mava/systems/tf/maddpg/execution.py", line 171, in select_actions
[evaluator/0]     for agent, observation in observations.items():
[evaluator/0] AttributeError: 'OLT' object has no attribute 'items'

Hi @xavierwwj , it looks like your timestep.observation is an OLT object as follows:
timestep = OLT(
                observation=OLT(...),
                legal_actions=...,
                terminal=...,
            )

, when it should be:
timestep = OLT(
                observation={'agent_0':...},
                legal_actions=...,
                terminal=...,
            )

This is likely being returned by your environment's step function.

@xavierwwj So you need to use PettingZooParallelEnvWrapper with the ParallelEnvironmentLoop. In your example, looks like you are using  PettingZooAECEnvWrapper (sequential wrapper) with the ParallelEnvironmentLoop (parallel loop).
Is your environment parallel or sequential? If it is parallel, I recommend using  ParallelEnvironmentLoop.


Mirror answers on the Git mailing list to the corresponding PRs

So far, GitGitGadget has been a one-way street: commits pushed to GitGitGadgets' Git fork could be sent to the Git mailing list, but the communication about the patches had to happen there, completely.
With this PR, the answers on the Git mailing list get added as PR comments.
While the format is far from perfect (the emails are rendered in a rather ugly way, non-ASCII senders are not displayed properly, for replies to individual patches, there is no obvious link to the respective commit, etc), it is a start.
This can be seen in action at https://github.com/gitgitgadget/git/pull/31#issuecomment-457692752

I was wondering if there are any tests for gitgitgadget because there is a lot of parsing going on and tests would really help validate it.

Indeed, it gives a bit more confidence to have tests covering this functionality.
The part that I think is the only part that is testable, though, is the parsing of the mbox file (which is already tested). The more important part is where the code actually acts on mails sent to the mailing list, which I think is not really testable, not unless I mock quite a bit of stuff into the code... which would cost me a lot of time, and might actually be buggy in and of itself? So I'll try to be lazy here ;-)
Thank you for the review!


Validation pattern not accepted by preg_match

Describe the bug
The pattern provided by GenericValidator::getPattern() is not suitable for usage with preg_match()
To Reproduce...
Reproducible by running this sample code. The $testUuid should be valid.
<?php
require_once 'vendor/autoload.php';
$validator = new Ramsey\Uuid\Validator\GenericValidator();
$testUuid = 'c2e2d482-011a-4adc-a115-5cfe60785bcc';
var_dump(preg_match($validator->getPattern(),$testUuid));

Received output:
PHP Warning:  preg_match(): Delimiter must not be alphanumeric or backslash in /home/dbx12/PhpstormProjects/voting/test.php on line 5
PHP Stack trace:
PHP   1. {main}() /tmp/test.php:0
PHP   2. preg_match() /tmp/test.php:5
bool(false)

Expected behavior

The pattern is accepted by preg_match().
The pattern validates UUIDs correctly

Screenshots or output
n/a, all output is pasted above
Environment details

OS: Linux, Kernel 5.4.0-56-generic / Linux Mint Mate 20
PHP version: 7.4.3
ramsey/uuid version: 4.1.1

You will need to put delimiters around the pattern. It is designed this way so that you may use the pattern in other contexts, such as within other patterns.
var_dump(preg_match('/' . $validator->getPattern() . '/',$testUuid));

Oh man, it was obvious :man_facepalming:
Sorry for bothering you and thanks for the heads up.


Error in output handler base.lua

Hi,
I have a strange error regarding the base output handler. I'm using the version 2.0.rc12-1
I ran busted as follows
busted -lpath "./source/?.lua" tests/test_bashEdsl.lua

which leads to the following output:
/usr/share/lua/5.3/busted/outputHandlers/base.lua:146: bad argument #1 to 'insert' (table expected, got nil)

The test code is probably not the cause of this problem. However, here is it:
describe("general bash EDSL tests #BDSL", function()
             randomize(true)

             b = require "../source/bashEdsl"

             it("tests whether package was loaded correctly", function()
                    assert.Truthy(b)
             end)

             it("tests verbatim parameters #VP", function()
                    assert.True(b.c("foo")() == "foo")
             end)

             it("tests a simple parameter expansion use cases #PE", function()
                    assert.are.equal(b.pE("foo")(), [[${foo}]])
             end)

             it("tests parameter expansion use cases #PE", function()
                    assert.True(true)

                    assert.True((b.pE("foo") .. b.pE(b.pE("bar")))() ==
                        [[eval eval ${foo}\${${bar}}]] ) end)
end)

Brainstorming
In base.lua:146 there is a little if - elseif cascade that compares the status variable against different strings. status seems to be a table here. Am I missing something crucial?

Uhm, as it turned out, I forgot that I've overwritten the function tostring in the global environment.
As soon as I commented out my custom tostring, everything worked as to be expected.
However, the documentation should mention that you cannot do such a thing in conjunction with your library...

"Don't override global functions" isn't something I think needs to be documented, but glad you got it working!


Docs update on how to use ODBC credentials in sql database

Description
Docs update on how to use ODBC credentials in sql database
<!--
Please link any related issues. This helps us keep the PR focused and merge it faster.
None

Thanks for reviewing Marcin, yes your documentation covers this here. So this additiong is not required and can be closed.
Sorry, I missed it earlier.
I'll close this PR now.


choco installation option

Hey, love your work. I was wondering if you could add installation through chocolatey package manager?

@abishekaditya but there's literally scoop :thinking:

@h404bi is this a blessing for my comment? :rofl:


[release-1.8] Update min k8 supported version for istio 1.8

This is an automated cherry-pick of #28814

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio_release-1.8
8da111dbc853977f20b009ec9dae6eca8c5e0bc1
link
/test integ-multicluster-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-multicluster-k8s-tests_istio_release-1.8

@googlebot I consent


Adding size functions in equations removes spacing

Examples: a {\small + } b a {\small = } b a {\small - } b
Without Sizing:

With Sizing:

@rrandallcainc Did you test against LaTeX? Because a{-}b is generally supposed to remove the spacing around - in LaTeX.

@edemaine Doh! Nice catch. I can close this issue. Curious, what's the best way to accomplish a smaller operator then with LaTeX?

You need to remap the new symbol in \mathbin to get it to act like a binary operator again:
x\mathbin{\small +}y

Enjoy!


withscores

Hi!
Wonder if you could consider whether it's feasible to support commands which take withscores option to return hashes instead of plain arrays.
TIA,
--Vladimir

It's an old discussion. curious to know if 'withscore' is implemented.. this is really an important feature.
Mranney, great work so far !!

Not fixed => reopening


Add Database

Adds ActiveRecord & Standalone Migrations (may god help us)
Adds PostgreSQL driver
Configures Rake to setup test database before running tests
Updates a bunch of tests, plus adds some integration tests

The tests are failing here because I have not setup a Postgres DB for the GH Action. They do pass locally. For now, I will merge this PR and setup the Postgres DB here later.


Driver booster 9 addition

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

IObit has removed the 8.0 (DriverBooster8) in its entirety now only offering DriverBooster9 (and now all the old urls lead to DriverBooster9) it might be an idea to remove DriverBooster8 from wingets program application lists I tried doing this before in a another PR but it just resulted in a lot of errors. https://github.com/microsoft/winget-pkgs/pull/33254


Error: url.hash is inaccessible from load. Consider accessing hash from the page store within the script tag of your component.

Describe the bug
Once I updated the latest svelte-kit version and above (x ><EMAIL_ADDRESS> I am getting the following error when I just try to use the url in the load function. As you can see from the repro I don't even try to access the url.hash but it still reports as it's illegal to do it.
See the contents of +layout.js.
Reproduction
https://stackblitz.com/edit/sveltejs-kit-template-default-n4vmbd?file=src/routes/+layout.js
Logs
url.hash is inaccessible from load. Consider accessing hash from the page store within the script tag of your component.
Error: url.hash is inaccessible from load. Consider accessing hash from the page store within the script tag of your component.
    at get hash [as hash] (file:///home/projects/sveltejs-kit-template-default-n4vmbd/node_modules/@sveltejs/kit/src/utils/url.js:99:9)
    at [nodejs.util.inspect.custom] (https://sveltejs-kit-template-default-n4vmbd.w.staticblitz.com/blitz.df64f655701fde45529fa8e152b3842072335b47.js:6:137075)
    at formatValue (https://sveltejs-kit-template-default-n4vmbd.w.staticblitz.com/blitz.df64f655701fde45529fa8e152b3842072335b47.js:6:95687)
    at inspect (https://sveltejs-kit-template-default-n4vmbd.w.staticblitz.com/blitz.df64f655701fde45529fa8e152b3842072335b47.js:6:92243)
    at formatWithOptionsInternal (https://sveltejs-kit-template-default-n4vmbd.w.staticblitz.com/blitz.df64f655701fde45529fa8e152b3842072335b47.js:6:115079)
    at formatWithOptions (https://sveltejs-kit-template-default-n4vmbd.w.staticblitz.com/blitz.df64f655701fde45529fa8e152b3842072335b47.js:6:116334)
    at console.value (https://sveltejs-kit-template-default-n4vmbd.w.staticblitz.com/blitz.df64f655701fde45529fa8e152b3842072335b47.js:6:1056475)
    at console.log (https://sveltejs-kit-template-default-n4vmbd.w.staticblitz.com/blitz.df64f655701fde45529fa8e152b3842072335b47.js:6:1056613)
    at console.consoleCall (https://sveltejs-kit-template-default-n4vmbd.w.staticblitz.com/blitz.df64f655701fde45529fa8e152b3842072335b47.js:15:372509)
    at load (/src/routes/+layout.js:2:10)

System Info
Not needed - see repro.

Severity
blocking an upgrade
Additional Information
No response

It's not technically a bug, though I can see why it would be frustrating. You are accessing url.hash, because console.log is trying to access it to log its value.

Oh yeah, of course toString() would try to print the hash as well. 🤦♂Found also the PR/reasoning for this change - although it kinda didn't account for these kind of frustrating experiences. 😅
I can close the issue if this is not something to be reconsidered.

If we wanted we could override LoadURL.prototype.toString so that it returns the URL without the hash? People would miss out on the warning, but I think that's probably better than the current thing

Actually wait, toString doesn't invoke the getter:

(though we should override it anyway because it's currently revealing the hash)

Ok, so the issue here is that Node behaves in a non-standard way — browsers will log the object just fine, but Node does things differently. We can fix it like this...
import util from 'node:util';

export class LoadURL extends URL {
  /** @returns {string} */
  get hash() {
    throw new Error(
      'url.hash is inaccessible from load. Consider accessing hash from the page store within the script tag of your component.'
    );
  }

  [util.inspect.custom]() {
    return this.toString(); // or something that better resembles the current output
  }

  toString() {
    return this.origin + this.pathname + this.search;
  }
}

...but that doesn't work outside Node environments. Hmm.


Clarify data-toggle to use responsive-toggle

When trying to use the responsive-toggle feature, I kept getting an error that '#' was not a valid method, because the element id was not being passed with data-toggle trigger. Added notes to clarify that the menu id should also be set on data-toggle: data-toggle="MENUID".

Thank you @dgdblank.


Implementation of reactive streaming API for read operations.

This would a suggestion on implementing the streaming of read operations based on the reactive streams API supporting full backpressure and out-of-the-box compatibility with reative frameworks like RxJava, Project Reactor and JDK 9 Flow.
This solution consists of the following parts:

Adaption of the EventStoreDBClient-API to return a (cold) Publisher of events on read operations. This is implemented by the AbstractRead (and its sub classes implementing the Publisher contract using the internal ReadSubscription class for fulfilling the reactive contract.
Introduction of reactive streams TCK as test suite for testing the read operations and the reactive contract.

The major building block is definetly the ReadSubscription class which acts as the adapter between the gRPC StreamObserver-API and the Publisher / Subscriber contract. This implementation is currently based on thread synchronisation between the gRPC reader thread used for triggering the StreamObserver and the Subscribers consumer thread which can be any thread including the main thread.

I reviewed @dpasek-senacor PR (https://github.com/EventStore/EventStoreDB-Client-Java/pull/106). It's excellent work. Thank you for the enhanced comments guiding about the changes.
I'll start with a disclaimer: I'm haven't worked on a Java project for a few years, so my perspective may be skewed. I have a general concern about the PR. I'm all for enabling the reactive approach and giving the option to enumerate through the long streams. I know that the RX approach is popular in the Java land, but I'm not sure how much that's a standard. I wonder if we could provide an API or a bit of syntactic sugar, making the default scenario so reading the whole stream more accessible? Based on my experience, most people want to read the entire stream and do left-fold to aggregate the state. I know that we could use EventCollectorReadSubscriber, but the user always needs to add a few additional lines. I'm not sure how much that's doable, but maybe we could come up with the API that's not an RX-first and enable accessibility on both scenarios?
Thoughts?

Hi @oskardudycz
Thanks for the review and your thoughts about the approach.

I'm all for enabling the reactive approach and giving the option to enumerate through the long streams. I know that the RX approach is popular in the Java land, but I'm not sure how much that's a standard.

The approach using the reactive stream API should be the most standard way currently possible. It is not an RX approach, i.e. not tied to any special implementation of reactive streams but uses the API that allows interoperability with the market standards: RxJava and Project Reactor. It is also API compatible to the new JDK 9 Flow API which is the new official standard for consuming streams with backpressure. As discussed with @YoEight internally we would propose not to use Flow-API directly as this would break JDK8 support. This would be a bit to early as many projects are still tied to JDK 8. In 2 years it would be easy to migrate to JDK9 Flow-API by just replacing imports without changing any code.
Last but not least this API is the closest to the API used in other languages, e.g. .net (using IAsyncEnumerable<ResolvedEvent> as return type) or JavaScript (using StreamingRead<AllStreamResolvedEvent>)

I wonder if we could provide an API or a bit of syntactic sugar, making the default scenario so reading the whole stream more accessible? Based on my experience, most people want to read the entire stream and do left-fold to aggregate the state. I know that we could use EventCollectorReadSubscriber, but the user always needs to add a few additional lines. I'm not sure how much that's doable, but maybe we could come up with the API that's not an RX-first and enable accessibility on both scenarios?

I think that the given approach provides us the flexibility and feature set and give us the options to make the live easier for certain use cases:

You have full backpressure support. Backpressure is necessary on reading and processing long streams. Getting backpressure right is not a simple tasks. It is always beneficial to let the clinet/driver handle the dirty details of it.
You can easily use the power of RxJava or Project Reactor (filtering, mapping, grouping and parallelism) if needed.
If we think that reading the events into a list is a standard operations we should add it to the client as a method, i.e. create an API on EventStoreDBClient, that clearly separates "read" and "stream" operations. This would be very simple to add using the foundation we have now. The old Memsys ESJC had this approach and it was very helpful to let the developer decide  if streaming and reading is the better approach.

So yes we should consider adding methods which provide this "read into list" support as currently available, but use the reactive foundation behind it. This would also be beneficial in regard of keeping the next release of the driver backward compatible to the 1.0 release. I'm a huge fan of semantic versioning and following this approach the current change would require to release it as "breaking change", i.e. a major version. Keeping the old method signatures and adding the new ones for streaming would prevent this.

@dpasek-senacor, I agree that for the long streams proposed, API is a great way to deal with them (especially regarding efficient memory usage and backpressure you mentioned).
My main take was that typically, you should try to avoid such cases, where you have really long streams. Of course, sometimes it's unavoidable, so it should be possible to do that effectively. We should try to provide the change non-breaking, so adding streams methods keeps the old one. After that, we could try to gather feedback from the community if they're okay with removing the support for the old ones.

@YoEight @oskardudycz
I have now updated the access to streams via reactive streams to be an additional option in the API next to the existing classic read methods. Internally it uses the reactive infrastracture.
I have also reverted the samples to reference the previous implementation.


SPM is not available on Xcode 12.2 RC (Swift 5.3.1)

Environment details

Specify the API at the beginning of the title (for example, "Places: ...")
OS type and version: macOS 11.0.1 Beta (20B5022a)
Library version and other environment information: Xcode 12.2 beta 4 (12B5044c)

Steps to reproduce

Install Xcode 12.2 Release Candidate
Build project with SPM-dependency on Google Maps Utils

Compile Error
Failed to build module 'GoogleMapsUtils' from its module interface;
the compiler that produced it,
'Apple Swift version 5.3 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)',
may have used features that aren't supported by this compiler,
'Apple Swift version 5.3.1 (swiftlang-1200.0.41 clang-1<IP_ADDRESS>)'

Same with Xcode 12.1.1 RC:
Failed to build module 'GoogleMapsUtils' from its module interface; the compiler that produced it,  'Apple Swift version 5.3 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)',  may have used features that aren't supported by this compiler,  'Apple Swift version 5.3 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)'

Looks like you should change Build Libraries for Distribution to “Yes” in the framework’s build settings

The GoogleMapsUtils.xcframework is already built with the flag BUILD_LIBRARIES_FOR_DISTRIBUTION  enabled and SKIP_INSTALL set to false which should built the frameworks with Module Stability enabled. That said, I'm, not sure your fix in #348 will address the issue you're seeing. See: https://github.com/googlemaps/google-maps-ios-utils/blob/main/.github/workflows/release.yml#L46...L50 I'll dig into this.

I was not able to reproduce this issue on Xcode 12.1

I tried it on another mac and couldn't reproduce either.
Must be something with my environment, sorry.
And thank you. ☺

Unfortunately, we're experiencing this very issue on both 12.1. and 12.2
Apparently, the framework will only work on the exact Swift version build as it was compiled on.
If you need additional infos, let me know @arriolac

JFYI 3.3.0 seems to work. Haven't tested newer versions.

Interesting that 3.3.0 works. Nothing changed in how we generate the .xcframework between 3.3.0 and later versions. Will look into this again.

I'm still not able to reproduce this on Xcode 12.2 on an example project even while testing using a different Swift Language version (I tried Swift 5 and Swift 4.2 which both work). @marckrenn or @Scvairy, are either of you able to share an example project demonstrating this bug?

I'm facing the exact issue with another framework.

@anupamchugh Any resolution? Zendesk's iOS SDK is experiencing this exact issue when installing via SPM
https://github.com/zendesk/support_sdk_ios/

hey @arriolac I'm also facing this issue, created example Package that uses GoogleMapsUtils package, see https://github.com/libec/GoogleMapsUtilsPackageExample
I checked the script where XCFramework is created as you mentioned in https://github.com/googlemaps/google-maps-ios-utils/blob/main/.github/workflows/release.yml#L46...L50
I'm not sure by this BUILD_LIBRARIES_FOR_DISTRIBUTION=YES.
If you check build options in Xcode and turn actual setting names on (editor > Show Setting Names) you can see that key for Build Libraries for Distribution is BUILD_LIBRARY_FOR_DISTRIBUTION, not BUILD_LIBRARIES_FOR_DISTRIBUTION but that should not be the issue as the setting is set to YES in Xcode project as far as I can see.
If you would take a look at the example project and see if that works for you that'd be appreciated 👍
btw. 3.3.0 does not work in my case, behaves the same as .upToNextMinor(from: "3.4.2")

hey @arriolac I'm also facing this issue, created example Package that uses GoogleMapsUtils package, see https://github.com/libec/GoogleMapsUtilsPackageExample
I checked the script where XCFramework is created as you mentioned in https://github.com/googlemaps/google-maps-ios-utils/blob/main/.github/workflows/release.yml#L46...L50
I'm not sure by this BUILD_LIBRARIES_FOR_DISTRIBUTION=YES.
If you check build options in Xcode and turn actual setting names on (editor > Show Setting Names) you can see that key for Build Libraries for Distribution is BUILD_LIBRARY_FOR_DISTRIBUTION, not BUILD_LIBRARIES_FOR_DISTRIBUTION but that should not be the issue as the setting is set to YES in Xcode project as far as I can see.
If you would take a look at the example project and see if that works for you that'd be appreciated 👍
btw. 3.3.0 does not work in my case, behaves the same as .upToNextMinor(from: "3.4.2")

Closing. Please let me know if anyone is still encountering this issue.

What an odd coincidence. This issue hasn't been touched for months, but 5 hours after it was closed I am experiencing the same issue on Xcode 12.5.
Here is the error message: "Failed to build module 'GoogleMapsUtils' from its module interface; the compiler that produced it, 'Apple Swift version 5.3.1 (swiftlang-1200.0.41 clang-1<IP_ADDRESS>)', may have used features that aren't supported by this compiler, 'Apple Swift version 5.4 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)'"

I found this similar issue which discusses using Library Evolution in Swift to solve this issue. It enables the framework to be built in a way that future versions of the compiler are compatible with it.

PR #335 was supposed to enable library evolution support, but perhaps it is being overridden (or disabled) at some point during the build process. I'll look into this.

In SPM, I set it to Up to Next Major Version, which means it should be the latest version of the library

Any update on this? Having the same issue as @EthanTheInnovator has

I've had a lot of trouble to try to reproduce this last time I looked into this issue. To help with debugging / reproducing, @monRo can you share more details (i.e. your environment, stacktrace, etc.)?

@arriolac sure I can.
Here we go:
Mac OS: 11.4
Xcode: 12.5.1
Steps to reproduce:

XCode -> New -> Project -> App -> Interface: Storyboard, Life Cycle: UIKit App Delegate, Language: Swift
Add new package dependency
Search by google maps utils
Add it to the project
Open ViewController.swift class
Add import GoogleMapsUtils
Build

At this point, I'm able to see the compiler error Failed to build module 'GoogleMapsUtils' from its module interface; the compiler that produced it, 'Apple Swift version 5.3 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)', may have used features that aren't supported by this compiler, 'Apple Swift version 5.4.2 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)'
thx in advance

Please try with v3.10.3

@arriolac what I'm doing wrong? Now can see another error:
Failed to build module 'GoogleMapsUtils' from its module interface; it may have been damaged or it may have triggered a bug in the Swift compiler when it was produced

Did you also include GoogleMaps as a dependency? Unfortunately GoogleMaps is not available in SPM yet so you'll need to do so with one of the install options (CocoaPods, Carthage or manually).

@arriolac my bad, sorry, forgot to add it to a new fresh project. It works. Thanks

I'm having the same issue now:
Failed to build module 'GoogleMapsUtils'; this SDK is not supported by the compiler (the SDK is built with 'Apple Swift version 5.4.2 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)', while this compiler is 'Apple Swift version 5.6.1 (swiftlang-<IP_ADDRESS>3.66 clang-13<IP_ADDRESS>)'). Please select a toolchain which matches the SDK.

Any suggestions on how to get on with this? Does it take a new version of the SDK? Currently installing with SPM and "4.1.0 - Next Major".


Allow setting per-function annotations

This makes it possible to use things like kube2iam which require annotations on the pod.
Eg.
functions:
  myFn:
    handler: handler.myFn
    annotations:
      iam.amazonaws.com/role: role-arn

Hi @SomeoneWeird, you will need to adapt the tests in order to proceed. You need to at least modify the function createDeploymentNocks of test/lib/mocks.js to include the empty object annotations.

Yep - my bad. Thought I ran the tests but obviously didn't. Will fix.

Should be all green now

thanks!


Feat/strapi user interface

This allows usage of interface augmentation for StrapiUser
Also, fixed typescript tsconfig.json and include basic vscode configuration to force usage of local typescript version

@stafyniaksacha Seems that the new configuration doesn't pass the CI, could you please fix it 😄


Waiting for chief to finish

Hello,
I am running Adanet 0.5.0 in GCP with Runtime version 1.10.
I am using a CPU configuration with multiple nodes.
The training phase is very fast but it gets totally slowed down by the evaluations. The evaluation don't seem to take advantage of the multiple nodes and the logs are flooded with "Waiting for chief to finish" messages coming from the workers and generated by Adanet Estimator.
I think support for evaluation phase to use the multiple nodes should be added and that be a priority change as not only the nodes are not used, you also keep paying for them.
Is that feasible?
Thanks in advance
Jose

@picarus: This is a known issue when using the adanet.Evaluator in distributed training.
One way you can make the evaluation much faster is to pass the steps argument to its constructor (e.g. steps=100). This will end evaluation after n batches instead of evaluating over the full dataset. Alternatively if you do not pass an Evaluator to the adanet.Estimator, the Estimator will use a moving average of the train loss to determine the best candidate, and skip evaluation altogether. This option is fine if you have only a single candidate per iteration.
You're right that distributed evaluation should be a supported feature, unfortunately it is non-trivial to implement. Do you have any suggestions how you can shard evaluation across all the workers given an arbitrary input_fn?


[Feature Request] 简易服务器实现

Checklist

[X] I searched exising issues and no one else requests similar feature.
[X] I think that 25%+ users are positive towards this feature.

Describe the feature
为qe和cg提供文档功能
Additional context
No response

https://github.com/Filirom1/SimpleHTTPServer


Overlay and Highlight Polyfunctional Cell Subsets on a FACS plot

I would like to create a plot similar to Fig. 3b from T Cell Responses against Mycobacterial Lipids and Proteins Are Poorly Correlated in South African Adolescents, which highlights cells that are positive for a particular combination of markers on top of a FACS plot.
I figure this is a two-step process:

Identify the small subset of cells from the sample that displays the specific markers of polyfunctionality, e.g. TNF-α+IL-2+, but which are negative for the other markers. I am not sure how to do this. Should I add additional gates to my GatingSet?

Highlight those cells in the FACS plot. I tried using an existing gate to see if I could get geom_overlay() to work, but ran into a couple errors which appear to be unrelated to each other, shown below.

> packageVersion("ggcyto")
[1] ‘1.3.7’
> packageVersion("flowWorkspace")
[1] ‘3.20.5’
> # Check the list of nodes to make sure "8+/TNFa+" is in it
> stopifnot("8+/TNFa+" %in% getNodes(gsSub[["Specimen_001_A2_A02_002.fcs_467210"]], path="auto"))
> # Tried geom_overlay() on my GatingSetList
> ggcyto(gsSub, aes(x = TNFa, y = IFNg)) +
+   geom_hex(bins = 120) +
+   labs_cyto("marker") +
+   facet_grid(Antigen~Time) +
+   ggtitle(title) +
+   geom_overlay("8+/TNFa+", col="black")
 Hide Traceback

 Rerun with Debug
 Error: unsupported overlay data type: ncdfFlowList
9.
stop("unsupported overlay data type: ", class(data), call. = FALSE)
8.
geom_overlay.default(fs.overlay, col = "black")
7.
geom_overlay(fs.overlay, col = "black")
6.
eval(expr, envir, enclos)
5.
eval(thisCall)
4.
eval(thisCall)
3.
add_ggcyto_gs(e1, e2)
2.
ggcyto(gsSub, aes(x = TNFa, y = IFNg)) + geom_hex(bins = 120) +
    labs_cyto("marker") + facet_grid(Antigen ~ Time) + ggtitle(title) +
    geom_overlay("8+/TNFa+", col = "black")
1.
ggcyto(gsSub, aes(x = TNFa, y = IFNg)) + geom_hex(bins = 120) +
    labs_cyto("marker") + facet_grid(Antigen ~ Time) + ggtitle(title) +
    geom_overlay("8+/TNFa+", col = "black")
>
>
> # Tried converting to ncdfFlowList first
> fsSub <- getData(gsSub, "8+")
> ggcyto(fsSub, aes(x = TNFa, y = IFNg)) +
+     geom_hex(bins = 120) +
+     labs_cyto("marker") +
+     facet_grid(Antigen~Time) +
+     ggtitle(title) +
+     geom_overlay("8+/TNFa+", col="black")
 Hide Traceback

 Rerun with Debug
 Error: Don't know how to add o to a plot
8.
stop("Don't know how to add ", objectname, " to a plot", call. = FALSE)
7.
add_ggplot(e1, e2, e2name)
6.
p %+% o
5.
add_ggplot(e1, e2, e2name)
4.
ggplot2:::`+.gg`(e1, e2)
3.
add_ggcyto(e1, e2, e2name)
2.
ggcyto(fsSub, aes(x = TNFa, y = IFNg)) + geom_hex(bins = 120) +
    labs_cyto("marker") + facet_grid(Antigen ~ Time) + ggtitle(title) +
    geom_overlay("8+/TNFa+", col = "black")
1.
ggcyto(fsSub, aes(x = TNFa, y = IFNg)) + geom_hex(bins = 120) +
    labs_cyto("marker") + facet_grid(Antigen ~ Time) + ggtitle(title) +
    geom_overlay("8+/TNFa+", col = "black")

Any advice would be appreciated. Thank you very much.

My latest push should fix your second issue.

Regarding to the first question,  assuming you have all the marginal 1d gates available for all the markers, you can simply create the booleanFilter to combine these 1d gates. e.g.
#A, B , C, D, E are the node paths to corresponding marginal gates, e.g. CD4/TNFa+
g  <- booleanFilter(`A&B&!C&!D&!E`) #using ! to negate the other markers
 add(gs, g, parent = "CD4", name = "A&B")
 recompute(gs, "CD4")
 autoplot(getData(gs, "CD4"), "markerA", "markerB") + geom_overlay("A&B")

Thank you, @mikejiang !
It works great now with booleanFilter(), the GatingSetList, and the ggcyto() plotting command.


Better error info

...than only "Package FSharp.Core is referenced in different versions in test.fsproj"

thx


Headers already sent

Hi,
My php version is 7.4.4 and phpunit version is 9.1.0 when i run my test-sut it gives error
ini_set(): Headers already sent. You cannot change the session module's ini settings at this time
vendor/shardj/zf1-future/library/Zend/Session.php:205
vendor/shardj/zf1-future/library/Zend/Session.php:445
No idea how to resolve this.

Hi, what exactly are you doing?
According to the below linked SO post this means that you've already started sending content back so the headers can't be changed. This isn't something I've ever encountered with the zf1 framework.
https://stackoverflow.com/questions/8028957/how-to-fix-headers-already-sent-error-in-php

I'll re-open the issue once you come back with some more information

I am running into a similar issue, don't know why yet (trying to do a collosal 10-years-forward leap of what the code runs on)
IndexController
 ✘ Initialize [6.55 ms]
   │
   │ ini_set(): Headers already sent. You cannot change the session module's ini settings at this time
   │
   │  vendor/shardj/zf1-future/library/Zend/Session.php:226
   │  vendor/shardj/zf1-future/library/Zend/Application/Resource/Session.php:112
   │  vendor/shardj/zf1-future/library/Zend/Application/Bootstrap/BootstrapAbstract.php:695
   │  vendor/shardj/zf1-future/library/Zend/Application/Bootstrap/BootstrapAbstract.php:638
   │  vendor/shardj/zf1-future/library/Zend/Application/Bootstrap/BootstrapAbstract.php:598
   │  vendor/shardj/zf1-future/library/Zend/Application.php:373
   │  vendor/shardj/zf1-future/library/Zend/Test/PHPUnit/ControllerTestCase.php:142
   │  vendor/shardj/zf1-future/library/Zend/Test/PHPUnit/ControllerTestCase.php:125
   │

wonder if the stack is of any help?


Create AMIs for general use for old Oracle versions

We have the EC2 AMI builder now, rather than guessing what users need I think we should create these base AMIs as and when the need arises.


Create DTO Class

[x] create admin bean class
[ ] create faculty class
[ ] create course class
[ ] create batch class
[ ] create course_plan class

[ ] create AdminDao class
[ ] create AdminDaoImpl class
[ ] create AdminException
[ ] create AdminUseCase

Today I only create the admin workflow - tomorrow I will work on faculty workflow

done ✅


Implement case preservation in search as well

In https://github.com/microsoft/vscode/issues/9798 we implemented some support for preserving the match case while doing a find/replace. We need the same feature in search.

@roblourens , Can I work on this ?

Yes that would be great @skprabhanjan! I want the same button that supports the same "preserve case" logic, but when using search in the side bar. Here is basically what you need to do:
The original PR is here: https://github.com/microsoft/vscode/pull/60311

Add the same button to the replace input that the find widget got
Add plumbing for a "preserve case" option that goes along with the "is regex" and "whole word" and other options
We compute the replace string for search here: https://github.com/microsoft/vscode/blob/ca2eb3be062bb5d6f15788667b523557b9f33dae/src/vs/workbench/contrib/search/common/searchModel.ts#L99 and we need to take the "preserve case" option into consideration here too. So we need to use this same code: https://github.com/microsoft/vscode/blob/ca2eb3be062bb5d6f15788667b523557b9f33dae/src/vs/editor/contrib/find/replacePattern.ts#L55-L64 ideally copying it into a shared file so that find and search will use the same preserve case logic.

Should be relatively straightforward, let me know if that doesn't make sense.

Case preservation is a great feature.
Just to be clear: would it work with editor.action.addSelectionToNextFindMatch / addSelectionToPreviousFindMatch? I use this actions a lot through keybindings and hope this feature will be supported there too.


[Bug]: Fails to load on servers

Bug Description
Adding this mod to a server prevents it from starting.
How to Reproduce?
No response
Expected Behavior
No response
Version
resourcefulconfig-neoforge-1.21-3.0.0
Mod Loader Version
1.21.0-21.0.20-beta
Mod Loader
N/A
Logs or additional context
https://gist.github.com/NielsPilgaard/fe8a8f7a41bc90b54a22e25b7c30271d

Thanks 👍


core/network: Fix bad import %s/runtime_primitives/sr_primitives/

Relates to https://github.com/paritytech/substrate/pull/3214.

Isn't this also the thing that broke master temporarily?

Not quite sure I get the question. This is the thing I was referring to in Riot in regards to the current master failures.


Enhance configs Prop in RangeDatepicker to Include monthsToDisplay

This PR introduces a new enhancement to the RangeDatepicker component. With this update, users can now specify the number of months they want to display in the datepicker.
This enhancement allows for greater flexibility when integrating the datepicker into various user interfaces, especially where space or user experience considerations might dictate displaying a different number of months.
Please review and let me know if any further changes are required.

@nt9142  I got the idea what you are trying to do, there is a typescript error from the PR if you check it locally. Do you want me to fix it for you in this pr or handle it by yourself. And you need to export the props to the datepicker configs level.

@aboveyunhai oops, my bad! I've fixed the TypeScript error and made sure the props are exported correctly. Can you give it another look? Thanks!

@nt9142  lgtm, I also fixed some of my own typescript mistakes (since some of them misguide your code) if you're interested in taking a look.


FormDateSelector change by the model bind

Describe the bug
When my data from api change but the value which the field show is not change. So i want to know how to change the value the field show except press the date selector. Also i bind the property 'date' to the state, the date selector change the date but it can't show in the field. Please help me , thank you.
''
To Reproduce
Steps to reproduce the behavior:

Get data from api

Expected behavior
The date field value can change by value change.
Screens

hots
Smartphone (please complete the following information):

OS: Andriod
React-Native Version 0.70.1
Additional context
Add any other context about the problem here.

I see other field have the Property 'value'

@SpringSan That's an interesting bug, while the form state is not meant to be directly manipulated by providing the value, it exists to be handled by form field state change.
I can however try to add additional state updater binding that to the value prop and updating form state internally.
What you can do is instead of just having date object as a state variable, have the entire intial form values as the state and then when data from API changes try to update the initial values and see if that updates your date field.
Let me know if that works.
I will try to test the usecase whenever I can spare some free time this weekend.

Your suggestion that update the initial values i have tried. It don't works. But if you update the initial values the date selector's value will update, however the field value that show never change.  Also i think the function  'setFeildValue' can update the field value.

And the function onDateChange can't work

@SpringSan  Yes, I get the point. That is only changing the values for submission and not updating the base date picker's value, hence not the updated value in UI. What we could do is that If an existing value exists from the values[name] == name (date picker) as an initial value we can update that from the start or whenever values[name] for date changes. Kind of like an initial setter and onChange trigger.

  useEffect(() => {
    if (values[name] && moment(values[name).isValid()) {
      setFieldValue(name,date);
    }
  }, []);

@SpringSan Something like this, which might not be the best solution at the moment can make things work.

  useEffect(() => {
    if (values[name] && moment(values[name).isValid()) {
      setFieldValue(name, values[name]);
    }
  }, []);

@SpringSan Something like this, which might not be the best solution at the moment can make things work.

Hey，I try to add the code to \node_modules@superforms\superforms-rn\src\Form\FormDateSelector , but it doesn't works. And it seems never go into this code.

  useEffect(() => {
    if (values[name] && moment(values[name).isValid()) {
      setFieldValue(name, values[name]);
    }
  }, []);

@SpringSan Something like this, which might not be the best solution at the moment can make things work.

Hey，I try to add the code to \node_modules@superforms\superforms-rn\src\Form\FormDateSelector , but it doesn't works. And it seems never go into this code.

Hmm, it should have. I will debug this later in the week. Maybe you can add '''values [name]''' in the dependency array.

Ok . Thanks a lot


mysql sink lag reached 206s when inject network partition between cdc and kafka

What did you do?
1、create changefeed for mysql sink and kafka sink separately with the same upstream
2、run sysbench
3、inject network partition between cdc and kafka
What did you expect to see?
will not effect mysql sink lag when inject network partition between cdc and kafka
What did you see instead?
mysql sink lag reached 206s when inject network partition between cdc and kafka

Versions of the cluster
./cdc version
Release Version: v8.2.0
Git Commit Hash: 498e3d3fd1cda4817e70ea50d27dcb157956349d
Git Branch: HEAD
UTC Build Time: 2024-07-03 02:52:36
Go Version: go version go1.21.10 linux/amd64
Failpoint Build: false
2024-07-30T10:59:11.930+0800
current status of DM cluster (execute query-status <task-name> in dmctl)
No response

/remove-area dm
/area ticdc

/assign asddongmen

/severity major

duplicate with: https://github.com/pingcap/tiflow/issues/11340


FALCON-2193 Fix ExtensionStoreTest

Fixes UTs failing after FALCON-2188

:+1:

Build has hung, but, has gone past the UT failure. Merging.


feat: prevent IpRanges with length smaller then /16

Description
Changes proposed in this pull request:

prevent IpRanges with length smaller then /16

Related issue(s)

/retest


Add star to Galsim decoder

Merged star and galaxy into one decoder
Cleaned up redundant classes in case_studies folder
The notebooks are used for model testing and will be modified after the next step.

Hi @ismael-mendoza, thank you for pointing it out, and just fixed it!


Firefox bug

I tested firefox browser and got issue
Playwright::Error (Error: Navigation failed because page crashed!
=========================== logs ===========================
navigating to "https://be.oui.sncf/en", waiting until "load"
============================================================
Note: use DEBUG=pw:api environment variable to capture Playwright logs.):

Can you please check on your side?

Could you describe how to reproduce the issue?
I tried this and worked as expected.
  playwright.firefox.launch(headless: false) do |browser|
    page = browser.new_page
    page.goto('https://be.oui.sncf/en')
    puts "DONE"
  end

Playwright.create(playwright_cli_executable_path: './node_modules/.bin/playwright') do |playwright|
      context = playwright.firefox
      context.launch(headless: false) do |browser|
        page = browser.new_page
        page.goto @url, timeout: 60000
      end
    end

Can you please try this?

Not reproducable...


Feature request - Force HTTPS if LetEncrypts is enabled

Could we redirect all http (except ACME ~/.well-known/*) to https if LetEncrypts option is enabled ?
And adding HTTP Strict Transport Security
Thanks.

If Let's Encrypt is enabled it is already redirecting the requests to HTTPS, it's just not setting the HSTS header.

Hi @tboerger ,
I re-check my drone server (v0.8.1) via curl, and this is what I got (I replaced hostname and ip)
$ curl -vvv http://drone.example.com/
*   Trying <IP_ADDRESS> ...
* Connected to drone.example.com (<IP_ADDRESS>) port 80 (#0)
> GET / HTTP/1.1
> Host: drone.example.com
> User-Agent: curl/7.43.0
> Accept: */*
>
< HTTP/1.1 200 OK
< Access-Control-Allow-Origin: *
< Cache-Control: no-cache, no-store, max-age=0, must-revalidate, value
< Content-Type: text/html; charset=UTF-8
< Expires: Thu, 01 Jan 1970 00:00:00 GMT
< Last-Modified: Wed, 08 Nov 2017 15:47:23 GMT
< X-Content-Type-Options: nosniff
< X-Drone-Version: 0.8.1+build.1318
< X-Frame-Options: DENY
< X-Xss-Protection: 1; mode=block
< Date: Wed, 08 Nov 2017 15:47:23 GMT
< Content-Length: 370

Then I try to access via http url on browser => it redirected to Github OAuth page with redirect_url was an http url
Thanks !

We already have HSTS header provide by middleware Secure
// Secure is a middleware function that appends security
// and resource access headers.
func Secure(c *gin.Context) {
	c.Header("Access-Control-Allow-Origin", "*")
	c.Header("X-Frame-Options", "DENY")
	c.Header("X-Content-Type-Options", "nosniff")
	c.Header("X-XSS-Protection", "1; mode=block")
	if c.Request.TLS != nil {
		c.Header("Strict-Transport-Security", "max-age=31536000")
	}

	// Also consider adding Content-Security-Policy headers
	// c.Header("Content-Security-Policy", "script-src 'self' https://cdnjs.cloudflare.com")
}

This handler is enabled if let's encrypt is active, so it clearly redirects: https://github.com/drone/drone/blob/master/cmd/drone-server/server.go#L568

Sorry but please look to reality that "no redirect" in my context (I enabled LetEnscrypt, used 0.8.1)
Btw, your mentioned code just prove that "http" uses the same handler with "https", but no redirecting middleware or something do it.
Thanks.

Damn, right... @bradrydzewski why have you dropped the HTTP to HTTPS redirect if Let's Encrypt is enabled? I'm sure we had a redirect in there before...

This seems to be missing again in 1.0.0-rc.1.

it has to be configured in 1.0
DRONE_HTTP_SSL_REDIRECT=true
DRONE_HTTP_SSL_TEMPORARY_REDIRECT=true
DRONE_HTTP_SSL_HOST=cloud.drone.io
DRONE_HTTP_STS_SECONDS=315360000


Menu with sublists can have many items marked as hovered

OpenUI5 version:
Version 1.77.2
Browser/version (+device/version):
Google Chrome 81.0.4044.138
URL (minimal example if possible):
https://sapui5.hana.ondemand.com/#/entity/sap.ui.unified.Menu/sample/sap.ui.unified.sample.MenuItemEventing
Steps to reproduce the problem:

Open sublist
Hover sublist item
Move mouse out of Menu component
Hover any other list item

What is the expected result?
Last hovered list element is marked as hovered
What happens instead?
As many hovered items as many list and sublists of the menu

Hello @salarenko ,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Tsanislav


set up complete graph if n<=d

If the number of nodes in a channel is smaller or equal than the requested degree, a fully connected graph is used. For n>d, a random d-regular graph is set up. (For n=d+1, the two are the same.)

Nice! We needed this fix.
Perhaps we should also check that both n and d are both higher than 1?
Also, I have seen another crash error that occurs when both n and d are odd numbers. It complains that nd has to be an even number. I temporarily solved it by allowing only even numbers for d, so that we are sure that dn is always even. Not sure if you see any other way to fix it here.

It would be easy to relax the condition in the underlying library code, but I don't think we want to touch that library now. Even numbers are fine, all examples I know of anyway happen to use even numbers anyway :-)

Good, we merge it then.


Significant reorganization of the project's structure

This PR significantly reorganizes the project's structure.
Changes:

Add CLI arg parsing
reorganize folders to be more welcoming to new contributors ("data" is more clear")
I re-ran imageoptim yielding a diff, but would rather automate this using actions as well. I will create another ticket.

Proof that the Prettier step is working before I fix it1


DataTableContext refresh in script ignores applied filters

Description

In Step 1, a book is created, and its bookId is stored in the pageContext.
Upon proceeding to Step 2, a dialog prompts the user to select a school. The configurations are done on after next within step 1
After the school is selected, a new subject is created, and the table in Step 2 is filtered using the bookId from Step 1.
The table is refreshed afterward. However, the getAll endpoint, which is triggered via a script, does not pass the filter.

Steps to reproduce the behavior:

Go to 'https://functional-adminportal-test.azurewebsites.net/dynamic/TestModule/book-refresh'
Click on 'Add'
Open your nextwork/console
Enter all the details in step 1 then click on Next button
From the pop-up, select a school
Afterwards, check the table endpoint to see if the filter was applied and confirm if the console shows the ID used to filter with on the dataTable
Actual results: The subject getEndpoint does not pass the filter a

Expected behavior
Upon refreshing the dataTableContext 2, the filter should be applied

Hi @hlayisanimazuze @ktsapo
Let's start with this - https://www.mendix.com/blog/asynchronous-vs-synchronous-programming/
All actions on the button in Shesha are asynchronous. This is evident from the description of the methods:

Including you return a Promise object, which is executed asynchronously. This means that the system will not wait for the execution to complete, but will perform the following actions immediately.
Displaying a Modal Dialog is also asynchronous, otherwise, when displaying a Modal Dialog, the browser's response to any other events (including sending and receiving data) would be blocked.
If we return to the form configuration, then in the case where you configured the sequence as follows

Entered data at Step 1
Clicked the Next button, the BeforeNext script is executed, in which a request to create a book is sent. You return a Promise object, which is a response as onSuccess. The execution of the Promise is asynchronous, so the next action is started immediately.
The next action is AfterNext. There you call the Modal Dialog. Opening the Modal Dialog is asynchronous, so the next action is started immediately.
The next action is to display Step 2, in which a request is immediately sent to receive data for the table with the filter that is currently available. But, given that all actions were asynchronous, the request sent in point 2 (creating a book) may not yet return a response. Or it could have returned a response and the filter seems to be there, but... look what happens next
For the table in Step 2, we need a Book-School (Subject) link, which is created after closing the Modal Dialog. That is, even if there is a BookId, the request for the table will not return the correct data, since it does not exist yet.

Okay, our first request cannot return the correct data, what next...

In the Modal Dialog, we select a school, click the custom Next button and run the script to create the Book-School (Subject) link. This action is also ASYNCHRONOUS! And just like in point 2 - you return a Promise object, which is a response as onSuccess. The execution of the Promise is asynchronous, so the next action is started immediately.
And the next action is closing the window and another one is refreshing the table.
But the request to create the Book-School (Subject) connection has only just been sent, it is also ASYNCHRONOUS, the response has not been received and the object has not yet been created!
Therefore, the request for the table will also work incorrectly...

Okay, what needs to be done...
You just need to set the filter value at the end of all asynchronous actions that return data.
In the case of your form - onSuccess when creating the Book-School (Subject) connection. Since in this part of the code we have access to BookId only through PageContext, we simply add a new field

which we then use in the filter

In addition, there is no need to manually call the script to refresh the table. The table will refresh as soon as the filter value changes.
But I personally don't like that several unnecessary queries are executed for the table, which in principle cannot return correct data. It would be good to get rid of them

At the moment we don't have the ability to perform a query to get data for a table by condition.
But we can add a condition to the Hidden field so that the table is hidden until a value is set for the filter.

This way the table will be refreshed only once, when all operations for normal filtering are completed.

We have only 4 requests:

Create Book
Request list of schools
Create Item
Request data for Step 2 table


"Point in direction" angle picker makes degree symbol appear (e.g. 15º)

Expected Behavior
No degrees symbol should appear inside the input for the "point in direction" block.
Actual Behavior
Sometimes a degrees symbol appears as part of the number in the input, e.g. -60º
Steps to Reproduce
Drag out a "point in direction block"
Click the degree input to open the angle picker widget
Rotate the angle picker counter-clockwise past 0, then dismiss the angle picker. Sometimes (!) the degree symbol appears:

Operating System and Browser
Mac OS 10.11.6, Chrome 56

Possibly related to https://github.com/google/blockly/issues/973

Getting rid of the degree symbol entirely is easy, if that's the desired behaviour.  Just take out the appropriate code from FieldAngle:setText.
The "sometimes" on the degree symbol appearing is probably related to this bug: https://github.com/LLK/scratch-blocks/issues/581

I could consistently make it happen by moving my mouse while the input was closing, and could consistently make it not happen by leaving my mouse still.  The difference between those two is probably a setText vs. setValue problem (again).

Possibly fixed here: https://github.com/google/blockly/pull/1044

Is this bad though?

I like the little degree symbol.

Yeah, people who know radians but not programming might be confused, and I think the "low-floor" policy applies here :P

Agreed, though, of course, the degree system has to always be visible in that case – regardless of whether the input is 0, a typed in number, or a degree-picker number.
Also, the "set size to" block actually has this spec: set size to %n%. That displays as set size to (number)%. Note that even if you put a block inside of the input, the percent symbol will still be visible. Perhaps, for consistency, a ° symbol should be placed at the end of the point in direction block..?

I agree.
On Wed, May 3, 2017 at 3:08 AM, Liam<EMAIL_ADDRESS>wrote:

Agreed, though, of course, the degree system has to always be visible
in that case – regardless of whether the input is 0, a typed in number,
or a degree-picker number.
Also, the "set size to" block actually has this spec: set size to %n%.
That displays as set size to (number)%. Note that even if you put a block
inside of the input, the percent symbol will still be visible. Perhaps, for
consistency, a ° symbol should be placed at the end of the point in
direction block..?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/LLK/scratch-blocks/issues/843#issuecomment-298870989,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARIzhgglkxE1e1yCKMsIvOYQ1O5-StQRks5r2FIHgaJpZM4Mbk9F
.

Fixed when we updated the angle picker!


using multiple 'or' clause ignores 2nd 'or' clause

when writing a query using multiple 'or' clauses, it will return the records that match the first 'or' clause and ignore the 2nd or clause. This is the code that I have attempted but doesnt work.
Employee.find()
   .where({
   or:[
      {
         locationId:employee.currentLocation.id
      },
      {
         facilityId:employee.facilityId,
         userName:employee.userName,
         accountOwner:true
      }
   ]
},
{
   or:[
      {
         employeeId:{
            startsWith:params.search.value
         }
      },
      {
         fullName:{
            startsWith:params.search.value
         }
      },
      {
         street:{
            startsWith:params.search.value
         }
      },
      {
         emailAddress:{
            startsWith:params.search.value
         }
      },
      {
         employeeType:{
            startsWith:params.search.value
         }
      },
      {
         status:{
            startsWith:params.search.value
         }
      }
   ]
})

You're sending your second or clause as a second argument into .where. It's not part of the same object. It might help if you format your JSON since it's kind of hard to read.

I tried this in many different ways including putting the 'or' clauses in seperate where clauses, in the same where clause, using an 'and' clause, but seems to not work

You can only have a single or key in the object. Imagine an object like this:
{
  name: 'bob',
  name: 'tom'
}

Which is what you end up with in the above object. Im not sure what your above query would look like in SQL but for this it might be easier to run two separate queries.

if i were writing this in sql, it would be something like this.
'''
select * from employees where (locationid = :locationid or (facilityId= :facilityid and userName = :username and accountowner = true)) and (employeeId like :searchvalue or fullname like :searchvalue or street like :searchvalue or emailAddress like :searchvalue or employeetype like :searchvalue or status like :searchvalue)
'''

What If i want to use multiple OR in my query and ?
For example:
SELECT *
FROM "notification"
WHERE ("endDate" >= '2015-02-16'
       OR "endDate" IS NULL)
  AND ("startDate" <= '2015-02-16'
       OR "startDate" IS NULL)

In Waterline, this need to be look like:
Notification.find({
  or: [
    {
      "endDate": {
        '>=': '2015-02-16'
      },
    {
      "endDate": null
    }
  ],
  or: [
    {
      "startDate": {
        '>=': '2015-02-16'
      },
    }
    {
      "startDate": null
    }
  ]
});

But the generated SQL is wrong :(

This looks like a new feature, but a new feature which would need to be implemented in the adapters. If we are talking SQL, waterline-sequel may be the right place to start.

or :[[], []] would make sense. Nesting could go as deep as wanted.

How to write this query in waterline ?
select * from test_mas where
(perameter='test1' and type='asd') or
(perameter='test1' and ref_no='reg3' and order_no=2)

@pranaysonisoft This isn't a question for github issues. Either post it on stackoverflow, IRC, or on gitter.
But because I'm such a nice guy (ha), here's your answer:
TestMas.find({
  or: [
    {
      parameter: 'test1',
      type     : 'asd'
    },
    {
      parameter: 'test1',
      ref_no   : 'reg3',
      order_no : 2
    }
  ]
});

How to write this query in waterline ?
select * from test_mas where
(perameter='test1' or type='asd') and
(perameter='test2' or type='def' )

Hi @ibtisamniche-vteams , I want to do exactly the same thing! Did you find a solution?

This last query works for Mongo, but does not work for sails-mysql


Publishing full TSDF/ESDF maps

Hello, are there any plans to publish the full esdf/tsdf maps on ROS topics as was the case with Voxblox? I really liked that implementation, also with the option to only publish updated blocks. With the currently published map slices it is hard to implement any type of 3D navigation on top of nvblox.

Hi there.
This is a really good question and something that I've thought a bit about. You're correct that at the moment there really is no good way for downstream nodes to consume the 3D map.
Our friends at NVIDIA research who use nvblox for path-planning for robot arms (and who use nvblox for 3D mapping), take the approach of building nvblox, the ROS independent library, into their path-planner. But ideally, we'd like people to be able to consume the map in ROS.
Unfortunately, I think that with the resolution and rates nvblox is typically run at, the approach we took in nvblox of transmitting map deltas is not ideal. In nvblox we'd have to copy 3D voxels back to CPU, potentially serialize them, and copy them back to the GPU on the receiver(s) end. I think that for typical usage this would be too inefficient.
The correct approach, I think, is to do messaging using shared GPU memory. This is possible in ROS2, see here for example for the isaac_ros flavor.
There is a chance we'll do this in the future, but we'll have to see where the project goes.

I see. Seems like the shared GPU memory messaging would be a good approach then. Thanks for the advice, I will try to integrate nvblox directly into my project then.
For anyone who still wants a quick way to share the 3D map inefficiently, what I did was modify the pointcloud publishing function to publish a pointcloud of the full 3D map every time. On my end, I then stored the pointcloud in a hashmap which took a couple seconds for a pointcloud of about 0.5-1M points (working on CPU, no GPU accel) - usable for prototyping.

I have to add that it would be nice to at least have a ros interface for querying individual voxel values. I know it wouldnt perform too well but it would be at least something


NOTIFY could be lost until some network activity happens while using the same connection for queries and listening

When cursor is finished, check for incoming notifies that could have been delivered to the connection while connection hasn't been registered as reader.

Test case attached which hangs on unpatched version.

Thanks a lot, I pushed your patch, although I didn't quite like calling doRead manually, with no pending read events on the socket, so I just separated out the method checking for notifies and call it both when the reactor schedules doRead on the connection and when a cursor finishes.
Come to think of it, ideally that method would be called whenever doRead is called, even if it's inside the cursor. This way you wouldn't have to wait for your long query to finish to get notify events. I guess I'll make it work like this in a follow-up commit.
 After the API has been decided to only make the connection pollable (which makes more sense, anyway) that slightly artificial separation lived on in txpostgres.
Anyway, thanks a lot for the patch and the test case!


Remove Terraform duplication in streaming/

See this comment.
The Terraform inside /streaming/kafka-strimzi/terraform is mostly identical to the Terraform added by https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/pull/725.
We should minimize this duplication.
This would involve:

[ ] creating more generic (re-usable) Terraform (e.g., inside /streaming/kafka/terraform)
[ ] updating the two tutorials (Strimzi and Confluent) to use the new generic Terraform (/streaming/kafka/terraform)
[ ] removing unused Strimzi-specific and Confluent-sepecific Terraform from this repo

We should consider create a Terraform module (or modules) shared repo-wide.
More Terraform (similar to existing Terraform) was introduced via https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/pull/1487/files.


test

Codecov Report

:exclamation: No coverage uploaded for pull request base (build-target@538529e). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             build-target       #2   +/-   ##
===============================================
  Coverage                ?   55.25%
===============================================
  Files                   ?      176
  Lines                   ?    10608
  Branches                ?        0
===============================================
  Hits                    ?     5861
  Misses                  ?     4166
  Partials                ?      581

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


python311Packages.huggingface-hub: 0.20.2 -> 0.20.3

Description of changes
Changelog huggingface-hub: https://github.com/huggingface/huggingface_hub/releases/tag/v0.20.3
cc @kira-bruneau
Changelog huggingface-hub: https://github.com/huggingface/transformers/releases/tag/v4.37.0
cc @pashashocky @happysalada

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I've got a nixpkgs running and so far I have 10 failures that seem unrelated
├─ ⏸ python3.11-spacy-transformers-1.3.4
┃    │  ┌─ ⚠ python3.11-flax-0.7.5 failed with exit code 1 after ⏱ 6s in pythonRuntimeD…
┃    ├─ ⏸ python3.11-dalle-mini-0.1.5
┃    │  ┌─ ⚠ python3.11-sudachidict-core-20230927 failed with exit code 1 after ⏱ 14s i…
┃    ├─ ⏸ python3.11-sudachipy-0.6.7
┃    ├─ ⚠ tts-0.20.2 failed with exit code 1 after ⏱ 8s in pythonRuntimeDepsCheckHook
┃    ├─ ⏵ python3.11-shap-0.43.0 (pytestCheckPhase) ⏱ 1h28m26s
┃    ├─ ⚠ rclip-1.7.6 failed with exit code 1 after ⏱ 0s in pythonRuntimeDepsCheckHook
┃    ├─ ⚠ python3.11-libretranslate-1.5.2 failed with exit code 1 after ⏱ 1s in patchPh…
┃    ├─ ⚠ wyoming-faster-whisper-1.0.2 failed with exit code 1 after ⏱ 3s in pythonRunt…
┃    ├─ ⚠ khoj-1.0.1 failed with exit code 1 after ⏱ 3s in pythonRuntimeDepsCheckHook
┃    ├─ ⚠ python3.11-cleanlab-2.5.0 failed with exit code 2 after ⏱ 30s in pytestCheckP

the runtimedepscheck is failures because of multiple outdated depedencies.
my review appears to be stuck on shap pytestCheckPhase.

my review appears to be stuck on shap pytestCheckPhase.

Yes, stuck on shap as well...

I'm personally fine with merging this. I'm going to leave it open for a few more days to give people time to have a look, just in case.

I'm personally fine with merging this. I'm going to leave it open for a few more days to give people time to have a look, just in case.

Yes, there is nothing amazing in this update. I would be very surprised if it would break anything.


add build include_rados tag to prevent MAKE failing

According to https://github.com/docker/distribution/pull/443

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:RyanDeng/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Thanks for the PR, however the driver tests are not executed at all even the build tag is provided (e.g. go test -test.short -tags "include_rados" ./...).

@RichardScothern PTAL

@gierschv I'm not sure. When I run go test -test.short -tags "include_rados" ./... , the error happened again.
 ../github.com/noahdesu/go-ceph/rados/conn.go:5:29: fatal error: rados/librados.h: No such file or directory

Does that mean the rados driver test is being executed?

@RyanDeng  thanks for this submission - I was just about to do it myself
@gierschv : you can bulid/run the tests as follows with this PR like this:
make [test] DOCKER_BUILDTAGS=include_rados

@RichardScothern My point is that the build tag is not applied when executing the tests themselves (only in the build step of go test), the package is just skipped while testing (DOCKER_BUILDTAGS=include_rados for the examples below):

Makefile go test -test.short -tags "$DOCKER_BUILDTAGS" ./...: KO, the package is skipped;
Circle CI: go list ./... | xargs -L 1 -I{} godep go test -tags "$DOCKER_BUILDTAGS" -test.short -coverprofile=$GOPATH/src/{}/coverage.out {}: KO, go list doesn't list the package github.com/docker/distribution/registry/storage/driver/rados and the tests are skipped (see the current build of this PR). I tried a go list -tags ..., but the parameter looks to be ignored;
go test -test.short -tags "$DOCKER_BUILDTAGS" github.com/docker/distribution/registry/storage/driver/rados: OK.

Cheers,
Vincent

@gierschv
The current scenario is that when anyone tries to build the registry with make and they don't have librados source on their machine, the build fails.  I don't think it's necessary to build it by default with the makefile.  With this PR anyone developing the ceph storage driver can do so as follows:
DOCKER_BUILDTAGS=include_rados go build -tags "$DOCKER_BUILDTAGS" -v ${GO_LDFLAGS} ./...
DOCKER_BUILDTAGS=include_rados go test -tags "$DOCKER_BUILDTAGS" -v ${GO_LDFLAGS} ./...
DOCKER_BUILDTAGS=include_rados make [test]
However we do want the ceph storage driver to be built and tested on the build machine.  It looks like go list should obey build flags (which include -tags), but I also could not make it work.   We'll need to solve this before we can merge this.
cc @RyanDeng

I think we are encountering a bug in go list/go test when no files are left in a package after applying tags. I've described it here: https://github.com/golang/go/issues/4515#issuecomment-112627167.
A fix is forthcoming.

Note that I've filed go/golang#11246 to report the original issue.
Closing this for #637.


Create colostate.txt

Please add this school to the list

@Win-rose I am sorry, the domain colostate.edu is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


@WithFixtures and @WithContainer not auto-loaded

The @WithFixtures and @WithContainer are not autoloaded. It needs to be explicitly declared within the composer.json.

Fixed in version 1.0.1


Add previous video text from content item

@DilwoarH the review app page doesn't work - does it require some changes in the yml to be deployed first?

@DilwoarH the review app page doesn't work - does it require some changes in the yml to be deployed first?

Hi Yes - needs new content deployed to live


Make children select work as it should

I have a question:
Sorry if I misunderstood the way it should work. I have the following html:

  Span #1, in the div.
    A

   B

and my test as:
wrapper.find('.Item > span').length == 1 // and  'should' be true but it returns 2

This is not how the css selector should behave?

This is the correct behavior I believe.
There are two elements that match that selector, the first span tag, and the second span tag. Both are direct descendants of an element with .Item class


files names in tutorial

If a user follows: https://github.com/biocore/empress#example-using-empress-in-qiime-2; the sample_metadata.tsv downloaded file is actually named: Moving\ Pictures\ sample-metadata\ \(QIIME\ 2\ 2019.10\)\ -\ sample-metadata.tsv.

Oh, dang. That's annoying -- thanks for the catch!
From what I can tell, the most recently released Q2 moving pictures tutorial deals with this by asking the user to download and save the file as sample-metadata.tsv, or providing wget/curl commands that name the file properly.
My preference here is limiting the tutorial's complexity as much as possible, so I vote for us changing the sample metadata download link to point to the copy of the sample metadata file included in this repository. This link opens up a new tab (in my browser at least), and hitting ctrl-S in this window defaults to saving the file as just sample_metadata.tsv, as expected.

Sounds good to me but I think then we should a step in the travis build that runs those commands, just in case something changes in future either in QIIME 2 or empress ...

Would modifying the README's view/download links to all point to these files' location in the Empress repo be an acceptable solution? There's already a basic integration test that uses these QZA / metadata files, so we should be able to safely assume that these files are available.

Testing the tutorial would be great, but I think that will be easier if/when the plugin is integrated with QIIME2. Either of the solutions proposed here work, so as long as the tutorial works 👍


Windows \ issue

File names are read as assets\script.js instead of assets/script.js. This creates files at the root.

Closed in #3


Reimplement Twitter timeouts against older client

:ocean:
/cc @zendesk/ocean
Description
Branch the Twitter gem off from the same SHA from which Henry's work was branched, and add support for timeout settings
References

JIRA: https://zendesk.atlassian.net/browse/TWITTER-892

Risks

Medium: could cause Twitter deauthorizations to recur (once this is used in Channels)

:+1:


Reduce the memory to <= 3 GiB, when QEMU >= 7.0 && macOS <= 12.3 && CPU == M1

QEMU 7.0 beta is known to cause host kernel panic on M1 (Prox/Max only?) when the guest memory exceeds 3GiB limit, but the host kernel panic is reported to be fixed in macOS 12.4 beta
https://gitlab.com/qemu-project/qemu/-/issues/903#note_911000975
But not all people can upgrade macOS immediately, so probably we should reduce the default memory to 3GiB when QEMU >= 7.0 && macOS <= 12.3 && CPU == M1 .

Is this still present in qemu 7.0.0 release?
Perhaps there is a better way to detect this state than just the version?

Okay, upgrading my os the 12.4 seems to have made the error go away.
Apologies

How do I go about downgrading qemu?

Thanks @Amar1729 that Podman issue fix worked for me! However I had to do the following:
$ curl -L -H "Authorization: Bearer QQ==" -o qemu-6.2.0_1.monterey.bottle.tar.gz https://ghcr.io/v2/homebrew/core/qemu/blobs/sha256:fcc3b1a8139f70dae57f5449f3856f9b3b67448ee0623e64da1e47dc255b46f6
$ while brew list qemu ; do brew uninstall qemu ; done
$ HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK=1 brew install --ignore-dependencies -f ~/Downloads/qemu-6.2.0_1.monterey.bottle.tar.gz lima

Otherwise 1) new versions of qemu would not allow linking the 6.2 version, 2) qemu would auto-upgrade to v7 (the environment variable fixes it), and 3) lima dependencies would auto-upgrade qemu to v7 (--ignore-dependencies fixes it).


Question:  Welcome Pages for Institution and Ministry

What is the Effort to update Content on the the Instition and Ministry ... for Announcements? Is this a deployment to production or a quick thing?
Jason to talk to hugh to confirm reqiurements

@HRAGANBC can you describe more what you want to update- what is the userstories here ;)

Closing as this is replaced by other tickets


[Feature request] Add COUNT NODE query on grafana visualization

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
On grafana variables you have the choice to write an entire query without limitations has shown below:

(i use this query to count the number of cores of a virtual machine, each of which i take data from)
i can't use this syntax on the grafana visualization because i'm forced to use a SELECT statement:

Solution
Add another drop-down selection with a full-customized query editior that allows you to use all the language provided queries as in the grafana variables
Alternatives
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

any updates?


npm run build:windows fails due to unix-style variable substitution

When running npm run build:windows on my Windows 10 machine, I get the following error:
><EMAIL_ADDRESS>build:windows D:\dev\workspace\privat\anatine
> electron-packager . --overwrite --asar --out=dist --ignore='^media$' --prune --platform=win32 --arch=ia32 --icon=static/Icon.ico --version-string.ProductName=$npm_package_productName --app-version=$npm_package_version && cd dist/Anatine-win32-ia32 && zip -ryq9 ../Anatine-windows-${npm_package_version}.zip *

Packaging app for platform win32 ia32 using electron v1.3.3
Fatal error: Unable to parse version string
 undefined

As suggested in https://github.com/electron-userland/electron-packager/issues/400 I changed the variable strings like $npm_package_version in the build script to %npm_package_version%, which did the trick for me. However, this probably breaks the cross-platform build on OSX, so I don't think it advisable to change the build:windows script to include this 'fix'. Maybe truly cross-platform build scripts just aren't there yet. Just wanted to give you a heads up.

I'm working on switching to electron-builder. Will build on Windows then.


new: usr: #19: Support storing catalog in a DB

Have you forgotten to add the flyway migration files ?

You also need to add end-to-end tests.

I though only one migration would be present with the latest schema and new migrations would be added on top of that. Any reason why so many migrations are required in this change ?

Pro for keeping all the migration files is that it is compatible with the internal system and we can merge them eventually. It is worth a debate.

@vrajat  that is a good point to keep DB compatible with internal system. But for that keeping future migrations in sync with internal service is good enough. We do not require to carry old migrations for that.

So lets say internally we are up to V10 internally. We could merge all the changes and call it V11. So V1-V10 == V11. Going forward we use V12 in both systems so that they can be merged eventually. Will that work ?

yeah... that should work. Our tests for nezha server currently runs migration V1 to V10. After merging I assume V1- V10 would be dropped requiring them to run just V11 onwards and that should be fine.

I dont think we can have V11 in internal server. Current DBs have till V10. So internal server cannot be changed. Going forward, both can be in-sync from V12

@adeshr The code seems almost in shape. I see three more tasks:

Need unit tests - talk to @amoghmargoor or me to choose the tests.
Need to decide on flyway migrations. I am not convinced either way.
Module/Code organization. I'll start another comment about that.

@adeshr @amoghmargoor I thinking about code organization.
This code seems like the catalog module of a database. This is what I propose:

Start a new module catalog which contains schemafactories for both JSON and DB. Its the current code.
Namespace is com.qubole.quark.catalog.[json|db]
jdbc module adds it as a dependency.

The pros are that it is more usable if split into its own module.

In the future, quark-server also adds it as a module.
Possible a custom implementation of the server can also use it.

In the current state, both of them have to depend on jdbc module which is unnecessary.
What is your opinion ?

@adeshr lets keep migrations as is.

Logic & tests looks good. Code needs cleanup.

Can pojo/* and 'Relschema::Db*' classes be merged ?
There should be only one definition tests for Select and Metadata
Extract common code from model tests.

Moving pojo/Cube to RelSchema can be confusing since there is already a DbCube.
DbCube can not be merged with Cube because:

DbCube needs List/List/List to be present.
To read dimensions/measures from db we need cube id to be present.
one needs the other, that's why Cube (Intermediary class) was created, which stores cube from db, then read dimensions/measures and create DbCube from cube/dimensions/measures.

Good to merge. @adeshr did you try to rebase ? If not successful, I'll squash merge

hmm - Just realized a missing piece. You are assuming that there is a record for DSSet. Lets tackle that in a different task.


Add support for Rust files (.rs)

As far as I can see Rust files currently use the default file icon.

I'm creating an app with Tauri using Rust Lang, and I'd also love to see this ✨


Allow the option use the call and create contract host functions

Resolves #29 and related to #22.
The two new commands take a JSON SCVec as an argument. I haven't updated how arguments are passed to the existing command that invokes WASM directly, but wanted to get input on this change before moving forward.
The user experience also isn't great, but I think we can make some improvements. The user needs to construct the JSON, which isn't really feasible by hand. For example, I tested this by using a rust test case and printed out the arguments that I wanted.

cc @paulbellamy who is working on:

#22.

@leighmcculloch The github checks are failing because I stopped using strval. I'll fix that if we agree on the change in this PR.


Todo: /role command

What should this command do exactly?

Main thing was replace all of these

Probably in a similar way to what the Cloudflare Developers Discord has:

Oh I see, will get to working on it soon.

Btw last question, should I use the announcement roles or make a new "grantable roles" field incase there can be any role that isn't related to announcements but can be self-granted?

make a new "grantable roles" field incase there can be any role that isn't related to announcements but can be self-granted?
This seems like it would make the most sense - there can be a config mapping of role names and IDs to populate the list with

I'll see, I have implemented something at least but can't test it because for some reason the new command doesn't get registered on my own testing bot.

D#+ doesn't expose registration errors very well, if a command isn't registering then try checking that all descriptions are within the character limit and that there are no capital letters in command and option names. Could be a number of things but that's the most common I run into


Windows MR Converter should report file not found errors

Using the tool this am. I thought it was broken, but it I just had a typo on the file name that I was entering. Would it be possible to report file not file not found or similar text.

Fixed by #16 . Thanks @erikdahlstrom !


Demo title Add files via upload

@dianawilde go to hell stop spamming

Pull Request Test Coverage Report for Build 768351670

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.032%

Totals

Change from base Build 766149280:
0.0%

Covered Lines:
199

Relevant Lines:
211

💛  - Coveralls


merge from konsum-frontend-svelte

package.json

chore(scripts): add testcafe $BROWSER:headless tests/cafe/*.js -s build/test --app-init-delay 7000 --app "{{testcafe.app}}" (scripts.test:cafe)
chore(deps): add ^10.7.6 remove ^10.7.5 (devDependencies.npm-pkgbuild)

.github/workflows/ci.yml

chore: ()

:tada: This PR is included in version 1.31.18 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.31.18
GitHub release

Your semantic-release bot :package::rocket:


Less than or equal sign does not appear in comments.

Whenever I put a "<=" in a comment in student code, it does not get rendered.

This happens when annotation pdf files.

I think I was annotating python .py files?

Hmm.  I can't replicate it when adding annotations to code files, but I do see the problem when adding an annotation for a pdf file.

Working on this. Also could not replicate this on .py files.