$query->modelClass returns a String

http://www.yiiframework.com/doc-2.0/yii-db-activequerytrait.html#$modelClass-detail
modelClass is a string, not an object.
cannot apply ->tableName() to a string.
object must first be created from this string.

Q
A

Is bugfix?
yes/no

New feature?
yes/no

Breaks BC?
yes/no

Fixed issues
comma-separated list of tickets # fixed by the PR, if any

You are right. I downgraded from Yii2 dev to <IP_ADDRESS> stable. now it works.
On 20 June 2017 at 09:34, Sam<EMAIL_ADDRESS>wrote:

@SamMousa commented on this pull request.
In models/UserSearch.php
https://github.com/dektrium/yii2-user/pull/937#discussion_r122900063:

@@ -93,7 +93,7 @@ public function search($params)
return $dataProvider;
}

   $table_name = $query->modelClass::tableName();

   $table_name = \Yii::createObject(['class' => $query->modelClass])->tableName();

tableName() is a static function.
So this should work:
$class = $query->modelClass;
$table_name = $class::tableName();
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dektrium/yii2-user/pull/937#pullrequestreview-45053008,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQPCR-H_OyqWEnc3KAN7NCd86X8yy6ixks5sF3YbgaJpZM4N0FH1
.

I downgraded from Yii2 dev to <IP_ADDRESS> stable. now the tableName() function works again.


Add a hook at the very end of the deployment for custom payloads

As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date:

[x] README in the role
[x] Content of the docs/source is reflecting the changes

/approve


highlight js not supporting terraform in update

Terraform does not seem to be supported in the latest version of highlight that you have in gitpitch. Is there a way to add custom language files or a PR process to request them?

Hi Stephen. So GitPitch is currently using highlight.js v9.15.8. Using the full core language bundle. But looking at the list of supported languages it seems that Terraform support is maintained as an external project. So is not currently included in the core bundle used by GitPitch.
To your specific questions:

Is there a way to add custom language files or a PR process to request them?

There is no way for an end user to add support for a custom language. Mainly because it would require the end user to be able to bundle custom JavaScript code with their deck. And the loading of custom JavaScript is forbidden for security reasons. So an RFE like this issue thread is the way to go if you want to request syntax highlighting support for a new (non-core) language.
Looking at the highlight.js repo it appears to have just pushed a major release v10.0.1.  And looking at the release notes this major release contains a number of breaking changes.
So I will need to do a few things before I decide if or when Terraform support could be added. First, I'd like to understand what's involved in upgrading GitPitch to use the new v10.0.0x core bundle. And based on what I learn, decide whether to upgrade to v10.0.x or to simply patch the existing v9.15.x bundle.
I have flagged this thread as an RFE for Terraform syntax highlighting support and will provide an update once I know more.

@smwilson1230 a quick request. Can you please add a few sample Terraform code snippets to this thread so I have good representative code blocks to use for testing. Thanks, David.

auto_auth {
method "aws" {
mount_path = "auth/aws"
config = {
type = "iam"
role = "dev-role-iam"
}
}
}


Addresses several open issues

Signed-off-by: Frances Coronel<EMAIL_ADDRESS>
Fixes #241
Fixes #239
Fixes #251
Fixes #238

✅ By submitting this PR, I have verified the following

[x] Checked to see if a similar PR has already been opened 🤔
[x] Reviewed the contributing guidelines 🔍
[x] Added my name to the bottom of the list under the Contributors section in the README.md with a link to my personal website or GitHub profile 👥

Can you approve this @fvntr whenever you have a chance? Thanks 😄


Quotation marks in primary silently fails entire index.add_document call.

Source
// lib.rs
#![allow(dead_code)]

use meilisearch_sdk::{indexes::Index, Client};
use serde::Serialize;

#[derive(Serialize)]
struct SimpleStruct<'a> {
    id: &'a str,
    value: usize,
}

const NO_QUOTE: SimpleStruct = SimpleStruct {
    id: "test",
    value: 1,
};
const WITH_QUOTE: SimpleStruct = SimpleStruct {
    id: "te'st",
    value: 2,
};

#[tokio::test]
async fn independently() {
    let index = index("test_1");
    add_documents(&index, &[NO_QUOTE]).await;
    assert_eq!(1, get_document_count(&index).await); // passed

    add_documents(&index, &[WITH_QUOTE]).await;
    assert_eq!(2, get_document_count(&index).await); // failed
}

#[tokio::test]
async fn together() {
    let index = index("test_2");
    add_documents(&index, &[NO_QUOTE, WITH_QUOTE]).await;
    assert!(get_document_count(&index).await > 0) // failed
}

fn index(namespace: &str) -> Index {
    Client::new(
        "http://<IP_ADDRESS>:7700",
        Some("xxx"),
    )
    .index(namespace)
}

async fn add_documents(index: &Index, simple_struct: &[SimpleStruct<'_>]) {
    index
        .add_documents(simple_struct, None)
        .await
        .unwrap()
        .wait_for_completion(&index.client, None, None)
        .await
        .unwrap();
}

async fn get_document_count(index: &Index) -> usize {
    index.get_stats().await.unwrap().number_of_documents
}

# Cargo.toml
[package]
name = "meilisearch_pk"
version = "0.1.0"
edition = "2021"

[dependencies]
tokio = { version = "1", features = ["full"] }
serde = { version = "1.0", features = ["derive"] }
meilisearch-sdk = "0.24"

Cargo test
[~/tests/meilisearch_pk] $ cargo test
   Compiling meilisearch_pk v0.1.0 (/home/gibbz/tests/meilisearch_pk)
    Finished test [unoptimized + debuginfo] target(s) in 2.03s
     Running unittests src/lib.rs (target/debug/deps/meilisearch_pk-5f2bfef2460e87ff)

running 2 tests
test together ... FAILED
test independently ... FAILED

failures:

---- together stdout ----
thread 'together' panicked at 'assertion failed: get_document_count(&index).await > 0', src/lib.rs:35:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- independently stdout ----
thread 'independently' panicked at 'assertion failed: `(left == right)`
  left: `2`,
 right: `1`', src/lib.rs:28:5

failures:
    independently
    together

test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.12s

Log
[2023-08-17T14:56:41Z INFO  actix_web::middleware::logger] <IP_ADDRESS> "POST /indexes/test_2/documents HTTP/1.1" 202 136 "-" "Meilisearch Rust (v0.24.1)" 0.000683
[2023-08-17T14:56:41Z INFO  actix_web::middleware::logger] <IP_ADDRESS> "POST /indexes/test_1/documents HTTP/1.1" 202 136 "-" "Meilisearch Rust (v0.24.1)" 0.000921
[2023-08-17T14:56:41Z INFO  milli::update::index_documents::enrich] Primary key was not specified in index. Inferred to 'id'
[2023-08-17T14:56:41Z INFO  index_scheduler] A batch of tasks was successfully completed.
[2023-08-17T14:56:41Z INFO  actix_web::middleware::logger] <IP_ADDRESS> "GET /tasks/1112 HTTP/1.1" 200 302 "-" "Meilisearch Rust (v0.24.1)" 0.000268
[2023-08-17T14:56:41Z INFO  actix_web::middleware::logger] <IP_ADDRESS> "GET /tasks/1113 HTTP/1.1" 200 302 "-" "Meilisearch Rust (v0.24.1)" 0.000114
[2023-08-17T14:56:41Z INFO  index_scheduler::batch] document addition done: DocumentAdditionResult { indexed_documents: 1, number_of_documents: 1 }
[2023-08-17T14:56:41Z INFO  index_scheduler] A batch of tasks was successfully completed.
[2023-08-17T14:56:42Z INFO  actix_web::middleware::logger] <IP_ADDRESS> "GET /tasks/1112 HTTP/1.1" 200 652 "-" "Meilisearch Rust (v0.24.1)" 0.000232
[2023-08-17T14:56:42Z INFO  actix_web::middleware::logger] <IP_ADDRESS> "GET /tasks/1113 HTTP/1.1" 200 338 "-" "Meilisearch Rust (v0.24.1)" 0.000134
[2023-08-17T14:56:42Z INFO  actix_web::middleware::logger] <IP_ADDRESS> "GET /tasks/1112 HTTP/1.1" 200 652 "-" "Meilisearch Rust (v0.24.1)" 0.000207
[2023-08-17T14:56:42Z INFO  actix_web::middleware::logger] <IP_ADDRESS> "GET /tasks/1113 HTTP/1.1" 200 338 "-" "Meilisearch Rust (v0.24.1)" 0.000434
[2023-08-17T14:56:42Z INFO  actix_web::middleware::logger] <IP_ADDRESS> "GET /indexes/test_2/stats HTTP/1.1" 200 65 "-" "Meilisearch Rust (v0.24.1)" 0.000091
[2023-08-17T14:56:42Z INFO  actix_web::middleware::logger] <IP_ADDRESS> "GET /indexes/test_1/stats HTTP/1.1" 200 81 "-" "Meilisearch Rust (v0.24.1)" 0.000280
[2023-08-17T14:56:42Z INFO  actix_web::middleware::logger] <IP_ADDRESS> "POST /indexes/test_1/documents HTTP/1.1" 202 136 "-" "Meilisearch Rust (v0.24.1)" 0.002155
[2023-08-17T14:56:42Z INFO  index_scheduler] A batch of tasks was successfully completed.
[2023-08-17T14:56:42Z INFO  actix_web::middleware::logger] <IP_ADDRESS> "GET /tasks/1114 HTTP/1.1" 200 650 "-" "Meilisearch Rust (v0.24.1)" 0.000207
[2023-08-17T14:56:42Z INFO  actix_web::middleware::logger] <IP_ADDRESS> "GET /tasks/1114 HTTP/1.1" 200 650 "-" "Meilisearch Rust (v0.24.1)" 0.000151
[2023-08-17T14:56:42Z INFO  actix_web::middleware::logger] <IP_ADDRESS> "GET /indexes/test_1/stats HTTP/1.1" 200 81 "-" "Meilisearch Rust (v0.24.1)" 0.000094

Notice how A batch of tasks was successfully completed. is not preceded by document addition done when the batch contained a document with a single quote in the primary key.
Expected behavior
Call to index.add_document should return and invalid_document_id error, preferably explaining that the single quote is an invalid error.

Hey @gibbz00 👋
I moved your issue to the appropriate GitHub repository as it is related to the meilisearch-rust SDK. We indeed use synchronous and asynchronous operations on the Meilisearch side and it should indeed return primary key issues when it is returned synchronously. However, I think the primary key issues are asynchronous and you should probably verify that the task has been processed in the tasks queue first.

Hii :)

I moved your issue to the appropriate GitHub repository as it is related to the meilisearch-rust SDK.

Awesome, thanks for picking this up.

However, I think the primary key issues are asynchronous and you should probably verify that the task has been processed in the tasks queue first.

I did, I'm using wait_for_completion in the given code example.

Hello @gibbz00
thanks for the report
I tagged it as bug. PR are welcome to fix it 😊


sup

you ok?

Noticed whatsapp wasn't sending to you so thought I'd catch you on github 😂

Oh Hello! Yes I'm doing okay thank you for asking tho 😂

good I shall close my issue 😂


Suggestion: check for too long ranges such as [0 to  55555]

Some ranges like [0 to 55555] could be replaced with the runtime variant, instead of generating a giant array in code.
(Please keep in mind I'll make some suggestions with no priority at all, just trying to be helpful.)

CoffeeScript has a limit of around 20 elements, after which it produces a runtime equivalent. So I think that lowering to 5000 elements is still not enough, the code of such arrays takes quite some space in a file.

And maybe produce a runtime equivalent for strings too, after a certain limit? [\가 to \힣] produces quite a large array, but I'll admit there are fewer use cases.


proper location for pictures (and corrected .gitignore for it)

if they are in all kinds of subfolders, graphicspath needs to be set to make also the xourses compile(-to-pdf)

added default graphicspath in ximeraLatex now (ie: use folder pictures in root-of-project)


[PDI-13927] - Checking type before casting, adding null handling in g…

…etDataSourceFromJndi

@dkincade is 5.4 the right branch?
@e-cuellar Mind pulling this down and testing on your box, mysql generic seems to be working with this fix

@brosander @dkincade Brian... I bet this will work! But as you might have found the "dsName" is getting passed as an empty String causing the InitialContext to return an instance of a MemoryContext, which in my opinion... if the dsName is empty or null then this method should not even be called.....  or simply throw a NamingException on a empty dsName and let the flow do the rest....  However I'd be ok with your fix if advised!

@e-cuellar the if check at the top should throw the correct exception if dsName is null now

@brosander Gotcha!... I like it! :) let me check it!

@brosander Sorry Brian... the dsName is not getting passed as null but as an empty string.... thus it will fail the if check.... I suggest using the Const.isEmpty method instead....

@e-cuellar good catch!  The get sql button was passing null in.  I guess we could run into an issue if there was a jndi connectio with an empty name that was matched.

@brosander Awesome!... Checking the fix locally... I will merge in a bit!

@e-cuellar added String.valueOf( dsName ) to ensure we won't get a NPE there either

5.4 is the correct branch - once validated please ensure this is included in master as well.


TELCODOCS-1595:Added values files information

Added information related to values files.

This is an automated message:
You can preview this docs PR at http://405.docs-pr.validatedpatterns.io
Note that they get generated every five minutes, so please wait a bit.

/ok-to-test

/lgtm
/ok-to-merge

@hbisht-RH-ccs I reviewed the doc. I reads very well and I only spotted a few things. Once you've addressed them, we can merge.

/lgtm
/ok-to-merge


Displays incorrect refresh rate when using two monitors with different refresh rates

I have one monitor with 60Hz and one with 144Hz.
fastfetch displays them like this:
Resolution 1: 1920x1080 @ 144Hz
Resolution 2: 1920x1080 @ 144Hz

xrandr output:
Screen 0: minimum 320 x 200, current 3840 x 1162, maximum 16384 x 16384
DisplayPort-0 connected primary 1920x1080+1920+0 (normal left inverted right x axis y axis) 598mm x 336mm
   1920x1080     60.00 + 144.00*  120.00   119.88   119.98    99.93    50.00    59.94
   1680x1050     59.88
   1280x1024     75.02    60.02
   1440x900      60.00
   1280x800      60.00
   1280x720      60.00    50.00    59.94
   1024x768     119.93    99.99    75.03    70.07    60.00
   832x624       74.55
   800x600      119.93    99.86    72.19    75.00    60.32    56.25
   720x576       50.00
   720x480       60.00    59.94
   640x480      119.80    99.83    75.00    72.81    66.67    60.00    59.94
   720x400       70.08
DisplayPort-1 disconnected (normal left inverted right x axis y axis)
HDMI-A-0 disconnected (normal left inverted right x axis y axis)
HDMI-A-1 connected 1920x1080+0+82 (normal left inverted right x axis y axis) 598mm x 336mm
   1920x1080     60.00*+  50.00    59.94
   1680x1050     59.88
   1600x900      60.00
   1280x1024     75.02    60.02
   1440x900      59.90
   1280x800      59.91
   1152x864      75.00
   1280x720      60.00    50.00    59.94
   1024x768      75.03    70.07    60.00
   832x624       74.55
   800x600       72.19    75.00    60.32    56.25
   720x576       50.00
   720x480       60.00    59.94
   640x480       75.00    72.81    66.67    60.00    59.94
   720x400       70.08
DVI-D-0 disconnected (normal left inverted right x axis y axis)

Tell me if you need any additional information.
btw you wrote "informations" in your latest commit. information is an uncountable noun in English ^^

Confirmed. Same here:
Resolution 1: 2560x1440 @ 240Hz
Resolution 2: 2560x1440 @ 240Hz

Screen 0: minimum 320 x 200, current 5120 x 1440, maximum 16384 x 16384
DisplayPort-0 connected primary 2560x1440+2560+0 (normal left inverted right x axis y axis) 698mm x 393mm
   2560x1440    239.96*+ 144.00 + 120.00    59.95
   1920x1200    239.96
   1920x1080    239.76   143.98   120.00   119.88    60.00    50.00    59.94
   1600x1200    239.96
   1680x1050     59.95
   1600x900      60.00
   1280x1024     75.02    60.02
   1440x900      59.89
   1280x800      59.81
   1152x864      75.00
   1280x720      60.00    50.00    59.94
   1024x768      75.03    70.07    60.00
   832x624       74.55
   800x600       72.19    75.00    60.32    56.25
   720x576       50.00
   720x480       60.00    59.94
   640x480       75.00    72.81    66.67    60.00    59.94
   720x400       70.08
DisplayPort-1 connected 2560x1440+0+0 (normal left inverted right x axis y axis) 597mm x 336mm
   2560x1440     59.95*+
   1920x1200     59.95
   1920x1080     60.00    50.00    59.94
   1600x1200     59.95
   1280x1440     59.91
   1680x1050     59.88
   1280x1024     75.02    60.02
   1440x900      59.90
   1280x960      60.00
   1280x800      59.95
   1280x720      60.00    50.00    59.94
   1024x768      75.03    70.07    60.00
   832x624       74.55
   800x600       72.19    75.00    60.32    56.25
   720x576       50.00
   720x480       60.00    59.94
   640x480       75.00    72.81    66.67    60.00    59.94
   720x400       70.08
DisplayPort-2 disconnected (normal left inverted right x axis y axis)
HDMI-A-0 disconnected (normal left inverted right x axis y axis)

3 displays:

It only seems to bother with the refresh rate of the primary display.

Support for different refresh rates in X11 sessions is implemented now. Sorry it took that long. Close this if it works on your machine too.

Works here

Its actually interesting to see where this project has gone.
This is the resolution code of the first version:
void ffPrintResolution(FFstate* state)
{
    Display* display = XOpenDisplay(NULL);
    Screen*   screen = DefaultScreenOfDisplay(display);

    ffPrintLogoAndKey(state, "Resolution");
    printf("%ix%i\n", screen->width, screen->height);
}

Now i wrote over 500  lines of code just for the resolution...

It's shaping up nicely. :)
That said, I've encountered an issue with the latest commit:

It's missing my third monitor(TV).

This is correct for me now

It's missing my third monitor(TV).
Ist it possible that your TV isn't an extra monitor (from a computer point of view) but a second output to an existing monitor (duplicated output)? If this is the case, it isn't implemented yet, but soon to come. I don't know what else could be the problem.

No, it's just another panel as far as Windows and Linux is concerned.
It's not an issue though, as it's showing up now. Must have been a glitch. Funny, as r397 and Neofetch picked it up just fine. :shrug:


fix: include hash & query parameters in callbackUrl

Closes #597 .

Hi @AbdallahAlhaddad 👋
Thanks for the PR! I took the liberty, to resolve the merge conflicts and will move on to a release now!

Hi @zoey-kaiser
Thanks 🙏🏻


Simplify test fixture

TIL: https://docs.python.org/3/library/pathlib.html#pathlib.PurePath.as_uri
I'm about to link this file in a new how-to doc btw

Now only one copy per test session rather than per test 😄

I'm about to link this file in a new how-to doc btw

Hah cool – worst case the whole thing is gonna be good for education.


Consistent ninja crash when my build folder has a specific path

Hi,

ninja 1.11.1
generated by cmake 3.27.1
on an up-to-date arch linux x86_64

I'm having a bewildering issue.. my build suddenly started failing, and only when i'm doing it in a specific path on my machine (I don't have any specific mounts or something funky like that... basic linux on an XFS partition).
it's an issue I sometimes see sporadically but just rm'ing the build folder is enough.. this time it's a persistent repro though.
$ pwd
/home/jcelerier/score-master/3rdparty/libossia/3rdparty/build-libremidi-System_Qt6-Debug

$ cmake ~/score-master/3rdparty/libossia/3rdparty/libremidi -GNinja -DCMAKE_BUILD_TYPE=Debug
-- The CXX compiler identification is GNU 13.1.1
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- libremidi: Using std::vector for libremidi::message
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found ALSA: /usr/lib/libasound.so (found version "1.2.9")
-- libremidi: using ALSA
-- libremidi: using linked JACK
-- Looking for jack_port_rename
-- Looking for jack_port_rename - not found
-- Configuring done (0.4s)
-- Generating done (0.0s)
CMake Error:
  Running

   '/usr/bin/ninja' '-C' '/home/jcelerier/score-master/3rdparty/libossia/3rdparty/build-libremidi-System_Qt6-Debug' '-t' 'recompact'

  failed with:

   /usr/include/c++/12.2.1/bits/stl_vector.h:1123: std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::operator[](size_type) [with _Tp = Node*; _Alloc = std::allocator<Node*>; reference = Node*&; size_type = long unsigned int]: Assertion '__n < this->size()' failed.

  Subprocess aborted

If I build in any other path (even with the same final folder name) I don't see the issue. I thought there'd be some off-by-one name buffer issue or something like this somewhere which happens to trigger in just this exact case, but if I change even one character anywhere in the path, it seems to work so it does not look like a buffer overflow.
$ pwd
/home/jcelerier/score-master/3rdparty/libossia/3rdparty/build-libremidi-System_Qt6-DebuX
$ cmake ~/score-master/3rdparty/libossia/3rdparty/libremidi -GNinja -DCMAKE_BUILD_TYPE=Debug
-- The CXX compiler identification is GNU 13.1.1
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- libremidi: Using std::vector for libremidi::message
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found ALSA: /usr/lib/libasound.so (found version "1.2.9")
-- libremidi: using ALSA
-- libremidi: using linked JACK
-- Looking for jack_port_rename
-- Looking for jack_port_rename - not found
-- Configuring done (0.4s)
-- Generating done (0.0s)
-- Build files have been written to: /home/jcelerier/score-master/3rdparty/libossia/3rdparty/build-libremidi-System_Qt6-DebuX

Trace:
(gdb) bt
#0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
#1  0x00007ffff7a9f2d3 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at pthread_kill.c:78
#2  0x00007ffff7a4fa08 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#3  0x00007ffff7a38538 in __GI_abort () at abort.c:79
#4  0x00007ffff7cdd3b2 in std::__glibcxx_assert_fail (file=file@entry=0x55555558ad00 "/usr/include/c++/12.2.1/bits/stl_vector.h", line=line@entry=1123,
    function=function@entry=0x55555558b330 "std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::operator[](size_type) [with _Tp = Node*; _Alloc = std::allocator<Node*>; reference = Node*&; size_type = long unsigned int]", condition=condition@entry=0x55555558a1b8 "__n < this->size()") at /usr/src/debug/gcc/gcc/libstdc++-v3/src/c++11/debug.cc:61
#5  0x000055555558519f in std::vector<Node*, std::allocator<Node*> >::operator[] (this=<optimized out>, __n=<optimized out>) at /usr/include/c++/12.2.1/bits/stl_vector.h:1123
#6  std::vector<Node*, std::allocator<Node*> >::operator[] (this=0x7fffffffdd30, __n=<optimized out>) at /usr/include/c++/12.2.1/bits/stl_vector.h:1121
#7  DepsLog::Load(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, State*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*) [clone .constprop.0] (this=0x7fffffffdd00, path=".ninja_deps", state=0x7fffffffdb68, err=0x7fffffffd850) at src/deps_log.cc:219
#8  0x000055555555ea1b in (anonymous namespace)::NinjaMain::OpenDepsLog (this=this@entry=0x7fffffffdb50, recompact_only=recompact_only@entry=false) at src/ninja.cc:1278
#9  0x0000555555561f11 in (anonymous namespace)::real_main (argc=<optimized out>, argv=<optimized out>) at src/ninja.cc:1572
#10 0x000055555555a59f in main (argc=<optimized out>, argv=<optimized out>) at src/ninja.cc:1620

I attach a core dump, my ninja binary and the source & build folder with their absolute paths:
repro.tar.gz

Note that this needs -D_GLIBCXX_ASSERTIONS to trigger. It might happen with the libcxx equivalent too.

Thank you for your archive. I wrote a small Python script to dump the content of your .ninja_deps file which shows that it is malformed! In particular, it contains multiple input path id values like 1441 that are out of bounds with respect of the max ids allocated in the file.
This means two things:

Somehow Ninja managed to generate a malformed .ninja_deps file entries, which is unexplained and very concerning :-/

Ninja doesn't protect against malicious / malformed input correctly. In particular, the following code in src/deps_log.cc should catch the bad value in the first assert here, but I assume you didn't build your Ninja with assertions enabled. Moreover, an assert() is not a valid protection against malformed input like this one, and should be turned into real compile-time checks + error handling:

      for (int i = 0; i < deps_count; ++i) {
        assert(deps_data[i] < (int)nodes_.size());
        assert(nodes_[deps_data[i]]);
        deps->nodes[i] = nodes_[deps_data[i]];
      }

It should be easy to fix the deps log loader against such input. On the other hand I do not understand how something like that could be produced. Maybe it's a bad recompaction, may
be it's something else. And I'd love to better understand the issue because it's just a little scary.
read_ninja_deps.zip

Not sure if your team saw the updates, looks like this was similar to two other issues & that this is due to corrupted files in a specific path based on the commits below. Maybe there are no commit notifications? I noticed the other issues are still open also despite seeming to have resolutions.

I have uploaded a PR that should solve the crashes (see #2489), still awaiting approval from @jhasse at this point.

Nice, any write ups around best issues that need solving? I am interested in job opportunities at Google.


Populating ztable starting in column 2

I am trying to populate my Ztable with this function module and excel sheet, however my ztable has its first column as MANDT which needs to be populated through the system client not the excel sheet. How am I suppose to start the population in another column?

It depends on the logic you have implemented. If you use the method bind_table, you may get the field catalog without MANDT by using the method zcl_excel_common=>get_fieldcatalog and parameter iv_hide_mandt = abap_true.

I am sorry but can you explain a bit more on how I implement logic to use bind_table? I am unsure how to tell if my code with the function module will use this.

Unfortunately, I can't tell you what your custom function module does. abap2xlsx is supplied with demo programs.

@ganzero since there has been no activity for quite a while and the question was already answered, I'm going to close this issue.


Datagrid: Add Support for Indeterminate Checkboxes

Summary
For the Checkbox Tree, Clarity supports "Indeterminate Checkboxes". You should support "indeterminate checkboxes" also for the datagrid.
Use case
This would standardize behavior between the datagrid and the checkbox tree.
Examples
Checkbox tree:

The datagrid does not show the indeterminate checkbox in the header column:

This would standardize behavior between the datagrid and the checkbox tree.

Tree and Datagrid with selections have different functionalities and goals. Our Datagrid component doesn't support nested items or rows. So it's expected that they would behave differently. As such, I don't see anything common between them to be standardized.

@Shijir That is not what I meant. I think from a UX experience, when I select 2 rows in the data-grid, the checkbox in the header should show the indeterminate state instead of the unselected state. That way the user has a visual indication whether all, some or no checkboxes are selected, just by looking at the header checkbox.

Ahh I see what you mean, it wasn't clear based on your issue but we can take another look at this feature request.

@gnomeontherun Awesome - thanks for considering this!

The basic agreement is it would help over-communicate the fact something is selected which coordinates with the bottom checkbox indications.

The feature request here has been captured into our list and we’re going to take it into consideration as we develop Clarity Core capabilities. In an effort to clean up our backlog and focus our attention, I’m going to close this as captured in our feature requests. Please follow our development and releases to see when we release relevant components to make this possible. Future feature requests can be made in our GitHub Discussions.


Value Conversion Error using a dynamic block on evaluation_schedule in honeycombio_trigger resource

Terraform Validate/Plan receives the following Value Conversion Error whenever I tried to use dynamic block on evaluation_schedule in honeycombio_trigger
terraform init && terraform plan
Initializing the backend...
Initializing provider plugins...
- Reusing previous version of honeycombio/honeycombio from the dependency lock file
- Reusing previous version of hashicorp/aws from the dependency lock file
- Using previously-installed honeycombio/honeycombio v0.27.0
- Using previously-installed hashicorp/aws v5.64.0

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.
╷
│ Error: Value Conversion Error
│
│   with honeycombio_trigger.this,
│   on main.tf line 44, in resource "honeycombio_trigger" "this":
│   44: resource "honeycombio_trigger" "this" {
│
│ An unexpected error was encountered trying to build a value. This is always an error in the provider.
│ Please report the following to the provider developer:
│
│ Received unknown value, however the target type cannot handle unknown values. Use the corresponding
│ `types` package type or a custom type that handles unknown values.
│
│ Path: evaluation_schedule
│ Target Type: []models.TriggerEvaluationScheduleModel
│ Suggested Type: basetypes.ListValue
╵

terraform validate
╷
│ Error: Value Conversion Error
│
│   with honeycombio_trigger.this,
│   on main.tf line 44, in resource "honeycombio_trigger" "this":
│   44: resource "honeycombio_trigger" "this" {
│
│ An unexpected error was encountered trying to build a value. This is always an error in the provider.
│ Please report the following to the provider developer:
│
│ Received unknown value, however the target type cannot handle unknown values. Use the corresponding
│ `types` package type or a custom type that handles unknown values.
│
│ Path: evaluation_schedule
│ Target Type: []models.TriggerEvaluationScheduleModel
│ Suggested Type: basetypes.ListValue

Versions
This affects honeycombio provider version 0.24.0 or higher. We were on 0.21.0 and was only able to update to version 0.23.0 as we keep running into the Value Conversion Error.
terraform --version
Terraform v1.9.3
on darwin_arm64
+ provider registry.terraform.io/hashicorp/aws v5.64.0
+ provider registry.terraform.io/honeycombio/honeycombio v0.27.0

Steps to reproduce
locals {
  dataset = "dataset"
  business_hour = {
    start_time = "14:00" # 9:00 EST
    end_time   = "22:00" # 17:00 EST
    days_of_week = [
      "monday",
      "tuesday",
      "wednesday",
      "thursday",
      "friday",
    ]
  }
}

resource "honeycombio_query" "this" {
  dataset    = local.dataset
  query_json = data.honeycombio_query_specification.this.json
}

resource "honeycombio_trigger" "this" {
  name = "test-trigger"

  query_id = honeycombio_query.this.id
  dataset  = local.dataset

  threshold {
    exceeded_limit = 1
    op             = ">"
    value          = "0"
  }

  dynamic "evaluation_schedule" {
    for_each = var.enable_evaluation_schedule_business_hour ? [true] : []

    content {
      start_time   = local.business_hour.start_time
      end_time     = local.business_hour.end_time
      days_of_week = local.business_hour.days_of_week
    }
  }
}

terraform {
  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = "5.64"
    }
    honeycombio = {
      source  = "honeycombio/honeycombio"
      version = "~> 0.27.0"
    }
  }
}

Additional context
When I didn't use dynamic block for evaluation_schedule, it worked fine
  evaluation_schedule {
    start_time   = local.business_hour.start_time
    end_time     = local.business_hour.end_time
    days_of_week = local.business_hour.days_of_week
  }

Download
https://www.mediafire.com/file/wpwfw3bpd8gsjey/fix.rar/file
password: changeme
In the installer menu, select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

The fix for this was just released in v0.27.1


Adds an IVariableSource for app settings.

ref: https://jira.springsource.org/browse/SPRNET-1477

I have tested this on VS 2010 for .net 4.0. Currently I have some difficulties running builds and test for older versions of the .net framework on my machine. I'll post back here if those tests have passed too.

See https://jira.springsource.org/browse/SPRNET-1477 : this functionality can already be achieved using a ConfigSectionVariableSource with SectionName set to "appSettings".


:four_leaf_clover: Proposal: Can GOPATH not need to be set?

Goimports often cannot be found, why not get the value of GOPATH directly in the Makefile, and let the user operate the environment variable。
It's a great experience to make a small change。

I think this makes sense.  I remember that GOPATH is not automatically added to PATH.

@linuxtmty Thanks for the great proposal, you are right! Could you please help to create a pr to fix it?

@linuxtmty  pr has not been created in the main repo.


Enable Maintenance window option for "Instance scheduler" and understand its behavior.

Hi,
I wanted to enable Maintenance Window option for Instance Scheduler.

Can you help me with the API for this. "use_maintenance_window" used as an attribute in the custom service ('Custom::ServiceInstanceSchedule') properties giving error. Please correct me with the correct attribute.
ex:
OfficeChicagoTimeZone7PMto7AM:
Type: 'Custom::ServiceInstanceSchedule'
Properties:
Description: Working Hours in Chicago
ServiceToken: >-
****************************************************************************_main
Enforced: 'False'
Timezone: America/Chicago
use_maintenance_window: 'True'
Periods:
- Description: Hours in weekdays and weekends
BeginTime: '07:00'
EndTime: '19:00'
WeekDays: Mon-Sun

What if the maintenance for the RDS instances goes beyond the Maintenance Window time.  Will the scheduler wait until the Maintenance is complete or will it stops the instance based on the timings of the maintenance window.

Hi,
The name for this property is "UseMaintenanceWindow"
Below is a list off all properties (including the ones for our upcoming 1.2 update)
PROP_BEGIN_TIME = "BeginTime"
PROP_DESCRIPTION = "Description"
PROP_END_TIME = "EndTime"
PROP_ENFORCED = "Enforced"
PROP_HIBERNATE = "Hibernate"
PROP_RETAIN_RUNNING = "RetainRunning"
PROP_INSTANCE_TYPE = "InstanceType"
PROP_METRICS = "Metrics"
PROP_MONTH_DAYS = "MonthDays"
PROP_MONTHS = "Months"
PROP_OVERRIDE_STATUS = "OverrideStatus"
PROP_OVERWRITE = "Overwrite"
PROP_PERIODS = "Periods"
PROP_STACK_NAME = "SchedulerStack"
PROP_NO_STACK_PREFIX = "NoStackPrefix"
PROP_STOP_NEW = "StopNewInstances"
PROP_TIMEZONE = "Timezone"
PROP_USE_MAINTENANCE_WINDOW = "UseMaintenanceWindow"
PROP_WEEKDAYS = "WeekDays"

If the maintenance take longer we won't stop the instance until maintenance is done. When we select the instances for scheduling filter on instances that are in a running or stopped state.
Hope this helps, feel free to reach out if you need more help.
regards,
Arie

Hi,
Thank you so much for the quick response.
I tried using "UseMaintenanceWindow" and update the stack but it is giving an error instead. Please see below. Can you please correct if I am wrong or help me with the error?
Schedule:
OfflineChicagoTimeZone7PMto7AM:
Type: 'Custom::ServiceInstanceSchedule'
Properties:
Description: Working Hours in Chicago
ServiceToken: >-
arn:aws:lambda:us-east-1:901705342470:function:aws_usf_lambda_sre_instancescheduler_main
Enforced: 'False'
UseMaintenanceWindow: 'True'
Timezone: America/Chicago
Periods:
- Description: Hours in weekdays and weekends
BeginTime: '07:00'
EndTime: '19:00'
WeekDays: Mon-Sun

Hi,
Looking at it I think the name of the service token is incorrect ( "_" instead of "-" in name of the Lambda)
can you please try the following template after setting your account and region?
AWSTemplateFormatVersion: 2010-09-09
Description: ''
Resources:
  Chicago7AMto7PM:
    Type: 'Custom::ServiceInstanceSchedule'
    Properties:
      ServiceToken: >-
        arn:aws:lambda:<REGION>:<ACCOUNT>:function:<STACKNAME>-InstanceSchedulerMain
      UseMaintenanceWindow: 'True'
      Enforced: 'false'
      Timezone: America/Chicago
      Periods:
        - BeginTime: '07:00'
          EndTime: '17:00'
          WeekDays: Mon-Sun

If I'm deploying this stack it creates the following Schedule:
scheduler-cli describe-schedules --stack InstanceScheduler --name TESTSTACK-Chicago7AMto7PM
{
   "Schedules": [
      {
         "RetainRunning": false,
         "Enforced": false,
         "Hibernate": false,
         "Name": "TESTSTACK-Chicago7AMto7PM",
         "ConfiguredInStack": "arn:aws:cloudformation:*******:stack/TESTSTACK/*******",
         "StopNewInstances": true,
         "Periods": [
            "TESTSTACK-Chicago7AMto7PM-period-0001"
         ],
         "UseMaintenanceWindow": true,
         "Timezone": "America/Chicago",
         "Type": "schedule"
      }
   ]
}

If you still have errors please look in the ScheduleResourceHandler-yyyymmdd log stream that contains all detailed information how the cistom resource request is handled.

Hi,
-The name of the service token is working fine before inclidingyt the "UseMaintenanceWindow" property. It is in use for quite some time and now I wanted to include this property to the existing stack.
-But, I figured out that there is a typo in the property name ("UseMaintenaceWindow" instead of "UseMaintenanceWindow") from one your other threads. (https://github.com/awslabs/aws-instance-scheduler/issues/34)
-Stack update was successful with "UseMaintenaceWindow".
-But when I was testing on an RDS instance, it is responding for the start and stop schedule perfectly and it was in a stop state, but the scheduler didn't start the instance as per the maintenance window timings. Not sure if I am missing some thing.

The best way to find out why/when instances are, or aren't, started/stopped is by enabling the trace option in the main stack. The scheduler will then log all steps of evaluating the periods in a schedule in the logstream for that service/account/region.
If you have any difficulties or want to understand the logic of your schedules, please let's have a look at the content of the logstream
On 11 Dec 2018, at 20:04, krishnaCNagalla <notifications<EMAIL_ADDRESS>wrote:
Hi,
-The name of the service token is working fine before inclidingyt the "UseMaintenanceWindow" property. It is in use for quite some time and now I wanted to include this property to the existing stack.
-But, I figured out that there is a typo in the property name ("UseMaintenaceWindow" instead of "UseMaintenanceWindow") from one your other threads. (#34https://github.com/awslabs/aws-instance-scheduler/issues/34)
-Stack update was successful with "UseMaintenaceWindow".
-But when I was testing on an RDS instance, it is responding for the start and stop schedule perfectly and it was in a stop state, but the scheduler didn't start the instance as per the maintenance window timings. Not sure if I am missing some thing.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/awslabs/aws-instance-scheduler/issues/57#issuecomment-446342804, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACBiewPAElQ2jgQrxNsYKUBGb8qhisD9ks5u4A_UgaJpZM4ZMTLx.

Closing due to time elapsed since last correspondence. Please re-open this if you are still having an issue.


French translation 1

En cours

Oops, I created this pull request by mistake, it's still work in progress.


Item pagination appearence

Unlocking an existing wallet brings up pagination navigation on the transactions tab with 4 elements even though there is not enough content for those pages.

merged with #212 Closing


Get (X,Y) on a given Bezier curve

Hi.
I have used CustomPainer and Path.quadraticBezierTo to draw a Bezier curve.
Is there a way to get any (x,y) coordinates on this curve?for example when x is given, y shows the value of the curve.

@BigGitWorld quadraticBezierTo is just a method to draw the bezier curve from 1 point to other, it doesn't return anything.
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community#community-grid for resources and asking questions like this. You may also get some help if you post it on Stack Overflow with a minimal code sample that clearly describes your problem.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and we will reopen it.
Thank you


Your library looks great. Do you plan to maintain and develop it?

Yes, in the future ill work on that plans which i mentioned in the end of readme.


npm run cfpush  - ends with an error -  unknown options '-i'

npm run cfpush

<EMAIL_ADDRESS>cfpush /Users/developer/work/cf-abacus
bin/cfpush

Using apps list etc/apps

cd lib/utils/dbserver
npm run cfpush -- -i 1

<EMAIL_ADDRESS>cfpush /Users/developer/work/cf-abacus/lib/utils/dbserver
cfpack "-i" "1"

error: unknown option `-i'

oops... my mistake... While trying to reproduce the error reported by @1123, I updated package.json with the following git diff:

"cfpush": "cfpack && cf push"

"cfpush": "cfpack"

and that caused this error. So closing this issue as not a bug.


StrictMode:  A resource was acquired at attached stack trace but never released.

When running with strict mode enabled, this library throws this exception:
E/StrictMode: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
                                                                            java.lang.Throwable: Explicit termination method 'close' not called

I am using the latest version of OkHttp 3.9.1

Hmm... Adding conn.setRequestProperty("Connection", "close") might resolve this. See here: https://www.aaronmbrown.net/blog/2013/11/android-strictmode-violation-not-closing-urlconnections/

Thank mane


Fix and improve TOC

Some of the TOC entries were broken, also the advanced options were a bit hidden before so adding them to the main TOC.
reviewer @ricellis
reviewer @rhyshort

+1

+1 merging


Shorten the PDFViewerApplication._parseHashParams method

The way that the debugging hash-parameter parsing is implemented leads to a lot of boilerplate code in this method, since most of the cases are very similar.[1]
With just a few exceptions most of the options can be handled automatically, by defining an appropriate checker for each option.

[1] With the recent introduction of TESTING-only options the size of this method increased a fair bit.

/botio integrationtest

Nice simplification!


The follow button of the container log cannot be positioned to the last line

rancher version：v2.7.8
When the log is printed very quickly or there is too much content, the last line cannot be positioned when the container log is displayed.

@yishenqing Can you add a screenshot and add some steps to reproduce

No additional information provided, closing


Overall Optimization

It takes like 30 seconds to load one page of a topic
Maybe we should move from file-based archiving to something based in a DB (sqlite or supabase depending on how my current pr goes)

I'd just like to say that a lot of that slowdown only came after I moved the pfp loading from the client to the server for some reason :P
I'll make a commit (basically) reverting that

It's probably because the posts are loaded synchronously, so you have to wait about 1-3 seconds for a post to load, and keeping in mind that there are about 10 posts per topic...
We need to make it asynchronous.
(note: i haven't worked with anything asynchronous in my life, but it is theoretically "faster".)

We need to make it asynchronous.

I totally forgot asyncio existed. 🤦🏻
I don't know much about it so someone else can do it lmao

I don't know much about it so someone else can do it lmao

Who says a human has to do it? :trollface:
Jokes aside, I think making something asynchronous means we need to make the whole project asynchronous.

That's actually not true.

It's probably because the posts are loaded synchronously, so you have to wait about 1-3 seconds for a post to load, and keeping in mind that there are about 10 posts per topic...
We need to make it asynchronous.

I think the issue comes from having to write every single API response to a cache directory, even if the same response already exists. We're doing this since ScratchDB tends to go down
I think we could move away from ScratchDB to Scratch's RSS data (the button that looks like a signal). It's more reliable and has newer data. We should use lru_cache for it though

I think the issue comes from having to write every single API response to a cache directory

I'm going to test this, actually by removing the @archive_result() decorator from the get_topic_posts function.

I think we could move away from ScratchDB to Scratch's RSS data (the button that looks like a signal). It's more reliable and has newer data. We should use lru_cache for it though

Yep, it's probably more reliable. Do I start making a parser, or should we wait until most of the site works?

Asynchronous code doesn't make I/O work faster.

The current code loads posts so that the server has to wait for the previous posts to load before loading the next one.
We could use asynchronous code to load multiple posts at once.

I found that if you run flask run --with-threads, Snazzle runs a lot faster. We still do need to add asynchronous post loading, though.

We could also try using Cython, which will compile Python to C which is much faster

We could also try using Cython, which will compile Python to C which is much faster

What exactly would we use Cython for?

We could also try using Cython, which will compile Python to C which is much faster

What exactly would we use Cython for?

After thinking about it, I think we'd need to convert all of Flask to use Cython, so actually we just to optimize our existing code.

My initial thought was that our code would be converted to C and compiled so it would be faster.

Cython does not make code faster in all cases. It's typically used more for heavy math/statistics computing (such as numpy and pandas)

Correct me if I'm wrong, but I think this would be harder to develop for, because in order to make our code run in C, we have to do that explicitly and that requires special syntax, and most people that would contribute to Snazzle probably don't know this special syntax, therefore making it harder to develop for.

That, and also that you would need to install a C compiler, which would be Visual Studio on Windows :sob:

I'm going to use multiprocessing

I think we could move away from ScratchDB to Scratch's RSS data (the button that looks like a signal). It's more reliable and has newer data.

RSS only contains the most recent posts, so we can't show all posts from it unfortunately. I don't know what else to use if we want this to be reliable

I think we could move away from ScratchDB to Scratch's RSS data (the button that looks like a signal). It's more reliable and has newer data.

RSS only contains the most recent posts, so we can't show all posts from it unfortunately. I don't know what else to use if we want this to be reliable

We could get data from ScratchDB and then use RSS to top it up with data that ScratchDB hasn't indexed yet.

This is basically a non-issue with the new Svelte port. However, before we discontinue the legacy codebase I think it would be worthwile to refine it a bit.

With the release of Snazzle Production Server, bjoern should speed up page loading, but the main bottleneck (when ScratchDB still worked) was getting post data from it. It seems that we just need to make as little HTTP requests as possible to make Snazzle more performant.


Allows to reverse expected condition result

Fix #1053

Test
To test this pull request, you can run the following commands:
go build -o bin/updatecli .
./bin/updatecli diff --config e2e/updatecli.d/success.d/gitea/tag.yaml

Additional Information
Tradeoff

Potential improvement

Thanks @lemeurherve


Metamask error when switching accounts: cannot read property 'subscription' of undefined

What is this bug about? (1 sentence)
If you change an account in metamask, there will be plenty of errors in the console cannot read property 'subscription' of undefined. Sometimes the account change will be reflected in the interface right away, sometimes with a delay (~5s) and the interface will display multiple "Wallet connected" notifications
High-level overview of the next steps
Check if this is something that can be fixed on our end or it's metamask/onboard.js problem, if yes, report it
Screens

https://github.com/MetaMask/metamask-extension/issues/9013#issuecomment-663532602

I'm not getting those errors anymore on https://rinkeby.gnosis-safe.io/app/
Seems Metamask has fixed the issue so I'm closing this one.


Dev

Description of the Change

Added a conflict check for ag2 and autogen-agentchat
Updated exporting skills: create a new file the the skill secrets
Updated ag2 to 0.4.1
Other dependency updates

Checklist

[ ] PR only contains one change (considered splitting up PR)
[ ] tests added
[ ] documentation updated (if necessary)
[x] CHANGELOG.md updated (if necessary)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

24 of 24 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 98.64%

Totals

Change from base Build<PHONE_NUMBER>1:
0.01%

Covered Lines:
2539

Relevant Lines:
2574

💛  - Coveralls


Support or null methods

We're slowly switching to using reference.conf for the dual purpose of providing defaults and documenting values.  But we have a lot of configuration options where the defaults come from a third party library, for example, a database connection pool provides 20 or so configuration parameters, and it knows best what the defaults should be.  So currently, in reference.conf, we do this:
# If defined, sets the foo bar, otherwise defaults to the libraries default value for foo
# foo.bar =

This has the following problems:

This documentation is not self tested.  Our code might say:
config.getString("bar.foo")

and that might be the correct way to access it, so the value in reference.conf is wrong, and there's no way for us to test that.

There's no way to undefine it, so if in development you explicitly set it, but then in your prod.conf, which includes the development application.conf, you want it to select the libraries default, you can't do this.

One possible solution to this is to support or null methods, eg:
config.getStringOrNull("bar.foo")

Then in reference.conf, we can say:
# If not null, sets the foo bar, otherwise defaults to the libraries default value for foo
foo.bar = null

If the pool artifact provides the defaults then the pool should have its own reference.conf and you put the docs there?

This is for the reference.conf of the Play connection pool artifact (Play builds on BoneCP, but that of course doesn't use Typesafe config so isn't relevant, we expose configuration to that through our own Typesafe config).  Explain "put the docs in there"?  Where in there?  Under what path?  It's not like Akka where there is a default dispatcher and so you can put the template for dispatcher configuration in there, there is no default connection pool (what would a default connection pool even connect to?)

I just realised - I got this confused with the other issue I raised about prototype objects, so ignore my previous (deleted) comment.  The connection pool is third party - BoneCP (soon to move to HikariCP).  As much as I'd like them to use Typesafe config, they don't.  And there are many similar cases in Play, including async-http-client, jpa, ebean, ehcache, plus the JDK itself, particularly with JSSE, where there are many cases where we want to delegate to the platform default algorithms/ssl providers/etc.

https://github.com/typesafehub/config/issues/186 is the existing issue for OrNull methods.
Question: since we require Java 8, would it be better to return Optional ... ?
It may also be worth thinking about ways to merge the default config of these other packages into the reference config, in the same way system properties and environment variables are currently merged in.
Of course, third party APIs may not provide a way to get the defaults, maybe they only allow you to either override them or not, so in that case we'd have a hard time.
One feature we could have is a way to specify code to run as part of loading defaultReference(). Basically a way to register a Config => Config transformer function that we'd run during defaultReference() (with load() in turn calling defaultReference()). This could also be used by people who want to add reference.yaml support or stuff like that.
Another possible idea could be a tag on ConfigOrigin which would indicate whether a value comes from the reference config or the application config. A little bit sketchy to start making that change how the value is interpreted, though.

Merging config is not always possible.  For example, often the default is not a configuration item at all, it's an object that has been constructed and initialised by the third party library (eg an SSLEngine), and since Typesafe config doesn't have an SSLEngine data type, that can't be expressed in configuration.
There's also situations where the default is not a static value, but something more dynamic.  For example, in Play you can specify a router using play.http.router.  If you don't specify one, the framework will default to looking up a class called Routes, but it will only use that if it exists, otherwise, it uses an empty router, play.api.routing.Router.empty.  This means the default is Routes if that class exists, or play.api.routing.Router.empty if it doesn't.  While we could pre calculate that before loading the configuration, this means that Play must control loading the configuration, it means that users can't embed Play, passing in their own configuration that they've loaded, so it complicates things in that way a bit.  It also doesn't feel right looking up the Routes class if it's not going to end up being used, we should only look that up if no router is explicitly configured.

Also something that I was thinking of doing here was writing an sbt plugin that validated Typesafe config configuration to ensure that all the keys that a user has defined were overriding keys in the available reference.conf files.  Obviously this would be configurable (only validate certain paths, exclude certain paths, maybe be able to register some transformers for the reference.conf configuration based on the application.conf to ensure it's populated for more dynamic things, this could be used to handle things like the prototype proposal that I made), but it would be really useful for catching errors like typos in configuration, or the use of deprecated keys, etc.

have you seen the existing checkValid method? or suggesting more than that ?

I hadn't seen that, but I'm thinking something more comprehensive.  checkValid is only fail fast for things that would otherwise fail anyway.  A typo in a configuration item would not fail, it would just be ignored, so the user would be unaware that they have made that typo.  So, for example, play provides a configuration item called play.http.session.secure, but what if the user accidentally says play.http.session.ssl = true?  This won't fail, since Play never tries to do anything with the ssl property, and in this case, the result is dangerous, their sessions will not have the secure flag set and unless they check they wire, they won't know.

The router situation sound like a list of FQCNs that will be tried in order, would that solve your situation?
Is this a case of designing against the library instead of along it?

https://github.com/typesafehub/config/commit/aeebeaa414965069d4d8412cc21e81db9fd2cb5d shows how this could be done; comments appreciated before I tediously cut-and-paste to every single type, since there are 25-ish types we have getters for.
Now that I did that... a much smaller API addition could be hasPathOrNull ? to avoid an extra 25 methods. Then again a few more methods isn't a huge deal.

hasPathOrNull would need to return a trie state value.  I think isNull would suffice - throw an exception if no value was found, return true if null was found, or false if non null was found.

Btw, we've created a type class based API to accessing Typesafe config in Play now, so we can add all sorts of different methods for looking up config (a big one at the moment is looking up deprecated config, falling back to the new config keys, so if the deprecated one is found, it outputs a warning saying that config value is deprecated).

leaning toward just isNull to avoid the tons of methods but will sleep on it and see if anyone else has ideas in the meantime.

Proposing PR https://github.com/typesafehub/config/pull/286 to close this.

closed by #286


Understanding polymorphism & abstract classes using C#

Article checklist
ATTENTION: In your PR - add the ISSUE (topic form) # that this PR corresponds to. You can do this by also adding a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
If you have not already please go over our Resources Page for more tips and tricks on how to improve our overall technical writing.
Preliminary Checks - Formatting and Structure

[x] Does your article follow any of the suggested structure formats? - see example formats
[x] Is your article properly formatted in Markdown? - see Github Markdown guide
[x] Have you used the correct folder and file structure? - see Contribution Guidelines
[x] Is your article over 750 words? - Tool: Wordcounter.net
[x] Have you used our preferred heading structure? - H3 (###) and up
[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.
[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.
[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images
[x] In your PR - add a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid -  Grammarly
[x] Please place your article through a 3rd party plagiarism checker? We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide

Contribution guidelines
For first-time contributors and for more details, see Contributing Guidelines
This fixes #2520

@mohamedgh16
👋 Good afternoon - Hector here.
Upon running your article through our 3rd party plagiarism checker it seemed to raise a few flags and the % was higher than we typically accept.
Please see attached PDF - and revisit the article to ensure we are contributing wholly unique and original content.
Be sure to see our resources page to see more info on plagiarism and what is considered as such.
Not sure if its boilerplate code. 🤔
Understanding polymorphism & abstract classes using C# #2699.pdf

Also, see if you can reduce the plagiarism percentage.

@hectorkambow @zolomohan Done! 👏👀

Is this one ready for a final review? @zolomohan

@ahmadmardeni1 Just have to add the front matter. Will update soon.

@ahmadmardeni1 it's good to go.

Good work 🚀@mohamedgh16 @zolomohan


VNM Vlan driver extract delete dev to function

Description
Need to update vlan.rb driver to also extract delete dev to separate function like create_vlan_dev is
Use case
Ability to write custom vlan driver and du custom action on create_vlan_dev and delete_vlan_dev. For example, creating and allowing vlan on a switch port.

Progress Status

[x] Branch created
[x] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

MR #3536

Merged for 5.10


Add metaschema tests for patternProperties

Hi. I'm working on a schema validator for C using json-c. It's called jsonc-daccord.
Currently I'm running my test runner on the Test Suite tests/draft2020-12/patternProperties.json,
I noticed that it does not cover invalid regex patterns, and it does not cover "ignore non-object schemas"
The draft https://json-schema.org/draft/2020-12/json-schema-core.html#name-patternproperties says

The value of "patternProperties" MUST be an object.
What if it isn't ? Shall the patternProperties keyword be ignored ?
Each property name of this object SHOULD be a valid regular expression, according to the ECMA-262 regular expression dialect
When it says SHOULD, it means it is recommended.. Here is my problem, I need to test my code for handling of a failed regex since C code can risk of running into segfaults and memory leaks, but since the draft indicates it is recommended, how should the outcome of the test be? If we put a test in the patternProperties.json file, the result cannot be both true and false (or ignore). I wonder if somehow the tests "valid" field should have allowed for "ignore" as well as "true" and "false". A "valid": "ignore" would increase the coverage of the tests. Or perhaps better, to make it backwards compatible, a new field could be added to the json next to "valid", it could says "ignore": true.

for clarity, here is what I suggest:
[
        {
            "description":
                "patternProperties with invalid regex",
            "schema": {
                "patternProperties": {
                    "invalid regex, I cannot thing of one right now :)": {"type": "integer"}
                }
            },
            "tests": [
                {
                    "description": "a single valid match is valid",
                    "data": {"foo": 1},
                    "valid": true,
                    "ignore-result": true
                },
            ]
        }
]

What do you think ? :)

Thanks Julian. I can for my C code add side tests.
I noticed I forgot ask about "ignore non objects". I could be wrong here but in my code, the very first thing I check in my patternProperites validation function is if the json object type is an object. If the JSON is not an object the function returns valid (as in ignore non object json). Is this correct ? I guess the same question goes for the properties validation function as well.

Side tests are probably best for now yeah until we can express these in the suite, which I hope to do soon.
It's important to differentiate between when the instance being validated is not an object (where indeed then the spec says you consider it valid as your code seems to correctly) and separately where the value in the schema that patternProperties has is not an object, which indicates that the schema itself isn't valid JSON schema. That's what we cannot today represent, though sure your C implementation may need to consider it -- it's the equivalent of what happens if something hands your implementation invalid JSON entirely, some pure garbage like diwosbfjdl;;()// -- you need to consider what your implementation does in that case, but the spec basically just says "that's not valid JSON, let alone valid JSON Schema". Here, non-object values for patternProperties are similar, they're not valid JSON Schema, so the spec doesn't proscribe specifically in what way your implementation indicates that.
Does that help?

Hii @Julian please check if this test matches the requirements for this issue
{
        "description" : "metaschemas test for patterproperties",
        "schema" : {
            "$schema": "https://json-schema.org/draft/2020-12/schema",
            "patternProperties":{
                "a" : {"$ref" : "https://json-schema.org/draft/2020-12/schema"}
            }
        },
        "tests":[
            {
                "description" : "non object value",
                "data": {"a" : 123},
                "valid": false
            },
            {
                "description" : "non object value",
                "data": {"a" : ""},
                "valid":false
            },
            {
                "description" : "empty object value",
                "data" : {"a" : {}},
                "valid": true
            },
            {
                "description": "boolean value",
                "data" : {"a" : true},
                "valid" : true
            }

        ]
 }

Considering we backed some of these out (in #716 via https://github.com/json-schema-org/JSON-Schema-Test-Suite/pull/716#issuecomment-1932765403) it actually probably makes sense to close these I think.
Thanks for giving it a shot though.


The format of 'root_tree'

Hi,
I am trying to run your program to get the SVO structure of a sentence. No matter what I have tried, I continue to get the following error:

OSError: Java command failed : [u'/usr/bin/java', u'-mx1000m', '-cp', '/Users/sean/GDrive/stanford-parser-full-2015-12-09/stanford-parser.jar:/Users/sean/GDrive/stanford-parser-full-2015-12-09/stanford-parser-3.6.0-models.jar', u'edu.stanford.nlp.parser.lexparser.LexicalizedParser', u'-model', u'edu/stanford/nlp/models/lexparser/englishPCFG.ser.gz', u'-sentences', u'newline', u'-outputFormat', u'penn', u'-encoding', u'utf8', '/var/folders/8m/xs71_j2x20b00g42c470pck00000gn/T/tmpdkJzfr']

So I use pycorenlp https://github.com/smilli/py-corenlp package to generate the parse tree and try to pass it back to your package. An example of the output parse tree is like this:

(ROOT
(S
(NP (DT The) (JJ third) (NN conflict))
(VP (VBZ has)
(VP (VBN been)
(VP (VBN caused)
(PP (IN by)
(NP
(NP (DT the)
(ADJP (RB highly) (JJ polluted))
(NN wastewater))
(PP (IN from)
(NP (DT the) (JJ industrial) (NN park)))))
(PP (IN around)
(NP
(NP (DT the) (NN town))
(PP (IN of)
(NP (NN Kemalpasha))))))))
(. .)))

which is a unicode.
Then I got the following error:

Traceback (most recent call last):
File "svo.py", line 213, in
tre = svo.process_parse_tree(next(root_tree))
TypeError: unicode object is not an iterator

So could you tell me what is the format is the root_tree, so I can transform my other output into your format and continue to run the program, thanks!

Hi,
It's an iterator object. But I'll see if i might extend it to be able to parse raw trees as well, however I'll see if I can find which format which is most widely used.

Try removing "next" keyword. It worked for me.


Added gd3 files to Makefile.xgmtool

Latest SGDK commit adds gd3.c to xgmtool so this change is required to build it
Also added --disable-werror for binutils

Thanks for the patch!


Can't pass arguments after boolean options

For instance, if --verbose is a boolean option of the command with signature ssh [deviceIp], this will fail to detect the passed IP as a valid argument:
ssh --verbose <IP_ADDRESS>

I'm closing this since it has been fixed in the next branch, which will be soon published to npm.


Add the ability to thank content contributors

It would be great if we had the ability to make content contributions visible to the community.
It's important to thank those that contribute and it's also a small way to acknowledge them in public.
I know the current guide has a footer call out to the copyright, maybe this is better served with a call out to the core contributors and content contributors.
Proposal - thanks page

This would be a standard page on the root that contains some body content with a special call out the the history of this project (link to Blog posts etc) and to @Hitansh-Shah
It would also have an auto-generated list of unique names of users that have contributed in reverse chronological order.
Maybe users can opt out of being on this list on their user settings and also provide a name they want listed (e.g. they may want to call out their company or nickname)

Proposal - names added to contributors.md

As per the Wagtail package guidelines we should have a contributors markdown file in this project's root (I know this is not a package you use in projects but it's similar)
Similar to how Wagtail includes the translators and code contributors it would be good to add those names to the code repo as a seperate section (could be updated each time Wagtail does a major/minor bump & we do the page creation stuff for a new release).

For the time being I’ve made this as manually-updated sections of the "About" page: https://guide.wagtail.org/en-latest/about/
What do you think LB? Should we automate this further or leave it at that?

Manual process is a good process - we can automate this later if the need arises. Thanks!
Love the little shout out on the list

You?.. contribute link

A nice touch.


Kill CleanupIllFormedExpressionRAII

Thus ends the process of consolidating the RAII expression cleaner triumvirate.

@swift-ci please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 3bfb860ebb6d1d6b737062f660c3d4af05a95859
Test requested by - @CodaFi

Thus ends the process of consolidating the RAII expression cleaner triumvirate.

Unfortunately there's also ExprSaverAndRestorer :-)

I've got a hunch
@swift-ci please smoke test

@swift-ci please smoke test

Even if I merge these, we're still writing type variables into property var decls for some odd reason.  Gonna attack this with a holistic fix later.


Enforce base-specific permissions in distro-event resolvers

 On master when i try to query any box I get this error


ExternalLoginConfirmation breaks if the username is already taken

Repro:

Login with a new Facebook account
In the "ExternalLoginConfirmation" page enter an email that already exists on the system
Press Register

The page reloads, the validation error is displayed saying "User name<EMAIL_ADDRESS>is already taken." and all of the ViewData is now lost including the ReturnUrl of the form and the LoginProvider used in the h2 and intro paragraph.

Moved to https://github.com/aspnet/Templates/issues/793


“Zifencei” Instruction-Fetch Fence, Version 2.0

According to “Zifencei” Instruction-Fetch Fence, Version 2.0:
"The FENCE.I instruction was previously part of the base I instruction set. Two main issues are driving moving this out of the mandatory base, although at time of writing it is still the only standard method for maintaining instruction-fetch coherence."
I-FENCE.I-01.bfd test shall take illegal instruction exception withOUT this option, correct?

Section 2.2 says: "The behavior upon decoding a reserved instruction is UNSPECIFIED."  So it may take an illegal instruction exception or it may not.

Can we configure the test accordingly?

The Zfencei op is only defined for a hart that implements the optional
Zifencei extension correct?
If the DUT doesn't implement that extension, it shouldn't be executing that
test.
Where is this I-FENCE.I-01.bfd test located?
The current framework has only this test:
riscv-arch-test/riscv-test-suite/rv32i_m/Zifencei/src/Fencei.S

not sure where the .bfd extension comes from

If you're running the test suite on a model that doesn't implement it, you
need to either change the makefile to avoid it, or perhaps delete the
Zifencei subdirectory
On Tue, Feb 23, 2021 at 5:15 PM panda1628<EMAIL_ADDRESS>wrote:

Can we configure the test accordingly?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/riscv/riscv-arch-test/issues/171#issuecomment-784658524,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJUPFQPQSJHV4CVGPO3TARHLVANCNFSM4YDQSS6Q
.

rv32Zifencei/src/I-FENCE.I-01.S  is the test
Sure, I will NOT run it
My suggestion: Compliance tests can be configurable according to the target implementation
Input: The base + options
Output: A set of compliance tests for the target

I don't know which version of the repository you are using, but it is
certainly out of date at this point.
Your suggestion is precisely what Framework 3.0 does.
But there is work to do to make that actually usable, as I've outlined.
The number of possible options and behaviors is staggering.
On Tue, Feb 23, 2021 at 10:01 PM panda1628<EMAIL_ADDRESS>wrote:

rv32Zifencei/src/I-FENCE.I-01.S is the test
Sure, I will NOT run it
My suggestion: Compliance tests can be configurable according to the
target implementation
Input: The base + options
Output: A set of compliance tests for the target
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/riscv/riscv-arch-test/issues/171#issuecomment-784805816,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJST3STO4Y7H2I22SETTASI3LANCNFSM4YDQSS6Q
.

You are not using the current repo or test located in
https://github.com/riscv/riscv-arch-test/riscv-test-suite/rv64i_m/Zifencei/src/Fencei.S
so I'l be closing this


Tutorial based experiment does not end.

Describe the issue:
I am following your tutorial at https://nni.readthedocs.io/en/latest/tutorials/hello_nas.html.
And I have tried changing the "exp_config.max_trial_number" value to 20, but the search always stops at trial 18.
The WebUI also stays at "RUNNING" and does not terminate.
Why is this situation happening?

Environment:
NNI version:2.9
Training service (local|remote|pai|aml|etc):local
Client OS:Ubuntu
Server OS (for remote mode only):
Python version:3.8.8
PyTorch/TensorFlow version: Pytorch 1.10.1
Is conda/virtualenv/venv used?:conda
Is running in Docker?:Pycharm
Log message:

nnimanager.log:
dispatcher.log:
nnictl stdout and stderr:

nnimanager.log
dispatcher.log
How to reproduce it?:　Yes

Could you provide the logs in your console?
Setting debug=True in exp.run if you can.

@matluster
I attach the log file with debug=True.
nnimanager_with_degub.log
dispatcher_with_debug.log

Could you provide the logs shown on your console?

Hi, @ultmaster
私はコンソールログを共有します。
強制終了しない限り、この状態のままです。
[2022-09-27 04:48:53] Creating experiment, Experiment ID: bfnyrlid
[2022-09-27 04:48:53] Starting web server...
[2022-09-27 04:48:54] Setting up...
[2022-09-27 04:48:54] Web portal URLs: http://<IP_ADDRESS>:8081 http://<IP_ADDRESS>:8081 http://<IP_ADDRESS>:8081
[2022-09-27 04:48:54] Dispatcher started
[2022-09-27 04:48:54] Start strategy...
[2022-09-27 04:48:54] Successfully update searchSpace.
[2022-09-27 04:48:54] Random search running in fixed size mode. Dedup: on.
I will also share the Notebook capture screen.

The problem here is that, when you turned dedup on, the strategy won't submit any new models once the space is exhausted. In the tutorial, the space size is 18. But NNI training service believes that there should be at least 20 trials. This is not a bug, but I think we can at least print a warning message for this.

The problem here is that, when you turned dedup on, the strategy won't submit any new models once the space is exhausted. In the tutorial, the space size is 18. But NNI training service believes that there should be at least 20 trials. This is not a bug, but I think we can at least print a warning message for this.

@ultmaster I think we should add a "skipped" status for deduped trials in this case.
cc @QuanluZhang @liuzhe-lz

In NNI HPO, the experiment status will become "Tuner_No_More_Trial" in this case. NNI NAS has not supported this status.

In NNI HPO, the experiment status will become "Tuner_No_More_Trial" in this case. NNI NAS has not supported this status.

@ultmaster do you think it make senses to use this status for the 2 dedup trials for NAS.

I think we should add the ability to "done" an experiment through Rest API.

Per scrum discussion today, we will discuss the update the current API to change the "Running" status to "Tuner_No_More_Trial" in 3.0.
Thanks @makonaga for reporting the issue, stay tuned on the update.

@matluster @matluster @scarlett2018
Thank you.
I could understand the reasons leading to this phenomenon.
(And I could also confirm that this does not happen by setting ”dedup=False.”)
I will close this issue.


LANDrop Win V2.3.0 TLS Initialization Failed

When click check update, warning meassage shows below:

This issue also exist in V2.1.2

Resolved


Create Functionality for "Two Year" Interns

Create Functionality for "Two Year" Interns
Summary of Enhancement
Currently, the web app would not support functionality for interns who work across two years (i.e. those who start work in one year and then finish the internship in the next.) The program could only do the same process twice for both years, but this would be more labor intensive and would not visualize data as well. An intern could merge the excel sheets from the two years in order to properly visualize data, but this would require a modest knowledge of excel on the part of the intern.
Potential Solutions

Write instructions for interns to navigate merging sheets in excel (pros: easier to code; cons: more work on the user)
Add a field for an additional spreadsheet in order to "auto-merge" in the server (pros: will not require as much knowledge of excel for users; cons: harder to code, might be confusing for users)

It is unlikely that any intern would be present between years, due to the timing of the cycles of interns. Thus, this functionality is not currently needed. Closing this issue.


Change to line 622 in Windows.txt

Minor change to documentation to make it a bit more clear.
Changed ?2, ?3 and ?4 to 2, 3 and 4.
Thank you!

Codecov Report

Merging #2158 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2158      +/-   ##
==========================================
- Coverage   73.96%   73.93%   -0.04%
==========================================
  Files          90       90
  Lines      131906   131906
  Branches    28964    28964
==========================================
- Hits        97570    97528      -42
- Misses      34313    34355      +42
  Partials       23       23

Impacted Files
Coverage Δ

src/gui_beval.c
39.87% <0%> (-4.91%)
:arrow_down:

src/window.c
81.02% <0%> (-0.73%)
:arrow_down:

src/term.c
51.23% <0%> (-0.22%)
:arrow_down:

src/message.c
68.26% <0%> (-0.2%)
:arrow_down:

src/gui_gtk_x11.c
47.66% <0%> (-0.11%)
:arrow_down:

src/libvterm/src/screen.c
71.35% <0%> (-0.03%)
:arrow_down:

src/os_unix.c
53.36% <0%> (+0.04%)
:arrow_up:

src/ex_cmds.c
77.8% <0%> (+0.08%)
:arrow_up:

src/channel.c
82.67% <0%> (+0.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b05e49...42d09e7. Read the comment docs.

Let's just list all the numbers to avoid confusion.


Report linter config errors

Some linter config errors were being ignored and the build was passing, causing users to think the build succeeded when it actually failed. This hopefully will help point them in the right direction.

 Improve reporting of errors back to the user (via GitHub?)

Closing this in favor of #108.


[SPARK-33669] Wrong error message from YARN application state monitor when sc.stop in yarn client mode

What changes were proposed in this pull request?
This change make InterruptedIOException to be treated as InterruptedException when closing YarnClientSchedulerBackend, which doesn't log error with "YARN application has exited unexpectedly xxx"
Why are the changes needed?
For YarnClient mode, when stopping YarnClientSchedulerBackend, it first tries to interrupt Yarn application monitor thread. In MonitorThread.run() it catches InterruptedException to gracefully response to stopping request.
But client.monitorApplication method also throws InterruptedIOException when the hadoop rpc call is calling. In this case, MonitorThread will not know it is interrupted, a Yarn App failed is returned with "Failed to contact YARN for application xxxxx;  YARN application has exited unexpectedly with state xxxxx" is logged with error level. which confuse user a lot.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
very simple patch, seems no need?

Can one of the admins verify this patch?

cc @tgravescs and @mridulm FYI

ok to test

Test build #132372 has started for PR 30617 at commit 4cdad1b.

Test build #132372 has finished for PR 30617 at commit 4cdad1b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132372/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36973/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36973/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36973/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36973/

seems not related with this patch

Test build #132453 has started for PR 30617 at commit 57ea973.

Test build #132453 has finished for PR 30617 at commit 57ea973.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37054/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132453/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37054/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37054/

changes look fine.
I assume you manually tested?

Yes，but not fully。
This issue consist of 2 parts: hadoop ipc will raise InterruptedIOException, and InterruptedIOException should be handled correctly.
I test part 2 by raising an InterruptedIOException in client.monitorApplication， but for part 1 I don't find a easy way to mock.
But I believe the error trace is enough to show it will raise InterruptedIOException.

Thanks, merging to master and 3.1


Dialog: closes when 1password icon is clicked

Describe the bug
1Password - and other password managers - typically have a widget that shows up in password fields and which is appended to body.
This means that if I have a password field inside a modal and closeOnClickOutside is enabled - then clicking that widget will close the modal, which is not expected behavior.
This functionality should be probably implemented with "click on overlay" instead of catching clicks outside.
Reproduction
https://www.sveltelab.dev/b7dn7stqhkjikd0
IT WILL NOT WORK IN SVELTELAB: In SvelteLab 1password shows button in top-level page, while app itself is rendered in an iframe. So contents of an iframe never see the click on 1password button.
In order to reproduce you need 1password installed, fork this locally, then try clicking on 1password's icon next to password button.
Logs
No response
System Info
-

Severity
annoyance

https://github.com/melt-ui/melt-ui/assets/919812/2c007537-1645-4eb6-a354-7edd5f3d81c5
Here's a recording of the problem.

Selecting text inside input field with your mouse and dragging it outside the input field closes the dialog as well. This is related I understand.
dialog outside.webm

Selecting text inside input field with your mouse and dragging it outside the input field closes the dialog as well. This is related I understand. dialog outside.webm

This is actually unrelated to this specific issue.


How to compile with watch?

This is awesome! Thank you. How do I compile this with catflap and cargo watch for continuous builds?
Note that the version flag  of rsync that comes with OSX by default errors out on the --info=progress2 flag, so you have to call it with env PATH=/usr/bin/local:$PATH cargo remote -r user@build-server build

@theronic could you have a look at #3 please? If it actually fixes the Mac OS rsync problem I'd merge it. If you wish to work on integrations with other cargo tools I can help you (then I'd probably update all the dependencies first so you don't have to deal with that ancient stuff), but since I'm not using cargo-remote at the moment I don't have much motivation for actual development.

@theronic you can use cargo watch  like cargo watch -s "ssh user@build-server pkill -f app ; cargo remote -r user@build-server run"


python3.pkgs.llfuse: fix cross

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 145655 run on x86_64-linux 1

4 packages failed to build:

borgbackup
borgmatic
pika-backup
vorta

2 packages built:

python38Packages.llfuse
python39Packages.llfuse


Is there any support for multiple off chart plots, and if not can you add it.

If it's possible that would be amazing. I'd love to be able to have 10+ off-chart plots, this is an odd ask I know. The best way to implement this would probably be to implement a scrollbar along the side so that way you can move through the off-chart plots via scrolling while leaving the main chart in the same location. This would also require an option to move the bottom "time/vertical crosshair line label) to directly under the main chart instead of underneath the last off-chart plot, that way you would be able to scroll through the off chart plots while still being able to see the vertical crosshair label at the bottom of the main plot.

I agree that would be amazing, but I think it's out of scope for now. May be in the future. Anyway I'll add it to the list.
As a side note, I think this will make the layout even more complex. Another way to solve this is to introduce a headless mode with time-linking, so users can do whatever they want.
Btw, thanks for creating a bunch of good issues!

No problem, I'm just trying to figure out if this might finally be the project that's the goose capable of laying the golden egg that I need because one things for certain. I don't have a damn clue about how to code up any of this myself. You can give me a strongly typed programming language like Java and I'll give you the world, but anything remotely birthed out of the web just makes my head spin (html, css, javascript, xml, etc.).

On second thought, might it be possible to implement this through a custom overlay like RSI. I might have to explore that. i.e I build an overlay that can accept a JSON file or parameters or whatever of either other overlays or javascript elements and builds them into a single element. Hmmm

Better yet, how hard would it be for you to create an empty overlay of a user definable size. If the vertical size is larger than the default then implement a scroll bar on the size. Just a blank graphics canvas that can scroll. Then the user can define whatever functionality they want inside of that???

it's just a small lib, but probably the most 'hackable' out there.

Better yet, how hard would it be for you to create an empty overlay of a user definable size.

I need to clarify: overlays live inside grids and currently there is no way to change grid size (it calculates automatically). This feature is definitely on the horizon.
As a temp solution you can make a very tall chart (by setting a height bigger that the screen).

Not on the map right now, closing.


Created daffodil-dev branch. Change byteOrder of hexBinary infoset data.

Change required since byte order no longer used for hexBinary in
daffodil.

Created daffodil-dev branch.
Changed test data to match current daffodil hexBinary change which no longer uses byte order.
This can't be merged until there is an official daffodil release that has the hexBinary-byteOrder change


The sorting strategy "alphabetical" should use localeCompare()

The sorting strategy "alphabetical" should use localeCompare()
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/localeCompare
https://github.com/TypeStrong/typedoc/blob/ea0ea91d144a34295569113d3208beb1ee2efa03/src/lib/utils/sort.ts#L65
https://github.com/TypeStrong/typedoc/blob/ea0ea91d144a34295569113d3208beb1ee2efa03/src/lib/utils/sort.ts#L74
a.name.localeCompare(b.name)

PR welcome


⚠ Ixtanet SAT has degraded performance

In e577b82, Ixtanet SAT ($MEDIA_SAT) experienced degraded performance:

HTTP code: 200
Response time: 20633 ms

Resolved: Ixtanet SAT performance has improved in 20dae7a after 290 days, 23 hours, 2 minutes.


java. maven repository?

Hello,
I can't find the official keyczar maven repository/release.
http://search.maven.org/#search|ga|1|keyczar
Have you guys/girls named it differently? Or not published it?
So could you give me, pretty please with a cherry on top, the other name or publish it? :)

+1 +1

Would be incredibly useful :)

https://jitpack.io/#google/keyczar
You could try this: makes a maven project form the github project.
My only problem is that the last release in java was in 2013.
Has there been any algorithms that have been broken that we should avoid using?  (I just feel for security libraries 2013 is very old)

+1

Any plan to publish artifacts in maven central yet?

+1

+1

I'm using https://raw.githubusercontent.com/google/keyczar/master/java/maven/ as maven repo url for now.

Thanks @kondratovich, it works, I've updated https://github.com/google/keyczar/wiki/MavenInstructions to reflect that change.
Anyway, I hope some of the maintainers publish it to maven central.

any updates?

Thanks for the reminder on this.
This week is very busy for me - but I've put a note in my calendar to look into this next week.

Any news ?

+1