#158518449 update passenger profile

What does this PR do?
Adds passengers' profile update form for user to change;

Password
Email address
Username

Description of Task to be completed?

Building (without functionality), the UI elements with HTML&CSS.

How the app should be tested
On a webbrowser:

Download the repo
Extract and navigate into the Ride-My-Way folder
in the UI folder, open update_passenger_profile.html on a browser

On a  terminal (Linux):

Install and set up git sudo apt install git

Clone the repository git clone https://github.com/artorious/Ride-My-Way.git

Run git checkout ft-passenger-profile-update-158518449

Run cd Ride-My-Way/UI/

Open update_passenger_profile.html on a browser

Any background context you want to provide?
The UI has no functionality.
Developed using HTML and CSS
What are the relevant pivotal tracker stories?
#158518449
Screenshots

Questions:

Consider a margin between update and discard.
What if you had the update button to stand out in order to avoid accidental discard activities by the users.

It looks nice just check on the comments by @JoshuaOndieki

Did you make changes as per the recommendations from your peers? @artorious

@Ogollah @JoshuaOndieki @LWanjiru I appreciate the input and direction.


What is the reason why the Ingestion framework uses python instead of java?

The maintenance cost of using one language uniformly will be low, I want to know what are the advantages of using both java and python?

@sureshms @ayush-shah @harshach

@Narcasserun One main reason is

Ingestion Framework requires a scheduler to run the these jobs at a scheduled intervals so that we get new metadata frequently
Similarly ingestion framework not just limited to fetching metadata but also to run data profiler and tests etc..

In OpenSource we already have very popular schedulers such as Apache Airflow, Prefect etc.. they all are on python and it would be easier for us to integrate into existing scheduler to run these jobs/dags instead of re-building one from scratch.
Also another important thing here is SQLAlchemy , python library which has bindings to pretty much all of the databases . This helps us fetch metadata easier.
Hope this answers your question.

@Narcasserun One main reason is

Ingestion Framework requires a scheduler to run the these jobs at a scheduled intervals so that we get new metadata frequently
Similarly ingestion framework not just limited to fetching metadata but also to run data profiler and tests etc..

In OpenSource we already have very popular schedulers such as Apache Airflow, Prefect etc.. they all are on python and it would be easier for us to integrate into existing scheduler to run these jobs/dags instead of re-building one from scratch. Also another important thing here is SQLAlchemy , python library which has bindings to pretty much all of the databases . This helps us fetch metadata easier. Hope this answers your question.

Thank you very much for your answer. I have now implemented a metadata management of a multi-data source integrated architecture similar to Metacat. I hope to contribute some good features to OpenMetadata later.


Upload ipa and report error,How to repair?

Upload fail: TypeError: Cannot read property 'path' of undefined
at Object.add (D:\Work\Project\NodeJS\ipa-server-master\libs\ipa-manager.js:106:65)
at process._tickCallback (internal/process/next_tick.js:68:7)

Please run on Linux or macOS.


Updates the card service as per latest Stripe docs

This updates the card service to use the methods on customers.* e.g. customers.retrieveCard rather than the pattern used by most resources of resource.retrieve. As per latest stripe docs.

Sorry this took so long @bedeoverend. Thanks for the PR! 😄

@ekryski no worries - excited to start removing my internal code and shifting over to this project 😄


Add Infinite feature and fix some minor issue

Add infinite carousel
Fix issues:

Carousel not shown: Make sure Element_SizeChanged called at least one

I cannot evaluate your pull request. It seems you override the entire files. Thanks a lot for the collaboration.

Can you break this in separated PR?

We are using your libs in our project and our changes are in production already.

We didn't override your files. That might be issue on merging.

I checked that this is the way Github diff shows the changes. You could compare using Visual Studio for ease of comparison. We are currently using your code directly, but I think it's better to create a pull request then use the nuget :).

No, this not the way GitHub shows the changes. Normally it highlight in green the line or piece of code that changed. In your case is highlighting the entire thing, which is hard to understand.
Please, create separated PR for each fix/functionality. Start from scratch so only the pieces of code that changes are highlighted.
Thanks

The code is copied from our production source code so there, it comes as a whole when published to Github.
I couldn't help to create separate pieces for you.

Thanks.

Will you merge?

Only after you provide separated PR and me reviewing and evaluating the changes. Thanks


Issue770 sep arguments for reading csv files and storing reports

Fixes #770 --> Includes sep_reports, sep_logs, and sep_config to read csv files (logs and config file) and to store reports.

Checklist before merging:

[x] Existing tests still work (check by running the test suite, e.g. from RStudio).
[ ] Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
[ ] Updated or expanded the documentation.
[ ] Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
[ ] Added your name to the contributors lists in the DESCRIPTION and CITATION.cff files.

This branch is behind with the master branch, updating with master branch should address some or all of the failing tests

Thanks Vincent, I was working on that. It was not only updating the branch but also changing some read.csv functions for data.table::fwrite (fwrite can handle the sep argument better than read.csv). Now the tests pass, but I have an extra proposal below.
The data.table::fread function has an automatic detection for sep. I have tested this using comma, semicolons, and tabs in the files and it works well, it can read the data correctly. Should we investigate if replacing all read.csv for data.table::fread in GGIR work properly? If so, we can skip the sep_logs and we might not need to include another sep argument to read in the csv files with raw accelerometer data in the future.
If you agree with this, I will replace all read.csv and write.csv for fread and fwrite, and write some extra tests to make sure GGIR can read correctly raw acc files and log files with different sep.

Ok, sounds good. Double check that output format is the same, as I believe fread produces data tables instead of data.frames as read.csv does. Either way, I suspect that that could be a potential source for problems.

Codecov Report

Merging #791 (80854a5) into master (9e3dbad) will decrease coverage by 0.02%.
The diff coverage is 72.82%.

:exclamation: Current head 80854a5 differs from pull request most recent head 64b3ba4. Consider uploading reports for the commit 64b3ba4 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
- Coverage   73.81%   73.80%   -0.02%
==========================================
  Files          90       90
  Lines       11320    11350      +30
==========================================
+ Hits         8356     8377      +21
- Misses       2964     2973       +9

Impacted Files
Coverage Δ

R/g.plot.R
70.58% <0.00%> (-5.61%)
:arrow_down:

R/g.readaccfile.R
43.83% <ø> (ø)

R/check_params.R
57.91% <33.33%> (-0.27%)
:arrow_down:

R/g.part2.R
59.68% <40.00%> (-0.11%)
:arrow_down:

R/g.report.part2.R
64.59% <42.85%> (ø)

R/g.part4.R
75.18% <50.00%> (ø)

R/g.report.part4.R
82.14% <83.33%> (ø)

R/g.part5.R
75.26% <85.71%> (+0.09%)
:arrow_up:

R/convertEpochData.R
85.06% <88.00%> (+2.30%)
:arrow_up:

R/GGIR.R
73.36% <100.00%> (+0.11%)
:arrow_up:

... and 8 more

No, don't change it there as that would mean I have to test the functionality again on all test files. So, this would have to be a separate issue and a seperate project.

Great, so now it is working and all the tests pass. Only two new arguments are added: sep_reports and sep_config, and they are only used to store csv files. I am wondering if we could simplify this to only sep and it would be clarified in the documentation that it is used both for the reports and the config file. What do you think?
As reading is now more flexible with fread, we do not need any other sep argument for reading logs.

I have revised your proposed changes, see also a couple of comments above related to changes that I think it would be better to keep.

Already implemented these changes and just tested it again with sleeplogs in different formats and it wors as expected.

I have now updated this PR with the master branch, and made a few minor edits to this PR:

Object summary was declared but not used, so I remove that line.
I have renamed object daysummary to be P2daysummary_tmp. In this function this is important to clarify from which GGIR part a summary is as it loads and merges results from all the parts.


Fix for behavior that adds to symbol table on runtime issue.

Throw exception instead of bind on null, move runtime errors within evaluate and add test cases.
Fixes #44

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!

weird I can't reproduce this cross build error in docker.


Add SPDX License Header to Analyzer-Cli Test Files

Add SPDX license headers to all test files in the Analyzer-Cli project.

@Jeeppler : please look at ./apply-headers.sh in root folder. This does automatically appy spdx to our "normal" soruce files. It also describes some problem solutions/mitigations - e.g. for bash files (we do NOT add spdx headers on first line there...).


Feature/disable inaccessible buttons

Disable buttons that require the tenant to be an issuer.

Button behaviour/look is unchanged when tenant is an issuer.

messed up the rebase, redoing in new branch.


How to show info window for symbol layer with custom xml layout and handle click events on its views

I use Bubble layout and show custom info window. my info window has EditText, image view and ... . and i need handle click of views on info window that has custom XML layout. bubble layout was deprecated. help me what can i do to do get my goal!!?
i asked same question in another word and i did not get right answer, refer: #649 (comment)

i see this issue https://github.com/mapbox/mapbox-plugins-android/issues/887 too, but the example in it is deprecated.

This example is not deprecated, it's still the correct way to display a custom bitmap as an InfoWindow. To support your use case, you can try the MarkerView plugin. Instead of a marker, you can display an info window on top of the symbol layer.
In general, platform views are not supported outside of the MarkerView plugin and custom implementations.


I have git in my computer but not in C:/ ,but the vscode cannot find it ? Is git must put in C:/ ?

VSCode Version: Code 1.4.0 (6276dcb0ae497766056b4c09ea75be1d76a8b679, 2016-08-04T16:45:31.680Z)
OS Version: Windows_NT ia32 10.0.10586

Steps to Reproduce:

absolutely nope.
just make sure that git directory is in your PATH of your enviroment variables ie. make sure you can use `git

Indeed, thanks.


Add smoke tests for BigQuery.DataTransfer and Trace v2

These smoke tests don't work - creating the PR to let Chris see them :)

This is now fixed, and the new tests are in a separate PR.

@jskeet As far as I know, only one of these problems is fixed.
ParentNameOneof.From(new LocationName("[PROJECT]", "[LOCATION]")) is still generated, which presumably still causes problems?

Config fixed here: https://github.com/googleapis/googleapis/commit/e78a9ab4d32860f633dde839090ef172b987d845#diff-0cee087908075875821b3648c075c59f


import syntax problem

Greetings,
In both python 2.6.6 on a centos 6 box and in Portal Python 2.7.6 on a Windows computer, I need to do:
from graphitesend import graphitesend
gs = graphitesend.init()
gs.send("foo", 5)

in order for graphitesend to work.  If I just do an import, as per your documentation, I get the following:
import graphitesend
gs = graphitesend.init()
gs.send("foo", 5)

results in:
$ python t.py
Traceback (most recent call last):
  File "t.py", line 2, in <module>
    gs = graphitesend.init()
AttributeError: 'module' object has no attribute 'init'

I dont think I have ever run any of graphitesend on python 2.6.
I'll have a look into the errors for a easy fix.

Same issue with graphitesend 0.4.0 on RHEL 6.5 w/Python 2.6.6


No tabs (?)

In the previews you showcase your terminal having tabs of some sort

but if I open my terminal, do ctrl + shift + p and run the new tab command, it does not showcase this bar at the top
i may be misunderstanding what it is

You're correct, these are tabs. However, the screenshots were taken in Wezterm, not windows terminal.
See the config file here:
https://github.com/scottmckendry/Windots/blob/66b478c81f992b46b0b6563a45ba5d19bf1e85b6/wezterm/wezterm.lua#L35

Thank you so much!


Update README.md

Added missing / on maven dependency jadira - usertype.extended

Coverage remained the same at 79.19% when pulling c7a65cb8717372405b9adad4a0aa7e3276d9d214 on mlotysz:patch-1 into 31a5babab98292094dffed4b8684c95222d8b5f0 on dropwizard:master.

Thanks!


Update as upstream

Update as upstream

You have accidentally changed docs/api/browser-window.md instead of the one under translations.

@zcbenz Ah, I have confused with main docs. Sorry about that!

Committed at bd1b6fdc74fa0c3ea8501be2ee9eed0c85204951, thanks!


Multisig script construction

Context

We want to be able to construct script needed for multisig address.
Decision

Support for multisig construction is to be delivered. We should be able to construct nested predicates. (verification keys with all/any/atLeast guard). Introduce CLI enabling constructing hash from key, and constructing script hash
Acceptance Criteria

Multisig script type is defined and needed instances delivered
Multisig script can be constructed via CLI
Multisig script construction is tested
Hash of key functionality in CLI is added

Development

QA

There were a number of test suites added. The user now can do the following:
How to construct a script and calculate its hash in cardano-addresses

Let's say I have the following recovery phrase

$ cat recovery-phrase.txt
nothing heart matrix fly sleep slogan tomato pulse what roof rail since plastic false enlist

Now we create root key

$ cat recovery-phrase.txt | cardano-address key from-recovery-phrase Shelley > root.xprv
xprv1apjwjs3ksgm5mnnk0cc5v5emgv0hmafmmy8tffay5s2ffk69830whwznr46672ruucdzwwtv9upv72e4ylrypyz5m6cyh0p00t7n3u3agt20lv32j4kxcqlkzu78nzjx0ysxxlc2ghfz9prxfmrds802xsh67k7t

And derive two signing keys according to multisig CIP (TO-DO add link when available)

$ cat root.xprv | cardano-address key child 1852H/1815H/0H/3/0 > signingKey1.xprv
xprv1nrywvqyuwefulu6mqmpxelz92kcy0zluu5kf5p74c6l6f6z9830pfvcvgen923akys2d2fmlh8t3fttj6nvx040k30ek8k62jyvv9p38c8lyuz9qkyhgnyme7ay742e7nemd037jdevpl688fdvtcfq9eqpnkr57
$ cat root.xprv | cardano-address key child 1852H/1815H/0H/3/1 > signingKey2.xprv
xprv1vpr59y3p3cfggk85x6dvmlpkwm9f4c99lvkmw8r6j5vwd669830rw5lvsuh8530q897ht9a297kw2qhkpvn7kk98njhdg3scter64uukrwtashzde54v8ery8a92npx4e22ffg45mtshe6ewpnzjx2cn9qs42k0f

The corresponding verification keys and their hashes can be obtained as follows

$ cat signingKey1.xprv | cardano-address key public | cardano-address key hash --base16 > verKey1.hash
de5861cd05e99985b2c586ab383790c6600990809206f84e96eadaea
$ cat signingKey2.xprv | cardano-address key public | cardano-address key hash --base16 > verKey2.hash
aca52d7d28ce353f4766e4e2c8cc2208c7113d794e776eafb8c07a80

Notice the default hrp (in bech32) for the hash of verification key - xpub_hash

$ cat signingKey1.xprv | cardano-address key public | cardano-address key hash
xpub_hash1mevxrng9axvctvk9s64nsduscesqnyyqjgr0sn5katdw5egajw2

Now we can construct the script using the hashes of verification keys

$ echo "all [$(cat verKey1.hash),$(cat verKey2.hash)]" > script.txt
all [de5861cd05e99985b2c586ab383790c6600990809206f84e96eadaea,aca52d7d28ce353f4766e4e2c8cc2208c7113d794e776eafb8c07a80]

Having a script constructed we can get its script hash that could go to payment or staking credential when creating the address. Please notice the default hrp (in bech32) - script_hash

$ cardano-address script hash “$(cat script.txt)”
script_hash15hx806zf0g8kcv399dpxf6fq4l98myqpvvzj2rltg465uz36435

LGTM.


db got deleted after a massive slowdown

Hello.
I have a weird behavior with this module.
This is a the second time my db got deleted after a massive slowdown of the app.
anyone suffered from this ?

Can you provide a testcase that replicates?

unfortunately no.
it's sames to be random. but I suposed it's because the app (nw.js) slowsdown and I have to kill it in the middel of some processing.
that's why I asked if anyone is facing the same issue.


Implementation of Citation Style Language (CSL) for common metadata export (eg. RIS, Bibtex)

Hi,
I encountered one interesting issue mentioned in #5832. Currently, CSL can be implemented using (https://github.com/atmire/CSL63) in DSpace 6.3 which was EOL. So, I'm wondering can it be included in DSpace 7 or future version? If possible, it would be great. Thank you.

The code referenced above is from Atmire and was never officially in DSpace 6.x.  Therefore, this would require a volunteer (or possibly Atmire) to port or rebuild that work into DSpace 7.  I'm not aware of anyone working on that.  But, if a volunteer is interested, they are welcome to claim this ticket to work on it.

I should find some time to complete #8295 .  It may have bit-rotted somewhat, but mostly it needs UI work.


Support async?

I can see simple fn support (COOL!) but I didn't any mention or an example for async and also nodejs support or maybe TODO?

We currently prioritize WasmEdge-bindgen support in Go, C, Rust, and Python SDKs. In nodejs, there is already wasm-bindgen so it us less urgent. But we would really appreciate contributions in that area. It should be just wrapping the NAPI around the WasmEdge C SDK.


Build v8go in CI test workflow with clang sanitizers

Instead of trying to run valgrind across different platforms, we can conditionally set flags for relevant clang sanitizers on the builds of v8go when we are running tests so that we can automate the checking of any memory/thread leakage (for example.)
We could do the conditional configuration in here: https://github.com/rogchap/v8go/blob/master/cgo.go
Here is an example clang sanitizer: https://clang.llvm.org/docs/LeakSanitizer.html

We don’t need to run the leak detector on all platforms.  It is unlikely that there will be platform specific leaks.  So we could just use valgrind on CI, only on linux.  E.g. we are doing that in a ruby C extension (https://github.com/Shopify/liquid-c/pull/162).
It would just be nicer if we could run the leak checker locally on a non-linux OS, if it can catch leaks just as well.

The new Go release will include Address Sanitizer (https://github.com/golang/go/issues/44853), so we should use that.  It looks like gcc also supports address sanitization, so this isn't actually clang specific as I previously thought.  The address sanitizer normally do a leak check on exit, although even with gotip that still needs to be done explicitly by calling __lsan_do_leak_check().  What matters is that we should align ourselves with Go's future tooling, which is more likely to have better integration in the future.


Improve logic for version bumping in CD

Currently, all cases are hard-coded, so maintenance is not easy.
# 🤯
# https://github.com/duckie-team/duckie-quack-quack/blob/develop/.github/workflows/artifact-publish.yml

 - name: Bump artifact version (type_Major, target_LintQuack)
   if: ${{
     contains(github.event.pull_request.labels.*.name, 'bump_major') &&
     contains(github.event.pull_request.labels.*.name, 'target_lint-quack')
     }}
   run: ./gradlew bumpVersion --scan -Ptype="Major" -Ptarget="LintQuack"

 - name: Bump artifact version (type_Major, target_LintCompose)
   if: ${{
     contains(github.event.pull_request.labels.*.name, 'bump_major') &&
     contains(github.event.pull_request.labels.*.name, 'target_lint-compose')
     }}
   run: ./gradlew bumpVersion --scan -Ptype="Major" -Ptarget="LintCompose"

 - name: Bump artifact version (type_Major, target_UiComponents)
   if: ${{
     contains(github.event.pull_request.labels.*.name, 'bump_major') &&
     contains(github.event.pull_request.labels.*.name, 'target_ui-components')
     }}
   run: ./gradlew bumpVersion --scan -Ptype="Major" -Ptarget="UiComponents"

 - name: Bump artifact version (type_Minor, target_LintCore)
   if: ${{
     contains(github.event.pull_request.labels.*.name, 'bump_minor') &&
     contains(github.event.pull_request.labels.*.name, 'target_lint-core')
     }}
   run: ./gradlew bumpVersion --scan -Ptype="Minor" -Ptarget="LintCore"

# ...

We need to find a way to implement it by eliminating the repetitive structure.
--
Reference
conference-app-2022/CommentPR.yml 를 보면 자바스크립트를 사용하고 있다.

나도 이런식으로 해결할 수 있지 않을까?

DONE
https://github.com/duckie-team/duckie-quack-quack-mvp/pull/310


Minor cleanup, address warnings

No functional or breaking changes. Only containing minor housekeeping changes (address warnings)

Docs: grammar fixes
Gradle config: checkstyle, pmd and spotbugs config used in subsequent PR
Build files: quotes only
OpenApi: remove disallowed fields
GitHub workflows: Use V4 actions
Shell scripts: Use quotes for variables (Best practices)
cli: address warnings, minor optimizations
indexer: address warnings, minor optimizations

Doesn't need to be in this PR, but could you add a section to the DEVELOPER_INFO.md doc about how you generated all these changes please? Even if it's not automateable, I think it's useful info to preserve. Thanks again for all this cleanup work!

Done, added along with links to style guide


benchmarks: sched: capture output and evaluate

We were running this as a test and not evluating the output. Now we
verify the output and stop treating this as a ztest item.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3854f23). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #15097   +/-   ##
=========================================
  Coverage          ?   52.88%
=========================================
  Files             ?      309
  Lines             ?    45267
  Branches          ?    10451
=========================================
  Hits              ?    23938
  Misses            ?    16556
  Partials          ?     4773

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3854f23...58aa932. Read the comment docs.


Latest ReClass isnt working for me

Am trying to build the  git cloned solution on code 2019 using the latest .net release 528372 with the c++ sdk kit. for some reason when I try and open up the x86 exe and run it, it doesnt work.
The only compling error I got was related to NativeCode .vcxproj, but have been told not to worry about it.
Upon starting i get this

anyone has similar problems?

Could you please send a screenshot of the "Details" or even better, run ReClass.NET in the VS debugger. It should break on the exception and show more useful informations.

sure thanks for the quick reply

I have seen this error somewhere else but could not reproduce it at the time. Now I don't know where I got the report. For a quick fix just remove the DrawImage line. You loose the icons but no functionality. The error may be using a already disposed image. I will investigate this error if possible.

thanks that quick fix will do me, am just learning. thanks

I have found the error. This problem occurs while scaling icons if you have changed the DPI settings in Windows. I don't use scaling so the original image without the problem was used. Update your code to the last commit and the error should be gone.

that make sence yeah I have a big monitor and have changed my DPI setting so I can read !! thank you so much


Update packages

Address these 7 alerts - https://github.com/populationgenomics/sample-metadata/security/dependabot?q=is%3Aopen

Codecov Report
Patch and project coverage have no change.

Comparison is base (e6006b9) 68.41% compared to head (5b140cb) 68.41%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #491   +/-   ##
=======================================
  Coverage   68.41%   68.41%
=======================================
  Files          66       66
  Lines        6161     6161
=======================================
  Hits         4215     4215
  Misses       1946     1946

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I thought so too but I did npm audit fix rather than changing package.json directly, and it only updated package-lock.json

I guess that's just how it works - https://stackoverflow.com/a/56683169


All of the tests failed on my computer.

I download the repo, create a venv, and followed the instruction
pip install -r requirements.txt
dvc pull
pytest

But I got

dulwich.errors.HangupException: ssh: Could not resolve hostname https: nodename nor servname provided, or not known

For every single test.

self = <dulwich.protocol.Protocol object at 0x1056a66b0>

    def read_pkt_line(self):
        """Reads a pkt-line from the remote git process.

        This method may read from the readahead buffer; see unread_pkt_line.

        Args:
          path: Remote path to fetch from
          determine_wants: Function determine what refs
            to fetch.  Commands given as a string will be run in a subshell.
        capture : `bool`
            Capture and return output
        check_rc : `bool`
            Assert return code is zero
        cd : `str`
            Path to chdir to, defaults to workspace root
        """
        if isinstance(cmd, string_types):
            shell = True
        else:
            # Some of the command components might be path objects or numbers
            cmd = [str(i) for i in cmd]

        if not cd:
            cd = self.workspace

        with cmdline.chdir(cd):
            log.debug("run: {0}".format(cmd))
            if capture:
                p = subprocess.Popen(cmd, shell=shell, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, **kwargs)
            else:
                p = subprocess.Popen(cmd, shell=shell, **kwargs)
            (out, _) = p.communicate()

            if out is not None and not isinstance(out, string_types):
                out = out.decode('utf-8')

            if self.debug and capture:
                log.debug("Stdout/stderr:")
                log.debug(out)

            if check_rc and p.returncode != 0:
                err = subprocess.CalledProcessError(p.returncode, cmd)
                err.output = out
                if capture and not self.debug:
                    log.error("Stdout/stderr:")
                    log.error(out)
>               raise err
E               subprocess.CalledProcessError: Command 'pip install git+file:///private/var/folders/pv/474xpngj6w71zbfcsxhdxwc40000gn/T/pytest-of-gao/pytest-101/dvc-git-repo0@af70c33' returned non-zero exit status 1.

/opt/homebrew/lib/python3.10/site-packages/pytest_shutil/workspace.py:132: CalledProcessError

@karajan1001 Could you try cloning a dvc repo locally manually and then supply path to it in --dvc-git-repo?

It says
pytest --dvc-git-repo '/Users/gao/Code/dvc/' --dvc-revs af70c33 tests/benchmarks/cli/commands/test_exp_show.py                                    -1-[ins][11:15:20]
ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]
pytest: error: unrecognized arguments: --dvc-git-repo --dvc-revs af70c33 tests/benchmarks/cli/commands/test_exp_show.py
  inifile: /Users/gao/Code/dvc/pyproject.toml
  rootdir: /Users/gao/Code/dvc

And if I use pytest --dvc-git-repo '/Users/gao/Code/dvc.git' --dvc-revs af70c33 tests/benchmarks/cli/commands/test_exp_show.py
It says
>               raise NotGitRepository(
                    "No git repository was found at %(path)s" % dict(path=root)
                )
E               dulwich.errors.NotGitRepository: No git repository was found at /Users/gao/Code/dvc.git

.venv/lib/python3.10/site-packages/dulwich/repo.py:1090: NotGitRepository

@karajan1001 did you ever solve this? Since the error was that the--dvc-git-repo flag was not being recognised, I'm assuming this is due to the virtualenv not being set up correctly (possibly using a pytest version not in the virtualenv?)

@karajan1001 did you ever solve this? Since the error was that the--dvc-git-repo flag was not being recognised, I'm assuming this is due to the virtualenv not being set up correctly (possibly using a pytest version not in the virtualenv?)

Still the same, I'm in pytest 7.2.0, and which pytest points to the venv directory.

pytest --dvc-git-repo='/Users/gao/Code/dvc' --dvc-revs='main' tests works for me.

@karajan1001 Looks like you accidentally specified .git suffix on a dir instead of pointint to the dir or .git within that dir. (incorrect /Users/gao/Code/dvc.git vs correct /Users/gao/Code/dvc or correct /Users/gao/Code/dvc/.git).
So now everything works fine? I suppose the original issue was related to the proxy/vpn/firewall?

Note the =.
pytest --dvc-git-repo path/to/dvc tests/ is broken, whereas pytest -s --dvc-git-repo=$w/dvc tests/ works

@dtrifiro Good point. Please disregard my last comment, I got confused myself 🙂

I think this is how pytest parses arguments.

Custom pytest plugin commandline arguments may include a path, as in pytest --log-output ../../test.log args. Then args is mandatory, otherwise pytest uses the folder of test.log for rootdir determination (see also issue 1435). A dot . for referencing to the current working directory is also possible.

pytest --dvc-git-repo='/Users/gao/Code/dvc' --dvc-revs='main' tests works for me.

Closing 🙏


Use default leader election config

Restore default leader election config to avoid contention on the
contour ConfigMap. Contour will create a leader-elect ConfigMap for
each namespace that is dedicated to the leader election.
This change should allow tools like kapp to update the contour config
with an optimistic lock based on the current resource version.
Previously, the resource would mutate before kapp could complete the
update.
Signed-off-by: Scott Andrews<EMAIL_ADDRESS>

/assign @mattmoor

/lgtm
/approve
Thanks!


grpc support

Is anyone thinking to add support for grpc services ?

Hi jorgheymans
Currently PINPOINT team have no plan to support grpc.
We don't have anyone with enough experience with grpc so we won't be able to easily add grpc support.
If you familiar with grpc, you could go ahead and make a plugin for it  and send us a pull request!
thanks. :)


proposal: Go 2: net: make Pipe asynchronous

Currently, net.Pipe is documented as such:

Pipe creates a synchronous, in-memory, full duplex network connection; both ends implement the Conn interface. Reads on one end are matched with writes on the other, copying data directly between the two; there is no internal buffering.

This behavior occurs because net.Pipe was just a thin wrapper over io.Pipe, which is implemented as being synchronous. However, most network connections are not synchronous as they involve buffering at multiple layers (in the OS, on the wire, etc). Thus, we should switch net.Pipe to act in an asynchronous fashion to better emulate true network connections.

I will directly add to this bug that the current implementation is so surprising that it violates the io.Reader documentation: "Implementations of Read are discouraged from returning a zero byte count with a nil error" and I don't see a way of fixing that without stop matching writes and reads 1:1. For n > 0 zero writes, either you need to not send zero writes (n:0) or you need to read writes until you get a non-zero write (n+1:1).

Could you provide some additional rationale for this proposal? Why do you want net.Pipe to better emulate "real" network connections?
It might actually be beneficial to have net.Conn implementations that differ from the most commonly used ones while still satisfying the net.Conn contract, to avoid "all the world is a TCP socket" assumptions from creeping in. Not sure whether that has to be net.Pipe, though.

Why do you want net.Pipe to better emulate "real" network connections?

The most common use-case of net.Pipe is for testing. A test that is non-representative of the real-world is a poor test. It's not even an issue of "all the world is a TCP socket". Even Unix domain sockets present some form of buffering.
Suppose we were adding net.Pipe for the first time, I would still be asking for justification why this should be synchronous.

Note: This issue IMO is not that it's buffered or "synchronous". I think it makes sense to have a non-buffered synchronous net.Pipe for simplicity, but have no strong opinion about it. If you want buffering you can always glue some buffering onto the write interface.
The issue is that the current implementation is synchronous in a way that is very unhelpful and confusing. What does a pipe synchronize? It synchronizes data - bytes. Somehow the implementation are currently synchronizing something completely different: read and write operations. Common sense dictates that a pipe should block a read if there is no data to read and block a write if the write is not done yet. Essentially: we block when there is something remaining to do, otherwise we return to the caller.
But surely synchronizing read and writes is the same as synchronizing their data? Incorrect, when you write a zero length buffer (which is completely valid and should be a no-op) you now have to synchronize that operation with a read operation and return a zero length string - and block the write if there's no read operation to synchronize with. This breaks this critical assumption about how a reader and writer should behave.
For the same reason ("h" + "" + "ello" + "wo" + "" + "rld" + "") is the same as "hello world", write("h"); write(""); write("ello"); write("wo"); write(""); write("rld"); write("") should have the same effect as write("hello world"). Anything else is just really surprising.
The simplest way to fix this in the current net.Pipe is to simply ignore zero length writes instead of blocking, a one liner change. The argument against that is that the documentation somehow forbids this and this is therefore a 2.0 feature. My argument against is as follows:

io.TeeReader has equivalent documentation and does discards zero length buffers without matching those reads to "corresponding writes".
There is no "1:1 mapping of reads to writes". One write operation maps to some N number of reads already. Why can't N be zero? The documentation doesn't forbid it as far as I can tell.

@hnsl To be clear, the net.Pipe behaviour does not violate the io.Reader interface contract. Returning (0, nil) might be discouraged, but is still perfectly legal.

Agree, and I make no claim on the contrary.

A while ago I was implementing a synchronous network protocol, and used net.Pipe to test it. The lack of buffering caused a deadlock. If net.Pipe did buffering, I probably would not have noticed that my implementation depended on the underlying connection buffering at least n bytes.

This issue IMO is not that it's buffered or "synchronous".
…
The issue is that the current implementation is synchronous in a way that is very unhelpful and confusing.

Agreed 100%.

The simplest way to fix this in the current net.Pipe is to simply ignore zero length writes instead of blocking, a one liner change. The argument against that is that the documentation somehow forbids this and this is therefore a 2.0 feature.

Part of the problem is that the semantics of net.Pipe should pretty clearly match the semantics of io.Pipe, which does document this behavior clearly:
“Reads and Writes on the pipe are matched one to one except when multiple Reads are needed to consume a single Write. That is, each Write to the PipeWriter blocks until it has satisfied one or more Reads from the PipeReader that fully consume the written data.”
I would argue that we should change both io.Pipe and net.Pipe to drop 0-length writes in Go 2, and keep them both synchronous. That would remove the discouraged (and confusing) 0-length Read behavior, but keep net consistent with io.

most network connections are not synchronous as they involve buffering at multiple layers

Not every network connection is asynchronous. For example, I believe that implementations of UNIX domain sockets typically do not induce any additional buffering: writes can be copied immediately into the read buffer.
Moreover, “true” network connections often involve other effects (such as MTUs) that can affect read chunking. Fundamentally, if you want to make sure your program works with a particular kind of socket, you need to test it with that particular kind of socket: a fake that is more realistic in one dimension may only hide unrealism in another.

FWIW, I wrote bufconn for grpc's tests and benchmarks, which you can use in accordance with our license:
https://godoc.org/google.golang.org/grpc/test/bufconn
And also a latency package for realistically simulating bandwidth, latency, and MTU effects: https://godoc.org/google.golang.org/grpc/benchmark/latency

FYI I had to use use something like this to write integration tests for a TCP multiplexer and a proxy tool, so I rolled one up: https://github.com/cbeuw/connutil
It's also got some other utilities, like Dialer and net.Listener that Dial/Accept ends of pipes


Fix cluster directory being created with root ownership

When hostpaths used for bind mounting in Docker don't exist at the time the container is created, dockerd creates the directory. dockerd runs as root on most systems hence the directory is created with root ownership.
This ensures the directory exists before we attempt to launch the tools container that bind mounts the cluster directory.

The docker command was demonstrated to be executing before the directory is created through an strace.
3195314 21:24:01.454557 execve("/usr/bin/docker", ["docker", "run", "-d", "--name", "eksa_1715203440722790952", "--network", "host", "-w", "/home/chrisdoherty", "-v", "/var/run/docker.sock:/var/run/do"..., "-v", "/home/chrisdoherty:/home/chrisdo"..., "-v", "/home/chrisdoherty:/home/chrisdo"..., "--entrypoint", "sleep", "public.ecr.aws/l0g8r8j6/eks-anyw"..., "infinity"], 0xc000ab2000 /* 32 vars */) = 0
...
3195265 21:24:01.715948 mkdirat(AT_FDCWD, "persistent-mgmt", 0777) = 0
3195265 21:24:01.716067 mkdirat(AT_FDCWD, "persistent-mgmt/generated", 0777) = 0

An analysis of stracing the docker daemon with timestamps suggested on successful runs that the timing was extremely close and on failed runs the container launched first, hence dockerd created the host path with root ownership.
The fix inverts the syscalls removing any race.
18416 21:51:24.197012 mkdirat(AT_FDCWD, "persistent-mgmt", 0777) = 0
18416 21:51:24.197097 mkdirat(AT_FDCWD, "persistent-mgmt/generated", 0777) = 0
...
18470 21:51:24.388620 execve("/usr/bin/docker", ["docker", "run", "-d", "--name", "eksa_1715205084197278143", "--network", "host", "-w", "/home/eksadmin", "-v", "/var/run/docker.sock:/var/run/do"..., "-v", "/home/eksadmin/persistent-mgmt:/"..., "-v", "/home/eksadmin:/home/eksadmin", "-v", "/home/eksadmin:/home/eksadmin", "--entrypoint", "sleep", "public.ecr.aws/l0g8r8j6/eks-anyw"..., "infinity"], 0xc000ab2120 /* 34 vars */) = 0

/cherry-pick release-0.19

/lgtm

/approve


fix(toast): add component specific theme colors

can you add values for the dark theme too?

can you add values for the dark theme too?

Will need to clarify those with the designers first, will update once determined that it uses different primitives.


Fixed agent scrolling and resizing issues

Fixes https://github.com/Microsoft/sqlopsstudio/issues/2064.

@abist where are we with this one?  I still see the edits to the tree control in vs directory, so I guess we couldn't find a way to not need that?  Do you think this will be ready for August Public Preview?

@kburtram I synced up with @anthonydresser on this but couldn't figure it out. I believe he's looking into the issue, without changing vs code.

@abist thanks.  So it sounds like this will miss the August release.

@kburtram Most likely, unless we have a solution by today that doesn't touch vscode

Closing this PR since Anthony is looking at the issue.


[BUG] Update developer guide on how to run spotless task on subprojects

Describe the bug
Developer guide suggests to run ./gradlew server:spotlessJavaCheck as an example for executing it on subprojects, but spotless is not enabled for the server subproject, so it errors out:
FAILURE: Build failed with an exception.

* What went wrong:
Task 'spotlessJavaCheck' not found in project ':server'.

This is a meta issue to track spotless enabled for all modules.

[ ] :client:benchmark
[ ] :client:client-benchmark-noop-api-plugin
[ ] :client:rest
[ ] :client:rest-high-level
[ ] :client:sniffer
[ ] :client:test
[ ]  :client:transport
[ ]  :example-plugins:custom-settings
[ ]  :example-plugins:custom-significance-heuristic
[ ]  :example-plugins:custom-suggester
[ ]  :example-plugins:painless-whitelist
[ ]  :example-plugins:rescore
[ ]  :example-plugins:rest-handler
[ ]  :example-plugins:script-expert-scoring
[ ]  :libs:opensearch-cli
[ ]  :libs:opensearch-core
[ ]  :libs:opensearch-dissect
[ ]  :libs:opensearch-geo
[ ]  :libs:opensearch-grok
[ ]  :libs:opensearch-nio
[ ]  :libs:opensearch-plugin-classloader
[ ]  :libs:opensearch-secure-sm
[ ]  :libs:opensearch-ssl-config
[ ]  :libs:opensearch-x-content
[ ]  :modules:aggs-matrix-stats
[ ]  :modules:analysis-common
[ ]  :modules:ingest-common
[ ]  :modules:ingest-geoip
[ ]  :modules:ingest-user-agent
[ ]  :modules:lang-expression
[ ]  :modules:lang-mustache
[ ]  :modules:lang-painless
[ ]  :modules:lang-painless:spi
[ ]  :modules:mapper-extras
[ ]  :modules:parent-join
[ ]  :modules:percolator
[ ]  :modules:rank-eval
[ ]  :modules:reindex
[ ]  :modules:repository-url
[ ]  :modules:systemd
[ ]  :modules:tasks
[ ]  :modules:transport-netty4
[ ]  :plugins:analysis-icu
[ ]  :plugins:analysis-kuromoji
[ ]  :plugins:analysis-nori
[ ]  :plugins:analysis-phonetic
[ ]  :plugins:analysis-smartcn
[ ]  :plugins:analysis-stempel
[ ]  :plugins:analysis-ukrainian
[ ]  :plugins:discovery-azure-classic
[ ]  :plugins:discovery-ec2
[ ]  :plugins:discovery-gce
[ ]  :plugins:ingest-attachment
[ ]  :plugins:mapper-annotated-text
[ ]  :plugins:mapper-murmur3
[ ]  :plugins:mapper-size
[ ]  :plugins:repository-azure
[ ]  :plugins:repository-gcs
[ ]  :plugins:repository-hdfs
[ ]  :plugins:repository-s3
[ ]  :plugins:store-smb
[ ]  :plugins:transport-nio
[ ]  :qa:die-with-dignity
[ ]  :rest-api-spec
[ ]  :server
[ ]  :test:fixtures:azure-fixture
[ ]  :test:fixtures:gcs-fixture
[ ]  :test:fixtures:hdfs-fixture
[ ]  :test:fixtures:krb5kdc-fixture
[ ]  :test:fixtures:minio-fixture
[ ]  :test:fixtures:old-elasticsearch
[ ]  :test:fixtures:s3-fixture
[ ]  :test:framework
[ ]  :test:logger-usage

All the modules have Spotless as code formatting plugin now. Closing this issue.


cleanup tests: WaitForCertificateReady

What this PR does / why we need it:
There was some duplicate WaitForCertificateReady/ WaitForCertificateIssued logic, also waiting for a status update to the same state was not possible (eg. Ready=true -> Ready=true). (part of #4128)
Other included cleanups:

UseIngressIPAddress was added, so HTTP01 IP certificates can be tested
some TODOs were removed from s.complete(...) & shared variables are initialized better

Release note:

/release-note-none

/ok-to-test

Thanks for making the changes @inteon
/lgtm
/approve


Web workers jserrors tests - follow up

Overview
Follow up PR to #286 to resolve review comments & changes.

Reviewed, very nice & clean; thank you @metal-messiah


Immune systems?

Hi, is there any t480s model (i5-8250U / i7-i8550U / i5-i8350U / i7-i8650U) which is immune from this problem?

Right now I think the answer is no. There might be issues that can cause this tool not to work as expected though.


#stop_stream seems not stop auto reconnect

gem version: 2.6.1
After received on_reconnect callback, I call the #stop_stream to stop the stream.
but it still keeps receiving the on_reconnect callback until reached to max retries.
Is it expected behavior?

I found the problem is when reconnecting succeed, it reset the connection parameters in em-twitter gem. so if you want to stop the stream, it should be called in error callbacks.

Hi @sinorga
That's correct. The on_reconnect informs you of a reconnect (while also reconnecting you). What did your code look like? Just curious to see if this is something that could be handled differently. Thanks.

Hi @stve
Sorry, I didn't notice this comment until now.
At the beginning, I got a lot of reconnecting events and I didn't know what the exact error is. I need to stop it from keeping reconnecting to twitter in such situation. The on_error callback seems not designed for the common case, so I tried to stop it in on_reconnect callback. As you know it didn't work. I noticed when it gets into the reconnecting process, #stop_stream will be reset, it only works in some callbacks which will be executed before the reconnecting process. At the end I setup all callbacks to handle each situation.  😄
I also noticed there are some callbacks (ex. forbidden_callback) which are exposed by em-twitter but not tweetstream. any special reasons? Maybe tweetstream could bypass them to on_error callback. :)


Deploy web app to Heroku

Because Heroku is discontinuing their free tier, I'm considering deploying this app to Render instead.


PDF cannot be safed with proper content

One user complains that it is not possible to download the PDF which his shown in the borwser.
The user was using Firefox Browser. When the user presses "Save as" the PDF is stored with 6kByte content
However the PDF is properly shown to the user.
The work-arround for this issue is to print the PDF and store it as a new PDF through a PDF printer driver

I have never seen this issue anymore


Create a new pull request

Pull Request Test Coverage Report for Build 395536995

21 of 21 (100.0%)  changed or added relevant lines in 9 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.007%) to 94.679%

Files with Coverage Reduction
New Missed Lines
%

js/src/dropdown.js
1
94.46%

Totals

Change from base Build 393448408:
-0.007%

Covered Lines:
1917

Relevant Lines:
1988

💛  - Coveralls


Format Selection Limit Output File Total Size

Checklist

[X] I'm reporting a feature request
[X] I've verified that I'm running yt-dlp version 2022.01.21. (update instructions)
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
When using format selection with the default format (-f bestvideo*+bestaudio/best), I was trying to limit the size of the output file, using this syntax: -f "bestvideo*[filesize<400M]+bestaudio[filesize<400M]/best[filesize<400M]", which works except this limits video and audio individually, but my constraint (for example, I need to upload said output file to somewhere, but can't upload files bigger than 400MB) is on the output file total size, and not on the files (audio+video) making it.
Can we have a format syntax to tell yt-dlp to limit the total output file size? if is it not exactly known (because combining will probably make it smaller by a bit), the approximate size is the sum of the audio and video anyway, and probably (I don't know for sure, if I'm wrong correct me please) this limit is an upper limit (meaning size(audio)+size(video) is always <= size(audio+video)), so even if it's not exact, that's still good as an approximate limit.
If this is currently possible, please let me know how can I do that right now.
Thanks!

Currently not possible and implementing this would require some serious modifications to the format selection code

Yeah I assumed so... Oh well, Thanks anyway!

I have an initial implementation of this ready - https://github.com/yt-dlp/yt-dlp/compare/master...pukkandan:yt-dlp-dev:features/formats (Also addresses https://github.com/yt-dlp/yt-dlp/issues/389, https://github.com/yt-dlp/yt-dlp/issues/1176).
But, there is the issue of backward compatibility. Currently (A+B)[C] behaves as A[C]+B[C]. But adding this feature would require the filter to be instead run on the merged format. I suspect there are configurations that depend on the current behavior. So this change will need to go through a deprecation cycle.
That is, unless someone can think of a syntax that would support this while maintaining compat

Perhaps some way of automatically balancing out video size and audio size so that a good ratio comes out that meets the filelimit requirements.
ex. 8MB file limit, uses: bv*[filesize<7M]+ba*[filesize<1M]
But yeah pretty hacky way of doing it.

Would absolutely love a feature like this. Still very useful!

I thought this was sorted out. I am sure I read something about it, using smallest+filesize (smallest size plus the size).
Isn't there a way to use a filter for this in an output template.
The only other way is to get a list of formats and parse it or use simulate to keep going down the formats until you get the file size the is less or equal to the maximum file size you are looking for.
Isn't there  a way to express that as a function in the output template so this gets executed for every output?


incorrect stylized image when the screen resolution isn't 1920x1080

Hi, I tested the style transfer result in the demo website and found that I could not get correct stylized image when the screen resolution isn't 1920x1080. For example, when the screen resolution is 2160x1440, the generated image looks like this:

while it works for another computer with 1920x1080 resolution. Are there any possible reasons about this issue?

but that is also a style. it is artist

There are multiple ways to do this. The easiest and most straightforward one, would be to set a height and width to the final canvas or image element (depending on what you're using). For instance, doing canvas.height = 1920 after you've drawn the image to it, should work as expected. In the case of a <img />, setting one of the attributes statically (say, <img height="1920" {...} /> will set the desired height and adjust the width proportionally. Alternatively, you can set both of them statically.
The model will render the resolution of the container image, i.e. the first image selected by the User, and not the one used for "styling", so unless you've forced some custom width/height beforehand, it should render the resolution appropriately.


feat: mini.files integration

Integration of mini.files
It's work, but I don't understand why after applying action filetype is resetting. Do you have the idea why it happens?

I tested this. it works fine!

why after applying action filetype is resetting

what do you mean by this?

any updates?

this trick doesn't work anymore

willRenameFiles doesn't work with mini.files. I assume the event happens after renaming so to make it work use didRenameFiles


reference SDL2-CS from root of repo instead

from 9d9c2a3:
currently some files are referencing some SDL2-CS folder, outside where the repo would be cloned to somewhere
doing this because thats not the upstream repo's file structure, and build fails

now that i think about it, I do remember cloning my SDL2CS fork locally outside the project directory before adding the submodule. I must have added the fork instead of the submodule. I'll merge this.
Going forward, I might remove the fork and just submodule SDL2CS directly.


Fix formatting issues

This will have to wait for Phil or Islon to merge because I'm barred from approving my own PR. But, ironically, if you submit the same PR, I'll happily approve and merge it!


Novice Question。How to call this windows api: AccSetRunningUtilityState

The electron v30 I am using
be deeply grateful!!!!!

This api is quite ordinary, what you need is to simply open oleacc.dll and call it. You can simple treat HWND as a pointer, and use other api (e.g. GetForegroundWindow)to obtain it.
HRESULT AccSetRunningUtilityState(
  [in] HWND  hwndApp,
  [in] DWORD dwUtilityStateMask,
  [in] DWORD dwUtilityState
);


New Rule Proposal: no-unnecessary-html-attributes

Hi there 👋
Thanks for the continued work on this great plugin!
I had an idea for a rule today, and wanted to test the waters here on a no-unnecessary-html-attributes rule. It originally was inspired due to the default value type="text" on input elements, but due to maintainer feedback, it was modified to include default attributes on more elements.
Example of incorrect code:
<input type="text" />

<button type="submit">submit</button>

first

<link type="text/css" rel="stylesheet" href="https://example.com/main.css" />

<form method="GET"></form>
<form enctype="application/x-www-form-urlencoded"></form>
<form target="_self"></form>

<textarea wrap="soft"></textarea>

Examples of correct code:
<input />
<input type="number" />

<button>submit</button>
<button type="button">submit</button>

first

<link rel="stylesheet" href="https://example.com/main.css" />

<form></form>

<textarea></textarea>

It's far, far better to always require explicitness, even when things have defaults. I'd rather see a rule that forbids <input /> than one that requires people to keep an extra thing in their heads (that the default type is "text").

It's far, far better to always require explicitness, even when things have defaults

I understand the mindset, and in some cases, I agree.
But under some circumstances, it's nice to not have to write the verbose thing. And if you have a lot of code with inputs, this will reduce the amount of code that needs to be written / reviewed.
Also, and maybe more importantly, this is an opinion - other individuals and teams will have different ones :)
So I guess my question would be: why not both? There's a lot of prior art of ESLint rules that offer options for both opinions.

I don't think that just "input" is sufficient to warrant an entire rule. There's also already a rule, jsx-a11y/button-has-type, for button elements, but that's because the default is unintuitive.
Are there other HTML elements that this would apply to, where the default can be omitted and also is unsurprising? A single rule that encompasses a bunch of HTML elements in this way, autofixable, with both options, seems like it might be worth the complexity.

Are there other HTML elements that this would apply to, where the default can be omitted and also is unsurprising?

Looks like
 and the
 elements contained within have type attributes:

a for lowercase letters
A for uppercase letters
i for lowercase Roman numerals
I for uppercase Roman numerals
1 for numbers (default)

 on MDN
The
 element also has a type attribute, but this attribute is deprecated.
Also (but maybe less interestingly):


Core Microsoft SqlClient Data Provider: Line 1: Length or precision specification 0 is invalid

Azure SQL Table Schema:
create table Metrics (
	MessageId varchar(64) NOT NULL PRIMARY KEY,
	CreatedDate date NOT NULL,
	DeliveryDurationMs NUMERIC(10,7) not null
)

Model on C# side:
    public class Metric
    {
        public string MessageId {get;set;}
        public string CreatedDate {get; set;}
        public double DeliveryDurationMs {get;set;}
    }

Azure function output binding for adding a single row to SQL table, based on service bus queue trigger.
//....
[Sql("Metrics", ConnectionStringSetting = "sqlconnection")] out Metric metric,
 ILogger log)
{
    //....
    //...
    //...

    var diff = enqueuedTimeUtc - creationTime;

    metric = new Metric
            {
                MessageId = messageId,
                Date = enqueuedTimeUtc.ToString("yyyy-MM-dd"),
                DeliveryDurationMs = diff.TotalMilliseconds
            };

Azure function reports the following error:
System.Private.CoreLib: Exception while executing function: perfreportapp. Microsoft.Azure.WebJobs.Host: Error while handling parameter metric after function returned:. Core Microsoft SqlClient Data Provider: Line 1: Length or precision specification 0 is invalid.
Question:
Not sure if this a bug or I am doing something incorrect. Let me know.

Hi @kannanMSFT we've fixed this in https://github.com/Azure/azure-functions-sql-extension/pull/68 and will be available when we push our bits to NuGet. If you're consuming bits via myget, we do not plan on updating that package in the future.
If you have any questions on release logistics, please feel free to email me. Thanks!


Correction for raw affiliation Ethical approval: The institutional review board at the American Institutes for Research, Washington, DC, approved this study (project EX00215, 9/27/11).; Other disclosures: None reported.; e-mail: [email protected].; should be addressed to Dr. Pollart, University of Virginia School of Medicine, PO Box 800793, UVA Health System, Charlottesville, VA 22908; telephone:<PHONE_NUMBER>

Correction needed for raw affiliation Ethical approval: The institutional review board at the American Institutes for Research, Washington, DC, approved this study (project EX00215, 9/27/11).; Other disclosures: None reported.; e-mail: [email protected].; should be addressed to Dr. Pollart, University of Virginia School of Medicine, PO Box 800793, UVA Health System, Charlottesville, VA 22908; telephone:<PHONE_NUMBER>
raw_affiliation_name: Ethical approval: The institutional review board at the American Institutes for Research, Washington, DC, approved this study (project EX00215, 9/27/11).; Other disclosures: None reported.; e-mail: [email protected].; should be addressed to Dr. Pollart, University of Virginia School of Medicine, PO Box 800793, UVA Health System, Charlottesville, VA 22908; telephone:<PHONE_NUMBER>
new_rors: 00wn7d965
previous_rors: 00wn7d965;00490n048
works_examples: W1986467577
contact: 182ba1731f162d8bebc12e876994e7a4:7e12ff45b5d7a6 @ air.org

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Fix readme file to remove youtube-tv as default.

Change-type: minor
Signed-off-by: Daniel Andrade<EMAIL_ADDRESS>

Looks good but this should be a patch not minor


virtmanager: Fix gobject-introspection

Motivation for this change
Fixes #56943 till underlying issue can be resolved.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Can you add a comment linking to the issue?

@jtojnar Sure, no problem. Keep in mind, that this is not currently the only derivation using this fix, for example see udiskie.

@GrahamcOfBorg build virtmanager

Should this be backported to 19.03, or should we wait for the "proper" fix?

+1 for backporting to 19.03

backported to 19.03 in e548fd15c81


Fixed package.json exporting for npm-css

This should enable consumption via npm-css (and mostly likely parcelify).
Also added npm scripts so all that is required to build is:
$ git clone https://github.com/jonathantneal/sanitize.css
$ cd sanitize.css
$ npm install
# Make modifications
$ npm start
# Newly built css file awaits

Come to think of it, you might not even need to publish a built css file and building it on demand using postinstall scripts.  see https://docs.npmjs.com/misc/scripts  I'm not sure what best practice is, as I'm new to modules that need build steps but I'll let you know once I know more.
Closes https://github.com/jonathantneal/sanitize.css/issues/1

Since this modifies a recent commit by @pascalduez, I’d like more eyes on this before I merge it.

postinstall scripts are not recommended. And I would personnaly still ship the CSS file. Shipping a building step means npm have to download the devDependencies and run gulp, Sass and co.
But that would actually be at the maintainer discretion.

Okay, found at least one use for the main entry: webpack.
So it' used like require('sanitize.css');

Here's a possible package.json:
{
  "name": "sanitize.css",
  "version": "1.0.0",
  "description": "Render elements consistently. Style with best practices.",
  "author": "Jonathan Neal",
  "license": "CC0",
  "main": "dist/sanitize.css",
  "style": "dist/sanitize.css",
  "files": [
    "dist",
    "LICENSE.md",
    "README.md",
    "sanitize.scss"
  ],
  "homepage": "https://github.com/jonathantneal/sanitize.css",
  "repository": {
    "type": "git",
    "url": "https://github.com/jonathantneal/sanitize.css.git"
  },
  "bugs": {
    "url": "https://github.com/jonathantneal/sanitize.css/issues"
  },
  "devDependencies": {
    "autoprefixer-core": "^5.1.7",
    "gulp": "^3.8.11",
    "gulp-minify-css": "^1.0.0",
    "gulp-postcss": "^4.0.3",
    "gulp-sass": "^1.3.3",
    "gulp-sourcemaps": "^1.5.0"
  }
}

postinstall scripts are not recommended.

Ah ok good to know.  The link is broken but I kind of remember reading about this now.  Incorporating your suggested package.json changes. Hold tight

Ok this renames the npm script to build.  So building requires cloning this repo then
$ npm install
$ npm run build

I'm pretty sure its incorrect to include a gulpfile in the "main" field since this would just end up running the build script if you required it from another module.
Now here is the part I'm torn over:  the main field is for requirable javascript, not css files.
What webpack is doing seems pretty funky by specifying css in this field (I could be mistaken) and even invalidate the package.json WRT the commonjs standard.
Parcelify bundles css together based on the style field in package.json of javascript modules that are required in your javascript application AS javascript.  In order to require a css only module, you include a blank javascript export that you require in your javascript project that you bundle your css against. See https://github.com/rotundasoftware/parcelify/issues/28
I'm (personally happy) with just the style field.  I think its incorrect to specify a css file in the main field of package.json, unless the module is specifically targeting webpack (maybe a wrapper of some kind).  Having a blank js export allows for parcelify compatibility too, so it seems to maximise compatibility and minimise webpack wackiness.
Plus I like the browserify model more than webpack so there is my bias.  Heres most of that reasoning here: https://gist.github.com/substack/68f8d502be42d5cd4942#browserify-for-webpack-users

Then again, I don't use webpack or or parcelify, so I don't care that much about the main field either way.

@bcomnes++ I also think it's incorrect to specify a css file in the main field. Doing it for the edge case of webpack only makes sense if support for webpack over npm norms is a high priority.

@jonathantneal This is ready for merging, but in terms of which to support with the "main" field, it basically comes down to which do you want to support out of the box afaict: webpack or browserify.

Thanks, @bcomnes! Thanks, everyone!

:beers:

Dont forget to bump the version and publish the updates to npm!


Update manual-shared-update.md

These instructions are specific to runtime and JIT. Clarifying that in the title and summary. It needs a lot more instructions to cover all the other contents in the shared framework.

@leecow


How to change the address in the italics to regular and also the place and date on the right had side of the document?

\renewcommand*{\headeraddressstyle}[1]{{\fontsize{8pt}{1em}\headerfont\color{lighttext} #1}}
\renewcommand*{\letterdatestyle}[1]{{\fontsize{9pt}{1em}\bodyfontlight\color{graytext} #1}}

It would be really appreciated also if the guy stop opening issues according to his own problem, this is a template example, if you want to change it go deeper in the code and try to understand how the graphics and the fonts are madded.


updated cwk banner on class pages

removed preferred rate and added cwk rate to core classes.

We deleted all cwk from website for now.


ssl_cipher_list= does not do what openssl ciphers would do

I'm not sure if there are real-life use cases[1], so take this with a grain of salt.
Using empty string with openssl ciphers selects no ciphers.  That is, by observing this command, user could come to conclusion that passing empty string is a possible way to disable everything.
But, openwsmand does not behave the same way:
ssl_cipher_list=

results in enabling all (default) ciphers.  My (= C n00b level) reading of shttpd.c seems to confirm that empty value means the cipher list is just left alone.
What do you think?

[1]: Most plausible I can think of is if someone generates the config based on pre-approved cipher list and for some reason their list ends up being empty.

(Note that this was originally posted to openwsman-devel as a question.  Few days ago, just before the last spam storm which resulted in deletion of the mailing list.)

Well, ssl_cipher_list= just calls SSL_CTX_set_cipher_list which doesn't clearly describe the semantics of passing an empty string.
But I'll add a warning to the log if ssl_cipher_list is empty.


[AVM Question/Feedback]: Bring your own vnet but create a container registry for me?

Check for previous/existing GitHub issues

[x] I have checked for previous/existing GitHub issues

Description
It doesn't seem like I can have use_private_networking == true and virtual_network_creation_enabled == false.  If I bring my own vnet then the container_registry instance gets a error module.virtual_network is an empty tuple because it is directly coded against the vnet module and doesn't look for a bring your own vnet.  Is this by design or should it work?
module "virtual_network" {
  count               = var.use_private_networking && var.virtual_network_creation_enabled ? 1 : 0
  source              = "Azure/avm-res-network-virtualnetwork/azurerm"
  version             = "0.4.0"
  name                = local.virtual_network_name
  resource_group_name = local.resource_group_name
  location            = var.location
  address_space       = [var.virtual_network_address_space]
  subnets = merge(local.final_subnets, {
    container_registry_private_endpoint = {
      name           = local.container_registry_private_endpoint_subnet_name
      address_prefix = local.container_registry_private_endpoint_subnet_address_prefix
    }
  })
}

resource "azurerm_private_dns_zone" "container_registry" {
  count = var.use_private_networking && var.container_registry_private_dns_zone_creation_enabled ? 1 : 0

  name                = "privatelink.azurecr.io"
  resource_group_name = local.resource_group_name
  tags                = var.tags
}

resource "azurerm_private_dns_zone_virtual_network_link" "container_registry" {
  count = var.use_private_networking && var.container_registry_private_dns_zone_creation_enabled ? 1 : 0

  name                  = "privatelink.azurecr.io"
  private_dns_zone_name = azurerm_private_dns_zone.container_registry[0].name
  resource_group_name   = local.resource_group_name
  virtual_network_id    = module.virtual_network[0].resource_id
  tags                  = var.tags
}

This looks like an oversight. Will take a look and update / add a test.


Solve duplicates occurrenceID

There are 1608 duplicates at occurrence level (occurrenceID) due to the observation of the same species with two difference growth form. Good cath @LienReyserhove! The number of duplicates is still low, almost 3,7% of all occurrences.
My proposed solution: creating hashes based not only on species name but on the combination of species name and growth form.
@LienReyserhove, @peterdesmet: what do you think about it?
Example:
> vdigest(paste0(observations$`Macrofyt Naam`[1:2],
+                observations$groeivorm[1:2]),
+         algo = "md5")
      Rorippa amphibiaOever/moeras    Sparganium emersumVallisneriden
"35531b275a90b778df8b789382dfed20" "342e1f2934d6eccb21cf7430c8972bf6"

What you suggest seems like the best approach, but it is quite subject to change. I don't have a better alternative.

Yes, I share your same doubts: if they change the dictionary of growth forms, we will have to deal with all new observations. As long as thei changes are not retroactive we can deal with this. And even if they change growth form values retroactively, we know that the data up to end 2021 should be mapped based on the "old" export, so we filter the "old" data from the new export.


How to separate commands

Hi!
How to separate commands from main file like routes in express?
I want to store commands in different files in "commands" dir.

@GatoPresto export command handler and possibly its regex from a file, and attach them all im main

@GingerPlusPlus I had an error bot.sendMessage is not a function when I try to export bot from main and use it in command file like bot.sendMessage

@GingerPlusPlus ok, I did something like this:
bot.onText(/\/start/, (msg) => startCommand(msg, bot));

Can I implement it better or different way?

@GatoPresto it's fine
if you're better approach, I'd make a separate bot file exporting bot, which can be required by both main and your other files

@GingerPlusPlus ok, thanks


can't build from source on osx

Expected behavior
when I git clone a go app I should be able to build it most platforms - at least those that are linux like ;)
Actual behavior
build fails with the following error:
sed: illegal option -- r
usage: sed script [-Ealn] [-i extension] [file ...]
       sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]
(standard_in) 1: parse error
/bin/sh: line 0: [: -eq: unary operator expected

if could get some info what the "sed -rn" in MakeFile is actually for I could try come up with a more portable version.

The '-r' allows extended syntax (unfortunately, only in gnu sed), which permits the "\2" in the replacement string - substituting the value of the second match group.
Using -En instead of -rn will make it macOS compatible.
My recommendation is to get rid of the Glide version check completely, but I'll make a PR.


pre-train model

Hi zhang,
Would you like to share pre-train model?
Best regards,
PeterPham

Please wait for a while.

Hello zhang
Would you like to share the pre-trained weights?

Hi zhang,
Would you like to share pre-train model?
Best regards,
PeterPham

If satisfied, please star~
链接: https://pan.baidu.com/s/1a_cWANSSydb0KTUc9FPnYA 提取码: 9x9i
下载好后放在logs里

Hello zhang
Would you like to share the pre-trained weights?

If satisfied, please star~
链接: https://pan.baidu.com/s/1a_cWANSSydb0KTUc9FPnYA 提取码: 9x9i
下载好后放在logs里

Hi zhang,
Would you like to share pre-train model?
Best regards,
PeterPham

Code and data model links have been updated，Please see the homepage.
If satisfied, please star~

Hello zhang
Would you like to share the pre-trained weights?

Code and data model links have been updated，Please see the homepage.
If satisfied, please star~

Hello Zhang
Thanks for sharing the weights file, unfortunately not able to access baidu link. Do you mind sharing via Google drive or Dropbox?
Cheers
Kamal
From: Statistics<EMAIL_ADDRESS>Sent: 24 May 2020 20:27
To: statisticszhang/FaceMaskRecognition<EMAIL_ADDRESS>Cc: SandLogic Technologies<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [statisticszhang/FaceMaskRecognition] pre-train model (#1)
Hi zhang,
Would you like to share pre-train model?
Best regards,
PeterPham
If satisfied, please star~
链接: https://pan.baidu.com/s/1a_cWANSSydb0KTUc9FPnYA 提取码: 9x9i
下载好后放在logs里
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/statisticszhang/FaceMaskRecognition/issues/1#issuecomment-633243337 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ALITWS6ZSSPH3Y2QOPNKLQTRTEYUDANCNFSM4LWHKFBQ .  https://github.com/notifications/beacon/ALITWS5XZYREYR6CGBGN2KDRTEYUDA5CNFSM4LWHKFB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEW7INSI.gif

Hi zhang,
Would you please share pre-train model via Google Drive.


Bug fixing - deal with demo users

closes #1080 by adding warning in documentation (start page) and removing critical rights from the two demo users.

Code looks good, I make a quick testinstallation

works fine for ubuntu 20.04


BUG: makes is_market_hours() tz-aware

Timestamp is first converted to local time before being passed to other functions.
Similar change to #579.

@ssanderson @ehebert any chance of getting this accepted? anything I need to change first?

@ssanderson @ehebert ping!

@warren-oneill can you provide a concrete example of a TradingEnviromment setup and an input to is_market_hours that produces an incorrect answer here?  That would be useful both for my understanding of this change, and for ensuring that we don't accidentally break this down the line.

Sure, the issue arises when the timestamp passed to is_market_hours is on different days depending on if its is in UTC or local time.
In my case we have a 24/7 German market. The open time for, e.g., 01.01.2016 is 00:00 01.01.2016 in local time and 23:00 31.12.2015 in UTC since German time is +01:00. This means that when any timestamp within the first hour of trading is passed to get_open_close we will actually receive the open and close for the previous day and not the day we are interested in. This error comes from the first line of  get_open_and_close:
index = self.open_and_closes.index.get_loc(day.date())

In UTC day.date() will give the previous day and as the result the function will also give the open and close for the previous day.
My solution is to first covert the timestamp pass to is_market_hours to the day in local time and then pass the day to get_open_and_close. This way the open and close is returned for the correct day.


Add watch break points

It would be nice if we could tap into the ui a bit more - perl debugger supports variable / expression change breakpoints - we just need a proper way to maintain these.

Support for this has very recently been added to vscode in the form of "data breakpoints", cf. https://github.com/Microsoft/debug-adapter-protocol/issues/20

Thats interesting!


fix payment dcn length

Change description
fix payment dcn length. payment dcn should be 21 digit.
existing DCN generater generate variable length between 20-23.
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Actually, since random int brings different outcome in length, figured perhaps we could extend this function and provide the length of DCN we require to return? So smth as follows:
Long.toString(as is. we know the lenght) + string_pad_with_zeros(random int)

what should document DCN length be?

well, description says dcn needs to be 21 chars in length. so perhaps make all of the dcns same length? i guess scannable items don't care what length is it

well, description says dcn needs to be 21 chars in length. so perhaps make all of the dcns same length? i guess scannable items don't care what length is it

Mustafa:house_with_garden:  3 days ago
if we do not have to have 23 digits for other document  dcn we can change the dcn generator?

if 23 for others, then definitely can have a length param in there and calculate how much to pad with zeroes :)
anyway. this was just a suggestion. i don't mind what it is in pr right now - hence the approval. up to you whether take this suggestion or not
p.s. i might have missed the convo in channel - things sometimes just happen a lot everywhere ;)


Mh sha1 murmur3 aarch64

there seems to be a issue in push, will terminate this one and re-push later.


Look at reducing or simplifying the entry points to run the Prototype Kit

What
Assess if there is a way we can simplify the ways we run the kit locally and on Heroku.
Currently if you run npm start nodemon automatically starts up regardless as to whether its running in production or development. Procfile seems to only generate-assets and then creates the server.
Why
In the  latest incident review we found that we are running a different command in the Procfile for Heroku as we do for local development. This resulted in a broken website

as of v13 there are 2 main entry points:

npm run dev for local work
npm start for running online


timer event for checking systems

right now patrol.sh is local, but it should be configured by rsconf to run regularly. There may be different things done at different times. output should be emailed.

Consider nagios? I think this might be a rathole, but would give us "standard" system checks.

patrol.sh has been greatly improved. There's value to logging into the system and running manually so no need to automate.


adding shared processor and entitled processor fields in advanced setting for reporting.

adding shared processor and entitled processor fields in advanced setting for reporting as this information is not available.

Backported to morphy in commit 6f30cff46048a74d50e4e613517fb78d26b138ac.
commit 6f30cff46048a74d50e4e613517fb78d26b138ac
Author: Adam Grare<EMAIL_ADDRESS>Date:   Tue Jun 29 09:28:49 2021 -0500

    Merge pull request #21306 from Kuldip-Nanda/master

    adding shared processor and entitled processor fields in advanced setting for reporting.

    (cherry picked from commit 98cb43d08130aed68533aab259e344e8d8e65584)


AttributeError: 'TwoCaptcha' object has no attribute 'hcaptcha'

solver = TwoCaptcha('Hidden)

try:
    login_response = requests.post('https://discord.com/api/v9/auth/login', json=login_payload)

    captcha_key = solver.hcaptcha(
        sitekey='f5561ba9-8f1e-40ca-9b5b-Hidden',
        url='https://discord.com/api/v9/auth/login')

    login_response.raise_for_status()
except requests.exceptions.HTTPError as err:
    print(f"Login Failed with status code {err.response.status_code}: {err.response.text}")
    raise

@JakubLudvik Good afternoon, try running the code using the python3 command.
Example: python3 main.py
Or use a virtual environment.
And please let me know the result.

Please check https://github.com/2captcha/2captcha-python/issues/68#issuecomment-1920974503


CUDARuntimeError printing empty split

CUDARuntimeError printing empty split with out-of-bounds indices.
Code to reproduce follows.
import cupy as cp
a = cp.array([])
out = cp.split(a, [1])  # Indices must be 1, i.e. out-of-bounds to reproduce the error.

# Trying to print `out` yields an error while numPy would print `[array([], dtype=float64), array([], dtype=float64)]`
print(out)

Traceback (most recent call last):
  File "test.py", line 4, in <module>
    print(out)
  File "cupy/core/core.pyx", line 1290, in cupy.core.core.ndarray.__repr__
  File "cupy/core/core.pyx", line 1388, in cupy.core.core.ndarray.get
  File "cupy/cuda/memory.pyx", line 422, in cupy.cuda.memory.MemoryPointer.copy_to_host
  File "cupy/cuda/runtime.pyx", line 265, in cupy.cuda.runtime.memcpy
  File "cupy/cuda/runtime.pyx", line 145, in cupy.cuda.runtime.check_status
cupy.cuda.runtime.CUDARuntimeError: cudaErrorInvalidValue: invalid argument

It seems that it is not only for an empty array but for any array split with over-run.
>>> import cupy as cp
>>> cp.split(cp.array([1]), [2])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "cupy/core/core.pyx", line 1348, in cupy.core.core.ndarray.__repr__
    return repr(self.get())
  File "cupy/core/core.pyx", line 1439, in cupy.core.core.ndarray.get
    a_cpu = numpy.empty(self._shape, dtype=self.dtype, order=order)
ValueError: negative dimensions are not allowed
>>> cp.split(cp.array([1]), [2])[0].shape
(2,)


Running yarn run build according to the steps results in an error.

The issue has been resolved, but it has triggered another problem.

Are you using the same dB for medusa and strapi?...if you are please ensure
your schemas are different
Best Regards
Govind Diwakar
On Wed, 26 Jul, 2023, 06:51 microCloudCode, @.***>
wrote:

The issue has been resolved, but it has triggered another problem.
[image: image]
https://user-images.githubusercontent.com/46712199/256073254-ebcba9ec-ec69-4728-9a5e-d6d6b553658a.png
—
Reply to this email directly, view it on GitHub
https://github.com/SGFGOV/medusa-strapi-repo/issues/33#issuecomment-1650822866,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXEQJHBUZCWPVPZDWMBFE3TXSBWIXANCNFSM6AAAAAA2W2CFMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
This message (including any attachments) may contain confidential,
proprietary, privileged and/or private
information. The information is
intended to be for the use of the individual or entity designated above. If
you are not the intended recipient of this message, please notify the
sender immediately, and delete the
message and any attachments. Any
disclosure, reproduction, distribution or other use of this message or
any
attachments by an individual or entity other than the intended recipient is
prohibited.

@SGFGOV  Thank you, I have successfully started the application, but the data from Medusa is not synchronized in Strapi. Do I need to do anything else?

Do I need to install medusa-plugin-strapi-ts in Medusa? If so, when deploying the project, do I only need to include medusa-strapi, strapi-plugin-medusajs, strapi-plugin-sso-medusa, and strapi-plugin-multi-country-select? I apologize for asking multiple times, as I'm new to Strapi.

Ideally just restart both medusa and strapi..it should start to sync..have
you specified medusa backend url  in thr strapi .env file
Best Regards
Govind Diwakar
On Wed, 26 Jul, 2023, 12:00 microCloudCode, @.***>
wrote:

@SGFGOV https://github.com/SGFGOV Thank you, I have successfully
started the application, but the data from Medusa is not synchronized in
Strapi. Do I need to do anything else?
[image: image]
https://user-images.githubusercontent.com/46712199/256136999-8a961d58-5a38-4cd8-a7d9-addf4b6f0452.png
—
Reply to this email directly, view it on GitHub
https://github.com/SGFGOV/medusa-strapi-repo/issues/33#issuecomment-1651059544,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXEQJHHSGGZVSGMHIU74MYDXSC2OVANCNFSM6AAAAAA2W2CFMQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
This message (including any attachments) may contain confidential,
proprietary, privileged and/or private
information. The information is
intended to be for the use of the individual or entity designated above. If
you are not the intended recipient of this message, please notify the
sender immediately, and delete the
message and any attachments. Any
disclosure, reproduction, distribution or other use of this message or
any
attachments by an individual or entity other than the intended recipient is
prohibited.

Yes you need to install the plugin in medusa
Best Regards
Govind Diwakar
On Wed, 26 Jul, 2023, 12:10 microCloudCode, @.***>
wrote:

Do I need to install medusa-plugin-strapi-ts in Medusa? If so, when
deploying the project, do I only need to include medusa-strapi,
strapi-plugin-medusajs, strapi-plugin-sso-medusa, and
strapi-plugin-multi-country-select? I apologize for asking multiple times,
as I'm new to Strapi.
—
Reply to this email directly, view it on GitHub
https://github.com/SGFGOV/medusa-strapi-repo/issues/33#issuecomment-1651070783,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXEQJHCMCVBWJ56FAR2ZVMDXSC3WZANCNFSM6AAAAAA2W2CFMQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
This message (including any attachments) may contain confidential,
proprietary, privileged and/or private
information. The information is
intended to be for the use of the individual or entity designated above. If
you are not the intended recipient of this message, please notify the
sender immediately, and delete the
message and any attachments. Any
disclosure, reproduction, distribution or other use of this message or
any
attachments by an individual or entity other than the intended recipient is
prohibited.

Medusa-plugin-strapi-ts.. the rest come pre-installed
Best Regards
Govind Diwakar
On Wed, 26 Jul, 2023, 12:12 Govind Diwakar, <
@.***> wrote:

Yes you need to install the plugin in medusa
Best Regards
Govind Diwakar
On Wed, 26 Jul, 2023, 12:10 microCloudCode, @.***>
wrote:

Do I need to install medusa-plugin-strapi-ts in Medusa? If so, when
deploying the project, do I only need to include medusa-strapi,
strapi-plugin-medusajs, strapi-plugin-sso-medusa, and
strapi-plugin-multi-country-select? I apologize for asking multiple times,
as I'm new to Strapi.
—
Reply to this email directly, view it on GitHub
https://github.com/SGFGOV/medusa-strapi-repo/issues/33#issuecomment-1651070783,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXEQJHCMCVBWJ56FAR2ZVMDXSC3WZANCNFSM6AAAAAA2W2CFMQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
This message (including any attachments) may contain confidential,
proprietary, privileged and/or private
information. The information is
intended to be for the use of the individual or entity designated above. If
you are not the intended recipient of this message, please notify the
sender immediately, and delete the
message and any attachments. Any
disclosure, reproduction, distribution or other use of this message or
any
attachments by an individual or entity other than the intended recipient is
prohibited.

Is it correct that I only need to deploy medusa-strapi and install medusa-plugin-strapi-ts within Medusa? It seems that medusa-strapi already includes the following three components: strapi-plugin-medusajs, strapi-plugin-sso-medusa, and strapi-plugin-multi-country-select, so there is no need to clone the entire repository？

Yes
Best Regards
Govind Diwakar
On Wed, 26 Jul, 2023, 13:19 microCloudCode, @.***>
wrote:

Is it correct that I only need to deploy medusa-strapi and install
medusa-plugin-strapi-ts within Medusa? It seems that medusa-strapi already
includes the following three components: strapi-plugin-medusajs,
strapi-plugin-sso-medusa, and strapi-plugin-multi-country-select, so there
is no need to clone the entire repository？
—
Reply to this email directly, view it on GitHub
https://github.com/SGFGOV/medusa-strapi-repo/issues/33#issuecomment-1651163286,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXEQJHDTDJSRQEWYKTQ5CH3XSDDZJANCNFSM6AAAAAA2W2CFMQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
This message (including any attachments) may contain confidential,
proprietary, privileged and/or private
information. The information is
intended to be for the use of the individual or entity designated above. If
you are not the intended recipient of this message, please notify the
sender immediately, and delete the
message and any attachments. Any
disclosure, reproduction, distribution or other use of this message or
any
attachments by an individual or entity other than the intended recipient is
prohibited.

@SGFGOV I don't understand why it's an empty string here. It will cause an error.

Good catch.
Can you submit a small pr?
Best Regards
Govind Diwakar
On Sun, 30 Jul, 2023, 20:03 microCloudCode, @.***>
wrote:

[image: image]
https://user-images.githubusercontent.com/46712199/257057386-fed6f621-0097-42e6-8456-c49450860ec1.png
@SGFGOV https://github.com/SGFGOV I don't understand why it's an empty
string here. It will cause an error.
—
Reply to this email directly, view it on GitHub
https://github.com/SGFGOV/medusa-strapi-repo/issues/33#issuecomment-1657189141,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXEQJHGMC2S6UXBQXC4GZSLXSZWDFANCNFSM6AAAAAA2W2CFMQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
This message (including any attachments) may contain confidential,
proprietary, privileged and/or private
information. The information is
intended to be for the use of the individual or entity designated above. If
you are not the intended recipient of this message, please notify the
sender immediately, and delete the
message and any attachments. Any
disclosure, reproduction, distribution or other use of this message or
any
attachments by an individual or entity other than the intended recipient is
prohibited.

submitted


s3 support for modules

modules that read or write data to (non-temp) files should be able to support custom s3 storage (e.g. igneous, cloudian).  Generalized image reading and writing may be implemented in renderapi, but other things in the modules may need some additional development.
List operations in modules like apply mipmaps, generate tilespecs, and make montage scapes
validation and deletion modules

Resolved in #218


Python 3 compatibility

Thanks for that. I believe there was some issue with more.py. So before closing this, I will most probably push a fix tomorrow (of course you are welcome to have a look as well).


mac OS

do you have oni2 for mac?

Hello! I'm trying to build it but couldn't due to some issues with dependencies. When I can build it, I'll let you know!

Thank you!


How to disable the "Export as a dataset" function?

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

Expected Behaviour
Not every user should have the ability to download a dataset.
How can the function "Export as a dataset" be limited to certain users or be disabled?
Thanks
Current Behaviour
The function "Export as a dataset" is available to all users for all tasks.
Your Environment
CVAT [1.0.0] - 2020-05-29
Ubuntu 18.04.4 LTS

No one has an idea?
Even a dirty solution with code changes would be very appreciated!

Hi, sorry for the late response, as workaround please take a look https://github.com/opencv/cvat/blob/develop/cvat/apps/documentation/faq.md#how-to-make-unassigned-tasks-not-visible-to-all-users. This setting reduce task visibility to owner and assignee only.

@azhavoro Thank you very much!
Actually this does not solve it, because especially the assignee should not be able to export a dataset.
Could you maybe provide a workaround to achieve this or to disable the dataset export at all?
Having only the possibility to export annotations would be sufficient.
Thanks!

@brixxx Disabling of export a dateset functionality doesn't solve your issue as well, because the user should have access to the api/v1/tasks/3896/data endpoint (it returns task images) to annotate the task. So, actually the user can download dataset (annotations+images).
But you can modify this method https://github.com/opencv/cvat/blob/develop/cvat/apps/engine/views.py#L631. If you dont need this functionality you can return 403 response for all requests, i.e.:
return Response(status=status.HTTP_403_FORBIDDEN)

@azhavoro I thought the API would only deliver compressed and lower quality pictures for the annotation process.
However, your solution is what I was looking for.  At least for laypersons the original pictures are then not easily downloadable anymore.
So thanks a lot!

@brixxx @azhavoro I used reduce_task_visibility but I have multiple jobs in one task. So, i need also reduce job visibilty. All users can see other assignee jobs in one task. How can I solve this problem? If I solve this problem, ı will not need disabled data export. Thanks.

@brixxx Disabling of export a dateset functionality doesn't solve your issue as well, because the user should have access to the api/v1/tasks/3896/data endpoint (it returns task images) to annotate the task. So, actually the user can download dataset (annotations+images).
But you can modify this method https://github.com/opencv/cvat/blob/develop/cvat/apps/engine/views.py#L631. If you dont need this functionality you can return 403 response for all requests, i.e.:
return Response(status=status.HTTP_403_FORBIDDEN)

changing just 631 line with return Response(status=status.HTTP_403_FORBIDDEN)  is enough for this process? I changed like you said  and builded. However when I clicked export data or dump annotation, data is starting to download. I wanna user can not dowload data and annotation. Thanks..

@arcibiyo the file has changed significantly in the last year, you need this method https://github.com/openvinotoolkit/cvat/blob/f8077148701e303e42e70066cbc0b9a610fe344c/cvat/apps/engine/views.py#L631

@azhavoro thanks, I solve it but anyone can not export data with this way. I wanna just admin can export data. How can I modify this methods in views.py? Any advice about this topic ?

@azhavoro I modified the function as suggested.
Even after rebuilding with
docker-compose -f docker-compose.yml -f docker-compose.dev.yml build
a user can export tasks as a dataset in CVAT 1.4 (this workaround worked for me using 1.1). Any advice would be appreciated.

@azhavoro After changing the functionality to return Response(status=status.HTTP_403_FORBIDDEN) in dataset_export function, How can I reflect this change in docker.
After changing the dataset_export function., I gave these 2 lines., but It's not reflected in the UI. Still, download happens.
docker-compose -f docker-compose.yml -f docker-compose.dev.yml build
docker-compose up -d

@azhavoro After changing the functionality to return Response(status=status.HTTP_403_FORBIDDEN) in dataset_export function, How can I reflect this change in docker.
After changing the dataset_export function., I gave these 2 lines., but It's not reflected in the UI. Still, download happens.
docker-compose -f docker-compose.yml -f docker-compose.dev.yml build
docker-compose up -d

docker-compose`` -f docker-compose.yml -f docker-compose.dev.yml -f docker-compose.override.yml build
docker-compose -f docker-compose.yml -f docker-compose.dev.yml -f docker-compose.override.yml up -d

try it


ColorColumn basically invisible with Storm theme

Currently using the storm theme, I can't see the ColorColumn (here set cc=50), it should go through the h of night and the g of tokyonight.

Maybe setting it to something like bg_highlight for the night theme looks fine? I don't think it'll work for the storm theme.
Here the night theme with bg_highlight (set cc=50 as above):

Maybe this is this way since #72 and 1ea6950, I've just noticed a couple of weeks ago and now only found the time to check why it went missing.

@ner0-m I think this might be resolved by now. I see a clear (darker than bg) ColorColumn in tokyonight-storm.


VaadinSession autowireable?

Hey guys,
do you think it would be reasonable to add a VaadinSession-Bean configuration in the AutoConfiguration part so it is easy to just @Autowire the current VaadinSession?
Pesse

This should be pretty easy to do.

Looking forward to see and learn how this is done correctly