Problematic processing of optional metric dimensions

HTTP semantic conventions for metrics are introducing a concept of optional attributes, present only when the underlying value is available, for example status code when the response was sent back with status code.
In order to reduce telemetry COGS, some of the telemetry backends might perform additional post-processing of the metrics and store only time-based aggregations of a specific sets of attributes, on top of which you define additional visualizations or monitoring or do some extra processing or calculations. These sets of a attributes don't expect to have attributes present optionally. Raw metric records ingested to the telemetry backend are not stored.
In general, I am wondering:

what is the current support of optional attributes amongst the most most used telemetry backends? Do they allow optional attributes in metrics? Do i.e. Prometheus rules work well with optional dimensions?

is the concept of optional dimensions considered user friendly? Users must be aware of the optional dimensions and count with having 1 to N of them missing, every time they are working with a given metric - either visualizing, setting up monitoring etc. This in turn will make the monitoring / dashboarding logic more complicated. The case of status code missing (not sent as part of the response) is likely a rare case (considering the total volume of requests which will be sent back with the response), but a case which can happen. Assuming it is rare, the need to deal with it as an optional attribute might be unnecessary burden put on the OTel users.

is there any way to make processing of optional attributes easier, i.e. by allowing default values, instead of not adding that attribute at all?

Thanks for the response.

We discussed this a bit in the Semconv WG.  A few points:

Prometheus, and prometheus-like databases, tend to handle disjoint metric definitions by synthesizing missing labels/attributes.  Effectively, any label it's not aware of becomes an empty label.  It is considered good practice to provide all labels all the time.
You still need to deal with an issue where multiple versions of a binary running in production may have different ideas of a metric definition.  This is why prometheus is flexible and most prometheus-like databases provide flexibility.

That said, I do think having a default value in semconv for attributes that are optional is entirely reasonable feature request.  We likely need some specification work to understand what value we want for things like attributes that are integers to preserve the existing prometheus-like storage behavior of turning them into empty labels.


Issue with scatterplot code in tutorial: type GridLayout has no field needs_update

The tutorial gives as an example of a scatterplot:
axis = (width = 225, height = 225)
penguin_bill = data(penguins) * mapping(:bill_length_mm, :bill_depth_mm)
draw(penguin_bill; axis)

The last command results in the following error on Julia 1.6.1, macos. I'm guessing the tutorial code is just outdated, but I haven't looked at the package source code yet.
julia> draw(penguin_bill; axis)
ERROR: type GridLayout has no field needs_update
Stacktrace:
  [1] getproperty(x::GridLayout, f::Symbol)
    @ Base ./Base.jl:33
  [2] (::Makie.var"#926#927"{GridLayout})(al::Outside)
    @ Makie ~/.julia/packages/Makie/c5WJV/src/figures.jl:80
  [3] #invokelatest#2
    @ ./essentials.jl:708 [inlined]
  [4] invokelatest
    @ ./essentials.jl:706 [inlined]
  [5] setindex!(observable::Observable{Outside}, val::Outside; notify::Observables.var"#9#11")
    @ Observables ~/.julia/packages/Observables/Yf3xU/src/Observables.jl:207
  [6] setindex!
    @ ~/.julia/packages/Observables/Yf3xU/src/Observables.jl:201 [inlined]
  [7] notify!
    @ ~/.julia/packages/Observables/Yf3xU/src/Observables.jl:72 [inlined]
  [8] notify
    @ ~/.julia/packages/Makie/c5WJV/src/Makie.jl:37 [inlined]
  [9] Figure(; kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
    @ Makie ~/.julia/packages/Makie/c5WJV/src/figures.jl:82
 [10] Figure
    @ ~/.julia/packages/Makie/c5WJV/src/figures.jl:67 [inlined]
 [11] plot(s::AlgebraOfGraphics.Layer; axis::NamedTuple{(:width, :height), Tuple{Int64, Int64}}, figure::NamedTuple{(), Tuple{}}, palettes::NamedTuple{(), Tuple{}})
    @ AlgebraOfGraphics ~/.julia/packages/AlgebraOfGraphics/IVn8U/src/algebra/layers.jl:157
 [12] draw(s::AlgebraOfGraphics.Layer; axis::NamedTuple{(:width, :height), Tuple{Int64, Int64}}, figure::NamedTuple{(), Tuple{}}, palettes::NamedTuple{(), Tuple{}})
    @ AlgebraOfGraphics ~/.julia/packages/AlgebraOfGraphics/IVn8U/src/algebra/layers.jl:173
 [13] top-level scope
    @ REPL[46]:1

Edit: trying to make barplots results in the same error too. Perhaps it's an issue with my environment.
That is, running
using AlgebraOfGraphics, CairoMakie
set_aog_theme!()

axis = (width = 225, height = 225)
penguin_frequency = data(penguins) * frequency() * mapping(:species)

draw(penguin_frequency; axis)

results in
julia> draw(penguin_frequency; axis)
ERROR: type GridLayout has no field needs_update
Stacktrace:
  [1] getproperty(x::GridLayout, f::Symbol)
    @ Base ./Base.jl:33
  [2] (::Makie.var"#926#927"{GridLayout})(al::Outside)
    @ Makie ~/.julia/packages/Makie/c5WJV/src/figures.jl:80
  [3] #invokelatest#2
    @ ./essentials.jl:708 [inlined]
  [4] invokelatest
    @ ./essentials.jl:706 [inlined]
  [5] setindex!(observable::Observable{Outside}, val::Outside; notify::Observables.var"#9#11")
    @ Observables ~/.julia/packages/Observables/Yf3xU/src/Observables.jl:207
  [6] setindex!
    @ ~/.julia/packages/Observables/Yf3xU/src/Observables.jl:201 [inlined]
  [7] notify!
    @ ~/.julia/packages/Observables/Yf3xU/src/Observables.jl:72 [inlined]
  [8] notify
    @ ~/.julia/packages/Makie/c5WJV/src/Makie.jl:37 [inlined]
  [9] Figure(; kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
    @ Makie ~/.julia/packages/Makie/c5WJV/src/figures.jl:82
 [10] Figure
    @ ~/.julia/packages/Makie/c5WJV/src/figures.jl:67 [inlined]
 [11] plot(s::AlgebraOfGraphics.Layer; axis::NamedTuple{(:width, :height), Tuple{Int64, Int64}}, figure::NamedTuple{(), Tuple{}}, palettes::NamedTuple{(), Tuple{}})
    @ AlgebraOfGraphics ~/.julia/packages/AlgebraOfGraphics/IVn8U/src/algebra/layers.jl:157
 [12] draw(s::AlgebraOfGraphics.Layer; axis::NamedTuple{(:width, :height), Tuple{Int64, Int64}}, figure::NamedTuple{(), Tuple{}}, palettes::NamedTuple{(), Tuple{}})
    @ AlgebraOfGraphics ~/.julia/packages/AlgebraOfGraphics/IVn8U/src/algebra/layers.jl:173
 [13] top-level scope
    @ REPL[34]:1

That was an issue for a brief moment where a GridLayout bug caused this, but it was fixed soon after. Are you on all the latest versions?

Thank you --- updating did the trick; I've finally got the tutorial working! Basically there was another package that was requiring older versions of some of the dependencies that Makie and that package both had, and that in turn resulted in an older version of Makie being installed when I did add CairoMakie (and I hadn't realized that).
And sorry about not realizing this sooner!


Min.js fix

Make sure these boxes are checked before submitting this pull request~!~ Thank you!!

[done] The test of the method you have fixed is passing
[done] You have written a new skeleton method for someone else to work on!

Thanks for the contribution! Please follow the guidelines laid out in our README. We require each pull request to also contain a function for someone else to work on!


Conditions are not reset

Hi. I'm trying to use SleekDB like shown in manual.
$db_codes = \SleekDB\SleekDB::store('bonus_codes', PATH_DB, [
    'auto_cache' => false,
    ]);

$code1 = $db_codes->where('code', '=', $raw_code1)->fetch();
$code2 = $db_codes->where('code', '=', $raw_code2)->fetch();
$codes_all = $db_codes->fetch();

$code1 have one item, like it should. $code2 have 0 items, while it should have 1, $codes_all have 0 items, totally unlike it should.
I have looked through the code and I can see it's because on every -> where() call, local variable conditions[] are appended. Conditions have stacked through the calls, this is why just pure $db_codes->fetch() gives 0 results.
From my understanding, this is not how it's supposed to work. I expect $db_codes->where() not to modify initial $db_codes instance, but maybe create a copy. Or maybe conditions should be reset on every ->fetch() call.
How am I supposed to find items in foreach()? Create a new instance of $db_codes every time?
I have found https://github.com/rakibtg/SleekDB/issues/4 issue, where you give example code
 $db->store('orders')->insert([
    'order_id' => '92837483',
    'items' => ['coco', 'test', 'foo']
  ]);

If I'd create a new store for every query, that will obviously work. But that's not how you have it in your manual. I'd like to do it like your manual states.
Instead of
$db = new \SleekDB\SleekDB(PATH_DB, ['auto_cache' => false]);
$code1 = $db->store('bonus_codes', PATH_DB, ['auto_cache' => false])->where('code', '=', $raw_code1)->fetch();
$code2 = $db->store('bonus_codes', PATH_DB, ['auto_cache' => false])->where('code', '=', $raw_code2)->fetch();
$codes_all = $db->store('bonus_codes', PATH_DB, ['auto_cache' => false])->fetch();

It should be possible to just
$db = new \SleekDB\SleekDB(PATH_DB, ['auto_cache' => false]);
$db_codes = $db->store('bonus_codes'); // path and options are preserved.
$db_something1 = $db->store('something1'); // path and options are preserved.
$db_something2 = $db->store('something2', ['auto_cache' => true]); // path is preserved, options are overridden.

$code1 = $db_codes->where('code', '=', $raw_code1)->fetch(); // get corresponding raw_code1 item.
$code2 = $db_codes->where('code', '=', $raw_code2)->fetch(); // get corresponding raw_code2 item.
$codes_all = $db_codes->fetch(); // get all items in db.

Help please.

i just came across this bug/issue aswell. hoping that this was allready addressed.
but after realizing that it wasnt i simply decided to dig arround a bit inside the code.
i realized that the conditions allways get added into a new sub-array of the conditions array, so i simply deleted the conditions array after every fetch, update, insert or delete (not using insertMany so didnt bother to change it). i had simply made this change to the src/SleekDB.php file, but ended up having to make a few different changes for it to work.
the main line to add is:
$this->conditions = []
as this resets the conditions array to no conditions applied.
simply add this on all of the insert, fetch, update and delete function just before the 'return' keyword´.
though something to note is that the fetch function returns the result of a function directly, meaning that adding the line above before the function is called will result in your query executing without any conditions. to avoid this i simply reformated it like this:
so line 43 changes from:

return  $this->reGenerateCache();  // Returns data without looking for cached data.

to this:
$TempResult = $this->reGenerateCache(); //save the result before reseting conditions
$this->conditions = []; //reset conditions array to initial state
return  $TempResult; // Returns data without looking for cached data.

this worked perfectly for my usecase. however i havent been messing with SleekDB for long so i'm not sure if this hardcoded fix is the best way to do it. maybe there is a usecase where you want to save conditions between calls? this was simply my 5 minute aproach to solving it!

@dima-stefantsov and @Kulltero Many thanks for the details :)
@Kulltero Instead of setting $this->conditions = [] i think we should use $this->initVariables()
Tomorrow i think i will do a new release. In the meantime if you want to contribute please feel free to send a PR.
🍻

@dima-stefantsov If you need a quick fix then please replace fetch() method from SleekDB.php as this:
    // Read store objects.
    public function fetch() {
      $tmpData = null;
      // Check if data should be provided from the cache.
      if ( $this->makeCache === true ) {
        $tmpData = $this->reGenerateCache(); // Re-generate cache.
      }
      else if ( $this->useCache === true ) {
        $tmpData = $this->useExistingCache(); // Use existing cache else re-generate.
      }
      else {
        $tmpData = $this->findStoreDocuments(); // Returns data without looking for cached data.
      }
      $this->initVariables();
      return $tmpData;
    }

Hi @Kulltero, @dima-stefantsov
I just did a new release version 1.0.3.
Please update to version 1.0.3 and this bug should be fixed now.
The instance state will be reset on fetch(), update(), and delete() method from now.
Please let me know if it works for you or if you are facing any other issues :)

@dima-stefantsov If you need a quick fix then please replace fetch() method from SleekDB.php as this:

I've considered this solution, but my deployment process does not support editing of vendor files.
I just did
// Instance gets dirty after each ->where() call, have to get clean instance every time.
function db_codes() {
    return \SleekDB\SleekDB::store('bonus_codes', PATH_DB, ['auto_cache' => false]);
}
...
db_codes()->where('_id', '=', $code['_id'])->update($code);

Btw having to write ->where('_id', '=', $code['_id']) to update just single item looks super weird. I haven't found a proper way to save changes made to fetched items.

@dima-stefantsov Did you upgrade sleekdb to 1.0.3?

Btw having to write ->where('_id', '=', $code['_id']) to update just single item looks super weird. I haven't found a proper way to save changes made to fetched items.
So do you think the update method should return the new updated document?


UN-597: Collection Explorer page updates

Ticket URL: https://national-archives.atlassian.net/browse/UN-597
About these changes
This updates the back-end to add new features requested in the ticket, as laid out in the new designs.
How to check these changes
Edit the Collection Explorer page, and check that the designs have been met.
Before assigning to reviewer, please make sure you have

[x Checked things thoroughly before handing over to reviewer.
[x] Checked PR title starts with ticket number as per project conventions to help us keep track of changes.
[x] Ensured that PR includes only commits relevant to the ticket.
[x] Waited for all CI jobs to pass before requesting a review.
[x] Added/updated tests and documentation where relevant.

Merging PR guidance
Follow docs\developer-guide\contributing.md
Deployment guidance
Follow docs\infra\environments.md

Putting this back into draft to block merging. Looks like there has been some misunderstanding in the tickets - looks like this work has already been done, but on the home page..?

Hey @ababic, we just sort of touched on this in sprint planning - I've made a featured_article page chooser here, which allows editors to pick a page - either a RecordArticle or an Article page.
Should I change this into two separate Article and RecordArticle pickers, like we have on the other pages?

Hey @William-Blackie, cheers for the review. I've made the changes requested - just need @ababic to verify whether I should use the page chooser I've got, or if I should split it out into a separate featured_article and featured_record_article like we have elsewhere on the site.


S0205-S0208 uses comma-separated list, not colon-separated?

Documentation states that the data is a list of integers separated by colons. I think it shoould say commas?
https://github.com/rsmp-nordic/rsmp_sxl_traffic_lights/blob/master/sxl_traffic_controller.md#s0205

Yes. I believe it should be commas. It's a typo

I think this can be corrected without the risk of breaking any existing implementation. I think it should be fixed in next release, 1.0.15

Fixed in 824bf12

Ok, so should be current schema use commas?

Yes


Giving duplicate entry in every new entry

I want a new question every time for unique user but it gives duplicate entry every time for me even if I enter new user.
'question' => 'required|unique_with:asked_questions,user_id',

I need more info/context to help. Could you create a sample repo where this occurs?

Closed because of inactivity


Update README.rst

Since you need python3 should update the command.

pip usually means python2. Use python3 - m pip to avoid any confusion.


Tabbing through content can lead to weird horizontal scrolling bugs

Due to the new transition implementation

Probably all we need to do is apply something like pointer-events none to the inactive route.

Resolved with 2593f810913dcdc973802ebfa56ecbe201408cf0

💯 awesome job


Rearrange step schema

This moves a step's schema entirely under the mixin. So description and outputs are now under the mixin.
This makes it easier for the mixin to control the schema of the outputs. For example, helm outputs specify secret keys for where to find and publish secrets as outputs. Another mixin like exec, doesn't have outputs at all, and this lets it express that.
Moving description under, simply makes it cleaner and easier to deal with merging schemas.
I've done a sweep and updated all the docs and testdata to match the new schema.

Heh, this PR is why I opened #180. 😀


Incorrect segment counting

I spotted a similar issue to this one: https://github.com/TwilioDevEd/message-segment-calculator/issues/18.
When providing a message like this one:
]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]
Segment calculator shows it's 3 segments.
It's 153 scalars counted as 306 characters. That's 2142 bits for characters + 96 bits for 2 headers. That should add up to 2238 bits so still within 2 segments.
But when adding the last character of this string another header is added and the message takes up 2286 bits: 3 segments.
There are other calculators that show this as 2 segments (https://sakari.io/sms-length-calculator/)
But when sending the message on Twillio it is sent as 3 segments. So I have been wondering which is correct and what is causing this behaviour.

I don't believe that the segment calculator is incorrect. For GSM-7 encoding, ] is hex 1B3E which is reflected accurately as 0x001B 0x003E. See here https://www.developershome.com/sms/gsmAlphabet.asp

]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]

Checked out this string using https://messente.com/documentation/tools/sms-length-calculator
it shows that the string splits into 2 segments but your calculator considers the string as 3 segments.

]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]]

Checked out this string using https://messente.com/documentation/tools/sms-length-calculator it shows that the string splits into 2 segments but your calculator considers it as 3 segments.

This site says 2 parts, but it has 3 headers with a single ] after the last header.


ptask: accept versions 2.5.0, 2.5.1, 2.5.2

Motivation for this change
Uh, for those unnamed folks who may or may not be using 2.5.2 O:).
I may have put this together forgetting about an overlay or two...
still, seems reasonable for general use O:).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Huh, why do we have this patch in nixpkgs? Would definitely warrant a comment in ./default.nix

Oops, nevermind.  Agreed doesn't belong in nixpkgs, whoops!


u8g2_esp32_hal

my code is often (not consistently) experiencing multiple resets - otherwise the display is fine
E (615) err: esp_err_t = 263
assertion "0 && "i2c_master_cmd_begin(I2C_MASTER_NUM, handle_i2c, I2C_TIMEOUT_MS / portTICK_RATE_MS)"" failed: file "I:/data/dropbox/myprograms
/esp32/hello_world/main/u8g2_esp32_hal.c", line 159, function: u8g2_esp32_i2c_byte_cb
abort() was called at PC 0x400d3e4b on core 0
0x400d3e4b: __assert_func at /Users/ivan/e/newlib_xtensa-2.2.0-bin/newlib_xtensa-2.2.0/xtensa-esp32-elf/newlib/libc/stdlib/../../../.././newlib
/libc/stdlib/assert.c:63 (discriminator 8)
Any recommendations
Iam using SSD1306
u8g2_Setup_ssd1306_i2c_128x64_noname_f

I have the same issue
When I use in the same program DS3231 library from UncleRus https://github.com/UncleRus/esp-idf-lib and the u8g2 from nkolban im getting the same error.
For me it looks like conflict of two i2c libraries:
"i2cdev.h" from UncleRus
and
"driver/i2c.h" from espidf team
But I can be wrong... no solution till now

I have the same issue
no solution till now

I had the same issue before, sometimes it worked, most of the time it didn't.
Turned out I had an issue with the SCL line, so I2C communication could not be established.
This returns an error which is trying to be checked by the above code, resulting in a hard error and a reset.
After fixing the SCL issue the above did not happen any more.
Have you been able to fix the issue?

Hi all,
I'm having the same error also. Was not able to fix it yet.
How did you solve the issue?

Hi all,
I'm having the same issue.
How did you solve it?

Hi all,
I'm having the same issue.
How did you solve it?
Thanks

Hi all, I was able to solve the issue at my end by replacing the function 'u8g2_Setup_ssd1306_128x32_noname_f' with 'u8g2_Setup_ssd1306_i2c_128x64_noname_f' and setting the reset pin along with SDA_PIN and SCL_PIN as shown below:
#define RST_PIN GPIO_NUM_16 u8g2_esp32_hal.sda   = SDA_PIN; u8g2_esp32_hal.scl  = SCL_PIN ; **u8g2_esp32_hal.reset = RST_PIN;** u8g2_esp32_hal_init(u8g2_esp32_hal);
Please note: I'm using Heltec esp32 board.
For your reference: https://www.gitmemory.com/issue/nkolban/esp32-snippets/872/597721315
Regards,
Artur

Hi all, I was able to solve the issue at my end by replacing the function 'u8g2_Setup_ssd1306_128x32_noname_f' with 'u8g2_Setup_ssd1306_i2c_128x64_noname_f' and setting the reset pin along with SDA_PIN and SCL_PIN as shown below:
#define RST_PIN GPIO_NUM_16
[...]
u8g2_esp32_hal.sda = SDA_PIN;
u8g2_esp32_hal.scl = SCL_PIN ;
u8g2_esp32_hal.reset = RST_PIN;
u8g2_esp32_hal_init(u8g2_esp32_hal);

Please note: I'm using Heltec esp32 board.
For your reference: https://www.gitmemory.com/issue/nkolban/esp32-snippets/872/597721315
Regards,
Artur

Hi all, I was able to solve the issue at my end by replacing the function 'u8g2_Setup_ssd1306_128x32_noname_f' with 'u8g2_Setup_ssd1306_i2c_128x64_noname_f' and setting the reset pin along with SDA_PIN and SCL_PIN as shown below:
#define RST_PIN GPIO_NUM_16
[...]
void task_test_SSD1306i2c(void *ignore) {
	u8g2_esp32_hal_t u8g2_esp32_hal = U8G2_ESP32_HAL_DEFAULT;
	u8g2_esp32_hal.sda   = SDA_PIN;
	u8g2_esp32_hal.scl  = SCL_PIN ;
	**u8g2_esp32_hal.reset = RST_PIN;**
	u8g2_esp32_hal_init(u8g2_esp32_hal);

	u8g2_t u8g2; // a structure which will contain all the data for one display
	**u8g2_Setup_ssd1306_i2c_128x64_noname_f**(
		&u8g2,
		U8G2_R0,
		//u8x8_byte_sw_i2c,
		u8g2_esp32_i2c_byte_cb,
		u8g2_esp32_gpio_and_delay_cb);  // init u8g2 structure
	u8x8_SetI2CAddress(&u8g2.u8x8,0x78);
[...]
}

Please note: I'm using Heltec esp32 board.
For your reference: https://www.gitmemory.com/issue/nkolban/esp32-snippets/872/597721315
Regards,
Artur


integration_tests fail on a CI system targeting iOS 14, stuck on local network permission popup

On iOS 14, an integration_test test will prompt the user to allow local network access when the observatory publishes:

The tests hang forever until you hit OK, so fails in a CI setup when there's no one to hit the button.
Steps to Reproduce
Fix up the iOS example to actually work....
https://github.com/flutter/plugins/tree/master/packages/integration_test/example/ios

Check in the ios/Podfile with RunnerTests inherit! :search_paths set up (not sure why the README says to add a use_framework!...)

# Uncomment this line to define a global platform for your project
# platform :ios, '9.0'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'

project 'Runner', {
  'Debug' => :debug,
  'Profile' => :release,
  'Release' => :release,
}

def flutter_root
  generated_xcode_build_settings_path = File.expand_path(File.join('..', 'Flutter', 'Generated.xcconfig'), __FILE__)
  unless File.exist?(generated_xcode_build_settings_path)
    raise "#{generated_xcode_build_settings_path} must exist. If you're running pod install manually, make sure flutter pub get is executed first"
  end

  File.foreach(generated_xcode_build_settings_path) do |line|
    matches = line.match(/FLUTTER_ROOT\=(.*)/)
    return matches[1].strip if matches
  end
  raise "FLUTTER_ROOT not found in #{generated_xcode_build_settings_path}. Try deleting Generated.xcconfig, then run flutter pub get"
end

require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root)

flutter_ios_podfile_setup

target 'Runner' do
  flutter_install_all_ios_pods File.dirname(File.realpath(__FILE__))

  target 'RunnerTests' do
   inherit! :search_paths
  end
end

post_install do |installer|
  installer.pods_project.targets.each do |target|
    flutter_additional_ios_build_settings(target)
  end
end

Update the import to the right integration_test casing to

#import <integration_test/IntegrationTestIosTest.h>

Run the tests.

Recommended fix

Convert the XCTest to XCUITests and.  This would be a breaking change for existing tests, including the one's in Flutter.
In +setUp/class func setUp (not -setUp or func setUp) detect the popup and hit it when the app launches in the INTEGRATION_TEST_IOS_RUNNER macro

let springboard = XCUIApplication(bundleIdentifier: "com.apple.springboard")
let button = springboard.buttons['OK']
if button.exists {
  button.tap()
}

See cocoon for working example.

Update the example app to a XCUITests target.

Change the README to

Create a UI Testing Bundle target (navigating File > New > Target... and set up the values)

See https://github.com/flutter/flutter/issues/65207 and https://github.com/flutter/flutter/issues/60634 for context.

\cc @dnfield based on CODEOWNERS.
I would work on this myself but I'm about to be on vacation for a week, so I want to leave a breadcrumb in case iOS 14 gets released in the meantime.


[KW-search] Confluence: Standardize parents and internal ID

Goal is to ensure for Confluence that:

Parent ids used in the parents[] array in core data_source_nodes and internal ids from connectors should now match node_id in core data_sources_nodes (= document_id for docs, table_id for tables, folder_id for folders);
the convention that parents[0] = node_id should be enforced.

The connector should be thoroughly inspected. If there is a convention mismatch, fix it; explained in details in https://github.com/dust-tt/dust/issues/9069

Taking this one @philipperolet

As noted here : https://github.com/dust-tt/dust/pull/9261/files#r1879852550 , we should add parent_id parameter in upserts as part of this card once parents are standardized.

done!
related PRs (sorry I forgot to mention this issue):

https://github.com/dust-tt/dust/pull/9274
https://github.com/dust-tt/dust/pull/9308
https://github.com/dust-tt/dust/pull/9337
https://github.com/dust-tt/dust/pull/9363

every one working on the migration scripts


Child window doesn't load correctly

Hi there,
When trying to login to twitter via apple account, the browser opens a child window to process the authentication. But in the Avalonia demo example, the child window doesn't load the url. See the attached screencast below:

Is this a known issue?

Try without ORS mode on, there's a run configuration for that.

Try without OSR mode on, there's a run configuration for that.

Thanks for the quick reply, unfortunately it's the same without the OSR

I tried this demo here and it also didn't open it correctly.

You need to handle the popup opening, something like this:
https://github.com/OutSystems/CefGlue/pull/82/commits/52455aac0336c3070da8d1c2e72f12488ba05ca5
You should also beware that some sites (like google) don't allow users to login through embedded browsers (such as CEF).

You need to handle the popup opening, something like this: 52455aa
You should also beware that some sites (like google) don't allow users to login through embedded browsers (such as CEF).

thanks for the solution, but I'm afraid there's more to than just loading a new browser with the target url. The Apple account page behaves differently when it's opened in a new tab vs in the popup. See my demonstration:

Basically what happens with the suggestion above is like we're opening a new tab manually then load the url. And as I simulated in the screencast, it doesn't work even though it's the same url. My guess is that it's related to Window.opener property. But do you may have idea why?

I suggest that you look here.

I suggest that you look here.

Unfortunately I couldn't find anything there. But I also tried running the Wpf example from CefSharp and it works. Meanwhile it doesn't work for CefGlue both for the Wpf and also Avalonia example.


add ability to hide compliance check result

We are going to add a helper rule to detect HyperShift/OCP version, and we want to be able to hide the rule since it doesn't serve any purpose than providing API endpoint path.

Needed to add some e2e test for this PR

The code looks good to me and works fine with ComplianceAsCode/content#9726
Do you know why is the CI failing?
Please also remember to document the variables in CO's changelog, but that can be done in a future CO patch.

Took a while to figure out what was wrong, it the scan is supposed to be not applicable at the first place, and we shouldn't find CCR object.

adding the no-FF labels out of band: This is in itself an internal change. Documentation, testing and PX will come later with a more thorough support for HyperShift.

/hold cancel
I think the commit is actually pretty safe and it would help to be able to test hypershift guest clusters.


Node 6 Warning in Azure DevOps

Currently seeing this warning when using the android-manifest-version task. Any chance of releasing an update that uses Node 10?
##[warning]This task uses Node 6 execution handler, which will be removed March 31st 2022. If you are the developer of the task - please consider the migration guideline to Node 10 handler - https://aka.ms/migrateTaskNode10 (check this page also if you would like to disable Node 6 deprecation warnings). If you are the user - feel free to reach out to the owners of this task to proceed on migration.

Oh my! Yes, I will put it on my list, been a while since I did anything in the repo though, so may take some time for me to get back up to speed lol

@nickrandolph  if you are willing to test out https://github.com/jamesmontemagno/vsts-mobile-tasks/pull/41
i think i did it right

I think i probably need to re-build a lot if it with these changes. Maybe even delete and start over... hmmm

I haven't taken a look at the code but if it's just PowerShell, perhaps just publish it as a script file that can be included in either DevOps or GHA


Refactor Binary Merkle Tree

We should refactor the binary merkle tree such that the tree is backed by a Sparse Merkle Tree.  This allows the storage structure to be significantly more efficient.  This means that this library can also support sparse merkle trees for substrate which is a great addition.

This has been completed by the various changes to the library.


Metatables

In preparation for Teardown 0.5, the framework should move more towards APIs that will be reuse-able in the new modding system, metadata for common objects is a good way to simplify code in mods working on those objects.
Vectors, Quaternions, and Transforms have already received this improvement. The goal of this issue is to unify those metatables into a robust system.

[x] Main meta system
[x] Vectors
[x] Quaternions
[x] Transforms
[x] Entities

[x] Base
[x] Body
[x] Shape
[x] Location
[x] Joint
[x] Light
[x] Trigger
[x] Screen
[x] Vehicle
[x] Player

Basic metatables for all main types are complete. Currently only wrappers around game functions are available for most of these types but this is expected to change with time.


Suggestion - remove constraint abstraction to reduce un-necessary nesting

Currently most of the constraints in the input descriptor are located under the constraints JSON member, however I would posit that virtually everything inside the input descriptor object is about conveying what the requestor wants and is hence a constraint. The suggestion is to remove the nesting around the constraint object so the syntax of the input_descriptor is simplified from:
{
  "comment": "Note: VP, OIDC, DIDComm, or CHAPI outer wrapper would be here.",
  "presentation_definition": {
    "id": "32f54163-7166-48f1-93d8-ff217bdb0653",
    "input_descriptors": [
      {
        "id": "bankaccount_input",
        "name": "Full Bank Account Routing Information",
        "purpose": "We can only remit payment to a currently-valid bank account, submitted as an ABA RTN + Acct # or IBAN.",
        "schema": [{
            "uri": "https://bank-standards.example.com/fullaccountroute.json"
        }],
        "constraints": {
          "limit_disclosure": "required",
          "fields": [ ...field constraints ]
        }
      }
    ]
  }
}
...

To
{
  "comment": "Note: VP, OIDC, DIDComm, or CHAPI outer wrapper would be here.",
  "presentation_definition": {
    "id": "32f54163-7166-48f1-93d8-ff217bdb0653",
    "input_descriptors": [
      {
        "id": "bankaccount_input",
        "name": "Full Bank Account Routing Information",
        "purpose": "We can only remit payment to a currently-valid bank account, submitted as an ABA RTN + Acct # or IBAN.",
        "schema": [{
            "uri": "https://bank-standards.example.com/fullaccountroute.json"
        }],
        "limit_disclosure": "required",
        "fields": [ ...field constraints ]
      }
    ]
  }
}

+1, simplification proposed here is logical and clean.
Since this would be a breaking change, it would be good to get the opinion of existing implementers - if this update to the syntax could be tolerable (also in light of few other updates and potentially going to PE V2.0)

+1 from me for v2 of PE

I'm generally in favour of this change, but if this is the difference that would require implementations to support a new major version I'd be against it. It doesn't change anything significant about the protocol and will make current implementations 99% the same, but just different enough to introduce complications. I'm particularly interested in what the other changes would be with regards to going to PE v1.1 or 2.0 (as @Sakurann mentioned)

Setting a deadline of next Wednesday September 15th to get feedback on whether or not this should still happen.

Closing per comment period with resolution to retain the current structure.


New cop Style/ClosingParenthesisIndentation

Second part of fix for #1144.
Please review the rules I chose for indentation of the hanging ). They are partly based on the discussion in #1144, partly on what Emacs does, or what I imagine it would want to do if it had a ruby parser.
And of course the implementation to enforce those rules.

:+1: Looks good to me!


[Documentation] Have a better documentation and way to update and maintain it regularly

Is your feature request related to a problem? Please describe
This repository contains various aspects of distribution from building to releasing. We have various workflows, images and other components that is used for build, test and release.
However, the documentation is distributed in various places. Example:

README: https://github.com/opensearch-project/opensearch-build/blob/main/README.md
Wiki: https://github.com/opensearch-project/opensearch-build/wiki
Sign workflow: https://github.com/opensearch-project/opensearch-build/tree/main/src/sign_workflow/README.md
Test workflow: https://github.com/opensearch-project/opensearch-build/blob/main/src/test_workflow/README.md
Release process: https://github.com/opensearch-project/opensearch-build/blob/main/RELEASE_PROCESS_OPENSEARCH.md

As a community user it comes difficult to search for information and get what we are looking for.
Describe the solution you'd like
Move all the content to GitHub wiki. It is great place for "too much" information. The UI automatically lists the sub-topics and makes its easier to parse through the content.
One drawback is, wikis do not allow Pull Requests (yet!). However, there is a work around to automate updating wikis. See  https://nimblehq.co/blog/create-github-wiki-pull-request
Describe alternatives you've considered
Keep what is it now.
Additional context
No response

i think two or more contributor can work together to find a workaround for organizing the documentation to help community better.

I would be interested in working on this. If anyone else wants to do it with me, let me know.

Thanks @chawinphat.Assigning this issue to you. Please comment the approaches you would like to move forward with before moving to implementation.
If anyone else is interested in collaborating please comment on this issue.

Hi @gaiksaya @chawinphat!
The first comment suggested a solution that I tried to implement, but it did not work for me.
As an alternative, I tried using github-wiki-action, and it appears to be working. It involved creating a folder named wiki in root directory and adding a workflow.
Here is the wiki page: https://github.com/SachinSahu431/opensearch-build/wiki
One issue I observed is that linkchecker workflow is failing due to relative URLs.

Hi @SachinSahu431 I'll take a look at this over the weekend, and will let you know any progress I make.

@SachinSahu431 I tested the solution you posted and I think it works nicely too. I started migrating some of the documentation to test out the formatting.
I think we can link all the document on the home.md file instead of adding a sidebar, since we can organise to our liking instead of having it alphabetically sorted like this:

I sorted the different README files into their respective folders:

@SachinSahu431 I've tried out your method and it looks good to me. I don't think we can use relative addressing since it will point to the .md file instead of the corresponding wiki page?
I have a somewhat working version here.
The only problem is that link checker is failing like you said. The problem is alot less severe if we do not include the main README.md file in our wiki. What are your thoughts?

@SachinSahu431  I talked to @gaiksaya and she said to PR the workflow and get tbe first page of the wiki up first. For the links, we should use the urls of files in the main branch of opensearch-build, similar to what you did with your Page 2 example.


Fix a couple compatibility issues with conda build 1.x

As discussed in #60, there were a couple of lines that are not compatible with conda build 1.x. This should fix those...

Thanks @mwcraig for the PR and @pelson for merging.
BTW this is no longer a conda-build 1 workaround because this behavior is back in latest conda-build 2. So the previous behavior, that used the extra config argument, is the one deprecated.
PS: Can we get a new release :wink:

@Ocepaf - I think the change needed for t latest conda-build is a little different than that. The call being made now is not part of t API and should not be used. There is an API now for getting the path to the built package. Will get to that PR on Monday unless someone else does it sooner.

There is an API now for getting the path to the built package.

Nice. I thought there was not one when I tried #70

See this if you want to fix today :wink:: https://github.com/astropy/conda-channel-astropy/issues/105#issuecomment-265346930
I'd wait for that fix before a new release that we know will be broken with the latest conda build.

Thanks @mwcraig. I can wait. (I had it pinned before to get the packages uploaded but now I actually want the get latest conda-build in my repo.)
Cool! did not know about get_output_file_path.

Neither did I...still not used to the idea that there is an API that should be used instead of reading the source code!

So this seems to cause some weird issues when trying to build things using numpy. Not entirely sure why, but going back to 1.0.0 does not encounter these issues.
xref: https://github.com/conda-forge/numpy-feedstock/issues/42


Added atoi function to template funcs and test

This fixes #660. Included test case too.

Thanks for the contribution! I've added a doc string and will merge it soon.


Report error if any of the sync paths failed in syncMetadata

Before this change, if any path was successfully synced, we return success from syncMetadata.
After this change, we only return success if there was no failures and all paths have been synced without interruption.
This also fixes an issue where an interrupted syncmetadata is considered synced by the file system master and will not be synced again until sync interval passes.

Codecov Report

Merging #12901 (f491d5d) into master (9dcbc2d) will decrease coverage by 25.49%.
The diff coverage is 77.77%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dcbc2d...5c4202a. Read the comment docs.

i just realized that this PR does more than returning errors to the user. It also fixes a bug where a part of the tree that is incompletely synced could be incorrectly considered synced. but the user proably won’t notice unless their sync interval is something other than 0 or -1.   The newly added test fails without this change and passes with this change. @bf8086 @gpang

@yuzhu If this fixes bugs, then why do we need a flag?

@gpang the flag is because of a prior discussion. Since it significantly changes the behavior of how ufs sync error is handled, we want to be able to work around it at runtime if, for example.  ufs sync always fails for a particular file.

@gpang any more comments? trying to close this out today

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.5 please


Plugin does not correctly handle bind mounts when BuildKit is enabled or when the source is the context not another Image.

Currently the plugin adds COPY commands when for bind mounts always, it should only do this in the case when BuildKit is disabled.
Additionally it should distinguish between contextual bind mounts and bind mounts from another image as the syntax of the COPY command changes depending on the source type (contextual, bind). At the moment contextual bind mounts are not supported by this plugin.
See the documentation for bind mounts
Currently using the following syntax (where extensions is a folder in the docker build context):
RUN --mount=type=bind,from=extensions,source=.,target=/extensions

Will get converted into
COPY --from=extensions . /extensions

Which will fail as the build system will be looking  for the Docker image extensions producing an error like the following:
ERROR: pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed

The generated copy should look like so:
COPY extensions/  /extensions/

The generation of the COPY instruction will become a bit more complex in that it will need to account for relative paths the current version does not as when specifying source for images absolute paths are required as there is no relative path. This is not the case with bind mounts of the Docker build context.

Note that changing this we can still have an unavoidable bug in that if a FROM alias has the same name as a folder in the Drupal context we can't distinguish between the two and what is intended.

Note that changing this we can still have an unavoidable bug in that if a FROM alias has the same name as a folder in the Drupal context we can't distinguish between the two and what is intended.

If I'm reading the docs correctly in that case the user should drop the from=value to indicate that it from should be the build context to distinguish between the two so there is a way to make this clear.

Resolved with version 0.0.3


chore(main): release 2.0.3

:robot: I have created a release beep boop
2.0.3 (2024-10-04)
Bug Fixes

deps: update dependency @octokit/webhooks-types to v7.6.1 (#153) (12aed42)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v2.0.3
:sunflower:


Draft a media repository system

As we're finally getting at a technology point where we can use Node.js to build a media repository system, we should agree on a standard procedure for doing those things.
Below is a bit of collection of what's currently in mind:

https://hackmd.io/EwUwhgnAJgbADFAtAVmQZiQFjgYwogDh2B0QHYwQDkqIxhkCg===#
https://piratenpad.de/p/inexor-media-json
http://www.sonatype.org/nexus/2017/02/14/using-nexus-3-as-your-repository-part-2-npm-packages/

As well @aschaeffer should give some feedback here, since he's currently the main drive behind the repository feature.

This is working already


Ctrl + Space Trigger Suggestion

Triggering suggestions via the built-in ctrl + space shortcut no longer works for me. ctrl + space is my preferred shortcut but I have verified that:

It does work with ctrl + I alternate

It does work when selecting it from the command palette

I ensured this was reproducible with --disable-extensions and a clean --user-data-dir applied

I can see that ctrl + space does not register with screencast as well:

However ctrl + shift + space does register

I have the following troubleshooting log scenarios:
ctrl + space

ctrl + shift + space

ctrl + i

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:
Version: 1.79.2 (system setup)
Commit: 695af097c7bd098fbf017ce3ac85e09bbc5dda06
Date: 2023-06-14T08:57:04.379Z
Electron: 22.5.7
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045

Steps to Reproduce:

Launch a code window
Try to trigger suggetions with ctrl + space

/duplicate
See https://github.com/microsoft/vscode/issues/184583#issuecomment-1582506295

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Uses importing module memory for host function calls

Fixes #195

I raised for review while I backfill unit tests

cool!

Changed to make WASI tests test the constants mentioned in docs (notably the import is now a constant instead of embedded godoc)

FYI @nullpo-head @r8d8 this PR drifts your PRs in a good way as testing the wasi functions is easier (since you can use a constant for the imports instead of copy/pasta of a %.wat file)

Thanks for the review @mathetake and the hints on the issue and offline @nullpo-head


Fixing DopeBox and Sflix

As both of the extensions are basically the same, I will just refer to DopeBox
DopeBox had an episode listing error, wherein the episode list would show up in a reverse order than what we are used to. This caused problems in the episode loaders of the player as well.
It would move up an episode and a season at the same time.
So from Season 1 Episode 5, next would become Season 2 Episode 6, with no previous episode existing.
A simple reversing of the episode list ,before pushing to the user, fixed both the problems!

can you tell me an example show where this problem exists?

It would move up an episode and a season at the same time.
So from Season 1 Episode 5, next would become Season 2 Episode 6, with no previous episode existing.


Adds dart_fix support to flutter_test

Adds fixes for the first round of deprecations listed in #122323
Adds tests for all new fixes
Adds a note for the runTest(timeout) deprecations to prevent them from being removed before integration_test also has dart fix support

Resolves #123154
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

LOL I am too slow for @goderbauer


Accessing files from resource files as part of docker container orchestration

Referencing closed issue: [https://github.com/Azure/Batch/issues/159]
Using resource files, I see a file copied to tasks working directory in root/wd/xxxx.txt (this I presume is the root node). But where can I see where exactly it is mapped in docker container, i.e. where will this be located in dockers volume? I have tried SSHing into the node and then exploring the container but no luck.
Is there deeper documentation/tutorial on using container images and Azure batch?

@sa1sen,
I did a quick test on a pool for you to hopefully help illustrate what is going on. In this case i'm creating a pool using the ubuntu-hpc:2004 image (container supported image) and then submitting a task that pulls the CHANGELOG for batch from github and then spawns a container process which will just do "ls -la && pwd && echo $AZ_BATCH_TASK_WORKING_DIR
{
"id": "container-test-task",
"url": "REDACTED",
"eTag": "0x8DB8D24C593346F",
"lastModified": "2023-07-25T15:35:27.615Z",
"creationTime": "2023-07-25T15:35:27.615Z",
"state": "completed",
"stateTransitionTime": "2023-07-25T15:35:35.002Z",
"previousState": "running",
"previousStateTransitionTime": "2023-07-25T15:35:33.692Z",
"commandLine": "/bin/bash -c "ls -la && pwd && echo AZ_BATCH_TASK_WORKING_DIR=$AZ_BATCH_TASK_WORKING_DIR"",
"containerSettings": {
"imageName": "ubuntu:20.04",
"workingDirectory": "taskWorkingDirectory"
},
"resourceFiles": [
{
"httpUrl": "https://raw.githubusercontent.com/Azure/Batch/master/changelogs/nodeagent/CHANGELOG.md",
"filePath": "CHANGELOG.md"
}
],
"environmentSettings": [],
"constraints": {
"maxWallClockTime": "P10675199DT2H48M5.4775807S",
"retentionTime": "P7D",
"maxTaskRetryCount": 0
},
"requiredSlots": 1,
"userIdentity": {
"autoUser": {
"scope": "pool",
"elevationLevel": "nonadmin"
}
},
"executionInfo": {
"startTime": "2023-07-25T15:35:33.737Z",
"endTime": "2023-07-25T15:35:35.002Z",
"exitCode": 0,
"containerInfo": {
"containerId": "fd8c4015b77a4db6c0b1201e88d9d6b22d73e065ebbc1e799c58ad64f11b44ff",
"state": "exited"
},
"retryCount": 0,
"requeueCount": 0,
"result": "success"
},
"nodeInfo": {
"affinityId": "TVM:REDACTED",
"nodeUrl": "REDACTED",
"poolId": "container-test",
"nodeId": "REDACTED",
"taskRootDirectory": "workitems/test-job/job-1/container-test-task",
"taskRootDirectoryUrl": "REDACTED"
}
}
stdout.txt from this task is as follows:
total 40
drwxr-x--- 2 _azbatch _azbatchgrp  4096 Jul 25 15:35 .
drwxr-xr-x 4 _azbatch _azbatchgrp  4096 Jul 25 15:35 ..
-rwxrwx--- 1 _azbatch _azbatchgrp 31386 Jul 25 15:35 CHANGELOG.md
/mnt/batch/tasks/workitems/test-job/job-1/test-task-4/wd
AZ_BATCH_TASK_WORKING_DIR=/mnt/batch/tasks/workitems/test-job/job-1/test-task-4/wd
So what we can see here is that the resource file (CHANGELOG.md) was downloaded to the host and then the AZ_BATCH_TASK_WORKING_DIR was mapped into the container. In this case the path within the container is /mnt/batch/tasks-workitems/test-job/job-1/test-task-4/wd, however we should just use the environment variable AZ_BATCH_TASK_WORKING_DIR as this is automatically mapped on both the host and within the container so you don't have to worry about paths too much.
https://learn.microsoft.com/en-us/azure/batch/batch-docker-container-workloads#container-task-working-directory
Hope this makes things more clear!

Thank you so much!
I can confirm now the environment variables are working and I can pass dynamically the input files!


fix #87: wait for fresh chain 15x faster

Implemented a profiler and then optimized the slow parts.
This can be rebased after PR #88  is merged. Meanwhile, please review only the 2nd commit @ 5acbccbfa3404679371fc1ff080610099708835f

Thanks for the feedback. I've switched this PR back to Draft until the comments are addressed.

As part of the fixes in c54ff65900f48e98854f0c6a6645bb05464372cf, this PR also makes the chain.cache the primary block store and phases out the use of a single-file for every block in the chain.


jitpack not finding version <IP_ADDRESS>

Not sure what is going on here but this github project has a release tag https://github.com/afollestad/material-dialogs/releases/tag/v<IP_ADDRESS> but it is not being found by jitpack. If you look at their releases for some reason they have a release tagged v<IP_ADDRESS>.0 which doesn't appear to be a tag (https://jitpack.io/com/github/afollestad/material-dialogs/<IP_ADDRESS>.0/build.log). Not sure what to do but this is a huge problem, if I can't fetch older versions. Obviously I could go to a submodule, but I would prefer not to.

But those older releases were originally hosted on jCenter, I switched to JitPack for newer releases. Although JitPack should still find them in theory.

You shouldn't be using old builds anyways, there's too many things that had to be fixed since then.

No but the issue is some of us still depend on build tools 22 and 0.8.0 requires 23.

Sorry bad grammar. But because I am still dependent on api build tools version 22 and cannot upgrade yet, I am stuck on the older support library which 0.8.0 requires.

Sorry for the late response, you can reference old versions by commit hash ID, also.


Add Zola to static files directory table

Summary
This simply adds the static file directory information for Zola (documentation here) to the table found on the Add To Your Site page of the Netlify CMS docs (here).
Test plan
I installed the website's dependencies and started a local server to test the modifications, using the instructions in the README.  I'm using Node.js 10.16.0 LTS and Yarn 1.16.0 locally.
yarn
yarn start

On the local version of the site, the modified table renders as expected (pictured below).

At some point we'll need to stop adding to these lists, but I'm cool with merging for now.


Support for playing X amount of seconds into the video

Would be very helpful for my case if mkdocs-video supported skipping the first couple of seconds on videos. I use Cypress to create documentation videos that is display in an mkdocs video, and the first couple of seconds are just a "loading" screen.
I can cut it myself before, but it is a big hassel. If it is not hard to make it would be awesome!

Thank you for your quick answer! I tried adding #t=5 to the end like this
![type:video](./videos/Feature/turbines.feature.mp4#t=3)

But it still start and 0sec. Tried it in Google Chrome and Microsoft Edge with running mkdocs serve. Any thought to what I might be missing?

Your Markdown looks good, so I think that issue is somewhere in the MkDocs configuration.
If you want me to help you, could you pls share with me the following data:

The entire plugins section of your mkdocs.yaml file. Something like that: plugins:
   - mkdocs-video:
       is_video: False
   - ...

Screenshot of the Elements section from your browser DevTools, where I can see the HTML code of the video tag.
2.1 Right-click on the video on the page

2.2 Click Inspect and make sure that the code with the video tag (including video URL) is highlighted in the DevTools section that opens

I don't guarantee that I'll definitely solve your issue, but I'll definitely try :upside_down_face:

Yes, that would be really helpful! I had is_video to True at first. But changed it now to match yours
plugins:
  - mkdocs-video:
      is_video: False
      video_autoplay: False
      css_style:
        width: "850px"
        height: "478px"
  - search:
      separator: '[\s]+'
      lang: en
      prebuild_index: true
  - git-revision-date

Hello @HansKristianVikOlsen,
I've reviewed your case and conducted a couple of tests and haven't found any root causes related to the mkdocs-video itself.
I have 2 assumptions about the cause of the issue:

Something wrong with this turbines.feature.mp4 video file
Something wrong with the browser you used

Try to change these 2 "variables" (try another browsers, test another files) to define what's wrong...

Closed as outdated


Scala 2.12 support

changed name of parent module
some Spark and Flink code had to be adapted because of ambiguous methods due to Java 8 and Scala interface

Pull Request Test Coverage Report for Build 298

2 of 6 (33.33%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.004%) to 39.982%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sansa-rdf-flink/src/main/scala/net/sansa_stack/rdf/flink/utils/DataSetUtils.scala
0
1
0.0%

sansa-rdf-spark/src/main/scala/net/sansa_stack/rdf/spark/io/rdfxml/RdfXmlDataSource.scala
2
5
40.0%

Files with Coverage Reduction
New Missed Lines
%

sansa-rdf-spark/src/main/scala/net/sansa_stack/rdf/spark/io/rdfxml/RdfXmlDataSource.scala
1
29.41%

Totals

Change from base Build 284:
-0.004%

Covered Lines:
1818

Relevant Lines:
4547

💛  - Coveralls


Support price discovery proposal

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

good catch on the typo


Ansible play for host configruation

The playbook https://github.com/ublue-os/forge/blob/main/setup/ansible/main.yml needs a play / role for the host configuration:
What is needed (list not complete....)

[x] Add *.ublue.local entries to etc/hosts
[x] Add tls root certificate to host
[ ] - Import root certificate in Browsers like Fireforx, Edge etc.

Importing root certificate into browser is tricky because there are different variant such as firefox, edge, vivalid etc but also with and without flatpak or installed in a distrobox.. Covering all cases is very complex. I will open a dedicated issue for this. It won't be prio 1 for now.


CUDA out of memory error

Hi,
Thanks for making the code available for such an interesting work.
I have tried to train the Relation Prediction model on GPUs with 32 GB of memory but it lead to CUDA out of memory error. I have also tried to train with vgg16(pretrain=True) but still ran into the same problem. So, I wonder what kind of GPU you used for your experiments and how you manage the memory in training.

The problem was solved by adding the following to the run.py file:
import tensorflow as tf
gpus = tf.config.experimental.list_physical_devices('GPU')
for gpu in gpus:
    tf.config.experimental.set_memory_growth(gpu, True)

We used NVIDIA 3080 or sometimes the NVIDIA A10 for training. Usually changing the train_batch_size to a smaller value helps with the out-of-memory error problem. I am glad you found a solution that worked for you, hence your error might be related to a different version of TensorFlow.


fix chef-bin bundling in omnibus

this file winds up in the embedded lib at:
/opt/chef/embedded/lib/ruby/gems/x.y.0/gems/chef-X.Y.Z/Gemfile
It needs to find the chef-bin gem from the same library, rather than
simply omitting it.
The chef-config gem comes in through the chef.gemspec so the lines are
different.

Do we also need this in omnibus/Gemfile ?

no it should work fine without that there.


Refactor LoadMethod.LOCAL to use symlinks as opposed to copying the dbt source dir

As of Cosmos 1.0-1.2, it copies the entire dbt project for every operator that runs dbt:
https://github.com/astronomer/astronomer-cosmos/blob/c82e6bc66dd31d6e1404fc24548d978489f4f0ab/cosmos/operators/local.py#L198
As reported in the #airflow-dbt slack, this can lead to performance issues:
https://apache-airflow.slack.com/archives/C059CC42E9W/p1697718075031609?thread_ts=1697708239.918849&cid=C059CC42E9W
We successfully adopted a strategy of using symbolic links from a temporary folder to run dbt ls:
https://github.com/astronomer/astronomer-cosmos/blob/c82e6bc66dd31d6e1404fc24548d978489f4f0ab/cosmos/dbt/graph.py#L167-L171
The goal with this ticket is to adopt this same strategy when running tasks using LoadMethod.LOCAL.

I can work on this one, in #629 to reduce complexity I created the function: https://github.com/astronomer/astronomer-cosmos/blob/9cd46d2353dff874cc94c66baa0b146255ec42f5/cosmos/dbt/graph.py#L56-L61
which could be DbtLocalBaseOperator.run_command.


Possible memory leak?

I posted here: https://github.com/ElmahCore/ElmahCore/issues/158#issuecomment-1607701229
But I think there is still a memory leak with ElmahCoreEx
We see memory usage spike and then we hit the limit on our Application Pool after 10-12 minutes just by sitting on the /elmah page. If you route to /elmah/api/new-errors?{id} and have it load everything, the memory leak may appear more quickly.
As a stop-gap, we have a URL rewrite that just returns a 200 response for that route; so far so good with the fixes in this repo. (This repo seems to fix the CPU usage + that URL rewrite is (at least for us) fixing the memory usage.) The URL rewrite fix doesn't prohibit loading more errors (you can still scroll down and get more) but does avoid a frontend error notification versus just doing an 'abort request' in the rewrite. I think the one caveat to this fix is that it may prevent XHR requests from loading new requests, but stability is the most crucial thing for us. We can manually refresh if needed.
Do you think there's anything that can be done about this?

@cvocvo what storage provider is in use ? XML/SQL ?
Is there a specific log entry that you think triggers it, if so can you attach it?
I ran a test again that endpoint and couldn't see anything that stood out, gen 0 memory is going up but GC should collect that.

@cvocvo
I've tried to make some improvements and pushed a build https://www.nuget.org/packages/ElmahCoreEx/2.1.3-beta.1
If you have a change try it and let us know if it makes a difference.

We're using a SQL DB to store the error logs; I'm not sure if there's a specific log that triggers it / I'm not sure how to test that. I think that the JSON serializer changes look like an improvement, but we'll try to give that a test today or tomorrow after we deploy some other things. Thank you for publishing that as a nugget package -- that makes it faster/easier to test/rollback/manage than deploying and then manually swapping DLLs.

How can I look at the memory usage like you've shown in the screenshots above?
Jetbrains DotMemory

I'll close this as fixed,  and release a non-beta nuget with the changes.

Published in v2.1.3 Closing..


Update dependencies, align python support with test matrix

Description
pyproject.toml python support was not aligned with supported and tested versions of python, updating poetry.lock file as well.
This should resolve issues in the publish workflow around trying to run on python 3.10 which is not yet tested.
General Checklist

[ ] Tests added for this feature/bug
if it was a bug, test must cover it.
[ ] Conform by the style guides, by using formatter
[ ] Documentation updated
[ ] (optional) Please add a label to your PR

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.874%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4309

Relevant Lines:
5134

💛  - Coveralls


New branch created

Description

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

Hi @Obasoro - I'm not sure what this PR is. Looks like from the file you changed you were maybe running into some issues? Closing this for now, but happy to help in the comments here.


Do you see this turning into a full fledged component library/design system? Steps for contributing?

Really love the idea of this and would love to help in any way shape or form if there are plans to turn this into a component library with a design-system or not. Do you have any steps for contributing? Would love to help when there needs to be more things done.
I'm planning on using this for a gatsby project currently so I'm also curious how that will work. I saw you have instructions on Next.js integration.

Hey, that is the plan! I'm currently testing this and plan on using it in all of my universal production apps.
I only started working on it last month, so I haven't put together any contribution details yet. I'm happy to do that, though.
As for Next.js / Gastby - there is currently a bit of an issue with server-side rendering of React Native apps and using React Native Web when it comes to responsive design. I can follow-up in a separate comment with details since I'm currently on my phone. I currently have a work-around that makes this library work on Next.js + Expo apps, and I assume the same work-around would work for Gatsby, though I haven't tested it yet.
The current workaround is to wrap your app with the DripsyProvider component, and pass an options prop dictionary where ssr is set to true. options={{ ssr: true }}. Under the hood, this renders a different component that used styled-components. The reason behind this is elaborated in a few other issues. Basically, it comes down to this: when using server-side rendering, every component's props on the first render on the client side must be the exact same as their props on the server's render. Since we use the screen size to determine which style to apply, and this is done using JS, it's possible that the props on the server and client won't match. This happens because the server doesn't know what the screen size will be on the client.
My current work-around is to use actual CSS media queries, rather than JS-based screen measurements, for server-side rendered apps. This way, the components always have the same props. This is achieved by using styled-components if ssr: true.
However, this solution is't long-term safe. Why? Because styled components requires editing a component's className prop in order to give it styles (and, more importantly, media queries.) However, the people behind React Native Web just deprecated the className prop, so this solution isn't going to work anymore soon.
Hope the long-winded explanation makes sense, let me know if you need me to clarify.
Important note None of what I just said applies if you're willing to lazy-load components. I figured you'd want to use them for good SEO since they're on Gatsby / Next.js, but if you're willing to lazy load them with code splitting, then you can use this library like normal. 😇

I'm going to try to put together a separate website for docs, maybe following the layout of the theme ui docs.

Thanks for the detailed response that will definitely help me as I try to implement the library on gatsby.
I'm going to start playing around with the library and get familiar with it. I'll see if I can get the gatsby implementation running today. I don't mind starting on some components. I'll try to follow the theme-ui components for now and we can merge those in later if you want.
I think a separate website for the docs with the same style as the theme-ui one would be a move. That would be super helpful.

Sounds good, lmk how it goes.
Right now, most of the standard React Native components can are exported from this library (View, Box, Text, ScrollView), as well as some nice HTML-like elements (H1, H2, ..., P).
You can see which ones exist in src/components.


Change MicroprofileSpec.HEALTH_METRICS to MicroprofileSpec.METRICS

Also change in the templates and the output within the API response.

Code: MicroprofileSpec.java
What happens to the description/alias for web?

Also updated


[Bug]: It does not initiate the request through the proxy

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Theme
Expected behavior
The request is made through the proxy.
Actual behavior
I am in China and I need to develop Shopify through a proxy.
When developing a theme locally execute shopify theme dev

I set proxy for terminal with export https_proxy=http://<IP_ADDRESS>:7890 http_proxy=http://<IP_ADDRESS>:7890 all_proxy=socks5://<IP_ADDRESS>:7890
Then I executed shopify theme dev It still doesn't make requests through the proxy.
What causes this? Does anyone know? Thanks in advance!
The latest version I use. Everything is up to date on MacOS
Verbose output
2023-03-27T02:25:12.641Z: Running command theme dev
  shopify:theme:dev init version<EMAIL_ADDRESS>argv: [ '--verbose' ] +0ms
2023-03-27T02:25:12.652Z: Ensuring that the user is authenticated with the Theme API with the following scopes:
[]

2023-03-27T02:25:12.652Z: Ensuring that the user is authenticated with the Admin API with the following scopes for the store MobilePixels.myshopify.com:
[]

2023-03-27T02:25:12.652Z: Getting session store...
2023-03-27T02:25:12.654Z: Validating existing session against the scopes:
[
  "openid",
  "https://api.shopify.com/auth/shop.admin.graphql",
  "https://api.shopify.com/auth/shop.admin.themes",
  "https://api.shopify.com/auth/partners.collaborator-relationships.readonly",
  "https://api.shopify.com/auth/shop.storefront-renderer.devtools",
  "https://api.shopify.com/auth/partners.app.cli.access"
]
For applications:
{
  "adminApi": {
    "scopes": [],
    "storeFqdn": "MobilePixels.myshopify.com"
  }
}

2023-03-27T02:25:12.654Z: Sending Identity Introspection request to URL: https://accounts.shopify.com/oauth/introspection
2023-03-27T02:25:12.654Z: Sending POST request to URL https://accounts.shopify.com/oauth/introspection
With request headers:
 - User-Agent: Shopify CLI; v=3.44.1
 - Keep-Alive: timeout=30
 - Sec-CH-UA-PLATFORM: darwin
 - Content-Type: application/json

╭─ error ──────────────────────────────────────────────────────────────────────╮
│                                                                              │
│  request to https://accounts.shopify.com/oauth/introspection failed,         │
│  reason: connect ETIMEDOUT <IP_ADDRESS>:443                                │
│                                                                              │
╰──────────────────────────────────────────────────────────────────────────────╯

2023-03-27T02:26:27.731Z: Unable to log analytics event - no information on executed command

Reproduction steps
1.Set proxy port in terminal
2.Execute the command shopify theme dev
Operating System
Mac OS Ventura, Windows 11
Shopify CLI version (check your project's package.json if you're not sure)
3.44.1
Shell
zsh, cmd
Node version (run node -v if you're not sure)
v19.8.1
What language and version are you using in your application?
No response

Currently I can only develop by installing proxifier, but that wasn't the case a week ago. I thought it might be my problem, I switched to windows11 fresh install shopify-cli and it still does the same.

@ma-zhao-yang Did you solve this problem? If so, can you share the method?

我也遇到了这个问题，停下来了，等官方搞好

Shopify Cli 要比 themekit 好用得多，现在用回 themekit，好不方便。可以使用了，大家留言提醒一下，谢谢

Still waiting...

same problem Still waiting...

How to solve the problem of timeout auth through proxifier, can you share the configuration
@zhouru1bin I use it with Clash and there is no configuration with Authentication enabled. This should only be configured relative to the local machine. Usually there is no need to set it. Below is my configuration.
For example, my ClashX hybrid proxy port is 7890

Any updates?

Hello everyone, great! Now it works fine again. But don't know exactly what caused it. Or is there any update?
If your shopify-cli terminal proxy still doesn't work, try updating. Or keep using "proxifier". Although I haven't updated any, but you can try any way.
I'm closing this question for now.

hello, how to use Proxifier? the same qustion,


Implement the bug fix for SPARK-41448 and shim it for Spark 3.2.4 and Spark 3.3.{2,3} [databricks]

Fixes #8114.
This makes the map reduce job ID consistent across attempts in GpuFileFormatWriter. This fix was already fully incorporated into the Spark 3.4.0 shim code (and that shim has several other fixes), so this addresses all other Spark versions. It shims the 3.2.4/3.3.2/3.3.3 fix out so if there are further upstream fixes, the shim should accommodate those automatically.

build

build

build


Right Arm not animating in ALS Default Overlay.

Hello, my Manny's right arm is not being animated when in the Default Overlay with the ALS system. I am using dyanikoglu's ALS-Community version of the Plugin. I also used your Plugin and followed along with the Editor Utility Blueprint parts. As far as I understand the Skeleton's are the same and thats pretty much all we've been working with at this point.
Mantling is awesome, Rifle Overlay and Pistol Overlays are good. I was thinking this is in the constraints but all the Animations look good on their own. I am unsure if this is an IK issue happening somewhere in the Community verson?
I followed along with the basic version of ALSv4 from the Marketplace and same thing. The right arm is not animated.
In this video, I demonstrate my issue. I have completed up to Episode #11.0.

Ah that's your issue... I'm almost pretty sure that your anim curves got messed up from the overlay states. Sadly that is an unreal engine bug that is present since UE4. 🙈
Here might be your fix. https://youtu.be/Bp20Q436RpM
In case you don't want to code it yourself you can use the official release of TTToolbox v0.3.
Let me know if it worked for you, so we can close this issue here. If you step into new issues, do not hesitate to ask your questions here I read from time to time here and answer questions. What might also help is taking a look at the closed issues here on GitHub or in comments below on my YouTube videos. There we already also solved some questions.

Ohh okay, I apologize for asking early. Probably should have just kept going. Its just you show the ending results at the end and so far mine isnt matching

Did you get it working now? Oh it's fine, it's still a very complicated topic with lots of small details. Furthermore, we step into engine issues ... :-)

Just chiming in that I am also having this same issue with a metahuman retargeted to ALS. All other fixes recommended in the tutorials have worked so far but the arm is the last thing that is still unresolved. I tried fixing the anim curves one by one in the retargetted animations using TTCopyAllCurves, and added the missing curves to the metahuman base skeleton. This fixed some other issues but not the arm unfortunately.
Appreciate your efforts on this tool!

Aye! Overlay state anim sequences are the main part when it comes to anim curves.
Thank you guys really appreciate that you like my work and tutorials. Soon I will make an entire series about Metahumans. Found some pretty neat parts that will make our life's easier when it comes to Metahuman retargeting. 😉
As the issue seems to be solved I will close this one here.
If you guys step into further issues, do not hesitate to open a new one here.
All the success to your character integration journeys. 😉


E2E fails with mons, mgr and/or mds in crashloopbackoff

Describe the bug
E2E fails with mons, mgr and/or mds in  crashloopbackoff.
This is accompanied with #1969 and maybe probable cause for #1875
Environment details

Image/version of Ceph CSI driver :
Helm chart version :
Kernel version :
Mounter used for mounting PVC (for cephfs its fuse or kernel. for rbd its
krbd or rbd-nbd) :
Kubernetes cluster version :
Ceph cluster version :

Steps to reproduce
NA
Actual results
E2E fails
Expected behavior
E2E runs successfully.
Logs
https://jenkins-ceph-csi.apps.ocp.ci.centos.org/job/mini-e2e-helm_k8s-1.20/895/display/redirect
helm-e2e-log-1.txt
helm-e2e-extra-log-1.txt
https://jenkins-ceph-csi.apps.ocp.ci.centos.org/job/mini-e2e_k8s-1.20/906/display/redirect
e2e-log-1.txt
e2e-extra-log-2.txt

Hit this issue again in #1998
https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/mini-e2e_k8s-1.20/detail/mini-e2e_k8s-1.20/907/pipeline/
e2e-log.txt
e2e-extra-log.txt
https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/mini-e2e-helm_k8s-1.20/detail/mini-e2e-helm_k8s-1.20/896/pipeline/98
helm-e2e-log.txt
helm-e2e-extra-log.txt

liveness probe timeout failure seems to have caused this issue.
May 20 12:00:32 minikube kubelet[2788]: E0520 12:00:32.287201    2788 remote_runtime.go:392] ExecSync 5b36a9134ab2c05c4bac48e82686ddeb9e90cc5bf0db8c348da4afbc62e856fc 'env -i sh -c ceph --admin-daemon /run/ceph/ceph-mds.myfs-b.asok status' from runtime service failed: rpc error: code = DeadlineExceeded desc = context deadline exceeded

Disabling liveness probe for mons, mds and mgr seems to prevent this issue from #2097 ci runs.

This issue is no longer being observed in ci runs.


Actions on text objects are not performed if the cursor is positioned before the text object

Describe the bug
Following this I did some testing, and found that if the cursor is positioned in the text object, actions are performed as expected, but if it is positioned before the text object, they are ignored. The default (Neo)Vim behaviour is that if a text-object action is called when the cursor is not within a text object of that type, it is performed on the next text object of the same type in the same line, if there is one.
Steps to reproduce
Consider this line:
hello "world" ~blabla~

If the cursor is at the beginning of the line and di" is called, the word world will be deleted. Now, if di~ is called, nothing happens (unless the cursor is within ~blabla~, of course).
Expected behavior
The expected behaviour would be for ~blabla~ to be deleted.
Emacs functionality
No response
Minimal init.lua

-- Enter your minimal_init.lua here

Screenshots and recordings
No response
OS / Distro
Arch Linux
Neovim version/commit
0.9.4
Additional context
No response

I'll take a look at this by this weekend and see about resolving it if nobody else does as a heads up.

Thx ^_^

Thank you for resolving this issue, @PriceHiller 🌼


workspace: settings

fixes #2936 #2604
for a start, the settings store last opened tabs info. This pr will preserve your open tabs and your active tab but it will not make any guarantees about the order of your tabs.
QA

[x] macOS
[x] iPad
[x] android
[ ] iPhone
[ ] linux
[ ] windows

I think there's also a universe in which these things are saved in a file in core itself. Or a universe where core & server are more directly aware of various settings.

I don't believe this closes https://github.com/lockbook/lockbook/issues/2604 yet-- there's a file tree component to that request.


cannot run the same task in different directories same time

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:
OS Version:

Version: 1.85.0-insider (user setup)
Commit: 54b8f6a80aaad7489b75e9293b8d7a1700bed815
Date: 2023-11-17T10:49:40.914Z
Electron: 25.9.4
ElectronBuildId: 25127168
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22631

Steps to Reproduce:

I have a task.json

{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "tasks": [
        {
            "label": "terraform init --upgrade",
            "type": "shell",
            "command": "terraform init --upgrade",
            "options": {
                "cwd": "${fileDirname}"
            }
        },

        {
            "label": "terraform apply",
            "type": "shell",
            "command": "terraform apply",
            "options": {
                "cwd": "${fileDirname}",
            },
            "dependsOn": ["terraform init --upgrade"],
            "presentation": {
                "reveal": "always",
                "panel": "new",
            }
        },

        {
            "label": "terraform destroy",
            "type": "shell",
            "command": "terraform destroy",
            "options": {
                "cwd": "${fileDirname}"
            },
            "dependsOn": ["terraform init --upgrade"],
            "presentation": {
                "reveal": "always",
                "panel": "new",
            }
        }
    ]
}

I have the following project structure

2.  in syd folder, go into main.tf, Ctrl-Shift+P run task, the apply task
3. in mel folder, go into main.tf Ctrl-SHift-P run task, the apply task
getting task is already active

I expect I can run the 2 tasks at the same time.
I found this issue, https://github.com/microsoft/vscode/issues/168741 mentioned fix this already, but I still cannot run the same task in different dirs same time

/duplicate #93001


Update documentation on switching themes

As a follow-up to #22803, we should update https://zulip.com/help/dark-theme to describe the theme switcher.
I think we can just replace the current Desktop/Web instructions; the way to do it via settings doesn't have to be documented.

@sayamsamal are you up for taking care of this one?

Surely @alya, thanks!


[Formfield#859] Add snapshots

Snapshots was added for formfield and some accessibility identifiers was added for ui test

branch for snapshots: https://github.com/adevinta/spark-ios-snapshots/pull/94

Very much not a fan of snapshot testing formfield containing other Spark components, it's not unit anymore and might be impact every time one of those components is modified


add separate jax notebook with cuda

/condalock

/condalock

Something is failing in the pytorch notebook even though it wasn't edited...

/condalock

/condalock

/condalock


7900 XTX: Error invalid device function at line 679 in file /bitsandbytes/csrc/ops.hip

System Info
Kernel: 6.5.0-28-generic
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.4 LTS
Release:        22.04
Codename:       jammy
GPU: Sapphire Pulse RX 7900 XTX
ROCm Version: 6.0.2
CPU: Ryzen 7 7700X
Motherboard: Gigabyte Aorus Elite AX B650 (BIOS: F24c)
Torch version: torch==2.3.0+rocm6.0
Python version: 3.10.14
Reproduction
I'm on the rocm_enabled branch. Attempting to compile the ROCm 6.2 testing branch results in errors. Running the following code results in this error:
# Huggingface Transformers

model_id = "microsoft/Phi-3-mini-128k-instruct"
bnb_config = BitsAndBytesConfig(
    load_in_8bit=True,
    #load_in_4bit=True,
    #bnb_4bit_quant_type="nf4",
    #bnb_4bit_compute_dtype=torch.float16
)

tokenizer = AutoTokenizer.from_pretrained(model_id)
model = AutoModelForCausalLM.from_pretrained(
    model_id,
    torch_dtype=torch.bfloat16,
    device_map="cuda",
    trust_remote_code = True,
    attn_implementation="eager",
    quantization_config = bnb_config # un-comment to quantize your model; Only supports Nvidia GPUs
)

attached here is ops.hip:
ops.hip.zip
Expected behavior
after running that piece of code, I get the following error:
Error invalid device function at line 679 in file /home/$USER/bitsandbytes/csrc/ops.hip.
Nothing else prints to my terminal.

Here's the terminal output with AMD_LOG_LEVEL:
log_level3.txt
rocminfo:
rocminfo.txt
hipconfig --version: 6.0.32831-204d35d16

Could you try with rocm 6.1? You can use rocm/pytorch:latest docker.
If you have to use 6.0, please try with rocm/pytorch:rocm6.0.2_ubuntu22.04_py3.10_pytorch_2.1.2
Please make sure to select gfx1100 gpu with the container.

Alright, will try it out. I built my previous one with gfx1101. What's the Navi 31 GFX name supposed to be anyways? Is it 1100?

Gave it a try today.
I installed the latest ROCm version of 6.1.1 after uninstalling 6.0.2.
I pulled the latest version of the repo and did the following:
git checkout rocm_enabled
git pull
pip install -r requirements-dev.txt
cmake -DCOMPUTE_BACKEND=hip -S . -DBNB_ROCM_ARCH="gfx1100" -DCMAKE_HIP_COMPILER=/opt/rocm-6.1.1/llvm/bin/clang++
make
pip install .

the program compiled but gave me warnings.
after rerunning it with the same python script, it seems to still give the same errors.

here's the output when I run AMD_LOG_LEVEL=3 now:
log_level3_new.txt
and here's rocminfo:
rocminfo_new.txt
hipconfig version: 6.1.40092-038397aaa

Please set HSA_OVERRIDE_GFX_VERSION=11.0.0 and retry. Its an environment variable, you can export or set it while running the script. It will target to gfx1100 architecture.

I had the same error, adding HSA_OVERRIDE_GFX_VERSION=11.0.0 seems to fix it but unforcenetly now i get:
rocblaslt warning: No paths matched /opt/rocm/lib/hipblaslt/library/*gfx1100*co. Make sure that HIPBLASLT_TENSILE_LIBPATH is set correctly.
A: torch.Size([1984, 3200]), B: torch.Size([3200, 3200]), C: (1984, 3200); (lda, ldb, ldc): (c_int(1984), c_int(3200), c_int(1984)); (m, n, k): (c_int(1984), c_int(3200), c_int(3200))
error detectedTraceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/opt/Projects/axolotl/src/axolotl/cli/train.py", line 70, in <module>
    fire.Fire(do_cli)
  File "/opt/Projects/venv/lib/python3.10/site-packages/fire/core.py", line 143, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
  File "/opt/Projects/venv/lib/python3.10/site-packages/fire/core.py", line 477, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
  File "/opt/Projects/venv/lib/python3.10/site-packages/fire/core.py", line 693, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
  File "/opt/Projects/axolotl/src/axolotl/cli/train.py", line 38, in do_cli
    return do_train(parsed_cfg, parsed_cli_args)
  File "/opt/Projects/axolotl/src/axolotl/cli/train.py", line 66, in do_train
    return train(cfg=cfg, cli_args=cli_args, dataset_meta=dataset_meta)
  File "/opt/Projects/axolotl/src/axolotl/train.py", line 170, in train
    trainer.train(resume_from_checkpoint=resume_from_checkpoint)
  File "/opt/Projects/venv/lib/python3.10/site-packages/transformers/trainer.py", line 1885, in train
    return inner_training_loop(
  File "/opt/Projects/venv/lib/python3.10/site-packages/transformers/trainer.py", line 2216, in _inner_training_loop
    tr_loss_step = self.training_step(model, inputs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/transformers/trainer.py", line 3238, in training_step
    loss = self.compute_loss(model, inputs)
  File "/opt/Projects/axolotl/src/axolotl/core/trainer_builder.py", line 539, in compute_loss
    return super().compute_loss(model, inputs, return_outputs=return_outputs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/transformers/trainer.py", line 3264, in compute_loss
    outputs = model(**inputs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/accelerate/utils/operations.py", line 822, in forward
    return model_forward(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/accelerate/utils/operations.py", line 810, in __call__
    return convert_to_fp32(self.model_forward(*args, **kwargs))
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/amp/autocast_mode.py", line 16, in decorate_autocast
    return func(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/peft/peft_model.py", line 1430, in forward
    return self.base_model(
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/peft/tuners/tuners_utils.py", line 179, in forward
    return self.model.forward(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 1164, in forward
    outputs = self.model(
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/opt/Projects/axolotl/src/axolotl/monkeypatch/llama_attn_hijack_flash.py", line 814, in llama_model_forward
    layer_outputs = torch.utils.checkpoint.checkpoint(
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/_compile.py", line 24, in inner
    return torch._dynamo.disable(fn, recursive)(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/_dynamo/eval_frame.py", line 328, in _fn
    return fn(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/_dynamo/external_utils.py", line 17, in inner
    return fn(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/utils/checkpoint.py", line 451, in checkpoint
    return CheckpointFunction.apply(function, preserve, *args)
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/autograd/function.py", line 539, in apply
    return super().apply(*args, **kwargs)  # type: ignore[misc]
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/utils/checkpoint.py", line 230, in forward
    outputs = run_function(*args)
  File "/opt/Projects/axolotl/src/axolotl/monkeypatch/llama_attn_hijack_flash.py", line 808, in custom_forward
    return module(
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/opt/Projects/axolotl/src/axolotl/monkeypatch/llama_attn_hijack_flash.py", line 907, in forward
    hidden_states, self_attn_weights, present_key_value = self.self_attn(
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/opt/Projects/axolotl/src/axolotl/monkeypatch/llama_attn_hijack_flash.py", line 422, in flashattn_forward
    query_states = self.q_proj(hidden_states)
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/peft/tuners/lora/bnb.py", line 217, in forward
    result = self.base_layer(x, *args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/opt/Projects/venv/lib/python3.10/site-packages/bitsandbytes/nn/modules.py", line 801, in forward
    out = bnb.matmul(x, self.weight, bias=self.bias, state=self.state)
  File "/opt/Projects/venv/lib/python3.10/site-packages/bitsandbytes/autograd/_functions.py", line 559, in matmul
    return MatMul8bitLt.apply(A, B, out, bias, state)
  File "/opt/Projects/venv/lib/python3.10/site-packages/torch/autograd/function.py", line 539, in apply
    return super().apply(*args, **kwargs)  # type: ignore[misc]
  File "/opt/Projects/venv/lib/python3.10/site-packages/bitsandbytes/autograd/_functions.py", line 398, in forward
    out32, Sout32 = F.igemmlt(C32A, state.CxB, SA, state.SB)
  File "/opt/Projects/venv/lib/python3.10/site-packages/bitsandbytes/functional.py", line 2388, in igemmlt
    raise Exception("cublasLt ran into an error!")
Exception: cublasLt ran into an error!

I suggest moving over to the alpha test of the actual Bitsandbytes library. You can use the multi_backend_refactor branch. It works on my 7900 XTX

I must of missed this issue as I opened a seperate issue to report a similar issue on my Radeon Pro W7900 (also gfx1100) with loading the model in 8-bit. It should be noted that while trying to load a model in 8-bit is not working with bitsandbytes on Radeon GPUs I did get it to work loading models in 4-bit. Not sure if this will help your use-case but using load_in_4bit=True instead of load_in_8bit=True worked for me.
Note that as of newer versions of PyTorch there ais an upstream issue with PyTorch force loading HIPBLASLT for all AMD GPUS which is not supported on Radeon GPUs. You will also need to set TORCH_BLAS_PREFER_HIPBLASLT=0 for it to work.


feat: null safety

null safety + some formatting

Ok looks great. We will keep this on a dedicated branch until null safety is stable. Great work!


GlobalTracer ported from Java

This is a port from the opentracing-java project. It currently has the following deviations:

C# does not have the synchronized keyword and usage of MethodImpl.Synchronized is not really recommended so I'm using regular locking instead. I might have messed that up so any feedback is welcome. :)
Java's tracer variable is static. I do not really know why as GlobalTracer is more or less a regular wrapper/decorator type so it should be an instance variable.

Note that this currently does not compile as it requires the NoopTracer from #57. That's also the reason why there's no unit tests yet.
This will resolve #45.

fyi: I'll probably merge this on Tuesday morning (UTC) if there's no contrary comments.


As bot retrieve ReplyTo message

One of the functions of my bot is to run a command against another message in a channel. For convenience a user can reply to the original message with the command for the bot.
The idea is the bot will catch the command then read the content of the message referenced in the MessageReplyHeader of Message.ReplyTo. The header of course only contains message identifying information.
var inputMessage = new InputMessageID {id = message.reply_to.reply_to_msg_id};
var messages = await this.Channels_GetMessages(new InputChannelFromMessage
{
    peer = Client.Chats[message.peer_id],
    msg_id = message.reply_to.reply_to_msg_id,
    channel_id = message.peer_id.ID
}, new InputMessage[] {inputMessage});

Produces exception FROM_MESSAGE_BOT_DISABLED. How do I go about retrieving the message that the user replied to? It must be possible in some fashion as the Telegram.Bot library automatically populates a property called ReplyToMessage on it's Message object.

InputChannelFromMessage is used when a channel posts a message in another chat, so I don't think it's adequate for your problem.
To fetch the replied-to message, here is a code that worked for me (using latest version of the lib):
var messages = await client.GetMessages(chats[message.peer_id.ID], message.reply_to.reply_to_msg_id);

(tested successfully with User/Chat/Channel peers, using bot or user account)


how  i select multi row in table ?

i try to select multiple row but not working how i fix it ?

I don't know how to help you, tell me more.

look example/Overview maybe it can help you

i can't select multi row in the tab