Global type name uniqueness constraint too onerous

Due to how Monoid instances for hashmaps work, the final API description contains exact same schemas for different types with the same name.
This is a bug unless it is required that type names are globally unique. However, it should be possible to lift this requirement by disambiguating hashmap keys, i. e. by adding route name as a prefix to each key.
Alternatively, I'd like there to be a warning or even an error, because otherwise I simply end up with wrong documentation.
Example:
-- in Module1.hs
data ResponseBody = ResponseBody { rbField1 :: () } deriving Generic

-- in Module2.hs
data ResponseBody = ResponseBody { rbField2 :: () } deriving Generic

-- in Main.hs
type MyApi
  = "Route1" :> Get '[JSON] Module1.ResponseBody
    :<|>
    "Route2" :> Get '[JSON] Module2.ResponseBody

main = let swagger = toOpenApi (Proxy :: Proxy MyApi) in
  B.putStrLn $ encodePretty swagger

{
    "components": {
        "schemas": {
            "ResponseBody": {
                "type": "object",
                "properties": {
                    "rbField2": {
                        "items": {},
                        "maxItems": 0,
                        "type": "array",
                        "example": []
                    }
                },
                "required": [
                    "rbField2"
                ]
            }
        }
    },
    "openapi": "3.0.0",
    "paths": {
        "/Route1": {
            "get": {
                "responses": {
                    "200": {
                        "content": {
                            "application/json;charset=utf-8": {
                                "schema": {
                                    "$ref": "#/components/schemas/ResponseBody"
                                }
                            }
                        },
                        "description": ""
                    }
                }
            }
        },
        "/Route2": {
            "get": {
                "responses": {
                    "200": {
                        "content": {
                            "application/json;charset=utf-8": {
                                "schema": {
                                    "$ref": "#/components/schemas/ResponseBody"
                                }
                            }
                        },
                        "description": ""
                    }
                }
            }
        }
    },
    "info": {
        "version": "",
        "title": ""
    }
}

Facing similar issues.  I tried to alter schema names adding module prefix to type name but this does not affect references.  Looks like there is no way to alter reference name.


LastFM Now Playing not working.

The LastFM Now Playing does not work. I have authorized the client as well as enabled now playing, but LastFM only displays the scrobble once the song is over.

Seems to be a last.fm problem.

There is really nothing I can do here. If there is nothing in foobar's error log (View -> Console) then submission to last.fm was successful, and the problem is on the side of last.fm (At the time of writing this, Now Playing notifications seem to be delayed by a few minutes.)


SW-5795 Use unique Balena IDs in tests

Unlike most of our unique IDs, Balena device IDs aren't generated by our database
but rather come from Balena's API. But they're still required to be unique, so we
don't want tests to use hardwired ones that can collide.
Update the relevant tests to use generated IDs that are unique across threads.

#2276  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgrimm and the rest of your teammates on  Graphite

Merge activity

Aug 14, 12:21 PM EDT: @sgrimm started a stack merge that includes this pull request via Graphite.


Pipelines: Fail to get accesstoken with oauth config

I can't set up pipelines with Github:
Fail to get accesstoken with oauth config
I tried to remove and re-add Github config. It works fine to authenticate me as a user but not for pipelines.

Rancher logs aren't helpful:
2019/04/27 19:16:01 [ERROR] Unknown error: Fail to get accesstoken with oauth config

Useful
Info

Versions
Rancher v2.2.2 UI: v2.2.41

Route
global-admin.clusters.index

The error indicates that Github returns an empty access token. Is it a private Github install? It might be a configuration issue. FYI, here is a similar discussion about that in https://github.com/drone/drone/issues/1435.

We're experiencing this as well, the Rancher version is 2.2.3 though. In this case it's not a private GitHub @gitlawr.

@gitlawr It worked fine before, and somehow stopped working with the same install (Github login keeps working fine). It's a private Github install but I wouldn't know what could be configured wrong.

It might be worth adding that authentication works fine in our case as well.

Do you recall any change before it breaks?
Single mode or HA Rancher?
Is there anything special in the install like a proxy, firewall between users and the rancher server?
Might not be relevant but trying to find a way to reproduce it

Sadly I don't, afaik I didn't change anything. Single mode. I do have a CDN in front of the rancher server (edge TLS served by the CDN, CDN and the origin (rancher) is protected with TLS) if that is relevant.

Regarding the firewall; I've tried it on three networks thus far and one of those doesn't have a firewall, but it fails on all networks. There's no proxy, CDN, load balancer or whatever either.
Mentioning the word "proxy" I came up with using Charles to analyze the HTTP calls, perhaps that will help finding the cause.
:method | POST
:scheme | https
:path | /v3/project/[id]/githubPipelineConfigs/p-dhhsg:github?action=testAndApply

{
	"code": "[code]",
	"clientId": "",
	"clientSecret": "",
	"redirectUrl": "https://rancher.domain.ext/verify-auth",
	"inheritAuth": true,
	"hostname": "github.com"
}

As you can see, the clientId and clientSecret are empty indeed.
GitHub is being opened in the pop-up with the following URL:
:method | GET
:scheme | https
:path | /login/oauth/authorize?client_id=[id]&response_type=code&scope=repo+admin%3Arepo_hook&state=[number]&redirect_uri=https%3A%2F%2Francher.domain.ext%2Fverify-auth

Thanks for the details.
Confirmed as a regression bug that can be reproduced in v2.2.3 by following steps:

Enable Github as the global authentication provider.
Go to project pipeline page click Authenticate

The workaround is to click Use another OAuth Application, then input the client ID/secret of your OAuth app explicitly as @RobbinHabermehl suggested.

Still happens on 2.3.3 with a slightly different error:
oauth2: server response missing access_token

just tried for gitlab with rancher 2.2.10 and it fails too.
verified the payload in the post request on "authenticate" button click and it contains the proper values for appid and secret
there is no "use another OAuth Application" option anymore in this version.

Same here using rancher 2.3.5 ant it fails with "TestAndApply Error Fail to get accesstoken with oauth config"

Same issue here with a fresh install of rancher and trying to authenticate to the gitlab cloud version.

Sign me up, I am having the same issue with GitLab. It has appeared right out of blue.
Anybody aware of any changes to GitLab OAuth2?
My brain has melted down thinking of the way to sniff the service for exact http request & response.

I get this error with Gitlab.com
TestAndApply Error
Fail to get accesstoken with oauth config

I get this error with Gitlab.com
TestAndApply Error
Fail to get accesstoken with oauth config

+1

it happens too on gitlab
Is there any workarround on that for gitlab users?
2020/01/29 10:50:37 [ERROR] Unknown error: Fail to get accesstoken with oauth config

https://github.com/rancher/rancher/issues/25657#issuecomment-597410043

Gitlab related issue is different from the original post, I think we should track it in a separate issue: https://github.com/rancher/rancher/issues/25975
Please see the description, cause and possible workaround there.

me too,  i look at the source code, may be the field 'globalConfig.ClientSecret' in func of testAndApply is not correct, the value is not correct 'github client secret' but the name (cattle-global-data:githubconfig-clientsecret) of secret of 'github client secret'.


Breaks character shadow

Hello thanks for your great mod,
I'd love to use it but unfortunately I find it breaks immersion because in first person my character's shadow is only a floating head/suit helmet. Screenshot attached.
I tested this with game v45, bepinex 5.4.2200 and toomanyemotes 1.5.3. Only those installed on a new r2mm profile.

Fixed with 1.5.4 ♥

Sorry, forgot this issue was also posted on here, otherwise I would have mentioned it was fixed!

Didn't mean to reopen.


{Network} az network application-gateway url-path-map: Migrate commands to codegen v2

Related command

az network application-gateway url-path-map
az network application-gateway waf-config
Description

Total: 12 commands
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Network


[QUERY] Azure Form Recognizer DocumentFieldType always returns Unknown but expecting DocumentFieldType.Double

Library name and version
Azure.AI.FormRecognizer 4.0.0
Query/Question
Trying to map some values from Azure form recognizer Custom Extraction Model. Within Form Recognizer studio the field is type number -> not-specified. I would imagine this would map to the DocumentFieldType.Double within the C# library but it keeps returning as DocumentFieldType.Unknown. What is the correct way to map non-currency numeric values? Updating the library version to 4.1.0 does not help.
Here is the output json from the recognition for a field. I'd imagine it not having a valueNumber field might have something to do with it but I don't quite understand why it doesn't have one.
"WaterMeterReadingFrom": {
	"type": "number",
	"content": "2568",
	"boundingRegions": [
		{
			"pageNumber": 2,
			"polygon": [
				4.868,
				1.6141,
				5.1725,
				1.6141,
				5.1725,
				1.7562,
				4.868,
				1.7562
			]
		}
	],
	"confidence": 0.964,
	"spans": [
		{
			"offset": 1866,
			"length": 4
		}
	]
},

Environment
Windows 11 .NET7.0
JetBrains Rider 2023.3.2

Tagging and routing to the member best able to assist you. /cc:@kinelski

@jlunarzewski ,
The SDK exposes the field type as Unknown because it lacks a valueNumber, as you noticed. This means that the service was not able to parse it into a floating point value on their end. If you still want to extract it as a number, you can get the string representation of the field in DocumentField.Content and you will need to parse it on your side.
You can still extract the expected field type from the DocumentField.ExpectedType property, which should be set to Double.


Redirect Livewire

Hello guys
I'm trying use toast in redirect route livewire, but i'm getting this message:

Any ideas how to workaround this?

Can you provide the code block that's causing this issue?

Found the culprit. Please upgrade to 1.1.2.

Hello, sorry for the delay responding.
I updated for the 1.1.2 version, the error message disappeared, but toast not displayed.
This is my code:

Thanks for the help!

Hello, sorry for the delay responding.
I updated for the 1.1.2 version, the error message disappeared, but toast not displayed.
This is my code:

Thanks for the help!

Can you show the contents of the Controller that's serving users.index?

I am also facing the same issue...
After redirecting, the Toast does not appear.

I am also facing the same issue... After redirecting, the Toast does not appear.

Okay. Can you please provide some more info in order to debug what's going on? Because I can't reproduce it.

I am also facing the same issue... After redirecting, the Toast does not appear.

More specifically, I'll need to see how you are dispatching your toasts and what your Controller / Livewire component you redirected to is doing in the next request. As I've said previously, I can't reproduce it alas and thus won't be able to provide a fix without a repro.
Thanks.

https://gist.github.com/zhi8617/5d9cc0e17c5bb8d390d232d06c490916
I have placed the test code in the provided link.
The expected behavior of the code is that after executing the CompanyController, it should redirect to the test page and display a Toaster message.
Perhaps I misunderstood something?
Thank you for your response. I really appreciate the design of this package.

https://gist.github.com/zhi8617/5d9cc0e17c5bb8d390d232d06c490916
I have placed the test code in the provided link.
The expected behavior of the code is that after executing the CompanyController, it should redirect to the test page and display a Toaster message.
Perhaps I misunderstood something?
Thank you for your response. I really appreciate the design of this package.

Hey, thank you so much for the gist! I'll take a look as soon as possible.

So I had a gander, and everything seems to be fine.
Can you confirm whether your endpoints are using the web middleware group? And can you please share the contents of that middleware group also? I have a hunch that's going to be the culprit for both of you.
@zhi8617 @lucas-davi
Thanks!

Thank you for your response. Yes, the endpoint uses web middleware, and the web middleware has not been modified.
Laravel Version  10.12.0
PHP Version  8.2.6
Executed within Laravel Sail.

Perhaps I just encountered a special case. It's okay, go ahead and attend to your matters. Thank you.

Perhaps I just encountered a special case. It's okay, go ahead and attend to your matters. Thank you.

Hey,
I'll see if I can fix it. I did take a look yesterday and the culprit might be full-page Livewire components which is what you provided in the gist. I have never worked with full-page components, so I'll need a bit more time to figure out what's going wrong.
I'll keep you posted!

Hey @zhi8617
I set up an application with the exact setup you provided in the gist. Unfortunately I am still unable to reproduce the issue.
I'd really appreciate a repository with minimal code that can reproduce the bug, so I can track down the cause and fix it. Could you provide such a repository?
Otherwise, my hands will be tied until some does provide a reproduction. Thanks.

When I created a new Laravel application and it works, that's awesome! Thank you so much.

Hello,
In my project I was also using the log-viewer extension.
I removed the log-viewer from the project and it worked perfectly as describe in the documentation.
Keeping the two extensions, after the redirect the Toast does not appear for me, is it possible a conflict between the extensions?
Thanks for the help! 😃

@lucas-davi Which version of that package did you install? I'll see if there's any conflict.

I used these versions:
log-viewer: 2.4.1
toaster: 1.2.0

It was indeed a conflict of multiple packages registering a macro with the same name.
Please don't use the RedirectResponse / Redirector macros in this case and call the Toaster façade directly.


fix #597 Code optimization meet p3c code checking rules

Ⅰ.  Does this pull request fix one issue?
fix #597 Code optimization meet p3c code checking rules
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #598 into develop will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             develop     #598   +/-   ##
==========================================
  Coverage      32.02%   32.02%
  Complexity       775      775
==========================================
  Files            200      200
  Lines           7915     7915
  Branches         937      937
==========================================
  Hits            2535     2535
  Misses          5122     5122
  Partials         258      258

Impacted Files
Coverage Δ
Complexity Δ

.../rm/datasource/AbstractPreparedStatementProxy.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...fescar/server/session/FileBasedSessionManager.java
54.87% <ø> (ø)
15 <0> (ø)
:arrow_down:

...lTransactionWithGlobalLockDataSourceBasicTest.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...scar/core/rpc/netty/AbstractRpcRemotingServer.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb0904...92e5669. Read the comment docs.


light level don't work. LEEDARSON LIGHTING/M350ST-W1R-01

Hi, the following device light level was working on groovy with the stock zigbee dimer driver, but on edge the level do not work.
application: 01 endpointId: 01 firmwareFullVersion: 00000009 firmwareImageType: 257 firmwareManufacturerCode: 4456 manufacturer: LEEDARSON LIGHTING model: M350ST-W1R-01 zigbeeNodeType: ROUTER
https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/f266b81134ad80e52e0f23c029f465e948992d82/drivers/SmartThings/zigbee-switch/fingerprints.yml#L519

The fingerprint for dimming light capability of this device is missing at drivers/SmartThings/zigbee-switch/src/zigbee-dimming-light/init.lua

This has been reported to the engineering team. Thanks for sharing! In case we need more info, we'll contact you through the Community forum.
Please, in case you see other issues, create a new post in this section and tag us (@nayelyz or @andresg)


Updated lvl 11

The good one is level_11, not sure why lucas_rambaud is still there but it's obsolete


Cards vs Payment Methods

I am not sure if this is a feature request, missing functionality or actually is a bug...but listing my thoughts below.
Here's what I've found from using Cashier
Stripe exposes APIs for creating "cards"(which it considers to be ONE type of payment method).

https://stripe.com/docs/api/cards/object
https://stripe.com/docs/api/payment_methods/object

The Cashier APIs only expose Payment Methods, not cards. It would be nice to expose the Cards CRUD APIs in Cashier, as well.
When you go to the Stripe Dashboard, and from within a customer object, you manually add a card, it creates a card, like so:

        {
            "id": "card_0GhSbBDXGF9cqh5pRFYCQcg6",
            "brand": "visa",
            "last_four": "4242",
            "exp_month": 5,
            "exp_year": 2055
        }

If you use the addPaymentMethod() API, it creates a payment method object that looks like this:
        {
            "id": "pm_0GhRNwDXGF9cqh5pMGhuPY1p",
            "brand": "visa",
            "last_four": "4242",
            "exp_month": 2,
            "exp_year": 2022
        }

This is weird and confusing and is also the cause for the issue https://github.com/laravel/cashier/issues/933
Even after a lot of trial and error and research, I'm not sure:

Should we be creating cards first, then payment methods, and then tying the card to the Payment Method?
Why does $user->defaultPaymentMethod() only return values for cards having ids like card_0GhSbBDXGF9cqh5pRFYCQcg6, and NOT payment method objects with IDs like pm_0GhRNwDXGF9cqh5pMGhuPY1p
?
How do you get the default payment method using Cashier? What is the use case for

$user->defaultPaymentMethod()
vs
$user->asStripeCustomer()->invoice_settings->default_payment_method

I'd like to suggest 2 things:

At a minimum, it would be helpful to get answers to the 3 questions above.
If it makes sense to do so, it might be helpful to also expose the Cards CRUD APIs in Cashier.

Should we be creating cards first, then payment methods, and then tying the card to the Payment Method?

Payment methods / payment intents are Stripe's new and current recommended way of providing ways in which customers can pay. The old card / sources api is the old deprecated and will be removed at some point in the future. See https://stripe.com/docs/sources/cards

Use of this API is no longer recommended. We recommend adopting the Payment Intents API. This new integration lets you benefit from Dynamic 3D Secure and helps you avoid an increase in declined payments due to Strong Customer Authentication regulation in Europe.

Why does $user->defaultPaymentMethod() only return values for cards having ids like card_0GhSbBDXGF9cqh5pRFYCQcg6, and NOT payment method objects with IDs like pm_0GhRNwDXGF9cqh5pMGhuPY1p

I think you mean the other way around? Atm this method returns objects with pm_ ids.

How do you get the default payment method using Cashier? What is the use case for

Exactly the method you gave: $user->defaultPaymentMethod().
Let's continue this discussion on Discord as the issue tracker here isn't a support channel (see the issue templates).

@driesvints sounds good, and sorry for the noise. I do still see the discrepancy between $user->defaultPaymentMethod() and $user->asStripeCustomer()->invoice_settings->default_payment_method (as detailed above). Let's continue the discussion on Discord


get_json function returning None when force equal to true is used

Hello,
When I use get_json(silent=True, force=True) and there is no value in the request body, the function returns me with a None.
Wouldn't the correct be an empty dictionary since I'm saying that force is true?
A possible correction could be as follows:
https://github.com/pallets/werkzeug/compare/master...duducp:patch-1

why? null / None seems more sensible to me than an empty dict. not all json payloads are dicts.


Python Programming to Add two numbers

Store input numbers
num1 = input('Enter first number: ')
num2 = input('Enter second number: ')
Add two numbers
sum = float(num1) + float(num2)
Display the sum
print('The sum of {0} and {1} is {2}'.format(num1, num2, sum))
Output
Enter first number: 1.5
Enter second number: 6.3
The sum of 1.5 and 6.3 is 7.8

Please go through the Contribution Guidelines

Running Sum of 1d array Solution.py ...

#1488

# Python implementation of substituting a   # specific text pattern in a string using regex     # importing regex module  import re     # Function to perform  # operations on the strings  def substitutor():             # a string variable      sentence1 = "It is raining outside."            # replacing text 'raining' in the string       # variable sentence1 with 'sunny' thus      # passing first parameter as raining      # second as sunny, third as the       # variable name in which string is stored      # and printing the modified string      print(re.sub(r"raining", "sunny", sentence1))             # a string variable      sentence2 = "Thank you very very much."            # replacing text 'very' in the string       # variable sentence2 with 'so' thus       # passing parameters at their       # appropriate positions and printing       # the modified string      print(re.sub(r"very", "so", sentence2))     # Driver Code:   substitutor()
Ok


Fixes #125: Integration with Automatic

Awesome! Would be great to add a vehicle_type option to this source once we have it implemented.


Feature Request: Use Publish Profile file in repo instead of in secrets

I would like to use version control for my publish profile instead of just having it in secrets.
My ideal setup would be:

Download the publish profile from Azure portal
Replace any passwords with tokens aka #{USER_PWD}#
Add it to the repo
Use https://github.com/cschleiden/replace-tokens to replace the tokens in a step in the workflow
Deploy using the local file relative path instead of a secret aka publish-profile: 'deploy/repost.PublishSettings'

Here is an example workflow file I tested it with: https://github.com/philip-gai/repost/actions/runs/1344501354/workflow

Thank you but this request is declined due to other priorities.
Plus, I don't think it's a good practice to have that information in source control where a less sophisticated user could make the easy mistake of forgetting to remove the secrets as they put the publish profile into their repository.


Add helper function : bpf_fib_lookup

This issue is to track adding support for the following helper functions:

[ ] bpf_fib_lookup

what about l3/l4_csum_replace? Is csum_diff any useful without the replace functions?

@qmonnet will help answer any questions necessary to implement in a platform-agnostic fashion.

@shankarseal also observed that in Windows there are APIs at PASSIVE IRQL but this helper is needed at DISPATCH IRQL.  DISPATCH lookups are not currently exposed outside the tcpip.sys driver, just done inside it.


Remove Catalog.merge_datasets()

Current implementation doesn't really work with our new feature schemas from lib and is also not really used from anywhere except from CLI.
We already haveDataChain.merge() which maybe can be used instead, but we need to check if dataset dependencies are handled in a right way with that one.
Maybe we can also remove CLI command for this as well as it seems kind of random to have that there(this is more of a product decision though)

Let's remove it!
It's not even clear how to use merge_dataset() without merge condition. It seems like very specific use case.


Add asymp and asymp.not symbols

See https://forum.typst.app/t/symbol-for-hardys-asymptotic-notation/1601/2.
The symbols ≍ and ≭ are in Unicode "Mathematical Operators 2200-22FF" as
EQUIVALENT TO and NOT EQUIVALENT TO respectively.
In practice, they are used in the literature for asymptotic behaviour,
providing a shorthand notation for the big-O notation, see https://en.wikipedia.org/wiki/Big_O_notation#:~:text=of his tract-,Hardy,-defined the symbol.

Thanks for the PR. Just a suggestion: it would seem that eq.equiv.not would be more consistent with the existing naming rules for symbols, such as eq.not, tilde.not, in.not, etc.

I was wondering about that. I looked through the symbols, and observed that neq and nequiv are always used instead of eq.not and equiv.not. I think it's more coherent to keep that up. A single instance of equiv.not exists in tilde, but also defines the shorthand nequiv.

Hi! Thanks for the PR. We were already considering adding this symbol, but we think the names asymp and asymp.not would be better. If you want to discuss it with us, it will be easier on Discord. If you don't have Discord, I can provide a summary of the arguments here.
If we instead decide to go for your suggestion (i.e., eq.equiv instead of asymp), ≭ should be eq.equiv.not instead of eq.nequiv. When neq or nequiv are used, it is part of a larger symbol where only the eq or equiv part is negated.

Thanks for the details!

When neq or nequiv are used, it is part of a larger symbol where only the eq or equiv part is negated.
Did not realise that subtlety, is this documented explictly somewhere?

I don't think this is documented anywhere outside of the symbol list, where it's not stated explicitly (but you can stare at the symbols and names until the logic appears to you).
There are few rules that are set in stone regarding symbol naming (because Unicode would always hits us with an exception). Instead, we try to make everything as consistent as possible, while keeping short names for commonly used symbols.

Looks like there is consensus from the Discord discussion!


fail to import model_selection

I'm trying to just run the examples from the docs. I seem to fail to import model_selection. It I could not find it on the master branch either.
-----------------------------------------------------------
ImportError               Traceback (most recent call last)
<ipython-input-178-0c70db37b907> in <module>
      2 from creme import linear_model
      3 from creme import metrics
----> 4 from creme import model_selection
      5 from creme import preprocessing
      6 from creme import optim

ImportError: cannot import name 'model_selection' from 'creme' (/usr/local/Caskroom/miniconda/base/lib/python3.7/site-packages/creme/__init__.py)

Ok, I guess you have moved it to evaluate https://github.com/creme-ml/creme/blob/dd42c852f7a05c7402dceb80be4800c3b4f4ec6c/creme/evaluate/progressive_validation.py#L14
maybe worth updating docs.

Hey @LeonardAukea! On what version of creme are you testing? We renamed model_selection to evaluate but that only affects the development branch.
We're in the process with merging with scikit-multiflow. It's a big undertaking and a fair amount of things will change.


Android 4.4.4 axios JSON.parse(response) error

Environment
System:
  OS: macOS High Sierra 10.13.3
  CPU: x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
  Memory: 94.82 MB / 16.00 GB
  Shell: 3.2.57 - /bin/bash
Binaries:
  Node: 8.11.4 - ~/.nvm/versions/node/v8.11.4/bin/node
  npm: 5.6.0 - ~/.nvm/versions/node/v8.11.4/bin/npm
  Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
  iOS SDK:
    Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
  Android SDK:
    Build Tools: 19.1.0, 20.0.0, 21.1.1, 21.1.2, 22.0.0, 22.0.1, 23.0.0, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 24.0.1, 24.0.2, 24.0.3, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.0, 26.0.1, 26.0.2, 26.0.3, 27.0.1, 27.0.2, 27.0.3, 28.0.2
    API Levels: 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27
IDEs:
  Android Studio: 3.1 AI-173.4907809
  Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
npmPackages:
  react: 16.4.1 => 16.4.1
  react-native: 0.56.0 => 0.56.0
npmGlobalPackages:
  react-native-git-upgrade: 0.2.7

Description
On Android 4.4.4，when response body is too big(~20kb), response body will cut the content and JSON.parse(response) will occur the SyntaxError: Unexpected token i in JSON at position. I print the request body, and this content like this: {"id":1,"name":""isRequired":1}, the content after name lose the value",. The complete content should be {"id":1,"name":"value","isRequired":1}.
I also set maxContentLength: Number.MAX_VALUE, but it's not work.
I using react native v0.56.0 and axios v0.18.0.
I also tried Fetch and it's work.

Hallo! I've tried recreating this problem in React-Native version 0.56. I'm using Axios version 0.18.0.
I've made a request with a body of: 37.62 KB and header size headers: 450 B.
I'm using an Android Simulator running 4.4.2 and the request works fine, and the application doesn't crash
Does this problem also happen to you on 4.4.2? If so, maybe try updating React-Native to version 0.56?

Valid json key is string, so id should be "id", maybe it's the problem. Can you check this ?

@MarkDaleman，i tried updating React-Native to version 0.56, but the problem still remains.

Hello! I've made a simple demo here. I'm using JSON data with a response body size of 148.97KB as you can see in the image.

I've also uploaded my demo to github, maybe you can clone it and see if it still happens?
https://github.com/MarkDaleman/AxiosTest

@wxcchdStar You need to provide an repro to find the issue.

@gengjiawen @MarkDaleman , I provide a repo to reappear the issue: https://github.com/wxcchdStar/AxiosTest。

Also tried upgrade to okhttp 3.11.0, the problem still exists.

I tried fetch, and it's not working too, the json returned is as expected. What do you mean it works @wxcchdStar , do you see correct json returned ?

An expo snack repro: https://snack.expo.io/@gengjiawen/fetch-bug .
Run android version you can see the wrong output.

An expo snack repro: https://snack.expo.io/@gengjiawen/fetch-bug .
Run android version you can see the wrong output.

@gengjiawen, yes, it's work above Android 5.0 and not work below Android 4.4.4.
I tried your expo snack repro and the resp.json() on Android 4.4.4 return this, so the Fetch is work for me:

What's _40 and _55 in json ?

@gengjiawen, i update my repo: https://github.com/wxcchdStar/AxiosTest。 I tested Fetch and XMLHttpRequest, and both of them are work. Then i review the source code of Axios,  and i found a solution at axios/lib/adapters/xhr.js. I change the value of loadEvent from onreadystatechange to onload and it's work. You can try this way. I don't known why it's work, maybe related to the underlying system.

What's _40 and _55 in json ?

@gengjiawen,  it's a part of Promise construct. resp.json() return Promise not JSON. So you can resp.json().then(data=>console.log(data)) for print data

I have also noticed sporadic malformed JSON responses on Android <4.4. The issue appears to be in ProgressiveStringDecoder which is used to decode full JSON response from partial byte arrays. Issue is due to apparent bug in Java versions used in Android <4.4, namely misbehaviour of CharsetDecoder, which does not raise on invalid input. This code should determine how many bytes should trimmed and passed to subsequent byte array, however in Android < 4.4 CharacterCodingException is not thrown, and thus decoding of next byte array fails.
I have found no related bug report for CharsetDecoder or mention of changed behaviour, however, following code demonstrates difference in Android <4.4 and 5+:

byte[] data = new byte[] { 79, -59 };
ByteBuffer decodeBuffer = ByteBuffer.wrap(data, 0, 2);
CharsetDecoder decoder = Charset.forName("UTF-8").newDecoder();
decoder.decode(decodeBuffer);

On Android <4.4, this code decodes to "O", with no exception being thrown (NOT OK!)
On Android 5+, this code raises MalformedInputException (OK).
This issue affects only older devices, however it lead to sporadic failures that are very hard to debug. Maybe disabling progressive requests on older devices would be enough; alternatively, some alternative method of decoding in ProgressiveStringDecoder might be better - current logic of trying to decode whole buffer multiple times to determine whether it's last 4 bytes are ok seems a bit redundant...

cc @dryganets

Also note that this issue is manifested only when incremental networking is enabled, e.g. when certain listeners are set on XMLHttpRequest. In our case this was due to some instrumentation library extending default XMLHttpRequest, thus incremental networking was triggered implicitly on all requests. Avoiding incremental networking provides a quick workaround...

Hi @dryganets @lexs
Ran into the same issue myself, and had to do some deep dive to find out what was wrong.
This breaks some of my network calls without giving back any indicator that the original network response has been ignored.
The regression bug can be recreated using this sample code:
var request = new XMLHttpRequest();
request.onreadystatechange = (e) => {
  if (request.readyState !== 4) {
    return;
  }
  if (request.status === 200) {
    // This returns an empty string rather than the actual response.
    console.log('success', request.responseText);
  } else {
    console.warn('error');
  }
};
request.open('GET', 'https://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-test.txt');
request.send();

Following on from the #15295 fix, it assumes the invalid byte is at the end of the input rather than somewhere in the middle.
The ProgressiveStringDecoder::decodeNext needs to catch the index of the invalid bytes and probably skip them (or apply whatever the preferred behaviour should be).
Further discussion might be needed on this.
Does anyone know the most relevant active contributor to pick this up with?

me too

@dryganets thank you, this issue makes our app useless on Android 4.4, and cherry-picking your commits on top of 0.58 stable branch fixed it (compared to unmodified 0.58.6).
Will have to use a fork until this issue is fixed by merging your changes or somehow else.
Could you please consider creating PR with these fixes?

@dryganets it would be helpful if you could send a PR for this, yeah.

@TheSavior, here you go:
https://github.com/facebook/react-native/pull/24038

@dryganets
I've created a patch from your PR, applied it to my node_modules/react-native dir and nothing changed. I'm still having troubles with truncated response. How can I check that I'm applied your PR correctly?

@megabayt,
Do you build react-native from source?
ie does your app/build.gradle has
implementation project(':ReactAndroid')
instead of
implementation 'react-native:*'


Fix for #44 promise wait for fonts

Summary

Error: runtime.ExceptionDetails: Uncaught exception at 4:47: SyntaxError: Unexpected token %

Closing issues

Fixes #44
Checklist

[ ] Have you followed the guidelines in our CONTRIBUTING guide?
[x] Have you lint your code locally prior to submission (make lint)?
[ ] Have you written new tests for your core changes, as applicable?
[x] Have you successfully ran tests with your changes locally (make tests)?
[x] Have you updated the documentation (make doc)?
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code

For me is important to receive 500 status code and error in log. To know reason of problem and be able to resolve it somehow.

I totally agree!
I'll add a form value in order to change the font loading timeout.
Thank you for your time 😄


Error when running script

I receive the following error when trying to run the install script:
At C:\FFUDevelopment\BuildFFUVM.ps1:1801 char:26

... MSWebPage = Invoke-RestMethod 'https://www.microsoft.com/en-us/downlo ...

            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-RestMethod], WebException
FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeRestMethodCommand

I worked around it by setting install office to false which is unfortunately not ideal. any assistance is appreciated!

was able to get it to work on non work device.

This is fixed in 2410.1 (which will be pushed to main later this week).
For now, you can download the 2410.1 from its branch here - https://github.com/rbalsleyMSFT/FFU/tree/2410.1

Awesome, thank you!


can we produce turbulance ?

Will you plan to make turbulance function ?
Like this?
https://i.stack.imgur.com/6h552.jpg
http://jsfiddle.net/yRD6Z/1/
https://i.stack.imgur.com/xdVLn.png

I don't actively maintain this repository - I just wanted to learn a bit about procedural content generation and released the result a small library. That said, I can try implementing the algorithm from the second link you posted if it turns out simple enough - can't give you a time estimate, though.


Update package-lock.json with webpack deps

This diff is created when I run ./bin/fmt on main right now. It includes a bunch of stuff about webpack. Was this missed in the webpack PR?

Iiiinteresting...
I wouldn't think anything was missed since I definitely ran bin/run-test (which should have installed everything / updated the package-lock.json accordingly) before merging. Not exactly sure why this would have such a diff.


Update readme.md

Replace the invalid Fly github link with npm link.

Thanks @2hu12! Sorry for the delay... I'm saving this as a reminder to fix the AppVeyor tests. They obviously shouldn't be failing.

Thanks! Sorry for the wait~!


Xcode 10, Playground crash when TensorFlow Toolchain selected

Hello, I have issue after install precompiled TensorFlow for swift
My system:

OS X 10.14 (18A391)
Xcode 10.0 (10A255)

https://storage.googleapis.com/swift-tensorflow/mac/swift-tensorflow-DEVELOPMENT-2018-10-17-a-osx.pkg - crash in Playground, in REPL this work
https://storage.googleapis.com/swift-tensorflow/mac/swift-tensorflow-DEVELOPMENT-2018-08-15-a-osx-cuda.pkg - crash in REPL (no CUDA9 work libs found)

Playground support has been unstable. The primary prototyping environment we support and recommend is Jupyter notebooks.
Could you try an older toolchain, e.g. 2018-10-05?

Playground support has been unstable. The primary prototyping environment we support and recommend is Jupyter notebooks.

Hmm, Jupyter notebook + Swift + TensorFlow/Swift ?

Not sure what you mean exactly. Our tutorials are based on Jupyter, not Xcode.

I'm going to close the issue for now. Our recommended development environment is Google Colab (see instructions), and we will not fix playground issues in the near term.


[CELEBORN-1498] Decide whether to reuse the shuffle id based on the appShuffle's numAvailableOutputs

What changes were proposed in this pull request?
Decide whether to reuse the shuffle id based on the appShuffle's numAvailableOutputs instead of deterministic level
Why are the changes needed?
In Spark, the DAGScheduler determines whether to reuse task output based on multiple factors, deterministic level is one of them, but not all. I constructed a case in the test, where a shuffleId should be regenerated instead of reused. IMO, celeborn should decide whether to reuse the shuffle id based on whether the map output is empty, which means to delegating the decision of reusing previous attempt results to the DAGScheduler.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Add a test:  org.apache.celeborn.tests.spark.CelebornFetchFailureSuite#test("celeborn spark integration test - resubmit a barrier stage and do not reuse the shuffle id")

Once #2609 is merged, is this still relevant ?

Thanks for the reminder @mridulm, seems not needed


Crash log not generated when setting NoLinkerSymbols as true

I am from the Syncfusion team. In the below release notes, you have provided the RHBIND error fix and suggestions for Syncfusion controls. Can you please share the below release notes related to follow-ups with us?
https://github.com/microsoft/dotnet/blob/master/releases/UWP/net-native2.2/README.md#uwp-6212-february-9th-2021
And also if we use this suggestion, the crash reported was not generated for the application. Can you please suggest any other workaround to resolve this problem?

UWP 6.2.12 (February 9th, 2021)
Error code RHBIND : error RHB0002: Failed to write PDB. Fix for build failures with RHBIN error when building Xamarin and SyncFusion UWP projects. This is an opt-in fix and requires customer to setting the msbuild property NoLinkerSymbols
I use SyncFusion Component in my UWP Project and for this reason is must use the NoLinkerSymbols during compilation. If i dont't use NoLinkerSymbols the store not working with error:
Submit error : L'invio non è riuscito con uno o più codici di errore 1201. More info about the error(s) can be found
Now i have need to use AppCenter for tracking the bugs of my App, but AppCenter not trace Stack if i use NoLinkerSymbols, so it is perfectly useless
how do you solve this thing? visual studio compiles correctly even without NoLinkerSymbols, but the store does not accept the app, it is possible that there are always problems with UWP.

I have the same problem can you help me please ?

hello if I can very gladly
have you already tried to use this new flag?
UWP 6.2.14 (June 13th, 2022)
true

In which property group can i add "OutOfProcPDB>true</OutOfProcPDB" ?

this is my project sample
 <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|x64'">     <Use64BitCompiler>true</Use64BitCompiler>     <OutputPath>bin\x64\Release\</OutputPath>     <DefineConstants>TRACE;NETFX_CORE;WINDOWS_UWP;CODE_ANALYSIS;DISABLE_XAML_GENERATED_MAIN</DefineConstants>     <Optimize>true</Optimize>     <NoWarn>;2008</NoWarn>     <DebugType>pdbonly</DebugType>     <PlatformTarget>x64</PlatformTarget>     <UseVSHostingProcess>false</UseVSHostingProcess>     <ErrorReport>prompt</ErrorReport>     <Prefer32Bit>false</Prefer32Bit>     <EnableGatekeeperAnalysis>false</EnableGatekeeperAnalysis>     <UseDotNetNativeToolchain>true</UseDotNetNativeToolchain>     <!--<DebugSymbols>true</DebugSymbols>-->     <SingleThreadNUTC>true</SingleThreadNUTC>     <!--<NoLinkerSymbols>true</NoLinkerSymbols>-->     <OutOfProcPDB>true</OutOfProcPDB>     <UseDotNetNativeSharedAssemblyFrameworkPackage>false</UseDotNetNativeSharedAssemblyFrameworkPackage>     <ShortcutGenericAnalysis>true</ShortcutGenericAnalysis>     <!--crea problem dal menu impostazioni dice che il membro TipoTabella Non va bene -->     <!--<DebugSymbols>false</DebugSymbols>-->     <!--<DisableStackTraceMetadata>true</DisableStackTraceMetadata>     <DisableExceptionMessages>true</DisableExceptionMessages>     <AlignMethodsAtMinimalBoundaries>true</AlignMethodsAtMinimalBoundaries>-->   </PropertyGroup>

@EliseJoffre If you are still blocked by the 1201 error in Partner Center, please follow the instructions at https://github.com/dotnet/core/blob/main/Documentation/ilcRepro.md and we will try to help.

Closing this issue as we will provide assistance through<EMAIL_ADDRESS>


fix(autolayout): ensure the layout is recalculated when nesting autolayout

GitHub Issue (If applicable): #

PR Type
What kind of change does this PR introduce?

Bugfix

What is the current behavior?

updateLayout can be call before the verticalAlignment horizantalAlignment and padding are propertly set.
Happened with xamlreader

What is the new behavior?

trigger updateLayout when verticalAlignment horizontalAlignment and padding are changed

PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tested code with current supported SDKs
[ ] Docs have been added/updated which fit documentation template. (for bug fixes / features)
[ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[ ] Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
[x] Contains NO breaking changes
[ ] Updated the Release Notes
[ ] Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

This control will need lots of runtime tests, those look like important scenarios that should not regress.


overc-system-agent: Add parameter check for send_image RestAPI

Issue: LINPUL8-609
Check URL and template for RestAPI send_image
Signed-off-by: De Huo<EMAIL_ADDRESS>

You can close this one and look at pull req #94 instead.  It has this patch plus more.

closing for jrw's pull request.


Added tests to reproduce Issue #248

This PR contains some failing tests which exhibit #248

Closing as you've fixed the issues


[AUTO-PR] Automatically generated new release 2021-03-05T19:11:36.063Z

What are you changing?

[x] Releasing a new version of Notify
[ ] Changing kubernetes configuration

Provide some background on the changes
NOTIFICATION-API
NOTIFICATION-ADMIN

added prefixes for nav views to fix missing context on 404 (#923) by dorianjp

NOTIFICATION-DOCUMENT-DOWNLOAD-API
NOTIFICATION-DOCUMENT-DOWNLOAD-FRONTEND
NOTIFICATION-DOCUMENTATION
If you are releasing a new version of notify, what components are you updating

[ ] API
[x] Admin
[ ] Document API
[ ] Document UI

Checklist if releasing new version:

[x] I made sure that both API and Admin changes are present in Notify
[x] I have checked if the docker images I am referencing exist - ex: https://gallery.ecr.aws/v6b8u5o6/notify-admin

Checklist if making changes to Kubernetes:

[x] I know how to get kubectl credentials in case it catches on fire

@dorianjp You can approve and merge this one as soon as you tested the fix in staging 👍


Handle ember-auto-import chunks

Currently, any chunk generated by ember-auto-import is ignored. I just noticed this when doing a major refactoring, swapping out an underlying dependency, and not really seeing any asset size changes from this action :sweat_smile:
This PR now also handles the chunk.xxx.yyyyyyy.js type output that ember-auto-import/webpack generates.
Of course, it is not necessarily super easy to know what exactly a certain chunk is, but imho it is still better to at least see that they exist/their size changed than to hide them completely.

@mansona any chance we can get this in? Currently any apps updating to ember-auto-import v2 (required to consume addons that are on v2) will be having misleading sizes reported

Actually this might need a small amount of work. We probably want to summarise the chunk files output, this isn't really a human-friendly output
Functionally it works great though :)

I think we could make use of collapsible markdown in github's comment
https://gist.github.com/pierrejoubert73/902cc94d79424356a8d20be2b382e1ab
Maybe have a summary line in the main diff tables that adds it all up, and a separate expandable section that has the full chunk list.

Would be nice to get this moved forward, now that ember-auto-import v2 is default in Ember v4.x.

This has been merged in #47 👍


additional feedback for mc stat examples

More improvements to mc stat examples following https://github.com/minio/docs/pull/1285
Staged:
http://<IP_ADDRESS>:9000/staging/mc-stat-example-2/linux/reference/minio-mc/mc-stat.html#examples

@djwfyi no rush, if you want to have a look


demo commit

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command
Blueprint environment

/qovery  preview 8b857aca-447c-4406-8ed5-9a7777a78171
myapp

/qovery  preview {all|UUID1,UUID2,...}
To preview multiple environments

This comment has been generated from Qovery AI :robot:.
Below, a word from its wisdom :

Help yourself at 2AM by putting some metrics to help observability

/qovery preview 8b857aca-447c-4406-8ed5-9a7777a78171

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
:point_right: [PR] myapp - demo commit - 2024-11-07T08:50:27Z
Another comment will be posted when deployments are finished

Your preview environment has been successfully deployed !
Click on the link below to open your service:
:point_right: dummy-fastify-server


msgpack-cxx: make headeronly and boost optional

I tried it and even with cmake.install and boost enabled, it's still a headeronly library, so why not use cmake?
It seems works fine.
checking for xmake::msgpack-cxx ... msgpack-cxx 6.1.1
{
  license = "BSL-1.0",
  sysincludedirs = {
    "/Users/ruki/.xmake/packages/m/msgpack-cxx/6.1.1/cdfe231ae33d45ab98e4c0c70e3894d3/include ,
  },
  version = "6.1.1"
}

patching /Users/ruki/.xmake/packages/m/msgpack-cxx/6.1.1/cdfe231ae33d45ab98e4c0c70e3894d3/lib/p
kgconfig/msgpack-cxx.pc ..
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
-c -Qunused-arguments -target x86_64-apple-macos14.0 -isysroot /Applications/Xcode.app/Contents
/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk -std=c++17 -isystem /Users/r
uki/.xmake/packages/m/msgpack-cxx/6.1.1/cdfe231ae33d45ab98e4c0c70e3894d3/include -isystem /User
s/ruki/.xmake/packages/b/boost/1.85.0/ea54d63440cc46f2befc6c2c911bdf9f/include -o /var/folders/
32/w9cz0y_14hs19lkbs6v6_fm80000gn/T/.xmake501/240714/_21CB8C8128B444108E63739F6CA44830.o /var/f
olders/32/w9cz0y_14hs19lkbs6v6_fm80000gn/T/.xmake501/240714/_407F0AF53F7C47FD94352FD56BBEED07.c
pp
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang+
+ -o /var/folders/32/w9cz0y_14hs19lkbs6v6_fm80000gn/T/.xmake501/240714/_21CB8C8128B444108E63739
F6CA44830.b /var/folders/32/w9cz0y_14hs19lkbs6v6_fm80000gn/T/.xmake501/240714/_21CB8C8128B44410
8E63739F6CA44830.o -target x86_64-apple-macos14.0 -isysroot /Applications/Xcode.app/Contents/De
veloper/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk -lz -L/Users/ruki/.xmake/packag
es/b/boost/1.85.0/ea54d63440cc46f2befc6c2c911bdf9f/lib -lboost_atomic-mt -lboost_filesystem-mt
> checking for c++ includes(msgpack.hpp)
> checking for c++ links(boost_atomic-mt, boost_filesystem-mt)
> checking for c++ snippet(            #inc)
  => install msgpack-cxx 6.1.1 .. ok


RAG ingestion and chat pipelines

Introducing ilab commands changes to support the RAG ingestion and chat pipelines:

RAG ingestion: a new command that starts from pre-processed user docs (see https://github.com/instructlab/dev-docs/pull/148) to ingest the calculated embeddings in a configurable vector DB.
RAG chat: augment the context of the chat command with the result of a similarity search executed on the ingested database, to increase the accuracy of the response.

I think that the chat / options probably deserve some discussion and also look like they may not be a priority, but, other than that, this looks reasonable to me.

@jwm4

This document is a good start, but needs a lot more input from a lot of stakeholders

I think I need to clarify my position when I commented with a general "looks good to me" - I think that you raise some very valid points, but also I am operating under the assumption that this document serves as a proposal for "directionally where to head right now" and that any less-than-high-level details can, will, and probably should change as we understand the problem domain better during execution. I think that a useful modus operandi is to get a few key stakeholders to give a general approval and that that is enough to get started, and then have continuous feedback cycles all the time going forward to course correct as necessary. Analysis paralysis is a real effect that is best avoided.
Not trying to beat a dead horse but this is partly why I keep advocating for atomic decision records like ADRs over all-encompassing design docs like this. A general development roadmap is a necessary thing to have, but nobody will ever have enough information to design a full system specification, especially in the context of a marketplace and a large development organization. The only constant is change.

I will soon publish an updated version with the outcome of the discussion with the ilab Runtime (aka CLI) team.

@cdoern Could you please TAL and involve relevant people?

There are many design decisions being made here that appear to be in a bit of a vacuum and so increase complexity of product usage and configuration while there are opportunities to streamline it instead.
@jwm4 I think we need to dedicate a significant effort to work through these as a group.

@bbrowning

a custom Pipeline Block implementation or two

What would the purpose of indexing generated data be?

@bbrowning

a custom Pipeline Block implementation or two

What would the purpose of indexing generated data be?

I don't mean indexing generated data - I mean using our pipelines concept to run a RAG pipeline that generates embeddings, populates a vector db, whatever you need - as opposed to calling an LLM for inference and data generation. Pipelines take an input dataset, have a sequences of Blocks that get executed in step, with the first block getting each input sample as input, it transforms those samples in some way, outputs samples, and the next block gets those new samples as its input. Today we mostly use this for transforming data in datasets, building prompts and calling LLMs for inference, but you could also use this concept to tokenize text and insert into a vector db. A RAG pipeline just becomes another set of pipelines shipped with the product versus code custom and specific to the RAG use-case, other than perhaps some RAG-specific Blocks we'd like to ship in the product itself.
It may be hard to understand how this all works without understanding the code of SDG including the upcoming changes to it, but we should at least try to use the designed SDG extension points of custom Blocks for part of this I think.

@jwm4 @anastasds integrated changes from yesterday's meeting. Should we move it from Draft to Ready?

@jwm4 @anastasds I added a "User Experience Overview" section with diagrams to clarify the workflows we discussed in the last review meeting. Please share your feedback
FYI, @ilan_pinto

FYI, @jwm4 @anastasds I added a "Design Considerations" section to outline key design requirements.


TypeError: a bytes-like object is required, not 'str'

Crash Report
This crash report was reported through the automatic crash reporting system 🤖
Traceback
  File "/home/mariano/.local/bin/Electron Cash-3.2/lib/util.py", line 613, in run_with_except_hook
    run_original(*args2, **kwargs2)
  File "/home/mariano/.local/bin/Electron Cash-3.2/lib/network.py", line 960, in run
    self.wait_on_sockets()
  File "/home/mariano/.local/bin/Electron Cash-3.2/lib/network.py", line 927, in wait_on_sockets
    self.process_responses(interface)
  File "/home/mariano/.local/bin/Electron Cash-3.2/lib/network.py", line 615, in process_responses
    self.process_response(interface, response, callbacks)
  File "/home/mariano/.local/bin/Electron Cash-3.2/lib/network.py", line 561, in process_response
    self.on_get_header(interface, response)
  File "/home/mariano/.local/bin/Electron Cash-3.2/lib/network.py", line 837, in on_get_header
    branch.write('', 0)
  File "/home/mariano/.local/bin/Electron Cash-3.2/lib/blockchain.py", line 275, in write
    f.write(data)

TypeError: a bytes-like object is required, not 'str'

Reporter
This issue was reported by 1 user(s):

Electrum Version
Operating System
Wallet Type
Locale

3.2
Linux-4.15.0-20-generic-x86_64-with-Ubuntu-18.04-bionic
standard
en_US

Additional Information
The reporting user(s) did not provide additional information.

Fixed and I leave a comment like a cat sprays to leave it's mark, so I know this one is done.


images and jackrabbit auth

OK we have a problem.
JR has auth so images do not get loaded in the catalogue.
Any idea is wellcome apart from removing auth to JR
@guidospadotto-profesia also for you this one.
Shall we think about final deployment?
Could we have a rest that does a proxy to JR?
an API we call in the image source and in the java API we execute the get of the image to JR and return the image type?
If agree open an issue or work on this one

Well, files are indeed saved in JackRabbit, the problem is retrieving them once you have the URL.
There is a eu.cloudopting.store.StoreService.getDocumentAsStream(String) method that MIGHT do what you are asking and that was originally pushed by @ciprianpavel .

The default Repository.login() method starts a repository session using the default workspace and no user credentials. Jackrabbit tries to use the Java Authentication and Authorization Service (JAAS) configuration in such cases, but defaults to the anonymous user if a JAAS Subject is not found.

(Source: http://jackrabbit.apache.org/jcr/first-hops.html )
Someone with expertise in Spring/Spring Boot should tell us if it is possible to "propagate" JAAS credentials to JackRabbit.

I would go for an easier approach:
UI call API -> API call HTTP JR -> outstream of second become request answer of first, very straightforward.
Or get stream.
In any case we agree we need an API to do proxy so let us create it so we can remove errors in UI.
Guido create the API in the rest_component.
Create a dedicated controller call it ImageController, than Xavi will call that API in the catalogue.
Once you create the API that return a fixed image, you start working on proxying to JR while @xeviscc integrate it in UI

If you use the existing methods you should manage to get the file from JR without having problems or if you need the credentials you just get them from the properties either way you are good to go.
Better not mess with that part now

Fixed in commit 07f0d94
Check JcrImageResource.java
To get a JR image you will have to send a GET HTTP Request to "/jr/img" with the ABSOLUTE JackRabbit Path in the "jcrPath" Request Parameter.


Travis-ci integration

Add simple .travis.yml configuration for travis-ci
Add bin/report_results.py that allows simple summary report and proper error code return for travis
At the moment there are 6 skipped test. Should they be treated as failed?

Thanks for this - I'll enable Travis on the main repo.
It's valid to skip tests - for example some tests are skipped based on the language or simulator, some tests are temporarily disabled.


Generalize ocidir, dynamically generate containers

Currently we have a hardcoded "exampleos.tar" fixture, as well as
two .ociarchive containers that also hardcode its content.
Having pre-generated container fixtures on one hand is good because
we're testing compatibility of import from a frozen format.  But it also
means that we can't easily test changing our output format.
And I'd like to introduce some changes to the output format.  I'll
reintroduce compat testing another way.
To accomplish this, rework our internal ociwriter to be a generalized
ocidir module that also supports reading (and modifying) an existing
directory.
The export/encapsulation code uses this.
Then, add a helper method that is only exposed to our integration
testing suite which uses this to generate a derived image dynamically.

Draft since this depends on https://github.com/containers/oci-spec-rs/pull/85

OK, latest oci-spec is released and we're now using the crate version again; this should be good to go.

Rebased :surf

time to rebase again :) and looks like the linter is not happy.

Hmm actually it may be better if this one waits till the next release, it's not critical.


update example to 2.0-BETA8 and maven plugin

any update on this?

Already merged to master

@baev : after serving the report, while viewing after a certain amount of time it fails. Report generation is unstable. Trend line is not showing up as well.

History feature is only supported in ci environment (using Allure Jenkins/Teamcity/Bamboo plugins)
Can you provide more details on fails?