YARN-11469. Refactor FederationStateStoreFacade Cache Code.

JIRA: YARN-11469. Refactor FederationStateStoreFacade Cache Code.
The Cache of FederationStateStoreFacade uses JCache, but considering that JCache is not a general Cache implementation (the latest version was released in 2014), this part of the code is refactored to support multiple Cache in the future.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 51s

trunk passed

+1 :green_heart:
compile
0m 43s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 41s

trunk passed

+1 :green_heart:
javadoc
0m 43s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 35s

trunk passed

+1 :green_heart:
shadedclient
24m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

-1 :x:
javac
0m 36s
/results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 2 new + 57 unchanged - 0 fixed = 59 total (was 57)

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

-1 :x:
javac
0m 31s
/results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 generated 2 new + 54 unchanged - 0 fixed = 56 total (was 54)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 16s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 23 new + 0 unchanged - 10 fixed = 23 total (was 10)

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

-1 :x:
spotbugs
1m 30s
/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.html
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
23m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 55s

hadoop-yarn-server-common in the patch passed.

-1 :x:
asflicense
0m 33s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

106m 48s

Reason
Tests

SpotBugs
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Should org.apache.hadoop.yarn.server.federation.cache.FederationJCache$CacheRequest be a static inner class?  At FederationJCache.java:inner class?  At FederationJCache.java:[lines 124-162]

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5570

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 27e59105b2bb 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3a637411f67c443a913380cfe970de1391077a76

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/1/testReport/

Max. process+thread count
533 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
0m 10s
/branch-mvninstall-root.txt
root in trunk failed.

-1 :x:
compile
0m 10s
/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-yarn-server-common in trunk failed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.

-1 :x:
compile
0m  9s
/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt
hadoop-yarn-server-common in trunk failed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.

-0 :warning:
checkstyle
0m  8s
/buildtool-branch-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
The patch fails to run checkstyle in hadoop-yarn-server-common

-1 :x:
mvnsite
0m  9s
/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-server-common in trunk failed.

-1 :x:
javadoc
0m 10s
/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-yarn-server-common in trunk failed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.

-1 :x:
javadoc
0m 10s
/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt
hadoop-yarn-server-common in trunk failed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.

-1 :x:
spotbugs
0m 10s
/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-server-common in trunk failed.

-1 :x:
shadedclient
1m  9s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m  9s
/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-server-common in the patch failed.

-1 :x:
compile
0m 10s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-yarn-server-common in the patch failed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.

-1 :x:
javac
0m 10s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-yarn-server-common in the patch failed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.

-1 :x:
compile
0m 10s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt
hadoop-yarn-server-common in the patch failed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.

-1 :x:
javac
0m 10s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt
hadoop-yarn-server-common in the patch failed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m  7s
/buildtool-patch-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
The patch fails to run checkstyle in hadoop-yarn-server-common

-1 :x:
mvnsite
0m 10s
/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-server-common in the patch failed.

-1 :x:
javadoc
0m  9s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-yarn-server-common in the patch failed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.

-1 :x:
javadoc
0m 10s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt
hadoop-yarn-server-common in the patch failed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.

-1 :x:
spotbugs
0m 10s
/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-server-common in the patch failed.

-1 :x:
shadedclient
1m 47s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 10s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-server-common in the patch failed.

+0 :ok:
asflicense
0m 11s

ASF License check generated no output?

7m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5570

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d5b8f133ac1d 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e63c6519facf016e27afa6f45227966be4a4cae2

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/2/testReport/

Max. process+thread count
42 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/2/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 13s

trunk passed

+1 :green_heart:
compile
0m 41s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 42s

trunk passed

+1 :green_heart:
javadoc
0m 43s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 38s

trunk passed

+1 :green_heart:
shadedclient
23m 32s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

-1 :x:
javac
0m 36s
/results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 2 new + 57 unchanged - 0 fixed = 59 total (was 57)

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

-1 :x:
javac
0m 31s
/results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 generated 2 new + 54 unchanged - 0 fixed = 56 total (was 54)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 16s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 34 new + 0 unchanged - 10 fixed = 34 total (was 10)

+1 :green_heart:
mvnsite
0m 32s

the patch passed

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

-1 :x:
spotbugs
1m 31s
/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.html
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
shadedclient
23m 56s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 34s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

105m 14s

Reason
Tests

SpotBugs
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Equals method for org.apache.hadoop.yarn.server.federation.cache.FederationJCache$CacheRequest assumes the argument is of type FederationJCache$CacheRequest  At FederationJCache.java:the argument is of type FederationJCache$CacheRequest  At FederationJCache.java:[line 159]

org.apache.hadoop.yarn.server.federation.cache.FederationJCache$CacheRequest.equals(Object) does not check for null argument  At FederationJCache.java:null argument  At FederationJCache.java:[lines 159-160]

Should org.apache.hadoop.yarn.server.federation.cache.FederationJCache$CacheRequest be a static inner class?  At FederationJCache.java:inner class?  At FederationJCache.java:[lines 142-162]

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5570

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 90a7d3a224f8 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e63c6519facf016e27afa6f45227966be4a4cae2

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/3/testReport/

Max. process+thread count
531 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 44s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 29s

trunk passed

+1 :green_heart:
mvnsite
0m 42s

trunk passed

+1 :green_heart:
javadoc
0m 46s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 40s

trunk passed

+1 :green_heart:
shadedclient
24m 44s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s

the patch passed

+1 :green_heart:
compile
0m 42s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 42s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 17s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 34 new + 0 unchanged - 10 fixed = 34 total (was 10)

+1 :green_heart:
mvnsite
0m 35s

the patch passed

+1 :green_heart:
javadoc
0m 32s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

-1 :x:
spotbugs
1m 43s
/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.html
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
shadedclient
25m 21s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 17s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

109m 57s

Reason
Tests

SpotBugs
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Equals method for org.apache.hadoop.yarn.server.federation.cache.FederationJCache$CacheRequest assumes the argument is of type FederationJCache$CacheRequest  At FederationJCache.java:the argument is of type FederationJCache$CacheRequest  At FederationJCache.java:[line 159]

org.apache.hadoop.yarn.server.federation.cache.FederationJCache$CacheRequest.equals(Object) does not check for null argument  At FederationJCache.java:null argument  At FederationJCache.java:[lines 159-160]

Should org.apache.hadoop.yarn.server.federation.cache.FederationJCache$CacheRequest be a static inner class?  At FederationJCache.java:inner class?  At FederationJCache.java:[lines 142-162]

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5570

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c95c4e6a0fbc 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0b50549e38cb946d746fa49a4713838ba054b9aa

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/4/testReport/

Max. process+thread count
530 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Thank you very much for helping to review the code! I am currently refactoring a cache implementation to support additional cache implementations in the future. To aid me in this process, I have referred to The Ehcache 3.x JSR-107 Provider documentation, specifically version 3.10, as a resource. The goal is to improve the code and make it more extensible for future updates.
Can you help review the code again? Thank you very much!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 10s

trunk passed

+1 :green_heart:
compile
0m 52s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 43s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 37s

trunk passed

+1 :green_heart:
mvnsite
0m 51s

trunk passed

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 43s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 55s

trunk passed

+1 :green_heart:
shadedclient
24m 24s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 38s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 38s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 30s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 16s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 20 new + 0 unchanged - 10 fixed = 20 total (was 10)

+1 :green_heart:
mvnsite
0m 35s

the patch passed

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 29s

the patch passed

+1 :green_heart:
shadedclient
24m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 24s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

108m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5570

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 353b38ae414d 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ae55d8571c550c51ef96e7749ddaeac55228e56e

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/5/testReport/

Max. process+thread count
529 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m  0s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 41s

trunk passed

+1 :green_heart:
javadoc
0m 43s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 37s

trunk passed

+1 :green_heart:
shadedclient
24m  0s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 31s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 16s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 18 new + 0 unchanged - 10 fixed = 18 total (was 10)

+1 :green_heart:
mvnsite
0m 32s

the patch passed

+1 :green_heart:
javadoc
0m 28s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 27s

the patch passed

+1 :green_heart:
shadedclient
24m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  3s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

106m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5570

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d1bf24162fc4 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1961484e9a1663b28e71b1c1904c4d882e38629a

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/6/testReport/

Max. process+thread count
530 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 52s

trunk passed

+1 :green_heart:
compile
0m 43s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 41s

trunk passed

+1 :green_heart:
javadoc
0m 43s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 37s

trunk passed

+1 :green_heart:
shadedclient
23m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 16s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 18 new + 0 unchanged - 10 fixed = 18 total (was 10)

+1 :green_heart:
mvnsite
0m 32s

the patch passed

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 28s

the patch passed

+1 :green_heart:
shadedclient
23m 45s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  4s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

104m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5570

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 7ad38a3733d1 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9371e1e276c86d3887c9791c0e867118000a4966

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/7/testReport/

Max. process+thread count
613 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 57s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 29s

trunk passed

+1 :green_heart:
mvnsite
0m 41s

trunk passed

+1 :green_heart:
javadoc
0m 44s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 37s

trunk passed

+1 :green_heart:
shadedclient
24m 11s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 16s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 13 new + 0 unchanged - 10 fixed = 13 total (was 10)

+1 :green_heart:
mvnsite
0m 34s

the patch passed

+1 :green_heart:
javadoc
0m 28s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 30s

the patch passed

+1 :green_heart:
shadedclient
23m 47s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  2s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

106m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5570

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 80e367f73ea1 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk /<PHONE_NUMBER>fa3e7d95d6e2181d65e9030a24326a

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/8/testReport/

Max. process+thread count
531 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  6s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 25s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 42s

trunk passed

+1 :green_heart:
javadoc
0m 43s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 37s

trunk passed

+1 :green_heart:
shadedclient
24m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 16s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 1 new + 0 unchanged - 10 fixed = 1 total (was 10)

+1 :green_heart:
mvnsite
0m 32s

the patch passed

+1 :green_heart:
javadoc
0m 28s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 26s

the patch passed

+1 :green_heart:
shadedclient
23m 44s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  4s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

106m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5570

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 78e1fdf321e7 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / be17111ed00a3856abda9b3982a90c9b8c782278

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/10/testReport/

Max. process+thread count
536 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
patch
2m 30s

https://github.com/apache/hadoop/pull/5570 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem
Report/Notes

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/11/console

versions
git=2.17.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 58s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 29s

trunk passed

+1 :green_heart:
mvnsite
0m 41s

trunk passed

+1 :green_heart:
javadoc
0m 44s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 39s

trunk passed

+1 :green_heart:
shadedclient
24m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 16s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 0 new + 0 unchanged - 10 fixed = 0 total (was 10)

+1 :green_heart:
mvnsite
0m 34s

the patch passed

+1 :green_heart:
javadoc
0m 28s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 27s

the patch passed

+1 :green_heart:
shadedclient
24m  4s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  3s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

105m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5570

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 15caffddd6fb 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 529419af0f5d067f528d43105084ed5f96489709

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/12/testReport/

Max. process+thread count
600 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/12/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 51s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 29s

trunk passed

+1 :green_heart:
mvnsite
0m 42s

trunk passed

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 36s

trunk passed

+1 :green_heart:
shadedclient
23m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 16s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 0 new + 0 unchanged - 10 fixed = 0 total (was 10)

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
javadoc
0m 28s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 27s

the patch passed

+1 :green_heart:
shadedclient
23m 42s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  5s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

105m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/13/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5570

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 82adf7154d3b 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8cd7a382377a1a9a79095dc660cb6235f249f045

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/13/testReport/

Max. process+thread count
530 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5570/13/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Thank you very much for helping to review the code!

I want to implement a new cache replacement algorithm in hdfs but I don't know which part of module to use and modify. Can any one please help me find the modules and functions which need to override to add my own caching replacement algorithm in hdfs


Enabled configuration for loosely match responses

Hi RobWin,
This PR is about enabling a configuration validateResponseWithStrictlyMatch to allow loosely match for actual swagger response to expected swagger response.
The reason I added this is, I am working on a project which migrates an old API to a new one. We need  all the old API compatible with new API (subset of the new one).
Could you please accept this PR. Thanks.

Coverage increased (+0.7%) to 90.154% when pulling 311a36aafd01cca41dfc8c84fa3994e72a43e01b on zacyang:master into ba1594c73717efdce9548359eb6f19beb1512eb3 on RobWin:master.


Demo

From @tonystar on June 22, 2015 10:29
Copied from original issue: highweb/bootstrap-hover-tabs#3

https://jsfiddle.net/tonystar/cyrLqjj6/


3D support in lighnting

Hi Team,
I would like to know if z-axis property can be brought in to a lightning component, without using any external library such as three.js .

Hi @TheCodeBeginner, what is exactly you want to achieve?

Can we close this ticket?

Yeah, I guess we're not getting an answer. @TheCodeBeginner, please reopen if it's still relevant.


Uncaught TypeError: this.tip(...).find is not a function

Follow the quick start, i'd like to try the x-editable with jquery-ui build.
There is no problem in inline mode, but raise an exception when the mode is popup mode.
I find a closed issue https://github.com/vitalets/x-editable/issues/687
What's the problem? How can i resolve it?
jqueryui-editable.min.js:6 Uncaught TypeError: this.tip(...).find is not a function
    at b.innerShow (jqueryui-editable.min.js:6)
    at b.show (jqueryui-editable.min.js:5)
    at b.show (jqueryui-editable.min.js:5)
    at b.toggle (jqueryui-editable.min.js:5)
    at b.<anonymous> (jqueryui-editable.min.js:5)
    at HTMLAnchorElement.e (jquery-3.2.1.min.js:2)
    at HTMLAnchorElement.dispatch (jquery-3.2.1.min.js:3)
    at HTMLAnchorElement.q.handle (jquery-3.2.1.min.js:3)

X-editable Version:  v1.5.1
Jquery-UI: v1.12.1
Jquery: 3.2.1
Google Chrome Version 59.0.3071.115 (Official Build) (64-bit)

@Hoohaha This plugin isn't working with the latest version of jQuery UI v1.12.1.   I used v1.10.0 and was able to get popups to work.

thi isn't still updated. fail

Is this issue resolved?


Actually check logical devices in Nagios plugin

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Remove PPromise usage from task world

@dbaeumer This was actually pretty easy.
Related to #53487, #53526

LGTM. Feel free to merge in at our convenience.
And thanks for doing this.


add Premium_ChinaCdn support to cdn specification 2017-10-12

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-js

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-java

Automation for azure-sdk-for-go

Automation for azure-sdk-for-net
A PR has been created for you:
https://github.com/azure/azure-sdk-for-net/pull/5659
.NET SDK Commits:
https://github.com/adxsdknet/azure-sdk-for-net/pull/5659/commits/4365bf9a315ec35254f64b2960b14a0b60bb1f8c

Can one of the admins verify this patch?


Add a note in README since the Appearance API is officially supported

Since the Appearance API is officially supported by React Native, maybe we should warn people who develop bare React projects to use the official API?

https://github.com/expo/react-native-appearance/commit/3340d85df16edf05c45f7880b9a9cc4647cb351b


perftesttool support nnapi options

Description: Describe your changes.
Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.

I will change some code latter, merge first


empty Form data is getting submitted

Description
In the contact us page form data is getting submitted even if we only add spaces in the input fields.
Video
https://user-images.githubusercontent.com/68184118/232468627-5d395467-af72-41e0-badf-ecdf63ed5c86.mp4
I would love to work on this issue
Screenshots
No response
Additional information
No response

Hi,
Can I work on this issue?
Thanks,
Kunal


[cpr] update to <1.10.0>

Library name:cpr
New version number:1.10.0
Other information that may be useful (release notes, etc...)
https://github.com/libcpr/cpr

It is already included

Hi,
When I use vcpkg on windows 10 , none x64 files are generated. Only x86. Have you got an idea ?
I did on Command prompt
git clone https://github.com/Microsoft/vcpkg.git cd vcpkg bootstrap-vcpkg.sh vcpkg integrate install vcpkg install cpr

vcpkg install cpr:x64-windows

Fixed by #30747.


[REQUEST] Selenium Wait(Sleep) Action

Hi,
Please add Wait (Timeout/Sleep) Action to "Selenium Element" Actions
not waiting for specially element, just wait/sleep for seconds
ty

Can we use custom waitforelement time is yes them how?


documentation issue

should add
cd FedTree

between git clone and submodule init in https://fedtree.readthedocs.io/en/latest/Installation.html#clone-install-submodules

and SHARED=on mentioned in https://github.com/Xtra-Computing/FedTree/issues/44 is not shown in documentation either.

Hi @lidh15 ,
Thanks a lot! I have updated the docs.


Not compatible with Nominatim JSON

Hi,
thank you for the docker build. I tried to use it with ol-ext library as drop in replacement for Nominatim, and found out it is not 100% compatible. The JSON provided by your search and Nominatim API is not the same, and it causes troubles (at least the data structure is different). Is this a "feature", or the API did change during time and the python script in this docker doesn't reflect it (yet?). I also noticed there are not the the POLYGON boundaries of the city, that ol-ext uses to highlight the searched city. Am I looking wrong?
Thanks

Only the response fields lat', lon, display_name, type, class are in the same position. (Nominatim's format=jsonv2 returns category instad of class).  boundingbox` orders the coordinates in the list different. That has been from osmnames's first release. I don't think 100% compatibility was a goal of the project.

Only the response fields lat', lon, display_name, type, class are in the same position. (Nominatim's format=jsonv2 returns category instad of class).  boundingbox` orders the coordinates in the list different. That has been from osmnames's first release. I don't think 100% compatibility was a goal of the project.


Frontend part merge to master

NB:
Lot of commits because https://github.com/electron-react-boilerplate/electron-react-boilerplate transormed from submodule to code part
Improvements:

Removed submodule, frontend now is in Repository
Added minor frontend improvements lexa2hk
Added WebSecurityConfig.java to track CORS
(com.example.Encrypted_storage_with_face_recognition.Security.Config.WebSecurityConfig)
Added WebController isKeystoreExist endpoint
(com.example.Encrypted_storage_with_face_recognition.Controller.WebController)
Refactored KeyStoreCreator.java to KeyStoreService.java
(com.example.Encrypted_storage_with_face_recognition.Model.Modules.File.Create.KeyStore.KeyStoreService)
initialize Controller + React/Eelectron frontend project folder
initialize Controller + React/Eelectron frontend

GreatJob Lexa2hk!


Add ds4_driver:0.1.0 to 'kinetic/distribution.yaml'

Repository: https://github.com/naoki-mizuno/ds4_ros
ROS Wiki: http://wiki.ros.org/ds4_ros

@tfoote I renamed the package name. If you want the branch name also renamed I'll close this PR and open up another one.

Branch names are up to your development preference. Thanks for renaming it quickly.

Thank you for merging!


Ionic v1 angularJS, How to display a value based on max and min from a json array

Hello, everyone, im developing a mobile banking application using ioniv v1. I hav a form for making a withdraw.I want when the user enter any amount, it display automaticaly in the html view, the cost for this amount.
my json object look like this:
$scope.rateWithdraw = [
{min: 0.10, max: 5, transtype: 'WITHDRAW', value: 0.60, currency: 'USD', comment: 'class1'},
{min: 5.01, max: 10, transtype: 'WITHDRAW', value: 0.65, currency: 'USD', comment: 'class2'},
{min: 10.01, max: 20, transtype: 'WITHDRAW', value: 0.70, currency: 'USD', comment: 'class3'},
{min: 20.01, max: 50, transtype: 'WITHDRAW', value: 0.75, currency: 'USD', comment: 'class4'},
{min: 50.01, max:  100, transtype: 'WITHDRAW', value: 1.25, currency: 'USD', comment: 'class5'},
{min: 100.01, max: 200, transtype: 'WITHDRAW', value: 2, currency: 'USD', comment: 'class6'},
{min: 200.01, max: 300, transtype: 'WITHDRAW', value: 3, currency: 'USD', comment: 'class7'},
{min: 300.01, max: 400, transtype: 'WITHDRAW', value: 4, currency: 'USD', comment: 'class8'},
{min: 400.01, max: 1000, transtype: 'WITHDRAW', value: 5, currency: 'USD', comment: 'class9'}
];
Example, if the user type in the form an amount which is equal to 24$, the application must located in which interval, the amount is located (In occurence min: 20.01, max: 50) and display the cost for it (in occurence, value: 0.75$). Help me please, because im a beginer in ionic and angularJS

Hello @coolbeatz71
This isn't really the place to be asking JS questions like these. You're better off asking in a place like stackoverflow.
But since you asked, you need to use a for-loop to iterate over your JSON objects in the array and figure out what the appropriate object is.


Change composer to be the require command and add commands section

Using the composer require command is the best practices way to add a dependency to your project.
The commands section should hopefully help prompt more plugin authors to document their commands as most at the moment you have to guess or look at the source code for details.

Thanks for the contribution!


Enhanced scroll back button with timeline on it for smoother functioning.

Enhanced scroll back button with timeline on it for smoother functioning.

Please do that in each page's Scroll-to-top button.

@aslams2020 Okay

@aslams2020 Done


npm test does not run .test.ask test files

How to reproduce:

Open a *.test.ask file, e.g. src/askscript/tests/00-documentation-examples/documentation01-complete_example.test.ask
Write an untrue expect().toBe() statement, e.g.: expect(2 + 2):toBe(5)
Run npm test.

Expected: npm test fails with an error.
Actual: npm test succeeds with no error.
Note that also running npm test src/askscript/__tests__/00-documentation-examples/documentation01-complete_example.test.ask succeeds with a 'todo' mark:
PASS   test  src/askscript/tests/00-documentation-examples/documentation01-complete_example.test.ask
✓ starts
✓ compiles
✎ todo computes

Closing as a duplicate of https://github.com/xFAANG/askql/issues/154


dracula/psychopy

New Theme
Hey Guys,
I've created a theme for PsychoPy.
I would be happy if you publish it
https://github.com/alexchaichan/psychopy
Best regards
Alex

Hey, very cool! ✨
I just sent you an invitation to join the organization.
I also cloned your repository for Dracula's organization, so you can go ahead and delete or archive yours:

Your repository.
New repository.

Thanks for building this! 🎉

It's finally live: https://draculatheme.com/psychopy
Thanks @alexchaichan!

Nice, thanks you guys aswell for posting.
Love the icon !


Some issues

Hi!
Good initiative!
I just tried using this and found a few issues so I thought I'd let you know.
The code which is shown here doesn't seem to be right, compared to other storybook examples

Apart from that, the code is partly unreadable without selecting it

This is how I described the issue (putting this here in case its my configuration that is wrong)

Also, if I try to change a prop via the control, the component doesn't change/update

That's it for now! Thanks

thanks for the feedback! I found the same issue and apparently knob-addon is totally broke 😢
will investigate this weekend 😄


[Macros] Implement unqualified lookup for global macro-expanded peer declarations.

This change adds MacroDecl::getIntroducedNames, which populates the given vector with a list of names introduced by the macro decl. This list of macro-covered names is used in unqualified lookup to lazily expand declarations with attached macros covering a requested name. This can also be used later for name validation of attached macros.
Resolves: rdar://104345950

@swift-ci please smoke test

@swift-ci please smoke test


Different styles per language

Hi,
My store is loading different Woocommerce styles per laguage. It can be seen here:
http://on-timeshop.com/es/product-category/rolex-es/
If you change the language you'll see a different button on the product.
Can you help me to call to the correct css?
Thanks a lot,
Diego

Check Polylang API
pll_current_language
Returns the current language
Usage:
pll_current_language($value);

‘$value’ => (optional) either ‘name’ or ‘locale’ or ‘slug’, defaults to ‘slug’

returns either the full name, or the WordPress locale (just as the WordPress core function ‘get_locale’ or the slug ( 2-letters code) of the current language.


adding merging code

Hm... Can you change your PR? There's code already for merging. See https://github.com/leekgroup/recount-website/blob/master/rse/rse_sra/merge_all.R
I think that your new file should assume /dcl01/leek/data/recountwebsite/rse/rse_sra/all/rse_gene.Rdata exists already


safari support

it's not work when i import the apapter.js

Because safari do not support webrtc, I suppose.

Update: i think it should be working in LATEST safari, as it is enables webrtc


controls: push Resume blocking down to car port

Description
Move the resume block from #25402 down into the GM car port, so that other car ports can use Resume for first engagement.
Verification
In progress.
Route
Route: TBD

I remember the reason being that this was a feature we wanted to enforce across the cars + it would be too much code to support in GM's interface, but this seems simpler than I thought.
I didn't see any thing about the set speed state machine behavior in 15622:2018, only for ACC. Any thoughts @adeebshihadeh

Sorry for spamming this PR, I didn’t realise I was doing it.
I would really love to see this merged!
@adeebshihadeh what do you think?

In earlier conversations with the openpilot team, I believe they were open to discussing it. It's in Draft right now because there's a process replay diff with GM, possibly due to different rising/falling edge behavior. If there's going to be a process replay diff, it needs to be fully explained (which I can't yet) and it needs to be tested on a GM car (which I haven't asked anyone to do yet).

I remember the reason being that this was a feature we wanted to enforce consistency across the cars + it would be too much code to support in GM's interface, but this seems simpler than I thought.
I didn't see any thing about the set speed state machine behavior in ISO 15622:2018, only for ACC. Any preference on this @adeebshihadeh?
In all our cars here, I don't think I've driven one that let's you press the resume button before setting a speed (besides HKG main button), that's probably good to match, unless there's cars that don't do this.

Don't have a strong preference here, aside from generally matching the stock behavior to prevent confusion.

@jyoung8607 are you aware of any stock ACC system that allows you to press the resume/+ button on first engage?

@jyoung8607 are you aware of any stock ACC system that allows you to press the resume/+ button on first engage?

Volkswagen. It's the way I (and many others) use openpilot with stock ACC. The current behavior is a hard POLA violation.
Can't speak for other cars. If you'd like this PR to support it on a whitelist basis only, that would be reasonable.

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.
PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.


Unable to fetch replies

May be the Twitter conversation html have been updated. And the preg_match_all pattern could not match the replies.
|<a href=\"(/[^/]*/status/[0-9]*)\" class=\"tweet-timestamp js-permalink js-nav js-tooltip\"|U

May be the Twitter conversation html have been updated. And the preg_match_all pattern could not match the replies.
|<a href=\"(/[^/]*/status/[0-9]*)\" class=\"tweet-timestamp js-permalink js-nav js-tooltip\"|U

Hi,
Did you mange to find a solution? I was using the scraper before and it was working fine but now is not working for me since Twitter released their new API.

I'm afraid I haven't got around to updating the code to work with the
latest changes made by Twitter. The HTML structure might have changed, and
lately Twitter is also hiding some tweets, which would need adapting the
code.
On Sun, 8 Nov 2020 at 13:56, Fatima Haouari<EMAIL_ADDRESS>wrote:

May be the Twitter conversation html have been updated. And the
preg_match_all pattern could not match the replies.
|<a href="(/[^/]/status/[0-9])" class="tweet-timestamp js-permalink
js-nav js-tooltip"|U
Hi,
Did you mange to find a solution? I was using the scraper before and it
was working fine but now is not working for me since Twitter released their
new API.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/azubiaga/pheme-twitter-conversation-collection/issues/2#issuecomment-723580621,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABUD7PUYZ3ZIKQOP7QB6FMDSO2PPHANCNFSM4Q2RYFJQ
.

May be the Twitter conversation html have been updated. And the preg_match_all pattern could not match the replies.
|<a href=\"(/[^/]*/status/[0-9]*)\" class=\"tweet-timestamp js-permalink js-nav js-tooltip\"|U

Hi, Did you mange to find a solution? I was using the scraper before and it was working fine but now is not working for me since Twitter released their new API.

Anyone have a solution yet? If yes, can I have the file please?

I'm afraid I haven't got around to updating the code to work with the latest changes made by Twitter. The HTML structure might have changed, and lately Twitter is also hiding some tweets, which would need adapting the code.
…
On Sun, 8 Nov 2020 at 13:56, Fatima Haouari @.*> wrote: May be the Twitter conversation html have been updated. And the preg_match_all pattern could not match the replies. |<a href="(/[^/]/status/[0-9])" class="tweet-timestamp js-permalink js-nav js-tooltip"|U Hi, Did you mange to find a solution? I was using the scraper before and it was working fine but now is not working for me since Twitter released their new API. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUD7PUYZ3ZIKQOP7QB6FMDSO2PPHANCNFSM4Q2RYFJQ .

Anyone have a solution yet? If yes, can I have the file please?

May be the Twitter conversation html have been updated. And the preg_match_all pattern could not match the replies.
|<a href=\"(/[^/]*/status/[0-9]*)\" class=\"tweet-timestamp js-permalink js-nav js-tooltip\"|U

Hi, Did you mange to find a solution? I was using the scraper before and it was working fine but now is not working for me since Twitter released their new API.

Anyone have a solution yet? If yes, can I have the file please?

Hi,
With Twitter API v2 you can now retrieve the replies of a given tweet. There are libraries such as tweepy and twarc that you can use to make it easy to achieve the task. Please have a look at how you can do it using twarc

Hi,
With Twitter API v2 you can now retrieve the replies of a given tweet. There are libraries such as tweepy and twarc that you can use to make it easy to achieve the task. Please have a look at how you can do it using twarc

Do you have a "sourcecode"? Or can you be more specific? Thank you so much!


Left nav - selected topic jumps out of view

If you scroll down on the left nav bar and select a topic, when the topic loads, the left nav bar snaps back to the top. If the topic wasn't initially in view, and you needed to scroll down to find it, after the page loads, it's no longer in view again.
Whatever is selected in the left nav bar should stay in view - actually, it should stay in exactly the same position so that's easy to understand where you are in the site with a single glance.
To reproduce:

Go to this page.

Scroll down to the last chapter in the book "How-to guides", and expand it.

Click on an item under "How-to guides". For example, "Disable automatic learning".

Results:
The left nav bar resets right to the top.
Expected Results:
The left nav bar should be in exactly the same position it was before "Disable automatic learning" was clicked (still visible on screen)

@maxakuru I'm still see this issue.
Repro:

Open a new tab in your browser and go to this page: https://main--prisma-cloud-docs-website--hlxsites.hlx.live/prisma/prisma-cloud/en/compute/pcee/admin-guide/vulnerability-management/registry-scanning/scan-google-artifact-registry

Results:
Notice that the left nav is scrolled to the top. In the left nav, you can't see which topic is selected.

Expected results:
The topic selected is visible in the left nav.


docs: add initial performance guide doc

"higher is better" / "lower is better"

Good point! I'll add proper wording.

(I'll readd the 1.8 backport once also the follow-ups are merged early next week so we can take in all at once w/o partial state.)


not showing tag in status page

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
i created a monitor with tag then created a status page then when check the status page not showing the tag
ticked all the options of status page
version 1.16.0
node latest
linux
🐻 Uptime-Kuma Version
1.16.0
💻 Operating System and Arch
Linix
🌐 Browser
Chrome
🐋 Docker Version
No response
🟩 NodeJS Version
Latest

I noticed the same issue


Add ordered split to RDD class

To perform supervised machine learning, one must partition data into labeled data sets, typically according to a set of rules.  Creating an RDD function to perform this as a single step serves as a first step in moving toward single pass RDD partitioning.

Can one of the admins verify this patch?

This needs to be implemented in Scala since Spark's architecture is such that the Scala implementation can be exposed via the Python, Java, R, etc. APIs and not the other way around, starting with one of those APIs as the root implementation.

I don't think that we should add this to the core RDD API itself. This method is probably more useful / discoverable as part of one of the ml or mllib subpackages. In addition, the implementation here is not more efficient than what a user could write themselves (i.e. it's just syntactic sugar for ~ two lines of code).
If you'd still like to propose this change, please see the instructions at https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark and follow the process for filing a JIRA.

Sounds good, thanks for the input.


Allow user custom RequestOptions when configuration, #322.

The config about PartitionKey and Throughput may be override by Annotation.

Signed-off-by: Pan Li<EMAIL_ADDRESS>

Codecov Report

Merging #323 into master will decrease coverage by 0.53%.
The diff coverage is 70.37%.

@@            Coverage Diff            @@
##           master    #323      +/-   ##
=========================================
- Coverage   80.93%   80.4%   -0.54%
=========================================
  Files          40      42       +2
  Lines        1023    1036      +13
  Branches      134     134
=========================================
+ Hits          828     833       +5
- Misses        126     133       +7
- Partials       69      70       +1

Impacted Files
Coverage Δ

...ata/cosmosdb/exception/ConfigurationException.java
0% <0%> (ø)

.../spring/data/cosmosdb/core/DocumentDbTemplate.java
86.11% <100%> (-0.06%)
:arrow_down:

.../azure/spring/data/cosmosdb/DocumentDbFactory.java
91.3% <100%> (+0.39%)
:arrow_up:

.../spring/data/cosmosdb/config/DocumentDBConfig.java
95.23% <100%> (+0.5%)
:arrow_up:

...ure/spring/data/cosmosdb/common/CosmosdbUtils.java
42.85% <42.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5563d32...7f00bb3. Read the comment docs.


In a Grails multi-project, there are errors when the User/Role domain classes are in a separate plugin subproject

Our team has a new Grails 3.3.9 multi-project.  This issue manifests almost exactly like #56 but the work-around suggested there did not work.  Ultimately, copying the Domain classes from myplugin into the myweb subproject fixed the issue.  However, we want our Domain classes, including those for Spring Security (SecUser and SecRole) to reside in the shared plugin.
Task List

[x] Steps to reproduce provided
[x] Stacktrace (if present) provided
[x] Example that reproduces the problem uploaded to Github
[x] Full description of the issue provided (see below)

Steps to Reproduce
NOTE: If you clone the repo below, you can start with step 4

Setup a Grails multi-project as detailed in this article: http://www.databaseapplications.com.au/grails-multi-app.jsp
Add s2ui to the myweb subproject
compile 'org.grails.plugins:spring-security-ui:3.1.2'
Generate Controllers and crud gsps with s2ui-override command line:

grails s2ui-override auth
grails s2ui-override layout
grails s2ui-override role com.example (replace existing controller from earlier generate-all)
grails s2ui-override user com.example (replace existing controller from earlier generate-all)

cd myweb; grails run-app
Login to the app with user admin and password strongPassword.

I believe the issue may be that the plugin is dependent upon the grails-spring-security-core plugin while the app is dependent upon the grails-spring-security-ui plugin.
I believe both of the dependencies on grails-spring-security-core and grails-spring-security-ui should reside within the application, that would be myweb in your case.
All security related domain classes (SecRole, SecUser and SecUserSecRole), controllers, services, (etc) and config should also reside in the application, myweb.
The endpoints, including those in your plugin, may then be locked down by either annotating the controllers themselves or modifying application.groovy with the desired patterns and accesses.  Make sure to include the role controller in the static rules if you wish to provide access to users.
Please let me know if these changes work for you.

Thanks for replying!  Does your theory involve the possibility that the web app and the plugin might end up depending on different versions of grails-spring-security-core through transient dependencies?
My example is oversimplified, separating domain classes from a simple UI app.  Our actual use case is more complex, with multiple web apps relying on the same security infrastructure.  I was hoping not to have to duplicate domain classes in each web app.
In fact, right now my work-around is to copy the domain classes SecUser, SecRole, and SecUserSecRole into the web app.  So, I already know that putting those into the web app resolves the issue.  I'll try what you ask with the dependencies as well and see what difference that makes.

@dgoodman-idea, I have a solution for you.
The issue does, in fact, appear to be a configuration problem.
Access to URLs may be configured in one of three ways:

@Secured annotations. This is the default approach
A simple Map in application.groovy or application.yml
RequestMap domain class instances stored in the database

Your example application is using the @Secured annotations approach by default.  As a result, requests to access the role or user controllers are denied because those controllers are not annotated with @Secured in the grails-spring-security-ui source code.
The approach I recommend you take with your app is to use either the simple map or RequestMap approach.
To use the simple map approach to enable access to the user controller for all users, modify your application.yml as follows:
grails:
  plugin:
    springsecurity:
      securityConfigType: 'InterceptUrlMap'
      userLookup.userDomainClassName: 'com.example.SecUser'
      userLookup.authorityJoinClassName: 'com.example.SecUserSecRole'
      authority.className: 'com.example.SecRole'
      interceptUrlMap:
        - pattern: '/'
          access: ['permitAll']
        - pattern: '/console/**'
          access: ['permitAll']
        - pattern: '/static/console/**'
          access: ['permitAll']
        - pattern: '/index'
          access: ['permitAll']
        - pattern: '/index.gsp'
          access: ['permitAll']
        - pattern: '/error'
          access: ['permitAll']
        - pattern: '/user/denied'
          access: ['permitAll']
        - pattern: '/assets/**'
          access: ['permitAll']
        - pattern: '/**/js/**'
          access: ['permitAll']
        - pattern: '/**/css/**'
          access: ['permitAll']
        - pattern: '/**/images/**'
          access: ['permitAll']
        - pattern: '/user/**'
          access: ['permitAll']

Please note, I modified your config by:

setting the SecurityConfigType to be InterceptUrlMap instead of the default Annotation
added pattern and access values for the UserController

I verified this approach allows access to the UserController.
You will need to add additional patterns and accesses for your other controller endpoints and probably modify the my example to lock down access to UserController  :)
More information is available at
https://grails-plugins.github.io/grails-spring-security-core/3.2.x/index.html#requestMappings
Please let me know if this correctly addresses your issue!  Thanks!

@ddelponte I applied the changes you suggested and it still only works if I copy the domain classes into the myweb subproject.  My original goal was to allow the domain classes to reside in a plugin subproject.    Maybe a classloader issue?


Can't run nocode on codeless

I tried running nocode on one of these newfangled codeless platforms. Given the similarity in naming I thought it would be a perfect fit, but to my surprise I couldn't get it working. No matter what I did, it seemed like code was still being executed.
Do you have any tips for running nocode on codeless? Is support on your roadmap?

To be honest,I think this is not a project, it's a behavior artist.

To be honest,I think this is not a project, it's a behavior artist.

That's truly honest , you didn't lie to me.

you can do this. tring wirte some code to the text,then clicking DEBUG.


local Pihole queries only

Very good idea for this project thank you!
I'm not sure why but the only records that show up in Log Analytics / Sentinel in the Normalized_CL table are queries that the PiHole server does to "api.snapcraft.io".
Has something changed with PiHole in the last eight months that would cause this project to break? All my files and permissions are in the right locations per the scripts. One thing to note is that my pihole-FTL.db is 5GB in size and the server is very very busy and I do not run it on a raspberrypi.

Changing the owner to pihole:pihole and 755 recursively on the /opt/pihole-sentinel/* directory fixed the issue of pihole not uploading client queries into LAW.


Add placeholder image for projects

Should be used in the case where the user does not provide an image for the project.

Closed by #106


C producer examples leak memory?

Describe the usage question you have. Please include as many useful details as  possible.
Perhaps my limited C knowledge is making me miss something obvious, but I think the producer examples on this page of the documentation leak memory? Child schemas are malloced:
 //
 // Initialize child type #0
 //
 child = schema->children[0] = malloc(sizeof(struct ArrowSchema));

Then in the release implementation, we free the array of child pointers and call release on the children array, but don't actually free the child ArrowSchema allocations:
static void release_malloced_type(struct ArrowSchema* schema) {
   int i;
   for (i = 0; i < schema->n_children; ++i) {
      struct ArrowSchema* child = schema->children[i];
      if (child->release != NULL) {
         child->release(child);
      }
   }
   free(schema->children);
   // Mark released
   schema->release = NULL;
}

Since (as far as I can tell?) the docs don't otherwise explicitly state what the lifetime of these children is, it could be nice to fix this? Reading the C++ ExportArray implementation, it seems like these are in fact freed in the release call via the private_data pointer in at least the C++ implementation.
Component(s)
C, Documentation

The docs specify the lifetime and memory management semantics here: https://arrow.apache.org/docs/format/CDataInterface.html#memory-management
That said, it looks like you're right. There should be a free(child); after child->release(child); Would you be willing to contribute a PR to fix it? :smile:


[TASK] : Create a PySpark script to run Hive DDLs

Story: #3
Date: 10-02-2022
Description:
Estimated efforts: 5

Without SERDE


Add missing slashes

@indexzero Is this project still alive? Can anyone merge this simple PR?

@CatTail the protocol variable already includes the slashes:
https://github.com/CatTail/http-server/blob/e9c82393e1c0d14ee15016390b2a46fb37a72e5f/bin/http-server#L126
Did you see that output without them someplace? If so, where did you see them missing?
Thanks!

Sorry I can't reproduce the issue

NP @CatTail ! Thanks for checking.


Some bad error messages

First:
```pulse
fn foo ()
  requires emp
  ensures  emp
{
  let x : nat = -1;
  ()
}
```

Highlights the whole body and says:
- Expected a term with a non-informative (e.g., erased) type; got
  squash (x == - 1)

Very puzzling since we expect to see that we failed to prove the refinement, and on top of that squash is actually non-informative?
Second:
```pulse
fn foo (y:string)
  requires emp
  ensures  emp
{
  let x : nat = y;
  ()
}
```

Highlights the whole definition (from backticks to backticks) and says:
- refl_core_check_term failed:  Top ()
  > top-level subtyping ()
  Prims.string is not a subtype of i: Prims.int{i >= 0}
- Raised within Tactics.refl_core_check_term_at_type
- See also <input>(1,0-1,0)
Ambig.fst(1, 1): related location

Another bad error message issue that I ran into is with partially applied functions with "preconditions", the error doesn't point to the actual use which violates the precondition. For example:
open Pulse.Lib.Pervasives

let divide (a: erased int) (b: erased int { reveal b <> 0 }) : GTot (erased int) = a / b

```pulse
fn test()
  requires emp
  ensures emp
{
    let hundred = divide 100;
    let unknown = hundred 0;
    ()
}
\```

results in an error pointing to divide in let hundred = divide 100; with a secondary span pointing to the b argument of divide. This makes the error very difficult to debug if I used hundred  in multiple places in the fn and I'm not sure which one may have been called with 0


Alias the property background with bg

🚀 Feature Proposal
Use bg as an alias of background
Motivation
bg is shorteer than background and easier to transition from styled-system that already implements it
Example
function App() {
    return (
        <Box bg='red'>
        </Box>
    )
}

Pitch
Faster development and less code

Hello @remorses, I don't think having to learn a new language to use xstyled is a good thing. We add alias for margin and padding because it is very commonly used especially in grids. But background is not a common property that you use everywhere.
Also background and backgroundColor does not have the same treatment. So it could be confusing.
I think it is a bad choice from styled-system to alias it. Let's see if other users want it!

@P1X3L @theo-mesnil, your advice on this one?

Hey !
Maybe is not the best choice from styled system but, if this exist on styled system, it's better to have it on xstyled :)

I would add bg AND bgColor to avoid any confusion.
bg would be the alias of background
bgColor the alias of backgroundColor

I migrated from styled-system/rebass and was surprised why my "bg" not working :) I can live without it but I like this property as well.

OK, could someone make the PR to alias backgroundColor to bg?

@P1X3L @theo-mesnil we will stick to styled-system.


Could not connect to any read servers.

So I get this big ugly block of text after trying to log in:
array(4) { ["message"]=> string(38) "Could not connect to any read servers." ["file"]=> string(50) "/vagrant/vendor/block8/b8framework/b8/Database.php" ["line"]=> int(122) ["trace"]=> string(712) "#0 /vagrant/PHPCI/Store/Base/UserStoreBase.php(54): b8\Database::getConnection('read') #1 /vagrant/PHPCI/Controller/SessionController.php(41<EMAIL_ADDRESS>#2 [internal function]: PHPCI\Controller\SessionController->login() #3 /vagrant/vendor/block8/b8framework/b8/Controller.php(67): call_user_func_array(Array, Array) #4 /vagrant/PHPCI/Controller.php(55): b8\Controller->handleAction('login', Array) #5 /vagrant/vendor/block8/b8framework/b8/Application.php(60): PHPCI\Controller->handleAction('login', Array) #6 /vagrant/PHPCI/Application.php(36): b8\Application->handleRequest() #7 /vagrant/public/index.php(18): PHPCI\Application->handleRequest() #8 {main}" } Notice: Undefined index: REDIRECT_PATH_INFO in /vagrant/PHPCI/Application.php on line 53 array(8) { ["PATH_INFO"]=> string(14) "/session/login" ["REDIRECT_PATH_INFO"]=> NULL ["REQUEST_URI"]=> string(14) "/session/login" ["PHP_SELF"]=> string(24) "/index.php/session/login" ["SCRIPT_NAME"]=> string(10) "/index.php" ["DOCUMENT_ROOT"]=> string(16) "/vagrant/public/" ["SCRIPT_FILENAME"]=> string(25) "/vagrant/public/index.php" ["SERVER_SOFTWARE"]=> string(22) "Apache/2.2.22 (Ubuntu)" }

My config.yml:
prevstage:
    - start
    - database
    - github
    - email
b8:
    database:
        servers:
            read:
                - localhost
            write:
                - localhost
        name: phpci
        username: root
        password: xYdfj5DltdKWxpzs
phpci:
    url: 'http://localhost:8080'
    github:
        id: ''
        secret: ''
    email_settings:
        smtp_address: ''
        smtp_port: ''
        smtp_encryption: on
        smtp_username: ''
        smtp_password: ''
        from_address: ''
        default_mailto_address: ''

This may be related to #263

Got same error 'Could not connect to any read servers.'
turns out it because PDO extension is not installed
PDOException “could not find driver”
after I uncommented extension=php_pdo_mysql.dll in php.ini everything works fine
Error message should be more clear thought, maybe check for PDO driver installed?

Hello,
I've just installed PHPCI following install instructions on page and I've got "Could not connect to any read servers." after login.
After some debbuging, I've found out, the real problem is "SQLSTATE[HY000] [2002] No such file or directory" .. ( "localhost" in config to "<IP_ADDRESS>" )
So:

"Could not connect to any read servers" has zero information for user, and more,  full string is ungrepable in project, you must grep " Cound not connect  to" to find PDO mess...
Installer works with "localhost" in config flawlessly, but PHPCI after installation not ...

At least, please, upgrade code to show error message from PDO exception .. :)

I had this message too, but before this message I had this one:
Setting up your database...
[PDOException]
SQLSTATE[42000]: Syntax error or access violation: 1101 BLOB/TEXT column 'log' can't have a default value
Aparently, there's a error on your SQL script.

I found out my problem:
NOT ALWAYS localhost works on some systems. For instance, my /etc/hosts does not map localhost to <IP_ADDRESS>.
Changed the connection for <IP_ADDRESS> IP address and it worked. Maybe the default config should be changed to the ip address as well, to avoid ambient specific problems. IPs always works better than DNS based addresses.


build: skip automated integration test running on release PRs

Fixes #3355

Closing for now, feel free to reopen when this becomes pertinent again.


ci: bump number of builders to 7

Temp bump number of builders to 7 since we getting a lot of timeout
issues with normal PRs.
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

Codecov Report

Merging #12168 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12168      +/-   ##
==========================================
- Coverage   48.11%   48.06%   -0.06%
==========================================
  Files         284      284
  Lines       43383    43383
  Branches    10397    10397
==========================================
- Hits        20875    20853      -22
- Misses      18368    18389      +21
- Partials     4140     4141       +1

Impacted Files
Coverage Δ

subsys/logging/log_core.c
74.67% <0%> (-7.87%)
:arrow_down:

subsys/logging/log_msg.c
86.36% <0%> (-2.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc7240...50bb3db. Read the comment docs.


CI - update hxcpp and update setup-haxe

alright thats enough renames

and update setup-haxe

Please remove this part.


More Service Functions

LGTM. Let's give @vbfox some time to review if he wants as he often finds things I miss. :)

:+1: LGTM


Allow non-support users to add other users to their organisation

Context
As a placements user, I should be able to add other users to my organisation(s).
Changes proposed in this pull request

Controllers and views for non-support users to add other users.

Guidance to review
Login as any non-support placement user
Select an organisation (or not if user is only a member of one)
Add user
You should be able to add the same user to another organisation
Link to Trello card
https://trello.com/c/JTRen6nD
Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[ ] Required environment variables have been updated or added to the Azure KeyVault

Screenshots
https://github.com/DFE-Digital/itt-mentor-services/assets/44073106/8ede3d6a-a0fe-4215-b0b5-33966713f7c3

 Allow users to add other users to their organisation

 Allow users to add other users to their organisation

@elceebee, there are a couple of outstanding issues:
When a user enters an email that is already used, we show the error:

Email address already in use

When a form is in error, the page title should be prefixed with Error:, for example:

Error: Personal details - Add user - Manage school placements - GOV.UK

@elceebee, there are a couple of outstanding issues:
When a user enters an email that is already used, we show the error:

Email address already in use

When a form is in error, the page title should be prefixed with Error:, for example:

Error: Personal details - Add user - Manage school placements - GOV.UK

Nice catch! We value and appreciate your pedantry. :) These should both be fixed now if you want to have another look at the review app.


Use codegen.ts in CodeSandbox template

Currently it still uses a yaml file.

Updated: https://github.com/dotansimha/graphql-code-generator-issue-sandbox-template