Update tower extension

Description

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi @sebduggan nice addition. Thanks!

It seemed a pretty good solution to the inability to use Warp as an alternate terminal for opening from within Tower...
Not sure why some existing icons have been modified in the PR - they weren't modified or included in my git commit!

Sorry @sebduggan, but meanwhile testing some modifications on CI actions, I messed up your PR :(
Now that PR is closed I don't have permission to fix it anymore - do you mind either giving me permissions to fix it in your branch, or fix it on your end so we can re-open this PR?
This should bring back the changes on your branch:
git cherry-pick b292a6eaf06bde1ad0d191a3be893f7aa106efc7
Then you need to push it again, so I can reopen it. Sorry for inconvenience.

@grzegorzkrukowski Have added you as a collaborator on my branch, let me know if you need anything else

@grzegorzkrukowski That seems to have lost the new icon (maybe my comment above was misleading...)
icon-warp.png was new and added; the others in the original PR seemed to be randomly modified.

@grzegorzkrukowski That seems to have lost the new icon (maybe my comment above was misleading...)
icon-warp.png was new and added; the others in the original PR seemed to be randomly modified.

Yes sorry, I just fixed it


Add the empty, empty_with_mipmaps and empty_with_format functions

Close #486
cc #471
The empty method is like the current new_empty but doesn't need to pass any format and does not generate mipmaps.
The new_empty method has been deprecated.

How does it know which format to use?


RC6 error when adding Module: Unexpected token <

My application was working with ng2-bootstrap before RC5.  I have converted to RC6 now and removed ng2-bootstrap and everything is working. Now I want to add ng2-bootstrap.  I am just using the AlertModule and DatepickerModule because they are in the instructions.
In app.module.ts, I add the import:
import {AlertModule, DatepickerModule} from 'ng2-bootstrap/ng2-bootstrap';
Then I add AlertModule and DatepickerModule to the import of @NgModel as described in the instructions.  At this point I get a run time error - I have not even added the actual components to a page.  The error is:

Error: SyntaxError: Unexpected token <
at Object.eval (http://localhost:54675/lib/js/ng2-bootstrap/components/datepicker/date-formatter.js:2:14)
at eval (http://localhost:54675/lib/js/ng2-bootstrap/components/datepicker/date-formatter.js:13:4)
at eval (http://localhost:54675/lib/js/ng2-bootstrap/components/datepicker/date-formatter.js:14:3)
Evaluating http://localhost:54675/lib/js/moment/moment
Evaluating http://localhost:54675/lib/js/ng2-bootstrap/components/datepicker/date-formatter.js
Evaluating http://localhost:54675/lib/js/ng2-bootstrap/components/datepicker/datepicker-inner.component.js
Evaluating http://localhost:54675/lib/js/ng2-bootstrap/components/datepicker/datepicker.module.js
Evaluating http://localhost:54675/lib/js/ng2-bootstrap/components/datepicker.js
Evaluating http://localhost:54675/lib/js/ng2-bootstrap/ng2-bootstrap.js
Evaluating http://localhost:54675/lib/spa/app.module.js
Evaluating http://localhost:54675/lib/spa/main.js
Error loading http://localhost:54675/lib/spa/main.js

If I remove DateModule and just use AlertModule I get the same error that references datepicker.  If I remove AlertModule and add ModalModule I still get the error that reference datepicker.
Here are the relevant parts of systemjs.config.
(function (global) {
    System.config({
        paths: {
            // paths serve as alias
            'npm:': 'node_modules/'
        },
        // map tells the System loader where to look for things
        map: {
            'ng2-bootstrap': 'lib/js/ng2-bootstrap'
        },
        // packages tells the System loader how to load when no filename and/or no extension
        packages: {
            'ng2-bootstrap': { defaultExtension: 'js' }
    });

Any idea what I'm missing?

try to compare with https://github.com/valor-software/angular2-quickstart/blob/master/systemjs.config.js
/lib/js/ng2-bootstrap/components/datepicker/date-formatter.js
path seems correct, is file in place?

This is resolved.
It was not finding moment.  I need to add the js extension is systemjs.config.  Pre-RC5 it was appending it for me with the default extension.

Awesome!
On Mon, Sep 12, 2016, 18:53 chambersDon<EMAIL_ADDRESS>wrote:

This is resolved.
It was not finding moment. I need to add the js extension is
systemjs.config. Pre-RC5 it was appending it for me with the default
extension.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/valor-software/ng2-bootstrap/issues/957#issuecomment-246392832,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABDk46bNQ99Bgh5QsqkSDOYKT9X90B6tks5qpXSbgaJpZM4J6q-l
.


[IRGen][DebugInfo] Use attached SILLocation for generating debug location for variable declaration

Currently IRGen requires the AST node of a variable declaration to generate debug location. However, this will fail if the input is SIL due to the lack of AST reconstruction. Plus, it's unnecessary since we can just use the SILLocation attached on debug_value (and its friends) SIL instruction to generate the correct LLVM debug metadata. This patch implement the said solution.
Resolves SR-14868

@swift-ci test

@swift-ci test

@swift-ci test

Build failed
Swift Test Linux Platform
Git Sha - 2d35d31290763c91ec2b1bc665a072c20f5a4428

@swift-ci test

Previously Linux fail with "outdated module cache" error, which I think it's irrelevant to this PR, and now Mac OS X failed with some filesystem issue. Guess I need to launch again
@swift-ci test


[Blocked] Support Ruby 3

Blocked by https://github.com/remarkjs/remark-gfm/issues/6

Blocked by https://github.com/remarkjs/remark-gfm/issues/6

@depfu rebase

@depfu rebase


Sponsor module - Trial list

As there are no conflicts, for new features (that no one is using yes), I rather have the list of new components, routes, etc... (the kind of items that are likely to cause conflict) merged to master as soon as the component structure is stable.


updated stylesheet to prevent horizontal scrolling (#2)

restored original scrollbar width, should work fine now

ah, i see that #3 already solved the issue in the meantime. think this can be closed then

@ulieckstein Yes, but you gave me a new perspective on how it can be solved, thanks!


Azure Functions

How is the QuickPulseTelemetryModule configuration done in an Azure Functions v1 or v2 app, where there is no ConfigureServices method, and it seems to ignore applicationinsights.config?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e3307edb-b27c-a0b9-ff1e-610630c98c15
Version Independent ID: 20262b8a-31ff-4df9-dd05-859001f24eba
Content: Live Metrics Stream with custom metrics and diagnostics in Azure Application Insights
Content Source: articles/azure-monitor/app/live-stream.md
Service: application-insights
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@rwatjen in answer to your follow-up question, I just confirmed with @brettsam that there are no plans to backport this capability to Functions V1. Thanks again for bringing this to our attention and helping us to improve our docs!

@MicrosoftDocs/azure-cxp-triage #please-close

Thank you Michael.
From: Michael Bullwinkle<EMAIL_ADDRESS>Sent: Friday, February 8, 2019 1:41 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Aman Garg<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Azure Functions (#22916)
@MicrosoftDocs/azure-cxp-triagehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Forgs%2FMicrosoftDocs%2Fteams%2Fazure-cxp-triage&data=02|01|Garg.Aman%40microsoft.com|7966d7ed8d6b4999473308d68d385896|72f988bf86f141af91ab2d7cd011db47|1|0|636851670479157405&sdata=T1DNuiQFz%2BG2MDq0MKXdYisJncuqFLqnE25to9EKUZU%3D&reserved=0 #please-close
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F22916%23issuecomment-461578098&data=02|01|Garg.Aman%40microsoft.com|7966d7ed8d6b4999473308d68d385896|72f988bf86f141af91ab2d7cd011db47|1|0|636851670479167395&sdata=dL%2FZyK4iO476z8%2BfMfqDChirbwvisZLXhfIe0qx6Brs%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAqaBR7uPHrSMcHfbUFKoE6Hu8-JMfk_1ks5vLIhFgaJpZM4aKc5O&data=02|01|Garg.Aman%40microsoft.com|7966d7ed8d6b4999473308d68d385896|72f988bf86f141af91ab2d7cd011db47|1|0|636851670479167395&sdata=4juEocwJ0E0DYAQdQg0ZN8AQozdSum9VG4jzukxwrew%3D&reserved=0.

@mrbullwinkle Thank you for following up and clarifying that.


Add step that adds coopnorge as nuget source for csharp code

Related discussion https://github.com/coopnorge/github-workflow-supply-chain-security-validation/issues/63

@coopnorge/engineering please help in reviewing this


Add Python 3.9 to Github Actions

We tried to add Python 3.9 but not all dependencies are ready. We will then wait...


[improve][broker] Reduce object creation of EntryBatchIndexesAcks

Motivation
Only create EntryBatchIndexesAcks instance while batch index acknowledgment is enabled.
Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

:( shamely, I missed a place.

IMO, we can give the some method parameter @Nullable annotation. And use Optional to avoid potential NPE.

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks


When failing work items during commit, make sure to call completeWork…

Calls completeWorkAndScheduleNextWorkForKey when failing a work item during commit so that future work can be processed.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @scwhittle


"bug" in the loose sense of the word: the FAQ link in the README.md is the wrong link

The README.md currently points to https://nanoexpress.js.org/support/faq for the "faq" link, but that's a 404.

Thank you @Pomax


Windows and Unix commands

On Windows, I've installed Git as an isolated executable to not override some Windows' commands by the Unix ones, this unfortunately results to not have the wc command available.
So the lib/models/branches/local-branch.coffee should preferably use the find command instead on Windows platform not having the wc command.
[Suggestion] Detection with /^win/.test(process.platform) along with require('child_process').spawnSync("where wc") where returned object.status > 0?
Apparently, the equivalent to wc -l would be find /v /c ""

As you noticed, the PR #65 should solve it.
I think my solution is really cross platform :
git.cmd("rev-list --count<EMAIL_ADDRESS>(the pipe is completely removed and the counting is done by git)

Indeed, since it's directly a git command I won't argument with that! :wink:
Should I leave this issue opened until the PR is merged?

I don't know... just waiting for the "project collaborators" to react about it !


Microsoft Design involvement in WinUI 3.0 and beyond

Once WinUI 3.0 goes fully open, as new feature requests come in and new controls are added.  Will any members of the Fluent/Microsoft Design teams play a role here in evaluating control designs, and try to maintain consistency with ALL Microsoft UI frameworks?
WPF, WinForms, WinUI 3.0, Fabric - these will all be open source, and updateable outside of the Windows OS.  So a new control in one, could be added to the others, and their designs adjusted to match - truly making it a single Windows App Platform as mentioned at Build 2019

If you check out the Fluent Design System website or watch this year's BUILD session on Fluent Design System: The Journey to Cross-Platform you should take away this landscape:

The Windows UI Library ("WinUI") is the definitive source for Fluent Design System on Windows.
The "UI Fabric" web, iOS, and Android libraries are, respectively, the definitive source for Fluent Design System on web, iOS, and Android.

As discussed in that session, the teams are working to bring greater coherence to experiences built with these libraries.  For example, progress was shown during the talk on bringing the UI Fabric Web library into greater alignment with WinUI.  You may have also noticed issues in the WinUI repo tracking bringing even more alignment from this end: https://github.com/microsoft/microsoft-ui-xaml/issues/524
You shouldn't have to wait for WinUI 3.0 per se... the design teams already work closely with us on WinUI - and have since the start - to define the control designs as well as any visual, interactive, and functional updates to those designs over time. That includes improvements that come out of new feature requests from the community.
Even using WinUI 2.x you can get the latest Fluent Design styles for all controls (even the inbox controls) following the instructions in the Getting Started guide.
For WPF and WinForms a recommended way to take advantage of the Fluent Design System is to use WinUI via XAML Islands. That will become easier with WinUI 3.0. There are also some community projects that try to bring elements of Fluent Design System directly to those frameworks (esp. around the visual styles).

Thank you for the reply @pag3 The fact that there is a lot of overlap between Fabric Web, and Fluent UWP does lead a way to combining these different styles.
I was greatly interested and enthused to hear about plans for WinUI 3.0 - at present, WinUI 2.x does not include all controls, like the Buttons, CheckBoxes, TextFields etc.  So no behavioural changes can be implemented right now - but as the design of these controls is under the ownership of Microsoft Design teams, any proposed changes by us outsiders, would still need approval.
PWAs could appear like native experiences if the design of these controls were identical.
WPF is another odd ball, in that over time it has supported different ResourceDictionaries and designs for apps running on Windows XP Luna Blue, Green and Royale visual styles.  Which also gained Aero styles to match Vista and Windows 7.  Is now the time to add a Fluent option for WPF apps running on Windows 10?
WinForms I assume will always take their appearance from the GDI CommonControls within the Windows VisualStyle resources.  Will the now Open Source WinForms ever move to update those controls?
There are a lot of little loose threads where things could align better visually, but don't, and having a roadmap or knowing if there is an intention to bring all these designs together in the future.
The message I took from Build, is that the separation and differentiation of UWP & Win32 is ending.  As it becomes the Windows Presentation Platform.  So the next step surely should be trying to eliminate the differences between them.  Visual Design being the most obvious.
https://mybuild.techcommunity.microsoft.com/sessions/77008?source=sessions#top-anchor

The message I took from Build, is that the separation and differentiation of UWP & Win32 is ending. As it becomes the Windows Presentation Platform. So the next step surely should be trying to eliminate the differences between them. Visual Design being the most obvious.

XAML Islands is about bringing UWP XAML elements to these older platforms - but these platforms have native controls which could be made to fit closer to Fluent design - even if some elements like Acrylic, Motion, Touch wont be shared by all natively.

I was under the impression the Windows Presentation Platform is realized by WinUI 3.0, enabling you to use the exact same controls in all your native Windows apps (UWP, WPF and WinForms). UWP/WinUI controls look & feel won't be ported over to exisiting WPF/WinForms controls - if you want to ship apps like those with a native Windows 10 look & feel, you will have to use WinUI 3.0 via XAML Islands.
It was said quite clearly that going forward WinUI will be the only source of innovation for native Win 10 design elements, so I expect WinForms/WPF to remain (largely) untouched. Looking at the commits in this repo, we see that the WinUI team is also hard at work to close gaps between Win32 controls and their UWP counterparts.
So, to my understanding, for any app in the future with Windows 10 native look & feel: Use WinUI 3.0 (instead of the in-built platform controls).

When I think about Windows UI I think about this. Windows 10 modified the buttons but even more could be changed to align so much more with Fluent. I also feel that File Explorer's dark theme wasn't done right.
We can't just pretend everything else doesn't exist because they are all over Windows. Not even File Explorer uses WinUI. I think what @mdtauk is saying what I'm saying: they should all have the same style.
i wish i could react to comments with a sad emoji


Allow selective overriding of file explorer and workbench icon associations, instead of overriding all icons

Problem Statement
I'd like to, for example, create a new programming language.
I'd like to change the icon file association for my programming language, so that a logo for my programming language appears instead of the default icon.
For simplicity, let's say I'm creating a fictitious GitHub programming language that has files that end in .gh and my language makes use of a github script, for which I am also updating the icon.
If I just do
        "iconThemes": [
            {
              "id": "override",
              "label": "Only override a few icons",
              "path": "./override-icon-theme.json"
            }
        ],

in the contributes section of package.json, and override-icon-theme.json is
{
	"iconDefinitions": {
		"_github_logo": {
			"iconPath": "./GitHub-Mark-120px-plus.png"
		}
	},
	"fileExtensions": {
		"gh": "_github_logo"
	},
	"fileNames": {
		"github": "_github_logo"
	}
}

then I end up with

Notice how all icons are gone, except for the ones I specified.
How do I keep all icons, except for the specific ones I want to override?
Even if I were to just copy-and-paste extensions/theme-seti/icons/vs-seti-icon-theme.json, and merge
{
	"iconDefinitions": {
		"_github_logo": {
			"iconPath": "./GitHub-Mark-120px-plus.png"
		}
	},
	"fileExtensions": {
		"gh": "_github_logo"
	},
	"fileNames": {
		"github": "_github_logo"
	}
}

with that, that would be a hindrance to developers who use, say, extensions/theme-defaults/fileicons/vs_minimal-icon-theme.json, since now they have to use extensions/theme-seti/icons/vs-seti-icon-theme.json as their "fallback" icons to see updated icons for the fictitious "GitHub" programming language.
It would be really helpful if I could just selectively pick-and-choose which icon file associations to override, and let the remaining icon associations stay as-is, so as to not disturb developers' other icon preferences.
What are your thoughts on this?

There's PR https://github.com/microsoft/vscode/pull/118846 in the works that allows languages extensions to define a default icon for their language.
Ok to close in favor of https://github.com/microsoft/vscode/pull/118846?

Ah, I was not aware of this. That's fine with me. Thank you for the response!
Another issue I created, #138949, is also basically a duplicate of #118846.

Ah, I was not aware of this. That's fine with me. Thank you for the response!
Another issue I created, #138949, is also basically a duplicate of #118846.


tour: not implemented error on Windows 10

Context: http://<IP_ADDRESS>:3999/welcome/1
This began happening after the windows 10 upgrade from windows 7.
2016/01/31 21:32:23 Serving content from C:\Users\user1\My Projects\go\src\golang.org\x\tour
2016/01/31 21:32:23 A browser window should open. If not, please visit http://<IP_ADDRESS>:3999
2016/01/31 21:32:24 accepting connection from: <IP_ADDRESS>:49694
2016/01/31 21:32:54 not implemented

CC @adg @campoy

What version of Go and the tour are you running?

go version go1.6rc1 windows/amd64
application: go-tour
version: 1
runtime: go
api_version: go1

Are you running go tool tour to run the tour? Or gotour? If the latter, did you run go get to install gotour?

go get golang.org/x/tour/gotour
i just did that again a few days ago.
On 2/1/16, Andrew Gerrand<EMAIL_ADDRESS>wrote:

Are you running go tool tour to run the tour? Or gotour? If the latter,
did you run go get to install gotour?

Reply to this email directly or view it on GitHub:
https://github.com/golang/go/issues/14172#issuecomment-178225522

What do you do that triggers the not implemented log message? It seems to happen 30 seconds after the process starts, so I am assuming the message is triggered by some user action.
Do you have any problems with the user interface (in your browser) at the time the message is produced?
Can you provide a series of steps to reproduce the issue?

In the case of the this thread i simply opened the windows command
prompt and cd'd to the go bin folder. then i just typed "gotour.exe".
And it errored out almost right away. Sometimes i can acually run
something once.
Right now it opens edge which  gets a little goofed up sometimes in
the edit area with the cursor moving to the wrong place and text being
typed in the wrong place.
 If not, please visit http://12
<IP_ADDRESS>:3999
2016/02/04 21:53:59 accepting connection from: <IP_ADDRESS>:57325
2016/02/04 21:54:29 not implemented
On 2/4/16, Andrew Gerrand<EMAIL_ADDRESS>wrote:

What do you do that triggers the not implemented log message? It seems to
happen 30 seconds after the process starts, so I am assuming the message is
triggered by some user action.
Do you have any problems with the user interface (in your browser) at the
time the message is produced?
Can you provide a series of steps to reproduce the issue?

Reply to this email directly or view it on GitHub:
https://github.com/golang/go/issues/14172#issuecomment-180114693

Thanks for the information. I have an idea what the issue might be.
Can you please try running this command from a command prompt?
cmd /c start https://google.com/

Thanks for bearing with me.

Actually, never mind the above. I think I the issue is related to Microsoft's Edge browser's implementation of the websocket protocol, and a possibly outdated version of the websocket package in your version of the tour.
Can you please run
go get -u golang.org/x/tour/gotour

The -u flag is most important; it will make sure all the packages are updated to their most recent versions.


Command '['ninja', '-v']' returned non-zero exit status 1

Hi, we are facing the following issue while running Linux command line python script/run.py -c config/transductive/wn18rr.yaml --gpus [0]
Traceback (most recent call last):
File "/export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1667, in _run_ninja_build
subprocess.run(
File "/export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/lib/python3.8/subprocess.py", line 516, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "script/run.py", line 216, in
train_and_validate(cfg, model, train_data, valid_data, filtered_data=filtered_data)
File "script/run.py", line 57, in train_and_validate
pred = parallel_model(train_data, batch)
File "/export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in call_impl
result = self.forward(*input, **kwargs)
File "/export/home/s190009/myFile/repository/python/NBFNet-PyG/nbfnet/models.py", line 139, in forward
output = self.bellmanford(data, h_index[:, 0], r_index[:, 0])  # (num_nodes, batch_size, feature_dim）
File "/export/home/s190009/myFile/repository/python/NBFNet-PyG/nbfnet/models.py", line 104, in bellmanford
hidden = layer(layer_input, query, boundary, data.edge_index, data.edge_type, size, edge_weight)
File "/export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in call_impl
result = self.forward(*input, **kwargs)
File "/export/home/s190009/myFile/repository/python/NBFNet-PyG/nbfnet/layers.py", line 65, in forward
output = self.propagate(input=input, relation=relation, boundary=boundary, edge_index=edge_index,
File "/export/home/s190009/myFile/repository/python/NBFNet-PyG/nbfnet/layers.py", line 89, in propagate
out = self.message_and_aggregate(edge_index, **msg_aggr_kwargs)
File "/export/home/s190009/myFile/repository/python/NBFNet-PyG/nbfnet/layers.py", line 157, in message_and_aggregate
from .rspmm import generalized_rspmm
File "/export/home/s190009/myFile/repository/python/NBFNet-PyG/nbfnet/rspmm/init.py", line 1, in
from .rspmm import generalized_rspmm
File "/export/home/s190009/myFile/repository/python/NBFNet-PyG/nbfnet/rspmm/rspmm.py", line 204, in
rspmm = load_extension("rspmm", [os.path.join(path, "rspmm.cpp"), os.path.join(path, "rspmm.cu")])
File "/export/home/s190009/myFile/repository/python/NBFNet-PyG/nbfnet/rspmm/rspmm.py", line 199, in load_extension
return cpp_extension.load(name, sources, extra_cflags, extra_cuda_cflags, **kwargs)
File "/export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1079, in load
return jit_compile(
File "/export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1292, in jit_compile
write_ninja_file_and_build_library(
File "/export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1404, in write_ninja_file_and_build_library
run_ninja_build(
File "/export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1683, in run_ninja_build
raise RuntimeError(message) from e
RuntimeError: Error building extension 'rspmm': [1/2] /cm/shared/apps/cuda11.1/toolkit/11.1.0/bin/nvcc --generate-dependencies-with-compile --dependency-output rspmm.cuda.o.d -ccbin /export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/bin/x86_64-conda_cos6-linux-gnu-cc -DTORCH_EXTENSION_NAME=rspmm -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE="gcc" -DPYBIND11_STDLIB="libstdcpp" -DPYBIND11_BUILD_ABI="cxxabi1011" -isystem /export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/lib/python3.8/site-packages/torch/include -isystem /export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -isystem /export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/lib/python3.8/site-packages/torch/include/TH -isystem /export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/lib/python3.8/site-packages/torch/include/THC -isystem /cm/shared/apps/cuda11.1/toolkit/11.1.0/include -isystem /export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/include/python3.8 -D_GLIBCXX_USE_CXX11_ABI=0 -D__CUDA_NO_HALF_OPERATORS -D__CUDA_NO_HALF_CONVERSIONS -D__CUDA_NO_BFLOAT16_CONVERSIONS -D__CUDA_NO_HALF2_OPERATORS --expt-relaxed-constexpr -gencode=arch=compute_70,code=compute_70 -gencode=arch=compute_70,code=sm_70 --compiler-options '-fPIC' -O3 -std=c++14 -c /export/home/s190009/myFile/repository/python/NBFNet-PyG/nbfnet/rspmm/source/rspmm.cu -o rspmm.cuda.o
FAILED: rspmm.cuda.o
/cm/shared/apps/cuda11.1/toolkit/11.1.0/bin/nvcc --generate-dependencies-with-compile --dependency-output rspmm.cuda.o.d -ccbin /export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/bin/x86_64-conda_cos6-linux-gnu-cc -DTORCH_EXTENSION_NAME=rspmm -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE="gcc" -DPYBIND11_STDLIB="libstdcpp" -DPYBIND11_BUILD_ABI="cxxabi1011" -isystem /export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/lib/python3.8/site-packages/torch/include -isystem /export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -isystem /export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/lib/python3.8/site-packages/torch/include/TH -isystem /export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/lib/python3.8/site-packages/torch/include/THC -isystem /cm/shared/apps/cuda11.1/toolkit/11.1.0/include -isystem /export/home/s190009/myFile/tools/anaconda3/envs/py38pt180cuda111/include/python3.8 -D_GLIBCXX_USE_CXX11_ABI=0 -D__CUDA_NO_HALF_OPERATORS -D__CUDA_NO_HALF_CONVERSIONS -D__CUDA_NO_BFLOAT16_CONVERSIONS -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr -gencode=arch=compute_70,code=compute_70 -gencode=arch=compute_70,code=sm_70 --compiler-options '-fPIC' -O3 -std=c++14 -c /export/home/s190009/myFile/repository/python/NBFNet-PyG/nbfnet/rspmm/source/rspmm.cu -o rspmm.cuda.o
x86_64-conda_cos6-linux-gnu-cc: error trying to exec 'cc1plus': execvp: Permission denied
nvcc fatal   : Failed to preprocess host compiler properties.
ninja: build stopped: subcommand failed.
We created the required environment, which includes:
python                     3.8.11
torch                        1.8.0+cu111
torch-scatter            2.0.8
torch-sparse            0.6.12
torch-geometric      2.0.1
ninja                        <IP_ADDRESS>
easydict                   1.9
pyyaml                    5.4.1
And our gcc version is:
gcc version 7.3.0 (crosstool-NG <IP_ADDRESS>9-a04d0)
Could you please check out this issue, and provide some clues on how to resolve it? Thanks.

Seems you are missing the full compiler package and you are missing g++.
You could try installing gcc via conda if you don't have sudo rights to the underling machine.


Check if tls certs are expired if they already exist

Couple of things I've considered but want some feedback on:

Currently will check if cert is expired or will expire within 24 hours. Should the timeframe be different and should that value be configurable by the user(Not sure how much use that would get)?
Should there be a flag that tells the script to not delete and rotate the certs even if they are expired? (This will only happen if TLS_ENABLE=True and the certs already exist)
Should there be another entrypoint to allow certs to be rotated without having to run the deploy script?

Couple of things I've considered but want some feedback on:
1. Currently will check if cert is expired or will expire within 24 hours. Should the timeframe be different and should that value be configurable by the user(Not sure how much use that would get)?

I think 24 hours is too narrow of a window, maybe something like a week seems more reasonable.  Making it a user-configurable thing might be a good idea even if 99% of users leave the default.  On the other hand, users with special needs could always just delete the existing certs to force us to regenerate.  Let's discuss.

2. Should there be a flag that tells the script to not delete and rotate the certs even if they are expired? (This will only happen if TLS_ENABLE=True and the certs already exist)

I am not sure I can identify a reasonable use-case for such a flag.

3. Should there be another entrypoint to allow certs to be rotated without having to run the deploy script?

I think you are asking about (suggesting) a stand-alone script that would handled this without actually deploying stuff.  Hmmm, I can see the value in such a script.  On the other hand, we really would like people to regularly update to newer versions of Viya Monitoring.  Would providing such a script make it easier for them to NOT do that?  Hmmm, updating a deployment does NOT currently force an update of certs.  Maybe that is something we should consider as well.  Let's discuss.


Cancel button should work differently

https://github.com/spring-guides/gs-crud-with-vaadin/blob/fbca9797d4901efde7f5c08695abbaaa0325ace7/complete/src/main/java/com/example/crudwithvaadin/CustomerEditor.java#L68
Hi! I made the tutorial and I really like it. I just realized that this line might be wrong here because when I cancel the "edit" operation the Editor should hide again. Therefore it makes sense to push null into the editCustomer function right?

To repeat what I wrote on the related PR: People may wonder what happened to the window, so I'm going to leave it as it is. This would make a good short blog post to share with the community, though.


[move] Disable Move global storage instructions

Motivation
Rooch currently supports the global storage instructions in Move(move_to|move_from|borrow_global|borrow_globao_mut|exists).
At the same time, we have also provided methods to operate global storage through AccountStorage. The two overlap in functionality, and if used together in the same function, bugs may occur due to inconsistent caching.
The global storage instructions use TransactionCache in session, and AccountStorage uses the cache in the raw table extension.
Advantages of the AccountStorage mode:

Borrowed resources can be returned from the function, and their lifetimes are bound to StorageContext.
It is easy to support application-specific state space in the future.

Solution

Use the verifier to report errors for global storage instructions during compile time.
Use the gas meter implementation to report errors for global storage instructions during runtime.
Finally, the ChangeSet must be empty in the session output.

Challenges

This approach may bring some new learning costs to developers and how to be compatible with existing Move libraries that use global storage instructions in the future. One idea is to have the compiler replace the global storage instructions with the corresponding function calls in AccountStorage during compilation.
Security evaluation: #82

I feel like it's okay.


flutter-engine: allow install of older version

some of the tools installed are only available in 3.7+ releases of the engine and some of them are bound to impeller-vulkan configuration.
Allow installation on older releases by ignoring missing files (for the ones that are not bound to a PACKAGECONFIG) or bind them to the respective configuration.

LGTM.  Thanks!


Is script "build:dev" missing?

It is begginer question.
Trying to build and run in dev mode but failed. I added this script "build:dev": "cross-env NODE_ENV=development webpack --progress", and build it, all goes fine.
Really this script is missing, and any professionals can add it manually, or there is another ways to build in dev mode that I am missing?

I think with just the regular dev script we have here, it should just be triggering all of that for you through dotnet.
https://github.com/MarkPieszak/aspnetcore-Vue-starter/blob/master/content/package.json#L10
It definitely would be good to have that either way, sometimes you definitely have to force a webpack rebuild after all!


webkitStorageInfo/webkitIndexedDB deprecation warning

'window.webkitStorageInfo' is deprecated. Please use 'navigator.webkitTemporaryStorage' or 'navigator.webkitPersistentStorage' instead. - setup.js:108
'webkitIndexedDB' is deprecated. Please use 'indexedDB' instead. - setup.js:108

Using Chrome.

Yeah, noticed that, but not sure what to do:
for (var member in window) {
  if (window[member] instanceof ReactiveDict) {
    dictionaries.push({
      name: member,
      dict: window[member]
    });
  }
}

window[member] instanceof ReactiveDict is the offending LOC

Fixed in 1.1.7.

I have installed latest version of babrahams:constellation (0.1.10) and using constellation:console 1.2.2 in the background but still having this issue.
It looks like the line affected is this one:
https://github.com/JackAdams/constellation/blob/master/client/lib/setup.js#L119
I am also having another warning: 'webkitIndexedDB' is deprecated. Please use 'indexedDB' instead. in the exact same line.

Well, that's disappointing.  Thought I'd fixed that.
I'm open to suggestions on how to fix this.  The error doesn't seem to match the code, but it's definitely that line that's causing the problem.
In the meantime, it's ugly but harmless.

All right. Got a fix for this. It's not pretty, but it works.
I'll release a new version soon.

1.2.3 fixes this.

Wow, that was quick :smile:
Thanks Jack!

I updated and it's fine here as well now. Thanks!

Cool. Thanks for the independent verification that all is well again.


Update paths to components and sections for new file structure

Project was not building due to the new locations of files. Old references were still in place in the app.js

Thank you for your help 😄😄


Add error parameter to storage.SiteExists()

SiteExists lacked an error parameter, this can be used when there are OS or networking errors

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Nice, thanks! /cc @cretz (building on his original PR)

@mholt LGTM...I originally didn't have this as the file storage originally didn't differentiate between non-existence and other error.


NSIG Extraction Error

Potential primary issue in title, although I cannot be sure.
Error was prompted by the following command:

mov-cli -s youtube tek it

Error linked below:
errorlog.txt

Try updating yt-dlp

Huh, that fixed it. Thanks!


[Bug 🐞]: Error: failed to create contract: failed to create contract: error extracting events

What happened?
The farmer is trying to set up some nodes on Terraform.
Farmer says: "Trying to set up some nodes on the grid yesterday, the same problem today again.
│ Error: failed to create contract: failed to create contract: error extracting events from block(0xc58415959c1226847381d8015a1e61b874e5a8edc84065a73df05252ec170bf5): failed to decode event: unable to find field Balances_Locked for event #37 with EventID [20 17]
What did you expect?
Should have set up the node on the grid without any issues.
What browsers are you seeing the problem on?
No response
ZOS info
No response
Dashboard info
No response
weblets info
No response
Relevant log output
N/a

could you please check the version you use? is it v1.9.2?


solve typescript error: Could not find a declaration file for module 'cookies-js'.

"typings": "./dist/cookies.d.ts",

Shouldn't the key be types rather than typings? See https://www.typescriptlang.org/docs/handbook/tsconfig-json.html


Subscribe only to metrics feed from firehose

At the moment the Firehose function from the NOAA consumer is used. When instead using FilteredFirehose and restricting to only get the metrics we can avoid LogMessage events being sent at all. This leads even on an environment without many application to a meaningful reduction of

network bandwidth and
cpu utilization.

+cc @mkuratczyk please feel free to add your comments. And thanks a lot for doing all the testing.

Indeed. In my tests I was generating logs that amounted to 8MBps ingress traffic on the firehose VM and firehose_exporter was consuming 25% of the CPU. After switching to Markus' version network ingress dropped to almost nothing and firehose_exporter doesn't even make it to the top by CPU list.

Thanks @mrbuk for this contribution, and @mkuratczyk for testing it!


implemented a new feature that Hashie::Mash.load accepts a Pathname object #331

As suggested on https://github.com/intridea/hashie/issues/331, I implemented the feature so that Hashie::Mash can also load a Pathname object.

Please also squash your commits and update CHANGELOG and README.

@dblock , I updated the code as you suggested but accidentally I deleted this pull request. Sorry. So I newly created another pull request on #337 .
Could you see the page?


MySQL Version Not Found

I started getting the following error today:
STDERR: E: Version '5.5.49-0+deb7u1' for 'mysql-client-5.5' was not found
---- End output of apt-get -q -y install mysql-client-5.5=5.5.49-0+deb7u1 ----
Ran apt-get -q -y install mysql-client-5.5=5.5.49-0+deb7u1 returned 100
Having done a bit of googling I'm wondering if it's something similar to this - https://github.com/chef-cookbooks/mysql/issues/439
I searched the codebase and could only find reference to 5.5 so perhaps this is not an issue with the recipe but instead an issue with debian package manager?
I'm using debian 7.8

OK I have ran the test kitchen by hand and it works fine, it installs 5.5.50-0+deb7u2.  The error I was getting is from a Jenkins automated build.  This is very confusing as I run the same commands by hand as I do in the build script.  The only difference is the user that builds run as but I don't know why that would make a difference.  Regardless it's looking less likely to be an issue with this recipe so I'll close this issue.


Host chain allows overwriting of the active channel

Summary
The host chain assumes the controller chain will never allow a channel to OPEN if it is not in the active channel mapping.
Problem Definition
OnChanOpenConfirm will overwrite an active channel. This is fine for creating a new active channel after the previous one closed, but if the controller chain allows two channels to be opened for the same port (by incorrectly accounting for active channels), then this will overwrite an existing active channel
Proposal
Be defensive. If an active channel exist, return an error. Please add a test case for this scenario

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

@AdityaSripal I think this should be updated in the spec

But if the controller chain rewrites the active channel, shouldn't the host chain just use the latest active channel? I fail to see an attack here

The host chain assumes the controller chain will never allow a channel to OPEN if it is not in the active channel mapping.

I don't understand this point. The current architecture will allow a controller chain to initialize a new channel as many times as it likes. I don't understand why this would be a security issue.
The only potential vulnerability I see here is in the case where a relayer could spam channel creation after the first InitInterchainAccount and potentially stop packets from reaching the interchain account (by overwriting the active channel by spamming channel creation on the bound port for a specific interchain account).

But if the controller chain rewrites the active channel, shouldn't the host chain just use the latest active channel? I fail to see an attack here

There's a race condition here though right? If chainA ACKs channel-1 and channel-2 on the same port. A relayer could decide which becomes the active channel on chainB by submitting the OpenConfirm in a certain order. We could end up in a state where the controller active channel does not equal the host active channel (and it cannot be fixed)
I think the host chain should defensively consider overwrites of an active channel on the controller chain as byzantine behaviour (not necessarily attacking, but something is going wrong)

Action items:

[ ] Ensure only 1 active channel can be created on ACK by checking if active channel exists + and is open
[ ] document that host (in OpenConfirm) assumes controller only allows 1 channel to be ACK'd
[ ] ensure specs have this check
[ ] do defensive check in OpenTry


Poor performance when handling long lines

I tried the program, and one of the first issues I found was that when there are many long lines, the program becomes very sluggish and slow.
After copying and pasting the same text for a while, a part of the text suddenly disappears. It seems like a rendering issue.

I am using UWP system control (RichEditBox) as my Editor base and it comes with limitations. One of the limitations is what you just described and the reason here is actually because the limitation on the ScrollViewer. There is a rendering size limit on what it can render. Also, please take a look at my reponse for similar issue: https://github.com/JasonStein/Notepads/issues/10

Please also take a look at these:
https://github.com/windows-toolkit/WindowsCommunityToolkit/issues/2858
https://github.com/microsoft/microsoft-ui-xaml/issues/108

https://github.com/microsoft/microsoft-ui-xaml/issues/1842


feature clarification: cross-linker/cross-linked residue

There is a cross-linker (MI:0911) but no cross-linked residue. It is not clear how to use it. is it supposed to refer to cross-linked residue  or actual cross-linker ? if latter (although I cannot come up with a use case) than a new term is needed in order to annotate cross-linking sites. Otherwise definition of the term got to be modified...

Sure, I agree with your argument. I am just asking if you need the term for curation outside IMEx boundaries. I just do not want to create the term if there is not actual use case for it. If your answer is a definitive 'yes', I'll create the term.


Docker image up

First of all thank you Awawa again for a great job. This version looks amazing, if someone is interested on a Docker image of the latest version (v17) here is the link https://hub.docker.com/r/nocturno/hyper-hdr . This is an AARCH64 docker image. Any problem related to the Docker image or if you prefer to build your own image here is the place https://github.com/appleimperio/docker-hyperhdr.

Thanks @appleimperio  👍
I move it to the Discussion


updated code for drag and drop

Please implement the transformer back again. Either you haven't pulled correctly or you removed but we need it to resize and rotate the images and including the transformer the whole StarShape component is gone.. Please look at this commit: 07397ab and see how i implemented it

I did some changes, can you please review them


[FR] tighten line spacing for line-wrapped headings

Is your feature request related to a problem? Please describe.
Some of my notes' headings span multiple lines on my small mobile device.  The space between those lines looks wrong (too large).  For example, there is more space between line 1 and line 2 of the heading than there is between the (entire) heading and the following body text.
Describe the solution you'd like
Ideally the theme's CSS would be altered to reduce the line-height for headings compared to that for body text.
Describe alternatives you've considered

I looked for but could not find a related setting in Style Settings.
I looked for but could not find any obvious way (as a novice Obsidian user) to override heading line height globally.

This should now be addressed in Version 2.3.0.

It's perfect now.  Thank you, @damiankorcz.


Thread GUI

The current iteration of the gui is single threaded. This is unoptimal as some tasks take a noticeable length of time to complete. Threading the process should address these issues.

Work on GUI threading has been completed and pushed to threading branch. Completed in commit  93381febc0add4fc1ff3fae8fadfc9ba7be1d476.


Fix Snowflake table storage metrics

What does this PR do?
Report additional tags and metrics for Snowflake table storage.
Motivation
Snowflake table storage metrics reported confusing data in the following cases:

Tables with the same name in different databases - fixed by adding a database tag.
Tables that have been deleted and recreated. The underlying view contains a row for each table, including deleted ones. Since the query averaged each group, the results were extremely inaccurate. Fixed by adding deleted tag and metrics aggregated using sum.

Additional Notes

Review checklist (to be filled by reviewers)

[x] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[X] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Looks good but we can wait for Ilia to give final approval!


render_cell plugin hook's row object is not a sqlite.Row

From https://docs.datasette.io/en/stable/plugin_hooks.html#render-cell-row-value-column-table-database-datasette:

row - sqlite.Row
The SQLite row object that the value being rendered is part of

This appears to actually be a CustomRow, but I think that's unrelated to my issue.
I have a table:
CREATE TABLE IF NOT EXISTS "dss_job_stats"(
  job_id integer not null references dss_job(id) on delete cascade,
  host text not null,
  // other columns elided as irrelevant
  primary key (job_id, host)
);

On datasette 0.63.2, the render_cell hook receives a row value that looks like:
CustomRow([('job_id', {'value': 2, 'label': '2'}), ('host', 'cldellow.com')])

I expected the job_id value to be 2, but it's actually {'value': 2, 'label': '2'}.
I can work around this, but was wondering if this was intended behaviour?

Thanks for catching this!
Definitely a bug. This might be a good opportunity to reconsider how his should work though.
It's possible that Datasette will eventually support alternative database backends - PostgreSQL, DuckDB and ClickHouse are all on my radar here.
If that happens, this plugin hook returning a SQLite Row wouldn't make sense.
Some kind of thing abstraction layer - maybe CustomRow, maybe something a little bit better - might be a good idea.

Thanks for the response!
Yes, it does seem like a pretty nice developer experience--both the automagical labelling of fkeys, and the ability to index the row by column name in addition to column index.

A +1 for switching to CustomRow: I think you currently only get a CustomRow if the result set had a column that was an fkey (this code)
Otherwise you get vanilla sqlite3.Rows, which will fail if you try to access .columns or lookup the cell by name, which surprised me recently


Add Java package org.json

package found at https://github.com/stleary/JSON-java
Bundle from https://mvnrepository.com/artifact/org.json/json/20160810
This is the JSON parser included in Android (though probably not the exact version).
This parser does not auto-detect type, nor handle plain values, so the test script
includes some simple logic to dispatch to correct object parser.

Thank you.
I find interesting that this parser will reject any document with duplicated keys in objects.


Fix JUnit5 extension bug when using both declarative + programmatic simultaneously

This fixes #2122, please see the issue described there for details.
This PR makes it so that the options of httpPort/httpsPort/httpsEnabled/proxyMode and anything else that might be configured through the @WireMockTest attribute for a declarative setup in JUnit5 does not override programmatically configured options.

Please can we fix the formatting issues so that the tests can run?

Thanks, and sorry for the wait!


Fix #37

Fixes #37

So, this PR got huge—I've refactored URI parsing into a separate module, and at the same time:

I've moved to the Python 3.10-style Union type hints (A | B instead of Union[A, B], and A | None instead of Optional[A]), especially that a new version of Pydantic allowed to do that for schemes, too.
Extracted the existing enums (while I was adding the new ones, that were required for the feature).
Removed some redundancy.
Fixed some additional "UI/UX"-ish bug.

It could be more granular, but this is work that I started a few months ago and tackled whenever I had spare time and motivation, so after I already got carried away, I decided to just finish this in the current form and be done with it.
I suggest reviewing the PR commit per commit, as I tried my best to keep at least single commits granular.
I've also considered adding unit tests to that specific feature because during the development I've some crude "manual tests" in the onetimepass.otpauth.uri.main. My plan was to convert them into proper unit tests.
Unfortunately, I didn't commit them, then at some point, I cleared the main function, and when I got aware about this, it was already too late 😞
And the initial plan to implement them from scratch resulted in big procrastination, so I've decided I will push the PR w/o unit tests, just like the rest of the app, and will go back to that later.


GPS Info App: Show satellites "in view" separated by GNS-system; 2. Spirit Level App: Now also visible on Bangle.js 2

Does anybody ever seen a GLONAS satellite?

Thanks! With the spirit level I guess the colour issue is that it doesn't support themes?
If it used g.theme.fg and not 1,1,1 as the colour I bet that'd fix it properly without HW-specific defines. I'll do that now though

Sure you're right with the themes, but it's not running in the emulator and I don't have a Bangle.js 1


Dronekit assumes first waypoint as home location

On APM the home location is stored as the first waypoint. This is not the case for PX4.
Throughout dronekit the assumption that the first waypoint (sequence 0) will be the home location is being implemented. It will even set this location on a clear().
This results in numerous issues when working with DroneKit on PX4.
One such issue is already reported here: https://github.com/dronekit/dronekit-python/issues/725
The code should be thoroughly sweeped and made autopilot aware. APM seems to be the exception here as the mavlink spec says nothing about special treatment of the first waypoint.

Agree.

yep I got exactly the same problem see my issue here: https://github.com/dronekit/dronekit-python/issues/720

Any updates on DroneKit and PX4 compatibility?

@affourtit2 There isn't any particular work going on to support PX4 compatibility other than making sure that it broadly works. More specifically, there is a problem if this does not work: http://dev.px4.io/en/robotics/dronekit.html
PX4 is now concentrating development effort on the Dronecode SDK. Most work on DroneKit is from interested community members.
Upshot, PRs are accepted, but don't expect that ti will become more compatible in any signficant way, any time soon.

@hamishwillee I will investigate Dronecode SDK, then. Thank you for your response!

@hamishwillee so is that possible to work fine by installing Ardupilot multiple flight stacks instead of PX4? I am using Pixhawk 4 controller.


Improve and correct some error messages and warnings

THIS PULL REQUEST IS READY TO MERGE
Feature or improvement description
This PR corrects some error messages and warnings to be more precise and helpful for the user to debug errors in their MD input file. For example in MoorDyn_IO.f90 when a user used an unsupported output quantity the QType of this quantity was given in the error message, but to my mind it is more intuitive for users to output the name of the requested but unsupported quantity.
In addition, in MoorDyn.f90 there is an error "Unable to find matching rod type name for Rod". This was packed in an if-condition and thus were never thrown even if MD wasn't able to find matching rod type. This is repaired with this PR.
Impacted areas of the software
MoorDyn v2
Test results, if applicable
Not applicable. This PR should not touch the test results.

Thanks!


debounce refresh on widgets after global config changes

global config changes should have a debounce of ~200ms (or so) to prevent wasted requests to the prometheus backend if the user is rapidly updating date/range global settings.

closed by #290


When styles object is empty don’t render style attribute

Currently an empty styles object will server render the style attribute e.g.

 when what we really want is

. This is a slight inconsistency with React (and I think Preact?).
This sounds quite benign but as we don't allow inline styles in our CSP rules the addition of this attribute is quite major.. especially as React Router's Link seems to default this to an empty object.

Ahh very interesting!

Just need to double check a benchmark before I cut a release with this - it changes the return value of that util function so it can produce 2 types instead of a single type, but I think in this case it will be harmless.


Thx for a najs starter-kit ^_^

Here's where I brought it - Watch the video. Created from your template ...

Thanks for the notice and feedback, will have a look 😉

NP, loved your template. Very tidy, neat and concise. I'm not too skilled with Angular myself, so using something like this in my own stuff, makes my job a lot easier. I'll give you credits in its main "Credits" section in the next release. But for now, you'll find a link to your amazing starter-kit in the scaffolded results as you generate a frontend ... ^_^
Pssst, if you've got tips and tricks for how to apply even more cool settings during my scaffolding process, I'd appreciate it ...


HTTP 406 on find/delete customer in Sandbox

I'm not sure if this is just an issue with the sandbox but periodically when our integration tests run we get this exception:
com.braintreegateway.exceptions.UnexpectedException: Unexpected HTTP_RESPONSE 406
Customer customer = gateway.customer().find("the_customer_id");
When it should be a NOT_FOUND exception.
Are any others getting this exception? Should I bring this up with braintree support?

@agentgt,
Sorry for the weird responses you're receiving! I'd be happy to investigate these requests, but since I'm going to need specific information about your account, would you mind pinging<EMAIL_ADDRESS>Feel free to ask for me and I'll take a look at your Sandbox requests.
Cheers,
Cory
Braintree Developer

Ah, I was trying to use email addresses like<EMAIL_ADDRESS>as the customer id ... doesn't sound like this will work?


feat(JS): Added fetch-get-rquest.js.

Normal fetch GET API request with Authorization header.

I would use axios, or put a note in the code that it uses node-fetch 2.x because version 3.x is for ESM.

Yeah I agree with using axios, hence why I added "fetch" to the file names indicating that the example is using node-fetch/fetch.


Use second in the date timestamp when creating the directory

Since we are using a same GCP bucket for all the bundles produced by snc/installer PR and right now the bundles directory structure depend on the https://github.com/code-ready/snc/blob/master/createdisk-library.sh#L14 date which means new bundles override old one if produced on same day so better to include seconds field as part of directory creation.

Maybe it's possible to add the PR number in the directory structure? Only keeping the latest bundles for a PR should be good enough, and will save some space.

@cfergeau yes that also a possible solution, will  try that.


[EventRequest] Page 113 Budget.DimCodeToType

Please add new event
local procedure DimCodeToType(DimCode: Text[30]): Enum "G/L Budget Matrix Dimensions"
var
    BusUnit: Record "Business Unit";
    GLAcc: Record "G/L Account";
    //-------------------------------OnBeforeDimCodeToType:BEGIN
    GLBudgetMatrixDimensions: Enum "G/L Budget Matrix Dimensions";
    IsHandled: Boolean;
    //-------------------------------OnBeforeDimCodeToType:END
begin
    //-------------------------------OnBeforeDimCodeToType:BEGIN
    OnBeforeDimCodeToType(DimCode, GLBudgetMatrixDimensions, IsHandled);
    if IsHandled then
        exit(GLBudgetMatrixDimensions);
    //-------------------------------OnBeforeDimCodeToType:END
    case DimCode of
        '':
            exit("G/L Budget Matrix Dimensions"::Undefined);
        GLAcc.TableCaption():
            exit("G/L Budget Matrix Dimensions"::"G/L Account");
        Text001:
            exit("G/L Budget Matrix Dimensions"::Period);
        BusUnit.TableCaption():
            exit("G/L Budget Matrix Dimensions"::"Business Unit");
        GLSetup."Global Dimension 1 Code":
            exit("G/L Budget Matrix Dimensions"::"Global Dimension 1");
        GLSetup."Global Dimension 2 Code":
            exit("G/L Budget Matrix Dimensions"::"Global Dimension 2");
        GLBudgetName."Budget Dimension 1 Code":
            exit("G/L Budget Matrix Dimensions"::"Budget Dimension 1");
        GLBudgetName."Budget Dimension 2 Code":
            exit("G/L Budget Matrix Dimensions"::"Budget Dimension 2");
        GLBudgetName."Budget Dimension 3 Code":
            exit("G/L Budget Matrix Dimensions"::"Budget Dimension 3");
        GLBudgetName."Budget Dimension 4 Code":
            exit("G/L Budget Matrix Dimensions"::"Budget Dimension 4");
        else
            exit("G/L Budget Matrix Dimensions"::Undefined);
    end;
end;

[IntegrationEvent(false, false)]
local procedure OnBeforeDimCodeToType(DimCode: Text[30]; var GLBudgetMatrixDimensions: Enum "G/L Budget Matrix Dimensions"; var IsHandled: Boolean)
begin
end

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Add command descriptions in doc

Update sphinx-click to the master branch
Closes #1819
Preview

This is cool, but why can’t we wait until it’s pushed to PyPI?

Because I think the command docs will help new comers get into pipenv more quickly, but the release schedule can't be predicted.
But if you insist on not adding git editables to dev-package, I will update the Pipfile as soon as it is released.

I’m more in favour of following stable releases.

I’m more in favour of following stable releases.

I've gone ahead and released 1.1.0. You can use this now.

@stephenfin, thanks for that

because of the package dependencies change, please merge this to fix the CI failure

because this pr only updates Pipfile.lock, I'd like to close it to keep the commit log clean.


Fix httpclient deadlock

Fixed a deadlock issue as well as some crashing issues with restarting downloads.

This deadlock bug is severe, so a new release including the fix is appropriate


⚠ Bofrost.at has degraded performance

In ec977ac, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1623 ms

Resolved: Bofrost.at performance has improved in 41d6a93 after 7 minutes.


Select between "append" and "replace" completion behavior

If the cursor is in the middle of an identifier, there are two reasonable ways to do completion:
function(x) foo {}

function main() {
    fo|quux()
}

One is it "append" text to the cursor:
function(x) foo {}

function main() {
    foo(|)quux()
}

Another one is to replace existing identifier:
function(x) foo {}

function main() {
    foo(|)
}

In IntelliJ, the behavior depends on the key used for completion (Enter appends, Tab replaces).
I think currently it's impossible to express this feature in the LSP, because CompletionItem comes with a fixed text-edit, so the server needs to pick some option.

In IntelliJ, the behavior depends on the key used for completion ( appends,  replaces).

That seems related to my suggestion in https://github.com/microsoft/vscode/issues/70824.

So the completion item would basically need to provide two different edits.

Either that, or resolveCompletionItem could tell the server which variant is required.

We started to work on this in VS Code.

This got already implemented and documented in the 3.16 spec.


Need scope=public_content

I was stuck on your instructions for adding Instagram Access Token, as when I use your app, I was receiving:
This request requires scope=public_content, but this access token is not authorized with this scope.
The user must re-authorize your application with scope=public_content to be granted this permissions.

I did a search online and realized that the URL you have for step 9 needs an additional &scope=public_content
Once I did that, my access token worked and I could retrieve images.

Thanks. I think this has something to do with Instagram's API changes that finally kicked in June 1st. Will investigate soon!

Actually, I'm not sure it's working. I can download my own IG photos just fine, but I can't retrieve anyone else's. For example:
ragamints download -u therock -c 5
Specify --help for available options
ragamints: Could not find user ID for therock

Will check, thanks (but low expectations, I'm afraid).

Sorry for the delay. This is indeed as bad as it looks. I've updated the documentation to reflect on Instagram API change, and the token issue (thanks).
Tools such as ragamints are now considered invalid use cases and constrained to a Sandbox mode. This effectively blocks most of ragamints functionalities. You will need to generate a new access token, which will grant you access to your 20 most recent media, with reduced API rate limits. That’s about it. You will no longer be able to download photos from other Instagram accounts, perform searches, or access any of your photos past the first 20. I will keep ragamints alive for the time being, should Instagram relax its policy. Sad.

Hi, @sebastienbarre. Your ragamints is awesome. But i also stuck on this part of setting the access token configuration:

setting the RAGAMINTS_ACCESS_TOKEN environment variable beforehand.

$ export RAGAMINTS_ACCESS_TOKEN=[ACCESS_TOKEN]

or setting the corresponding option in a default .ragamints.json configuration file in your HOME directory, or any other configuration file of your choosing using the --config option.

{
  "access-token": [ACCESS_TOKEN]
}

So what i ask is, where is the folder that i should put line of my current access-token (i already got it) ?
thanks before

@davdevtokaekoen Thanks. The .ragamints.json file needs to be in your HOME directory. This is your usual home directory on Unix/OSX. For example, if you try this in a terminal:
$ echo $HOME
/Volumes/Users/barre

So my config file is at /Volumes/Users/barre/.ragamints.json
Does it work for you?

@sebastienbarre
Seems to be worked.

So, what i did, I already added line of access token like this:
...., "version": "1.3.1", "access-token": "MY_ACCESS_TOKEN"
Is it correct?

So, i performed downloading but i got such a results like this, when i typed syntax:
ragamints download --access-token [MY_ACCESS_TOKEN] -u [INSTAGRAM_USERNAME]
the result is user id not found (the name of user):
 Could not find user ID for [USER_ID]

Would you tell me what is wrong?

@davdevtokaekoen

why is there a "version" keyword in the file? What is the name and location of the file you put the token in? on which operating system?
if your access token is in your configuration file (.ragamints.json), then you don't need to specify it when calling ragamints. For example:

$ ragamints download -u sebastienbarre -c 1
Found user ID 26667401 for username sebastienbarre
Found another 1 media(s), nothing more.
#0001 [Or maybe those are] Fetched 2016-09-09_1473390756.jpg
#0001 [Or maybe those are] Updated metadata in 2016-09-09_1473390756.jpg
Done iterating over 1 media(s). Easy peasy.

Lol i forgot it, yes im using windows 10 and its location is in user
folder/Roaming/npm/npm-modules/packages.json
Yes, only file named 'packages' that has extension .json. Also, in
ragamints folder, there isn't ragamints.json, but packages.json too. So,
how?
On Fri, Sep 9, 2016, 23:23 Sébastien Barré<EMAIL_ADDRESS>wrote:

@davdevtokaekoen https://github.com/davdevtokaekoen

why is there a "version" keyword in the file? What is the name and
location of the file you put the token in? on which operating system?
if your access token is in your configuration file (.ragamints.json),
then you don't need to specify it when calling ragamints. For example:

$ ragamints download -u sebastienbarre -c 1
Found user ID 26667401 for username sebastienbarre
Found another 1 media(s), nothing more.
#0001 [Or maybe those are] Fetched 2016-09-09_1473390756.jpg
#0001 [Or maybe those are] Updated metadata in 2016-09-09_1473390756.jpg
Done iterating over 1 media(s). Easy peasy.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sebastienbarre/ragamints/issues/48#issuecomment-245963945,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOJOuJpda-ZwI-rUfUJOIX4nNP6bCJYlks5qoYgUgaJpZM4I5O2u
.

I'm afraid this is not at all where your user directory is on Windows 10. Do not add anything to any packages.json file in the npm-modules directory, you would likely corrupt the file or your NPM installation. You need to create a new ragamints.json file. Your users directory is likely in C:\users\<username> (see onedrive - How to rename the User folder in Windows 10? - Super User for example).

Oh, i see.
So i have to make new file "ragamints.json" in my C:\Users\my_user_folder,
is correct what i got?
Then, only just add the line of "access-token: [my_access_token]"? Only
contains my access-token?
On Sat, Sep 10, 2016, 00:08 Sébastien Barré<EMAIL_ADDRESS>wrote:

I'm afraid this is not at all where your user directory is on Windows 10.
Do not add anything to any packages.json file in the npm-modules
directory, you would likely corrupt the file or your NPM installation. You
need to create a new ragamints.json file. Your users directory is
likely in C:\users<username> (see onedrive - How to rename the User
folder in Windows 10? - Super User
http://superuser.com/questions/890812/how-to-rename-the-user-folder-in-windows-10
for example).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sebastienbarre/ragamints/issues/48#issuecomment-245976221,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOJOuG-QgZ9aTiXl2lkfpNS4FLix8SQWks5qoZJzgaJpZM4I5O2u
.

And the token needs to be inside curly braces:
{
  "access-token": "26667401.08bd1....fdsadwe",
}

@sebastienbarre
Okay so far i already done it as you told me.
But when i tried with instagram user (it is public user), i got this:
ragamints: Could not find user ID for [instagram_username_i_tried]
On Sat, Sep 10, 2016 at 12:33 AM, Sébastien Barré<EMAIL_ADDRESS>wrote:

It has a dot in front of it: .ragamints.json, not ragamints.json.
And the token needs to be inside curly braces:
{
"access-token": "26667401.08bd1....fdsadwe",
}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sebastienbarre/ragamints/issues/48#issuecomment-245983164,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOJOuPtxQNGGAD6Z3CUtr6W5YqOqxwgxks5qoZhSgaJpZM4I5O2u
.

also when i see the config file:
ragamints download --config
Invalid JSON config file: true
i already made file named ".ragamints.json" in my C:\Users\my_username\
On Sat, Sep 10, 2016 at 8:04 AM, google google<EMAIL_ADDRESS>wrote:

@sebastienbarre
Okay so far i already done it as you told me.
But when i tried with instagram user (it is public user), i got this:
ragamints: Could not find user ID for [instagram_username_i_tried]
On Sat, Sep 10, 2016 at 12:33 AM, Sébastien Barré <
<EMAIL_ADDRESS>wrote:

It has a dot in front of it: .ragamints.json, not ragamints.json.
And the token needs to be inside curly braces:
{
"access-token": "26667401.08bd1....fdsadwe",
}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sebastienbarre/ragamints/issues/48#issuecomment-245983164,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOJOuPtxQNGGAD6Z3CUtr6W5YqOqxwgxks5qoZhSgaJpZM4I5O2u
.

You need to give the full path to the config file to try it --config:
ragamints download --config /Volumes/Users/barre/.ragamints.json -u sebastienbarre -c 1

How about when i tried with downloading instagram user:
ragamints: Could not find user ID for [instagram_username_i_tried]
On Sat, Sep 10, 2016, 09:06 Sébastien Barré<EMAIL_ADDRESS>wrote:

You need to give the full path to the config file to try it --config:
ragamints download --config /Volumes/Users/barre/.ragamints.json -u sebastienbarre -c 1
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sebastienbarre/ragamints/issues/48#issuecomment-246081747,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOJOuJl3YRpmOsC0J3mK9fxbxu7r4L_wks5qohC6gaJpZM4I5O2u
.

Try with my username, sebastienbarre.

Still the result is could not find user. i exactly typed as you told me.
On Sat, Sep 10, 2016, 09:10 Sébastien Barré<EMAIL_ADDRESS>wrote:

Try with my username, sebastienbarre.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sebastienbarre/ragamints/issues/48#issuecomment-246081942,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOJOuN7cTuURAHUb3mDfYHvaD09XH8bWks5qohGlgaJpZM4I5O2u
.

Btw, Has access token a expiry date?
On Sat, Sep 10, 2016, 09:18 google google<EMAIL_ADDRESS>wrote:

Still the result is could not find user. i exactly typed as you told me.
On Sat, Sep 10, 2016, 09:10 Sébastien Barré<EMAIL_ADDRESS>wrote:

Try with my username, sebastienbarre.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sebastienbarre/ragamints/issues/48#issuecomment-246081942,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOJOuN7cTuURAHUb3mDfYHvaD09XH8bWks5qohGlgaJpZM4I5O2u
.

I don't think so. Try entering your use ID directly, instead of your user name. You can find your user ID here for example

It's work, you genius! But why the result is no photos:
Done iterating over 0 medias.

Where are photos be saved?
So, why i couldn't download with the ig username directly?
Say i just want to download all photos of user, is there specific
options?

On Sat, Sep 10, 2016, 09:22 Sébastien Barré<EMAIL_ADDRESS>wrote:

I don't think so. Try entering your use ID directly, instead of your user
name. You can find your user ID here for example
https://smashballoon.com/instagram-feed/find-instagram-user-id/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sebastienbarre/ragamints/issues/48#issuecomment-246082506,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOJOuNmuzJrzDXY26bOadUIEe82_Sg-Rks5qohRRgaJpZM4I5O2u
.

You have to tell ragamints how many photos you want. -c 1 means one photo. -c 10 means the last 10 photos.

the photos are saved in the same directory where you ran ragamints, unless you use the -d or --dest to specify a different destination directory,
no clue, the Instagram API was changed back in June, this may have affected this feature,
use -c to specify how many photos you want...

Seems get more weird :(. Here's the screenshot:
On Sat, Sep 10, 2016 at 9:49 AM, Sébastien Barré<EMAIL_ADDRESS>wrote:

You have to tell ragamints how many photos you want. -c 1 means one
photo. -c 10 means the last 10 photos.

the photos are saved in the same directory where you ran ragamints,
unless you use the -d or --dest to specify a different destination
directory,
no clue, the Instagram API was changed back in June, this may have
affected this feature,
use -c to specify how many photos you want...

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sebastienbarre/ragamints/issues/48#issuecomment-246083931,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOJOuOFpUpLyGyG-_PxlcwjBoZmdwO7Cks5qohrNgaJpZM4I5O2u
.

@denchen How about you? Did u succesfully used ragamints?

@davdevtokaekoen I stopped using this package because of the Instagram API changes that disallow fetching photos other than your own.

@denchen a pain, I know, but I'm working on circumventing the issue, to some extent, see #49.


Add LongestIdle option to routing methods in SetCsCallQueue and NewCsCallQueue along with a description

Docs Build status updates of commit 99733c0:
:clock10: Full build: the average full build time is 18 min(s) 9 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 99733c0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/New-CsCallQueue.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsCallQueue.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 1534d24:
:clock10: Full build: the average full build time is 18 min(s) 9 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 1534d24:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/New-CsCallQueue.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsCallQueue.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 1d43398:
:clock10: Full build: the average full build time is 18 min(s) 9 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 1d43398:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/New-CsCallQueue.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsCallQueue.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Expose Key interface in Cardano.Api.Shelley

Sorry for this unsolicited PR, it is not crucial for us, but we wanted to get also your feedback on:
In the Hydra project we are using the cardano-api quite heavily and thought we could distinguish Hydra key types using the same framework, but just with a new Hydra key role.
Unfortunately it was not possible because some of the type class definition was not exported.
This PR exposes the full type class to be able to define instances of it and having a Hydra key role, this yields SigningKey Hydra and VerificationKey Hydra key types.
See also this PR: https://github.com/input-output-hk/hydra-poc/pull/398

it looks good to me, and I especially love :heart: the added documentation. but I'm not really an owner of the API and I don't know if not exposing the full type class was intentional...

I especially love the added documentation.

:open_mouth: There should not be any documentation changes. Was probably in diff because it was not fast-forward to master again. Rebased now.

I especially love the added documentation.

:open_mouth: There should not be any documentation changes. Was probably in diff because it was not fast-forward to master again. Rebased now.

@ch1bo So to me, I think you should implement the instance in cardano-api. Why? Because then we don't have scattered cardano-api Key instances . Exporting the Key typeclass I think is a bad idea.

@ch1bo So to me, I think you should implement the instance in cardano-api. Why? Because then we don't have scattered cardano-api Key instances . Exporting the Key typeclass I think is a bad idea.

What in particular makes you think it's a bad idea?
Adding the Hydra Key instances to the cardano-api would make them part of this API and any breaking change to it would mean a breaking change of the API, e.g. when switching the digital signature scheme - this is even likely to happen.
We understood the Key typeclass to be an extension point and wanted to avoid some boilerplate downstream. Is this not the case?

What in particular makes you think it's a bad idea?
A user wanting to interact with "cardano" via the api will now have to search for the hydra key instances (if they also want to use them). It would be better if everything lived in cardano-api so a user does not have to go searching for the things they need.

Adding the Hydra Key instances to the cardano-api would make them part of this API and any breaking change to it would mean a breaking change of the API, e.g. when switching the digital signature scheme - this is even likely to happen.
This is fine
We understood the Key typeclass to be an extension point and wanted to avoid some boilerplate downstream. Is this not the case?
You can add what you need to cardano-api. What about a Cardano.Api.Hydra module? I can give you permission in the CODEOWNERs file to make changes to it without my approval.

Should they need/want access to some key management functionality for these keys in Haskell, we would provide a hydra-api package containing these things (does not exist right now)

Ok fair enough.

bors r+


Comments and feedback from full review of paper - August 2024

I'm opening this issue to track comments and feedback from the full review of the paper that I've just completed.
There are a few minor fixes that I'll submit in a PR, as well as some (mostly minor) more general points. I'll detail these here and they can then be linked to other issues if more discussion is required. I'll open separate PRs for suggested updates to separate them from minor fixes such as typos in order to simplify integrating, altering or rejecting proposed changes on a case-by-case basis.

Comments up to the end of section 4.3.4:

[ ] Introduction: In paragraph 5, “This community paper…” - it states that the paper defines core values and foundational competencies “…agnostic of specific technical capabilities…”. I’m not sure if this is a fair statement since many elements of the competencies are highlighting specific technical skills and requirements. I guess things are mostly programming language-agnostic but I don’t know that I’d say agnostic of technical capabilities.

[ ] Terminology: The definition of “Researchers” here seems too simplistic - it’s effectively saying that use the term “Researchers” to refer to anyone who makes use of the services provided by RSEs. I wonder if something slightly more detailed might be preferable? e.g.
“Researchers: Postgraduate research students and faculty members at all levels who are undertaking or leading work, within a single subject domain or across multiple domains, to develop new ideas and conclusions, verify and build upon existing findings and discover new knowledge. In the context of this paper, we consider these researchers to be consumers of the services provided by Research Software Engineers.

[ ] Start of 3.1.2: “RSEs are often experienced professionals who instruct and work closely with early career researchers.”. I’m not sure if I entirely agree that RSEs “instruct” ECRs? Maybe say: “RSEs are often highly experienced professionals who work closely with and provide technical training and guidance to early career researchers.”

[ ] Section 4: Foundational competencies - the start of this section provides a description of what we see as the role (or the positioning of the role) of the RSE. I think that in general, the paper takes a view of RSEs that falls very much towards the research end of the “RSE continuum” that spans from a role that looks the same as that of a researcher at one end to one that looks the same as a professional software engineer working in an industry environment at the other. While I don’t disagree with this and can identify with it from a personal perspective, we’re also increasingly seeing RSEs whose roles look quite different and are not so connected to the research lifecycle, even though they are writing code to support or undertake research.
Do we want to make some comment here, at the start of section 4 about RSE roles and the routes into the RSE profession changing as it develops? We could say that “we work with the model of the RSE as it is described here, because it fits best with the current environment in the research community in Germany, but as things develop, we recognise that roles may be more focused towards the (R) or (SE) side of RSE and training and skills development efforts will need to take this into account.”?

[ ] Section 4: Three pillars - Also in the intro to section 4, there is mention of “the three pillars”, I’m keen that these are not confused with the 4 pillars of RSE (which we haven’t referenced, but could) - I realise that the 4 pillars are taking a slightly different view of RSE looking at related activities beyond SE, and from the basis of what works from the perspective of institutional provision of RSE activities and support. Nonetheless, I think they’re still relevant in the context of the paper.

[ ] Section 4.1: With the increasing interest and awareness around “green computing” and efficiency, should we also have a sustainability section in 4.1, highlighting knowledge around efficient algorithms and code optimisation as an important competency for managing efficient and effective usage of resources that often have a major carbon footprint, especially in the context of, for example, the training of LLMs?

Some minor edits such as typo fixes and minor rewording up to the end of 4.3.4 are included in 0bcb3b6. PR to come soon for minor edits to the full paper.

Item 2 is maybe addressed by f23dfcd

@jcohen02 Do you think we can close that?

OK, item 5 and 6 look like sth. that could be tackled with a small MR.


Fix build deploy

This change allows the following workflow to work:
make clean # remove broker from build now
make build PROJECT=YOUR_DOCKER_HUB_ORG
docker push docker.io/YOUR_DOCKER_HUB_ORG/ansible-service-broker-apb:latest
make deploy # deploys to local oc cluster

This workflow uses the settings found in etc/dev.config.yaml.

One thing I don't like is that make build ASSUMES ansibleplaybookbundle as the PROJECT.

One thing I don't like is that make build ASSUMES ansibleplaybookbundle as the PROJECT.

I know what you mean, but IMO it works as a default in that it's useful for CI & releasing images. Also, it errors when a user tries to use it without permission.  To summarize my opinion, it's not harmful as ansibleplaybookbundle, just a little inconvenient if you don't notice it.

@rthallisey sadly I think almost everyone has push capabilities to ansibleplaybookbundle. Because we don't do an automatic push it's ok, but I've been bit by it defaulting to ansibleplaybookbundle. Leaving it alone for now.

I don't have an alternative to pitch, but I don't think that org is a sane default. We're viewing it as our "production" location right now, and it's too easy to build and push there, since most of us do have access. We should have explicit commands to target it (make release), and set up CI to use those commands so people can't accidentally target it using implicit defaults.
One alternative is to require a variable to be set before running make build? Not perfect, open to alternatives.

TEST
Make sure your etc/dev.config.yaml is configured properly:
---
registry:
  name: dockerhub
  url: http://localhost:1337
  user: YOUR_DOCKER_HUB_USER
  pass: YOUR_DOCKER_HUB_PASSWORD
  org: YOUR_DOCKER_HUB_ORG
dao:
  etcd_host: localhost
  etcd_port: 2379
log:
  logfile: /tmp/ansible-service-broker.log
  stdout: true
  level: debug
  color: true
openshift:
  target: <IP_ADDRESS>:8443
  user: admin
  pass: admin

Make sure you have a cluster
oc cluster up
# create an admin user

Now you can rebuild and deploy the broker:
make clean # remove broker from build now
make build PROJECT=YOUR_DOCKER_HUB_ORG
docker push docker.io/YOUR_DOCKER_HUB_ORG/ansible-service-broker-apb:latest
make deploy # deploys to local oc cluster

See if the pods came up
oc project ansible-service-broker
oc logs asb<TAB>

make release with a default to ansibleplaybookbundles wfm. Then we require PROJECT be set for make build.  👍

The broker should be able to run as anyuid following best container practices as non-root (apb base is a good example of this). It's not within the scope of this PR though, so I logged #142 to track this separately.


Missing .gem file for rb-inotify 0.9.6

I have a Maven build that worked last week, but is now failing with the following error message:
Could not find artifact rubygems:rb-inotify:gem:0.9.6
I dug a little deeper and found that http://rubygems-proxy.torquebox.org/releases/rubygems/rb-inotify/0.9.6/rb-inotify-0.9.6.pom exists, but http://rubygems-proxy.torquebox.org/releases/rubygems/rb-inotify/0.9.6/rb-inotify-0.9.6.gem results in a 404 Not Found. Replacing 0.9.6 with 0.9.5 in both URL's works fine and does not result in 404's.
My build doesn't explicitly depend on rb-inotify, but apparently it's a dependency of either the compass 1.0.3 or sass 3.4.19 Ruby gems. It seems version 0.9.6 was released only 3 days ago and my build worked fine before that, so I don't know why my build should fail now, as it apparently does not require version 0.9.6 of rb-inotify.
Is it possible to make gem-maven-plugin not try to download this missing 0.9.6 version? I tried adding a dependency on rb-inotify 0.9.5 explicitly, but that didn't change anything.

It seems it's compass 1.0.3 that depends on rb-inotify >= 0.9, so that's why Maven is trying to use the newly released 0.9.6.

I have the same problem - http://rubygems-proxy.torquebox.org/releases/rubygems/rb-inotify/0.9.6/rb-inotify-0.9.6.gem returns a 404 with some xml
<Error>
  NoSuchKey
  <Message>The specified key does not exist.</Message>
  <Key>gems/rb-inotify-0.9.6.gem</Key>
  <RequestId>A9F9B92B1E528D4A</RequestId>
  <HostId>
    6c89mVPcZa+QR7bWGR7Lsp/ZdeYWRZMw17/SpY6G5DtTsaHxRJItIzYZ2efP325Qq3kXeQ2xLxE=
  </HostId>
</Error>

I've implemented a temporary workaround on our Nexus instance by adding redirects for requests to the Maven metadata files for rb-inotify and serving a version that doesn't contain a reference to version 0.9.6.

a quick workaround is to add the rb-inotify 0.9.5 explicitly and add an exclusions to compass or sass with
<exclusions>
<exclusion>
<groupId>rubygems</groupId>
<artifactId>rb-inotify</artifactId>
</exclusion>
</exclusions>

will see if we can fix the proxy to do the right redirect. alternatively you can try https://github.com/torquebox/mavengem/tree/master/mavengem-wagon instead of the torquebox proxy - which works OK for regular dependencies but not on dependencies on a plugin section.

In the meantime http://rubygems-proxy.torquebox.org/releases/rubygems/rb-inotify/0.9.6/rb-inotify-0.9.6.gem has changed from returning a 404 Not Found to returning a 500 Internal Server error.

It looks as though here's a new version, 0.9.7, which has replaced 0.9.6.  However that's now returning the 400.

fixed the proxy code, wait for travis and hopefully get it live later today

I don't know if the new code is live already, but http://rubygems-proxy.torquebox.org/releases/rubygems/rb-inotify/0.9.6/rb-inotify-0.9.6.gem now returns a 500 Internal Server Error with a NullPointerException.
http://rubygems-proxy.torquebox.org/releases/rubygems/rb-inotify/0.9.7/rb-inotify-0.9.7.gem still returns a 404 Not Found.

Any update on this? 0.9.7 is still 404ing. For the time being we’ve overridden to 0.9.5 in our Gradle file but it’d be nice to remove that.

I also inserted a temporary workaround in my build.gradle file:
configurations.all {
    resolutionStrategy {
        force 'rubygems:rb-inotify:0.9.5'
    }
}

no proxy code finally deployed. thanx for being patient and sorry for the delay.

@mkristian http://rubygems-proxy.torquebox.org/releases/rubygems/rb-inotify/0.9.6/rb-inotify-0.9.6.gem still returns a 500 Internal Server Error.

0.9.6 was yanked from Rubygems: https://rubygems.org/gems/rb-inotify .

Ah, ok.

well the NPE is bad even for the yank case


[Bug]: Building extensions on windows produces invalid .zip

Description
The .zip archives created when building extensions on Windows end up containing Windows-style paths (\ separators) when other folders are included.
Although the archive is fine, cluster-side validation (Java based) sees this as invalid and throws an error:
{
  "code": 400,
  "message": "'alerts\\' ZIP entry is empty."
}

Steps to reproduce

Create an extension that references a folder (e.g. alerts or dashboards)
Run the build command
At validation step, it fails

Support information

[ ] Screenshots
[ ] Extension manifest file
[ ] YAML snippets
[X] Support archive (see here)

Currently, there is no workaround but to rollback the extension.
Find the extension in the VSCode extensions menu, click the cog icon, choose Install another version and select 2.6.2 until the issue is resolved.


Fix iTerm inputs & artwork not getting destroyed on exit

This PR should close #27
Some workarounds until it is properly fixed upstream in notcurses library

The only issue that remains with iTerm right now is that terminal is not recovering original state after quitting Yatoro.
Investigating workaround...


fix a bug of abnormal sagemaker stream output

Description
Sometime the stream response of sagemaker is split into two event, fix this bug by handling response manually.
Checklist

[x] The base branch of this PR is dev, rather than main
[x] The relevant docs, if any, have been updated or created

Screenshots
[ "For visual changes, include screenshots." ]
Testing
[ For new or modified features, provide testing instructions. ]

Great work on this!


We probably need some way to know what binary origins are...

When looking at historic versions we do not have easy way of telling which one was compiled with which Go compiler/runtime/stdlib. Also later we would not know if it was binary we made or was compiled in ports/repository provider, etc...
That makes me think if we should add this info to --version or create special flag to get detailed information about build environment (e.g. new flag  --buildinfo)

+1
We can find it if needed by going and looking at the release/Makefile for the tag, but still it would be nice to see in --version.

Well..  Now we have
$ websocketd --version
websocketd 0.2.10

My suggestion is to do something like this:
diff --git a/version.go b/version.go
index 4769ee7..66a58eb 100644
--- a/version.go
+++ b/version.go
@@ -5,14 +5,17 @@

 package main

+import (
+       "fmt"
+       "runtime"
+)
+
 // This value can be set for releases at build time using:
-//   go {build|run} -ldflags "-X main.version <IP_ADDRESS>".
+//   go {build|run} -ldflags "-X main.version 1.2.3 -X main.buildinfo timestamp-@githubuser-    platform".
 // If unset, Version() shall return "DEVBUILD".
-var version string
+var version string = "DEVBUILD"
+var buildinfo string = "--"

 func Version() string {
-       if version == "" {
-               return "DEVBUILD"
-       }
-       return version
+       return fmt.Sprintf("%s (%s %s-%s) %s", version, runtime.Version(), runtime.GOOS, runtime.GOARCH, buildinfo)
 }

That leads to this (basically this way probably should be in release/Makefile):
$ go run -ldflags \
            "-X main.version 0.2.11 -X main.buildinfo \"$(date +%s) $(git config user.email)\"" \
            *.go --version
websocketd 0.2.11 (go1.4.2 linux-amd64)<PHONE_NUMBER><EMAIL_ADDRESS>

Points not covered:

SHA1 of current git tree (could be useful)
SHA1 of one dependency we have (golang.org/x/netwebsocket)

I think we closed that one, it's merged in.


Extend POST on RTP resource to trigger state transition if RTP is ss:state

Extend POST on RTP resource to handle the case when the POST is done on ss:state RTP. Condition to trigger the state transition: run is mutable and state is Ready. Respond with 409 if condition is not met.
https://github.com/slipstream/SlipStreamServer/blob/master/jar-service/src/main/java/com/sixsq/slipstream/run/RuntimeParameterResource.java#L173

Instead ended up extending PUT on RTP resource if RT is ss:state.  Semantically PUT suites better for requesting the state change.