ROX-19860: Reduce RBAC resource requirements for routes

Description
TL;DR reduce role-based access control resource requirements for 6 route keys:

compliance
configmanagement
'network-graph' indirectly via nonGlobalResourceNamesForNetworkGraph
'policy-management'
risk
'vulnerability-management'

For cherry pick into 4.2.1 release branch, changes are limited to prevent merge conflicts with 3 route keys added in routePaths.ts file after 2023-08-24 https://github.com/stackrox/stackrox/pull/7566

'administration-events'
'clusters/init-bundles'
'deferral-configuraton'

Problem
Because I missed the forest for the trees while adding conditional rendering within routes to reduce resourceAccessRequirements during sprint 4.2C, some routes became unavailable for primary use cases because of lack of resources for secondary use cases, especially for Vulnerability Management 1.0 route.
Analysis
Vulnerability Management 1.0

WorkflowAdministration

VulnMgmt/Entity/Cluster does not use policyStatus nor policyCount values.
VulnMgmt/Entity/Namespace does not use policyStatus nor policyCount values.

Alert

Clusters, Namespaces, and Deployments use policyStatus and latestViolation values.

Cluster

ClustersWithNostClusterVulnerabilities renders database error.
CvesMenu renders undefined for all values.
/main/vulnerability-management/clusters route renders PageNotFound element.

Namespace

TopRiskiestEntities renders database error.
/main/vulnerability-management/namespaces route renders PageNotFound element.

Node

TopRiskiestEntities renders database error.
CvesMenu renders undefined for all values.
/main/vulnerability-management/nodes route renders PageNotFound element.

Compliance 1.0
With Compliance only:

In addition to READ_WRITE_ACCESS for Compliance, Scan environment requires READ_ACCESS for at least one of Cluster, Namespace, Node.
However, if environment has been scanned, absence of those resources is affects only specific widgets or pages.

Configuration Management

Unlike most other routes, it is not clear which resource (or subset of resources) are primary.
Dashboard is a mess even with all 4 resources directly related to its widgets.

Policy Management
Although, policies list and policy detail page make GET /v1/notifiers request, consider it secondary.
Network Graph

DeploymentExtension is required for 2 tabs of the side panel and IN THE FUTURE verify nowhere else:

Flows: GET /v1/networkbaseline/id has 403 Forbidden status
Baselines: ditto

NetworkPolicy: IN THE FUTURE investigate whether it is required only for Network Policy tab of side panel.

Listening Endpoints
With Deployment but not DeploymentExtension resource: page renders infinite polling loop.
Risk
With Deployment but not DeploymentExtension resource:

Can render list page.
Cannot render side panel, because it needs additional conditional rendering.

fetchProcesses request requires DeploymentExtension resource:
https://github.com/stackrox/stackrox/blob/master/ui/apps/platform/src/Containers/Risk/RiskSidePanel.js#L27
ProcessDetails tab requires DeploymentExtension in addition to Alert resource.
https://github.com/stackrox/stackrox/blob/master/ui/apps/platform/src/Containers/Risk/RiskSidePanelContent.js#L77-L98

Solution
Vulnerability Management 1.0

Delete WorkflowAdministration resource now and then IN THE FUTURE:

VulnMgmt/Entity/Cluster/VulnMgmtEntityCluster.js delete unused properties from query.
VulnMgmt/Entity/Cluster/VulnMgmtEntityNamespace.js delete unused properties from query.

Comment out resources to leave the same minimum resources as Workload CVEs route.

Compliance 1.0

Comment out resources to leave same minimum resources as Compliance 2.0 route.

Configuration Management

Comment out resources to leave minimum requirement of at least one that is directly related to a dashboard widget.

Policy Management

Comment out resources except for WorkflowAdministration, even though clone/create/edit workflow will probably not work correctly without Deployment, Image, Integration.

Network Graph

Comment out DeploymentExtension and NetworkPolicy resources and IN THE FUTURE add conditional rendering.
Leave Deployment because required for Details tab of side panel.

Risk

Delete DeploymentExtension resource and IN THE FUTURE make request and tab conditional.

Residue
IN THE FUTURE, investigate pro and con of conditional code:

CvesMenu on Vulnerability Management 1.0 dashboard for which the request is all or nothing for 3 resources.
Policies

For policies list and policy detail page.
Evaluate pro and con for clone/create/edit workflow to require the additional resources: Deployment, Image, Integration.

SummaryCounts on main dashboard for which the request was all or nothing for 6 resouces.
Investigate whether global search can conditionally render partial results.

Checklist

[ ] Investigated and inspected CI test results
[x] ~Unit test and regression tests added~
[x] ~Evaluated and added CHANGELOG entry if required~ Release Notes instead of CHANGELOG

Testing Performed
Manual testing
Adjust user role permissions from another browser window.
Vulnerability Management 1.0

Without Alert resource: see Cannot find the whatever error page.

Visit /main/vulnerability-management/clusters
Visit /main/vulnerability-management/namespaces
Visit /main/vulnerability-management/deployments

Without Cluster resource:

See undefined for all 3 counts in CvesMenu.
See database error in Clusters and so on widget.

Without Namespace resource:

See database error in Top risky namespaces widget.

Without Node resource:

See undefined for all 3 counts in CvesMenu.
See database error in Top risky nodes widget.

Without WorkflowAdministration resource:

Visit /main/vulnerability-management/clusters and then click a row: see error before deletion and page after.
However, do not include this change.

Visit /main/vulnerability-management/namespaces and then click a row: see error before deletion and page after.
However, do not include this change.

Compliance 1.0
With Compliance resource only:

With READ_WRITE_ACCESS, click Scan environment button.

See triggerScan request with complianceTriggerRuns: [] in response.

With READ_ACCESS after a scan.

See data for only some widgets.

Add Cluster resource

See data for additional widget.

See data for additional widgets. My notes failed me how these look without Cluster resource :(

Visit /main/compliance/clusters

See list, but errors for side panel.

Visit /main/compliance/namespaces

See absence of data for list.

Configuration Management

Visit /main/configuration-management

See a mess of errors, even with all 4 of the someResource resources.

Policy Management

Visit /main/policy-management/policies

See GET /v1/notifiers request which has 403 Forbidden status code.

Click a policy

See GET /v1/notifiers request which has 403 Forbidden status code.

Network Graph

Visit /main/network-graph,click a deployment, and then click Flows tab. Ditto for Baselines tab.

See absence of data without DeploymentExtension resource.

Listening Endpoints

Visit /main/listening-endpoints without DeploymentExtension resource.

See primary requests have 403 Forbidden status code.

Risk

Visit /main/risk without DeploymentExtension resource.

See list but no tabs in side panel.

Branch from master for clarity, simplicity, and ongoing testability, because changes are independent of changes to routePaths.ts file so far during 4.3 sprints.
Good question why 3 resources for Vulnerability Management 1.0
After we get CI run tonight, I will repeat steps in the morning and add screenshots to Testing Performed

WatchedImage for images and/or image-cves list
Deployment for image and/or image-cve side panel
Bonus I will also confirm behavior of corresponding single pages.

One random thing I noticed was that the deployment tab was removed from the violations page once you click into a deployment. Do you where that logic was implemented? I don't know when we changed that and the data is returned in the API but the tab doesn't show up in the UI if you don't have Deployment resource access

One random thing I noticed was that the deployment tab was removed from the violations page once you click into a deployment. Do you where that logic was implemented? I don't know when we changed that and the data is returned in the API but the tab doesn't show up in the UI if you don't have Deployment resource access

Good eyes, Connor. https://github.com/stackrox/stackrox/pull/7411
Although alerts response indeed has a deployment, here is a different request that requires Deployment resource:
https://github.com/stackrox/stackrox/blob/master/ui/apps/platform/src/Containers/Violations/Details/Deployment/DeploymentDetails.tsx#L26-L28
The reason to omit the tab is React does not allow useFetchDeployment(alertDeployment.id) in an if statement.
The way that I reread the code, only the Network policies card could have been rendered in that situation:
https://github.com/stackrox/stackrox/blob/master/ui/apps/platform/src/Containers/Violations/Details/Deployment/DeploymentDetails.tsx#L84-L91
And that card is more about namespaces than the deployment itself:

Therefore, maybe better as a separate conditionally rendered tab if NetworkPolicy resource and if any policies?

/retest

ocp-4-10-ui-e2e-tests

kubelet may be retrying requests that are timing out in CRI-O due to system load. Currently at stage sandbox storage creation: context deadline exceeded


JSON - white space at start/end of key names

Description
White space padding JSON key names destroys parsing
Input
The code looked like this before beautification:
{
            "vendorItemId": "AMD-17830-124",
            "upc": "784626944152",
            "manufacturerItemId": "C5350014",
            "purchaseOrderlineNumber": 13,
            "itemTitle": "MAIZE",
            "packageCount": 1,
            "packageLabel": "Bolt",
            "itemsPerPackage": "1",
            "itemLabel": "yard",
            "cost": 87
        }

Expected Output
The code should have looked like this after beautification:
{
    "itemLabel": "yard",
    "cost": 87,
    "itemsPerPackage": "1",
    "itemTitle": "PUMPKIN",
    "manufacturerItemId": "C5350015",
    "packageCount": 1,
    "packageLabel": "Bolt",
    "purchaseOrderlineNumber": 14,
    "upc": "784626944169",
    "vendorItemId": "AMD-17830-148"
}

Actual Output
The  code actually looked like this after beautification:
{
            "
            vendorItemId ": "
            AMD - 17831 - 43 ",
            "
            upc ": "
<PHONE_NUMBER>76 ",
            "
            manufacturerItemId ": "
            C5350016 ",
            "
            purchaseOrderlineNumber ": 15,
            "
            itemTitle ": "
            LEAF ",
            "
            packageCount ": 1,
            "
            packageLabel ": "
            Bolt ",
            "
            itemsPerPackage ": "
            1 ",
            "
            itemLabel ": "
            yard ",
            "

https://github.com/Glavin001/atom-beautify/issues/2306

@prettydiff
If you run this on https://beautifier.io using the Javascript beautifying, you get the following output:
{
    "vendorItemId": "AMD-17830-124",
    "upc": "784626944152",
    "manufacturerItemId": "C5350014",
    "purchaseOrderlineNumber": 13,
    "itemTitle": "MAIZE",
    "packageCount": 1,
    "packageLabel": "Bolt",
    "itemsPerPackage": "1",
    "itemLabel": "yard",
    "cost": 87
}

I'm not sure how you are getting that output in the atom editor, but it is unlikely that this is due to js-beautifier engine.

Ah, that is almost spot on.

As @prettydiff said on a separate bug. It could make sense to replace newlines with "\n" automatically.


a script for the recall@N, thanks

Could you provide a script for the calculation the recall@N for the dataset?

Hello,
We are preparing to release an update to our current codebase that includes the features you requested. However, for now, you can find the code for recall@N calculation in this gist
I shall keep the issue open till the next code release, although the issue is addressed with the above gist.
Thank you for your interest in our work!


Skip some tests if spatialite DB backend is active.

Those tests fail because of missing features in spatialite.

Hi @fladi, I'll have to sound like the image in this tweet https://twitter.com/fioroco/status/671128541057142784 this time :-D

Thanks for the review. I've update my PR. It now includes more precise reasons why tests are skipped for spatialite.

Thanks


Normalized the grid and table views in the media manager, removed rel…

…oading the contents all over again from the store when the table display type is selected

Description
Please describe your pull request:

Why is it necessary?
There was a need to normalize both types of displays in the media manager, icon size, paging, and so on.
What does it improve?
Overall end user experience, expected behaviour from the end user side.
Does it have side effects?
No

Questions
Answers

BC breaks?
no

Tests pass?
yes

Related tickets?
https://issues.shopware.com/issues/SW-17808

How to test?
Login in the backend, open up the media manager, switch the icon size, the icon size will be reflected in both views, grid and table.

Hey @pthreat,
thank you your Contribution :blue_heart:.
It's already merged long time ago, but not closed. Thanks for your work :heart:


feat!(docsearch): remove default facetFilters

Types of changes

[ ] Bug fix (a non-breaking change which fixes an issue)
[x] New feature (a non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves: #169
Checklist:

[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes (if not applicable, please state why)

Thanks Buddy!


UI macros not working after installing 4.7 in Madrid

I have installed 4.7 in my companies development instance and for some reason UI actions are not displaying at all. Is this an actual bug?

Note: I cannot even backout of 4.7 because the ui action to back out is not available.

It looks like maybe it was a cache issue, the macros worked fine when I restarted my computer.


It looks like the script runs but no changes to Stash

I wonder if the script is not forward compatible? I am using the latest version of Stash (Windows). Running the script, it connects to my Stash over the network and goes through the motions of loading the metadata from my local SQLLite database(s), then takes a much longer time sending metadata up to Stash. The process eventually completes after about 5 minutes. No errors are returned, but nothing changes on the Stash side. I am wondering if there are API changes in the new Stash that are breaking the script.
Watching the Trace Log in Stash, it looks like it is trying to match files using the scraped username as the path, plus the size of the file. Unfortunately, the username that OFMetadaToStash is formatted differently than what OFScraper outputs. OFMetadaToStash pulls the username as username_1234567, but OFScraper stores the files under \username. Perhaps that is why the SQL queries are not finding any matching files? I'll have to look into the Stash database directly to be sure. I can always rename the physical folder to match and rescan, but I'd rather not as the scan takes a long time.
Update: Renaming the folder from username to username_1234567 solved the issue. Maybe this was user error?
OFMetadataToStash v0.9
Stash v0.26.0

Resolved


Prepare subutai update binding

Since we have different update cases, such as management update, resource host update, container update, etc we should prepare unified call for all these operations. It must be agent's CLI binding which will support "--check" flag to show if there updates are available without installing them. Also it must use locks to prevent multiple calls, operation timeouts, etc.

Update binding was pushed to the update branch and should be tested with kurjun new API


OffsetOutOfRange Error

I initially posted this to the kafka users group, but they suggested to post it here as I am using the python client:
I recently received a OffsetOutOfRange error in production while it was functioning properly for like 4-5 days.
In the kafka broker log:
[2014-11-03 21:39:25,658] ERROR [KafkaApi-8] Error when processing fetch request for partition [activity.stream,5] offset 7475239 from consumer with correlation id 69 (kafka.server.KafkaApis)
kafka.common.OffsetOutOfRangeException: Request for offset 7475239 but we only have log segments in the range 8014610 to 10227768.
And on the client side I saw:
Nov 03 21:39:25 INFO kafka consumer.py: Commit offset 10227769 in SimpleConsumer: group=ActivityStream, topic=activity.stream, partition=5
...
...
Nov 03 21:39:26 ERROR demux.consumer_stream consumer_stream.py: OffsetOutOfRangeError(FetchResponse(topic='activity.stream', partition=5, error=1, highwaterMark=-1, messages=<generator object _decode_message_set_iter at 0x3dcf870>),)
Why would the kafka client commit offset 10227769, and then, 1 second later, turn around and ask kafka for the offset 7475239?
We are using a fork with some minor modifications of the kafka-python client.

MultiProcessConsumer really need offsets fix in OffsetOutOfRangeError problem, hopes

not sure what the cause is, but #296 and #356 include some possible fixes to underlying issues. the fork you are using has a lot of tweaks in it -- consumer rebalancing issues could be a cause (I see you are using mahendra's zookeeper patch!).  if you can reproduce w/ a released kafka-python client, please re-open.


Travis CI Builds

@kroikie please review, and if you choose to merge please use the Gthub 'squash' option.
This does the following:

Standardize build tools version, ignoring lint, and proguarding release variant
Add Travis CI configuration:

On pull requests, do a quick assembleDebug for all folders (~10 min on Travis)
On merged commits, build the whole thing (~30 min on Travis)

Future work:

Make the build faster so that we don't ever hit Travis' 50 minute limit.

@samtstern could we travis encrypt the google-services.json file?

It's all just mock values I made up by smashing the keyboard.  The
important thing is they pass basic regex and match the package name so the
build can succeed.
On Wed, May 25, 2016, 12:56 PM Arthur Thompson<EMAIL_ADDRESS>wrote:

@samtstern https://github.com/samtstern could we travis encrypt the
google-services.json file?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/firebase/quickstart-android/pull/21#issuecomment-221688246

Ah so no real API keys, gotcha!


React Navigation 2.x breaks while using createSwitchNavigator or SwitchNavigator

Reproduction steps:
change createStackNavigator to SwitchNavigator

Oops!!! Mobx State is persistent bcz of AsyncStorage, finding a way to stop persistance in dev mode

Yep, this is a big pain point at the moment. We're probably going to add a few buttons in Reactotron that will make clearing persisted state easier.

I think storing navigation is a bad idea, let's take the example of whatsapp, if you are on a chat screen and closes the app and then reopens after sometime in our case it shows the opened chat screen rather than chats home screen. I don't know the use case for you. throw some thoughts here!!

I see it as no different than any other piece of state.
You want to return people to the same place they left.  It sounds like in your app, you have a valid business rule not to? In this case, you need to alter your state upon app load.
I agree that changing the shape of your state to be incompatible, but you can write some code to defend against that. For example, since navigation state is a frequent offender of this, what I do in my navigation store is check to see if the incoming state is valid to react-navigation.  If it isn’t, I reset it to the default.
This prevents crashes.


PHOENIX-7243 : Add isServerConnection property to ConnectionInfo

Opened https://github.com/apache/phoenix/pull/1839 for master branch @shahrs87

Server connections are always opened on the server, and they are only special in that they are cached and cannot be closed.
How would creating a new server connection help if we already have a similar non-server connection ?

@stoty This came up in PHOENIX-6883 where we want to invalidate the metadata cache on a region server and only a server connection should be allowed to do so. Since we enforced that condition, some tests which tried to perform invalidation on a non-server connection failed.

Thank you @stoty for your comment.
Mostly this is a problem on the test side where PhoenixTestDriver is caching the server and non server connections.
Looking at the code, MDEI always creates server connections but there is nothing enforcing in the code so there is a possibility that someone might create non server connection also.


Updating php, python, ruby

@treeder could you please review?
Sizes of images:
php:       37.14 MB
python2:   67.56 MB
python3:   110.9 MB
ruby:      273.5 MB

Pretty sure we don't want most of these changes. What's the reason for all these changes?  Makes all the images bigger. Also, the single line Dockerfile's are worse than multi-line ones since it can't cache things and it's harder to read. There's no benefit to that. Hit me up in #dev on slack and let me know what the reason is for all this stuff.

@treeder here is the link of the ticket
https://trello.com/c/QGDX2b1k/36-merging-iron-x-images
So you don't want one line dockerfile, but in this case image downloading/extracting is faster than multiline dockerfile.


Cache clean

NPM (cache clean), Bower (cache-clean) and others have a facility for cleaning their local cache, either by package name, or for all packages.
I think this is an important feature to have in Chocolatey as well, because we're running into some scenarios where a package with a bunch of dependencies can fail halfway through.  This usually involves me telling people to manually find their chocolately lib folder and start deleting stuff.
It would be useful to issue a simple clean command to delete the package and all it's listed dependencies, so that a reinstall can be attempted without resorting to manually sifting through the package list.  In our experience, --force doesn't really address this.

--force --force-dependencies (or -fx)

This is now linked up with https://github.com/chocolatey/choco/issues/1124 so please follow from there.


Data doesn't load for the first 1000 blocks

The text "loading data for the first 1000 blocks" flickers for a bit when page is reloaded, but the data doesn't load actually

Status response has been added. It shows statement that there are no any data (in the last 1000 blocks) to show.


improve: add retries for pushes/pulls from GHCR

A small percentage of the time, calls to push or pull blobs from GHCR fail with 502 Bad Gateway. Adding a single retry to these requests will improve reliability and prevent the need to rerun failed jobs frequently. Example:
error pushing image "ghcr.io/secureblue/bluefin-main-laptop-hardened:20240222" to "docker://ghcr.io/secureblue/bluefin-main-laptop-hardened:20240222": trying to reuse blob sha256:68285333949b6a5f2ed1df59871327faf019ae8593c288b7ecb933a07abcf9e6 at destination: failed to read from destination repository secureblue/bluefin-main-laptop-hardened: 502 (Bad Gateway)

Oh yeah we can use the retry action like uBlue does

I think this retry should be added cli-side, because the retry action felt kind of hacky last time I looked at it, and it will try to retry if any part of the build fails, not just on nondetermenisticn podman errors.

I think this retry should be added cli-side, because the retry action felt kind of hacky last time I looked at it, and it will try to retry if any part of the build fails, not just on nondetermenisticn podman errors.

curious how this would translate. Would we just retry the entire build if the bluebuild build returns an exit code != 0?

@bayou-brogrammer
No you should just need to add a retry inside of specific calls made in the cli, like here:
https://github.com/blue-build/cli/blob/681aab4a85c7c5a016ef1b064b9668fd518cc04c/src/commands/build.rs#L1012


Increase strictness and safeness in the codebase

Having stricter TypeScript checks will lead to a safer codebase. Consider incorporating the following flags one by one into your codebase.
		"noImplicitAny": true,
		"noImplicitReturns": true,
		"noImplicitThis": true,
		"noUnusedParameters": true,
		"strictBindCallApply": true,
		"strictNullChecks": true,
		"strictFunctionTypes": true,
		"strictPropertyInitialization": true,

Also, omit the suppressImplicitAnyIndexErrors flag.

Disabling suppressImplicitAnyIndexErrors has its purpose, as it gets super tedious to do what is needed without falling back to code full of type casting to as T[keyof T]. I've been there, and I am not planing to revert this.
Note that we have strict flag enabled, which means:

Enable all strict type checking options.
Enabling --strict enables --noImplicitAny, --noImplicitThis, --alwaysStrict, --strictBindCallApply, --strictNullChecks, --strictFunctionTypes and --strictPropertyInitialization.

So only thing from your suggestions that is not implemented is noImplicitReturns (which I am also not planning to change now, but I am open for PR) and noUnusedParameters (which don't really works well with inheritance, it repots unused params where they need to be present because of contracts from interfaces).

Lol looks like the problem with noUnusedParameters can be worked around by prefixing the unused params with _, interesting.
But the bottom line is that I invested a lot of my time in making this repository strict, there are more checks than just the TS compiler, namely the codeclimate static analyses is really strict. Enabling noUnusedParameters in TS does report only those false positives where I would have to add the _ prefix.

That's great to hear! Sorry, I did not know the strict flag enables all the others too, I thought it's only for the Javascript native strict mode.
I work for a rather large company, and one of our legacy tools is going to be re-implemented. I plan to use this ORM there but it's still under discussion.


ACS-engine private cluster jumpbox fails to install

Request for help
ISSUE
What version of acs-engine?:
Version: v0.14.0
I'm trying to deploy an ACS with Kubernetes private Cluster but when I configure to also deploy a jumpbox the ARM Template Test Deployment fails with errors around missing variables:

vnetID
vmSizesMap

I've the following Cluster Definition regarding internal ip addresses and jumpbox configuration:
"kubernetesConfig": {
"privateCluster": {
"enabled": true,
"jumpboxProfile": {
"name": "my-jb",
"vmSize": "Standard_D4s_v3",
"osDiskSizeGB": 30,
"storageProfile": "ManagedDisks",
"username": "azureuser",
"publicKey": "ssh-rsa xxx"
}
},
"clusterSubnet": "<IP_ADDRESS>/24",
"dnsServiceIP": "<IP_ADDRESS>",
"serviceCidr": "<IP_ADDRESS>/16"
}
After the creation of the ARM Templates the Azure Test deployment fails because of missing variables in the ARM Templates. See above.
I'm able to deploy the internal only ACS with Kubernetes cluster when I remove the jumpbox settings.
My Azure Environment consists of two Resource Groups:

Resource Group with:

Domain Controller and DNS
-Virtual Network

Resource Group with:

Kubernetes Cluster nodes etc.

The Kubernetes Cluster nodes are using the VNet from Resource Group 1.
I'm able to deploy and connect to the Kubernetes Cluster when I deploy the cluster without the jumpbox configuration.
Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
Kubernetes 1.9.0
What happened:
Deployed failed when trying to include jumpbox vm for ACS with Kubernetes internal deployment.
What you expected to happen:

Deployment of ACS with private Kubernetes cluster including the jumpbox VM.

How to reproduce it (as minimally and precisely as possible):

Create 2 Resource Groups in Azure
Create a VNet in one Resource Group
Create a Cluster Definition file for private clusterin including jumpbox configuration
Run ACS Engine
Verify ARM Templates for missing variables.

@stefanstranger thank you for reporting! That is indeed a bug in the implementation which makes the jumpbox incompatible with a custom vnet. I will have a PR to fix it soon, I'll report back here when it's out.

The fix was just released in v0.14.1, please let me know if you run into any other issues!


CreateDynamicImport(0) should not parse comments

Static (default) mode in Chet is more stable than dynamic.
Example:
In static mode Chet returns code with comments correctly moved from C header.
In my case this comment contains string:
/**
The outer loop to be set for the face. If the
function succeeds, this loop will be deallocated.
*/

After using CreateDynamicImport(0) Chet generates the following method, which is a bug:
succeeds := GetProcAddress(aDLLHandle, 'succeeds');

Yup, I'm working on that.

Please update this thread once you've fixed it.


Crashing While Socketing Mjolnir

Mjolnir from Mythic Botany CAN be given affixes with no issue however once you try to add a gem into the sockets via the smithing table all seems fine until and only until you go to take the new socketed mjolnir out of the table. Game crashes and takes you to the launcher with an error code. Just thought I would mention this since I hadn't seen any search results about this issue.
crash-2023-07-25_03.54.56-client.txt

You're using an outdated version of apoth - this was fixed in 6.3.0

Well thank you very much for the info and a rapid response. Will let our server host know too.


from Qt import Widgets Crashing Sphinx autodoc

i'm having a strange issue where importing a method from a lib that had a "from Qt import QtWidgets " line, crashes sphinx with out error....
my rst file was the following auto module settings...
if i comment that line out i can effectively run sphinx...
has anyone had this issue before?
.. automodule::
:members:
:inherited-members:
:show-inheritance:

hmmm i think this is a sphinx issue with PySide2


dashboard: project selector in header

Add a selector in header navigation to quickly navigate between your projects

workspace too :)

I am closing this one as this will part of the redesign for the organizations work.


feat(HACBS-2387): use cosign copy skopeo copy in push-snapshot

$ diff -r task/push-snapshot/0.8 task/push-snapshot/0.9
Only in task/push-snapshot/0.9: pipeline-test.yaml
diff -r task/push-snapshot/0.8/push-snapshot.yaml task/push-snapshot/0.9/push-snapshot.yaml
7c7
<     app.kubernetes.io/version: "0.8"
---
>     app.kubernetes.io/version: "0.9"
13c13
<     Tekton task to push snapshot images to an image registry using `skopeo copy`
---
>     Tekton task to push snapshot images to an image registry using `cosign copy`
45c45
<         quay.io/hacbs-release/release-base-image@sha256:9e7fd1a3ccf0d2c8077f565c78e50862a7cc4792d548b5c01c8b09077e6d23a7
---
>         quay.io/hacbs-release/release-utils@sha256:fbe973077b00242eeb3d25101def1be286c621436c5a003527736eabb48f0398
52,58c52,56
<           skopeo copy \
<             --all \
<             --preserve-digests \
<             --dest-precompute-digests \
<             --retry-times="$(params.retries)" \
<             "docker://$2" \
<             "docker://$3:$4"
---
>           attempt=0
>           until [ "$attempt" -gt "$(params.retries)" ] ; do # 0 retries by default which will execute this once
>             cosign copy "$2" "$3:$4" && break
>             attempt=$((attempt+1))
>           done
diff -r task/push-snapshot/0.8/README.md task/push-snapshot/0.9/README.md
3c3
< Tekton task to push snapshot images to an image registry using `skopeo copy`.
---
> Tekton task to push snapshot images to an image registry using `cosign copy`.
15a16,21
> ## Changes since 0.8
> * `cosign copy` replaces `skopeo copy` so the signatures and attestations are also copied
>   * As part of this change, the image used in this task was updated to the release-utils image
>   * Some flags that exist for `skopeo copy`, but not for `cosign copy` were dropped, but the functionality
>     seems to be unchanged
>
19c25
<     in the filename provided by snapshotPath.
---
>     in the filename provided by snapshotPath
diff -r task/push-snapshot/0.8/samples/sample_push-snapshot_TaskRun.yaml task/push-snapshot/0.9/samples/sample_push-snapshot_TaskRun.yaml
14c14
<         value: quay.io/hacbs-release/task-push-snapshot:0.8
---
>         value: quay.io/hacbs-release/task-push-snapshot:0.9
diff -r task/push-snapshot/0.8/tests/run.yaml task/push-snapshot/0.9/tests/run.yaml
14c14
<         value: quay.io/hacbs-release/task-push-snapshot:0.8
---
>         value: quay.io/hacbs-release/task-push-snapshot:0.9

$ diff -r pipeline/push-to-external-registry/0.12 pipeline/push-to-external-registry/0.13
diff -r pipeline/push-to-external-registry/0.12/push-to-external-registry.yaml pipeline/push-to-external-registry/0.13/push-to-external-registry.yaml
7c7
<     app.kubernetes.io/version: "0.12"
---
>     app.kubernetes.io/version: "0.13"
179c179
<             value: quay.io/hacbs-release/task-push-snapshot:0.8
---
>             value: quay.io/hacbs-release/task-push-snapshot:0.9
diff -r pipeline/push-to-external-registry/0.12/README.md pipeline/push-to-external-registry/0.13/README.md
26a27,29
> ## Changes since 0.12
> * the push-snapshot task was updated to version 0.9 to use `cosign copy` instead of `skopeo copy`
>
diff -r pipeline/push-to-external-registry/0.12/samples/sample_push-to-external-registry_PipelineRun.yaml pipeline/push-to-external-registry/0.13/samples/sample_push-to-external-registry_PipelineRun.yaml
40c40
<         value: quay.io/hacbs-release/pipeline-push-to-external-registry:0.12
---
>         value: quay.io/hacbs-release/pipeline-push-to-external-registry:0.13
diff -r pipeline/push-to-external-registry/0.12/tests/run.yaml pipeline/push-to-external-registry/0.13/tests/run.yaml
40c40
<         value: quay.io/hacbs-release/pipeline-push-to-external-registry:0.12
---
>         value: quay.io/hacbs-release/pipeline-push-to-external-registry:0.13

$ diff -r pipeline/release/0.15 pipeline/release/0.16
diff -r pipeline/release/0.15/README.md pipeline/release/0.16/README.md
21a22,24
> ## Changes since 0.15
> * the push-snapshot task was updated to version 0.9 to use `cosign copy` instead of `skopeo copy`
>
diff -r pipeline/release/0.15/release.yaml pipeline/release/0.16/release.yaml
7c7
<     app.kubernetes.io/version: "0.15"
---
>     app.kubernetes.io/version: "0.16"
161c161
<             value: quay.io/hacbs-release/task-push-snapshot:0.8
---
>             value: quay.io/hacbs-release/task-push-snapshot:0.9
diff -r pipeline/release/0.15/samples/sample_release_PipelineRun.yaml pipeline/release/0.16/samples/sample_release_PipelineRun.yaml
34c34
<         value: quay.io/hacbs-release/pipeline-release:0.15
---
>         value: quay.io/hacbs-release/pipeline-release:0.16
diff -r pipeline/release/0.15/tests/run.yaml pipeline/release/0.16/tests/run.yaml
34c34
<         value: quay.io/hacbs-release/pipeline-release:0.15
---
>         value: quay.io/hacbs-release/pipeline-release:0.16


traffic from container to outside world doesnt work

i tried to login to container and do ping google.com . containers are unable to communicate to outside world. please help

Yes they can. Give more information please

my session information
https://labs.play-with-k8s.com/p/bbomer7qgq2g00e5mnhg#bbomer7q_bbomesfqgq2g00e5mni0

hi Marcos,
any updates ? i have shared the information . kindly let me know if you
require any other information as well .
thanks,
prince
On 8 May 2018 at 13:03, Marcos Nils<EMAIL_ADDRESS>wrote:

Yes they can. Give more information please
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/play-with-docker/play-with-docker/issues/261#issuecomment-387379952,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALG1iOfRThnxY1nJBzE7tIfTWNWqO8QUks5twYmugaJpZM4T2g7J
.

--
Prince Paulson
+919902326412


[Termino] Send message on restart

Type

[ ] Bugfix
[x] Enhancement
[ ] New feature
[ ] Documentation

Description of the changes
Sends a message on successful restart. The message sent is customizable by the user. If you would like to change the default message to something else let me know (I'm not creative ._.)
Also simplifies a few things which can be reverted if you don't want them to be changed :D
Closes #78.

Thanks! I have made the requested changes (sorry if I haven't done something like resolve a conversation or something, I don't like gh's gui >.>)


make sure optional relationships have omitempty json tag

See for example:
https://github.com/calyptia/api/blob/e1192968076a2bba68f63817d79d9e27e3aff65f/types/membership.go#L11
This is an optional relationship and right now it is returning null instead of omiting the field at all and is breaking the tests.

@nicolasparada are you planning to work on this fix?

Right. Sure 👍

Right. Sure 👍

Is there a PR linked to this issue @nicolasparada ?

Lets re-open if we plan to fix it.


Display comments for a given item on the Comments pop-up

This pull request contains the following activities:

Add getComment function to fetch information from API.
Add loadComment function to fill the DOM with comments.
Fix linter errors.

Hi @dfsalam , there is nothing else to say other than... it's time to merge it :shipit:


Separate DataRequest from RemoteMessage

Feature Request
Currently our domain model DataRequest class is implementing the RemoteMessage interface and it is used to be sent through the protocol communication.
It's always better to separate domain model from protocol model.
Which Areas Would Be Affected?
transfer process
Why Is the Feature Desired?
separation of concerns
Solution Proposal
Introduce a new TransferRequestMessage class that will be the same as DataRequest at least at first (it could be stripped of unused fields eventually) and putting a transformation layer before sending and after receiving it.

One way to solve this would be to replace RemoteMessage with a RemoteMessageEnvelope<T> that encapsulates a payload of type T. The envelope can be sent to a RemoteMessageDispatcher, typed to the  RemoteMessageEnvelope<T> it handles.
This would decouple the domain types from the message metadata.
Let's discuss.


desc parameter

Is there a plan of adding the desc parameter to tqdm_pathos? In standard tqdm it is usually helpful for producing more verbose outputs.

Thanks for the suggestion! I've added a tqdm_kwargs optional argument to map and starmap, which passes any extra kwargs to the tqdm progress bar constructor. E.g., map(func, iterable, tqdm_kwargs={'desc': 'pbar description'}).


Query should be parsed into an object so that it is handled properly whe...

...n building the signature.
Testing against http://www.imsglobal.org/developers/LTI/test/v1p1/lms.php, the lis_outcome_service_url value is http://www.imsglobal.org/developers/LTI/test/v1p1/common/tool_consumer_outcome.php?b64=MTIzNDU6OjpzZWNyZXQ=. The query portion was being discarded because it was not being parsed. That is it was a string b64=MTIzNDU6OjpzZWNyZXQ=, but should have been an object: {b64:  'MTIzNDU6OjpzZWNyZXQ='}

Seems correct.
I'll get this merged tonight unless @Tape beats me to it.

Thanks!

Looks great to me, nice catch!

Thanks for merging! I'd like to start using this fix in production. Any idea when the npm package will be updated?
I tried doing "postinstall": "cd node_modules/ims-lti && npm install && make build", on the git repo version, but it doesn't work when deploying in a docker container.
Thanks

Published at 2.1.4

Awesome, thank you


Faulty build of latest Inkscape v0.92

Hi,
I am unsure who maintains the Inkscape formula, so forgive me if I am asking in the wrong forum. I have experienced issues with the build on OS X 10.11.6 when installing Inkscape via homebrew: it appears the "trace bitmap" function does not work; perhaps because the potrace dependency is not correctly set up.
Any idea how to repair that?
Best regards,
Emil

This has been moved to Homebrew Cask.

@emilkaae I've applied the fix you mentioned in the new home for this formula: https://github.com/caskformula/homebrew-caskformula
brew install caskformula/caskformula/inkscape


Caching the requests persistently?

Hello,
my issue is rather a question than an issue, however, your repository does not seem to have discussions enabled.
I am running a catalog of electronic components that is intended to be served from GH pages with no backend (https://github.com/yaqwsx/jlcparts). I stumbled upon your project and it seems it might be a suitable upgrade for my project.
I studied the project briefly and I see that you cache the requests in RAM. However, I was wondering if it would be possible to cache them either via Web Storage API or Cache API persistently, so the cache survives page reload (and have an external mechanism of purging the cache). If so, could you point me to where to look in the sources to add persistent caching support?

my issue is rather a question
That's fine.

if it would be possible to cache them either via Web Storage API or Cache API persistently

Great idea!
Currently, all the cached data is stored in a sparse array here: https://github.com/phiresky/sql.js-httpvfs/blob/master/src/lazyFile.ts#L36 So to generalize that you could just replace that with a simple interface Cache {get(i: number): Uint8Array, set(i: number, chunk: Uint8Array)}.
The main problem you'll probably encounter is that the cache has to be synchronous to work with my code, since SQLite is synchronous, so e.g. IndexedDB won't work directly.
As far as I know, the localStorage API is pretty limited, both in amount of data that can be saved as well as the structure, but it should work. The Cache API probably won't work because ServiceWorkers can't respond to synchronous XHR.
So for a simple solution, I'd try using localStorage. You can also use IndexedDB (or any async storage) if you save to the cache in the background and load everything into memory on page load.
For a better solution, you probably need to make the whole thing async. The easiest way here is probably to base it on wa-sqlite/IndexedDbVFS instead of my project, and reimplement my lazyFile on top of that. The reason is that wa-sqlite provides an API for async VFSes based on emscripten asyncify.

The main problem you'll probably encounter is that the cache has to be synchronous to work with my code, since SQLite is synchronous, so e.g. IndexedDB won't work directly.

Would it be feasible to change the code to work asynchronously? I'm also thinking to use the Cache API if possible, it can store much more data than localStorage.

You can check out how https://github.com/jlongster/absurd-sql does it. Ideally these projects would be merged!

The main problem you'll probably encounter is that the cache has to be synchronous to work with my code, since SQLite is synchronous, so e.g. IndexedDB won't work directly.

Can you elaborate? The API of sql.js-httpvfs is asynchronous. Why does it matter that the SQLite is synchronous?

All the VFS calls are called from within SQLite (like callbacks). Since SQLite calls them in a synchronous manner the VFS JS functions also have to be synchronous.

@phiresky So you mean that in addition to the patch you have already made to sql.js to support byte-range queries, you would need to write another patch to make sql.js asynchronous?

If you want to use sql.js specifically, yeah. But I wouldn't base new work on sql.js in any case

Closing because I have no plans on continuing adding new features to sql.js-httpvfs, since the base is pretty hacky and reimplementing on top of a cleaner base would be preferrable. If I would do it again I would try using wa-sqlite which is better suited for this kind of thing.


Bug with searching Gmail

Pre-condition: Use must have Informed Delivery emails in their Gmail account
Environment: Android
Steps to Reproduce:

Log into Google
Select Mail Search
Select a date range
Hit search

Exception thrown @ MailPieceService.fetchMail -> searchMailPieces

On iOS runtime error as soon as logged in with flutter message "Unable to retrieve email."

@tatikozh That might be different from what I am experiencing.   Can you file a separate issue for this?

I will, just wanted to mention it because I think it also related to mail fetching


Fix complexity and duplicated code on scale management

Fix complexity and duplicated code on scale management

BTW, noticed the original code has a bug too, if min was changed, but max was not, changed would be false. Do the new tests detect that?

I didn't do a specific test for that but in the other PR I was using OR ||.
In my opinion, the change should be applied if min or max (or both) are changed.

Now it's:
  let changed = changeScaleLimit(scale, range, 'min', 'suggestedMin');
  const changed = changeScaleLimit(scale, range, 'max', 'suggestedMax') || changed;

is the same of
  cont changed = changeScaleLimit(scale, range, 'min', 'suggestedMin') || changeScaleLimit(scale, range, 'max', 'suggestedMax');

or am I wrong?

I didn't do a specific test for that but in the other PR I was using OR ||.

I have implemented the test case: box/adjustScaleMax.


Add ability to sync Azure Service principals

add flag to enable syncing service principals that are part of synced groups. Currently syncs SP with its guid as the username, based on the constraints of SP access tokens

LGTM


Using C-k C-e doesn't open "Change when expression" in keybindings editor

Issue Type: Bug

Go to keybindings editor (File > Preferences > Keyboard Shortcuts)
Select any command that allows changing the when context.
Press C-k C-e.
Brings up search tool to select an open file tab instead of allowing editing the define when expression dialog.

Attaching video:
https://user-images.githubusercontent.com/10625935/135919231-28926cda-fac6-4ccf-81f1-54493258d9d1.mp4
In the video, I first show that I can use the "Change when expression" option, by trying to change the keybindings.editor.defineWhenExpression item.  I then press C-k C-e and that dropdown pops up instead.  I've also looked to see if there was a conflicting keybinding and there wasn't.
VS Code version: Code 1.60.2 (7f6ab5485bbc008386c4386d08766667e155244e, 2021-09-22T12:00:31.514Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No

System Info

Item
Value

CPUs
AMD Ryzen 7 5700U with Radeon Graphics          (16 x 1797)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.40GB (1.74GB free)

Process Argv
--crash-reporter-id ff847a9c-5b94-44a0-b759-b62cfb7fa79c

Screen Reader
no

VM
0%

Extensions: none
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vstes627:30244334
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551:30345470
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
vsccppwtct:30364498
pythonvssor306:30344512
bridge0708:30335490
pygetstartedt2:30371810
dockerwalkthrucf:30370837
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedc:30364665
pythonvspyt187:30373474
pydsgsc2:30361791
vsqsis300:30374797
vsaa593cf:30376535

Let's first try to find out what command executes on your machine, with your settings and your keybindings when pressing ctrl+k ctrl+e. Could you please try the following:

Run the command Developer: Toggle Keyboard Shortcuts Troubleshooting
This will activate logging of dispatched keyboard shortcuts and will open an output panel with the corresponding log file.
Press exactly the keybinding you desire.
check what VS Code detects and what command is invoked.

If you are having trouble understanding the output, please feel free to paste here and I can try to help.

This is caused by your user defined keybinding ctrl+k mapped to Terminal: Clear:

The keybinding you have defined has no "when" condition. So basically ctrl+k will always invoke Terminal: Clear regardless of where the focus is, if it is in a terminal or not. So when you attempt to press ctrl+k ctrl+e, ctrl+k is first dispatched which leads to the invocation of Terminal:Clear (notice source: user) (it does not enter chord-mode) and then ctrl+e is dispatched it triggers quick open :
| Resolving ctrl+K
\ From 84 keybinding entries, matched workbench.action.terminal.clear, when: no when condition, source: user.
| Resolving ctrl+E
\ From 2 keybinding entries, matched workbench.action.quickOpen, when: no when condition, source: built-in.

I would suggest that you narrow down your ctrl+k keybinding to only be active when focus is in the terminal. You can use the terminalFocus context key for that.

Ah, thanks for that.  However, it now exposed a different bug where if I use that keybinding to try and modify the When of a keybinding that has no When already, it doesn't do anything.
In this video, the 2nd line has focus, I press the up arrow and then press C-k C-e, it then shows to edit that When condition.  I then press the down arrow and then press C-k C-e, it doesn't edit the When condition.  I then repeat the same steps again.
https://user-images.githubusercontent.com/10625935/137958756-72a3e759-134a-4dc0-b3b2-187745dbba25.mp4
Should this be filed as a new bug?


Fix termguicolors not to break ctermbg=NONE on vim.exe & Windows Terminal.

Current implementation of vim.exe, ctermbg=NONE does not make transparent on Windows Terminal.
Repro steps

Start Windows Terminal
Set background image of cmd.exe to something.
Start vim.exe on the cmd.exe
set termguicolor

This change fixes background color not to set invalid color.

If the ctermbg is set to NONE of Normal highlight group, this works like below.

Transparent mode

Acrylic mode

When termguicolors is set Vim ignores ctermbg in favor of guibg. So the current behaviour is absabsolutely right.
olutely right.

I don't change the behavior. Just cheking -1 for transparent.

Please add an update to the help, so users can find out about this feature.

If termguicolors is set then transparency depends on if guibg=NONE or not. AFAIK, it is already working like that and there is no need to change anything.

If termguicolors is set then transparency depends on if guibg=NONE or not. AFAIK, it is already working like that and there is no need to change anything.

Well, did you try it on vim.exe & Windows Terminal?

I found that this breaks the background color when running on Command Prompt with set tgc.

What is your colorscheme? and command-line args?

Default settings with 'tgc':
vim -u DEFAULTS --cmd "set tgc"

VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Aug 29 2022 10:42:56)
MS-Windows 64-bit console version
Included patches: 1-312

Please try on Command Prompt without using Windows Terminal.

 After this, it becomes pale orange or white (or some other color?).

Ah, I beleaved that this white background is intended for tgc.

How this work for the issue?
diff --git a/src/os_win32.c b/src/os_win32.c
index f06227f10..8edf97c49 100644
--- a/src/os_win32.c
+++ b/src/os_win32.c
@@ -213,6 +213,7 @@ static int g_color_index_bg = 0;
 static int g_color_index_fg = 7;

 # ifdef FEAT_TERMGUICOLORS
+static int default_console_color_bg = 0x000000; // black
 static int default_console_color_fg = 0xc0c0c0; // white
 # endif

@@ -7878,6 +7879,13 @@ vtp_init(void)
     store_console_fg_rgb = save_console_fg_rgb;

 # ifdef FEAT_TERMGUICOLORS
+    if (!USE_WT)
+    {
+	COLORREF bg;
+	bg = (COLORREF)csbi.ColorTable[g_color_index_bg];
+	bg = (GetRValue(bg) << 16) | (GetGValue(bg) << 8) | GetBValue(bg);
+	default_console_color_bg = bg;
+    }
     fg = (COLORREF)csbi.ColorTable[g_color_index_fg];
     fg = (GetRValue(fg) << 16) | (GetGValue(fg) << 8) | GetBValue(fg);
     default_console_color_fg = fg;
@@ -8160,11 +8168,21 @@ get_default_console_color(
 	ctermbg = -1;
 	if (id > 0)
 	    syn_id2cterm_bg(id, &ctermfg, &ctermbg);
-	cterm_normal_bg_gui_color = guibg =
-			    ctermbg != -1 ? ctermtoxterm(ctermbg) : INVALCOLOR;
+	if (!USE_WT)
+	{
+	    guibg = ctermbg != -1 ? ctermtoxterm(ctermbg)
+						: default_console_color_bg;
+	    cterm_normal_bg_gui_color = guibg;
+	    ctermbg = ctermbg < 0 ? 0 : ctermbg;
+	}
+	else
+	{
+	    cterm_normal_bg_gui_color = guibg =
+		    ctermbg != -1 ? ctermtoxterm(ctermbg) : INVALCOLOR;

-	if (ctermbg < 0)
-	    ctermbg = 0;
+	    if (ctermbg < 0)
+		ctermbg = 0;
+	}
     }

     *cterm_fg = ctermfg;

It seems that it fixes the problem.


FetchEvent is non cancelable yet checks canceled flag

Spec "Create a trusted event e that uses the FetchEvent interface, with the event type fetch, which does not bubble, is not cancelable, and has no default action."
But later "If event's canceled flag is set, then:
Set eventCanceled to true.

"
The DOM spec says preventDefault() can only set the canceled flag if the event is cancelable. 1
So cancelable or not cancelable?

@jungkees @jakearchibald

@nikhilm I'll respond it after checking our previous discussion in the repo. Thanks for spotting this!

FetchEvent should be cancelable: https://github.com/slightlyoff/ServiceWorker/issues/51#issuecomment-51172079. Thanks!


BRPOPLPUSH blocked totally

Hey, that's a simple queue, fine with redis.
import redis

if __name__ == '__main__':
    rds = redis.StrictRedis()
    while True:
        result = rds.brpoplpush('urls', 'urls_q', 0)
        print(result)

But with ardb, all clients will be blocked, and 100% CPU usage.

it's bug on non-reentrant lock, just fix in last commit.

pretty cool


Empty cpp-library fail on strip task

No code with only cpp-library.

This may only fail for release build which I think we are missing coverage for.


specify sharepoint restore libraries

Does this PR need a docs update or release note?

[x] :no_entry: No

Type of change

[x] :robot: Supportability/Tests

Test Plan

[x] :green_heart: E2E

huh, well that's new. Looks like we're starting to pick up automated emails sent to the inbox of the test user

ah, I think I see what happened. I think I mucked up a comparison in a recent PR. Let me push something for it

huh, well that's new. Looks like we're starting to pick up automated emails sent to the inbox of the test user

Oh yeah, I've been meaning to make a ticket about that.


Add support for associating jobs with a series and graphing the resul…

…ts of a series. Primitive caching support is included for building a dashboard view
This is a starting point for review. I expect to need some schooling on making idiomatic javascript and python.
To run this against an existing cstar install you will need to manually run the create table for the series table.

Tired of trying to make d3.js into what it isn't. Will come back once I have replaced it with a declarative graphing tool.


The Idle Inhibitor icon isn`t changed on another monitor

I`ve got an external monitor for my laptop and when I activate/deactivate the Idle Inhibitor by clicking on the icon on one monitor it won`t switch on another one. It doesn`t depend which monitor I click on.

Idle inhibitor is linked to a surface which is different on each bar, it might not be possible to fix that.

@Alexays Maybe you could create a file somewhere if idle is being inhibited (and watch it with something like libinotify/GFileMonitor)?
This would have the additional advantage of allowing easy external control over the inhibit with a simple rm/touch.

I raised a draft PR for this, it works but the part that causes the idle inhibitor modules on other bars needs to be worked on.

Closed by #906


Modify _BaseSubject to allow an error message override to be included

Just throwing the PR out there in case we get time to review :)

Some usage notes:
field.Text(1, all_errors=False) will result in only producing a 'blank' CellError, reporting the coordinates and field name.
field.Text(1, custom_error_msg='New Error') will append the specified string as a new CustomError object containing the string 'New Error', appearing as any other error message for the cell
field.Text(1, custom_error_msg='New Error', all_errors=False) will produce a CellError, only containing the custom_error_msg string

I was trying to figure out how to trigger the tests to run in github so I could respond to a specific failing test after my latest changes... but I gave up...
Anyways, the test test_file_invalid_type is failing now that I've updated _BaseSubject and it's base classes to use a kwargs-like style instead of positional args. Digging into how that test was previously succeeding, it seems like it was essentially just testing whether a user passed down some unknown keyword arg... but that works now that i've made these changes. I'm not sure, but I wonder if this test is still required? There's probably something I'm not thinking about that I'd like to know! :)

I was trying to figure out how to trigger the tests to run in github so I could respond to a specific failing test after my latest changes... but I gave up...
Anyways, the test test_file_invalid_type is failing now that I've updated _BaseSubject and it's base classes to use a kwargs-like style instead of positional args. Digging into how that test was previously succeeding, it seems like it was essentially just testing whether a user passed down some unknown keyword arg... but that works now that i've made these changes. I'm not sure, but I wonder if this test is still required? There's probably something I'm not thinking about that I'd like to know! :)

lol apparently i enabled the workflows I forked... my last commit triggered them on the other branch

Anyways, the test test_file_invalid_type is failing now that I've updated _BaseSubject and it's base classes to use a kwargs-like style instead of positional args. Digging into how that test was previously succeeding, it seems like it was essentially just testing whether a user passed down some unknown keyword arg... but that works now that i've made these changes. I'm not sure, but I wonder if this test is still required? There's probably something I'm not thinking about that I'd like to know! :)

Ooh this was a really tricky one to figure out, but I finally got it.
TL;DR I wrote a test that went bad a long time ago, and your implementation of **kwargs actually exposed how worthless that test was, but now we need to slightly pull back on your use of kwargs
So what the test was supposed to cover was a verification of a keyword argument for the file type. That check was specifically expecting the TypeError to get raised, because that's how I wrote the checker. At some point the support for that keyword got removed, but the test still passed because the keyword was getting passed all the way down to the _BaseSubject, at which point it hit the constructor which didn't allow for kwargs. The test was checking for a TypeError, which is coincidentally the type of exception that gets raised when you pass a bad keyword argument. I never noticed that I was testing broken functionality, because I chose the wrong builtin exception...
note to self: never try to overload TypeError in a package.
So what happened today, is that you allowed kwargs on the base class, and the keyword was no longer rejected, but then the test failed because it was no longer catching the TypeError that it expected.
So, we needed to do two things here:

Remove that test, because it's testing for something that no longer exists (you can confirm that by searching the code base for the string "file_type", which appears only once, in the unit test
Remove **kwargs from the _BaseSubject. We need to do this, because leaving an open kwargs in a class that doesn't make any calls to super means that we can pass all kinds of keywords and never realize it. That leaves a big vulnerability.

In doing that, we allow the base class to throw an error whenever we ask it for something that doesn't get handled correctly while being passed down. This forces us to appropriately handle every argument before passing it down, instead of just passing down a kitchen sink of params.
I've made those changes so that you can see what I mean. I totally did not mean to, and didn't expect that I would be able to, but I pushed the changes directly to the branch in your fork. Sorry... :-1:
This also exposed some other wonky bad stuff that I had done with some unit tests, which I also corrected.


vscode problems reporting virtual files errors /vscode-chat-code-block/ts-nul-authority

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.87.1
OS Version: macOS Sonoma

Steps to Reproduce:

open a typescript project , chat a bit with copilot, after a while (I dunno when it exactly happens), the problem might show some error of files that are not in the workspace.

when checking the logs under tsserver i get this error
{       "seq": 2,       "type": "request",       "command": "updateOpen",       "arguments": {         "changedFiles": [],         "closedFiles": [],         "openFiles": [           {             "file": "^/vscode-chat-code-block/ts-nul-authority/3e0d69f2-e827-46ab-9c23-323509e83078",             "fileContent": "<BaseNumberField\n  // ...other props\n  onKeyDown={(event) => {\n    // Handle the key down event\n    console.log(event.key);\n  }}\n/>",             "projectRootPath": "/",             "scriptKindName": "TS"           },
I don't have any idea on how to exclude this /vscode-chat-code-block/ts-nul-authority/ from the problem matcher. I'm even not sure if this is this a vscode or tsserver bug?

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.87.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!

Duplicate of #207593)


Ensure conda environment creation is working

While creating the conda environment according to the instructions in 00_SETUP.md (conda env create --file environment.yml), I encountered this error:
Preparing transaction: done
Verifying transaction: \
SafetyError: The package for pyvo located at /Users/donald/opt/anaconda3/pkgs/pyvo-1.4-pyhd8ed1ab_0
appears to be corrupted. The path 'site-packages/pyvo/dal/sia.py'
has an incorrect size.
  reported size: 32907 bytes
  actual size: 32963 bytes

The error occurred while I was having a slow/inconsistent internet connection, so maybe that's the only problem.  If we can't reproduce this error, we're probably fine.
pip freeze showed that pyvo came from conda-forge:
pyvo @ file:///home/conda/feedstock_root/build_artifacts/pyvo_1664228312964/work
If we're not comfortable with conda for pyvo, we could change environment.yml to use pip.

The SafetyError was reproducible for me, but I was able to clear it up by deleting the offending package file and tarball rm -rf /Users/donald/opt/anaconda3/pkgs/pyvo-1.4-pyhd8ed1ab_0.  So it does not appear to be a general problem with our setup instructions (i.e., nothing wrong with pyvo at conda-forge).


feat: New test package

This new package is essentially the test-utils, the test adapter, and the node module validation plugin from the Astro core repo, but with the following modifications:

Remove any reference to internals so it works outside the mono repo without relying on the package installation paths
Make everything properly typed so TS is happy (and fix some bugs that were not being caught because it was not typed)
Remove some pieces that are only relevant to test internal Astro behavior (by causing specific internal states)
Make the plugin check for any node module instead of a shortlist
Wrap some too permissive and dangerous APIs (because they are meant to be internal) in more user-friendly wrappers
Add documentation to all the exposed APIs for testing
Make it test-framework agnostic. Works Vitest, Node tests, Playwright, ...
Make paths relative to the test using the utility and not to the utility itself (since it is now a dependency and not part of the project)

There is ongoing conversation about having this in the Astro core repo to be published under @astrojs/.
I'll still need this to test existing and future Inox Tools packages until that lands on Astro. If/when that happens, this package can be deprecated.

I will merge this to proceed with testing everything on Inox Tools. We can always come back to it as others develop opinions about it.


Update pybio (bioimageio) submodules

.. and remove unused cache_path from eval_model_zip

problem: torch script weight formats seems to become invalid due to this refactor

out of curiosity - do you know why this happens?

problem: torch script weight formats seems to become invalid due to this refactor

out of curiosity - do you know why this happens?

no, but the same happens with pickle. So maybe this is related

ahh @FynnBe, you have good instincts. I have checked the old weights, and those reference the model python file in pybio/torch/models/unet2d.py... So I would assume this is only related to this testdata.

So I would assume this is only related to this testdata.

good. The refactor really shouldn't break anything else

@k-dominik any idea why the CI doesn't run here?

to me it looks like the tests/data/unet2d_torchscript/weights.pt file is corrupt. I tried unzipping it and got the following error:
caution:  zipfile comment truncated
error [.../tiktorch/tests/data/unet2d_torchscript/weights.pt]:  missing 9131070 bytes in zipfile
  (attempting to process anyway)
error [.../tiktorch/tests/data/unet2d_torchscript/weights.pt]:  attempt to seek before beginning of zipfile

@constantinpape , @FynnBe how was this weight file generated? Would it be possible to regenerate it? (By the way, I found it interesting that this information could not be inferred from the model.yaml... - how are users supposed to know how it was trained?)

to me it looks like the tests/data/unet2d_torchscript/weights.pt file is corrupt.

Yes indeed, looks like something with the torchscript weights is wrong.

@constantinpape , @FynnBe how was this weight file generated? Would it be possible to regenerate it?

The whole model was copied from here https://github.com/bioimage-io/pytorch-bioimage-io/blob/master/specs/models/unet2d_nuclei_broad/UNet2DNucleiBroad.model.yaml#L63-L76 and the torchscript weigths are just generated from the normal pytorch model.

(By the way, I found it interesting that this information could not be inferred from the model.yaml... - how are users supposed to know how it was trained?)

Yes, that's indeed a bit unfortunate. The reason is that we had a formalized description of the training procedure in the first iteration of the bioimage format. However, it turned out that this was to complex, so we know rely on self-documentation of the training procedure and providing the training script or linking to the relevant notebook. Unfortunately for the model at hand this got lost over time because it was copied around so much ...
I can re-add this part, but for this it would be good if we use a single version of this model (preferably the one at https://github.com/bioimage-io/pytorch-bioimage-io/blob/master/specs/models/unet2d_nuclei_broad/UNet2DNucleiBroad.model.yaml) and don't keep separate versions that need to be kept in sync.

thank you for the update @constantinpape !

I can re-add this part, but for this it would be good if we use a single version of this model (preferably the one at https://github.com/bioimage-io/pytorch-bioimage-io/blob/master/specs/models/unet2d_nuclei_broad/UNet2DNucleiBroad.model.yaml) and don't keep separate versions that need to be kept in sync.

let's re-add the weights here and tackle the single model change in a separate PR. I've opened an issue (#165) about using a single model for the test case.

I think the pytorch script weights were generated with this script:
https://github.com/bioimage-io/pytorch-bioimage-io/blob/master/pybio/torch/converters/torchscript.py

@k-dominik should we continue this PR a bit more do switch to conda-packages and further update the bioimageio dependencies?

oh I would prefer to merge this now. With conda packages you never know :)


[BUG] Unable to run AzureADPreview commands

To Reproduce
The issue is unable to run AzureADPreview commands in CloudShell even I have installed and imported AzureADPreview Module in CloudShell. But in on-prem environment, I can run these commands without issue.
Below screenshot, left is on-prem, right is Cloud Shell: (as you see, on-prem and CloudShell has installed AzureADPreview module)

But in CloudShell, if I run "Get-AzureADMSPrivilegedRoleDefinition", it said it's not recoginized as a name of a cmdlet, fuction, script file or executable program. On-prem environment runs without any issue:

Commands you ran

Get-AzureADMSPrivilegedRoleDefinition -ProviderId aadRoles -ResourceId 926d99e7-117c-4a6a-8031-0cc481e9da26
Reference document:
https://docs.microsoft.com/en-us/azure/active-directory/privileged-identity-management/powershell-for-azure-ad-roles
Include error output here

PS /home/yoyo> Import-Module AzureADPreview
Import-Module: Assembly with same name is already loaded
PS /home/yoyo> Get-AzureADMSPrivilegedRoleDefinition
Get-AzureADMSPrivilegedRoleDefinition: The term 'Get-AzureADMSPrivilegedRoleDefinition' is not recognized as a name of a cmdlet, function, script file, or executable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
PS /home/yoyo>

## Expected behavior
Able to run AzureADPreview in CloudShell.

## Is this specific to Cloud Shell?
Please verify if the same issue can be reproduced by running the same tool **outside Cloud Shell** - for example,
by installing it on your own computer. If so, it is likely to be a bug in that tool or in the Azure service it communicates with,
not in Cloud Shell. Please file the issue with the appropriate project.

Yes, this is specific to Cloud Shell. On-prem PowerShell runs well

Hello
I have a similar issue when trying to follow https://docs.microsoft.com/en-us/azure/active-directory/develop/active-directory-claims-mapping
I am completely stuck.
I tried various proposal online that suggest to do UnInstall-Module AzureAD then install AzureADPreview. Also logout/login before using the command but it didn't work.

Same Issue with Get-AzureADDirectorySetting

Apparently from support ticket: https://docs.microsoft.com/en-us/answers/questions/645848/get-azureadpolicy-is-not-working-under-version-ver-1.html

Also, you CANNOT run this on Core/CloudShell, if that's what you're trying to do. The AzureAD module is only supported on Windows PowerShell.

Thanks @benoittgt it is a shame as we don' t want to dedicate a machine just to run Powershell for Admins (they don' t know their password)

Do you know if this is on the roadmap?

Sorry @ChristopheLux I have no idea about this.

The background story is:
The Identity team builds the AzureAD and Microsoft Graph PowerShell modules. They ship AzureAD and AzureADPreview via the PowerShell gallery. AzureADPreview provides access to the preview endpoint of Azure AD and includes extra commands. However as you have found those modules are only compatible with Windows PowerShell and do not work in Cloud Shell, which is based on PowerShell 7 on Linux.
In Cloud Shell, we provide AzureAD.Standard.Preview. This is a version of the AzureAD module (not AzureADPreview) recompiled to be compatible with .NET Standard and hence work in Cloud Shell. However Preview in the name indicates the level of completeness, not access the AzureADPreview features.
The Identity team are concentrating on completing the Graph module at the time of writing and AzureAD/AzureADPreview are receiving only minor updates. We do not expect them to updated to work with PowerShell 7.
So at this point I am afraid that we do not have a timeline for the availability of these commands in Cloud Shell. In the interim the only workaround I am aware of is to run the commands from a separate Windows-based environment such as a VM or on-prem workstation.

Hello Ed,
Thanks a lot for those detailed explanation.
Our use case was as we are using a tool to secure admin access where admin does not know their password Cloud Shell seems a good solution.
Maybe we should move everything to graph :)
Enjoy your day!

While importing module use "-RequiredVersion" parameter
"Connect-AzureAD;
Import-Module Azureadpreview -RequiredVersion <IP_ADDRESS>"


Avoid duplicating the 'Filters' section

Fixes #79630

I found a related bug while testing this change, but actually it has existed for some time.
I opened a new PR that includes both fixes but if that's not right, let me know. I would be happy to raise a separate bug and create a PR including just the icon fix.

I think the original code makes little sense. Why is this method called on every popup if the menu is supposed to always be the same? It should only be initialized once, right after filter is created.

I agree. This seems to be a better solution.

I tried to initialize the menu right after filter is created, but the images on the menu were broken:

The original code seems to have taken this into consideration.

The icons should be assigned in NOTIFICATION_THEME_CHANGED.

You should remove get_theme_icon() calls from _append_filter_options_to().

Looks like we forgot to say "thanks", so here's Thanks!
Cherry-picked for 4.1.2.


Add continuous integration and rules for merging

As soon as #6 is merged, add CI to run the tests and force all subsequent PRs to pass the CI checks before allowing them to merge.

Closed in #9


added priority based preemption to priority plugin

What this PR does / why we need it:
Priority plugin now adds preemptable function which makes preemptee a victim if and only if job priority of the preemptee is strictly lower than job priority of the preemptor.
This is consistent with default behavior of the standard kubernetes scheduler: if a Pod cannot be scheduled, the scheduler tries to preempt (evict) lower priority Pods to make scheduling of the pending Pod possible (see https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/).
To disable this functionality use enablePreemptable: false in the priority plugin configuration.
Closes kubernetes-sigs/kube-batch#894
Which issue(s) this PR fixes :
Fixes #894
Special notes for your reviewer:
Release note:

Priority plugin now adds preemptable function which makes preemptee a victim if and only if job priority of the preemptee is strictly lower than job priority of the preemptor. To disable this functionality use `enablePreemptable: false` in the `priority` plugin configuration.

Adjusted log level from 3 to 4 inside all preemptable functions for consistency, to make build pass and to not spam too many logs.

/assign @k82cn

/ok-to-test

/lgtm
/approve


Further slim down libxml2

Signed-off-by: Tim Smith<EMAIL_ADDRESS>

In its current state this breaks the nokogiri install.

this works now after some fixes


Events to Customize Response Data?

In Lexik you can customize the data response using event listeners.  The way the refresh token is added breaks our REST API model and I need to be able to customize the response as I can with Lexik.  Are there events I can subscribe to in order to make sure the refresh token is placed in the right part of the response instead of just appended to it?
Thank you!

Hello,
use php bin/console debug:event-dispatcher to debug and plug your eventListener after Gesdinet\JWTRefreshTokenBundle\EventListener\AttachRefreshTokenOnSuccessListener::attachRefreshToken()
Such as:
The event class src/UserBundle/EventListener/AuthenticationSuccessListener.php
<?php

namespace UserBundle\EventListener;

use Lexik\Bundle\JWTAuthenticationBundle\Event\AuthenticationSuccessEvent;
use FOS\UserBundle\Model\UserInterface;

class AuthenticationSuccessListener
{
    private $jwtTokenTtl;

    public function __construct($jwtTokenTtl)
    {
        $this->jwtTokenTtl = $jwtTokenTtl;
    }

    /**
     * @param AuthenticationSuccessEvent $event
     */
    public function onAuthenticationSuccessResponse(AuthenticationSuccessEvent $event)
    {
        $data = $event->getData();
        $user = $event->getUser();

        if (!$user instanceof UserInterface) {
            return;
        }

        $formattedData = array(
            'AccessToken' => $data['token'],
            'RefreshToken' => $data['refresh_token'],
            'TokenType' => "Bearer",
            'ExpiresIn' =>$this->jwtTokenTtl
        );

        $event->setData($formattedData);
    }
}

Register the event
UserBundle\Resources\config\services.yml
services:
    user.jwt.authentification.success.listener:
        class: UserBundle\EventListener\AuthenticationSuccessListener
        arguments: ["%jwt_token_ttl%"]
        tags:
            - { name: kernel.event_listener, event: lexik_jwt_authentication.on_authentication_success, priority: -1, method: onAuthenticationSuccessResponse }
        autoconfigure: false

Debug with php bin/console debug:event-dispatcher:

Let me know if it works for you!

Would be great if this could get added to the documentation, took a while for me to find this :+1:


Error login

I put the site on vps.
When i go to the site : http://prntscr.com/8gkquf
some info he got from db..... and other loading...
When login : http://prntscr.com/8gkq72
I just edit the design !
soz my bad english ç.ç

Error with a Login button somewhere. I had the same issue when installing. Not 100% sure, I'm drunk.

I know the Problems you need to read the readme correct.
All is right and all works good i think you make the problem to your own ^^
I can help you add me on Skype RatexIndex and we can talk about this problem or i fix it over teamviewer. So but now i go sleep good night.

ok i will try fix

http://prntscr.com/8irkuf now i can login but , the pot and chat still loading...
http://prntscr.com/8irl76
any ideia ?

nvm its working.


Replacing Apache commons-lang3 object serializer with Kryo serializer

Fixes this issue #580. (more discussions are present here. #495).
Switching over to kryo serializer to allow serialization of all spark supported objects including non-java serializable objects.

@n3nash @bvaradar @vinothchandar PTAL.

Top level question is : can kryo serialize everything java serialization can? This looks self contained and kryo would be more efficient.. But are there tradeoffs here, we are making

Kryo can serialize all objects. Infact it also allows us to specify serializers for individual classes if we want to avoid using Kryo's default FieldSerializer.
Only catch here is that in case of Java serialization it uses writeObject() & readObject() apis if you have overridden one. Kryo will not use those apis for serde. But if we really want kryo to use them then we can always register this class to use instead JavaSerializer() using "spark.kryo.registrator" spark config.
Details of kryo serialization performance are here. https://github.com/EsotericSoftware/kryo

@vinothchandar @n3nash - Addressed all review comments. Can you PTAL again?

@ovj : can you run mvn integration-test and check if they succeed.

Thanks @bvaradar - Ran this "mvn clean integration-test". It passes.


[SPARK-29618] remove V1_BATCH_WRITE table capability

What changes were proposed in this pull request?

Build the BatchWrite in the planner and get rid of the V1_BATCH_WRITE table capability.
Why are the changes needed?

It's always better to make the API simpler and easier to implement. When I was working on v1 read fallback API at https://github.com/apache/spark/pull/26231 , I realized that we don't need a table capability for it, because we create the Scan object in the planner. We can do the same thing for v1 write fallback API as well.
This can also reduce duplicated code of creating the WriteBuilder.
Does this PR introduce any user-facing change?

no
How was this patch tested?

existing tests

cc @brkyvz @rdblue

A related topic: https://github.com/apache/spark/pull/25990 suggests that we should pass some physical information when creating Write. This makes me think if we should have logical and physical write as the read side API does. We create the logical write in the planner, and the physical plan creates physical write given some physical information.

Test build #112766 has started for PR 26281 at commit b973fbd.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17711/
Test PASSed.

Test build #112769 has started for PR 26281 at commit 9156561.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17715/
Test PASSed.

Test build #112766 has finished for PR 26281 at commit b973fbd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class AppendDataExec(write: BatchWrite, query: SparkPlan) extends V2TableWriteExec
trait V2TableWriteWithV1FallBack extends V2TableWriteExec with SupportsV1Write

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112766/
Test FAILed.

Test build #112769 has finished for PR 26281 at commit 9156561.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class AppendDataExec(write: BatchWrite, query: SparkPlan) extends V2TableWriteExec
trait V2TableWriteWithV1FallBack extends V2TableWriteExec with SupportsV1Write

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112769/
Test FAILed.

Until we support Table creation through V2 in DataFrameWriter.save, I'm a -1 on this.

I don't get your point. The only change to data source developers is that, they don't need to specify the V1_BATCH_WRITE table capability when they implement v1 flalback write (V1WriteBuilder). This is a pure simplification to DS v2 implementations that need v1 fallback write.
How is it related to "Table creation through V2 in DataFrameWriter.save"?


Add more tests

Some more tests.

ohhh... HHVM is extra sad...
could you please make him happy?

Thank you @SpacePossum.

:D


Human times

You can:

find_*(start_time='2015')
find_*(start_time='2015-03')
find_*(start_time='2015-03-30 18:00:00')
find_*(start_time=datetime.datetime(...))

and likewise, of course, for end_time.
MDS now expects a timezone field in its config file, such as timezone: 'US/Eastern'.
Tests are included.

@arkilic I'd like to get this merged in time for tomorrow's tag and deployment to all the beamlines.

Can you also update the conda-recipe for the new pandas dep

It seems worth adding a note somewhere regarding valid options for this new timezone field.  Something like
# list the valid timezones for metadatastore config
import pytz
print(pytz.all_timezones)

Otherwise :+1:

Timezone names are pretty standard, not sure it is worth documenting

Can we please not add any pandas dependency to metadatastore? Human friendly time zone stuff belongs to broker, not here.

I disagree, but I can see your point of view. I considered putting this in Broker instead but -- my pandas fandom aside -- pandas is part of the core scientific Python stack these days. Why not depend on it? Human-friend times make forensics like the recent XPD debacle much easier.
@ericdill @tacaswell Agreed that the names are standard and not Python-specific, but I think Eric's right that we might as well point people to a list of them.

Two reason:
1: we might change the backend to some language other than Python. Less language specific data structure makes it easier to change things around. There are others in the controls community willing to deploy this in a larger scale and Python will not be the way they go. If they do something better and faster using our language independent architecture, I would like us to be able to easily adopt it.
2: this is a database, not a scientific tool. Jsonifying complex objects are harder and makes rest interface much slower. I have implemented a RESTful service using our current api and it's very fast and literally 100 lines of code because the objects we put on the wire are simple as we designed(good job everybody!). RESTful services sort of solve the issue of how we will get user their data.
Forensics are their fault, we can't make these backends human fault free. There're too many ways to add human friendly times and I don't think the reward is worth adding a new dependency like pandas.

The point of pulling in pandas here is just to get it's timestring <->
timestamp parsing.  If we have a lighter library which will do this then we
should rip pandas out, but for now this is the most expedient option.
On Tue, Mar 31, 2015 at 9:16 AM Arman Arkilic<EMAIL_ADDRESS>wrote:

Two reason:
1: we might change the backend to some language other than Python. Less
language specific data structure makes it easier to change things around.
There are others in the controls community willing to deploy this in a
larger scale and Python will not be the way they go. If they do something
better and faster using our language independent architecture, I would like
us to be able to easily adopt it.
2: this is a database, not a scientific tool. Jsonifying complex objects
are harder and makes rest interface much slower. I have implemented a
RESTful service using our current api and it's very fast and literally 100
lines of code because the objects we put on the wire are simple as we
designed(good job everybody!). RESTful services sort of solve the issue of
how we will get user their data.
Forensics are their fault, we can't make these backends human fault free.
There're too many ways to add human friendly times and I don't think the
reward is worth adding a new dependency like pandas.
—
Reply to this email directly or view it on GitHub
https://github.com/NSLS-II/metadatastore/pull/122#issuecomment-88079843.

I'm actually with @arkilic on this one.  I don't see the value in letting mds understand human friendly times.  That really sounds like the job for databroker which converts the human friendly argument to a timestamp and passes it to mds

My new communication technique works, I now make sense as of release 28.1 :tada:
So we need to address two issues:
Do we want metadatastore to understand human friendly time? If so, can we use pure pytz or some expedient library?

With @arkilic's blessing in an in-person conversation, we are merging this to get the functionality and finding a better package later.


#Buffstreams"!! MF & DaZN X SeRies 17 Live Stream Free On TV Channel (31/08/2024)

A former sports star makes his boxing debut as Danny Simpson faces Danny Aarons on the latest MF & DAZN: X Series event.
Here’s how you can watch MF & DAZN: X Series 17, including live stream options, start time and more.
➤➤🔴🌍📺📱👉 GO LIVE==►► CLICK HERE TO WATCH LIVE
➤➤🔴🌍📺📱👉 STREAMING==►► CLICK HERE TO WATCH LIVE
➤➤🔴🌍📺📱👉 GO LIVE==►► CLICK HERE TO WATCH LIVE
➤➤🔴🌍📺📱👉 STREAMING==►► CLICK HERE TO WATCH LIVE
MF & DAZN: X Series 17 will stream live on DAZN.
DAZN monthly subscription: $19.99 on a 12-month contract or $24.99 month-to-month in U.S. | $24.99 per month in Canada
DAZN annual subscription: $224.99 in the U.S. | $199.99 in Canada
MF & DAZN: X Series 17 start time
Date: Saturday, August 31
Time: 2 p.m. ET | 11 a.m. PT
Location: 3Arena — Dublin, Ireland
MF & DAZN: X Series 17 is on August 31, with the main card starting at 2 p.m. ET. The main event should start around 5:30 p.m. ET, depending on how long the undercard fights last.
MF & DAZN: X Series 17 fight card
Danny Aarons vs. Danny Simpson
Deen TheGreat (c) vs. Dave Fogarty for the MFB lightweight title
Sami Hamed vs. Jesse Clarke
HSTikkyTokky vs. George Fensom
Ben Williams vs. Warren Spencer
Gabriel Silva vs. TBA
Jake Cornish vs. Mike Edwards
DTG vs. Malcolm Minikon
Simpson has played pro soccer since 2006. He started with Manchester United and last played in a game while on Bristol City. He retired in July with Macclesfield. Simpson was known for his time with Queens Park Rangers and Leicester City. The 37-year-old has over 157K followers on Instagram. Aarons has 2.1 million Instagram followers.
Started by KSI, the X Series "showcases the biggest global names in entertainment, sports, and lifestyle competing against one another.” KSI was supposed to compete in a handicap fight but backed out due to injury.
Dean TheGreat, with 391K Instagram followers and 508K YouTube subscribers, has a 5-0 boxing record. He defends the MFB lightweight title against Shark Tank AU judge Dave Fogarty, who has 153K Instagram followers.


add Everright-formEditor & Everright-filter

Submitted two warehouses, added a subcategory, if there is a problem, I can change it

pls remove the subcategory, other than that its fine


Fix of the datepicker reopen problem

Resolve #3705
When testing this issue, please make sure date picker and date range picker still function alright as this pr removes
a open picker on focus. Perhaps this part of code needs to be rebuild only in the datepicker.

You should test if the datepicker still opens when navigating via tab press to the field.

Just tested it. @Elblinator I cannot reproduce your problem with pressing return.
Before: you need focus on the dialog icon and press return/enter to open it.
After my change: you need focus on the dialog icon and press return/enter to open it.
So here is no problem. Please give an "exact" error description.

you need focus on the dialog icon

wanted behaviour: you need to focus on the input OR the icon field to open the dialog
This was the behaviour before and should stay like that (Repo: focus the Event location and press tap to navigate to the date-input field

Worked on the (base) date picker/date range picker. I added a check to open the picker, if pressed Return or Enter.

I did not review this.
@reiterl please rerequest a review if you do fundamental changes to your PR.


Feature Request: Configure HTTPS in wiki

If possible, I'd like to see an article explaining how to set up the HTTPS certs/communication in the wiki, ideally with some quick steps to follow and then how to use it. I played around with it a bit but unfortunately not proficient enough to get it working and this article would be much appreciated.

More info in 52c700fca7ff0bf361036022e364ac26fc1a41fe


[doc] Change index.md to add a schema for data blocks

Also make data file schemas valid json (no trailing commas)
What is the purpose of the change
Clarify the docs for the data file format
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? recursively so

Someone may get confused that the implementation should use an Avro reader/writer to read/write this data

I think it is completely reasonable to use an avro serializer to write the data blocks in a custom implementation? Whether the reader should be different for efficiency purposes is a different question, but I think the schema accurately describes the format of a data block.

@martin-g, can you merge this or rope in someone who can?

I prefer someone else to approve it too before merging it.

Yeah, this LGTM.  It's entirely appropriate to describe it using an Avro schema.  Thanks for the contribution!

Cherry-picked to branch-1.11.


Honor HOT_LOAD_PORT environment var

I have other services running on port 8888 and 8080, so I need to use alternate ports.
This PR allows one to do something like this instead:
$ ( export PORT=7778 HOT_LOAD_PORT=7779; npm run dev )

A separate issue is that you can't do this:
$ PORT=7778 HOT_LOAD_PORT=7779 npm run dev   # <-- doesn't work
[ ... ]
   warn  - error raised: Error: listen EADDRINUSE
[ ... ]

So somewhere else will need a patch in order to pass down PORT and HOT_LOAD_PORT to child processes as needed.

Found another spot to patch. I'm going to do that and rebase into a single commit.

@gldnspud - thank you!


Do the target column have to always be at the end ?

Hello, do the target column have to always be at the end of line ? (last column for CSV ?)
Is it possible to specify which column is the target ?
Thanks

@andrewdalpino any idea ? Thanks.

Hey, @zenati thanks for the question! By convention, in a labeled dataset, the last column of the data table is reserved for the label. If you would like to use another column as the label you can rearrange the column order in-flight using Column Picker.


Break up the non-SRP files

Better to have multiple files and associated tests to figure out what is going on and then tests and files only have one reason to change.

BTW, happy to do this. Just let me know you concur.

That is a goal. I tried this out earlier today and got into an issue with
circular dependencies. I need the factory you mentioned recently to make
this work
On Saturday, February 14, 2015, Mark W. Foster<EMAIL_ADDRESS>wrote:

BTW, happy to do this. Just let me know you concur.
—
Reply to this email directly or view it on GitHub
https://github.com/smizell/minim/issues/15#issuecomment-74403547.

Also, forgot to mention, feel free to solve this if you were interested! I
think if you solve the factory issue, this will be simple.
On Saturday, February 14, 2015, Stephen Mizell<EMAIL_ADDRESS>wrote:

That is a goal. I tried this out earlier today and got into an issue with
circular dependencies. I need the factory you mentioned recently to make
this work
On Saturday, February 14, 2015, Mark W. Foster<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:

BTW, happy to do this. Just let me know you concur.
—
Reply to this email directly or view it on GitHub
https://github.com/smizell/minim/issues/15#issuecomment-74403547.

I think this should include these things:

Break up actual code
Break up tests around code, and refactor most Array tests to be Collection tests
Update README to describe Collections instead of Arrays and say Arrays and Objects have all the functionality of Collection (because it's a subtype)

Yeah. The whole collection thing was more mental effort than I wanted to put in to understand given it all being lumped together.
:+1: on all the proposed changes.

On Feb 17, 2015, at 6:29 AM, Stephen Mizell<EMAIL_ADDRESS>wrote:
I think this should include these things:
Break up actual code
Break up tests around code, and refactor most Array tests to be Collection tests
Update README to describe Collections instead of Arrays and say Arrays and Objects have all the functionality of Collection (because it's a subtype)
—
Reply to this email directly or view it on GitHub https://github.com/smizell/minim/issues/15#issuecomment-74675376.

This can be handled by proposal of #22


JsFiddle Demos do not work

Example on http://jsfiddle.net/pdfjs/9engc9mw/ provided in interactive examples does not work.
PDFJS is not defined error is presented

/cc @yurydelendik for updating the JSFiddle examples with the new code.

Updated, waiting for cache to catch up

@timvandermeij can you verify if I used proper API to access worker settings?

Looks good to me! Closing as fixed.

@yurydelendik The jsfiddle example imports PDF.js using window['pdfjs-dist/build/pdf'].
That is very unidiomatic. There is also a global symbol called pdfjsDistBuildPdf, which would be more natural, but still the name is a bit verbose. Can you replace the former with the latter, at least?
While writing documentation (#9528), I came across the fact that there is no short and obvious name for to access the library. Before submitting a documentation update, I have opened a new ticket to request a better name at #9545.


Pass name in as the default value if nothing is provided

This appears to be in line w/ graphql-js implementation:
https://github.com/graphql/graphql-js/blob/1c5cdbd314200a5bc78ef52b6be9194587a55437/src/type/definition.js#L823

you're right ... thx


Error on startup, uncaught exception

Windows error when launching Android Messages on Windows 10. Started today for no reason.

On closing the window it just opens back up again
EDIT: I still receive notifications but when clicking on the notification to open the window it crashes again

Confirmed this issue occurs frequently on the latest release.

Confirmed to be occurring on my Windows 10 system as well:
Edition:	Windows 10 Enterprise
Version:	1903
OS build:	18362.175

Possibly an issue with registering incoming messages for display in the Windows 10 Notification Center?

I don't believe it has to do with push notifications. Notifications do not cause any crashing behavior. Crashes only occur when opening the GUI.

This error specifically occurs when I have Android Messages minimized to the task bar and new messages are received. I get one for each new message that arrives, and have to click OK on each of them in turn. Which is why I originally attributed this issue to notifications.

I am also having this issue, any word on what may be causing it?

I also get this error message when a new message comes in.

This happens randomly for me. As mentioned above, usually (always?) when minimized to tray. It works for a few days and then I get this error that requires ending from task manager to end/clear.


docs: invalid example, vim docs are outdated?

See #340
There is an example in the vim docs which doesn't work, and has multiple issues. It doesn't appear in the README, but it is found in Usage.md as well. It should probably just be removed since the same behavior can be achieved in/via setup()?

Overrides
The individual components, such as [palettes][palette], [specs][spec], and [groups][group], can be overridden separately to customize the theme according to your preferences.

local override = require('github-theme').override
override.palettes({
  github_dark = {
    red = '#ff0000',
  },
  github_light = {
    comment = '#636e7b',
  },
})
override.specs({
  github_dark = {
    syntax = {
      keyword = 'magenta'
    }
  }
})
override.groups({
  all = {
    IncSearch = { bg = 'palette.cyan' },
  },
})

Issues with the example:

.overrides at the top should be apart of the require string/path
overrides.{specs,palettes,groups} lower in the example are not functions (and shouldn't be called)
Doing overrides this way may be sensitive to whether it's done before or after calling setup() and/or loading the theme (with :colorscheme ...)

Fixed in a24960a