Implementing an adaptive Trotter decomposition that dynamically adjusts the number of Trotter steps based on the complexity of the quantum circuit.

Suggested feature
Implementing an adaptive Trotter decomposition that dynamically adjusts the number of Trotter steps based on the complexity of the quantum circuit. This would allow for more accurate error mitigation in a scalable manner.
Developing a feature for Qiskit experiments to intelligently select qubits for error mitigation based on their susceptibility to Trotter errors. This could involve analyzing historical data or using heuristics to identify qubits that are more prone to errors and prioritizing their mitigation.
Introducing a mechanism functionality for dynamically adjusting the error threshold used in error mitigation. This could involve monitoring the performance of previous error mitigation attempts and adapting the threshold to achieve optimal reduction without sacrificing computational efficiency.
Proposed Solution
We can Create a simulation configuration where the Trotter error arising from non-commuting Hamiltonians in a multi-qubit system offset, to some extent, the Trotter error between the unitary component and the noise component of the simulated dynamics. Alternatively, we can also explore methodologies that eliminate time discretization as an intermediary step and focus on continuous-in-time mappings to transition from one dissipative dynamics to another.

Sounds like this is another independent software built on top of Qiskit Experiments. Since the ExperimentData class provides APIs to the experiment service where we can have a data storage, we can leverage that resource for statistical or historical trend analysis. However, the built-in library of Qiskit Experiments focuses on providing fundamental (and the minimum set of) experiment assets.
But it would be great some community contributor like you can develop intelligent transpiler software with Qiskit Experiments :)


Fix remote cluster restore for data stream

Description

Fixing data stream issue for remote cluster state restore.
Updated existing data stream ITs to run with Remote store restore.

Related Issues
#10773

Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ConcurrentSearch test issue - https://github.com/opensearch-project/OpenSearch/issues/10154

zone awareness test failure - https://github.com/opensearch-project/OpenSearch/issues/3603


'ember-idx-tree' is not in the npm registry

Hello,
I've tried to install this package but it fails all the time:
npm install --save-dev ember-idx-tree
npm http GET https://registry.npmjs.org/ember-idx-tree
npm http 404 https://registry.npmjs.org/ember-idx-tree
npm ERR! 404 'ember-idx-tree' is not in the npm registry.

Can you please publish 'ember-idx-tree' in npm?

Ops?
Done :)


DAG tab hidden

Bug Report
Expected behaviour
DAG tab in workflows should never be hidden
Actual behaviour
DAG tab is sometimes hidden
Steps to reproduce the behaviour
Start with full screen, keep making the window horizontally shorter.  The DAG tab will be hidden at some point.
(Attach tool/workflow documents or links where applicable to help us reproduce your issue)
Environment (Browser or OS and Dockstore version)
Describe your operating system (relevant for CLI and launcher) or your web browser (name and version, relevant for the Dockstore website)

This issue causes non-fullscreen or low res cypress tests to fail.

@garyluu  FYI, either fill in the environment and instructions or leave them off.

I believe this should be fixed.


Avoid running unnecessary checks in the merge queue

#ci-shedding-friday
Currently we are running all the CI jobs when checking in the merge queue, even though only checks and stable tests are checked.
This skips all the unneded checks.
It also enables MSRV tests as per the TODO.

I'll have to remove the required tests (stable, true) once we merge this, and enable the renamed tests (Rust stable) once everyone is rebased on the new HEAD.


allow multiple AUR packages

I'm using multiple desktop env on 1 computer.
But xremap-x11-bin and xremap-wlroots-bin are conflicting at /usr/bin/xremap so I can't switch them easily.
paru -S xremap-x11-bin then paru -S xremap-wlroots-bin makes
error: failed to commit transaction (conflicting files)
xremap-wlroots-bin: /usr/bin/xremap exists in filesystem (owned by xremap-x11-bin)
Errors occurred, no packages were upgraded.

For example in case x11, can you make xremap-x11-bin's binary name to /usr/bin/xremap-x11 and create symlink to /usr/bin/xremap if /usr/bin/xremap is empty, or always override it to allow multiple xremap's packeges?

moved to https://github.com/xremap/aur-autoupdater/issues/49


For better experience, add stars and date of last release or version

Example of my experiencie, in list Tables / data grids, I don't know which them are active, so I suggest to add stars and date of last release for each them, I dont know if possible to add a date dynamic in markdown.

I think that adding stars to every component will be really nice addition showing which library is more popular and more supported.

I found some badges:

[![GitHub stars](https://img.shields.io/github/stars/vuejs/vue.svg?style=social&label=Star&maxAge=2592000)](https://github.com/vuejs/vue/stargazers/)
[![Github last commit](https://img.shields.io/github/last-commit/vuejs/vue.svg)](https://github.com/vuejs/vue/commits)

There seems to be no badges related to npm publish. but, I made a badge available through http://registry.npmjs.org/vue.

[![Npm Last Updated](https://img.shields.io/badge/dynamic/json.svg?label=last%20release&url=http%3A%2F%2Fregistry.npmjs.org%2Fvue&query=$.time.modified)](https://www.npmjs.com/package/vue)

It's easy to add badge we just want this to become the standart when adding package

Is there a way to allow individuals to give thumbs up/down for each? Like we can do on these comments?
How would you define number of stars? 1 star for currently maintained, 1 star for Vue integration, 1 star for having advanced features such as server-side pagination, multi-column sort/filtering, 1 star for good documention, 1 star for being agnostic backend, 1 star for not requiring other UI frameworks such as jQuery/Angular/React, etc?

@wan2land  this is very easy for all. I made for you.
Source Codes can be accessed from my github repository.  https://github.com/MelihAltintas/vue-awesome-githubstars
live demo : https://vueawesomestars.netlify.app/

@LinusBorg What do you think about this?  I don’t mean anything bad about this if it gives users the opportunity to quickly choose, but the stars are appealing

If we do this, then I think real popularity is measured better with downloads, so:

And for activity to keep it alike maybe use commits per month?


Create log and PID file paths at server start-up

Description
Adding code to create log root and PID root dirs when server starts.
It is expected that log root and PID dirs exist and have mode 755 and currently the server will fail to start if this is not the case. Seems to make sense to create them if needed.
Use case
This is especially useful when deploying code in the EBI nfs-based environment where the same code checkout will be running on multiple VMs and log/pid dir names are based on the hostnames. For each host new log/pid dirs must be created (currently a manual process).
Benefits
Simplifies deployment SOPs
Possible Drawbacks
Can't think of any
Testing
Only manual testing
Changelog
n/a
Target branches
Please can this go to master and release/94 branches

This is a long needed cleanup. @nicklangridge could you do a parallel pull request against release/94 please. Thanks.

@nicklangridge just pinging you on this pull request, if you could address the checking for the existence of the directory before attempting to create it. Thanks.

@lairdm re. existence check, the make_path function in https://metacpan.org/pod/File::Path does it's own check so I didn't think I needed to do it here.

From the documentation: "If the directory already exists (and thus does not need to be created), the permissions will not be modified."
Hence the only problem I see is in the case of an existing directory with different permissions. If I'd want to be pedantic, I'd check for the existence and mode before invoking make_path.

OK, that's fair enough.

I've added a check for existence and permissions. If a dir cannot be created or permissions cannot be set then the script will die and the server won't start.
I also updated the 'Remove cruft' commit to take out an old/redundant hashbang that I noticed.
If this is ok I'll make another PR for release/94


[hi] Localize /en/docs/reference/glossary/api-eviction.md

Prerequisites:

If this is your first contribution, visit Contribute to K8s docs for information on how to get started.
Review a few examples of localized glossary entries to see which content you change and which you live unchanged.

Procedure:

Check out dev-1.22-hi.1 and create a working branch called localize-api-eviction.md.
Create a file called content/hi/docs/reference/glossary/api-eviction.md.
Copy the content of https://raw.githubusercontent.com/kubernetes/website/main/content/en/docs/reference/glossary/api-eviction.md to the file you created.
Localize the content.
Push your change and create a pull request.

Completing this feature issue fixes part of https://github.com/kubernetes/website/issues/35600

/language hi
/good-first-issue

Hey @rolfedh, I would like to work on this issue

/triage accepted

/assign

Hey @bishal7679, thanks for taking this up. If you already have another issue, would you mind letting @khannakshat7 have this one?

@rolfedh Thanks for pinging me
Actually I am working on it
And I can see @khannakshat7 already got assigned on three issues.I am gonna raise many issue soon.
@khannakshat7 you can take among  them obviously 👍

Thank You @rolfedh and @bishal7679, Sure I'll take up others issues.

Hi is anyone working on this issue?If not,i would like to work on it please.Thanks.

Hi @OtherHorizon, welcome to the project. Are you on the #kubernetes-docs-hi channel yet?

Hi @bishal7679, if you have a PR for this issue, would you add a comment to the PR stating "Fixes https://github.com/kubernetes/website/issues/35938" This way, the PR shows up here in the issue as well.

Hi @OtherHorizon, welcome to the project. Are you on the #kubernetes-docs-hi channel yet?

No,This is my first trying to contribute to this project.

You're welcome to join us on the #kubernetes-docs-hi channel in Slack.
I've invited @taniaduggal to reach out to you and help you find an onboarding friend.

You're welcome to join us on the #kubernetes-docs-hi channel in Slack. I've invited @taniaduggal to reach out to you and help you find an onboarding friend.

Thanks a lot.

Hey @rolfedh, and @OtherHorizon I would like to take this up if no one is working on it.

Sure thanks!

can anyone guide me how to resolve this issue

Please close this issue if this solved and link the merged pr of this issue.

Is this issue resolved? If not then I need guidance in order to solve it?

@ibilalkayy @Sajiyah-Salat @Atharshoyeb
The PR has already been raised for resolving this issue

Thank you for clarifying.

Hey!! @rolfedh is the issue still open then please assign me the one!!! Thanks...

@rolfedh Please assign this issue to me.

Hey @anshikavashistha Thanks for your interest!
just comment by /assign thats it.
You can refer this PR #36809

/assign @anshikavashistha

@shelar1423 This is assigned to @anshikavashistha.
@anshikavashistha Are you still working on this issue?

Sure @vaibhav2107 ,if she's not working on it, kindly assign it to me

@anshikavashistha Due to no response for two weeks, assigning this issue to @shelar1423
pls feel free to get assigned another issues and contribute!
/assign @shelar1423

/unassign @anshikavashistha

Thank you @bishal7679 ,just had the doubt in the first step , regarding what exactly does checkout mean here ? I understood that I'll have to create a new branch after that.

Thank you @bishal7679 ,just had the doubt in the first step , regarding what exactly does checkout mean here ? I understood that I'll have to create a new branch after that.

This branch creating procedure has been stale. You can push your changes to directly main branch itself

Prerequisites:

If this is your first contribution, visit Contribute to K8s docs for information on how to get started.
Review a few examples of localized glossary entries to see which content you change and which you live unchanged.

Procedure:

Check out dev-1.22-hi.1 and create a working branch called localize-api-eviction.md.
Create a file called content/hi/docs/reference/glossary/api-eviction.md.
Copy the content of https://raw.githubusercontent.com/kubernetes/website/main/content/en/docs/reference/glossary/api-eviction.md to the file you created.
Localize the content.
Push your change and create a pull request.

Completing this feature issue fixes part of #35600

/assign

hi @shelar1423 i want to work on this issue, please assign me this issue i will surely come out with best solution.


[AIRFLOW-333] Fix non-module plugin components

Distinguish between module and non-module plugin components

Fix handling of non-module plugin components

admin views, flask blueprints, and menu links need to not be
wrapped in modules

Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:

https://issues.apache.org/jira/browse/AIRFLOW-333

Per Apache guidelines you need to create a Jira issue.
Testing Done:

Placed sample plugin from documentation in airflow/plugins folder and started airflow
Could not figure out how to hook in before a particular test runs to interrupt plugin import without interfering with everything else.

Reminders for contributors (REQUIRED!):

Your PR's title must reference an issue on
Airflow's JIRA.
For example, a PR called "[AIRFLOW-1] My Amazing PR" would close JIRA
issue #1. Please open a new issue if required!
Please squash your commits when possible and follow the How to write a good git commit message.
Summarized as follows:

Separate subject from body with a blank line
Limit the subject line to 50 characters
Do not end the subject line with a period
Use the imperative mood in the subject line (add, not adding)
Wrap the body at 72 characters
Use the body to explain what and why vs. how

@gwax, please follow the 50/72 rule for the commit message. Thanks.

@skudriashev : commit ammended and pr updated

[Current coverage][cc-pull] is 64.31%

Merging [#1663][cc-pull] into [master][cc-base-branch] will increase coverage by 0.01%

@@             master      #1663   diff @@
==========================================
  Files           122        122
  Lines          8606       8609     +3
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           5534       5537     +3
  Misses         3072       3072
  Partials          0          0

Powered by Codecov. Last updated by [aea1fa2...7a422df][cc-compare]
[cc-base-branch]: https://codecov.io/gh/apache/incubator-airflow/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/apache/incubator-airflow/compare/aea1fa2d653c5dde236cc82022cf0db0cde59856...7a422df86825426ac8ec4e502ca4d8fc75976ff4?src=pr
[cc-pull]: https://codecov.io/gh/apache/incubator-airflow/pull/1663?src=pr

ping @skudriashev

Test failures are unrelated.

@mistercrunch @artwr @plypaul

Why was this not merged?

Good question. It looks reasonable to me. Sorry I was a little slow on the review. LGTM.

It was extended and reopend as #1738 with tests and other improvements
This PR should NOT be merged.


HTML

How would I go about running Picraftzero through HTML,  so I could control my robot outside my network.

Do you mean access you robot remotely via your home router when on the internet away from home?

Away from home... Do I have to port forward.  Pretty new to robotics and
rapsberry pie.   Also uses the noobs install of rapsbian, your universal
remote works great saved me hours of writing code.  However I have a slight
problem with my adafruit pan tilt mount.  I have the servos plugged in the
0 and 1 sockets. But after a few pan and tilt movements the servos freeze
and I have to restart picraft zero.  Once restarted it does it again...
Any help would be greatly appreciated
Thanks
Ritchie
On Mon, 10 Sep 2018, 14:17 Wayne Keenan<EMAIL_ADDRESS>wrote:

Do you mean access you robot remotely via your home router when on the
internet away from home?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/WayneKeenan/picraftzero/issues/64#issuecomment-419908335,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ApBdE4Q4b4oRXmJXsztDsx8PiGC2TqZmks5uZmZjgaJpZM4WgC9P
.


ext: investigate loading of module vs. package from entrypoints

Problem
Entrypoint loading fails when package is defined in entrypoints.

closed via 393103ef


Bugfixes, documentation updates and Travis

I decided to use Travis CI to make sure everything about BANEScarparkinglite was absolutely great.
Narrator: Things were not absolutely great.

Bugfixes:

get_events_detail now correctly references functions from other packages, and it has a shiny new progress bar
get_events would fail if you tried to start from the first day of a month. It doesn't do that any more. And it was jealous of  get_events_detail's progress bar, so it has one too.
get_rugby just plain wasn't working. It is now.
Examples in documentation have been corrected.

Other things to note:

Updated to MIT license (same as parking repo in general)
@rkenning has proper credit as an author/contributor
There's a link to the development version (and a Travis build status badge) at the bottom of the README

Changes made:

.travis.yml relocated to main directory. I've added some comments about what's going on in the file and a quick explanation of what Travis is doing/how to make sure builds pass.
Separate badges in BANEScarparkinglite README for main and dev versions, each linked to respective Travis build pages

Were you asking for a Travis build for this version too? I sort of assumed so, and I've made changes accordingly. I'll need your help though - I don't have access to  BathML on Travis, so you'll have to go and flick the switch!

In the interest of avoiding over-engineering, let's not have a badge for the BathML build.


Welcome splash screen links to inactive ideditor.blog

http://ideditor.blog/

https://github.com/openstreetmap/iD/issues/7045

Proposal: For latest information see changelog and report bugs at github.com.


Feature/onboarding addtitional step

Description
This PR builds off of the work done by @darkerthanblackoff in #619. The changes in this PR were performed in order to get the original PR pulled in to an upcoming release.
The Google Maps onboarding feature that was added in #619 is not slated to be included for the release, so the additional commit on this PR removes that functionality, along with some minor UX enhancements (cut-off text in onboarding screens unrelated to this PR, scrollable authorities list).
Screenshots:
No Authorities Added Yet
Note: The "Choose health authority" button brings a user to the ChooseProvider screen

Authorities Added (scrollable list)

How to test
Walkthrough onboarding and:

Confirm that the header text on all screens is not cut off on the top
You are able to add a health authority, and after completing onboarding, the authority is in your subscribed list in settings

Didnt mean to close/open - GitHub mobile UI is hard to navigate


Move management of secrets out of Ansible

Move management of secrets out of Ansible to facilitate migration to HashiCorp Atlas.
Requirements:

Create a design documentation prior to implementation
Must include all secrets, keys, certificates or system and user accounts

Miscellaneous notes and considerations:

The current thinking to move secrets from Ansible to consul with consul-template
How will we expose secret management with consul? Should we develop our new REST API to abstract consul implementation?  If so, do we need to develop a CLI consumer of the our new REST API to simplify human administration?

I believe you're familiar but I'll add a note for using Vault, the newly released tool from Hashicorp: https://vaultproject.io. I believe it would integrate well with your current stack.

We're tracking secret management with vault in #859


Add custom Jest matchers for AMP validation

Adds the following new Jest matchers:

toBeValidAMP
toBeValidAMPStoryPage - like toBeValidAMP, but wraps the component/string in <amp-story> first
toBeValidAMPStoryElement - like toBeValidAMPStoryPage, but wraps the component/string in <amp-story-page> and <amp-story-grid-layer> first

Usage:
await expect(<VideoOutput {...props} />).toBeValidAMPStoryElement();

To test:

Apply the following patch:

diff --git assets/src/edit-story/elements/video/output.js assets/src/edit-story/elements/video/output.js
index d7d7c784..54255cb7 100644
--- assets/src/edit-story/elements/video/output.js
+++ assets/src/edit-story/elements/video/output.js
@@ -52,7 +52,7 @@ function VideoOutput({
     src,
   };
   const props = {
-    autoPlay: 'autoplay',
+    autoPlay: true,
     poster,
     layout: 'fill',
   };

Run npm run test:js assets/src/edit-story/elements/video/test/output.js
See the following output:

Video output › should produce valid AMP output

Expected
<amp-video autoPlay="true" poster="https://example.com/poster.png" layout="fill"><source type="video/mp4" src="https://example.com"/></amp-video>
 to be valid AMP. Errors:
The attribute 'autoplay' in tag 'amp-story >> amp-video' is set to the invalid value 'true'. (see https://amp.dev/documentation/components/amp-video)

This exact error was actually caught only because of the work on #346. I figured adding some tests for our AMP validity would make sense.
While it's not exactly how AMP validation works, and is not perfect (lots of assumptions right now), it seems to do the trick.
I also considered running the validator every time a story is saved, but amphtml-validator doesn't run in the browser.

Could perhaps also use AMP Optimizer:
https://github.com/ampproject/amp-toolbox/tree/master/packages/optimizer#incomplete-markup

Just noticed that WithElementMask doesn't produce valid AMP, see d0bdd5e0d6b1a3acfb59c1e4a747ad8f219ba3f5.

The property 'clip-path' in attribute 'style' in tag 'div' is disallowed. (see https://amp.dev/documentation/guides-and-tutorials/develop/style_and_layout/style_pages)

Looks like AMP only allows it on svg elements.
@dvoytenko Any thoughts on this?

Just noticed that WithElementMask doesn't produce valid AMP, see d0bdd5e0d6b1a3acfb59c1e4a747ad8f219ba3f5.

I don't see this documented anywhere in AMP docs. So, we should definitely reach out to them to confirm.
In the meantime, we need to work it around (@wassgha PTAL). We could do something like this:

Scan all elements when building


Clustering

Dear Madam/Sir,
Thank you very much for putting together this repo and for explaining how to use it.
I have around 1000 fingerprints calculated and I was wondering if there is any direct way to cluster them  based on a similarity threshold

hi, i am also interested in this. did you find any solution?


Different authentication for different organizations

Dear all,
Is it possible to use different authentication (two LDAP groups) for two organizations? For example, LDAP Group students should not have access to the organization of employees. This would be a great feature for my company.
Maybe like that:
Organization Staff:
AUTH_LDAP_USER_SEARCH = LDAPSearch("ou=staff,dc=example,dc=com",
                                   ldap.SCOPE_SUBTREE, "(mail=%(user)s)")

Organization Student:
AUTH_LDAP_USER_SEARCH = LDAPSearch("ou=student,dc=example,dc=com",
                                   ldap.SCOPE_SUBTREE, "(mail=%(user)s)")

The Django LDAP library we're using  has some provision for this sort of thing; see https://zulip.readthedocs.io/en/latest/production/authentication-methods.html#multiple-ldap-searches
Does that do what you're looking for?

Yeah that's great, but is this way possible with different organization (different subdomains)? So i want to choose different LDAP authentication for each organization, so group staff just can access organization staff und group student just can access organization student.
Do you know what i mean?

Yeah that's great, but is this possible with different organization (different subdomains)? So i want to choose different LDAP authentication for each organization, so group staff just can access organization staff und group student just can access organization student.
Do you know what i mean?

Are there any new findings or solutions?

@ThomasBaeuml I believe this can be done by modifying the code to add more LDAP backend classes, but I haven't gone through the details of how exactly to accomplish it. Nevertheless, this is a feature we want to implement in master at some point, so I'll reopen the issue to keep track of this.

This is possible now in Zulip 4.0 with AUTH_LDAP_ADVANCED_REALM_ACCESS_CONTROL:
https://zulip.readthedocs.io/en/stable/production/authentication-methods.html#restricting-ldap-user-access-to-specific-organizations


Build failure: steam(?)

Steps To Reproduce
Steps to reproduce the behavior:

programs.steam.enable = true;

Build log
log here
Additional context
not actually steam but idk at which package to point.
full config is
programs.steam = {
  enable = true;
  dedicatedServer.openFirewall = true;
  extest.enable = true;
  extraCompatPackages = [ pkgs.proton-ge-bin ];
  extraPackages = with pkgs; [
    steamtinkerlaunch
    protontricks
    winetricks
  ];
  gamescopeSession.enable = true;
  localNetworkGameTransfers.openFirewall = true;
  remotePlay.openFirewall = true;
};

Notify maintainers
I can see that @K900 made some bigger changes to steam few days ago
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.11.2, NixOS, 24.11 (Vicuna), 24.11.20241009.65d98cb`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Lix, like Nix) 2.91.0
System type: x86_64-linux
Additional system types: i686-linux, x86_64-v1-linux, x86_64-v2-linux, x86_64-v3-linux
Features: gc, signed-caches
System configuration file: /etc/nix/nix.conf
User configuration files: /home/nat/.config/nix/nix.conf:/etc/xdg/nix/nix.conf:/home/nat/.nix-profile/etc/xdg/nix/nix.conf:/nix/profile/etc/xdg/nix/nix.conf:/home/nat/.local/state/nix/profile/etc/xdg/nix/nix.conf:/etc/profiles/per-user/nat/etc/xdg/nix/nix.conf:/nix/var/nix/profiles/default/etc/xdg/nix/nix.conf:/run/current-system/sw/etc/xdg/nix/nix.conf:/nix/store/0nrvyvki12xmq6ccidgrin0k0c9hf136-gnome-settings-daemon-46.0/etc/xdg/nix/nix.conf
Store directory: /nix/store
State directory: /nix/var/nix
Data directory: /nix/store/cfl6rqw64ndbh2m0qapg410jf4xmycia-lix-2.91.0/share`
 - nixpkgs: `/nix/store/y4rmd9g036gmgz5xjiplw1zcbi16fqdr-source`

nixpkgs commit from which i tried to build steam is https://github.com/NixOS/nixpkgs/commit/564451a037500d67b2c798ef7bddf43772ab6096

Add a :+1: reaction to issues you find important.

OK, so this is actually a bug in our pixman packaging, but also, you somehow have something that pulls in pixman.dev in your hardware.graphics.packages, so maybe try getting rid of whatever that is.

The actual core issue is fixed by https://github.com/NixOS/nixpkgs/pull/348483.

you somehow have something that pulls in pixman.dev in your hardware.graphics.packages, so maybe try getting rid of whatever that is.

weird, I use nixos-hardware for gpu

nixos-hardware is a repo of set of modules designed for specific hardwares. The modules themselves may import pixmap in your hardware.graphics, even if you explicitly did not do so in your configuration. Either way, this should be fixed when the channels are updated.

nixos-hardware is a repo of set of modules designed for specific hardwares. The modules themselves may import pixmap in your hardware.graphics, even if you explicitly did not do so in your configuration.

yes, that's what I meant, I just wouldn't expect this to occur in nixos-hardware

This seems to be caused by having protontricks in programs.steam.extraPackages but programs.steam.protontricks.enable works fine. If that's expected then close this

I'm going to close this since the underlying issue should also be fixed on -next now.


Add sijibao.com to powered-by page

Please answer these questions before submitting pull request

Why submit this pull request?
[x] New feature provided

Help submit our company logo icon

Coverage remained the same at 16.865% when pulling 2176c5e04cf92af21a8eb8b6070516bacb827b61 on one-cloud:master into e0b7306e5ddae91adc0faf09f505dee9401ded01 on apache:master.

Ref #443


Flaky balance display

Note: still requires more info to reproduce.
One user has reported: I ran it before and got 20:05 and then it dissapeared to 20:00 and then 20:05 and now 20:01 but i usually run it 1-2 hours not having it on for 24 hours

I just experienced a related issue on rc71:
This is my correct balance

When the agent was starting, my "current balance" dipped to 20.15.

I haven't seen this, nor has it been reported, for several iterations, so am closing.


"Improve Performance of Convolutional Neural Networks on GPU"

Currently, TensorFlow's performance for convolutional neural networks (CNNs) on GPU can be further optimized. The goal of this issue is to identify and implement improvements that enhance the speed and efficiency of CNN computations on GPU devices. This includes optimizing convolutional and pooling operations, leveraging GPU-specific optimizations, and exploring techniques such as kernel fusion and memory access optimizations.
Expected Outcome:
By addressing this issue, we aim to achieve significant performance improvements for CNN workloads on GPU, enabling faster training and inference times for deep learning models. This will enhance the overall efficiency and scalability of TensorFlow for CNN-based applications and empower researchers and practitioners to train and deploy models more effectively.
Help Needed:
Contributors with expertise in GPU programming, CUDA, and deep learning optimization techniques are encouraged to collaborate on this issue. The community's insights and contributions are valuable in identifying bottlenecks, proposing optimizations, and implementing efficient GPU-accelerated CNN operations in TensorFlow.
Additionally, suggestions and insights from domain experts, performance profiling, and benchmarking results are welcome to drive this improvement initiative. Let's work together to make TensorFlow's GPU performance for CNNs even better!
Please note that this issue is currently open and up for contributions. Feel free to join the discussion and contribute your expertise towards enhancing the performance of convolutional neural networks on GPU in TensorFlow.

To address the issue "Improve Performance of Convolutional Neural Networks on GPU" in TensorFlow, here are some potential areas to focus on for code improvements:

Utilize GPU-Accelerated Operations:

Replace CPU-based operations with GPU-accelerated counterparts, such as tf.nn.conv2d for convolution and tf.nn.max_pool for pooling, to leverage the GPU's parallel processing capabilities.

Apply Optimized Convolution Implementations:

Explore optimized convolution algorithms, such as Winograd or FFT-based convolutions, that can provide faster computations for specific scenarios.

Employ Memory Optimization Techniques:

Implement memory optimizations, such as memory reuse and memory padding techniques, to minimize data transfers between the GPU and system memory, reducing memory overhead and improving performance.

Consider Mixed-Precision Training:

Investigate the use of mixed-precision training, where lower precision (e.g., float16) is used for certain computations, to speed up training while maintaining acceptable accuracy.

Implement Kernel Fusion:

Investigate opportunities for kernel fusion, where multiple operations can be combined into a single GPU kernel, reducing memory accesses and improving computational efficiency.

Profile and Optimize Data Transfers:

Analyze data transfer patterns between the CPU and GPU, and optimize data movement to minimize unnecessary transfers and latency.

These are just a few examples of areas to focus on for code improvements. It is recommended to further analyze the specific requirements and characteristics of your CNN models and identify bottlenecks using profiling tools to guide the optimization efforts. Additionally, leveraging TensorFlow's GPU-specific APIs and optimizing memory access patterns can further enhance the performance of CNN computations on GPU.
Let's together collaborate in the TensorFlow community, participate in discussions, and consider the latest research and advancements in GPU optimization techniques to make meaningful contributions towards improving the performance of convolutional neural networks on GPU in TensorFlow.

To improve the performance of Convolutional Neural Networks (CNNs) on GPUs, you can consider implementing optimizations such as utilizing GPU-specific libraries, batching data, and using parallel computing techniques. Here's an example of Python code that showcases these optimizations:
import tensorflow as tf

# Define your CNN model
model = tf.keras.models.Sequential([
    tf.keras.layers.Conv2D(32, (3, 3), activation='relu', input_shape=(32, 32, 3)),
    tf.keras.layers.MaxPooling2D((2, 2)),
    tf.keras.layers.Flatten(),
    tf.keras.layers.Dense(10, activation='softmax')
])

# Compile the model
model.compile(optimizer='adam', loss='sparse_categorical_crossentropy', metrics=['accuracy'])

# Load your dataset
(x_train, y_train), (x_test, y_test) = tf.keras.datasets.cifar10.load_data()

# Normalize and preprocess the data
x_train = x_train.astype('float32') / 255.0
x_test = x_test.astype('float32') / 255.0

# Create a TensorFlow Dataset
train_dataset = tf.data.Dataset.from_tensor_slices((x_train, y_train)).batch(64)

# Enable GPU memory growth to avoid memory allocation errors
physical_devices = tf.config.list_physical_devices('GPU')
tf.config.experimental.set_memory_growth(physical_devices[0], True)

# Train the model
model.fit(train_dataset, epochs=10)

# Evaluate the model on test data
test_loss, test_accuracy = model.evaluate(x_test, y_test)
print(f'Test Loss: {test_loss}, Test Accuracy: {test_accuracy}')

In this code, we define a simple CNN model using the Keras API in TensorFlow. We compile the model with appropriate settings and load the CIFAR-10 dataset. To improve GPU performance, we normalize the data, create a TensorFlow Dataset for efficient data loading, and enable GPU memory growth to avoid memory allocation errors.
By utilizing GPU-specific libraries and implementing best practices for training CNNs, you can significantly improve the performance of your models on GPUs. Additionally, you can explore techniques like model parallelism and mixed precision training for further optimization.
Remember to customize the code based on your specific use case and requirements.

Hi @Abhishekagrawal1404
The tensorflow provides Profiler to track the performance of TensorFlow models and  understand how the model performs on the host (CPU), the device (GPU), or on a combination of both the host and device(s).
Also, we can use the profiler to do GPU performance analysis and get the maximum performance out of GPUs.
Can you provide more specific context on the issue?
Thanks.

Hi @pjpratik
Thank you for reaching out with your question about improving the performance of Convolutional Neural Networks (CNNs) on GPUs. I appreciate your interest in optimizing the utilization of GPU resources.
The code you provided is a great starting point for training a CNN model using TensorFlow and leveraging GPU capabilities. To further enhance the performance, I would recommend considering the following:

Utilize GPU-specific libraries: TensorFlow provides various GPU-accelerated operations and libraries, such as cuDNN, which can significantly speed up computations on GPUs. You can explore using these libraries to further optimize your CNN model.

Batch data processing: By batching your data, you can process multiple samples in parallel, taking advantage of the parallel processing capabilities of GPUs. This can lead to improved performance and faster training times.

Parallel computing techniques: TensorFlow provides functionalities like data parallelism and model parallelism, where you can distribute the computations across multiple GPUs or machines. This allows for increased scalability and can further boost the performance of your CNN models.

Remember to customize these optimizations based on your specific use case and experiment with different techniques to find the best performance gains for your CNN model on GPUs.
If you have any further questions or need more specific guidance, please feel free to provide additional context, and I'll be happy to assist you.
Best regards,
Abhishek

Most of the techniques listed, like mixed precision, are already implemented in TensorFlow. Others, like fusion, are enabled through XLA. Therefore I'll close this issue. If you have a specific optimization to improve performance of convolutions which you would like TensorFlow to implement, please file a new issue.


Cors with HTTPS

Hello, i want to use cors with a express HTTPS Server but this does not work, am i right?
Is there a workaround or is the Problem on my side?

`let express = require('express');
let bodyParser = require('body-parser');
let fs = require('fs');
let https = require('https');
let customerService = require('./services/customer');
let intermediaryService = require('./services/intermediary');
let cors = require('cors');
let customerRoute = require("./routes/customer");
let app = express();
app.use(cors());
let credentials = {
pfx: fs.readFileSync('PATHTOCERTIFICATE'),
passphrase: '*****'
};
let httpsServer = https.createServer(credentials, app);
app.use(bodyParser.json());
app.use(bodyParser.urlencoded({ extended: true }));
app.use('', customerRoute);
// catch 404 and forward to error handler
app.use(function (req, res, next) {
next();
});
/first API to check if server is running/
app.get('*', (req, res) => { })
httpsServer.listen(3000, function () {
console.log('HTTPS Server listening on port: ' + port);
});`
this is the code that does not accept CORS requests

Thank you. Unfortunately the code you posted above did not run without modifications and you didnt provide the steps to reproduce the issue you are having.
I modified the code so I coule run it and then made a simple CORS request to the https server without issue. Unfortunately there are many variables in the types of CORS requests and you didn't provide any information.
Please provide the steps to reproduce the issue you are having so we can help.

I dont know what i have done, but i cant reproduze the problem anymore, so its solved i guess :)

Hi @SteffenLammers glad you got it working :) !


[Map] DM-battledrome

Hash: 5dc3c1641f6a9ac2495b606d041a9dc97c78ae2c
Current name: DM-battledrome
According to the readme, the authors are SnowTiger and Smiley
These are the same people as the authors of DM-Battledrome-A where in the readme they appeared as Smiley & SnowTiger.  Battledrome-A is an updated version of Battledrome

Updated and flagged as variation.


Fix #548: Converting html images fails if the image refers to an emoji without a shortcut

emojiReference.txt contains ~1000 emojis without shortcuts, but HtmlConverterCoreNodeRenderer.java made the incorrect assumption that every emoji had a shortcut, which broke converting certain  tags to Markdown.
PR includes a test case which illustrates the problem: the test will fail with an exception when the fix is not present.

I have to say I'm very happy with the extensive test suites in flexmark! Great stuff!

@DamnedElric, thank you for the PR. I merged it, and added another test case with the full HTML source you had in issue #548.
```````````````````````````````` example Issue 548: 1
This is my test to a Facebook emoji:
![text](https://static.xx.fbcdn.net/images/emoji.php/v9/t71/2/16/1f967.png)
.

This is my test to a Facebook emoji:

````````````````````````````````


fix(installer): Don't execute any nil rollback or cleanup

What does this PR do?
Enforces that we can never panic when executing a rollback or a cleanup during apm injector installation
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Support messageKey property to avoid dupe XH.alerts/confirms

A process might call XH.alert() and related methods powered by MessageSourceModel multiple times and yet only want the last call to show, instead of stacking up multiple modal alerts and creating a storm of modals on the browser.
Our message APIs could take an optional property such as messageKey which, if provided, would auto-close any modals created with the same key before showing the latest request.

Here is an interesting commentary initiated by John.  Question is should we just hanging the promise?  rejecting it? or resolving it as cancel?  See discussion below:
if you are doing an await on the message promise it would never resolve right?
lee:maple_leaf:  8:21 AM
thought about that a bit, but not enough, obviously
john.haynes  8:21 AM
:slightly_smiling_face:
lee:maple_leaf:  8:21 AM
my thought was that user never answered the question, so we don’t want to resolve
john.haynes  8:21 AM
I think cancelling makes sense?
8:21
yeah its a tricky one
8:23
or does it make sense to reject the old promise?
lee:maple_leaf:  8:24 AM
thinking… conceptually that seems appealing
john.haynes  8:25 AM
yeah I think I like that more than calling cancel since we can't really assume that apps don't have special logic when cancelling
lee:maple_leaf:  8:25 AM
but that could also yield some errors in user code
john.haynes  8:26 AM
yeah
lee:maple_leaf:  8:27 AM
what would you want in your use case — was just an alert, right, where you did not care about the answer
New
john.haynes  8:27 AM
nope was a confirm
8:27
in my case cancelling would be fine because I don't do anything unless they confirm
8:28
but some uses of confirm could case more about the answer and do something either way
lee:maple_leaf:  8:30 AM
well we do have this precedent here —
// Message modals are automatically dismissed on app route changes to avoid navigating the
// app underneath the dialog in an unsettling way.
this.addReaction({
track: () => XH.routerState,
run: () => this.close()
});
8:34
but on the other hand, clicking escape, would cancel, and it seems close to that — also the word cancel, arguably implies the no-op action for the app
8:37
So cancelling would be good for an app that was asking “Discard Changes?” And not so good for an app that was asking “Save Changes?”
8:38
Perhaps the latter is a poorly written app, if it ties an active state change to a “cancel” operation….


Update HA integrations docs with TPMS sensors and examples

Add TPMS sensors to HA integrations docs.

ooops forgot to add '_bar' to the value_template ie. sensor.tesla_tpms_pressure_fl_bar instead of sensor.tesla_tpms_pressure_fl etc
I'll update the pull request


[cloud] Add several more tools/versions for RNA seq and VC

Installation sequence for tool-installers

[x] Test using @galaxybot test this
[x] Inspect CI output for expected changes
[ ] Deploy using @galaxybot deploy this if test install was successful
[ ] Merge this PR

@galaxybot deploy this


Fixed: Overwriting resource_dir.ini

Is there a way to keep you from overwriting resource_dir.ini every time I check for updates? Please! What is the point in having an ini file so that we can set the font/luts directories if you are going to overwrite it every day?
*.ini is in the .gitignore file but it seems to be ignored.

All right. I've seen this kind of feedback several times. For users who don't like to update the plugin with git pull, I would consider changing the default filename suffix.

Already changed the *. ini files default suffix to *. ini. example, and need to change it to *. ini for the first configuration.

Thank you!


fix: unrug THOR swaps to RUNE

Description

Notice

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #3926   👈

This comment was auto-generated by Graphite.


Pass through AsyncRead and AsyncWrite traits

Closes https://github.com/Nullus157/async-compression/issues/296

Thank you!


Gitolite integration with GitList

This pull request allows integration with Gitolite. It contains a fix for full relative path of nested repositories (based on #536 with my comments) which is critical for this. Since there is a chance that a user doesn't have access to any repository, I added catching NoRepositoryException to all Controllers so a user sees nice error message (not RuntimeException or a blank page).
To get list of accessible repos you have to write 2 simple scripts (see below). The first one gitolite-wrapper.sh is called from GitList itself and it calls the second one gitolite-perms.sh via sudo as gitolite user (so the web server user doesn't have ability to call gitolite command via sudo).
I included scripts in this PR.
Requirements

You have to setup a web server to perform authentification and pass username in $_SERVER['PHP_AUTH_USER'].
Usernames must correspond to those in gitolite.
You have to allow web server user to call gitolite-perms.sh via sudo as gitolite user and permit passing env variable GL_USER.

I hope this helps.

Can you please adapt your code to the PSR-2 standard?

@klaussilveira: I have adapted the code to PSR-2 and I also included wrapper scripts. If you merge this I will write a wiki how to setup this.

When do you paln to integrate this feature in the master ?

@Hologos as described in #739 I'm quite not sure if your changes should be in GitList, as the core of GitList should be minimalistic and only support the common needed features. In addition I don't prefer any sudo calls in webserver scripts, as they may be exploited easily, if the user didn't setup the environment carefully.
However, I'd love to hear your feedback in #739.

Is there somebody who can merge? The latest commit was on Aug 2017.


New package: Gen v0.3.5

Registering package: Gen
Repository: https://github.com/probcomp/Gen.jl
Created by: @marcoct
Version: v0.3.5
Commit: 0466d478c47fcf78ad11ef10bcceec78372fe590
Reviewed by: @marcoct
Reference: https://github.com/probcomp/Gen.jl/commit/0466d478c47fcf78ad11ef10bcceec78372fe590#commitcomment-39404777

Running the tests again.

I am not quite sure if the failure is only due to the name being too short (which I think in this case is fine), or is it something else.
@ChrisRackauckas ?

Also the version number not being any of X.0.0, 0.1.0 or 0.0.1

Will that break something, if we merge it with the version number it has? Clearly the package has earlier history prior to registration - so I'd be ok merging - all else being ok.

No, it's just one of the guidelines for automatic merging, but it doesn't cause any harm


automatic start does not show mediaelement player

Hi Rafael,
I have tried using the 'automatic start' method but only come up with the standard html5 video player and not the mediaelement player.
`

<link rel="stylesheet" href="build/mediaelementplayer.css">

`
According to this:
"You can avoid running any startup scripts by adding class="mejs__player" to the  or  tag. All the player configuration can be added through data-mejsoptions attribute."
I don't need any other javascript - is that correct? Am I doing something wrong here or just misinterpreted the above statement.
Thanks in advance
Rob

The code did not show this part:

Try again:
<video id="videoPlayer" src="video/big_buck_bunny_480p_surround-fix-2.mp4" width="800" height="400" controls   class="mejs_player"    data-mejsoptions='{"pluginPath": "build/", "alwaysShowControls": "true"}' ></video>

I think you have a typo: class="mejs_player should be class="mejs__player

Hi Rafael,
Yes you are absolutely correct. That did the trick. How did I miss the double underscore?
By the way, I love the demo for the plugins. I am glad to see the playlist is up, running and looking good.
Great work Rafael.
Thanks heaps
Rob

You are welcome. Glad I could help you. Just FYI I'm not maintaining the project anymore. I'm just wrapping things up for Wordpress at this point

Hi Rafael,
That's not good news. Your work and support is greatly appreciated.
Will someone elese be taking over from you?
Cheers
Rob
On Wed, 2017-08-16 at 15:53 +0000, Rafael Miranda wrote:

You are welcome. Glad I could help you. Just FYI I'm not maintaining
the project anymore. I'm just wrapping things up for Wordpress at
this point

I'm not sure. I talked to John Dyer about it but nobody so far have come up for this.

Thanks Rob wish you the best


IIS Webserver role

Changes

Adding a new Role role::webserver to manage Windows IIS servers

This role uses profile::platform::windows::webserver::iis_server which installs and configures IIS.

Reboots the Windows machine after Chocolatey installs 7zip. (via puppetlabs-reboot)

Note for the reviewer:
This is how I verified that after 7Zip was uninstalled, the next time Puppet will enforce the installation again and reboot after that.

I've added one comment about ordering but I suspect this works perfectly in its current form. However there are a few things to consider that might improve the functionality:

Can we get rid of the download-then-move mechanism? Seems a but messy
What would happen if someone manually changed the index.html? Would Puppet fix it?
Do we need to ensure permissions on the index.html once it's created? Would it need to be owned by some kind of IIS user in order for IIS to read it? We should presumably at least make sure that it isn't world writable for example as we don't want people going in and changing it

Let me know what you think of the above

Hey @dylanratcliffe
So I made some changes based on your suggestions.

I removed the "download-then-move" logic, I switched to a simpler version with a File resource
I'm changing the permissions so everyone can read but not make changes on the index.html
The group IIS_IUSRS was used to allow IIS to read and render the HTML on port 80

Test
To test that no one else could modify the HTML file, I went to the Windows server and tried to edit it with VIM:

Let me know what you think :)


[Dubbo] move the classes of model from config to rpc-api for reusing

What is the purpose of the change
reusing those model in rpc module.
Brief changelog
the refactor is very safe with unit test convering.

Codecov Report

Merging #2636 into master will decrease coverage by 0.24%.
The diff coverage is 22.22%.

@@             Coverage Diff             @@
##             master   #2636      +/-   ##
===========================================
- Coverage     55.05%   54.8%   -0.25%
+ Complexity     5283    5263      -20
===========================================
  Files           571     571
  Lines         25515   25510       -5
  Branches       4532    4532
===========================================
- Hits          14048   13982      -66
- Misses         9352    9419      +67
+ Partials       2115    2109       -6

Impacted Files
Coverage Δ
Complexity Δ

...rg/apache/dubbo/rpc/model/ProviderMethodModel.java
0% <ø> (ø)
0 <0> (?)

...a/org/apache/dubbo/rpc/model/ApplicationModel.java
0% <ø> (ø)
0 <0> (?)

...ava/org/apache/dubbo/qos/command/impl/Offline.java
95.83% <ø> (ø)
7 <0> (ø)
:arrow_down:

...ain/java/org/apache/dubbo/qos/command/impl/Ls.java
85% <ø> (ø)
9 <0> (ø)
:arrow_down:

...java/org/apache/dubbo/qos/command/impl/Online.java
83.33% <ø> (ø)
5 <0> (ø)
:arrow_down:

...java/org/apache/dubbo/rpc/model/ProviderModel.java
0% <0%> (ø)
0 <0> (?)

...rg/apache/dubbo/rpc/model/ConsumerMethodModel.java
0% <0%> (ø)
0 <0> (?)

...java/org/apache/dubbo/rpc/model/ConsumerModel.java
0% <0%> (ø)
0 <0> (?)

.../java/org/apache/dubbo/config/ReferenceConfig.java
51.07% <100%> (+0.35%)
42 <0> (ø)
:arrow_down:

...in/java/org/apache/dubbo/config/ServiceConfig.java
47.9% <100%> (-0.47%)
63 <0> (-1)

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adb5b0e...c78648a. Read the comment docs.

If it prevents reuse when staying in the config module, then let's move these classes to the rpc module.
This migration will have no effect on other functionalities but for telnet, please make sure telnet still works fine when doing this.


chore: ci-workflow

Description :sparkles:
Issues :bug:
Closes :no_good_woman:
OH-136:
Related :handshake:
Testing :alembic:
Automated tests :gear:
Manual testing :construction_worker_man:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.41%. Comparing base (91b71c1) to head (9fae5f3).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   95.46%   95.41%   -0.06%
==========================================
  Files         125      125
  Lines        3746     3748       +2
  Branches      403      404       +1
==========================================
  Hits         3576     3576
- Misses        116      117       +1
- Partials       54       55       +1

Flag
Coverage Δ

95.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ATV-API branch is deployed to platta: https://atv-api-hki-kanslia-atv-dev.agw.arodevtest.hel.fi :rocket::rocket::rocket:

ATV-API branch is deployed to platta: https://atv-api-hki-kanslia-atv-dev.agw.arodevtest.hel.fi :rocket::rocket::rocket:


System returns technology agnostic (POJO) payloads

In Genie 2.0 the entity (JPA) classes were used as data transfer objects. This worked all right given the limited scope but as we move to Genie 3 we're realizing that this coupling of the Entity/Domain model and the data transfer layer is causing limitations. The entity classes are becoming fields of annotations and as we need to do things to change the data model it directly impacts services and API's. This shouldn't be the case. Currently if someone wanted to implement a service storage in something other than JPA they would have to use entity classes to transfer data. Implement a new system where read-only DTO's are used to transfer data from client to server and within the server between services. This should enable us to blackbox our services better and implement them multiple ways while freeing us up to make changes to the data model and other internals without impacting API, UI etc.
DTO's should be documented in API documentation.

Complete. Documentation will be done as part of #154


TypeError undefined is not an object (evaluating 'nativeVersion.major')

Is this a bug report?
YES

i want rn 0.49, but error with this, why?

Have you read the Contributing Guidelines?
YES
Environment
Environment:
OS: macOS Sierra 10.12.6
Node: 6.10.3
Yarn: 0.21.3
npm: 5.5.1
Watchman: 4.7.0
Xcode: Xcode 9.1 Build version 9B55
Android Studio: 2.3 AI-162.3934792
Packages: (wanted => installed)
react: ^16.1.1 => 16.1.1
react-native: 0.49.0 => 0.49.0

You’d get this error if you’re not running the same version of JS as the native code. I’d recommend deleting node modules, clearing derived data, resetting simulator, basically clear all the caches, make sure you have the same version of TN everywhere, then rebuild since this isn’t a bug with RN.

thank you, clean and run, is ok,

I had to run watchman watch-del-all && react-native start --reset-cache

@wanghuajian620 They just moved out the PropTypes from React core. You have require separate package to use it, https://www.npmjs.com/package/prop-types

i am getting error

do try building, react-native run-android /ios and check for any errors and then restart package manager. It solved the error for me. I got errors when I have run react-native run-android


[NetAppFiles] Update azure-mgmt-netapp version to 7.0.0

Description

Update azure-mgmt-netapp dependency to version 7.0.0 and changes made according to that version.
Fixed list parameters that were declared as tag type.
Fixed boolean parameters for active directory commands.
Fixed NFSv3 volume creation with no export policy.
Testing Guide

History Notes

[NetAppFiles] az netappfiles snapshot restore-files: New command to restore specified files from the specified snapshot to the active filesystem
[NetAppFiles] az netappfiles volume create: Add optional parameters --enable-subvolumes
[NetAppFiles] az netappfiles volume delete: Add optional parameter --force-delete or --force
[NetAppFiles] az netappfiles volume update: Add optional parameter --unix-permissions
[NetAppFiles] az netappfiles subvolume: New command group to manage subvolume resources
[NetAppFiles] az netappfiles subvolume create: New command to create subvolume
[NetAppFiles] az netappfiles subvolume show: New command to get specified subvolume
[NetAppFiles] az netappfiles subvolume update: New command to update specified subvolume
[NetAppFiles] az netappfiles subvolume list: New command to get all subvolume in a specified volume
[NetAppFiles] az netappfiles subvolume delete: New command to delete specified subvolume
[NetAppFiles] az netappfiles subvolume metadata: New command group to manage subvolume metadata resources
[NetAppFiles] az netappfiles subvolume metadata show: New command to get details about a specified subvolume
[NetAppFiles] az netappfiles account ad add: New optional parameters to support ldap search scope --user-dn, --group-dn and --group-filter
[NetAppFiles] az netappfiles account ad update: New optional parameters to support ldap search scope --user-dn, --group-dn and --group-filter

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

NetAppFiles

@hildurhodd, Please fix CI issues

I am not able to figure out why this is failing:
FAIL - HIGH severity: no_ids_for_list_commands     Command: netappfiles subvolume list - List commands should not expose --ids argument
There is no ids argument for this command

Hi @hildurhodd, I've merged this PR to support the feature first. --no-wait command can finish long running operation in advance instead of waiting for the long running operation finish.

Hi @hildurhodd, I've merged this PR to support the change of your PR first. --no-wait command can finish long running operation in advance instead of waiting for the long running operation finish.

Hi @kairu-ms, thanks for this. I will create a ticket for no-wait support, and it will be included in the coming pull requests


Sort []reflect.Value

Pull Request Test Coverage Report for Build 322

152 of 154 (98.7%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 99.666%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

helpers/tdutil/sort.go
132
134
98.51%

Totals

Change from base Build 318:
-0.03%

Covered Lines:
5072

Relevant Lines:
5089

💛  - Coveralls


CHANGE(BMP-242): update example for CI

Modified interpolation strings with the non-deprecated ones and added github workflow.

pom.xml should contain interpolation string


THRIFT-4476: Typecasting problem on list items (+ low precision double rendering, + mis-rendering non-fractional double literals in Python)

high precision double rendering in JS, Java, Python and C++
testing double rendering in JS, Java, Python and C++

see the related issue: https://issues.apache.org/jira/browse/THRIFT-4476

It appears that there is another compilation problem in Erlang. In the file test/DoubleConstantsTest.thrift, the double literal 1000000.1 is compiled to 1e+06. However, Erlang does not accept exponent literals where the number before the exponent does not have floating point. This causes an error in some tests.

The AppVeyor builds stay in the queue for a long time. Is there any possibility to run the builds more quickly?

You can fork the project and set up your own Travis CI and Appveyor builds, and submit pull requests into your fork to kick off builds, and you will not contend with the rest of the apache arsenal of projects.

Two errors at the initial steps of my builds:

The one in Travis (happening in multiple builds):

Resolving master.dl.sourceforge.net (master.dl.sourceforge.net)... <IP_ADDRESS>
Connecting to master.dl.sourceforge.net (master.dl.sourceforge.net)|<IP_ADDRESS>|:80... failed: Connection refused.
The command '/bin/sh -c apt-key adv --keyserver keyserver.ubuntu.com --recv-keys EBCF975E5BA24D5E &&         wget http://master.dl.sourceforge.net/project/d-apt/files/d-apt.list -O /etc/apt/sources.list.d/d-apt.list &&         wget -qO - https://dlang.org/d-keyring.gpg | apt-key add -' returned a non-zero code: 4
The command "if [[ `uname` == "Linux" ]]; then build/docker/refresh.sh; fi" failed and exited with 4 during .

The one in AppVeyor (at the initial steps):

Downloading winflexbison3
  from 'https://sourceforge.net/projects/winflexbison/files/old_versions/win_flex_bison-2.5.10.zip'
WARNING: C:\projects\thrift\buildcache\winflexbison3\<IP_ADDRESS>70725\win_flex_bison-2.5.10.zip is of content type text/html
Progress: 100% - Completed download of C:\projects\thrift\buildcache\winflexbison3\<IP_ADDRESS>70725\win_flex_bison-2.5.10.zip (652 B).
Download of win_flex_bison-2.5.10.zip (652 B) completed.
Error - hashes do not match. Actual value was '7A07D3F7CCA5C0B38CA811984EF8DA536DA32932D68C1A6CCE33EC2462B930BF'.
ERROR: Checksum for 'C:\projects\thrift\buildcache\winflexbison3\<IP_ADDRESS>70725\win_flex_bison-2.5.10.zip' did not meet '565967D6F6D021B617144698DEDD055DF9B91825CB61A7E1F29BFD22219F550C' for checksum type 'sha256'. Consider passing the actual checksums through with --checksum --checksum64 once you validate the checksums are appropriate. A less secure option is to pass --ignore-checksums if necessary.
The install of winflexbison3 was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\winflexbison3\tools\chocolateyInstall.ps1'.
 See log for details.
Chocolatey installed 0/1 packages. 1 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
Failures
 - winflexbison3 (exited -1) - Error while running 'C:\ProgramData\chocolatey\lib\winflexbison3\tools\chocolateyInstall.ps1'.
 See log for details.
Command exited with code -1

I think these errors are build configration-related. These also showed up in the builders running on my forked repo.

Sourceforge was down for a while.  I am working on getting the builds back to green (passing).  I recommend that you keep your pull request squashed to one commit.  In fact since you are doing iterative development you are clogging up the pull request build pipeline.  I recommend you close this pull request and work on your own fork until you are satisfied you have resolved the issues.  I am hoping to have the builds back to "green" by the end of today.

Okay, I will open it back once I am done.

I finalized the changes, however there are a couple of errors in my builds which I think are irrelevant to my changes.
Here are the links to my build results (please let me know if you cannot access them):
Travis-CI: https://travis-ci.org/ozymaxx/thrift
AppVeyor: https://ci.appveyor.com/project/ozymaxx/thrift/build/1.0.0-dev.42
Here are the error descriptions:
On Travis CI #19.7:
  +--<EMAIL_ADDRESS>  +--<EMAIL_ADDRESS>  | `--<EMAIL_ADDRESS>  +--<EMAIL_ADDRESS>  `--<EMAIL_ADDRESS>    +--<EMAIL_ADDRESS>    `--<EMAIL_ADDRESS>      `--<EMAIL_ADDRESS>        `--<EMAIL_ADDRESS>deduped
npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>Makefile:811: recipe for target 'check-local' failed
make[4]: *** [check-local] Error 1
make[4]: Leaving directory '/thrift/src/lib/js'
Makefile:686: recipe for target 'check-am' failed
make[3]: *** [check-am] Error 2
make[3]: Leaving directory '/thrift/src/lib/js'
Makefile:536: recipe for target 'check-recursive' failed
make[2]: *** [check-recursive] Error 1
make[2]: Leaving directory '/thrift/src/lib/js'
Makefile:580: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory '/thrift/src/lib'
Makefile:662: recipe for target 'check-recursive' failed
make: *** [check-recursive] Error 1

On Travis CI 19.11:

npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>Makefile:811: recipe for target 'check-local' failed
make[4]: *** [check-local] Error 1
make[4]: Leaving directory '/thrift/src/lib/js'
Makefile:686: recipe for target 'check-am' failed
make[3]: *** [check-am] Error 2
make[3]: Leaving directory '/thrift/src/lib/js'
Makefile:536: recipe for target 'check-recursive' failed
make[2]: *** [check-recursive] Error 1
make[2]: Leaving directory '/thrift/src/lib/js'
Makefile:580: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory '/thrift/src/lib'
Makefile:662: recipe for target 'check-recursive' failed
make: *** [check-recursive] Error 1

On AppVeyor Environment: PROFILE=CYGWIN, PLATFORM=x64, CONFIGURATION=RelWithDebInfo, DISABLED_TESTS=(ZlibTest|OpenSSLManualInitTest|TNonblockingServerTest|StressTestNonBlocking):
2314Scanning dependencies of target thrift_static
2315      0 [main] make 3676 fork: child -1 - forked process 3656 died unexpectedly, retry 0, exit code 0xC0000005, errno 11
2316make[2]: fork: Resource temporarily unavailable
2317make[1]: *** [CMakeFiles/Makefile2:1171: lib/cpp/CMakeFiles/thrift_static.dir/all] Error 2
2318make: *** [Makefile:161: all] Error 2
2319
2320C:\projects\thrift>set lastexitcode=2
2321
2322C:\projects\thrift>set  1>C:\Users\appveyor\AppData\Local\Temp\tmp86A3.tmp
2323
2324C:\projects\thrift>echo C:\projects\thrift  1>C:\Users\appveyor\AppData\Local\Temp\tmp86A4.tmp
2325
2326C:\projects\thrift>exit /b 2
2327

The current master is fairly clean except for a recurring dlang issue.  Squash and rebase on master.  Squash to one commit please.

I merged the changes in the master branch into mine, and ran the builds. There are still some errors:
On AppVeyor:
3125"C:\projects\build\MSVC2017\x64\INSTALL.vcxproj" (default target) (1) ->
3126"C:\projects\build\MSVC2017\x64\ALL_BUILD.vcxproj" (default target) (3) ->
3127"C:\projects\build\MSVC2017\x64\test\cpp\TestServer.vcxproj" (default target) (32) ->
3128(ClCompile target) ->
3129  C:\projects\thrift\test\cpp\src\TestServer.cpp(799): error C3861: 'sleep': identifier not found [C:\projects\build\MSVC2017\x64\test\cpp\TestServer.vcxproj]
3130
3131    24 Warning(s)
3132    1 Error(s)

On Travis:
depbase=`echo gen-c_glib/t_test_second_service.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/bash ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src/thrift -I../../lib/c_glib/src/thrift  -I../../lib/c_glib/src -Igen-c_glib  -g -Wall -Wextra -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2 -MT gen-c_glib/t_test_second_service.lo -MD -MP -MF $depbase.Tpo -c -o gen-c_glib/t_test_second_service.lo gen-c_glib/t_test_second_service.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src/thrift -I../../lib/c_glib/src/thrift -I../../lib/c_glib/src -Igen-c_glib -g -Wall -Wextra -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2 -MT gen-c_glib/t_test_second_service.lo -MD -MP -MF gen-c_glib/.deps/t_test_second_service.Tpo -c gen-c_glib/t_test_second_service.c  -fPIC -DPIC -o gen-c_glib/.libs/t_test_second_service.o
gen-c_glib/t_test_second_service.c: In function 't_test_second_service_processor_process_secondtest_string':
gen-c_glib/t_test_second_service.c:397:3: error: unknown type name 'TTestSecondServiceSecondtestStringArgs'; did you mean 'TTestSecondServiceProcessorClass'?
   TTestSecondServiceSecondtestStringArgs * args =
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   TTestSecondServiceProcessorClass
gen-c_glib/t_test_second_service.c:398:19: error: 'T_TEST_TYPE_SECOND_SERVICE_SECONDTEST_STRING_ARGS' undeclared (first use in this function); did you mean 'T_TEST_TYPE_SECOND_SERVICE_PROCESSOR'?
     g_object_new (T_TEST_TYPE_SECOND_SERVICE_SECONDTEST_STRING_ARGS, NULL);
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                   T_TEST_TYPE_SECOND_SERVICE_PROCESSOR
gen-c_glib/t_test_second_service.c:398:19: note: each undeclared identifier is reported only once for each function it appears in
gen-c_glib/t_test_second_service.c:408:5: error: unknown type name 'TTestSecondServiceSecondtestStringResult'; did you mean 'TTestSecondServiceProcessorClass'?
     TTestSecondServiceSecondtestStringResult * result_struct;
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     TTestSecondServiceProcessorClass
gen-c_glib/t_test_second_service.c:417:35: error: 'T_TEST_TYPE_SECOND_SERVICE_SECONDTEST_STRING_RESULT' undeclared (first use in this function); did you mean 'T_TEST_TYPE_SECOND_SERVICE_SECONDTEST_STRING_ARGS'?
     result_struct = g_object_new (T_TEST_TYPE_SECOND_SERVICE_SECONDTEST_STRING_RESULT, NULL);
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                   T_TEST_TYPE_SECOND_SERVICE_SECONDTEST_STRING_ARGS
depbase=`echo gen-c_glib/t_test_thrift_test.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/bash ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src/thrift -I../../lib/c_glib/src/thrift  -I../../lib/c_glib/src -Igen-c_glib  -g -Wall -Wextra -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2 -MT gen-c_glib/t_test_thrift_test.lo -MD -MP -MF $depbase.Tpo -c -o gen-c_glib/t_test_thrift_test.lo gen-c_glib/t_test_thrift_test.c &&\
mv -f $depbase.Tpo $depbase.Plo
depbase=`echo gen-c_glib/t_test_thrift_test_types.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/bash ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src/thrift -I../../lib/c_glib/src/thrift  -I../../lib/c_glib/src -Igen-c_glib  -g -Wall -Wextra -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2 -MT gen-c_glib/t_test_thrift_test_types.lo -MD -MP -MF $depbase.Tpo -c -o gen-c_glib/t_test_thrift_test_types.lo gen-c_glib/t_test_thrift_test_types.c &&\
mv -f $depbase.Tpo $depbase.Plo
Makefile:654: recipe for target 'gen-c_glib/t_test_second_service.lo' failed

npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>Makefile:811: recipe for target 'check-local' failed
make[4]: *** [check-local] Error 1
make[4]: Leaving directory '/thrift/src/lib/js'
Makefile:686: recipe for target 'check-am' failed
make[3]: *** [check-am] Error 2
make[3]: Leaving directory '/thrift/src/lib/js'
Makefile:536: recipe for target 'check-recursive' failed
make[2]: *** [check-recursive] Error 1
make[2]: Leaving directory '/thrift/src/lib/js'
Makefile:580: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory '/thrift/src/lib'
Makefile:662: recipe for target 'check-recursive' failed
make: *** [check-recursive] Error 1

Am I missing something? @jeking3

Appveyor: It looks like I broke the build yesterday with a check-in that I did not run through CI.  I am fixing it.
Travis: c_glib, that's new; npm; that might be an intermittent failure
Could you squash your PR to one commit to prepare it for merge?

The AppVeyor builder with the MSVC2013 configuration generates large double constants differently as the old MSVC2010 configuration used to do. So I will add a condition to not do the TestRenderedDoubleConstants test on that builder. I also suspect that this problem might be due to the architecture (x86). The result of the CYGWIN x86 builder will give us some clue on this.

I put the MSVC2013 job back in to make sure we had some backwards compatibility... glad I did.   I wonder if we have 32-bit issues with double in general in thrift?

I have just disabled my new tests on MSVC2013 builders and kicked a build. Let's see what happens.
If the tests also fail on the CYGWIN machine, I will also write out new tests for the x86 machines. However, the issue is not about the architecture, only some modifiers seem to be overlooked in the generators.

The build on the CYGWIN x86 (see https://ci.appveyor.com/project/ozymaxx/thrift/build/job/09xqx9b54efog55o for more details) machine has broken. Here is the error that I got:
3504CMake Error at lib/java/cmake_install.cmake:39 (file):
3505  file INSTALL cannot find
3506  "/cygdrive/c/projects/build/CYGWIN/x86/lib/java/build/docs/javadoc".
3507Call Stack (most recent call first):
3508  cmake_install.cmake:36 (include)

Some of the Travis builds have timed out (more details at https://travis-ci.org/ozymaxx/thrift). A build has also failed with the following error:
Failed examples:

rspec ./spec/server_spec.rb:103 # Server Thrift::ThreadPoolServer should serve inside a thread
rake aborted!
/usr/bin/ruby2.3 -S rspec ./spec/base_protocol_spec.rb ./spec/base_transport_spec.rb ./spec/binary_protocol_accelerated_spec.rb ./spec/binary_protocol_spec.rb ./spec/bytes_spec.rb ./spec/client_spec.rb ./spec/compact_protocol_spec.rb ./spec/exception_spec.rb ./spec/flat_spec.rb ./spec/http_client_spec.rb ./spec/json_protocol_spec.rb ./spec/namespaced_spec.rb ./spec/nonblocking_server_spec.rb ./spec/processor_spec.rb ./spec/serializer_spec.rb ./spec/server_socket_spec.rb ./spec/server_spec.rb ./spec/socket_spec.rb ./spec/ssl_socket_spec.rb ./spec/struct_nested_containers_spec.rb ./spec/struct_spec.rb ./spec/thin_http_server_spec.rb ./spec/types_spec.rb ./spec/union_spec.rb ./spec/unix_socket_spec.rb --color --format d failed
/var/lib/gems/2.3.0/gems/rspec-core-2.13.1/lib/rspec/core/rake_task.rb:156:in `run_task'
/var/lib/gems/2.3.0/gems/rspec-core-2.13.1/lib/rspec/core/rake_task.rb:124:in `block (2 levels) in initialize'
/var/lib/gems/2.3.0/gems/rspec-core-2.13.1/lib/rspec/core/rake_task.rb:122:in `block in initialize'
Tasks: TOP => default => gem => spec => realspec
(See full trace by running task with --trace)
Makefile:655: recipe for target 'check-local' failed
make[3]: *** [check-local] Error 1
make[3]: Leaving directory '/thrift/src/lib/rb'
Makefile:515: recipe for target 'check-am' failed
make[2]: *** [check-am] Error 2
make[2]: Leaving directory '/thrift/src/lib/rb'
Makefile:580: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory '/thrift/src/lib'
Makefile:662: recipe for target 'check-recursive' failed
make: *** [check-recursive] Error 1

@jeking3

@jeking3 Forget about what I said on Travis. There is only 1 failure in Apache arsenal of Travis (at cross-test) as follows:
===============================================================================
Using JSON protocol
Using framed transport
testVoid() = void
testString("Test") = "Test"
testBool(true) = True
testBool(false) = False
testByte(1) = 1
testI32(-1) = -1
testI64(-34359738368) = -34359738368
testDouble(5.325098235) = 5.325098235
testDouble(-0.000341012439638598279) = -0.000341012439638598
testBinary(000102030405060708090A0B0C0D0E0F101112131415161718191A1B1C1D1E1F202122232425262728292A2B2C2D2E2F303132333435363738393A3B3C3D3E3F404142434445464748494A4B4C4D4E4F505152535455565758595A5B5C5D5E5F606162636465666768696A6B6C6D6E6F707172737475767778797A7B7C7D7E7F808182838485868788898A8B8C8D8E8F909192939495969798999A9B9C9D9E9FA0A1A2A3A4A5A6A7A8A9AAABACADAEAFB0B1B2B3B4B5B6B7B8B9BABBBCBDBEBFC0C1C2C3C4C5C6C7C8C9CACBCCCDCECFD0D1D2D3D4D5D6D7D8D9DADBDCDDDEDFE0E1E2E3E4E5E6E7E8E9EAEBECEDEEEFF0F1F2F3F4F5F6F7F8F9FAFBFCFDFEFF) =<PHONE_NUMBER>05060708090A0B0C0D0E0F101112131415161718191A1B1C1D1E1F202122232425262728292A2B2C2D2E2F303132333435363738393A3B3C3D3E3F404142434445464748494A4B4C4D4E4F505152535455565758595A5B5C5D5E5F606162636465666768696A6B6C6D6E6F707172737475767778797A7B7C7D7E7F808182838485868788898A8B8C8D8E8F909192939495969798999A9B9C9D9E9FA0A1A2A3A4A5A6A7A8A9AAABACADAEAFB0B1B2B3B4B5B6B7B8B9BABBBCBDBEBFC0C1C2C3C4C5C6C7C8C9CACBCCCDCECFD0D1D2D3D4D5D6D7D8D9DADBDCDDDEDFE0E1E2E3E4E5E6E7E8E9EAEBECEDEEEFF0F1F2F3F4F5F6F7F8F9FAFBFCFDFEFF
testBinary(000102030405060708090A0B0C0D0E0F101112131415161718191A1B1C1D1E1F202122232425262728292A2B2C2D2E2F303132333435363738393A3B3C3D3E3F404142434445464748494A4B4C4D4E4F505152535455565758595A5B5C5D5E5F606162636465666768696A6B6C6D6E6F707172737475767778797A7B7C7D7E7F808182838485868788898A8B8C8D8E8F909192939495969798999A9B9C9D9E9FA0A1A2A3A4A5A6A7A8A9AAABACADAEAFB0B1B2B3B4B5B6B7B8B9BABBBCBDBEBFC0C1C2C3C4C5C6C7C8C9CACBCCCDCECFD0D1D2D3D4D5D6D7D8D9DADBDCDDDEDFE0E1E2E3E4E5E6E7E8E9EAEBECEDEEEFF0F1F2F3F
.
.
.
*** FAILED ***
*** FAILED ***
*** FAILED ***
*** FAILED ***
*** FAILED ***
Test CrazyNesting
testStruct({"Zero", 1, -3, -5}) = {"Zero", 1, -3, -5}
testNest({1, {"Zero", 1, -3, -5}, 5}) = {1, {"Zero", 1, -3, -5}, 5}
testMap({0 => -10, 1 => -9, 2 => -8, 3 => -7, 4 => -6}) = {0 => -10, 1 => -9, 2 => -8, 3 => -7, 4 => -6}
testList({-2, -1, 0, 1, 2}) = {-2, -1, 0, 1, 2}
testSet({-2, -1, 0, 1, 2}) = {0, 1, 2, -2, -1}
testEnum(ONE) = ONE
testEnum(TWO) = TWO
testEnum(THREE) = THREE
testEnum(FIVE) = FIVE
testEnum(EIGHT) = EIGHT
testTypedef(309858235082523) =<PHONE_NUMBER>82523
testMapMap(1) = {4 => {1 => 1, 2 => 2, 3 => 3, 4 => 4, }, -4 => {-4 => -4, -3 => -3, -2 => -2, -1 => -1, }, }
testInsanity() = {1 => {TWO => {{FIVE => 5000, }, {{"Truck", 8, 8, 8}, }}, THREE => {{FIVE => 5000, }, {{"Truck", 8, 8, 8}, }}, }, 2 => {SIX => {{}, {}}, }, }
Test Multi(1,2,9223372036854775807,System.Collections.Generic.Dictionary`2[System.Int16,System.String],FIVE,5000000) = Xtruct(byte_thing:1,String_thing:Hello2,i32_thing:2,i64_thing:9223372036854775807)
testException("Xception")
testException("TException")
testException("ok")
testMultiException("Xception", ...)
testMultiException("Xception2", ...)
testMultiException("success", "OK")
Test Oneway(1)
Test Calltime() = 59 ms a testVoid() call
Total time: 00:00:04.3274560

===============================================================================
Return code: 1
Test execution took 4.5 seconds.
Wed Mar 14 13:10:58 2018

But the error is the same in the Windows builders (although it seems green here).

Btw, what's the full name of the test which you want to succeed? I squashed to another commit and will take a look if this test has passed or not (I hope there is not something wrong related to my change set :))

Need to squash to one commit, ideally, to make a merge easier, and fix the issue causing older MSVC compilers (which people still use...) to generate different floating constants than other compilers.  There could be a compiler flag, or a way to fix it in the compiler.  It's great that we added tests to verify the output of the compiler; we shouldn't disable the new tests just because the C++ compiler is different.

Okay, I will add a condition on the tests. The values to do the assertions with will depend on the compiler.

You may be missing my point here.  Regardless of the compiler used to build the thrift compiler, whether it is gcc-4.6, clang-6.0, MSVC 2010, MSVC 2013, MSVC 2017, the floating constants emitted from the thrift compiler should be the same.  If they are not, I recommend fixing the thrift compiler and NOT disabling the new tests which caught an important issue.

@jeking3 , I will now re-enable the tests. But please note that the problem is at the C++ compiler level. The pre-2015 versions of the Visual Studio C++ compilers uses a different parsing and formatting algorithms on floating point numbers. Check this link out: https://blogs.msdn.microsoft.com/vcblog/2014/06/18/c-runtime-crt-features-fixes-and-breaking-changes-in-visual-studio-14-ctp1/ (go to the title "Floating Point Formatting and Parsing Correctness")
Another article describing the issue: http://www.exploringbinary.com/visual-c-plus-plus-strtod-still-broken/
The comment made on the article, by a Visual Studio dev. team member: http://www.exploringbinary.com/visual-c-plus-plus-strtod-still-broken/#comment-9403
In the light of these, the best solution seems checking the compiler version, and doing the tests accordingly.

@jeking3 or another alternative path to go: emitting double can depend on the msvc compiler version. If the compiler version is 2013 or less, we can ignore using fixed.

If there's a way to fix it in the compiler so that it works properly, that's much better.  Having compiler-version-specific branches in the thrift compiler to handle floating point oddities like this is fine.  Carrying the C++ compiler identifier down through the build system and pass into the tests as an argument/option/variable should really be avoided.

I have reverted the changes on passing the compiler flag to the testers, and modified the double emitter.

@jeking3 the build results have come out.

All green! :)

Yes, however, it needs to be squashed to a single commit.  I would prefer if you did that, but I can do it if you really need me to.  It's just a lot more work for the committers to do that, and we have a lot of work we're doing already.  Looks like a good change though - thanks for that!  Clearly you care about your doubles a lot.
https://softwareengineering.stackexchange.com/questions/263164/why-squash-git-commits-for-pull-requests

Thanks! I have just caught the meaning of squash since it's been the first time i try to contribute an open source project. I will squash all into a single one and let you know from here.