with_name  issue

Cursive library introduced new trait: https://docs.rs/cursive/0.15.0/cursive/traits/trait.Nameable.html#method.with_name
This breaks this library if I want to use with_name() or NamedView directly.
My example usage gives me this error when I try to wrap table with NamedView:
error[E0277]: the trait bound `cursive_table_view::TableView<ui::images::ImageTableRow, ui::images::ImageTableColumn>: cursive_core::view::view_wrapper::ViewWrapper` is not satisfied
  --> src/ui/images.rs:81:29
   |
81 |       ui.add_fullscreen_layer(NamedView::new(
   |  _____________________________^
82 | |         "images_table",
83 | |         ResizedView::with_full_screen(table),
84 | |     ));
   | |_____^ the trait `cursive_core::view::view_wrapper::ViewWrapper` is not implemented for `cursive_table_view::TableView<ui::images::ImageTableRow, ui::images::ImageTableColumn>`
   |
   = note: required because of the requirements on the impl of `cursive_core::view::view_trait::View` for `cursive_table_view::TableView<ui::images::ImageTableRow, ui::images::ImageTableColumn>`
   = note: required because of the requirements on the impl of `cursive_core::view::view_wrapper::ViewWrapper` for `cursive_core::views::resized_view::ResizedView<cursive_table_view::TableView<ui::images::ImageTableRow, ui::images::ImageTableColumn>>`
   = note: required because of the requirements on the impl of `cursive_core::view::view_trait::View` for `cursive_core::views::resized_view::ResizedView<cursive_table_view::TableView<ui::images::ImageTableRow, ui::images::ImageTableColumn>>`
   = note: required because of the requirements on the impl of `cursive_core::view::view_wrapper::ViewWrapper` for `cursive_core::views::named_view::NamedView<cursive_core::views::resized_view::ResizedView<cursive_table_view::TableView<ui::images::ImageTableRow, ui::images::ImageTableColumn>>>`
   = note: required because of the requirements on the impl of `cursive_core::view::view_trait::View` for `cursive_core::views::named_view::NamedView<cursive_core::views::resized_view::ResizedView<cursive_table_view::TableView<ui::images::ImageTableRow, ui::images::ImageTableColumn>>>`
   = note: required because of the requirements on the impl of `cursive_core::view::into_boxed_view::IntoBoxedView` for `cursive_core::views::named_view::NamedView<cursive_core::views::resized_view::ResizedView<cursive_table_view::TableView<ui::images::ImageTableRow, ui::images::ImageTableColumn>>>`

I'm no expert but Cursive provides convinient macro that can help with this implementation: https://github.com/gyscos/cursive/blob/main/cursive-core/src/view/view_wrapper.rs#L13

This is most likely a version mismatch between the version of cursive you use, and the one used in this library. The hint "ViewWrapperis not implemented" is a bit misleading;Viewis what is actually required, rustc sees thatViewWrapperimplementsView`, and that's what is offers.

This is most likely a version mismatch between the version of cursive you use, and the one used in this library. The hint "ViewWrapperis not implemented" is a bit misleading;Viewis what is actually required, rustc sees thatViewWrapperimplementsView`, and that's what is offers.


Update manage-environments-infra-definitions.md

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://659c0315404dea02e424c941--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://659c03da1954300093b76761--harness-developer.netlify.app


_<

Hello good afternoon sir,
can I use this repo to learning?? and want to ask how to use it?

Yes you can use it.
Thank You
Richard Dewan

From: TDR-3000 @.>
Sent: Monday, August 15, 2022 12:59 PM
To: rddewan/App-License-Manager-WEB @.>
Cc: Subscribed @.***>
Subject: [rddewan/App-License-Manager-WEB] >_< (Issue #6)
Hello good afternoon sir,
can I use this repo to study? and want to ask how to use it?
—
Reply to this email directly, view it on GitHubhttps://github.com/rddewan/App-License-Manager-WEB/issues/6, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADEN5B7752USE6VMIIHPO4DVZHWVZANCNFSM56RLLLOQ.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


HeapByteBufferR not Usable

The underlying Agrona code has a hard time with HeapByteBufferR (read-only view) that I tried to use:
java.lang.ClassCastException: java.nio.HeapByteBufferR cannot be cast to sun.nio.ch.DirectBuffer
	at uk.co.real_logic.agrona.concurrent.UnsafeBuffer.putBytes(UnsafeBuffer.java:732)
	at uk.co.real_logic.agrona.concurrent.UnsafeBuffer.putBytes(UnsafeBuffer.java:713)
	at io.reactivesocket.internal.FrameFlyweight.encode(FrameFlyweight.java:141)

Not an issue.


compile error

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
/home/smart-battery-edge/inverter-tools-master/inverter-tools-master/HIDAPI_INCLUDE_DIR
used as include directory in directory /home/smart-battery-edge/inverter-tools-master/inverter-tools-master
used as include directory in directory /home/smart-battery-edge/inverter-tools-master/inverter-tools-master
/home/smart-battery-edge/inverter-tools-master/inverter-tools-master/LIBSERIALPORT_INCLUDE_DIR
used as include directory in directory /home/smart-battery-edge/inverter-tools-master/inverter-tools-master
used as include directory in directory /home/smart-battery-edge/inverter-tools-master/inverter-tools-master
used as include directory in directory /home/smart-battery-edge/inverter-tools-master/inverter-tools-master
HIDAPI_LIBRARY
linked by target "inverterd" in directory /home/smart-battery-edge/inverter-tools-master/inverter-tools-master
linked by target "inverterctl" in directory /home/smart-battery-edge/inverter-tools-master/inverter-tools-master
LIBSERIALPORT_LIBRARY
linked by target "inverterd" in directory /home/smart-battery-edge/inverter-tools-master/inverter-tools-master
linked by target "testserial" in directory /home/smart-battery-edge/inverter-tools-master/inverter-tools-master
linked by target "inverterctl" in directory /home/smart-battery-edge/inverter-tools-master/inverter-tools-master

You need to install hidapi and libserialport.

how is command to build all?
this is another error  #include <nlohmann/json.hpp>

did you resolve compilation issues?


Config proposal

Hi,
Please can you provide a proposal for a config file with Security Key?
Thanks!

as in an example?
{
    networkKey: 62E7BCB13BC9B3525B806AA3306AA616
}


Browser freezes when maxZoom is to high

const map = L.map('map', {
  center: L.latLng([48.78232, 9.17702]),`
  maxZoom: 180
});

This looks like a core Leaflet issue (and not a markercluster one). I know there are problems going beyond level 32 (due to int32 precision and such), but am unsurehow/where to check for this best.

Core Leaflet: https://jsfiddle.net/falkedesign/1rLntbo5/ (working)
With MarkerCluster: https://jsfiddle.net/falkedesign/xpjz53hf/6/ (freezing)
I only added:
const clusterMarker = L.markerClusterGroup();
var marker = L.marker([48.79232, 9.17702], { pmIgnore: false });
// Also add a marker outside of the cluster
clusterMarker.addLayer(marker);

// Add cluster of markers to map
map.addLayer(clusterMarker);

Maybe MarkerCluster creating something for each zoom level

I'm experiencing exactly the same issue. If I add max zoom to the map config, the map renders.


Delay for validation CSS classes on ion-item

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.6.0
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
Validation CSS classes for inputs inside list items are not properly applied (delayed by one input event) to their containging item.
Expected behavior:
Validation CSS classes should be applied suddenly to the input field itself, the containing item and the form.
Steps to reproduce:
http://plnkr.co/edit/s8GHhetlXV3hJMJy5dIn?p=preview
The form field has [minlength="4"], so focus the form field and enter 4 characters. It is still red (invalid).
If you inspect the HTML you'll see the ion-input and the form are updated and have .ng-valid classes but the ion-item is not yet updated.
If you enter another character or blur the field, the ion-item gets updated, too.
It's the exat same behaviour the other way around - if you delete some characters and drop below the 4 required ones.
Related code:
<ion-list>
	<form>
		<ion-item>
			<ion-input type="text" minlength="4" [(ngModel)]="username" name="username" required></ion-input>
		</ion-item>
	</form>
</ion-list>

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
cli packages: (C:\...)
    @ionic/cli-utils  : 1.9.2
    ionic (Ionic CLI) : 3.9.2

local packages:
    @ionic/app-scripts : 2.1.3
    Ionic Framework    : ionic-angular 3.6.0

System:
    Node : v6.9.1
    npm  : 4.0.2
    OS   : Windows 10

Hello! Thank you for opening an issue with us!
I am closing this because I believe it is a repeat of #12588 & (especially) #12503, but your example is really good so I will make sure those issues link back here. Please follow those issues for further updates.
Thank you for using Ionic


Remove unsupported Python versions

Coverage: 100.0%. Remained the same when pulling 18ca4aedbe31a75045727bddca4d84f14d6f1f72 on remove-stale-versions into 354b1e58f349f14931d2402e2b29b41080f14fbd on master.


Add Spotify element

Added Spotify element:

Displays current track and artist names
Icon changes based on currently playing/paused
Clicking the element pauses and unpauses the current track
Hides when Spotify is closed

Playing:

Paused:

Spotify closed:

Not sure whether this element should be enabled by default?

I really like that, I'll merge it as it is. I think it is not a problem to enable it by default for now.
Maybe when I have created some installation scripts, I could let the user choose what "widget" he want to display.
I'd just like to do something to handle long song names because on a 13" screen I'm worried that it would overlap on current process name.
Anyway, thank you for this functionality!

That's a good idea, much better than truncating 👍

I was thinking about something like this:

(The gif is a bit laggy)
If it's okay for you I'll push that :)

Looks great! 🚀


Add examples utilizing plugins

For the Acl plugin, this test contract can also serve as example. Probably we should mention it in the README.

@mooori Olha is about to finish adding several examples there, the PR will be created soon. The issue is just to have an appropriate one matched to the PR.


Active link doesn't work before reloading

When top nav link is clicked it doesn't apply active attribute until page is reloaded.

https://github.com/ReactTraining/react-router/issues/1684#issuecomment-129171225


[Windows] No longer exclude WinRe KB from updates

Description
It should be a part of distro now
Related issue:
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run windows2019,windows2022


Enhance UI for "Meet our Friends Here" Section

Enhance the "Meet our Friends Here" section's UI by replacing the previous rectangular design with more suitable styling, aligning it with UI standards and improving the overall user experience.
Before :

After :

I would like to work on it. Can u assign this to me

Hi @akshitagupta15june  , I am from JOWC, please assign me this issue.


Documentation anchros not working

Hi there,
the documentation anchors in docs/specification are not working.

Thanks for fixing it!


filtering search results' list by means of an external system

Dear Sirs,
Let me describe my development scenario:
a) I already was able to create a custom template, appliable by its triggers on the query results' list, for showing my Idol custom field content in the 'black badge', see this picture:

b) custom template currently applies ONLY to results coming from a couple of indexes (Idol databases) that have the custom field whose content I need to show in the badge. But I need to implement a further filtering rule to be applied to results. I need to show the 'black badge' ONLY if the current user in NOT-AUTHORIZED to read a result in the list. Such authorization concerns permissions the current user has to access the "Fascicolo" (that's my Idol custom field) and such an auth is not managed by Idol (ACL, SecurityInfo) but it is managed by an external system, a REST-API JEE application that exposes some JPA-Repo endpoints to check for current user permissions. Permissions are stored to a SQLServer DB-schema
c) is there a way to modify Find Java code in order to query the external system, AFTER the Idol-query action, for current user's authorized list of "Fascicolo"?
NOTICE: "Fascicolo" is the italian for "Folder", a collection of documents, held by an Alfresco ECM instance, but that complexity is all-managed behind the system that exposes permissions endpoints

If the idea is to hide documents which the user is not allowed to see; I would recommend using IDOL's document-level mapped security instead; which can selectively hide or show documents based on the user's permissions in content itself; rather than trying to filter in Find itself.
See https://www.microfocus.com/documentation/idol/IDOL_12_0/IDOLServer/Guides/pdf/English/IDOL_12.0_DocumentSecurity_en.pdf

I already used IDOL DOCUMENT MAPPED SECURITY in prevs projects, mapping LDAP Users and Groups to Idol by using OmniGroupServer and providing ACL when importing documenta to Idol indexes. Also using SecirityInfo tokens with every query. And it works!
But I fear I cannot in this current scenario:

customer is a main domestic security agency and they do not want/can map part of their internal LDAP domain (Groups, Users) to Idol; it is a legal impediment
document's permissions vary very frequently, even more than once per-day, so keeping documents ACLs updated being very demanding
finally, Idol Find should interact with another system, exchanging some data (in the request/response headers) such as: user-identity, portal-identity, resulting not-allowed "Fascicolo"-IDs; i.e. user should be able to click the black-badge and so sending the "Fascicolo"-ID, readable in the badge, to the other system (another web application) in order to issue a "request for temporary access/search authorization"

Well, if you really want to, you can try adding code to the end of com.hp.autonomy.types.requests.Documents#query to call out to your external server and censor the results.
https://github.com/microfocus-idol/find/blob/9cffadd8d7a6182fe72a68be667e742c917b258c/webapp/idol/src/main/java/com/hp/autonomy/frontend/find/idol/search/IdolDocumentsController.java#L153
I don't think this is a good idea though; since the original text may still be leaked in query summaries or other aggregate information.

Sorry, correction; that's actually the "recommend-documents" callback; forgot to rename it.
If you're doing the censoring; you actually want to add a new method to that same file to override the query method on the superclass, e.g.
@Override
public Documents<IdolSearchResult> query(
        @RequestParam(TEXT_PARAM) final String queryText,
        @RequestParam(value = RESULTS_START_PARAM, defaultValue = "1") final int resultsStart,
        @RequestParam(MAX_RESULTS_PARAM) final int maxResults,
        @RequestParam(SUMMARY_PARAM) final String summary,
        @RequestParam(value = INDEXES_PARAM, required = false) final List<String> databases,
        @RequestParam(value = FIELD_TEXT_PARAM, defaultValue = "") final String fieldText,
        @RequestParam(value = SORT_PARAM, required = false) final String sort,
        @RequestParam(value = MIN_DATE_PARAM, required = false) @DateTimeFormat(iso = DateTimeFormat.ISO.DATE_TIME) final ZonedDateTime minDate,
        @RequestParam(value = MAX_DATE_PARAM, required = false) @DateTimeFormat(iso = DateTimeFormat.ISO.DATE_TIME) final ZonedDateTime maxDate,
        @RequestParam(value = HIGHLIGHT_PARAM, defaultValue = "true") final boolean highlight,
        @RequestParam(value = MIN_SCORE_PARAM, defaultValue = "0") final int minScore,
        @RequestParam(value = AUTO_CORRECT_PARAM, defaultValue = "true") final boolean autoCorrect,
        @RequestParam(value = INTENT_BASED_RANKING_PARAM, defaultValue = "false") final boolean intentBasedRanking,
        @RequestParam(value = QUERY_TYPE_PARAM, defaultValue = "MODIFIED") final String queryType
) throws AciErrorException {
    final Documents<IdolSearchResult> results = super.query(queryText, resultsStart, maxResults, summary, databases, fieldText, sort, minDate, maxDate, highlight, minScore, autoCorrect, intentBasedRanking, queryType);

    final List<IdolSearchResult> origDocs = new ArrayList<>(results.getDocuments());

    results.getDocuments().clear();

    for(final IdolSearchResult doc : origDocs) {
        final String username = authenticationInformationRetriever.getPrincipal().getName();
        // TODO: call some external server based on the username
        final boolean redact = true;

        if (redact) {
            // we are arbitrarily hiding the summary, and saying 'redacted' instead
            results.getDocuments().add(doc.toBuilder()
                .summary("redacted")
                .build());
        }
        else {
            results.getDocuments().add(doc);
        }
    }

    return results;
}

The same information-leaking-via-query-summaries-or-other-aggregate-information considerations apply though; so it's not really a good idea.

I am trying to implement it.
I want to call "Idol Find" url (from another application) passing some Request Params, this way:
http://localhost:15080/public/search/query?basicToken=[aBase64Token]&idPortaleRis=3
(note: launching Idol Find webapp as a pre-authenticated service)
Then, in my Override of the "recommend-documents" callback, I want to be able to read such two params, something like this:
   // how to get these two ?
   final int **idPortaleRis** = requestParamsRetriever.getIdPortale()
   final String **basicToken** = "Basic " + requestParamsRetriever.getBasicToken();

   for(final IdolSearchResult doc : origDocs) {
	// final String username = authenticationInformationRetriever.getPrincipal().getName();
	// TODO: call some external server based on the username

       // call to external endpoint - here
   }

cause I need them for calling the external-system endpoint.
Could you let me know the way to pass those two-params throughout up to my overridden method, in the "IdolDocumentsController.java" class ?

thank You Tung, v.m.,
inspecting the ["idol" module] query Controller class (IdolDocumentsController.java) I am not able to find a parameter corresponding to the 'famous' anyLanguage boolean param for the Idol query action. How to add it?
I need query returns results in more than 1 language, at least Italian and English

Sorry Tung,
by using the new method/code U suggested to me:
"If you're doing the censoring; you actually want to add a new method to that same file to override the query method on the superclass, e.g. ..."
I am experiencing an error in visualizing the results List: Required String parameter 'text' is not present
and I see:

I tried to provide the queryText param to the URL:

localhost:15080/public/search/query?queryText=omicidio
or
localhost:15080/public/search/query?text=omicidio
but the error still happens

Also, I tried to use some null/empty guard-clauses in the method body:
//guard-clauses
String theQueryText=queryText, theSummary=summary; int theMaxResults=maxResults;
if (theQueryText == null || theQueryText.isEmpty() ) theQueryText="*";
if (theMaxResults < 1) theMaxResults=30;
if (theSummary == null || theSummary.isEmpty() ) theSummary="";

final Documents<IdolSearchResult> results = super.query(
	theQueryText, resultsStart, theMaxResults, theSummary, databases, fieldText,
		sort, minDate, maxDate, highlight, minScore, autoCorrect, intentBasedRanking, queryType);

but it still happens. I cannot understand what is the origin of that error. In the browser console I have:

The anylanguage=true parameter is already being sent; look at the action=grl of IDOL or the content engine query logs to confirm that.
If you're searching with terms which should return results in English and Italian and you're only getting English; your content engine language settings are probably not configured correctly; talk to Micro Focus support for advice.
Without seeing your configs and data it's impossible to diagnose; but possibly the solution would involve adding
 [LanguageTypes] GenericStemming=true
to your content config; and if you have [english] NgramMultiByteOnly=TRUE replace it with [english] NGramOrientalOnly=true . After making changes, you'd have to reindex the content (DREEXPORTIDX/DREEXPORTXML your data to save it, DREINITIAL to wipe all data and use new config, DREIMPORT your idx/xml back in).
As for your Required String parameter 'text' is not present error, I can't debug it without having your code and stack traces since you've made your own changes. https://github.com/microfocus-idol/find/tree/example/scoped-bean-parameter-passing builds correctly for me. Try running mvn clean to remove all existing built files, then build again and see if that helps.

It works!
my error was to leave the 'original_12.0.0' query method un-renamed; I followed Your #49-issue code-sample and now I have no more ('text' param) errors. Moreover, I can receive the two passed request-params through autowiring Ur Holder Component both into IdolDocumentsController and IdolFindController classes, of the "idol" module
I think we can close this issue, now.
If I need more help, I will open it again

dear Tung Jin Chew
I dont want to repoern this issue, but I have a question:
see my attache image on "Apr 3rd": I added to the results List a black badge as a background for my custom data ("... Protocollo ASC-..."). Such a badge has its onclick method (it copies the Protocollo_ID to the browser clipboard) BUT when I click it also the results List standard behavior happens, details open to the right side of the List. How could I avoid to open details panel ONLY for those results with the custom-data black badge ? (only in such cases I dont want details to be shown)
Many Thanks, b.r.

it worked perfectly!
many thanks


Add "fade" to envelope elements

The elements that describe envelopes are collected within EnvelopeControls and include:

delay
attack
hold
decay
sustain
release

These describe most envelope curves but there are many devices that also have a parameter to control the slope of the sustain level. This is sometimes called "fade" and is a time based element, similar to decay.
It may be advantageous to add "fade" to the list, i.e. http://lv2plug.in/ns/ext/parameters#fade. This would likely handle most, fixed envelopes.
There are also flexible envelopes, constructed of arbitrary quantity of stages with each stage described by a level and a time (duration) parameter. It may be advantageous to have a mechanism for describing such an envelope. I am not sure how best to do that. I haven't yet looked at how LV2 might describe this or whether it has structures that might suit.

Calf Monosynth and Calf Wavetable have a, "fade" parameter for its envelopes. The fade is bipolar, allowing increasing or decreasing slope on the sustain phase with 0 being flat, positive numbers increasing the downward slope and negative numbers increasing the upward slope.
MiMi-d has a, "sustain time" parameter which controls the slope of its sustain phase. This is a positive only value that controls the time it takes for the curve to hit zero, with 10 being flat and 0 being instantaneous.
There may be others but these are near the top of my list of LV2 software synths so are the ones I encounter most often.
It occurs to me, whilst revisting this topic that "fade" may not be the appropriate symbol to use for this parameter. Maybe "sustain_decay" would be a better symbol.


Valkyrie Issue Templates

Hello everyone,
I have created some github issue templates to streamline issue creation for Valkyrie.
Issue selection

Issue markdown

Final issue

This streamlines the issue experience and points the users towards a clearer direction what kind of issue they want to add and what information is needed.
Currently I came up with four common issue categories:

Feature
Bug
New Scenario
Scenario Translation
Question

You can try them here (feel free to open some issues, I'll delete the repo later anyway) and the code is here.
What do you think of that? Are there maybe more common categories that could be used?

Another common one is just question, though maybe you can just broaden the definition of bug?

Ah yes that's definitely missing. I'd prefer to have it's own category for Question because of the auto tagging feature.

@scrubbless  @redwolf2 Any ideas regarding this stuff?
What do you think of automtically setting the title. Do you think there would be too many user who forget to update it when creating the ticket?
I think starting with the topic in brackets (e.g. [Bug]) makes the issue list much cleaner. See this as an example.

It's done ! Thanks @Quantumrunner

Unlike it! Very nice


remove gopacket import in agent/process-agent

What does this PR do?
Reorganizes the NDM traceroute code to not import github.com/google/gopacket into a binary, unless it is needed.
Motivation
The github.com/google/gopacket dependency has several large fixed allocations that can take up memory, even if not used. This is part of a larger effort to reduce the RSS and binary size of the agent processes.
Describe how to test/QA your changes
Code was only reorganized not functionally changed, so existing automated tests is sufficient.
Possible Drawbacks / Trade-offs
Additional Notes

looks like this may not be working on windows?

Clear win here, thanks for the contribution

looks like this may not be working on windows?

Unrelated. One known flake and the other two failing jobs are also failing on main.

/merge


Automated cherry pick of #7449

Cherry pick of #7449 on cloud.
/cc  @mgdelacroix

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: c5b9210e1fbed8780743930609d565ced287c4a6


Reduce the verbosity of "info" logging

name: Reduce the verbosity of info logging.
about: Changed SQL_READ and SQL_WRITE logging from info to debug
title: 'Reduce the verbosity of info logging'
labels: Status:Discovery
assignees: ''

Environment
Liquibase Version: 3.8.9
Liquibase Integration & Version: Core
Liquibase Extension(s) & Version:
Database Vendor & Version: All
Operating System Type & Version: All
Pull Request Type

[ ] Bug fix (non-breaking change which fixes an issue.)
[x] Enhancement/New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
As discussed in CORE-3220, and PR #918, Liquibase logs all SQL statements at an info level.  Usually logging that kind of detail is done at a debug level.  This PR changes the log level of SQL_READ and SQL_WRITE logging to debug.  This way, the default level of "info" just tells you what changes Liquibase is running, which is perfect for info logging.
Steps To Reproduce
List the steps to reproduce the behavior.
Run any changelog with the log level set to "info"
Actual Behavior
A clear and concise description of what happens in the software before this pull request.
All SQL statements are logged to the console.
Expected/Desired Behavior
Only the change sets being run are logged, not the SQL.
Screenshots (if appropriate)
If applicable, add screenshots to help explain your problem.
Additional Context
Add any other context about the problem here.
Fast Track PR Acceptance Checklist:

[x] Build is successful and all new and existing tests pass
[ ] Added Unit Test(s)
[ ] Added Integration Test(s)
[ ] Documentation Updated

This didn't have a testing impact since there aren't any tests to verify at what level each thing logs.
┆Issue is synchronized with this Jira Story by Unito
┆Fix Versions: Liquibase 4.0 beta 2

@stevesaliman that was quick, thanks!
Sizing risklow thanks to all the work done by submitter:

Contains clear description
links in old PR and issue for context
contains tests (yay!)

@stevesaliman ,
One more favor Steve, would you mind targeting this PR for master?  We are now asking users to do PRs to master for issues that are not release specific.
I hear you worked with @nvoxland and would love to catch up with you and fill you in on our plans for community contributions.
Thanks for being a part of the team!
-Ronak
Liquibase Developer Evangelist.

It looks like Liquibase 4 (what is in master) has completely changed the way logging is done.  Instead of statements like log.debug(LogType.WRITE_SQL, sqlToExecute[0]);, Liquibase is now using SqlListeners to write the sql it is going to run, and it looks like it doesn't log all the statements by default, which is what this PR does.
So I think this PR is still useful for future 3.8.x releases, and I'd request that it be included in future 3.8.x releases, but I don't think it applies anymore in the world of 4.0.

@stevesaliman , thanks for the clarification.  It makes sense, we are concentrating on 3.10.1 and 4 currently, and operational patch fixes to the existing branches is being hashed out.  Hang tight and we'll update this PR shortly.

That raises an interesting point.  My intent for this patch (and a couple of others I've submitted) was for them to go out in the next 3.x version, whatever that was.  Do I need to re-submit them as PRs against the 3.10.x branch?

@stevesaliman, the easiest path forward (I just met with @nvoxland) would probably be to target 3.10.x (realistically 3.10.2).

Closing.  This same code was already merged as part of #1258


initialCamera crashes iOS with google provider [NSMallocBlock zoom]: unrecognized selector sent to instance

Summary
With<EMAIL_ADDRESS>initialCamera works in iOS and google provider.
With<EMAIL_ADDRESS>the app crashes in iOS and google provider.
Using android and google provider works without any problems.
Error:
[__NSMallocBlock__ zoom]: unrecognized selector sent to instance 0x280881bc0
Further logs can be found in the end.
Reproducible sample code
<MapView
    provider={PROVIDER_GOOGLE}
    initialCamera={{
        altitude: 0,
        center: { latitude: 52.509266, longitude: 13.397118 },
        heading: 0,
        pitch: 0,
        zoom: 11,
    }}
/>

Steps to reproduce
Use sample code above on an iOS device.
Expected result
App should not crash when using initialCamera für iOS (google maps).
Actual result
App crashes.
React Native Maps Version
1.0.0
What platforms are you seeing the problem on?
iOS (Google Maps)
React Native Version
0.69.1
What version of Expo are you using?
 I will look into it and get back to you :)

Quick status report and notes for myself and others who might look into this:
_initialCamera is being deallocated before being accessed in layoutSubviews.

This is happening in v1.0.0-beta.1, so should be introduced here https://github.com/react-native-maps/react-native-maps/compare/v0.31.1...v1.0.0-beta.1
I haven't had the time to figure out why this is happening yet.

Hi guys. I've just released v1.0.1 that should fix the issue. Could you test it out and report back to me?

@Simon-TechForm Yeah, thx! :) Works perfectly now.

Yes all good, thanks for the quick fix!


[BUG] Anchors may have invalid chars that break the links

VS Code version
OS
Extension version

1.14.0
Win 10 x64 pro (french) 14393
0.8.1

Steps to reproduce
Use extension to create/update the TOC will produce this:

- [Valid link](#valid-link)
- [Invalid _link_](#invalid-_link_)
- [Another invalid link ([a link](https://link.com))](#another-invalid-link-a-linkhttpslinkcom)

## Valid link

## Invalid _link_

## Another invalid link ([a link](https://link.com))

Results
Second and third links are broken in TOC.
Expectations
Extension must remove invalid chars such as _ or links in title to build valid reference targets. So the code above should be:

- [Valid link](#valid-link)
- [Invalid _link_](#invalid-link)
- [Another invalid link (a link)](#another-invalid-link)

## Valid link

## Invalid _link_

## Another invalid link ([a link](https://link.com))

Note: the third link still won't work in VSCode but do in GitHub.

Regards

Thank your for your issue.
I had fixed it, i will release new version in recent days.


web server bound to pod hostname instead of <IP_ADDRESS>

Describe the bug
Kubernetes port forwarding to either web console (8161) or core (61616) does not work due to web server of broker bound to pod host name instead of <IP_ADDRESS>
To Reproduce
Steps to reproduce the behavior:

using docker-desktop kubernetes, deploy a cluster of 2 brokers with web console exposed using the following spec:
`apiVersion: broker.amq.io/v2alpha5
kind: ActiveMQArtemis
metadata:
name: ex-aao
spec:
adminUser: root
adminPassword: password
deploymentPlan:
size: 2
image: placeholder
messageMigration: true
persistenceEnabled: true
podSecurity:
runAsUser: 0
console:
expose: true
sslEnabled: false
addressSettings:
applyRule: merge_all
addressSetting:

match: '#'
autoDeleteAddresses: true
autoDeleteQueues: true`

Run port-forward on dekstop to forward requests from localhost to the pod on cluster:
kubectl port-forward pod/ex-aao-ss-0 8161:8161 -n myproject
3.Try to access the web console from desktop: http://localhost:8161/console and observe connection refused at port forward:
Handling connection for 8161 E0823 16:45:23.498827   30440 portforward.go:400] an error occurred forwarding 8161 -> 8161: error forwarding port 8161 to pod 8e8a1bc1d45bab4643532b6035fa3a54bffadff672ab1c58c7786dd35b185274, uid : exit status 1: 2021/08/23 20:45:12 socat[15739] E connect(17, AF=2 <IP_ADDRESS>:8161, 16): Connection refused

Platform (please complete the following information):

OS: Windows 10 with WSL2
Version 0.20.0 (according to version.go file)
Go [e.g. 1.13.4

Expected behavior
Optional, use if not obvious. A clear and concise description of what you expected to happen.
Screenshots
Optional, add screenshots to help explain your problem.
Additional context
Optional. Add any other context about the problem here.

So, what's the status?

The web server of broker bounds to pod host name instead of <IP_ADDRESS> for security reasons but we could add a second bind to localhost address to fix this issue, WDYT?

Binding to localhost helps in this case (port forwarding to localhost) but in the case where we need to expose it to external developer with a url like https://tenant1.mycompany.com/dev/Artemis would it work? Ideally, we would like to have an option to config the binding

@lnthai2002  the operator creates Ingress on Kubernetes and Route on Openshift for console with expose and sslEnabled true, i.e.
apiVersion: broker.amq.io/v1beta1
kind: ActiveMQArtemis
metadata:
  name: artemis-broker
spec:
  console:
    expose: true
    sslEnabled: true

Staring from 1.0.11 you will be able to set a custom ingress domain, see #475, i.e.
apiVersion: broker.amq.io/v1beta1
kind: ActiveMQArtemis
metadata:
  name: artemis-broker
spec:
  console:
    expose: true
    sslEnabled: true
    ingressDomain: 'tenant1.mycompany.com'

Thank you, so I guess the 2nd binding for localhost is good for me and when I need to expose to external dev, I can use the ingress

Hello, any new on supporting localhost?

Hi before the localhost bind option is added, you can try using a custom init image to configure the broker console.
Some examples for building a custom init: https://github.com/artemiscloud/artemiscloud-examples/tree/main/operator/init


Simplify build process

Currently our users don't need to copy over the fabritone jar to TEST the project, but to BUILD it they gotta open up the fabritone project. That's annoying.
When building a full jar the process should be easy. If at all possible, everything should be merged into one jar.
If not, at least every dependent jar should be included somewhere in the build folder.

This is only true for Fabritone.
I think it's better to focus on #36 and solve this(#41) issue in that way...

Well not really, the issue is that fabritone/baritone would be included as a SEPARATE jar. Your mods folder should look like this:
mods
- alto-clef-SNAPSHOT.jar
- baritone-1.16.jar
- other potential jar files also must be put here!

However, when you run build in the altoclef project, it only generates the alto-clef-SNAPSHOT.jar, not the other jars. Doesn't matter if the separate project is using fabritone or baritone. The user should have easy access to those jars when building, otherwise every time they want to test it online they have to open up the project that can build baritone-1.16.jar AND also locate all the other dependencies that I may add in the future. That's no fun, and I'd like to fix that before making an official build/release.

Shadow works with extra libraries, but the baritone jar is still needed and I couldn't figure out how to package it together.
Will abandon this idea for now, as external libraries can now be added without changing the build process.


Version 1.0.18

🛠 Fixes

LanguageSelector ref issue fix

The current PR templates are a bit hard to use as you need to pass them as a query parameter. I'll remove the other one so then it should always use the default template. Let's fit that it in this release still so we can test it out in the next version release✌🏻

The current PR templates are a bit hard to use as you need to pass them as a query parameter. I'll remove the other one so then it should always use the default template. Let's fit that it in this release still so we can test it out in the next version release✌🏻

yeah sure 👍🏻 I'll also wait with the merge for @kacperkosinski, as he may also want to introduce the Table component in this release 😉


ConverterConfigurer not found

class ConverterConfigurer not found in the package which is downloaded from maven repository
https://mvnrepository.com/artifact/com.github.rozidan/modelmapper-spring-boot-starter/1.0.0

Hi, the ConverterConfigurer is exists in the 1.0.1-snapshot version.
Add the sonatype public repository
repositories {
mavenCentral()
maven { url "https://oss.sonatype.org/content/groups/public" }
...
}


added wip action

This GitHub Action sets a pull request status to pending if the title includes "WIP".
Related to #122

@smaranjitghose please review it.


Improve configuration to be read on fly

The config (practically just api endpoint at this moment) is build into the final bundle. REfactor codes to read this value from file on the server.

This is solved (indirectly) by the way the system is deployed. The issue was removed unless we need some very special app url mapping.


Add stripProperPrefix, filename, and dirname operations

This methods exists in commercialhaskell/path -> add them to strong path also. They are useful and needed.
There are also couple more functions dealing with properPrefix, and there are some functions dealing with file extensions -> consider adding those to.

Instead of filename and dirname separately, I implemented basename that works both on files and dirs.

Closing in favor of #40 .


Sync version between Sbt and Gradle

I a not 100% sure if this is the right approach (but maybe I just miss some information and context here).
Can you explain a bit when exactly do you need the version from sbt for gradle? Is it for the release process?
The problem I see is that when the compiler/version.properties file does not exist, I have to run publish or publishM2 to generate it, however this triggers a snapshot release to sonatype (at least when running publish, I just did that). Also when e.g. checking out a git tag to reproduce things locally, I would have to run publish just to generate the version.properties files, but the publish command will fail because a release would already exist in the maven central repos.
Do you know what I mean?
Maybe, if you explain a bit we can figure out how to solve this (or maybe I just get things wrong).

Hi, Matthias! 👋
This PR needs to us by two reason.

Have the same version for Gradle plugin as other Twirl modules
Gradle plugin will be depends on Twirl compiler and we need a version of compiler that published locally or public.

The problem I see is that when the compiler/version.properties file does not exist, I have to run publish or publishM2 to generate it, however this triggers a snapshot release to sonatype (at least when running publish, I just did that).

publishM2 installs artifacts into Local Maven repo we won't have a problem with Sonatype. Anyway, we always can create this file manually if sure that this compiler version is already published somewhere.

Do you know what I mean?

Yep. Think that it's just a bridge between Sbt and Gradle to tell Gradle what version Gradle plugin should be and what version compiler we should depends. Maybe in the future this will be separated variables but now I think one is enough.


Generic driver sudo requirements should be documented

Currently the documentation for the generic driver and guides states the the user used need to have passwordless sudo rights. However the only examples I can find states to solve it likes this:
"dockeradmin     ALL=(ALL) NOPASSWD: ALL." which essentially allows the user to do anything
From a security point of view this is unacceptable. If sudo rights are needed (that's another question) then the explicit requirements must be documented so that administrators can setup an account which grants only those rights.

As another potential user I agree it is madness to require this sudo setup. Can we have an option that expects the host to be setup correctly already, not requiring any automated, and intrusive, changes to the existing host? At most it does sanity checks that the host has what is needed instead of trying to brute force a specific setup.


[rebber-plugins] Simplify escape code

Here what I suggest for the escapes, please tell me if you have any comments.

sounds good to me.


EventLoop doesn't provide Reader a way to terminate execution elegantly

Problem
The code in the EventLoop class handles the reader (typically a composite reader) and provides it with events from the tree(s) by:

Call reader.begin() method
For each event:
a. Call reader.event()
Call reader.end()

In each case, the return of each of reader's methods is ignored.  This makes it awkward for a reader to tell the event loop to terminate early, or not run at all in the case of begin(). begin() can raise an exception of course, but in some cases that is more extreme than really needed.
Solution
Have the return of each calll to reader begin, event, and end checked, and execution halted if the return does not evaluate to true.
Specific example
I'm running over a large heppy dataset and including the existing RA1 AlphaTools sequence as a single Reader.  The heppy dataset is being split up using AlphaTwirl and submitted to the Bristol htcondor batch system.  One of the datasets in this input is not supposed to be handled by AlphaTools and AlphaTools knows this, so it would normally just ignore it, however this causes an exception to be raised crashing the batch job, which is then re-submitted.  To enable things to finish elegantly, I would prefer to be able to signal to the EventLoop that this jobs should not proceed in the begin() method of the reader that wraps AlphaTools.

That is an interesting point.
Can you point me to the single Reader mentioned in Specific example?
The return code of event() is already used for event selection. For example in ReaderComposite:
https://github.com/alphatwirl/alphatwirl/blob/4948d49794636c64865a87457bd44f50029a6256/alphatwirl/loop/ReaderComposite.py#L36-L38
also classes in basic.py.
If event() returns False, that means the reader rejects the event. It doesn't mean that the reader cannot read any more events.
Neither of the return codes of begin() or end() is used.
Your suggestion implies that a reader doesn't always begin with begin() but can decide not to read any events. I would like to understand why that happens. Why is the eventLoop called at first place?


No hurricane tracks on the UI (v0.2.19)

There are no tracks shown along with the other hurricane layers on the UI.
i do see the track layer in the catalog data. it is just not being displayed on the UI

Is this V1 we are talking about? The custom code for getting MetGet hurricane track info was not added to V1.

nope, v0.2.19.

I see hurricane tracks on the AWS UI right now.

all i see is the cone the icons, no track.


Have ParseWebHook return a event-related "marker" interface

ParseWebHook currently returns an interface{}. I know there's no one method that all webhook events share. But what if we added a "marker" interface and had ParseWebHook return that type? This would make the return type of ParseWebHook a little clearer, and allow consumers to use the same interface in their codebase as they pass events throughout.
Example:
type GitHubEvent interface {
    Event()
}

func (e *BranchProtectionRuleEvent) Event() {}
func (e *CheckRunEvent) Event() {}
func (e *CheckSuiteEvent) Event() {}
...
func (e *WorkflowRunEvent) Event() {}

Exporting the method (Event()  in the example above) would be useful for tests. Tests could define struct types that implement the same interface, independent of specific webhook types.
Related
https://github.com/google/go-github/issues/1154

Thank you, @hashtagchris . I think I would have to see this to give my opinion.
Do you want to put together a PR with test cases demonstrating its implementation and usage?
Bonus points if you don't break any existing APIs.  :smile:

Thanks @gmlewis, I'll try to put something together. However I think one of the biggest benefits is the stricter type checking during the build. I'm not sure I can capture that in a test case.
Short example
package main

import (
	"fmt"
	"log"
)

func main() {
	// no build error - have to use runtime checks to catch this bad arg 👎
	LogEvent("Oops, I'm passing a string instead of an event")

	// build error 🎉
	LogEventUsingProposedType("Oops, I'm passing a string instead of an event")
}

type GitHubEvent interface {
	Event()
}

type BranchProtectionRuleEvent struct {
	RuleName string
	// imagine several more fields relevant to BranchProtectionRuleEvent here
}

func (e *BranchProtectionRuleEvent) Event() {}

func LogEvent(event interface{}) {
	switch evt := event.(type) {
	case *BranchProtectionRuleEvent:
		fmt.Printf("BranchProtectionRule: %s\n", evt.RuleName)

	default:
		log.Fatalf("Type %T is not a known event type\n", event)
	}
}

func LogEventUsingProposedType(event GitHubEvent) {
	switch evt := event.(type) {
	case *BranchProtectionRuleEvent:
		fmt.Printf("BranchProtectionRule: %s\n", evt.RuleName)

	default:
		log.Fatalf("Type %T is not a known event type\n", event)
	}
}

https://go.dev/play/p/RacH5YLMAo3

Ah, I gotcha, @hashtagchris - thank you for the example!  So the down-side to this is that we "simply" need to make sure that every event has the magic line func (e *BranchProtectionRuleEvent) Event() {}, correct?  Can this be kept up-to-date with go generate ./... ?
If the answer is "yes" (and I think the answer is indeed "yes"), then we could put all these magic lines in a separate auto-generated file with the standard "DO NOT EDIT - See Contributing.md for details", and never have to think about this again, right?
If so, then this makes sense to me to do.  Obviously, others are welcome to comment with other opinions.
If there are no objections, then do you want to put together a PR that implements this, @hashtagchris , or would you like to open this up for one of our other contributors to implement?

Yup and Yup!
I may have time this week to contribute changes. Would you have the generator identify the event structs by iterating over the eventTypeMapping values? Or use the AST to find the  exported struct types with a name ending in Event?

Yup and Yup!

Fantastic! It's yours.

I may have time this week to contribute changes. Would you have the generator identify the event structs by iterating over the eventTypeMapping values? Or use the AST to find the exported struct types with a name ending in Event?

Great question! I'm all for the solution that is easiest to maintain (which usually means "simplest") and the one which seems to be most future-resistant as possible in the hopes that no matter what we do to the code, it will reliably find the events.  So I'm leaning toward the former, but am leaving it up to you. We can further comment during the code review. 😁

@gmlewis I made some progress, but won't be able to work on this again for several weeks. I created a draft PR and I'm open to other contributors taking this change forward.
Thanks for the encouragement and guidance!

I second this proposal.
As a step further, we could group events and provide an higher level API. For example, some of them always have a Sender field. So we have dummy code like:
func getSender(eventPayload interface{}) (string, error) {
	switch payload := eventPayload.(type) {
	case *github.IssueCommentEvent:
		return *payload.Sender.Login, nil
	case *github.PullRequestEvent:
		return *payload.Sender.Login, nil
	case *github.PullRequestReviewEvent:
		return *payload.Sender.Login, nil
	case *github.PullRequestReviewCommentEvent:
		return *payload.Sender.Login, nil
	case *github.PushEvent:
		return *payload.Sender.Login, nil
	case *github.ReleaseEvent:
		return *payload.Sender.Login, nil
	case *github.CheckRunEvent:
		return *payload.Sender.Login, nil
	case *github.CheckSuiteEvent:
		return *payload.Sender.Login, nil
	case *github.IssuesEvent:
		return *payload.Sender.Login, nil
	case *github.ProjectCardEvent:
		return *payload.Sender.Login, nil
	case *github.ProjectColumnEvent:
		return *payload.Sender.Login, nil
	case *github.ProjectEvent:
		return *payload.Sender.Login, nil
	case *github.WatchEvent:
		return *payload.Sender.Login, nil
	case *github.ForkEvent:
		return *payload.Sender.Login, nil
	case *github.CreateEvent:
		return *payload.Sender.Login, nil
	case *github.DeleteEvent:
		return *payload.Sender.Login, nil
	case *github.PublicEvent:
		return *payload.Sender.Login, nil
	case *github.GollumEvent:
		return *payload.Sender.Login, nil
	case *github.TeamEvent:
		return *payload.Sender.Login, nil
	case *github.TeamAddEvent:
		return *payload.Sender.Login, nil
	case *github.StatusEvent:
		return *payload.Sender.Login, nil
	case *github.MembershipEvent:
		return *payload.Sender.Login, nil
	case *github.LabelEvent:
		return *payload.Sender.Login, nil
	case *github.MilestoneEvent:
		return *payload.Sender.Login, nil
	case *github.PageBuildEvent:
		return *payload.Sender.Login, nil
	}
	return "", fmt.Errorf("unknown event type")
}

@hashtagchris: I'll try to help out on the draft PR.


Issues/#878 adding fake stacked gas asset data (Part 2/3)

Adding a gas load page with a gas chart (the data is used is fake).
Merge: #887 first.

@ChaelKruip This is what it looks like with some real data.

The 0.125 bar ↔ 4 bar and 4 bar ↔ 8 bar connections have some fairly extreme constraints, and 50% loss.
On the one hand, I think this chart is useful for getting an overview of the loads on each layer, but I also find the combination of capacity constraints and loss can be quite confusing. A visitor might not understand how there could be 14MWh of load on the endpoints, but only ~1MWh the next level up. The answer is that there's a capacity constraint, and a 13MWh deficit.
We can remedy this by showing deficits and surpluses (flaring) at each level:

What do you think?
Loss is a bit of an awkward one, because it is visualised on the positive (consumption) side of the chart, when in fact it can occur both as a result of consumption and production (feed-in). Perhaps it should be split into two separate parts?

We can remedy this by showing deficits and surpluses (flaring) at each level:

I like this a lot! I suggest to plot the deficit in the positive direction (just as consumption).
The negative direction is reserved for feed-in and I think both the feed-in and the resulting loss should be plotted in the negative direction.
I would rename "Surplus" to "Flaring" and show it in the negative direction as well.
FYI: the losses only occur for feed-in direction (when compressing gas from low to high pressure). Gas flowing down has no losses.

I would rename "Surplus" to "Flaring" and show it in the negative direction as well.

Will do.

FYI: the losses only occur for feed-in direction (when compressing gas from low to high pressure). Gas flowing down has no losses.

I know that's true in the real-world, I just wanted to cover all eventualities. 😆
I'll swap loss to the negative side of the chart and leave it at that for now.


"direct link" URLs 404

The README mentions:

with direct link

<script src="//cdnjs.cloudflare.com/ajax/libs/vue/3.0.2/vue.min.js"></script>
<!-- CDNJS :: Sortable (https://cdnjs.com/) -->
<script<EMAIL_ADDRESS><!-- CDNJS :: Vue.Draggable (https://cdnjs.com/) -->
<script src="//cdnjs.cloudflare.com/ajax/libs/Vue.Draggable/4.0.0/vuedraggable.umd.min.js"></script>

However 2 out of 3 of these produce a 404: only sortable works.
It would also be nice to include import ... code for those that want to use ESM a the CDN URL.
It's also surprising if this doesn't import its own dependencies and needs Sortable as a peer dependency.
I'm also not sure Vue would be needed here. Anybody using this is already importing Vue in some way.

I think this library is dead, find other ways to accomplish this functionality.

You can get it here
<EMAIL_ADDRESS>


All basic wrapper methods working

Time to ~party~
Create, Load, Resize., Load all working.
Load, and Resize need more tests.
Making a pull request now so everyone can move forward.

Looks great excited to get rolling on more tests


Bug: Content missing in PDF export

When creating a slide full of content, the content is visible in the browser but disappears when exported to a PDF file.
A minimal reproduction can be found in the original issue: https://github.com/slidevjs/slidev/issues/1860

i can confirm this, it maybe related to the layouts/top-title-two-cols.vue CSS.  perhaps something in the pdf export causes the longer divs to be pushed off screen for some reason.  PR welcome!

I noticed that this issue also affects certain slides using the top-title layout (and possibly others).
I found a potential fix, although the underlying cause remains unclear:

-

+

        <slot name="left" />


Server Error

Server Error: Could not Find dependency: RocketAPI ???
Photo:  http://gyazo.com/2e824192f0cbd9734dc283f8b5916411

Looks like an outdated plugin.  What plugins do you have installed?


Rdoc

Enhancements for open, parse, minor tweaks.

@kou, did not mean to merge this.  What to do now?

Ok, thanks.  Will study tomorrow.


Custom header checkbox remains checked when uncheck any row.

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior

Using custom checkbox templates click "select all" checkbox in the datatable header, then uncheck any row. Header checkbox still appears as checked.
Expected behavior

Header checkbox must be unchecked when at least one row would be unchecked.
Reproduction of the problem

Can be reproduced in online demo: http://swimlane.github.io/ngx-datatable/#chkbox-selection-template.

Table version: >10.0.3

Appears in ngx-datatable higher then 10.0.3.
Problem placed right here: https://github.com/swimlane/ngx-datatable/blob/master/src/components/header/header-cell.component.ts#L149
Template gets context object just ones, and when some props shenges, allRowsSelected for instance, cellContex object remains the same.
I think step back to v10.0.3 implementation will solve the problem. Path needed properties directly to [ngTemplateOutletContext]. here: https://github.com/swimlane/ngx-datatable/blob/master/src/components/header/header-cell.component.ts#L34
        [ngTemplateOutletContext]="{
          column: column,
          sortDir: sortDir,
          sortFn: sortFn,
          allRowsSelected: allRowsSelected,
          selectFn: selectFn
        }">

Have you settled it yet? @mishkolesnikov

Yes, using v10.0.3.


TikTok

CZO thread

@ZZxxccvv111 please avoid opening junk issues in this tracker, which is being used by an active project.


Add k8sDistro and prerequisites for OLM CSV

RHEL OLM CSV should have k8sDistro set to "openshift" in the example CR.

Prerequisites in OLM preview:


Add codeclimate GPA badge

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #4   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          13     13
  Lines         205    205
=====================================
  Hits          205    205

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e602074...9ecd608. Read the comment docs.

Closing because codecov misbehaves


task1186_nne_hrngo_classification improvement

Mentioned in issue #630
The task is similar to the tasks added in PR #393

Thanks, the explanations are better, but they can be more direct.
For example, when you say something is not "meaningful" or "grammatical" explicitly refer to the issue in your explanation.

Thanks!


Docs: Wrong title for concurrency reference docs

Summary
https://github.com/litestar-org/litestar/blame/7c4dd4bfceea7361ee76815550bfbf6cf185c5b8/docs/reference/concurrency.rst#L1

[!NOTE]
While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.
Check out all issues funded or available for funding on our Polar.sh dashboard

If you would like to see an issue prioritized, make a pledge towards it!
We receive the pledge once the issue is completed & verified
This, along with engagement in the community, helps us know which features are a priority to our users.

Title is cli but should be concurrency

@redmer PRs are welcome :)

Created a PR to fix :)


MoveToPixelTask

Task to move to a pixel with complete autonomy instead of just aligning. We should also consider pixel priority and potentially integrate this with the current pixel detection systems, as the multi-colour threshold will collate all data in the getData() method.
Will also need to consider making these tasks compatible in Auton as well.

New requirements for improvement:

[ ] Pixel priority
[ ] Calibration of Pixel detection methods, tied to VisionTuner


is returning false on equal lists

Immutable.is( new Immutable.List([]), new Immutable.List([])); --> true
Immutable.is( new Immutable.List([{}]), new Immutable.List([{}])); --> false
I'm guessing this is due to the object being 2 different instances of a native object. Is this the desired behavior?

Yes, this is the expected behavior.

What is the preferred way to check this?

Immutable.is( new Immutable.List([{}]), new Immutable.List([{}])) === false

Is correct for the same reason
Immutable.is( {}, {} ) === false

For the same reason
({} === {}) === false

Two object references are always considered not equal since they are designed to be mutable and allowed value equality checking between them can be dangerous and lead to bugs.
Immutable.js only treats the immutable collections as value equal, which is why comparing two immutable empty lists together is considered equal.
A variation of your original example but using Map instead of a JS object will result in value equality:
Immutable.is(
  Immutable.List([ Immutable.Map() ]),
  Immutable.List([ Immutable.Map() ])
) === true


Batch prefetch in large copy operations

This PR:

Reworks the _copy logic to separate out the cases, making debugging and modifying and optimizing much easier.
Adds a deduplication stage that fetches batch dedup shards for any existing destination files with source data larger than 10MB, as well as the 16 largest files in the batch.

Supplanted by https://github.com/xetdata/pyxet/pull/97


Append to new file

I thought I had broken things when I decided that appending to a new file was the same as appending to an existing file. It seems to me that it should be. However, if I try to do this I end up with a corrupt filename. You can reproduce this by running the test code and selecting option 2:Append without first selecting option 1:Create.
I am writing a log file to the USB drive. I want to append continuously to the log file, but I need to handle the case where the drive is blank at first, or if someone removes the USB drive with the log file on it and inserts a new one with no file on it. This means that every time it is time to write to the log I must first check if the file exists, then create it and write to it if it doesn't exist, or move the cursor to the end and write to it if it does exist. This is cumbersome, but then, so is everything in the programming world.
What I want to do is openFile(), moveCursor(CURSOREND), then writeFile() every time. If the file is new it will be created and will be empty, and moveCursor() will essentially do nothing. Is this possible? I hope so.
Thanks for the great library!

Hi, yes i reproduced. Actually flashDrive.openFile(); function returns a value.If the file is not exist then return 43h what is ERR_FOUND_NAME answer from the chip. So it has to be "if condition". if(flashDrive.openFile() == ANSW_USB_INT_SUCCESS){                      flashDrive.moveCursor(CURSOREND);          } .Thanks, i will update the example code.

Thanks! My current workaround is openFile() then getFileSize(). If the file length is zero then I can use writeFile(), but if it's not then I use moveCursor() then writeFile().
I'm using your code for a simple data logger. I have noticed a couple of odd things, so if I can't get them working then I'll post an issue here. Thanks for taking a look at this one.

Ok, I'm glad I could help. Then i will close this issue and if you find more problems,then you are welcome to open a new issue ;)


Add simple profiling tests

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?  In order to motivate your point, it may be valuable to explain why this change is useful or what problem is being solved.
Additional Notes
This is the section to put technical guidance/constraints, call out potential regressions, cite sources, and in general offer some exposition on the how of the PR.  This section doesn't need to be incredibly detailed, but it makes life easier for reviewers!
How to test the change?
Describe here in detail how the change can be validated.  This is a great section to call out specific tests you've added or improved, or to acknowledge code sections which are particularly difficult to test.

Current dependencies on/for this PR:

main

PR #141

PR #142

PR #143

PR #144

PR #145

PR #146

PR #147

PR #148

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: 9lylUEXBAvDRoXRafmxH


woman_office_worker SVG files are broken

Zoomed in screenshot of assets/Woman office worker/Medium-Light/Color/woman_office_worker_color_medium-light.svg:

Lips are bugged.
PNG version as well as icon in Figma files do not have this bug:
https://github.com/microsoft/fluentui-emoji/blob/main/assets/Woman office worker/Medium-Light/3D/woman_office_worker_3d_medium-light.png
Same bug affects other skin tone variations of this icon.

@cyberalien Thanks for the call out - we'll look at fixing this in our next sprint.


WiP time: sim-time thread safety and move guard-dog fully into abstract time.

Description: This PR addresses a TODO left behind earlier in guarddog_impl.cc which was bypassing the time-source and working directly with real time. Instead we use timers and a dispatcher to run the guard dog.
There was a race previously in guarddog_impl_test.cc which had to be resolved to integrate this (inserting a sleep at the current impl: https://github.com/envoyproxy/envoy/issues/6239#issuecomment-475446764), and another race in the interlock mechanism due to a race between the test sleep()ing (moving time forward) and the impl reading time to compute misses and megamisses. This was resolved by incorporating time into the interlock mechanism.
Note: SimulatedTimeSystem had threading issues when mutating alarms on one thread while executing them on another. The thread-annotation needed overrides due to the challenges the compiler faces proving that time_system_->alarm_->time_system == time_system, and we want to use a single mutex for the time-system and its alarms.
Risk Level: medium -- guarddog runs all the time. OTOH a lot of test iterations show this appears to be robust both in real-time and system-time.
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a

Note: this PR does not resolved #6239 but my plan is to use the same pattern to address that one.

I'm fine with it this way. Thanks for the review and pointing out the great simplification using libevent's new feature. The 1-hour timer also would've been a good hack but the new feature is nicer.


Streams samples bugfix

Resolves issues #642 , #641

Closing in lieu of #645 - The rebase I attempted got messed up.


Math operator in figure caption results in failure.

Description
Using unicode-math version 0.8m, installed with TeX Live 2018, causes math operators in figure captions to fail with the following error:
! Undefined control sequence.
\__um_fontswitch:n ...ath@bgroup \__ummath@bgroup
                                                  \cs_set_eq:NN<EMAIL_ADDRESS>
l.10   \caption{Test caption $i \bmod 64$.}

I am observing this issue on Mac OS X 10.13.
Check/indicate

[X] Relevant for XeTeX
[X] Relevant for LuaTeX
[X] Issue tracker has been searched for similar issues?
[ ] Links to <tex.stackexchange.com> discussion if appropriate

Minimal example demonstrating the issue
\documentclass{article}

\usepackage{unicode-math}

\begin{document}

\begin{figure}
  \caption{Test caption $i \bmod 64$.}
\end{figure}

\end{document}

Further details
Based on the error message, this issue seems to be related to #492.

\bmod has always been a fragile command. If you comment out unicode-math, add \listoffigures and compile with pdflatex, the .lof file will contain
\contentsline {figure}{\numberline {1}{\ignorespaces Test caption $i \nonscript \mskip -\medmuskip \mkern 5mu\mathbin {\mathgroup \symoperators mod}\penalty 900\mkern 5mu\nonscript \mskip -\medmuskip 64$.}}{1}

Use \protect\bmod when the command is used in a moving argument.
On the other hand, it would probably be a good addition if unicode-math makes the command robust.


Selecting a static tab

Is there a proper/official way to make a static tab selectable?
I know there's an approach here: http://stackoverflow.com/questions/37470852/angular2-set-active-tab-on-init but I'm not sure that's the way it should go.

Found a way by using router params.


Allow SOCD settings to be stored alongside a Profile

Please read these quoted sections before submitting, and remove them (including this one) when you have provided what
is asked, in order to make addressing the issue easier for everyone. Thank you!
Be sure to:

Check the documentation HERE to answer many questions on firmware capabilities and usage.
Make sure that your idea has not already been filed HERE.
Confirm the feature does not exist in the latest version of the firmware, found
HERE.

Problem
Different games have different optimal SOCD resolution (e.g. neutral for SF6, vs SOCD-U for tag fighters). Often times, this warrants changing a profile as well as inputting a shortcut on the device to change SOCD.
Solution
Store SOCD settings alongside a profile. This allows a few improvements:

Reducing one less device input to change SOCD alongside changing profiles

Intuitively, this makes it very easy to set-it-and-forget-it for each game
With the recent 0.7.10 release, custom profile names will benefit displays. Seeing the correct profile on your device display is insurance that your SOCD is set correctly, instead of managing two changes on first-plug.

Do you plan to work on this feature yourself?
Yes. I will create a PR to kick things off, and will engage w/ the community and Discord to get this merged.
Notes

Discord Thread

As a breadcrumb you will be looking at adding something new to ProfileOptions in the protobuf structure. I don't have an opinion currently on if that should be more GamepadOptions (most fields of which would be ignored in the profiles) or a new structure (which might suggest GamepadOptions needs a refactoring) but be aware that is a critical element of how to do this.

Would it be feasible to also save the rgb led profile as well? Thank you for reading.


Please add consolidated docs for all Group Policies

Please add consolidated docs for all Group Policies

⚠ Idea migrated from UserVoice
Created By: Anonymous
Created On: 2017/07/27 19:34:28 +0000
Votes at Migration: 1
Supporters at Migration: 1

@ginami @laurenhughes Given this to related to Windows. Can you point to the right person?

Thanks for the feedback--I've passed your request to our authors.

This issue is transferred to author. Currently no plan to create code example in all languages due to resource limitation. But author will keep monitoring the request and get an idea of demand for specific language.


Fi write user data

Description

Adds new Fault Injection countermeasure that duplicate user data pointers during DTLS communication and stores it in ssl context for further pointers verification
Adds MBEDTLS_FI_COUNTERMEASURES to config.h and enables the flag in baremetal.h

Status
READY

Will the MBEDTLS_FI_COUNTERMEASURES setting be provided for all FI countermeasures or only those that consume the most resources?

@piotr-now , for now we can wrap our new FI features with this flag. Latter we will check which already existing FI countermeasures should be wrapped

Please add suggested changes, and also make sure that the formatting is as in the rest of the library - mainly by adding spaces after ( and before ).
Also, there are some major questions to answer, and two things a bit wrong:

The commit message should not exceed 72 characters in length;
The PR has no description (you used an unchanged template), and it's necessary for people that will look at this code later to understand why was it added and what's its purpose.

@AndrzejKurek , I added description to PR.
How I can changes commit message of PR ?

Please add suggested changes, and also make sure that the formatting is as in the rest of the library - mainly by adding spaces after ( and before ).
Also, there are some major questions to answer, and two things a bit wrong:

The commit message should not exceed 72 characters in length;
The PR has no description (you used an unchanged template), and it's necessary for people that will look at this code later to understand why was it added and what's its purpose.

@AndrzejKurek , I added description to PR.
How I can changes commit message of PR ?

 For one of the previous ones, I think it is the best to use an interactive rebase git rebase -i and do reword on the commit with the message to be changed. In any case, you'll have to do a force push git push --force at the end. Here is a instruction:
https://docs.github.com/en/github/committing-changes-to-your-project/changing-a-commit-message


Front page: Don't show buttons that require login

I think the "Host a new market" section should be different on the frontpage depending on whether a user has logged in or not.
Right now new users can click "Opret nyt marked", without being logged in, being redirected to a login form. From there new users have to find the tiny "Opret en bruger" button in the bottom of the login form.
I think it would make more sense if there was an easily accessible "Opret en bruger" button already on the front page.
We could perhaps look at what other websites are doing design wise these days...

Let's make a drawing of the front page we want on the white board next Wednesday. Once we have agreed on layout and content, the implementation shouldn't be difficult.

Deal. One drawing for both logged in and not logged in.


get started button in top nav turns to background white, color white, so both button and text is white

overview
on hover over the get started button in the top nav it visually disappears
issue in chrome, and safari

pretty sure this is related to https://github.com/pulumi/pulumi-hugo/pull/603 as if the button is visible on hover if the top nav is not pinned and is visible if it gets a z-index


Scroll bars cannot slide!!!

When I execute the code on top of the two quickly
The scroll bar can't roll properly

This is because virtualScroll cannot easily monitor if the array has changed.
There's a new version on npm which does a slightly better job of monitoring these changes, please update to it.
Also, please add
this.virtualScroll.refresh();

before this.virtualScroll.scrollInto
or
setTimeout(() => { this.virtualScroll.scrollInto(item); }, 0);

Closing this for now. Please re-open if you continue to have issues.


PeerASN limited to at most 65534

On windows server 2019 the powershell module Add-BgpPeer does not allow to specify an PeerASN higher than 65534, as even though it is of type uint32, there is a validateRange(1, 65534) set, therefore 32-bit asn's or private asn's cannot be used.
The localASN parameter also has this bug, even though it is not listed within cdxml, it still fails with biger AS numbers.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f03f71fb-9804-6d6b-a0a4-32c6ac8922c1
Version Independent ID: ccafb83e-a48e-8563-73ac-fec02b4a19eb
Content: Add-BgpPeer (remoteaccess)
Content Source: docset/windows/remoteaccess/Add-BgpPeer.md
Product: w10
Technology: powershell-windows
GitHub Login: @andreabarr
Microsoft Alias: v-anbarr

@agowa338 . Number 65534KB is used for limitation  size for log events.
Mine is not an answer to your query

@agowa338 The article pertains to Windows versions 10 and Server 2016, and not to 2019.
That nuance will most likely be addressed with Server 2019 content when it comes out. Thank you.


Module augmentation doesn't apply to useSession().data

Environment

Operating System: Linux
Node Version:     v16.18.1
Nuxt Version:     3.0.0
Nitro Version:    1.0.0
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      css, build, modules, content, runtimeConfig, auth
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction

Define a next-auth.d.ts as explained in the doc to augment the next-auth module with custom session data:

import NextAuth, { DefaultSession } from "next-auth";

declare module "next-auth" {
  interface Session {
    user: {
      /** The user's postal address. */
      address: string
    } & DefaultSession["user"]
  }
}

In a component, call useSession() and see what TypeScript suggests in the data.value.user value:

const { data: session } = useSession();
session.value?.user.<cursor_position>

Describe the bug
Only the default user properties are proposed, suggesting that module augmentation is not taken into account by nuxt-auth's useSession() composable:

Additional context
Looking at<EMAIL_ADDRESS>the data property type is hardcoded to the default and not referring to SessionData.
declare const _default: () => {
    status: import("vue").ComputedRef<"authenticated" | "unauthenticated" | "loading">;
    data: Readonly<import("vue").Ref<{
        readonly user?: {
            readonly name?: string | null | undefined;
            readonly email?: string | null | undefined;
            readonly image?: string | null | undefined;
        } | undefined;
        readonly expires: string;
    } | null | undefined>>;
//...
};

Replacing this by the following fixed things for me:
declare const _default: () => {
    status: import("vue").ComputedRef<"authenticated" | "unauthenticated" | "loading">;
    data: Readonly<import("vue").Ref<SessionData>>;
//...
};

You can maybe trace things back to the src code, if you confirm this is a bug
Logs
No response

Hey @tmlmt 👋
Thanks for the issue + the thourough research you already did (:
This is actually an issue we fixed yesterday! See https://github.com/sidebase/nuxt-auth/issues/112 and PR: #115 by @JoaoPedroAS51 💯
I'm doing a release in a couple of minutes, would be great if you can do a clean install of that version then and check if the error persist.
I'll let you know here when the release is done + close the issue with the release. Would mean the world if you could then still get back to me here, on discord or via a new issue to let me know if the issue is fixed ❤

Closed by https://github.com/sidebase/nuxt-auth/releases/tag/0.3.1 🎊
To use: npm i -D<EMAIL_ADDRESS>

@BracketJohn, great ! I confirm it's working with v0.3.1 🎉
As a matter of fact, the other bug I encountered earlier today was actually the other one that was fixed in the release (redirect: false) and it's also working like a charm.
Thanks, both of two 👍

Yaaay, glad to hear and thank you so much for reporting this back (: Happy holidays!


Reproducing mBART results for Arabic->Engllish

❓ Questions and Help
I am trying to fine-tune the mBART model to reproduce the arabic -> english results reported in table 2 in the paper.  So far I am only getting a BLEU score of 28.8 while the paper reports 37.6.
In terms of the fine-tuning dataset, I used the TED parallel data that were available for training in IWSLT'17 combined with the available dev and test splits in IWSLT 2011-2015. The total number of training examples was 230k. I am not sure what data I am missing to get to the 250k used in the paper.
It would be really helpful if you could share the preprocessing and fine-tuning scripts you used for all language pairs or at least those used for arabic -> english.
I used the same hyper-parameter values as in the provided en->ro tutorial.
    SRC=ar
    TGT=en
    MODEL=${cc25_pretrain}/sentence.bpe.model
    ${SPM} --model=${MODEL} < ${DATA}/${TRAIN}.${SRC} > ${DATA}/${TRAIN}.spm.${SRC} &
    ${SPM} --model=${MODEL} < ${DATA}/${TRAIN}.${TGT} > ${DATA}/${TRAIN}.spm.${TGT} &
    ${SPM} --model=${MODEL} < ${DATA}/${VALID}.${SRC} > ${DATA}/${VALID}.spm.${SRC} &
    ${SPM} --model=${MODEL} < ${DATA}/${VALID}.${TGT} > ${DATA}/${VALID}.spm.${TGT} &
    ${SPM} --model=${MODEL} < ${DATA}/${TEST}.${SRC} > ${DATA}/${TEST}.spm.${SRC} &
    ${SPM} --model=${MODEL} < ${DATA}/${TEST}.${TGT} > ${DATA}/${TEST}.spm.${TGT} &

    DICT=${cc25_pretrain}/dict.txt
     python preprocess.py \
            --source-lang ${SRC} \
            --target-lang ${TGT} \
            --trainpref ${DATA}/${TRAIN}.spm \
            --validpref ${DATA}/${VALID}.spm \
            --testpref ${DATA}/${TEST}.spm  \
            --destdir ${DEST} \
            --thresholdtgt 0 \
            --thresholdsrc 0 \
            --srcdict ${DICT} \
            --tgtdict ${DICT} \
            --workers 70

PRETRAIN=${cc25_pretrain}/model.pt
langs=ar_AR,cs_CZ,de_DE,en_XX,es_XX,et_EE,fi_FI,fr_XX,gu_IN,hi_IN,it_IT,ja_XX,kk_KZ,ko_KR,lt_LT,lv_LV,my_MM,ne_NP,nl_XX,ro_RO,ru_RU,si_LK,tr_TR,vi_VN,zh_CN
python train.py $DEST  --encoder-normalize-before --decoder-normalize-before  --arch
 mbart_large --task translation_from_pretrained_bart  --source-lang ar --target-lang en --criterion
label_smoothed_cross_entropy --label-smoothing 0.2  --dataset-impl mmap --optimizer adam --
adam-eps 1e-06 --adam-betas '(0.9, 0.98)' --lr-scheduler polynomial_decay --lr 3e-05 --min-lr -1
--warmup-updates 2500 --total-num-update 200000 --dropout 0.3 --attention-dropout 0.1  --
weight-decay 0.0 --max-tokens 128 --update-freq 2 --save-interval 1 --save-interval-updates
5000 --keep-interval-updates 10 --no-epoch-checkpoints --seed 222 --log-format simple --log-
interval 2 --reset-optimizer --reset-meters --reset-dataloader --reset-lr-scheduler --restore-file
$PRETRAIN --langs $langs --layernorm-embedding  --ddp-backend no_c10d --save-dir
$MODEL_SAVE_DIR --memory-efficient-fp16 --distributed-world-size 1

The only changes I made are setting --max-tokens to 128 instead of 1024 and using --memory-efficient-fp16 to fit things in my GPU memory.
And here is my evaluation script
python generate.py $DEST  --path ${MODEL_SAVE_DIR}/${model}  --task
translation_from_pretrained_bart --gen-subset ${subset} -t en -s ar --bpe 'sentencepiece' --
sentencepiece-vocab ${cc25_pretrain}/sentence.bpe.model --sacrebleu  --remove-bpe
'sentencepiece' --max-sentences 32 --langs $langs --beam 5 > $PREDICTIONS_DIR/ar_en

grep ^H $PREDICTIONS_DIR/ar_en | cut -f3- > $PREDICTIONS_DIR/${subset}.hyp
grep ^T $PREDICTIONS_DIR/ar_en | cut -f2- > $PREDICTIONS_DIR/${subset}.ref

sacrebleu -tok 'none' -s 'none' $PREDICTIONS_DIR/${subset}.ref < $PREDICTIONS_DIR/${subset}.hyp

Thanks.

cc: @MultiPath

Hi @aagohary ,
I am trying to to fine-tune mBART on a language of dataset size 0.7 Million, I use the same command as you i.e., modified the existing to  --memory-efficient-fp16 --max-tokens 128, but still I am unable to train due to CUDA out of memory error.
Trained even on a single GPU.
Using 8 Geforce RTX 2080ti (11 GB RAM).
Can you please confirm the above RAM would be sufficient to fine-tune it, other than the training data size I do not see any diff across the two.
Even if your GPU has above 11 GB can you inform the max memory it occupies while training.
Thanks.

I am using a single GeForce GTX 1080 Ti GPU which also has 11GB of memory.

Hi, Does your GPU support fp16 training, can you provide the output of this
torch.cuda.get_device_capability(0)[0]
Also in the train command does target-lang need to be en or en_XX as in the langs variable, in order to properly finetune since it is pretrained using particular lang-id?

Hi, Does your GPU support fp16 training, can you provide the output of this
torch.cuda.get_device_capability(0)[0]
Also in the train command does target-lang need to be en or en_XX as in the langs variable, in order to properly finetune since it is pretrained using particular lang-id?

Hi @aagohary ,
I am trying to to fine-tune mBART on a language of dataset size 0.7 Million, I use the same command as you i.e., modified the existing to  --memory-efficient-fp16 --max-tokens 128, but still I am unable to train due to CUDA out of memory error.
Trained even on a single GPU.
Using 8 Geforce RTX 2080ti (11 GB RAM).
Can you please confirm the above RAM would be sufficient to fine-tune it, other than the training data size I do not see any diff across the two.
Even if your GPU has above 11 GB can you inform the max memory it occupies while training.
Thanks.

Hey,gvskalyan. Sorry to be a  bother. I met the same error that  CUDA out of memory when I  fine-tune mBART on wmt16 en-ro dataset. I fune-tune  on a single GPU RTX2080TI (11 GB RAM).
Have you solved the error so far? Thanks.

Hi @hischen , I have not solved this .
But there are few things left to try,

As per this maybe even mBART memory would have been reduced which makes it easier to load and fine-tune. Transformers library has mBART en-ro pre-trained from fairseq.

try gradient checkpointing as mentioned in issue no 1936

Does anyone know whether anything in particular needs to be done to account for Arabic being written right-to-left, while most of the other languages in the mBART corpus are written left-to-right?  Does the sentencepiece tokenization need to be flipped?  Do the self-attention masks need to be flipped?
Thanks!


Getting Error , Fix please

ERROR    | 199 - Error while getting user data. Response 401. Try again after 30s

Traceback (most recent call last):
File "/data/data/com.termux/files/home/Cexio-Tap-bot/bot/core/tapper.py", line 644, in run

me too

2024-10-17 22:51:36 | ERROR    | 720 - xx | Unknown error: 'NoneType' object is not iterable
2024-10-17 22:51:36 | ERROR    | 424 - xx| Error code 401 While trying to get data
Traceback (most recent call last):
File "D:\TGbot\Cexio-Tap-bot\bot\core\tapper.py", line 664, in run
await self.find_potential()
File "D:\TGbot\Cexio-Tap-bot\bot\core\tapper.py", line 515, in find_potential
for category in self.card:
TypeError: 'NoneType' object is not iterable

Update new version and wait