portproxy not systematically correctly configured for localhost

cmd.exe /c ver

Microsoft Windows [Version 10.0.19043.1826]

wsl.exe --status

Default Distribution: Ubuntu
Default Version: 2
Windows Subsystem for Linux was last updated on 5/11/2022
The Windows Subsystem for Linux kernel can be manually updated with 'wsl --update', but automatic updates cannot occur due to your system settings.
To receive automatic kernel updates, please enable the Windows Update setting: 'Receive updates for other Microsoft products when you update Windows'.
For more information please visit https://aka.ms/wsl2kernel.

lsb_release -r

20.04

I would like to mention the last comment from a closed issue although there is as of August 2022 still an issue with this:
See post by @rehantoday in https://github.com/microsoft/WSL/issues/4636#issuecomment-1166408493_
The solution he or she quotes does work. We then need to manually add the proxy, e.g. doing netsh interface portproxy set v4tov4 8080 <IP_ADDRESS> 8080 <IP_ADDRESS>
localhost forwarding should be automatic.
Last week, there was no such issues. It appeared randomly as mentioned in above closed issue by several people within this year 2022.

same issue

netsh interface portproxy add v4tov4 listenport=7860 listenaddress=<IP_ADDRESS> connectport=7860 connectaddress=$(wsl hostname -I)
But it doesnt always work...


RouteResult in Router

Why is the RouteResult not saved in the Router for later usage to check the route name  used etc ?

Have a look at #187. Is this, what you are looking for?

@zf2timo thank you. That indeed will work.

oh and probably it could be saved in Router itself. So I will open this to hear from @weierophinney .

I can send a PR with getRouteResult https://github.com/zendframework/zend-expressive/blob/master/src/Router/RouterInterface.php#L43 once a route is matched. What do you think about adding this method in the interface ?

It's not as easy as just adding a method to the interface, you would need to implement it in all router packages as well.
Zend\Expressive\Router\RouteResult is independent of the router packages. Besides that, I think it's easier to have it in the request object since that should be available in all middleware: No need to inject a router to get the route result.

you would need to implement it in all router packages as well
yes.

Zend\Expressive\Router\RouteResult is independent of the router packages

not sure what you were getting at. For this is independent of package.
Normally the Router is available as a view helper and the route result is getting based on the match method. So it seems to me,the RouteResult is good at Router level.
Thank you.

Related, I was trying to get the route result in view helper. In the post_routing middleware
                'post_routing' => [
			[
			    'middleware' => 'App\Middleware\RouteMatched',
			],
		],

I registered the middleware, but it seems not getting called. If I move the class to pre_routing it works. The problem is only after routing the request will contain the result. I cannot find a way to inject the request nor it have no use for it will be entirely different.
<?php

namespace App\Middleware;

use App\View\Helper\CurrentRoute;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Zend\View\HelperPluginManager;
use Zend\Expressive\Router\RouteResult;

class RouteMatched
{
	protected $manager;

	public function __construct(HelperPluginManager $manager)
	{
		$this->manager = $manager;
	}

	public function __invoke(ServerRequestInterface $request,
		ResponseInterface $response, callable $next = null)
	{
		$result = $request->getAttribute(RouteResult::class);
		$this->manager->setFactory('currentRoute', function () use ($result) {
			return new CurrentRoute($result);
		});
		return $next($request, $response);
	}
}

This is why I prefer the result in router for you can inject the router and not the request.

@harikt

Why is the RouteResult not saved in the Router for later usage to check the route name used etc ?

That would make the router stateful and impossible to use Zend\Expressive for multiple dispatch cycles.

This is why I prefer the result in router for you can inject the router and not the request.

I think this is the real problem here. I'm not sure why you think you cannot inject the request. If it is because your post_routing is not being run (thus, the request you want cannot be injected) then I think the problem you should be focusing on is why is your post_routing middleware not being run? If you can fix that problem it sounds like the request has what you need and your middleware will do what you want... the real problem is that your middleware doesn't seem to being run.
Am I mistaken?

post_routing won't help here because it runs after your "Action" middleware:
pre_routing -> route matching -> "action" middleware -> post_routing.
If post_routing is not running, thats probably because your action middleware is not calling $next().
Unfortunately it is currently impossible to pipe a middleware that runs between route matching and the call of action middleware, because the routing middleware itself calls the matched action middleware. That would be possible after https://github.com/zendframework/zend-expressive/pull/192 gets merged, tough it would work only for specific routes, not globally.

Also, @harikt I think you can take advantage of TemplateRendererInterface::addDefaultParam() instead of configuring a view helper.

@simensen

I'm not sure why you think you cannot inject the request.

What I was trying to say is $di->set('request', $psr7request) for the request is immutable. And it will change with*() method called. So you can't do the above in psr7 based frameworks.

If it is because your post_routing is not being run (thus, the request you want cannot be injected) then I think the problem you should be focusing on is why is your post_routing middleware not being run? If you can fix that problem it sounds like the request has what you need and your middleware will do what you want... the real problem is that your middleware doesn't seem to being run.

post_routing is not run, and I figured it with the help of @danizord that if in your action if $next($request, $response) is not called the post_routing will never get called :-/ .

@danizord not sure how I can make use of TemplateRendererInterface::addDefaultParam() . Do you have any example for it?

@harikt

I'm not sure why you think you cannot inject the request.

What I was trying to say is $di->set('request', $psr7request) for the request is immutable. And it will change with*() method called. So you can't do the above in psr7 based frameworks.

You can totally do that in a PSR-7 framework. You just need to make sure it is injected after all of the other middleware have been run that might modify the request. I think the problem you are having is that you have no place to do this injection after the route but before your action is called. But it is still possible I'm not understanding the problem.
FWIW, this is similar to other problems I've been having with other systems that need to be stateless.

@simensen What I need is RouteResult from the request attribute. Two ways you can do are
1 ) Get the RouteResult from the request in every action ( it is tedious ) and pass the value to render() .
2 ) Use a view helper, inject somehow the RouteResult getting from the request attribute.
In an earlier way we could have injected the Request as below with the help of a di container, but now your request is immutable and it changes, and you should pass it to __invoke and you can't do the same via injection by a di container.
<?php
class ViewHelper
{
    public function __construct(Request $request)
    {
        $this->request = $request;
    }
}

so the above code can be changed to
<?php
class ViewHelper
{
    public function __invoke(Request $request)
    {
        return $request->getAttribute(RouteResult:class);
    }
}

So we need to inject the request to view data and call as $this->currentRoute($request) . See the hacks than the old ones :-/ .
It may be personal likes / dislikes of usage.

@harikt
class InjectRouteResultMiddleware
{
	private $templateRenderer;

	public function __construct(TemplateRendererInterface $templateRenderer)
	{
		$this->templateRenderer = $templateRenderer;
	}

	public function __invoke($req, $res, $next)
	{
		$routeResult = $req->getAttribute(RouteResult::class);

		$this->templateRenderer->addDefaultParam('routeResult', $routeResult);

		$next($req, $res);
	}
}

class SomeActionMiddleware
{
	private $templateRenderer;

	public function __construct(TemplateRendererInterface $templateRenderer)
	{
		$this->templateRenderer = $templateRenderer;
	}

	public function __invoke($req, $res, $next)
	{
		return new HtmlResponse($this->templateRenderer->render('some-template'));
	}
}

This way you can access routeResult variable in all your templates.

@danizord Thank you.
One question : isn't I can register middleware in pre_routing or post_routing only ? I am looking at middleware-pipe.global.php . If it is pre, then you will not get the route result . I think there was something I noticed earlier. Some sort of way to call the match on router before execution. But don't remember what it was.

@harikt as I said in  https://github.com/zendframework/zend-expressive/issues/198#issuecomment-159313968, I'm not sure if this is possible in a clear way before #192 gets merged. But yeah you can hack this by returning a MiddlewarePipe with piped InjectRouteResultMiddleware in your action middleware factory. @michaelmoussa explains that approach in  https://github.com/zendframework/zend-expressive/issues/190

@harikt —
pre-routing middleware is middleware to execute every request and/or for subpaths (e.g., registering a separate middleware pipeline for URIs starting with /api). post-routing middleware should typically only be used for error middleware, as most routed middleware will return a response directly.
#192 is adding support for you to provide a list/queue of middleware to execute for a route match. This will allow you to do something like:
'middleware' => [
    'InjectRouteResultMiddleware',
    'SomeActionMiddleware',
]

when defining your route, and they will be done in a chain. What I'm trying to determine is if we can also provide a way to automate this somehow, so that you don't have to do the above every time you want to do templated middleware. One idea I have is setting up a subject/observer triggered by the routing middleware with the route result, which would simplify this tremendously.
Now:

What I was trying to say is $di->set('request', $psr7request) for the request is immutable. And it will change with*() method called. So you can't do the above in psr7 based frameworks.

The request is not a service. It's a message, representing the state when the application is executed. It should not be registered as a service; it should be passed to objects that need to know about it.
Similarly, the RouteResult is a product of calculation; it's the result of analyzing the request against a set of rules. As such, it, too, should be passed to objects interested in those results. We do that by pushing the matched parameters into a new request, as well as the RouteResult itself, so that lower layers in the system can retrieve them.
For middleware, then, getting access to this information is relatively easy. The hard part is templates, which may want access to the current matches in order to simplify URI generation. That's the part we need to solve. As noted above, #192 is one way to solve it; I'll likely also be submitting a patch with the subject/observer idea shortly, which may better answer this specific use case.


Fix size column for archive files

Resolved / Related Issues
The statusbar always displays the cumulative size counting 0 for files whose size is not known. This impacts zip folders.
Details of Changes
The cumulative size is no longer displayed if one of the elements does not have a known size.
Validation
How did you test these changes?

[ ] Built and ran the app
[ ] Tested the changes for accessibility

@cinqmilleans thank you!


Conolutional Neural Network: float() argument must be a string or a number?

I want to train my data with a conventional neural network (CNN),I start with reshaping my data than creating my model:
model = Sequential()
input_traces = Input(shape=(3253,))

model.add(Convolution1D(nb_filter=32, filter_length=3, border_mode='same',
activation='relu',input_dim=input_traces))
model.add(MaxPooling1D(pool_length=2))
model.add(Flatten())
model.add(Dense(250, activation='relu'))
model.add(Dense(1, activation='sigmoid'))
model.compile(loss='binary_crossentropy', optimizer='adam', metrics=
['accuracy'])
print(model.summary())
model.fit(x_train, y_train, batch_size=15, nb_epoch=30, show_accuracy=True,
validation_data=(x_test, y_test))

But this code gives me this error:
CNN_Based_Attack.py:139: UserWarning: Update your `Conv1D` call to the Keras 2 API: `Conv1D(activation="relu", input_shape=(None, /in..., padding="same", filters=32, kernel_size=3)`
  model.add(Convolution1D(nb_filter=32, filter_length=3, border_mode='same', activation='relu',input_dim=input_traces))
Traceback (most recent call last):
  File "CNN_Based_Attack.py", line 139, in <module>
    model.add(Convolution1D(nb_filter=32, filter_length=3, border_mode='same', activation='relu',input_dim=input_traces))
  File "/home/.local/lib/python2.7/site-packages/keras/models.py", line 430, in add
    layer(x)
  File "/home/.local/lib/python2.7/site-packages/keras/engine/topology.py", line 557, in __call__
    self.build(input_shapes[0])
  File "/home/.local/lib/python2.7/site-packages/keras/layers/convolutional.py", line 134, in build
    constraint=self.kernel_constraint)
  File "/home/.local/lib/python2.7/site-packages/keras/legacy/interfaces.py", line 88, in wrapper
    return func(*args, **kwargs)
  File "/home/.local/lib/python2.7/site-packages/keras/engine/topology.py", line 390, in add_weight
    weight = K.variable(initializer(shape), dtype=dtype, name=name)
  File "/home/.local/lib/python2.7/site-packages/keras/initializers.py", line 200, in __call__
    scale /= max(1., float(fan_in + fan_out) / 2)
TypeError: float() argument must be a string or a number.

I really don't understand this error. Could you please help me.

You're trying to mix the Functional API and the Sequential API.
If you want to use the Sequential API, do not use an Input layer. Please see the documentation
https://keras.io/getting-started/sequential-model-guide/

Hello,
I am facing same issue, though I AM not mixing APIs, I am using functional API. Please help!

Hello
I also have the same problem.
And, I also use functional API only.
Traceback (most recent call last):   File "/Volumes/disk2s1/experiment/Script/Python/Behavior_analysis/DNN.py", line 158, in <module>     main()   File "/Volumes/disk2s1/experiment/Script/Python/Behavior_analysis/DNN.py", line 155, in main     eval.calculate_DNN()   File "/Volumes/disk2s1/experiment/Script/Python/Behavior_analysis/DNN.py", line 149, in calculate_DNN     self.CNN_with_Keras(mel,chr)   File "/Volumes/disk2s1/experiment/Script/Python/Behavior_analysis/DNN.py", line 117, in CNN_with_Keras     x = GRU(200, return_sequences=True, dropout=0.5)(x)   File "/Users/masaru/.pyenv/versions/3.7.2/lib/python3.7/site-packages/keras/layers/recurrent.py", line 532, in __call__     return super(RNN, self).__call__(inputs, **kwargs)   File "/Users/masaru/.pyenv/versions/3.7.2/lib/python3.7/site-packages/keras/engine/base_layer.py", line 431, in __call__     self.build(unpack_singleton(input_shapes))   File "/Users/masaru/.pyenv/versions/3.7.2/lib/python3.7/site-packages/keras/layers/recurrent.py", line 493, in build     self.cell.build(step_input_shape)   File "/Users/masaru/.pyenv/versions/3.7.2/lib/python3.7/site-packages/keras/layers/recurrent.py", line 1273, in build     constraint=self.kernel_constraint)   File "/Users/masaru/.pyenv/versions/3.7.2/lib/python3.7/site-packages/keras/legacy/interfaces.py", line 91, in wrapper     return func(*args, **kwargs)   File "/Users/masaru/.pyenv/versions/3.7.2/lib/python3.7/site-packages/keras/engine/base_layer.py", line 249, in add_weight     weight = K.variable(initializer(shape),   File "/Users/masaru/.pyenv/versions/3.7.2/lib/python3.7/site-packages/keras/initializers.py", line 209, in __call__     scale /= max(1., float(fan_in + fan_out) / 2) TypeError: float() argument must be a string or a number, not 'Dimension'

Hello
I also have the same problem.
And, I also use functional API only.
Traceback (most recent call last): File "/Volumes/disk2s1/experiment/Script/Python/Behavior_analysis/DNN.py", line 158, in <module> main() File "/Volumes/disk2s1/experiment/Script/Python/Behavior_analysis/DNN.py", line 155, in main eval.calculate_DNN() File "/Volumes/disk2s1/experiment/Script/Python/Behavior_analysis/DNN.py", line 149, in calculate_DNN self.CNN_with_Keras(mel,chr) File "/Volumes/disk2s1/experiment/Script/Python/Behavior_analysis/DNN.py", line 117, in CNN_with_Keras x = GRU(200, return_sequences=True, dropout=0.5)(x) File "/Users/masaru/.pyenv/versions/3.7.2/lib/python3.7/site-packages/keras/layers/recurrent.py", line 532, in __call__ return super(RNN, self).__call__(inputs, **kwargs) File "/Users/masaru/.pyenv/versions/3.7.2/lib/python3.7/site-packages/keras/engine/base_layer.py", line 431, in __call__ self.build(unpack_singleton(input_shapes)) File "/Users/masaru/.pyenv/versions/3.7.2/lib/python3.7/site-packages/keras/layers/recurrent.py", line 493, in build self.cell.build(step_input_shape) File "/Users/masaru/.pyenv/versions/3.7.2/lib/python3.7/site-packages/keras/layers/recurrent.py", line 1273, in build constraint=self.kernel_constraint) File "/Users/masaru/.pyenv/versions/3.7.2/lib/python3.7/site-packages/keras/legacy/interfaces.py", line 91, in wrapper return func(*args, **kwargs) File "/Users/masaru/.pyenv/versions/3.7.2/lib/python3.7/site-packages/keras/engine/base_layer.py", line 249, in add_weight weight = K.variable(initializer(shape), File "/Users/masaru/.pyenv/versions/3.7.2/lib/python3.7/site-packages/keras/initializers.py", line 209, in __call__ scale /= max(1., float(fan_in + fan_out) / 2) TypeError: float() argument must be a string or a number, not 'Dimension'

Have you solved?

I am having the same problem.
self.encoded2 = Dense(nodes, activation=act)(self.encoded2)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/keras/engine/base_layer.py", line 431, in call
self.build(unpack_singleton(input_shapes))
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/keras/layers/core.py", line 866, in build
constraint=self.kernel_constraint)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/keras/legacy/interfaces.py", line 91, in wrapper
return func(*args, **kwargs)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/keras/engine/base_layer.py", line 249, in add_weight
weight = K.variable(initializer(shape),
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/keras/initializers.py", line 209, in call
scale /= max(1., float(fan_in + fan_out) / 2)
TypeError: float() argument must be a string or a number, not 'Dimension'
Any advice?

I encountered this issue while building GRU layer in a functional API fashion and solved the problem by making a minor change to the Keras source code.
The problem of this issue is that the type of a tensor shape isn't properly cast to int type recognized by float function.
In my case, I add a line of code, which transform Dimension type of a shape to int type, below the build function of recurrent.py at line 440. The code is as follow, and my Keras version is 2.1.5.
def build(self, input_shape):
        # Note input_shape will be list of shapes of initial states and
        # constants if these are passed in __call__.
	input_shape = tuple([i if (isinstance(i, int) or i is None else i.value for i in input_shape)]) # casting "Dimension" type of input_shape's elements to "int" type

	if self._num_constants is not None:
            constants_shape = input_shape[-self._num_constants:]
        else:
            constants_shape = None

        if isinstance(input_shape, list):
            input_shape = input_shape[0]

If you encountered the issue when building another layer, you may find the build function in related file and modify the code like above.

I encountered this issue while stacking GRU layer in a functional API fashion and solved the problem by making a minor change to the Keras source code.
The problem of this issue is that the type of a tensor shape isn't properly cast to int type recognized by float function.
In my case, I add a line of code, which transform Dimension type of a shape to int type, below the build function of recurrent.py at line 440. The code is as follow, and my Keras version is 2.1.5.
def build(self, input_shape):
        # Note input_shape will be list of shapes of initial states and
        # constants if these are passed in __call__.
	input_shape = tuple([i if (isinstance(i, int) or i is None else i.value for i in input_shape)]) # casting "Dimension" type of input_shape's elements to "int" type

	if self._num_constants is not None:
            constants_shape = input_shape[-self._num_constants:]
        else:
            constants_shape = None

        if isinstance(input_shape, list):
            input_shape = input_shape[0]

If you encountered the issue when building another layer, you may find the build function in related file and modify the code like above.

Or if you use Reshape layer with tensor shape as argument, like tensor.shape[1], you can just change tensor.shape[1] to tensor.shape[1].value that is int instead of 'tensorflow.python.framework.tensor_shape.Dimension'

.value

Thanks. this works for me. Cheers !!

I encountered this issue while stacking GRU layer in a functional API fashion and solved the problem by making a minor change to the Keras source code.
The problem of this issue is that the type of a tensor shape isn't properly cast to int type recognized by float function.
In my case, I add a line of code, which transform Dimension type of a shape to int type, below the build function of recurrent.py at line 440. The code is as follow, and my Keras version is 2.1.5.
def build(self, input_shape):
        # Note input_shape will be list of shapes of initial states and
        # constants if these are passed in __call__.
	input_shape = tuple([i if (isinstance(i, int) or i is None else i.value for i in input_shape)]) # casting "Dimension" type of input_shape's elements to "int" type

	if self._num_constants is not None:
            constants_shape = input_shape[-self._num_constants:]
        else:
            constants_shape = None

        if isinstance(input_shape, list):
            input_shape = input_shape[0]

If you encountered the issue when building another layer, you may find the build function in related file and modify the code like above.

Or if you use Reshape layer with tensor shape as argument, like tensor.shape[1], you can just change tensor.shape[1] to tensor.shape[1].value that is int instead of 'tensorflow.python.framework.tensor_shape.Dimension'

Thanks, change tensor.shape[1] to tensor.shape[1].value work for me, thanks !!!


Updated to cds-services 3.4.0 and bumped other dependencies

Run npm upgradge in app, srv and mtx/sidecar also.

Run npm upgradge in app, srv and mtx/sidecar also.

@vmikhailenko done


UI related icons not showing up after loading a CSV file

Hello,
I am using this distribution - spark-notebook-master-scala-2.11.8-spark-2.3.0-hadoop-2.7.3-with-hive
Here's what I have done ...
val tmr = sparkSession.sqlContext.read.format("csv")
.option("header", "true")
.option("inferSchema", "true")
.load("hdfs://<IP_ADDRESS>:9000/snb/tmr1.csv")

This works fine ...
tmr.show

But I don't see any UI related icons/linked to be able to view the table.
Per docs, whenever a list/matrix is returned, then the UI icons/links should show up automatically.
Thanks
Naga Vijayapuram

Sorry, not an issue, as the UI icons render fine after .collect on the dataframe.

However, it will be a nice feature enhancement to render the UI icons when cell returns DF, even if a sampling from the DF is shown in the UI.

cell:
val tmr = sparkSession.sqlContext.read.format("csv")
.option("header", "true")
.option("inferSchema", "true")
.load("hdfs://<IP_ADDRESS>:9000/snb/tmr1.csv")

do not return anything, it just creates a value/variable tmr
to return you need a return statement at the end of the cell, like this:
val tmr = sparkSession.sqlContext.read.format("csv")
  ...
tmr


Sema: Avoid application extension platforms in if #available fix-its

When the type checker noticed that a declaration with application extension availability markup was used somewhere that it would be potentially unavailable at runtime, the fix-it emitted by the compiler would check for the application extension platform's availability:
if #available(macOSApplicationExtension 12, *) {
  // Use potentially unavailable declarations
}

This runtime check won't work. The fix-it should just suggest checking the availability of the base, non-extension platform instead.
Resolves rdar://125860317.

@swift-ci please smoke test


feat: xlsx-to-oscal-profile

create common xlsx module
create xlsx-to-oscal-profile task
artifacts for 100% code coverage

Types of changes

[ ] Hot fix (emergency fix and release)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Documentation (change which affects the documentation site)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Release (develop -> main)

Quality assurance (all should be covered).

[x] My code follows the code style of this project.
[x] Documentation for my change is up to date?
[x] My PR meets testing requirements.
[x] All new and existing tests passed.
[x] All commits are signed-off.

Summary
New task xlsx-to-oscal-profile with refactoring of common spread sheet code from task xlsx-to-component-definition.
Key links:

Sonar coverage

Before you merge

Ensure it is a 'squash commit' if not a release.
Ensure CI is currently passing
Check sonar. If you are working for a fork a maintainer will reach out, if required.

@degenaro Can we add a brief documentation for the existing tasks as part of this PR? I believe the documentation should at least include the available tasks names ie 'xlsx-to-oscal-cd' and new 'xlsx-to-oscal-profile' and explain what config is available for them

@degenaro as we are moving close to the 1.0 release, can we add a brief documentation for the existing tasks as part of this PR? I believe the documentation should at least include the available tasks names ie xlsx-to-oscal-cd and new xlsx-to-oscal-profile and explain what config is available for them

Actually, there already is cli.md doc for the comp-def transformer. But is it wrong due to the new name, so I will fix. I'll also add doc for the profile transformer...


fix: LEAP-665: Fix runtime crash by downgrading react

We introduced a runtime error by upgrading React 17 -> 18. This PR fixes it by rolling back to React 17
PR fulfills these requirements

[X] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[ ] Tests for the changes have been added/updated (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[X] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[X] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[ ] Product design
[ ] Backend (Database)
[ ] Backend (API)
[X] Frontend

Describe the reason for change
Some pages became unusable due to a runtime error.
What is the new behavior?
No more runtime error
What is the current behavior?
Runtime error occurs when accessing certain pages
Does this PR introduce a breaking change?
(check only one)

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[X] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?
(check all that apply)

[ ] e2e
[ ] integration
[ ] unit

Which logical domain(s) does this change affect?
Whole LSO

/docker build


About time to bump Rhai version?

Right, I'll check tomorrow.

Rhai 1.4.1 is published on https://rhai.rs/playground/dev/. If nothing special needs attention then we can run the workflow to copy it over to stable.

I think the dev version is stable, so it can be moved to stable!

Done.

About time to bump... now at 1.7.0...

Ah sorry, I updated the unstable build to 1.7.0 a few days ago but then forgot about it. I just deployed it to stable too.


Twitter Rate Limiting

It looks like twitter is throwing up 429 (too many requests) after the first 900 or so hits. According to their API documentation they limit to around 900 hits per 15 minutes. Although we are not using the API, it seems they are putting similar limiting in place per IP.
I've begun working on a branch that lets users plug in a list of proxies the script will rotate through to avoid 429. This does make the tool less approachable but at this point it's not working on large groups of tweets. Will keep everyone updated

Working draft is up in the feature-proxy branch


UnexpectedResponse("watch html did not contain a PlayabilityStatus")

Summary
No response
Video IDs

OxqNH2s74ZA
ZveUN5KRhuo
and well.. any video :(

Version
0.6.0

Log output or error

log
  path/to/project>cargo run -- ytd OxqNH2s74ZA
  Finished dev [unoptimized + debuginfo] target(s) in 0.31s
   Running `target\debug\sle.exe ytd OxqNH2s74ZA`
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: UnexpectedResponse("watch html did not contain a PlayabilityStatus")', src\you_tube.rs:4:85
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: process didn't exit successfully: `target\debug\sle.exe ytd OxqNH2s74ZA` (exit code: 101)

Additional notes or ideas
No response

I have the same problem

I switched over to rusty_ytdl

Any progress on this?


Update how-to-configure-tracking-for-a-pipeline.md

To be consistent with the other tracking articles I add it "Track Events - *" and "Track Message Bodies - *"

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

biztalk/core/how-to-configure-tracking-for-a-pipeline.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

biztalk/core/how-to-configure-tracking-for-a-pipeline.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add module to capture when attaching to telemetry

Telemetry emits the info when attaching without the module:

[info] Function passed as a handler with ID {TelemetryMetricsTelegraf, [:vm, :memory], #PID<0.877.0>} is local function.
This mean that it is either anonymous function or capture of function without module specified. That may cause performance penalty when calling such handler. For more details see note in telemetry:attach/4 documentation.
https://hexdocs.pm/telemetry/telemetry.html#attach-4

Thanks!


{"success":false,"error":"failed to process request before timeout","duration":0}

Describe the bug
The request's failing for some reason.
Log entries
{"success":false,"error":"failed to process request before timeout","duration":0}
Installation details

OS: Ubuntu
Docker setup Portainer

Additional context
Using deep stack version: https://hub.docker.com/layers/deepquestai/deepstack/gpu/images/sha256-1a02e4e784c90eb109dd1aaa8cdf340dfb334875dfc140974a7dece68741326a?context=explore

I'm not familiar with Portainer so I'm not going to be able to help much with this. Common things to look at are whether the networking setup in Portainer allows communication between this project and Deepstack. If the two Docker containers can't talk to each other you might get that error.

This issue seems to be an issue with Deepstack latest version.

Does it work if you roll back to an older Deepstack Docker image?

Does it work if you roll back to an older Deepstack Docker image?

Haven't tried yes will try it out. Here is the issue: https://forum.deepstack.cc/t/gpu-2022-01-1-no-objects-detected/1343

Well... that looks like a Deepstack bug then so there's not much I can do about it. Try rolling back to the previous image.

@neilenns Did Deepstack anything? Current version in GPU docker brach and NVDIA 510 drivers. I am getting no detection:

2022-01-23T10:07:55-05:00 [Trigger Garage] /MotionEye/Garage/images/Garage-2022-01-23-10-07-48.jpg: Analyzing
2022-01-23T10:07:55-05:00 [Trigger Garage] /MotionEye/Garage/images/Garage-2022-01-23-10-07-48.jpg: No objects detected. (171 ms)
Not sure if something needs to up be updated in deepstack-trigger.

I don't follow their development work, I suggest either:

Rolling back to an older version of their GPU image
Trying a non-GPU image


What's the actual state of the project ?

Hi! I'm creating a small framework on top of apollo, express, mongodb, and react/redux and I wanted to know how difficult it would be, considering the actual stage of the project, to achieve mechanisms such as

providers auth
token expiration and refresh
password update
providers linking

Hey @Aetherall!
Thank you for the interest in this project!
You can go over to #107 for current stages of our next big release that will feature:

Typescript all around
Modular authorization strategies including oauth providers (auth and linking)

For the current stage of the project, it already has a solution for local strategy (password based) and it currently handles password update and including forgot password emails, enrollement email ("Set your password") and email verification.
We also have JWT based token system in place which will be scoped as "session management" after our change is complete.
Hopes this helped explain the current stage we are at.
If you'd like to help advance us further, please go through the open PRs liseted under #107 and try those out on your own. We need feedback, and also if you would like to contribute, I've just pushed the current work of refactoring into a new WIP PR #112.

I'll try those on the next week !


Investigate and support Next.js instrumentation

Next.js 15 introduced a loadInstrumentationModule methods that appears in our bundled worker which caused our workers to fail at runtime.
We're solved such issue by replacing the content of the loadInstrumentationModule methods with a no-op implementation (see: https://github.com/opennextjs/opennextjs-cloudflare/pull/169), this was the simplest and quickest way to work around the issue and unblock Next.js 15 for us, it is however most likely not the correct solution and almost certainly breaks Next.js' instrumentation.
So this issue is for investigating and understanding if and how we support instrumentation, and if we don't support it (which most likely we don't) find a way to do so.

As I understand, this adapter does support Next.js 15.1 now?

Yes it does 🙂
Although we don't support all Next.js 15 features (like instrumentation), I don't even think we have investigated all features and understood the extent of our support
@vicb might be able to shed some light here 🙂

Yes it does 🙂
Although we don't support all Next.js 15 features (like instrumentation), I don't even think we have investigated all features and understood the extent of our support
@vicb might be able to shed some light here 🙂

Great. Appreciate your work being done on this adapter for the serverless infrastructure.


Leader election

We should probably only let one Metacontroller instance be active at a time for now. In the PoC, a single instance hosts Lambda Controllers for the whole cluster.

@enisoc - I'll take a look at this

As an alternative, while we still only support one instance at a time, we can use a StatefulSet of size 1. This just means when the Pod goes away for any reason (drained, or being upgraded), we probably have to wait a bit longer before the new one is ready. That should be fine though, at least for alpha.

/assign
As synced by person, this issue can be resolved by changing Deployment to StatefulSet with 1 pod. To support high availability, however, we need to think through how leader election should be performed.

FYI there is an alpha API in client-go for leader election:
https://godoc.org/k8s.io/client-go/tools/leaderelection
We could consider using this if/when it makes sense to support HA.

As a Metacontroller instance handles multiple composite or decorator controllers, HA support is vital.
We can also let the users choose whether they want to enable HA support or not when they create multiple Metacontroller instances (although I don't find any reason for them not to do so).
As this issue has low priority, we can wait till the leader election API becomes beta before working on the HA feature. I am interested to work on it!


Ru

Ru
Originally posted by @price111 in https://github.com/Uniswap/token-lists/pull/152#discussion_r1036664182

There's no meaningful title, nor description. I'm closing this.


⚠ ClamAV has degraded performance

In ecf1633, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 448 ms

Resolved: ClamAV performance has improved in c711e0e.


Issues shutting down my nodejs application when using this library

Hello,
I'm playing around with this library.
I want to implement a small application which needs a "proper" shutdown. Unfortunately I don't get it working.
I feel it has something to do with this library...
This is the code:
const ExclusiveKeyboard = require('exclusive-keyboard');

var keyboard = new ExclusiveKeyboard("event6", false);
keyboard.on('error', keyboardError);
keyboard.on('keypress', keydown);
keyboard.on('close', keyboardClose);

function keyboardError(error) {
  console.error("Got keyboard error %s", error)
}

function keyboardClose() {
  console.log("Keyboard closed");
}

function keydown(keyboardEvent) {
  var keyId = keyboardEvent.keyId
  console.log(keyId)
}

function handleExit(signal) {
  console.log(`Received ${signal}. Close my server properly.`)
  keyboard.close();
  keyboard = undefined;
  setTimeout(function () {
    console.log("Will stop now");
    process.exit(0);
  }, 1000);
}

process.on('SIGINT', handleExit);
process.on('SIGQUIT', handleExit);
process.on('SIGTERM', handleExit);

When you now run the app and hit <ctl+c> it prints:
^CReceived SIGINT. Close my server properly.
Keyboard closed
Will stop now

But it never really stops.
Any idea what could be the issue here?

found a workaround similar to https://github.com/song940/input-event/issues/21#issuecomment-570073906


add new exercises

Hi. Are the codes under review?

??????

Sorry for the delay, we were all on holidays. I'll have a look.

Before I review, could you look at fixing the CI issues: https://github.com/exercism/func/actions/runs/7286216384/job/20085703711?pr=4?


Updated version of mymindstorm/setup-emsdk workflow action

Mildly annoying version deprecation warning fixed :-)

Wow, that's a few versions in a bump!
Thank you.

Yeah, I was a bit surprised - but I suppose actions pretty much get left alone while they still work!


NuGet Pack - path to csproj files returns no files with minimatch pattern

If I enter the following in the 'path to csproj or nuspec file(s) to pack' field, it will find all csProj files - including the test project:
***.csproj
However, if I use the pattern from the example (which is shown below), it returns zero files.  This is the same pattern that shows up in the example when hovering over the "i" button
*.csproj;-:*.Tests.csproj

For the option of Path to csproj or nuspec file(s) to pack, the negative pattern can’t work.
Such as the pattern **\*.csproj can works fine, but these patterns can’t work: **\*.csproj;-:**\ConsoleApplication1.csproj and  ;-:**\ConsoleApplication1.csproj.

I'm sorry, but this is a frustrating answer.  Are you saying that it doesn't work now or that it will not be supported at all?
I have issues with this because previously, I used the Nuget Packager step.  This step now shows that it is deprecated now.  Also, someone updated it and now my builds are no longer working.  I tried to update them to use the new 'Nuget' step as recommended, but this step doesn't support the pattern that the old one did. So my builds still are not working.  If I leave the negative pattern there, it finds no files.  If I remove the negative pattern it builds nuget packages for my test projects.  I know I could delete the nuget packages for the test projects after they were built and before publishing them, but it is a hassle when the minimatch pattern worked with the old step.

@alexmullans from msft to advise

@TThat17 I posted above is not an answer, but the comment to explain same issue as you met. We can wait until the nuget pack task be updated.

I'm having similar problems getting the negative pattern to work.  Copying the example from the markdown text doesn't work.  Any update on when this may be fixed?  Currently I have 14 Nuget Pack tasks because I can't use wildcards!  (I raised stackflow question http://bit.ly/2tcvuZH which lead me to this issue)

Are you using the NuGet Packager task or the NuGet task (with the 'pack' command selected)? If the former, that task is now deprecated and a number of improvements were made to the new NuGet task. Please switch to using that task and see if that fixes your issue.

Using the new shiny NuGet task with the pack command.  Unless you've done a release since yesterday (with a fix for this in it) it's still broken :)

I'm experiencing the same issue using the NuGet task with the pack command selected.
The issue isn't just for negative patterns not working, its not even working for multiple files. In short if I use the semicolon separator the task finds no matching files.

If anyone requires a workaround for this, you can build all the csproj files using the ***.csproj wildcard search, and then add a powershell task and use an inline script such as this to remove the unwanted packages before pushing them up:
Remove-Item –path $(Build.ArtifactStagingDirectory)\*test*.nupkg –recurse

@grantwar - I noticed that the ; was messing things up too.  I'll give the powershell script you've mentioned a go.  Thanks ;)

Can confirm, we're hitting this issue too. There's something wrong when you include a semi-colon.

This is fixed by #4775. Will be live in the next day or so.


[SPARK-44179][CORE]Fix the number of executors is calculated incorrctly when the task fails and it is speculated that the task is still executing

What changes were proposed in this pull request?
The dynamic scheduler listener keeps track of the number of running speculative tasks. When a task fails and is not a speculative task, and its corresponding speculative task is still running, the stageAttemptToTaskIndices will not remove the task index.
Why are the changes needed?
Assuming a stage has Task 1, with Task 1.0 and a speculative task Task 1.1 running concurrently, the dynamic scheduler calculates the number of executors as 2 (pendingTask: 0, pendingSpeculative: 0, running: 2).
At this point, Task 1.0 fails, and the dynamic scheduler recalculates the number of executors as 2 (pendingTask: 1, pendingSpeculative: 0, running: 1).
Due to the failure of Task 1.0, copyRunning(1) becomes 1. As a result, Task 1 is speculated again and a SparkListenerSpeculativeTaskSubmitted event is triggered. However, the dynamic scheduler's calculation for the number of executors becomes 3 (pendingTask: 1, pendingSpeculative: 1, running: 1), which is obviously not as expected.
Then, Task 1.2 starts, and it is marked as a speculative task. However, the dynamic scheduler still calculates the number of executors as 3 (pendingTask: 1, pendingSpeculative: 1, running: 1), which again is not as expected.
Does this PR introduce any user-facing change?
No
How was this patch tested?
add ut

cc @cloud-fan @LuciferYang thanks

Thanks for contributing this patch @lyy-pineapple, I will take a look at it later tomorrow.

The issue here is in TaskSetManager (tsm), not ExecutorAllocationManager.
The scenario you laid out is correct, namely:
Initial state:

For partition P, original task T1 = 1.0  and speculative task T2 = 1.1
speculatableTasks is empty, since 1.1 has started already.

T1 fails [1]:

tsm.handleFailedTask adds the task again (addPendingTask at the end).
This in turn adds P to all the task lists

Assuming [1] has not yet been scheduled and we have checkSpeculatableTasks invoked.
The condition in checkAndSubmitSpeculatableTasks will be true, namely : !successful(index) && copiesRunning(index) == 1 && !speculatableTasks.contains(index).
Hence we add a speculative task for schedule.
This is the reason why we have 3 pending tasks - the running speculated task, the re-added task from failure, and the new speculative task.
So what ExecutorAllocationManager is doing is IMO correct - what is incorrect is addition of the second speculative task itself.
The fix would be to change the condition in checkAndSubmitSpeculatableTasks to something like:
  !successful(index) && copiesRunning(index) == 1 && !speculatableTasks.contains(index) &&
  // make sure the currently running copy is not a speculative task
  !info.speculative

+CC @Ngone51 as well, since this is a bit more involved change (though a 1 line change :-) )

The issue here is in TaskSetManager (tsm), not ExecutorAllocationManager. The scenario you laid out is correct, namely:
Initial state:

For partition P, original task T1 = 1.0  and speculative task T2 = 1.1
speculatableTasks is empty, since 1.1 has started already.

T1 fails [1]:

tsm.handleFailedTask adds the task again (addPendingTask at the end).
This in turn adds P to all the task lists

Assuming [1] has not yet been scheduled [1] and we have checkSpeculatableTasks invoked, we will have:
The condition in checkAndSubmitSpeculatableTasks will be true, namely : !successful(index) && copiesRunning(index) == 1 && !speculatableTasks.contains(index) Hence we add a speculative task for schedule. Now we actually have the running speculative task, the re-added failed task replacement, and yet another speculative task added. This is the reason why we have 3 pending tasks.
So what is incorrect is addition of the second speculative task itself. The fix would be to change the condition in checkAndSubmitSpeculatableTasks to something like:
  !successful(index) && copiesRunning(index) == 1 && !speculatableTasks.contains(index) &&
  // make sure the currently running copy is not a speculative task
  !info.speculative

+CC @Ngone51 as well, since this is a bit more involved change (though a 1 line change :-) )
[1] If scheduled, copiesRunning > 1, so no speculative task will be scheduled again in checkAndSubmitSpeculatableTasks

if add condition  !info.speculative ,the speculative task would not be speculated.I thought there may be some issues with this

We already have a speculative task running, and have scheduled the retry for the task when it failed ... so I dont see an issue with adding the condition ... having said that, given how sensitive this code is, will wait for @Ngone51 to also take a look.
Also, +CC @JoshRosen, @jiangxb1987 in case you have bandwidth to look into this :-) Would love an extra pair of eyes on this.

if we already have a speculative task running, and failed task would not retry because dequeueTaskFromList  need copiesRunning(index) == 0:
 if (!successful(index)) {             if (copiesRunning(index) == 0) {               return Some(index)             } else if (speculative && copiesRunning(index) == 1) {               return Some(index)             }           }

Yes, that condition would need to be relooked into as well, good point.


Cannot read properties of undefined (reading '_logger')

When using batchDescribe function and if the response has any errors, the error log is failing. Below is the stack trace.
TypeError: Cannot read properties of undefined (reading '_logger')
    at /node_modules/jsforce/lib/connection.js:1336:18
    at tryCallOne (node_modules/promise/lib/core.js:37:12)
    at /node_modules/promise/lib/core.js:123:15
    at flush (/node_modules/asap/raw.js:50:29)
    at processTicksAndRejections (node:internal/process/task_queues:78:11)

https://github.com/jsforce/jsforce/blob/9cb317cfdbc6c69bfaf9c8497d09dc0af80f5f84/lib/connection.js#L1336

triaging old issues...
v1 doesn't receive updates, this method was removed in v2.


adevice - silent mode is not working as expected

each device treats this settings differently, so the result can be the opposite of expected -> non silent instead of silent

I wont change the implementation, since it works on majority of devices.


Move to opensearch dashboard user agent

The user agent is still using "Kibana", we need to change to OpenSearch Dashboard like AD dashboard https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/blob/main/server/utils/constants.ts#L40

PR: https://github.com/opensearch-project/anomaly-detection/pull/56


Use non deprecated API

rmw_qos_profile_t call was deprecated, we should use rclcpp::QoS. This API was deprecated on jazzy https://github.com/ros2/rclcpp/blob/jazzy/rclcpp/include/rclcpp/node.hpp#L268-L274.

Linux
Linux-aarch64
Linux-rhel
Windows

Not really sure, I was suprised too


Bigger impact of road condition should not affect highway roads

Describe the problem
Highways cannot be maintained so their condition value is always the lowest and currently when the option is enabled it will drop the speed limit for vehicles to min value (-25%).
Steps to reproduce

Snowfall DLC required
Enable the option
Check current vehicle speed at highways, dry road (without Individual Driving Styles), use debug Vehicle overlay.
Vehicles will move at 75% of speed limit or 80km/h if the limit is higher than 110km/h and those roads cannot be maintained by road maintenance vehicle so vehicles will never reach the selected speed limit.

See tab Road Condition not the first one, Coverage
I've checked the code. Transfer offers for road maintenance are sent only from roads with info.m_highwayRules == false
You can also check m_condition - it's always zero. The only thing which can increase road condition (by accident) is when you build road network that maintenance vehicle are forced to use highway, but like I said, roads itself don't send requests for maintenance so these going outside the city broders between outside connections will have -25% speed limit.


CMG-95 go to correct slack channel for alerts

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.35%. Comparing base (00fe0eb) to head (1da974e).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #10   +/-   ##
=========================================
  Coverage     55.35%   55.35%
  Complexity       19       19
=========================================
  Files            10       10
  Lines           168      168
  Branches         10       10
=========================================
  Hits             93       93
  Misses           75       75

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Task network_plugin/weave : reload weaveproxy always fails for rhel OS family

Example job run https://travis-ci.org/kubespray/kargo/jobs/154751212

Seems resolved by the recent commits, see CI results https://travis-ci.org/kubespray/kargo/builds/156486366


Update Homebrew formula

Updates formula to the current version used by Homebrew.
Additionally adds a "devel" block that allows using a version
of protobuf-swift from the "ProtoBuf3.0-Swift2.0" branch.
Thanks for the help getting this working, thought I'd send
back the formula I used, in case you'd find this helpful.

This version won't work, because protobuf-swift 3.0 dependence demands like   brew install protobuf --devel.

I'm sorry, but I'm not sure what you're saying. If the problem is that I chose an arbitrary version number in the range "3.0" for the devel branch, I definitely don't know what I'm doing there, I just thought it would be good to keep it out of the 2.0 range, since I'm not sure when you'll support protobuf3 as the main release, and there may be more in the 2.x series of the protobuf-swift before then. Not tied to that at all.


Missing i variable in powerset function

powerset function misses i variable, it causes a compiler error.

https://github.com/jneug/typst-finite/blob/6277ce1d868ff2912080dda19acdf925a88c141f/cmd.typ#L299

Sorry, missed this one for the 0.4.0 relase that just published. I submitted 0.4.1 with a fix for this.


[Brainstorming] - Roadmap

Feature brainstorming for GH integration

[x] Pass model back to artifact in actions
[x] Make a release flag so that the model will be made into a release automatically.
[x] Create a docker image of the model
[x] Deployment of a model, which has not been trained on AML or with GH Actions

Added Tasks to individual actions.


Update to prometheus/common v0.44.0

[ ] I added CHANGELOG entry for this change.
[x] Change is not relevant to the end user.

Changes
Updated the prometheus/common package v0.42.0 => v0.44.0
Verification
This is a minor change to httpconfig

It looks like the protobuf String methods have changed in client v0.4.0.  I'm in the process of updating the test strings now,


[ZEPPELIN-4598]. upgrade-note.sh GitNotebookRepo cannot be cast to OldNotebookRepo

What is this PR for?
This PR fix the issue that OldGitNotebookRepo not loaded correctly because we still try to load GitNotebookRepo
What type of PR is it?
[Bug Fix]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-4598

How should this be tested?

Manually tested

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Someone has verified it (see jira comment). Will merge it if no more comments.


Object initializer code ignored in generic method

Expected
"2"

Actual
"1"

Steps To Reproduce
Deck
public class Program
{
    public static void Main()
    {
        Console.WriteLine(TestMethod<TestClass>().TestProperty);
    }

    public static TType TestMethod<TType>()
        where TType : TestClass, new()
    {
        return new TType
        {
            TestProperty = 2
        };
    }
}

public class TestClass
{
    public TestClass()
    {
        this.TestProperty = 1;
    }

    public int TestProperty { get; set; }
}

Hi @kosmab,
Thank you for reporting this defect and a sample code demonstrating the issue.
The sample did help to verify and debug a lot; we just changed class and prop names a bit to make it more readable.
It has been fixed in will be included in 15.6 release. Thanks again for reporting.


read_storage panics

There is a problem with read_storage, if an offset passed that is out of bounds of the length of the value the implementation of an extrinsic will panic. This PR solves it.
There is another problem with the API itself: there is no way to indicate how many bytes were read. So even if we fix the panic, the API wouldn't be universally usable since the API cannot indicate how many bytes it wrote to the buffer.
The API is not used within Substrate, except for implementing exists (e.g. this).

alternative here: https://github.com/paritytech/substrate/pull/3597 which i prefer since it just forces a cap on the value rather than introducing a full conditional.
the point of the call isn't to be "universal" - if you want true universality, then you either use the allocating storage function or use two calls to read_storage, one to find the length and the second to actually read some or all of it into a pre-allocated buffer.

should do the trick.


Intrenal Traffic Manager Endpoint go down by NSG inbound rule on subnet

[Enter feedback here]
I'm using Premium SKU and deploying the APIM on VNET as external vnet mode. Additionaly, we are using multi region (Japane East and West).
We have requirements that inboud 443 https connection to APIM from only specified clients (Logic App and WAF) are allowed. so we are being allowed 443 port from only Service Tags and WAF IP range on NSG inbound rules which APIM is deployed.
In this case, client application is working normaly.
But multi region load balancing by APIM does not work because intrenal Traffic Manager Endpoints on each region are blocked.
Traffic Manager Endpoint
https://--01.regional.azure-api.net/status-0123456789abcdef
https://contoso-westus2-01.regional.azure-api.net/status-0123456789abcdef
I could reproduce this behavior on my enviroment easily.
After I allowed "from Traffic Manager to Virtual Network 443" on NSG, the monitor status of  Intrenal Traffic Manager become healthy and regionalload balancing work correctly.
ASK:
I think that "from Traffic Manager to Virtual Network 443" should be added on the list of the following documents. And the note should be add to this docs also.
Common Network Configuration Issues
https://docs.microsoft.com/en-us/azure/api-management/api-management-using-with-vnet#-common-network-configuration-issues

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d7b2624c-40ea-c23c-3af5-79953d4cb549
Version Independent ID: 0bf60c10-7ae4-476a-6cbd-4a189a97000f
Content: Deploy Azure API Management services to multiple Azure regions - Azure API Management
Content Source: articles/api-management/api-management-howto-deploy-multi-region.md
Service: api-management
GitHub Login: @mikebudzynski
Microsoft Alias: apimpm

Hello @y10e
Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.
@mikebudzynski could you please have a look at the issue. Thank you!

Closing - this point has been addressed in subsequent updates to required ports in https://learn.microsoft.com/en-us/azure/api-management/virtual-network-reference?tabs=stv2
#please-close


Error using {push_files}

Summary
Whenever I pass the {push_files} argument to a run: in the pre-push section I just get this error message that says error replacing {push_files}: exit status 128
Steps to reproduce
Here's the relevant sections my lefthook.yaml file:
---
skip_output:
  - meta       # Skips lefthook version printing
  - success    # Skips successful steps printing
pre-push:
  parallel: true
  commands:
    shellcheck:
      tags: sast
      glob: "*.sh"
      run: scripts/shellcheck.sh {push_files}

Contents of shellscheck.sh though I'm sure it doesn't matter because it happens no matter what I use but adding for completeness sake:
#!/usr/bin/env bash
set -euo pipefail

if ! command -v shellcheck > /dev/null; then
  echo "WARN: shellcheck is not installed. Installing....."
  if [[ "$(uname)" == "Darwin" ]]; then
    if ! command -v brew > /dev/null; then
      echo "ERROR: Homebrew isn't installed. Please see https://docs.brew.sh/Installation for instructions."
      exit 1
    else
      brew install -q shellcheck
    fi
  else
    echo "ERROR: Non macOS operating systems not supported at this time. Feel free to open a PR and extend this check :)"
  fi
fi

for file in "$@"
do
  shellcheck -o all "${file}"
done

Expected results
I expect it to not error? lol. I know the file i'm testing should cause an error to return from my script. I've also tried other scripts in the run directive and the same results.. anytime I reference the {push_files} I get that same error.
Actual results
I make adjustments to a *.sh file and when I try to push up the change to remote up I get the error [snipped branch name details]:
➜  git push origin BRANCH_NAME
error replacing {push_files}: exit status 128
shellcheck: (SKIP. ERROR)

refs/heads/style/BRANCH_NAME branch_sha refs/heads/style/BRANCH_NAME branch_sha

SUMMARY: (done in 0.09 seconds)

Possible Solution
🤷🏻

Well, I guess I know more golang that I thought... this line is causing the error. Primary branch names are no longer called master and are usually called main but could also be called any other thing. Should this be configurable?
for now i've just switched to using to work around it:
    shellcheck:
      tags: sast
      files: git diff --name-only HEAD @{push} || git diff --name-only HEAD main
      glob: "*.sh"
      run: scripts/shellcheck.sh {files}

Hi! Thank you for the issue. I knew that someday it would shoot. I think this command should be changed to get the diff from the first parent of the current branch. However this could break it for other people using the tool if I put it to the fix version. I think this can be done for the next minor/major release of lefthook. What do you think?

Hi! Thank you for the issue. I knew that someday it would shoot. I think this command should be changed to get the diff from the first parent of the current branch. However this could break it for other people using the tool if I put it to the fix version. I think this can be done for the next minor/major release of lefthook. What do you think?

I think including it in the next major release would make sense to me, that way folks can opt-out or give time to fix any issues it may have with their current setup.

Just ran into this when pushing the PR to a repo that (wait for it) uses the pre-push hook. 😆  I'd love to see this fixed, or made configurable. Maybe the upstream ref should be targeted instead of a hard-coded (or even configurable) branch?  Something like this might provide a more reasonable default?

Any updates on this?


Make alternate6 - cave dimension (overworld with nether generation)

nether generation has nothing to do with caves

When you create a buffet world with a cave world generator it looks like nether

Huh. I was thinking we could use the same caves as the real overworld does (if this dimension gets implemented of course)


[FLINK-31444][runtime]FineGrainedSlotManager reclaims slots when job is finished

What is the purpose of the change
When a job shuts down there is a race condition between slots being freed and requirements being set to 0. If the slot release arrives first at the RM then it will immediately try to re-allocate slots, since the requirements are not 0 yet.
This change try to free all inactive slots in task executor when job finished(clear requirements).
Verifying this change

Added unit test testReclaimInactiveSlotsOnClearRequirements to verify reclaim only invoked on clear requirements

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature?(no)

@xintongsong thanks, comments addressed. PTAL

@flinkbot run azure


Feature: Marker / Highlighter

This can almost be done with the line tool, however the stroke is too small, and by default it goes on top of the already existing drawing.
My suggestion would be:
Thickness: text + some margin
Place at background so the text can still clearly be read

It can be done right now with a rectangle shape:

Though the workflow is not ideal.
Anyway, this might be part of https://github.com/excalidraw/excalidraw/issues/1126

Yes, found the flow for using rectangle less useful since my other boxes were empty so I had to toggle all the settings back and forth. In the end I went with underlining in my drawing since it was easiest.

I would update the other issue and have them tackle at the same time... text color and background fo ranges.

Still need this feature, native highlighter could be very useful

please!


Indexing error leading to cwl-runner CLI mismatch

Bug Report
Expected behaviour
https://dockstore.org/workflows/github.com/cancerit/workflow-seq-import/chksum_seqval_wf_interleaved_fq:0.4.0?tab=info should run via both

Using cwl-runner
Using Dockstore CLI

Actual behaviour
Fails running using cwl-runner as shown by https://gitter.im/ga4gh/dockstore?at=5c77fd05212d0c1e1aae08ca
if_file_name_is_bz2_then_return_null_else_return_in_json_to_output.cwl should be in a toolkit directory as shown in https://github.com/cancerit/workflow-seq-import/tree/0.4.0/cwls/toolkit
However, it seems to index in the pwd as shown by https://dockstore.org/api/api/ga4gh/v2/tools/%2523workflow%252Fgithub.com%252Fcancerit%252Fworkflow-seq-import%252Fchksum_seqval_wf_interleaved_fq/versions/0.4.0/CWL/files
Thanks @byb121 for giving us the heads-up
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Fix Versions: Dockstore 1.6
┆Sprint: Seabright Sprint 6 Ferry
┆Issue Number: DOCK-540

Another clue. Looks like the zip download gives the correct structure and so does the DB.
This may be a translation to TRS issue (and then to the GUI) https://gitter.im/ga4gh/dockstore?at=5c78088b2ca5ec5474550aed

Hm, not sure if this is working. I was able to reproduce the old bug using production's CLI, but when I try running it with the latest release I get the following.
https://staging.dockstore.org/workflows/github.com/cancerit/workflow-seq-import/chksum_seqval_wf_interleaved_fq:0.4.0?tab=launch
/usr/local/bin/cwl-runner 1.0.20180403145700
No handlers could be found for logger "rdflib.term"
/usr/local/lib/python2.7/site-packages/rdflib/plugins/parsers/structureddata.py:30: UserWarning: html5lib not found! RDFa and Microdata parsers will not be available.
  'parsers will not be available.')
Could not load extension schema http://schema.org/docs/schema_org_rdfa.html: html5lib is not installed, cannot use RDFa and Microdata parsers.
https://staging.dockstore.org:443/api/api/ga4gh/v2/tools/%23workflow%2Fgithub.com%2Fcancerit%2Fworkflow-seq-import%2Fchksum_seqval_wf_interleaved_fq/versions/0.4.0/plain-CWL/descriptor/%2Fcwls%2Fchksum_seqval_wf_interleaved_fq.cwl:124:1: unrecognized extension field `dct:creator`.  Did you include a $schemas section?
foreign properties set([])
https://staging.dockstore.org:443/api/api/ga4gh/v2/tools/%23workflow%2Fgithub.com%2Fcancerit%2Fworkflow-seq-import%2Fchksum_seqval_wf_interleaved_fq/versions/0.4.0/plain-CWL/descriptor/%2Fcwls%2Fchksum_seqval_wf_interleaved_fq.cwl:3:1: unrecognized extension field `http://schema.org/codeRepository`.  Did you include a $schemas section?
foreign properties set([])
https://staging.dockstore.org:443/api/api/ga4gh/v2/tools/%23workflow%2Fgithub.com%2Fcancerit%2Fworkflow-seq-import%2Fchksum_seqval_wf_interleaved_fq/versions/0.4.0/plain-CWL/descriptor/%2Fcwls%2Fchksum_seqval_wf_interleaved_fq.cwl:3:1: unrecognized extension field `http://schema.org/license`.  Did you include a $schemas section?
foreign properties set([])
https://staging.dockstore.org:443/api/api/ga4gh/v2/tools/%23workflow%2Fgithub.com%2Fcancerit%2Fworkflow-seq-import%2Fchksum_seqval_wf_interleaved_fq/versions/0.4.0/plain-CWL/descriptor/%2Fcwls%2Fchksum_seqval_wf_interleaved_fq.cwl:3:1: unrecognized extension field `http://schema.org/author`.  Did you include a $schemas section?
foreign properties set([])
https://raw.githubusercontent.com/cancerit/dockstore-cgp-chksum/0.4.1/Dockstore.cwl:15:1: unrecognized extension field `dct:creator`.  Did you include a $schemas section?
foreign properties set([])
https://raw.githubusercontent.com/cancerit/dockstore-cgp-chksum/0.4.1/Dockstore.cwl:15:1: unrecognized extension field `dct:creator`.  Did you include a $schemas section?
foreign properties set([])
[workflow %2Fcwls%2Fchksum_seqval_wf_interleaved_fq.cwl] start
[step if_input_is_bz2_convert_to_gz_else_just_rename] start
Unexpected exception
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/cwltool/workflow.py", line 840, in job
    **kwargs):
  File "/usr/local/lib/python2.7/site-packages/cwltool/command_line_tool.py", line 374, in job
    builder.pathmapper = self.makePathMapper(reffiles, builder.stagedir, **make_path_mapper_kwargs)
  File "/usr/local/lib/python2.7/site-packages/cwltool/command_line_tool.py", line 233, in makePathMapper
    separateDirs=kwargs.get("separateDirs", True))
  File "/usr/local/lib/python2.7/site-packages/cwltool/pathmapper.py", line 229, in __init__
    self.setup(dedup(referenced_files), basedir)
  File "/usr/local/lib/python2.7/site-packages/cwltool/pathmapper.py", line 282, in setup
    self.visit(fob, stagedir, basedir, copy=fob.get("writable"), staged=True)
  File "/usr/local/lib/python2.7/site-packages/cwltool/pathmapper.py", line 271, in visit
    self.visitlisting(obj.get("secondaryFiles", []), stagedir, basedir, copy=copy, staged=staged)
  File "/usr/local/lib/python2.7/site-packages/schema_salad/sourceline.py", line 164, in __exit__
    raise self.makeError(six.text_type(exc_value))
ValidationException: Dockstore.json:2:15: [Errno 2] No such file or directory: '/Users/natalieperez/ftp://ftp.sanger.ac.uk/pub/cancer/dockstore/examples/tiny_interleaved.fq.gz'
[step if_input_is_bz2_convert_to_gz_else_just_rename] Cannot make job: Dockstore.json:2:15: [Errno 2] No such file or directory: '/Users/natalieperez/ftp://ftp.sanger.ac.uk/pub/cancer/dockstore/examples/tiny_interleaved.fq.gz'
[workflow %2Fcwls%2Fchksum_seqval_wf_interleaved_fq.cwl] completed permanentFail
{
    "chksum_json": null,
    "results_manifest": null,
    "interleaved_fastq_out": null,
    "chksum_put_server_response": null
}
Final process status is permanentFail

@NatalieEO
What does your Dockstore.json look like?
/Users/natalieperez/ftp://ftp.sanger.ac.uk/pub/cancer/dockstore/examples/tiny_interleaved.fq.gz seems odd and unlikely to be affected by a server-side bug.
We might have a new client bug on our hands

{
  "fastq_in": {
    "path": "ftp://ftp.sanger.ac.uk/pub/cancer/dockstore/examples/tiny_interleaved.fq.gz",
    "class": "File"
  },
  "put_address":"https://postman-echo.com/put",
  "chksum_json": {
    "path":"/tmp/chksum_fq_inter_result.json",
    "class": "File"
  },
  "chksum_put_server_response": {
    "path":"/tmp/server_response_1.json",
    "class": "File"
  },
  "interleaved_fastq_out": {
    "path":"/tmp/interleaved.fq.gz",
    "class": "File"
  },
  "results_manifest": {
    "path":"/tmp/rg_file_manifest.txt",
    "class": "File"
  }
}```

Oh, I see now.
So dockstore cli supports ftp, cwltool/cwl-runner does not support ftp, not yet anyway.
So when testing with cwl-runner, you'll need to have the files available locally (and modify the Dockstore.json accordingly).

@denis-yuen thanks for the help. cwl-runner is working using DockstoreAPI - 1.6.0-beta.3. Was able to successfully launch https://staging.dockstore.org/workflows/github.com/cancerit/workflow-seq-import/chksum_seqval_wf_interleaved_fq:0.4.0?tab=launch using Dockstore CLI and cwl-runner.


Setup

Hello, dear code reviewer!
In this branch I've:

Set up a rails app as an API only with Postgresql as the database
Configured the database, routes, controllers & models
Configured the controllers to render json instead of html
Set up a "Procfile" with foreman to run both the rails & the react servers simultaniously
Laid down the instructions in the README file

Here is a link to the pull request of the frontend repo:
https://github.com/Peter1907/hello-react-front-end/pull/1
Let me know if there's anything to be added or improved.
Thank you!

@brytebee Good to see you here 😂😂🚀 Thank you


Right-clicking Cmder's taskbar icon gets broken after a pinning and unpinning sequence

100% reproducible on Windows 8.1 x64. Steps:

Launch Cmder from Windows Explorer
Right-click Cmder's taskbar icon and select "Pin this program to the taskbar"
Right-click Cmder's taskbar icon and select "Unpin this program from taskbar"
Try to right-click Cmder's taskbar icon again (no menu is shown)

I'm seeing the same, icon changes to conemu default.  Would love to be able to pin this version.

Duplicate of #251.


[Bug] Very laggy experience with the mac version during remote play

Describe the bug
No response
To Reproduce
No response
Expected behavior
No response
Environment
- OS: macos Ventura
- Device: MacBook air m1
- Greenlight version:

Anything else?
No response
New issue

[X] I confirm that this is a new issue and not a duplicate

+1

Feel like I've noticed the same, also a lot of spurts where my screen freezes but the game doesn't, and 5 seconds later it unfreezes the screen.  Input still works during that time because now I hit pause when I realized what's happened and when it comes back its on the pause screen.

I have been experiencing lag problems since the features in the picture below were added. Also sometimes it won't connect to my Xbox. I'm currently using the latest version, 2.2.0. Is this a problem or how should I change the settings to get the most performance?

I have been experiencing the same, even with the latest release 2.2.1.

[DarkxPunk]
I have the EXACT same laptop and the EXACT same problems.
I'm using Version 2.3.1.


Update DNS architecture ADR

It needs to be amended slightly to make clear that we cannot do application specific green and blue deployments.
Also adds a clearer diagram.

Thanks for re-doing this! Nitpick: it would be nice to have this diagram in higher quality.

Updated with a higher resolution image.


Remove paragraph with broken lines

Solve -> Remove paragraph with broken lines

Hi Felipe! Thanks for the pull request, but this space at the end of the page is left intentionally, in order to let it "breath" 😄

OMG! Sorry please! thanks for explanation me @PanosSakkos  👍  :D

No worries! :smile:


Tx Vs SignedTx better naming to logically distinguish for readability

Transaction includes user's sig as well, but because we also have a struct called SignedTransaction  it always causes confusion when reviewing code on what Signed means. Let's fix that.
Note: We also have CertifiedTransaction, this is generally understandable.

Transaction: user signed => rename to ClientSignedTransaction
Signed Transaction: signed by user and an authority => rename to AuthoritySignedTransaction
Certified Transaction: authority sigs reached 2f+1 and certified
pub type Transaction = TransactionEnvelope<EmptySignInfo>;
pub type CertifiedTransaction = TransactionEnvelope<AuthorityStrongQuorumSignInfo>;
pub type SignedTransaction = TransactionEnvelope<AuthoritySignInfo>;

any idea if this is still needed? @lxfind

I would say this is no longer need. We already have SenderSignedData within Transaction


fix(net): Rate-limit MetaAddrChange::Responded from peers

Motivation
There is no limit to the amount of MetaAddrChange::Responded updates a peer can send to the shared address book updater channel.
This is a remotely-triggerable security issue, likely resulting in a hang or very slow network performance.
Complex Code or Requirements
This code runs concurrently for every peer, then writes to a channel shared between all peers. Writing on the channel blocks if it is full.
Solution

Stop allowing peers to send a Ping or Pong message to generate a MetaAddrChange::Responded
Instead, generate a MetaAddrChange::Responded after every successful heartbeat, which is already rate-limited by Zebra

Review
This is a security fix that we might want to block the stable release for.
Reviewer Checklist

[ ] Will the PR name make sense to users?

[ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)

[ ] Are the PR labels correct?
[ ] Does the code do what the ticket and PR says?

[ ] Does it change concurrent code, unsafe code, or consensus rules?

[ ] How do you know it works? Does it have tests?

@mpguerra this seems serious enough to block the stable release, but it's a small change so it should be easy to review.

Temporary network failure:

Error: buildx failed with: ERROR: failed to solve: failed to push us-docker.pkg.dev/zfnd-dev-zebra/zebra/zebrad-test:pr-6738: failed to copy: failed to do request: Put "https://us-docker.pkg.dev/artifacts-uploads/namespaces/zfnd-dev-zebra/repositories/zebra/uploads/...": write tcp <IP_ADDRESS>:47038-><IP_ADDRESS>:443: write: connection reset by peer

https://github.com/ZcashFoundation/zebra/actions/runs/5039819774/jobs/9038203151?pr=6738#step:10:926

@mpguerra this seems serious enough to block the stable release, but it's a small change so it should be easy to review.

Is there a corresponding issue for it? It's ok if not, I just want to make sure we track it somehow.

I didn't open a separate ticket.
This is related to #6672, because it was one of the ways that remote peers could easily manipulate their address state inside Zebra. (If we'd fixed this bug earlier, the audit finding might have been low severity, because peer state changes would all have been rate-limited or triggered by the local Zebra node.)
Also happy to call it a separate bug if you want.

@mpguerra this seems serious enough to block the stable release, but it's a small change so it should be easy to review.

Is there a corresponding issue for it? It's ok if not, I just want to make sure we track it somehow.

I didn't open a separate ticket.
This is related to #6672, because it was one of the ways that remote peers could easily manipulate their address state inside Zebra. (If we'd fixed this bug earlier, the audit finding might have been low severity, because peer state changes would all have been rate-limited or triggered by the local Zebra node.)
Also happy to call it a separate bug if you want.

Nope, I see I already linked it to the relevant audit issue, it's all I need :)


Fix indexing in coord adjust weighted blend CLI test.

In newer versions of numpy, e.g: 1.15.1, it is no longer permitted to index an array with a float.
Updated the BATS test to return an integer. Data should be unchanged.
(In Python 2, integer division returned an integer, but at Python 3, this returns a float - need to use explicit integer division in Python 3)
Testing:

[x] Ran tests and they passed OK

@cgsandford tells me that this test is being removed in IMPRO-857 - so feel free to disregard/close this PR if it is no longer necessary.


[CELEBORN-1251] Connect the server and client bootstraps to RpcEnv

What changes were proposed in this pull request?
This connects client/server bootstraps to the RpcEnv in Celeborn. This is a prerequisite for leveraging RPC security in subsequent PRs where we will add Sasl authentication to the communication between the client and Celeborn Master/Workers.
It is part of the epic: https://issues.apache.org/jira/browse/CELEBORN-1011.
Why are the changes needed?
The changes are needed for adding authentication to Celeborn. See CELEBORN-1011.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added some UTs

@waitinfuture @RexXiong @FMX @pan3793 Please help review

Thanks, merge to main(v0.5.0)


Elastalert Query

Hello,
I wanted to write a query for rule mentioned below. Request you to kindly help me on that.
'
Rule Condition.
In wazuh SIEM if there is level of alert is 12 and above in agent 000 and if the same source IP has generated the alert level 12 and above in any other agent then alert should be triggered.

Hi @vikrampc

ElastAlert2 Server
A server that runs ElastAlert2 and exposes REST API's for manipulating rules and alerts.

Questions related to ElastAlert2 please send directly to its github project: https://github.com/jertel/elastalert2/discussions


New clusterRoleName helper seems to be causing a template error

Hi folks, thanks for maintaining CoreDNS!
I'm looking to update from version 1.30.0 to 1.36.0 of the CoreDNS chart.
When I run helm template against the new version without making any changes to values files I get the following error:
		STDERR:
		  Error: template: coredns/templates/_helpers.tpl:233:38: executing "coredns.clusterRoleName" at <.Values.clusterRole.nameOverride>: nil pointer evaluating interface {}.nameOverride
		  Use --debug flag to render out invalid YAML

This looks to be caused by the following snippet in the helper templates for the chart:
{{/*
Create the name of the service account to use
*/}}
{{- define "coredns.clusterRoleName" -}}
{{- if and .Values.clusterRole .Values.clusterRole.nameOverride -}}
    {{ .Values.clusterRole.nameOverride }}
{{- else -}}
    {{ template "coredns.fullname" . }}
{{- end -}}
{{- end -}}

Without the clusterRole key set in the values, Helm errors when trying to evaluate whether .Values.clusterRole.nameOverride is defined, because it is trying to access a child property of a parent which does not exist. As far as I understand, this is the expected behaviour in Helm and their recommendation is to prefer using relatively flat variable names: https://github.com/helm/helm/issues/8026#issuecomment-677851638)
Adding an empty clusterRole: {} key in a values file lets me template the chart successfully.
As best I can tell, clusterRole was currently only used as a parent for the new clusterRole.nameOverride. Should it be added to the chart default values as an empty dictionary to avoid running into this templating error? ie:
# /charts/coredns/values.yaml

clusterRole: {}

Thanks,
Nikki

Hi @nikki-quant , thanks for raising this.
I think you're correct and the lack of a default value causes a nil pointer exception. The right value should be an empty string  ("") as we expect a string vaule there not object.
I would be happy to review a PR with the fix

Thank for taking a look -  I'll put a PR in :)

Hi @hagaibarel , I've put in a pull request. Very happy to make updates if that doesn't look right, or if there's styleguide type things you'd prefer done differently for the changelog or comments.

Fixed in #181


Expand Contributing.md to include additional relevant details

Currently the Contributing.md file does a good job of covering how to get set up, but is should also:

Include an embed of the video demo Tuomas recorded
Include a link to the spreadsheet (read-only) for people to browse to get a better idea of what it's for, and an explanation of what the spreadsheet is.
You might want to clarify the role of Arcade Mode - basically, a stand alone app that will soon become the freeCodeCamp coding interview prep section

The Contributing guide has been updated for points 2 and 3.

@timolawl Awesome! Thanks!


Explainability: extend support to include external ip

In addition to the currently supported VSI's network interfaces.

At least one src/dst must be a VSI network interface
The ip input will be given as a single CIDR external block
In the output connections between sub-interval of the given CIDR to the network interface will also be presented
The output will be presented in a minimal - grouped manner

Implementation wise - the computation will be done to disjoint blocks of the SG rules and the given CIDR and then grouped

Extend to non-external CIDRs?

solved by #295 and #310


Fixed the number or created repositories (#1098)

Hello
The code was fixed and now it's according the expected.
[root@wallsat65 script1]# ./ocp36-sat6.py --password redhat
Adding OCP images to org ID: 1 with the product name: ocp36
Continue? y/n:
y
Adding product with name: ocp36
Product created.
Adding openshift3 images
Repository created.
Repository created.
Repository created.
Repository created.
Repository created.
The following vars should exist in your OpenShift install playbook
oreg_url: defaultorganization-ocp36-openshift3_ose-${component}:${version}
openshift_disable_check: "docker_image_availability"
openshift_docker_insecure_registries: "wallsat65.usersys.redhat.com:5000"
openshift_docker_additional_registries: "wallsat65.usersys.redhat.com:5000"
openshift_examples_modify_imagestreams: True
Sync repo data? (This may take a while)
Continue? y/n:
y
...

Only 5 repos created according the manual steps (in order to skip the script).
Please check and merge ASAP the code, we have a lot of consultants using this script and causing problems on Satellite (disk reaching 100%).
Thank you.

@dav1x can I get a +1 here


Feature Request: Disabling dates with custom function

Flatpickr will accept a function handler which takes date as variable and return true if that date can be set and false if that date should be disabled!

See http://chmln.github.io/flatpickr/#disable


Streamline Pre-commit Hooks and Enhance Justfile Commands

Pull Request
Description
This change restructures the pre-commit hook system to improve organisation and execution of checks. The main updates include:

Separating checks into mandatory and optional categories.
Integrating gitleaks, justfile formatting, and prettier checks into the main pre-commit script as mandatory checks.
Removing individual script files for gitleaks, justfile, and prettier.
Adding a new just-format-check command to verify justfile formatting.
Introducing a gitleaks-detect command in the Justfile for secret detection.
Simplifying the main pre-commit script by removing execution time reporting and unnecessary echo statements.
Updating the Justfile with new commands for formatting and checking justfile itself.
Modifying the labeller configuration to include 'pre-commit' and 'post-commit' files under the 'shell' label.
Updating the code-quality workflow to use the new just-format-check command.

These changes aim to streamline the pre-commit process and provide a clearer distinction between essential and supplementary checks, while improving the overall efficiency of the hook system.
fixes #79

#76  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite

Merge activity

Oct 29, 3:49 PM EDT: A user started a stack merge that includes this pull request via Graphite.


[TACHYON-1323] Change code in Javadoc to use link where appropriate

https://tachyon.atlassian.net/browse/TACHYON-1323

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/6968/
Test PASSed.

LGTM. Thanks for the doc improvement!

LGTM


Include wakeup instructions in config file metadata

Is your feature request related to a problem? Please describe.
Config files contain instructions for inclusion/exclusion, but don't currently have an option to include wakeup instructions for battery devices.
Describe the solution you'd like
Add an additional wakeup key to the metadata portion of device configuration files, where wakeup instructions can be included. This will allow applications to show wakeup instructions if available for a battery node prior to performing a re-interview/refresh/etc.

@AlCalzone further color on this. Some ZWA files include wakeup instructions but when I pulled them before they were terrible. A lot of "see manuals" and such. These would need to be hand added for the most part but it probably makes sense to include a place for people to do so.

Or the UI could do that on its own where wakeup isn't defined.

Yeah, that's better IMO.


e2e_tests: use initctl for upstart scripts

Centos 6 uses initctl for the google-compute-engine scripts. Update the tests
to check accordinly

/ok-to-test


Why set gpu_memory_utilization so big? What‘s the benifit for it?

if gpu_memory_utilization set to 0.9，nowhatever you load a model， it will occupy very huge memory

Got it! Thank you for your detailed reply and awesome work!  Expect the dynamic resize of KV cache

@cason0126 it "increases the number of requests that can be batched together" (from @WoosukKwon) and not the throughput or speed of results.


v0.18.0

close in favor of https://github.com/facebook/lexical/compare/main...0.18.0__release which has backwards compatibility


[BugFix] Fix unused DCHECK in DictMappingExpr

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes https://github.com/StarRocks/StarRocksTest/issues/1833
Problem Summary(Required) ：
when we enable tablet inner parallel scan. olap-scan-prepare-operator may execute multi times. and they share the same conjunct_ctxs
    _conjunct_ctxs = _scan_node->conjunct_ctxs();
    ...
    // Parse conjuncts via _conjuncts_manager.
    RETURN_IF_ERROR(cm.parse_conjuncts(true, max_scan_key_num, enable_column_expr_predicate));

    // Get key_ranges and not_push_down_conjuncts from _conjuncts_manager.
    RETURN_IF_ERROR(_conjuncts_manager.get_key_ranges(&_key_ranges));
    _conjuncts_manager.get_not_push_down_conjuncts(&_not_push_down_conjuncts);

    _dict_optimize_parser.set_mutable_dict_maps(state, state->mutable_query_global_dict_map());
    RETURN_IF_ERROR(_dict_optimize_parser.rewrite_conjuncts(&_not_push_down_conjuncts, state));

when we rewrite the conjuncts. if we call slot_id in next time, DCHECK will failed.
but it's safe to call parse_conjuncts when we rewrite the conjuncts. so we could remove it
Signed-off-by: stdpain<EMAIL_ADDRESS>Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[x] 2.4
[ ] 2.3
[ ] 2.2

run starrocks_admit_test

run starrocks_be_unittest

@Mergifyio backport branch-2.5

@Mergifyio backport branch-2.4


:alien: nextcloud/listdir conform to frontend

change nextcloud listdir apicall to expect fpath as get parameter to conform with the frontend api

Looks good to me 👍


Focus follows mouse over outputs with focus_follows_mouse no

Focus should not follow mouse over outputs with focus_follows_mouse no to be compatible with the i3 behavior of this config directive.

This is a limitation with wlc. Ping @Cloudef.

Some issues with this are discussed here: wlc#32


Admin section wishlist

Using admin section for first time this year, some things jump out at me as being missing.  Note I don't have time right now to look at any of the code to see why or fix any of these things, just putting here in case someone gets ambitious and wants to address these:
Menu:

page you are on should have a "selected" class
names should match the headings of the pages (eg: menu says "Talks", page says "Submitted Talks")

Dashboard:

totals should update in real-time as I select/favourite talks

Admins:

ability to add admins

Submitted Talks:

should be able to sort asc/desc (right now only asc is available)
sort column should be identified somehow (arrow would make most sense assuming the previous item is done
submitted by should be sortable
filters would be quite useful
created on is not really important and should be removed to create more real estate
add columns for level, desired, sponsor, airport, travel costs (could be a calculate button if not already known), speaker # of previous selections
should have yes/no/maybe type selection instead of "selected" & "star"
should have a totals section at top (yes talks, yes speakers, yes cost, no, maybe)
needs an export button (excel, csv, whatever)
delete option
view all (ps, i dislike pagination in general)
selections and favourites on a per-admin basis

Speakers:

i feel like we need an option to yes/no/maybe speakers
ability to sort/filter columns
option to remove pagination (view all)

Review Talks:

I don't know what this section does. It never seems to have any talks populated

Closing this because of @jakefolio's huge admin PR fixed a bunch of these issues, we can revisit individual ones after


change the ReadMe.md file as gitfetch has got a major update

change the full readme.md as the gitfetch is completely change now, v.0.2.0 is a major update for gitfetch

@ArshErgon assign it to me 🥹

@deepraj02 I'm assigning it to you, it's all yours.