Add fault injection macro unit tests

Adding fault injection unit tests to rmw_dds_common. This should get coverage to about 99%. I'll post CI results soon.
Signed-off-by: Stephen Brawner<EMAIL_ADDRESS>

Builds and tests of the following packages rcutils, rcl_logging_spdlog, rosidl_typesupport_c, rosidl_typesupport_cpp, rcl, rcl_action, rcl_lifecycle, rosidl_runtime_c, rmw_dds_common, rmw

Linux
Linux-aarch64
macOS
Windows

Testing this PR branch against current ros 2 branches. Testing --packages-select rmw_dds_common

Linux
Linux-aarch64
macOS
Windows

Linux
Linux-aarch64
macOS
Windows

Trying again after merging https://github.com/ros2/rcutils/pull/283

Linux
Linux-aarch64
macOS
Windows

rpr build fails because it requires a new release to rcutils for the fault injection macros, but the CI builds all pass so this should be good.

rpr build fails because it requires a new release to rcutils for the fault injection macros, but the CI builds all pass so this should be good.

Why not first release rcutils and once retriggered CI passes merge?

That's reasonable. It will be my first release, so I was just unsure about the whole process. I'll work to figure it out.


Add support for exit_group syscall

Part of #34

How do I approve this? I understand the code change now and it is legit.


⚠ Samsung has degraded performance

In f287632, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2448 ms

Resolved: Samsung performance has improved in 5a3a622.


Refactor save method in PersistedRequests

Details

This PR fixes storing duplicated data in PersistedRequests array. This solution based on adding idempotencyKey param to OnyxData type. There cannot be two requests with the same idempotencyKey in the PersistedRequests array.
cc @roryabraham

After fix in PersistedRequests.ts file.

https://github.com/Expensify/App/assets/47774969/65f69c13-c248-4adc-ae9c-491d8c8cb579

Fixed Issues

$ https://github.com/Expensify/App/issues/28172
PROPOSAL:
$ https://github.com/Expensify/App/issues/28172#issuecomment-1771445491
Tests

Turn on offline mode in your browser or device.
Switch between the same chats.
Turn on online mode.
Check if the same requests are not sent multiple times.

[x] Verify that no errors appear in the JS console

Offline tests

Turn on offline mode in your browser or device.
Switch between the same chats.
Turn on online mode.
Check if the same requests are not sent multiple times.

QA Steps

Turn on offline mode in your browser or device.
Switch between the same chats.
Turn on online mode.
Check if the same requests are not sent multiple times.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/47774969/c7a8cd47-e521-437a-a69b-77063730a6a1

Android: mWeb Chrome

https://github.com/Expensify/App/assets/47774969/a1243eee-094d-4a91-a4d5-f4b47e9d72c4

iOS: Native
https://github.com/Expensify/App/assets/47774969/3d86592a-0118-4ac6-86fe-2ae1175928ad

iOS: mWeb Safari

https://github.com/Expensify/App/assets/47774969/6ac46379-d1ed-4696-838d-3e42ac69faa1

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/47774969/1f23f10d-5889-419d-af3e-fbc023318bc9

MacOS: Desktop
https://github.com/Expensify/App/assets/47774969/d370716a-b73b-44bf-bec6-58ae5b5e32e6

I have read the CLA Document and I hereby sign the CLA

recheck

Reviewing

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/59907218/1d2a8b3a-4406-4a69-b834-207930815b94

Android: mWeb Chrome

iOS: Native
https://github.com/Expensify/App/assets/59907218/47b7f0f7-4c6e-4303-9176-9d4d805d5b07

iOS: mWeb Safari
https://github.com/Expensify/App/assets/59907218/f77d49c9-0149-4798-baa8-4b2a8998d233

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/59907218/399d2f94-ea70-4d36-9c36-e337716bdf21

MacOS: Desktop
https://github.com/Expensify/App/assets/59907218/b315d968-b39f-43d4-be62-7d46bfa07194

Also, let's plan on adding some basic unit tests to cover this change before merging

@roryabraham I've added some adjustments according to your suggestions. Additionally I've written some basic tests to check if behaviour of PersistedRequests save method is proper. I have one question about merging data from requests. What should be the result of this test:
const request: Request = {
    command: 'OpenReport',
    data: {
        idempotencyKey: 'OpenReport_1',
    },
    successData: [{key: 'reportMetadata_1', onyxMethod: 'merge', value: {}}],
    failureData: [{key: 'reportMetadata_2', onyxMethod: 'merge', value: {}}],
};

beforeEach(() => {
    PersistedRequests.clear();
    PersistedRequests.save(request);
});

afterEach(() => {
    PersistedRequests.clear();
});

it('merge a new request with one existing in PersistedRequests array', () => {
        const newRequest: Request = {
            command: 'OpenReport',
            data: {
                idempotencyKey: 'OpenReport_1',
            },
            successData: [{key: 'reportMetadata_3', onyxMethod: 'merge', value: {}}],
            failureData: [{key: 'reportMetadata_4', onyxMethod: 'merge', value: {}}],
        };

        PersistedRequests.save(newRequest);

        const persistedRequests = PersistedRequests.getAll();

        expect(persistedRequests.length).toBe(1);

        const mergedRequest = persistedRequests[0];

        expect(mergedRequest.successData?.length).toBe(2);
        expect(mergedRequest.failureData?.length).toBe(2);
    });

If we use the lodashMerge function then length of both arrays inside the mergedRequest object will be equal to 1. Is it expected behaviour of merging requests? I created method mergeOnyxUpdateData, because I thought that it should work in the way presented above in the test. This method merges data of arrays: successData, failureData and optimisticData by key property of the elements in arrays. If it shouldn't work this way and we can use only lodashMerge to merge this requests I will fix the tests and remove unnecessary code.

Brought this up in slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1699039930496579
Seems like there's general consensus that this isn't a bad idea, so that's good

I refactored createUpdatedRequest method. I did it without using lodashMergeWith function because in that implementation objValue and srcValue have types any. Currently it works but we should be aware that now we can store duplicates in failureData, successData and optimisticData arrays.

@alitoshmatov can you please re-review and re-test?

Reviewing

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).

[x] I verified the correct issue is linked in the ### Fixed Issues section above

[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms

[x] I included screenshots or videos for tests on all platforms

[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack

[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers

[x] I verified that this PR follows the guidelines as stated in the Review Guidelines

[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)

[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)

[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such

[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)

[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.

[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
N/a

Android: mWeb Chrome

N/a

iOS: Native

N/a

iOS: mWeb Safari
N/a

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/59907218/e55a6fa5-bd79-4bb5-8a2b-73d6bea23bbb

MacOS: Desktop
https://github.com/Expensify/App/assets/59907218/bf111f97-f992-42b1-bb34-1c7baf7a5742

Nice and simple where we landed

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.2-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@roryabraham The issue connected with this PR is mentioned above. I've checked it and previously in the save method in PersistedRequests we used a copy of persistedRequests. Now we modify this array directly in the function and save to the Onyx. I think that this issue can be fixed by using a copy of persistedRequests inside the save function.
diff --git a/src/libs/actions/PersistedRequests.ts b/src/libs/actions/PersistedRequests.ts
index c788d69de7..bf98c19a5e 100644
--- a/src/libs/actions/PersistedRequests.ts
+++ b/src/libs/actions/PersistedRequests.ts
@@ -18,16 +18,18 @@ function clear() {
 }

 function save(requestToPersist: Request) {
+    const requests = [...persistedRequests]
     // Check for a request w/ matching idempotencyKey in the queue
-    const existingRequestIndex = persistedRequests.findIndex((request) => request.data?.idempotencyKey && request.data?.idempotencyKey === requestToPersist.data?.idempotencyKey);
+    const existingRequestIndex = requests.findIndex((request) => request.data?.idempotencyKey && request.data?.idempotencyKey === requestToPersist.data?.idempotencyKey);
     if (existingRequestIndex > -1) {
         // Merge the new request into the existing one, keeping its place in the queue
-        persistedRequests.splice(existingRequestIndex, 1, requestToPersist);
+        requests.splice(existingRequestIndex, 1, requestToPersist);
     } else {
         // If not, push the new request to the end of the queue
-        persistedRequests.push(requestToPersist);
+        requests.push(requestToPersist);
     }
-    Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, persistedRequests);
+    persistedRequests = requests
+    Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, requests);
 }

@WojtekBoman I tried your solution above but I get the following error in the CloseAccount command:
Your session has expired. Please sign in again.

I'm reverting this PR since it introduced this blocker and other issues https://github.com/Expensify/App/issues/31733

@luacmartins

@WojtekBoman I tried your solution above but I get the following error in the CloseAccount command:
Your session has expired. Please sign in again.

Could you please give me the steps to reproduce? I tried to reproduce it but I didn't get this error
https://github.com/Expensify/App/assets/47774969/c6f545f2-547e-4937-84f5-95e5bc9aa5b9

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.2-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

I think that this issue can be fixed by using a copy of persistedRequests inside the save function.

Sounds good 👍🏼

Could you please give me the steps to reproduce? I tried to reproduce it but I didn't get this error

I'm not sure if there are any other steps other than just log in and log out with the account. That's all I did to reproduce that issue. I can test again once the new PR is up and see if I still have the issue.


Plugin doesn't return the MAC address

See https://github.com/docker/libnetwork/issues/605#issuecomment-152034903

Fixed by #26


fix #263

To get around #263, the py-cpuinfo package is used.

Thanks!
I've changed the behavior to use the old method first and only fallback to py-cpuinfo, because the latter takes about one full second to collect the information. And I don't like adding this much startup overhead by default.

Sounds great. Thanks for using the code, the encouragement to start, and the tox debugging help.


Update Compute spec to 2016-03-30

Hi @jianghaolu, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;


fix(highlights): missing highlights when accessing static methods and referencing methods

Fix #94
Checklist:

[ ] All tests pass in CI.
[ ] There are sufficient tests for the new fix/feature.
[x] Grammar rules have not been renamed unless absolutely necessary.
[x] The conflicts section hasn't grown too much.
[x] The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

@p00f Please check this out.

@dcreager @rewinfrey @patrickt Is there any chance that any of you folks at GitHub could look into why GitHub actions doesn't seem to reliably run for this repository? I wonder if it's a bug in Actions, or if we just don't have it set up  properly. It looks to me like the actions workflow is configured properly, but we just never get a status report back for any PRs, so it's hard to merge PRs confidently.

Apologies for the bump on this PR @maxbrunsfeld and @captainko,  but pulling in the updates to the workflow file appears to have kicked off CI.
@maxbrunsfeld in case you continue seeing this in future PR's,  please feel free to ping us! 🙇♂

Thanks so much for getting that working @rewinfrey ❤.

Thanks for the PR @captainko.


Custom testpypi version creation script

Proposed changes
The test.pypi.org uploader workflow needed a custom version to function properly. This PR adds that custom post-release version.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Functionality update (non-breaking change which updates or changes existing functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)
[ ] Documentation update (an update to enhance the user experience when reading through the docs)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have followed the guidelines in the CONTRIBUTING document
[x] I have signed the CLA
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change
[x] I have performed a self-review of my code
[x] My code follows the style guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[x] Basic linting passes locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have added necessary documentation (if appropriate)
[x] I have updated the Changelog with a brief description of my changes

See https://github.com/tektronix/tm_devices/actions/runs/6428687958/job/17456310320 for a successful deployment using the updated workflow.


[FEATURE]: Video Background

Is your feature request related to a problem?
No
Description
it would be nice if I had the option to use a video file as a background instead of the background images. incl. uploading videos.
Describe the solution you'd like
in admin backend a switch to select if video or still image as background.
in admin backend a possibility to upload videofiles .mp4 up to 4K
Describe alternatives you've considered
Alternatively the possibility to set a livestream (youtube) as background.
Additional context
No response

Oh. I would love that feature!


[Existing API Name] : combing both geolocation api and nominatim api

Brief Description 🤓
the Geolocation API to determine the user's current location accurately, With the help of the Nominatim API, the application identifies the user's location and retrieves detailed information such as the city, landmarks, and historical context associated with that location.
Provide reference!
https://developer.mozilla.org/en-US/docs/Web/API/Geolocation_API
https://nominatim.org/
Select the open source program you are contributing to
Other
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINES of this project.

Greetings @Rohitha-pudu🎀 ! , We are excited to have you dive into another issue with us!🚀
Your involvement in our project has been invaluable, and we're confident that your skills and insights will help us conquer this challenge😇.  Use command /gssoc24 to self assign the issue.  This issue represents an exciting opportunity for us to improve and enhance our project, and we are thrilled to have you on board.
We request you to follow CONTRIBUTING GUIDELINES.
Looking for your PR soon!
In case of any issues, you can contact us on Discord.❣

/gssoc24

Hey @Rohitha-pudu ! I wanted to inform you that we have closed issue.Thank you for your understanding, and we look forward to your continued engagement with our repository🤗.
In case of any issues, you can contact us on Discord.
Thank you! ❣
Happy Coding! ✨
Will See you soon❣

Hey @Rohitha-pudu ! I wanted to inform you that we have closed issue.Thank you for your understanding, and we look forward to your continued engagement with our repository🤗. In case of any issues, you can contact us on Discord. Thank you! ❣ Happy Coding! ✨ Will See you soon❣

may i know why it is closed> @dishamodi0910


Investigate: new info Auto-accumulator tail-recursive using Dafny 3

Using Dafny 3.0.0, a (new?) info has showed up:
"Auto-accumulator tail-recursive".
This is not an error or warning but may deserve some attention: how do we suppress this info from showing up, like induction info?
And example is the tail recursive function timeSeq in utils/Helpers.dfy:
 function method {:tailrecursion true} timeSeq<T>(t : T, k : nat) : seq<T>
        ensures |timeSeq(t,k)| == k
        ensures forall i :: 0 <= i < k ==> timeSeq(t,k)[i] == t
        decreases k
    {
        if k == 0 then []
        else [t] + timeSeq(t, k - 1)
    }

Even with {:tailrecursion true} attribute the info appears using Dafny 3.

This seems to be a duplicate of https://github.com/dafny-lang/dafny/pull/1415#issuecomment-918237133 which should be resolved in the upcoming Dafny release.

@keyboardDrummer Thanks a lot for the update. Looking forward to the new release!

Will be fixed in next Dafny release so closing this issue.


Chef 12 'chef-server-ctl upgrade' fails on RHEL 5.11

Originally filed by @ve7cxz as https://github.com/chef/chef/issues/3072
====
I'm migrating from Chef 11 (11.1.3) to Chef 12 (12.0.5) on a RHEL 5.11 server, and running into an issue after running chef-server-ctl upgrade:-
- configure service runit_service[rabbitmq]
* link[/opt/opscode/service/rabbitmq] action create
  - create symlink at /opt/opscode/service/rabbitmq to /opt/opscode/sv/rabbitmq

At this point, it hangs. Running strace against the chef-client process shows it trying to stat /opt/opscode/service/rabbitmq/supervise/ok, which apparently doesn't exist:-
stat("/opt/opscode/service/rabbitmq/supervise/ok", 0x7fffa031f450) = -1 ENOENT (No such file or directory)

I'm assuming this part of the chef-server-ctl upgrade is supposed to create it, but for some reason it isn't. I've attempted the upgrade twice now, and both times it has failed at the same point.
Exiting out of the upgrade leaves Chef 12 in a bad state, and it appears to then be impossible to continue the upgrade:-
<...>
Creating /tmp/chef11-server-data20150312-21492-nblrd0 as the location to save the open source Chef 11 server data
Ensuring Chef 12 server is stopped
warning: rabbitmq: unable to open supervise/ok: file does not exist
Unable to stop the Chef 12 server, which is needed to complete the upgrade

The only way to get the upgrade process to work again is to uninstall the chef-server-core RPM and start again.

I actually managed to get this installed by starting /opt/opscode/embedded/bin/runsvdir-start from another terminal while chef-server-ctl upgrade is running. I'm still not sure why this doesn't happen automatically, though.

@ve7cxz I'll try to look into this when I get a chance. Glad you got it working. I wanted to note that the references to private-chef-ctl are okay (you brought this up in the original issue before it was moved here). That is because the enterprise server and open source server merged and now there is only one server and it is completely open source. This new code though is based off the enterprise code base (although the old enterprise and open source code bases did share a lot of code). So the private-chef-ctl is just a naming reference that hasn't been cleaned up. chef-server-ctl and private-chef-ctl both run the same code under the hood - one is just a symlink to the other for now to ensure backwards compatibility.

@mmzyk cheers! I assumed the references were benign but I wanted to mention it just in case. It's an odd one because it looks like the runsvdir-start command gets added to /etc/inittab, but doesn't get started, which makes me wonder if the init reload to reread it never happens.

I'm going to close this for now.  We haven't been able to reproduce this in upgrade testing.  If someone sees a reproduction case of this issue we can happily reopen it.

I see this on ubuntu, I tried to upgrade but there were broken cookbooks so I remove (apt-get autoremove) the chef-server-core package and killed runsv processes.
Now when I am trying to upgrade I see the next:
dpkg -i chef-server-core_12.8.0-1_amd64.deb
(Reading database ... 132335 files and directories currently installed.)
Preparing to replace chef-server-core 12.8.0-1 (using chef-server-core_12.8.0-1_amd64.deb) ...
Unpacking replacement chef-server-core ...
Setting up chef-server-core (12.8.0-1) ...

But nothing started. Then I start upgrade and it raises this exactly error. It seems I need to cleanup somewhere, but I have no Idea where, the installed doesn't suggest anything.
P.S. Upgrade process is terrible, it raises errors on each cookbook, you have to fix it and go through the entire process again and again. Spent the whole day and ended up with this error.


Uncorrect output testing on linux

Hello @bitbank2 ,
I've tested your code with a sample QVGA bmp that I attach here and I have a corrupted output. I'm chasing the bug in case you have any suggestion that's welcome!
test_png.zip
Thanks,

Thanks for finding the 2 issues. I combined them into a single commit that I pushed.


Add new precision time function

What does this PR do?
With the merge of #8837 there were now three different checks using the same code block to get precision time measurements.  This PR factors them out into the base check.
This PR covers datadog_checks_base, changes to the other checks will be covered separately.
Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

ActiveMQ failure covered by #8839


Matplotlib could support more legend_position values

In the bokeh backend you have the possible legend_position values of "top_right", "top_left", "bottom_left" and "bottom_right". These options could also be supported by matplotlib but are currently not implemented.

Added them in the commit referenced above. Closing.


Unstated light dependencies

I'm counting xfce4-battery-plugin, networkmanager, nm-applet, clipit, i3exit....

Yeah, but those will not cause i3wm to crash if they are not installed. I could add them as dependencies in the README.md and in the script later, but I'm not that sure if it's worth the extra big README.md at this time.
I think a good thing would be to add a new bash script with the 'extras' for people to run to get those.

please, add.. same goes for the script (i3-exit) used to suspend/shutdown/restart etc actions.
Either include it in the repo or provide a link to it, please


Setting Correct Timezone on New Machine

Is there any way to set the timezone for the new machine that's being built from the config.yml file? It looks like mine was set to UTC by default.

I don't have the geerlingguy.ntp role added to Drupal VM at this time, so the default remains UTC... however, you could add a script or Ansible task file that updates the timezone like so: https://github.com/geerlingguy/ansible-role-ntp/blob/master/tasks/main.yml#L5-L10
See this doc for help adding scripts or task files to run pre/post provisioning: http://docs.drupalvm.com/en/latest/extras/scripts/

I'm still having issues with this on my VM. Every day I log into it the timezone is way off. Not sure what's going on. I've tried installing NTP using apt-get install ntp but today it says "Wed Jul 20 18:27:41 EDT 2016". It's currently "Wed Jul 20 10:26:41 EDT 2016". I'm not sure why it keeps changing the time after I manually correct it. Any ideas?

The main reason it's a problem for me is that one of my primary sites handshakes with an API and has to send a timestamp. If the timestamp is off by more than a few minutes all of the API calls fail.

I'm going to try adding the "virtualbox-guest-additions-iso" package to see if this helps at all.

@attheshow - The guest additions should already be installed and running.
I'm wondering if there's some other timezone or networking issue on your local machine—I've just checked on two of my Macs, and with Ubuntu 14 and 16, and otherwise default configs, all the times are correct and in sync (I just leave all the VMs default to UTC, and in PHP I set a site timezone as needed).

The time in my VMs is not sync too. I noticed that it happens every time after I leave the VM running and close its lid before sleep.

See https://github.com/geerlingguy/drupal-vm/issues/1097

Thanks @oxyc. I believe following https://github.com/geerlingguy/drupal-vm/issues/1097#issuecomment-271213478 has solved the issue for me.


Fix Godot-2.1 build error on VS2013, wrong way to call pow() function - issue #18556

Fix Godot-2.1 build error on VS2013
Fixes this issue: https://github.com/godotengine/godot/issues/18556
https://github.com/godotengine/godot/blob/2.1/editor/script_editor_debugger.cpp
https://github.com/godotengine/godot/blob/2.1/core/script_debugger_remote.cpp
pow(2, 20)
To fix this build error on Visual Studio 2013, calling pow() should be:
pow(2.0, 20.0)

Issue description:
Build failure on Visual Studio 2013 because of calling pow() with integer (without type casting).
Steps to reproduce:

Build "Godot-2.1 (branch) or Godot-2.1.4 (stable)" with Visual Studio 2013 + Python 2.7 + scons
scons platform=windows vsproj=yes
This will throw error:

editor\script_editor_debugger.cpp(1736) : error C2668: 'pow' : ambiguous call to overloaded function
        D:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\INCLUDE\math.h(1233): could be 'long double pow(long double,int) throw()'
        D:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\INCLUDE\math.h(1231): or       'long double pow(long double,long double) throw()'
        D:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\INCLUDE\math.h(1117): or       'float pow(float,int) throw()'
        D:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\INCLUDE\math.h(1115): or       'float pow(float,float) throw()'
        D:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\INCLUDE\math.h(1027): or       'double pow(double,int) throw()'
        D:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\INCLUDE\math.h(512): or       'double pow(double,double)'
        while trying to match the argument list '(int, int)'
editor\script_editor_debugger.cpp(1736) : error C2143: syntax error : missing ')' before ';'
scons: *** [editor\script_editor_debugger.windows.tools.32.obj] Error 2
scons: building terminated because of errors.

As I mentioned on https://github.com/godotengine/godot/issues/18556#issuecomment-385918886, I don't think that's the proper fix.

Yes that sounds good, thanks. Could you also squash the commits together when doing the change? See PR workflow.

OK


listener broken with iOS 8

The view gets resized wrong in iOS 8.

So I'm guessing it has been 64-bitted... I've done many solutions myself to mimic iMessage... Was hoping if this module works with Ti SDK 3.5.1+ ?


Updated CocoaPods

Update to version 1.2.0

Codecov Report

Merging #101 into master will decrease coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   74.83%   74.49%   -0.34%
==========================================
  Files          33       33
  Lines        1498     1498
==========================================
- Hits         1121     1116       -5
- Misses        377      382       +5

Impacted Files
Coverage Δ

MyWeight/Services/MassService.swift
47.05% <0%> (-4.21%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac47b67...2f47a67. Read the comment docs.


Add scaledJob related metrics document

Add scaledJob related metrics
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)

Relates to https://github.com/kedacore/keda/issues/4798
Relates to https://github.com/kedacore/keda/pull/4913

@yoongon just checking, is this up-to-date with all the changes you did on the main PR?


Remove Scribe support?

Is Scribe support something that should still be in the code? It forces dependencies (including binary ones), reduce the capacity to run on non x86 machines (at least the way it is currently done) and doesn't seem to build on recent systems anyway (external report I got from a friend, didn't check that myself).

@bjonnh - it is currently used only at Twitter for collecting metrics - we could potentially - make it a conditional compilation.

@maosongfu @nwangtw @huijunw - thoughts?

@bjonnh - wondering what is the CPU values that you give when you compile heron?

@bjonnh - here is the PR to fix the issue -
https://github.com/twitter/heron/pull/2801

@kramasamy  I tried single-job and multi-job to rule that out. No change (just really really hard to find where the error was with multiple jobs).
Thanks for the PR!

@bjonnh - the PR that I put out is pretty straight forward - if you can verify if it is able to compile using the branch - it will be great!

Still fails. Again, I am on x86…
/bin/mkdir -p '/root/.cache/bazel/_bazel_root/b8d5998435f0e9226488fd32fcb079f8/execroot/main/bazel-out/k8-fastbuild/genfiles/third_party/zookeeper/bin'
/bin/bash ./libtool   --mode=install /usr/bin/install -c cli_st cli_mt load_gen '/root/.cache/bazel/_bazel_root/b8d5998435f0e9226488fd32fcb079f8/execroot/main/bazel-out/k8-fastbuild/genfiles/third_party/zookeeper/bin'
libtool: install: /usr/bin/install -c cli_st /root/.cache/bazel/_bazel_root/b8d5998435f0e9226488fd32fcb079f8/execroot/main/bazel-out/k8-fastbuild/genfiles/third_party/zookeeper/bin/cli_st
libtool: install: /usr/bin/install -c cli_mt /root/.cache/bazel/_bazel_root/b8d5998435f0e9226488fd32fcb079f8/execroot/main/bazel-out/k8-fastbuild/genfiles/third_party/zookeeper/bin/cli_mt
libtool: install: /usr/bin/install -c load_gen /root/.cache/bazel/_bazel_root/b8d5998435f0e9226488fd32fcb079f8/execroot/main/bazel-out/k8-fastbuild/genfiles/third_party/zookeeper/bin/load_gen
/bin/mkdir -p '/root/.cache/bazel/_bazel_root/b8d5998435f0e9226488fd32fcb079f8/execroot/main/bazel-out/k8-fastbuild/genfiles/third_party/zookeeper/include/zookeeper'
/usr/bin/install -c -m 644 include/zookeeper.h include/zookeeper_version.h include/zookeeper_log.h include/proto.h include/recordio.h generated/zookeeper.jute.h '/root/.cache/bazel/_bazel_root/b8d5998435f0e9226488fd32fcb079f8/execroot/main/bazel-out/k8-fastbuild/genfiles/third_party/zookeeper/include/zookeeper'
make[1]: Leaving directory '/tmp/zookeeper.Uy8RA/zookeeper-3.4.10/src/c'
ar: u' modifier ignored since D' is the default (see U') ar: u' modifier ignored since D' is the default (see U')
ar: u' modifier ignored since D' is the default (see U') ar: u' modifier ignored since D' is the default (see U')
ar: u' modifier ignored since D' is the default (see `U')
ERROR: /root/heron/heron/metricsmgr/src/thrift/BUILD:3:1: error executing shell command: 'set -e
rm -rf bazel-out/k8-fastbuild/genfiles/heron/metricsmgr/src/thrift/thrift_scribe_java_src.srcjar.srcs
mkdir bazel-out/k8-fastbuild/genfiles/heron/metricsmgr/src/thrift/thrift_scribe_java_src...' failed (Segmentation fault): bash failed: error executing command /bin/bash -c ... (remaining 1 argument(s) skipped)
/bin/bash: line 3: 26022 Segmentation fault      third_party/thrift/thrift-linux-x86_64.exe -r --gen java -o bazel-out/k8-fastbuild/genfiles/heron/metricsmgr/src/thrift/thrift_scribe_java_src.srcjar.srcs heron/metricsmgr/src/thrift/scribe.thrift
INFO: Elapsed time: 46.282s, Critical Path: 40.93s
FAILED: Build did NOT complete successfully
the problem is " third_party/thrift/thrift-linux-x86_64.exe" that segfaults on my machine (even when running it manually).

@bjonnh - can you describe your environment? Machine CPU, operating system and version of the operating system.

It seems the PR that I put out has passed compilation, unit tests and most of the integration tests in Mac OS X, Ubuntu and Debian.

Intel(R) Xeon(R) CPU           X5675  @ 3.07GHz 20 cores * 2
Debian Testing - in Xen
I've never had anything segfault before on that VM nor on its clone.
if that may help, gdb trace:
(gdb) run
Program received signal SIGSEGV, Segmentation fault.
0xffffffffff600400 in ?? ()
(gdb) where
#0  0xffffffffff600400 in ?? ()
#1  0x00000000005df87d in ?? ()
#2  0x00000000004178a3 in ?? ()
#3  0x00000000005a8440 in ?? ()
#4  0x00000000004001b9 in ?? ()
#5  0x00007fffffffebc8 in ?? ()
#6  0x0000000000000000 in ?? ()
I tried in an ubuntu docker (to have a different glibc) same problem.
Maybe it is an issue of that static build with the kernel I am using.
I think I'll just comment out the build of scribe for now. But we may want to keep that as a reference somewhere if anybody else struggle with that.
Thanks.

@bjonnh - can you try this with 0.17.8 and see if this works?

Tried with latest master:
bazel build --config=ubuntu heron/...
INFO: Analysed 574 targets (288 packages loaded).
INFO: Found 574 targets...
ERROR: /root/heron/heron/heron/metricsmgr/src/thrift/BUILD:3:1: error executing shell command: 'set -e
rm -rf bazel-out/k8-fastbuild/genfiles/heron/metricsmgr/src/thrift/thrift_scribe_java_src.srcjar.srcs
mkdir bazel-out/k8-fastbuild/genfiles/heron/metricsmgr/src/thrift/thrift_scribe_java_src...' failed (Segmentation fault): bash failed: error executing command /bin/bash -c ... (remaining 1 argument(s) skipped)
/bin/bash: line 3:  5879 Segmentation fault      third_party/thrift/thrift-linux-x86_64.exe -r --gen java -o bazel-out/k8-fastbuild/genfiles/heron/metricsmgr/src/thrift/thrift_scribe_java_src.srcjar.srcs heron/metricsmgr/src/thrift/scribe.thrift
INFO: Elapsed time: 44.657s, Critical Path: 11.12s
FAILED: Build did NOT complete successfully
I'm going to change the OS on that machine anyway, will see if it still fails.


Dev

564;

Hi @kylehendricks, @MartinHjelmare,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!


setup instructions

Hello, I've not quite been able to get past step 2. I keep getting
"Traceback (most recent call last):
File "run.py", line 6, in
import _jsonnet
ModuleNotFoundError: No module named '_jsonnet'"
All the solutions I found online didn't work for me. Any help will be appreciated.

Hi @Ebipatei
Have you tried the solution provided here?
https://github.com/allenai/allennlp/issues/1969#issuecomment-565742519

Hi @Ebipatei
Have you tried the solution provided here?
https://github.com/allenai/allennlp/issues/1969#issuecomment-565742519


Fix testing of clang-format and omni-xmod-pool

launch jenkins clang-format omni-xmod-pool

:green_circle: tsa/integration_test/spack_info_omni-xmod-pool.log
:green_circle: tsa/integration_test/spack_spec_omni-xmod-pool.log
:green_circle<EMAIL_ADDRESS>:green_circle: tsa/unit_test/summary.log

:green_circle: daint/integration_test/spack_info_omni-xmod-pool.log
:green_circle: daint/integration_test/spack_spec_omni-xmod-pool.log
:green_circle<EMAIL_ADDRESS>:green_circle: daint/unit_test/summary.log

Maybe if we replace --until build with --before install we have a solution that works with every package.

Maybe if we replace --until build with --before install we have a solution that works with every package.

spack install only support --until, but not --before.

launch jenkins clang-format omni-xmod-pool

:green_circle: tsa/integration_test/spack_info_clang-format.log
:green_circle: tsa/integration_test/spack_info_omni-xmod-pool.log
:green_circle: tsa/integration_test/spack_spec_clang-format.log
:green_circle: tsa/integration_test/spack_spec_omni-xmod-pool.log
:green_circle<EMAIL_ADDRESS>:green_circle: tsa/unit_test/summary.log

:green_circle: daint/integration_test/spack_info_clang-format.log
:green_circle: daint/integration_test/spack_info_omni-xmod-pool.log
:green_circle: daint/integration_test/spack_spec_clang-format.log
:green_circle: daint/integration_test/spack_spec_omni-xmod-pool.log
:green_circle<EMAIL_ADDRESS>:green_circle: daint/unit_test/summary.log

:green_circle: balfrin/integration_test/spack_info_clang-format.log
:green_circle: balfrin/integration_test/spack_info_omni-xmod-pool.log
:green_circle: balfrin/integration_test/spack_spec_clang-format.log
:green_circle: balfrin/integration_test/spack_spec_omni-xmod-pool.log
:green_circle<EMAIL_ADDRESS>:green_circle: balfrin/unit_test/summary.log

Maybe if we replace --until build with --before install we have a solution that works with every package.

spack install only support --until, but not --before.

True, it's only a dev-build option :-(


Use Public Image Instead of Building One

If a project publishes a public container image then maybe the button should allow the skipping the build and just using the existing image.  Via app.json like:
{
    "build": {
        "skip": false
    },
    "override": {
        "image": "gcr.io/cloudrun/hello"
    }
}

Not sure if this is a good idea or not.

This basically makes the project an alternative to deploying directly from Cloud Run console. Similarly, broadens the focus from "deploy repos" to "deploy images or repos".

Yeah, maybe if https://console.cloud.google.com/run/create had a way to specify some default params (image, service name, allow-unauthenticated, etc) then that'd be a better way to go.  Still would be missing env var handling though.


doc about findFiles in vscode-api

below code come from vscode
findFiles('**∕*.js', '**∕node_modules∕**', 10)

when i copy the example code from vscode,
it can work fine before  1.18.0, but after 1.18.0, it can't work.
Actually i find that the backslash (  ∕  ) in the code is so strange, it should be ( / ).
Can you fix the mistake?

What do you mean, it doesn't work? Please include more details.

@roblourens I just mean the document of vscode api should not use wrong backslash ( ∕ )  should use ( / ).
Ther findFiles api can't work after 1.18.0 when using wrong backslash ( ∕ )

Oh I see, it is using a fancy slash character. @octref Do you know why that is? Copy/paste of that code snippet doesn't work.

@jrieken I found https://github.com/Microsoft/vscode/issues/891 and https://github.com/Microsoft/vscode/commit/dd4f269d15006f0b696ef07d2f0114239065fc22
Which way should I go forward? I can introduce a build step that manually changes the magical slash to normal slash in website. But is there anyway in JSDoc to fix it?

But is there anyway in JSDoc to fix it?

That's the question... I have used a weird unicode character because glob-patterns in comments tend to end the comment... I could use backslashes instead of that character but I am unsure how we handle backslashes in glob-patterns...

I would rather encourage people to use forward slash, which looks better and is less-likely to break cross-platform. Especially given https://github.com/Microsoft/vscode/issues/32533
Can we fix it on the website's end then?

I would rather encourage people to use forward slash

Agreed. Problem is in JSDoc this would break syntax-highlight (same for GitHub).
/**
 * findFiles('**/*.js', '**/node_modules/**', 10)
 */

So there are two solutions:

@mjbvz Is it possible to fix this in JSDoc grammar so it's possible to use **/ in JSDoc?
Go back to use the special unicode in vscode.d.ts, and I can look for it and do a global replace in website build.

I don't think we can fix it with the grammar, if you write that then it's simply not valid TS/JS. Let's use the special character and fix it for the website.

Yes, this is part of the ecmascript spec. We cannot change it.
I thought you could escape this as *\/ but that doesn't work either.

@jrieken Do you mind reverting the changes then? I'll look for the special char and replace it wish slash in website build scripts.

I'll look for the special char and replace it wish slash in website build scripts.

Well, that will only help the website not with the doc hover and other in-tool-experiences... I still think backslash is fair. @roblourens Is there a way for you to fix escape characters?

To fix backslashes or special slash characters?

backslashes

I guess so. The comment will have to have a double backslash though. It's annoying that we have to work around it like this just because it's encoded in a block comment, but I can't think of a better solution.

I don't think other things (glob.ts?) handle backslashes cross-platform yet. Easy test, on mac, change the build/**/*.js rule to use backslashes.

Then the build/lib/*.js files show up in the file explorer.

Hm, create a folder with backslashes in it's name? It being filtered would be the correct behaviour which also means we treat a backslash like a name-character (not separator) on these platforms...

@jrieken it is not valid to have backslash in glob patterns but for the target paths that we match on it can either be backslash or slash, we normalize it.

@jrieken it is not valid to have backslash in glob patterns

Really, but it's valid to have backslashes in filenames

@jrieken at least the node-glob library calls out to this issue (https://github.com/isaacs/node-glob#windows) and others (https://www.tcl.tk/man/tcl/TclCmd/glob.htm) also seem to remind people to not use backslashes. I think the \ has special meaning in some glob implementations that it would escape the special characters like "*" or "?".
Interestingly this page (https://en.wikipedia.org/wiki/Glob_(programming)) reads:

In all cases the path separator character (/ on Unix or \ on Windows) will never be matched.

But I am not sure that is true for most implementations.

I now use *\u200b/ (zero width space) to break the */ sequence. Still not copy-paste-able but it looks nicer and more correct

This will be deployed to the website in our next release.


Datasets: Datasets from Wei2022 repository (aqua, asdiv, commonsenseqa, date_understanding, gsm, mapwps sports_understanding, strategy_qa, svamp)

Observations for asdiv :

[ ] The formatting of the question text could be improved through post-processing (there are many superfluous spaces; capitalization). I guess this was carried over from the source?
[ ] For CoTs with a single line, the "First, [...] prefix could be removed.

Observations for asdiv :

[ ] The formatting of the question text could be improved through post-processing (there are many superfluous spaces; capitalization). I guess this was carried over from the source?
[ ] For CoTs with a single line, the "First, [...] prefix could be removed.

I think we should have "natural" text, each NLP model will potentially have different in-built tokenizers and we should not present pre-tokenized input to models. Models were pre-trained on natural/unprocessed text, so the inputs should closely resemble that.


Linux: Unable to access .scm.azurewebsites.net, Service Unavailable

I have 7 web apps connected to a service plan. Only 2 of them are able to access their scm.azurewebsites.net sites. The rest give Service Unavailable. They all use very similar settings, as they were deployed through a copy loop using the ARM template.

Are they sites where this has ever worked, or was it broken from creation time? What's one of the broken site names?

The apps are docker containers and they run fine. I'm just unable to access kudu. they were just deployed an hour ago. Right now I'm getting these 2 errors:

All of them just suddenly went back online now. Very strange.

Adding @rramachand21 since this is Linux.

The same happened to me. I also deleted and redeployed apps with the same name multiple times.

@ElanHasson  Could you provide more details on how you are creating the app? Looks like you are trying to create Linux Function App with AppService plan. Is that correct?
Also are you using an existing app service plan?

@balag0, I've opened a support case with Azure support and can provide it and other details to you via email.
You're correct, Linux function app and a new app plan.
I created via azure portal UI and via Visual Studio publish feature to the same end result.

Okay. Thanks. We will follow up with you using the support case and we will close this issue for now.

@balag0 I just got an email from them and they told me to log an issue here: https://github.com/Azure/azure-functions-core-tools/issues/ as it's in preview still.

Okay. I will follow up there since the issue is likely unrelated to kudu. Thanks

I have the issue with kudu not loading (service unavailable) and my specific case is with a vnet integrated function-app. I cannot deploy the function after vnet integration (timesout after a whopping 43 minutes of Microsoftiness and gives 503 error) and I cannot even look at kudu logs because it is not working. Microsoft should focus on getting some things right instead of making the products extremely complex and they cannot handle it.

Please open an App Service support ticket instead.

opened

I have the same issue, SCM shows "Service Unavailable" , other function in the same function plan is working just fine (with the same exact configuration/location, just different resource groups)


Css is ignored

Hi,
How do I make dompdf to see my css files?
Here is how I load css files
<head>
    <!-- Web Fonts  -->
    <link href="https://fonts.googleapis.com/css?family=Open+Sans:300,400,600,700,800" rel="stylesheet" type="text/css">

    <!-- Vendor CSS -->
    <link rel="stylesheet" href="{{ absolute_url(asset('build/admin/vendor/bootstrap/css/bootstrap.min.css')) }}" />

    <!-- Invoice Print Style -->
    <link rel="stylesheet" href="{{ absolute_url(asset('build/admin/css/invoice-print.css')) }}" />
</head>

And output is just white html page with css.

You should ask the question at https://github.com/dompdf/dompdf


Symbolic Objects for Local and Remote entanglement generation processes

May we reorganize things a bit. Could you make two folders inside of the newly created StatesZoo folder, one for each of the two new objects. And then keep the matlab code for each in the corresponding folder. Let's also have a name that describes a bit more the "why" not the "what".

something like
StatesZoo
- cascaded_source
-- precursor_code (that contains a readme explaining what was done to the code)
- entanglement_swap
-- precursor_code (again with explanation of what was done to it)

Keep in mind that these two things are very different types of processes and states, they should not be lumped together.
Also, keep the express statements local, do not put them in a completely different file.

We need to figure out how to name these objects.
For the cascaded source, Saikat and Dirk refer to it as "ZALM source" for Zero-added-noise Multiplexed. It comes from https://arxiv.org/abs/2206.03670 and https://arxiv.org/abs/2206.03670
So let's call the symbolic object ZALMpair and let's have it printed out as ρᶻᵃˡᵐ.
When you set up its doc string, please leave in [](@cite) references to these two papers. In terms of how to do the references, they need to be added as bibtex to the bibfile in the doc src folder. See for instance this pull request and the bibtex and docstrings in it https://github.com/QuantumSavory/QuantumSavory.jl/pull/37/files
The best way to get up-to-date bibtex references is from google scholar.

For the midswap folder, let's have two separate symbolic objects defined there. Maybe for names we can use DualRailMidSwapBell and SingleRailMidSwapBell. Not quite sure about the names, please feel free to suggest better ones. Not quite sure for their unicode/latex representation either. Maybe ρᵈʳᵐˢ and ρˢʳᵐˢ but again, please feel free suggesting something better.

In terms of how to do the symbolics, check out this file and how "SpecialKet" is done there https://github.com/QuantumSavory/QuantumSymbolics.jl/blob/main/src/QSymbolicsBase/predefined.jl
The issue is that we do not really have the same for density matrices. I think a good way to do this is to make abstract type AbstractTwoQubitState <: AbstractTwoQubitState end (that probably should be in QuantumSymbolics) and then make a struct ZALMPair <: AbstractTwoQubitState (in QuantumSavory).

The cascaded_source folder has two functions for generating density matrices, one in the spin-spin basis which outputs a 4x4 density matrix and another in fock basis which outputs a 36x36 matrix, currently I have implemented the symbolic object ρᶻᵃˡᵐ being expressed as the one in spin-spin basis. Let me know what we should name the other one, it would be a small change.
Also, in the above comment the part

I think a good way to do this is to make abstract type AbstractTwoQubitState <: AbstractTwoQubitState end

was not clear, so for now I did abstract type AbstractTwoQubitState <: AbstractTwoQubitOp end , let me know if you feel we should do it differently.
Then, I was not sure if we need the const cascaded_source_basis as a symbolic object, so its currently left as such, let me know what you think would be the best way to represent it.

could you add a few tests, something along the lines of:
reg = Register(2)
initialize!(reg[1:2], symbolicstate)
observable(reg[1:2], some_observable)

just to make sure that the API is not broken


chore: overlay style flexible

Description

overlay-style-flexible
Additional context

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

for different device size, like mobile , or ipad

Can you share the screenshot of how this would display in different screen sizes (desktop, mobile, ipad, etc) in the description?

actually, U can change the browser size/mode by device toolbar

@patak-dev could u plz review this

@patak-dev need review =_=


Added insert-tests for Microsoft SQL Server.

Please review pull request #218 first since it will make some of these tests fail
Right now we are throwing an exception for the RETURNING statement since it's not implemented in MS SQL the same way as PostgreSQL. In MS SQL it is the OUTPUT clause but it appears before the VALUES in the syntax. When I have some more time, I'll try to implement it correctly. But at least there are tests for all the INSERT statements that are currently supported.

So awesome! :smile: Merging now - thank you!


docs: Revamp how-to guides structure

Addressing Jira issue: https://warthogs.atlassian.net/browse/KF-5814

@kimwnasptd this is ready for review. Full details of the PR can be found in the Jira issue attached in the description. Note that "List DSS commands" section is not modified as I expect to move that information to the API Reference guide we plan to work on.

Note that "List DSS commands" section is not modified as I expect to move that information to the API Reference guide we plan to work on.

Actually, after having another look, the List DSS commands info belongs to the Manage DSS how-to page. Added the content there.

@kimwnasptd ready for another pass/approval!

@afgambin looks good! Let's rebase now that https://github.com/canonical/data-science-stack/pull/131 was merged and we are good to go


/api/protected/destinations/{id}

Show "Not Found" instead of specified destination

id is actually name

Solution is to fix the documentation for now, change from {id} to {name}

PR merged and close now


how to specify io.zeebe.monitor.connectionString via command line argument?

The readme says that args can be passed on the command line.
However --help doesn't return any help, its not clear how to specify the zeebe connection string.
can you please add an example to the readme?
Thank you

sorry, answering my own question.
You can pass configuration options via environment variables, like this:
$ docker run --rm -p 9080:8080 -it -e io.zeebe.monitor.connectionString=<IP_ADDRESS>:26500 camunda/zeebe-simple-monitor:0.15.0


Common interface for all g-function boundary conditions

With the multiplication of borehole boundary conditions, a centralize function would simplify the use of pygfunction.

Since a need for this feature was brought up in #56. There are a few issues that could be addressed here to make the g-function call future-proof.
Boundary conditions - Different boundary conditions require different inputs (e.g. The uniform inlet fluid temperature method requires a list of pipes in addition to the list of boreholes).
Solution algorithm - At the moment only the similarities method is available in addition to a detailed method. Other methods will surely be implemented at some point, especially if inclined boreholes or processes like groundwater are to be implemented.
The common interface could be inspired by https://docs.scipy.org/doc/scipy/reference/generated/scipy.optimize.minimize.html which also has the need for method-dependent inputs.

Since a need for this feature was brought up in #56. There are a few issues that could be addressed here to make the g-function call future-proof.
Boundary conditions - Different boundary conditions require different inputs (e.g. The uniform inlet fluid temperature method requires a list of pipes in addition to the list of boreholes).
Solution algorithm - At the moment only the similarities method is available in addition to a detailed method. Other methods will surely be implemented at some point, especially if inclined boreholes or processes like groundwater are to be implemented.
The common interface could be inspired by https://docs.scipy.org/doc/scipy/reference/generated/scipy.optimize.minimize.html which also has the need for method-dependent inputs.

As far as future proofing goes; it should be possible to query a function for its inputs. Since everything in Python is an object, the inputs to a function could be successively looped over and pulled from the common interface class (probably by use of getattr). Thus, the goal of the common interface could be that the only necessary modifications moving forward would be additional instances not already prescribed.

As far as future proofing goes; it should be possible to query a function for its inputs. Since everything in Python is an object, the inputs to a function could be successively looped over and pulled from the common interface class (probably by use of getattr). Thus, the goal of the common interface could be that the only necessary modifications moving forward would be additional instances not already prescribed.

I like your first draft of the common interface. I would suggest that __init__ keeps common parameters in addition to **kwargs (or an options dict). This helps for auto-completion. My proposal :
class gFunction(object):
    """
    Draft for gFunction class.

    Attributes
    ----------
    boreholes_or_network : list of Borehole objects or NEtwork object
        List of boreholes included in the bore field, or network of boreholes
        and pipes.
    alpha : float
        Soil thermal diffusivity (in m2/s).
    time : float or array, optional
        Values of time (in seconds) for which the g-function is evaluated. The
        g-function is only evaluated at initialization if a value is provided.
    method : str, optional
        Method for the evaluation of the g-function. Should be one of
            - 'similarities' : [...]
            - 'detailed' : [...]
        Default is 'similarities'.
    boundary_condition : str, optional
        Boundary condition for the evaluation of the g-function. Should be one
        of
            - 'UHTF' : Uniform heat transfer rate.
            - 'UBWT' : Uniform borehole wall temperature.
            - 'MIFT' : Mixed inlet fluid temperatures.
        If not given, chosen to be ''UBWT'' if a list of boreholes is provided
        or ''MIFT'' if a Network object is provided.
    options : dict, optional
        A dictionary of solver options. All methods accept the following
        generic options:
            nSegments : int, optional
                Number of line segments used per borehole.
                Default is 12.
            processes : int, optional
                Number of processors to use in calculations. If the value is
                set to None, a number of processors equal to cpu_count() is
                used.
                Default is None.
            disp : bool, optional
                Set to true to print progression messages.
                Default is False.
        For method-specific options, see [...]
        (method-specific options are the tolerances for the similarities
        method)

    """

    def __init__(self, boreholes_or_network, alpha, time=None,
                 method='similarities', boundary_condition=None, options=None):
        # Initialization of g-function parameters, calls
        # self._check_assertions():

        # If time is not None, calls self.evaluate_g_function(time)
        return True or gFunc

    def evaluate_g_function(self, time):
        # Calculates the g-function using the correct method and boundary
        # condition
        return gFunc

    def check_assertions(self):
        """
        This method ensures that the instances filled in the gFunction object are what is expected.
        Returns
        -------
        True
        """
        # [...]
        return True

This interface could easily deal with the different boundary conditions, using the flexible boreholes list or network object as the first parameter. For fluid temperature boundary conditions, m_flow, cp and borehole_connectivity would be required. The Network object can easily be modified to accept nominal values for the first two at initialization (borehole_connectivity is already required).
I would argue that the 'UIFT' boundary condition should be deprecated, since it is a special case of the mixed inlet condition with all boreholes in parallel (the default option of the Network class).
A nice feature here would be to add a __call__(self, time) that interpolates within the last computed g-function values.

I like your first draft of the common interface. I would suggest that __init__ keeps common parameters in addition to **kwargs (or an options dict). This helps for auto-completion. My proposal :
class gFunction(object):
    """
    Draft for gFunction class.

    Attributes
    ----------
    boreholes_or_network : list of Borehole objects or NEtwork object
        List of boreholes included in the bore field, or network of boreholes
        and pipes.
    alpha : float
        Soil thermal diffusivity (in m2/s).
    time : float or array, optional
        Values of time (in seconds) for which the g-function is evaluated. The
        g-function is only evaluated at initialization if a value is provided.
    method : str, optional
        Method for the evaluation of the g-function. Should be one of
            - 'similarities' : [...]
            - 'detailed' : [...]
        Default is 'similarities'.
    boundary_condition : str, optional
        Boundary condition for the evaluation of the g-function. Should be one
        of
            - 'UHTF' : Uniform heat transfer rate.
            - 'UBWT' : Uniform borehole wall temperature.
            - 'MIFT' : Mixed inlet fluid temperatures.
        If not given, chosen to be ''UBWT'' if a list of boreholes is provided
        or ''MIFT'' if a Network object is provided.
    options : dict, optional
        A dictionary of solver options. All methods accept the following
        generic options:
            nSegments : int, optional
                Number of line segments used per borehole.
                Default is 12.
            processes : int, optional
                Number of processors to use in calculations. If the value is
                set to None, a number of processors equal to cpu_count() is
                used.
                Default is None.
            disp : bool, optional
                Set to true to print progression messages.
                Default is False.
        For method-specific options, see [...]
        (method-specific options are the tolerances for the similarities
        method)

    """

    def __init__(self, boreholes_or_network, alpha, time=None,
                 method='similarities', boundary_condition=None, options=None):
        # Initialization of g-function parameters, calls
        # self._check_assertions():

        # If time is not None, calls self.evaluate_g_function(time)
        return True or gFunc

    def evaluate_g_function(self, time):
        # Calculates the g-function using the correct method and boundary
        # condition
        return gFunc

    def check_assertions(self):
        """
        This method ensures that the instances filled in the gFunction object are what is expected.
        Returns
        -------
        True
        """
        # [...]
        return True

This interface could easily deal with the different boundary conditions, using the flexible boreholes list or network object as the first parameter. For fluid temperature boundary conditions, m_flow, cp and borehole_connectivity would be required. The Network object can easily be modified to accept nominal values for the first two at initialization (borehole_connectivity is already required).
I would argue that the 'UIFT' boundary condition should be deprecated, since it is a special case of the mixed inlet condition with all boreholes in parallel (the default option of the Network class).
A nice feature here would be to add a __call__(self, time) that interpolates within the last computed g-function values.

@j-c-cook Is your interface still on any of your branches?

@j-c-cook Is your interface still on any of your branches?

The commits associated with reverting the file mod changes (https://github.com/MassimoCimmino/pygfunction/pull/55#issuecomment-753662224) was not completely straightforward.
I have created a pull request to your master. The only differences between your master and my issue_33 branch (pull request #63) is my initial recommendation for a common g-function interface.
I didn't see an issue33 branch of your own for me to pull request to.

The commits associated with reverting the file mod changes (https://github.com/MassimoCimmino/pygfunction/pull/55#issuecomment-753662224) was not completely straightforward.
I have created a pull request to your master. The only differences between your master and my issue_33 branch (pull request #63) is my initial recommendation for a common g-function interface.
I didn't see an issue33 branch of your own for me to pull request to.

@j-c-cook I created the missing issue33 branch and simply pushed your commits there. Your PR (#63, now closed) shows no merge conflicts so it is fine to work on this issue from there.
The work plan would be as follows :

[ ] Add parameters for nominal values of m_flow, cp and nSegments in the Network class
This should be as simple as adding m_flow=None, cp=None, nSegments=None to the __init__ method and calling all coefficients_[...] methods (through a new _initialize_coefficients method) if values are provided for all three.

[ ] Configure calls to the already-implemented g-function calculation functions using the new interface
This includes the configuration of the interface (__init__), the assertions (_check_assertions), and the evaluation of the g-function (evaluate_gfunction).

[ ] Implement visualization options for the g-function and other advanced metrics (heat extraction rates and borehole wall temperatures)
First step here would be to add a profiles=False parameter to the g-function calculation functions. If True, then the functions return a tuple (gFun, Tb[nSegments,Nt], Qb[nSegments,Nt]) instead of gFun. Methods can then be implemented to visualize the evolution of the borehole-averaged heat extraction rates or borehole wall temperatures vs. time, and the heat extraction rates and borehole wall temperature profiles vs z at a specified time.

[ ] Update the examples and the documentation of pygfunction to use the new interface
This is self-explanatory.

@j-c-cook I created the missing issue33 branch and simply pushed your commits there. Your PR (#63, now closed) shows no merge conflicts so it is fine to work on this issue from there.
The work plan would be as follows :

[ ] Add parameters for nominal values of m_flow, cp and nSegments in the Network class
This should be as simple as adding m_flow=None, cp=None, nSegments=None to the __init__ method and calling all coefficients_[...] methods (through a new _initialize_coefficients method) if values are provided for all three.

[ ] Configure calls to the already-implemented g-function calculation functions using the new interface
This includes the configuration of the interface (__init__), the assertions (_check_assertions), and the evaluation of the g-function (evaluate_gfunction).

[ ] Implement visualization options for the g-function and other advanced metrics (heat extraction rates and borehole wall temperatures)
First step here would be to add a profiles=False parameter to the g-function calculation functions. If True, then the functions return a tuple (gFun, Tb[nSegments,Nt], Qb[nSegments,Nt]) instead of gFun. Methods can then be implemented to visualize the evolution of the borehole-averaged heat extraction rates or borehole wall temperatures vs. time, and the heat extraction rates and borehole wall temperature profiles vs z at a specified time.

[ ] Update the examples and the documentation of pygfunction to use the new interface
This is self-explanatory.

As for future-proofing for eventual new calculation methods, this can be addressed when they are developed and we have a better idea of what is required.

As for future-proofing for eventual new calculation methods, this can be addressed when they are developed and we have a better idea of what is required.


not working on ESP32: I2C pins cannot be defined

The  Adafruit ESP32 Feather V2 has an ESP32-PICO-MINI-02.  The I2C pins on this dev board are SDA=22 and SCL=20 (pinout)
Even when specifying these I2C ports in line 48 of DFRobot_GR10_30.cpp:     _pWire->begin(22,20);  the board fails to initialize, presumably because the ESP32 can't find it on the I2C bus.
All works fine on an Arduino MKR WiFi 1010 whose I2C pins default to SDA=11, SCL=12

Solved. It was a wiring problem. The sensor and its library work just fine.


Tag i18n not supported as described in vue-i18n guide for interpollation

Environment

Operating System: Linux
Node Version:     v16.20.0
Nuxt Version:     3.6.5
Nitro Version:    2.5.2
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      modules, devtools
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-kh9jk9?file=i18n.config.ts,app.vue
Create a new repo, set it up for translation. Try to use the i18n tag as defined in the vue-i18n guide for interpollation.
Describe the bug
I tried to use the component interpollation, which uses the tag i18n, as described in the vue-i18n documentation (https://kazupon.github.io/vue-i18n/guide/interpolation.html#basic-usage).
The tag seems to be ignored, and I couldn't find anything in the documentation which stated this as a current limitation.
Additional context
No response
Logs
No response

nuxt i18n module use Vue I18n v9.
i18n tag (Translation Component) is ranamed to i18n-t tag in Vue I18n v9
please read docs breaking change section.
https://vue-i18n.intlify.dev/guide/migration/breaking.html#translation-component
FYI: I've just added Vue I18n version in nuxt i18n module docs
https://github.com/nuxt-modules/i18n/pull/2257
Thanks!


SBT plugin for transforming PMML files to SER files

From the mailbox:

You are converting pmml models to Java SER data format in a Maven Plugin. Do you have a solution which uses Gradle instead of Maven or is it even possible to do the conversion in Gradle? Nowadays everyone uses Gradle instead of Maven in Android apps so I guess every Android developer have this problem.

The business logic of a Maven/SBT plugin:

Unmarshall PMML file into a org.dmg.pmml.PMML class model object (using org.jpmml.model.JAXBUtil).
Transform the class model object by applying appropriate Visitor API workers on it. For example, saving memory by throwing away SAX Locator information, and interning repeated elements.
Serialize the transformed class model object to a SER file (using org.jpmml.model.SerializationUtil).


Bugfix/93 preview not resized and displayed correctly when orientation changes

We have the same issue on ios i think @ryaa did you tried ?

We have the same issue on ios i think @ryaa did you tried ?

This should be fixed by this PR https://github.com/capacitor-community/camera-preview/pull/235. Please also see more details here https://github.com/capacitor-community/camera-preview/issues/232

@ryaa i did merge your both PR in this repo and published it :
https://github.com/Cap-go/camera-preview/tree/main
And this is still failing, when rotate the camera view take half the screen on ios

@ryaa i did merge your both PR in this repo and published it : https://github.com/Cap-go/camera-preview/tree/main And this is still failing, when rotate the camera view take half the screen on ios

@riderx, can you please try to install from my from npm install ryaa/camera-preview#chore/my-latest-fixes-as-of-21-july-2022
It includes fixes for iOS (https://github.com/capacitor-community/camera-preview/issues/232) and Android (https://github.com/capacitor-community/camera-preview/issues/93) and other people reported that everything seems to be working fine.

@ryaa after second round of testing i can see a improvement. but still not as expected.
The video don't rotate, then if i look down witht the phone and up again it rotate.
https://drive.google.com/file/d/1awylwmhwq5oDWvtA8LNpcXLInbjLMmLC/view?usp=sharing

https://drive.google.com/file/d/1awylwmhwq5oDWvtA8LNpcXLInbjLMmLC/view?usp=sharing

interesting. as I understand, the problem is on an Android device, right? I will try to double check to see if I can reproduce this problem. Right now, it seems to be working ok on my end.

@ryaa nope that on IOS

@ryaa nope that on IOS

This PR is for the fix for android and not iOS, so this is not relevant. Please note that the fix for iOS has already been merged to master and released - see https://github.com/capacitor-community/camera-preview/releases/tag/v3.1.1

@ryaa the title of the fix for iOS is "fixed the problem when photos taken in the landscape orientation are off" which is not my issue.
The issue I have is "preview not resized and displayed correctly when orientation changes" so that why I posted here.
I agree the original issue is connected to Android, but not the PR, which is the one i found.

@ryaa the title of the fix for iOS is "fixed the problem when photos taken in the landscape orientation are off" which is not my issue. The issue I have is "preview not resized and displayed correctly when orientation changes" so that why I posted here. I agree the original issue is connected to Android, but not the PR, which is the one i found. Sorry for the misunderstanding

ah.. got it... question - are you having the problem with the plugin installed from my branch (as I indicated above)? or is this the plugin installed from your branch?

@ryaa i tried with both and the behavior is the same, who seems normal since my branch is ISO as yours. ^^
While reading the code i don't see any change for the rotation issue in your commit for IOS, so that seems normal to me.

@ryaa i tried with both and the behavior is the same, who seems normal since my branch is ISO as yours. ^^ While reading the code i don't see any change for the rotation issue in your commit for IOS, so that seems normal to me.

Here is the change for iOS which fixes the rotation issue https://github.com/capacitor-community/camera-preview/pull/235/files
It should be there, in the plugin source code

@ryaa this is the fix for "fixed the problem when photos taken in the landscape orientation are off" , but you mean that also fix when you rotate the camera that rotate the preview?

@pbowyer when you have time to check that one, it seems important for android too :)

Thanks for checking these @riderx I will merge and make a new release 👍
Re "@pbowyer when you have time to check that one, it seems important for android too :)" -- which one do you mean by "that one"?

thanks !
App MVP builder at Forgr https://forgr.ee/
Podcast host at INDIE MAKERS https://indiemakers.fr
Maker of Captime https://captime.app Crossfit timer app
Creator of Capgo https://capgo.app/ Capacitor OTA system
On August 29, 2022, Martin DONADIEU @.***> wrote:

Merged #238 <https://github.com/capacitor-community/camera-
preview/pull/238> into master.

—
Reply to this email directly, view it on GitHub
<https://github.com/capacitor-community/camera-preview/pull/238#event-
7278504235>, or unsubscribe
<https://github.com/notifications/unsubscribe-
auth/AA7FGLZ3PIIHWFTLLHBOXZDV3SZHDANCNFSM54EL3XZQ>.
You are receiving this because you were mentioned.Message ID:
<capacitor-community/camera-
@.***>


[wip][nat64] use c-ares impl to replace getaddrinfo_a

https://github.com/openthread/ot-br-posix/issues/2033
This commit replaces functions such as getaddrinfo_a, which now rely on glibc, with a solution from the c-ares library to enable asynchronous address parsing functionality for either glibc or musl libc.
After this commit, the OPENTHREAD_POSIX_CONFIG_NAT64_AIL_PREFIX_ENABLE functionality should be properly enabled on the OpenWrt platform.
Feel free to give your comments. @jwhui

@ihidchaos , are you still interested in moving this PR forward?

Yes. I will try to make the CI check pass.

I'm having two problems, the first is that the "Size / size-report" test passes locally, but the CI always fails. The other is that "Border Router / BR nat64 openthread (mDNSResponder, TREL=0)" always fails on two tests, test_with_infrastructure_prefix.py and test_multi_border_routers.py.
All other CI test items can be made to succeed by running them repeatedly.
Among them,  the failure log for test_with_infrastructure_prefix.py is
======================================================================
FAIL: test (__main__.Nat64SingleBorderRouter)
----------------------------------------------------------------------
Traceback (most recent call last).
  File "/home/ubuntu/dev/temp/openthread/tests/scripts/thread-cert/border_router/nat64/test_with_infrastructure_prefix.py", line 112, in self.assertNotEqual
    self.assertNotEqual(favored_nat64_prefix, local_nat64_prefix)
AssertionError: 'fddd:9c84:1796:2:0:0::/96' == 'fddd:9c84:1796:2:0:0::/96'

And the failure log for test_multi_border_routers.py is
======================================================================
FAIL: test (__main__.Nat64MultiBorderRouter)
----------------------------------------------------------------------
Traceback (most recent call last).
  File "/home/ubuntu/dev/temp/openthread/tests/scripts/thread-cert/border_router/nat64/test_multi_border_routers.py", line 131, in test
    self.assertNotEqual(br2_local_nat64_prefix, br2.get_br_favored_nat64_prefix())
AssertionError: 'fdeb:75d8:bf2d:2:0:0::/96' == 'fdeb:75d8:bf2d:2:0:0::/96'

Regarding the two test items above, can you suggest me some modifications?


Created a PTX file reader.

This is a PTX file reader. It has the quasi-obvious limitation that it needs to scan the full file to have the bounding box.
Used together with the tiling patch it allows to index a pointcloud directly from PTX files, without the need for txt2las or lastile.
By now it is not useful without the tiling phase, because each ptx file will be scanned many times only to have its bounding box during indicization.

Needs further investigation.


No project source license specified

The VIACOM PRO community edition is often described as Open Source (Such as in the README.md) and I believe that is the intention.
However this repository is missing a license file or any details about what license the code is being distributed under so it is technically not Open Source as it stands, it is in a bit of a grey area.
There is an MIT license in the installer sub-folder but nothing top level or elsewhere that I can see.
This lack of clarity can lead to issues down the road or put potential contributors off.
Suggestion:

Add a top-level license file to the repository
(Optional) Add the short blurb of whatever license is chosen to the top of each code file.

Applying this after contributions have already been made is itself a bit iffy legally speaking without a CLA but I don't think anyone is going to complain

Yes agreed, we had some discussions about how we would go forward and hence the MIT license in the source. I'll just need to loop back with the collaborators and make sure this will work with the original GPL Hollywood placed on it.
Thanks for pointing this out it needs to be clearly defined.

Top Level MIT Licence added to repository.Will look at individual files on next develop merge.


Cart is incorrectly referencing productId rather than variantId

Subtotals are accurate on pageload but get overwritten with the final subtotal by JS otherwise. I'm not 100% sure on my fix, but it seems to work here.

Current coverage is 53.58% (diff: 100%)

Merging #691 into master will not change coverage

@@             master       #691   diff @@
==========================================
  Files           103        103
  Lines          5401       5401
  Methods           0          0
  Messages          0          0
  Branches        647        647
==========================================
  Hits           2894       2894
  Misses         2404       2404
  Partials        103        103

Powered by Codecov. Last update 89f63a6...5b00323

@lampyjon Thanks for PR :) But there is one more problem. To fix this change productId to variantId at https://github.com/mirumee/saleor/blob/master/saleor/cart/views.py#L60


Frontend for authorization

Template for authorization and registration

integrate Thymeleaf

transform jsp examples into html to get it work
add special controller to get and observe templates in work
/showtemplate/manager
/showtemplate/trainer
/showtemplate/student
add registration controller
/registration/


⚠ Bofrost.lu has degraded performance

In f1aec08, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1460 ms

Resolved: Bofrost.lu performance has improved in aea8afc after 41 minutes.