cleanup: expose requestedServerName as a string view

Signed-off-by: Kuat Yessenov<EMAIL_ADDRESS>Description: expose stream info method to return a string_view since it owns the string value.
Risk Level: low
Testing: unit
Docs Changes: none
Release Notes: none

The intent is to make the ownership explicit. A view from const std::string& may become dangling if a local temporary is used in the implementation.

Generally, const std::string& as a return value is fine if it refers to a member string memory. That means protobuf signatures are guaranteed to work correctly. The issue is that I don't see how to impose this constraint on Envoy code. The implementation is free to create a temporary string which will break string_view at the call site.
Handling at the call site is a little too ominous. Many strings in Envoy have very clear ownership semantics as they are request or connection bound.

Handling at the call site is a little too ominous. Many strings in Envoy have very clear ownership semantics as they are request or connection bound.

No, as long as you don’t implicitly copy const std::string& to a temporary std::string (which you don’t want to do anyway) and implicitly converting it to string_view, you won’t have dangling string_view.

Fair enough. I'm still concerned that someone might change the signature to const std::string down the line. But we have to wait until the important libraries start taking string_view as input in their methods.

I'm still concerned that someone might change the signature to const std::string down the line

In general even you have a std::string_view from a temporary std::string, it is safe to use as long as you don't use the string_view out of the scope. i.e. if a function is invoked with a string_view parameter from a temporary string from caller, the string_view is not dangling until the end of the function.

The problem is with interpreter like CEL. It can hold a string view beyond the scope of a function. It's the reason why I have been hunting down strings.


FR: Vertical Size

With this metadata it would be easier to integrate markline into the documents, so that they take up what you need.
I think it would also be interesting to have an automatic option, so that it adjusts to the number of lines in the code.

+1


Performance: Youtube embed cause performance issue.

Issue Summary

Steps to Reproduce
Issue can reproduce by embedding youtube link in post and then test published blog on PageSpeed Insights.
Ghost Version
v5.70
Node.js Version
v16.20.0
How did you install Ghost?
ubuntu 18
Database type
MySQL 8
Browser & OS version
Chrome 119/windows 10
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

Thanks for the issue - I wouldn't necessarily call this a bug so I'd suggest opening a feature request on the forum with the request 🙂


Refactoring grammar development

@James-Yu
Currently, this repo only contains the TeX, LaTeX and BibTeX grammars. They are only ones built in VS Code. I think we should move all the grammars to this repo for the ease of maintenance and testing. Then, LaTeX-workshop would only pull the grammars and language configurations from this repo.
In particular, fixing #85 will certainly require to duplicate the LaTeX grammar inside the doctex one. This has to be done inside the building tools as we do in build-md.js
Do you agree with this change?

I am absolutely fine with that!


Multi Discrete Envs Spaces

At multiple places we assume there's only a single dimension in the observation/action space if the env is discrete.
E.g.
https://github.com/SforAiDl/genrl/blob/dc2d58bdade1c5239ccc0925aeda78d1dc59e972/genrl/environments/vec_env/vector_envs.py#L123
https://github.com/SforAiDl/genrl/blob/dc2d58bdade1c5239ccc0925aeda78d1dc59e972/genrl/environments/vec_env/vector_envs.py#L133

This caused a bug in running continuous envs with On Policy algos when you tried to fix it ig. For example, PPO wasn't running on Pendulum-v0. I've reverted it back to what it was for now. Let's deal with this when we're working with multi discrete envs?

Tracking in #382


In dynamic blocks turn A.B() into new A.B()

For instance the library http://threejs.org/ uses an object namespace named THREE and currently the only way to instanciate a class of this lib in a browser is :
window.\iScene = THREE.\iScene;
dynamic scene = Scene();

Did anyone ever open an issue against the typechecker for this?
I mean, given that A.B() is now the natural syntax in Ceylon for a constructor-based instantiation, I don't see any reason why this shouldn't work!

No I haven't opened the issue in the typechecker. But why does the typechecker need a change? x.Y() is already a qualified type expression

Oh because of what I mentioned back in November? Right. I just tested with the hapi example, I can fix that just now, but that's turning a.B() into new a.B(), but A.B() still doesn't pass the typechecker.

@chochos the typechecker now accepts this.

The compiler already supported this, I was just waiting on typechecker support. Closing.


Build failed in v4.0.4

Hi I upgraded to v4.0.4. But it cause building failed.

Could you try cleaning in xcode and let me know if that fixes it? Thank you
I've added other troubleshooting steps here: https://github.com/DylanVann/react-native-fast-image/blob/master/docs/troubleshooting.md

I am experiencing the same. :\

@edo1493 Have you tried those troubleshooting steps?
I've cleaned all the stale data I can think of and installed the new version on a new React Native project and it builds and works for me.
I'd like to be able to test on another machine to be 100% sure but I don't have one available at the moment. Also thinking about setting up some CI for this but all the iOS CI solutions cost money and I'm not sure yet which one would be best for this.

Got the same error as well, using pods is not an option for me.

Apparently when running fastlane #import <SDWebImage/FLAnimatedImageView.h> doesn't work.

Yep, same issue here. Running in debug mode, releaser throws same error. Tried all the steps as well (clearing cache, deleting modules/build folder, watchman del all, npm start reset cache, delete derived data in xcode, cmk shift k)

Had to downgrade to 3.0.2

v4.0.3 should work.
yarn add<EMAIL_ADDRESS>
I'll try to resolve this tonight.

v4.0.6 is released. This issue should be fixed now.
Ended up doing it like this:

Conditional import - https://github.com/DylanVann/react-native-fast-image/commit/084a41497d5688c7939f94be7d48d2f2ad74fb74
Fix other header search path - https://github.com/DylanVann/react-native-fast-image/commit/ac00fdaa6309f03afc3bf052584a99c18726d21e

Seems to work in all the scenarios I tested:

Debug/Release
Using CocoaPods
Using fastlane

Let me know if this fixes things, thank you


Previous messages aren't not showing up in the chat if the other user has deleted his account - reported by @thesahindia

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

You need account A which has old messages from account B
Delete account B
Log out of account A and Log in again
Check if the previous messages from account B is there

Expected Result:
Old messages should still display
Actual Result:
Previous messages aren't not showing up in the chat if the other user has deleted his account and when we send another message to the deleted user, a welcome message shows up. Also getting an error while requesting money.
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.36-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43995119/153808156-a478adc3-90ca-4a8e-b387-c7f095ee8113.mov
Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1643297398089800
View all open jobs on GitHub

Triggered auto assignment to @isabelastisser (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Triggered auto assignment to @JmillsExpensify (Internal) because issue was reported by a contributor who needs to be compensated if this issue is fixed

I am fairly sure this is internal, so I'm not applying the External label in doubt.

Cool, that sounds about right. Leaving it in the pool and then I'll check back in next week.

Still waiting on internal volunteers.

@flodnv We've been sitting in this issues for quite some time with no internal volunteers. Shall I change up the labels, for instance a daily or something else? Another approach is that we decide to close the issue and not optimize for deleted accounts right now.

I bumped the internal question I had: https://expensify.slack.com/archives/C03TQ48KC/p1645210228878819

@JmillsExpensify I unassigned you -- since you were assigned, no one could see this issue in the list of unassigned issues 😛

Can take a look here and see what I find 👀

I don't really get this issue. I tried to test this locally and everything works fine.

Created 2 new accounts and a chat between them with comments
Deleted 1 user
Accessed the chat as the second user
Signed out then signed in
No issues accessing the chat or leaving comments.

Going to close this unless there are clearer reproduction steps.


Redrawing a Geo JSON layer

I'm creating a Geo JSON layer, and I update ctrl.clusterDisplayProperties by firing off a GET request to a server every time the extent of the map changes.  I can see the request hit the server, and I can see clusterDisplayProperites update.  Unfortunately, I never see the features on the map change.  How can I get the layer to update?
<openlayers ol-center="ctrl.boundingBox" width="100%" height="100%">
    <ol-control name="{{ control.name }}" ng-repeat="control in ctrl.controls"></ol-control>
    <ol-layer ol-layer-properties="ctrl.clusterDisplayProperties"></ol-layer>
</openlayers>

faced similar problem... I've done it by "redrawing" layer directly in OL3
// create layer, see http://tombatossals.github.io/angular-openlayers-directive/#/layers/layer-geojson-inline
$scope.featuresLayer = {
    name: 'featuresLayer',
    source: {
        type: 'GeoJSON',
        geojson: {
            object: $scope.featuresGEOJSON,
            projection: 'EPSG:3857'
        }
   },
   style:(function () {
       ...
   })
}

...

//update on change
olData.getMap().then(function (map) {
    var layers = map.getLayers();
    layers.forEach(function (layer) {
        if (layer.get('name') === 'featuresLayer') {
            var lSource = layer.getSource();
            var nf = lSource.readFeatures($scope.featuresGEOJSON); //new features
            lSource.clear(); //remove existing features
            lSource.addFeatures(nf);
            layer.setStyle($scope.featuresLayer.style);
        }
    });
});

I've got it working now.  Thanks!

no problem!


[WIP] support for Config files

Fixes #13 I don't yet what all config options we are supporting yet so for now its is a WIP.
@arcolife @samikshan

@arcolife made the changes.

@procrypt some conflicts here.. also we have a config system now. Might wanna revisit this? Whaazzup

@arcolife I'll update it as per the new config system :+1:

@arcolife can you please point me to the new config system we have now.

covering this in https://github.com/truechain/truechain-consensus-core/pull/57#issuecomment-406927564 (will wrap any commits in there so as to not loose author. Example https://github.com/grafana/grafana/pull/6043/commits/2fdda7973cbc594d89dc93e93a1146c0ff88e2a5)


How to send parameter

I know I can send parameters on Label (something like label: '{{scopeVariable}}', but I need to send two arguments, how can I send one in Label and other parameter in another key ?
I already tried to get scope variable in template of breadcrumb, however I can't get that.
If I can send parameter like a JSON, it can help me too.
I know when scope variable is not on label key it is not rendered.

@Brenw10 Same issue here!
Any ideas?!


Support embedded queries

Codecov Report

Merging #40 (b11e478) into main (29e65cd) will increase coverage by 0.73%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   88.21%   88.95%   +0.73%
==========================================
  Files           7        7
  Lines         331      353      +22
  Branches      105      117      +12
==========================================
+ Hits          292      314      +22
  Misses         28       28
  Partials       11       11

Flag
Coverage Δ

client
88.95% <96.66%> (+0.73%)
:arrow_up:

generator
88.95% <96.66%> (+0.73%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

packages/client/src/helpers/makeFetcher.ts
97.56% <96.66%> (-2.44%)
:arrow_down:

packages/client/src/helpers/makeWhere.ts
73.88% <0.00%> (+0.74%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e65cd...b11e478. Read the comment docs.


jackson: add test coverage #2634

(cherry picked from commit e69019354d6a11521d0c61a6183af3b4376ec2bb)

That's a nice test coverage @ffang. Maybe we could even do less in the context of quarkus/graalvm but better have more than less.
Beyond, I've left some minor comments, apart from that looks good to me.

Hi @aldettinger ,
Thanks for the feedback, and please see my comments inline.
Freeman


Quantifier bounds in set filters shouldn't allow multiple variables

This should be illegal:
---- MODULE Test ----
op == {x, y, z \in Nat : P(x, y, z)}
====

However, the quantifier_bound rule allows it. At the cost of making the set_filter rule more verbose this could be fixed, but making the grammar more restrictive often increases its size. Thus it is worth exploring whether fixing this is worth it.
Discovered in the course of working on https://github.com/tlaplus/tlaplus/issues/882

Note that CHOOSE has the same restriction, so perhaps we could abstract out the quantifier of that rule and merge it with the set filter rule.


[improve][broker] Add ServiceUnitStateTableView (ExtensibleLoadManagerImpl only)

PIP: https://github.com/apache/pulsar/pull/23300

Motivation

Implements the PIP: https://github.com/apache/pulsar/pull/23300
Modifications

Add ServiceUnitStateTableView interface
Add ServiceUnitStateTableViewImpl implementation that uses Pulsar System topic (compatible with existing behavior)
Add ServiceUnitStateMetadataStoreTableViewImpl implementation that uses Pulsar Metadata Store (new behavior)
Refactor ExtensibleLoadMangerImpl and ServiceUnitStateChannelImpl to accept ServiceUnitStateTableView.
Add time-based producer restart logic in LoadDataTableView and improved its shutdown logic.
Improve ownership release logic to be more graceful upon broker shutdown
Refactor related tests code
ServiceUnitStateTableViewSyncer to sync the two table views during migration.

Verifying this change

[x] Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/heesung-sn/pulsar/pull/81

@BewareMyPower @Demogorgon314 Updated the code. PTAL thanks.

Codecov Report
Attention: Patch coverage is 78.50746% with 144 lines in your changes missing coverage. Please review.

Project coverage is 74.70%. Comparing base (bbc6224) to head (bee4bd5).
Report is 591 commits behind head on master.

Files with missing lines
Patch %
Lines

...sions/channel/ServiceUnitStateTableViewSyncer.java
68.25%
24 Missing and 16 partials :warning:

...ata/tableview/impl/MetadataStoreTableViewImpl.java
75.65%
24 Missing and 13 partials :warning:

...el/ServiceUnitStateMetadataStoreTableViewImpl.java
60.78%
14 Missing and 6 partials :warning:

...xtensions/channel/ServiceUnitStateChannelImpl.java
81.25%
14 Missing and 4 partials :warning:

...ensions/channel/ServiceUnitStateTableViewImpl.java
75.67%
11 Missing and 7 partials :warning:

...lance/extensions/channel/ServiceUnitStateData.java
50.00%
1 Missing and 2 partials :warning:

...dbalance/extensions/ExtensibleLoadManagerImpl.java
89.47%
1 Missing and 1 partial :warning:

...ensions/channel/ServiceUnitStateTableViewBase.java
94.44%
2 Missing :warning:

...er/loadbalance/extensions/store/LoadDataStore.java
0.00%
2 Missing :warning:

.../pulsar/metadata/cache/impl/MetadataCacheImpl.java
60.00%
1 Missing and 1 partial :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23301      +/-   ##
============================================
+ Coverage     73.57%   74.70%   +1.13%
+ Complexity    32624     2757   -29867
============================================
  Files          1877     1936      +59
  Lines        139502   145635    +6133
  Branches      15299    15935     +636
============================================
+ Hits         102638   108802    +6164
+ Misses        28908    28540     -368
- Partials       7956     8293     +337

Flag
Coverage Δ

inttests
27.89% <27.16%> (+3.30%)
:arrow_up:

systests
24.62% <4.77%> (+0.30%)
:arrow_up:

unittests
74.07% <78.50%> (+1.23%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

...org/apache/pulsar/broker/ServiceConfiguration.java
98.96% <100.00%> (-0.43%)
:arrow_down:

...adbalance/extensions/channel/ServiceUnitState.java
100.00% <100.00%> (ø)

.../channel/ServiceUnitStateDataConflictResolver.java
76.00% <100.00%> (ø)

...e/extensions/store/TableViewLoadDataStoreImpl.java
96.77% <100.00%> (+8.67%)
:arrow_up:

...sar/broker/service/persistent/PersistentTopic.java
79.54% <ø> (+1.08%)
:arrow_up:

...pache/pulsar/metadata/api/MetadataCacheConfig.java
83.33% <100.00%> (+3.33%)
:arrow_up:

...he/pulsar/metadata/api/MetadataStoreTableView.java
100.00% <100.00%> (ø)

...dbalance/extensions/ExtensibleLoadManagerImpl.java
83.33% <89.47%> (+3.24%)
:arrow_up:

...ensions/channel/ServiceUnitStateTableViewBase.java
94.44% <94.44%> (ø)

...er/loadbalance/extensions/store/LoadDataStore.java
0.00% <0.00%> (ø)

... and 7 more

... and 579 files with indirect coverage changes


BUG: GH10209 fix bug where date_format in to_csv is sometimes ignored

closes #10209
When datetimes are not dates only i.e. have fractional day values, date_format passed to to_csv is ignored.

This might be a silly question: Would I need to rebase after the PR passed the build test but has become stale?

you need to move the release note to v0.16.2.txt

Ah. I see. Will do. Thanks!

merged via https://github.com/pydata/pandas/commit/282746ae3c05edf7eac5c9583a17aa53ea12b7da
thanks!


Bulk: Update @devoxa/prettier-config

Codecov Report

Merging #501 (7e23b84) into master (e564094) will not change coverage.
The diff coverage is 100.00%.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Generic BioEngine: change name

I think we should eventually change the name to something that makes more sense for users. Some suggestions:

RunModelTest
ModelTest
RunDefaultModelTest
DefaultModelTest
RunModelPreview
ModelPreview
RunDefaultModelPreview
DefaultModelPreview

(But I think it's not high priority, let's fix #280 first)

In the paper, we call it "Test Run", we can also use it here.
Also, I would change the icon back to the play button, I think it's more intuitive than the giraffe.


conda packages

Would it be possible to maintain a conda package of this?  Since ctapipe uses conda for the recommended install, it would be very useful to have the ctapipe conda package depend on this package without using a pip hack.  That will be needed for the next release. TI's quite easy to create a recipe using conda skeleton pypi eventio.  Then we either:

host the recipe on the cta-conda-recipes repo and manually build it ourselves when there is a new relase

put it on conda-forge for automatic building (recommended)

I think @kosack referred to mixing conda and pip packages in environment.yml files.

I've already make packages for it, the package recipe is for now in the https://github.com/cta-observatory/cta-conda-recipes repo.  Eventually we should automate the builds of the packages, though, or move it to conda-forge so it's done automatically by them.

you can see the recipe here: https://github.com/cta-observatory/cta-conda-recipes/blob/master/eventio/meta.yaml


RubyGems post-install hook not triggering

I see a lot of talk about Bundler install hooks on different issues/PRs that (like this thread) mentions that Bundler respects RubyGems post install hooks, but I'm testing it out and that doesn't seem to be the case… if I install via gem install the hook runs, but if I add the gem to a Gemfile and install it doesn't seem to be triggering the hook. Is that unexpected?

The easiest way I found to test this out is to create a new gem. Add a file at lib/rubygems_plugin.rb with something like this:
Gem.post_install do
  File.write("~/test.txt", "it worked!")
end

If you do rake install you should see the gem install and then that file will be written to your home directory.
But if you create a new folder, add a Gemfile, and reference your gem via path: "path/to/your/gem", and then bundle install, the file won't be written.

Thanks for reporting this! Running bundle install with path gems does not install those gems. The path feature is a shortcut to add the path to $LOAD_PATH, and does not do any of the usual gen installation procedures. Please create a gem if you need to run a post-install hook during bundle install.

Hmm, if memory serves I also tried that because I suspected path might be bypassing this… but I can't remember. Let me try that now.

Yeah, I just tried it with a private gem on GitHub… oh wait, does that not work either? Does it only trigger the install hook if the source is RubyGems?

@brandonweiss I honestly don't know about git gems, but I would only expect a post-install hook to run from an actual .gem file coming from a gem server, yeah.

No wait, that doesn't make any sense, because if I rake install it gets run. It definitely shouldn't matter where it gets installed from.

OK, my theory is that it has something to do that I install gems with bundle install --path. That sorts of makes sense, in that if it's just being dumped in a directory and Bundler is doing some magic to load the gem, and if what's actually causing the post install hook to fire is Rubygems, then maybe Rubygems never gets the chance to trigger it?
I tried to test this out by removing the path, although… that's weird, I don't see the gem when I do gem list. And when I run bundle show gem_name it's in:
/Users/brandon/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/gem_name
Shouldn't it be in the outer-level gem directory? Did Bundler change at some point to nest it inside the Bundler gem?

Bundler only should be running the install hooks when it runs an actual gem installer, which definitely doesn't happen for path gems

By “path gems” do you mean a gem that is referenced in a Gemfile via the path option or when gems are installed via Bundler to a local path via the path flag? The former I guess makes sense, although the latter is not what I'd expect… I would not expect a gem to install differently simply because gems are being put in a specific directory.

Via the :path option in the Gemfile

@brandonweiss to answer your earlier question, I believe that gems in bundler/gems are :git gems? If a .gem built gem is installed via bundle install, it shouldn't go into a directory named bundler. Maybe you have some environment variable or bundler setting changing the --path still?

@indirect Oh, well I am installing it via GitHub at the moment, so that would make sense why it's being installed there. OK, so maybe it's still bypassing the RubyGems install process and thus not triggering the post-install hook. Let me try publishing a gem to RubyGems and see if installing via bundler triggers the post-install hook.

ping @brandonweiss

I'm closing this for now but feel free to open this again if needed

The install from path not triggering lib/rubygems_plugin.rb-registered hooks issue still exists.

Please share a gemfile that we can use to reproduce the issue

Remove the workaround here:
https://github.com/glebm/critical-path-css-rails/blob/penthouse-npm/Gemfile#L7-L10
The run bundle: https://github.com/glebm/critical-path-css-rails/tree/penthouse-npm
(note that gemspec is effectively a path gem)

Ah now I understand, thanks!

@glebm gems from paths are never installed, and that's why the post install hook is not firing. can you describe what you would expect to happen with a post install hook for gems that aren't installed? what's the goal you're trying to accomplish?

@indirect it's just that the plugin file should be loaded, if I'm understanding correctly. I have a patch nearly done

Sorry I haven't followed up with a repro 😞 Distracted by two many things.
It's possible the term “installation” might have a particular meaning here that I'm not getting, but if I made a gem, someone might “install” it a number of ways.
Manually to global gems
gem install gem_name
From a Gemfile with Bundler to global gems
source "http://rubygems.org"

gem "gem_name"

bundle install
From a Gemfile via path with Bundler to global gems
source "http://rubygems.org"

gem "gem_name", path: "~/Code/gem_name"

bundle install
From a gemfile with Bundler to local path
source "http://rubygems.org"

gem "gem_name"

bundle install --path vendor

It's possible there are some other permutations I'm not thinking of, but from my perspective, running bundle install is installing all of these. I get technically in some cases it's probably not (like specifying the gem via path), but I would expect every single one of these to trigger the post-install hook. Does that seem reasonable?

From a Gemfile via path with Bundler to global gems

This case doesn't actually install gem_name, it just puts its require paths on the load_path

@segiddins True but that's an implementation detail. The expection is that rubygems_plugins are loaded.

Loading the plugins is separate from post install hooks, and I think loading them is totally reasonable

If you load the plugins, their post-install hooks will run, right?

*post- and pre-install hooks

I guess I don't really understand the terminology… I would assume loading the plugin would then trigger a pre/post-install hook (if one exists) because they're defined in lib/rubygems_plugin.rb in a gem?

Yes, that's what I think as well. Just checking as I am a bit confused by @segiddins's last comment

Looks like hooks will not trigger during the gems installation (by design): http://help.rubygems.org/discussions/problems/378-gempre_install-does-not-working-as-it-named

Damn. That is really disappointing. npm has this ability and it's super-useful. 😞

OK, I sort of got it working, actually. Here's the repo: https://github.com/brandonweiss/git-hookshot
Instead of using rubygems_plugin.rb to define an install hook, I just defined it in the gemspec. The reason I thought it worked and shipped it is because when I was testing this I was using the GitHub repo as the source in my Gemfile. And when I bundle installed the first time, or any time I bundle updated the install hook would run and generate the directory and symlinks.
But someone just noticed that if they use RubyGems as a source then it doesn't work. Is that expected? That pre/post install hooks would run if the source is from GitHub but not RubyGems?


Update lndmanage.py

On empty input print help. Also accept -h and --help for help.
Fix bitromortac#56

Makes sense! Thank you for the contribution. :rocket:


Interactive Figure Proof of Concept

Initial implementation of #200. This allows the user to save most of the current state of their WWT widget by calling the save_as_html_bundle function on the widget and specifying a folder or zip file destination. There is still functionality that would be good to add to the feature, some of which is listed below:

Allowing users to name the exported csv and fits files with a nice interface (this pull request names the data files with the layer id)
Better handling of errors when loading data:

Retry loading depending on returned error.
Better formatted way to display error messages.

Add support for camera rotation and angle (and potentially add the ability to change these in python code)
Potentially adding the option for the user to embed table data in the configuration JSON file
Potentially show loading message and/or hide render window in the exported html page until all of the data is loaded.

@pkgw I just rebased this onto the master branch.

Initial implementation of #200. This allows the user to save most of the current state of their WWT widget by calling the save_as_html_bundle function on the widget and specifying a folder or zip file destination. There is still functionality that would be good to add to the feature, some of which is listed below:

Allowing users to name the exported csv and fits files with a nice interface (this pull request names the data files with the layer id)

Better handling of errors when loading data:

Retry loading depending on returned error.
Better formatted way to display error messages.

Add support for camera rotation and angle (and potentially add the ability to change these in python code)

Potentially adding the option for the user to embed table data in the configuration JSON file

Potentially show loading message and/or hide render window in the exported html page until all of the data is loaded.

Forgot to add that support for user added image collections is currently missing

Travis failures are transient link-check issues, so I think we're good!


Metadata of ogg files in local song library scanner aren't read

Finally I had time to test my ogg files library with the local song feature. Playing just works great. Only thing is that the metadata (artist, song, album) isn't read when importing OGG files into the library. MP3 files with metadate are working fine. FFmpeg should be able to read the metadata of ogg files as well.
Thanks!

I think the issue is that OGG metadata is part of the stream and not part of the container, like with other formats, so it isn't found by ETV's current parser. Will work on a fix.


Feature Request: Only check marked structs

Add an option to check only marked structs:
// exhaustivestruct:[strict | loose]
type Some struct {
}

I so want this, too! Because there are so many false positives, but sometimes it would be great to require it so that if you ever upgrade a version, you get a notification that more fields have been added.


codecov: revert experiments

Please take a look.

Codecov Report

Merging #1636 (957d387) into master (1858083) will increase coverage by 1.74%.
The diff coverage is 82.91%.

@@            Coverage Diff             @@
##           master    #1636      +/-   ##
==========================================
+ Coverage   71.46%   73.21%   +1.74%
==========================================
  Files         489      503      +14
  Lines       54288    59718    +5430
==========================================
+ Hits        38797    43722    +4925
- Misses      13086    13517     +431
- Partials     2405     2479      +74

Impacted Files
Coverage Δ

blas/gonum/level2float32.go
0.00% <0.00%> (ø)

...sp/fourier/internal/fftpack/array_bounds_checks.go
51.11% <ø> (ø)

...fourier/internal/fftpack/array_no_bounds_checks.go
81.81% <ø> (ø)

dsp/window/window.go
100.00% <ø> (ø)

dsp/window/window_complex.go
100.00% <ø> (ø)

graph/formats/rdf/kind_string.go
0.00% <0.00%> (ø)

graph/formats/rdf/parse.go
91.78% <ø> (ø)

dsp/window/window_parametric.go
69.23% <20.00%> (-14.77%)
:arrow_down:

graph/formats/rdf/nodebug.go
25.00% <25.00%> (ø)

graph/encoding/digraph6/digraph6.go
56.86% <40.00%> (+3.52%)
:arrow_up:

... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 286b092...957d387. Read the comment docs.


hugolib: Add parameter option for .Summary

Add the ability to have a summary page variable that overrides
the auto-generated summary.  Logic for obtaining summary becomes:

if summary divider is present in content use the text above it
if summary variables is present in page metadata use that
auto-generate summary from first x words of the content

Fixes #5800
Tests have been added to ensure all three cases work as expected.  Note that in the tests the summary has markdown elements to ensure that processing occurs correctly; as such RST is explicitly excluded from the list of tested engines in the tests added in hugolib/page_test.go.
There is a discrepancy between the summary when auto-generated and when generated using the explicit delimiter; in the former case the output is plain and in the latter case it is wrapped with <p>.  I chose to go for the former option when generating from the summary metadata, as in general the summary would be wrapped in <div> or similar anyway, and it's cleaner for RSS output.
Talking of which, I added a custom summary to one of the test pages in hugolib/site_test.go to ensure that the output XML is correct with summary metadata that contains markdown; test is in hugolib/rss_test.go.
I haven't studied the Hugo codebase to any great depth so please do take a good look at the changes and let me know if there is anything that's incorrect here.  Thanks.

Thanks. There are some tests that fail.

Okay, the issue was that the tests were in Markdown source and although I excluded the RST processor from the tests I missed the Asciidoc one due to not having it installed locally.  Tests should be passing now.

@mcdee Please update the documentation too .. grep for Summary in the existing docs and makes changes related to this feature wherever appropriate. It would also be really useful to specify the new summary front-matter variable somewhere.
Thanks.

@kaushalmodi I was planning to do that after this PR was accepted; didn't want to write docs against a moving target.

@mcdee This looks just right, thanks for this. I merged this quickly to get it into my ongoing manual testing for Hugo 0.55 (a rather massive and cool release). I would really appreciate if you could update the docs (in the /docs folder in this repo) in a separate PR with the summary changes.


Fix typo

@juniorrojas Note that this tutorial is for an old version of Lean, and it is around only for historical purposes. We are not maintaining it any more. The new version is here: https://leanprover.github.io/theorem_proving_in_lean/.


Delta backups done against full rather than incrementals

Hi @ddebeau I am seeing in my aws console that the incrementals created are based on the full rather than on previews incremental.

If you look at my backups, they are getting bigger and bigger duplicating a lot of data. I can't create a new full as it needs to be stored for 6 months due to deep archive constraints. I am open to create a PR to solve this but I wanted your opinion on the subject.
This affects:

Backups: They need to look into the latest incremental and use that as a base
Restores: They need to restore the full and all the chain of incrementals up to the point where the user specifies in time

The savings would be massive across time
Thanks

I would support a PR that adds true incremental backup support. The backup object should support it. Just the backup and restore logic would need to be changed.
The feature would be a pretty big undertaking. Let me know if you have any questions or run into any issues creating new tests!

Finally I completed this work! PR: https://github.com/ddebeau/zfs_uploader/pull/75


Unable to eliminate queuing of requests

I have a requirement wherein many parallel requests hit the hosted Takes server.
I need to identify the port of the source from which the request is being sent. This will help me track back-to-back requests and then return a response stating something like - 'Successive requests from a process shall be processed at an interval of 500ms only'.
Or is there any solution to gracefully reject successive requests from a same source if they are too frequent ?

@flouou


logging api

It would be nice to use the logging module so we can spit out debug logs, etc.  I've been sprinkling print statements around and (usually) remembering to take them out before merging in PRs, but some debug info would be good to keep in, hidden behind a flag or environment variable so it doesn't spam normal users.

+1, down to blanket replace prints with this


Integrate lido-exporter into the monitoring stack

Changes:

Add lido-exporter as a service in the monitoring stack

Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Other (please describe):

Testing
Requires testing

[x] Yes
[ ] No

In case you checked yes, did you write tests?

[x] Yes
[ ] No

Codecov Report
Attention: Patch coverage is 58.73786% with 85 lines in your changes missing coverage. Please review.

Project coverage is 44.47%. Comparing base (464352d) to head (e73b712).

Files with missing lines
Patch %
Lines

internal/monitoring/monitoring.go
27.41%
44 Missing and 1 partial :warning:

...ernal/monitoring/services/lido_exporter/service.go
67.56%
10 Missing and 2 partials :warning:

cli/cli.go
60.71%
6 Missing and 5 partials :warning:

internal/monitoring/data/monitoring.go
33.33%
6 Missing and 4 partials :warning:

cli/monitoring.go
92.72%
2 Missing and 2 partials :warning:

cmd/sedge/main.go
0.00%
3 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #420      +/-   ##
===========================================
+ Coverage    44.34%   44.47%   +0.13%
===========================================
  Files          114      115       +1
  Lines         9797     9965     +168
===========================================
+ Hits          4344     4432      +88
- Misses        4991     5057      +66
- Partials       462      476      +14

Flag
Coverage Δ

unittests
44.47% <58.73%> (+0.13%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


suggest academy lesson based on sql or cartocss errors

If someone tries a SQL/PostGIS command but gets and error from running the SQL command, it'd be nice to have a system that read the keywords and suggests and academy lesson to browse as a resource.
"We see you're trying to JOIN data but having trouble.. check out our academy lesson on joins for more information!"
Same thing goes for CartoCSS, infowindows, etc.
cc @saleiva @andrewxhill

This need to be configurable to disable it in onpremise

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


解包至Checkpoint的阶段发生报错

Celeste某个版本后目前本工具有点小问题。。。拆好的资源我在贴吧也发过一份。

Here's the same error in English

@noiob Thanks for your report. I have known that the tool has some problems with the latest Celeste. I will fix it as soon as possible these days.

@ChichiMomo @noiob
Try the new release: https://github.com/wtdcode/CelesteExtractor/releases/tag/v1.1.

That works perfectly! Thanks a lot!


Can't get GeneratedDatabaseHolder

DBFlow Version:
4.2.4
Bug or Feature Request:
Can't get GeneratedDatabaseHolder。
Description:
When I did the FlowManager.init(this);throws ClassNotFoundException tell me
GeneratedDatabaseHolder Not Found。Your comments tell me this：warning if a library uses DBFlow with module support but the app you're using doesn't support it.
This is my configuration.：
compileSdkVersion: 27,
minSdkVersion    : 17,
targetSdkVersion : 27
supportVersion = "27.1.0"
My device version is.
Android：v4.4.4

You can look at https://agrosner.gitbooks.io/dbflow/content/MultipleModules.html


Dark mode

The page is not ready for dark mode, transparency into the pngs is not helpful.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: add3636d-1287-4879-1c87-13a90cd8321b
Version Independent ID: f9a7290e-9118-af3c-25f6-4b57a8be99e8
Content: Azure Cosmos DB bulk executor library overview
Content Source: articles/cosmos-db/bulk-executor-overview.md
Service: cosmos-db
GitHub Login: @tknandu
Microsoft Alias: ramkris

@JuanKRuiz Thanks for pointing out, I submitted a PR to fix the image. Changes will be live later today.  We will now close this issue.
#please-close


Compiletime ops bounds fail inside of inlined def

If we remove inline from def check then the code compiles.
Compiler version
v3.2.0-RC2
Minimized code
https://scastie.scala-lang.org/vb2kekoaSO6lBZzwIQl8fw
import compiletime.ops.*

class Inlined[T](val value : T)
object Inlined:
  trait TC[UB, R]:
    type Out <: UB
    def apply(arg: R): Inlined[Out]
  object TC:
    transparent inline given fromVal[UB, R <: UB]: TC[UB, R] = new TC[UB, R]:
      type Out = R
      def apply(arg: R): Inlined[R] = forced[R](arg)
    transparent inline given fromInline[UB, R <: UB, I <: Inlined[R]]: TC[UB, I] =
      new TC[UB, I]:
        type Out = R
        def apply(arg: I): Inlined[R] = arg

  protected inline def forced[T](_value: Any): Inlined[T] = Inlined[T](_value.asInstanceOf[T])

  def add[T <: Int, R](lhs: Inlined[T], rhs: R)(using tc: TC[Int, R]) =
      forced[int.+[T, tc.Out]](lhs.value + tc(rhs).value)
  def get[T <: Int](inlined: Inlined[T]) : T = inlined.value

object Test:
  inline def check[UB <: Int](ub: Inlined[UB]): Unit =
    val y = Inlined.get(Inlined.add(ub, 1)) //error

Output
Found:    Playground.Inlined[UB + ?2.Out]
Required: Playground.Inlined[T]

where:    ?2 is an unknown value of type Playground.Inlined.TC[Int, Int]
          T  is a type variable which is an alias of UB + (param)1
          UB is a type in method check with bounds <: Int

Expectation
No error

@smarter, since you're experimenting with Named Tuples, this issue may affect you because named tuples are implemented with the same compiletime.ops mechanism.


loadPartitionedParquetAlignments fails with Reference.all

scala> import org.bdgenomics.adam.rdd.ADAMContext._
import org.bdgenomics.adam.rdd.ADAMContext._

scala> val alignments = sc.loadAlignments("adam-core/src/test/resources/small.sam")
alignments: org.bdgenomics.adam.rdd.read.AlignmentRecordRDD = RDDBoundAlignmentRecordRDD with 2 reference sequences, 0 read groups, and 2 processing steps

scala> alignments.saveAsPartitionedParquet("small.partitioned.alignments.adam")

scala> val partitioned = sc.loadPartitionedParquetAlignments("small.partitioned.alignments.adam")
partitioned: org.bdgenomics.adam.rdd.read.AlignmentRecordRDD = DatasetBoundAlignmentRecordRDD with 2 reference sequences, 0 read groups, and 2 processing steps

scala> partitioned.sequences
res1: org.bdgenomics.adam.models.SequenceDictionary =
SequenceDictionary{
1->249250621, 0
2->243199373, 1}

scala> partitioned.dataset.count()
res0: Long = 20

scala> partitioned.dataset.filter(partitioned.dataset.col("contigName").equalTo("1")).count()
res2: Long = 20

scala> partitioned.dataset.filter(partitioned.dataset.col("contigName").equalTo("2")).count()
res3: Long = 0

scala> val chr1 = sc.loadPartitionedParquetAlignments("small.partitioned.alignments.adam", Seq(ReferenceRegion.all("1")))
chr1: org.bdgenomics.adam.rdd.read.AlignmentRecordRDD = DatasetBoundAlignmentRecordRDD with 2 reference sequences, 0 read groups, and 2 processing steps

scala> chr1.dataset.count()
res4: Long = 0

scala> val chr1 = sc.loadPartitionedParquetAlignments("small.partitioned.alignments.adam", Seq(ReferenceRegion.fromGenomicRange("1", 0L, 249250621L)))
chr1: org.bdgenomics.adam.rdd.read.AlignmentRecordRDD = DatasetBoundAlignmentRecordRDD with 2 reference sequences, 0 read groups, and 2 processing steps

scala> chr1.dataset.count()
res5: Long = 20

Ping @jpdna for triage

Is it expected that:
scala> ReferenceRegion.all("1")
res7: org.bdgenomics.adam.models.ReferenceRegion = ReferenceRegion(1,0,9223372036854775807,INDEPENDENT)

surely<PHONE_NUMBER>854775807 is not correct?
If I try to use that ReferenceRegion directly I get an error printed to the console
scala> val chr1 = sc.loadPartitionedParquetAlignments("small.partitioned.alignments.adam", Seq(ReferenceRegion(1,0,9223372036854775807,INDEPENDENT) )
<console>:1: error: integer number too large
val chr1 = sc.loadPartitionedParquetAlignments("small.partitioned.alignments.adam", Seq(ReferenceRegion(1,0,9223372036854775807,INDEPENDENT) )

but it would seem that error is getting swallowed by the loadPartitionedParquetAlignments call.

Ah yeah<PHONE_NUMBER>854775807 is Long.MaxValue at
https://github.com/bigdatagenomics/adam/blob/1bfddc69a86212ffa6810db79fd30da178ea30a4/adam-core/src/main/scala/org/bdgenomics/adam/models/ReferenceRegion.scala#L165
I'm looking further...

Closed by #1980.


Compile demos using the new babel optimizations for react 0.14

https://facebook.github.io/react/blog/2015/09/10/react-v0.14-rc1.html#compiler-optimizations

#205 is also needed for this

cc @bsansouci too if you're ever bored and want to add this


v0.9.4 Debug panic! Expected to have op token: :

on this file https://github.com/denoland/deno/blob/5d7bcf86fdb2bfcee0bfac24aeb7aeecb8b3faca/cli/tests/workers_test.ts

@ry thanks, but could you hold off on opening more issues for a bit? I have a feeling that the latest swc minor version bump broke all this as there was a change related to token capturing, but maybe not.
I'm not seeing any of these files panic in the playground, but perhaps they are debug only panics.

Sure - sorry for the flood  : )
Yes these are debug panics.

@ry no problem! Yeah, my dprint tests panic when I delete my lock file and go from swc 0.21.6 to 0.21.7. I'll look into this tonight after work, but it's related to the fix for https://github.com/swc-project/swc/issues/726

Opened https://github.com/swc-project/swc/issues/728

@ry I did a 0.9.5 release that pegs the swc_ecma_parser version. I think I'll keep it pegged from now on so I'm able to run every new swc version through my test suite before doing a release and so we don't run into this problem again.


updating 3D rendering

revising the rendering commands, and the examples that use them, to match heading of current turtle state

resolves #27 - ultimately.

Fixed!


Improve data loading

Explore tensorflow dataset
Explore alternatives

Problem: currently whole dataset is loaded in memory, tensorflow dataset might solve this.
There also needs to be functionality to download the dataset from the internet (figshare)
@raar1 can you share the link to the dataset?

related: #49

All Prosit data for the 2019 model can be found here: https://figshare.com/projects/Prosit/35582
Training and holdout datasets for the fragmentation models are here: https://figshare.com/articles/dataset/ProteomeTools_-_Prosit_fragmentation_-_Data/6860261

It looks like there is not a good alternative for tensorflow datasets apart from making something custom.

Closing this issue because more precise issues have been created.


Review rafid-test branch

Review rafid-test branch and see if we can delete it

ohhh i see it, it was last updated 2 weeks ago I think we can delete it. I don't see any functionality there that main doesnt have.
lmk if u agree and we can delete

awesome. deleting it now


Detecting Theme Change

I'm submitting a ...  (check one with "x")

[ ] bug report
[ ] feature request
[X] question

Issue description
I am currently using the ngx-admin along with other components like ag-grid where themes are involved in those components as well. Other components have their own themes.
How do I detect the theme change, so that I can change the theme everywhere.
Current behavior:
When I change the ngx admin theme the other themes do not change which is making the app look bad.
Expected behavior:
When I change the ng admin theme the other component themes should change.
Steps to reproduce:
Use an ag-grid with a blue theme in the ngx-admin and try changing it to light.
Other information:
npm, node, OS, Browser
Node, npm: `v9.3.0 and `6.0.0`
OS: Windows 10
Browser: Chrome or FireFox

Hi @nsankaranarayanan, you can subscribe to a onThemeChange method of NbThemeService. Will add to the documentation.

That works. Thanks.