Remove dependence on Fabric Mixin

Fabric Mixin can be extremely outdated at times, and does not reflect the true nature of Mixins in Forge, we should release patched versions of mixins ourselves.

I don't know if you are interested in this (its very hacky), but I kind of got fabric mixins working using this:
https://github.com/IzzelAliz/MixinLoader
and a patch that

Changes it to use fabricmc's mixin
Fixes a bug where mixin is passing in some/package/ClassName to the Forge classloader for bytecode transformation, but it is actually expecting the dot format.

diff --git a/build.gradle b/build.gradle
old mode 100644
new mode 100755
index c554b32..0f2f59c
--- a/build.gradle
+++ b/build.gradle
@@ -10,7 +10,8 @@ java.toolchain.languageVersion = JavaLanguageVersion.of(16)
 repositories {
     mavenCentral()
     maven { url = 'https://files.minecraftforge.net/maven' }
-    maven { url = 'https://repo.spongepowered.org/maven' }
+    //maven { url = 'https://repo.spongepowered.org/maven' }
+    maven { url = 'https://maven.fabricmc.net' }
 }

 configurations {
@@ -20,7 +21,10 @@ configurations {
 }

 dependencies {
-    embed 'org.spongepowered:mixin:0.8.3'
+    //embed 'org.spongepowered:mixin:0.8.3'
+    embed ('net.fabricmc:sponge-mixin:0.9.4+mixin.0.8.2') {
+        transitive false
+    }
     implementation 'cpw.mods:modlauncher:9.0.7'
     implementation 'cpw.mods:grossjava9hacks:1.1.0'
     implementation group: 'net.sf.jopt-simple', name: 'jopt-simple', version: '5.0.4'
diff --git a/gradlew b/gradlew
old mode 100644
new mode 100755
diff --git a/src/main/java/io/izzel/mod/mixinloader/MixinLoaderLaunchPlugin.java b/src/main/java/io/izzel/mod/mixinloader/MixinLoaderLaunchPlugin.java
old mode 100644
new mode 100755
index 452de16..88f1c38
--- a/src/main/java/io/izzel/mod/mixinloader/MixinLoaderLaunchPlugin.java
+++ b/src/main/java/io/izzel/mod/mixinloader/MixinLoaderLaunchPlugin.java
@@ -70,9 +70,13 @@ public record MixinLoaderLaunchPlugin(ILaunchPluginService delegate) implements

     @Override
     public void initializeLaunch(ITransformerLoader transformerLoader, NamedPath[] specialPaths) {
+ITransformerLoader wrapper = (className) -> {
+    final var name = className.replace('/', '.');
+    return transformerLoader.buildTransformedClassNodeFor(name);
+};
         try {
             var handle = MixinLoaderService.LOOKUP.findVirtual(delegate.getClass(), "initializeLaunch", MethodType.methodType(void.class, ITransformerLoader.class, Path[].class));
-            handle.invokeWithArguments(delegate, transformerLoader, null);
+            handle.invokeWithArguments(delegate, wrapper, null);
         } catch (Throwable e) {
             throw new RuntimeException(e);
         }
diff --git a/src/main/java/io/izzel/mod/mixinloader/MixinLoaderService.java b/src/main/java/io/izzel/mod/mixinloader/MixinLoaderService.java
old mode 100644
new mode 100755
index a103c89..aea4886
--- a/src/main/java/io/izzel/mod/mixinloader/MixinLoaderService.java
+++ b/src/main/java/io/izzel/mod/mixinloader/MixinLoaderService.java
@@ -202,7 +202,7 @@ public class MixinLoaderService implements ITransformationService {

     private static void addClassesToClassloader() throws Throwable {
         load(new Path[]{
-            extract("mixin-0.8.3.jar", "./libraries/org/spongepowered/mixin/0.8.3/mixin-0.8.3.jar")
+            extract("sponge-mixin-0.9.4+mixin.0.8.2.jar", "./libraries/org/spongepowered/mixin/0.8.3/mixin-0.8.3.jar")
         });
     }

This doesn't work fully though. There is a strange issue with classloading.
If you try to use a CallbackInfo(Returnable) it fails to find the sponge classes.
At first I thought it was a bug in the way the above mod hacks sponge into the classloader, but trying to implement it properly also leads to Forge's classloader being unable to load the sponge plugin using the java.util.ServiceLoader.
In my testing, I can't even use the forge classloader to getResource() the URL for the sponge class files, even though I can see the jar on my classpath when I print out the system properties?
I am obviously overlooking something, but don't know what it is.

By the way, the sponge mixin plugin has the same issue as this:
https://github.com/architectury/architectury-loom-runtime/blob/master/src/main/java/dev/architectury/loom/forgeruntime/mixin/ForgeLoomMixinRemapperInjectorService.java
beginScanning() now returns a List
but that shouldn't stop it getting classloaded.

This should be resolved with the new architectury-mixin.


Sensorstoshow table column

Description

Added sensors_to_show column in generic_asset table
Copy over sensors_to_show data from inside the attributes column to the sensors_to_show  column.
Logic to copy over data from inside the attributes field to the sensors_to_show  field for new assets or newly added sensors

Look & Feel
There isn't any visual change.

How to test

Run the new migrations with the command: flexmeasures db upgrade
Visit the asset detail page: Asset Detail

Further Improvements
The function name process_sensors, there could be a better name for it, I am open to suggestions
Related Items
This PR closes the second task in #1076

[x] I agree to contribute to the project under Apache 2 License.
[x] To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

The db migration works well, it seems!
I encountered a problem when visiting an asset page, though. Here is the db content (after migration):
 id |            name            | latitude | longitude |              attributes               | parent_asset_id | generic_asset_type_id | account_id | consumption_price_sensor_id | production_price_sensor_id | sensors_to_show
----+----------------------------+----------+-----------+---------------------------------------+-----------------+-----------------------+------------+-----------------------------+----------------------------+------------------
 32 | Leaf van XY |   22 |    33 | {"sensors_to_show": [14, 73, 74, 75]} |                 |                     5 |          1 |                             |                            | [14, 73, 74, 75]

Looks okay to me. But the error (when visiting http://localhost:5000/assets/32) is:
  File "/home/nicolas/workspace/seita/flexmeasures/flexmeasures/ui/crud/assets/utils.py", line 111, in process_internal_api_response
    asset = GenericAsset(
  File "<string>", line 4, in __init__
  File "/home/nicolas/envs/fm-3.10/lib/python3.10/site-packages/sqlalchemy/orm/state.py", line 571, in _initialize_instance
    with util.safe_reraise():
  File "/home/nicolas/envs/fm-3.10/lib/python3.10/site-packages/sqlalchemy/util/langhelpers.py", line 146, in __exit__
    raise exc_value.with_traceback(exc_tb)
  File "/home/nicolas/envs/fm-3.10/lib/python3.10/site-packages/sqlalchemy/orm/state.py", line 569, in _initialize_instance
    manager.original_init(*mixed[1:], **kwargs)
  File "/home/nicolas/workspace/seita/flexmeasures/flexmeasures/data/models/generic_assets.py", line 145, in __init__
    super().__init__(*args, **kwargs)
  File "/home/nicolas/envs/fm-3.10/lib/python3.10/site-packages/sqlalchemy/orm/decl_base.py", line 2170, in _declarative_constructor
    setattr(self, k, kwargs[k])
  File "/home/nicolas/envs/fm-3.10/lib/python3.10/site-packages/sqlalchemy/orm/attributes.py", line 537, in __set__
    self.impl.set(
  File "/home/nicolas/envs/fm-3.10/lib/python3.10/site-packages/sqlalchemy/orm/attributes.py", line 1277, in set
    value = self.fire_replace_event(
  File "/home/nicolas/envs/fm-3.10/lib/python3.10/site-packages/sqlalchemy/orm/attributes.py", line 1292, in fire_replace_event
    value = fn(
  File "/home/nicolas/envs/fm-3.10/lib/python3.10/site-packages/sqlalchemy/orm/events.py", line 2573, in wrap
    return fn(target, *arg)
  File "/home/nicolas/envs/fm-3.10/lib/python3.10/site-packages/sqlalchemy/ext/mutable.py", line 536, in set_
    value = cls.coerce(key, value)
  File "/home/nicolas/envs/fm-3.10/lib/python3.10/site-packages/sqlalchemy/ext/mutable.py", line 972, in coerce
    return Mutable.coerce(key, value)
  File "/home/nicolas/envs/fm-3.10/lib/python3.10/site-packages/sqlalchemy/ext/mutable.py", line 455, in coerce
    raise ValueError(msg % (key, type(value)))
ValueError: Attribute 'sensors_to_show' does not accept objects of type <class 'str'>

Which extra value do we get from using MutableList, actually? Better protection against other values comin in?

i came across this as well but I am yet to find where this action is occurring

It seems that entries of the list need to be of a certain type, and that a string does not do. But I believe a simple string is also valid JSON?
You can also play around with this directly, opening flexmeasures shell, importting GenericAsset and try creating one in various ways. That might be most effective.
Or maybe we should try not using the MutableList, just making it a JSON field and see if that solves this issue?

does not accept objects of type <class 'str'>

I actually was able to find where the issue was, a section of the code was incorrectly parsing a string (JSON) instead of a list of JSON objects, which led to the error. After identifying this part, I made a small conversion to ensure it properly handles a list of JSON objects, and now it works as expected.


[Feature]: Suggestions on chat APIs

Contact Details(optional)
No response
What feature are you requesting?

remove GET /api/chat, this can cause serious privacy issues.

Add api to generate a token for anonymous users before they can start any conversation, this should be the identifier temporarily

APIs requests should pass user token for validation,
token should be changed on each login/register/anonymous query, should have expire time - e.g. 24hrs, should can extract logged-in user id somehow to append to user history, instead of pass user id that anonymous users doesn't have, and pass id is not safe as well.

POST /api/chat session id should return a complex string to avoid information leak. add also token in coming request. e.g. request should be

POST xxx/api/chat HTTP/1.1
Content-Type: application/json
{
token: string,
sessionId?: string,
message: string
}

GET /api/chat/{id} doesn't seems to work at this moment, should also add token, a better way could be GET /api/chat?id=?&token=?

GET /api/chat/history/{id} - description is Chat:Get-Chat-History-By-Account-Id which should be chat session id? can also change to GET /api/chat/history?session-id=?&token=?

[ ] #180

As we discussed, we need to make a solution for this.


added keepass2

Build the container:
docker build -t keepass2 .

Run the container and mount your keepass2 database file:
docker run -it -v /home/$USER/DB.kdbx:/root/DB.kdbx -v /tmp/.X11-unix:/tmp/.X11-unix -e DISPLAY=$DISPLAY keepass2

Fixed and rebased!

thanks!


The models are automatically copied into your grobid-home

The models are automatically copied into your grobid-home instead of manually copying them. Edited the documentation as well to reflect that.

@lfoppiano In https://github.com/kermitt2/grobid-quantities/commit/c97b48ff2b26914374c2ce9301805c16c181747c you deleted the task copyModels, please add it back in build.gradle

Sorry @yoannspace it wasn't intentional. 😄 not enough coffee


Invalidate instant execution cache upon changes to the sequence of init scripts

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.


Ping indicator freezes after some time

Not sure if it's been reported yet, but I notice that after the season 4.5 update, sometimes the ping display just freezes after playing the game for a while and won't update when I change to servers with a different ping. Not sure if it's a problem with the tracker or it's due to some changes within the code of the game.

I have the same problem 2 days ago.

I think this is more on Fall Guys  than the tracker as they changed something that breaks the ping

I recently opened a related issue #100.
The game doesn't update the log file with the ping after some time. So there is nothing they can do to fix it.
It started to happen after the 4.5 update, I hope they write it again in season 5.


SSL Support

We really should be using SSL, this tutorial using LetsEncrypt is quite good

Also need to think about where prod deployment will be. Possibly AWS free tier (https://testdriven.io/blog/django-docker-https-aws/ ) but RDS only 12mo free.


refactor: use transports everywhere + change publicerc4337client to bundlerclient

Pull Request Checklist

[ ] Did you add new tests and confirm existing tests pass? (yarn test)
[ ] Did you update relevant docs? (docs are found in the site folder, and guidelines for updating/adding docs can be found in the contribution guide)
[ ] Do your commits follow the Conventional Commits standard?
[ ] Does your PR title also follow the Conventional Commits standard?
[ ] If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
[ ] Did you run lint (yarn lint:check) and fix any issues? (yarn lint:write)
[ ] Did you follow the contribution guidelines?

PR-Codex overview
Focus of this PR:
This PR focuses on replacing the publicErc4337Client with the bundlerClient in various files.
Detailed summary:

Deleted packages/core/src/client/publicErc4337Client.ts.eslintignore file.
Updated .github/* and /.nx/cache in the .eslintignore file.
Updated lerna.json file by removing "useNx": true.
Updated packages/core/src/client/decorators/smartAccountClient.ts file by renaming smartAccountClientDecorator to smartAccountClientActions.
Updated yarn.lock file.
Updated nx package version in nx.json file.
Updated packages/core/src/account/schema.ts file by omitting rpcClient and extending the schema.
Updated packages/core/src/client/smartAccountClient.test.ts file by replacing publicErc4337 with bundler in imports.
Updated packages/ethers/src/types.ts file by replacing PublicErc4337Client with BundlerClient.
Updated packages/accounts/src/msca/plugins/multi-owner/signer.ts file by replacing PublicErc4337Client with BundlerClient.
Updated packages/core/src/client/schema.ts file by replacing PublicErc4337Client with BundlerClient.
Updated packages/ethers/src/account-signer.ts file by replacing PublicErc4337Client with BundlerClient.
Updated packages/alchemy/src/client/types.ts file by replacing PublicErc4337Client with BundlerClient.
Updated packages/core/src/actions/bundler/getSupportedEntrypoints.ts file by replacing Erc4337RpcSchema with BundlerRpcSchema.
Updated packages/core/src/actions/bundler/getUserOperationByHash.ts file by replacing Erc4337RpcSchema with BundlerRpcSchema.
Updated packages/core/src/actions/bundler/getUserOperationReceipt.ts file by replacing Erc4337RpcSchema with BundlerRpcSchema.
Updated packages/core/src/actions/bundler/sendRawUserOperation.ts file by replacing Erc4337RpcSchema with BundlerRpcSchema.
Updated nx.json file by removing "tasksRunnerOptions".
Updated nx.json file by adding "cache": true to build, test, and generate targets.
Updated nx.json file by adding "cache": true to generate target.
Updated packages/ethers/src/provider-adapter.ts file by replacing createPublicErc4337FromClient with createBundlerClientFromExisting.
Updated packages/ethers/src/provider-adapter.ts file by replacing getPublicErc4337Client with getBundlerClient.
Updated packages/core/src/actions/bundler/estimateUserOperationGas.ts file by replacing Erc4337RpcSchema with BundlerRpcSchema.
Updated packages/core/src/account/types.ts file by replacing PublicErc4337Client with BundlerClient.
Updated packages/accounts/src/nani-account/__tests__/account.test.ts file by replacing createPublicErc4337Client with createPublicClient.
Updated packages/accounts/src/msca/utils.ts file by replacing createPublicErc4337FromClient with createPublicClient.

The following files were skipped due to too many changes: packages/alchemy/src/client/lightAccountClient.test.ts, packages/core/src/middleware/actions.ts, package.json, packages/ethers/src/__tests__/provider-adapter.test.ts, packages/alchemy/src/client/rpcClient.ts, packages/accounts/src/light-account/account.test.ts, packages/alchemy/src/client/lightAccountClient.ts, site/migration-guide.md, packages/core/src/utils/testUtils.ts, packages/core/src/index.ts, packages/accounts/src/light-account/e2e-tests/light-account.e2e.test.ts, packages/accounts/src/light-account/createLightAccountClient.ts, packages/accounts/src/light-account/account.ts, packages/accounts/src/msca/account/multiOwnerAccount.ts, packages/core/src/account/base.ts, packages/core/src/account/smartContractAccount.ts, packages/core/e2e-tests/simple-account.e2e.test.ts, packages/core/src/account/simple.ts, packages/core/src/client/bundlerClient.ts, packages/core/src/account/__tests__/simple.test.ts, packages/accounts/src/nani-account/account.ts, packages/accounts/src/msca/account/sessionKey.ts, packages/core/src/client/smartAccountClient.ts, packages/core/src/client/decorators/publicErc4337Client.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

thanks for incorporating the comments?


Works only when deployed to azure?

Just for my understanding: This method would only work when deployed to azure as functions proxys are not yet supported by the cli (https://github.com/Azure/azure-functions-core-tools/issues/102). Is that correct?
Thank you!

Proxies should be available in V2 CLI now. I haven't personally tested it though. Let me know if the static file server works for V2. I suspect some changes are required.


Support Edge

make the extension compatible with MS Edge

still no response from MS Store

Any update on this and Safari's extension? Do you intend to support these 2 browsers via the CI build pipeline?

MS Edge extensions are not really worth energy at the moment IMO

FWIW: Edge makes up about 1% of the traffic to my tools, while Safari makes up 13%.
For reference, Chrome has a commanding lead at 73%, while Firefox is third with 8%. If those demos are similar in your tools/extension, then the browser priority list would be Chrome -> Safari -> Firefox, which together represent nearly 95% of users.

with Edge, i had to apply to post on their "addon store". Here's where I applied, no response yet: https://developer.microsoft.com/en-us/microsoft-edge/extensions/requests/

I agree it might not be worth the effort until they figure out what they are doing with Edge. Seems they are replacing it with Chrome base. Once they have it stable and process ironed out, it should be a very easy way to add it to their addon store too.


Execution time on report is coming as 00:00:00 for all tests.

This is likely an issue with the reporter plugin. I think you mean html-report here.
Nothing seems to wrong with gauge-js in this respect. I see proper timestamp in the console log, but I think the html-report rounds the timestamp wrongly.

See the discussion at getgauge/html-report#10. You should close this issue here.

Oh wait. The code is currently passing "0" as execution time for all steps in src/processor/ExecuteStepProcessor.js. That looks like the reason.

Reopening this to use duration property in resolve promise in done() in ./src/test.js to detect time taken for each step/hook.

Implemented.


Version 2.0.0 incorrectly lists 'StreamsJS Version: STREAMS_VERSION'

in Version 2.0.0 in the logs, it prints 'STREAMS_VERSION' instead of the expected '2.0.0', previously displayed correctly in 1.7.5
example log:
{
"component": "ccp",
"level": "INFO",
"text": "StreamsJS Version: STREAMS_VERSION",
"time": "2022-01-22T19:13:54.029Z",
"exception": "null",
"objects": "[]",
"line": 8,
"agentResourceId": null,
"loggerId": "1642878832848",
"_oriKey": 12,
"_ts":<PHONE_NUMBER>029,
"_key": 17
}

Thanks for reporting, looking into this.

Merged the PR and the issue is fixed from version 2.1.1.


Do something with dotenv finally

Hi, there is problem with dotenv+windows+apache that .env is sometimes ignored and default configuration is used https://github.com/laravel/framework/issues/8191
The worst thing is there is possible security problem in some Laravel applications, consider encryption key in .dotenv https://github.com/vlucas/phpdotenv/issues/76
Therefore .env files should not be used for production, even official notes state that:

phpdotenv is made for development environments, and generally should not be used in production.
https://github.com/vlucas/phpdotenv#usage-notes

However, Laravel documentation implies that .env files should be used for different enviroments (local, production server !!!) https://laravel.com/docs/5.2/configuration#environment-configuration
I know this can be "fixed" with php artisan config:cache which creates .php file with all config options but reliability and security must not depend on one shell command. Another issue is that the command is not mentioned in the docs.

You need to config cache first. Not a bug.

We don't expect it to work if you forget to do that.

You need to config cache first. Not a bug.

What is the real reason to run artisan command config:cache?

Apache/PHP on Windows is flawed?
Laravel allows dotenv for production even dotenv is not intended for production?
Both above

We don't expect it to work if you forget to do that.

Then it should be in docs near the dotenv section. With red fat warning that if a programmer does not run "php artisan config:cache" then the app is hackable and sometimes it will response with HTTP 500 which is not handled by ExceptionHandler.
There should be another red warning that states if programmer does not notice the first warning, he/she will spend half a day debugging and thinking whether get rid of dotenv, or get rid of Apache, or get rid of Laravel.


[DRAFT] Add retry when trying to bind to gRPC port.

Signed-off-by: Artur Souza<EMAIL_ADDRESS>Description

Issue reference

Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

@artursouza  I found many similar logs in dapr container logs. This log is more clear that the 50001 port is used (or not free in time) :
time="2022-08-31T03:53:31.6769864Z" level=warning msg="Failed to listen on [::1]:50001 with error: listen tcp [::1]:50001: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted." app_id=actorfeatures instance=actorfeatures-586d955bb-jcdtg scope=dapr.runtime.grpc.api type=log ver=edge

time="2022-08-31T03:53:31.6769864Z" level=warning msg="Failed to listen on <IP_ADDRESS>:50001 with error: listen tcp <IP_ADDRESS>:50001: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted." app_id=actorfeatures instance=actorfeatures-586d955bb-jcdtg scope=dapr.runtime.grpc.api type=log ver=edge

time="2022-08-31T03:53:31.6769864Z" level=fatal msg="failed to start API gRPC server: could not listen on any endpoint" app_id=actorfeatures instance=actorfeatures-586d955bb-jcdtg scope=dapr.runtime type=log ver=edge

This test did not show potential. Closing.


[AutoDiff] Fix inout parameters + subset parameters thunk crash.

Update subset parameters thunk logic to handle original inout parameters.
Fix pullback thunk inout argument forwarding. Improve comments.
Add end-to-end correctness and SIL FileCheck tests.
Resolves TF-1204.

@swift-ci Please test tensorflow

Merging to unblock progress. This fix unblocks a user.


fix(curriculum):Not allowing attributes outside link

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #45215

fixed the attributes to be inside the tag.
didnt change the closing tag so it wont cause inconsistensy, if it's desired i could do an easy fix to allow that.

@raisedadead fixed my friend! missed one digit there. thank you!


Burn, Mint permission checks

Also some doc comments added.
Signed-off-by: Egor Ivkov<EMAIL_ADDRESS>

Description of the Change

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

Basically it is ok, but there are some unnecessary pattern matching and if let statements.
Would be great to refactor permissions_validators model and use static types more to compose checks like type BurnOnlyOwnedAssets = isi::If(isi::Eq(isi::GetAssetsOwner, Authority), ...

We discussed the possibility to use ISIs to check permissions. But to my mind they are not ,mature enough right now, and therefore we decided to stick with traits and trait objects for now. We had this discussion when finalizing Permissions RFC.

@humb1t I know that you are all for ISI permission checks. My point is that maybe we should reconsider when ISI language is complete and rewrite permissions then, but not know. We are trying to keep things simple for now and reach a small usable MVP release ASAP.


plot func

plots wave func

options for length of axis
option for colour own and standard
option for labels own and standard

Consider this closed as reviewing commit 2d0b463


blender 2.82 import fails and Yup2Zup is not parented properly

While exporting from the govox sample project from https://github.com/jamie-pate/govox
(see attached zip for a canned version)
Exporting the 'main.tscn' -> 'main.gltf2' works fine, but when importing there are errors in blender.
The platform should be a horizontal plane, but it's vertical

blender GLTF2 import:
Traceback (most recent call last):
  File "/usr/share/blender/scripts/addons/io_scene_gltf2/__init__.py", line 850, in execute
    return self.import_gltf2(context)
  File "/usr/share/blender/scripts/addons/io_scene_gltf2/__init__.py", line 864, in import_gltf2
    if self.unit_import(path, import_settings) == {'FINISHED'}:
  File "/usr/share/blender/scripts/addons/io_scene_gltf2/__init__.py", line 887, in unit_import
    BlenderGlTF.create(self.gltf_importer)
  File "/usr/share/blender/scripts/addons/io_scene_gltf2/blender/imp/gltf2_blender_gltf.py", line 41, in create
    BlenderScene.create(gltf, scene_idx)
  File "/usr/share/blender/scripts/addons/io_scene_gltf2/blender/imp/gltf2_blender_scene.py", line 80, in create
    BlenderNode.create(gltf, node_idx, None)  # None => No parent
  File "/usr/share/blender/scripts/addons/io_scene_gltf2/blender/imp/gltf2_blender_node.py", line 174, in create
    BlenderNode.create(gltf, child_idx, node_idx)
  File "/usr/share/blender/scripts/addons/io_scene_gltf2/blender/imp/gltf2_blender_node.py", line 64, in create
    mesh = BlenderMesh.create(gltf, pynode.mesh, node_idx, parent)
  File "/usr/share/blender/scripts/addons/io_scene_gltf2/blender/imp/gltf2_blender_mesh.py", line 67, in create
    BlenderPrimitive.add_primitive_to_bmesh(gltf, bme, pymesh, prim, material_idx)
  File "/usr/share/blender/scripts/addons/io_scene_gltf2/blender/imp/gltf2_blender_primitive.py", line 136, in add_primitive_to_bmesh
    blender_num_components = len(bme_verts[0].link_loops[0][layer])
IndexError: BMElemSeq[index]: index 0 out of range

location: <unknown location>:-1

govox-yup2zup-gltf2.zip
system-info.txt

2.82 Blender is not supported. Will close the issue after a brief reply period.

Works in blender 2.83.5


Refactor spo site ensure to use util instead of calling other command, Closes #5305

Closes #5305

Thank @nicodecleyre for another PR 👍 We will review it ASAP 🕵♂
BTW please do remember to also take care of the already reviewed PRs left in draft awaiting your feedback 🙏

Hi @nicodecleyre,
never mind. Just saw that this was done in the next PRs that I am reviewing and that these all are linked together.
No action required form your end.
br,

Hi @nicodecleyre, thank you very much for your contribution.
I had a look on the specs and it seems that the aim of this PR was to change two commands. I can see that you are manipulating the aad utils over multiple PRs.
Is there any reason to do this? Seems that the tests are not running through. Could you please have a look into this and rebase with the latest version?
Thank you for your feedback,

Hi @plamber,
The goal is indeed to change 2 commands. To replace the spoSiteSetCommand, the util function spo.updateSite is created, which in turn uses aadGroup.setGroup (line 1281). That's why this is also included in this PR.
I've rebased with the latest version

Thank you. Manually merged


Add Xcode 10.1 configuration to project_precommit_check

Adds Swift version 4.2.1 to project_precommit_check, to run with Xcode 10.1 selected.

@swift-ci test


Improve readbility of jvb/vjp/value_and_grad

I had some difficulties understanding the code and I made some changes which I think can improve the readbility of the functions.
There is no changes on the code's actual behavior in this PR, but I will try to simplify the functions once this is merged.
Proposed changes

Add comments and rename some variables to meaningful names.
Use size_t instead of int as vector index when possible, it is easier to tell if the arg supports negative index this way, and this will be required when you enable more compiler warnings in future.
Use explicit type name instead of auto in places where it is hard to tell the type by reading code.
Reorder some code for easier understanding.
For code that does the same thing, make them look the same. (I'll try to remove duplicate code in later PRs.)
Some places were creating copies of arrays implicitly, as a bonus of this PR I changed them to use reference or move semantics.

Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING document
[x] I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have updated the necessary documentation (if needed)

Just found this is crashing C++ tests, closing for now.


How get which route I'm on in a normal class method

i want to get compose current route in a normal method . before I used to judge which fragment I was in . Help :(

I want to know which destination is the current one  in a not Composable function,like in a activity function

Hmm, mostly you should need this inside Composable functions 🤔
Anyway, there is NavController.currentDestinationFlow that you can collect, but you need to get a hold of the NavController that you're passing to DestinationsNavHost.

This works great, thank you very much!


coords format select

Right-click select format?
Would be a great use of shadcn/ui context menu
https://ui.shadcn.com/docs/components/context-menu

Didn't end up using right-click context menus, just a left-click feature
Initially planned to leave the function in misc/utils.js but the code ended up growing to slightly unreasonable length in many iterations to catch all edge-cases a not be FK specific
adds a coords_format_cycler.js component and tweaks event_history and event_details views
Tested on cloud-dev and deployed to production


useless ICE trickle feature in SDK.

as the commit https://github.com/EricssonResearch/openwebrtc-ios-sdk/pull/45
did any one using this send each candidate to other peer right now?
this looks all fine, but when u really using this separate the candidate n media info, you will realize for the audio MAY works, but for the video will NOT working at all.
when there are 2 stream we send the candidate 1 by 1, we didnt know which is audio or video!
and take look into the code index = [remoteCandidate[@"sdpMLineIndex"] intValue];
when added wrong info will take slow pair for candidate and failed!
and one more question for https://github.com/EricssonResearch/openwebrtc-ios-sdk/pull/50
did any one tell me what is a=ice-options:trickle that mean, I didn't found it in rfc5245.

Hey "sdpMLineIndex" seems to specify if it is a candidate for audio or video stream.
My candidates on the web client look like that:
`            if (evt.candidate != undefined && evt.candidate.candidate != undefined) {
            var candidate = "";
            var s = SDP.parse("m=application 0 NONE\r\na=" + evt.candidate.candidate + "\r\n");
            var candidateDescription = s && s.mediaDescriptions[0].ice.candidates[0];
            if (!candidateDescription) {
                candidate = evt.candidate.candidate;
            }

            var metaData = JSON.stringify(
                {
                    "candidate": {
                        "candidate": candidate,
                        "candidateDescription": candidateDescription,
                        "sdpMLineIndex": evt.candidate.sdpMLineIndex
                    }
                }
            );

            // save for debug history
            VIDEOSUPPORT.candidatesHistorySelf.push(metaData);
            hasValidCandidate = true;
        }
    }`

and on the app I do:
    candidate = [candidate[@"candidate"] mutableCopy];     index = [candidate[@"sdpMLineIndex"] intValue];
to get the right index.

of course "sdpMLineIndex" is index audio or video stream, otherwise I won't remind in this topic.
Because in current design the ICE trickle way is useless.
I has been fixed the index and doing cache stuff in my local, and removed the candidate in offer and answer.
But still slow because there designed when generated all candidates done then send offer or answer.
And also the libnice discovery STUN/TURN candidate are slow too.

So you are caching your candidates? We once tried to cache the candidates too, but it did not work. Now we have it working with ICE Trickle on web client but no trickle on iOS. So in iOS all candidates are sent inside the offer/answer and on web we send each candidate as soon as it is created. Now we have stable connections from web2web web2app app2app and app2web. Even without trickle on the iOS client the connection is established really fast (beneath 2 seconds)

Yeah, when u cache the candidate from handle remote candidate receive if u process before offer or answer, that won't work because auth info in candidate.
And also the connection speed depends on your network STUN/TURN (the most time I won't set just 1 services) services and network NAT type.
I not sure which version of OWR you using. I also fast in same Wifi using host to host connection. But when using mobile network got more problems, for example though NAT etc..
Check it out the ref issue on this topic,
Until now after I modified a lot of in libnice and own TURN/STUN services, it goes fast from discovery candidate to pair then got stream.


feat: Create tutorial on parsing arXiv dataset

Overview
@vanitech presented a really great dataset that would be really beneficial to be inserted into the vector database for use as context for the RAG approach. This dataset is essentially all of the papers in arXiv: https://www.kaggle.com/datasets/Cornell-University/arxiv/data
After some investigation it looks like this data lives in Google Cloud Storage, so it can easily be retrieved with fsspec without any credentials!
The kaggle repository does contain an index of this data, we can either just grab the data from gcs or directly from arXiv using langchain arXiv loader: https://python.langchain.com/docs/integrations/document_loaders/arxiv

This is currently being done in #24

https://github.com/uw-ssec/tutorials/commit/d86cc689129294d61ee5b52cf294fb56e9cf14a9

Completed at https://uw-ssec-tutorials.readthedocs.io/en/latest/SciPy2024/appendix/astrophysics-dataset-creation.html


E2E tests with Deno

Add e2e tests for http server with Deno

CHANGELOG :) overall looks good!

Always has been one =]

Deferred to integration tests to be done later.


Support HTML Sanitizer API from browser

https://developer.mozilla.org/en-US/docs/Web/API/HTML_Sanitizer_API
creating a Sanitizer object with const sanitizer = new Sanitizer(); gives the following error:
ReferenceError: Sanitizer is not defined

Hi @GeorgeTailor,
The Sanitizer API is part of the DOM API more generally. While supporting DOM in Workers could be useful, it would be a massive project. We don't currently have any plans to do this, sorry.
For most HTML-oriented uses cases in Workers, HTMLRewriter is actually a better fit. This API allows you to modify HTML in a streaming fashion, which uses less memory and incurs less latency in the Workers context.
We don't currently have any sort of sanitization functionality built into HTMLRewriter, but this might be something that could be provided by a library pretty easily, built on top of HTMLRewriter.
Point of order: I am going to convert this issue into a discussion. We prefer to reserve issues for immediately-actionable bugs and tasks, not for open-ended feature requests. Discussions are a better place for those.


Replace pre-emptive compiler with additional pass

Fixes #27
webpack 2 can run as many compile passes as needed by responding to a
new plugin point called need-additional-pass. The way this PR supports
accurate used modules is through using additional passes as necessary.
This has the benefit of only using one pass when only one is needed and
working with other plugins like HMR that the pre-emptive step was
breaking in cases.

Thank you so much for you work!
I am still having issue:
It works with your plugin enabled when there is no cache yet, but does not work for the 2nd build (when cache is used).
The first time HMR push updated as expected, the second time the dev server send this messages (same as before)
[HMR] Checking for updates on the server...
[HMR] Cannot find update (Full reload needed)
[HMR] (Probably because of restarting the server)

@MoOx I want to guess that you need to clear your cache. You changed the webpack config without clearing the cache (like turning on HMR), leaving modules from a previous render built without the HMR plugin in a build that has HMR on. Those modules that accept hot module changes will have the code that would execute to do that disabled from a build that had HMR disabled.
This raises a really interesting edge case for #17. Its not just being in development or production but it can also be running with the webpack cli tool versus the webpack-dev-server cli tool since the dev-server modifies the webpack options. That is something I wasn't thinking about for #17, so that'll help while I figure out the solution for that. I wish that had a simple answer.

@mzgoddard The dev server always modify the cache in the same way, not sure what's causing this. With webpack 1, everything works perfectly.

Like we said in #17, we use a hash to create/reuse a cache folder. So if HRM worked without cache, and then right after a restart stopped working, isn't it a hard-source plugin issue?
In both run,  HMR was enabled so config didn't changed. (I deleted the cache by hand in the first place, just in case).

@MoOx it could still be hard-source. My hesitance in thinking its that and not clearing the cache or some config thing is from trying to reproduce your stated error. I tried with HMR with the dev-server and hot-middleware. I hit the error with the hot-middleware (though I understand how to repro with dev-server too now). When I looked at the output script I saw that my module.hot block for a stylesheet hadn't been evaluated. It wasn't evaluated because the module was from a cache that had been built without HMR enabled.
Can you look in your built script for the module.hot block that should be working but isn't? Whether its hard-source or not, you should have a module.hot block to accept your changes.
For example style-loader creates a block like
if (module.hot) {
  module.hot.accept('./path/to/content.css', function() {
    var newContent = require('./path/to/content.css');
    /* do stuff with it */
  });
}

With HMR enabled the output of that would look like
if (false) {
  module.hot.accept('./path/to/content.css', function() {
    var newContent = require('./path/to/content.css');
    /* do stuff with it */
  });
}

With HMR enabled it'll look like:
if (true) {
  module.hot.accept(13, function() {
    var newContent = require(13);
    /* do stuff with it */
  });
}

OK, I have if (true)... Not sure what I changed, but seems to be working now...
Will be more careful next time, sorry for the false alarm...

@MoOx no worries. This at least gives me more to document for others and more to think about for stuff like #17 to reduce the possibility you or others using HardSource run into that problem.


feat(Grafana-Dashboards): add cluster label to some metrics

Some queries in Grafana dashboards are missing the cluster labels.
This PR tries to fix this.

Here is the PR at the upstream project https://github.com/kubernetes-monitoring/kubernetes-mixin/pull/542

Here is the PR at the upstream project https://github.com/kubernetes-monitoring/kubernetes-mixin/pull/542

I can not find any cluster label in those metrics, such as container_memory_working_set_bytes 。why?

I can not find any cluster label in those metrics, such as container_memory_working_set_bytes 。why?

I have the cluster label at these metrics:

I have the cluster label at these metrics:

do you set external_labels in prom?
https://github.com/prometheus-operator/kube-prometheus/search?l=YAML&p=1&q=cluster

do you set external_labels in prom?
https://github.com/prometheus-operator/kube-prometheus/search?l=YAML&p=1&q=cluster

This seems to be already completed. Please reopen if this is not already included.


ESlint fragments

https://github.com/alexey-koren/bundlers-boilerplates/blob/95332b2ec6ea9f09c85c7563c7c35865cef63ff5/.eslintrc#L186
Maybe this is better     "react/jsx-fragments" : ["error", "syntax"]
https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-fragments.md

https://github.com/alexey-koren/bundlers-boilerplates/blob/95332b2ec6ea9f09c85c7563c7c35865cef63ff5/.eslintrc#L186 Maybe this is better  "react/jsx-fragments" : ["error", "syntax"] https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-fragments.md

Sure. Fixed


error 404 on click at hostname because it links on icinga v1 ressource

{"error":404.0,"status":"The requested path 'cgi-bin/extinfo.cgi' could not be found or the request method is not valid for this path."}
I use your plugin with icinga2 API. The connection is functionally and shows hosts and services. The link on hostname in the plugin window goes to https://:5665/cgi-bin/extinfo.cgi.....
Could you make it configurable to input the Webserver-URL for the Browser?

Thanks for reporting this, I already realised this myself.
Added the option and pushed a new release to Chrome store (0.3.1) which should be available soon.


Add support for setting up OMAPI key

This is needed so that the puppet-foreman_proxy module will be able to set up OMAPI in the dhcp server when the foreman-installer is called with the dhcp-key-name and dhcp-key-secret options.

Sorry about that. I don't do too much development so I was just copying code from later in the file, but I think I now understand what that if statement was really checking and have fixed the commit.

an added spec test would be very nice[tm]

I removed the space and added the data to the init.pp spec test. How does it all look now?

This is good to go, except the space, which is still there in the commit pushed :)

Everything should be fixed now.

merged, thanks @mrobbert!


curl: (35) error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure

I get this when I run the code from postman no answer. I tried to refer to older issues nothing helps.
var ca = [fs.readFileSync('/etc/ssl/mongo.pem')];
//var ca = [fs.readFileSync('/etc/letsencrypt/live/mydomain.com/fullchain.pem')];

if (!databaseUri) {
  console.log('DATABASE_URI not specified, falling back to localhost.');
}

var api = new ParseServer( {
  databaseURI: databaseUri || 'mongodb://parse:pass@mydomain.com:27017/mydb?ssl=true',
    cloud: process.env.CLOUD_CODE_MAIN || __dirname + '/cloud/main.js',
  appId: process.env.APP_ID || 'id',
  masterKey: process.env.MASTER_KEY || 'master', //Add your master key here. Keep it secret!
  serverURL: process.env.SERVER_URL || 'https://localhost:1337/parse',  // Don't forget to change to https if needed
  liveQuery: {
    classNames: ["Posts", "Comments", "_User"] // List of classes to support for query subscriptions
  }
});
// Client-keys like the javascript key or the .NET key are not necessary with parse-server
// If you wish you require them, you can set them as options in the initialization above:
// javascriptKey, restAPIKey, dotNetKey, clientKey

/*var uri  = 'mongodb://parse:password@mydomain.com:27017/mydb?ssl=true';
var options = {
    mongos: {
    ssl: true,
    sslValidate: true,
    sslCA: ca
   }
};

mongoose.createConnection(uri, options);
*/

Please use Stack Overflow for implementation related questions.

problems was with var httpServer = require('https').createServer(app); changed to http and this issue resolved


Help with combining dnd with virtual list

Hello! I'm trying to combine the virtual list with a drag-and-drop list, and I'm seeing some strange behavior with rendering and dragging. I think it comes down to the way that I'm calculating the number of items to render within dnd::show(), but I'm not sure if I'm approaching the problem correctly.
I've started with the virtual list example and refactored out the drawing to be able to draw dnd elements. Here's the overall structure:
pub fn main() -> eframe::Result<()> {
    let mut items: Vec<_> = (0..100).collect();
    let mut virtual_list = VirtualList::new();
    let mut dragged_item_idx: Option<usize> = None; // used for dragging and dropping across

    eframe::run_simple_native(
        "Virtual List Drag-and-Drop Example",
        Default::default(),
        move |ctx, _frame| {
            CentralPanel::default().show(ctx, |ui| {
                ScrollArea::vertical().show(ui, |ui| {
                    ui.set_width(ui.available_width());
                    // Wrap dnd inside virtual list (see next code snippet)
                });
            });
        },
    )
}

// Helper function for drawing draggable elements
fn draw_item(ui: &mut egui::Ui, handle: egui_dnd::Handle, item: &i32) -> egui::Rect {
    let mut rng = StdRng::seed_from_u64(*item as u64);
    let height = rng.gen_range(0.0..=100.0);

    Frame::canvas(ui.style())
        .inner_margin(Margin::symmetric(16.0, 8.0 + height / 2.0))
        .show(ui, |ui| {
            ui.set_width(ui.available_width());
            handle.ui(ui, |ui| {
                ui.label(format!("Item {}", item));
            });
        }).response.rect
}

And here's how I'm wrapping the dnd list inside the virtual list:
virtual_list.ui_custom_layout(ui, items.len(), |ui, start_index| {
    let mut num_shown = 0;
    let mut used_height = 0f32;

    let response = egui_dnd::dnd(ui, "dnd").show(
        items[start_index..].iter_mut(),
        |ui, item, handle, _dragging| {
            // TODO: exit early if used height exceeds available height
            used_height += draw_item(ui, handle, item).height()
                + ui.spacing().item_spacing.y;
            num_shown += 1;
        },
    );

    // Handle drag start and drag stop
    match dragged_item_idx {
        None => {
            if let Some(update) = &response.update {
                dragged_item_idx = Some(start_index + update.from);
            }
        }
        Some(idx) => {
            if let Some(update) = &response.final_update() {
                // Convert indices in slice to indices in original vec
                egui_dnd::utils::shift_vec(
                    idx,
                    start_index + update.to,
                    &mut items,
                );

                dragged_item_idx = None;
            }
        }
    }

    num_shown
});

As written above, this code draws every single element each time, as the layout closure passed to virtual_list::ui_custom_layout draws every single item. I've tried a number of different methods to calculate how many elements I should render based on the available space, but I haven't been able to account for the scroll area's current offset and the virtual list's overscan. It's pretty easy to get the maximum vertical area (as that can be calculated with the central panel's ui.available_height() or cached from the result of ScrollArea::vertical().show()), but it's not clear to me how to take into account the scroll area's current offset.
Ignoring that issue and rendering a fixed number of items, I haven't been able to drag an item cleanly across dnd "boundaries". For example, if I render 10 item in dnd::show(), the virtual list will sometimes call the layout closure with a start_index of 0 and a start_index of 10 (which makes sense). If I drag an item within indices 0 to 9 or 10 to 19, the other items appear to move out of the way as the item is dragged through them and the list is properly updated upon release. If I drag an item from index 2 to index 14, it behaves properly until it passes index 9, and then it appears to float over the next elements instead of them moving out of the way. I'm not sure how to handle this, because from the perspective of each call to dnd::show(), the iterator at the start of the drag is different than the iterator at the end (if the layout closure passed to virtual_list::show() is called multiple times).
In summary, my questions are:

Am I using the right virtual list and dnd calls (and nesting them properly)?
How should I calculate the correct height of the elements to render from dnd::show()?
How should I handle drags across instances of dnd::show()?

Thanks very much! Once I get this sorted out, I'm happy to clean it up and submit it as a PR for a virtual list + dnd example.

Hi! Have you looked at the infinite_scroll dnd example? It should be pretty similar to the virtual_list, since internally infinite_scroll is just a wrapper around a virtual_list? If that doesn't help I can try to create a virtual_list example tomorrow.


Parse SafeTx numeric parameters to int

Guard SafeTx from other numeric formats like float, Decimal or even str

Why this is necessary?

That's a good question.
EIP712 library is very picky, and does not accept different types than expected. I spent today a lot of time debugging an issue because a Decimal was passed to a SafeTx (default numeric type used by Django admin) instead of an int, so I thought it would be very useful to just parse everything to int to make sure we are handling the correct datatypes and not finding issues later when calling safe_tx_hash


added re.UNICODE flag to token_clean regex to fix IndexErrors

Fixes issue #103

Looks great! could you add a test case so this will stay unbroken.

thx @cubgs53!!


[GOBBLIN-294]Change logging level for reflection utilities

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-294] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-294

Description

[x ] Here are some details about my PR, including screenshots (if applicable):

Tests

[ x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

+1


Improve determinism with inserting by Entity order

Looking for feedback on this approach.  I understand this likely requires additional changes before acceptance.
I have a physics simulation that, when ran twice side-by-side, can produce slightly different data between the two simulations.  I determine this data desync by serializing the RapierContext (using bincode) on each frame and then hashing the result.  However, after the very first frame, when the SyncBackend systems get to run for the first time, my two simulations return two different hashes. I have the physics and query systems disabled to start, so it is not from StepSimulation yet.  I have "enhanced-determinism" on and have a guaranteed creation order of Entities.  I have exactly 100 Entities with both RigidBody and a Collider.
This non-determinism in the hash stems from Bevy not having a guaranteed Entity order for Queries, and I have found it fruitful to enforce that constraint in Rapier's systems.  This PR shows how I have handled this in my fork.  Doing a sort on the Queries as I have done in this PR seems to ensure that all of Rapier's internal data are initialized in exactly the same order, and thus the hashes returned are always the same.
Open questions I have are:

What is the best way to introduce this without also adding performance concerns to users?  An option on the RapierConfiguration?  There is a feature for "enhanced-determinism", but that has always seemed like a way to select packages to me.

Is there a more efficient way to sort these by Entity?

I feel sorting by Entity is the best way to accomplish this for my purposes, but are there other ways a user may want/need to sort these?

@sebcrozet I am ready for this to be reviewed.
I selected the feature flag for this purpose because it makes the for ... x.iter() simpler to write in Rust without having to worry about move semantics.

Ah, yes, you are right.  I was testing this on a different branch and added all of the feature checks after-the-fact and was not working against the correct branch.  My apologies.
Is there much point to putting this behind a feature flag at all?

Hi @sebcrozet, just wanted to ping you on this PR again.  Please let me know if there's anything else I can do to improve this change.  Thanks!


FAQ button from errors redirects users to Chinese support pages

Context
To better support Chinese-speaking users, we recently introduced a dedicated page at https://nearhelp.zendesk.com/hc/zh-cn and hired a native-speaking customer success person located in China.
This is an opportunity to update any Zendesk links generated by the wallet set to the Chinese language.
Story
As a Chinese-speaking wallet user getting an error, I want to click support and FAQs buttons linking to the Chinese version of Zendesk, so I can read the guides and open a ticket in Chinese language.

Acceptance Criteria

[ ] By setting the Chinese language in the wallet (either of the two available options) the support link changes to https://nearhelp.zendesk.com/hc/zh-cn
[ ] In case of an error, the FAQ button (查看常见问题) redirects the query to the Chinese language of Zendesk
[ ] Mobile ok
[ ] Tested

Unhappy Path
The user receives an error in Chinese language, but the FAQ and the support links redirect to the English version of the wallet.

Adding a P1: it's blocking for @RubyJiao
cc @think-in-universe

@stefanopepe  @RubyJiao
Here is my solution that should probably work: https://github.com/near/near-wallet/pull/1975
@RubyJiao Ruby, could you please test with this version to check whether it works well for Chinese FAQs now? https://near-wallet-pr-1975.onrender.com/

It works well for Chinese FAQs

#1975 is merged so is now live on staging -- it'll be in our next release :)


Jacobi Iterative Solver readme update

Existing Sample Changes
Description
Updated structure to match new template. Corrected some formatting. Corrected some branding. Corrected some spelling and grammar issues flagged by automated tools. Added category to readme. Updated information on using DevCloud.
Fixes Issue#
External Dependencies
N/A
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.

[x] Documentation quality

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Command Line
[x] VSCode

Adding @jimmytwei and @IgorOchocki for notices.

Good comments. I'll amend the commit with the changes. Thanks.


[BUG] Something Wrong with doWeatherStuff

Version of Advanced Rocketry
Varying results on different versions, which I've tested at length. These are all with just vanilla and Advanced Rocketry installed, nothing else (except Avaritia so I can fly fast). I tested this on a generic Advanced Rocketry planet that was generated by the game, no planetDefs was ever specified. Each time I switched versions, I generated a new world as well. LibVulpes version was not changed from build -62. Here's what I found:
v139 and below: Never crashes, weather works perfectly fine on all planets capable of weather.
v149: Simply crashes the game when weather toggles, 100% of the time. Crash: https://pastebin.com/PQfLwk97
v150-179: This is where the game stops crashing. Instead, weather now simply doesn't work. Whenever the weather event triggers, it lasts for maybe a second (just long enough to a see couple rain drops or snowflakes) and then immediately stops again.
Have you verified this is an issue in the latest unstable build
Yes.
Version of LibVulpes
LibVulpes 0.4.1-62
Version of Minecraft
1.12.2
Does this occur without other mods installed
Yes, though the bug gets worse with other mods installed, specifically mods like Just Enough Dimensions, Dimensional Control, and Topography.
Description of the problem
To reproduce this problem, just make a fresh pack with just AR v150-179, go to a planet, and either toggle downfall or wait for weather to trigger. You can observe the weather briefly start, then immediately stop.
This problem gets much worse however with a mod that installs dimensions installed. Another thread about this was maybe 20 days ago, right here: https://github.com/zmaster587/AdvancedRocketry/issues/1670
Here's a crash report from my main modpack I've been working on. I keep getting this same error: https://pastebin.com/p8BZBiyw
It's always at problem at WorldProviderPlanet.doWeatherStuff and at WorldProviderPlanet.updateWeather.
This problem doesn't exist on or before version 139. It first becomes aparent in v149. Even with Dimensional Control installed, v139 will never crash, the weather will always work, etc.
I hope this is enough information to help solve the issue! Let me know if you need me to test anything else. Thanks for your time!

You know the spectator mode right. It goes fast too.

It's looking like those mods replace worldInfo, that'd cause problems because AR expects the vanilla minecraft worldinfo to be there

AdvancedRocketry-1.12.2-1.6.0-universal.jar.zip
Can you give this one a try?

This seems to have completely solved the crashes!! Been running it for about 5 hours, haven't crashed once. Thanks a bunch for the speedy reply, this is great!!
I also tested weather on a vanilla pack with the version you gave me, but it seems like weather is still not quite working correctly on AR planets. No crashes, it just auto-disables weather right when it triggers.

@xlea99 Was this on a planet with low atmosphere that it was disabling weather?

@zmaster587 Sorry, didn't see that comment! No, I've tried testing it on all sorts of different planets, including 100 and 200 atmosphere planets. In any biome that allows rain/snow, it'll turn on briefly before turning off. I just verified the problem still exists in version 183.

@xlea99 does this issue also occur with just AR and libvulpes and no other mods?

So I have the same issue with the weather stopping to work after a second when toggling.
LibVulpes: 1.12.2-0.4.2-69
Advanced Rocketry: 1.12.2-1.6.0-194
How to reproduce:
You'll need some form of chunk loader to keep the space station dimension loaded when returning to the overworld from it. Weirding Gadgets works for me.

Create a new world with cheats enabled. Verify that rain works by entering the command
/weather rain
Build a space station, a rocket and fly up to the station.
Place a chunk loader somewhere on the space station
Return to the overworld with the rocket
Once landed, re-enter the /weather rain command and see how rain cannot be toggled on anymore

This is an issue for me since I have solar panels build on my station and want to use them for power generation.


Migrated to Java and added new examples

Hi Emily
Please have a look my PR. Hope you like to merge it. I introduced multiple changes.
First, I migrated your C++ examples to Java. I'm using Maven and JUnit5's  data driven feature for the test. I don't understand why your are using ApprovalTest for C++. I believe it's not necessary in Java, so I removed this dependency.
Second, I re-arranged the order of the methods. I used the exmple in a coaching session and I like to start with the obvious cases. In my opinion it's reverting a condition.In this sessions my first recommendation is: "Never start with a negativ condition".
Further, I introduce a new example and renamed the existing spilt/join methods. The new example describes how to split/join an OR expression. Your original code contains the same for split/join an AND expession.
Best regards,
Roland

Thankyou! You're right - Approvals is not needed here. I have it in my boilerplate setup project since I so often use it, and forgot to remove it. Thanks for the other improvements too!


fixed AssociateProteinsDlg's OK button never being enabled

fixed OK button never being enabled when AssociateProteinsDlg's PeptideCount == 0
fixed TestImportPeptideSearch not waiting for OK button to be enabled

I don't know if this will fix the actual intermittent failure but it definitely fixes a usability bug when the FASTA mapping results in no peptide matches.

/rebase

/rebase


Implement a lagging broadcast channel

I'd like to support the lagging broadcast channel that tokio provides, so postage can be fully compatible with existing tokio code.
I think the current channel is useful, but it needs a new name.

I'd like to support the lagging broadcast channel that tokio provides, so postage can be fully compatible with existing tokio code.

Tokio's behaviour to me (and some other Rust devs I've talked to) seems a bit wrong, to just drop a message if a receiver is lagging. However, if it's an optional feature, people can just choose the behavior they expect.

Yeah, I think the tokio behavior is there because writing a broadcast channel with back-pressure is difficult.
The only contetxt that dropping might make sense is in audio/video processing apps (for frames or samples).  But in general apps it can cause some wild bugs that are really hard to reproduce.


Events (open|close)

Is there a way to fire an event when the Dropdown is shown?, I read the documentation, but still is not clear.
I tried using 'on' this but is not working:
on(eventName, handler, [ctx])

on and off are meant to be used on the instance rather than in the configuration object.
drop = new Drop()
drop.on('open', function() { ... })

http://github.hubspot.com/drop/#events


Pull Neat and Bourbon from NPM instead of Bower

I set out to have neat installed via NPM instead of bower, but I was unable to do so without updating ember-cli. So this PR got a little bit large.  If you want I can split it up into 2 pieces (1 to update ember, and 1 to remove node), just let me know.
I took the approach for loading from npm from the ember-cli-bourbon project and I also took the liberty of mostly copying their single acceptance test.

Interesting timing! I was just about to do the same thing. :tada:

I haven't really looked into the 2.0 neat update.  Maybe release and tag this change with a major version bump and then do the neat update as another?

That makes the most sense. The api drastically changed in 2.0, so I doubt most users have upgraded.

@tzellman turns out my question was too ambiguous.  Should I bump neat?

I agree that it probably is the lowest risk to keep the same version of neat bundled in with this PR.

Ok - great!  Then I think this is ready.

@tsharman any thoughts on this?

@jrjohnson sorry this took so long. Still trying to resolve why I'm not getting email notifications from Github.

No problem. Thanks for the quick release after merging. I got the greenkeeper update notification before I saw that this had been merged.


Replace favicon with Elegant logo

Related to https://github.com/Pelican-Elegant/elegant/issues/190

First we should get a logo and then talk about replacing fav icons.


put this live

behind the existing teaser

move DNS
PR to replace front page
PR for new album page

change repo name


Spring boot feature flag quickstart looks incomplete / missing pieces

Trying to recreate the sample in the associated quickstart. It looks like a significant portion is missing. The provided steps don't produce a runnable app. For example, where/what is the Model class in HelloController? I don't see any mentions or links to its sample code:
@GetMapping("/welcome")
    public String mainWithParam(Model model) {
        model.addAttribute("Beta", featureManager.isEnabled("Beta"));
        return "welcome";
    }

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6181beec-df25-e22e-fd74-e771c52ac207
Version Independent ID: e25f278a-8d64-430d-72eb-8520a5ec4d90
Content: Quickstart for adding feature flags to Spring Boot - Azure App Configuration
Content Source: articles/azure-app-configuration/quickstart-feature-flag-spring-boot.md
Service: azure-app-configuration
GitHub Login: @mrm9084
Microsoft Alias: mametcal

@snimmagadda1 Thank you for reaching out to us and sharing your feedback. Will further look into this and get back to you at the earliest.

@snimmagadda1 The Model class being used in HelloController is the org.springframework.ui.Model. Which we are using with spring-boot-starter-thymeleaf. To modify the html template. You can see the value being used on this line <li class="nav-item" th:if="${Beta}">.
Thanks for the input and we will update the Quickstart to clarify this.

@BharathNimmala-MSFT @mrm9084 ah got it that makes sense. Thank you!

@mrm9084 Thank you for helping on this and sharing additional context and also taking feedback  further to reflect the documentation.
@snimmagadda1 Thank you for reaching out to us and sharing your feedback. For now, will go ahead and close this issue. If you have any further queries please do tag us in your reply and we will be more than happy to continue the conversation.


Removed (and checked) a TODO in simtel config writer; fixed one pylint report

Addresses the Todo in issue #933.
This is really a feature of sim_telarray with the first telescope being the default one. Removed therefore the 'todo' after improving the comment.
Fixed also an issue reported by pylint (but note: conflict with ruff reporting...)
Closes #933

Thanks!


Support DicomCast name as a prefix to Dicomcast tables

Description
This Pr allows the paas service to pass the dicomcast name to oss such that the flow will store the exception to correct dicomcast specific table.
Related issues
Addresses AB#88226
Testing
Added unit tests.

AllTables in Constants does not have the dicomCastName added, and is used here - https://github.com/microsoft/dicom-server/blob/a7251027997c56584495c5a8157f9ded3b105838/converter/dicom-cast/src/Microsoft.Health.DicomCast.TableStorage/Features/Storage/TableServiceClientInitializer.cs#L32

Should this one be updated too?
https://github.com/microsoft/dicom-server/blob/a7251027997c56584495c5a8157f9ded3b105838/converter/dicom-cast/src/Microsoft.Health.DicomCast.TableStorage/Features/Storage/TableSyncStateStore.cs#L44
Would it make sense to update constants so they are strings like "{dicomCastName}FhirFailToStoreExceptionTable" so it is clear what the full table names are?


Remove invalid model definition from test

The test doesn't use the definition in any event.

Codecov Report

Merging #203 (2b2a226) into main (21b0788) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 2b2a226 differs from pull request most recent head ca2f798. Consider uploading reports for the commit ca2f798 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage   78.74%   78.74%
=======================================
  Files           7        7
  Lines         414      414
=======================================
  Hits          326      326
  Misses         88       88

Flag
Coverage Δ

unittests
78.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Amend the Charter doc to clarify our position on free/paid countent?

Do we need a policy statement from OWD that OWD will only put effort / energy into features & content that is fully free to consume?

Yes, I think we should (both only work on free content and have that explicitly in the charter). I think we should connect this with making web documentation available to as many people as possible. But I'm not sure how we should integrate that into the current wording of the charter.

Yes.
Would it be sufficient enough to add some bits to the last paragraph? Like so:

Open Web Docs invests in and protects free documentation for the open web platform. We provide incentives and a platform for other related organizations to get involved in this work. We ensure developers have the best information available for free to make technology and design decisions and implement on the web platform.

Or do we think this needs its own core value?


V5

Upgrade Guide in new docs
Installing
npm install<EMAIL_ADDRESS>
or
yarn add<EMAIL_ADDRESS>
Current exported files

Changelog V4 -> V5
Improvements

Dropped package dependency uuid

Using React useId (https://beta.reactjs.org/apis/react/useId)

Unfortunately useId was introduced only into React v18, so, that will be the minimum necessary version of React to V5

Dropped package dependency prop-types (I'm thinking if we will use prop-types with TS)

V4 props available in V5:

[x] children -
[x] place - data-place
[x] ~type~ - Deprecated | in V5 -> variant - data-variant
[ ] effect - not implemented yet, if many users need this feature, we will work on this one.
[x] offset - data-offset
[ ] ~padding~ - Deprecated | in V5 -> can be easy updated by className prop
[ ] ~multiline~ - Deprecated | in V5 -> this is already supported as default by content and html props
[ ] ~border~ - Deprecated | in V5 -> can be easy updated by className prop
[ ] ~borderClass~ - Deprecated | in V5 -> can be easy updated by className prop
[ ] ~textColor~ - Deprecated | in V5 -> can be easy updated by className prop
[ ] ~backgroundColor~ - Deprecated | in V5 -> can be easy updated by className prop
[ ] ~borderColor~ - Deprecated | in V5 -> can be easy updated by className prop
[ ] ~arrowColor~ - Deprecated | in V5 -> can be easy updated by className prop
[ ] ~arrowRadius~ - Deprecated | in V5 -> can be easy updated by className prop
[ ] ~tooltipRadius~ - Deprecated | in V5 -> can be easy updated by className prop
[ ] ~insecure~ - Deprecated | in V5 -> CSS will be a separate file and can be imported or not
[x] className
[x] id
[x] html
[x] delayHide - data-delay-hide
[ ] ~delayUpdate~ - Deprecated | if requested, can be implemented later
[x] delayShow - data-delay-show
[ ] event - not implemented yet, if many users need this feature, we will work on this one.
[ ] ~eventOff~ - Deprecated
[ ] ~isCapture~ - Deprecated
[ ] ~globalEventOff~ - Deprecated
[x] getContent - Now this attribute only accepts a function instead of any
[ ] afterShow - not implemented yet, if many users need this feature, we will work on this one.
[ ] afterHide - not implemented yet, if many users need this feature, we will work on this one.
[ ] ~overridePosition~ - Deprecated
[ ] ~disable~ - Deprecated | in V5 -> state can be controlled or uncontrolled
[ ] scrollHide - not implemented yet, if many users need this feature, we will validate if we wrok on this one.
[ ] resizeHide - not implemented yet, if many users need this feature, we will validate if we wrok on this one.
[x] wrapper - data-wrapper
[ ] ~bodyMode~ - Deprecated
[ ] ~clickable~ - Deprecated | Supported by default in V5
[ ] ~disableInternalStyle~ - Deprecated | in V5 -> CSS will be a separate file and can be imported or not

Break Changes

All data attributes now has tooltip into his name
Default Padding changed from padding: 8px 21px; to padding: 8px 16px;
Exported module now is Tooltip instead of ReactTooltip

If you already have a Tooltip component in your application and want to explicitly declare this is ReactTooltip, just import { Tooltip as ReactTooltip } from "react-tooltip"

CSS import is now optional, so, you can modify and/or add any styling to your floating tooltip element
data-tip attribute now is data-content
getContent prop now doesn't accept any anymore, just a function
default behavior of tooltip now is solid instead of float

New Props

[x] classNameArrow
[x] events - data-events -['hover', 'click'] - default: ['hover'] (always an array when using as prop, even with only one option, when using as data attribute: data-events="hover click")
[x] isOpen - boolean (to control tooltip state) - if not used, internal state of tooltip will handle the show state
[x] setIsOpen - function (to control tooltip state) - if not used, internal state of tooltip will handle the show state

Hi guys, I want to know your thoughts about a thing, as in the current code of V5, we only have 2 elements for tooltip:

tooltip div
arrow div
And there are a lot of props related to tooltip customization and arrow customization, like:
border
borderClass
padding
backgroundColor
borderColor
arrowColor
arrowRadius
tooltipRadius

And we can override the default styles by simply using CSS in prop className and classNameArrow.
So, those v4 props sound redundant to me, what does everyone thinks about that?

I think you should make it as simple as possible, still keeping the same customization available. So if you are able to make the changes with pure CSS, it is fine to leave these props out - but you will want to make a migration guide + example to show how to change them with CSS in the new version.
It's great you are able to work on this and possibly get to a more react style component with the new version! I'm sure many people are looking forward to it!

hey @aronhelser, I'm very happy to have your feedback, thanks!
Yes, sure! I'll update docs and the release notes with the steps and changes after every change :)

About #753 : it would be easily implemented if the size of the arrow was the same in every orientation. Currently there are some pixels of difference that would make the calculations harder.

Yes, I agree @FedeTommi, the current code for arrow in V5 is:
.arrow {
  position: absolute;
  background: #222;
  width: 8px;
  height: 8px;
  transform: rotate(45deg);
}

So, probably this problem will not happen in V5, as we are using the API of float-ui to compute the positions.

This is WIP but it's already available for preview:
https://react-tooltip.com/docs/getting-started

Looking forward to have feedback on the work that is already done until now

v5.0.0-beta.1 released to fix types export and now a typescript project can use the react tooltip as expected :)

Hi @aronhelser can you let me know your thoughts on https://react-tooltip.com/docs/getting-started, please?
Thanks!

It looks great! I don't have particular comments about code style or anything. I see a few typos various places in docs/readme, but I don't think that should hold you up. I haven't worked in typescript in 7 years, so I would defer to someone else there.
+1

It looks great! I don't have particular comments about code style or anything. I see a few typos various places in docs/readme, but I don't think that should hold you up. I haven't worked in typescript in 7 years, so I would defer to someone else there.
+1

Thanks :D
oh, the typos are in Grammarly?
Please, do the suggestions, I'm not a native English speaker, but I'm still improving my English hahaha

I'll release ReactTooltip V5 tomorrow (December 7), if anyone has anything to say before that, now it's the moment :)

All issues related to V4 will be closed.
They are old and the codebase from V4 to V5 is totally different.


Support targeting solution filters

I've got a POC in my branch but with some breaking changes.
Happy to open a PR if wanted.

Thanks! I took a quick look at it, and I think I am willing to support this. However, I think I want to revert some of the breaking changes...
I think, for now at least, we should keep the api.lua the same, and not rename anything there. I think we can just create the new methods in utils.lua.
I don't have the best documentation, but I look at the methods in utils.lua as sort of "private" even though they are exposed, and the ones in api as something other plugins or someone could use int their config.
A couple of other things: I think we should try and combine some of the vim.fs.root and vim.fs.find methods in the utils.root method. I have gotten a couple of issues earlier about performance when finding the solution file, and this adds even more filesystem searching.
Otherwise, I think it looks good. I think I like the naming change of the config option for ignore_target and choose_target. I have actually been considering adding the .csproj files it finds to the vim.ui.select list, so that it is possible to only load a single project. Then target as a name fits better. I think however we should accept the old names for now and issue a notify warning about those options being deprecated if they are used, and then I will remove them at a later time


463 withdraw options for submitted placement requests

[https://dsdmoj.atlassian.net/jira/software/c/projects/APS/boards/1328?selectedIssue=APS-14](Jira card)


Adding  Prerequisite

Problem description
Currently, Loadestar needs more packages into Prerequisite
https://github.com/ChainSafe/lodestar?tab=readme-ov-file#prerequisites

make
build-essential or gcc

Solution description
Adding above packages into the document
Additional context
No response

make and gcc should only be required for node versions without pre-builds, what node version do you use?
For more deftailed prerequisites list, we might wanna document those here https://github.com/ChainSafe/lodestar/blob/unstable/CONTRIBUTING.md#prerequisites instead.

This time, I used the newly installed wsl2 Ubuntu 24.04.1 LTS.
$ node -v v22.12.0


fix valgrind warning on font

LGTM. @matt335672 is working around this code but I think it doesn't conflict.

Here is the output from valgrind, line numbers might not be exact as I found this in another branch.
[2023-09-23T16:47:44.564-0700] [WARN ] No DPI value is available to find login font
[2023-09-23T16:47:44.605-0700] [WARN ] Using the default_dpi of 96
==21800== Thread 2:
==21800== Invalid read of size 2
==21800==    at 0x483A0D8<EMAIL_ADDRESS>(vg_replace_strmem.c:1033)
==21800==    by 0x112AB1: xrdp_cache_add_char (xrdp_cache.c:586)
==21800==    by 0x120630: xrdp_painter_draw_text (xrdp_painter.c:938)
==21800==    by 0x10F60B: xrdp_bitmap_invalidate.part.0 (xrdp_bitmap.c:706)
==21800==    by 0x10F2C8: xrdp_bitmap_invalidate (xrdp_bitmap.c:613)
==21800==    by 0x10F621: xrdp_bitmap_invalidate.part.0 (xrdp_bitmap.c:1005)
==21800==    by 0x10F2C8: xrdp_bitmap_invalidate (xrdp_bitmap.c:613)
==21800==    by 0x125CB5: xrdp_wm_init (xrdp_wm.c:805)
==21800==    by 0x1264DA: xrdp_wm_login_state_changed (xrdp_wm.c:2054)
==21800==    by 0x1264DA: xrdp_wm_check_wait_objs (xrdp_wm.c:2331)
==21800==    by 0x121F13: xrdp_process_main_loop (xrdp_process.c:287)
==21800==    by 0x115606: xrdp_process_run (xrdp_listen.c:152)
==21800==    by 0x4D4AFA2: start_thread (pthread_create.c:486)
==21800==  Address 0x5655250 is 0 bytes inside a block of size 1 alloc'd
==21800==    at 0x4837B65: calloc (vg_replace_malloc.c:752)
==21800==    by 0x11548E: xrdp_font_create (xrdp_font.c:264)
==21800==    by 0x125963: xrdp_wm_init (xrdp_wm.c:586)
==21800==    by 0x1264DA: xrdp_wm_login_state_changed (xrdp_wm.c:2054)
==21800==    by 0x1264DA: xrdp_wm_check_wait_objs (xrdp_wm.c:2331)
==21800==    by 0x121F13: xrdp_process_main_loop (xrdp_process.c:287)
==21800==    by 0x115606: xrdp_process_run (xrdp_listen.c:152)
==21800==    by 0x4D4AFA2: start_thread (pthread_create.c:486)
==21800==    by 0x4C7A06E: clone (clone.S:95)
==21800==
==21800== Invalid read of size 1
==21800==    at 0x483C035: __memcmp_sse4_1 (vg_replace_strmem.c:1111)
==21800==    by 0x1155C5: xrdp_font_item_compare (xrdp_font.c:360)
==21800==    by 0x11299B: xrdp_cache_add_char (xrdp_cache.c:553)
==21800==    by 0x120630: xrdp_painter_draw_text (xrdp_painter.c:938)
==21800==    by 0x10F60B: xrdp_bitmap_invalidate.part.0 (xrdp_bitmap.c:706)
==21800==    by 0x10F2C8: xrdp_bitmap_invalidate (xrdp_bitmap.c:613)
==21800==    by 0x10F621: xrdp_bitmap_invalidate.part.0 (xrdp_bitmap.c:1005)
==21800==    by 0x10F2C8: xrdp_bitmap_invalidate (xrdp_bitmap.c:613)
==21800==    by 0x125CB5: xrdp_wm_init (xrdp_wm.c:805)
==21800==    by 0x1264DA: xrdp_wm_login_state_changed (xrdp_wm.c:2054)
==21800==    by 0x1264DA: xrdp_wm_check_wait_objs (xrdp_wm.c:2331)
==21800==    by 0x121F13: xrdp_process_main_loop (xrdp_process.c:287)
==21800==    by 0x115606: xrdp_process_run (xrdp_listen.c:152)
==21800==  Address 0x5655251 is 0 bytes after a block of size 1 alloc'd
==21800==    at 0x4837B65: calloc (vg_replace_malloc.c:752)
==21800==    by 0x11548E: xrdp_font_create (xrdp_font.c:264)
==21800==    by 0x125963: xrdp_wm_init (xrdp_wm.c:586)
==21800==    by 0x1264DA: xrdp_wm_login_state_changed (xrdp_wm.c:2054)
==21800==    by 0x1264DA: xrdp_wm_check_wait_objs (xrdp_wm.c:2331)
==21800==    by 0x121F13: xrdp_process_main_loop (xrdp_process.c:287)
==21800==    by 0x115606: xrdp_process_run (xrdp_listen.c:152)
==21800==    by 0x4D4AFA2: start_thread (pthread_create.c:486)
==21800==    by 0x4C7A06E: clone (clone.S:95)

Yup - we definitely need this. I introduced this bug, so apologies for that.
@jsorg71 - meta and I are looking at a potential security issue in another thread. Because of the way github publishes security information, it's not visible to the whole team which is a pity.
I'm going to merge this now and check it doesn't conflict with anything else.

BTW - this code isn't in V0.9 so we don't need to backport this.

I agree.

I've updated the devel branch in the private fork and rebased my change. There were no actual conflicts but I've added a comment to the code where the alloc is done for the blank glyph.

@matt335672 As far as I looked v0.9 code, I think backport is not required.
https://github.com/neutrinolabs/xrdp/blob/v0.9/xrdp/xrdp_font.c#L137-L150

Ah, maybe we need to add this block?
                if (datasize == 0)
                {
                    /* Allocate a single blank pixel for the glyph, so
                     * that it can be added to the glyph cache if required */
                    f->width = 1;
                    f->height = 1;
                    f->data = (char *)g_malloc(1, 1);
                    f->data = (char *)g_malloc(FONT_DATASIZE(f), 1);
                }

Hi @metalefty
For v0.9 we're using the older fonts which are generated on Windows. As a result, datasize is never zero, and so we don't need to consider this case.
The move away from the fonts generated on Windows was part of #2341.


Annotations are not detected though all the libraries of TestNG are included

TestNG Version

7.0.0

Expected behavior
The annotations should be imported and do not throw an error.
Actual behavior
The annotations are not imported. And when I used them it throws an error.
If I wrote import org.testng.annotations.* then it does not throw an error. But it does not allow me to write import org.testng.annotations.Test. All the testng libraries are added correctly and maven dependencies are updated.
Is the issue reproducible on a runner?

[ ] Shell
[X] Maven
[ ] Gradle
[ ] Ant
[X] Eclipse
[ ] IntelliJ
[ ] NetBeans

Test case sample
Here is the screenshot of the problem I'm facing

Sample code with error
`
package test_demo.demo_test1;
import org.openqa.selenium.By;
import org.openqa.selenium.WebDriver;
import org.openqa.selenium.chrome.ChromeDriver;
import org.testng.annotations.Test;
public class App
{
WebDriver driver;
  @Test
  public void test() {
   	  System.out.println("Test is executing");
  }

  @BeforeTest
  public void before() {
	  System.out.println("Before test");
  }

}`

##I got the solution.
Just have to install TestNG through eclipse
Step 1: Go to Help -> Install New Software
Step 2: Go address http://beust.com/eclipse
Step 3: Install the TestNG from there.
Step 4: Include the TestNG library in the project
That's it. It works fine for me.

Solved it!


fetching a map by ID returns the wrong difficulty

calling a map by id only returns the top diff of the set
https://osu.ppy.sh/beatmapsets/807850#osu/1695382
https://osu.ppy.sh/beatmapsets/807850#osu/1700527

fixed


SSD-MobileNet got fail(AttributeError: module 'torch.xpu' has no attribute 'locations_to_boxes')

🚀 The feature, motivation and pitch
Run ssd-mobilenetv1 on LNL Windows with https://github.com/intel-innersource/frameworks.ai.pytorch.gpu-models/SSD-MobileNetv1 on stock PyTorch got error
fail(AttributeError: module 'torch.xpu' has no attribute 'locations_to_boxes').

This is because the model used an ipex customized op at link. Do we need to support it or use an official version on ssd-mobilenet in torch_vision?
OneAPI 2025.0.0+compiler 2025.0.1
PyTorch wheel is install on IPEX_2.5.10+xpu/RC1
Alternatives
No response
Additional context
No response

Since we are going to use OOB model scripts instead of the IPEX scripts, we will close this issue.


Chore/switch tsimp tsx

Pull Request
Checklist

[x] Have you read Digital Catapult's Code of Conduct?
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.

PR Type
Please delete options that are irrelevant.

[ ] Bug Fix
[ ] Feature
[ ] Documentation Update
[x] Code style update (formatting, local variables)
[ ] Breaking Change (fix or feature that would cause existing functionality to change)

Linked tickets
VR-144
High level description
Swap all usages of tsimp for tsx
Detailed description
Also fixes seed script
Describe alternatives you've considered
N/A
Operational impact
None, this doesn't affect compilation or build artifacts
Additional context
We've been having lots of issues with tsimp in dev caching stale build artifacts and leading to eroneous type errors. Hopefully tsx will improve upon this and make things nicer to use. Trying in this repo to test the water

This is blocked by https://github.com/privatenumber/tsx/issues/347 which prevents using tsyringe with tsx

Closing in favour of #172


Cannot use as AMD module

Missing return statement to export as AMD module.
Example + fixed example: http://codepen.io/anon/pen/GJKpNJ

Whoa! Sorry I missed this. Thank you for this fix! :joy_cat:


included external hosts as part CSR hosts for peer

Hi @adityajoshi12 , thanks for the PR!
Can you elaborate on why this is needed?
Thank you

Hi @adityajoshi12 , thanks for the PR!
Can you elaborate on why this is needed?
Thank you

When using istio the FQDN was not part of csrHost, this will ensure that even in the case of a change of Node IPs, CA can be still accessed via the FQDN.

But the change is for the peer right?

Merged


Support OpenShift 4.7+ /Kubernetes 1.20+

Update readme
Update Podsecurity policy to use SecurityContextConstraints

LGTM  Thanks for your contribution!


Documentation improvements

Main PR goal: document the codebase using docstrings.
Secondary goal: minor refactoring, typo fixes...
This PR also brings a lot of changes regarding linting & code formatting:

Use ruff for code formatting instead of black
Add isort rules
Add pydocstyle rules to validate docstrings
Add pyupgrade rules to automatically upgrade syntax for newer versions of the language

Conflit on pyproject.toml @pvanliefland

Thanks @cheikhgwane , I've resolved the conflicts


Added new questions

What this PR does / why we need it:
This PR adds new questions to the FAQ.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

NONE

/review @JordanJordanov


Add optional position bounds

It would be nice to have the ability to specify that the position never go beyond a certain range, despite further rotations in a certain direction. If you already have a solution for that in the current implementation that I'm not seeing, please let me know. I may attempt a PR, but C++ is not something I touch much.

Thx for submitting a pull request!
I really like the idea and will create a new version in the next couple of days.

Hi, quick note: Your pull request only kind of worked. It didn't take rotary encoders into account that increase the step value greater one. I updated the files accordingly.
And I added a check whether the lower_bound is greater 0.
If so, I set the initial value to the lower_bound.

@LennartHennigs yeah I ran into that but wasn't sure if that would be considered expected behavior or not. Sorry I should have made a follow up comment this morning. Thanks for patching up both PRs!

No problem.


[Test-Proxy] Add ability to sanitize a header conditionally based on other header value

This is needed by Communication - see https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/communication/Azure.Communication.Chat/tests/Infrastructure/ChatRecordedTestSanitizer.cs#L18

This may actually not be needed - I talked to the Communication team and they didn't think it was necessary.


[Feature] Change first day of the week on the date-picker widget

Summary
We should be able to change the first day of the week on the date picker widget.
Motivation
As requested by a user on discord.

Looks good can i pick this up @ayushpahwa

Hi @Hyperion101010 , 👋  the issue is all yours! Do raise a PR within 4 days and read our Contribution.md

@OladapoAjala go for it! We can do both, detect the current locale and set that as the default as well as give the user an option

Thanks @somangshu I'd work on this over the weekend and give a feedback soon, been a bit busy lately!


Removing unnecessary curly braces

What is the issue?
There is no need of using curly braces
How is the issue relevent?
Curly bases are used only when there are multiple statements. As there is only one statement there is no need of using curly braces. It decreases the readability of the code.
How can we resolve this issue?
Remove the curly braces when there is only one statement.

Hm, no. The parentheses are needed in Lamba expressions. Removing them results in a compilation error.


emacs: better glib-networking detection

Fixes https://github.com/NixOS/nixpkgs/issues/249756
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@shivanshukantprasad can you please test this?

Tested. Pages are loading properly now.

Scary.


Backports for stable

Motivation for this change
I looked through commits I've been involved with on master and I think these ones should be applied to release-16.03 as well (various improvements).
Things done

[x] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

I'm currently testing my system with it, I'll merge in a day (or more, depending on speed of my PC) if I don't see any regressions.

I threw in youtube-dl updates too. (I noticed it was broken (runtime) on release-16.03.)


initial draft

initial draft code for experimentation / collaboration around the topic of map data updates.
Currently tied to OS Unplugged but clearly such behaviour is applicable to other apps.

Minor question on the naming of the interface, other than that, LGTM.

Cheers Dave, much appreciated.


Update zip dependency

I recently updated transitive flate2 dependency (a dependency of zip) and faced slowdown: https://github.com/rust-lang/flate2-rs/issues/395.
I reached to the author of zip and looks like he addressed the performance regression in the new version: https://github.com/zip-rs/zip2/issues/138
Could you update zip dependency to 1.3?

Sure

Would have fixed this now, but im still blocked on arturoc/color-rs#2 for the release ...

Thanks, closing.


[WIP]Use first version of finatra that supports scala 2.12

What is this PR trying to achieve?
Take us a step closer to upgrade scala
Who is this change for?
💅 🎪

🐳 🎉


Added Profile

Your name should be same as in your github profile

Your name should be same as in your github profile

hello, I corrected it, could you accept my PR, please?


Added a folder of social media hover animation

I have created a folder named social-media-hover-animation and made the animation using HTML, and CSS.
Being a total beginner I am not very well versed with other technology but I am learning and will contribute to other technologies next year.
This is how my project looks like

And on hover animation, it looks like

Please tell me if it requires any changes, and I will be more than happy to do so.
Thank you!

good projects. thanks for contributing in my repo.
ur pull request have been merged🙂


feat: add LawCommIdentity + IdempotentOp for BitVec.[and|or|xor]

As these instances seemingly require explicit arguments, this PR also makes some arguments explicit.

I feel we really need to understand better under which conditions arguments should be explicit or implicit and then should standardize this across the BitVec library.

awaiting-review


Tinkers Books & Book Binder

The Tinkers Books don't want to go in the Book Binder. I don't find the settings for that in the configs. (Older versions had that). I use the default configs and there I found the books in the library_books.json.

The config for the Book Binder is located at \minecraft\config\books\enchiridion.cfg
You can manually add books for the book binder there.
Add these lines directly below the witchery and opencomputers books listed:
TConstruct:manualBook 0
TConstruct:manualBook 1
TConstruct:manualBook 2
TConstruct:manualBook 3
TConstruct:manualBook 4


A11y warning on "Who to Follow" page

They can be resolved by adding unique aria-label attributes to each link with the same text (eg, all "Website" links), but that feels unnecessary and potentially excessive for a screen reader user.
It reads well when I use VO, so I'm going to say that it's fine. For now at least, and I'm keeping this "issue" here while I try to find a resource that tells me if that's a bad thing.

resolved


stripe: Refactor event_status and sponsorship_request views.

This PR refactors event_status view and adds BillingSession.get_event_status method.
This refactoring will help in minimizing duplicate code while supporting both realm and remote_server customers.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

I should have a version pushed back to merge shortly.

I fixed all the issues noted above as well as rebasing this on top of other recently merged work.