Action: dropdown onTap icon or button

Need an action to show dropdown like this when I click on an icon

Enhance PopupMenu. It was half done.

it's in progress but not assigned to anyone? @vusters ?

see this use case, in header, we have a row, onTap of the row we're opening a drowdown, there should be a dropdown action, which can be called with action (onTap) and its items should be customizable (i.e we can pass the ui to the item)

Suggested EDL

Row:
  onTap:
      openDropdown:
          items: ${getProperties.body}
          name: property
          widget: DropDownItem
  children:
     - Image
     - Text
     - Icon

 DropDownItem:
    inputs:
       - property
    body:
       Row:
          onTap:
              # store selected item in storage
          children:
              - Image
              - Text
              - Icon

@sharjeelyunus you have 2 different use cases here. One is a customizable Dropdown (this is done), while the other is more like a Popup menu. Please update the tix to reflect Popup menu (if still needed)

@sharjeelyunus please update

yss, the itemTemplate way works for me


Signature of bkpt() function

I was just looking at ways to cheaply and clippy happy "terminate" an #[entry] function and was looking at the cortex_m::asm:bkpt() function noticing that it has  a signature of pub fn bkpt(). My expectation would have been that this function has a signature of pub fn bkpt() -> ! instead which would qualify it as a terminating statement in #[entry].
Is there a reason for bkpt() not returning never?

After the breakpoint is triggered, the debugger can just continue and execution continues after the function, right?

I thought the never type was used to express "no value" or uncertainty of program flow and bpkt() would qualify.
Do you have any other idea how to produce a never value for #[entry] that does not produce overhead (like panic!()) or is frowned upon by clippy (like loop {})?

This related issue just in: https://github.com/rust-embedded/cortex-m-rt/issues/139

The never type ! as a function return type means "never returns" which isn't true of bkpt(). I usually do something like loop { cortex_m::asm::wfi() } or nop().
Re that c-m-rt issue, that's sort of correct behaviour as far as "It seems that all divergent functions (fn(..) -> !) are given the noreturn attribute" goes. Annoying that trashing LR screws with debugging of course...

I'm still not convinced bpkt() doesn't count as a diverging function because it is not guaranteed that program flow will ever continue after it; it's totally up to the debugger (if connected) to decide whether and how to continue after that point.
However reading the book about the never type I actually found a good, cheap and clippy happy solution to my problem:
loop {
     continue;
}


chore: bdd-nh-import-1587749246 to 0.0.1

chore: Promote bdd-nh-import-1587749246 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Run “mvn clean package” command and the reactor build order has no "mapkeeper binding"

I followed https://github.com/m1ch1/mapkeeper/wiki/Getting-Started to install mapkeeper to test LevelDB, but when I run “mvn clean package” command in YCSB directory, I get the following outputs which has no "mapkeeper binding":
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for com.yahoo.ycsb:hbase094-binding:jar:0.13.0-SNAPSHOT
[WARNING] 'dependencies.dependency.exclusions.exclusion.groupId' for com.yahoo.ycsb:hbase098-binding:jar with value '' does not match a valid id pattern. @ line 51, column 20
[WARNING] 'dependencies.dependency.exclusions.exclusion.artifactId' for com.yahoo.ycsb:hbase098-binding:jar with value '' does not match a valid id pattern. @ line 52, column 23
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] YCSB Root
[INFO] Core YCSB
[INFO] Per Datastore Binding descriptor
[INFO] YCSB Datastore Binding Parent
[INFO] Accumulo DB Binding
[INFO] Aerospike DB Binding
[INFO] ArangoDB Binding
[INFO] AsyncHBase Client Binding for Apache HBase
[INFO] Azure table storage Binding
[INFO] Cassandra 2.1+ DB Binding
[INFO] Couchbase Binding
[INFO] Couchbase Java SDK 2.x Binding
[INFO] Azure DocumentDB Binding
[INFO] DynamoDB DB Binding
[INFO] Elasticsearch Binding
[INFO] Geode DB Binding
[INFO] Google Cloud Datastore Binding
[INFO] Google Cloud Bigtable Binding
[INFO] HBase 0.98.x DB Binding
[INFO] HBase 0.94.x DB Binding
[INFO] HBase 1.0 DB Binding
[INFO] Hypertable DB Binding
[INFO] Infinispan DB Binding
[INFO] JDBC DB Binding
[INFO] Kudu DB Binding
[INFO] memcached binding
[INFO] MongoDB Binding
[INFO] Oracle NoSQL Database Binding
[INFO] OrientDB Binding
[INFO] rados of Ceph FS binding
[INFO] Redis DB Binding
[INFO] Rest Client Binding
[INFO] Riak KV Binding
[INFO] S3 Storage Binding
[INFO] Solr Binding
[INFO] Solr 6 Binding
[INFO] Tarantool DB Binding
[INFO] YCSB Release Distribution Builder
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building YCSB Root 0.13.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------

I don't know why it happens and how to solve it.
It seems the the content of Get Started(https://github.com/m1ch1/mapkeeper/wiki/Getting-Started) is too old, could anyone update it? I can not successfully install the mapkeeper binding.

The getting started you referenced (https://github.com/m1ch1/mapkeeper/wiki/Getting-Started) is not from this project. For this project see: #181 and #262

I followed the way described in  #262(The method of Compiling mapkeeper temporarily). I redescribe the steps I do:
step 1: run 'mvn clean package' in YCSB directory
After step 1, I can run './bin/ycsb load basic workloads/workloada' succcessly.
step 2:
follow "https://github.com/m1ch1/mapkeeper/wiki/Getting-Started" to Generate Thrift MapKeeper Binding
a.  install libevent
b.  install boost
c.  install thrift
d.  generate mapkeeper binding
step 3:
After generating mapkeeper binding, go the "mapkeeper/thrift/gen-java/target", and run
'cp mapkeeper-1.1-SNAPSHOT.jar mapkeeper-1.0.jar'
'mvn install:install-file -Dfile=mapkeeper-1.0.jar -DgroupId=com.yahoo.mapkeeper -DartifactId=mapkeeper -Dversion=1.0 -Dpackaging=jar'
the two commands run successfully
step 4: Modify "YCSB/mapkeeper/pom.xml" as follows:

com.yahoo.mapkeeper
mapkeeper
1.0

org.apache.thrift
libthrift
0.8.0

step 5:
Uncomment "mapkeeper" and "<mapkeeper.version>1.0</mapkeeper.version>" in "YCSB/pom.xml"
step 6:
reRun 'mvn clean package' in YCSB directory
I got the outputs in step 6:
I seem to get the artifact issue in the latest version(0.12.0). After I run the "mvn clean package", I get the outputs:
[INFO] Reactor Summary:
[INFO]
[INFO] YCSB Root .......................................... SUCCESS [ 2.010 s]
[INFO] Core YCSB .......................................... SUCCESS [ 13.360 s]
[INFO] Per Datastore Binding descriptor ................... SUCCESS [ 0.419 s]
[INFO] YCSB Datastore Binding Parent ...................... SUCCESS [ 0.832 s]
[INFO] Accumulo DB Binding ................................ SUCCESS [06:10 min]
[INFO] Aerospike DB Binding ............................... SUCCESS [ 7.636 s]
[INFO] ArangoDB Binding ................................... SUCCESS [ 2.068 s]
[INFO] AsyncHBase Client Binding for Apache HBase ......... SUCCESS [01:01 min]
[INFO] Azure table storage Binding ........................ SUCCESS [ 1.382 s]
[INFO] Cassandra 2.1+ DB Binding .......................... SUCCESS [ 52.470 s]
[INFO] Couchbase Binding .................................. SUCCESS [ 2.999 s]
[INFO] Couchbase Java SDK 2.x Binding ..................... SUCCESS [ 2.365 s]
[INFO] Azure DocumentDB Binding ........................... SUCCESS [ 0.926 s]
[INFO] DynamoDB DB Binding ................................ SUCCESS [ 15.698 s]
[INFO] Elasticsearch Binding .............................. SUCCESS [ 19.951 s]
[INFO] Geode DB Binding ................................... SUCCESS [ 8.180 s]
[INFO] Google Cloud Datastore Binding ..................... SUCCESS [ 2.674 s]
[INFO] Google Cloud Bigtable Binding ...................... SUCCESS [ 8.763 s]
[INFO] HBase 0.98.x DB Binding ............................ SUCCESS [ 7.534 s]
[INFO] HBase 0.94.x DB Binding ............................ SUCCESS [ 8.953 s]
[INFO] HBase 1.0 DB Binding ............................... SUCCESS [01:04 min]
[INFO] Hypertable DB Binding .............................. SUCCESS [ 2.535 s]
[INFO] Infinispan DB Binding .............................. SUCCESS [ 2.284 s]
[INFO] JDBC DB Binding .................................... SUCCESS [ 4.903 s]
[INFO] Kudu DB Binding .................................... SUCCESS [ 2.029 s]
[INFO] memcached binding .................................. SUCCESS [ 1.775 s]
[INFO] MongoDB Binding .................................... SUCCESS [ 4.154 s]
[INFO] Oracle NoSQL Database Binding ...................... SUCCESS [ 1.138 s]
[INFO] OrientDB Binding ................................... SUCCESS [ 8.265 s]
[INFO] rados of Ceph FS binding ........................... SUCCESS [ 2.524 s]
[INFO] Redis DB Binding ................................... SUCCESS [ 1.020 s]
[INFO] Rest Client Binding ................................ SUCCESS [ 27.616 s]
[INFO] Riak KV Binding .................................... SUCCESS [ 6.584 s]
[INFO] S3 Storage Binding ................................. SUCCESS [ 1.833 s]
[INFO] Solr Binding ....................................... SUCCESS [01:29 min]
[INFO] Solr 6 Binding ..................................... SUCCESS [01:45 min]
[INFO] Tarantool DB Binding ............................... SUCCESS [ 1.562 s]
[INFO] YCSB Release Distribution Builder .................. FAILURE [ 4.023 s]
[INFO] Mapkeeper DB Binding ............................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:23 min
[INFO] Finished at: 2016-12-21T16:11:39+08:00
[INFO] Final Memory: 124M/237M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.5.5:single (default) on project ycsb: Failed to create assembly: Artifact: com.yahoo.ycsb:mapkeeper-binding:jar:0.13.0-SNAPSHOT (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. -> [Help 1]

You are getting [INFO] Mapkeeper DB Binding ............................... SKIPPED that to me is saying its not trying to build the mapkeeper db binding.
It looks like you have to add the following to distribution/pom.xml:
<dependency>
  <groupId>com.yahoo.ycsb</groupId>
  <artifactId>mapkeeper-binding</artifactId>
  <version>${project.version}</version>
</dependency>

Can you try the following from the YCSB directory:
mvn clean; mvn package -pl mapkeeper-binding -am

I still failed, after changing the Step 5 and Step 6 as follows.
Step 5:
Uncomment mapkeeper and <mapkeeper.version>1.0</mapkeeper.version> in "YCSB/pom.xml";
add the following to distribution/pom.xml:
<dependency>
  <groupId>com.yahoo.ycsb</groupId>
  <artifactId>mapkeeper-binding</artifactId>
  <version>${project.version}</version>
</dependency>

Step 6:
6.1, run mvn clean successfully,
6.2  different commands  all failed.
6.2.1 run  mvn clean; mvn package -pl mapkeeper-binding -am , I got the output:
[ERROR] [ERROR] Could not find the selected project in the reactor: mapkeeper-binding @
[ERROR] Could not find the selected project in the reactor: mapkeeper-binding -> [Help 1]
6.2.2 You may mean to run mvn clean; mvn -pl com.yahoo.ycsb:mapkeeper-binding -am clean package, I got the output:
[ERROR] src/main/java/com/yahoo/ycsb/db/MapKeeperClient.java[0] (javadoc) JavadocPackage: Missing package-info.java file.
[ERROR] src/main/java/com/yahoo/ycsb/db/MapKeeperClient.java[187:17] (extension) TreeWalker: Got an exception - expecting EOF, found '}'
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] YCSB Root .......................................... SUCCESS [  2.437 s]
[INFO] Core YCSB .......................................... SUCCESS [ 10.347 s]
[INFO] Per Datastore Binding descriptor ................... SUCCESS [  0.426 s]
[INFO] YCSB Datastore Binding Parent ...................... SUCCESS [  0.949 s]
[INFO] Mapkeeper DB Binding ............................... FAILURE [  0.459 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15.306 s
[INFO] Finished at: 2016-12-26T10:00:57+08:00
[INFO] Final Memory: 37M/589M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.16:check (validate) on project mapkeeper-binding: You have 2 Checkstyle violations. -> [Help 1]
6.2.3 After run  mvn clean package, I got the output:
[INFO] There are 2 errors reported by Checkstyle 6.2 with checkstyle.xml ruleset.
[ERROR] src/main/java/com/yahoo/ycsb/db/MapKeeperClient.java[0] (javadoc) JavadocPackage: Missing package-info.java file.
[ERROR] src/main/java/com/yahoo/ycsb/db/MapKeeperClient.java[187:17] (extension) TreeWalker: Got an exception - expecting EOF, found '}'
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] YCSB Root .......................................... SUCCESS [  1.565 s]
[INFO] Core YCSB .......................................... SUCCESS [  7.751 s]
[INFO] Per Datastore Binding descriptor ................... SUCCESS [  0.310 s]
[INFO] YCSB Datastore Binding Parent ...................... SUCCESS [  0.608 s]
[INFO] Accumulo DB Binding ................................ SUCCESS [05:23 min]
[INFO] Aerospike DB Binding ............................... SUCCESS [  5.570 s]
[INFO] ArangoDB Binding ................................... SUCCESS [  1.477 s]
[INFO] AsyncHBase Client Binding for Apache HBase ......... SUCCESS [02:33 min]
[INFO] Azure table storage Binding ........................ SUCCESS [  0.826 s]
[INFO] Cassandra 2.1+ DB Binding .......................... SUCCESS [01:36 min]
[INFO] Couchbase Binding .................................. SUCCESS [ 10.334 s]
[INFO] Couchbase Java SDK 2.x Binding ..................... SUCCESS [  7.370 s]
[INFO] Azure DocumentDB Binding ........................... SUCCESS [  2.501 s]
[INFO] DynamoDB DB Binding ................................ SUCCESS [ 36.151 s]
[INFO] Elasticsearch Binding .............................. SUCCESS [01:09 min]
[INFO] Geode DB Binding ................................... SUCCESS [ 15.375 s]
[INFO] Google Cloud Datastore Binding ..................... SUCCESS [ 17.363 s]
[INFO] Google Cloud Bigtable Binding ...................... SUCCESS [ 28.209 s]
[INFO] HBase 0.98.x DB Binding ............................ SUCCESS [ 17.536 s]
[INFO] HBase 0.94.x DB Binding ............................ SUCCESS [ 14.672 s]
[INFO] HBase 1.0 DB Binding ............................... SUCCESS [02:07 min]
[INFO] Hypertable DB Binding .............................. SUCCESS [  2.727 s]
[INFO] Infinispan DB Binding .............................. SUCCESS [  4.463 s]
[INFO] JDBC DB Binding .................................... SUCCESS [ 15.285 s]
[INFO] Kudu DB Binding .................................... SUCCESS [  3.029 s]
[INFO] memcached binding .................................. SUCCESS [  2.389 s]
[INFO] Mapkeeper DB Binding ............................... FAILURE [  1.827 s]
[INFO] MongoDB Binding .................................... SKIPPED
[INFO] Oracle NoSQL Database Binding ...................... SKIPPED
[INFO] OrientDB Binding ................................... SKIPPED
[INFO] rados of Ceph FS binding ........................... SKIPPED
[INFO] Redis DB Binding ................................... SKIPPED
[INFO] Rest Client Binding ................................ SKIPPED
[INFO] Riak KV Binding .................................... SKIPPED
[INFO] S3 Storage Binding ................................. SKIPPED
[INFO] Solr Binding ....................................... SKIPPED
[INFO] Solr 6 Binding ..................................... SKIPPED
[INFO] Tarantool DB Binding ............................... SKIPPED
[INFO] YCSB Release Distribution Builder .................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 16:07 min
[INFO] Finished at: 2016-12-26T09:50:18+08:00
[INFO] Final Memory: 98M/233M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.16:check (validate) on project mapkeeper-binding: You have 2 Checkstyle violations. -> [Help 1]
`

The mapkeeper-binding has some check style validation issues. Since the mapkeeper-binding was added, UCSB added some check style checks for conformance across the bindings. You can fix the validation issues. The validation issues are in the Maven output you posted. You are making progress since the binding now is being built.

I successfully intall mapkeeper when doing the six steps on YCSB-0.4.0.  Thank you very much. I am very poor in maven, I may fix the validation issues latter.


Add methods to avoid copying.

Add apropriate methods to avoid copying when storing bytes into OutputStream and MessageDigest. Also, add a method to convert a record into a Bytes object.
Description:

Related issue(s):
Fixes #
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

@jasperpotts I added tests.


Add support for SG15 pseudopotentials

The Yambo code requires a pw.x calculation as a starting point for the GW calculations. However, their code currently only supports Norm-conserving pseudos, and non-linear core corrections (included in the Pseudo-dojo pseudos) are not fully implemented. Hence, @mikibonacci has requested support for the SG15 pseudos, since he would like to use the protocol methods implemented in aiida-quantumespresso with this family of pseudopotentials.
A few topics of discussion:

[ ] Do we keep extending the aiida-pseudo install command when providing support for new pseudopotential families?
[ ] AFAIK, there is no detailed study that provides us with a set of recommended cutoffs for the SG15 pseudos. However, @mikibonacci suggested that perhaps the pseudo-dojo cutoffs might be a good guesstimate.

If I understand correctly, SG15 is not a particular format, but actual pseudo potentials. The SSSP actually includes a number of SG15 pseudos. I think as a rule, we only consider adding an automated entry in aiida-pseudo install if the pseudo family is published, rigorously tested and provided through some persistent identifier, or at least a very stable location to download it from. People are free to create custom pseudopotential families. One can already create an SG15 family with recommended cutoffs with the current API and even CLI. All we have to do here is maybe improve the documentation on how to do this. But all the necessary functionality is there.

I think as a rule, we only consider adding an automated entry in aiida-pseudo install if the pseudo family is published, rigorously tested and provided through some persistent identifier, or at least a very stable location to download it from.

Sounds reasonable. Does "rigorously tested" also mean that one or more stringencies with recommended cutoffs have been identified, as was done for the SSSP? Note that there are several publications on the SG15 pseudos:
http://www.quantum-simulation.org/potentials/sg15_oncv/
You can also download the full set in XML and UPF format from the site.

All we have to do here is maybe improve the documentation on how to do this.

Indeed, I suppose at some point we'll have to set up proper documentation on readthedocs 😅 - Would be happy to work on this, might be a good exercise for me to set this up from scratch. Will already prepare a set of instruction for @mikibonacci for the SG15 pseudos as a starting point.

Does "rigorously tested" also mean that one or more stringencies with recommended cutoffs have been identified, as was done for the SSSP

What I mean here is that there is at least one set of cutoffs defined that has been tested with convergence tests which have been published, and this is not just "some set" that someone came up with off the cuff


Llama3 Conversion to TFLite version gets prematurely killed when running the convert_to_tflite.py script

Description of the bug:
I installed the library and all the requirements for trying out the Llama 3 1B model conversion to TFLite format. However, on running the convert_to_tflite.py script I always end up the process getting killed. Any idea why? This is what get printed on the console. Btw, I'm working on WSL.
2024-10-17 14:06:29.116876: I tensorflow/core/util/port.cc:153] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variableTF_ENABLE_ONEDNN_OPTS=0. 2024-10-17 14:06:29.978986: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations. To enable the following instructions: AVX2 AVX_VNNI FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags. /home/venv/lib/python3.11/site-packages/torch/_subclasses/functional_tensor.py:362: UserWarning: At pre-dispatch tracing, we will assume that any custom op that is marked with CompositeImplicitAutograd and functional are safe to not decompose. We found xla.mark_tensor.default to be one such op.   warnings.warn( /home/venv/lib/python3.11/site-packages/torch/_subclasses/functional_tensor.py:362: UserWarning: At pre-dispatch tracing, we will assume that any custom op that is marked with CompositeImplicitAutograd and functional are safe to not decompose. We found xla.mark_tensor.default to be one such op.   warnings.warn( WARNING:root:PJRT is now the default runtime. For more information, see https://github.com/pytorch/xla/blob/master/docs/pjrt.md WARNING:root:Defaulting to PJRT_DEVICE=CPU WARNING: All log messages before absl::InitializeLog() is called are written to STDERR I0000 00:00:1729174062.687510     372 cpu_client.cc:467] TfrtCpuClient created. Killed
Actual vs expected behavior:
Expected Behavior : It should ideally run without issues and create a tflite file after conversion.
Actual Behavior : Conversion process gets prematurely killed.
Any other information you'd like to share?
No response

Hello. My machine has 16 GB of installed RAM.

I see. The current conversion might require you to have a machine w/ 32 GB Ram, we are working on improvements.

Okay I see. Are there any cloud-based alternatives that I can use to run the scripts?

yes, can you try colab pro? or if you have a remote cloud instance that has sufficient memory, that will work too.


Change the provided AWS CF template URL to be an S3 bucket-based URL

Is your feature request related to a problem? Please describe.
The VMClarity readme.md provides an AWS CloudFormation Template for easy spin-up in an AWS account. The file is hosted in GitHub vs. the AWS supported location of an S3 bucket. Per the AWS guidelines the templateURL must be in an S3 bucket or you will receive an error of "TemplateURL must be a supported URL."  Reference documentation: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-stack.html
Describe the solution you'd like
Place the https://raw.githubusercontent.com/openclarity/vmclarity/main/installation/aws/VmClarity.cfn file into a public S3 bucket (once we move the project to public).

This was resolved. We include the cfn file in each release.


Possibility to keep not Found selectors?

Is to Possible to keep a Selector in the String if it is not found in the Object?

Yes, this is possible with SmartSettings as described in the Wiki. You can e.g. choose to igrnore, to throw an exception etc. The corresponding Parser and Formatter properties are self-descriptive. Examples (you'll need the first one):
Smart.Default.Settings.ParseErrorAction = ErrorAction.MaintainTokens;
Smart.Default.Settings.FormatErrorAction = ErrorAction.MaintainTokens;

Are also instance specific settings (not static ones) possible?

Yes, it is like it is mentioned in the  Wiki:

SmartSettings have the scope for each SmartFormatter instance (meaning they are not static).

Smart.Format(...) are static methods of a static class. So you'll have to create an instance of SmartFormatter. In this case remember to add required SourceExtensions and FormatterExtensions, because they are not set by default.


@Select() of an @Receiver doesnt trigger change events

@Receiver()
    static showTrafficLayer ({ patchState }: StateContext<MapViewStateModel>, { payload }: EmitterAction<boolean>): void {
        patchState ({ showTrafficLayer: payload });
    }

Doesn't trigger changes to that property somewhere else in my code as defined with a Select decorator
@Select(MapViewState.showTrafficLayer) showTrafficLayer$: Observable<boolean>;

the receiver decorator is not designed for this

the problem even is not in receiver, the @Select decorator wants to receive anonymous function | static method decorated with @Selector | state class reference or if there are no arguments passed - it takes your decorated property name

As a user of your package I believe it is a serious shortcoming and should be noted in the documentation. What prevent's it to be implemented? In the receiver code could it be hooked to the dispatch code of selector? (sorry haven't read the code yet)
I think your package is extremely valuable. One thing that becomes quickly apparent when using NgxsModule is the over abundance of Actions even for trivial task which is counter productive. I prefer to use emitter for simple actions and reserve @Action for things that stand up.  But I would expect that the end result is the same.

this violates the concept NGXS, unfortunately, it will not be implemented


Rename Exec to Cmd for service configs to match arch docs

Description:
Issues affected:

Resolves #XXXX

This change is

Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

providers/service/get.go, line 23 [r1] (raw file):

	Uptime      time.Duration     `json:"uptime"`
	ActiveState string            `json:"activeState"`
	Cmd         []string          `json:"exec"`

json tag should be cmd right?

Comments from Reviewable

Review status: 5 of 8 files reviewed at latest revision, 1 unresolved discussion.

providers/service/get.go, line 23 [r1] (raw file):
Previously, mmlb (Manuel Mendez) wrote…
> json tag should be `cmd` right?

Done.

Comments from Reviewable

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable


Import Error when trying to run sh test.sh

After setting all the paths for images and pretained model checkpoint correctly, I run sh test.sh
Get the following error:
ImportError: cannot import name 'loss' from partially initialized module 'lib' (most likely due to a circular import) (/media/user/7200rpm Seagate/UGRP-TruckNumberPlate/GTR/liberation22/init.py)

Seems like there is something very messed up with the standard S-GTR model importing code. frequent errors in this regard.
I ran sh test.sh from main GTR directory

Thanks to @siddagra. We recently checked the import error of the plugin code and solved the problem. Due to other projects, we plan to release some sample packages later.
Please wait for a while

About this problem, we will update some packages of this plugin code recently.


Fix buildtags for some cluster agent related files

What does this PR do?
Properly sets build tags on some files added in PR http://github.com/DataDog/datadog-agent/pull/4935 in order for Snyk testing to pass.
(The change in cmd/cluster-agent/commands/clusterchecks.go is to make it consistent with cmd/cluster-agent/commands/configcheck.go)
Motivation
Snyk go module fails right now, as it runs without considering build tags, so it would see cmd/cluster-agent-cloudfoundry/app/app.go, but not  cmd/cluster-agent/commands as that has buildtags on all files.
Additional Notes
Anything else we should know when reviewing?

Thanks for the reviews everyone! Merging.


--publish doesn't show indication that it is pushing

I ran pack build --push and thought the build is legit stuck here for 1 minute:
===> EXPORTING
[exporter] Adding layer 'launcher'
[exporter] Adding layer 'google.nodejs.runtime:node'
[exporter] Adding layer 'google.nodejs.npm:env'
[exporter] Adding 1/1 app layer(s)
[exporter] Adding layer 'config'

But then it printed
[exporter] *** Images (sha256:9b2a2f74a2cb192598685fc21167c064c176b10258bc8914490d0be9827840e1):
[exporter]       gcr.io/ahmetb-demo/sample-node:latest
[exporter] Reusing cache layer 'google.nodejs.runtime:node'
[exporter] Reusing cache layer 'google.nodejs.npm:npm'
Successfully built image gcr.io/ahmetb-demo/sample-node

a message indicating build has started would be nice.

This is unfortunately outside of our control as buildpacks only have control over the detect and build phases. Please file an issue against pack at https://github.com/buildpacks/pack/issues.

Done https://github.com/buildpacks/pack/issues/615
Thank you.


0.64.1: multiple "bases" declarations yields duplicate releases

see #611
Using 0.64.1
This does not work (expected)
bases:
  - myenv.yaml
  - mydefaults.yaml

This does work (gets past the .Environment references in mydefaults.yaml), however it renders the releases: section twice (and then causes issues w. duplicate releases)
bases:
  - myenv.yaml
---
bases:
  - mydefaults.yaml
---
releases:
....

// Also see my comment at https://github.com/roboll/helmfile/issues/611#issuecomment-495027118

@bitsofinfo I couldn't reproduce the duplication issue.
Could you run helmfile --log-level=debug and see if it really duplicates releases?
For reference, here's what I've used:
The command:
helmfile -e=test --log-level=debug template

helmfile.yaml:
bases:
  - myenv.yaml
---
bases:
  - mydefaults.yaml
---
releases:
  - name: {{ .Environment.Values.myname }}
    chart: stable/envoy
    values:
    - replicaCount: 1

mydefaults.yaml:
helmDefaults:
  tillerNamespace: kube-system
  kubeContext: {{ .Environment.Values.kubeContext }}
  verify: false
  {{ if .Environment.Values.wait }}
  wait: true
  {{ else }}
  wait: false
  {{ end }}
  timeout: 600
  recreatePods: false
  force: true

myenv.yaml:
environments:
  test:
    values:
      - test.env.yaml

test.env.yaml:
kubeContext: test
wait: false
cvOnly: false
myname: "dog"

@bitsofinfo Would you mind sharing your files so that I can try to reproduce or guess what's wrong?

I will tomorrow, but whats diff about mine is that within my releases: is a template using range (so its a loop, feeding of data coming from .Environment.Values

@bitsofinfo Hey! Did you have some time to work on it? I've tried myself but no luck.

I hope to get back to it sometime this week, I'll let you know

Here you go:
I run
helmfile version v0.64.1

helmfile --log-level debug -f deployments.yaml -n default -e test1 apply

I get
processing file "deployments.yaml" in directory "."
first-pass rendering input of "deployments.yaml.part.0": {test1 map[]}
error in first-pass rendering: result of "deployments.yaml.part.0":
 0: bases:
 1:   - envs.yaml
 2:

first-pass rendering result of "deployments.yaml.part.0": {test1 map[]}
second-pass rendering result of "deployments.yaml.part.0":
 0: bases:
 1:   - envs.yaml
 2:

first-pass rendering input of "envs.yaml.part.0": {test1 map[]}
first-pass rendering result of "envs.yaml.part.0": {test1 map[appname:test1 kubeContext:XXXX services:[map[name:x] map[name:y]] something:test1 wait:false]}
second-pass rendering result of "envs.yaml.part.0":
 0: environments:
 1:   test1:
 2:     values:
 3:       - test1.env.yaml
 4:   test2:
 5:     values:
 6:       - test2.env.yaml
 7:

merged environment: &{test1 map[appname:test1 kubeContext:XXXX services:[map[name:x] map[name:y]] something:test1 wait:false]}
merged environment: &{test1 map[appname:test1 kubeContext:XXXX services:[map[name:x] map[name:y]] something:test1 wait:false]}
first-pass rendering input of "deployments.yaml.part.1": {test1 map[appname:test1 kubeContext:XXXX services:[map[name:x] map[name:y]] something:test1 wait:false]}
error in first-pass rendering: result of "deployments.yaml.part.1":
 0:
 1: bases:
 2:   - defaults.yaml
 3:

first-pass rendering result of "deployments.yaml.part.1": {test1 map[appname:test1 kubeContext:XXXX services:[map[name:x] map[name:y]] something:test1 wait:false]}
second-pass rendering result of "deployments.yaml.part.1":
 0:
 1: bases:
 2:   - defaults.yaml
 3:

first-pass rendering input of "defaults.yaml.part.0": {test1 map[appname:test1 kubeContext:XXXX services:[map[name:x] map[name:y]] something:test1 wait:false]}
first-pass rendering result of "defaults.yaml.part.0": {test1 map[appname:test1 kubeContext:XXXX services:[map[name:x] map[name:y]] something:test1 wait:false]}
second-pass rendering result of "defaults.yaml.part.0":
 0: helmDefaults:
 1:   tillerNamespace: kube-system
 2:   kubeContext: XXXX
 3:   verify: false
 4:   wait: false
 5:   timeout: 600
 6:   recreatePods: false
 7:   force: true
 8:

merged environment: &{test1 map[appname:test1 kubeContext:XXXX services:[map[name:x] map[name:y]] something:test1 wait:false]}
merged environment: &{test1 map[appname:test1 kubeContext:XXXX services:[map[name:x] map[name:y] map[name:x] map[name:y]] something:test1 wait:false]}
first-pass rendering input of "deployments.yaml.part.2": {test1 map[appname:test1 kubeContext:XXXX services:[map[name:x] map[name:y] map[name:x] map[name:y]] something:test1 wait:false]}
first-pass rendering result of "deployments.yaml.part.2": {test1 map[appname:test1 kubeContext:XXXX services:[map[name:x] map[name:y] map[name:x] map[name:y]] something:test1 wait:false]}
second-pass rendering result of "deployments.yaml.part.2":
 0:
 1: releases:
 2:
 3:   - name: nginx-test1-x
 4:     namespace: default
 5:     chart: stable/nginx-ingress
 6:
 7:
 8:
 9:   - name: nginx-test1-y
10:     namespace: default
11:     chart: stable/nginx-ingress
12:
13:
14:
15:   - name: nginx-test1-x
16:     namespace: default
17:     chart: stable/nginx-ingress
18:
19:
20:
21:   - name: nginx-test1-y
22:     namespace: default
23:     chart: stable/nginx-ingress
24:
25:
26:

merged environment: &{test1 map[appname:test1 kubeContext:XXXX services:[map[name:x] map[name:y] map[name:x] map[name:y] map[name:x] map[name:y] map[name:x] map[name:y]] something:test1 wait:false]}
err: duplicate release "nginx-test1-x" found in "kube-system": there were 2 releases named "nginx-test1-x" matching specified selector
in ./deployments.yaml: duplicate release "nginx-test1-x" found in "kube-system": there were 2 releases named "nginx-test1-x" matching specified selector

SOURCE FILES:
defaults.yaml
helmDefaults:
  tillerNamespace: kube-system
  kubeContext: {{ .Environment.Values.kubeContext }}
  verify: false
  wait: false
  timeout: 600
  recreatePods: false
  force: true

deployments.yaml
bases:
  - envs.yaml

---

bases:
  - defaults.yaml

---

releases:

  {{- $appname := .Environment.Values.appname -}}
  {{- $namespace := .Namespace -}}

  {{- range $service := .Environment.Values.services }}

  - name: nginx-{{ $appname }}-{{ $service.name }}
    namespace: {{ $namespace }}
    chart: stable/nginx-ingress

  {{ end }}

envs.yaml
environments:
  test1:
    values:
      - test1.env.yaml
  test2:
    values:
      - test2.env.yaml

test1.env.yaml
appname: test1

kubeContext: XXXX
something: test1
wait: false

services:
  - name: "x"
  - name: "y"

test2.env.yaml
appname: test2

kubeContext: XXXX
something: test2
wait: false

services:
  - name: "x"
  - name: "y"

@bitsofinfo You revealed a big bug, which is fixed via #622. Thanks for your support as always ☺

@bitsofinfo Btw, please feel free to give me advanced example configs like yours, so that I can turn them to regression tests.

absolutely, as they come up I'll keep posting.
thanks!

@bitsofinfo Thanks again for the report! I've reproduced it locally, and will fix it soon.

Verified fixed


make dll bundle

Description
Bundle all into DLL to make it easier for some ppl.
Problems
There's a problem with DLL bundling with the future in mind. Allow me to explain:

Mod
Version
Assets Size

Cheb's Necromancy
2.X.X
~22mb

Cheb's Necromancy
3.X.X
~27mb

Adding the Cheb's Mercenaries mod stuff to the assets bundle added about 5mb. In the future, as more variants get added like Druidry, Demonology, so on and so forth, this can be expected to grow and grow.
Separate
Attention: as of 3.0.6, ChebsValheimLibrary.dll is merged into the ChebsNecromancy.dll, meaning that only the assets file is left separate.
If left separate, the player can have one copy of the asset bundle on their system and the DLLs will share it:

Benefits

Most efficient

Drawbacks

Most complicated: several DLLs and an assets file

Bundled
If bundled, each bundle is its own box and requires a copy of everything inside it to work:

Benefits

Simple: one big, fat DLL

Drawbacks

One big, fat DLL
Each additional mod added has its own copy of everything which bloats

Future Scenario
Imagine in the future when we have not only Necromancy and Mercenaries, but also Druidry, Demonology, and Golem Maker. Let's theorize that the new mods have resulted in a 75mb assets file.
Separate
If installed using the separate method, the total file size of all 5 mods including their DLLs will be less than 80mb.
Bundled
If installed using the bundle method, the total file size of all 5 mods will be at least 375mb.

Ugh, the final nail in the coffin for this bundling stuff is it ruins the cross-compatible nature of my mods when installed together. For more detail, please read here where the discord discussion took place but I'm going to have to disappoint and deny this request. I'm sorry.


fix($templateRequest): Set Accept header on template requests

Set the Accept header on HTTP requests for templates to text/html, text/ng-template.
Previously the default request headers sent by $http were used.
Closes #6860

We have a new PR that overrides this one, as it is configurable and has tests.


Develop a color layer for scalar values (eg temperature)

WIP, working but not optimized, see https://github.com/IHCantabria/Leaflet.CanvasLayer.Field/issues/7

Maybe better to switch to WebGL rendering, e.g. should be simple to draw a grid overlay with https://github.com/manubb/Leaflet.PixiOverlay.

We encounter the same issue than https://github.com/IHCantabria/Leaflet.CanvasLayer.Field/issues/8 with GFS, the layer should be updated to manage longitude wrapping when input data grid are specified in range [0, 360] and not [-180, 180].
Maybe we should enhance our Grid class to manage the formatting of input data in the same reference system. To avoid any artifacts this has to be taken into account when interpolating.

It also seems that in some cases we exceed the WebGL vertex buffer size limit. For now we create one mesh, we can subdivide the grid in order to produce multiple mesh.


Add pumpout_port and connection_size to product_option

Because the structure of the JSON response has changed due to the production attribute refactor, this will need to be re-worked as well.


Fixed no scroll issue in CaseRef and updated directory name

Fixed the no scroll issue in CaseRef and updated directory name.

Can we do single purpose PRs in the future please

Sure.


Failed requests get retried forever

We were recently investigating a very high traffic bill from our datacenter to Bugsnag. It turns out that all of our servers have the following in their /var/log/upstart/bugsnag.log:
...
Cannot send request. Retrying in 5 seconds
Traceback (most recent call last):
  File "/usr/bin/bugsnag-agent", line 138, in _client
    urllib2.urlopen(req).read()
  File "/usr/lib/python2.7/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 406, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 519, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 444, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 527, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
HTTPError: HTTP Error 400: Bad Request
continuing...
Enqueued 590886 bytes (119/1000)
Sending 612099 bytes (118/1000)
Cannot send request. Retrying in 5 seconds
Traceback (most recent call last):
  File "/usr/bin/bugsnag-agent", line 138, in _client
    urllib2.urlopen(req).read()
  File "/usr/lib/python2.7/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 406, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 519, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 444, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 527, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
HTTPError: HTTP Error 400: Bad Request
continuing...
Enqueued 573080 bytes (119/1000)
...

It appears to have the same set of around 120 errors stuck in it's queue, and every one of the 10 threads sends one and gets the same "400 Bad Request" response, and requeues it and waits 5 seconds. That's 2 requests per second, or 172,800 per day, or at around 1MB per request, 172GB per server per day. With around 10 servers and running bugsnag-agent for around 10 days, the ~10TB bandwidth bill certainly caught us off guard.

Is there any way to see what problem notify.bugsnag.com has with these requests? (they come from bugsnag-php)
Can bugsnag-agent be made not to retry failed requests, or limit the number of retries made for each payload?

@jesseschalken Apologies for the delay on getting back to you on this. If the requests are 1MB that seems likely that is the cause - we limit the size of a crash report and this would definitely be over that limit. Can you take a look at any of the reports to see what they contain? Do you know why they would be so large?
I think the solution of not retrying failed requests more than a few times is totally reasonable. The agent should also log the payloads that fail so we can inspect them to see what the issue is. We are totally open to a PR if you have the bandwidth to get around to this before I do - but I will try and get around to making this change this week.

@snmaynard I was just about to deploy https://github.com/jesseschalken/bugsnag-agent.js which is just a Node.js version of the same script that doesn't retry failed requests (and doesn't have the arbitrary queue size/thread count), to at least fix our traffic problem.
I've only focused on making the agent we use not behave badly in the case of failure, and haven't bothered trying to figure out what the actual problem is with the requests.
Most payloads are in the 500KB-1MB range. What is the limit notify.bugsnag.com imposes?
I'll try to reproduce a failing request and get back to you. If I can't reproduce it locally I'll deploy bugsnag-agent.js with it logging failed payloads and have a look at the logs.

I think the request size was indeed the problem. The threshold where notify.bugsnag.com responds with 401 Bad Request is somewhere between 524,259 and 524,534 bytes, and according to the log the requests that are failing are consistently over 524KB and the ones the succeeding are consistently less. I found the threshold by sending a report with 1,900 stack frames through, so I still don't know why the reports happening in production are so large. It could be a big chunk of data in $_SESSION or something.

I've been able to reproduce a 4MB payload. Bugsnag_Client has been configured to use batch sending ($client->setBatchSending(true)), which will queue up all errors and send them in a single request. If a lot of errors happen in a single PHP process, then the 524KB limit is easily exceeded.
Maybe bugsnag-php needs to be changed to bundle multiple queued errors in batches of less than 5KB?

The large requests in production turned out to be megabytes of data stored in $_SESSION. See https://github.com/bugsnag/bugsnag-php/pull/91.

Fixed via #14


SPUserProfileSyncConnection: Connection get's recreated every time if the name contains a dot

Details of the scenario you try and problem that is occurring:
We're adding multiple sync connections to the UPS.
If the name for the connection contains a ".", this connections is recreated every time you run the script.
We were able to "fix" it, by replacing the dots with hyphens (see code below).
The connection was already beeing named with the hyphen in SP, even without replacing the dot. So if the forest is "ads.foobar.de" it shows up as: Name "ads-foobar-de" and forest "ads.foobar.de".
$SharePointConfigData.Services.UserProfiles.SyncConnections | ForEach-Object -Process {
    SPUserProfileSyncConnection $_.Forest
    {
        Name                  = $_.Forest.Replace(".", "-")
        Forest                = $_.Forest
        UserProfileService    = $SharePointConfigData.Services.UserProfiles.Name
        IncludedOUs           = $_.IncludedOUs
        ConnectionType        = $connectionType
        ConnectionCredentials = $UpsSyncAccount
        UseSSL                = $false

        DependsOn             = "[SPUserProfileServiceApp]UserProfileServiceApp"
        PsDscRunAsCredential  = $SpSetupAccount
    }
}

Example from our configuration file:
SyncConnections  = @(
    @{
        Forest      = "adm.bla.blub.ads.foobar.de"
        IncludedOUs = @(
            "CN=MANAGED SERVICE ACCOUNTS,DC=ADM,DC=SWE,DC=baz,DC=ADS,DC=foobar,DC=DE",
            "CN=USERS,DC=ADM,DC=SWE,DC=baz,DC=ADS,DC=foobar,DC=DE",
            # <snip>
            "OU=TESTSERVERS,DC=ADM,DC=SWE,DC=baz,DC=ADS,DC=foobar,DC=DE"
        )
    },
    @{
        Forest      = "ADS.foobar.COM"
        IncludedOUs = @(
            "CN=USERS,DC=ADS,DC=foobar,DC=COM",
            # <snip>
            "OU=RO,DC=ADS,DC=foobar,DC=COM"
        )
    }
    # <snip>
}

Version of the Operating System and PowerShell the DSC Target Node is running:
Windows Server 2012 R2, PowerShell 5.1
Version of SharePoint that is used (e.g. SharePoint 2016):
SharePoint 2016
Version of the DSC module you're using:
<IP_ADDRESS>

I am working on an update for this resource in my next bugfix PR. I will investigate this issue and implement a fix at the same time!

Fixed in PR #811

PR merged, closing issue


pagination directive: the itemsPerPage id argument (id: tableConfig.key) does not match a registered pagination-id.

Hi,
When updating to the latest version 0.11.0 I'm getting the following error:
pagination directive: the itemsPerPage id argument (id: tableConfig.key) does not match a registered pagination-id.
My pagination-id is being set properly. Version 0.10.0 is working good but not 0.11.0.
A breaking change has been introduced and looks like related with the deregisterInstance code addition in V0.11.0?

Thanks for the report. There was no regression in the unit tests with v0.11.0 - are you doing something "special" with the module? Are the controls inside and ngIf or something else which might be destroying the scope in the middle of usage?

Thank you for the answer. The pagination control have a ng-if="tableRows.length > 0".
But I'm running the same code with 0.10.0 and working great. Some of the changes for 0.11.0 is a breaking change. For now, I'll be using 0.10.0 and won't upgrade to 0.11.0.

Ok, reverting to 0.10.x makes sense for now. When I get time, I'll add some unit tests for you type of use case and try to fix the changes to 0.11.0.

@patrickrioux If you have time, could you try to reproduce the issue by forking this plunker demo - it is using the latest version (0.11.0 right now) so hopefully you should be able to reproduce.

I reverted to 0.10.0 as well as I got the same results after adding the following packages:
"angular-loading-bar": "^0.9.0",
"angular-animate": "^1.5.3"
Later when I have time I will try to help and debug why these packages break 0.11.0 but not 0.10.0

Please update to v0.11.1 (I reverted the memory-leak fix) and let me know if this solves this issue.

Hi Michael,
Sorry for not having the time to update the plunker demo although I took some times to test v0.11.1
I confirmed that your changes fixed the issue. Thank you.


Group context doesn't seem to apply when inherited via parent

Description
I have permission nodes in a group called plotperms and I use this group to give permissions to players to use in specific server/world contexts by adding it as a parent to the default group.  In previous versions of LuckPerms this seemed to work fine, but I am setting up a new network and applying the same technique but the player is not able to inherit these permissions.
Reproduction steps

Example permission of plots.auto exists in the group plotperms
Player1 is on server public in world plot75
default inherits plotperms on server public and world plot75 contexts
(by using the command /lp group default parent add plotperms public plot75)
Player1 tries using the command /plot auto which claims a new plot but it says they do not have permission: plots.auto and looking at /lp verbose says that the plots.auto permission is undefined.

If you assign the plotperms group to default or to the player directly without a server or world context, the player is then able to use the command.
Environment details
Running Tuinity 1.16.5 build f0e91a4
Using LuckPerms v5.3.53
No errors in console

This was resolved by deleting config.yml and regenerating a new one. I guess I modified something that broke context evaluation? Anyways it's fixed now.


[RAINCATCH-507] Update to handle sync remote events

What
Allow users to view the current sync status of a workflow on-device, notifying them if there are any errors that occurred during sync to the remote data store.
How
The current sync status is included in the workflow object received from cloud. In the workflow list template, a sync error icon and message are added and shown when a remote update failed occurs.
JIRA
https://issues.jboss.org/browse/RAINCATCH-507

@vchepeli updated according to review


Vision

The vision cam base has been set, however the live cam is not set currently. Need to look at code later and configure dual camera with the Rio


periodic duplicate counts of docker.containers.running metric on ecs ec2 hosts running both agent in both a daemonset and sidecar

What happened:
we run daemonset datadog agents on each of our ecs ec2 nodes.  on most nodes the docker.containers.running metric accurately reflect the number of conatiners running on that machine. on a few machines we run a container with the datadog agent additionally running as a side-car to a container to forward APM traces.  on this nodes we see repeating periodic duplicate counts of docker.containers.running metric.

What we expected:
we expected no duplication of counts of the docker.containers.running metric on the nodes where the daemonset agent is responsible for sending metrics/logs/dogstatd, and the side-car is configured to only for APM trace forwarding
To reproduce the issue:
run a daemonset or locally run datadog agent set to handle metrics.logs/dogstatd/checks.  then on the same machine run a container with the datadog agent running in a sidecar with the following environmental variables and no volumes mounted from the host system:
                {
                    "name": "DD_APM_ENABLED",
                    "value": "true"
                },
                {
                    "name": "DD_APM_NON_LOCAL_TRAFFIC",
                    "value": "true"
                },

Environment details:
AWS ECS, Amazon Optimized 2 Linux for ECS.
datadog/agent:7.27.0-7.28.1

Hi @danbf. We do not recommend running two agents on one node ever. This will cause a lot of unexpected behavior, including the behavior you are referring to here. You can follow these instructions for running APM with your ECS EC2 agents: https://docs.datadoghq.com/agent/amazon_ecs/apm/?tab=ec2metadataendpoint

We have a large cluster, and only a few services that require APM so we didn't want to turn APM up on every node in the cluster and were hoping to not have to introduce complexity into our environment by introducing sub-clusters for those services wanting to run APM.
Overall what we have going works, except for the few metrics like the periodic duplicate counts of docker.containers.running.


Theme re-submission : Potato Dark

Theme submission
Please make sure that you have read the theme submission guidelines before submitting a theme. The guidelines provide all relevant information and requirements that have to be fulfilled before the submission. Please tick the relevant boxes for your theme in the checklist below:
Link to my theme repository: https://github.com/surajmandalcell/potato-dark
I made sure that...

[x] the repository contains a good README.md describing my theme
[x] an open source license has been added to LICENSE.md
[x] all metadata have been added to theme.toml
[x] screenshots have been added in the images/ folder with the required dimensions
[ ] in case I'm using a customized demo via the exampleSite folder that

[ ] https://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domains
[ ] I tested that my theme's demo works with the content directory of gohugoio/HugoBasicExample

[x] I tested my theme against the gohugoio/HugoBasicExample

[x] I've checked the developer tools' console in my browser for error messages

[ ] in case my theme is using Hugo Pipes features like toCSS and PostCSS that I have committed the /resources directory with all generated assets, for my theme to work in the basic version of Hugo

N.B. By submitting a theme to the Hugo Themes Showcase you understand that you need to maintain your theme. You will need to keep an eye on whether your theme's demo generates on the Hugo website, whenever there is a new release. We are a very small team and we just cannot keep up opening issues in the various theme repositories to notify authors. Whenever a theme demo breaks and remains broken then at some point it will be removed from the list without prior warning. If you no longer wish to maintain a theme please let us know.
Feel free to ask questions. We're glad to help.

Hello @surajmandalcell
Everything seems fine except for the min_version in theme.toml it should be 0.57.0 since you fixed your theme for #682
Also note that Hugo started using full semver versions even for main releases in v0.54.0, therefore a valid min_version needs to be entered as 0.57.0 and not 0.57
Once you fix this let me know.

@onedrawingperday Done, thanks for letting me know.

@surajmandalcell
I added your theme back to the Hugo Themes Showcase in 81feb36

Thank you!


Add packet SClickContainer and abstractions

Only the packet and abstraction has been implemented so far, the logic will be implemented shortly.

Tried to get double-clicking to work, but since everything else works, and I'm kind of tired of Inventory work, I'll just leave my PR as this.
Also, do note that due to how Pumpkin currently handles packets in quick succession (it doesn't, it sometimes drops them), dragging items only partially works.

In this PR, I have also added the command /echest which is very helpful when testing out the inventory system.
It is a global container, that all players can look at at the same time.


What is necessary to be able to implement completion?

Hello.
I just recently came to this project, and I found it to be very interesting.
I'm looking forward to the Autocomplete feature, and I intend contributing to the project to implement it.
What would be the general guidelines to have something like this implemented?

I'm not sure if you're asking what it would take to implement it, what my policy would be on you implementing it directly, or something else. I'll try to answer everything:

To implement this, basically a full on SQL lexer / parser would need to be implemented. Since the different dialects of SQL are in use for the different databases, likely a "single lexer" would not be good enough. A lexer/parser would be necessary in order to create suggestions that are context sensitive (ie, there is some kind of "comprehension" of what valid/invalid SQL is.

Assuming that 1 is implemented, then it would be relatively easy to integrate it into the existing readline package that is in use in order to suggest the next item. I believe it's just a simple anonymous function that gets passed somewhere when creating the readline configuration. It handles the busy work of responding to tabs/completing the actual word(s).

If you wanted the context completion to be really cool, it would also be necessary to do some kind of database introspection for column, table names, stored proc names, etc. You might want to look at the xo project for some fairly comprehensive introspection code.

That said, my policy would be if you implemented any / or part of the above (or integrated some other code) I'd be glad to merge it so long as it wasn't in conflict with the MIT license. I'd be happy to merge all or part of the above for one or more databases so long as the code is well written, documented, and clear. Try using the gometalinter tool. This project isn't very big, so we don't have anything like crazy CLAs or anything to submit code. Just create a PR, I'll review, and either merge or close it out without merging.
Anyway, I'm glad you like the tool! I'd love to see third-party contributions!

Also -- note that if you have some other clever way of doing completion without a full fledged SQL lexer/parser, that's cool too. Submit it here! If you're concerned that your work would be in vain because I disagree with your approach, do a simple 1 or 2 paragraph write-up in advance describing how you propose to implement it, and I'll provide feedback. Even if we might disagree, it's MIT licensed, so anyone is free to branch the repository -- one of the great things of open source!

Hi,
funny 7 Months ago, I mentioned (as stdiopt) i was working in something similar with basic highlighting
https://www.reddit.com/r/golang/comments/5x7hr4/usql_is_a_universal_commandline_for_sql_databases/
but basically I stopped working on it and lately I've been resuming testing few things including maintaining the chzyer readline, which seems dormant, in a fork project and one added feature was the ability to alter the prompt "render"  providing highlight capability
https://github.com/gohxs/readline
Also corrected some issues and crashes as shown in my readline merge attempt
https://github.com/chzyer/readline/pull/130
I think you can easily (not sure about multilines) implement  https://github.com/alecthomas/chroma the that for:

syntax highlighting (WIP)

As for completion I implemented it on mine as a regular PrefixCompleter from package readline but I started to implement a lexer/parser to contextual complete

SQL completion (WIP)

I was also trying to do something with the history stored:

If the API is the same as the original readline package, it should be able to drop into usql without much difficultly. I already have a working branch of usql with some highlighting involved, but haven't finished it.

For the highlight i had to adapt readline itself, hence the fork, with the way readline is made(controlling the cursor, position the line, etc) i didn't found an easy solution outside of pkg itself.
Although seems that the author started merging some PR's and one of those includes a similar to the one I adapted. so the latest readline should support something similar.
Odly he didn't merge my PR and went away, i've got a couple of user posted issues fixed
https://github.com/gohxs/readline/issues?q=is%3Aissue+is%3Aclosed

I changed over to @hexasoftware 's readline package, as well as changed the github group, and implemented the initial version of the syntax highlighting.
Use \set to change the settings:
ken@ken-desktop:~$ go install github.com/xo/usql
ken@ken-desktop:~$ usql pg://
Connected with driver postgres (PostgreSQL 9.6.5)
WELCOME TO THE JUNGLE Tue Oct 10 00:51:06 WIB 2017
Type "help" for help.

pg:booktest@=> \set
SHOW_HOST_INFORMATION = 'true'
SYNTAX_HL = 'true'
SYNTAX_HL_FORMAT = 'terminal16m'
SYNTAX_HL_STYLE = 'monokai'
pg:booktest@=> \set SYNTAX_HL_STYLE dracula

Even though I closed this issue, wanted to give a brief update here. I've tracked down "most" of the bugs / issues with syntax highlighting. I'll be adding "completion" as soon as I can get to it. Appreciate @hexasoftware additions to readline -- originally I had been looking at making similar changes to readline in order to get chroma to work with it, but glad that I did not ultimately have to. The syntax highlighting is hackish, inefficient, and ugly, but hey, it works! Note though that for whatever reason it doesn't seem to work correctly on Windows.

I'll be doing a new release soon, after a couple of other features/enhancements, but please if you can, try this out with a couple of different databases, and let me know if there are any issues. You can simply do the standard Go installation:
$ go get -u github.com/xo/usql

chzyer/readline (thus gohxs/readline) has some issues with windows ansi, it should support at least 16colors

I am confused. According to the subject of this issue the issue is about completion, but people keep talking about syntax highlighting. Moreover, if I am not mistaken, there is no completion at all in usql, let alone context-based completion - contrary to what the main README.md says. That's disappointing.

Can anyone confirm @dsh2 's claim? Tab-completion is much more useful than syntax highlighting. Without tab-completion usql would basically be a multi-database Sqlcmd replacement (feature-wise)

Well, I don't understand why README writes that usql supports tab completion.
There is no completion at all, pressing tab just inserts a tab. ( I only tried it on Windows & WSL)
I think even completion such as in phpMyAdmin is better than this, it seems in phpMyAdmin the completion is somewhat just a list of keywords without context.
A REPL without completion is I think much less useful.


Fix docker-compose bug: publicClient is not valid and error

What changed?
Fix docker-compose bug: publicClient is not valid and error

Why?
For https://github.com/uber/cadence/issues/4121

How did you test it?
Local test.
The error is gone after this change.

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 79190792-0e12-4b5e-ae65-e657e05725d4

0 of 0   changed or added relevant lines in 0 files are covered.
55 unchanged lines in 10 files lost coverage.
Overall coverage decreased (-0.02%) to 59.755%

Files with Coverage Reduction
New Missed Lines
%

host/signalworkflowTest.go
1
95.53%

common/task/fifoTaskScheduler.go
2
85.57%

service/history/execution/mutable_state_builder.go
2
69.85%

service/history/handler.go
2
46.67%

service/history/queue/timer_queue_processor.go
2
58.77%

common/persistence/cassandra/cassandraPersistence.go
3
51.2%

common/types/history.go
4
24.69%

service/history/historyEngine.go
4
70.84%

service/history/queue/timer_queue_processor_base.go
4
78.6%

common/persistence/cassandra/cassandraPersistenceUtil.go
31
90.98%

Totals

Change from base Build 9dc8b8dc-fdbb-4c95-9864-08e8eeb83d3f:
-0.02%

Covered Lines:
87895

Relevant Lines:
147093

💛  - Coveralls


[CIT-408] Add az.mapper.timestamp unit tests and refactoring in config tests

Proposed changes

I completely forgot to add unit test cases for az.mapper.timestamp. Added those tests.
Did small refactoring for the key az.mapper.timestamp. Basically, the implementation should be the same with mqtt.port, however, there was inconsistency whether adding the key to TEdgeConfigDefaults struct. I decided to add az.mappaer.timestamp to there.
Did refactoring the existing unit tests in config. Some tests should be renamed, some tests should be merged to other tests, something was missing. I consulted with @albinsuresh.

Types of changes
What types of changes does your code introduce to thin-edge.io?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactorings that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[x] I used cargo clippy as mentioned in CODING_GUIDELINES
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Codecov Report

Merging #289 (5339e12) into main (5e34f13) will increase coverage by 0.59%.
The diff coverage is 98.96%.

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
+ Coverage   65.63%   66.22%   +0.59%
==========================================
  Files          65       65
  Lines        3710     3778      +68
==========================================
+ Hits         2435     2502      +67
- Misses       1275     1276       +1

Impacted Files
Coverage Δ

tedge_config/src/tedge_config_defaults.rs
89.47% <50.00%> (-4.65%)
:arrow_down:

tedge_config/src/tedge_config.rs
44.44% <100.00%> (ø)

tedge_config/tests/test_tedge_config.rs
98.70% <100.00%> (+0.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e34f13...5339e12. Read the comment docs.


Save Login Credentials?

Is there a way to save your login credentials so that we don't have to type them every time we open the app?

Hello, @drohm.
Unfortunately app is not maintained any more.


Fix malformed known anchor in system-web-samesite

@jeremycook  how did you find that?

@Rick-Anderson that there was a broken link was pretty obvious when looking at the page.

Thanks again.

You're welcome. Thank you to you and your team for the docs.


Posting to reference endpoint creates an empty reference

This might be a frontend bug, because I'm sending the same request that the frontend sends and maybe the request is wrong, but when posting the following, the reference is created but is empty:
POST /dataset/3/reference
{
   "type":"personal_communication",
   "title":"Species estimates based on World Ferns data (personal comment).",
   "author":[
      {
         "family":"M.",
         "given":"Hassler"
      }
   ],
   "issued":{
      "date-parts":[
         "2019",
         "04",
         "21"
      ]
   },
   "accessed":{
      "date-parts":[
         "2019",
         "04",
         "21"
      ]
   }
}

9d511e85-343a-4096-bcd4-b8c6a37f3b79
GET https://api.catalogue.life/dataset/3/reference/9d511e85-343a-4096-bcd4-b8c6a37f3b79
{
  "created": "2020-10-26T15:13:22.705672",
  "createdBy": 103,
  "modified": "2020-10-26T15:13:22.705672",
  "modifiedBy": 103,
  "datasetKey": 3,
  "id": "9d511e85-343a-4096-bcd4-b8c6a37f3b79",
  "parsed": false
}

yes, the reference objects look different from what you posted:
http://api.catalogue.life/#model-Reference

It looks like the frontend just sends the CslData component of the reference object. Should I transfer this to the frontend?

@thomasstjerne, the reference request should actually be like below.
POST http://api.dev.catalogue.life/dataset/3/reference
{
  "csl": {
    "type": "personal_communication",
    "author": [
      {
        "family": "Hassler",
        "given": "M."
      }
    ],
    "accessed": {
      "raw": "2019"
    },
    "issued": {
      "raw": "2019"
    },
    "title": "Species estimates based on World Ferns data (personal comment)."
  },
  "year": "2019",
  "citation": "Hassler, M. 2019. Species estimates based on World Ferns data (personal comment).",
  "datasetKey": "3"
}

GET: http://api.dev.catalogue.life/dataset/3/reference/8a9227c0-609f-42ed-8e2a-8971d76ca4e7
{
  "created": "2020-10-26T18:18:49.801388",
  "createdBy": 103,
  "modified": "2020-10-26T18:18:49.801388",
  "modifiedBy": 103,
  "datasetKey": 3,
  "id": "8a9227c0-609f-42ed-8e2a-8971d76ca4e7",
  "csl": {
    "type": "personal_communication",
    "author": [
      {
        "family": "Hassler",
        "given": "M."
      }
    ],
    "accessed": {
      "raw": "2019"
    },
    "issued": {
      "raw": "2019"
    },
    "title": "Species estimates based on World Ferns data (personal comment)."
  },
  "citation": "Hassler, M. 2019. Species estimates based on World Ferns data (personal comment).",
  "year": 2019,
  "parsed": true
}


Who is in charge of writing the history?

See overview here: https://github.com/fractal-analytics-platform/fractal-server/issues/506
This is a bit of a tricky question. I see 3 main places of who could write this history, all with pros & cons:
1. Each task writes the history
Tasks write history into the metadata dictionary and the OME-Zarr file?
Or tasks write it in the metadata dictionary, something else writes it in the OME-Zarr file?
Or tasks write history to the OME-Zarr file, the server gets it from there if it's needed for the metadata
Pros:

Minimal changes to the server

Cons:

Every task needs to handle this => additional complexity and code repetition across tasks
Some tasks written by a third party may not write any history

2. The run_fractal_task function writes the history
The wrapper function that is being used to run the task and already applies the type checking of the inputs,
Pros:

Wrapped and abstracted from normal task running
A single place to update for changes
Is run as the user => has access to the OME-Zarr file on disk
Already handles updates to the metadata dictionary, if things should go via there

Cons:

Do all other task packages need to depend on the large fractal-tasks-core package to get this utils function?
What about non-Python tasks? => would need to write this on their own or not have history
If we want to e.g. save the workflow export here, does this code executed from within the task package have access to all relevant information? It can't make a call to the server. It has access to the task parameters, but also the task version (yes via version of the installed package)?

3. The server writes the history
Pros

Very general solution: Any task that is run by Fractal server will have its history written, independent of task language and how someone implements their task.

Cons:

Server becomes OME-Zarr specific through its history writing
The server process (e.g. the fractal user) doesn't have write access to the OME-Zarr file

I don't like the raw option 1. Option 2 sounds appealing, but raises some questions (see cons). Also could be a different wrapper approach than run_fractal_task of course. Option 3 would be the most general, but also comes with downsides.
One idea (depending on where that history is stored when, see: https://github.com/fractal-analytics-platform/fractal-server/issues/508) could also be to have this split: run_fractal_task adds information to the metadata dictionary and we require other tasks to also put some info in there (e.g. a Java task needs to also update that metadata json). Another part then ensures it's written to the OME-Zarr file. Not sure whether such a split would be helpful though (may still allow tasks that don't write any history and doesn't solve the access problem).
An alternative thought is having a "collection" task that is always run after each task (1 per plate), which ensures that the correct history is taken from the metadata file (or added to the metadata file first) and then written to the OME-Zarr. Downside here is that this wouldn't run in our normal setup if any well fails (see discussion on when history is written).

With #803, we implemented option 3 for the server-side history. The rest is still to be decided as part of #508 (maybe this issue can be merged with #508, or a single one can be created out of these two).

I'd say this is covered in the new framing of #508 as "Propagate history from db Dataset to ome-zarr"


upd(obs-backgroundremoval): 1.1.7 -> 1.1.8

jammy is not supported for building anymore. cf https://github.com/occ-ai/obs-backgroundremoval/issues/502
CI fails to uninstall on other distros


next-aws-lambda can now be consumed using async signature

next-aws-lambda now supports async promises:
// using async promise

module.exports.render = async (event, context, callback) => {
  const responsePromise = compat(page)(event, context); // don't pass the callback parameter
  return responsePromise;
};

Also updated usage in the plugin to use this approach.
Closes https://github.com/danielcondemarin/serverless-nextjs-plugin/issues/125

Would this allow us to control header (like cache-control)?


Roundtrip failure when using DELTA_BINARY_PACKED

Describe the bug
As far as I can tell, the DELTA_BINARY_PACKED decoder can sometimes get into a "runaway" state, where the values it produces get more and more different from the correct value.
To Reproduce
I've uploaded two small parquet files:

http://www.asayers.com/files/good.parquet (7 KiB)
http://www.asayers.com/files/bad.parquet (4 KiB)

They both contain the same data: a bunch of numbers in a single INT64 column.  They were both produced using the parquet crate (HEAD, 3135a53e).

In good.parquet they're encoded as PLAIN RLE.
In bad.parquet they're encoded as DELTA_BINARY_PACKED RLE.

Here's a program which reads the data back and prints it:
fn main() {
    let path = std::env::args().nth(1).unwrap();
    let file = std::fs::File::open(path).unwrap();
    let rdr = parquet::file::serialized_reader::SerializedFileReader::new(file).unwrap();
    for row in rdr.into_iter() {
        use parquet::record::RowAccessor;
        println!("{}", row.get_long(0).unwrap());
    }
}

Running this program on good.parquet gives back the correct numbers, ending like so:
1468797175075281492
1468797175076709400
1468797175076902975
1468797175077250207
1468797175077829776
1468797175077980647
1468797175078872591
1468797175083351616
1468797175804941300
1468797178324785080

Running on bad.parquet looks correct at first, but then towards the end it starts to go wacky:
1468797175059406818
1468797175059715342
1468797175059831514
1468797175060873770
2937593677245033068
4406390179428921343
5875186685908006897
7343983196682139470
8812779707456502586
-8165167851184027777
-6696371327525264784
-5227574803866540077

More context
I spent some time yesterday minimising this reproducer (it started at 1.4 GiB).  However, while I was able to reproduce the bug with a variety of data, I was never able to do it with fewer than 1000 rows.  I hope that gives you a clue to the cause!

Looks like this is the first failing commit: 02d17abfb2533b5c4afb4b33cc7b552030f8665e

@tustvold do you have any ideas about what could be causing this?

Hi, thank you for the report. I'll take a look either today or tomorrow, it's likely a bug in the offset tracking logic


fix alma failure

There is one additional os.path.join in the alma.core file where I'm unsure if it should be replaced: https://github.com/astropy/astroquery/blob/master/astroquery/alma/core.py#L900
But this PR at least makes the tests pass:

https://ci.appveyor.com/project/MSeifert04/astroquery/build/1.0.6
https://travis-ci.org/MSeifert04/astroquery/builds/150737049 (still running)

Thanks @MSeifert04!


Update OpenAiApi.java

While exploring the OpenAiApi class, I identified some areas for improvement within the ChatModel and ChatCompletionFinishReason enums and proceeded with the following adjustments:

I updated the version in ChatModel from gpt-3.5-turbo-1106 to gpt-3.5-turbo-0125.
I corrected a typo in ChatCompletionFinishReason, changing TOOL_CAL to TOOL_CALL.

based on this comment from https://openai.com/blog/new-embedding-models-and-api-updates
Customers using the unpinned gpt-3.5-turbo model alias will be automatically upgraded from gpt-3.5-turbo-0613 to gpt-3.5-turbo-0125 two weeks after this model launches.
```

it seems like we should set the default to `gpt-3.5-turbo` this way we are always on the latest version?

I think that since the gpt-3.5-turbo will always point to the "unpinned" gpt-3.5-turbo model. However, users may still want to explicitly specify by name the model they want to use, even if at some point in time it matches the model that is the alias for gpt-3.5-turbo model. I'll update the PR to add the new version instead of replace the older one.

I've made modifications to keep the existing version without removing it

merged in<PHONE_NUMBER>184a1a555cf1724fb65bb354e35152  Thanks!


WEP Networks don't display anything.

When I click "show password" on any of my stored WEP networks not happens, no popup, only the "settings has been granted an interactive shell" toast from SuperSU app.
Works fine on all my WPA networks.
Thank you for your time and awesome module.

There is a new version that you can download from the xposed repo, give it a try and let me know if you have any troubles


Use UTF-8 default and support numbers

hash() will always expect a string, so standardizing UTF-8 is a must. Also in this PR we support numbers to be hashed.

such change

such change

Big change @ItsGravix

new source who dis

Urmom

I have tested this code on my local environment and encountered the following attribute error when logging in.
2019-09-30 15:07:11,840 [INFO ]  basil is logging in!
2019-09-30 15:07:12,058 [INFO ]  basil has logged in successfully
2019-09-30 15:07:12,058 [ERROR]  <traceback object at 0x7f7b2c4ae748>
Traceback (most recent call last):
  File "/home/ben/Workspace/houdini-asyncio/houdini/spheniscidae.py", line 186, in run
    await self.__data_received(data)
  File "/home/ben/Workspace/houdini-asyncio/houdini/spheniscidae.py", line 169, in __data_received
    await self.__handle_xml_data(data)
  File "/home/ben/Workspace/houdini-asyncio/houdini/spheniscidae.py", line 129, in __handle_xml_data
    await listener(self, body_tag)
  File "/home/ben/Workspace/houdini-asyncio/houdini/handlers/__init__.py", line 105, in __call__
    return await self.callback(*handler_call_arguments)
  File "/home/ben/Workspace/houdini-asyncio/houdini/handlers/login/login.py", line 98, in handle_login
    confirmation_hash = Crypto.hash(os.urandom(24))
  File "/home/ben/Workspace/houdini-asyncio/houdini/crypto.py", line 21, in hash
    return hashlib.md5(undigested.encode('utf-8')).hexdigest()
AttributeError: 'bytes' object has no attribute 'encode'

I think this is because of this line in the login handler. Which passes the result of os.urandom() (a bytes-like object) into the Crypto.hash method.
We only ever need to call encode when Crypto.hash() has been passed a string. So to add support for integers being passed.
@staticmethod
def hash(undigested):
    if type(undigested) == str:
        undigested = undigested.encode('utf-8')
    elif type(undigested) == int:
        undigested = str(undigested).encode('utf-8')
    return hashlib.md5(undigested).hexdigest()

I am happy for you to amend your pull request and i'll merge.
Although, I am not sure what benefit this method being able to hash integers has? It seems like it would only be useful in the case that perhaps a plugin or handler needs to pass an int at some point, I feel like it would be more efficient to manually convert the int to a string each time since we're performing an additional check even when no integers are being passed (which is most of the time).
Like this:
Crypto.hash(str(integer_to_hash))


Page 10765 " "Posted Sales Invoice - Update"

We need a new event in Page 10765 " "Posted Sales Invoice - Update".
The change will be in the function "RecordChanged":
LOCAL RecordChanged() RecordIsChanged : Boolean
{
EXIT(
("Special Scheme Code" <> xSalesInvoiceHeader."Special Scheme Code") OR
("Invoice Type" <> xSalesInvoiceHeader."Invoice Type") OR
("ID Type" <> xSalesInvoiceHeader."ID Type") OR
("Succeeded Company Name" <> xSalesInvoiceHeader."Succeeded Company Name") OR
("Succeeded VAT Registration No." <> xSalesInvoiceHeader."Succeeded VAT Registration No."));
}
RecordIsChanged :=
("Special Scheme Code" <> xSalesInvoiceHeader."Special Scheme Code") OR
("Invoice Type" <> xSalesInvoiceHeader."Invoice Type") OR
("ID Type" <> xSalesInvoiceHeader."ID Type") OR
("Succeeded Company Name" <> xSalesInvoiceHeader."Succeeded Company Name") OR
("Succeeded VAT Registration No." <> xSalesInvoiceHeader."Succeeded VAT Registration No.");
OnAfterRecordChanged(Rec,xSalesInvoiceHeader,RecordIsChanged);
EXIT(RecordIsChanged);
The new event will be:
LOCAL [IntegrationEvent] OnAfterRecordChanged(VAR SalesInvoiceHeader : Record "Sales Invoice Header";xSalesInvoiceHeader : Record "Sales Invoice Header";VAR RecordIsChanged : Boolean)
We need the same change in the pages 10766 and 10765.
Thank you.
Sonia Roca.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


feat: Slim down playground container images

This PR
Reduces the size of the playground container images from 1.2G to 200m.

Making this a feature so we can release a new version.

nice.


3232 Allow charts to be removed in TA3 operators

Description
Added a button to tera-simulate-chart.vue which allows it to be removed from the list when clicked.

Resolves #3232

Looks great, thanks!


ag --filename pattern singlefile doesn't print singlefile

man page says:
       --[no]filename
              Print file names. Enabled by default, except when searching a
              single file.

Observed behaviour:
$ echo pattern > singlefile
$ ag --filename pattern singlefile
1:pattern

Expected output:
singlefile
1:pattern

A workaround is to include a placeholder filename as an argument on the command line.
Unfortunately, ag errors out when passed /dev/null.
But if using bash we can use the "fish operator", <(), to create an anonymous empty file:
echo pattern > singlefile
ag --filename pattern singlefile <() | cat
singlefile:1:pattern

A named pipe could be used if ag is wrapped programmatically.

@talwrii Are you sure that isn't because you're sending ag's output to a pipe instead of to the terminal?  I'm observing that ag ignores some output settings depending on whether its output goes to a pty or a pipe.

So this would be an easy fix I'd think, but I'm trying to wrap my head around the philosophy of this approach....
If we expressly set the flag, it sets the option to DEFAULT
src/options.c
525                 } else if (strcmp(longopts[opt_index].name, "filename") == 0) {
526                     opts.print_path = PATH_PRINT_DEFAULT;
527                     opts.print_line_numbers = TRUE;
528                     break;

Which later the program overrides if there is only one file
src/search.c
568             /* Not a directory. Probably a file. */
569             if (depth == 0 && opts.paths_len == 1) {
570                 /* If we're only searching one file, don't print the filename header at the top. */
571                 if (opts.print_path == PATH_PRINT_DEFAULT || opts.print_path == PATH_PRINT_DEFAULT_EACH_LINE) {
572                     opts.print_path = PATH_PRINT_NOTHING;
573                 }

Changing the forced setting to something like PATH_PRINT_ALWAYS seems like it would be an obvious fix, but what use cases expect it to work this way?
If nothing else, the current behavior breaks this documented use case when used with ack.vim:
let g:ackprg = 'ag --nogroup --nocolor --column'

Adding my 2 cents that I would like this.
I'm trying to use ag and fzf combined to create a fuzzy finder tool that searches for text within a single file in my IDE. When searching through directories it works fine, but using it when limiting the search to a single file means I don't get file hyperlinks in my output.
agf is my alias and it echoes the output command. You'll see I'm piping through fzf to perform the search.
~/Code/marketplace (main)$ agf /Users/kyle/.bashrc --filename
ag --filename . /Users/kyle/.bashrc <() | fzf --multi --height=70% --layout=reverse-list --border=rounded --info=inline --prompt='$> ' --pointer='→' --marker='♡' --header='CTRL-c or ESC to quit' --color='dark' --delimiter=':' --nth='3..'
1:# ~/.bashrc: executed by bash(1) for non-login shells.
~/Code/marketplace (main)$ agf /Users/kyle/ --filename
ag --filename . /Users/kyle/ <() | fzf --multi --height=70% --layout=reverse-list --border=rounded --info=inline --prompt='$> ' --pointer='→' --marker='♡' --header='CTRL-c or ESC to quit' --color='dark' --delimiter=':' --nth='3..'
/Users/kyle/last_update_spike.md:1:

I just stumbled across this. It was surprising to me that --filename was a no-op when I happened to be searching a single file. I wanted the filename because I have some other tools that can jump me to the specified line in a file when it's formatted with the filename. It certainly seems like an explicit request from the user shouldn't be overridden by a default behavior. (The default makes sense as a default but it shouldn't be an immovable object.) So +1 on changing it to mean PATH_PRINT_ALWAYS


Use new ExecutionStatus: [ECR-4222]

Overview
Migrate the light client to use the extended ExecutionStatus,
currently available from ejb-common module.
The ExecutionStatus, as previously, is exposed as a protobuf
class as a simpler approach compared to a separate
user-facing class (which would also require all the documentation
already present in the message).

See: https://jira.bf.local/browse/ECR-4222
Definition of Done

[x] There are no TODOs left in the code
[x] Change is covered by automated tests
[x] The coding guidelines are followed
[x] Public API has Javadoc
[x] Method preconditions are checked and documented in the Javadoc of the method
[x] Changelog is updated if needed (in case of notable or breaking changes)
[x] The continuous integration build passes

Coverage decreased (-0.1%) to 85.057% when pulling 405c323c88c3f9a44947c6b0b9653944494d590e on up-common into 2ee756cbd09a70db591d7362fdeeffde6476f29e on master.


Update Theme API Doc.

VS Code Version: 1.66.0
OS Version: Windows 10

Steps to Reproduce:

https://code.visualstudio.com/api/references/theme-color

Update the Theme API of new properties which are added in March 2022 (version 1.66):-
Example - comments.resolved.border, comments.unresolved.border etc.

The names of the colors need to be improved first. See https://github.com/microsoft/vscode/issues/146813


Remove collections usage from demos

Should we also update the "Last updated" field for both demos?

Yes, sorry. Updated! 👍


Fixed clone on NdLayout to propagate cols properly

PR title explains the change. My only worry is why does the id need to be copied across, doesn't super handle that?

I want to figure out whether the propagation of id is really needed before merging.

Note, this PR addresses #1738.

I want to figure out whether the propagation of id is really needed before merging.

It definitely is Layout.clone does the same thing. A clone of an Element should resets any custom options while a Layout should not. I'm happy to merge if you think it's ready.

A clone of an Element should resets any custom options while a Layout should not.

Ok. That makes sense, in which case this is ready to merge.


password not working

when i opened vnm for the first time i made a password, and when i set the sexual level from safe to explicit and i went back into vnm i wasn't asked for a password. btw i'm using version 1.0.8

where can i download the fixed version?. sorry I don't really understand about github. thanks


Stress Test: JSON logs

Allows to save logs to a .jsonl file and plot relevant information from it

Adds output flag for writing logs to a file
Adds python script that plots the information from the output file
Adds Makefile commands for running the stress test
Adds documentation of the stress test in the README

I ran the test in the benchmarking server and got the following information:

Checklist

[ ] Linked to Github Issue
[x] This change requires new documentation.

[x] Documentation has been added/updated.

Codecov Report
Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 90.92%. Comparing base (cde5664) to head (b7afb22).
Report is 1 commits behind head on stress-binary.

Files
Patch %
Lines

src/bin/cairo-native-stress.rs
0.00%
25 Missing :warning:

Additional details and impacted files
@@                Coverage Diff                @@
##           stress-binary     #686      +/-   ##
=================================================
- Coverage          90.97%   90.92%   -0.05%
=================================================
  Files                117      117
  Lines              33407    33424      +17
=================================================
  Hits               30391    30391
- Misses              3016     3033      +17

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Beautiful plots! 🎉


Last fixes to README files

Codecov Report

Merging #332 (df5bd8d) into main (b0cd297) will increase coverage by 0.94%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   90.22%   91.16%   +0.94%
==========================================
  Files          33       17      -16
  Lines        5226     3340    -1886
==========================================
- Hits         4715     3045    -1670
+ Misses        511      295     -216

Flag
Coverage Δ

unittests
91.16% <ø> (+0.94%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

qoqo/src/measurements/cheated_measurement.rs

qoqo/src/operations/two_qubit_gate_operations.rs

qoqo/src/operations/pragma_operations.rs

qoqo/src/operations/multi_qubit_gate_operations.rs

qoqo/src/quantum_program.rs

...c/measurements/measurement_auxiliary_data_input.rs

qoqo/src/circuit.rs

qoqo/src/operations/define_operations.rs

qoqo/src/operations/mod.rs

...oqo/src/operations/single_qubit_gate_operations.rs

... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


train_dataset. download

I couldn't find the dataset of './local/owt/openwebtext_train.jsonl'  Can you provide relevant instructions or download address

Uploaded the data preparation script at https://github.com/lhao499/blockwise-parallel-transformer/blob/main/bpt/tools/prepare_owt.py


\ backslash in string property

I have a string property in an object that has backslashes () in the property and this seems to cause problems.
At the server the posted object appears as null.
If the backslashes are removed the posted object is removed.
Is there anything I should be doing to resolve this problem?
I am using Delphi XE6, VS2013 Community

OK, I switched to using SuperObject as it appears there is a long time delphi bug with backslashes not being parsed correctly, so uploading now works fine.
But now I have an issue with the updates coming down, I get a marshalling error and am not sure what to do now to get this working? any ideas?

the server is a WebApi and ASP.NET 5.0 rest site

Here is the json coming down to the delphi client.
'{"Project":null,"ProjectMember":null,"ProjectMemberStatus":null,"ProjectMemberName":null,"ProjectMemberPermissions":null,"ProjectMemberActive":null,"Subproject":null,"ListGroup":null,"List":null,"ThiredPartyLink":null,"Time":null,"TimeBunch":null,"TimeBunchPost":null,"Inbox":null,"Task":null,"TaskSubject":null,"TaskProjectID":null,"TaskSubProjectID":null,"TaskParentID":null,"TaskPriority":null,"TaskStatus":null,"TaskArchive":null,"TaskShowAllMembers":null,"TaskCreateDate":null,"TaskStartDate":null,"TaskDueDate":null,"TaskCompletedDate":null,"TaskBudget":null,"TaskBudgetType":null,"TaskBudgetLock":null,"TaskOwnerID":null,"TaskMember":null,"TaskMemberBudget":null,"TaskMemberStartDate":null,"TaskList":null,"Comment":null,"Attachment":[{"datamemo":"This note won''t get through.... or will it?\r\n\r\nc:\testing\paths\with\backslashes\and\more\","datatype":1,"attachmentid":"{3FF9130A-834B-409D-AF97-BDEBD6CFA519}","md5":"","objectid":"{3A0C5B72-8A4E-48C2-8898-C45945462287}","objecttype":1,"projectmemberid":"","size":0,"modifieddate":2415017.95833333}],"Tag":null,"TaskTag":null,"UnitOfMeasure":null,"PackagingType":null,"Reminder":null,"Filter":null,"Sort":null,"Delete":null,"NavItem":null,"Id":0,"Description":"","SessionID":""}'

The backslashes must be escaped.
 c:\\testing\\paths\\with\\backslashes\\and\\more\\"

Yeah I spotted that this morning, this what is being received from the server, so I will troubleshoot this next


Rental's should track their creator

User_id is now for customer, we should still be tracking who created the rental.
user_id should be renamed to renter_id
creator_id will be the other id which is the user that created that rental (which should just be @current_user)

User no longer has many rentals because of the relationship between User and Rental.  The rentals table has two foreign keys referring to the users table:

renter_id for the user which the item will be used by
creator_id for the user which created the rental

Often these will be the same user but the distinction is still important.


Update homebank.json

Url change
http://homebank.free.fr has been redirected to https://www.gethomebank.org

[x] I have read the Contributing Guide.

Close pull request


Re added russian language

This adds back some strings that have been removed in previous commits, can you pull in the latest from the develop branch?

This adds back some strings that have been removed in previous commits, can you pull in the latest from the develop branch?

ok

Thank you so much!

I will test this locally to make sure it's working correctly.

@rovecode Thank you!


CKEditor 4.x

It does not work with CKEditor 4.x. Are you planning to provide support for CKEditor 4.x in near future for this plugin?

I created an Angular 1.5 component that is compatible with CKEditor 4.6 if you wanna check it out here

It works perfectly fine with CKEditor 4.x
I am using it with CKEditor 4.8 right now