fix: do not move terminated service to desired state on kernel shutdown

Description of changes:

Fixes a race condition between component error and kernel shutdown
Adds integ test

Why is this change necessary:
If component error and kernel shutdown happen at the same time (e.g. SIGKILL is sent to both component process and nucleus process), there is a chance that component restarts during kernel shutdown.
Specifically, if the component has a hard depender, it waits for the depender to close first during kernel shutdown and allows other state transitions.
After this change, while it still waits for the depender to close, it does not restart.
How was this change tested:

[ ] Updated or added new unit tests.
[x] Updated or added new integration tests.
[ ] Updated or added new end-to-end tests.
[ ] If my code makes a remote network call, it was tested with a proxy.

Any additional information or context required to review the change:
Documentation Checklist:

[ ] Updated the README if applicable.

Compatibility Checklist:

[x] I confirm that the change is backwards compatible.
[ ] Any modification or deletion of public interfaces does not impact other plugin components.
[ ] For external library version updates, I have reviewed its change logs and Nucleus does not consume
any deprecated method or type.

Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

As Michael and I discussed offline, we will adopt a different approach that addresses this issue.


Delete element from collection during upload

Whats the best practise to delete files of a CollectionFS that are still uploading?
Szenario:
I want to have filevalidation (size,type etc.) if a user picks a file. The validation is set with filters inside my collection. Now i pass this file to the collection with an insert, because i havent found a method that gives me the possibilty to make a simple isValidCheck() without uploading.
Now when a user decides to change the image. I had to delete the older image out of CollectionFS and if the image is still uploading there are some ugly error messages in console. The client still tries to upload while he cant because the file was already deleted.
Is there a method to tell the fileObj that i want to stop upload before deleting the image?
Iam using dev-branch.
Whats best practise?

hi @bitomule did u find a solution delete during the upload ?

I don't remember. I was using a fork that allowed multiple server setups and cancel worked better. I'm not doing a lot of meteor now but I won't use CollectionFS again. I'll try to do something smaller using packages for different parts.


Add ability to register custom load balancers

New Feature
Add ability to register custom load balancers.
Motivation for New Feature
We are using the Consul provider. We would like to add a custom load balancer that decides which service to route to, based on our custom metrics that are known in Consul.
E.g. we would like to give preference to services that have no "critical" or "warn" health checks. Or give preference to service instances that have a certain tag. Stuff like that...
This functionality is currently not possible with the built-in load balancers (CookieStickySessions, NoLoadBalancer, RoundRobin or LeastConnection). So I would like to be able to add load balancers, and specify them during DI composition.
This would require reworking the LoadBalancerFactory class, because only the built-in load balancers can be created there (switch statement).
(Possibly related to #870?)
Specifications

Version: 13.5.2
Platform: Windows-x64
Target framework: netcoreapp2.2

fixed by #1155

Fixed by https://github.com/ThreeMammals/Ocelot/pull/1155


tenant paramater is not present in error response

Documentation says that tenant will be included in parameters in error response.
This does not seem to be true, at least not in cases:

when on "Permissions requested" page user clicked "Cancel"

?error=access_denied
&error_description=AADSTS65004%3a+User+declined+to+consent+to+access+the+app.%0d%0aTrace+ID%3a+7c839d05-4806-48f2-ba40-bf4128382500%0d%0aCorrelation+ID%3a+b94f5bce-b15e-48c6-a713-fc07c5c41a77%0d%0aTimestamp%3a+2023-08-28+11%3a25%3a19Z
&error_uri=https%3a%2f%2flogin.microsoftonline.com%2ferror%3fcode%3d65004
&admin_consent=True
&state=d66b10a0-8f6f-4631-9336-2d2201c984e1#

when user from other directory tries to access  "Permissions requested"

?error=access_denied
&error_description=AADSTS50020%3a+User+account+%27%7bEmailHidden%7d%27+from+identity+provider+%27https%3a%2f%2fsts.windows.net%<id>%2f%27+does+not+exist+in+tenant+%27ExampleDotCom%27+and+cannot+access+the+application+%<app>+in+that+tenant.+The+account+needs+to+be+added+as+an+external+user+in+the+tenant+first.+Sign+out+and+sign+in+again+with+a+different+Azure+Active+Directory+user+account.%0d%0aTrace+ID%3a+3834489b-3100-4983-aa26-829196f82700%0d%0aCorrelation+ID%3a+49c5d71e-1688-4bc7-b84c-9948c58a3eaa%0d%0aTimestamp%3a+2023-08-28+11%3a39%3a39Z
&error_uri=https%3a%2f%2flogin.microsoftonline.com%2ferror%3fcode%3d50020
&admin_consent=True
&state=1534ee0d-c7e2-4595-840d-ada2514f61b4#

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a5837e27-7af3-12ad-3fd7-10995017581e
Version Independent ID: 6ccb62ba-b31c-0cd5-c169-06c3ca899a4b
Content: Microsoft identity platform admin consent protocols - Microsoft Entra
Content Source: articles/active-directory/develop/v2-admin-consent.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

One more case: on "Permissions requested" page log in as user without grant access permissions and click "return without consent" (something like that, I'm not sure what's the actual text here :) ).
This time missing parameters are: tenant, error_description and error_uri; additionally there is one  undocumented parameter present: error_subcode.
?error=access_denied
&error_subcode=cancel
&state=ac080c73-8a0e-468f-80c9-fc963b623549

@rwike77
Could you please review add comments on this, update as appropriate.

@dsymiec-deviniti
Thank you for bringing this to our attention.
I've delegated this to content author @rwike77, who will review it and offer their insightful opinions.

@dsymiec-deviniti thanks for pointing this out.  I confirmed with engineering, the tenant parameter is not returned in the error response.  The documentation is in error.  I'm also looking into the three other parameters you mentioned.  I'll update the content when I've got more info.

#please-close


Delete prompts should accept yes/no

I really hate the delete prompts and find the --yes parameter a little awkward; but if we must have it, then the command line prompt should accept yes/no as responses, which is standard *nix behavior.

cleaning up github issues, we've made changes here (but not literal yes support); if this is a scenario you think we're not understanding, let us know.

I'm pretty sure he meant that the prompt should accept the literals "yes" and "no" since the parameter is called --yes.

@leol7, can you take care of this one with the goal of ensure we know how to release knack?

@yugangw-msft Can you tell me which scenarios we have delete prompts?

when you delete anything such as "az group delete -n mygp"


Fixed error thrown when element missing name

I have the following code
<form id="myform">
    <input type="text" name="name" placeholder="Full Name" required />
    <label class="checkbox">
        <input type="checkbox" required />
        I agree not to send any unsolicited email, or send email to addresses purchased, rented or otherwise obtained from a third party. I understand that port 25 is blocked by default and I have to request that it be opened. I also understand that if I violate the rules set by Server Blaze that port 25 will be closed.
    </label>
    <button type="submit">Done</button>
</form>

and in JavaScript I have this
$("#myform").validate()

The code always errors out and continues with submit regardless of if a name is entered into the name field or not.  I have tracked the error down to this line:
https://github.com/jzaefferer/jquery-validation/blob/master/jquery.validate.js#L729
With this PR, I fixed the error in the code by skipping the name check if the name doesn't exit.

Looking at this again, the patch doesn't make much sense.

@jzaefferer why doesn't the patch make sense? If the name is empty then you cannot do a findByName.

I may have misread then. Will check it out again, later.

Applying this fix as is would also mean that ignore rules wont apply for those elements.
It feels like the name attribute should be required instead.

Well, this plugin requires it anyway, for anything with a rule attached. In this case, the non-named input has a required attribute, so the plugin requires a name attribute.
I've started labelling related issues: https://github.com/jzaefferer/jquery-validation/labels/name-attribute

Well, this plugin requires it anyway, for anything with a rule attached. In this case, the non-named input has a required attribute, so the plugin requires a name attribute.

Right but the PR is targeted to change that for checkboxes/radios. I think we agree that name will stay  mandatory and therefore this PR is invalid.

@staabm @jzaefferer if the name is required, which I am not arguing with that decision.  Things should fail more gracefully then they do right now.  Because if somebody is using jquery-validation ontop of a straight HTML5 implementation with no custom configuration.  The code just bombs out and the developer is left wondering why his code isn't working.
If the name attribute is truly required, which is not HTML5 purist friendly, then some kind of error should be thrown into the console to alert the developer as to why his code is failing.

If the name attribute is truly required, which is not HTML5 purist friendly, then some kind of error should be thrown into the console to alert the developer as to why his code is failing.

For now it is, though there is at least one ticket to investigate changing that. Could you update your PR to throw a decent error message, as you describe? That would help. Thanks!


chore(demo): update migration to v6 for non-angular apps

Preview environments are getting posted here, as soon as they are ready!


FCDO explore "export dataset", "add to parser queue" and "parse activity in dataset" functionality

Code behind "add to parser queue" is outdated and could maybe be updated to work with the latest dataset parsing task.
Export dataset has no script behind it, and the functionality is unclear (asked rumy).
Parsing a specific activity in dataset is not defined in the current parsing and would take a lot of effort.
My suggestion going forward is to drop these old uses and just use the parsing options as provided, unless the export does turn out to be important.


Add Support for Additional Response Content-Types

Currently, Azure Core expects that the Content-Type of a response is either json or xml. There are additional Content-Types that need to be supported such as plain text, images, and additional forms of json or xml that aren't currently supported.

Azure Search uses text/plain

AppConfig could use application/vnd.microsoft.appconfig.kv.v1+json if that helps

If that could helps, some notes on what Python is doing:

When you call the pipeline, you pass a parameter to say if you want the pipeline to "pre-deserialize" the body (stream=True/False):

If you pass stream=True, pipeline doesn't touch the body and give you back an open socket on the HTTP connection (e.g. download blob). Content-Type is ignored.
If you do pass stream=False, this means load the body in memory, and use the Content-Type to do a first pass:

If regexp match JSON, create the JSON object
Else if XML, create a XML tree
Else if text/*, decode the body and return the string
Else fail for content-type impossible to handle

mgmt-plane got response as application/json 99.9%.
automation has a text/powershell.
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/automation/resource-manager/Microsoft.Automation/stable/2018-06-30/runbook.json#L54-L91
I think at present modelerfour will parse this as binary, so we are still safe.

This issue may be broken out into smaller children issues per Content-Type needing support.


Fix #561, Add branch coverage reporting

Describe the contribution
Fix #561, Adds branch coverage and removes no-longer-needed report file manipulation to exclude unit test code from coverage report
Testing performed
Steps taken to test the contribution:

Standard build/test/lcov (same as enhanced CI)
Confirmed branch coverage reported (~91%)

Expected behavior changes
No changes to operational behavior
System(s) tested on

Hardware: cFS Dev Server 3
OS: Ubuntu 18.04
Versions: Master bundle w/ this change

Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

CCB Approved - 20200318


fix: drop custom slack notifications from CI (unused)

Follows up incident #165 and allows SLACK_* CI configs to be removed. Notifications have been suspended since August team/channel shuffles in any case.

👍  Looks good to me once the other issues are fixed.


docs: add section about "Middleware Destination" feature

closes https://github.com/denoland/fresh/issues/1341
The issue seems to be the exact case introduced by the "middleware destination" concept, but there isn't any documentation for it!

Thanks again for this PR. Really appreciate it and sorry if I come off as nitpicky at times.


Refactor threadpools hit by SyncSliceTest

I'm curious as to why you had slowdowns. Any ideas?
On Jan 30, 2024 10:38 AM, bgprudhomme @.***> wrote:

This email originates from a sender outside of CUNY. Verify the sender before replying or clicking on links and attachments. *

Closed #6https://github.com/ponder-lab/solr/pull/6.
—
Reply to this email directly, view it on GitHubhttps://github.com/ponder-lab/solr/pull/6#event-11643721598, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAPUGPYW2EZ7WASNP6SQB23YREHV3AVCNFSM6AAAAABCRJ77AGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGY2DGNZSGE2TSOA.
You are receiving this because you authored the thread.Message ID: @.***>


Reading and parsing Visual Studio Solution file and project files

I am looking for a way to read and parse Visual Studio Solution file and project files in C#.
Is this possible in with MSBUILD project. Which part of the API is relevant for this? Is there a sample to get me started with this? I am primarily interested in finding all files that are referenced via solution/project files.

In the past I've modified Project files (csproj) using the Project Class (https://msdn.microsoft.com/en-us/library/microsoft.build.buildengine.project(v=vs.110).aspx) although the latest on MSDN seems to mark this API as obsolete.
The API wasn't well documented when I looked at it in the past but is pretty straight forward. The example you're looking for can be extracted from this example https://msdn.microsoft.com/en-us/library/microsoft.build.buildengine.project.propertygroups(v=vs.110).aspx


Recover Amazon shipping from marketplace

As @saleweaver suggested the default will now be AmazonShipping_US, and it can be auto-calculated from the MarketPlace.

Thanks @saleweaver.


Guaranteed ownership transforming terminators

This PR teaches the ownership-verifier how to handle guaranteed arguments with values provided by a switch_enum or a checked_cast_br.
The specific properties that the verifier checks is that the argument's ownership kind is the same as the ownership of the terminators argument. For the owned case, we verify the users of the argument separately from the users of the operand. But in the case of guaranteed parameters, we add the end_borrow_argument instruction of the guaranteed argument to the "must live" set of the terminator's operand. This means that the guaranteed value must live as long as the argument does implying that all uses of the guaranteed argument must be within that liveness region.

@swift-ci smoke test and merge

Messed up. This is going to fail. 1 sec.

Interesting. Turns out if you forget to end a borrow, the error is that you are leaking. I think I can improve that error.

@swift-ci smoke test and merge

@swift-ci smoke test and merge


Align not work .

in writeln() {
write();
feed();
}
You write function do
ESC a 1  T e s t ESC a 0 ESC d 1
in line work last align command .
Correct must be
ESC a 1  T e s t LF ESC a 0

Thanks for feedback, fixed!


fix the bugs  in the PyG library

Hi,I hope this message finds you well. I recently came across your repository associated with the paper you published. However, while running the code, I noticed your alert Caution: Use pyg-lib for sampling acceleration here. May need to fix the bugs in the PyG library (neighbor_sampler.py). How should I modify neighbor_sampler.py in the PyG library?

Thank you for your interest in our work! 🤗
I’ve reviewed the source code for the torch_geometric.sampler.NeighborSampler class, and I believe I’ve identified a bug that affects the functionality of torch_geometric.loader.NeighborLoader, which is crucial for neighbor sampling in LTGNN. To fix this bug, please refer to the source code of torch_geometric.sampler.NeighborSampler, and make a slight modification at around line 299 in the _sample method.
Here’s the original line of code:
row, col, node, edge, batch, _ = out + (None, )

And here’s the revised version:
# *** Caution: changed the PyG code here!
row, col, node, edge, batch, _ = out #+ (None, )

This change should address the issue and allow the LTGNN code to work correctly. There is no need to re-compile or re-install any Python libraries after applying this revision. You can simply execute the LTGNN code, and everything will be fine.
However, please be cautious. Depending on the version of the PyG library you’re working with, you may not always need this exact revision. I’ve only tested this code with PyG versions torch_geometric==2.2.0, 2.3.1 and pyg-lib version pyg-lib==0.2.0+pt113cu117. If you find the proposed modification is incorrect in your own context, I kindly recommend either aligning your PyG version with mine or promptly reporting any encountered errors during code execution. Besides, If you find that the LTGNN code operates correctly without implementing this revision, feel free to proceed and just allow the code to execute.


Add shell management

Add shell management group based on Zephyr Docs.

@petrovichkr Hi, thanks so much for this contribution!
I have been slow to add docs here and now it is slowing you down 😢
To lint:
. ./envr.ps1
lint

Or run without the envr alias:
black --check . && isort --check-only . && flake8 . && mypy .

Done fixing lint issues. This is my first contribution to the Python project, so sorry too :)

Great! I will create a ticket to improve the _do_test function. Now that I'm looking at my own _do_test code again it looks too "magic" to me and I want it to be easier for contributors. I'd love your advice!

My test writing skills are about zero, so I'm a bad advisor :) I created these tests based on your test_os_management.

In order to test these with a device, I'll bump smpclient and smpmgr to implement the shell management group that you've added. Very useful (and dangerous), especially over BLE!

Overall these tools will be a good replacement for the existing newtmgr/mcumgr. BLE transport is much more stable and doesn't require root rights. I'm going to use the smpclient package to develop automation utilities for testing Zephyr based hardware over BLE.
By the way, I've already implemented the shell group in smpclient. I can do PR to smpclient after the release of this project.

Overall these tools will be a good replacement for the existing newtmgr/mcumgr.

That's the goal, but there's a lot of work and testing to be done!  While there are still only a few people using these tools, breaking changes may be frequent to arrive at a consensus API.  You can trust the semantic versioning and release notes to indicate these breaking changes.


enable DANE/TLSA

is there a possibility of enabling DANE on the domain, so dns responses are secured (especially  for the dnslink entry)?
PS: and also enable the DNSSEC check in ipfs.

Thanks for bringing this up!
I haven't looked into DANE, but it looks like a good idea. About DNSSEC I'm a bit wary, mainly because of what tptacek has to say about it [1][2].

[1] http://sockpuppet.org/blog/2015/01/15/against-dnssec/
[2] http://sockpuppet.org/stuff/dnssec-qa.html

What’s the alternative to DNSSEC?
Do nothing. The DNS does not urgently need to be secured.
All effective security on the Internet assumes that DNS lookups are unsafe.

what's about ipfs dnslinks and cjdns IPs? we need something to secure these.

Governments control the most important TLDs.

he's right but :D we need to trust someone, implement web of trust (lol look at pgp) or use a blockchain (lol look at namecoin) or something.
electrum could be the solution (in a few years). Also i don't think blockchain tech is implementable at client level (btc needs 50gb of hdd space) yet (?).

I think it is not long until ethereum releases light weight clients and then you will be able to recreate namecoin but in ethereum world.


THEME option missing? Storybook docs say theme is an option, is it gone?

addDecorator(   withOptions({     name: 'Storybook',     theme: themes.dark   }) )
Error says theme does not exist as an option

Hey @alienfacepalm , what versions of storybook and the options addon are you using? Can you also try with addParameters instead of addDecorator as in https://github.com/storybooks/storybook/blob/next/examples/official-storybook/config.js#L49?

addParameters compiles with no issue, doesn't appear have any effect from my config, info section works, none of the options are applied, but that's another issue.
  options: {
    name: 'NowSecure UI 1.0',
    hierarchySeparator: /\/|\./,
    hierarchyRootSeparator: '|',
    theme: dark
  },
  info: {
    inline: true,
    styles: {
      header: {
        h1: {
          color: '#002e48'
        }
      }
    }
  }
})


Custom remarkable plugins?

I'll need to add some custom plugins to remarkable (to embed videos etc.).
Since there's no way to teach linkify that I'll have to pull your source into my application and do it myself.
Would you be interested in adding the possibility in ember-remarkable to add custom plugins?

Yeah, absolutely. I've been pondering adding plugin support for a little while, but I wasn't sure if it was functionality that people were looking for. However, it looks like you've encountered a use case/need already!
So its definitely something to put onto the radar. I'm thinking that remarkable plugins can be added as an array in the App options, something like:
var pluginOne = require('plugin-one');
var pluginTwo = require('plugin-two');

var app = EmberApp({
  remarkablePlugins: [pluginOne(), pluginTwo()]
});

Yeah having them as App options would suit my use-case really good.
People who need different plugins for several places would be out of the picture but that shouldn't be to common either.
One more thing:
Writing plugins for Remarkable isn't straight forward. Therefore I use https://github.com/rlidwka/remarkable-regexp. How about integrating that with your plugin-support?

Yeah, that's the one concern I had, was when to enable or disable plugins. However I'm not sure how to integrate that. I will ponder it a bit.
I will put the remarkable-regexp on the radar for supporting, too.

Ohhhhh, I think I got it. We can pass in all plugins like before, in the App options, but as an array of objects:
var app = EmberApp({
  remarkablePlugins: [{
    name: 'foo',
    plugin: pluginOne()
  }, {
    name: 'bar',
    plugin: pluginTwo()
  }]
});

Then, if you want to change the plugins you can extend the component and ignore/specify plugins:
components/md-bar-text
import MarkdownComponent from 'ember-remarkable/components/md-text';

export default MarkdownComponent.extend({
  usePlugins: ['bar']
});

That way, the above component will only use the bar plugin. How does that sound?

That sounds like a great and future-proof solution to me. I'll switch back to using ember-remarkable the minute you implement it <3

: )

@johnotander any progress on this? I just came across the need to add the markdown-toc to be used on ember-fastboot.com. tried to spike it out, but then saw this issue and a path forward.
let me know how i can help

Hey @davidpett. I haven't made any progress on this. After specing out how the API might work I was pulled on to other work and this was left by the wayside. I'm going to be pretty bogged down for the next week, but I can schedule some time after that to start taking a whack.
Also, if you have time this next week and want to contribute, I'd be happy to add you as a collaborator/owner and let you get started (I definitely want to see this feature) -- even if it is just a WIP PR. Let me know what your thoughts are, and thanks!

I've added a PR with plugin support that worked for me, let me know if it works for you or needs any changes.

Closed with #29, thanks @maciek134!


Updated Effect schema with enabled flag

This PR addresses #1187 - Add enabled Flag to Effects
If there is an associated issue, link it in the form:
Fixes #1187
Summarize your change.

Added enabled flag to Effect schema
Updated Effect schema to version 2
Updated core version to 0.18.0

Reference associated tests.

Updated unit tests in test_effect.py to account for enabled flag
added empty_effect.json and updated test_json_backend.py accordingly

I need some guidance on how to correctly update CORE_VERSION_MAP.cpp, as running make version-map-update results in the below error. Manually setting the version to 0.18.0 results in the failed tests, e.g. here. Would appreciate any pointers or guidance!
(.venv) fschleich@Florians-MacBook-Pro OpenTimelineIO % make version-map-update
updating the CORE_VERSION_MAP...
Traceback (most recent call last):
  File "/Users/fschleich/Developer/github/fschleich/OpenTimelineIO/src/py-opentimelineio/opentimelineio/console/autogen_version_map.py", line 116, in <module>
    main()
  File "/Users/fschleich/Developer/github/fschleich/OpenTimelineIO/src/py-opentimelineio/opentimelineio/console/autogen_version_map.py", line 86, in main
    args = _parsed_args()
           ^^^^^^^^^^^^^^
  File "/Users/fschleich/Developer/github/fschleich/OpenTimelineIO/src/py-opentimelineio/opentimelineio/console/autogen_version_map.py", line 38, in _parsed_args
    default=otio.__version__,
            ^^^^^^^^^^^^^^^^
AttributeError: module 'opentimelineio' has no attribute '__version__'
make: *** [version-map-update] Error 1

A while back when we added enabled to Clip, we were able to do so without increasing the schema version because the new property has a clear fallback value (true). I think you can do the same here for Effect. Here's the PR for Clip for reference: https://github.com/AcademySoftwareFoundation/OpenTimelineIO/pull/1175

Codecov Report
Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.62%. Comparing base (c0e97b0) to head (b266f1a).
Report is 23 commits behind head on main.

Files with missing lines
Patch %
Lines

src/opentimelineio/effect.h
50.00%
1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1798      +/-   ##
==========================================
- Coverage   84.11%   81.62%   -2.50%
==========================================
  Files         198      176      -22
  Lines       22241    12350    -9891
  Branches     4687     3027    -1660
==========================================
- Hits        18709    10081    -8628
+ Misses       2610     1726     -884
+ Partials      922      543     -379

Flag
Coverage Δ

py-unittests
81.62% <94.73%> (-2.50%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

src/opentimelineio/effect.cpp
93.33% <100.00%> (+1.66%)
:arrow_up:

...entimelineio-bindings/otio_serializableObjects.cpp
93.69% <100.00%> (-0.17%)
:arrow_down:

.../py-opentimelineio/opentimelineio/schema/effect.py
100.00% <ø> (ø)

tests/test_effect.py
96.42% <100.00%> (+0.35%)
:arrow_up:

tests/test_json_backend.py
93.65% <100.00%> (+0.20%)
:arrow_up:

src/opentimelineio/effect.h
80.00% <50.00%> (-20.00%)
:arrow_down:

... and 65 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5184c36...b266f1a. Read the comment docs.


Raise Option Texture Snippet by 1 Pixel

I discovered that I can't exactly center the option "arrow" that's here. I retextured it as you can see. It's horrible assymetrical at the moment so could you raise it by 1 pixel joshie? :)

Is this still applicable, I didn't check.


Emojis Are Black

When I install this plugin and start typing a emoji name, the part where the preview should been shown is black and I can't see them. Do I need some specific font here? I use NerdFont...

https://github.com/ezpuzz/deoplete-emoji/tree/submodule-emojis fixed in my branch here

@ezpuzz sounds cool! :+1:
Will give it a try soon. :)


Create AccumuloClient, deprecate Connector

Created AccumuloClient from Connector
Created Connector.from() as a bridge between the two
Moved new builder API to AccumuloClient
Replaced almost all uses of Connector with AccumuloClient

Splitting these commits up so this PR is easier to review... un momento, por favor

@keith-turner and @ctubbsii Checkout b79c429.

With the creation of new builder methods to make it easier to use, it made sense to do it now and put them in a new class.

Ok, so if its not done now then it can't be done later without also deferring the new builder methods?

create an opportunity to have something better than Connector.

The changes are really nice, it will make newly written Accumulo code look a lot nicer.  I hope we keep Connector around for a long time though to support existing code since it has been the only way to write Accumulo code since 2011.

This change broke the maven-plugin IT.

Busbey-MBA:accumulo busbey$ git log --oneline -n 1
4043c72ab (HEAD) Merge branch 'accumulo-client' Closes #636
Busbey-MBA:accumulo busbey$ git clean -xdf 2>/dev/null 1>&2 && mvn -DskipTests --batch-mode -q -pl maven-plugin -am install && mvn --batch-mode -q -pl maven-plugin verify
     [java] The following errors occurred during analysis:
     [java]   Unable to locate method java.util.TreeSet.stream()Ljava/util/stream/Stream;
     [java] Analysis errors: 1
     [java] The following errors occurred during analysis:
     [java]   Unable to locate method java.util.HashSet.removeIf(Ljava/util/function/Predicate;)Z
     [java]   Unable to locate method java.util.HashSet.stream()Ljava/util/stream/Stream;
     [java] Analysis errors: 2
     [java] The following errors occurred during analysis:
     [java]   Unable to locate method org.apache.hadoop.conf.Configuration.spliterator()Ljava/util/Spliterator;
     [java] Analysis errors: 1
09:51:08,469 [ERROR] The following builds failed:
09:51:08,471 [ERROR] *  plugin-test/pom.xml
09:51:08,473 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.1.0:run (integration-test) on project accumulo-maven-plugin: 1 build failed. See console output above for details. -> [Help 1]
09:51:08,474 [ERROR]
09:51:08,474 [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
09:51:08,474 [ERROR] Re-run Maven using the -X switch to enable full debug logging.
09:51:08,474 [ERROR]
09:51:08,474 [ERROR] For more information about the errors and possible solutions, please read the following articles:
09:51:08,474 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

details from maven-plugin/target/it/plugin-test/build.log :

09:51:06,628 [INFO] -------------------------------------------------------------
09:51:06,628 [ERROR] COMPILATION ERROR :
09:51:06,628 [INFO] -------------------------------------------------------------
09:51:06,628 [ERROR] /Users/busbey/tmp_projects/accumulo/maven-plugin/target/it/plugin-test/src/test/java/org/apache/accumulo/plugin/it/PluginIT.java:[55,26] cannot find symbol
  symbol:   method builder()
  location: class org.apache.accumulo.core.client.Connector
09:51:06,628 [INFO] 1 error
09:51:06,628 [INFO] -------------------------------------------------------------
09:51:06,629 [INFO] ------------------------------------------------------------------------
09:51:06,629 [INFO] BUILD FAILURE
09:51:06,629 [INFO] ------------------------------------------------------------------------
09:51:06,629 [INFO] Total time: 15.634 s
09:51:06,629 [INFO] Finished at: 2018-09-21T09:51:06-05:00
09:51:06,909 [INFO] Final Memory: 51M/541M
09:51:06,909 [INFO] ------------------------------------------------------------------------

I'll push an addendum shortly, once my local test passes.


Let the teacher populate the round with data

We're not actually dealing with creating rounds or sessions at the moment—just setting data (ie, the list of flowers, the time) on a pre-existing round.
Closes #49.
Closes #36.

(The regressions in the layout should be all fixed now! :slightly_smiling_face:)

Roger that, thanks! I'll need to update this branch to incorporate PR #76—I'll do that Monday morning—and then should I maybe ask for one person to re-review the changes?

Okay, I know that Audrey's review is a bit stale, but given that it looks like nothing changed when we merged in the Firebase emulator, and given that we don't want to drag this review process out for longer than we have to, I think it makes sense to merge in this branch now. (Sorry if that's the wrong decision!)


default setting for style of version strings in setup.cfg is not compatible with PyPi

Hi all,
I recently used versioneer for publishing my library on PyPi. However, the default setting for the version string style is   style = pep440, which in my case produced version strings which were not accepted by PyPi yielding the following error:
ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
         '0.0.3+0.ga7bcbda.dirty' is an invalid value for Version. Error: Can't
         use PEP 440 local versions.

In the end changing the style parameter to style = pep440-pre solved the issue. I am now wondering if this was a special case for me or not, hence have you ever experienced this before?
If so I would suggest changing the default setting to a format which is compatible with PyPi, since this is a major database for distribution of Python libraries.
Cheers,
Aaron

'.dirty' indicates that you have uncommitted changes.  Committing the recent changes and try it again.

pep440-pre is needed to push non-tag versions to PyPI, or if you want to use test.pypi.org to verify your packaging workflows. The base assumption of versioneer though is that you do care about the hash on non-release packages. I don't think the default is likely to change, although I've hung up my maintainer's hat here.


fixing issue #7011

fixing https://github.com/arangodb/arangodb/issues/7011

@pluma mergeable then?


jamf_policy_delete feature added

syntax follows -n --name convention

@zackn9ne I've merged this in to a new deleters branch, please send any new PRs related to deleter scripts to this branch for now.


fix repository links (poet ➜ poetry)

Seems there still were some poet repository links lingering.
This causes https://pypi.org/project/poetry/ to link poet repository and its statistics instead of poetry.

Thanks!


The vehicle never starts in simulating the local planning by using OpenPlanner

Hi, Autoware!
In order to run OpenPlanner, I've been following https://www.youtube.com/watch?v=FKM8v79X3_s (I'd appreciate @hatem-darweesh!).
As I understand, this footage introduces two different ways of the local planning simulation using

ff_waypoint_follower [05:01~09:03]
pure_pursuit [09:04~10:45]

Am I right?
I had no problem in performing the simulation with 1); however, not with 2).
As shown below, the vehicle (model) never hit the road even after launching pure_pursuit.

At the moment 2) starts (followed by 1)),

way_planner is checked on
(blue-colored) global path is active (as displayed in RViz)
vel_pose_connect is checked on
(dp_planner is checked off)

With the above conditions, I've just followed what @hatem-darweesh did in order of

wf_simulator
twist_filter
self-localize using 2D Pose Estimate in RViz
dp_planner
(finally,) pure_pursuit

But the vehicle (model) doesn't go.
What can be the culprit of this problem?
Thanks for reading, @hatem-darweesh :)

1- Setup -> TF , Vehicle Model
2- Map -> Point Cloud map , Vector Map, TF
3- Computing:
a) vel_pose_connect -> check "Simulation Mode"
b) twist_filter and tf_simulator, then select start pose from RVIZ using "2D Pose Estimate"
c) way_planner (after set map path), select goal pose from RVIZ using "2D Nav Goal"
d) dp_planner (after set map path)
e) pure_pursuit -> select Waypoint
Car should move.
Regards,

Thanks for your reply, @hatem-darweesh!
By following the sequence you gave, the vehicle model is now moving!

Great,
Can you share with us what was wrong with your steps, so I can consider in the tutorial.
Regards,

I think I was wrong in setting start and goal positions on RViz with way_planner. As demonstrated, this step should be done after wf_simulator and before dp_planner.
I'd appreciate your support, @hatem-darweesh!

A lot of these issues is solved with the new OpenPlanner 1.5 if you have spare time give it a try feature/OpenPlanner and tutorial video is on the OpenPlanner youtube channel.


Create personas

*At least N+1 for an N-sized team.

My research began where I searched up reasons as to why people don’t like taking out the trash. Theses include:

It smells
The liquid In the trash makes me more unlikely to take it out.

The Strategist, rated 5 of the very best kitchen trash cans. The features they based it on include:

Material
Capacity
Compartments
Closures
Price

The experts to conduct the research for this list include interior designers, organizers, architects, etc.
https://medium.com/ignation/your-guide-to-successful-persona-building-f3dae3f4762d

Persona 1:

Persona 2:
Katherine
The busy Mom
About Katherine:

Age: 34
Has kids; 7-11 year olds
Works a 9 am - 5 pm job everyday
Preps meal for the week on Sunday with her husband
Neat freak who needs the house to be mostly organized and cleaned majority of the time
Get frustrated when no one cleans up after themselves and doesn't help out

Key goals and needs:

Needs kids and husband to do their share of chores
Stay on top of work
Come home on time
Wants kids to excel in school and know when to help out at home without asking
Wants a stress-free dynamics at home with family.

Persona 3:
Daniel
Food Lover, Room Mate
About Daniel:

23, bachelor, lives in a shared apartment
Works in an s technology firm.
Apartment has the bare minimum.
Doesn't like children, responsibilities, and cooking.
Likes to earn money, spend it, and party.

Key goals and needs:

Tolerable environment to complete basic needs.
Wants to own his own company by 35.
Watching his friends succeed motivates him.


V3 external font support

Version 3.0
Bug fixes
Added external font support
Readme improvements
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Checked<EMAIL_ADDRESS>for vulnerabilities

New Commits added to address issues. Please Review.

Fixed comments and tested again to confirm it still works.


levels.txt v.0.4.2

Check out some levels I've made!

Those are some really nice levels, I'm glad you made them


Question about inference of the video data.

Hello, thanks for the your great work!!
I have some question about your Model inference code.
I want to inference of the video data, but it support only image data.
However, demo of the huggingface support video data as input.
I randomly pick the 8 frames of the video and save to the image_list.

And change the prompts goes like this.

Is this process is same as the huggingface's demo code??
If not, could you tell me the detailed of the process of video in huggingface?
Thank you.

Hi, the model on huggingface space is the advanced version of mPLUG-Owl which natively support video with temporal related module as input without treating video as multiple frames. The video is tokenized into 65 tokens as image. We will release it very soon.

Ok, thanks for the answer!


Grow the size of the window with the browser window

This will need some resizing in many places, but it is doable.

the box containing the data is very small with big blank space either side. I know I can zoom in, but I would like the window to be adjusted to be my screen size; that is especially relevant when I turn on the homoelogue view; I have seen this in IE, Firefox and Chrome
UAUY: If this is easy, then OK.. if this is tricky and can mess other things then not a priority.


[FIX] #76

Not fixed

screenshots ?

screenshots ?

Hold on until verified from your forked repo.


How to create single app.js/app.css files

Hello, Im wondering how can I modify the webpack configuration in order to create a build that generates a single app.js and app.css
Ive been trying to use the LimitChunkCountPlugin, adding a vue.config.js file like explained here:
https://itnext.io/vuidget-how-to-create-an-embeddable-vue-js-widget-with-vue-custom-element-674bdcb96b97
however Im not sure if the vue.config.js file is taken into account when using npm.
Does anybody know a webpack configuration for dayspan vuetify that makes a build in one single app.js file?

Sorry Im new to webpack.
Just figured out this has nothing to do with the dayspan vuetify.


[BUG] asian providers returns 'NoneType' error

Describe the bug
Expected behavior
Nil
Screenshots
Nil
Error
The name of the provider [actvid]: viewasian
None
[!] Please Enter the name of the Movie: age of legends
https://viewasian.co/movie/search/age-of-legends
[1] Age of Legends TV

[q] Exit!

[s] Search Again!

[d] Download!

[p] Switch Provider!

[sd] Download Whole Show!

Enter your choice: 1
https://viewasian.co/drama/age-of-legends
https://viewasian.co/watch/age-of-legends/watching.html
Please input the episode number(Total: 47): 27
https://viewasian.co/watch/age-of-legends/watching.html?ep=27
[!] An error has occurred |  'NoneType' object is not subscriptable

The name of the provider [actvid]: watchasian
None
[!] Please Enter the name of the Movie: age of legends
https://watchasian.la/search?type=movies&keyword=age+of+legends
[1] Age of Legends TV

[q] Exit!

[s] Search Again!

[d] Download!

[p] Switch Provider!

[sd] Download Whole Show!

Enter your choice: 1
https://watchasian.la/drama-detail/age-of-legends
Please input the episode number(Total: 47): 27
https://watchasian.la/age-of-legends-episode-27.html
[!] An error has occurred |  'NoneType' object is not subscriptable

Desktop (please complete the following information):

OS: Windows
Version: 10

Additional context
Nil
Possible cause
Nil
Possible solution
Nil
Version
0.6.6

Could you please check if that episode has an DoodStream or an Streamtape link before opening a Issue, because that episode doesn't have any.


Archive the repo

See https://github.com/cdfoundation/sig-interoperability/pull/110#issuecomment-2460060805 for details on background of this


feat: add --monday-first arg

This one is a beautiful feature. My only comment is that it looks a bit weird to display "Mon", "Wed", and "Fri" when Monday is the first day (the last two rows do not display their corresponding days, see the figure). If the flag is enabled, maybe it should display "Tue", "Thu", and "Sat"... but I think that I don't really have a strong opinion on this. Any ideas?
Also, I just noticed that if the flag is enabled, the key variable in the last loop does need a + 1 to adjust the alignment of the displayed days. This fix might break if it's Sunday, because the script might create a new column when is not really needed (hard to test btw...)

(This one was patched using the + 1 fixup)


[Snyk] Fix for 3 vulnerabilities

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json

package-lock.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

768/1000  Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 7.5
Uncontrolled resource consumption SNYK-JS-BRACES-6838727
Yes
Proof of Concept

858/1000  Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 9.3
Authentication Bypass SNYK-JS-HAWK-6969142
Yes
Proof of Concept

661/1000  Why? Recently disclosed, Has a fix available, CVSS 7.5
Inefficient Regular Expression Complexity SNYK-JS-MICROMATCH-6838728
Yes
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: fsevents
    The new version differs by 87 commits.

f650d82 Fix Exiting Beahviour (#346)
6a3bb59 remove static things from c-code (#342)
662406c Update tests to include LTS & current (#344)
c58ab88 Closes #336.
864d79b Release 2.1.3.
59366e7 Add nodegyp devdep to fix yarn warnings
2cef39e Merge pull request #312 from royru/patch-1
688a14e Update README.md
f2b4ba8 Merge pull request #311 from RDIL/license
f2e554c Bump license years
9cdfb44 Release 2.1.2.
7c9f854 Adjust types.
6722e56 Always return a promise from the stopper function (#296)
5ca31f3 Run CI for PRs.
4ef1026 Merge pull request #295 from SimenB/ts
e34236b feat: add typescript definition
e468f15 Merge pull request #292 from fitztrev/patch-1
ebea62b Update README.md
7ae710c Update README.md
39593b3 Test against Node v13
b0bb4d6 Release 2.1.1.
f95c1ac Fix random thread hanging due to incorrect pthread_cond_wait usage (#290)
d5cc566 Delete .npmignore
25f354d Use NPM files to discard .github dir.

See the full diff

Package name: gulp
    The new version differs by 45 commits.

5c4c547 chore: Release 5.0.0 (#2762)
bf72116 chore: Add index.mjs to files list
b00de68 feat: Provide an ESM export (#2760)
72668c6 chore!: Normalize repository, dropping node <10.13 support (#2758)
85896d4 chore(docs): Update stream handbook link (#2711)
818bd73 Docs: Remove gulp-sourcemaps because it is built-in (#2592)
598f971 Docs: Fix broken link in recipe (#2571)
9877de0 Docs: Guide CustomRegistries to maintain properties on tasks (fixes #2561) (#2565)
f91c388 Docs: Remove typo in custom registry docs (#2543)
df25250 Docs: Fix typo in task docs (#2524)
b6d6d7c Docs: fix recipe link (#2526)
c26ebcb Docs: Cleanup registry error message subtitles
d51c6eb Docs: Rename the automate releases recipe file
4c1bead Docs: Add subtitles for registry error messages (#2502)
6e56ed8 Docs: Update and refactor release workflow recipe (#2498)
131b702 Docs: Remove recipe for using a config file
c5ff7e0 Docs: Remove recipe for splitting tasks in files
147327c Docs: Remove recipe for specifying a CWD
1a653a9 Docs: Remove recipe for running shell commands
e1190ea Docs: Remove recipe for exporting tasks
c4305df Docs: Remove recipe for running tasks in series
486f927 Docs: Remove recipes for selecting changed files
b7b70b8 Docs: Fix some links
93564bd Docs: Add advanced section for creation of custom registries (#2479)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Note: This is a default PR template raised by Snyk. Find out more about how you can customise Snyk PRs in our documentation.
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Uncontrolled resource consumption
🦉 Authentication Bypass

👷 Deploy Preview for optimistic-mahavira-71b58e processing.

Name
Link

🔨 Latest commit
4c05b9505031a3ec620465a355bf2a95f34aee0e

🔍 Latest deploy log
https://app.netlify.com/sites/optimistic-mahavira-71b58e/deploys/664e3ce486f1d600080deac9


Binary Sensor Type value 0xFF not handled correctly

Discussed in https://github.com/zwave-js/node-zwave-js/discussions/6923

Originally posted by @spudwebb June 13, 2024
Checklist

[X] I have read and followed the above instructions

[X] I have checked the troubleshooting section and my problem is not described there.

[X] I have read the changelog and my problem was not mentioned there or the fix did not work.

Describe the issue
According to the ZWave specs for the Binary Sensor CC version 2, when receiving a binary sensor type value 0xFF in a binary sensor report we should look at the first supported sensor type to determine the actual sensor type of the report, instead ZWave JS just use the "Any" type and create an "Any" value instead of the actual type value.

Sensor Type (8 bits)
Sensor Type specifies what type of sensor this command originates from. Refer to Table 2.92. The
sensor type value 0xFF returns the first found supported sensor type in the bit mask (starting from
bit 0 in Bit Mask 1) by the Binary Sensor Supported Report.

See for example this Ecolink Motion sensor. During interview it correctly reports that the only binary sensor type supported is Motion, but then when queried for its value, it reports a sensor type=0xFF which is then translated by ZWaveJS as Any instead of Motion.
09:43:26.441 CNTRLR   [Node 084] Interviewing Binary Sensor...

09:43:26.441 CNTRLR » [Node 084] querying supported sensor types...

09:43:26.443 DRIVER » [Node 084] [REQ] [SendData]
                      │ transmit options: 0x25
                      │ callback id:      67
                      └─[BinarySensorCCSupportedGet]

09:43:26.599 CNTRLR   [Node 084] [+] [Binary Sensor] supportedSensorTypes: 1 [Endpoint 0] [internal]
                      2

09:43:26.599 DRIVER « [Node 084] [REQ] [ApplicationCommand]
                      └─[BinarySensorCCSupportedReport]
                          supported types: Motion

09:43:26.600 CNTRLR « [Node 084] received supported sensor types:
                      · Motion

09:43:26.600 CNTRLR » [Node 084] querying current value for Motion...

09:43:26.602 DRIVER » [Node 084] [REQ] [SendData]
                      │ transmit options: 0x25
                      │ callback id:      68
                      └─[BinarySensorCCGet]
                          type: Motion

09:43:26.809 CNTRLR   [Node 084] [Binary Sensor] Any: metadata updated                  [Endpoint 0]

2024-06-12 09:43:26.809 INFO Z-WAVE: [Node 084] Metadata updated: 48-0-Any

09:43:26.810 CNTRLR   [Node 084] [+] [Binary Sensor] Any: false                         [Endpoint 0]

2024-06-12 09:43:26.810 INFO Z-WAVE: [Node 084] Value added: 48-0-Any => false

09:43:26.810 DRIVER « [Node 084] [REQ] [ApplicationCommand]
                      └─[BinarySensorCCReport]
                          type:  Any
                          value: false

Sorry I don't have a full debug log as I don't own this device myself, the log is coming from another user.
Software versions
Driver (node-zwave-js): 12.9.1
Z-Wave JS UI: 9.13.3
Device information
Manufacturer: Ecolink
Model name: PIR Motion Sensor v2.5
Node ID: 84
Checklist

[x] I made sure to provide a driver log on level debug.

[X] The log includes a re-interview of the problematic device (if applicable).

[X] The log includes the problematic interaction with the device (if applicable).

[X] I provided the node ID of the problematic device (if applicable).

Upload Logfile
Node 084 Log.txt

The way I understand that part of the specs is that you can use 0xFF in the Get command and the device must respond with the sensor type set to the first sensor it supports.
So this is more of a workaround than an actual fix, but I suppose it makes sense to support this.


GEOPY-734: Bulk replace of copyright year 2023

GEOPY-734 - Bulk replace of copyright year 2023

@sebhmg can you merge this in yours?

see dedicated PR instead: https://github.com/MiraGeoscience/geoapps/pull/470


: no longer a word stop

Description of issue
https://stackoverflow.com/questions/73818442/vim-9-word-boundary-change-for-perl-files/73818721#73818721
excerpt copied here:
In vim 8, if you had the following string:
package Some::Package::Name;
and you placed your cursor on the S in Some::Package::Name and did a cw it would replace the text Some with whatever you typed.
In vim 9, cw now changes from S to the e in Name.
Could this  be due to a change in
/usr/share/vim/vim90/syntax/perl.vim
or vim9?
I received  a work around in the stackoverflow post that works, but also Andy Lester encouraged me to post the issue here so you could investigate.
Thanks for the great plugin.
If your bug is not related to highlighting or folding, please feel free
to delete the text below.
Screenshot of the issue:

Sample code:
package Some::Package::Name;

Link to vimrc
vimrc
Output of vim --version
VIM - Vi IMproved 9.0 (2022 Jun 28, compiled May 10 2022 08:40:37)
Included patches: 1-105
Modified by<EMAIL_ADDRESS>Compiled by<EMAIL_ADDRESS>Huge version without GUI.  Features included (+) or not (-):
+acl               +file_in_path      +mouse_urxvt       -tag_any_white
+arabic            +find_in_path      +mouse_xterm       -tcl
+autocmd           +float             +multi_byte        +termguicolors
+autochdir         +folding           +multi_lang        +terminal
-autoservername    -footer            -mzscheme          +terminfo
-balloon_eval      +fork()            +netbeans_intg     +termresponse
+balloon_eval_term +gettext           +num64             +textobjects
-browse            -hangul_input      +packages          +textprop
++builtin_terms    +iconv             +path_extra        +timers
+byte_offset       +insert_expand     -perl              +title
+channel           +ipv6              +persistent_undo   -toolbar
+cindent           +job               +popupwin          +user_commands
-clientserver      +jumplist          +postscript        +vartabs
-clipboard         +keymap            +printer           +vertsplit
+cmdline_compl     +lambda            +profile           +vim9script
+cmdline_hist      +langmap           -python            +viminfo
+cmdline_info      +libcall           +python3           +virtualedit
+comments          +linebreak         +quickfix          +visual
+conceal           +lispindent        +reltime           +visualextra
+cryptv            +listcmds          +rightleft         +vreplace
+cscope            +localmap          -ruby              +wildignore
+cursorbind        -lua               +scrollbind        +wildmenu
+cursorshape       +menu              +signs             +windows
+dialog_con        +mksession         +smartindent       +writebackup
+diff              +modify_fname      +sodium            -X11
+digraphs          +mouse             -sound             -xfontset
-dnd               -mouseshape        +spell             -xim
-ebcdic            +mouse_dec         +startuptime       -xpm
+emacs_tags        +mouse_gpm         +statusline        -xsmp
+eval              -mouse_jsbterm     -sun_workshop      -xterm_clipboard
+ex_extra          +mouse_netterm     +syntax            -xterm_save
+extra_search      +mouse_sgr         +tag_binary
-farsi             -mouse_sysmouse    -tag_old_static
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/usr/share/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -Wdate-time -g -O2 -ffile-prefix-map=/build/vim-dFzTGe/vim-9.0.0105=. -flto=auto -ffat-lto-objects -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -D_REENTRANT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc -Wl,-Bsymbolic-functions -flto=auto -ffat-lto-objects -flto=auto -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o vim -lm -ltinfo -lselinux -lsodium -lacl -lattr -lgpm -L/usr/lib/python3.10/config-3.10-x86_64-linux-gnu -lpython3.10 -lcrypt -ldl -lm -lm

So if I'm understanding correctly:

In vim 8, cw would delete Some from Some::Package::Name.
In vim 9, cw would delete all of Some::Package::Name
vim 9's behavior is the expected behavior and has been for 9 years.
You don't like the behavior, and got around it by using setlocal iskeyword-=: so that : would no longer be seen as part of a word.
I also don't like the behavior and have long had something similar in my .vimrc:
au FileType perl set iskeyword+=^:  " So we don't see :: separators as part of function names.

So to me the question is: What changed on your machine between vim 8 and vim 9? Did you have something in vim 8 that was removing the : from iskeyword, and it disappeared when you went to 9?

I could be confusing causes for sure.
So I had been developing on ubuntu systems since 16.04.  I move to 18.04 and a couple of years ago I upgraded VIM to 8 manually.  Recently, I created a 22.04 VM and have been moving my dev tools/processes over to it.  Fresh install of Ubuntu, installed VIM via jonathonf/vim PPA and finally moved over my .vimrc linked above (along with .vim dir with colors).
That said, I'm not sure why my early instances did not also exhibit the behavior I did not like, maybe a plugin was "fixing" that for me?  I did not move my pathogen stuff over, and have only added a few plugins using the vim plugin methods.
Thanks for your help.  I don't think that there is a "problem" per-se.  I just could not figure out how to correctly change to my preferred behavior.

maybe a plugin was "fixing" that for me?

That's my guess.
If it's not a problem, and you don't have any other questions on this, you can close the ticket.


Need onStartShouldSetPanResponderCapture to steal PanResponder from Childs

The missing onStartShouldSetPanResponderCapture prop makes it impossible to steal PanResponder on Move if Child has a Pressable:
https://stackoverflow.com/questions/75975994/react-native-zoomable-view-child-component-should-have-onpress-and-be-pannable
To fix this we need onStartShouldSetPanResponderCapture as an Prop.

This sounds like a good idea – please open a pull request with the changes and we'll review it. Thank you!

This is my first time contributing somewhere. Please give me some advice if there is something wrong with the pill request. ;)
https://github.com/openspacelabs/react-native-zoomable-view/pull/93

I'm having the exact same problem (Pressable inside zoomable view consumes pan event) and don't understand the solution outlined here. Could someone explain, please?

solved in #101


log/console_adapter: support 'console' gem v1.25

Which issue(s) this PR fixes:

Fixes #4487

What this PR does / why we need it:
Console::Terminal::Logger class path has changed in console gem v1.25:
https://github.com/socketry/console/compare/v1.24.0...v1.25.0#diff-6e7355da8b6a8f794e74e462aebbe4b23f7752dab2a29967d17707eabb71ce12
This causes LoadError for ConsoleAdapter.
It means that LoadError occurs for plugin_helper/http_server/server, and Fluentd replaces the helper by plugin_helper/http_server/compat/server.
It also causes the CI failures.
This PR fixes these problems.
Please see #4487 for details.
Note: There is another issue about console gem v1.25:

#4488

Docs Changes:
Not needed because this is a bug fix.
Release Note:
HttpServer helper: Fixed a problem that some Fluentd logs were not being output.

I forgot to consider Ruby versions before 3.1.
I will add it.

About the failures on Windows, I have made an issue:

#4493

It doesn't seem to have anything to do with this fix.

@ashie @kenhys Could you please see this?
We have another option to keep console v1.24.
I'd like to hear your opinion.

About the failures on Windows, I have made an issue:
* [CI: Windows: An error occurred while installing cool.io (1.8.0), and Bundler cannot continue. #4493](https://github.com/fluent/fluentd/issues/4493)

It doesn't seem to have anything to do with this fix.

Resolved.

Thanks!

We need to backport this to v1.16

We need to backport this to v1.16

Sorry, we should not.
On v1.16, we should stay using console v1.24, given the purpose of the stable branch.


Does futures_cpupool still exist? (in futures 0.3)

Does futures_cpupool still exist in this repo? Or is there anything that can replace it?

@DCjanus perhaps Juliex might fit your needs.
It has a spawn shorthand method that sets up a backing threadpool behind the scenes and just work.
And it has a Threadpool constructor that can come in handy when you need to setup thread-locals for your app.

Thanks! @yoshuawuyts

It seems that juliex does not cover all futures_cpupool usage.
For example, If I want to implement a async file IO library, and I don't want to use AIO in Linux, which means I have to put block task to separate thread pool and await this task in main executor.
futures_cpupool provided a good abstraction for this: "await a Future in other executor".

CpuPool has been renamed to ThreadPool and incorporated to futures::executor (see https://github.com/rust-lang-nursery/futures-rs/commit/8198563d7aa970fda052f9d09e2837da89d062dc).

@DCjanus , I think what you want is spawn_with_handle, then the code use cpupool :
let result_fut = cpu_pool.spawn(long_running_future);

can be replaced with ThreadPool or juliex:
let result_fut = thread_pool.spawn_with_handle(long_running_future).unwrap();

Is futures::executor::ThreadPool appropriate to run blocking work on though? The purpose of futures-cpupool was a place to run blocking synchronous work and get a handle that will resolve with the result. As far as I'm aware ThreadPool is intended as a very basic futures executor, which means it will likely be making tradeoffs targeted at running non-blacking asynchronous work.

@laizy Thanks for your help, spawn_with_handle is do helpful to me.

@Nemo157 My problem has been solved, but seems that you got more idea about this, I am not sure if I should close this issue.
If you think this issue could be done, please just close this issue; if you want to keep track this idea in this issue, maybe you want to keep this issue open.


Disable type hints in method override signatures

Hello,
I don't know if it's the right place to ask, if not please let me know where to go.
Actually I am working with Django and I am overriding a class method, then it show autocomplete which is very good, the point is that I am not working with type hints and the method gets autocompleted with the hints and classes that are not imported
When I type:

def save_mo...
trying to reach save_model

It autocompletes like this:
def save_model(self, request: Any, obj: _ModelT, form: Any, change: Any) -> None:
        return super().save_model(request, obj, form, change)

expected autocompletion:
def save_model(self, request, obj, form, change):
        return super().save_model(request, obj, form, change)

Is there a way to config this?
Thank you!

We currently don't have a configuration for this, no. We're including the types because we include stubs for Django, which includes the types for these parameters (so we carry them down).

Thank you for the answer. Would be great if we could configure it in the future.

Adding my own two cents that I'd also love this added. For my particular use case I'm using type comments in the PEP 484 style due to working on a python 2.7 project, I even have a Python 2.7 interpreter set in the VS Code workspace, and still the autocompletes bring in the type hints in the python 3.7 style, which isn't valid syntax.

Moving this issue to discussion as an enhancement request for comments and upvotes.


suggestion

If you want to be able to control your website's metrics and you have your portfolio hosted on vercel, you can add web analytics.
I've recently added:

You can also see the countries they access the most, browsers, and even the OS.

she is using beam analytics instead


Correction for raw affiliation Université Lyon 2, UMR 5600, Bron, France

Correction needed for raw affiliation Université Lyon 2, UMR 5600, Bron, France
raw_affiliation_name: Université Lyon 2, UMR 5600, Bron, France
new_rors: 029brtt94;0256r1e04
previous_rors: 029brtt94
works_examples: W1966692644
contact: d230d2567efb4cda4074c1f4004c833b:c8ee034f2b012087ba6c4ef74878 @ ens-lyon.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-21. The new affiliations should be visible within the next 7 days.


Geographic Collections page errors out

Aziria reports that the Sources Geographic Collections page returns an error page:

app_js.5b5cdaf4.js:162449 TypeError: Cannot read property 'map' of undefined
    at CountryCollectionListContainer (app_js.5b5cdaf4.js:128680)
    at oh (app_js.5b5cdaf4.js:147993)
    at Rj (app_js.5b5cdaf4.js:148101)
    at Qj (app_js.5b5cdaf4.js:148086)
    at Kj (app_js.5b5cdaf4.js:148086)
    at yj (app_js.5b5cdaf4.js:148079)
    at app_js.5b5cdaf4.js:147963
    at exports.unstable_runWithPriority (app_js.5b5cdaf4.js:148170)
    at cg (app_js.5b5cdaf4.js:147962)
    at fg (app_js.5b5cdaf4.js:147963)
    at gg (app_js.5b5cdaf4.js:147962)
    at Mj (app_js.5b5cdaf4.js:148080)
    at Object.notify (app_js.5b5cdaf4.js:1910)
    at Subscription.notifyNestedSubs (app_js.5b5cdaf4.js:1983)
    at Subscription.handleChangeWrapper (app_js.5b5cdaf4.js:1988)
    at dispatch (app_js.5b5cdaf4.js:5203)
    at app_js.5b5cdaf4.js:128777
    at app_js.5b5cdaf4.js:476
    at app_js.5b5cdaf4.js:70925
    at app_js.5b5cdaf4.js:155967
    at app_js.5b5cdaf4.js:33870
    at dispatch (app_js.5b5cdaf4.js:5607)
    at app_js.5b5cdaf4.js:33893

the store appears to be pulling an empty value here: state.sources.collections.geo.byCountry investigating...


Bring back ahead/behind counts while git syncing

VSCode Version: 1.12.0
OS Version: Win 10

Steps to Reproduce:

Create a commit and click on the sync icon in the bottom left
Observe how the ahead/behind counts disappear immediately before the operation is done

This change was done in fab6f8871ad234ffe0123265f313458590535119 (@joaomoreno) and it really annoyed me when it was released and still does. It just seems wrong to me and I found it much nicer before. With 1.12.0 the sync icon spins again, but now removing the ahead/behind counts immediately feels weird as the spinning sync operation "works" on pushing/pulling those two things and only when it's done spinning the counts should disappear as well. I hereby vote for reverting that change, especially since now the icon is spinning again. Thanks! :)

PR? 👍


Fix be_routable description -- Renames BeRoutableMatcher to BeRoutable

Problem
Previously, using be_routable in a one-liner...
RSpec.describe 'a not-routable route', type: :routing do
  let(:sad_route) { '/this/route/makes/me/sad' }
  specify { expect(get: sad_route).not_to be_routable }
end

...will output the following:
a not-routable route
  should not be routable matcher

BaseMatcher#description turns BeRoutableMatcher into "be routable matcher".
Solution
The solution implemented here is to rename BeRoutableMatcher to BeRoutable in order to rely on BaseMatcher#description to correctly return the following description:
a not-routable route
  should not be routable

This looks like the precedence in other matchers like BeValid.
Alternate Solution
Alternatively, #description could be overridden in BeRoutableMatcher:
def description
  "be routable"
end

I'd be happy to change PR if that's preferred :smile_cat:

I'm not sure what @cupakromer will think but personally I'd rather see:

Alternate Solution
Alternatively, #description could be overridden in BeRoutableMatcher:

def description
  "be routable"
end

I agree with @JonRowe. Let's define description.

Thanks @JonRowe @cupakromer. I'm closing this PR and redefining #description in https://github.com/rspec/rspec-rails/pull/1310


Convert CollabWindowTracker to NoopHeuristic, lift Accept out of it

This change refactors the CollabWindowTracker with a couple objectives:

Start lifting the responsibility of accepting QuorumProposals out of the Container (this is what originally got me looking at this).  Ultimately this responsibility should live with QuorumProposals as part of its own contract (basically the same as what PactMap already does).  This change just lifts it up to the Container though, since moving it further starts to cross API boundaries.
Convert the object to be an event emitter rather than taking a submit callback.  This better encapsulates the class (simpler interface to use), and removes its ability to directly call superpowers like the ability to submit messages.

Not in this change, but this would also make it easier in the future to support replacing the object on service config changes.  Just need to unregister the old listener on the old object and set up a new listener on the new object; no need to fear that the old object will somehow still be able to submit a rogue noop.

Renames to NoopHeuristic to better reflect what it does and avoid conflation with the CollabWindow from merge-tree.  Also renames member methods to make its contract more apparent.

Hi folks!  If you have a chance to review this I'd appreciate it!

Hi folks!  Just a reminder that this still needs review.


Add deprecation warnings to legacy builder images

Adds deprecation warnings to the heroku/builder-classic:22 and heroku/buildpacks:20 CNB builder images, to raise awareness that they are no longer supported/recommended.
The warnings have been added using a warnings buildpack, similar to the approach used for the Heroku-18 EOL in:
https://github.com/heroku/cnb-builder-images/pull/336
For now these are just warnings, however, in the future will be changed to an error (skippable via env var, like in the PR linked above).
Since these are warnings, the buildpack has been added to the end of each buildpack order group, such that the message is at the end of the overall build log, and so hopefully more visible to end users. (Once the warning is turned into an error, the buildpack should be moved to the start of the order groups, so the build fails early for improved UX.)
A separate mostly-copy-pasted buildpack was used for each builder, since there is no other easy way to customise the message shown for each (and I wanted to include the name of the deprecated builder in the warning message, so users know what image name to grep for).
These buildpacks were written in bash (rather than in Rust, using libcnb.rs), since:

the buildpack functionality we need is extremely simple
the buildpack is temporary (it will be deleted when we stop updating these builders in the future), so we don't need/want long term published images on CNB registry or to have to set up a Rust compilation/packaging step in this repo.

The buildpacks give zero lint warnings when checked with shellcheck locally.
GUS-W-14194729.
GUS-W-14194736.

Example warning for heroku/builder-classic:22:
https://github.com/heroku/cnb-builder-images/actions/runs/6669195890/job/18126518745?pr=429#step:6:248
And for heroku/buildpacks:20:
https://github.com/heroku/cnb-builder-images/actions/runs/6669195890/job/18126512300?pr=429#step:6:241
And locally in a console that supports colour:

I am not the biggest fan of the echo_stderr name, since it doesn't only redirect to stderr, but also colorize the text.
About the HEREDOCs...
Instead of this workaround:
read -r -d '' EOL_MESSAGE <<-'EOF' || true
…
EOF

echo_stderr "${EOL_MESSAGE}"

You can simplify it to this:
echo_stderr "$(cat <<'EOF'
…
EOF
)"

Alternatively, in the helper function, you can call cat without arguments instead of echoing $1, like so:
function echo_stderr() {
  # send all of our output to stderr
  exec 1>&2
  # if arguments are given, redirect them to stdin
  # this allows the funtion to be invoked with a string argument, or with stdin, e.g. via <<-EOF
  (( $# )) && exec <<< "$@"
  local ansi_red="\033[1;31m"
  local ansi_reset="\033[0m"
  echo -ne "\n${ansi_red}"
  cat
  echo -e "${ansi_reset}\n"
}

The invocation then becomes much cleaner:
echo_stderr <<'EOF'
…
EOF

Due to the (( $# )) && exec <<< "$@" line, you can still pass simple string arguments.

You can simplify it to this:

@dzuelke The reason for the current implementation, is that once it's turned into an "error if env var not set" the message needs to be used twice, so needs to be assigned to a variable.
This can be seen in the PR linked in the PR description (and why I mentioned in the description that this would be turned into an error in the future):
https://github.com/heroku/cnb-builder-images/pull/336

I am not the biggest fan of the echo_stderr name

I've renamed it to display_error.

I've also since found:
https://gitlab.com/gitlab-org/cluster-integration/auto-build-image/-/issues/73
https://gitlab.com/gitlab-org/cluster-integration/auto-build-image/-/merge_requests/159

I plan on upgrading these deprecation warnings to errors (that are skippable with an env var) in the next couple of weeks.


Evaluation failures on unstable: theodore, cclib

Caused by pyqt4 dependency.
error: pyqt4 has been removed, because it depended on the long EOL qt4

I can handle removing this as part of bumping the package version, since this part of the code is basically dead.


Orphan pages checker GHA

Signed-off-by: tushar5526<EMAIL_ADDRESS>Description
GHA that outputs the orphan pages in GHA logs on same interval as broken link checker.
Fixes #89
Type of change
Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Tested on my forked repo and locally
...
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings
[x] I have tagged the reviewers in a comment below incase my pull request is ready for a review
[x] I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

Hey @joewxboy. It was great fun to solve this one.
Can you test this GHA if it is working fine? It's working fine on my fork.

This gets the job done, but I can also make it such that this action runs whenever we add any specific label to a PR or something like that if there is a need for it.


Corking

You need to implement corking.
Basically wrap the ServerResponse in a callback inside cork.
    res.cork(() => {
      res.writeStatus(...)
      res.writeHeader(...)
      res.write(...);
    })

Its easy to do and will improve performance significantly. If you are having troubles, I can open a PR.
From the lib:
Corking a response is a performance improvement in both CPU and network, as you ready the IO system for writing multiple chunks at once. By default, you're corked in the immediately executing top portion of the route handler. In all other cases, such as when returning from await, or when being called back from an async database request or anything that isn't directly executing in the route handler, you'll want to cork before calling writeStatus, writeHeader or just write. Corking takes a callback in which you execute the writeHeader, writeStatus and such calls, in one atomic IO operation. This is important, not only for TCP but definitely for TLS where each write would otherwise result in one TLS block being sent off, each with one send syscall.

Hi @romanzy-1612, a PR would be very welcome for this!

any movement on this? it's basically blocking us from upgrading to node 18 or colyseus 0.15

Hi @hunkydoryrepair, I've never managed to reproduce this, can you share how to reproduce it? 🙏

Hi Endel, I just created a PR for this. Also, bumped the version of "uWebSockets.js" to v20 (from v19) to support Node 18.

Yeah, the issue appears when uWebSockets v20 is used. v19 doesn't work with Node 18 (just crashes), and our CICD platform is removing support for Node 16 in 2 months.

Thank you @Always-Pixels 🙏 https://github.com/colyseus/uWebSockets-express/pull/25 has been merged and published!


[dataset] Switchboard

Dataset name: Switchboard
Description:
Switchboard contains transcripts of phone conversations between two people. Participants are given a topic to discuss and have a chance to introduce themselves before recording their discussion. The conversation metadata includes information about the conversation topic (both a short and long description), date, length (in minutes), and the ID of the caller ('from_caller') and receiver ('to_caller'). The user data includes the user's sex, education level, birth year, and dialect area. Utterance information includes the text spoken, the ID of the first utterance in the conversation, the timestamp, and the ID of the user the utterance is replying to. The metadata includes DAMSL tags, parts-of-speech (POS), and tree structure corresponding with the utterance. The DAMSL tags describe the statement type, for example 'question', 'non-verbal', 'hedge', etc.
Note that the original switchboard dataset did not split utterances by user, but rather by the associated tags. In the corpus we created, we combined consecutive utterances by the same user into one utterance. This is why the metadata tags are in the form of dictionaries, such that the keys are the utterance text segments and the values are the tags.
Details:
See more detail in our README.txt
In our created corpus, the statistics are:
440 users, 122646 utterances, and 1155 conversations.
Licensing information:
The SWDA Switchboard work is licensed under a Creative Commons Attribution-NonCommercial-ShareAlike 3.0 Unported License (see source here
Associated paper:
https://web.stanford.edu/~jurafsky/ws97/manual.august1.html
Contact:
Corpus translated into ConvoKit format by Nathan Mislang, Noam Eshed, and Sungjun Cho.
Corpus link:
corpus.zip
For our ConvoKit conversion and examples of its usage, take a look at our forked repo here

Hi,
Thanks for your work with converting SwDA, and sorry for the delayed response! Here are some comments:
Description:

I wonder if it would be better to follow the original authors' convention of calling the corpus Switchboard Dialog Act Corpus (which I believe is where the SwDA shorthand comes from?), instead of Switchboard Telephone Conversation Corpus (which seems to refer to an earlier version that comes without dialog acts tags).

To be consistent with ConvoKit documentations, I think it might be helpful to include the original paper more directly/explicitly (i.e., providing citations & links, see other dataset docs for format). The corpus page could be included as a further detail, either as part of the description, or as part of Additional note (explained later).

User-level information:

it's probably worth mentioning that user names are taken from the numerical id in SwDA.

dialect_area: while the rest of the categories are self-explanatory, it it perhaps helpful to include some short note on how "MIXED" or "UNK" are decided

Utterance-level information:

reply_to should be None if the utterance is not a reply.

I wonder if a dictionary of text segment to corresponding tag/tree is the best structure to store such data. It seems redundant to have essentially three copies of texts (once in text fields, twice as dictionary keys), and it seems less intuitive to use? (e.g., consider if I want the sequence of dialog acts in the utterance, or count dialog-act bigrams -- I think the general comment is to structure it in a way that best fits the needs of an end-user, which you might have better ideas than I do.) Additionally, could you clarify how are the POS and parses obtained? (i.e., by humans or by some toolkits? -- I guess if it's all machine-labeled, they may seem less essential to include?)

Conversation-level/Corpus-level information:

I think what's currently stored as corpus-level metadata should probably all go to conversation-level meta: since it's currently stored as a dictionary keyed by conversation ids, it seems more appropriate to leave the values to be in the meta fields for the conversation indexed by the key?

Additional note

I think we would hope for a one-piece documentation that covers all necessary information. Currently the bulk of info is in the README file, but there are pieces that's only in the comment (e.g., Licensing information). I would suggest adding those to a new "Additional note" section (which most of ConvoKit datasets have) in the README .

Similarly, other "additional information", e.g., the special note under utterance that explains how the operationalization of an utterance differ with the original SwDA release, can be included in the same section .

This is optional, but it may also be helpful to leave some pointers for how speech is transcribed, so that users can have a feel of what various symbols (e.g., "{}", "+") in this context means.

Other
As a stylistic note, you may want to consider using more descriptive text for the links your are including, and insert comma at appropriate positions in numbers (e.g., 221616 -> 221,616), for readability.
Let me know if these comments make sense, and thanks again for your work!

As a follow up, after discussing with Cristian, we think it may be cleaner to not include the pos and parse tree information for now, given that the dialog acts are the perhaps more essential annotation for ConvoKit users (unless there are serious issues you think that may arise). For dialog acts tags, we wonder if a list of (text, tag) tuples may be a better structure to store such data (so there is a more explicit signal for the ordering of text segments).
Let me know if you have any questions, and thanks again for working on this!

Thanks for your suggestions! We are working on applying these changes now.
You mentioned that reply_to should be None if the utterance is not a reply. Am I correct in understanding that you are referring to the very first utterance in each conversation? Since we are combining consecutive utterances by the same user, there should not be utterances in the middle of a conversation which are not directly replying to the previous speaker. Please let me know if I have understood correctly!

Yes, I am referring to the very first utterance (i.e., root) in each conversation. I think currently its reply_to is the id of itself, but by ConvoKit convention, it should be None (as exemplified in other datasets, e.g., [here] (https://zissou.infosci.cornell.edu/convokit/documentation/chromium.html]).

No problem, we'll make that update! In terms of the (text, tag) list format for the dialog tags, would you like that to be in the metadata, separate from the utterance text? Or would you prefer that we replace the utterance text with a list of the (text, tag) tuples?

Thanks! With the (text, tag) list, I meant to have it to replace the dictionary of text segment to tag that's currently being stored in the metadata, utterance text should remain unchanged.

We've made the updates you mentioned. Please let me know if there is anything we are missing or have misunderstood!
Our updated README is here: README.txt
Our updated corpus is here: corpus.zip

Some quick things:

Could you make the first reference of the paper in proper citation format (i.e., how you put in Related publications, starting with "Distributed together with")
Could you add in license information (which you had in your first comment) in the "Additional Note" section?
Under "Usage and Stats", could you convert it to the style as the Chromium documentation linked above (i.e., stats comes directly from corpus.print_summary_stats())

Hello,
We've updated the README to reflect the changes in the metadata and also other information (reference, license information, etc.). Feel free to take a look at the forked repo here, and let us know in case anything else comes up.
Thank you!

Hi Thanks for the update! I checked out the current version under corpus in the linked repo, just to clarify:

In the README, you mention that "Conversations are indexed by the original SwDa dataset IDs", but I think currently conversations are indexed by the id of the root (i.e., "4384-0" as opposed to "4384"). I don't think we have to align with SwDA id, but we probably do want to be accurate in the documentation.

For some conversations there is the additional meta info of "filename", but not all conversations have that. Is there any reason why? This field is also not mentioned in the README, and I personally feel we may necessarily need to keep them, given that's it's more of a conversion detail that is less relevant for anyone doing conversational analysis with the corpus.

You are right, I updated the README to document that we are using the roots of the SwDA IDs for the conversation IDs. Here's the updated README: README.txt
I'm a bit confused by your second point. Do you mean that we should get rid of the filename meta info, or that we should keep it? You said that you think we need to keep it, but follow that up by saying that it is not a relevant piece of information. Was this a typo, and you meant to say we do not necessarily need to keep it?
Thanks!

Thanks for the update! Re 2, I did not mean that you need to keep it (my vote is no, unless you find particular reasons for such need). However, I was a bit confused about why some conversations have that meta field but others don't (presumably all conversations are read from some file?). So the earlier part of my comment is meant to say that it may be worth checking why there is such behavior, but not that they should be kept.

Hello, sorry to keep you waiting.
So I digged up the original data, and what I found was that in several files of the swda dataset, the ptb_basename field (which we transferred as "filename") was left blank, hence leaving meta fields in some conversations as empty.
In fact, they don't actually coincide with the actual file names we get the transcripts, but I believe the developers of swda used those to denote the filenames in the raw data, not the data they released. So I'm guessing we have two choices: 1) We can keep the "filename" field, but instead use the filenames corresponding to the released version of the dataset, which could be useful? or 2) We can simply remove the "filename" field of conversations as you mentioned.
Let me know which you would prefer, and I'll update it accordingly. Thank you!

Hi, thanks for getting back! Would using filenames corresponding to the released version provide information for people who want to look up for the parse trees (which I believe we decided to exclude?). If so, I think it would be good if we go with option 1).

Yup, the users will be able to look up corresponding parse trees in the original swda dataset with the filename. Let me update the dataset. Thanks!

Hey, I am just wondering if you have found the time to make the edits you mentioned? (No worries if you were busy, it would also be helpful if you are willing to share any in-progress intermediates).

Oh sorry, I should have sent a confirmation. The edits have been made already, and updated in the repo. Feel free to take a look and give any feedback.

Thanks! This corpus has now been integrated into ConvoKit (https://zissou.infosci.cornell.edu/convokit/documentation/switchboard.html)! Let me know in case you find any issues.

Will do. Thank you for your patience!

@all-contributors please add @sc782 for data

@all-contributors please add @noameshed for data


base chain: op-reth nonce returns an error when getting transaction data

Describe the bug
The nonce value is inconsistent with the actual user nonce
Steps to reproduce
Use the request request node to view the nonce in the returned data and compare it with the browser.
curl --location --request POST 'http://<IP_ADDRESS>:21601'
--header 'User-Agent: Apifox/1.0.0 (https://apifox.com)'
--header 'Content-Type: application/json'
--data-raw '{
"jsonrpc":"2.0",
"method":"eth_getTransactionByBlockHashAndIndex",
"params":[
"0xd75603fddf8651d797bf4c7c6f36e404726a6a9771b6fd66b4337bd0207f5a9d",
"0x0"
],
"id":1
}'
Node logs
No response
Platform(s)
Linux (x86)
What version/commit are you on?
v1.1.0
What database version are you on?
2024-10-14T08:30:26.080146Z  INFO Initialized tracing, debug log directory: /root/.cache/reth/logs/dev
Current database version: 2
Local database version: 2
Which chain / network are you on?
base
What type of node are you running?
Archive (default)
What prune config do you use, if any?
No response
If you've built Reth from source, provide the full command you used
No response
Code of Conduct

[X] I agree to follow the Code of Conduct

could you please elaborate,
what error is returned, what is inconsistent?

could you please elaborate, what error is returned, what is inconsistent?

This account obviously has a lot of transactions, nonce should not be 0x0.
https://basescan.org/address/0xdeaddeaddeaddeaddeaddeaddeaddeaddead0001
result info,
    "nonce": "0x0",

the missing deposit receipt version is solved by a pretty big change which is making TransactionCompat stateful (adding ref to self as arg to TransactionCompat::fill), as mentioned in https://github.com/paradigmxyz/reth/pull/11440#issuecomment-2405081663

Do I need to resynchronize the node for this to take effect? After upgrading the software to v1.1.1, the nonce returned by the transaction request has not changed.
Nonce still returns 0x0
curl -s -X POST -H "Content-Type":application/json --data '{"method":"eth_getTransactionByHash","params":["0x0089734ba94159246d3c343b72b44fe034b053075c32f764b2816c342e62946e"],"id":1,"jsonrpc":"2.0"}' http://<IP_ADDRESS>:21601 |jq

Or is it because of the huge transaction volume of this address?  https://basescan.org/address/0xdeaddeaddeaddeaddeaddeaddeaddeaddead0001
Return normal Nonce when querying other users' transactions

for rpc, the noce field is the  tx receipt's nonce field

looks like we just need to use the nonce here
https://github.com/paradigmxyz/reth/blob/3a337cd7d4ad8c14569d20141fdcc2b1c54dbdf3/crates/optimism/rpc/src/eth/transaction.rs#L111-L111
I believe we already had this at some point


<EMAIL_ADDRESS>hash check failed

Checking hash of install-pep-514.reg ... ERROR Hash check failed!
App:         business/python
URL:         https://raw.githubusercontent.com/ScoopInstaller/Main/master/scripts/python/install-pep-514.reg
First bytes: 57 69 6E 64 6F 77 73 20
Expected:    c2611c8010979a47cdeea1af17d5061d8df40c5356fd8c2f3ba9492d516a99d1
Actual:      27c2d7e74442f356d54d29000379afd55078fb4ede00455fc012f81745e4bcac

You are right. Thank you for reporting.


Errors Are Not Exceptions

source: devto
devToUrl: "https://dev.to/swyx/errors-are-not-exceptional-1g0b"
devToReactions: 97
devToReadingTime: 5
devToPublishedAt: "2021-01-29T15:18:16.000Z"
devToViewsCount: 2502
title: Errors Are Not Exceptions
published: true
description: Many language ecosystems use try/catch paradigms to represent both errors and exceptions. This is wrong.
tags: languages, golang, javascript
slug: errors-not-exceptions
canonical_url: https://www.swyx.io/errors-not-exceptions
listen to me explain this in a podcast
TL;DR

Errors are unrecoverable, Exceptions are routine.
Most languages (Java, PHP) build the distinction into the language. Yet others (Go) name them the other way round. Some languages (JavaScript, Python) treat them as synonyms.
No matter what way you name things, you should handle Errors and Exceptions separately in your code or bad things happen.

Because I started out in JS/Python and then went to Go, without touching Java, getting this distinction right took me a few hours of thinking and research. It's not self-evident!
Context
If you've ever thrown an error in a function expecting its invoker to catch it, you're doing it wrong.

Ok, I'll admit I'm just hamming up a mere opinion for a more eye-catching opening. But I do feel strongly about this so...

I was recently reminded of this while going through the Go FAQ and being reminded that Go does not have exceptions.
What? If you've always coded in a language that has exceptions, this ought to jump out at you.
Go does not have try or catch. Despite those language constructs existing for decades, Go chose to have Defer, Panic, and Recover instead. By convention and design, Go encodes an extremely strong opinion that errors should be returned, not thrown.
But Why
Relying on exception handling to handle errors either leads to convoluted code or unhandled errors.
This kind of code is common in JavaScript:
function trySomethingRisky(str) {
		if (!isValid(str)) throw new Error('invalid string!')
		return "success!"
}

function main() {
	try {
		return trySomethingRisky(prompt('enter valid name'))
	} catch (err) {
		if (err instanceof Error) {
			// handle exceptions
		} else {
			// handle errors
		}
	}
}

If you're thinking that you don't write this sort of code very often, you're probably not thinking through your failure modes enough.

JavaScript doesn't have a native way to indicate whether a function can throw, if you invoke it. So you cannot lint against it — you must either pay this cost earlier in manual code review or later in bug reports.
An innocent fs.readFileSync call can bring down a whole server (or memory-leak descriptors) given the wrong string.
Promise calls without a catch in the browser will simply log silent errors (a terrible user experience).

The more function and module boundaries you cross, the more you need to think about defensively adding try/ catch and handling the gamut of errors that can happen, and the harder it is to trace where errors begin and where they are handled.

Aside - some authors like this Redditor and Matt Warren make a performance driven argument for encouraging developers to not overuse exceptions. Exceptions involve a memory and compute intensive stack search. This matters at scale, but most of us will never run into this so I choose not to make a big deal out of it.

Errors vs Exceptions
Let's attempt a definition:

Exceptions are expected failures, which we should recover from.
Errors are unexpected failures. By definition, we cannot recover elegantly from unexpected failures.

You might notice the ironic inversion - it is errors that are "exceptional", while exceptions are routine. This was very confusing to your humble author.
This is no doubt due to the fact that JavaScript, Python, and other languages treat errors and exceptions as synonyms. So we throw Errors when we really mean to throw exceptions.
PHP and Java seem to have this difference baked into the language.
To make things extra confusing, Go uses error where other languages would call exceptions, and relies on panic to "throw" what other languages would call errors.

Notes: Chris Krycho observes that you can use Rust, F#, and Elm's Result in a similar way, and Haskell's Either.

Exception Handling vs Error Checking
The realization that we need different paradigms for handling errors and exceptions is of course not new. Wikipedia's entry on Exception Handling quotes Tony Hoare (creator of QuickSort, CSP and the null reference) saying that exception handling is "dangerous. Do not allow this language in its present state to be used in applications where reliability is critical."
That was said in 1980, yet here we are 40 years later.
The alternative to exception handling is error checking.
Error Checking in Go

Note: Go seems to have a strong opinion that "Errors" are routine and Exceptions (not formally named, but used in panic) are Exceptional - in direct opposition to other languages. I have opted to use Go-native terminology - minimizing confusion locally at the cost of increasing global confusion.

Errors are values in Go — made to be passed, not thrown. Go's FAQ is worth quoting here:
We believe that coupling exceptions to a control structure, as in the try-catch-finally idiom, results in convoluted code. It also tends to encourage programmers to label too many ordinary errors, such as failing to open a file, as exceptional.
When something goes wrong, your default choice should be using multi-value returns to report errors:
i, err := strconv.Atoi("42")
if err != nil {
    fmt.Printf("couldn't convert number: %v\n", err)
    return
}
fmt.Println("Converted integer:", i)

This pattern would be subject to the same weaknesses I outlined above, except for the fact that Go will refuse to compile if you 1) don't assign all returned values at the callsite or 2) don't use values that you assign. These two rules combined guide you to handle all errors explicitly near their origin.
Exceptions still have a place — but the language reminds you how rarely you should use it, by calling it panic().  You can still recover() and treat it like a backdoor try/ catch in Go, but you will get judgy looks from all Gophers.
Error Checking in Node
JavaScript lacks the 2 features I mention above to force you to handle errors.
To work around this and gently nudge you, Node uses error-first callbacks:
const fs = require('fs');

function errorFirstCallback(err, data) {
  if (err) {
    console.error('There was an error', err);
    return;
  }
  console.log(data);
}

fs.readFile('/some/file/that/does-not-exist', errorFirstCallback);
fs.readFile('/some/file/that/does-exist', errorFirstCallback);

This pattern is idiomatic in most Node libraries, but the further we get away from Node, the more we tend to forget that there is an alternative to throwing errors, when writing libraries and app code.
Lastly, it is tempting to promisify those callbacks:
const util = require('util');
const fs = require('fs');

const stat = util.promisify(fs.stat); // i am using fs.stat here, but could be any error-first-callback userland function

// assuming top-level await
try {
	const stats = await stat('.')
	// do something with stats
} catch (err) {
	// handle errors
}

And we are right back where we started - being able to fling errors and exceptions arbitrarily high up and having to handle both in the same place.
Other Reads

Dave Cheney on Go Errors and Exceptions
Haskell Wiki on Errors vs Exceptions
You can implement a Result or Maybe in JS: https://true-myth.js.org/

Thanks to Charlie You and Robin Cussol for reviewing drafts of this post.

try/catch/throw is basically GOTO