Ctrl+w closes 2 webviews at once when one webview has retainContextWhenHidden set to true.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:

~ code --version
1.75.0
e2816fe719a4026ffa1ee0189dc89bdfdbafb164
x64

OS Version: Arch Linux

Steps to Reproduce:

Set up this reproducer command in an extension:

import * as vscode from 'vscode'
export async function activate (context: vscode.ExtensionContext): Promise<void> {
  context.subscriptions.push(
    vscode.commands.registerCommand('small.reproducer', async () => {
      vscode.window.createWebviewPanel('', 'panel1', vscode.ViewColumn.One, { retainContextWhenHidden: true })
      vscode.window.createWebviewPanel('', 'panel2', vscode.ViewColumn.One, {})
    })
  )
}

Run the extension.
Open an empty new tab (ctrl+n).
Run the extension command (small.reproducer, or whatever you call it). This opens 2 more empty webviews to the right of the new editor tab.
Ctrl+shift+tab twice to get to the first tab.
Ctrl+tab twice to go back to panel2.
Ctrl+w to close the webview. It closes both webviews.

This works most of the time, though sometimes it will correctly close just 1 webview. Repeat steps 4-7 if this happens. This is only an issue when retainContextWhenHidden is true for panel1.

Thanks for the repo steps but I'm unable to reproduce even after multiple attempts
Are you still seeing this in the latest VS code insiders build?

Yes, I can still reproduce this with the insiders build with a new extension and a new node version.
I will say that I forgot that I have my key bindings remapped, so ctrl+tab opens next editor and ctrl+shift+tab opens the previous editor like in Chrome (as opposed to most/least recent). With default keybindings the reproducer should be ctrl+PageUp twice, then ctrl+PageDown twice. Sorry for the confusion.

Hey @mjbvz, this issue might need further attention.
@samgiz, you can help us out by closing this issue if the problem no longer exists, or adding more information.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Where can I get the VS solution mentioned in the article?

I cant see any links to where I can download the VS solution described.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0891e384-80e8-5d40-8bde-24081e06876a
Version Independent ID: b6ecc0cb-e827-80aa-934d-ef03d674c97e
Content: Bootstrap with company data FAQ - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/data-entities/dual-write/bootstrap-company-data.md
Service: dynamics-ax-applications
Product: ****
Technology: ****
GitHub Login: @RamaKrishnamoorthy
Microsoft Alias: ramasri

Thanks for your feedback. This looks like the same question as received earlier. I will close this issue and keep the other one open for feedback from the author.


Using Maccy with Microsoft Remote Desktop Connection, does not paste anything. It just puts a "v" character instead.

The list of available items appears but it just doesn't do the paste.
It might have something to do with the fact the Windows expects Ctrl + V but I am not sure

What happens when you press CMD+V manually in the app? Is it also not doing anything to does it paste normally?

Using CMD+V does work and Pastes the clipboard as expected but that also happens when i press Ctrl+V which is default on windows. I think the app transforms Cmd+V to Ctrl+V automatically.
Beni Ile
On 25 Jan 2022, 07:08 +0200, Alex Rodionov @.***>, wrote:

What happens when you press CMD+V manually in the app? Is it also not doing anything to does it paste normally?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: @.***>

Interesting. What Maccy does is simply send a "Cmd+V" event so I would expect it to transform the event too. I'll need to look into this.

Let me know if I can help with testing
Beni Ile
On 25 Jan 2022, 09:02 +0200, Alex Rodionov @.***>, wrote:

Interesting. What Maccy does is simply send a "Cmd+V" event so I would expect it to transform the event too. I'll need to look into this.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: @.***>

@ibgbeny Do you happen to have an accessible Windows machine I could use to RDP to? I only have Windows VM running via Parallels Desktop, but it's Windows 11 Home Edition and I cannot enable Remote Desktop on this edition. Also, pasting works fine in Parallels Desktop.

I've noticed this as well with many clipboard managers over the years. It also types a "v" when doing a remote screen share using the macOS native app to another Mac.
If you invoke Maccy, it sends a "v", but backspacing the v and then pasting normally will paste the item you wanted.
(I do this daily since I do Mac Help Desk)
I do not know if the cause is the same for ARD and MS RDP, but it might be.

Yes, i've had this issue with other clipboard managers in the past but there are some that work.
For example aText, which is a text expander working also with the clipboard, works ok with this.

@ibgbeny Do you happen to have an accessible Windows machine I could use to RDP to? I only have Windows VM running via Parallels Desktop, but it's Windows 11 Home Edition and I cannot enable Remote Desktop on this edition. Also, pasting works fine in Parallels Desktop.

I'll give it a try and find you a windows machine to connect to. I'll DM it to you on twitter

@p0deje I managed to create an Azure Win 10 PC for your testing purposes. I tried DMing you but it seems I cannot. Let me know how I could send you the credentials

@ibgbeny I've opened DMs on Twitter for everyone - you should be able to send the credentials there.

@ibgbeny I can confirm the bug is happening on Microsft RDP. I also tried using other RDP clients (I have Jump Desktop) and pasting works correctly there. I assume there is something special about how the Microsoft RDP app handles keyboard events. I will try to figure this out, thank you for the help.

I haven’t had this issue before. Maccy, Alfred, or BTT clipboard manager in Microsoft rdp.
I do I know for me each and every  connection inside connection manager. I have to set “redirect clipboard” under “devices & audio”
Unless I misunderstanding the context of the issue.

I haven’t had this issue before. Maccy, Alfred, or BTT clipboard manager in Microsoft rdp.
I do I know for me each and every connection inside connection manager. I have to set “redirect clipboard” under “devices & audio”
Unless I misunderstanding the context of the issue.

This is strange. I have the same setup but it doesn't work for me. Are you using the relatively new RDP app, or the old one?

10.7.6 (1972)
I did remeber  the other setting under
Connections =>keyboard mode => Unicode
you have set to Unicode. I notice the mention of the virtual keys above another app(MacPass) autotype feature would just send “v” s because of that.

If I switch to "Unicode" mode under connection, it doesn't even type "v". Attempt to paste produces a macOS sound similar to the one when you try to press "Cmd+V" in a window that doesn't accept paste (e.g. Maccy preferences).

To clarify you have to select an item within the clipboard history. This actions sends or shares the clipboard contents to the remote device (as long as you have clipboard sharing turned on for that connection). You can then paste using the specified keyboard shortcut on the remote device after that.
Microsoft RDP app when using with a clipboard manager doesn't actively check the pasteboard for changes. I have found when using a any clipboard manager to be the workflow.

The problem is not with copying the contents, the problem is that pasting directly from Maccy doesn't work.

Correct, and pasting directly into RDP if you use scan mode it you will get the errant v character. In the other referenced app is an a character and that's because of the method of keyboard events and specially RDP. Sorry, I am not trying suggest Unicode completely "fixes" this issue.
The point is when you are attempting to paste into RDP. It seems to be related to the keyboard events being used by maccy in relationship to the keyboard mode.
For reference:
There is specific post relating to the errant key
https://github.com/MacPass/MacPass/issues/1020
https://github.com/keepassxreboot/keepassxc/issues/3080

Just to clarify, pasting works neither in scanmode nor unicode mode.
@georgesnow Thanks for referencing other issues, I wish I could find an example of when it works.

So I am not sure there is a way for Maccy to do it without doing something specific when RDP becomes the active app. 🤷♂
I just checked the one other app I use. Screens by Eodvia, which is Remote Desktop client(VNC). That app has a specific feature that shares the clipboard and seems to work as expected. So it seems to be dependent on the rd app unfortunately.

Yes, it indeed looks like RDP specific events handling and I'm not sure how to work it around.

Have you tried sending Ctrl+V instead of sending Cmd + V?
Beni Ile
On 12 Feb 2022, 07:38 +0200, Alex Rodionov @.***>, wrote:

Yes, it indeed looks like RDP specific events handling and I'm not sure how to work it around.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: @.***>

I'm frankly out of ideas on what else to try. Would be happy if anyone chimes in?

It's more of a bug for Remote Desktop clients itself.
If you close the session you have and reopen it, it will works
For the copy & pastes to work, you have to close and reopen it from time to time.
The bug is not for Maccy.
When you reach the bug, you just simply can't paste anything.

Thanks to FlyCut https://github.com/TermiT/Flycut/pull/18, I managed to make it work in "Scanmode" keyboard mode. I can't still make it work in "Unicode" mode but I hope it's already better. PRs that will make it work for both modes are more than welcome!


Support uneven DDP inputs with pytorch model.join

See more details: https://github.com/pytorch/pytorch/issues/38174
cc @borda @tchaton @rohitgr7 @akihironitta @awaelchli

Interested in this issue! Hopefully some progress is done soon :+1:

Interested in this also :)

Is there any progress on this issue? Happy to help in any way.

@rohan-varma that would be great!! Want to try and submit a draft PR? And we can help from there?

@edenlightning Sounds good, I also pinged the slack channel for any feedback/discussions.

We'd also be very interested in this feature. Let us know if there's anything I can do to help!

The PR https://github.com/PyTorchLightning/pytorch-lightning/pull/5141 is ready for review, in case anyone wants to take a look.

I discussed this more with @rohan-varma  - DDP join docs: https://pytorch.org/docs/stable/_modules/torch/nn/parallel/distributed.html#DistributedDataParallel.join

This module currently does not support custom distributed collective operations in the forward pass, such as SyncBatchNorm or other custom defined collectives in the model’s forward pass.

As the LightningModule is wrapped in another module which is then wrapped with DDP, the LightningModule's train_step becomes the forward pass run by the DDP wrapped module: https://github.com/PyTorchLightning/pytorch-lightning/blob/d471fa30b3bf95cfe601014bac544754067241ca/pytorch_lightning/plugins/training_type/ddp.py#L223-L227
As a result, any collective call (such as metric syncing or all_gather) that happens during training step will cause this to not work. Therefore I lean towards closing this out given the caveats. @awaelchli @justusschock what do you think?

agree, I also don't see how this can be supported at the moment.

Also blocked by the duplicate validation data, which causes the validation result to be incorrect. Is there any workaround for this issue? Like only running validation on one gpu?

@JiesiZhao077 Running in one GPU would be the easiest and safest option. You can also set this DistributedSampler which would also solve the issue, but introduces the risk of deadlocks if collective operations are used
https://github.com/PyTorchLightning/pytorch-lightning/blob/45f6a3b1758f88af7fd776915539800cbc0137a9/pytorch_lightning/overrides/distributed.py#L80
We use automatically with trainer.predict. You could try and use it with trainer.validate as well.
Closing this issue as there's no clear way forward at the moment.

@ananthsub commented 6 hours ago

However, the manner in which join tracks collectives can quickly run into issues with other collectives that run in the forward pass / training_step.

In PyTorch, the "with Join" construct is used as a simple wrapper around training steps. It should work in simple cases even if there are more complex cases where it doesn't work.
So, why not simply add an option to the trainer that enables wrapping the invocations of training_step with with Join? That should be pretty straightforward, and it would leave it up to users to determine when with Join is the right thing to use and when it doesn't work.

So, why not simply add an option to the trainer that enables wrapping the invocations of training_step with with Join?

The join here is specific to pytorch DDP. If it was implemented, it would have to live inside the DDP plugin/strategy. For simple cases it may work, but no collective calls are allowed if I understand correctly.
If we did want to do it "correctly", we would probably have to set throw_on_early_termination=True and then we must handle the error in all custom collective calls, including the ones in torchmetrics. I don't know if that would work, but it's probably not feasible.

To recap, the plan would be:

Enable "join" as an optional feature of the DDP strategy: Trainer(strategy=DDPStrategy(uneven_input_support: bool). We could also add a registry string for it.
Add support for "joining" the training_step, validation_step, test_step. Probably not necessary for predict_step since we use an UnrepeatedDistributedSampler.
When the feature is enabled, we don't automatically use the generic DistributedSampler as we wouldn't want to duplicate data to make inputs even: https://github.com/pytorch/pytorch/issues/49180. Could we use UnrepeatedDistributedSampler?
We print a big warning about how this feature is experimental and describe all its caveats.

Is there a benefit to doing it for validation_step and test_step? Probably not

I assume there is, if collectives are being used. For example, sync_dist=True in self.log or similar.

When the feature is enabled, we don't automatically use the generic DistributedSampler as we wouldn't want to duplicate data to make inputs even.

https://github.com/pytorch/pytorch/issues/49180 is great! Hopefully this will clarify the drop_last argument which has a slightly misleading/incomplete description :) We would indeed need the UnrepeatedDistributedSampler.

Hi, everyone, I'm gathering information on what is needed in order to support this properly.

Use torch.distributed.algorithms.Join (https://pytorch.org/docs/stable/distributed.algorithms.join.html) as a context manager in which is the model run.
Use UnrepeatedDistributedSamplerWrapper
Check for all modules, that could use syncing (such as SyncBatchNorm) and have them as arguments to the Join context manager from 1.
Figure out what to with calls to self.log(..., sync_dist=True)

Is that it? cc @awaelchli, @carmocca.

@otaj Almost.
Additionally, all metrics from torchmetrics would have to be considered as well as they are also capable of issuing syncs on their own. And in general, the user can run arbitrary syncing calls within each of the steps which have to be considered as well (which will be the trickiest part I guess)

oh, those torchmetrics are going to be fun... :sweat_smile: I think capturing user calls can be solved with yet another contextmanager (our, custom one), what do you think?

if we can capture user calls with that, it might work similarly with torchmetrics. So let's ignore those metrics for now and if you got a working solution for everything else, I'm sure we'll manage to integrate metrics with that :D

let's check the option with LigthingLite first 🦦

Here is the corresponding issue as suggested in planning: #14635

hi, any updates of this issue?

Is there a (hacky) method for implementing the PyTorch .join() context into your own PL setup? Or is currently the only solution to revert back to PyTorch?

Any updates on this issue?


[ROX-12496] : Add deprecation notice for csv export endpoint and provide info about new endpoints to use

Checklist

~[ ] Investigated and inspected CI test results~
~[ ] Unit test and regression tests added~
~[ ] Evaluated and added CHANGELOG entry if required~
~[ ] Determined and documented upgrade steps~
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Not needed for Changelog update

/retest-required

/retest

/retest-required


Update ppmc

## The process of new PPMC member

### discuss in mailing<EMAIL_ADDRESS>see **PPMC Member Discuss Template**
### Call a vote in mailing<EMAIL_ADDRESS>see **PMC Member Vote Template**
### Close the vote
see **Close Vote Template**
### Send message to IPMC
see **Send message to IPMC Template**
### If the result is positive, invite the new PPMC member
see **PMC member Invite Template**

...

How about removing these, seems duplicated to the TOC


Not calling the module.run() when using AngularJS 1.7.x

I am trying to update from AngularJS 1.5 to AngularJS 1.7 and it seems something in the order of execution has changed.
The $log is being used before the module.run(), so the getInstance() is not present, causing the application to crash.
I was wondering if anyone has come across this and may have a solution.
I will keep poking around to see if I can figure it out in the meantime.

Your help is appreciated!


When I run serve.prod.exp I get a type definition error because of missing Firebase type definiations

When I run run run serve.prod.exp I get a type definition error.
This is when I run the command in git bash.
Error is: Error: Cannot find type definition file for 'Firebase'
My app uses Firebase and it seems I need to add the type Firebase some where.
Where do I add 'firebase' for serve.prod.exp to work?
This is my attempt at adding the file firebase.d.ts:

This is me trying to add firebase to tsconfig:

Below is a screen shot of the error:

i have the same problem with my own jquery type definition but i have another type definition of zxcvb and this works  :(

@owndann there are a lot of issues closed regarding collision between Protractor's type definitions and jQuery. You can search for the answer there.
@markoddi01 you should use npm i @types/firebase --save-dev. Take a look at this article.


modulesFolder not working

I want to shim node's stream, and from what I've understood modulesFolder is the way to go. Thus my fuse.js looks like this:
const fb = require("fuse-box");

const FuseBox = fb.FuseBox;

const fuse = FuseBox.init({
  homeDir: "source",
  sourceMap: {
    bundleReference: "public/dist/main.js.map",
    outFile: "public/dist/main.js.map",
  },
  outFile: "public/dist/main.js",
  modulesFolder: "source/shims"
});

fuse.devServer("> js/main.js");

my source/shims/stream/index.js contains:
module.exports = {
  test: "asd",
};

and my source/js/main.js:
console.log("test", require("stream"));

Expected result
To log "test", {test: "asd"}.
Actual result
"test", {}.
Am I doing something wrong?

Have you disabled cache? Because your library will treated like any other NPM module.
Btw, We have stream library already in place

If by disabling cache you mean setting cache: false and/or rm-rf:ing the .fusebox folder then yes.
It seems to me the provided stream library doesn't do much?

Well, not for browser yes. Only server. I will check, maybe there is an issue with custom module priorities

Fixed in v1.3.111


The weights of ClientsAndWeights aren't guaranteed to be sorted for binary searching

RandomWeightedLoadBalancer selects the client using Collections.binarySearch which requires the list to be sorted to avoid undefined results. There are no preconditions to check that the weights are actually sorted.

The list is assumed to be sorted.  I'll add documentation to call that out but I don't see the value of doing an actual precondition check.


Missing requirements.txt

requirements.txt is not in the /app directory.

Should definitely fix that, thanks!


AttributeError: is_homepage

Up new site now and return error, branch developer
https://i.imgur.com/4yJlD4I.png

checkou to aec69f34d38842adf5e5c150c37c3816b91b57e7
I've deleted the database again and climbed the quokka and it worked.

I've test again, following strictly the https://github.com/quokkaproject/docker-gunicorn-supervisor/blob/master/README.md instructions.
It worked well if you run manage.py populate as the last step.
There are 2 problems.

When docker-compose up starts it does not ensure the order of loading, in other words, Gunicorn starts serving quokka app before MongoDB is ready. For that I included a note to run "docker-compose run mongo" once before.

The same problem is happening when docker-compose up starts again. Quokka has a script in ext/fixtures that tries to load base needed data, default configs, base channels, homepage etc.. if mongo is not responding it fails silently.

Solution: We need to refactor ext/fixtures to use @retry or another way to ensure base fixtures are loaded & we need a way to start serving quokka only after MongoDB is available.

BTW: If run any command in shell
docker-compose run --rm quokka python manage.py shell

or
docker-compose run --rm quokka python manage.py populate

It magically works
Maybe we need a mandatory command?
docker-compose run --rm quokka python manage.py install

??


replace Raphael's grammar with Boris' grammar

Opening this Pull Request so we can have discussion about it.
Please merge only once discussion has finished.
Boris' grammar seems to be working more reliable, so I think we should use it as a starting point.
Someone who understands these grammars should then add everything back that was better in Raphael's grammar.

Boris' grammar is also not completly error free, so if we decide to merge this PR then we would have to fix the same issues that are present in Boris' issue tracker:
https://github.com/BorisChumichev/modelicaSublimeTextPackage/issues

I'm good with merging this. I tried several files. I found one case where @BorisChumichev's grammar is wrong:
http://bit.ly/1PuWY19
Annotations are tricky to get right. Some options for fixing this one are:

Make the regex look for a trailing ); instead of just ;.

Have the grammar look for nested Icon( -- ). I think that's how Boris avoids tagging semicolons in the HTML section.

Is that fix sufficient?
Does it work if the annotation ends with ) ; (note the space between parantheses and semicolon)?

Here's what was in the original grammar:
'\\)\\s*;\\s*$'

OK, that line is reverted to Raphael's version.

@lochel if it looks good to you also, feel free to press the Merge button.

Here is another case where Raphael's grammar works better:
http://bit.ly/1GeI3G1
but I don't know how to fix it.

I think this can be merged. The issues with Boris' grammar can be added separately.

Merge the PR and publish a new minor version.
I will close some of the issues and open new ones this weekend.


Hot reloading not working for styles

I have an idea of what this might be; a few releases ago I made ExtractTextPlugin non-production-only, so going to switch it back and see if it resolves the issue.

ExtractTextPlugin does not support hot reloading and is intended to only be used in production.

Yeah I don't know why I did it, I purposely kept it out of development in the past... just an oversight. Reverting it now.

@bulby97 this is fixed with https://github.com/davezuko/react-redux-starter-kit/commit/a7c3513916b8d9eac4f2cd7887b3f4ec20bd8d15. Sorry about that!

@davezuko No problem ! You're doing a great work ! Thanks for your reactivity


Cloud 538

MDC context passed to threads from executorservices
corrected some log messages
fixed np in ambari role allocator

@keyki , @martonsereg , @doktoric have fun ;)

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1077/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1079/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1080/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1087/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1091/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1092/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1093/


nuspec diff noise due to lack of sorting

I am frequently seeing changes to my .nuspec source file from a build because the ReferenceGenerator reorders dependencies, such as this one:
-        <dependency id="Microsoft.VisualStudio.Threading" version="14.1.114" />
-        <dependency id="Newtonsoft.Json" version="6.0.6" />
         <dependency id="System.AppContext" version="4.0.0" />
         <dependency id="System.Collections" version="4.0.10" />
         <dependency id="System.Diagnostics.Debug" version="4.0.10" />
         <dependency id="System.Diagnostics.Process" version="4.0.0-beta-23409" />
         <dependency id="System.Globalization" version="4.0.10" />
         <dependency id="System.IO" version="4.0.10" />
         <dependency id="System.IO.FileSystem" version="4.0.0" />
         <dependency id="System.Linq" version="4.0.0" />
         <dependency id="System.Net.Primitives" version="4.0.10" />
         <dependency id="System.Runtime" version="4.0.20" />
         <dependency id="System.Runtime.Extensions" version="4.0.10" />
         <dependency id="System.Security.Claims" version="4.0.0" />
         <dependency id="System.Security.Cryptography.Algorithms" version="4.0.0-beta-23409" />
         <dependency id="System.Security.Cryptography.Primitives" version="4.0.0-beta-23409" />
         <dependency id="System.Security.Principal.Windows" version="4.0.0-beta-23409" />
         <dependency id="System.Text.Encoding" version="4.0.10" />
         <dependency id="System.Threading" version="4.0.10" />
         <dependency id="System.Threading.Tasks" version="4.0.10" />
+        <dependency id="Microsoft.VisualStudio.Threading" version="14.1.114" />
+        <dependency id="Newtonsoft.Json" version="6.0.6" />

If I let that get checked in, the next build may switch it back. And so it goes, back and forth.
Can this build step please consistently sort?

It's supposed to be sorting alphabetically by package id, so I'm not sure what's going on. I have seen this a few times but can't repro it:
https://github.com/onovotny/ReferenceGenerator/blob/master/src/ReferenceGenerator/Program.cs#L98

It looks like you don't sort the whole list. You only sort your insertion into the list. So your list's position relative to other elements (that I've added myself) evidently is undefined?
https://github.com/onovotny/ReferenceGenerator/blob/master/src/ReferenceGenerator/Program.cs#L157


Can't find Google Group

Hi,
Sorry for posting here but I wanted to reach out on your Google Group, unfortunately I can't find any Google Group under<EMAIL_ADDRESS>Can you help me out ?
Best regards,
Evelina

Hi Evelina,
Sure, how can I help?
Best,
Peter
On Wed, May 25, 2022 at 3:18 AM EvelinaPillai @.***>
wrote:

Hi,
Sorry for posting here but I wanted to reach out on your Google Group,
unfortunately I can't find any Google Group under @.***"
Can you help me out ?
Best regards,
Evelina
—
Reply to this email directly, view it on GitHub
https://github.com/verilylifesciences/deepmass/issues/8, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6Q7PTQXFKHPPGIREKKNV3VLX5ALANCNFSM5W4TRR6A
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hi Peter,
We would like to apply the in-silico predicted spectral library from Prism to increase the number of protein IDs and improve protein quantification (LFQ) of a DDA experiment.
In this context, we would like to ask the following question:
Can Prism be implemented in a standard MaxQuant workflow for LFQ?
Maybe in a way that the predicted intensities from the output of Prism can be imported into MaxQuant to improve the peptide identification and therefore also LFQ of proteins?
We would be very grateful for your support. Thank you very much in advance!
Best regards,
Evelina

Hi Evelina,
I suggest you reach out to Prof. Juergen Cox, who has been integrating
Prism into MaxQuant.
Best,
Peter
On Fri, May 27, 2022 at 12:32 AM EvelinaPillai @.***>
wrote:

Hi Peter,
We would like to apply the in-silico predicted spectral library from Prism
to increase the number of protein IDs and improve protein quantification
(LFQ) of a DDA experiment.
In this context, we would like to ask the following question:
Can Prism be implemented in a standard MaxQuant workflow for LFQ?
Maybe in a way that the predicted intensities from the output of Prism can
be imported into MaxQuant to improve the peptide identification and
therefore also LFQ of proteins?
We would be very grateful for your support. Thank you very much in advance!
Best regards,
Evelina
—
Reply to this email directly, view it on GitHub
https://github.com/verilylifesciences/deepmass/issues/8#issuecomment-1139359136,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6Q7PQVQZ2LH35W4U6MAHLVMB3BBANCNFSM5W4TRR6A
.
You are receiving this because you commented.Message ID:
@.***>


Bug 2184058: Display 'Add network interface' button only once

📝 Description
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2184058
Remove Add network interface button from VM's Network interfaces tab in case there are no any NICs present, according to the UX suggestions. Display the button only once - in the left up, next to the YAML switcher.
Notes:
Note that the solution is not 100% consistent with "empty state" but it’s more important that all the buttons in the VM details page are aligned (discussed that with the UX).
Also note that within the BZ https://bugzilla.redhat.com/show_bug.cgi?id=2176797, the title of the page Network interfaces will be added and then the button will be positioned under that title.
🎥 Screenshots
Before:
Add network interface button  displayed twice:

After:
Add network interface button  displayed once - position of the button same as in other VM's tabs:

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

/lgtm

Note that the solution is not 100% consistent with "empty state" but it’s more important that all the buttons in the VM details page are aligned (discussed that with the UX).

just out of curiosity is there any plan to make the empty state consistent for also VM list or other place we have duplicated buttons according to UX?

just out of curiosity is there any plan to make the empty state consistent for also VM list or other place we have duplicated buttons according to UX?

If we hit such duplicated buttons somewhere else, we definitely want to make it consistent. I haven't found such duplications yet, requires more testing. If you are aware of such pages, let me know.

@hstastna I aware of these two

Yes, we need to remove unnecessary buttons from those pages you've pointed out. And according to the discussion with Yifat, we want to remove upper right buttons, not from the middle, because it's consistent with the Patternfly empty state. That's the default convention for empty state. I'm gonna do it in a followup PR. Thanks for pointing that out, Aviv! sparkle

This may be consistent with PF, but it is not consistent with console as all resources pages have the button at the upper right corner, I'm not sure we want to go in that direction

I am not sure if it is a good approach to look at console project when looking for some "source of truth", applicable to our actual one. We know there were many issues and inconsistencies...
As I've said, this is a bit problematic, as we have some specific screens and cannot be consistent with both approaches I've mentioned, at once, approaches that are different. We can be consistent only with one of them. We have to choose one to improve the screen/screens at least a bit, move towards better. Our project is still fresh and fast evolving. We may not know everything right now, like future plans etc, so we also may not understand all the UX decisions. Because this (a.k.a. the result of this PR and the followup ones that are gonna be created for MigrationPolicies and VMs empty states) was the decision made by the UX, not myself.
We should follow the PF guidelines for sure, if possible. Of course, for specific situations we have specific UX decision that may not be aligned with PF for 100%.
Anyway, if you do think it was not a good decision, please, feel free to come up with some other suggestions for the mentioned screens, and discuss that with me together with Yifat or anyone from UX. I did this already and this was the decision, I didn't come up with any better ideas to suggest. UX are experts for the UX part of our project anyway. We are aware of the fact that the decision wasn't 100% consistent with everything. We (I and the UX) do realize that. It's probably not the final state of those screens, as I've already said, this project is still evolving and very fast...


depthimage_to_laserscan: 2.5.0-1 in 'rolling/distribution.yaml' [bloom]

Increasing version of package(s) in repository depthimage_to_laserscan to 2.5.0-1:

upstream repository: https://github.com/ros-perception/depthimage_to_laserscan.git
release repository: https://github.com/ros2-gbp/depthimage_to_laserscan-release.git
distro file: rolling/distribution.yaml
bloom version: 0.10.7
previous version for package: 2.3.1-1

depthimage_to_laserscan
* Install includes to ${PROJECT_NAME} folder and use modern CMake (#58 <https://github.com/ros-perception/depthimage_to_laserscan/issues/58>)
* Fix the launch files to work with Rolling. (#59 <https://github.com/ros-perception/depthimage_to_laserscan/issues/59>)
* Contributors: Chris Lalancette, Shane Loretz

Holding for Rolling sync.


What about destructive (!) methods?

I have a feeling like I already asked it but I can't find my question.
For example:
  1.upto(7) do |i|
    x = image.width * i / 8
    image = image.draw_line [255, 0, 255], x, 0, x, image.height - 1
    y = image.height * i / 8
    image = image.draw_line [255, 0, 255], 0, y, image.width - 1, y
  end

Instead of image = image.draw_line I would like to write image.draw_line!.
UPD: Specifically in this case If I only needed horizontal lines I would write smth like 1.upto(7).inject(image) do |i, image| and then would not need the image = but I need a chain of two operations. Probably I can do image.draw_line(...).draw_line(...) but that's not a style I want to see here.

Hello, the problem is that libvips does not really support destructive operations. Having immutable images makes a lot of the sharing and caching systems much, much simpler. I did experiment with a destructive draw_line at one point, but a small mistake could produce a segv, so it seemed too dangerous.
The way to do this safely is to do image.copy to make a fresh image which you are sure is not being shared, then to do a series of destructive operations, then to return the modified image. You could use it from Ruby perhaps like:
modified_image = start_image.destructive do |x|
    x.draw_line! 255, 10, 10, 100, 100
    x.draw_line! 255, 10, 110, 100, -100
end

Maybe with something magic in draw_line! so it only works inside a destructive block.

I don't mind how libvips works under the hood. Think about it as a Ruby-specific feature.
Here is another example.
Let's say we have some procedure that covers image with some drawings:
some_iterator do |i|
  args1, args2 = f(i)
  image = image.draw_line *args1
  image = image.draw_line *args2
end

Now I decided to apply this not to a single image but to image1, image2 and image3. So I have to do this:
image1, image2, image3 = [image1, image2, image3].map do |image|
  some_iterator do |i|
    args1, args2 = f(i)
    image = image.draw_line *args1
    image = image.draw_line *args2
  end
  image
end

or this:
images = [image1, image2, image3]
images.map! do |image|
  some_iterator do |i|
    args1, args2 = f(i)
    image = image.draw_line *args1
    image = image.draw_line *args2
  end
  image
end

But what if I don't want the images array? With destructive methods I could do:
[image1, image2, image3].each do |image|
  some_iterator do |i|
    args1, args2 = f(i)
    image!.draw_line *args1
    image!.draw_line *args2
  end
end

Maybe define the Image#replace method and then smth like:
list_of_image_methods_that_return_another_image = %i{ draw_line draw_circle }
list_of_image_methods_that_return_another_image.each do |method|
  Image.define_method "#{method}!" do |*args|
    self.replace self.send method, *args
  end
end

You could simply add draw_line!, but if you made even a small mistake your program would crash with a segmentation fault, or perhaps generate corrupt output with no warnings.
I think the difficulty is how to add destructive operations in a safe way.

Let's tag this as an exhancement and experiment with destructive operations in a branch.

Here's a branch that adds destructive draw:
https://github.com/jcupitt/ruby-vips/tree/destructive-draw
You use it like this:
require "vips"

a = Vips::Image.new_from_file "/home/john/pics/k2.jpg"

n_lines = 1000

a = a.destructive do |image|
    n_lines.times do |i|
        image.draw_line 255,
            i * image.width.fdiv(n_lines), image.height,
            0, i * image.height.fdiv(n_lines)
    end
end

a.write_to_file "x.jpg"

So a set of draw operations must be wrapped in a destructive block. It seems to work, it's reasonably quick, and it runs in very little memory, compared to the previous version anyway.
What do you think?
Obvious improvements:

You can easily get a crash or a corrupt image if you use draw outside the block, or if you use non-destructive operations inside the block. There should  be some kind of lock to switch the kind of operations which are allowed and to catch mistakes.

We should add a ! to the end of all destructive operations. We could have both draw_line and draw_line!, and enforce the rule that they must be used in the right context.

Another solution would just be to abandon the draw operations. They are only really useful for drawing on float or complex images (for example), where most drawing packages fail.
A better alternative might be a helper function around svgload_buffer. Perhaps something like:
image = image.composite '<rect x="0" y="0" width="1" height="1" style="fill:red"/>', :over

To render the SVG as an overlay on the image. This would be easy to implement and would give a much better set of drawing operations. The libvips svg renderer has no problems doing very, very large images, so it should scale better too.

enforce the rule that they must be used in the right context

We can define the ! method as a wrapper that calls a method without ! inside a context.

Barely understanding inner working of the gem my approach is this:
require "vips"

require "delegate"
class ImageMutable < SimpleDelegator
  %i{ draw_line draw_circle }.each do |m|
    define_method "#{m}!" do |*args|
      __setobj__ self.send m, *args
      self
    end
  end
end

image = ImageMutable.new Vips::Image.new_from_file "ab.png"

image.draw_circle! 0, 100, 100, 100

image.write_to_file "ab_.png"

based on https://stackoverflow.com/a/9131654/322020

I made another branch with a possible solution:
https://github.com/libvips/ruby-vips/tree/add-mutableimage
This adds a new image class called MutableImage. You use it like this:
#!/usr/bin/ruby

require 'vips'

image = Vips::Image.new_from_file ARGV[0]

image = image.mutate do |mutable|
  (0 ... 1).step(0.01) do |i|
    mutable.draw_line! 255, mutable.width * i, 0, 0, mutable.height * (1 - i)
  end
end

image.write_to_file ARGV[1]

The idea is that the copy happens in the mutate member, then the block runs with the MutableImage as a parameter, then the block result is the mutated image turned back into a regular image again. Performance is obviously fantastic compared to the regular draw_line.
You can use it to modify image metadata too, eg.:
image = image.mutate do |mutable|
  image.get_fields.each do |field|
    mutable.remove! field if field != "ixcc-profile-data"
  end
end

There's set! and set_type! as well.
call checks that you only use method! inside a mutate block, and set! etc. is only defined on MutableImage. I've not updated the docs. It should print a warning if you use set on a regular Image, but it doesn't yet. The API is unchanged (so draw_image on a regular image still works).
Comments etc. very welcome!

@lovell @kleisauke this feels like a possible solution to the metadata modification problem. JS would be very like Ruby. C++ and Python would be a little awkward without an equivalent of blocks, though maybe Python's with could be abused?

Interesting. What will be if I call draw_line on MutableImage? Does it make any sense? If not then by invoking the block we kind of told the computer already that we want to do mutating things and we don't have to tell it again by adding the !. I mean, do we really need to add the ! to methods called on MutableImage?

You're right, it's the same idea, but the implementation is new -- the classes are split so it can check and enforce the rules about what operations you can call when. The rules are checked here:
https://github.com/libvips/ruby-vips/blob/add-mutableimage/lib/vips/operation.rb#L383
The old y = x.draw_line still works. This makes a copy of x before calling draw_line, then returns the new image to y, so it's a pure function. It checks that x a plain Image and not a MutableImage. You can use it anywhere.
The new addition, x.draw_line! only works on MutableImage, and therefore only works in a mutate block. It skips the copy, since it knows that MutableImage is already unique and unshared. It's not a function (since it modifies x), but the mutate block as a whole is a pure function.
I've put the metadata modifiers like set! into MutableImage too -- they are rather broken at the moment, since set does no checking that the image is unshared.
Another example:
#!/usr/bin/ruby

require 'vips'

# load and stream into memory
image = Vips::Image.new_from_file(ARGV[0], access: :sequential).copy_memory()

starting = Process.clock_gettime(Process::CLOCK_MONOTONIC)

lines = image
(0 .. 1).step 0.01 do |i|
  lines = lines.draw_line 255, lines.width * i, 0, 0, lines.height * (1 - i)
end

ending = Process.clock_gettime(Process::CLOCK_MONOTONIC)
puts "non-destructive took #{ending - starting}s"

starting = Process.clock_gettime(Process::CLOCK_MONOTONIC)

lines = image
lines = lines.mutate do |x|
  (0 .. 1).step 0.01 do |i|
    x.draw_line! 255, x.width * i, 0, 0, x.height * (1 - i)
  end
end

ending = Process.clock_gettime(Process::CLOCK_MONOTONIC)
puts "mutate took #{ending - starting}s"

lines.write_to_file ARGV[1]

I see:
$ ./mutate.rb ~/pics/k2.jpg x.jpg
non-destructive took 0.5115553569994518s
mutate took 0.14628159700077958s

With a huge drop in memory use too, of course, since it saves making 100 copies of the image.

OK, merged to master for 2.0.18.

Pushed as 2.1 https://libvips.github.io/libvips/2021/03/08/ruby-vips-mutate.html

This was just landed in NetVips with commit https://github.com/kleisauke/net-vips/commit/89f374947656cebca0240439bd9d55a94fb04074.

Oh nice! And the syntax is even OK. Good job Kleis!


Installed in OCI Workspace with another App, want to use other App application based authentication

Have a single OCI Workspace with an existing App using application-based authentication.  Installed Polling App in same workspace, different schema than existing App.  Turned on Workspace Sharing in both App Shared Components App Authentication.  Added a button in orig App to redirect to Polling App to test, but errors and says: "You are not authorized to view this application, either because you have not been granted access, or your account has been locked. Please contact the application administrator.
Access denied by Application security check".  Also, do not want to break ability to e-mail links to polls.
Suggestions please.  (And, thanks for the Polling App, a big help)
Thanks

h


Removing NotNullAttribute

Farewell!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

You won't be missed!  (Except by @davidfowl :trollface:)

:cry: it'll be back


Make default number of shards configurable

The default number of primary shards for a new index, when the number of shards are not provided in the request, can be configured for the cluster.
Signed-off-by: Arunabh Singh<EMAIL_ADDRESS>Description
Adding a way to modify the default number of shards for indices whose creation requests do not have the number of shards setting explicitly provided. This will be useful in cases where for such indices the cluster manager wants to have a default value other than the hardcoded value of 1 shard. Assumption is that most of the users will not need to modify this property but adding it as an option for cloud providers and for cases where most create requests don’t provide the number of shards explicitly.
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

LGTM. This new setting should be documented somewhere in product documentation, alongside existing settings. Since we don't have that available at present, could we open an issue (with docs tag) to add this later?

start gradle check

LGTM. This new setting should be documented somewhere in product documentation, alongside existing settings. Since we don't have that available at present, could we open an issue (with docs tag) to add this later?

Yes, please open an issue to update the documentation.

Issue tracking documentation for this change - https://github.com/opensearch-project/OpenSearch/issues/660. @arunabh23

LGTM. This new setting should be documented somewhere in product documentation, alongside existing settings. Since we don't have that available at present, could we open an issue (with docs tag) to add this later?

Thanks for opening the issue.

Hey @arunabh23, by default the main merges are part of OpenSearch 2.0 release. If you want this in 1.0 release, you'll need to raise a backport PR to 1.x. If you don't have a github issue already for this PR, I would suggest creating one. I can tag it with backport label, and then you can raise a backport PR against it.


Unable to Set Suite Variable with String Starting with @ & $

My company has a Robot Test that generates a random string consisting of alphabetical, numerical or symbolic characters and sets it as a suite variable. It appears that using a string starting with '@', '&' or '$' and setting as a suite variable breaks RF4.1.3.
Consider the sample test below (test.robot):
*** Test Cases ***
Set Suite Variable Starting with Alphabetical
    [Documentation]  Passes
    ${var} =  Set Variable  test
    Set Suite Variable  ${var}

Set Suite Variable Starting with Numerical
    [Documentation]  Passes
    ${var} =  Set Variable  123test
    Set Suite Variable  ${var}

Set Suite Variable Starting with Symbol
    [Documentation]  Passes
    ${var} =  Set Variable  ,test
    Set Suite Variable  ${var}

Set Suite Variable Starting with '$' (Built-in Var Syntax)
    [Documentation]  Fails
    ${var} =  Set Variable  $test
    Set Suite Variable  ${var}

Set Suite Variable Starting with '@' (Built-in List Syntax)
    [Documentation]  Fails
    ${var} =  Set Variable  @test
    Set Suite Variable  ${var}

Set Suite Variable Starting with '&' (Built-in Dict Syntax)
    [Documentation]  Fails
    ${var} =  Set Variable  &test
    Set Suite Variable  ${var}

All failures cases occur at Set Suite Variable and have the following error string:
Variable '${test}' not found. Did you mean:
    ${TEST_TAGS}
    ${TEST_NAME}

@rmccarth-bosch, Can you please try within single quotes or double quotes as  "$", "@", and "&" are built-in keywords,

Hi @hello2ray, I am aware of that syntax already but the problem is that it will literally include the single or double quotes in the string variable. I updated the test cases and the resulting test 'passed' but now has the extra " or ' contained in the variable value. "$", "@" or "&" should also need braces {<some value>} after the built-in start as well. I would expect Robot to be smart enough to recognize the '$', '@' or '&' to be used as a string and not the built-in use in this case. For laughs, I tried escaped- syntax and I got the same failure as originally described.

@rmccarth-bosch, anything starts with "$", "@" and "&", Robot Framework will consider as variable. Single Quotes or Double Quotes is only option.
FYI..
escaped-syntax is for
NOTE: If the variable has value which itself is a variable (escaped
or not), you must always use the escaped format to set the variable:

@hello2ray Thanks for the further explanation but can you please point me to where in the Documentation this is described explicitly? Robot Framework enforces the user to use "" or '' but in the process ends up changing the value of the string -- this does not seem right.  In this case, it's as simple as "$test" != $test.  If I wanted to use value for variable test, it would simply be ${test}. String for dollar sign plus test would be $test. There are other work arounds for when a user intends to run a keyword vs string.  Like, Run Keyword If or Run Keyword and Continue on Failure. I don't think this is intended, hence why all $, @, & all require the use of braces.

The problem is that when you use, for example, Set Suite Variable  ${x}  Value Robot cannot know do you want to set variable ${x} or does the variable ${x} contain the name of the variable you actually want to set. It tries to be clever and does the following:

Checks does variable ${x} exist. If not, you clearly want to create it.
If it exists, it checks its value. If the value isn't itself a variable, you apparently want to set ${x} again so that the new value overrides the old one.
If variable ${x} exists and its value is a variable, Robot sets that variable and ${x} isn't affected.

Because there can be such surprises, Set Suite Variable accepts the variable to set in a special format without {} decoration. This means that if you use Set Suite Variable  $x  Value, it knows you want to set variable ${x}. That's handy, but it unfortunately makes the above algorithm to check how to handle a variable specified like ${x} even more error prone. In the step 3. when it checks is the value of ${x} a variable, it considers it a variable both if it uses format ${y} and format $y.
In one of your example you had this:
    ${var} =  Set Variable  $test
    Set Suite Variable  ${var}

This is how the above is interpreted:

${var} is created with value $test.
Set Suite Variable is used with variable name ${var}.
Robot sees that ${var} has value $test and assumes you want to create variable ${test}.
Set Suite Variable doesn't get variable value, so Robot assumes you want to use the existing value of the variable ${test}.
${test} variable doesn't exist.

To test this, you can chance the above to
    ${var} =  Set Variable  $test
    Set Suite Variable  ${var}  value
    Log many    ${test}    ${var}

and you'll see that ${test} variable now has value value and ${var} still contains $test.
As you probably have already realized, a way to avoid these problems is using Set Suite Variable with the $var syntax unless you actually want to pass in the variable to set as a variable. In other words, changing your example to
    ${var} =  Set Variable  $test
    Set Suite Variable  $var

ought to solve the problem for good.

This functionality definitely works strangely and you aren't the first one to have problems with it. See #3233 for another example. This stuff is explained in the documentation of [Set Suite Variable](file:///home/peke/Devel/robotframework/doc/libraries/BuiltIn.html#Set%20Suite%20Variable), but perhaps docs should be changed to make it more clear that $name syntax, not ${name}, should typically be used.
We could also consider enforcing using $name and allow ${name} only when that variable exists and contains a variable name to actually set. Set Suite Variable and its variables Set Test/Global/Local Variable are used so much that outright changing the behavior would not be a good idea and a deprecation period would be needed. I'm not sure should we even emit a deprecation warning in the beginning. It would probably be safest to first update documentation to tell $name should be used and to mention this in release notes. Then in some later release we could start emitting those deprecation warnings and even later we could really enforce $name syntax. In the comments of #3233 I wrote that I don't think this is worth the effort, but I'm starting to change my mind.

@pekkaklarck Wow! Thank you for the very thorough explanation of how this works. I did not realize the complex nature that  existed within Set <Level> Variable. I would be a fan of your second comment's path forward and agree a good starting place would be updating the documentation and slowly enforcing the ${name} syntax only when the var exists.
Even in your ought to solve the problem for good case, I still have one small problem...
Typically, the first character in the string for Set Suite Variable will be an otherwise valid string, integer or symbol not @ & $. The start of @ $ & is an edge case, so I cannot just do this generically every time. This complicates things because in my actual test code, a keyword is responsible for generating the random string. I was trying to work around this with all built-in functionality. A quick helper to not allow @ $ & for randomly generated strings will work for me for now, not sure if you had any other ideas...

If you use pattern
    ${var} =  Set Variable  <text>
    Set Suite Variable  $var

it shouldn't matter that <text> contains. The key is using $var, not ${var}, with Set Suite Variable.
I'll leave this issue open as a reminder to at least updated documentation of Set Suite Variable to explain this a bit more thoroughly and to recommend using the $name format.

Need to still think should we really deprecate using ${name} format. If yes, this issue needs to get deprecation label so that we remember to mention that in the release notes. As I wrote earlier, we shouldn't emit actual deprecation warnings in RF 5.0 yet anyway.

Decided not to deprecate the normal ${name} syntax because it would require changes to so many tests. Instead the $name syntax is now recommended strongly in documentation. If we come up with nice syntax to create local variables (#3761) that can also be extended to other scopes, possibly we can then very slowly deprecate and remove these keywords altogether.


Conflicting setup requirement with standard library for Python 3.7 / 3.8

This library supports an integration in Home Assistant.
One or more of the requirements of this library (see below) conflicts with one or more standard library modules for Python 3.7 and/or 3.8.
To avoid issues it would be good if this library would remove these conflicting requirements from your library setup requirements or use a condition to only install the requirements when using a lower Python version.
If a setup.py file is used it means updating the install_requires list and removing or updating the conflicting requirements.

See this blog for how to use a condition in install_requires: https://hynek.me/articles/conditional-python-dependencies/

Found conflicts:

datetime

Thanks for your support of Home Assistant!

Will be fixed in a future release that addresses this and other problems.


Spillover from search ticket

Things that would be useful to add to the search method:

[x] Return numAssets

[x] Investigate why domain filters are returning things that don't have the domain set - can we control this? We can pass an addition filter for hasXXX

[x] Add a method to get facets separately to the searchAcrossEntityCall. We need to know the domain URNs in order to pass the filters to the search call. If the URL query parameters contain only the labels then we will need to perform a lookup by label. This also gives us the option to show all possible options even when a filter is applied that excludes some of them.

[x] The response object should make it easier to lookup facet labels by value or vice versa

[ ] There is no search highlighting yet - how do we pass this back? The default app does this client side, using react-highlight, so we would also need to this on the client side.

[x] We need to be able to filter by ID. (Fixed by passing urn as the filter name)

[ ] When searching for a data product by name, all the datasets within it rank higher than the actual data product. We would expect this to be the top ranked result. My best guess is that datasets have more fields, and each match with the search terms increases the score of a result. We could avoid this by separating the data product and dataset queries into two queries, and mixing them on the frontend so that data products go at the top. Alternatively, we could try and customise the scoring to boost results based on _entityType = 'DataProduct'.

Note: we are currently using the deprecated filters parameter rather than the more expressive orFilters parameter
We should fix this

The domains filter does not return null domains
Example query on demo instance
{
  searchAcrossEntities(
    input: {
      types: [DATASET],
      query: "*",
      start: 0,
      count: 10,
			orFilters: [
        {and: [{field:"domains", values: ["urn:li:domain:7d64d0fa-66c3-445c-83db-3a324723daf8"]}]}
      ]
    }) {
    start
    count
    total
    searchResults {
      entity {
        urn
        ... on Dataset {
          domain {
            associatedUrn
          }
        }
      }
    }
  }
}

Will need to debug this further on our instance

How the backend of search works

graphql resolver https://github.com/datahub-project/datahub/blob/master/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/search/SearchAcrossEntitiesResolver.java calls an EntityClient
EntityClient calls a EntitySearchService https://github.com/datahub-project/datahub/blob/master/metadata-io/src/main/java/com/linkedin/metadata/client/JavaEntityClient.java#L321
ElasticsearchService calls ESSearchDAO https://github.com/datahub-project/datahub/blob/master/metadata-io/src/main/java/com/linkedin/metadata/search/elasticsearch/ElasticSearchService.java#L132
https://github.com/datahub-project/datahub/blob/master/metadata-io/src/main/java/com/linkedin/metadata/search/elasticsearch/query/ESSearchDAO.java uses a SearchRequestHandler to build the query
https://github.com/datahub-project/datahub/blob/master/metadata-io/src/main/java/com/linkedin/metadata/search/elasticsearch/query/request/SearchRequestHandler.java
SearchRequestHandler uses SearchQueryBuilder https://github.com/datahub-project/datahub/blob/master/metadata-io/src/main/java/com/linkedin/metadata/search/elasticsearch/query/request/SearchQueryBuilder.java#L60
This uses the opensearch library directly (e.g. QueryBuilder, QueryBuilders) as well as https://github.com/datahub-project/datahub/blob/master/metadata-io/src/main/java/com/linkedin/metadata/search/utils/ESUtils.java

Observations:

Soft deleted entities are excluded by default. This can be overriden by including filters for the "removed" field
We get different behaviour if we prefix our query string with "\\/q " (structured queries)

If we want to tweak the ranking, we can customise the elasticsearch query like this
https://datahubproject.io/docs/how/search/#example-3-exclusion--bury

Search highlighting in the react app uses react-highlight
import Highlight from 'react-highlighter';

const StyledHighlight = styled(Highlight).attrs((props) => ({
    matchStyle: { background: props.theme.styles['highlight-color'] },
}))``;

        <>
            {enableNameHighlight && hasMatchedField ? (
                <StyledHighlight search={hasSubstring ? normalizedSearchQuery : pattern}>{text}</StyledHighlight>
            ) : (
                text
            )}
        </>


[Bugfix] Handle best_of>1 case by disabling multi-step speculation.

This PR addresses #7968 by disabling multi-step speculation when best_of>1 is enabled; this is the same approach as was taken in #6138 which disabled speculation for best_of>1. This prevents requests with best_of>1 from failing with an unhandled exception, as is the current case.
FIX #7968 (link existing issues this PR will resolve)
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Adding or changing kernels
Each custom kernel needs a schema and one or more implementations to be registered with PyTorch.

Make sure custom ops are registered following PyTorch guidelines: Custom C++ and CUDA Operators and The Custom Operators Manual
Custom operations that return Tensors require meta-functions. Meta-functions should be implemented and registered in python so that dynamic dims can be handled automatically. See above documents for a description of meta-functions.
Use torch.libary.opcheck() to test the function registration and meta-function for any registered ops.  See tests/kernels for examples.
When changing the C++ signature of an existing op, the schema must be updated to reflect the changes.
If a new custom type is needed, see the following document: Custom Class Support in PT2.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

I understand the approach but get a bit confused about the code changes. Specifically how the "disabling multi-step when n>1" handled in this PR? Seems like this PR only raises an exception?

Apologies @comaniac forgot to mark this as draft

As discussed in
https://github.com/vllm-project/vllm/issues/7968
I think we want to have some way to prevent n>1 from crashing the server without having to disable multi-step entirely, given that in principle vLLM still supports n>1 (until the major release that redoes the whole architecture of vLLM.) @robertgshaw2-neuralmagic  has been interested in having me land this n>1 single-step fallback PR.

Hi @njhill can you please point to the PR or other information about the workstream which would move best_of outside of the engine?

@afeldman-nm this is the one I was thinking of, from @youkaichao: https://github.com/vllm-project/vllm/pull/9302


🌱 remove API export reference from API binding status, make API export reference in API binding immutable

Summary
This is WIP, checking e2e tests.
I am adding more text to make e2e really happy, also this will fix some things, like API export immutability.
Let's see if this is enough to make the bots happy.
Related issue(s)
Fixes https://github.com/kcp-dev/kcp/issues/2051

/lgtm
/approve


Windows Support

Have you looked into mklink
C:\>mklink /?
Creates a symbolic link.

MKLINK [[/D] | [/H] | [/J]] Link Target

        /D      Creates a directory symbolic link.  Default is a file
                symbolic link.
        /H      Creates a hard link instead of a symbolic link.
        /J      Creates a Directory Junction.
        Link    Specifies the new symbolic link name.
        Target  Specifies the path (relative or absolute) that the new link
                refers to.

or New-SymLink for the symlinking?


[Feat]: Closing the menu after clicking outside the menu

What feature?
It would be a better UI experience if a user suppose clicks outside the menu bar once opened and then the menu closes.
Add screenshots

Code of Conduct

[X] I agree to follow this project's Code of Conduct

That would be good. Do you want to work on this @AbhayaShankar

Yeah, @JasonDsouza212 I will add this feature. No issue 👍


Neo 2.0

[x] Cleaner releases
[x] Github CI
[x] Fix tests
[x] Fix a race in flag submission (#6)
[x] Fix unnecessary checks for binary exploits (#7)
[x] Support for per-sploit timeouts (#8)
[x] Support for "endless" sploits (#8)
[x] Option to run exploit once (#9)
[x] Run exploits ASAP (w/o waiting for the first tick)
[x] Run a command on all clients (e.g. install a missing requirement)

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@37244cd). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #10   +/-   ##
=========================================
  Coverage          ?   45.11%
=========================================
  Files             ?       19
  Lines             ?      931
  Branches          ?        0
=========================================
  Hits              ?      420
  Misses            ?      474
  Partials          ?       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37244cd...850ea39. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@37244cd). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #10   +/-   ##
=========================================
  Coverage          ?   49.40%
=========================================
  Files             ?       19
  Lines             ?      929
  Branches          ?        0
=========================================
  Hits              ?      459
  Misses            ?      430
  Partials          ?       40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37244cd...fb5065a. Read the comment docs.


Ahoy captain not recognizing data or failing to initialize

Hi I have a rails 7 esbuild app and am trying to get it to work with ahoy_captain. When I visit /ahoy_captain, I do not get any results:

I also get this error and other warnings in the console:

I followed the installation instructions to the tee (although, rails g ahoy_captain:migration does not work).
I also checked that ahoy_visits table has data
Any help is appreciated!

What happens if you select a period like year-to-date? What happens if you try to fetch the data using ActiveRecord based on the queries its reporting?
http://localhost:3000/ahoy_captain?period=ytd should get you there quick.

Same results come up. Here are the logs for it:
17:24:03 web.1  | Processing by AhoyCaptain::Stats::UniqueVisitorsController#index as HTML
17:24:03 web.1  |   Parameters: {"period"=>"ytd"}
17:24:03 web.1  |   Ahoy::Visit Count (0.9ms)  SELECT COUNT(DISTINCT "ahoy_visits"."id") AS "count_id", DATE_TRUNC('day', "ahoy_visits"."started_at"::timestamptz AT TIME ZONE 'Etc/UTC')::date AS "date_trunc_day_ahoy_visits_started_at_timestamptz_at_time_zone_" FROM "ahoy_visits" LEFT OUTER JOIN "ahoy_events" ON "ahoy_events"."visit_id" = "ahoy_visits"."id" WHERE ("ahoy_visits"."started_at" > '2023-01-01 00:00:00' AND "ahoy_visits"."started_at" < '2023-08-03 21:24:03.807444' AND "ahoy_events"."time" > '2023-01-01 00:00:00' AND "ahoy_events"."time" < '2023-08-03 21:24:03.807502') AND ("ahoy_visits"."started_at" IS NOT NULL) GROUP BY DATE_TRUNC('day', "ahoy_visits"."started_at"::timestamptz AT TIME ZONE 'Etc/UTC')::date /*application:Blens,controller:unique_visitors,action:index*/
17:24:03 web.1  |   Rendering layout ...
17:24:03 web.1  |   Rendering ...
17:24:03 web.1  |   Rendered .... (Duration: 0.2ms | Allocations: 119)
17:24:03 web.1  |   Rendered layout .... (Duration: 58.9ms | Allocations: 50800)
17:24:03 web.1  | Completed 200 OK in 66ms (Views: 59.5ms | ActiveRecord: 0.9ms | Allocations: 54561)
17:24:03 web.1  |

When I try the query using Active Record I actually get no results as well. I think its because of my ahoy_events table is empty. So i guess I need to track events as well. Thought it could work with visits only.
Removing the left outer join of ahoy_events does return results though...
SELECT COUNT(DISTINCT "ahoy_visits"."id") AS "count_id",
         DATE_TRUNC('day', "ahoy_visits"."started_at"::timestamptz AT TIME ZONE 'Etc/UTC')::date
       AS "date_trunc_day_ahoy_visits_started_at_timestamptz_at_time_zone_"
FROM "ahoy_visits"
WHERE ("ahoy_visits"."started_at" > '2023-01-01 00:00:00'
        AND "ahoy_visits"."started_at" < '2023-08-03 21:24:03.807444'
        AND "ahoy_visits"."started_at" IS NOT NULL
       )
GROUP BY DATE_TRUNC('day', "ahoy_visits"."started_at"::timestamptz AT TIME ZONE 'Etc/UTC')

While with ahoy_events return 0 results
SELECT COUNT(DISTINCT "ahoy_visits"."id") AS "count_id",
       DATE_TRUNC('day', "ahoy_visits"."started_at"::timestamptz AT TIME ZONE 'Etc/UTC')::date AS "date_trunc_day_ahoy_visits_started_at_timestamptz_at_time_zone_"
FROM "ahoy_visits" LEFT OUTER JOIN "ahoy_events"
ON "ahoy_events"."visit_id" = "ahoy_visits"."id"
WHERE ("ahoy_visits"."started_at" > '2023-01-01 00:00:00' AND "ahoy_visits"."started_at" < '2023-08-03 21:24:03.807444'
    AND "ahoy_events"."time" > '2023-01-01 00:00:00'
    AND "ahoy_events"."time" < '2023-08-03 21:24:03.807502')
    AND ("ahoy_visits"."started_at" IS NOT NULL)
GROUP BY DATE_TRUNC('day', "ahoy_visits"."started_at"::timestamptz AT TIME ZONE 'Etc/UTC')

What are my paths forward?

Same thing happened to me. I just pointed the gem to the main branch (since there was no release yesterday) and it's fixed there. Try the 0.8 release and see if it goes away.

Yes that helped, thanks so much. Still get the NaN as well

@oyenmwen should be fixed in 0.81 which was just released.
there's a fix for queries coming up here shortly. just need to figure out why some are misbehaving.

@oyenmwen give 0.82 a try. lots of query fixes.

I'm not getting data on 0.83, yet I do when I'm on 0.8.
I have only tested in localhost, though I don't see any code that filters that.
0.8

Query
23:00:03 web.1             | Started GET "/ahoy_captain/stats/unique_visitors?period=all" for <IP_ADDRESS> at 2023-08-07 23:00:03 -0700
23:00:03 web.1             | Processing by AhoyCaptain::Stats::UniqueVisitorsController#index as HTML
23:00:03 web.1             |   Parameters: {"period"=>"all"}
23:00:03 web.1             |   Ahoy::Visit Count (1.2ms)  SELECT COUNT(DISTINCT "ahoy_visits"."visitor_token") AS "count_visitor_token", DATE_TRUNC('month', "ahoy_visits"."started_at"::timestamptz AT TIME ZONE 'Etc/UTC')::date AS "date_trunc_month_ahoy_visits_started_at_timestamptz_at_time_zon" FROM "ahoy_visits" LEFT OUTER JOIN "ahoy_events" ON "ahoy_events"."visit_id" = "ahoy_visits"."id" WHERE (("ahoy_visits"."started_at" > '2004-08-01 00:00:00' AND "ahoy_visits"."started_at" < '2023-08-08 06:00:03.948980') OR ("ahoy_events"."time" > '2004-08-01 00:00:00' AND "ahoy_events"."time" < '2023-08-08 06:00:03.949274')) AND ("ahoy_visits"."started_at" IS NOT NULL) GROUP BY DATE_TRUNC('month', "ahoy_visits"."started_at"::timestamptz AT TIME ZONE 'Etc/UTC')::date

0.83

Query
23:02:43 web.1             | Started GET "/ahoy_captain/?period=all" for <IP_ADDRESS> at 2023-08-07 23:02:43 -0700
23:02:43 web.1             | Processing by AhoyCaptain::Stats::UniqueVisitorsController#index as HTML
23:02:43 web.1             |   Parameters: {"period"=>"all"}
23:02:43 web.1             |   Ahoy::Visit Count (0.8ms)  SELECT COUNT(DISTINCT "ahoy_visits"."visitor_token") AS "count_visitor_token", DATE_TRUNC('month', "ahoy_visits"."started_at"::timestamptz AT TIME ZONE 'Etc/UTC')::date AS "date_trunc_month_ahoy_visits_started_at_timestamptz_at_time_zon" FROM "ahoy_visits" LEFT OUTER JOIN "ahoy_events" ON "ahoy_events"."visit_id" = "ahoy_visits"."id" WHERE ("ahoy_visits"."started_at" > '2004-08-01 00:00:00' AND "ahoy_visits"."started_at" < '2023-08-08 06:02:43.956371') AND ("ahoy_events"."time" > '2004-08-01 00:00:00' AND "ahoy_events"."time" < '2023-08-08 06:02:43.956679') AND ("ahoy_visits"."started_at" IS NOT NULL) GROUP BY DATE_TRUNC('month', "ahoy_visits"."started_at"::timestamptz AT TIME ZONE 'Etc/UTC')::date

Are your page view events setup correctly?

@joshmn Thanks for your response, no I don't have page view events set up since there was no mention of that on the ahoy repo or the ahoy_captain one. I now see that https://github.com/joshmn/ahoy_captain/commit/e7ad0c60ba1902d9ab0ba514e02097e21bb4e360 added clarification, however, I think this is not clear:

By default, AhoyCaptain assumes you're tracking controller and action in your Ahoy::Event properties, and a page view event is named $view.

I assumed it means ahoy_captain expect us to track all actions like this section in the ahoy readme does. Something like:
class ApplicationController < ActionController::Base
  after_action :track_page_view

  protected

  def track_page_view
    ahoy.track "$view", controller: controller_name, action: action_name, url: request.url, params: request.path_parameters
  end
end

If so, it'd probably be good to add the above snippet to the README, or inject it via a generator. In addition, these configs should probably be enabled by default, in order to provide good, batteries included defaults:
config.event.url_column = "properties->>'url'"
config.event.url_exists = "JSONB_EXISTS(properties, 'controller') AND JSONB_EXISTS(properties, 'action')"

I tested the above and it works great!

@davidalejandroaguilar how's this? https://github.com/joshmn/ahoy_captain/commit/f8246fcc8520088d9d495e310c134331d31cf455 :)

That works, thank you very much for your time in both responding and building this gem 😺

So my problem was that I wasnt tracking actions with ahoy events. Worked once i added that. Thanks!


Building from source requires a compiler specifically named g++-7

At least with EU4-to-Vic2, the makefile generated by CMake relies on the presence of the specific executable g++-7, and will fail to do anything if it's not present, even if there is a GCC 7.x compiler installed. There is no option to override via the CC/CXX environment variables, only by manually editing CMakeLists.txt
Given that CMake will automatically find the system's C++ compiler and it's version, can't you use that information instead of always using this specific name?

That was my attempt to force  it to use a C++17 supporting compiler on Ubuntu on Windows an Jenkins. If you know what I need to do to make it work properly, I'll happily implement it. I'm just not very experienced with CMake, is all.

I'd be willing to look into this if allowed. CMake best practices are, in my experience, a contentious issue at best (the documentation doesn't really provide much pointers in this regard) so feel free to reject the proposal if you feel it is not appropriate for the project.
The issue, if I understand it correctly, is that the compiler (in this is case a g++ v7 compiler) is  specified in the build file (CMakeLists.txt). I would argue that the build file should not attempt to find an appropriate compiler but simply test whether the supplied toolchain can compile and link the project, giving a verbose error if it fails. I propose doing the following:

Split out the logic of selecting the toolchain into a separate file (e.g. "Toolchain.cmake") that is not put into version control (because it is specific to each environment). In this file you can then specify the compiler and linker. Note that this is not necessary if the default compiler on the build system is suitable.  E.g. I replaced the default compiler on my OS by a newer version I compiled from source and would not need to create a toolchain file because it supports c++ 17. To make this easy for people unused to CMake I propose to add a few example toolchain files in version control, together with some documentation on how to modify/use them. Users who want to use another compiler than the standard one on their system (including the CI build) will then need to call cmake with the "-DCMAKE_TOOLCHAIN_FILE=/path/to/my/personal/toolchainfile" option which will, in turn, point it to the correct compiler and linker. See here for an unhelpfully short description of the variable.

Add a series of tests to the CMakeList.txt to check whether the compiler has the required capabilities, e.g. basic C++17 support or support for specific language features ("constexpr", "override", ...). If the compiler fails this test a useful error message should be printed, describing what is missing and how a toolchain file can be used to select a different, hopefully more capable, compiler.

The same applies to the standard library used: if the code uses, for example, "std::optional", a test could be added to test whether this template is available. This could be done using a "try_compile" cmake command to compile small test programs that use the standard library symbol in question. If the test program does not compile, the script can once again warn the user that there is a problem and point to a solution.
IMHO it's not necessary to bother developers to keep this list of tests up to date: every added feature or build test is a bonus but it is not required. If it is reported that people have problems compiling due to a newly introduced dependency on an experimental c++ feature, further tests can be added easily.

To make it easy to re-use the tests and avoid cluttering the several projects CMake files, I would propose adding them either as CMake modules or functions, located in a separate folder, only to be loaded/called by those build files that use them.

If this proposal (or part of it) is acceptable, I'll set up a Jenkins CI build on my machine and start gradually implementing this for one project in my forked repository. If you have objections or a different solution, feel free to point them out and I'll try to implement them.

That sounds reasonable to me! Thanks for looking into it.

Just a quick question: what version of the GCC are you using (I assume the 7 or 8 branch) ?
I added some CMake macros to test a few c++ 14/17 standard library features and appropriate error  messages but want to make sure they compile correctly against a specific minimum compiler version.
Also, looking at the CMake 3.5 documentation there is no build-in compiler-agnostic way to force c++17 standard compliance (only available in CMake 3.8), so I'll have to write a simple macro for that as well.

It looks like I built g++ 7.1.0 and haven't updated it since.
It also seems that when I created the organization I messed up travis-ci.org's ability to actually do the CI stuff, which is a pain.


[BUG] Missing cursors on XFCE4

There are some missing cursors on XFCE4:

Missing cursors when manipulating desktop icons.
Missing loading cursor when opening program instances.
Using single direction resize cursors when resizing windows diagonally.

Here are the fixes to be done under the src/symlinks directory:

Add symlink from "progress" to "08e8e1c95fe2fc01f976f1e063a24ccd".
Add symlink from "link" to "dnd-link".
Add symlink from "grabbing" to "dnd-move".
Replace the origin of symlinks "n-resize" and "top_side" by "sb_up_arrow".
Replace the origin of symlinks "s-resize" and "bottom_side" by "sb_down_arrow".
Replace the origin of symlinks "w-resize" and "left_side" by "sb_left_arrow".
Replace the origin of symlinks "e-resize" and "right_side" by "sb_right_arrow".

If you are interested in solving this issue, ask to be assigned.

I am going to handle this.

Fix is now available on the upstream branch.


decimal_places shouldn't be applied to amount

Pair's decimal_places are really about rate. Amount, as long as it's greater than the minimum, can have up to 8 decimal places regardless the pair and currency (at least in Trade method parameter and result set, but I suspect it applies everywhere). Enforcing 8 decimal places in parameter values ARE important, 9 or more places are rejected.
I failed to find a reference to 8-digit amount precision in the documentation -- maybe some other libraries have it, as there are obviously many bots buying and selling amounts like 0.01003882 BTC.
Looking at the code, I'd suggest that format_currency should be split in format_rate and format_amount (the latter doesn't really need pair information, so it's unclear in what class should in be defined). For existing code calling format_currency, it should probably be treated like format_rate to be on the safe side. Maybe I'll have some time to prepare a complete patch.

Thank you for reporting this, if you don't get time to write up a patch soon I'll see if I can address it.  Sorry for taking so long to respond--free time has been scarce lately!


EasyPost Issues once again

Website slowed way down again. Rebooted server and cleared my cache and got the EasyPost error about the required index thing again. Tried to delete the EasyPost shipping methods and get:
Property Concrete\Package\CommunityStoreEasypost\Src\CommunityStore\Shipping\Method\Types\EasypostShippingMethod::$id does not exist
So I decided enough of EasyPost and I cannot uninstall it.
Same error
Property Concrete\Package\CommunityStoreEasypost\Src\CommunityStore\Shipping\Method\Types\EasypostShippingMethod::$id does not exist
I assume you still can log in? You might still have cpanel login too? If not I'll send them to you if you're willing to look.
On Chrome the site is completely broken, but with Edge I can navigate the site, but cannot check out.

If you're able to completely remove EasyPost I'd prefer that.

Just noticed
Tried to enable a flat rate shipping method:
No identifier/primary key specified for Entity "Concrete\Package\CommunityStore\Src\CommunityStore\Shipping\Method\Types\FlatRateShippingMethod" sub class of "Concrete\Package\CommunityStore\Src\CommunityStore\Shipping\Method\ShippingMethodTypeMethod". Every Entity must have an identifier/primary key.
This was the error I always got from EasyPost, never affected the other methods.

Just taking a quick look now - site is coming up fine for me in Chrome, and I can add things to the cart and progress through the checkout.
The site does seem painfully slow at times though, at places where I wouldn't expect it to.
I'm wondering if the server is simply overloaded here, and the issues you are seeing are more to do with it timing out, rather than actual issues with Easypost.

I think it is server overload. But what's causing it?
I cannot edit any shipping method or add any either.
We talked about upgrading my shopping cart to the latest version before, you think that might clean things up? If so, email me.

We can certainly look at upgrading the site, but I'm pretty sure that it won't resolve the slowdowns.
It's more likely to be something like the sitemap being large, and then the autonav struggling to fetch all the pages it needs to to output the nav. And that processing might be maxing out what the server is prepared to allocate CPU wise to your site, and effectively limits everything. And the more product pages you've added over time, the worse it's become.
So you might require some site optimisations, rather than upgrades. There is an add-on that can help analyse such issues I believe.  I'm unlikely to have time tomorrow to email about this, but I can touch base early next week - if I'm not available to help, others might be able to offer their services too.

Yes, the sitemap added over a second to the load time, so I copied the HTML and put it in a HTML block.
So, I would like you to quote the optimization and the upgrade when you can. Early next week would be fine.
But to prove your point though, I just rebooted and cleared cache and it seems the issues have resolved, though I did it 2 times earlier with no luck.
Check out still seems to be extremely slow.


fix build errors for ODROID

added some source codes with using definition ODROID.
"/usr/lib/aarch64-linux-gnu/libMali.so" in the ODROID N2

I'm truly sorry but what you did is a very bad way to do things.
Adding a new definition is not the good way to do that.
Removing #ifdef RPI for the #include is the good one.
In my recent commit, I have just fixed these two mistakes.

I'm truly sorry but what you did is a very bad way to do things.
Adding a new definition is not the good way to do that.
Removing #ifdef RPI for the #include is the good one.
In my recent commit, I have just fixed these two mistakes.

Thank you for the advice.
I look forward to your good activities ^^

Sorry to have rejected your PR, this was nice from you.
The version should build now on Odroid too.
Still, I'm interested in your korean translation. Can you do a PR with it ?

Sorry to have rejected your PR, this was nice from you.
The version should build now on Odroid too.
Still, I'm interested in your korean translation. Can you do a PR with it ?

I'm fine ^^
I'll try to RP as soon as possible.


Resolve clippy warnings

The GitHub workflow configuration uses cargo clippy -- -D warnings which disallows warning. Therefore the workflow tests don't succeed. This fixes the annotations and code clippy warns about.

Thank you so much! I've been meaning to get around to sorting this one out :)


Invoke Lambda function with Payload

Looking through the docs it doesn't look like the invoke method on the lambda client has an option to set a payload. Is this correct? If this is missing by mistake, I don't mind making the change myself.

The lambda example has the answer I'm looking for: https://github.com/awsdocs/aws-doc-sdk-examples/blob/master/cpp/example_code/lambda/lambda_example.cpp#L74


Check if max pairs limit reached in generate_pairs and generate_multilabel_pairs

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Hello!
Apologies for the delay.
I think this direction makes a lot of sense. I'm actually a bit surprised that I didn't think of this initially. Previously, if you set max_pairs to e.g. 20, you would often get e.g. 22 pairs or something - which is just very confusing/surprising. This only got worse the larger the discrepancy between classes.
I merged your changes with some other recent changes from this week (e.g. moving away from the InputExample class), and then I rewrote it all somewhat. I think the direction is a bit clearer now, while still being equivalent to what you wrote. If max_pairs is not set, then the pairs are also still sampled like normal. All good there.
Thanks for putting this together and bringing it to my attention!

Tom Aarsen


[QST]!NOT_FOUND  cannot run on GPU

What is your question?
Hi, I got an GPU warning while using Spark 3.0 with rapdis. This warning starts with the operation of dataframe.cache().
!NOT_FOUND <InMemoryTableScanExec> cannot run on GPU because no GPU enabled version of operator class org.apache.spark.sql.execution.columnar.InMemoryTableScanExec could be found
Most of my operations were based on Spark SQL. Specially, dataframe.cache() were applied for in-memory acceleration.  My question is that does this warning represent that it can not scan GPU in-memory data or datasets haven't been cached to GPU?

We are still working on optimizing cache and persist for the GPU see #11
Because of how the code works in spark it is going to require changes to spark to be able to even do things like optimizing the compression of the data using the GPU. Currently, this is being worked on as a part of https://github.com/apache/spark/pull/29067.  But even after those changes, it would not be enough to cache the data in GPU memory. We might be able to hack something together to make that work, but likely even further changes would be required to spark and the block manager to be able to do something like that.

@PerkzZheng is it Okay if I close this?

@revans2 Sure, thank you for your reply !


Strategy: Fix UST-MATIC LP

Vault was never test harvested, it also needs to be set to harvest on deposit.

I addressed both of these issues and have created a PR in beefy.app to add the new token and updated the corresponding pool in the frontend.

crashes without wormhole image.
obv we can't use WORMHOLE asset, its unrelated to UST.
not sure whats better UST or USTw, maybe USTw to differentiate 2 different tokens, so we would need to copy-paste UST image

changed to use UST image to fix crash. renamed LP to USTw-MATIC.

Resolve conflicts please

Resolve conflicts please

resolved.


support feature selector

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
1.Missing rate：
example: missing_series = self.data.isnull().sum() / self.data.shape[0]
2.Correlation coefficient:
example: data.corr()
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

The first one is supported in Mars.
We decided to implement df.corr() with the pearson method.


RxJS v6

RxJS v6 is currently in beta and comes with some breaking changes that effect jasmine-marbles.
Mostly some trivial module path updates.
eg. Observable now needs to be imported off rxjs instead of rxjs/Observable, and TestScheduler from rxjs/testing instead of rxjs/testing/TestScheduler.
RxJS v5 -> v6 upgrade guide: https://docs.google.com/document/d/12nlLt71VLKb-z3YaSGzUfx6mJbc34nsMXtByPUN35cg/preview

Fixed via #14

It would be great to have this documented in the README, to let people know that if they are still on RxJS v5  that they should use v0.2 of jasmine-marbles.


Invalid formula error - MacOS 12.0

⚠ Support requests in an issue-format will be closed immediately. For support, go to Swarm's Discord.
Context
OS: MacOS 12.0.1
Hardware: MacBook Pro (M1 Pro)
Brew version:  Homebrew 3.3.5
Homebrew/homebrew-core (git revision 47e6dc9e7fe; last commit 2021-11-23)
Summary

Started following instructions at : https://docs.ethswarm.org/docs/installation/install/
It begins with "brew tap ethersphere/tap", so I ran that command.
It ultimately fails with "Error: Cannot tap ethersphere/tap: invalid syntax in tap!"

Expected behavior
I was hoping to be able to move to the next instruction of actually installing swarm-clef.
Actual behavior
This is the actual output when I ran "brew tap ethersphere/tap"....
==> Homebrew is run entirely by unpaid volunteers. Please consider donating:
https://github.com/Homebrew/brew#donations
==> Auto-updated Homebrew!
Updated 1 tap (homebrew/core).
==> New Formulae
rizin
==> Updated Formulae
Updated 54 formulae.
Updating Homebrew...
==> Tapping ethersphere/tap
Cloning into '/opt/homebrew/Library/Taps/ethersphere/homebrew-tap'...
remote: Enumerating objects: 150, done.
remote: Counting objects: 100% (150/150), done.
remote: Compressing objects: 100% (149/149), done.
remote: Total 150 (delta 63), reused 3 (delta 0), pack-reused 0
Receiving objects: 100% (150/150), 20.84 KiB | 2.08 MiB/s, done.
Resolving deltas: 100% (63/63), done.
Error: Invalid formula: /opt/homebrew/Library/Taps/ethersphere/homebrew-tap/swarm-bee.rb
formulae require at least a URL
Warning: Calling bottle :unneeded is deprecated! There is no replacement.
Please report this issue to the ethersphere/tap tap (not Homebrew/brew or Homebrew/core):
/opt/homebrew/Library/Taps/ethersphere/homebrew-tap/swarm-clef.rb:9
Error: Invalid formula: /opt/homebrew/Library/Taps/ethersphere/homebrew-tap/swarm-clef.rb
formulae require at least a URL
Error: Cannot tap ethersphere/tap: invalid syntax in tap!
Steps to reproduce

Run "brew tap ethersphere/tap" in a terminal window.

Possible solution
None known.

Problem was because there was no arm64 candidate for swarm-clef fixed it now https://github.com/ethersphere/bee-clef/pull/58


On Prod-bed, 'Totals Nodes' counter is confusion

There are 70 yarn works, and 3 master, but the dashboard display total 74 nodes.

That's because there is one node <IP_ADDRESS> we didn't deploy any useful services at all, but it is still in the cluster, so we've deployed driver & node-exporter on it. See http://<IP_ADDRESS>/cluster-view/services.html
The total node is based on the data from node-exporter. Yarn can't cover the nodes which didn't deploy NM.

Yeah, that's my question: which should be the ground truth?
Yarn or node-exporter?


Update Fontsource tip to add @fontsource-variable scope

Description (required)

Since Variable Fonts in fontsource start with @fontsource-variable/, I thought it might be better to display It will start with @fontsource/ or @fontsource-variable/ followed by the name of the font. instead of the tip It will start with @fontsource/ followed by the name of the font.

Related issues & labels (optional)

Closes # #7981
Suggested label:

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉
Here’s what will happen next:

Our GitHub bots will run to check your changes.
If they spot any broken links you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean!

In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

en
guides/fonts.mdx
Source changed, localizations will be marked as outdated.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.