[MED PRI] Constraint solver that generates shrinkwrap.

Constraint solver that generates shrinkwrap.json.
Constraint solver that generates yarn lockfile (stretch goal, maybe not needed).

Description thanks to @andreypopp:
yarn/npm use a super naive dependency solver. This is somewhat acceptable for JS code but doesn't scale with OCaml ecosystem.
The problem is that with OCaml we have multiple compiler versions available (4.02, 4.03, 4.04, ...), npm will fail trying to solve dependency on a compiler (remember they get rid of enforcing "engine" field in package.json?).
Another problem is that sometimes we need more expressive dependency declarations, for example opam allows boolean formulas there — https://opam.ocaml.org/doc/Packaging.html#Moreonopamfiles — but we yet need to analyze how we should deal with that. Probably boolean formulas are to powerful and confusing for users.
Thea idea is to use CUDF based solver so that we don't need to write one and (hopefully) worry about their perf (as they are written in C and highly optimized). http://www.mancoosi.org/cudf/ Such tool would generate npm-shrinkwrap.json or yarn.lock so that installers could use them.
Bonus point fot this task: write OCaml, not JS


Sum metrics with the same hostname for Datadog Agent instead of selecting the only one

Describe what happened:
In my company we have between 10 - 60 instances with unique datadog agent hostnames.
It results in beautiful charts with big amount of visible data.
That big amount of instances is producing a big amount of unique custom metrics which we are charged for.
We've decided to lost possibility of more grained analysis and we've set the same hostname for all of Datadog Agents.
So we've lost the granularity and we wanted to  gain less amount of unique custom metrics which we are charged for. But the result was as it is described in here:
Note: When removing the host tag, you are removing a unique identifier for the submission of custom metrics. When two datapoints are submitted with the same timestamp/metric/tag combination and do not have unique identifiers, the last received/processed value overwrites the value stored. To avoid this edge case, ensure that no host is submitting the same exact metric/tag combination at any given timestamp.
So we've seen only metrics from 1 instance instead of from 60 instances.
Describe what you expected:
Datadog should not bill for host tag or it should be possible to send data with the same hostname - and this should be treated as the same agent, the metrics should be summed up.
Steps to reproduce the issue:
Start multiple Datadog Agents with the same hostname. Resulting count should be much lower than count for Datadog Agents with unique hostnames.

Distribution metrics type solves that issue - closing

@crisperit I have tested it on my side recently, seems Distribution metrics type has the same issue.


votelink (pda voting !!!)

About the PR

adds the VoteLink cartridge, a new app that lets you create polls and vote in them!
comes preinstalled on all PDAs
creating polls is restricted to command
5 minute cooldown, voting is predicted, timer updates separately, everything is in the code :godo:
Why / Balance

i thought it'd be cool
with each PR we're closer to PDA messaging
Media

Click me!

hiiiii

Given that it is intended to be a PDA cartridge, it may be better stylistically to not have popups. Instead change the contents of the PDA.

yes I hear that but I personally prefer doing popups for stuff like this mainly for accessibility reasons: PDAs have a locked size, but you can resize popups, open multiple at once
it's convenient for taking screenshots, takes less screen space than the entire PDA, etc etc


Command "Setup-BcContainerTestUsers" throws an error.

Describe the issue
The command "Setup-BcContainerTestUsers"  throws the following error:
Exception calling "DownloadFile" with "2" argument(s): "The remote server returned an error: (409) Conflict."
Public access is not permitted on this storage account.

From an Azure machine.
Docker BC version: public 24.2 US
BcContainerHelper version: 6.0.18
Scripts used to cause the issue
$defaultPassword = (ConvertTo-SecureString -String '########' -AsPlainText -Force);
$credential = New-Object pscredential '########', $defaultPassword
$containerName = "us242Cloud"

Setup-BcContainerTestUsers -containerName $containerName -Password $defaultPassword -credential $credential

Full output of script
Skipping app 'C:\Applications.US\Microsoft_Permissions Mock_24.2.20227.20579.app' as it is already installed
Skipping app 'C:\Applications.US\Microsoft_Test Runner_24.2.20227.20579.app' as it is already installed
Skipping app 'C:\Applications.US\Microsoft_Any_24.2.20227.20579.app' as it is already installed
Skipping app 'C:\Applications.US\Microsoft_Library Assert_24.2.20227.20579.app' as it is already installed
Skipping app 'C:\Applications.US\Microsoft_Permissions Mock_24.2.20227.20579.app' as it is already installed
Skipping app 'C:\Applications.US\Microsoft_Library Variable Storage_24.2.20227.20579.app' as it is already installed
TestToolkit successfully imported
Downloading C:\Users\administrador\AppData\Local\Temp\8\6465f440-5e98-47fd-9d01-5ff0bd787bd6\Microsoft_CreateTestUsers_<IP_ADDRESS>.app
Downloading using WebClient
Error downloading..., retrying in 5 seconds...
Downloading using WebClient
Publish-BcContainerApp Telemetry Correlation Id: 83ecab7f-fe29-463b-8279-bb2962d7b7f3
Setup-BcContainerTestUsers Telemetry Correlation Id: 6f4516d2-768f-44c4-8014-46e95ed7d45f
Exception calling "DownloadFile" with "2" argument(s): "The remote server returned an error: (409) Conflict."
Public access is not permitted on this storage account.
<?xml version="1.0" encoding="utf-8"?><Error>PublicAccessNotPermitted<Message>Public access is not
permitted on this storage account.
RequestId:433f70ab-001e-0059-13a4-bc1ab5000000
Time:2024-06-12T08:44:59.8941076Z</Message></Error>
At C:\Program Files\WindowsPowerShell\Modules\bccontainerhelper\6.0.11\Common\Download-File.ps1:110 char:17
+                 throw (GetExtendedErrorMessage $_)
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (Exception calli...essage></Error>:String) [], RuntimeException
    + FullyQualifiedErrorId : Exception calling "DownloadFile" with "2" argument(s): "The remote server returned an er
   ror: (409) Conflict."
Public access is not permitted on this storage account.
    <?xml version="1.0" encoding="utf-8"?><Error>PublicAccessNotPermitted<Message>Public access is not pe
   rmitted on this storage account.
RequestId:433f70ab-001e-0059-13a4-bc1ab5000000
Time:2024-06-12T08:44:59.8941076Z</Message></Error>

Additional context

The same error occurs on other colleagues' Azure machines.

Are we missing something?

Encountered the same issue on my local machine
Exception: C:\Program Files\WindowsPowerShell\Modules\BcContainerHelper\6.0.15\Common\Download-File.ps1:97:17
Line |
  97 |                  throw (GetExtendedErrorMessage $_)
     |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Exception calling "GetResult" with "0" argument(s): "Response status code does not indicate
     | success: 409 (Public access is not permitted on this storage account.)." Response status code does
     | not indicate success: 409 (Public access is not permitted on this storage account.).

This is fixed in 6.0.19 (currently in prerelease)


active:hover item has wrong text color since Bootstrap 4.4

With Bootstrap 4.4.1 the text color is black, using 4.3.1 is white.
https://jsfiddle.net/h5cz3ena/

Looks like this was introduced here 13b74165446dc0dac3bb09498e9a58e6b1416bfe (twbs/bootstrap#29140).

Confirmed to be an issue with Bootstrap. They merged a fix that will be available next release.


Error with installation

Dear,
I followed the installation steps on my Linux workstation.
When I run the command python setup.py install
This error showed up:
setuptools.extern.packaging.version.InvalidVersion: Invalid version: 'master'
Thanks in advance

Hello,
We've recently updated our system requirements to address this issue. To ensure compatibility, please make sure that your environment matches the updated requirements, specifically the CUDA version compatible with the latest version of PyTorch we are now using. Please feel free to reach out if you encounter any further issues or have any more questions.


trunk-combined channel hasn't updated for 17 days

tested job http://hydra.nixos.org/build/28002207#tabs-constituents

Failing tests:

[ ] gnome3 http://hydra.nixos.org/build/28002102
[x] kde http://hydra.nixos.org/build/28002228

cc @lethalman @wkennington @ttuegel

KDE4 tests were working for me on 3c397e8e. I posted before to #11097.

Ah, I haven't seen that.

If we used a bulletin board, we could pin Hydra failure threads at the top. It seems GitHub doesn't have that feature though.


⚠ Samsung has degraded performance

In d997535, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2700 ms

Resolved: Samsung performance has improved in 8378ba6.


Mitigate transaction timeout issues due to backgrounding and slow networks

Description
One of the most common errors we see in the verification flow at the moment is transaction timeout, which is added by the Valora app and currently specified to 45 seconds.
We have observed a number of cases where a transaction timeout will occur, and then the transaction will continue and be mined successfully not too long after. Looking at a number of these events, raising the timeout period would appear to increase the success rate of transactions, provided the user is willing to wait. (In cases where they do not want to wait, they may cancel the action they are taking and the transaction will not be monitored further.)
In this PR, the timeout is increased to 90s, which I have observed will handle most of the cases where the timeout triggers on transaction that eventually end up being mined. This should be a useful measure to increase transaction reliability until we can revisit the sending flow to incorporate additional improvements.
Other changes

Add some comments to the verifications flow.
Added a grace period to after initial transaction timeout to mitigate #5142.
Change view call for balance fetch to select from redux state to avoid expensive view call.
Log full transaction details in the GethNativeBridgeWallet to improve debugging in Sentry.

Tested
Tested on iOS simulator to confirm that without the changes, transaction report as timeout after being backgrounded for more than 90s. With the grace period, I observed that the timeout did not occur. On my full-speed WiFi, it got the transaction confirmation within 1 second of returning from suspension. On simulated 3G, it confirmed within 3 seconds of returning to the background.
Related issues

Fixed #5353
Mitigates #5142

Backwards compatibility
100%

When you say:

and then the transaction will continue and be mined successfully not too long after.

Is this because a confirmation by the light client can not be received by the app while it is suspended? But then when the app foregrounds, it will receive such confirmation?

Is this because a confirmation by the light client can not be received by the app while it is suspended? But then when the app foregrounds, it will receive such confirmation?
So in this section I am actually only referring to the timeout length as a whole. In theory, timeouts are useful for when you are pretty sure the operation you are doing is not going to succeed. (e.g. "If this transaction doesn't get mined within 90s, it's never going to be mined") Taking a quick look at the data we have, about 1.5% of transactions take longer than 45s and about 0.4% take long than 90s. (This does not account for the fact that transactions on slower networks are much more likely to take more than 45s. The 60th percentile on Airtel UG is currently around 40s e2e)
https://metabase.celo-networks-dev.org/question/240/notebook

Gotcha, thanks for the context. Great to see we are getting better insights into this, really wonder what's the cause of such huge confirmation times

Hi @jeanregisser @nategraf Verified task using Test flight build v1.4.0 (28) and Android play store (internal build) v1.4.0<PHONE_NUMBER>) and found the following:

Verification failed pop up is shown when app is running on background with slow networks.
We have tried 3 times but for two times we got verification failed pop up and not able to get the attestation code if app is running on background.

Please find the logs for the same.
celo_logs.txt
Also, please let us know if we need to verify any thing else.


Shai: Support returning structured verification data in RPC responses

With #2138 in place, we now have support for nearly all important CLI functions (test and simulate are really just calls to check with some pre-determined configs.
However, we are currently  only able to reply with:

A parsed TLA Module if the operation succeeds
A message with an error code if the operation fails

We now need to adjust the architecture of the pass chains so we can get back key output like counter-examples, and structured information about key kinds of errors.

[x] Identify the outputs needed by MBT in Atomcraft

looks to be mainly only the logs output and traces

[x] Draft plan for returning this data from the PassChainExecutor

[x] #2185

[x] Make changes to PassChainExecutor
[x] Use returned data to return data from RPC

After reviewing the log configuration code, and thinking things over a bit, it doesn't look like we can simply add a log appender with the current architecture -- at least not if we intend the server to be able to handle concurrent requests. In the current architecture, the logger collects output from all threads, and I don't see an immediately obvious way of segregating the logging output into different pass chain executions without pretty pervasive alterations to the architecture.
This leads me to think we should instead focus on collecting the useful data during the pass chain execution, rather than trying to dump all the logs into an RPC response. It should be easier to implement, and will give better quality data in response too, I think.

@shonfeder I have a general request, with the particular instance for this case. When asking the questions like "Identify the outputs needed by MBT in Atomcraft", could you please ask us these questions directly? I don't remember being ask that, and I don't see where the answer "looks to be mainly only the logs output and traces" comes from... In particular, I don't actually think this is what we want. What we want is:

either a short description of an error, preferably with pointers to concrete locations in the input files.
or a counterexample trace, if we are talking about the check operation.

In general, would be really great to have a joint meeting and discuss this. Let's try to set up one

Hi, Andrey! We should definitely make time to discuss MBT needs. I'll get an invite out.
In the proper order of things the final version of the RPC data returned should absolutely be based on requirements gathered from your side. In the future I'll loop MBT in on issues that aim to meet MBT requirements!
In this case, the work has been proceeding with less rigorous planning or status updates than optimal. The checked off TODO item you're referring to is misleading: the actual data currently being returned in #2186 is much closer to what you're requesting, and this issue has ended up being more about returning some data at all from the Apalache passes, rather than about returning the data in RPC in its final form.
Certainly, I had every intention of consulting with MBT prior to declaring the data returned sufficient :)

Ok, great to hear:) yes, async communication saves lots of time, but can also misleading in some cases, as the complete context is missing. I am looking forward to a sync meeting, and after that we should have the right communication balance for the future. Thanks, Shon!

async communication saves lots of time, but can also misleading in some cases, as the complete context is missing

True! Tho I can and should also improve my ticket tracking hygiene so it served better as a way to communicate and coordinate with MBT work. Thanks for pointing out the deficiency here.


Show output of console.log in karma console runner

@stefanvr the default value of this option should be true according to the Karma docs, but doesn't hurt to make it explicit :+1:


Library dependency System.Drawing.Common prevents compilations for Linux

For recent versions of .NET (6.0), the code won't compile anymore.
After removing the dependency and the code that uses it (png creation of the board), it works.

Sorry that I didnt respond to this anymore in the last season,
this season I checked if the project works on ubuntu so the new client should have less problems on other platforms.
However from the error message it looks like it was the Colored Console Printing / Getting the Console Title that caused the issue.

I solved it by simply removing the dependency and changed the related code


Added new device, but not getting recognized by other devices

I added a new device (my desktop) and it gave me a code, I entered that one on my laptop and my desktop seem to like it, since it continued with the setup proces. But my laptop doesnt seem to recognize it or something. It says something about things being done last by an unknown device. The log is coming from my laptop.
my log id: 6dc773947d22ec302b85e21c

hmm, my desktop started complaining suddenly, so aparently it wasnt added correctly.. I gave my desktop my paper key and that seems to fix the issue there, but my laptop is still in a bugged state 😢

Thanks for reporting!
Resolved by keybase/client#5850 and keybase/kbfs#760

confirmed laptop not being in bugged state anymore 👍


feat: RND-100: Stabilize Adala deployments for compatibility

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.23%. Comparing base (3b6d651) to head (e2c608e).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   58.48%   61.23%   +2.74%
==========================================
  Files          43       44       +1
  Lines        1874     2030     +156
==========================================
+ Hits         1096     1243     +147
- Misses        778      787       +9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


url bar does not use browser density

right click top bar > customize toolbar > density

Does this fix the issue? If yes I will create a PR to the theme store. Thank you!


Fix optional model in tabular tasks

Fix https://github.com/huggingface/huggingface_hub/issues/2015. Thanks @abidlabs for noticing :pray:

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

LGTM thanks for the quick fix @Wauplin! Just a couple of nits regarding the docstrings above

Thanks for the careful review @abidlabs!


Don't show replication factor input when offsets.topic.replication.factor=1

From https://github.com/jlandersen/vscode-kafka/pull/60#discussion_r551871879
Apparently, you can't use a replication factor higher than the cluster's offsets.topic.replication.factor value.
IMHO if offsets.topic.replication.factor=1, then there's no point in even showing that part of the wizard.
See https://github.com/jlandersen/vscode-kafka/blob/824a615fd5d49e2021b485d694dc9706429bc1a6/src/commands/topics.ts#L145-L156 as an example to get the cluster's config value:
@jlandersen what do you think about that?

Beware that for some clusters, you won't be able to read the configuration (cloudkarafka.com apparently prevents it). So make sure it doesn't break when config is not accessible

Beware that for some clusters, you won't be able to read the configuration (cloudkarafka.com apparently prevents it). So make sure it doesn't break when config is not accessible

well I can't even create a cloudkarafka.com topic from vscode-kafka, even when authenticated (via my SASL/SCRAM POC)

well I can't even create a cloudkarafka.com topic from vscode-kafka, even when authenticated (via my SASL/SCRAM POC)

By default the topic replication factor should be set to offsets.topic.replication.factor. If the config is not accessible, then fallback to number of brokers.


problems combining --substitute and label plugins

You can't use --substitute with  pre_add_labels_in_df.py, because the value for the substitution has to be a dictionary ({labelname: labelvalue}) and the substitution feature only supports string-values.
Sort-of related, labels should be reversed-domain according to docker upstream (com.example... etc.), but the --substitute command uses the dot character to determine which part of the configuration to substitute within.

Hi, related/masking this, the substitution has to be for a string only, whereas the pre_add_labels_in_df configuration needs a dict {label: value}

I've worked around this for what I'm doing right now by writing a wrapper-plugin that accepts a flat string as an argument and decodes it into a JSON dictionary at initialisation (before handing the result to pre_add_labels_in_df: https://bitbucket.org/jboss-dockerfiles/dock/commits/4d2c2e462cf15ea4364544bd28df08f04d0307b8?at=jdowland-serialised-label-plugin

When this was implemented, we didn't even know about the reverse-domain policy.
--substitute option was implemented for you guys; so if you can come up with a better solution to this, I don't have problem merging it/improving it (but I feel like that passing json-encoded string via CLI is a bit rough -- on the other hand, we might not have another option)

Yeah we're very grateful for --substitute, thank you! We make extensive use of it: I've only just extended our use to labelling (and we aren't using my extension in production yet, we're still evaluating it).
I considered submitting this
-- a/dock/plugin.py
+++ b/dock/plugin.py
@@ -340,7 +340,8 @@ class InputPlugin(Plugin):
                 build_json[key] = value
             else:
                 try:
-                    plugin_type, plugin_name, arg_name = key_fragments
+                    plugin_type, plugin_name = key_fragments[0],key_fragments[1]
+                    arg_name = '.'.join(key_fragments[2:])
                 except ValueError:
                     logger.error("invalid absolute path: it requires exactly three parts: "
                                  "plugin type, plugin name, argument name separated be dot")

But it didn't seem right as I wouldn't be running the affected code.

How about something like this:
--substitute "prebuild_plugins->add_labels_in_dockerfile->args->labels->com.example.key=value"

@TomasTomecek Are you sure the example above is correct? Either case, why not use {} directly to specify the labels:
--substitute prebuild_plugins.add_labels_in_dockerfile.labels="{labelname: labelvalue, abc: 12}"

If it would be messy to make --substitute work with both - direct and non-direct substitutions we could add a marker to make it clear that the value is a valid json snippet:
--substitute json:prebuild_plugins.add_labels_in_dockerfile.labels="{labelname: labelvalue, abc: 12}"

or as part of the value (which could work better):
--substitute prebuild_plugins.add_labels_in_dockerfile.labels=json:"{labelname: labelvalue, abc: 12}"

Hi, I took another look at this and PR #102 is an example of just overloading the existing plugin parameter. It didn't work out as messy as I thought it would, and shouldn't need any changes for other users of the plugin. What do you think?

LGTM

If you guys are happy, I'm happy :) I really don't have strong feelings for one way or the other
Can this be closed since #102 is merged?

@TomasTomecek Awesone, thank you! Yes, this issue can be closed now. If we'll need something else, we'll open a new one.


Fixed Zen Mode not exiting when leaving fullscreen - #231474

I propose to remove the unnecessary check so that Zen Mode toggles off when a user leaves Fullscreen Mode.
To test these changes:

Start Virtual Studio Code
Enter Fullscreen Mode
Enable Zen Mode
Exit Fullscreen Mode

Zen mode should now be toggled off.

@microsoft-github-policy-service agree


[Bug]: Unable to find environmentid error

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Some users reported that the Unable to find environment id <id> error occurs in various scenarios: when an application page is reloaded, when a Postgres query is executed, when an Airtable API is tried to be created, among others.

Steps To Reproduce
Since I was not able to replicate the error, I am attaching the conversations with each of the users:

https://app.frontapp.com/open/cnv_12yvuy4s?key=IpJCxACoAjSfgeMpBUjbjTk8IzEMVZmU

https://app.frontapp.com/open/cnv_12qfbqto?key=c2bYHKzKc8cSe-1Z7mkqptFSoyah_kW7

https://app.frontapp.com/open/cnv_12qb90p8?key=P_wCtYDh9XmnmM-6mecQ8_4kDZsKUEI5

https://app.frontapp.com/open/cnv_11uog83w?key=OM9D_n8csBEWw70iNBSdD9UmctBlzYev

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud

This is going to be resolved with the changes made under this issue https://github.com/appsmithorg/appsmith-ee/issues/2164

Not reproducible in the latest version and the underlying issue could be due to permissions or resource not found


Support for PUG includes

Description
Promoting Vite on stackoverflow.com but that's hard. I guess Vite loses to Webpack in terms of support and size of community. I think more easy-to-implement features could be added to Vite for closing the gap.
I had recently a hot debate on handling PUG files.
https://stackoverflow.com/questions/76565215/vite-not-detecting-changes-vue-pug
Turned out there's no support for PUG includes in VIte and a couple of existing PUG plugins doesn't solve the problem.
Suggested solution
Add support of using include inside <template lang="pug">
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

I got pug includes to work in our projects by specifying the basedir in the vue plugin config like this:
vue({
  template: {
    preprocessOptions: {
      basedir: path.resolve(__dirname, './src') // or something else here
    },
  }
}


Cannot read properties of undefined

Environment
Database: MySQL
OS: Windows
Node.js v20.12.1
Bug
TypeError: Cannot read properties of undefined
When an application loses its connection to the database, the application crashes with the error
TypeError: Cannot read properties of undefined (reading '__knexUid')
#Fix
\knex\lib\client.js:344:58 connection.__knexUid to connection?.__knexUid

Please provide reproductive repo

We also see this, both in production and test environments. And it's not just Windows.
Challenging to replicate though.


Updated contribution guide to include exemptions to the parameters

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable

Description
In certain scenarios, a parameter is required; whilst also being optional. The response returned should indicate that a parameter is required in order to get the desired outcome on the usage of a command. For example, /streamlink is a valid command, in order to open a specific channel; you MUST use the channel parameter, thus making it a required parameter: /streamlink <channel>

This is my counter argument ce873aeb241cfca2e540165ae49626b7270a3816

This change seems unnecessarily pedantic - in the current example in CONTRIBUTING.md with the listed conventions, /streamlink <channel> implies that I do need to specify an argument for the command to work at all which is not the case. /streamlink [channel] implies that the argument isn't required for use, but can be specified for a change in default behaviour.
@Felanbird's commit makes more sense to me.

This change seems unnecessarily pedantic - in the current example in CONTRIBUTING.md with the listed conventions, /streamlink <channel> implies that I do need to specify an argument for the command to work at all which is not the case. /streamlink [channel] implies that the argument isn't required for use, but can be specified for a change in default behaviour.
@Felanbird's commit makes more sense to me.

My commit does not oppose felanbird's. Both are technically correct and I believe both should be merged.

Invoking /streamlink with no arguments succeeds, which makes [channel] an OPTIONAL argument, not REQUIRED one.

The usage text would only appear if the user somehow types the wrong thing as the channel parameter. Since we are trying to correct the user's actions, it is a required parameter - as they are wanting to open another channel, not open the current channel in streamlink.
I mention again that my commit is not designed to oppose felanbird's - as using /streamlink [channel] in the documentation IS correct. If the user is trying to open streamlink for another channel, then the channel parameter becomes required in order to get the desired result.

One point of note only semi-relevant to this discussion, I believe the usage for /streamlink can never be generated because we don't check the input for said command.

I love Chatterino, but does anyone know how to get the Chatterino Special Pepe Badge. lol 😋

CONTRIBUTING.md is not meant to be for users of Chatterino, but to help developers know when to use what type of brackets. Angled brackets imply that the parameter MUST be there, not that the parameter may be there, and if it's not there it will work with a default behaviour anyway.
Because of this, in #3536 I'm updating the usage documentation of streamlink, which was wrong.
Note that I am not changing the text in CONTRIBUTING.md because again, it is not for users. We could add texts after the example commands with the intent, but that can be another pull request.
Closing in favour of #3536


create_csv_agent prompt errors in latest version

System Info
The creat_csv_agent function may have some bugs on the latest version of Langchain. I had a slightly older version on my local environment and the csv_agent was working with any csv. When i moved over the function to AWS Lambda where i was working with the latest version of Langchain, I keep getting an exceeded prompt length error (same exact dataset). The function will work with a smaller data set but something in the latest version of LC may be causing it to send too much to OpenAI
Who can help?
No response
Information

[X] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[X] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[X] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
import langchain
from langchain.agents import create_csv_agent
from langchain.llms import OpenAI
import os
import boto3
import tempfile
file_name = 'XX'
session = boto3.Session(
aws_access_key_id='XX',
aws_secret_access_key='XX'
)
bucket_name = 'chatscreamingfrog'
os.environ['OPENAI_API_KEY'] = 'XX'
Create an S3 resource object using the session
s3 = session.client('s3')
Create a temporary file to download the CSV file from S3
with tempfile.NamedTemporaryFile() as temp_file:
# Download the CSV file from S3 to the temporary file
s3.download_file(bucket_name, file_name, temp_file.name)
agent = create_csv_agent(OpenAI(temperature=0), temp_file.name,verbose = True)

agent.run("show all Addresses with less than 10 Unique Inlinks")

Expected behavior
The agent executor should have returned my answer. However it is returning an exceeded prompt error.

The models also aren't static but if you could bisect to point to a commit that changed it that would be helpful


Insertion noise model

This PR is part of #4640. It adds the InsertionNoiseModel, which injects noise based on a user-defined map.
#4671 is a prerequisite for this PR. The only files that need to be reviewed in this PR are:

cirq-core/cirq/devices/...

__init__.py
insertion_noise_model[_test].py

Updated with the new OpIdentifier match tools. Pinging @MichaelBroughton for review.


Runtime errors on iOS8 - Cordova 3.6 + PushPlugin 2.4.0

App compiles OK but I am seeing these errors at runtime  on iOS8:

Attempting to badge the application icon but haven't received permission from the user to badge the application

registerForRemoteNotificationTypes: is not supported in iOS 8.0 and later.

Result: app badge does not appear, notifications are not being received.
I understand that this is due to Apple having deprecated the old API - but is a fix planned for this plugin or should I abandon it and use a different notification plugin?

@Hirbod What fork? There are several mentioned in the very long thread you link to. Is it this one? https://github.com/forcedotcom/PushPlugin#unstable

Yes


Package ASDF does not exist.

Hi,
I wanted to try cl-jupyter the quick and dirty way (just starting to learn about lisp), and what I got was:
[I 16:12:43.298 NotebookApp] KernelRestarter: restarting kernel (2/5), new random ports
This is SBCL 1.4.5.debian, an implementation of ANSI Common Lisp.
More information about SBCL is available at <http://www.sbcl.org/>.

SBCL is free software, provided as is, with absolutely no warranty.
It is mostly in the public domain; some portions are provided under
BSD-style licenses.  See the CREDITS and COPYING files in the
distribution for more information.
Unhandled SB-C::INPUT-ERROR-IN-LOAD in thread #<SB-THREAD:THREAD "main thread" RUNNING
                                                 {10005E85B3}>:
  READ error during LOAD:

    Package ASDF does not exist.

      Line: 3, Column: 29, File-Position: 150

      Stream: #<SB-INT:FORM-TRACKING-STREAM for "file /home/pollinta/Downloads/cl-jupyter-master/cl-jupyter.lisp" {1001B73963}>

Backtrace for: #<SB-THREAD:THREAD "main thread" RUNNING {10005E85B3}>
0: (SB-DEBUG::DEBUGGER-DISABLED-HOOK #<SB-C::INPUT-ERROR-IN-LOAD {1001B75F83}> #<unused argument> :QUIT T)
1: (SB-DEBUG::RUN-HOOK *INVOKE-DEBUGGER-HOOK* #<SB-C::INPUT-ERROR-IN-LOAD {1001B75F83}>)
2: (INVOKE-DEBUGGER #<SB-C::INPUT-ERROR-IN-LOAD {1001B75F83}>)
3: (ERROR #<SB-C::INPUT-ERROR-IN-LOAD {1001B75F83}>)
4: (SB-C:COMPILER-ERROR SB-C::INPUT-ERROR-IN-LOAD :CONDITION #<SB-INT:SIMPLE-READER-PACKAGE-ERROR "Package ~A does not exist." {1001B75F23}> :STREAM #<SB-INT:FORM-TRACKING-STREAM for "file /home/pollinta/Downloads/cl-jupyter-master/cl-jupyter.lisp" {1001B73963}>)
5: (SB-C::%DO-FORMS-FROM-INFO #<CLOSURE (LAMBDA (SB-KERNEL:FORM &KEY :CURRENT-INDEX &ALLOW-OTHER-KEYS) :IN SB-INT:LOAD-AS-SOURCE) {1001B75A6B}> #<SB-C::SOURCE-INFO {1001B75A23}> SB-C::INPUT-ERROR-IN-LOAD)
6: (SB-INT:LOAD-AS-SOURCE #<SB-INT:FORM-TRACKING-STREAM for "file /home/pollinta/Downloads/cl-jupyter-master/cl-jupyter.lisp" {1001B73963}> :VERBOSE NIL :PRINT NIL :CONTEXT "loading")
7: ((FLET SB-FASL::THUNK :IN LOAD))
8: (SB-FASL::CALL-WITH-LOAD-BINDINGS #<CLOSURE (FLET SB-FASL::THUNK :IN LOAD) {7FFFF63E77DB}> #<SB-INT:FORM-TRACKING-STREAM for "file /home/pollinta/Downloads/cl-jupyter-master/cl-jupyter.lisp" {1001B73963}>)
9: ((FLET SB-FASL::LOAD-STREAM :IN LOAD) #<SB-INT:FORM-TRACKING-STREAM for "file /home/pollinta/Downloads/cl-jupyter-master/cl-jupyter.lisp" {1001B73963}> NIL)
10: (LOAD #P"/home/pollinta/Downloads/cl-jupyter-master/cl-jupyter.lisp" :VERBOSE NIL :PRINT NIL :IF-DOES-NOT-EXIST T :EXTERNAL-FORMAT :DEFAULT)
11: (SB-IMPL::PROCESS-EVAL/LOAD-OPTIONS ((:LOAD . "/home/pollinta/Downloads/cl-jupyter-master/cl-jupyter.lisp") (:QUIT)))
12: (SB-IMPL::TOPLEVEL-INIT)
13: ((FLET SB-UNIX::BODY :IN SAVE-LISP-AND-DIE))
14: ((FLET "WITHOUT-INTERRUPTS-BODY-36" :IN SAVE-LISP-AND-DIE))
15: ((LABELS SB-IMPL::RESTART-LISP :IN SAVE-LISP-AND-DIE))

unhandled condition in --disable-debugger mode, quitting

I have a clean SBCL installation on Ubuntu 18.04, and quite possibly I just need to know how to get asdf permanently - nothing had changed after running (require 'asdf) in sbcl.

@freifrauvonbleifrei SBCL bundles ASDF, so it is really weird to not have one? Quicklisp also bundles ASDF, have you installed it already?

@PuercoPop hrm, no, apt list --installed | grep asdf did not give me anything. I tried installing cl-asdf, and reinstalling sbcl, to no avail.

@freifrauvonbleifrei It is not a good idea to use the distribution packages for Lisp libraries. Uninstall CL-ASDF. SBCL bundles ASDF as part of their main repository. I recommend using the SBCL you got from apt to compile your own sources:
$ sh make.sh --prefix=/usr/local --fancy
And follow the instructions and then
$ apt-get remove sbcl

But installing quicklisp should provide you with an (albeit old) ASDF version regardless.

I face a similar problem - running Debian and having quicklisp installed though.
(I got SBCL from apt-get install on Jessie)

I got a similar problem.  I installed sbcl from source, as per a suggestion above.  I still get the Package ASDF does not exist error.  sbcl --eval "(require asdf)" --quit` works just fine though.

cl-jupyter kind of depend on quicklisp so the setup.lisp script should be loaded implicitly or explicitely ... Closing this (happy that you find a solution)

I got a similar problem. I installed sbcl from source, as per a suggestion above. I still get the Package ASDF does not exist error. sbcl --eval "(require 'asdf)" --quit works just fine though.
UPDATE: I figured out my problem. I don't have a .sbclrc so sbcl doesn't automatically (require 'asdf) or (load "~/quicklisp/setup.lisp"). I suspect this might solve some people's problems.

can you post your .sbclrc file? how to load with cl-jupyter??

can you post your .sbclrc file? how to load with cl-jupyter??
@mrmechko

can you post your .sbclrc file? how to load with cl-jupyter??
@mrmechko

Its been a while since Ive used it since I switched to emacs and just started using SLIME. If you want, check out https://github.com/tripslab/vagrant-trips. The whole thing is unnecessary for you, but the way the virtual machine gets set up, cl-jupyter ran on it. Sorry i can't be more help, but I got a thesis to finish :3


Style Declarations in index.html incorrectly output by UnoCSS

UnoCSS version
0.51.12
Describe the bug
Normal CSS styles that happen to match the name of a UnoCSS class in a

https://unocss.dev/guide/extracting
You can add @unocss-ignore tag try again.

Good catch, I'll give that a try, thanks! 😄


legacy mode?

This would be good for clients that wern't patched to support the new server.

 Clients will just have to update, it's not that big of a change apart from indexes. All things that require an index (with the exception of ulist) will use mode 3 from now on (the same one that is used for home auto-get API.
As a side note if any client is still using get_home they should start using the REST API to get home posts.


limit number of results from one file

sometimes there can be way too many results from a file especially from documentation files for example.
there should be some limit established regarding the number of lines one file can include, at least as long as they are not direct matches

#162 would solve the same problem in a better way


feat: implement add_tx in mempool struct

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.32%. Comparing base (fddee60) to head (a0ace16).

Additional details and impacted files
@@                             Coverage Diff                             @@
##           ayelet/mempool/implement-mempool-struct      #47      +/-   ##
===========================================================================
+ Coverage                                    44.54%   47.32%   +2.77%
===========================================================================
  Files                                            7        7
  Lines                                          110      112       +2
  Branches                                       110      112       +2
===========================================================================
+ Hits                                            49       53       +4
+ Misses                                          60       58       -2
  Partials                                         1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Avoid calling shutdown after failed write of AsyncWrite

in serialize_rb_stream_to_object_store
Which issue does this PR close?

Rationale for this change
Avoid "async fn resumed after completion" panics caused by trying to shutdown an errored writer.
See e.g. BufWriter in object_store which holds on to an underlying Future and doesn't transition the state on error. (https://github.com/apache/arrow-rs/blob/master/object_store/src/buffered.rs#L376-L379)
I tried to figure out from the documentation of AsyncWrite whether we should be able to call poll_shutdown after poll_write failed but I didn't manage to figure it out so I think it's better to be defensive here.

What changes are included in this PR?
We make the WriterType returned on error optional and omit it when the error originated from the writer itself.

Are these changes tested?
No, not sure how to reproduce it outside of real-world conditions, let alone test it 😢

Are there any user-facing changes?
No user-facing changes.

Thanks again @joroKr21  and @comphead


Allows runtime configuration of vault provider retry delay and tries.

Due to recent issues on sync jobs caused by the Vault connectivity issues that are leading to timeouts, the ability to extend the timeout is desired. The existing implementation does not allow this at runtime due its use of decorators. This PR uses the retry_api.retry_call to facilitate runtime specification of delay and tries for retry.

Would there be any objections if I were to up the default timeout to 300 from 2? @adisunw @rtjoseph11

Would there be any objections if I were to up the default timeout to 300 from 2? @adisunw @rtjoseph11

I think I would prefer a change in the default tries rather than delay, but i'll defer to @rtjoseph11 on preferred usage.

I think we should set default timeout to 60 seconds and tries to 5


Configuration option for text-rendering: optimizeLegibility

Implement a configuration option for text-rendering: optimizeLegibility as that is required for ligatures to work. See https://github.com/atom/atom/issues/3821#issuecomment-146474764

If this is added as an option, it should be done  with font-feature-settings, rather than text-rendering: optimizeLegibility. Some of the coding fonts with OpenType features are using contextual alternates, per this article, which means the setting should at least enable:
.feature-enabled {
  font-feature-settings: "liga" 1, "calt" 1;
}

Contextual alternates and ligatures are both supposed to be on by default anyway, per the OpenType spec, but isn’t being consistently followed. A more thorough, forward-looking version would be:
.feature-enabled {
  @supports not (font-variant-ligatures: common-ligatures) {
    font-feature-settings: "liga" 1;
  }
  @supports not (font-variant-ligatures: contextual) {
    font-feature-settings: "calt" 1;
  }
  font-variant-ligatures: common-ligatures;
  font-variant-ligatures: contextual;
}

Another approach would be to include this by default, as the majority of monospaced fonts will not include OpenType features, and the ones that do should be making the less widely applicable ligatures dlig discretionary ligatures.

Just want to let you know optimizeLegibility will be default behaviour on Chrome 49 so some font-feature-settings setting will probably what you want if the feature is not enabled by default (which most features fonts need, like liga, are)

@ebraminio Does that mean that ligatures will work by default in Atom when Atom is upgraded to Chrome 49? I feel like there is something missing in your statement and I can't fully understand what you wanted to say.

Yes. In fact there was two code path for handling text shaping, the one that was called simple and wasn't able to make ligatures happen and the other one which was called complex (webdevs know that as being triggered by optimizeLegibility) which uses a third party library for shaping and is able to do all needed font features request if they are enabled by default. These code paths now are merged and actually it is just got became to be like Firefox.

Cool :D
Do you happen to know when will be electron upgraded to Chrome 49?

Yes. Of course if nothing unpredicted happens in between.

I was asking for when, not if it's going to be upgraded.

Oh sorry, well that also depends, I am not an electron team member :) But I guess electron will be updated to Chrome 49 sometime after it become stable which would be couple of weeks I'd guess.

Do you happen to know when will be electron upgraded to Chrome 49?

It all depends on how much needs to be changed, especially within Atom.  I'd guess that switching the default text rendering path will break a lot of tests.

@50Wliu I'm confused. Wasn't Atom 1.1 supposed to fix ligatures? (which btw aren't enabled by default even that we're almost at Atom 1.3 now). Why would enabling ligatures by default break unit tests if the entire point of Atom 1.1 was to fix ligatures in the first place?

Why would enabling ligatures by default break unit tests if the entire point of Atom 1.1 was to fix ligatures in the first place?

Subtle differences in character widths and spacing, etc.  It's happened before with subpixel font scaling.  I'm not familiar with this part of Atom though so I could be totally wrong.  We'll see when the initial PR is created :).

Maybe @as-cii can enlighten us?

I'd guess that switching the default text rendering path will break a lot of tests.
It did on Chrome so probably would do here also but if you have updated enough version of Chrome, you can do apply optimizeLegibility before hand and remove it after the migration so that would make the change smoother.

Personally, I don't think unit tests are much of a deal-breaker here. However, I'd prefer the optimizeLegibility setting to be opt-in (at least for the time being) because that styling is known to affect Layout times and it becomes increasingly noticeable when there are lots of text runs (such as within a text editor).
An opt-in configuration setting would make most sense to me, although hacking the personal stylesheet seems almost as straightforward (I guess this is the reason why it wasn't implemented yet).

Known layout time defects are mostly gone on the recent versions with CachingWordShaper, the technique which is also incorporated on Firefox. I suggest if you have Chrome 46 in, give it a try. And if you have runed into performance regress that also is available on 49, report that to Chrome project.

That's great to hear, @ebraminio. Electron currently runs on top of Chrome 45 and I think my benchmarks were based on that version or the immediately previous one. I am :ok: to enable this by default as soon as we upgrade to a more recent major version of Chrome and test performance out once again. :chart_with_upwards_trend:

Oh that would great. Actually 45 is also good but its complex tab is unable to handle tabs. If you are handling tabs by your own that would be no issue, but I am not sure how Atom works.

And oh 45 performance is bad when white-space: pre is enabled but it is fixed on 46. Still not sure if you using it but 46 probably would be safer for test.

Yeah, I just tried to perform some benchmarks on this version and indeed we have a performance regression if we turn on optimizeLegibility (I guess because we use white-space: pre). I'll be more than happy to come back to this once Chrome solves these slowdowns in the next versions. :tada: :racehorse:

Time has passed and Chrome 49 which is always "optimizeLegibility" has become stable Chrome release now, I guess all bugs with mention of "optimizeLegibility" could be closed after the migration on Atom also.

Well, it seems still some differences is available, asked on https://bugs.chromium.org/p/chromium/issues/detail?id=404597#c70

Labeling as blocked until Atom upgrades to Electron 0.37.

This should be closed as the upgrade to Chrome 49 on Electron 0.37 which atom uses now.

Thanks for the update @ebraminio!


SqlServerDsc: Naming convention must be explained

Details of the scenario you tried and the problem that is occurring:
When repository is renamed to SqlServerDsc and PR #902 is merged then 'Naming convention' section must be updated in CONTRIBUTING.md (based on issue #851).
The DSC configuration that is using the resource (as detailed as possible):
n/a
Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a
What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a
Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

@johlju, I can take this one since I put together the issue.


[Marketplace][Custom app] custom application disappears from My applications if to updated the version from the card view or Edit context menu

EPAM AI DIAL chat version
0.18.0
What happened?

DIAL Marketplace -> My applications ->+ Add app -> create any application and Add it
Click on the added application -> the card view is opened
Click on Edit button -> Change version -> Save
Note the app disappears from the My applications -> bug
It appears only after browser refresh
The same if to edit using context menu

https://github.com/user-attachments/assets/b24ef598-ba45-42ec-be6c-f120907fdf79
Note: The same if to updated the app name
Expected: The app should stay on My applications with updated version
Confidential information

[X] I confirm that do not share any confidential information

tested on staging successfully


is speech_campplus_speaker-diarization_common onnx model available?

is speech_campplus_speaker-diarization_common onnx model available?

Exporting onnx models is not currently supported

does speech_campplus_sv_zh-cn_16k-commo or speech_campplus-transformer_scl_zh-cn_16k-common support onnx model?

not supported now

thankyou

@lancelee98
We have supported it in https://github.com/k2-fsa/sherpa-onnx/pull/522
We are adding C++ runtime for it.

@lancelee98 We have supported it in k2-fsa/sherpa-onnx#522
We are adding C++ runtime for it.
thank you


Always try to clear render target before drawing 3D with Canvas BG mode

This is necessary to ensure that we aren't copying garbage data to the 3D renderbuffer
Previously I thought it was only needed when no CanvasItems were present in the scene, but it is also needed when CanvasItems are present, but nothing is rendered.
render_target_do_clear_request() has an early-out in case a clear has already been done this frame.

Thanks!


improvement: fix coverity scan issue

Signed-off-by: pingkai<EMAIL_ADDRESS>

Codecov Report

Merging #347 into develop will decrease coverage by 6.01%.
The diff coverage is 14.28%.

@@             Coverage Diff             @@
##           develop     #347      +/-   ##
===========================================
- Coverage    68.17%   62.15%   -6.02%
===========================================
  Files          212      212
  Lines        11565    11568       +3
===========================================
- Hits          7884     7190     -694
- Misses        3681     4378     +697

Impacted Files
Coverage Δ

cmdline/cicadaPlayer.cpp
0.00% <0.00%> (ø)

framework/data_source/curl/CURLConnection.cpp
64.53% <0.00%> (+0.29%)
:arrow_up:

framework/demuxer/play_list/playList_demuxer.cpp
80.51% <ø> (ø)

framework/demuxer/play_list/playList_demuxer.h
83.33% <ø> (ø)

framework/data_source/curl/curl_data_source.cpp
84.23% <33.33%> (-0.29%)
:arrow_down:

framework/cacheModule/CacheManager.h
0.00% <0.00%> (-100.00%)
:arrow_down:

framework/data_source/cachedSource.h
0.00% <0.00%> (-100.00%)
:arrow_down:

mediaPlayer/PlayerCacheDataSource.cpp
0.00% <0.00%> (-100.00%)
:arrow_down:

framework/cacheModule/cache/CacheFileRemuxer.h
0.00% <0.00%> (-100.00%)
:arrow_down:

framework/data_source/cache/sliceBufferSource.h
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747dd21...3d0cc5e. Read the comment docs.


Missing support or not for outlook mobile

Hi team, please add on session client support related the outlook mobile.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e22eb42c-6ab3-854c-c229-569f1ca6d2ea
Version Independent ID: b86cc920-b40d-3a2c-c88b-a36e3692fbbc
Content: Use markdown to format Power Automate approvals - Power Automate
Content Source: articles/approvals-markdown-support.md
Service: flow
GitHub Login: @gcorvera
Microsoft Alias: gcorvera

Thanks for your feedback. Please submit your feature request here:  https://powerusers.microsoft.com/t5/Power-Automate-Ideas/idb-p/MPAIdeas

For Outlook Mobile, the above parameters can vary depending on the Outlook client app and version that you are using. I've added this note to the doc


Add more logs to LRE/Remote

This change is

Let's reevaluate this one. The current setup only seems to lag in the pulumi part sometimes where we already have logs.


duplicate track request for the same product by the same user

scenario:

user searches for google pixel and select the google pixel 7a 5g and request the track request.
2, and later same user searches for google pixel 7a 5g and select the google pixel 7a 5g and request the track request.

the url for these two instances will be different even though the product is same.
for example:
https://www.amazon.in/Pixel-Sea-8GB-128GB-Storage/dp/B0CMHLNVGS/ref=sr_1_4?crid=29M7LBVDXVQCP&keywords=google+pixel+7a+5g&qid=1700846878&sprefix=google+pixel+7a+5g%2Caps%2C159&sr=8-4
https://www.amazon.in/Pixel-Sea-8GB-128GB-Storage/dp/B0CMHLNVGS/ref=sr_1_3?crid=15JYE7A72BD2R&keywords=google+pixel&qid=1700846833&sprefix=google+pixel%2Caps%2C187&sr=8-3
above two url are for the same product, but because user visited this page using different search keywords, the url formed is slightly different. because of this, when user tracks again, a different track request is created, which it should not.
one solution: strip the use to remove the extra information before storing in our database. for example only store the below as url.
https://www.amazon.in/Pixel-Sea-8GB-128GB-Storage/dp/B0CMHLNVGS/

do we still have this error? can you please test and close this defect, with notes, if the error is no longer there.


Error when installing Kubeflow with microk8s

I'm see the below error when I attempt to install Kubeflow.
It seems that it cannot find the .kube/config file. (which is not there by the way.  not sure how microk8s does this)
microk8s enable kubeflow
Enabling dns...
Enabling storage...
Enabling dashboard...
Enabling ingress...
Enabling metallb:<IP_ADDRESS>-<IP_ADDRESS>...
Waiting for DNS and storage plugins to finish setting up
Kubeflow could not be enabled:
The connection to the server <IP_ADDRESS>:16443 was refused - did you specify the right host or port?

Command '('microk8s-kubectl.wrapper', 'wait', '--for=condition=available', '-nkube-system', 'deployment/coredns', 'deployment/hostpath-provisioner', '--timeout=10m')' returned no
n-zero exit status 1
Failed to enable kubeflow
ubuntu@node05ob96:~$ microk8s kubectl get nodes
NAME         STATUS   ROLES    AGE   VERSION
node02ob96   Ready    <none>   20m   v1.19.2-34+1b3fa60b402c1c
node01ob96   Ready    <none>   18m   v1.19.2-34+1b3fa60b402c1c
node05ob96   Ready    <none>   42m   v1.19.2-34+1b3fa60b402c1c

Thank you @jtfogarty for this!
/assign @knkski

@jtfogarty: The fastest way to fix this is with sudo snap switch microk8s --channel 1.18/stable && sudo snap refresh.
cc @ktsakalozos, as this looks like a 1.19 / calico sort of issue

With the currently recommended microk8s versions for the Kubeflow addon being 1.20 and 1.21 we can close this issue.
If you are able to reproduce this in the latest kubeflow bundle and the issue is still relevant feel free to reopen it.


Testing stages

Depends-On: https://github.com/openstack-k8s-operators/ci-framework/pull/2374

recheck

The MR conflict in the cifmw PR has to be resolved first -> https://github.com/openstack-k8s-operators/ci-framework/pull/2374

recheck

/retest

/retest-required

recheck

recheck

recheck

No longer needed


Issue #765 - Moving functional tests into the source tree

Updates

Moved all functional tests from the centralized test/ directory to the appropriate test directories closer to the source
Split all test directories into unit/ and functional/ directories.
Removed a couple tests with identical or duplicated functionality

functional_test_nat.py (duplicated functionality)
test_util_exceptions.py (identical functionality in same unit test)

this is ready for review @zancas and @caphrim007. I left the test/ structure alone for now so we can land @wojtek0806's ASM PRs. After those are merged I can migrate those tests and close out the test/ directory.

lgtm


Enable profiling information for cache

Caching information should be available from the application profiling page.

I'm also not in favor of such a feature as caches are supposed to be really fast and should be the last place to look for bottlenecks, so I don't think there's any benefit in this.


Solved Links not working in the readme.md

Pull Request Description
Summary
This pull request addresses the issue of broken links in the README.md file. All non-functional links have been identified and corrected to ensure smooth navigation and better user experience.
Changes Made

Fixed broken links in the README.md file.
Verified all updated links to ensure they point to the correct resources.

Impact

Improved accessibility to documentation and external references.
Enhanced user experience by eliminating dead links.

Testing

Manually checked each link to confirm they are working correctly.

Fixes #148
@Harshdev098
Pls give me level2,gssoc-extd,hacktoberfest,etc.

@Harshdev098
Pls merge my pr

@Harshdev098
Yes, I have tested the links are working

@MastanSayyad , @RadhikaMalpani1702 isn't this should be level 1?

Hi @alo7lika Dont worry, you are not the only one who is being reviewed, whole leaderboard is. For him the review is under process your review was assign to her, after this Contributors review we will reduce it too.

@Harshdev098 you didn't add me as a collaborator yet, kindly reduce labels from level 2 to level 1 and add me.


codeunit 1605 "PEPPOL Management" - IsRoundingLine

Describe the request
Can you change procedure IsRoundingLine to global in codeunit 1605 "PEPPOL Management"?
Additional context
I need this to check whether a line is rounding line in a customization. And I do not want to duplicate the code if I can avoid it.Internal work item: AB#495053

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 15328.


Scoped package name for plugins

Hi,
Just to have your opinion about this. What do you think about using scoped packages for gulp plugins?
Something like gulp-concat would become @gulp/concat or @gulp-plugins/concat.

Plugins aren't controlled by the gulp team. They are all in userland.


liboqs: Fix build error

Description of changes
Currently the build fails with
CMake Error at /nix/store/4vq5ggsg1vmfs09r4sqbidmgvqlxrv14-cmake-3.27.8/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
  system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY
  OPENSSL_INCLUDE_DIR) (Required is at least version "1.1.1")

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3166


Is it possible to unify addons and agent package such that we don't have 2 different concepts to deal wiith

The spec defines downloadable addons and downloadable agent package. These features overlap in some ways. Can we unify and get of one of the concepts?

We can do this by deleting the entire spec section dedicated to agent packages and then renaming "addon" to "package" in the spec and adding an enum to the messages to tell if the package is an addon package or agent's installable package. This should significantly simplify the protocol and remove duplication of very similar functionality.


rules: Use narrower interface for rule manager loading of for state

To load ALERT_FOR_STATE only storage.Queryable interface is required,
so this patch uses this narrower interface for to perform this.
@brian-brazil @bwplotka @codesome @gouthamve

If people want I'm also happy to rename the TSDB struct field, as Queryable arguably might make more sense now. Let me know.

:+1:
Renaming makes sense to me.

Is it the purpose to make it importable? Because currently we are not resilient to nil interfaces.

Is it the purpose to make it importable? Because currently we are not resilient to nil interfaces.

It's so I can play around with alternative implementations and not have to implement the whole interface, and Prometheus happens to also only need this narrower interface, which is generally good practice.


Use Rbac.filtered where appropriate

Trivial cleanup / refactoring: we already have a method to encapsulate a common pattern, but we're not using it at the moment.

@matthewd please rebase to pull in the fix from #3204 to fix your test failure

@gtanzillo Please review

@chessbyte All looks good :)

Could we avoid adding a bunch of if statements?
before:
if filter_id.zero?
  Rbac.filtered(targets, :class => ci_klass, :userid => @requester.userid)
else
  MiqSearch.find(filter_id).filtered(targets, :userid => @requester.userid)

after:
class MiqSearch
  def filtered(targets, options)
    filter_id = options.delete(:filter_id)
    if filter_id != 0 || filter_id.nil?
      Rbac.filtered(options)
    else
      find(id).filtered(targets, options.delete(:class)
  end
end

MiqSearch.find_filter(targets).filtered(targets, filter_id, :class => ci_klass, :filter_id => filter_id, :userid => @request.userid)

@kbrock yeah, I was definitely thinking about something along those lines... either like that, or with something like a Null Object version of an MiqSearch. For now I'm focusing on whether I can reduce the API surface area of Rbac.search, along with getting it better acquainted with Relations.
For now, I wanted to keep this change as A :: B as possible.

@matthewd Sorry - you already said that. LGTM


Display pubspec-provided documentation link.

Some packages may have a site that hosts documentation separate from the main homepage. If your package has that, you can also add a documentation: field with that URL. If provided, a link to it is shown on your package’s page.

https://www.dartlang.org/tools/pub/pubspec#documentation
At the moment pub site ignores this setting. Source: https://github.com/dart-lang/site-www/issues/801

How many packages actually do this?

How many packages actually do this?

(staging data) 230, out of which 210 are linking to external sites (e.g. not www.dartdocs.org or pub.dartlang.org). Considering that we have never displayed this value on the package page, I'd say it is significant.


Revert "Delay PreferencesActionsContribution (#159719)"

This reverts commit 3b26f306d8e7373947acd772106047c5dbb20427.
Fixes #159875

I am still curious how this change could have caused the regression? It should not matter when a keybinding is registered for it to work`

I'll merge this for now and then investigate later


Update knex to 0.11.4 and fix tests to work with new, breaking changes

Empty knex configuration options no longer error, so I updated the first test to instead check for invalid models/collections paths which do error.
This update brings knex to the latest version which includes nice features such as varbinary columns in mysql.

Coverage decreased (-1.6%) to 98.413% when pulling bcdf44e5b60e3d573fc39a6260f20b9f8129b7d6 on Luminopia:master into 882e7418098beaa00b5aebf455a068abf13d8180 on lob:master.

Maybe this would be even better if knex and bookshelf were set as peerDependencies for this package?

Hey @awendland!
Thanks for the contribution! I definitely agree that knex and bookshelf are much better suited to be peer dependencies than actual dependencies. Good call. To make sure that the tests still pass though, you'll need to add npm install bookshelf knex to the .travis.yml file so that there are copies of those modules for the tests to run against (since npm install won't install them by default anymore).
It also looks like the tests are missing coverage of the catch statement you added. Could you add a test to make sure that that error is thrown correctly?
Also, we recently added the generate-changelog module to this repo so that we don't have to worry about manually creating the changelog. We'll be updating the README so that it's more clear when contributing, but until then, can you amend your commit message to follow the format?
chore(dependencies): make bookshelf and knex peer dependencies

@robinjoseph08 I've updated the PR to reflect the changes you mentioned.

Coverage remained the same at 100.0% when pulling e39441c9a4ca394982158a34d8f65f671a2b18ab on Luminopia:master into 882e7418098beaa00b5aebf455a068abf13d8180 on lob:master.

Awesome, looks great! I'll let you know when I've cut a new version. Thanks again for the contribution!

Published v2.0.0! I made it a major change since before it was possible to have everything working without explicitly installing bookshelf and/or knex, but now those packages need to be listed as direct dependencies.

Makes a lot of sense. Thanks for accepting this PR!


Azure DevOps MS SQL firewall

Hi all and thank you for really great provider.
I have issue with Azure DevOps pipeline when using mssql_user.
During pipeline execution Azure DevOps has public IP, so we need to add it to MS SQL firewall to plan / apply mssql_user
Is it possible to add inside of mssql_user task adding and removing current public IP firewall rule?
Or maybe you can suggest a workaround?
Thank you

This is a generic mssql provider, so this is very likely not really a fit for the code base of this provider.
What you can do (if your security policies allow that) is to enable Allow access to Azure services on your server firewall, as explained here. As Azure pipelines run on Azure VMs, that will give the required access.

@alxy thanks for suggestion, but looks like when SQL connection than this approach is not working.
E.g. when we are using SqlAzureDacpacDeployment@1 in yaml CI/CD we have IpDetectionMethod: 'AutoDetect'
I'm not an expert at terraform, but maybe you can suggest something like before_hook, local-exec or remote-exec so that we can enable SQL firewall using cmd before terraform plan / apply and after finish remove those SQL firewall rule?
Thank you

I think doing it within Terraform itself is not a good idea. Why cant you just create extra steps in your pipeline to create a firewall rule and remove it? I don't have the exact code, but should be farily easy using azure cli, e.g.: az sql server firewall-rule create -g $(resourceGroupName) -s $(sqlServerName) -n $(ruleName) --start-ip-address ${{ pipelineIp }} --end-ip-address ${{ pipelineIp }}'
You need to find a good way how to get the pipeline ip however, not sure if there is a good process to do that, probably by calling some API that returns your public ip.

@alxy yes for CI/CD it is possible to do, but we need to keep this in mind. Also for local machine you will have to go and do it manually.
Maybe you know about terraform options what is better to try first?
Thank you1

I don't like the idea of putting it in Terraform, remember that this is a descriptive language - so you are actually describing a desired state in your terraform configuration. There is no such thing as transient objects (like this firewall rule) in Terraform.
You can certainly achieve that with null_resources and couple of depends_on blocks, and triggers that always trigger (time-based). However, you will never get a clean plan, and it really feels hacky to me.

@alxy thanks for your suggestions. One more point, can we change error message so that user will see SQL exception about firewall same as e.g. MS SQL Management Studio shows when blocked by firewall?

I'm not aware that this would be natively possible by terraform unforutnately :(

@alxy thanks for all your help! Looks like we can close this issue


Fixing problem with labels in inluded papers.

Parameters in new commands in new environments need double pound to defer the correct parameter. This should fix problems with multiply defined labels.

Thanks!


Form Recognizer (cf closed issue #24903). Run model on each page independently.

    > Current Invoice API assumes that whole input document is a single invoice and it does not do any document splitting. It selects value with highest confidence across all pages for each field. It is possible to use "pages" parameter of invoice API to run model for each page independently and implement some post custom post-processing logic to merge results (i.e. if InvoiceId is different on the next page, start new invoice).

Hi @anatolip , @vkurpad @catalinaperalta  Hope this hasn't been covered in another thread. Can you please let me know what parameter I should use in "pages" parameter in order to get two analyzed documents instead of one for the use case depicted above (i.e a 2 pages pdf where each page is a single page document to be analyzed). So far i've tried the following :
pages = "1,2"
pages = "1-1,2-2"
But unfortunately :
len(results["analyzeResult"]["documents"]) equals 1
In order to reproduce the result explained above you can use the following code as well as the attached pdf file.
import aiohttp
import asyncio
import io

async def analyze_docs(data):

    # Config
    modelId = "prebuilt-invoice"
    pages = "1,2" # pages = 1,1 or pages = 1-1,2-2 or other ?
    url = f"https://westeurope.api.cognitive.microsoft.com/formrecognizer/documentModels/{modelId}:analyze?api-version=2022-08-31&pages={pages}"
    headers = {
        "Content-Type": "application/octet-stream",
        "Ocp-Apim-Subscription-Key": "...",
    }

    # Post request
    async with aiohttp.ClientSession(headers=headers) as session:
        while True:
            response = await session.post(url=url, data=data)
            if response.status in [200, 202]:
                callback = response.headers["Operation-Location"]
                break

    # Get results request
    headers = {"Ocp-Apim-Subscription-Key": "..."}
    async with aiohttp.ClientSession(headers=headers) as session:
        while True:
            response = await session.get(callback)
            results = await response.json()
            if "status" in results:
                if results["status"] == "succeeded":
                    break

    nb_docs = len(results["analyzeResult"]["documents"])  # Equals to 1 instead of 2 as expected.
    return nb_docs

async def main() -> None:

    path_to_file = f"2_docs_to_analyse.pdf"

    with open(path_to_file,"rb") as f:
        stream = f.read()

    # await
    await analyze_docs(stream)

if __name__ == "__main__":
    asyncio.set_event_loop_policy(asyncio.WindowsSelectorEventLoopPolicy())
    asyncio.run(main())

2_docs_to_analyse.pdf
Originally posted by @dev-td in https://github.com/Azure/azure-sdk-for-python/issues/24903#issuecomment-1368061516

Thanks for reaching out @dev-td! @anatolip and @vkurpad please share any guidance you have for this case. I see that in the older issue #24903, @anatolip mentioned that pages might be able to be used for this purpose, is that correct? If so, is the example above the recommended way to do this?
In the meantime, as a workaround it might be best to send 2 requests @dev-td, one with pages="1" and another request with pages="2".

Hi @catalinaperalta , got an answer from Product Group team
“Currently the analyze document expects only a single document in the payload. If there are multiple documents in the file, only the first document is processed. The options are to split the PDF using open source tools (https://www.pdflabs.com/tools/pdftk-server) if you know the document ranges, or use the pages option in the request and send the same document with different page ranges in each request. The split and classify API is planned for February, this would help with files where the page ranges are not known, but will still currently require multiple requests. There will be an update in H2 of 2023 where this will be a single request solution”


ci: add Nyx-Testing tests

Add tests based on https://github.com/nyx-fuzz/Nyx-Testing

Tests are failing because QEMU-Nyx cannot access KVM-PT
running 31 tests
test tests::test_create_and_load_pre_snapshot ... FAILED
[QEMU-Nyx] Could not access KVM-PT kernel module!
[QEMU-Nyx] Trying vanilla KVM...
[QEMU-Nyx] Error: NYX requires support for KVM_CAP_DIRTY_LOG_RING in fallback mode!
qemu-system-x86_64: /home/mtarral/_work/kAFL/kAFL/qemu-nyx/accel/kvm/kvm-all.c:2197: kvm_init: Assertion `ret < 0' failed.

The runner didn't have a kAFL enabled kernel.
This has been fixed.
Some tests are passing, but the rest are timing out:
test tests::input_buffer_write_protection_child_32 ... ok
test tests::input_buffer_write_protection_child_64 ... ok
test tests::coverage_bitmap_32 has been running for over 60 seconds
test tests::get_host_configuration_twice_32 has been running for over 60 seconds
test tests::hget_fail_32 has been running for over 60 seconds
test tests::load_root_snapshot_32 has been running for over 60 seconds
test tests::load_root_snapshot_with_custom_input_size_32 has been running for over 60 seconds
test tests::resize_coverage_bitmap_32 has been running for over 60 seconds
test tests::resize_coverage_bitmap_host_to_guest_32 has been running for over 60 seconds
test tests::resize_coverage_bitmap_host_to_guest_fail_32 has been running for over 60 seconds
test tests::resize_small_coverage_bitmap_32 has been running for over 60 seconds
test tests::set_agent_configuration_twice_32 has been running for over 60 seconds
test tests::set_agent_configuration_twice_64 has been running for over 60 seconds
test tests::skip_get_host_configuration_32 has been running for over 60 seconds
test tests::skip_set_agent_configuration_32 has been running for over 60 seconds

Well, this looks weird. Could be an issue caused by running low on memory since all tests are executed at once (and each test spawns a new VM).
Try to run the tests sequentially by adding --test-threads 1 to the command...maybe this will fix the issue.

I ran a test with --test-threads 1 on the runner, manually in tmux:

all green ✅
However, I don't get the same results in the Github Action job:

2 tests are passing ✅
And then it hangs for no clear reason until the job max timeout kicks-in (6h).

Continue to debug the hang issue today.
I started by capturing the stacktrace with rust-gdb, and noticed that the test was waiting for a QEMU to write a message on a socket
Without any further leads, I tried to force cleanup the job workspace because each run (since it's not done automatically on the self-hosted runners).
Apparently it solves the hang issue, not sure exactly why.


Cubic Bezier

That would be nice, please!

See here: https://github.com/koenbok/Framer/blob/master/framer/Animators/BezierCurveAnimator.coffee


Bypass dropping UniquePtrs for Translator, Generator, and Whisper on Windows

Releasing UniquePtrs for sys::Translator, sys::Generator, and sys::Whisper cause the program to hang on Windows.
This PR bypasses them on Windows as a workaround.
See also: https://github.com/jkawamoto/ctranslate2-rs/issues/64#issuecomment-2236987058

See https://github.com/OpenNMT/CTranslate2/issues/1729#issuecomment-2242206332
If it works normally with Python, I suspect that it's something with Rust itself

We might need some special care on Windows, but I haven’t found any document yet…


Graceful shutdown handling for Babe

Aha! Link: https://soramitsucoltd.aha.io/requirements/PRE-52-8

Resolved a long time ago.


[SPARK-23310][CORE] Turn off read ahead input stream for unshafe shuffle reader

To fix regression for TPC-DS queries

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/550/
Test PASSed.

Test build #87014 has started for PR 20492 at commit 36b099b.

Test build #87014 has finished for PR 20492 at commit 36b099b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87014/
Test PASSed.

Just a minor comment, LGTM. Thanks!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/583/
Test PASSed.

Test build #87059 has started for PR 20492 at commit 732cf9e.

Test build #87059 has finished for PR 20492 at commit 732cf9e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87059/
Test PASSed.

LGTM

merging this to master/2.3


pulsar: 1.104.0 -> 1.107.1

Hopefully a version bump is all that is required, as no external dependencies should have updated
Description of changes
For minor changes in 1.107.1, please see https://github.com/pulsar-edit/pulsar/releases/tag/v1.107.1
For major changes in 1.107, please see https://github.com/pulsar-edit/pulsar/releases/tag/v1.107.0
For major changes in 1.106, https://github.com/pulsar-edit/pulsar/releases/tag/v1.106
For major changes in 1.105, https://github.com/pulsar-edit/pulsar/releases/tag/v1.105
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

I believe this (mostly) fits the contribution guide, however, please let me know if that is not the case.
I personally do not (yet) have a copy of NixOS to test these changes. Current maintainer, @COLAMAroro, would you mind testing these changes? I can update the PR of the description with additional "things done", if something else is required.

Duplicate of an already merged PR #243972
Please close

Please prefix the title with [Backport Release 23.05]

Cancelling PR as @COLAMAroro has since offered to see about getting the current unstable entry for 1.107.1 ported to stable.
Apologies for the (hopefully small, but still important) time investment


Test chunked request body

Verify that the proxy properly streaming the body contents of a chunked
transfer between backend and frontend.
Fixes #32

👍


Set up basic CI using GameCI and GithubActions

What?
Introducing a structure for CI tests to run using Github Actions, Game CI and unity testrunner.
How?
There are three parts of this PR:

Tests~/BasicBuildTest <- This folder and the stuff beneath it is a very simple unity project. Right now it contains only a testrunner with a PlayModeTest that makes a guest login towards LootLocker backend and verifies success. As part of this it pulls in the LootLocker package at ../../../ (root in this case is ./Library) which means it takes the current branch SDK and builds this. If there are compilation errors in the SDK or if the flow under test has fails the tests will fail.
.github/workflows <- This is the stuff necessary for setting up github actions.

main.yml is the important bit, it defines the job and uses pre-defined github actions from game ci.
activation.yml only needs to be run to fetch an activation token to be used in setting up the requirements for the headless unity runner.

GitHub changes <- The most important bit is that I have introduced 5 secrets to this repo. It's 3 unity license secrets utilizing my personal Unity license for the headless runner and then 2 LootLocker ones for an api key and a domain key to a test user with a set up game to communicate with. Any tests needing specific data thus needs to set this up in that game/user.

Using it
Right now it triggers on PRs (I hope opening them, and changes to them but haven't tested this yet) and I will try to make it also run on push to main. It is also possible to trigger manually. Everything exists under the actions tab above.

I have POCed this, let me know if you think it is actually useful and good enough as a structure to build on.

After a discussion in Discord we decided that the Test project should not live in this repo. It will bloat the size significantly and thus increase people's download times etc. So I've moved the test project to a separate repo: unity-sdk-tests. During CI testing that repo is now checked out as a step in the build and is used to test this repo.


More verbose error messages.

L10ns is AWESOME.
It has been a pleasure to use it this whole time. But now, I get an error when I run `l10ns update'
It simply says:
[error] Localizations update failed
L10ns should show more descriptive errors, so I can actually do something to fix it.

Never mind, found --stack flag.

thanks @nmn. I'm just curious what the stack shows?

genuine error in my code. Stack traces were super accurate. I just think this flag should be ON by default. We are all developers. We all like good error messages. This is why I even created the issue before I hunted for a flag.
The actual error was that I was calling the same key with different values, (second arg, obj)

@nmn Ok that error should actually be displayed regardless of stack option. I will fix it. Thanks for reporting.

Ok fixed in<EMAIL_ADDRESS>

Thanks!


function correlation_lags is added

This is my first PR . A function correlation_lags is added . Waiting for the review . I will be adding test cases in a day.

please, rewrite the test like the ones above it.
Also verify that it works locally with pytest before submitting it. Thanks

please, rewrite the test like the ones above it. Also verify that it works locally with pytest before submitting it. Thanks

Sorry, I couldn't understand what do you mean by this:
"Rewrite the test like the ones above it". Please specify what you are referring to @emcastillo

Sorry, can you fix the style errors that the CI reports? thanks

Hey @emcastillo .
I have been trying to figure out the style errors for which I had installed pre-commit and then made few changes but I was not able to get passed all the files which were failing so I tried to push the code may be the pre-commit was not allowing it due to the failed ones.
Please help me out .
[WARNING] The 'files' field in hook 'ci-generate' is a regex, not a glob -- matching '/*' probably isn't what you want here
[INFO] Installing environment for https://github.com/pre-commit/mirrors-autopep8.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
ensure no direct commit to master/vXX branch.............................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
fix utf-8 byte order marker..............................................Passed
check yaml...............................................................Passed
autopep8.................................................................Failed

hook id: autopep8
files were modified by this hook
flake8...................................................................Failed
hook id: flake8
exit code: 1

cupyx/scipy/signal/_signaltools.py:447:9: W605 invalid escape sequence '\l'
cupyx/scipy/signal/_signaltools.py:447:18: W605 invalid escape sequence '\s'
cupyx/scipy/signal/_signaltools.py:447:34: W605 invalid escape sequence '\l'
cupyx/scipy/signal/_signaltools.py:448:20: W605 invalid escape sequence '\i'
cupyx/scipy/signal/_signaltools.py:449:9: W605 invalid escape sequence '\o'
cupyx/scipy/signal/_signaltools.py:449:20: W605 invalid escape sequence '\l'
cupyx/scipy/signal/_signaltools.py:449:40: W605 invalid escape sequence '\l'
cupyx/scipy/signal/_signaltools.py:457:9: W605 invalid escape sequence '\l'
cupyx/scipy/signal/_signaltools.py:457:18: W605 invalid escape sequence '\s'
cupyx/scipy/signal/_signaltools.py:457:34: W605 invalid escape sequence '\l'
cupyx/scipy/signal/_signaltools.py:458:20: W605 invalid escape sequence '\s'
cupyx/scipy/signal/_signaltools.py:458:27: W605 invalid escape sequence '\i'
cupyx/scipy/signal/_signaltools.py:458:36: W605 invalid escape sequence '\i'
cupyx/scipy/signal/_signaltools.py:459:9: W605 invalid escape sequence '\o'
cupyx/scipy/signal/_signaltools.py:459:20: W605 invalid escape sequence '\l'
cupyx/scipy/signal/_signaltools.py:459:40: W605 invalid escape sequence '\l'
flake8 (cython)......................................(no files to check)Skipped
mypy.....................................................................Passed
mypy (install).......................................(no files to check)Skipped
check CI files are up-to-date (.pfnci/generate.py)...(no files to check)Skipped

test your code locally before submitting it to review please

Let's close this meanwhile :). feel free to reopen when you have updates!


[Feature Request]: SVAMP for CRITIC

Feature Description
Familiarize yourself with the repository and take a look the CRITIC repo, paper, and SVAMP.
There are 3 math reasoning tasks tested in the paper: GSM8k, SVAMP, TabMWP.
Currently, the CRITIC implementation only has prompts for HotpotQA and TriviaQA.
Add the SVAMP prompts and relevant logic to the current CRITIC implementation. You'll see that an agent's current structure is divided into cog/agent, cog/modules, and cog/functional/. This task will require you to make modifications in cog/prompts, but will also require you to test your code in all the other relevant modules cog/functional and cog/agent. CRITIC does not have any cog/modules.
What to submit:

[ ] Set up your environment via the CONTRIBUTING.md
[ ] Make a Pull Request (PR)
[ ] Add the prompts for SVAMP
[ ] Write a short notebook tmp.ipynb in cog/agent showcasing the agent ran on a sample question from the benchmark

[ ] Add print statements for all calls to the LLM for easier debugging + I can easily verify the outputs

[ ] Request a review from @alckasoc

If there is any additional logic for how CRITIC is tested on SVAMP (refer to the paper's repo), include these specifications in the PR description.
Feel free to ask me questions on slack if you're confused! Good luck!

I'll take this issue :)


[WIP]: Feat: integrate uv in the ci pipelines and the docs

Description
This PR fixes #1020
Summary
This PR does....

PR Checklist
Please ensure that:

[ ] The PR contains a descriptive title
[ ] The PR contains a descriptive summary of the changes
[ ] You build and test your changes before submitting a PR.
[ ] You have added relevant documentation
[ ] You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

[ ] Ensure that you have run the pre-commit hooks on your PR.

@Mr-Sunglasses , is this PR complete?

@Mr-Sunglasses , is this PR complete?

No this PR is still WIP


"window.newWindowDimensions": "inherit" does not inherit fullscreen/zen mode

Test item #18632

VSCode Version: Code - Insiders 1.9.0-insider (4265f5e35cb3ea8ba7e0cf6b14ec606b6f8647ea, 2017-01-24T10:37:36.620Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions: None

Steps to Reproduce:

Set "window.newWindowDimensions": "inherit"
In fullscreen (or zen) mode, a new window will get default size

Good catch. Note that zen mode is not part of this settings support, but fullscreen should work now.


Create njsscan.yml

Description

[ ] I have read and understand the CONTRIBUTING.md document in this repository

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

Thank you for the PR. However, adding additional CI steps isn't something we're looking at doing at this point in time.


Is there an equivalent of Squiggle's cdf?

See Squiggle docs (not much info there though).
Right now I'm doing something like this:
import squigglepy as sq
import numpy as np

samples = sq.norm(mean=0, sd=2) @ 10000
num_above_threshold = np.size(np.where(np.array(samples) >= 0.5))
print(num_above_threshold / len(samples)) # prints 0.4023

Which would be equivalent to this in Squiggle:
x = normal(0, 2)
1.0 - (x |> cdf(0.5)) // outputs 0.401

Is there already such a function in squigglepy? If not, it'd be convenient to have one built in. (I'd be happy to implement it if you want to add it, but up to you of course.)

I mainly implement this via:
import squigglepy as sq
import numpy as np
np.mean((sq.norm(mean=0, sd=2) >= 0.5) @ 10000)

What do you think of that?

BTW np.mean(sq.norm(mean=0, sd=2) @ 10000 >= 0.5) also works and saves you a few keystrokes

Oh cool that's nice enough, thanks! Closing this.


Support LMST/LTST and other time systems

efosse
https://jira.jpl.nasa.gov/browse/AERIEQS-230
Moderate
Surface missions on Mars require the ability to view activities within a given Martian Sol, which we all know is longer than an Earth day. Additionally, the unit of time spoke is typically Local Mean Solar Time (LMST) or Local True Solar Time (LTST). Both time bases are useful for Mission Planning.
I believe the values themselves can be retrieved from a SPICE Kernel but there is no way to have them be the default time unit display for an activity timeline.

@AaronPlave is working on a first implementation of this feature. We've discussed a lot of different possibilities for implementing this over the past few months, so I wanted to capture a few of the important points that are driving the way we think about it:

There is some variation in exactly how different missions calculate LMST. Even assuming they use the same formula, mission-specific SPICE kernels are needed to calculate it generally, since LMST is location-dependent. There are also occasionally other time systems that are used. For this reason, we think Aerie should support custom, user-provided time systems in general (of which LMST is one), rather than have Aerie itself implement LMST calculations.
Custom time systems need to be able to tell Aerie how to convert their times to & from UTC, and how to format them as a string. They may need to rely on other files/libraries to do this, namely by referencing a SPICE kernel.
Philosophically, it feels like the time system(s) and their used by a mission "should" be a part of the mission model - it is a property of the mission, and having it in the model would allow all other Aerie systems to make use of it.

However, the Aerie UI needs to be able to format & display time strings quickly, at "animation speed" - eg. to label the timeline cursor while the user is moving it around on the timeline, or to label the ticks on the timeline while it's being zoomed in and out.
Therefore, we don't think it's viable to only perform time conversions in the Aerie backend, since making an API call for every conversion would make the UI feel unacceptably slow. To support our current interactive time labeling, we need to be able to convert times on the frontend, in Javascript.

While there are good use cases for being able to convert between time systems in other parts of Aerie, such as simulation and scheduling, most of the interest from users seems to be focused on just displaying time labels in the UI in LMST. Therefore, we've decided to focus on just the frontend/UI implementation of time systems for our first version, and consider integrating with the backend/mission model later.
User research indicates that durations of time are usually (though not always) thought of by planners in terms of "earth time" (ie. UTC [or more precisely, "ET", Ephemeris time, since UTC leap seconds are not included]). Therefore our first implementation will focus on applying time systems to absolute time labels in the UI, not durations.

draft requirements to follow in next comment...

Time Systems v1 Requirements
Based on meetings with @AaronPlave here are the requirements we decided on for v1:

Provide a Javascript interface which defines the structure of custom time system "adaptations", ie. JS files/bundles which implement LMST & other time systems. This should include at least format and parse functions, which convert a UTC DateTime to and from a string representing the time in the custom system.
Implement a way for users to include/upload their time system adaptations in their Aerie deployment. This could take the form of a UI which lets the user upload/configure time systems, or could be as simple as placing the time system adaptation files in a certain directory in your aerie deployment folder before running the Docker containers, depending on implementation decisions.

This should take into account that a single adaptation may need multiple files, eg. a JS file + a SPICE kernel.

Provide a way for the user to specify their primary and secondary time systems, since we have labels which can show two time formats at once. For v1 this setting will apply to the entire deployment and affect all plans, rather than being plan-specific.
Update the Aerie plan timeline UI to use the configured primary/secondary time systems, if provided, to format any absolute time labels and tooltips in the UI (wherever it makes sense to do so).
Implement, likely in a separate repo, a set of Aerie "recommended" time system adaptations covering the most common use cases. This should include at least:

An LMST implementation which uses a SPICE kernel + the timecraftjs library to convert to LMST.
A local time zone conversion (eg. UTC -> PST)

Let me know if I missed anything!

@dandelany @AaronPlave how do you feel about adding the ability to customize the plan duration?
"1 sol" mars surface plans are rarely exactly 24 mars hours, and rounding is usually preferred. 37 sol plans would also show as 38 days.
I think SI units for activity span durations are still the way to go for V1

@dandelany @AaronPlave how do you feel about adding the ability to customize the plan duration dispay in the new plan form?
"1 sol" mars surface plans are rarely exactly 24 mars hours, and rounding is usually preferred. 37 sol plans would also show as 38 days.
I think SI units for activity span durations are still the way to go for v1

@joswig What about anchor offsets?