Full Recalculation Rollup not calculating SUM correctly of all child records

I submitted a prior issue #491 which may/may not be similar/related to this bug issue.  It is similar in that the rollup calculation is incorrect when performing a full recalculation rollup from the Recalculate Rollup tab.

I recorded a video here: https://www.loom.com/share/234985f295e34efe80f89d9382a5a4e9?sid=c5d15090-b303-4303-852f-9d7388eea1c3
The EXPECTED results should have been:

The ACTUAL incorrects results were:

Here are the debug logs (zip file) and the record Id of the record above with the incorrect results
Account Record Id =  0011C00002cfTvJQAU
Debug Logs.zip
Please let me know if you need any additional information.

If it'll help, I have read the documentation around Nebula logger and the nebula logger plug-in and plan on installing.

Thanks so much for providing all this detail. I will keep you updated.

@baobao917 I've managed to reproduce this issue after a lot of testing. The logs - and the video - were absolutely instrumental in helping me to understand where things are currently going wrong when the recalc is started from the app. I will continue to keep you updated.

@baobao917 I've managed to reproduce this issue after a lot of testing. The logs - and the video - were absolutely instrumental in helping me to understand where things are currently going wrong when the recalc is started from the app. I will continue to keep you updated.

@jamessimone Thanks.  By the way, I've got Nebula logger and the plug in installed for Apex rollup. I see it's created a bunch of logs and log entries (although I still am pretty unfamiliar with the tool and not sure what it all means), I'm more than happy to give you any information from that or if you need access to review them, I can provide that as well.

@baobao917 I should have all the info I need, thank you! I was hoping to wrap this one up before the weekend but I'm afraid the fix will have to wait till early next week to be released. Thank you again for all of your help with this, and for your patience as well.

@jamessimone I installed the update but it doesn't appear to have corrected the problem.  Here is a video.  Pls let me know what else you need from me.
https://www.loom.com/share/bf8d917af2fc4083bafabc5c56f336e8?sid=874b6bd4-03f3-4025-8262-51f1b76b170c

@baobao917 so sorry you're still experiencing issues, but it's exciting to hear that you have Nebula installed now, as that should make searching through the logs for this specific parent a lot easier. What I observed from the last few times you sent logs over were these lines in several logs (these are excerpts from the logs you sent over using 1.5.85):
DEBUG|Rollup v1.5.85: lookup record prior to rolling up:
{
  "attributes" : {
    "type" : "Account",
    "url" : "/services/data/v58.0/sobjects/Account/0011C00002cfTvJQAU"
  },
  "Id" : "0011C00002cfTvJQAU"
}

And then:
DEBUG|Rollup v1.5.85: lookup record after rolling up:
{
  "attributes" : {
    "type" : "Account",
    "url" : "/services/data/v58.0/sobjects/Account/0011C00002cfTvJQAU"
  },
  "Id" : "0011C00002cfTvJQAU",
  "Open_A_P_Balance_Aged_90_Days__c" : 0.10
}

Then, because this account has more than 500 children, it appears in another log: (once again using the rollup field from the above log):
DEBUG|Rollup v1.5.85: lookup record after rolling up:
{
  "attributes" : {
    "type" : "Account",
    "url" : "/services/data/v58.0/sobjects/Account/0011C00002cfTvJQAU"
  },
  "Open_A_P_Balance_Aged_90_Days__c" : 0.0,
  "Id" : "0011C00002cfTvJQAU",
  "Open_A_P_Balance_Aged_61_90_Days__c" : 0.00,
  "Total_Open_A_P_Balance__c" : -99.90,
  "Open_A_P_Balance_Aged_0_60_Days__c" : -100.00
}

So, by the time the parent has appeared in two log files, the value being rolled up was already wrong; it had been incorrectly cleared. The fix that I added in #503 should have addressed this by changing the way the field value tracking is performed across multiple batches. Clearly that hasn't proved to be the case. I'd be willing to bet that if you searched for that parent Id, 0011C00002cfTvJQAU within the log entries generated by the full recalculations you performed, you'd see them across three different logs (as that particular parent has > 1000 children; so, three times the batch size).
On the other hand - since now some of the values are calculating correctly, and all of your rollups are SUM-based rollups, it is a bit odd that these inconsistencies are continuing to appear. I'm going to try a full integration tests using a setup more similar to your own to try to track down the issue here - in the meantime, if you do end up finding any of those relevant log entries in Nebula Logger, let me know. Again, I appreciate your patience as we work together to resolve this issue for you.

Hi @jamessimone - I'm not sure I understood everything you were saying, but I went ahead and re-ran the process with nebula debugging turned on.  I then did a search of that parent Id on the log entries created.  This is what I got.

Would it be easier if I gave you access to my sandbox org?

judging by what you showed me from the loom video you uploaded last, those CPU timeouts are being inconsistently caused by the update statements (by the accounts being updated). I would try updating the Max Parent Rows Updated At Once value down to something like 250 (half the current amount of the batch chunk size, in other words), as that should help a bit.
I don't think I'll need sandbox access to fix this issue, but I will keep you updated

@baobao917, let's try this again with #506 - the new package version (which will be promoted and available for installation in production orgs momentarily) may address the other issue you were seeing here.

@jamessimone That did the trick! Thanks for your assistance!  Becoming a big fan of this app.

Awesome - glad to hear it. Apologies that took me a while to track down - it was due to a fairly obscure part of the code that it doesn't seem like anybody's had a problem with before! Quite the edge case, but I'm glad to have finally fixed it.

@jamessimone I found another example of a bug here where it isn't calculating correctly.  Different org but same type of rollup calculation and happening with the full rollup calculation from the Recalculate Rollup tab.  Should I open a new ticket? Or reopen this one with the details?

@jamessimone I saw your email reply (but don't see it in GitHub).  You had stated the following:

judging by what you showed me from the loom video you uploaded last, those CPU timeouts are being inconsistently caused by the update statements (by the accounts being updated). I would try updating the Max Parent Rows Updated At Once value down to something like 250 (half the current amount of the batch chunk size, in other words), as that should help a bit.

I don't think I'll need sandbox access to fix this issue, but I will keep you updated
Did you mean to lower it down to 5000?  The Max Parent Rows Updated At Once is defaulted to 5000 on Rollup Control

@jamessimone I just replied but deleted the reply.  If you received in email, you can disregard.  I got confused referring to one of your earlier replies

@baobao917 you're right in saying that the record count shouldn't matter when it comes to performing the full recalculations. Clearly though, there's still some sort of issue. This might actually be a time where it would be easier for me to diagnose in the sandbox so you don't have to continually be waiting for full recalcs to conclude.

@jamessimone Sure.  I can give you access to the sandbox.  How do you want me to do this?

Feel free to use my salesforce email<EMAIL_ADDRESS>

@baobao917 I've finally had the chance to re-investigate this issue over the past few days. I really appreciate your patience, as I had a few other in-flight updates I was trying to get out as part of #520. I've validated some changes in your sandbox that appear to be leading to the proper results. I'll be including these changes as well in the hopes that we'll be closing this one out for good

@jamessimone I spoke too soon.  I just did a full recalculation from the Recalculate Rollup tab for a grandparent rollup and having inconsistent results where many grandparents do not have the correct SUM of grandchildren records.  Do you want me to include details as a continuation of this ticket or do you want me to open a new ticket?

Let's open a new item for that. The grandparent side of the system works a bit differently than direct parent parts of the codebase, and given the other issues you have open on that front at the moment I'd expect them all to be related

@baobao917 as somebody who used to work 8 hours a day in Excel - let me just thank you again for the high quality videos you put together. This issue, in all likelihood, is a bit different from #523 (as mentioned previously) due to differences in the grandparent rollup code path. I have a bit of time tonight to look into both of these, thank you again for all of the work you put into documenting these issues.

@baobao917 is there any chance that the report and xlsx you linked to are coming from a different org? I just spot checked the first 7 accounts with discrepancies and in each case the value reported by Apex Rollup appears to be correct:

Parent Id
Apex Rollup value
Report value
Diff

0014w00003cpHePAAU
8.25
588.50
(580.25)

0014w00003cpMaCAAU
23.49
46.98
(23.49)

0014w00003dIfebAAC
0.00
107.62
(107.62)

0014w00003dIfeiAAC
59.82
179.45
(119.63)

0014w00003dIfelAAC
123.92
185.87
(61.95)

0014w00003dIffBAAS
0.00
83.36
(83.36)

0014w00003dIffEAAS
0.00
136.75
(136.75)

@jamessimone Yes, they are coming from the same org.  Pls see video below.
https://www.loom.com/share/68f702fe960543f49332dce2e6cdfcd3?sid=ea0dff8e-7b16-4a31-8ff3-d88fd99a2959

Do you have any insight into the records pulled by the report and the records I spot-checked, then?

Do you have any insight into the records pulled by the report and the records I spot-checked, then?

@jamessimone I'm not sure I follow.  In my video, I showed that values per my report vs the excel file are the same values.  (meaning they have the same values that don't agree to each other).
Would it be easier to do a screenshare/call to clarify?  I'll be online for another 1/2 hour.

Sorry, I had shut down for the night. It makes sense that the values in the report and the excel file are the same, because the excel is just an export of the report. However, when I spot-checked some of those same Accounts (the first seven of which I pasted above), I only found children records that matched the calculated total.

I double checked the first two records and the roll-up field value did not
SUM the balance of all the child records. I'll check the rest of those 7
sample records tomorrow.
On Wed, Oct 25, 2023, 9:10 PM James Simone @.***> wrote:

Sorry, I had shut down for the night. It makes sense that the values in
the report and the excel file are the same, because the excel is just an
export of the report. However, when I spot-checked some of those same
Accounts (the first seven of which I pasted above), I only found children
records that matched the calculated total.
—
Reply to this email directly, view it on GitHub
https://github.com/jamessimone/apex-rollup/issues/500#issuecomment-1780263782,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AY7A4O5XVUSQ6XFRWUZC5FLYBG2BNAVCNFSM6AAAAAA463ZAS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBQGI3DGNZYGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

@baobao917 it sounds like you're looking at the AcctSeed__Total__c field, but the rollup is set to run on the AcctSeed__Balance__c field. All of the discrepancies above are due to the difference between these two fields.

@jamessimone Ugh...sorry! Made a mistake with my report...result of multi-tasking and overworked.  I reran and it all tied out.  I'll reclose this issue.  Sorry for the waste of time!

No worries whatsoever, we were both working late. I just wanted to make sure we were looking at the same thing! Thank you for the update.


Challenge http://www.freecodecamp.com/challenges/waypoint-add-borders-around-your-elements has an issue

The page isn't recognizing that I have specified a border width and style. The code is rendered properly in the "Cat Photo App", but I can't advance to the next challenge. The code in question:
.thick-green-border {
border-color: green;
border-style: solid;
border-width: 10px;
}

This is a duplicate of #704.

Thanks for reporting this, @s-j-hadley. We've now fixed this.


fs package issue under LocalStorage

This is in relation to the error discussed here.
https://github.com/feathersjs-offline/owndata-ownnet/issues/44
I managed to get rid of the error regarding node-localstorage by installing these packages.
assert, constants, events, path, stream, and fs
however, the package fs has a security issue and it is now suggested to use fs-extra. . now I get a new error.

I am now clueless as to what to do. Here is my repo
https://github.com/messycoding/myfeathersofflinefirstproject
Note: This error will only show if I call
owndataWrapper(app, '/messages', {});

Hi,
When running npm run test I get
Is this consistent with what you see – or am I missing something?
/Michael
From: messycoding @.>
Reply-To: feathersjs-offline/owndata-ownnet @.>
Date: Tuesday, 20 July 2021 at 07.51
To: feathersjs-offline/owndata-ownnet @.>
Cc: Subscribed @.>
Subject: [feathersjs-offline/owndata-ownnet] fs package issue underLocalStorage (#46)
This is in relation to the error discussed here.
#44
I managed to get rid of the error regarding node-localstorage by installing these packages.
assert, constants, events, path, stream, and fs
however, the package fs has a security issue and it is now suggested to use fs-extra. . now I get a new error.
I am now clueless as to what to do. Here is my repo
https://github.com/messycoding/myfeathersofflinefirstproject
Note: This error will only show if I call
owndataWrapper(app, '/messages', {});
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thank you for the response, the latest React Native version has some Jest compatibility issues that is why you see errors when running the test "npm run test".
So the original error says:
Error: Unable to resolve module path
so I did npm install path, now the error says
Error: Unable to resolve module fs
so I npm install fs, now the error says  Unable to resolve module  assert, constants, events, and stream

I am thinking if this is a machine-related issue?

This probably has something to do with my mac . . thank you so much for the help. . I will now close the case thank you.

Hi,
After downgrading Jest to version 26 I got the test to work – without any problems with feathersjs-offline/client v1.0.8. Is this also your experience?
Regards,
Michael
From: messycoding @.>
Reply-To: feathersjs-offline/owndata-ownnet @.>
Date: Wednesday, 21 July 2021 at 02.20
To: feathersjs-offline/owndata-ownnet @.>
Cc: Michael Hillerström @.>, Comment @.***>
Subject: Re: [feathersjs-offline/owndata-ownnet] fs package issue underLocalStorage (#46)
Closed #46.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.


Get temptifly fix to avoid redirect in plugin

https://github.com/stolostron/backlog/issues/20794

/cc @jeswanke


webviz tf could not work well

I set a tf SAE_Rear, which y axis reverse. The arrow marker and box marker in below pic are both in the SAE_Rear coordinate, but the box markers are transfered correctly and the arrows not.

Actually, in Rviz, they are both transfered correctly

Can you share a sample bag that can be used to reproduce the problem?


:construction: collection grid temp fix

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Context

[x] Closes #4547
[ ] Requires deployment <>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[x] I've tested it at </bsx/collection>
[x] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Perfect

pay 30 usd
remove/adjust it in

#4444
#4532

😍 Perfect, I’ve sent the payout
💵 $30 @ 24.59 USD/KSM ~ 1.22 $KSM
🧗 FNyt7T1xdbhN7dagf7yGYCRJuE3R45VmTCE3tjzy1rKxa7y
🔗 0x5114359ff55d559c4cd44303322001431075a67c96c1f62b9ac6c8e6b97ee470
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Files:  UI for moving multiple files

This may be an unexpected feature, but one can move file by changing name to include path, for example to move a file one folder higher:

I was about to suggest renaming the label from "Rename" to "Move/Rename", but unfortunately "Rename" is disabled when more than one file is selected:

TL;DR
We seem to be missing UI for "moving multiple files": right now only way to do it is via repeated  drag&drop. One per each dir level, which makes it extremely painful if you want move /from/this/deep/dir/ to /some/other/one/.

Move to different folder is very important for me, I would like to move stuff uploaded by browser extension around easily.


Feature: color-code small/medium/large imports?

Would be nice if import sizes were colour coded (maybe configurable?)
I'm not 100% sure what webpack uses nowadays for determining what large imports are, but I'm sure we can come up with some sane numbers?
Just a though, love the plugin!

Added in version 1.2.0.
https://github.com/wix/vscode-import-cost/commit/1201a169f7ebddb85a21acc4813f403b9dc45686

// Upper size limit, in KB, that will count a package as a small package
"importCost.smallPackageSize": 50,
// Upper size limit, in KB, that will count a package as a medium package
"importCost.mediumPackageSize": 100,
// Decoration color for small packages
"importCost.smallPackageColor": "#7cc36e",
// Decoration color for medium packages
"importCost.mediumPackageColor": "#7cc36e",
// Decoration color for large packages
"importCost.largePackageColor": "#d44e40",


Create pretty diagrams of the stack at a few detail levels

In the index revamp meeting we identified that there is a lack of visual information orienting the user about where they are in the stack. We agreed that we need new diagrams that show the stack at the 1000-foot level and to zoom in on the specific areas (storage, auth, smart contracts/blockchain, BNS).
@jasperjansz agreed to take it on; assigning

For simplicity, I'm closing this issue as we are doing a lot of this work in #658


Update REPLs

Working Node.js REPL
Update Ruby + Python Polar#repl methods to accept a list of files instead of a boolean parameter.
Hook Ruby + Python REPLs up to readline

This looks great, and all work for me. I'm wondering if the RESET code for JS is correct because I get output in yellow, not white like the others.

I am also not a JS person, so can't really review for convention/style.

The RESET code is an ANSI escape sequence so it's standard across all of the languages -- it's for the terminal; not for the language itself.
The JS booleans being printed out in yellow sounds like this, but since colors: false is the default for util.inspect, I'm not sure why that would be happening. console.log says it shells out to util.format, which also apparently defaults to colors: false, so... I'm not sure. We can explicitly set colors: false if you think it's worth it.


Project Initialization

Description
Initializes the project with a quick start sample app written in Kotlin. This provides examples of how to invoke the pay sheet using an Order as well as using a Token (existing order ID).
Technical Details

The order package contains sample code for creating a new Order using the Checkout SDK as well as launching the Pay Sheet with that order.
The token package contains sample code for creating a new Order using the Orders API and then launching the Pay Sheet with that Order ID (also known as token or ec token). Keep in mind that creating an Order with this method requires using an app secret along with a client ID, for simplicity this is done using Retrofit in-app, with a production application this should be handled with a backend service where the secret can be securely stored.

Hi Cody!   Will you please add me as a reviewer?  Thanks!


For Swift 3/4 mode, do not treat IUOs in illegal positions as Optionals.

Instead, just emit a deprecation warning and suggest switching to Optionals.
The old behavior caused several projects to break, so before we change
the behavior here we need to investigate whether we can mitigate most
of those breaks.

@swift-ci Please smoke test

I missed updating one migrator input file.

@swift-ci Please smoke test


Ceil function with % and variable works inside editor and with debug build but not with release build

Godot version:
3.1 b243c26
OS/device including version:
Windows 10
Issue description:
My project working inside editor and with debug build but not with release build.
Here is screenshoot with working project, exported with enabled debugging

and here is screenshoot with project, exported without enabled debugging

Steps to reproduce:

Just export minimal project with debug and without and open it

Minimal reproduction project:
UP.zip

Your project will work if you attach your script to your UP node and replace this lines:
onready var number_of_pages_node : Label = get_node("Tlo/Dokument/OS/IloscStron")
onready var progress_node : TextureProgress = get_node("Tlo/Dokument/OS/CzasDoNastepnejListy")
onready var grid_node : GridContainer = get_node("Tlo/Dokument/SiatkaOfert")

Not really, a dynamically-typed language can still be strongly-typed (as GDScript is).

Shouldn't a strongly typed language throw an exception/crash when such error occurs?
I might be wrong, but how is type-checking working in build (exported project) when type information is lost? What about dynamically loaded code? Or is type-checking supposed to be only available for a compilation-time, so allowing unsafe (from typing perspective) code execution at runtime? Wouldn't JIT benefit from keeping type info around?

Reopening as I reverted #26562.

I am in 3.1-stable under Linux and this still happens.
This is a huge issue that shouldn't be ignored because it causes bugs that are very hard to solve, especially for beginners coming from other engines. The fact that it only happens on Release, makes it even harder to debug.
In our team, we spent the best part of a week trying to find a bug related to this issue, instead of implementing features for our game.

Discussing this on IRC, seems like the best solutions would be:

Adding type information to release builds, as long as it does not cause the resulting binary to grow too much.
Adding a mode to GDScriptCompiler in which it emits valid code even when type information is not available. That would mean assuming all engine functions are untyped.

If this causes too much of a performance impact, compiling GDScript to opcodes instead of just saving the source tokens should help.


Is it possible to adjust face plasticity?

I was trying to compare two models, fsgan Face Reenactment and first-order-motion-model (absolute coordinates): https://youtu.be/v0K1NDsQY_0?t=59
Around this timestamp (0:59) the animated character on the right (fsgan) makes an eyebrow movement, but in the left video the eyebrow movement is not noticeable. I've noticed also that facial expressions from the driving video are transferred in a less pronounced way (as if the face muscles of the target character were less movable). Is there a way to adjust some parameters to increase plasticity of the face, or would it require to retrain the model on my own datasets (for example, which specifically contain separate eyebrow movements)?

You could try to increase number of keypoints. Fsgan use 68 kp, while fomm use 10.

You could try to increase number of keypoints. Fsgan use 68 kp, while fomm use 10.

Thank you, I tried it (setting num_kp: 50 in vox-adv-256.yaml), but getting this error:
Traceback (most recent call last):
  File "demo.py", line 146, in <module>
    generator, kp_detector = load_checkpoints(config_path=opt.config, checkpoint_path=opt.checkpoint, cpu=opt.cpu)
  File "demo.py", line 44, in load_checkpoints
    generator.load_state_dict(checkpoint['generator'])
  File "/home/user1/miniconda3/envs/first/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1052, in load_state_dict
    self.__class__.__name__, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for OcclusionAwareGenerator:
	size mismatch for dense_motion_network.hourglass.encoder.down_blocks.0.conv.weight: copying a param with shape torch.Size([128, 44, 3, 3]) from checkpoint, the shape in current model is torch.Size([128, 204, 3, 3]).
	size mismatch for dense_motion_network.mask.weight: copying a param with shape torch.Size([11, 108, 7, 7]) from checkpoint, the shape in current model is torch.Size([51, 268, 7, 7]).
	size mismatch for dense_motion_network.mask.bias: copying a param with shape torch.Size([11]) from checkpoint, the shape in current model is torch.Size([51]).
	size mismatch for dense_motion_network.occlusion.weight: copying a param with shape torch.Size([1, 108, 7, 7]) from checkpoint, the shape in current model is torch.Size([1, 268, 7, 7]).

Should I change some other parameters?

It requires retraining.

Ok, got it, thank you


Wallet - Make Transfer

from discord

Stanislav_nspcc — 04/22/2021
Yes, that's creating NEP-17 token transfer TX and relaying it

I plan to add an example to the /examples/ folder which shows how to manually build a multi-signature transaction which withdraws the funds from the genesis blocks (which is nothing more but calling "transfer neo" from the consensus multisig address)

done


[e2e]: go workflow_dispatch branch1 config-ldflags slsa3

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/3653859465
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Fri Dec  9 02:29:17 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/3662189424
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Sat Dec 10 02:20:53 UTC 2022
Tests are passing now. Closing this issue.


engine: add titan metrics

What have you changed? (mandatory)
Add Titan related metircs
What are the type of the changes? (mandatory)

New feature (change which adds functionality)

How has this PR been tested? (mandatory)
No
Does this PR affect documentation (docs) or release note? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
Will add later

PTAL again @kennytm @zhangjinpeng1987 Thanks!

/run-integration-tests

/release

/release

PTAL again @kennytm @zhangjinpeng1987


style: making colorBox circular & cursor for improving UX

Made the color box to circular so that it will be less dominant while traversing through the code.
The default cursor says that color box is neither clickable nor selectable
This PR fixes no issue, it adds some styling to color box

Any reason why we have to make the border radius 50%?

As from a design perspective, it will be easier to read/skim through code, if the color box is circular.

we are not going to change the UX in near term, thanks for your help.


Split facility and facilitydetails serializers

Overview
To improve performance on the full facilities query, remove some
unrelated and expensive queries for other_name, other_contributors, and
other_addresses which are only needed for the details page.
Create a new FacilityDetailsSerializer and update the React app's
propTypes in tandem.
Update fetchSingleFacility Redux action to get data from the API
unconditionally rather than trying to get it from the existing
facilities data -- since the latter no longer containers some required
details data.
Remove unused utility function and test.
Connects #309
Testing Instructions

serve this branch then search from the main map and verify that it still works
visit a facility details page and verify that that still works too

Will this have any effect on the /list/{id} page?

Will this have any effect on the /list/{id} page?

Great question. Let me check.

Will this have any effect on the /list/{id} page?

I think the answer is no because the serializers there are not using the geojson serializer, but we may have reused the prop types in some way.

Looking at this now.

https://github.com/open-apparel-registry/open-apparel-registry/issues/314 is for the map height adjustments -- I gave it a design label.


Gravity should be a Vector2

Currently gravity is a float. Some games like to change the direction of gravity for various reasons.
Alternatively, to not break compatibility, an additional gravity_direction vector can be provided. It might also be worthwhile to just grab gravity from the physics engine itself instead using its own specific gravity value.

Absolutely, don't know why I didn't implement this as vector in the first place.
Will look into it in the next few days.

Done in recent commit.
You can grab the build from the latest build workflow.
I will create a release and the update will be on the Asset Library in a few days.

It might also be worthwhile to just grab gravity from the physics engine itself instead using its own specific gravity value.

I'd rather not do this, because these are two completely different systems.
Another option would be to provide a kind of physics material resource for ropes that can be shared.
However, I'm not sure which properties should be included in such a material and which not.
It also only makes sense if there are a lot ropes of the same kind whose properties need to be changed dynamically at runtime.
Hence, this is a problem for the future when there is a certain demand for it.


Core: some barriers are not processed correctly

See http://www.openstreetmap.org/way/143754364

Fixed in 7e724fd0f1975bd0dc1cf32f2e7f343158abc1f3


Chore: pointer refactor

This takes advantage of the smart-pointer stuff from #442 and a small optimization on go_register_variables. Through some benchmarks, this is just a tiny bit faster (but within a margin of error, so, at the very least, just as fast).
It introduces a (possibly contentious) idea that any C memory created in Go, must be released in Go -- which is new.
I'm also opening a PR with just the optimization in case we don't like this idea.
Beyond this, FrankenPHP cannot be optimized further without improvements in stack switching by Go itself.
I did some benchmarks; there is a slight (but barely detectable) improvement over the other PR:

branch
time per request (1.5 million requests - 95% quantile)
error

main
60.39ms
1.2ms

chore/pointer-refactor
59.20ms
1.3ms

chore/optimize
60.05ms
1.2ms

As you can see, for performance, this is a micro-optimization; however, I believe it can improve code maintenance since it delineates which language owns which bits of memory.

I like the idea, IIUC but I suspect that this will increase the memory usage if the PHP script is a long-running one.
For instance, we currently free the memory allocated for $_SERVER entries before starting the execution of the PHP script itself.
With this patch, we will do it after. If the PHP script is long and slow, we keep the memory for some time for nothing. WDYT?

we currently free the memory allocated for $_SERVER entries before starting the execution of the PHP script itself.
With this patch, we will do it after. If the PHP script is long and slow, we keep the memory for some time for nothing.

Oof, that is a good point that I didn't consider. I was thinking of how to start and finish the response faster, which would indeed use more memory, especially on longer-running scripts.
Anyway, I will close this as I was hoping for more performance gains than what was realized and I doubt the memory usage is worth the small gains.


Rename unsafe react lifecycle methods and update packages

Description
Rename the React lifecycle methods that are going to be deprecated according to their guidelines.
Checklist

[x] Set proper GitHub labels (e.g. v1.6+, ignore if you don't know)
[ ] Unit tests added or updated
[ ] Documentation added or updated
[ ] Example(s) added or updated
[ ] Update schema.json if there are changes to the viewconf JSON structure format
[ ] Screenshot for visual changes (e.g. new tracks or UI changes)
[x] Updated CHANGELOG.md

One question, does anything regarding react-resizable or react-sortable change?

Yes, they have the same  problem internally so React complains about them. Updating them fixed the issue in those libraries but we still get warnings from a couple other libraries (react-grid-layout). Whenever they release new versions we can update them as well.


AWS Lambda end of support for Node.js 12

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
No response
Amplify CLI Version
9.1.0
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
I did not
Amplify Categories
auth, function
Amplify Commands
add
Describe the bug
I received this email from AWS.

Looking into my lambdas, I noticed the autogenerated amplify lambdas for auth, are using Node 12 for their runtimes:

Expected behavior
Autogenerated Auth lambdas running on correct runtimes
Reproduction steps

amplify add auth
Go to lambda's console
List your lambdas an order by runtime

GraphQL schema(s)

# Put schemas below this line

Project Identifier
No response
Log output

# Put your logs below this line

Additional information
No response

Hey @alphonse92 :wave: thanks for raising this! Marking this as a duplicate of https://github.com/aws-amplify/amplify-cli/issues/10894 and https://github.com/aws-amplify/amplify-cli/issues/10887, closing in favor of tracking the existing items


Support for unicode control characters

According to this wiki article, XML 1.0 should accept unicode characters in the ranges U+007F–U+0084 and U+0086–U+009F, even though it notes their usage is highly discouraged.
Example:
const RAW: &str = "<?xml version=\"1.0\"?><Element>\u{007}</Element>";

fn main() {
    let parser = xml::EventReader::new(RAW.as_bytes());
    for res in parser {
        res.unwrap();
    }
}

$ cargo run
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error { pos: 1:31, kind: Syntax("Invalid character U+0007") }', src/main.rs:7:13

Eh, I thought I'd get away with following only the latest XML recommendation. But I guess I have to observe the version in the prolog, and adjust rules accordingly :/

I'm testing against W3C's XML test suite, which has tests for illegal characters, and it's a whack-a-mole — some tests require it to be one way, other tests require it to be seemingly opposite. The combination of allowed ranges I've picked currently pass highest number of tests out of the options I've tried…
What's unclear to me is relationship between XML version in the document prolog, version of the XML spec, and allowed characters. Did the XML 1.1 spec obsolete 1.0 spec, so I can say the parser is 1.1 and parse everything by 1.1 rules? Or does <?xml version="1.0"?> mean I have to apply old spec's character restrictions to that particular document.

You include \07 in your example, but XML 1.0 fifth edition states:
https://www.w3.org/TR/xml/#charsets

Char       ::=      #x9 | #xA | #xD | [#x20-#xD7FF] | [#xE000-#xFFFD] | [#x10000-#x10FFFF]  /* any Unicode character, excluding the surrogate blocks, FFFE, and FFFF. */

What's unclear to me is relationship between XML version in the document prolog, version of the XML spec (including 1.0 1-4ed vs 1.0 5th ed), and allowed characters. Did the XML 1.1 spec obsolete 1.0 spec, so I can say the parser is 1.1 and parse everything by 1.1 rules? Or does  mean I have to apply old spec's character restrictions to that particular document.

I see, didn't realize it'd be that complicated.

Char ::= #x9 | #xA | #xD | [#x20-#xD7FF] | [#xE000-#xFFFD] | [#x10000-#x10FFFF] /* any Unicode character, excluding the surrogate blocks, FFFE, and FFFF. */

🤔 guess I am actually getting invalid XML from some producer with more relaxed XML serialization then, thanks 🙇.

In 0.8.12 I've added XML-version-dependent check for allowed chars.


model_locations option does not works with model parameter

Hi, thank you for this package. I've found an issue.
model_locations option in the ide-helper.php file only works when running all models like
php artisan ide-helper:models
but if you want to use it for one model is not consider
php artisan ide-helper:models Mymodel DOES NOT WORK as it doesn't use model_locations option
php artisan ide-helper:models App\Models\Mymodel WORKS
Expected:
model_locations=App\Models
php artisan ide-helper:models Mymodel should work with file App\Models\Mymodel

And there is another issue:
app/Models
├── Foo
│   ├── Foo.php
├── Common
│   ├── FooBase.php
│   └── BarBase.php
├── Bar
│   ├── Bar.php
└── Traits
    └── ModelHelper.php

model_locations is app by default and we can use --dir option to add another location
the question is: how can i only proceed models file under app/Models/Foo directory
but not others?

Currently the model requires the FQCN. I don' think this should be change, you could have two models with the same name in different namespace but only mean one of them to be generated.
@barryvdh personal opinion, but I vote for not encouraging to support this :}


Command force:user:create throws an error but creates the User.

Summary
Our CI job needs to create a user that we will later use to run our test suite, but we're getting an error even though the user is successfully created:
ERROR running force:user:create:  Error authenticating with the refresh token due to: expired access/refresh token

Steps To Reproduce:
Repository to reproduce: dreamhouse-lwc

Authenticate to a devhub using sfdx force:auth:sfdxurl:store
Authenticate to a scratch org using sfdx auth:accesstoken:store
Create a user in the scratch org using sfdx force:user:create with a definition file.

Expected result
Successfully create the user without throwing an error.
Actual result
Receiving an error although the user is successfully created in the scratch org.
ERROR running force:user:create:  Error authenticating with the refresh token due to: expired access/refresh token

System Information

Which shell/terminal are you using? (e.g. bash, zsh, powershell 5, powershell 7, cmd.exe, etc.)

bash (Github Workflows)

{
  "cliVersion": "sfdx-cli/7.164.2",
  "architecture": "linux-x64",
  "nodeVersion": "node-v16.17.0",
  "pluginVersions": [
    "@oclif/plugin-autocomplete 1.3.0 (core)",
    "@oclif/plugin-commands 2.2.0 (core)",
    "@oclif/plugin-help 5.1.[12](https://github.com/CrisisTextLine/salesforce/runs/7975851330?check_suite_focus=true#step:5:13) (core)",
    "@oclif/plugin-not-found 2.3.1 (core)",
    "@oclif/plugin-plugins 2.1.0 (core)",
    "@oclif/plugin-update 3.0.0 (core)",
    "@oclif/plugin-version 1.1.1 (core)",
    "@oclif/plugin-warn-if-update-available 2.0.4 (core)",
    "@oclif/plugin-which 2.1.0 (core)",
    "alias 2.1.0 (core)",
    "apex 1.1.0 (core)",
    "auth 2.2.3 (core)",
    "community 2.0.0 (core)",
    "config 1.4.17 (core)",
    "custom-metadata 2.0.0 (core)",
    "data 2.1.2 (core)",
    "generator 2.0.2 (core)",
    "info 2.0.1 (core)",
    "limits 2.0.1 (core)",
    "org 2.2.0 (core)",
    "schema 2.1.1 (core)",
    "signups 1.2.0 (core)",
    "source 2.0.12 (core)",
    "telemetry 2.0.0 (core)",
    "templates 55.1.0 (core)",
    "trust 2.0.3 (core)",
    "user 2.1.0 (core)",
    "@salesforce/sfdx-plugin-lwc-test 1.0.0 (core)",
    "salesforce-alm 54.8.1 (core)",
    "texei-sfdx-plugin 1.16.1 (link) /home/runner/work/salesforce/salesforce/node_modules/texei-sfdx-plugin"
  ],
  "osVersion": "Linux 5.[15](https://github.com/CrisisTextLine/salesforce/runs/7975851330?check_suite_focus=true#step:5:16).0-10[17](https://github.com/CrisisTextLine/salesforce/runs/7975851330?check_suite_focus=true#step:5:18)-azure"
}

Additional information

Thanks for the issue @javierCTL, I am going to attempt to reproduce this. Was this working as expected in previous versions of the CLI?

Hey @iowillhoit thank you for answering. I'm afraid I can't tell, this is the first time we've tried this combination of commands.

Ok, I was able to replicate this using auth:accesstoken:store. A few things I noticed:

It does not seem to matter how you authenticated to the devhub. I am using JWT
Tested the scratch org auth with different methods

No error with JWT
No error with auth:device:login (web)
No error with auth:sfdxurl:store (web)
No error with auth:web:login (web)

I will get a ticket created to look into this. In the meantime (if you are able) you could use an alternative auth method to your scratch org.

Do you have any news about this issue? It's still preventing us from finishing our CI/CD

@javierCTL - this issue is in the queue to be worked on.

https://github.com/salesforcecli/plugin-user/pull/473


Removing JSDoc comments from d.ts files

I'm building my library with option to remove comments. At the same time I generate d.ts files for library.
Expectation is to remove comments from produced js files, and not from d.ts.
js is production file - I don't wan't comments there, d.ts is development - so JSDoc comment should not be removed even if remove comments flag is specified.

Duplicate of https://github.com/Microsoft/TypeScript/issues/14619

I think we should just change the behavior of --removeComments to exclude declarations.. I am sure some one will hate this behavior though :).

I'm sure of that too ... :) 2 parameters?:)
closing in favor of #14619


Interfaces ( inc & php ) changes for multiwan dhcp6 - Part 1

The additions and changes to these files are the first part needed to add multiwan dhcp6. They should not have any effect on single wan instances.

let's use the small refactor as a base d0fba889a57cb4f5
I don't think we should call legacy_interface_stats() to check the interface, since that could change afterwards as well. What was the reason for including this check?

if I remember I think I did it because dhcp6c gets upset if it gets called on an interface that's down.

Ok, we have to keep this in mind.
I have an idea how we can "outsource" the loop for all interfaces and support both old and new mode relatively easy. With 731922834c7ae we always write a unique IA-ID into the config. We keep the per-interface files, but merge them also into a single dhcp6c file. Maybe just transitional, but easier to keep track of the larger overhaul to be done still.

Hold on, there are now missing conf writes I'm just trying to work out where they got lost.

OK, something did get lost in translation but it was a fortunate as it caused me to re-look at a few things, namely the scripts...

I think we might have nailed it. I left it for a few hours, came back to it all working nicely still. Rebooted OK. checked RADVD in manual mode all good. I'll do some more thorough testing tomorrow.

Added your squashed PR to https://github.com/opnsense/core/pull/4088 to finish up and discuss


atom*: drop

Description of changes
https://atom.io redirects to https://github.blog/2022-06-08-sunsetting-atom/ which explicitly states No more security updates and the repo is archived since last November. This means atom is probably vulnerable to the recent libwebp and libvpx CVEs and probably more.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Ref to: #254798

ofborg-eval is unhappy due to various dependencies on atomEnv in nixpkgs.

I just checked a few atomEnv usages and it mostly seems like a legacy artifact before electron was really a thing and is in some cases not required at all.

I started all touched applications and they started up properly but I never went past login screens.

It would be nice to add a notice about Pulsar being the new Atom fork ;)

We can write that into the error message but I don't think we can just alias it without any user action required.

Please re-order the commits to put the atomEnv removal at the end (after its usages were removed). Otherwise LGTM.


Ability to lock out Mirador user interface controls

The ConservationSpace project has a need to deny certain users the ability to navigate through a manifest.  Instead, a canvas view will be reconstituted but users will only be able to view the resulting canvas as if it is a static image. No ability to pan / zoom, annotate, etc. will be enabled in this mode.
I imagine we would want UI Lock to be a Mirador start-up parameter and that the UI could be unlocked by an API if needed without having to reload Mirador.

I have to ask the question - why use Mirador to display, essentially, a static jpg (using the Image API)?

This is an edge case in the application but since we're using Mirador to reconstitute views, annotations might be displayed, or brightness / contrast adjusted, etc.  So Mirador is still required to reproduce the view - a IIIF image URL would be insufficient by itself.  I raised one eyebrow as well when I first heard of this requirement although I never followed up on this one because it sounded pretty easy to accommodate, but I'll dig into the user story a little more and supplement the description.

Given recent decisions about supporting different modes of Mirador based on whether a ConservationSpace author is editing vs. viewing, this is no longer a requirement, so I'm going to close the ticket.  Thanks for challenging the assumption.


Add support of clickhouse-log via podTemplates

Hello!
I want to override clickhouse-log container via podTemplates section.
I found that it's not possible in current version.
So I make some changes to support this feature https://github.com/Altinity/clickhouse-operator/pull/1012
I make it Draft because I don't check it and maybe I not found all places which should be changed.
I'm ready for any advises how to make it better.

PR https://github.com/Altinity/clickhouse-operator/pull/1012 was approved.


Using Cloudflare Adapter

Hey, I really like this project and would love to use it,
but currently I can't build it for Cloudflare.
Whole error message is below, but the node dependencies seam to be the problem.
Is it possible to change the build process to not use them?
If it's a lot of work, I would gladly contribute some solution myself, but I need to know what has to be done.
Thank you in advance. :)
Error Message
✘ [ERROR] Could not resolve "path"

    node_modules/@svelteness/kit-docs/node/index.js:1:19:
      1 │ import __path from 'path';
        ╵                    ~~~~~~

  The package "path" wasn't found on the file system but is built into node. Are you trying to
  bundle for node? You can use "platform: 'node'" to do that, which will remove this error.

✘ [ERROR] Could not resolve "url"

    node_modules/@svelteness/kit-docs/node/index.js:2:49:
      2 │ import { fileURLToPath as __fileURLToPath } from 'url';
        ╵                                                  ~~~~~

  The package "url" wasn't found on the file system but is built into node. Are you trying to bundle
  for node? You can use "platform: 'node'" to do that, which will remove this error.

✘ [ERROR] Could not resolve "module"

    node_modules/@svelteness/kit-docs/node/index.js:3:49:
      3 │ import { createRequire as __createRequire } from 'module';
        ╵                                                  ~~~~~~~~

  The package "module" wasn't found on the file system but is built into node. Are you trying to
  bundle for node? You can use "platform: 'node'" to do that, which will remove this error.

✘ [ERROR] Could not resolve "fs"

    node_modules/@svelteness/kit-docs/node/index.js:20673:46:
      20673 │ import { readFileSync as readFileSync3 } from "fs";
            ╵                                               ~~~~

  The package "fs" wasn't found on the file system but is built into node. Are you trying to bundle
  for node? You can use "platform: 'node'" to do that, which will remove this error.

✘ [ERROR] Could not resolve "process"

    node_modules/@svelteness/kit-docs/node/index.js:20685:21:
      20685 │ import process2 from "process";
            ╵                      ~~~~~~~~~

  The package "process" wasn't found on the file system but is built into node. Are you trying to
  bundle for node? You can use "platform: 'node'" to do that, which will remove this error.

✘ [ERROR] Could not resolve "stream"

    node_modules/@svelteness/kit-docs/node/index.js:20701:26:
      20701 │ import { Transform } from "stream";
            ╵                           ~~~~~~~~

  The package "stream" wasn't found on the file system but is built into node. Are you trying to
  bundle for node? You can use "platform: 'node'" to do that, which will remove this error.

✘ [ERROR] Could not resolve "crypto"

    node_modules/@svelteness/kit-docs/node/index.js:21245:27:
      21245 │ import { createHash } from "crypto";
            ╵                            ~~~~~~~~

  The package "crypto" wasn't found on the file system but is built into node. Are you trying to
  bundle for node? You can use "platform: 'node'" to do that, which will remove this error.

Not entirely sure how to resolve this since Cloudflare workers don't support Node. I'm also not sure why KitDocs is an issue when SvelteKit itself uses Node. Did you accidentally import from @svelteness/kit-docs/node in a client-side file such as a page?

Thank you for quick response. :)
Now I see that I've imported @svelteness/kit-docs/node as I followed the tutorial.
svelte.config.js:
  3  import preprocess from "svelte-preprocess";
  4: import { kitDocsPlugin } from "@svelteness/kit-docs/node";
  5  import Icons from "unplugin-icons/vite";

src/routes/kit-docs/[dir].sidebar.json.ts:
  1: import { createSidebarRequestHandler } from "@svelteness/kit-docs/node";
  2

src/routes/kit-docs/[slug].meta.json.ts:
  1: import { createMetaRequestHandler } from "@svelteness/kit-docs/node";
  2

From what I see in the documentation, I can create sidebar manually.
But I don't see such possibility for meta endpoint. :|
But it seems to be the correct direction, because when I changed the endpoints to return empty response, the build did work. :)

@mastermakrela Did you manage to resolve this.
This should work because all of the docs can be pre-rendered so I don't think node is needed at runtime.

This seems to be caused by an upstream bug/regression in Svelte Kit. I have created an issue here: https://github.com/sveltejs/kit/issues/9469


Workaround for tests to pass with new warning being triggered in auth

@sduskis this should resolve the CI issues for now

I'm experimenting with a potentially cleaner way of dealing with the warnings in our tests, please hold off on a review until I sound off.

As an interim solution, we can just pin to a version of auth that doesn't include the warning.


fix cypress_folder deprecation warning by internal code

internal code should use the new install_folder instead of the old cypress_folder method.

Thanks also for rewording the deprecation message -- that was confusing me yesterday :). This would have been much clearer, so I'm sure it'll help others.

Thank you


Uncaught Error: INVALID_STATE_ERR: DOM Exception 11:356

Invoked https cross domain call, which resulted in 404 status code. The same with 200 response working properly. But i got this error as an unhandled exception and unable to proceed.
Can you please look into this ?

It may be access denied to the response, because 404 page doesn't include CORS headers.

This issue is happening only in Stock Browser (4.3 Android) Samsung GT-i9300 phone S |||.
Its working properly in Android 4.4+ mobiles & chrome browser.

Oh, the Samsung 4.3 browser is awful. Sorry, we can't support it. It doesn't even have remote debugging, so it's very hard to check what's going on.

I found out where it was exactly crashing with this error by adding try / catch block, in the 'end' event of Request function.
Accessing status / statusText properties in the end event could have caused this problem.
As of now i wrapped the block with try / catch and invoked callback with error as empty and data as empty object.
Code Snippet:
try {
if (err) {
return self.callback(err, res);
}
	if (res.status >= 200 && res.status < 300) {
		return self.callback(err, res);
	}

	var new_err = new Error(res.statusText || 'Unsuccessful HTTP response');
	new_err.original = err;
	new_err.response = res;
	new_err.status = res.status;

	self.callback(err || new_err, res);
} catch (e) {

// In Samsung s3, reading property like status / statusText if invalid http readyState
// result in the error "Invalid DOM Exception: Internal state error"
// Raising the callback as successful response since its an exception occured for 404 status
// of https CORS request.
self.callback(null, {});
}
Please have a look and let me know if there are any issues. Can you also think about adding this to master code base ?

self.callback(null, {}); reports it was a success, so this is wrong to do that when an error happened. It will break other people's code.
Can you quote what error did you get exactly? Is res undefined? Is res an object, but res.status throws?

when i try to access res in the catch block to know the value, I am getting the same exception "Internal State Err: DOM Exception".
I think accessing the variable drives this problem. To get rid of this problem i thought of changing the library from superagent to x. Can you please identify the problem and add the same in the latest version ?

Thanks @RajeshSivanesan. Please try superagent 2.0.0-alpha.3

Thanks pornel.


Set the cloud storage credentials when opening a datatree from ZarrStore (#9197)

[x] Closes #9197
[ ] Tests added
[ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
[ ] New functions/methods are listed in api.rst

This look good, but I'm concern that it might break again in the future.
Is there any way we could test that storage_options gets passed on properly to Zarr? Maybe with a local directory store?

Hi Stephan,
Indeed I am not really sure how to efficiently set tests on this. It should probably rather focus on the ZarrStore rather than this backend higher-level API, since here we are only passing this kwarg storage_options to the store. What is always a bit difficult is to get the correct structure of this storage_options to correctly pass the credentials. This could be very carefully documented, but it depends on the backend.
Another possibility could be to have more like an integration test where we simply try to open a sample zarr product from a private cloud storage. This requires to have such a storage and to add the credentials in the CI environment variables.
Please tell me if this helps, or if I can investigate anything.

Is this made redundant by all the extra kwargs that were passed through by #9377? That PR also passes through storage_options.

Actually this PR is still needed because https://github.com/pydata/xarray/blob/19a0428005f255da1ae538d8db682f7f6f83cc4f/xarray/backends/zarr.py#L1259 doesn't pass through storage_options.
The fix here ideally would refactor to use _iter_groups to build a full dict to pass to DataTree.from_dict.

@vlevasseur073 please try this with main - I'm 80% sure we have already implemented what you need!


downloading

Discussed in https://github.com/S-codes14/smaller-sites/discussions/152

Originally posted by sidanuk August 20, 2022
HI
Not sure if this is the right area to post this. Pretty new to Git.
first of i love this. I do a lot of work with Mobirise, custom codes and blocks, so pretty excited about this , One quick question , if i try to use the download button it just creates a small file named download. is this not working yet.
Is it also possible to self host and use my own templates.
Thanks for your work

@sidanuk  i'll work on it today and give a PR soon so you can download it and immidiately use it

@mmestiyak That would be fantastic, looking forward to seeing if i can add new themes blocks etc. thanks in advance

@sidanuk  i'll for now only work on the download button so if you download you can directly run on the web the downloaded file


Merge branch 'master' into '0.2'

Coverage remained the same at 7.43% when pulling f577dcae7e6341b56320a7f56b63babaa9ff7ef8 on master into e6ee5766eebdca1138cf9b91527a6c92c67c48d6 on 0.2.

Coverage remained the same at 7.43% when pulling f577dcae7e6341b56320a7f56b63babaa9ff7ef8 on master into e6ee5766eebdca1138cf9b91527a6c92c67c48d6 on 0.2.


fix: RLIM_INFINITY type is uint64 on loong64

When I ported prometheus to loong64 I got this problem. I fix the problem by this PR.
Also I don't want to use build constraints to solve this, it doesn't look worth it.
zerrors_linux_amd64.go
zerrors_linux_loong64.go
I think the root problem is caused by golang. So I consulted the golang comminuty,  Bran C. Mills and peterGo gave me some advices but still can't explain how exactly this difference arises.
https://groups.google.com/g/golang-nuts/c/XTKcN5q8DaQ
A test for this.
https://go.dev/play/p/MJpePQDL-1A
I don't know how to sign CNCF's Developer Certificate, a reference link maybe help me.

Thanks!


UI support for pipeline notification config

Proposed changes
UI support for pipeline notification config

After:

Types of changes

New feature (non-breaking change which adds functionality)

Linked Issues

https://github.com/rancher/rancher/issues/15666
Further comments

@westlywright Done, Thanks for your review.


Nested paths will work even if there is no route for them

Version
4.3.1
Test Case
Steps to reproduce
Go to your example of 404 page
https://reacttraining.com/react-router/web/example/no-match
Click on "Will Match". The address will be changed to
https://1rlvm1j0q4.codesandbox.io/will-match
add anything after it like https://1rlvm1j0q4.codesandbox.io/will-match/fsadfsadfk
It will still render the same component, although the path is far from the one specified in
<Route path="/will-match" component={WillMatch} />
Expected Behavior
It should not render the same component, because path is not matching
Actual Behavior
It will renders the same component, although the path is not matching

This is what the 'exact' prop on routes is for:
https://reacttraining.com/react-router/web/api/Route/exact-bool
If you want exact to be the default behavior, we already have #4958 for that.


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-26-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3773

Questions ?
Please refer to the Backport tool documentation


Turn off lights when Kodi shutsdown/enters standby

Hey there anybody,
is there already a way to turn off the light when Kodi shuts down and/or enters standby?
If not I'd like to look into it - any further suggestions? Like wait for [x] minutes before lights-out to safely reach the bedroom at night ;-)
ciao
Anthrax

If Kodi supports something similar to "on exit" API point, it should be trivial using light transition time - e.g. 60 second transition time after app is closed. It's good thing to look into, but requires careful UX considerations - I don't always want them to be shutdown, rather select from the exit menu (quit & shut the lights down).


Repo not found

Hi Aaike,
I was just trying to install this via the instructions and got a "Repo not found" error when trying to use jspm directly like
jspm install gooy/aurelia-animator-greensock
It did install when I appended github on the begining of the address though
This does seem to have worked, though I've yet to use it for anything yet.
jspm install github:gooy/aurelia-animator-greensock
I'm guessing the registry needs to be updated? Maybe something with jspm changed?
Anyway thanks for your work.
-Cort

And when I add the plugin to my main configuration file, it hangs on the initial spinning animation.
If you can point me in the right direction I'd be happy to do the footwork to fix this, I'd actually like to use gsap as a general purpose animation library with svg's and aurelia if you have any tips or warnings about that as a direction. I was installing this as a way to figure out how to reference the configuration properties for greensock. Thininking that familiarizing myself with your plugin would help me figure out how these things are configured.
I can confirm that after using the line above that both greensock1.17.0 and gooy/aurelia-animator-greensock are in the jspm github package directory, but I'm hot sure where the configuration problem is.
Thanks for any thoughts if you have them.
-Cort


Update fork

Please update the fork, the swagger project has been completed in the base repository.
@thewilly

Doing it now. Thanks for the swagger project @ByBordex 👍


Make the gateway fast

#1530 reports a critical limitation in the gateways, where requests like /pay_invoice are handled serially, and so the gateway is not ready to serve multiple users at once!
Experiment.
Make gateway /info super slow, and try to issue multiple requests from gateway-cli info tool.

I used a 10s sleep in gateway handler for info requests
fedimint_api::task::sleep_until(Instant::now() + Duration::from_millis(10000)).await;
Issued 3 requests to source gateway info. Numbers are representative. Please account for some few seconds of human switching shell tabs to press ENTER on gw info (gateway-cli info) command

Observations:

Before gateway request handler changes included in this PR, all the requests would be handled serially!

Client requests are queued up, with longer and longer wait times for each subsequent request
Would be a terrible experience for clients that are calling into the gateway for services like /pay_invoice

After gateway request handler changes proposed  in this PR, the requests are now parallel

Client requests are handled in parallel using threads spawned by the gateway
Requests take as long as the logic of processing needs to operate. Simulated by the 10s sleep

Blocker

To apply these changes as an improvement to the gateway, we need some client logic changes to allow for thread safety.
https://github.com/fedimint/fedimint/blob/master/client/client-lib/src/lib.rs#L145-L150

#[derive(Copy, Clone)]
pub struct Client<C> {
    config: C,
    context: Arc<ClientContext>,
    #[allow(unused)]
    root_secret: DerivableSecret,
}
++++

Here is a script I used to to test parallel request handling in tmuxinator:
> cat stress.sh
#!/usr/bin/env bash

set -e

export connection_string
connection_string="$($FM_MINT_CLIENT connect-info | jq -e -r '.connect_info')"

function pingpong() {

  local cli
  local dir

  dir="$TMP/cli-${RANDOM}${RANDOM}"
  cli="./target/debug/fedimint-cli --workdir $dir"

  echo "join"
  $cli join-federation "${connection_string}" > /dev/null

  for loop_i in $(seq 10) ; do
    echo "recv $loop_i"
    local invoice
    invoice=$($cli ln-invoice 13 "foo${RANDOM}${RANDOM}" | jq -e -r '.invoice')

    $FM_LN2 pay "${invoice}" >/dev/null || echo "recv: FAILED ln2 pay ${invoice}"

    local ok
    for _retry_i in $(seq 20) ; do
      if $cli wait-invoice "${invoice}" | jq -e -r '.paid_in_tx' > /dev/null ; then
        ok="true"
        break
      fi
      sleep .2
     done

    if [[ "$ok" != "true" ]] ; then
       echo "recv: FAILED wait: ${invoice}"
    fi

    $cli fetch > /dev/null

    echo "send $loop_i"
    invoice="$($FM_LN2 invoice 12 "foo${RANDOM}${RANDOM}" "bar" | jq -e -r '.bolt11')"
    $cli ln-pay "$invoice" > /dev/null || echo "send: FAILED: ${invoice}"

  done
  echo "done"
}

for _i in $(seq 30) ; do
  pingpong &
done

wait

Maybe it will come handy.

@elsirion Has patches for this that go max further already.

Proposing as an improvement to on/after the new gateway design at #1337


#2077 File upload not displaying newly uploaded file

What's included?
Replace @input with @update:model-value for vue3.
Closes #2077
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?

find an exercise with applications
select the applications tab
choose an application
click the edit button to edit it
scroll down and ensure you can upload a self assessment or cv (if the file upload is available for the application)
once uploaded ensure it displays the file name and that you can click on the file name to download the file
try pressing the 'replace' button and uploading a different file
once uploaded ensure you can click the filename link to download it again

Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

I can't see an upload document button; can you include a screenshot of where it should be pls?


Support $$ in Stringer

The while result != ... will misbehave because $$ turns to $, so a bare substitution will be necessary on the LHS, e.g. while Template(result). substitute() !=, or something similar. May need safe_substitute` or something like that.
Consider that $$ may enter back into the result pattern at any time, therefore this cannot be handled prior to the loop.
An is_valid() check or straight up $$ in ... may also work.

Just need to handle $$ in sub-Stringers. This can be done by having a method which leaves the $$ in for the potentially recursive part, then an outer method that replaces the $$ with $ only at the very end of the uppermost Stringer.


issuee-167- new text on abou-us and added link to about_us in the he footer

new iteration:
about us alignment

footer update. link in "aqui" now follows to about_us


Dev Task: Side activities/systems

A side activity would be anything outside of the main combat loop. Things like collectibles, crafting mechanics, etc.
I don't know what the consensus is about these, so i propose a few to discuss about.

Alchemy

Players can find various materials by killing enemies, random loot or from merchants.
These may have a certain properties that when mixed, are added togheter to a single potion. This allows players to mix several potion effects into a single one. Players may save potion presets for quicker crafting.
Some more niche effects may be exclusive to player made potions or it may allow players to have more buffs than it would be otherwise possible with store-bought potions.
The amount of effects and their intensity contribute to a "potency" value, players can withstand a certain amount of "potency" at any given time. This potency wears off with the potion's effects.

Enchantments

Players can have an enchantment in each piece of equipment. Most enchantments have drawbacks and are meant to reinforce builds.
Most drawbacks are about stat shifting, rising one while lowering another.
Optionally, players could enchant themselves up to a certain amount of enchantments. With a similar mechanic to alchemy's "potency"

Stealth

Players could attempt to invade a dungeon causing the least amount of chaos possible for greater rewards.
Enemies would be alarmed by traps or by simple line of sight, but hardly due to hearing combat.
Players that do not stay hidden will end up attracting more enemies at a time, making fights harder. Some enemies may also damage loot when alerted, causing loot they where guarding to yield less rewards.

Hunting

Players could take bounties involving finding and killing a specific monster type.
This kind of activity does not grant any sort of marker or clue, it instead falls on the player's knowledge to find where a monster may be hiding.
The bounty may be for a specific monster instead of a type, in these cases the monster will be more powerful than their regular counterpart, and may often avoid fighting entirely, making players have to plan ahead or setup traps to get a chance at combat. Once
Monsters of this kind may roam around the entire map and have ways to remain hidden.
These monsters will often leave clues on their wake to give players an idea of where to find them.
in combat, these monsters will prefer to stop fleeing.

Artifact trading

As part of the usual loot, players may find seemingly useless scrolls, carvings or relics that someone COULD be looking for.
Players may keep these for later selling if they find anyone looking for them, but are otherwise nearly worthless when sold at a shop.
There is no guarantee that someone is looking for any of these, NPCs may randomly decide they want an artifact of X kind which may or may not exist in the world yet (from a code stand point).

Negotiation quests

Sometimes, a quest may involve getting something from another, random NPC.
The target NPC will usually want something in return, players may negotiate by offering to complete a quest for the target or simply by paying with specific items or gold.
Different targets may or may not accept certain things.
If the NPC is neutral or there is some justification for it, the players may fight them for it.
Players with high charisma or a related skill may attempt "rolls" on the target to reduce the requirements from the target, possibly completing it instantly.

Faction relations

Players may improve or harm their relations with specific factions due to a variety of activities.
Some quests may include a shift in faction relations towards the participating players
Some factions are in conflict with each other, in these cases, increasing/lowering relations with one past a certain point will affect the other. (improving relations with faction A from "disliked" to "neutral" will have no effect, but reaching "friendly" will cause their enemies to loose relations with the player)
High relations will cause the faction to give the player better prices and some other benefits.
Lowering relations enough will cause the player to be barred from entering the faction's "cities". Players may still accept quests from them, which will raise relations.

Nice proposals again. I think these better fit the beta release as they are additional to the base attack/level/class system.


[ConstraintSystem] Fail ~= synthesis if constraint generation fails

If constraint generation for application of ~= failed, that should
result in an immediate synthesis failure.
Also add __attribute__ ((warn_unused_result)) to generate* methods
to make it harder to make such a mistake in the future.
Resolves: rdar://92366212

@swift-ci please test

@compnerd I didn't know that __attribute__ ((warn_unused_result)) is not supported on Windows, should I make it a macro or is there a better option?
C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\include\swift/Syntax/Syntax.h(505): warning C4996: 'swift::syntax::RawSyntax::dump': only for use in the debugger
C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\include\swift/Sema/ConstraintSystem.h(4591): error C2059: syntax error: '('
C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\include\swift/Sema/ConstraintSystem.h(4591): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\include\swift/Sema/ConstraintSystem.h(4591): error C2059: syntax error: ')'
C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\include\swift/Sema/ConstraintSystem.h(4591): error C2059: syntax error: ')'
C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\include\swift/Sema/ConstraintSystem.h(4592): warning C4183: '__attribute__': missing return type; assumed to be a member function returning 'int'

Everything spelt with attribute is unavailable as that is a GNU extension (similar to how declspec is unavailable on Darwin).  I would prefer the standard [[nodiscard]] which should work on everything, though there might be a vestigial LLVM_NODISCARD macro.

@compnerd Thanks! I'll give it a try right now

LLVM_NODISCARD is what I have been looking for...

@swift-ci please test


[tool_crash] FileSystemException: Cannot create link, OS Error: Incorrect function., errno = 1

Command
flutter pub get

Steps to Reproduce

...
...
...

Logs
FileSystemException: Cannot create link, OS Error: Incorrect function.
, errno = 1
#0      _Link.throwIfError (dart:io/link.dart:263:7)
#1      _Link.createSync (dart:io/link.dart:184:5)
#2      ForwardingLink.createSync (package:file/src/forwarding/forwarding_link.dart:20:16)
#3      ForwardingLink.createSync (package:file/src/forwarding/forwarding_link.dart:20:16)
#4      _createPlatformPluginSymlinks (package:flutter_tools/src/flutter_plugins.dart:1029:12)
#5      createPluginSymlinks (package:flutter_tools/src/flutter_plugins.dart:964:5)
#6      refreshPluginsList (package:flutter_tools/src/flutter_plugins.dart:1055:5)
<asynchronous suspension>
#7      FlutterProject.ensureReadyForPlatformSpecificTooling (package:flutter_tools/src/project.dart:316:5)
<asynchronous suspension>
#8      PackagesGetCommand.runCommand (package:flutter_tools/src/commands/packages.dart:177:5)
<asynchronous suspension>
#9      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1161:27)
<asynchronous suspension>
#10     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#11     CommandRunner.runCommand (package:args/command_runner.dart:209:13)
<asynchronous suspension>
#12     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:281:9)
<asynchronous suspension>
#13     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#14     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:229:5)
<asynchronous suspension>
#15     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:62:9)

[✓] Flutter (Channel stable, 2.10.5, on Microsoft Windows [Version 10.0.22000.613], locale en-US)
    • Flutter version 2.10.5 at D:\FlutterSDK\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5464c5bac7 (3 weeks ago), 2022-04-18 09:55:37 -0700
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at C:\Users\madel\AppData\Local\Android\sdk
    • Platform android-32, build-tools 32.1.0-rc1
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Enterprise 2022 17.1.1)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Enterprise
    • Visual Studio Enterprise 2022 version 17.1.32228.430
    • Windows 10 SDK version 10.0.22000.0

[✓] Android Studio (version 2021.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)

[✓] VS Code (version 1.67.0)
    • VS Code at C:\Users\madel\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.40.0

[✓] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22000.613]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 100.0.4896.127
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 100.0.1185.50

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: stable
Creation framework version: 5464c5bac742001448fe4fc0597be939379f88ea
Plugins
path_provider-2.0.9
path_provider_android-2.0.13
path_provider_ios-2.0.8
path_provider_linux-2.1.5
path_provider_macos-2.0.5
path_provider_windows-2.0.5

Closing as duplicate of #66224


APT whitelist request for clamav

http://packages.ubuntu.com/precise/clamav
anti-virus utility for Unix - command-line interface

:+1:

:+1:


fix: bug with URL not working on google-chrome

Connects to #185

Coverage remained the same at 80.98% when pulling 40ce42e2ce009b9334191223f23551849ed549a8 on helio-frota:pr into ac49d5ffebbd662ff643f3954e33aaa9c9c287fd on bucharest-gold:master.


Update getting-started-with-wso2-api-controller.md

The command "./apictl" to start the CTL tool doesn't work and gives out an error as seen below.

Instead just running the command as "apictl" works and the directory structure for the configuration files ( <USER_HOME>/.wso2apictl ) gets created.

Yes it does make sense to generically say apictl , as ./apictl is specific to executing the command on Linux/Mac from the same path that the executable is located in.
Even in Linux/Mac, if the end user adds the ctl to the PATH, they will be able to execute this as simply apictl as well. So +1 for doing this change throughout our docs for consistency.


Test*IfNoneMatchHeader tests fail from time to time

Example:
--- FAIL: TestListUsersOKUsingExpiredIfNoneMatchHeader (0.01s)
	assertions.go:241:

	Error Trace:	users_blackbox_test.go:911

			users_blackbox_test.go:713

	Error:		Not equal: "Mon, 24 Jul 2017 17:18:57 GMT" (expected)
			        != "Mon, 24 Jul 2017 17:18:58 GMT" (actual)

Similar to https://github.com/fabric8-services/fabric8-wit/issues/1331

@sbose78 I think it's the same issue. Closing as a duplicate.


Show "Share"-URL + Possbility for Short-URLs (e.g with YOURLS)

That would be very useful that a paste, image or anything else uploaded would not only have the name displayed on the top right, but also the link, as well as the direct link it can be shared and viewed from!
Also a possible implementation for Short-URLs would be awesome to have, as an example from a self-hosted YOURLS-Server: http://yourls.org/

Short URLS are not possible as the seed (the part after the #) is a cryptographic key and we don't want to bring that under a good level of cryptographic strength. If you want to send your seeds to a URL shortener, you can do so, but we strongly recommend against it as it reveals your seeds to an unnecessary 3rd party.


Getting the error 404 in bot composer framework after implementation of the CLU

Getting the below error in bot framework composer

I also have doubt the endpoint URL in bot composer from the CLU project that I am using so kindly share the steps from where I have to get that Endpoint for CLU.
Kindly help me out:
Thanks & Regards,
Nisha

@Nishabhardwaj786
It would be great if you could add a link to the Microsoft documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!!


Remove iconv from the ruby build

It hasn't been needed since 1.8.7, and it needs to die with chef 12.
https://github.com/chef/omnibus-software/blob/92d13d4dc24edf5f28ed872e502fd9e6fb3a9b15/config/software/ruby.rb#L38-L42

The comment mentions nokogiri, is that no longer correct?

that was what came up, but there's no guarantee its the only c ext that accidentally links to libiconv if its there

I mean that we are still planning to distribute nokogiri as part of the Chef installers, so even if Ruby doesn't need it, ...

i don't think its required for nokogiri, i think it just gets promiscuously picked up by libxml2/libxslt if its there...

👍 Just need to check back when we kill it and make sure it's not coming in from the OS.

there's the omnibus health_check alarms that go off if we accidentally link to anything that isn't in the whitelist, which better not let us do that..

#5993


Do not duplicate frames to reach the video profile target framerate. Drop frames if the encoder can't keep up

This PR makes sure that the videorate plugin only drops frame if the input framerate is higher than the target, and does not duplicate frames to reach the target framerate in all cases.
This also marks the post decoder queue as leaky to avoid pipeline stalls if the encoder can't keep up.

The updated tests may fail because the xvimagesrc can't keep up 30fps, not that we don't duplicate frames, but I'll need to make sure on a better network. I'll update the test if so.

We should not publish this to cloud immediately and get some testing on it first.


I think this should fix unbound module Ast_404

I don't really know how OCaml works exactly, but my I think this fixes @rickyvetter's issue. @rickyvetter can you try on this branch and see if your issue is fixed?

@tekknolagi Do we still need this? I think Ricky has fixed this on his side.

Yeah I don't think this is needed. Closing since it's working on my end. Thanks for the help! :)

Thanks everyone. Mind explaining the fix for posterity

@rickyvetter added ocaml-migrate-parsetree to his package.json, as far as I am aware.

Ah, that's what I thought would solve the problem. @yunxing Note that our theory was correct.


delegate method that returns date only once the animation has finished

It would be nice to have a delegate method that returns the date only once the animation has completed. That way I don't start working with a date and call tableView.reloadData along the way, and the animation is cancelled by that action

I added a pull request for that, see https://github.com/Mozharovsky/CVCalendar/pull/137. Hope it helps.

Thanks @hffmnn !

@thomasbaldwin, @hffmnn: Guys, if this issue isn't solved, let me know, I'll reopen the thread.


[KYUUBI 4650][Improvement] LogDivertAppender supports reading RollingFileAppender pattern

Why are the changes needed?

close #4650
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #4653 (e4bb732) into master (4c2f1e6) will decrease coverage by 0.08%.
The diff coverage is 25.00%.

@@             Coverage Diff              @@
##             master    #4653      +/-   ##
============================================
- Coverage     57.64%   57.56%   -0.08%
  Complexity       13       13
============================================
  Files           579      579
  Lines         31901    31958      +57
  Branches       4263     4271       +8
============================================
+ Hits          18389    18397       +8
- Misses        11755    11793      +38
- Partials       1757     1768      +11

Impacted Files
Coverage Δ

...e/kyuubi/operation/log/Log4j12DivertAppender.scala
0.00% <0.00%> (ø)

...he/kyuubi/operation/log/Log4j2DivertAppender.scala
93.18% <33.33%> (-2.06%)
:arrow_down:

... and 16 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks, merged to master


Support Go to Definition

Apparently, when parsing with YARD.parse_string, it happens that constants are not well resolved.
module Controllers
  class BarController < BaseController
  end
end

To the above code, YARD::CodeObjects::ClassObject#superclass returns "BaseController" instead of "Controllers::BaseController" in that situation.


Linux | Add Flatpak Support

STATUS EP 2022 Sprint:

Hugo has been exploring packaging Mu as a flatpak under Arch Linux.
He attained a very good level of success.

NEXT:

He is about to share a PR towards Mu.
Which will then be adapted to pup.

:-)

This is my work on Flatpak for Mu: https://github.com/mu-editor/mu/pull/2304


base.html styles

this is a new design for our navbar and resposivity.

r

squash the commits..

@guy9050 done.


Parcel 1.8.1 Cannot read property 'package' of undefined

When i update to Parcel-bundle 1.8.1 and compile error:
Cannot read property 'package' of undefined
at Bundler.bundler.on (/Users/swift/dev/element-starter/node_modules/parcel-plugin-sw-precache/index.js:16:43)
at emitOne (events.js:116:13)
at Bundler.emit (events.js:211:7)
at Bundler.bundle (/Users/swift/dev/element-starter/node_modules/parcel-bundler/src/Bundler.js:288:12)
at
at process._tickCallback (internal/process/next_tick.js:188:7)

this is closed automatically by merging the related pr, but things are not fully done yet.
after I have done the rest fixes I will patch a new version. say 0.5.0 for now.

@swift1911 try out v0.5.1


No alive nodes found in your cluster

I've installed and configured the package and when ever I try to index a record, I keep getting this error:
OpenSearch \ Common \ Exceptions \ NoNodesAvailableException
No alive nodes found in your cluster

My OpenSearch cluster is online in AWS and I checked via the _dashboards and I am able to create/retrieve records via the dev tool fine. I am just not able to access it via this package.
I tried all of the following combination for the "host" and none of them work

search-myapp-aaabbbcccdddeee.us-east-1.es.amazonaws.com
search-myapp-aaabbbcccdddeee.us-east-1.es.amazonaws.com:443
https://search-myapp-aaabbbcccdddeee.us-east-1.es.amazonaws.com
https://search-myapp-aaabbbcccdddeee.us-east-1.es.amazonaws.com:9200

I've tested it in postman and it works fine

Any ideas?
PHP 8.2.1
Laravel 10.4.1

Connecting to Amazon OpenSearch Service

SigV4 signing configuration
'sigV4Region' => 'us-east-1',
'sigV4Service' => 'es',
'sigV4CredentialProvider' => true, // Default credential provider.
// Using a custom access key and secret
// 'sigV4CredentialProvider' => [
//     'key' => 'awskeyid',
//     'secret' => 'awssecretkey',
// ]

If you want to log all failing requests and responses, please set a PSR-3 logger to use for the client.
'logger' => (new Logger('opensearch'))->pushHandler(new RotatingFileHandler('opensearch')),

Thanks, after configuring the SigV4 signing in the config/scout.php for opensearch, I tried to index a record again and now I am getting a different error message:
Aws \ Exception \ CredentialsException

Error retrieving credentials from the instance profile metadata service. (cURL error 28: Connection timed out after 1001 milliseconds (see https://curl.haxx.se/libcurl/c/libcurl-errors.html) for http://<IP_ADDRESS>/latest/meta-data/iam/security-credentials/)```

I am little confused by this, because I did opt-in for a `Default credential provider` when I created the cluster initially.

Here's the security configuration for my opensearch domain cluster:
![image](https://github.com/zingimmick/laravel-scout-opensearch/assets/6196415/8c897b15-b522-4410-bb24-9f2a447fe0e6)

I believe I have this solved now. I was under the impression iAM user key/secrets weren't required because the domain was created with internal user database (username/password) and assumed that was enough.
I've fixed it doing the following:

Create a new iAM user and attach the OpenSearch policies (as required)
Create access key/secret for the new iAM user
Re-create the opensearch domain and Set IAM ARN as master user to the newly created iAM user
Then configure the scout config like this:

    'opensearch' => [
        'hosts' => [env('OPENSEARCH_HOST', 'localhost:9200')],
        'basicAuthentication' => [env('OPENSEARCH_USER', 'admin'), env('OPENSEARCH_PASS', 'admin')],
        'retries' => env('OPENSEARCH_RETRYS', 2),
        'sigV4Region' => env('OPENSEARCH_REGION', 'us-east-1') ,
        'sigV4Service' => 'es',
        'sigV4CredentialProvider' => [
            'key' => env('OPENSEARCH_IAM_KEY'),
            'secret' => env('OPENSEARCH_IAM_SECRET'),
        ],
    ],

Now i am able to index the records.


EmojiConvertor is not a constructor

I keep having this issue:
Uncaught TypeError: EmojiConvertor is not a constructor     at Object.wdtEmojiBundle.init (wdt-emoji-bundle.js:60)     at submit:40
This is the line:
self.emoji = new EmojiConvertor();

I had the same error as above, before I realized that I need to include emoji.min.js, just like shown in the demo file.
Also make sure you added entire wdt-emoji-popup to your html,


Google Cloud Exporter removes attributes from OTLP log entries

Issue
When using Logging exporter and Google exporter, I noticed that the Cloud Monitoring log entry did not contain attributes despite these attributes being present in the Logging exporter's output.
Logging exporter output:
Jun 10 15:56:04 fedora observiq-otel-collector[499827]: 2022-06-10T15:56:04.178-0400        DEBUG        loggingexporter/logging_exporter.go:82        ResourceLog #0
Jun 10 15:56:04 fedora observiq-otel-collector[499827]: Resource SchemaURL: https://opentelemetry.io/schemas/1.6.1
Jun 10 15:56:04 fedora observiq-otel-collector[499827]: Resource labels:
Jun 10 15:56:04 fedora observiq-otel-collector[499827]:      -> host.name: STRING(fedora)
Jun 10 15:56:04 fedora observiq-otel-collector[499827]:      -> os.type: STRING(linux)
Jun 10 15:56:04 fedora observiq-otel-collector[499827]: ScopeLogs #0
Jun 10 15:56:04 fedora observiq-otel-collector[499827]: ScopeLogs SchemaURL:
Jun 10 15:56:04 fedora observiq-otel-collector[499827]: InstrumentationScope
Jun 10 15:56:04 fedora observiq-otel-collector[499827]: LogRecord #0
Jun 10 15:56:04 fedora observiq-otel-collector[499827]: ObservedTimestamp: 2022-06-10 19:56:04.076019131 +0000 UTC
Jun 10 15:56:04 fedora observiq-otel-collector[499827]: Timestamp: 1970-01-01 00:00:00 +0000 UTC
Jun 10 15:56:04 fedora observiq-otel-collector[499827]: Severity:
Jun 10 15:56:04 fedora observiq-otel-collector[499827]: Body: a test message 2
Jun 10 15:56:04 fedora observiq-otel-collector[499827]: Attributes:
Jun 10 15:56:04 fedora observiq-otel-collector[499827]:      -> log_type: STRING(file)
Jun 10 15:56:04 fedora observiq-otel-collector[499827]:      -> log.file.name: STRING(messages)
Jun 10 15:56:04 fedora observiq-otel-collector[499827]: Trace ID:
Jun 10 15:56:04 fedora observiq-otel-collector[499827]: Span ID:
Jun 10 15:56:04 fedora observiq-otel-collector[499827]: Flags: 0

Google Cloud Logging:

Expectation
Open Telemetry log data model suggests that body should remain a string and parsed values should end up under attributes. With the Google exporter, I need to parse_to body as all resources and attributes seem to be omitted in Cloud Logging.
I have collectors running in onprem environments ingesting log data from many different sources. None of which line up with the http request that is given in the collector's example.
Config
My configuration looks like this, using the latest version of Open Telemetry Contrib
receivers:
  filelog:
    include: [ ./in ]
    start_at: beginning

processors:
  resourcedetection:
    detectors: ["system"]
    system:
      hostname_sources: ["os"]

  attributes:
    actions:
      - key: gcp.log_name
        action: insert
        value: test

exporters:
  logging:
    loglevel: debug

  googlecloud:

service:
  pipelines:
    logs:
      receivers:
      - filelog
      processors:
      - resourcedetection
      - attributes
      exporters:
      - googlecloud
      - logging

Hi @jsirianni, I think https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/424 will fix your problem. We weren't parsing the rest of the attributes to labels, which we should have been.

@damemi, will attributes be limited to map[string]string?

@jsirianni the GCP labels are limited to <string, string>, so attributes will be converted to that as well. Object attributes should end up as a json-encoded string value in the labels map

Thank you for jumping on this so quickly 👍


Create Code of Conduct

Nice work @Schow94! I have a question: is there a special reason for the Code of Conduct to be in a .github subfolder? Does that have some special meaning to GitHub? Otherwise I would probably have put it in the root folder next to the CONTRIBUTING guide, for example.

I saw that on another project, but I can move it to the project root folder if preferred. I don't see any reason why it needs to be in .github subfolder.

Yes, I think that'll make it easier to find. This page shows it being added to the root folder.

Nice work @Schow94! Thanks a lot.


Falcor: design and implement approach for specialization

This is strongly related to #16.
Given a shader with some set of "top-level" parameters, such as a Material, we need a way to inform the compiler that for a given variant to be generated, the implementation of that parameter's type should be specialized in a particular way (based on an actual run-time C++ object of type Falcor::Material in the Falcor case).
The ideal API interface is then relatively simple:

A shader entry point may include parameters (possibly declared at global scope) that belong to a high-level "module" type like Material or Light

When low-level code generation is requested for an entry point, we can specify a concrete type to substitute in for the parameter (any parameter where we don't specify this will ideally be left as a "generalized" parameter.

This seems to require a few things not present in the code today:

We need to flesh out the system for interface declarations (currently using the __trait keyword), and allow interface implementations and interface-typed parameters.

We need to split the code-generation API up (or at least support splitting it) into two phases:

An AST generation and checking phase, that produces a representation suitable for reflection
A low-level code generation phase, where the user requests compilation of one or more entry points into low-level code.

Actually, there might be a step (1.5) in that flow, which is where one creates target-specific "layout" objects from the raw AST objects to represent how parameters would be bound for a target.

Generics support and specialization in the API is working well. There is no reason to keep this issue open.