Dehumidifier tank status unknown

HA core version
2024.2.2
Current integration version
0.5.3
Last known working integration version
None
Device type and model
Dehumidifier 00000Q1A (161)
Working mobile app
Home Assistant
The description of problem
When looking into binary_sensor.DEVICE-ID_tank_full, I always see status „problem“, when the tank is full or „unknown“, when the tank is empty. Anyway, the status remained as „problem“ in both cases.
Therefore I currently ignore this binary sensor and use sensor.DEVICE-ID_tank instead, which gives at least 0%, or 100%, when full.
This was already the case, when I used the version of georgezhao. But, as I now realized, that you indeed continue to maintain this integration, I decided to mention it. Maybe, you will have a look at it.
Thanks.
The logs
Nothing to debug, no logs written

@Vetti52 thank you for reporting. Can you  please join HomeAssistant  on Discord and then contact me: chemelli74#2180

just checked with the A1 device source code, tank_full result should based on tank and water_level_set, if you tank works well and water_level_set also works well, it should be works.
so why you not add any debug log for it?
please enable debug log based on README and  attach the detail debug log.
thanks!

Here are the two Debugger files:
The first one is with dehumidifier powered, the second is with power plug
switched off.
HTH
Hello World @.***> schrieb am Mo., 19. Aug. 2024, 11:52:

just checked with the A1 device source code, tank_full result should
based on tank and water_level_set, if you tank works well and
water_level_set also works well, it should be works.
so why you not add any debug log for it?
please enable debug log based on README and attach the detail debug log.
thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/wuwentao/midea_ac_lan/issues/235#issuecomment-2296153189,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI35VLH66VOPP5WV3UTE4L3ZSG57XAVCNFSM6AAAAABK2IMFFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJWGE2TGMJYHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

2024-08-20 18:00:10.290 WARNING (SyncWorker_3) [homeassistant.loader] We found a custom integration hacs which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-08-20 18:00:10.292 WARNING (SyncWorker_3) [homeassistant.loader] We found a custom integration midea_ac_lan which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-08-20 18:00:19.193 ERROR (MainThread) [aiohttp.server] Error handling request
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/aiohttp/web_protocol.py", line 452, in _handle_request
resp = await request_handler(request)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/aiohttp/web_app.py", line 543, in _handle
resp = await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/aiohttp/web_middlewares.py", line 114, in impl
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 91, in security_filter_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 100, in forwarded_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 80, in ban_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 235, in auth_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/headers.py", line 31, in headers_middleware
response = await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 149, in handle
result = await handler(request, **request.match_info)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/websocket_api/http.py", line 51, in get
return await WebSocketHandler(request.app["hass"], request).async_handle()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/websocket_api/http.py", line 284, in async_handle
await wsock.prepare(request)
File "/usr/local/lib/python3.12/site-packages/aiohttp/web_ws.py", line 152, in prepare
payload_writer = await super().prepare(request)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/aiohttp/web_response.py", line 415, in prepare
return await self._start(request)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/aiohttp/web_response.py", line 423, in _start
await self._write_headers()
File "/usr/local/lib/python3.12/site-packages/aiohttp/web_response.py", line 503, in _write_headers
await writer.write_headers(status_line, self._headers)
File "/usr/local/lib/python3.12/site-packages/aiohttp/http_writer.py", line 130, in write_headers
self._write(buf)
File "/usr/local/lib/python3.12/site-packages/aiohttp/http_writer.py", line 75, in _write
raise ConnectionResetError("Cannot write to closing transport")
ConnectionResetError: Cannot write to closing transport
2024-08-20 18:00:20.669 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Connecting to <IP_ADDRESS>:6444
2024-08-20 18:00:20.675 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Connected
2024-08-20 18:00:20.676 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Enabling device
2024-08-20 18:00:20.676 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Status update: {'available': True}
2024-08-20 18:00:20.676 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Authentication handshaking
2024-08-20 18:00:20.989 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Authentication success
2024-08-20 18:00:20.990 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Sending: {'header': 'aa1da1000000000000a0', 'body': '00000000000000000000000000000000000000', 'message type': '.a0', 'body type': '.00'}
2024-08-20 18:00:22.041 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Received: {'header': 'aa1da1000000000000a0', 'body': '00a1a1a1000000000000000000000000000000', 'message type': '.a0', 'body type': '.00'}
2024-08-20 18:00:22.042 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Device protocol version: 0
2024-08-20 18:00:22.042 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Sending: {'header': 'aa20a100000000000003', 'body': '418100ff0000000000000000000000000000000001ab', 'message type': '.03', 'body type': '.41'}
2024-08-20 18:00:22.154 DEBUG (Luftentfeuchter) [midealocal.devices.a1] [142936511674070] Received: {'header': 'aa22a100000000000303', 'body': 'c800033c7f7f003700000000000000005a58000000000128', 'message type': '.03', 'body type': '.c8'}
2024-08-20 18:00:22.154 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: None,                                      water_level: 50, tank_full_calculated: False
2024-08-20 18:00:22.154 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'tank_full': False, 'power': False}, tank_full: False
2024-08-20 18:00:22.154 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 50, tank_full_calculated: False
2024-08-20 18:00:22.154 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'tank_full': False, 'power': False, 'child_lock': False}, tank_full: False
2024-08-20 18:00:22.155 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 50, tank_full_calculated: False
2024-08-20 18:00:22.155 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'tank_full': False, 'power': False, 'child_lock': False, 'mode': 'Auto'}, tank_full: False
2024-08-20 18:00:22.155 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 50, tank_full_calculated: False
2024-08-20 18:00:22.155 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'tank_full': False, 'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium'}, tank_full: False
2024-08-20 18:00:22.155 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 50, tank_full_calculated: False
2024-08-20 18:00:22.155 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'tank_full': False, 'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False}, tank_full: False
2024-08-20 18:00:22.155 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 50, tank_full_calculated: False
2024-08-20 18:00:22.155 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'tank_full': False, 'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55}, tank_full: False
2024-08-20 18:00:22.155 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 50, tank_full_calculated: False
2024-08-20 18:00:22.156 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'tank_full': False, 'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False}, tank_full: False
2024-08-20 18:00:22.156 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 50, tank_full_calculated: False
2024-08-20 18:00:22.156 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'tank_full': False, 'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0}, tank_full: False
2024-08-20 18:00:22.156 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:00:22.156 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'tank_full': False, 'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0, 'water_level_set': '0'}, tank_full: False
2024-08-20 18:00:22.156 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:00:22.156 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'tank_full': False, 'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0, 'water_level_set': '0', 'current_humidity': 90}, tank_full: False
2024-08-20 18:00:22.156 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:00:22.156 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'tank_full': False, 'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0, 'water_level_set': '0', 'current_humidity': 90, 'current_temperature': 19.0}, tank_full: False
2024-08-20 18:00:22.156 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Status update: {'tank_full': False, 'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0, 'water_level_set': '0', 'current_humidity': 90, 'current_temperature': 19.0}
2024-08-20 18:00:28.852 WARNING (MainThread) [homeassistant.components.energy.sensor] Found unexpected state_class None for sensor.tasmota_sml_total_kwh
2024-08-20 18:00:53.055 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Sending: {'header': 'aa20a100000000000303', 'body': '418100ff000000000000000000000000000000000249', 'message type': '.03', 'body type': '.41'}
2024-08-20 18:00:53.168 DEBUG (Luftentfeuchter) [midealocal.devices.a1] [142936511674070] Received: {'header': 'aa22a100000000000303', 'body': 'c800033c7f7f003700000000000000005a580000000002ca', 'message type': '.03', 'body type': '.c8'}
2024-08-20 18:00:53.169 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:00:53.169 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False}, tank_full: False
2024-08-20 18:00:53.169 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:00:53.169 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False}, tank_full: False
2024-08-20 18:00:53.169 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:00:53.169 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto'}, tank_full: False
2024-08-20 18:00:53.169 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:00:53.170 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium'}, tank_full: False
2024-08-20 18:00:53.170 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:00:53.170 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False}, tank_full: False
2024-08-20 18:00:53.170 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:00:53.170 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55}, tank_full: False
2024-08-20 18:00:53.170 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:00:53.170 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False}, tank_full: False
2024-08-20 18:00:53.170 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:00:53.170 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0}, tank_full: False
2024-08-20 18:00:53.170 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:00:53.171 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0, 'water_level_set': '0'}, tank_full: False
2024-08-20 18:00:53.171 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:00:53.171 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0, 'water_level_set': '0', 'current_humidity': 90}, tank_full: False
2024-08-20 18:00:53.171 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:00:53.171 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0, 'water_level_set': '0', 'current_humidity': 90, 'current_temperature': 19.0}, tank_full: False
2024-08-20 18:00:53.171 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Status update: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0, 'water_level_set': '0', 'current_humidity': 90, 'current_temperature': 19.0}
2024-08-20 18:01:23.219 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Sending: {'header': 'aa20a100000000000303', 'body': '418100ff000000000000000000000000000000000317', 'message type': '.03', 'body type': '.41'}
2024-08-20 18:01:23.323 DEBUG (Luftentfeuchter) [midealocal.devices.a1] [142936511674070] Received: {'header': 'aa22a100000000000303', 'body': 'c800033c7f7f003700000000000000005a58000000000394', 'message type': '.03', 'body type': '.c8'}
2024-08-20 18:01:23.323 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:23.323 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False}, tank_full: False
2024-08-20 18:01:23.323 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:23.323 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False}, tank_full: False
2024-08-20 18:01:23.323 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:23.324 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto'}, tank_full: False
2024-08-20 18:01:23.324 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:23.324 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium'}, tank_full: False
2024-08-20 18:01:23.324 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:23.324 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False}, tank_full: False
2024-08-20 18:01:23.324 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:23.324 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55}, tank_full: False
2024-08-20 18:01:23.324 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:23.324 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False}, tank_full: False
2024-08-20 18:01:23.324 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:23.325 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0}, tank_full: False
2024-08-20 18:01:23.325 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:23.325 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0, 'water_level_set': '0'}, tank_full: False
2024-08-20 18:01:23.325 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:23.325 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0, 'water_level_set': '0', 'current_humidity': 90}, tank_full: False
2024-08-20 18:01:23.325 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:23.325 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0, 'water_level_set': '0', 'current_humidity': 90, 'current_temperature': 19.0}, tank_full: False
2024-08-20 18:01:23.325 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Status update: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0, 'water_level_set': '0', 'current_humidity': 90, 'current_temperature': 19.0}
2024-08-20 18:01:53.378 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Sending: {'header': 'aa20a100000000000303', 'body': '418100ff000000000000000000000000000000000494', 'message type': '.03', 'body type': '.41'}
2024-08-20 18:01:53.487 DEBUG (Luftentfeuchter) [midealocal.devices.a1] [142936511674070] Received: {'header': 'aa22a100000000000303', 'body': 'c800033c7f7f003700000000000000005a58000000000417', 'message type': '.03', 'body type': '.c8'}
2024-08-20 18:01:53.487 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:53.487 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False}, tank_full: False
2024-08-20 18:01:53.487 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:53.487 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False}, tank_full: False
2024-08-20 18:01:53.487 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:53.487 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto'}, tank_full: False
2024-08-20 18:01:53.488 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:53.488 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium'}, tank_full: False
2024-08-20 18:01:53.488 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:53.488 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False}, tank_full: False
2024-08-20 18:01:53.488 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:53.488 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55}, tank_full: False
2024-08-20 18:01:53.488 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:53.488 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False}, tank_full: False
2024-08-20 18:01:53.488 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:53.488 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0}, tank_full: False
2024-08-20 18:01:53.489 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:53.489 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0, 'water_level_set': '0'}, tank_full: False
2024-08-20 18:01:53.489 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:53.489 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0, 'water_level_set': '0', 'current_humidity': 90}, tank_full: False
2024-08-20 18:01:53.489 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False
2024-08-20 18:01:53.489 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0, 'water_level_set': '0', 'current_humidity': 90, 'current_temperature': 19.0}, tank_full: False
2024-08-20 18:01:53.489 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Status update: {'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0, 'water_level_set': '0', 'current_humidity': 90, 'current_temperature': 19.0}
2024-08-20 18:10:19.513 WARNING (SyncWorker_2) [homeassistant.loader] We found a custom integration hacs which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-08-20 18:10:19.515 WARNING (SyncWorker_2) [homeassistant.loader] We found a custom integration midea_ac_lan which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-08-20 18:10:30.192 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Connecting to <IP_ADDRESS>:6444
2024-08-20 18:10:33.246 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Connection error
2024-08-20 18:10:33.250 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Connecting to <IP_ADDRESS>:6444
2024-08-20 18:10:36.316 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Connection error
2024-08-20 18:10:36.317 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Connecting to <IP_ADDRESS>:6444
2024-08-20 18:10:38.327 WARNING (MainThread) [homeassistant.components.energy.sensor] Found unexpected state_class None for sensor.tasmota_sml_total_kwh
2024-08-20 18:10:39.388 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Connection error
2024-08-20 18:10:39.388 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Enabling device
2024-08-20 18:10:39.388 DEBUG (Luftentfeuchter) [midealocal.device] [142936511674070] Status update: {'available': False}
2024-08-20 18:10:39.391 ERROR (Luftentfeuchter) [root] Uncaught thread exception
Traceback (most recent call last):
File "/usr/local/lib/python3.12/threading.py", line 1073, in _bootstrap_inner
self.run()
File "/usr/local/lib/python3.12/site-packages/midealocal/device.py", line 515, in run
raise CannotConnect
midealocal.exceptions.CannotConnect

thanks , please upload the log as file to current issue in future and not paste it.
in fact, just checked with your paste log line by line, I found your tank result is always 0.
and in this time, you may change the water_level from default 50% to 0, I'm not sure the reason, you have manual changed it ? the log and time as your log:
2024-08-20 18:00:22.156 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 50, tank_full_calculated: False
2024-08-20 18:00:22.156 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device after - new_status: {'tank_full': False, 'power': False, 'child_lock': False, 'mode': 'Auto', 'fan_speed': 'Medium', 'swing': False, 'target_humidity': 55, 'anion': False, 'tank': 0}, tank_full: False
2024-08-20 18:00:22.156 DEBUG (Luftentfeuchter) [midealocal.devices.a1] Device - tank: 0, tank_full: False,                                      water_level: 0, tank_full_calculated: False

after find out the water_level changed reason, we still need to check  your tank value, as it always 0.
you should provide both log file to use:

log file and app info requirement 1: when tank_full is false, check the tank/water_level/tank_full value from midea app and share midea_ac_lan debug log to us.

log file and app info requirement 2: when tank_full is true, and also check the tank/water_level/tank_full value from midea app and share midea_ac_lan debug log to us

@Vetti52  any updates for this issue and debug log file ?

Sorry, I did not follow this issue, because I was in contact with @chemelli74 at Discord, where he provided a solution for this issue. This solution seems to be included in the latest update. At least, the solution still works after updating to v0.5.7

@Vetti52  thanks, so we can consider there is no error exist with the latest version v0.5.7?
if yes, we will close this issue

@Vetti52 please test with current version, v0.6.1, and report back.
If still experiencing an issue, attach fresh debug log.

Hi!
I will test it, when i am back next week.
What delay will you expect between powering on/off and HA reporting
connect/disconnect?
Simone Chemelli @.***> schrieb am So., 6. Okt. 2024,
18:59:

@Vetti52 https://github.com/Vetti52 please test with current version,
v0.6.1, and report back.
If still experiencing an issue, attach fresh debug log.
—
Reply to this email directly, view it on GitHub
https://github.com/wuwentao/midea_ac_lan/issues/235#issuecomment-2395508370,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI35VLBCY2PF6SE36Z4B6TTZ2FT7NAVCNFSM6AAAAABK2IMFFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGUYDQMZXGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@Vetti52 did you get time to test ?

Hi!
Just back from vacation. First I updated to v0.6.5.
After powering the dehumidifier, it took about 5 minutes until it was
available in HA. 2 minutes delay of HA response, when unpowering it. This
is unusual in other devices, which respond much faster in HA. After
powering every action responded immediately. I had not yet time to activate
debugging. So, this is just a first observation. If you need more details,
i will activate debug and let you know. However, this will be not before
weekend.
Kind regards
Issues-translate-bot @.***> schrieb am Di., 15. Okt.
2024, 15:36:

Bot detected the issue body's language is not English, translate it
automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

@Vetti52 https://github.com/Vetti52 did you get time to test ?
—
Reply to this email directly, view it on GitHub
https://github.com/wuwentao/midea_ac_lan/issues/235#issuecomment-2413940255,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI35VLE2X5C72NFTFQMTIT3Z3UK4XAVCNFSM6AAAAABK2IMFFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJTHE2DAMRVGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

@Vetti52
thanks for your update.

for power on took about 5 minutes: it's a expected result. if you device is power on and your HAOS reboot, it will try to connect your device with 5s/10s/15s/25s//30s/35s/etc (with 5seconds *n) to increase, and the max value is 600 seconds, eg 10 minutes. as someone may power off the device for a long time, for example, we will plug the power with our AC device in winter. so we have reduce the retry intervel with a increase step(anyway, we also can slower down it, but just select 600 seconds now)
in your exaple, your HA device start at the first time,but your device is poweroff, so it increasing it.... when you power on it, the interval becom about 5-6 minutes( still not reach the max interval), so you got this result.

for power off took about 2 minutes: yes, it's also a expect result. we just retry with the loop every 10seconds with 12 times, so the total time cost should be 120 seconds.

if there is only this two issue, and most of the device feature works well when your device is power on, so it should work as expected.
thanks

@Vetti52 as there is no any new issue exist, I will close this issue.


Update UPFDeployment pods on a config-map update.

Initial implementation of configuration changes in UPF. 101
In case of config-map update, we update an Annotation in Spec.Template.Annotations that trigger a deployment rolling update.
For the time being, we update the existing config map rather than creating a new one. The best practice described below is a subject for R2 or further releases.
Per John:
The best practice would be to create separate ConfigMap as they change. Then, you update the ConfigMap that the deployment volume refers to, which automatically does the rolling update.
By doing this, we ensure that the old replica set doesn't pick up the new ConfigMap. So, if the old Pod restarts, it still has the old config.

/approve

/lgtm


Display and allow to kill queued queries

@dain I rebased and added tests for that so now it is much easier to understand what I actually fixed.

@dain Addressed your comments. Thank you for review!


feat: add Superchain CTA to chain metadata and associated assets

PR-Codex overview
This PR adds a new page for applying gas credits in the settings section. It also includes changes related to gas credits, buttons, and components.
Detailed summary

Added a new page for applying gas credits in the settings section
Updated button functionality for external links
Modified components related to applying for gas credits
Added new images for CTA backgrounds

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2641  👈
#2640
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on  Graphite

📝 Changed routes:

…d/settings/gas-credits

(view full size)

Commit a4d790b0c7eb3b27b819b57c13ea68ce208c94cf (https://thirdweb-o9d65hdeu.thirdweb-preview.com).


Falcon 40B Instruct not loading via sharding

System Info
System information:

Container version: text-generation-inference:0.9,
OS: Debian 11,
model: tiiuae/falcon-40b-instruct,
hardware (GPU): 2x NVIDIA A100 40GB.

Information

[ ] Docker
[X] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Reproduction
When running the following command in CLI:
docker run --gpus all --shm-size 1g -p 8090:80 -v $volume:/data ghcr.io/huggingface/text-generation-inference:0.9 --model-id $model --num-shard $num_shard   --trust-remote-code --quantize bitsandbytes
OR
docker run --gpus all --shm-size 1g -p 8090:80 -v $volume:/data ghcr.io/huggingface/text-generation-inference:0.9 --model-id $model --num-shard $num_shard --quantize bitsandbytes
The output is:
2023-07-13T13:36:19.887169Z  INFO text_generation_launcher: Args { model_id: "tiiuae/falcon-40b-instruct", revision: None, sharded: None, num_shard: Some(2), quantize: Some(Bitsandbytes), dtype: None, trust_remote_code: false, max_concurrent_requests: 128, max_best_of: 2, max_stop_sequences: 4, max_input_length: 1024, max_total_tokens: 2048, waiting_served_ratio: 1.2, max_batch_prefill_tokens: 4096, max_batch_total_tokens: 16000, max_waiting_tokens: 20, hostname: "f11e74984000", port: 80, shard_uds_path: "/tmp/text-generation-server", master_addr: "localhost", master_port: 29500, huggingface_hub_cache: Some("/data"), weights_cache_override: None, disable_custom_kernels: false, json_output: false, otlp_endpoint: None, cors_allow_origin: [], watermark_gamma: None, watermark_delta: None, ngrok: false, ngrok_authtoken: None, ngrok_domain: None, ngrok_username: None, ngrok_password: None, env: false }
2023-07-13T13:36:19.887192Z  INFO text_generation_launcher: Sharding model on 2 processes
2023-07-13T13:36:19.887285Z  INFO text_generation_launcher: Starting download process.
2023-07-13T13:36:26.484803Z  INFO download: text_generation_launcher: Files are already present on the host. Skipping download.
2023-07-13T13:36:28.050301Z  INFO text_generation_launcher: Successfully downloaded weights.
2023-07-13T13:36:28.050508Z  INFO text_generation_launcher: Starting shard 0
2023-07-13T13:36:28.050556Z  INFO text_generation_launcher: Starting shard 1
2023-07-13T13:36:35.775510Z  WARN shard-manager: text_generation_launcher: We're not using custom kernels.
rank=0
2023-07-13T13:36:35.775510Z  WARN shard-manager: text_generation_launcher: We're not using custom kernels.
rank=1
2023-07-13T13:36:36.063775Z ERROR shard-manager: text_generation_launcher: Error when initializing model
Traceback (most recent call last):
File "/opt/conda/bin/text-generation-server", line 8, in
sys.exit(app())
File "/opt/conda/lib/python3.9/site-packages/typer/main.py", line 311, in call
return get_command(self)(*args, **kwargs)
File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 1130, in call
return self.main(*args, **kwargs)
File "/opt/conda/lib/python3.9/site-packages/typer/core.py", line 778, in main
return _main(
File "/opt/conda/lib/python3.9/site-packages/typer/core.py", line 216, in _main
rv = self.invoke(ctx)
File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/opt/conda/lib/python3.9/site-packages/typer/main.py", line 683, in wrapper
return callback(**use_params)  # type: ignore
File "/opt/conda/lib/python3.9/site-packages/text_generation_server/cli.py", line 78, in serve
server.serve(
File "/opt/conda/lib/python3.9/site-packages/text_generation_server/server.py", line 166, in serve
asyncio.run(
File "/opt/conda/lib/python3.9/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/opt/conda/lib/python3.9/asyncio/base_events.py", line 634, in run_until_complete
self.run_forever()
File "/opt/conda/lib/python3.9/asyncio/base_events.py", line 601, in run_forever
self._run_once()
File "/opt/conda/lib/python3.9/asyncio/base_events.py", line 1905, in _run_once
handle._run()
File "/opt/conda/lib/python3.9/asyncio/events.py", line 80, in _run
self._context.run(self._callback, *self._args)

File "/opt/conda/lib/python3.9/site-packages/text_generation_server/server.py", line 133, in serve_inner
model = get_model(
File "/opt/conda/lib/python3.9/site-packages/text_generation_server/models/init.py", line 288, in get_model
raise ValueError("sharded is not supported for AutoModel")
ValueError: sharded is not supported for AutoModel
rank=0
2023-07-13T13:36:36.066811Z ERROR shard-manager: text_generation_launcher: Error when initializing model
Traceback (most recent call last):
File "/opt/conda/bin/text-generation-server", line 8, in
sys.exit(app())
File "/opt/conda/lib/python3.9/site-packages/typer/main.py", line 311, in call
return get_command(self)(*args, **kwargs)
File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 1130, in call
return self.main(*args, **kwargs)
File "/opt/conda/lib/python3.9/site-packages/typer/core.py", line 778, in main
return _main(
File "/opt/conda/lib/python3.9/site-packages/typer/core.py", line 216, in _main
rv = self.invoke(ctx)
File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/opt/conda/lib/python3.9/site-packages/typer/main.py", line 683, in wrapper
return callback(**use_params)  # type: ignore
File "/opt/conda/lib/python3.9/site-packages/text_generation_server/cli.py", line 78, in serve
server.serve(
File "/opt/conda/lib/python3.9/site-packages/text_generation_server/server.py", line 166, in serve
asyncio.run(
File "/opt/conda/lib/python3.9/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/opt/conda/lib/python3.9/asyncio/base_events.py", line 634, in run_until_complete
self.run_forever()
File "/opt/conda/lib/python3.9/asyncio/base_events.py", line 601, in run_forever
self._run_once()
File "/opt/conda/lib/python3.9/asyncio/base_events.py", line 1905, in _run_once
handle._run()
File "/opt/conda/lib/python3.9/asyncio/events.py", line 80, in _run
self._context.run(self._callback, *self._args)
File "/opt/conda/lib/python3.9/site-packages/text_generation_server/server.py", line 133, in serve_inner
model = get_model(
File "/opt/conda/lib/python3.9/site-packages/text_generation_server/models/init.py", line 288, in get_model
raise ValueError("sharded is not supported for AutoModel")
ValueError: sharded is not supported for AutoModel
rank=1
2023-07-13T13:36:36.687624Z ERROR text_generation_launcher: Shard 0 failed to start
2023-07-13T13:36:36.687660Z ERROR text_generation_launcher: Traceback (most recent call last):

File "/opt/conda/bin/text-generation-server", line 8, in
sys.exit(app())
File "/opt/conda/lib/python3.9/site-packages/text_generation_server/cli.py", line 78, in serve
server.serve(
File "/opt/conda/lib/python3.9/site-packages/text_generation_server/server.py", line 166, in serve
asyncio.run(
File "/opt/conda/lib/python3.9/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/opt/conda/lib/python3.9/asyncio/base_events.py", line 647, in run_until_complete
return future.result()
File "/opt/conda/lib/python3.9/site-packages/text_generation_server/server.py", line 133, in serve_inner
model = get_model(
File "/opt/conda/lib/python3.9/site-packages/text_generation_server/models/init.py", line 288, in get_model
raise ValueError("sharded is not supported for AutoModel")
ValueError: sharded is not supported for AutoModel
Expected behavior
2023-07-13T13:45:05.877003Z  INFO shard-manager: text_generation_launcher: Server started at unix:///tmp/text-generation-server-0
rank=0
2023-07-13T13:45:05.876999Z  INFO shard-manager: text_generation_launcher: Server started at unix:///tmp/text-generation-server-1
rank=1
2023-07-13T13:45:05.911486Z  INFO text_generation_launcher: Shard 1 ready in<PHONE_NUMBER>52s
2023-07-13T13:45:05.911486Z  INFO text_generation_launcher: Shard 0 ready in<PHONE_NUMBER>28s
2023-07-13T13:45:05.992600Z  INFO text_generation_launcher: Starting Webserver
2023-07-13T13:45:07.278040Z  INFO text_generation_router: router/src/main.rs:208: Warming up model
2023-07-13T13:45:09.544761Z  INFO text_generation_router: router/src/main.rs:217: Connected
Tested with model-id bigscience/bloom-560m which does work. So it seems this is Falcon specific? They did push a new commit on Huggingface 16 hours ago so can this have something to do with it?

They reverted the name change so this should be resolved.
Could you check that this is indeed the case?

They reverted the name change so this should be resolved. Could you check that this is indeed the case?

Yes, issue resolved.


network: add socket interface factory and config option

Add bootstrap config option that allows startup injection of a custom
SocketInterface.
Signed-off-by: Florin Coras<EMAIL_ADDRESS>Risk Level: Low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

WIP meant to help with #11618
cc @yanavlasov @mattklein123 @ggreenway

I agree that the spec would be desirable before committing to making changes, just so that everyone is one the same page about upcoming changes. @florincoras would you be able to write one up?

@yanavlasov, sure! Will share once I have something ready.

@yanavlasov here is a first draft of the document. It's not yet complete but I wanted to get it out ASAP to maybe discuss it during the community meeting

/lgtm api

Thanks @htuch! @mattklein123 @lizan @yanavlasov do let me know if you think this needs additional changes. Linux-x64 tsan is failing because of this. Do we need to wait for that to be fixed?

The TSAN is a known false positive. @lizan @yanavlasov @mattklein123 API LGTM, will defer the rest to you folks.

Thanks in general this looks great. Can you please add a test for this functionality? One option would be a small integration test with a fake socket that just proxies through to the default socket. Thank you!

Added a basic integration test. Not sure if it entirely captures what you expected so do nitpick if missed the point.

//test/extensions/filters/network/rbac:integration_test failed this time but nothing (apart from the extra test) changed. So I guess this is another flake?


[Feature] Possibility to download  a single file from the output dir instead of the whole output_directory

Context:
The output directory of a GROMACS simulation is big. Doing a simulation of a small protein for 100 ns results in a output with 5Gb. The biggest file is the precise trajecory file, with about 4.9 GB. To produce the visualization, I just need the  compressed trajectory file which is just some Mb.
At this moment, the inductiva.tasks.fetch_task_output() method downloads the full output_directory as a zip file.
Possible solution 1:
Upload to blob storage just the compressed trajectory file and erase the other auxiliary files.
Con: expert users may want to access other files to analyse, debug and produce more visualisations.
Possible solution 2:
Introduce two different methods:
inductiva.tasks.fetch_task_output_folder() where the folder is downloaded in its totality.
inductiva.tasks.fetch_task_output_file() where only a specific file is downloaded. This could then be used in the scenarios to download just the specific file with the method scenario.download_output().
Cons: To implement the download of a specific file, I don't think we can have the output in a zip file in the blob storage, to be able to access the specific location in the blob storage.
What do you think the best solution is?

The "con" you present for solution 2 isn't fully correct, because the files in a ZIP are compressed individually, we don't need to extract the full contents of the ZIP to access a single file. Check this: https://docs.python.org/3/library/zipfile.html, we can extract a single file from a ZIP.

Thanks for the suggestion @luispcunha, I will work on implementing this :)

solved in https://github.com/inductiva/inductiva-web-api/pull/213.


jfryman/selinux is depricated

The jfryman/selinux module is deprecated and he recommends puppet/selinux as a better option. This module needs to be updated to use the currently maintained module.

Ping, anyone alive here?


fix: Adding invite to app permission to fix share modal getting auto-closed issue

Description
A public app that the logged-in user doesn't have access to was auto-closing the share modal when opened. This was happening because we were fetching workspace even when the user did not have the invite to app permission. This is now fixed with this PR.
PR fixes following issue(s)
Fixes #26870
Type of change

Bug fix (non-breaking change which fixes an issue)

Testing
How Has This Been Tested?

[x] Manual
[ ] JUnit
[ ] Jest
[x] Cypress

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/ok-to-test

/build-deploy-preview skip-tests=true

/ok-to-test

Manually tested the issue looks good


[proposed label: Question] Can JsContextRefs and JsPropertyIdRefs be safely stored in an JsArray??

What I am hoping to do is add assorted JsRefs that I want to be keep around for a while into an array that I have done a JsAddRef on, with the theory that since the array will not be garbage collected, none of the JsRef's stored in it will get garbage collected, but then when I want to release them all, I just need to do a JsRelease on the array, and I don't have to set up a separate tracking system for those things. and do a JsAddRef/JsRelaseon on each of them individually. Since ContextRefs and JsPropertyIdRefs are not JsValueRefs however (although they typedef to the same type),  I am not sure if it is possible to safely store them in an array.

You are correct except that you can't do that with JsContextRef/JsPropertyIdRef because you can't store them in a JavaScript Array since they are not JavaScript Vars. The same approach is used in node-ChakraCore, e.g. HandleScope::AddLocal.

Close as this question seems to be answered already. Feel free to re-open otherwise.


fix(ably_api_key): Properly set the key when importing the resource

If imported the state would contain null and since at no point we used the response from ably to fill it we would never override it.
I am unable to test the acceptance test since I don't personally have an ably account I won't risk it in production.
If someone can run them from me and let me know if there is any problem I am more than welcome to fix whatever comes up.
#125

Hi, thanks for pointing this out, I'd not really considered how this would break when importing existing resources. However I think nulling the key is a bad idea as outputs and such would not have access to it. I think the best thing we can do here is add the key as another field of the import command. So we're not importing <appid>,<keyid>,<key>. What do you think?

Hey @Morganamilo my MR doesn't change the importing strategy it still is <appis>,<keyid> the only thing I changed is that when reading the value in the Read & Update function the key field is filled with the api response from the ably endpoint.
We don't need to pass the <key> when importing the resource it can be read programmatically.
The acceptance test I added does precisely that, we could just run it and see if it does what we expect it

Unfortunately I don't think I can run the CI with secrets passed in.
My point about changing the import input was my suggestion on what's best to do, not what I thought you did. The issue is the control API will never tell you any secret values after the initial creation. So it can't be read problematically.
This PR will just allow it to be null instead of erroring. But in reality a key is never null, so this is why instead I think we should not allow key to be null and require you to specify it on import.

Hi @Morganamilo
I did a quick test against the api https://control.ably.net/v1/apps/{app_id}/keys and as I expected the full keys are returned. This means we don't need to give the private key as part of the import process.
Here is my response
[
  {
    "app_id": "REDACTED"
    "id": "REDACTED"
    "name": "Root",
    "key": "REDACTED"
    ...
  }
]

My suspicions came from the fact that in the Ably UI you can get the full api key. I suspect the ably ui is a simple wrapper around the api so it only made sense that functionality was on par with the api.
The tests seem to be made to be run in a special integration environment from ably. Anyway you could run the tests locally to make sure it actually works.

Hey there. I've been on holiday sorry. When I started building this the API would not return secrets but it appears it does now? I need to see what's going on as it's a different team that works on the control API.

Hi @Morganamilo no worries.
Keep me updated on what your findings I still think the approach of not needing the key in the import statement is prefered as long as the key is provided through the api.

Hey @Morganamilo any updates?

Hey @Morganamilo you STOLE my code here and took the credit for it.
There is no point in having this opened any more a friendly notification for my effort put into making the ticket https://github.com/ably/terraform-provider-ably/issues/125 and this MR would have been nice, although I would have prefer not to have been robbed away.
Don't expect any more contributions from me or my company on any other ably products and I will recommend my company to move away from you guys as soon as we can.


Allow overriding admintools image tag

https://github.com/alexandrevilain/temporal-operator/blob/v0.19.0/internal/resource/persistence/schema_setup_job_builder.go#L126
temporalio/admintools for 1.23.1 is missing in the docker hub (link) - but temporal-operator always uses cluster version as the tag, thus I cannot deploy new cluster (unless the k8s node has the pulled image 😉 )
Probably we can do the same changes for all other images where image is configurable.
Update: reported https://github.com/temporalio/docker-builds/issues/237

Hi!
Thanks for reporting this issue.
This will be addressed in: https://github.com/alexandrevilain/temporal-operator/pull/760

I created #788 instead as I cannot wait for #760 - it's preventing from launching new cluster

Got hit with this as well, was able to work around by vendoring the container with a new tag, and updating the image to point to internal repo but definitely need a way to change tags for admintools since they seem to be released with very odd tags now.


[WFLY-14123] Add OSGI Headers for jboss-client.jar

Issue: https://issues.redhat.com/browse/WFLY-14123

@yersan I made the changes to name, please review.


aws-iot-device-client fails saying AWS_IO_TLS_ERROR_NEGOTIATION_FAILURE

Describe the bug
Starting aws-iot-device-client results in this:
./build/aws-iot-device-client --enable-sdk-logging
2021-11-04T10:22:26.159Z [WARN]  {Config.cpp}: Key {template-name} was provided in the JSON configuration file with an empty value
2021-11-04T10:22:26.159Z [WARN]  {Config.cpp}: Key {csr-file} was provided in the JSON configuration file with an empty value
2021-11-04T10:22:26.159Z [WARN]  {Config.cpp}: Key {device-key} was provided in the JSON configuration file with an empty value
2021-11-04T10:22:26.159Z [WARN]  {Config.cpp}: Key {publish-file} was provided in the JSON configuration file with an empty value
2021-11-04T10:22:26.159Z [WARN]  {Config.cpp}: Key {subscribe-file} was provided in the JSON configuration file with an empty value
2021-11-04T10:22:26.159Z [WARN]  {Config.cpp}: Shadow Name {shadow-name} was provided in the JSON configuration file with an empty value
2021-11-04T10:22:26.159Z [WARN]  {Config.cpp}: Input file {shadow-input-file} was provided in the JSON configuration file with an empty value
2021-11-04T10:22:26.159Z [WARN]  {Config.cpp}: Output file {shadow-output-file} was provided in the JSON configuration file with an empty value
2021-11-04T10:22:26.159Z [INFO]  {Config.cpp}: Successfully fetched JSON config file:
{
"endpoint":	"xxxx.iot.eu-central-1.amazonaws.com",
"cert":	"build/cert/cert.pem",
"key":	"build/cert/private.key",
"root-ca":	"build/cert/AmazonRootCA1.pem",
"thing-name":	"xxxx",
"logging":	{
"level":	"DEBUG",
"type":	"STDOUT",
"file": "/var/log/aws-iot-device-client/aws-iot-device-client.log"
},
"jobs":	{
"enabled":	false,
"handler-directory": "/root/.aws-iot-device-client/jobs"
},
"tunneling":	{
"enabled":	true
},
"device-defender":	{
"enabled":	false,
"interval": 300
},
"fleet-provisioning":	{
"enabled":	false,
"template-name": "",
"template-parameters": "",
"csr-file": "",
"device-key": ""
},
"samples": {
"pub-sub": {
"enabled": true,
"publish-topic": "topic_1",
"publish-file": "",
"subscribe-topic": "topic_1",
"subscribe-file": ""
}
},
"config-shadow":	{
"enabled":	false
},
"sample-shadow": {
"enabled": false,
"shadow-name": "",
"shadow-input-file": "",
"shadow-output-file": ""
}
}
2021-11-04T10:22:26.159Z [DEBUG] {Config.cpp}: Did not find a runtime configuration file, assuming Fleet Provisioning has not run for this device
2021-11-04T10:22:26.159Z [INFO]  {Main.cpp}: Now running AWS IoT Device Client version v1.4.4
2021-11-04T10:22:26.161Z [INFO]  {SharedCrtResourceManager.cpp}: SDK logging is enabled. Check /var/log/aws-iot-device-client/sdk.log for SDK logs.
2021-11-04T10:22:26.161Z [DEBUG] {Retry.cpp}: Retryable function starting, it will retry until success
2021-11-04T10:22:26.164Z [INFO]  {SharedCrtResourceManager.cpp}: Establishing MQTT connection with client id xxxx...
2021-11-04T10:22:53.294Z [ERROR] {SharedCrtResourceManager.cpp}: MQTT Connection failed with error: aws-c-io: AWS_IO_TLS_ERROR_NEGOTIATION_FAILURE, TLS (SSL) negotiation failed
2021-11-04T10:22:53.294Z [ERROR] {SharedCrtResourceManager.cpp}: Failed to establish shared MQTT connection, but will attempt retry...
2021-11-04T10:22:53.294Z [DEBUG] {Retry.cpp}: Retryable function returned unsuccessfully, sleeping for 10000 milliseconds
To Reproduce
Follow the instructions for building, configuring and running.
Expected behavior
There are no errors and the program creates a log file.
Actual behavior
Opening the MQTT connection fails as the log describes. The log file doesn't appear even though the console log says logging is enabled.
Environment (please complete the following information):

Docker container running Debian 10 under virtualized Debian 9
Device Client commit: db93d612a5ca2aa1c71c9293bd5102ad2c0d619b

I got a hint to try with ATS endpoint and that solved the issue.


Added feature OnValidate to execute before the handshake.

With this, it's possible to add one function that refuses the connection before the handshake.

:white_check_mark: Build Fleck 0.0.33-ci completed (commit https://github.com/statianzo/Fleck/commit/bb719eed65 by @)

:white_check_mark: Build Fleck 0.0.33-ci completed (commit https://github.com/statianzo/Fleck/commit/bb719eed65 by @)

It might be better to reject with an http status code vs disconnecting immediately. How is it handled in the node.js websocket this was modeled after?


introduce ISO disks support - add ContentType  Param when creating disk

ContentType param is a string that can contain:
"data" - default
"iso"
"hosted_engine"
"hosted_engine_sanlock"
"hosted_engine_metadata"
"hosted_engine_configuration"
see https://ovirt.github.io/python-ovirt-engine-sdk4/master/types.m.html#DiskContentType

Hey @eslutsky why do we need ISO support?

it's a nice feature and will benefit our tests, and a relatively easy change,  we can add it later .

This is a considerable amount of work, we won't do it unless we actually need it. It's a huge overhead for a few tests.


Rewrite tooling scripts in Python

I’m currently rewriting the tooling scripts from Bash to Python on the tooling/python-all-the-things branch.
Goals of the rewrite:

Contain it to only the tooling scripts. Package recipes should be unaffected by the change.
Make it easier to add features to the tooling scripts, which is quite a challenge in their current Bash form.
Add more sanity checks when parsing and building recipes.

If you’d like to suggest a specific feature for the rewrite, feel free to comment below. I’d like to keep the rewrite as focused as possible so that we can quickly merge it and move to other more productive things.

#85 #210 #8 and perhaps poke at #45

#85 #210 #8 and perhaps poke at #45

In the interest of not blocking other tasks that depend on this, I’m planning on splitting this in two independent PRs:

[ ] Rewrite of package-build and repo-build.
[ ] Rewrite of repo-check and repo-build-web.

In the interest of not blocking other tasks that depend on this, I’m planning on splitting this in two independent PRs:

[ ] Rewrite of package-build and repo-build.
[ ] Rewrite of repo-check and repo-build-web.

Closing this since almost everything has been rewritten to Python, except for the repo-check script, which is ununsed anyway since we haven’t really integrated reproducible builds into our workflow yet.


Add "serviceName" to ListIngressGatewayCredentialsRequest

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[x] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

/azp run

@JackTn this API is consumed by our Azure first party partner teams and the service side changes for this particular API for version (2023-03-15) is not rolled out yet. We also didn't announce this new API version to our partner team that uses it and confirmed with them that it is not being used.
Would this data be enough to ignore the Swagger BreakingChange check? Let me know if you need further clarification on this.

@mikekistler  can you review this breaking change? This is a new version that has no release yet!

This is a new version that has no release yet!

Please do not merge API definitions to main in the public repo until they are ready to release. If you are still developing/testing this API then we should hold off merging this PR until all the changes are done. Ping me when you are ready to release and I'll review any breaking changes at that point.

This is a new version that has no release yet!

Please do not merge API definitions to main in the public repo until they are ready to release. If you are still developing/testing this API then we should hold off merging this PR until all the changes are done. Ping me when you are ready to release and I'll review any breaking changes at that point.

@mikekistler the PR(link) for this API in our service is now ready to be merged and rolled out.

@pruthvidhodda Okay, I'll give you a mulligan this time. But going forward, please do not merge any API definition to main until it is thoroughly tested and ready to release.

approved

@msyyc  take a look on this pr and can you merge it ? Thanks


Automatically initialize the SourceKit-LSP server when creating a TestSourceKitLSPClient

Sending the InitializeRequest was always unnecessarily verbose. If we automatically initialize the server when creating the test client, the code becomes sufficiently concise that we can set up the client + server in the test method itself and no longer need the setUp methods, making the tests easier to read.

@swift-ci Please test


Error: Patch file found for package qrcodejs2 which is not present at node_modules/qrcodejs2

I'm trying to run a script to build my project on a GitLab CI runner....everything worked fine before installing this package. I get the following error when i run

npm install

Error: Patch file found for package qrcodejs2 which is not present at node_modules/qrcodejs2

I'm using the latest version of the package: 1.7.0-beta.5

Hi and thanks for your reply, the beta should not be used in production, please use version 1.64


Execute network request in current thread instead of main thread

Handle network request callbacks in whatever thread started it, instead of main thread.
The performance for JSON.parseJSONData is not optimized for large chunk of JSON data. Giving developer the choice of handling the network response in another thread make performance improvements possible.

Sorry, this PR did not solve the problem. Closing


傳上新的貢獻詞

https://github.com/g0v/itaigi/issues/259

Coverage increased (+0.1%) to 94.354% when pulling ca0c03ed79234d435f0bd104ec0206867c6c4a43 on 傳上新的貢獻詞 into b4f39ae2a78e0ec7408b8a71b6a623c9c57c5df7 on master.

Coverage increased (+0.2%) to 94.431% when pulling 07f7b63c35faf326f3a76984de241f047bbe6bda on 傳上新的貢獻詞 into b4f39ae2a78e0ec7408b8a71b6a623c9c57c5df7 on master.

Coverage increased (+0.2%) to 94.438% when pulling 22beb1394e5bab4244dc3c46c2c75f1841881650 on 傳上新的貢獻詞 into 3bb3d71989735cc216a4a39b48c7d5fa7ef58ebf on master.


Automate parser generation

Everything in the src/ directory is generated by tree-sitter from grammar.js, so really this should be the only file we care about when it comes to grammar changes. I'm not sure if we can outright remove the directory from the repository as I haven't been able to find any examples that do so, however, the scala tree-sitter automates the updating of src/ files using a sync workflow. It looks like a straightforward process but I'm not entirely sure how that will affect contributions...

src/scanner.c is written by hand :smile:
There are several benefits to keeping the generated files in source control:

A user can download the sources and compile the parser without requiring the tree-sitter CLI as a dependency.
The generated files can change when tree-sitter is updated. We can track the historical state of those files, without guessing about which tree-sitter version was used at the time.

The sync job is interesting. I guess the benefit would be automatically alerting us when a new version of tree-sitter changes how the files are generated?

Yeah, I also avoid opening parser.c because it freezes my editor...
I just checked out several other tree-sitter projects, and crystal's parser is the largest:
~/src λ ls -lh */src/parser.c
-rw-r--r-- 1 gabe gabe 9.7M Dec 15 17:33 tree-sitter-bash/src/parser.c
-rw-r--r-- 1 gabe gabe  17M Dec 15 17:33 tree-sitter-cpp/src/parser.c
-rw-r--r-- 1 gabe gabe  25M Dec 13 19:34 tree-sitter-crystal/src/parser.c
-rw-r--r-- 1 gabe gabe 1.5M Dec 15 17:32 tree-sitter-go/src/parser.c
-rw-r--r-- 1 gabe gabe 2.4M Dec 15 17:29 tree-sitter-javascript/src/parser.c
-rw-r--r-- 1 gabe gabe 2.5M Dec 15 17:27 tree-sitter-java/src/parser.c
-rw-r--r-- 1 gabe gabe 3.3M Dec 15 17:29 tree-sitter-python/src/parser.c
-rw-r--r-- 1 gabe gabe  15M Dec 13 21:16 tree-sitter-ruby/src/parser.c
-rw-r--r-- 1 gabe gabe 5.9M Dec 15 17:29 tree-sitter-rust/src/parser.c
-rw-r--r-- 1 gabe gabe  23M Dec 15 17:27 tree-sitter-scala/src/parser.c

And our grammar isn't complete, so it's only going to grow.
I wonder if using git's skip-worktree feature would help?

A lot of relevant info is summarized here: https://github.com/sogaiu/ts-questions/tree/master/questions/should-parser-source-be-committed


ES6 module compatible export

At the moment chai-enzyme doesn't use an ES6 compatible export for its top level module (build/index.js). This means that it's impossible to import the library using ES6 without the use of an implicit interop translation layer like webpack.
This poses a problem when compiling statically using something like TypeScript, because
import chaiEnzyme from 'chai-enzyme'

will be compiled to ES5 similar to
var chaiEnzyme = require('chai-enzyme').default;

Currently there is no default export from the library, so this will fail.
Would you be open to exposing an ES6 export rather than a commonjs style?

No. this exposes babel interop to clients, like the .default

Are there known problems with exposing .default from a commonjs module? I wasn't under the impression that a default property was specific to Babel, but rather it was the defacto standard for how ES2015 default exports are expressed in ES5.
That being said, .default isn't the only leakage, there's also the  __esModule property that's leaked. That could be avoided with just
module.exports = …
module.exports.default = module.exports;

Would you be open to that approach?
Another alternative is simply publishing ES2015 under jsnext:main.

No, there is no standard for ES modules because the module loading spec, and the interop with node, are both not finished yet.
Entry points should only ever use module.exports - export syntax is best used only within a project. jsnext:main is another nonstandard convention that's popped up that imo is harmful to the ecosystem as a whole, and I don't think this project should support it.

I'm with @ljharb on this one, in the beginning of the project we switched from export to module.exports btw

Regardless, it's impossible to do modern web dev without browserify or webpack (or similar) - I don't think that's a use case that needs much consideration.


Fix typo in package.json

Fixes #530
fix typo that was blocking require.resolve()

Oh, that's a good one, thanks!


Mo' Bends compat

Hello, I saw that in the last update there was a fix https://github.com/copygirl/WearableBackpacks/pull/82 to make mo' bends compatible but I still cant see them work together. Sorry if i am missing something here as I see it working in the gif.
As seen on the image the backpack equipped as chestplate gives armor but it's not rendered

Mods:
WearableBackpacks-1.12.2-3.1.3
Mobends-0.24

Looks like it works in Mo' Bends 0.25 test builds that are not in curse.

Ah that's awesome. I thought I remembered there being something done on Mo' Bends' end for compatibility with this mod.


website: put download buttons on install page

The buttons at the top of golang.org/dl/ should be on golang.org/doc/install

Is this about the top menu or the featured downloads, or even something else no longer there after the site relooking ? At this point the top menu is the same, only the page width differs, with dl/ being width constrained and doc/install being fluid.

@ALTree Looks like this can be closed? Did I misread something here?

Yeah I think it's about the "Download Go for Windows" button which is now present on https://golang.org/doc/install too. I think we can close.


Update README.md

Packages impacted by this PR
@azure-rest/ai-vision-image-analysis
Issues associated with this PR
Describe the problem that is addressed by this PR
Broken links in readme.md
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
N/A
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
APIView has identified API level changes in this PR and created following API reviews.
@azure-rest/ai-vision-image-analysis


Crash cancelling ServiceGroup.run() in Swift 6

With Swift 6 nightly: swift-6.0-DEVELOPMENT-SNAPSHOT-2024-04-06-a
I get a crash when cancelling ServiceGroup.run
struct TestService: Service {
    func run() async throws {
        try await gracefulShutdown()
    }
}
await withThrowingTaskGroup(of: Void.self) { group in
    let serviceGroup = ServiceGroup(
        configuration: .init(
            services: [TestService()],
            gracefulShutdownSignals: [.sigterm, .sigint],
            logger: Logger(label: "JobQueueService")
        )
    )
    group.addTask {
        try await serviceGroup.run()
    }
    group.cancelAll()
}

It crashes on this line with a EXC_BAD_ACCESS https://github.com/swift-server/swift-service-lifecycle/blob/f5780d95bdf3f740f14decb6c8c823815c883451/Sources/ServiceLifecycle/ServiceGroup.swift#L498
Swift --version output
swift-driver version: <IP_ADDRESS> Apple Swift version 5.10 (swiftlang-<IP_ADDRESS> clang-15<IP_ADDRESS>)
Target: arm64-apple-macosx14.0

@adam-fowler are you able to reproduce this still?

Ok it seems to have resolved itself


QC: Only run pkgdown-dev on push to dev

QC Details
The PR of dev into main (#1732) triggered pkgdown-dev.yaml to run. That is intended to run when something is pulled into dev, not for any PR involving dev. Update the action to only run when a PR is merged into dev.
Additional Comments

@jonthegeek can we get this fix in before tomorrow by chance?


API not found, it's 404

https://tools.cornerstonejs.org/api/     it's 404

same here

the same problem

+1

There is a related issue floating around where I call out how we generate this page, and that this issue is up for grabs.

Duplicate of #1152 ?

did you find it？


Missing pointRadius attr declaration in PointPrefixedOptions

Expected behavior
Declaration of lineTension attribute in Typescript type of PointPrefixedOptions
https://github.com/chartjs/Chart.js/blob/master/src/types/index.d.ts#L2008
Current behavior
No declaration of lineTension attribute in Typescript type of PointPrefixedOptions
https://github.com/chartjs/Chart.js/blob/master/src/types/index.d.ts#L2008

Reproducible sample
https://github.com/chartjs/Chart.js/blob/master/src/types/index.d.ts#L2008
Optional extra steps/info to reproduce
No response
Possible solution
No response
Context
No response
chart.js version
v4.2.1
Browser name and version
No response
Link to your project
No response

Need to look where lineTension comes from but in the docs its descibed as ``tensionusing it liketension` it works fine:
https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAbzgYQBYENZwL5wGZQQhwDkAxhrAHQBWAziQNwCwAUGwG6ZxkwAecALxwAJhDIBXEAFMAdjCoBzaTACiAG2kz5AIQCeASREAKAEQg9aTDFMBKOOjpwAEgBUAsgBlk6WVzoaWnIwLKxcUHAWVljCstIA7iiUMMa8fAA0iGxwOXAwemDSAFyk6sBxJOnZuSLoMOglCNW5ueroAEbS6nQlANqmAErSIqaZpjrqEtKjcKYAml3qEPEzpgDiUNJyqwAKElBgmqsA8lC+yqYAulWsLS219XQqPXC9Tbd3n22d6iUkAMRwCB4OAANQgMGkDBun0+DwarwAjAAmTKIgCcmQAzJkAKyZVFwLHXZqwnKQ2R0YAQWQlREABhhsOwl1J2CZOQgYBg1MpjVJOToZHQmhe7zJfH5HzJAty7NlOT0UrJOQVOFl2DZbGwtkYQA

Hi !
Oh ok, didn't this that 😅
It's ok with tension: number; attribute in LineOptions interface
Thanks for the reply, we can close this issue


Source-build release pipeline pull request deletes entire Versions.props file

There is an issue somewhere in this code:
https://github.com/dotnet/source-build/blob/dd7ff5db09b2daa541b2059b1ca6f2c8b6144242/eng/submit-source-build-release-pr.sh#L136-L138
which completely deletes eng/Versions.props as seen here:
https://github.com/dotnet/installer/pull/13978/commits/c58a4510b43ed55f385da34bf11bd5cba1a593a3
It should only update the private source-built artifacts version number.

My guess is that both the commands cat and tee are running in parallel because of the pipe and tee empties it before cat can read it.
Maybe we can use sed -i $versions_props_path $regex; cat $versions_props_path?


Modular input not listed in Splunk after installing

Describe the bug
I've installed this add-on from Splunkbase on a 9.0.1 and 9.0.0 environments and in both cases the "GitHub Enterprise Audit Log Monitoring" modular input, as shown in the screenshot in ghe_audit_logs.MD of this repo, is appearing post installation. Am I missing a step?
To Reproduce
Steps to reproduce the behavior:

Install from Splunkbase
Go to data inputs
"GitHub Enterprise Audit Log Monitoring" modular input is not listed

Expected behavior
"GitHub Enterprise Audit Log Monitoring" modular input should be listed
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Hey @vector-sec - have you installed the Splunk Add-on for GitHub?  It's an additional addon which is required to query the GH audit log.  It's separate from the GitHub App for Splunk.


error on starting

when opening minecraft this error shows up

i know its very raw, but im waiting for prgress and very exited about future of this project. Good luck!

It is possible to compile project from one of old commits


host/fixer: Resurrect/repair MongoDB

Enables recovery of MongoDB in the host fixer and cluster monitor.

LGTM


Add Database Seeds

Description
As a Developer, I would like to be able to seed my local database with example data.
In order to get the application up and running and show example data either for local development it would be good if we could have a seed file db/seeds.rb, that would populate the database when we reset or run rails db:seed.

@ChaelCodes I would be interested in giving this a go if you like? 😄

@LittleBigProgramming Sounds good! We need a gem for our seeds though. One that supports data separated by embodiment.

Would something like https://github.com/faker-ruby/faker work for this? 😄  I'll take a look into it later today!

Would something like https://github.com/faker-ruby/faker work for this? 😄  I'll take a look into it later today!

Faker gives you fake data, but it doesn't seed it. It also makes data generation non-deterministic which can cause issues. For example, it might generate 2 identical handles which can't be saved.
There's also no guarantee that the fake data will be tasteful.
I'd rather we build some data that's friendly and reflects our folks, or innocuous like fictional characters.

No problem, I didn't see that issue when I raised this one!
Would you lose me to close this? 😄

No problem, I didn't see that issue when I raised this one!
Would you lose me to close this? 😄

No, it's your issue, but #72 is a PR. There must've been some confusion.


Implemented otp based login functionality

Implemented otp functionality for login, Issue number 344

Title: Implemented otp functionality for login
Issue No.: 344
Close #344

Screenshots/Video (mandatory)
https://github.com/user-attachments/assets/1db4a6ed-1755-4870-a7f2-cd2ade08f22a
mobile otp :

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] I have created a helpful and easy-to-understand README.md if it's a new page/tech stack.
[X] I have gone through the contributing.md file before contributing.

Additional context (Mandatory):
Implemented otp based functionality for login. OTP is sent to user's mobile number, and then its verified on server to login user
Are you contributing under any Open-source programme?

[X] I'm a GSSOC-EXT contributor
[X] I'm a HACKTOBERFEST contributor

Well done @Sourabh782


Add info to README

Regards adding info to request headers for signout route.

Figured this should be added to the README, b/c I had to go codesurfing to figure out how to implement the signout functionality ;)

LGTM!


Removal of LoadFactor variables within PR #91

@danielhuppmann
Why have those variables been removed from the nomenclature within PR #91:
LoadFactor|Electricity|Solar|Profile
LoadFactor|Electricity|Wind|OffShore|Profile
LoadFactor|Electricity|Wind|OnShore|Profile
I am unable to find an appropriate substitute variable for those, maybe I have overlooked something

Apologies, my mistake - I thought that I was just removed duplicates in that PR.
Can you make a PR re-introducing those, but with the correct spelling (see #93) and without a "Profile" tag (see #92).


Search by words in title or description

The app should gain search bar which would filter links by words in their titles or descriptions.

Minimal example done on branch Searching commit: 727d42d3cfe88cb45808cc4dd5321057105d6b0b


Update README to reflect end of Appsody development

Checklist:

[ ] Read the Code of Conduct and Contributing Guidelines.

[ ] Followed the commit message guidelines.

[ ] Stack adheres to Appsody stack structure.

Modifying an existing stack:
n/a - not modifying an existing stack
Contributing a new stack:
n/a - not contributing a new stack

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Remove dss analytics

We no longer link to https://digitalservicesstore.service.gov.uk/ so the analytics code should be removed.
https://www.pivotaltracker.com/story/show/122197843
For reference, here are the pull requests that added and fixed the cross-domain tracking:

https://github.com/alphagov/digitalmarketplace-buyer-frontend/pull/121
https://github.com/alphagov/digitalmarketplace-buyer-frontend/pull/124

Forgot about this earlier, sorry.
I can confirm that there's some obscure-looking variable about autolinking that's now gone, and that the three tests that were removed fail if you put them back in.
Seems legit.
👍


dart run warning

Describe the bug
../../../.pub-cache/hosted/pub.flutter-io.cn/postgres-2.6.4/lib/src/substituter.dart:24:52: Warning: Operand of null-aware operation '!' has type 'Map<String, dynamic>' which excludes null.
 - 'Map' is from 'dart:core'.
    replace ??= (spec, index) => converter.convert(values![spec.name]);
                                                   ^

To Reproduce
Steps to reproduce the behavior:
dart run bin/main.dart
Expected behavior
No warning.
Screenshots
None.
Serverpod versions

CLI Version: 1.2.5
Library version: 1.2.5

Platform information
SERVERPOD version: 1.2.5, dart: 3.3.0 (stable) (Tue Feb 13 10:25:19 2024 +0000) on "macos_arm64", time: 2024-02-28 09:55:10.949692Z
mode: development, role: monolith, logging: normal, serverId: default
Additional context
None.

This is an issue in the underlying postgres library: https://github.com/isoos/postgresql-dart/issues/306.
Your server should functional normally, this is just a compile warning.


Clearly state Controller requirements?

At the moment, BCP-006-01 draft focuses on the requirements on Nodes that transmit or receive JPEG XS streams.
This includes making REQUIRED all the Flow and Sender attributes, and Receiver parameter constraints, that enable a Controller to ascertain whether those Senders and Receivers are compatible.
We've learnt from the Controller spec activity (viz. recent INFO-005 and IS-04, IS-05 and BCP-003-01 updates) that we need to bring together and clearly state requirements for Controllers too.
Seems like we could add a Controllers sub-heading, and e.g. state that a Controller MUST be capable of using these Flow/Sender attributes and Receiver caps to determine compatibility?

Yes, I think we should always provide that information in any spec which implies the existence of a controller.

Resolved by #21


[APR-121] Correct the changelog entry for the user-agent addition

Requests to /intake already had the correct user-agent header since they are sent by the default forwarder.
Follow-up to https://github.com/DataDog/datadog-agent/pull/24582

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


14-CURRENT : Virtualbox - Stuck at BSD Logo when using live cd

Stuck at BSD Logo when using live cd in Virtualbox.
Build 0H277

Build 0H277 is a FreeBSD 14-CURRENT based experimental build.
Please boot in verbose mode to see what is going on, and please post a screenshot of the verbose screen error message. Thanks.

Please boot in verbose mode, not in single-user mode.
Also, please in general don't report bugs on  FreeBSD 14-CURRENT based experimental builds at this time, because our next release 0.8.0 will be 13.1 based, not 14.0 based.

Solved.


Update resource-project-lifecycle.ttl

Addition of concepts
Closed
Closed with exploration
As per discussion with Derek to account for all possible permutations of mine and exploration activities, and provide the ability to map from current MinOcc metadata.

@geoderekh good pick-up
now also added as topConcept


Youtube plugin slider showing different image than the thumbnail set for the video

It can be changed in the YouTubeVideo model

public function getThumbnail($no = 2).

The default number is changed to 0 in release 1.3 so the thumbnails now the same.


[Package Request] WinDump

Originally posted by @grillado in https://github.com/microsoft/winget-pkgs/discussions/106537
Download Url: https://www.winpcap.org/windump/install/bin/windump_3_9_5/WinDump.exe
Publisher: Riverbed Technologies
PackageId: Riverbed.WinDump
Version: 3.9.5
InstallerType: portable
ShortDescription: WinDump is the Windows version of tcpdump, the command line network analyzer for UNIX.
License: BSD
LicenseUrl: https://www.winpcap.org/windump/misc/copyright.htm
Copyright: |-
Copyright (c) 1999 - 2005 NetGroup, Politecnico di Torino (Italy).
Copyright (c) 2005 - 2006 CACE Technologies, Davis (California).
All rights reserved.

I think that's being handled in #64940 since the publishers have ceased development on WinPCap and recommend using Npcap https://www.winpcap.org/install/default.htm
I should edit my comment above to reflect that package depends on issue #64940 being resolved first

This package appears to depend on Insecure.Npcap.


Refactor Item Filtering

As discussed via Discord, I'll put this up for you to look at.

As discussed, will move parts of it to smaller prs and we do the interface change at the end of the season


Feature Request: Google Cloud Platform Integration

Same as #159 , the Datadog API supports Google Cloud Platform integration.
It would be great if go-datadog-api supports for that 👍
https://docs.datadoghq.com/api/?lang=bash#google-cloud-platform

I've just added a pull request for this issue 👉 #184
Thanks!

Awesome, thank you! 🙇

Nice work @dragon3 would you like me to cut a release?

Thank you for the quick review and release!


Update Makefile to override build image

Signed-off-by: Brian Downs<EMAIL_ADDRESS>

Proposed Changes

Allow for passing in a new parameter to the Makefile called BUILD_IMAGE and pass that value down to Dapper for use at build time.
Updated the entry.sh file to remove unnecessary arguments that are passed now.

Types of Changes

Verification

There's really no good way to verify that Dapper has done what you've specified but one way I found was to make sure that the image that is being used to override the default doesn't exist on the local system before attempting to perform a built. Once the build has completed, check to see if the image exists locally.
Linked Issues

#3954
User-Facing Change

Further Comments

Not needed.


control directive is not working for inner v-accordions

I have four levels of v-accordion, and I want to close all accordions when clicked on any levels. Basically everything should be collapsed when clicked on any item. Now I'm using collapseAll() function for the first accordion, but for inner accordions, it is not working. Can anyone help me on this? Thanks in advance.

Sorry for my late reply.
You can do this using controllerAs syntax:

  <v-accordion multiple control="main.accordion">

    <v-pane ng-repeat="pane in panesB">
      <v-pane-header>

{{ ::pane.header }}

      </v-pane-header>

      <v-pane-content>

{{ ::pane.content }}

        <v-accordion multiple control="main.nestedAccordion">
          <v-pane ng-repeat="subpane in pane.subpanes">
            <v-pane-header>

{{ ::subpane.header }}

            </v-pane-header>
            <v-pane-content>

{{ ::subpane.content }}

            </v-pane-content>
          </v-pane>
        </v-accordion>
      </v-pane-content>
    </v-pane>

  </v-accordion>

  <button ng-click="main.accordion.collapseAll()">Collapse</button>
  <button ng-click="main.nestedAccordion.collapseAll()">Collapse nested</button>

Thank you for this answer (this could be usefull in documentation) thank you for this great accordion component anyway it rocks !


Custom layout errors on build

Thanks for creating this great package!
config:
export default defineConfig({
  integrations: [
    liveCode({
      layout: './src/components/LiveCodeLayout.astro',
    }),
  ],
})

Running dev, no problem. Running build:
12:05:02 [ERROR] [vite] x Build failed in 1.81s
Could not resolve "./src/components/LiveCodeLayout.astro" from "src/content/docs/components/price.mdx"
file: /Users/silveltman/Github/fullui/docs/src/content/docs/components/price.mdx
  Stack trace:
    at getRollupError (file:///Users/silveltman/Github/fullui/node_modules/.pnpm/rollup@4.13.0/node_modules/rollup/dist/es/shared/parseAst.js:376:41)
    at ModuleLoader.handleInvalidResolvedId (file:///Users/silveltman/Github/fullui/node_modules/.pnpm/rollup@4.13.0/node_modules/rollup/dist/es/shared/node-entry.js:18891:24)
 ELIFECYCLE  Command failed with exit code

Seems to take the path from the mdx file, instead of from the root. Changing to src/components/LiveCodeLayout.astro also errors.
Solution:
{
  "extends": "astro/tsconfigs/strict",
  "compilerOptions": {
    "baseUrl": ".",
    "paths": {
      "@components/*": ["src/components/*"],
    }
  }
}

with:
export default defineConfig({
  integrations: [
    liveCode({
      layout<EMAIL_ADDRESS>    }),
  ],
})

@silveltman thanks for making the issue! Does it work with an absolute path i.e `/src/components/LiveCodeLayout.astro'?

Is does now actually, though I tried that before but might be mistaking.
thanks! :)


Initialize the temp sensor to prevent it from crashing

The device was crashing with the following error:
14:22:08.202 -> Guru Meditation Error: Core  1 panic'ed (LoadProhibited). Exception was unhandled.
14:22:08.202 ->
14:22:08.202 -> Core  1 register dump:
14:22:08.202 -> PC      : 0x400d7253  PS      : 0x00060d30  A0      : 0x800d73d7  A1      : 0x3ffb2700
14:22:08.235 -> A2      : 0x00000000  A3      : 0x00000000  A4      : 0x0000e8d2  A5      : 0x00000000
14:22:08.235 -> A6      : 0xadb333d8  A7      : 0x328974c8  A8      : 0xfffe0000  A9      : 0x00000000
14:22:08.235 -> A10     : 0xe8d20000  A11     : 0x000099f0  A12     : 0x86920000  A13     : 0xb58b0000
14:22:08.235 -> A14     : 0x00000000  A15     : 0x00000000  SAR     : 0x0000000f  EXCCAUSE: 0x0000001c
14:22:08.269 -> EXCVADDR: 0x00000040  LBEG    : 0x400895fc  LEND    : 0x40089612  LCOUNT  : 0xffffffff
14:22:08.269 ->
14:22:08.269 ->
14:22:08.269 -> Backtrace: 0x400d7250:0x3ffb2700 0x400d73d4:0x3ffb2720 0x400d8954:0x3ffb2740 0x400d2af5:0x3ffb2790 0x400edd01:0x3ffb2820
14:22:08.269 ->
14:22:08.269 ->
14:22:08.269 ->
14:22:08.269 ->
14:22:08.269 -> ELF file SHA256: 943ce1bc0631683a

The reason for that was that the SHT30 sensor wasn't initialized properly which caused sht30.get() to freak out.
This PR addresses this issue and adds init code.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Amazing, thank you!!


Keeps using InitialCreate

I made two migrations, InitialCreate then Rating.
When I use Update-Database, it keeps executing InitialCreate! Why?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 22803277-a2a7-0adf-acfc-35ed8e4238c8
Version Independent ID: 19869482-5737-adff-3f7f-60b4217b977d
Content: EF Core tools reference (Package Manager Console) - EF Core
Content Source: entity-framework/core/miscellaneous/cli/powershell.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @bricelam
Microsoft Alias: bricelam

@henryjones000 This should not be happening. Please post a small, runnable project/solution or complete code listing that demonstrates the behavior you are seeing.

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.


Housekeeping: group lookup data together, store in an optional struct

This PR groups the lookup information in the constraint system and verifier index together in an optional structure, removing a TODO.

LGTM besides the new file that was added


Update cached KubeVirt main schema

What this PR does / why we need it:
Update cached KubeVirt main schema.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
This should really be automated for main where we will be tracking KubeVirt's main branch.
Release note:

NONE

/approve
/lgtm

/approve
/lgtm