Configured theme not applying to all applications

I've used qt5ct and qt6ct to set custom styles for my qt apps, this works great for most apps and I've been using that.
But there's a bit of snag, KDE Connect and Tokodon seem to ignore the configured style.

Ark left has the theme applied; whilst Tokodon and KDE Connect fall back to their default light theme.
I have noticed that Kde Connect and Tokodon are a bit different compared to other Qt apps with a header bar and more mobile-forward and responsive layout; but I don't see why they wouldn't be styled by the Qt theme.
I can however confirm that this shouldn't be a configuration issue as both Qt5 and Qt6 applications work fine and without any major issues.

little follow-up that provides more information:
I did some digging and apparently both KDE Connect and Tokodon are built with Kirigami, whatever may be the cause is probably in relation to that.
What exactly is at play here, I don't know, but it does seem like a good place to start investigating.
In fact, I found this reddit thread talking about the exact issue at hand; but it doesn't seem to point to anything that could be of use.

KDE uses its own color scheme engine called KColorScheme (ignoring QPalette and Qt theme colors) and Kirigami applications are built on top of QML that qt5ct has no theme control for. The Qt's default for QML applications is the Fusion theme on Linux (just like for widgets) but KDE has its own theme called qqc2-desktop-style that allows applying widgets themes to QML applications. KDE applications are also made for their own icon engine called KIconEngine that applies KDE color schemes to svg icons so when the engine is not used you're likely to see things like black icons on black background.
I have a patch adding support KColorScheme/KIconEngine/qqc2-desktop-style support to qt5ct, packages with it are available for NixOS and qt{5,6}ct-kde on AUR.
An important thing is to have a KDE color scheme for your Qt theme and apply it in the patched qt5ct. It enumerates such color schemes but doesn't show a difference in preview (as I'm too lazy to implement this, it's good for me as is).

Kirigami is not the issue, as it also doesn't fully apply to KDE 6 apps like Dolphin using qt6ct.

System Settings do use Kirigami. Although you're right that it's not only Kirigami, it's KColorScheme framework which is used by both QML and Widgets KDE apps.

But does Dolphin use Kirigami? And Haruna? And Amarok git, build with Qt 6? And Okular? Because it doesn't work in those apps either. And if System Settings only partly uses Kirigami, I'd expect the theme to at least partially apply.
Btw, I tried your patch on Arch Linux with qt6ct from git, but it doesn't solve the issue.

As I said, it's not Kirigami but KColorScheme. And yes, all KDE applications use KColorScheme.

Btw, I tried your patch on Arch Linux with qt6ct from git, but it doesn't solve the issue.

Did you choose a color scheme with it that has a (KColorScheme) in its name?

But then what changed with KDE 6? Because I never had issues like this with KDE 5 apps.
Yes, I chose Breeze Dark. That's one of the two default KDE themes, so it should be good.

Yes, I chose Breeze Dark. That's one of the two default KDE themes, so it should be good. Except that it isn't.

Can you provide your Qt-related environment variables? env | grep QT

env | grep QT

❯ env | grep QT
QT_AUTO_SCREEN_SCALE_FACTOR=0
QT_WAYLAND_RECONNECT=1
QT_QPA_PLATFORMTHEME=qt6ct

Can you reproduce if you run affected application in that terminal session?

Then it seems to work fine.

Scratch that: it did apply the correct colors, but not the theming engine.

Then it seems to work fine.

So the issue is that you have set QT_QPA_PLATFORMTHEME in a way it doesn't go through all your graphical session

Then it seems to work fine.

So the issue is that you have set QT_QPA_PLATFORMTHEME in a way it doesn't go through all your graphical session

Please see my message after that one. 🙂

Scratch that: it did apply the correct colors, but not the theming engine.

Some KDE applications like Dolphin hardcode theme for non-KDE sessions now

see https://invent.kde.org/frameworks/kiconthemes/-/issues/3

Scratch that: it did apply the correct colors, but not the theming engine.

Some KDE applications like Dolphin hardcode theme for non-KDE sessions now

But I'm using KDE.

But I'm using KDE.

Then you don't really need qt6ct? Setting qt6ct would make that logic to think you're using a non-KDE session.

But I'm using KDE.

Then you don't really need qt6ct? Setting qt6ct would make that logic to think you're using a non-KDE session.

But using qt6ct I can disable cursor blinking, which is not supported by KDE itself. I was advised to use qt5ct for that on KDE 5, but I clean installed Arch Linux with KDE 6 last week, so now I need to use qt6ct to achieve that. And because of that, I also need to set the theming engine through qt6ct.

That logic seem to force the Qt style from kdeglobals so setting it via both qt6ct and system settings should theoretically do the thing

Could you explain that a bit more? Like I said: I did use this exact same setup with qt5ct without any issues.

Could you explain that a bit more

You don't know how to set Qt style via system settings?

Like I said: I did use this exact same setup with qt5ct without any issues.

As you can see the linked issue in kiconthemes, it's done in KF6, not KF5

I have set it in system settings, but it doesn’t make a difference for the majority of apps, including the ones I listed earlier.

What those commands return?
grep widgetStyle ~/.config/kdeglobals
grep style ~/.config/qt6ct/qt6ct.conf

❯ grep widgetStyle ~/.config/kdeglobals
widgetStyle=qt6ct-style

~
❯ grep style ~/.config/qt6ct/qt6ct.conf
style=kvantum
stylesheets=@Invalid()
toolbutton_style=2

~
❯

Could it be that you have kvantum installed only for Qt 5?

Nope, kvantum-qt6 is installed and qt6ct and FeatherNotes do use the Kvantum theme I set, so it's partly functioning.

The only idea is maybe there's a miscommunication. Can you upload a screenshot of how it looks wrongly and (if possible) how it should look like?

I have no idea what changed, but suddenly it's working now. Thanks for all of your help! 🙂

Actually, scratch that: it works for a moment in for example Dolphin, but when I close Dolphin, it reverts to Breeze. Then I re-apply qt6ct as theme engine in System Settings and Dolphin looks fine again until I close it…

Here's an example of what Dolphin is supposed to look like with Kvantum enabled in qt6ct. And it does, until I close Dolphin. Then I have to re-apply qt6ct in System Settings. And Dolphin is just one example, but there are more apps.

Here's an example of what Dolphin is supposed to look like with Kvantum enabled in qt6ct.

but how it looks when it's broken?

And it does, until I close Dolphin. Then I have to re-apply qt6ct in System Settings.

Does it get removed from kdeglobals?

Here's an example of what Dolphin is supposed to look like with Kvantum enabled in qt6ct.

but how it looks when it's broken?

Those apps fall back to Breeze then.

And it does, until I close Dolphin. Then I have to re-apply qt6ct in System Settings.

Does it get removed from kdeglobals?

How do I check that?

grep widgetStyle ~/.config/kdeglobals

this

Those apps fall back to Breeze then.

I mean there are different parts of Breeze (widget style, color scheme, etc), it would be useful to see which exactly parts get changed

grep widgetStyle ~/.config/kdeglobals

this

❯ grep widgetStyle ~/.config/kdeglobals
widgetStyle=qt6ct-style

Those apps fall back to Breeze then.

I mean there are different parts of Breeze (widget style, color scheme, etc), it would be useful to see which exactly parts get changed

Looks like I found what is wrong. System Settings sets
[KDE]
widgetStyle=qt6ct-style

While KConfigWidgets framework expects
[General]
widgetStyle=qt6ct-style

So adding tho two lines to kdeglobals.
I wonder whether that's a bug in kconfigwidgets...

That seems to have solved it forgood! Thank you so, so much for all of your help - I truly appreciate it! 🙂
And yeah, that seems to be a bug that needs to be reported, most likely on bugs.kde.org.

I tried to ask Cristoph Cullmann on Matrix, will see what he answers

But using qt6ct I can disable cursor blinking, which is not supported by KDE itself.

Put into ~/.config/kdeglobals
[KDE]
CursorBlinkRate=0

Now stop using qt6ct within plasma, thank you.

I tried to ask Cristoph Cullmann on Matrix, will see what he answers

Thanks. 🙂

But using qt6ct I can disable cursor blinking, which is not supported by KDE itself.

Put into ~/.config/kdeglobals
[KDE]
CursorBlinkRate=0

Now stop using qt6ct within plasma, thank you.

So they've finally added that option? Great, thanks! I'll try it. 🙂

That option has always been there, there’s just no GUI to it.

That option has always been there, there’s just no GUI to it.

I was told in the past it wasn't there or it wasn't available on Wayland or something, so I got recommended to use qt5ct. And then with KDE 6, I figured I would need qt6ct. Odd that people didn't know it was available all along then, but oh well.

I tried to ask Cristoph Cullmann on Matrix, will see what he answers

He ignored my question on Matrix so I ended up asking on https://invent.kde.org/frameworks/kiconthemes/-/issues/3#note_1042812. That's a bug indeed.

Thanks! 🙂

FWIW, looks like there's a long-standing bug in Kirigami applying platform palette outside of KDE. Replacing property font defaultFont: fontMetrics.font line with defaultFont: fontMetrics.font in /usr/lib/qt6/qml/org/kde/kirigami/styles/org.kde.desktop/Theme.qml (this is path for Arch, might be different in other distros) should make Kirigami apps to follow system palette even without patches to qt6ct.

FWIW, looks like there's a long-standing bug in Kirigami applying platform palette outside of KDE.

Should be fixed with KF 6.8 so Kirigami applications should start to follow QPalette just like widgets applications

Sadly, it's not fixed entirely. System Settings look better now, but Dolphin is totally broken now. I switched to LXQt in the mean time, btw, so I'm not even on KDE anymore.

but Dolphin is totally broken now

Dolphin uses their new approach of hardcoding theme outside of KDE, it now follows only kdeglobals for widget style and icon theme and xdg-desktop-portal's color-scheme spec for the light/dark color scheme switch.
#43 takes care about all that

He ignored my question on Matrix so I ended up asking on https://invent.kde.org/frameworks/kiconthemes/-/issues/3#note_1042812. That's a bug indeed.

(that bug was fixed too so setting widget style via systemsettings app should work just as well)

He ignored my question on Matrix so I ended up asking on https://invent.kde.org/frameworks/kiconthemes/-/issues/3#note_1042812. That's a bug indeed.

(that bug was fixed too so setting widget style via systemsettings app should work just as well but still portal is needed for proper dark mode without #43)

Sadly, the bug isn't fixed for me.

He ignored my question on Matrix so I ended up asking on https://invent.kde.org/frameworks/kiconthemes/-/issues/3#note_1042812. That's a bug indeed.

(that bug was fixed too so setting widget style via systemsettings app should work just as well but still portal is needed for proper dark mode without #43)

Cool, thanks. 🙂

Sadly, the bug isn't fixed for me.

wdym? Setting via systemsettings still doesn't work for you?

Nope, still doesn't work.
Also, I just tried your qt6ct branch, but it didn't fix the Dolphin issue. :/

Nope, still doesn't work.

Did you restart apps after changing it? It doesn't apply on the fly.

Also, I just tried your qt6ct branch, but it didn't fix the Dolphin issue. :/

What exactly issue do you have now?

I did restart apps, but it didn't work.
The issue I have now is that Dolphin uses a weird color scheme, with black and white markings with white text, and black text on a black background in the sidebar. Before the 6.8 update, Dolphin looked fine (white text on a black background and no white markings). Your branch sadly didn't fix it.

From that screenshot it looks like widget style successfully applied after all? Color scheme gets applied from portal settings as I explained before, not from systemsettings.

Your branch sadly didn't fix it.

Did you set the color scheme with (KColorScheme) in the name? Are you sure qt6ct was actually used?

Sorry, I didn't mean the widget style didn't apply. I mean switching styles from System Settings doesn't work. But once I set one manually like we figured out earliel in the thread, it does apply.
I did set that color scheme and I most definitely used qt6ct.

I mean switching styles from System Settings doesn't work. But once I set one manually like we figured out earliel in the thread, it does apply.

Are you sure you have kconfigwidgets 6.7.0 or later?

Yes, I'm on Arch and I received that update. But I don't care much for that bug, to be honest. Manually editing the config file is not such a hassle. I'd rather have a readable Dolphin back lol.

Yes, I'm on Arch and I received that update.

That's very weird cause it works for me now:
https://github.com/user-attachments/assets/76412cf3-3b65-43d5-9586-557dcdf36660

But I don't care much for that bug, to be honest. Manually editing the config file is not such a hassle. I'd rather have a readable Dolphin back lol.

Maybe that's somehow related to the fact you can't get it... Did you try running from terminal like QT_QPA_PLATFORMTHEME=qt6ct dolphin? What settings do you have in qt6ct?

Yep, Dolphin looks the exact same with that command. I have set it to Kvantum.

I have set it to Kvantum.

I mean maybe you can provide a screenshot of qt6ct settings or ~/.config/qt6ct/qt6ct.conf?

I have asked:

Did you set the color scheme with (KColorScheme) in the name?

You answered:

I did set that color scheme and I most definitely used qt6ct.

But this one

color_scheme_path=/usr/share/qt6ct/colors/darker.conf

Is not a KColorScheme.

Important thing is to choose a color scheme containing (KColorScheme) in name (such as Breeze Dark) as non-KDE color schemes (such as darker) won't KDE applications properly.

I know, but in the GUI of qt6ct it is set to Default and not the darker color scheme. So then it must be a bug in qt6ct.

Right, your config also has

custom_palette=false

But my point is that it won't work with neither Default nor darker. You need a KColorScheme for KDE applications to look properly. In Plasma Session, you always have a KDE color scheme set (Breeze Light by default).

I have a KColorScheme set.

But the config says you don't. You have custom_palette=false and color_scheme_path=/usr/share/qt6ct/colors/darker.conf.

Then there still is a bug somewhere, either in qt6ct or in KDE's systemsettings.

Maybe you configure qt5ct instead of qt6ct?

Nope.

Then there still is a bug somewhere, either in qt6ct or in KDE's systemsettings.

Hm. Can you provide a screenshot of your qt6ct settings?

Sure, here you go.

You don't have a KColorScheme set

The radio box has to be set to "Aangepast" and "Kleurenschema" to a value containing (KColorScheme) in name (and that provides a dark color scheme, of course).

But the color scheme from KDE systemsettings I have set is not available in that drop down list.

Also, I just tried your qt6ct branch

Are you sure you're using my branch? It's available only there.

Yes, I have manually compiled your branch qt6ct ‘shenenigans’.

Yes, I have manually compiled your branch qt6ct ‘shenenigans’.

 Do you have any KDE color schemes installed actually?

On Arch you can just install qt6ct-kde package from AUR.

Nope, other one is not installed anymore. And qt6ct-kde from AUR also doesn't have the correct color scheme in the drop-down list.

And qt6ct-kde from AUR also doesn't have the correct color scheme in the drop-down list.

I wonder where the correct color scheme is located in the file system?

I just installed qt6ct-kde yet again and now it finally shows other color schemes in the dropdown list.

However, Dolphin still looks the same. :(

Even if you launch it with QT_QPA_PLATFORMTHEME=qt6ct dolphin?

No, then it looks right. I guess there's a bug in Arch somewhere then.

It might be not easy to override QT_QPA_PLATFORMTHEME in a Qt desktop environment such as LXQt...

If xdg-desktop-portal-lxqt supported org.freedesktop.appearance.color-scheme parameter, it would just work I guess, even without qt6ct...

If merged, this should restore the possibility to change color scheme via kdeglobals when there's no portal.
https://invent.kde.org/frameworks/kcolorscheme/-/merge_requests/28

Great! Thanks for putting the time into that MR. 🙂

@Vistaus I was told you can specify your color scheme like
[UiSettings]
ColorScheme=Sonomatic

Usually it gets specified in app config file (e.g. dolpinrc) but it seem to also work with Dolphin when specified in kdeglobals from my testing.
On other hand, applications having color scheme chooser in UI (e.g. Elisa) seem to write ColorScheme setting with empty value to their config file if it isn't present what shadows the value in kdeglobals. But then you can easily select your color scheme in their UI.

If no answer, I would assume it works and will close the kcolorscheme MR


"scopes_tree_count_literals_in_blocks", a bug or on purpose?

The scopes_tree_count_literals_in_blocks in scopes-tree.cpp is called by  serializer_merge_scopes_into_bytecode. It is used to count slots needed for a scope's hash table, and should  divide bytecode into blocks and count unique literal indexes used in each block, as the code comment says.
However, in its implementation, the global_oc will never increase and next_uid will become 0 when enter a subscope, so it becomes counting the unique literal used in one instruction, instead of one block.. So its result will be larger, and leads to memory waste in lit-id-hash-table.
I fixed it (https://github.com/jiangzidong/jerryscript/tree/litcount), but the run-perf-result is not so good
                           Benchmark |         RSS
(+ is better) |        Perf
(+ is better) |
                           --------- |                          --- |                         ---- |
                          3d-cube.js |          132->   132 (0.000) |       0.344->0.3496 (-1.628) |
              access-binary-trees.js |          84->    72 (14.286) |       0.164->0.1688 (-2.927) |
                  access-fannkuch.js |          48->    52 (-8.333) |       0.912->0.9192 (-0.789) |
         bitops-3bit-bits-in-byte.js |          40->    36 (10.000) |       0.276->0.2784 (-0.870) |
              bitops-bits-in-byte.js |           40->    40 (0.000) |      0.3616->0.3632 (-0.442) |
               bitops-bitwise-and.js |           40->    40 (0.000) |       0.344-> 0.348 (-1.163) |
            controlflow-recursive.js |          244->   240 (1.639) |       0.152-> 0.156 (-2.632) |
                       crypto-aes.js |          152->   152 (0.000) |       0.604->0.6088 (-0.795) |
                       crypto-md5.js |         204->   208 (-1.961) |        3.74->3.8976 (-4.214) |
                      crypto-sha1.js |          148->   148 (0.000) |      1.6408-> 1.684 (-2.633) |
                date-format-tofte.js |          112->   112 (0.000) |        0.384->  0.36 (6.250) |
                date-format-xparb.js |           96->    92 (4.167) |        0.18-> 0.184 (-2.222) |
                      math-cordic.js |           48->    48 (0.000) |       0.3856->0.3856 (0.000) |
               math-spectral-norm.js |           44->    44 (0.000) |          0.2->   0.2 (0.000) |
                    string-base64.js |          200->   200 (0.000) |     28.4536->30.448 (-7.009) |
                     string-fasta.js |           60->    60 (0.000) |       0.624->0.6432 (-3.077) |
                     Geometric mean: |       RSS reduction: 1.3603% |            Speed up: -1.474% |

I also measure the heap peak counts:

Benchmark
heap peak counts old
heap peak counts new
+ is better

date-format-tofte.js
636
636
0.000000

crypto-aes.js
1164
1174
-0.859107

string-base64.js
2577
2575
0.077610

string-fasta.js
223
223
0.000000

math-spectral-norm.js
130
130
0.000000

math-cordic.js
130
129
0.769231

date-format-xparb.js
562
556
1.067616

access-binary-trees.js
727
727
0.000000

bitops-bits-in-byte.js
67
67
0.000000

crypto-md5.js
2293
2291
0.087222

3d-cube.js
646
644
0.309598

bitops-3bit-bits-in-byte.js
73
73
0.000000

bitops-bitwise-and.js
50
49
2.000000

controlflow-recursive.js
723
722
0.138313

access-fannkuch.js
99
99
0.000000

crypto-sha1.js
1461
1459
0.136893

Geometric mean

0.23%

I think the reason maybe:

memory: the hash_table for each blocks is larger than before. it need to store all literals used in code block, rather than one instruction. This will counteract the decrease of the lid-id-hash-table
performance:  during serializer_merge_scopes_into_bytecode, more items in hash_table leads to more look_up actions.

But I still believe it is a bug in scopes_tree_count_literals_in_blocks. Should I create a PR about that?

@jiangzidong, thank you for your question and detailed investigation. Yes, it is a bug.
The literal tables mechanism is planned to be reworked in near future, so the bug should also become fixed soon.

@jiangzidong, mechanism of literal tables construction was significantly reworked in PR #789. The bug is fixed in the new version - there is no global_oc global instruction counter now.
The PR was already merged, so closing the issue.


Add multi-select filters on organizations, members and activities filter list

…r-member-list# Changes proposed ✍
What
Fixed #1243

🤖 Generated by Copilot at 5d52afa
Changed several filters from single-select to multi-select components, to allow more flexible filtering of activities, channels, members, and organizations. Added a new filter for job title in the member module, to enable filtering by this attribute. Updated the config files and the custom-attributes service to reflect these changes.

🤖 Generated by Copilot at 5d52afa

Sing, O Muse, of the skillful coder who changed the filters
Of many modules, to make them more flexible and useful
He added a new jobTitle filter to the member module
Like Hephaestus forging a new tool for the gods on Olympus

Why
How

🤖 Generated by Copilot at 5d52afa

Replace the CrSelectFilter component with the CrMultiSelectFilter component in the activityType and channel filters of the activity module and the activityType filter of the member module, to allow the user to select multiple options instead of one (link, link, link, link, link, link).

Checklist ✅

[ ] Label appropriately with Feature, Improvement, or Bug.
[ ] Add screehshots to the PR description for relevant FE changes
[ ] New backend functionality has been unit-tested.
[ ] API documentation has been updated (if necessary) (see docs on API documentation).
[ ] Quality standards are met.

@joanagmaia please review when you need can. I can't find a way to request your review silently

@joanagmaia resolved


DoubleValue.setValue does not set stringValue

When using setValue on DoubleValue object only the value is set. The setter does not change stringValue which is then used in toString method.
Following test would fail:
    @Test
    public void shouldSetStringValue() {
        final DoubleValue doubleValue = new DoubleValue("42");

        doubleValue.setValue(43D);

        assertEquals(43D, doubleValue.getValue());
        assertEquals("43.0", doubleValue.toString());
    }

Thanks, I've opened PR -> https://github.com/JSQLParser/JSqlParser/pull/2009, so you can review.

@manticore-projects Thanks for reviewing. When you will be able to release a new version to maven ?

Greetings, we don't have any exact date for a new release 5.0 but my take is: before End of June.
Please note that as a matter of fact, JSQLParser has become a rolling-release where every last snapshot is deemed to be the latest greatest version and "stable release" does not bear any actual advantage.


Unable to get max resolution of device setting at the moment!

Hi at all!  I need that camera widget to take max resolution of video available on the device camera at that moment.
I have done these tests:
Samsung Galaxy S7
First Test:
setting camera to 19201080
ResolutionPreset setting to :
/// 2160p (3840x2160)
ultraHigh,
output video: 19201080
Second Test:
setting camera to 2560*1440
ResolutionPreset setting to :
/// 2160p (3840x2160)
ultraHigh,
output video : 1920 * 1080.
Third Test:
setting camera to 3840*2160
ResolutionPreset setting to:
/// 2160p (3840x2160)
ultraHigh,
output video: 1920 * 1080.
it seems to be that the Camera widget uses a default value of resolution, how Can I resolve it?
@ianloic @anaisbetts @sgraham  @gmoothart @sethladd

duplicate of https://github.com/flutter/flutter/issues/58163


FIFA: HTTPError 404: 'Not Found'

URL: https://www.fifa.com/fifaplus/en/watch/4V8H8qv7QM1LNVk5gUwYFa

yt-dlp.py -v "https://www.fifa.com/fifaplus/en/watch/4V8H8qv7QM1LNVk5gUwYFa" [debug] Command-line config: ['-v', 'https://www.fifa.com/fifaplus/en/watch/4V8H8qv7QM1LNVk5gUwYFa'] [debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8 [debug] yt-dlp version 2022.07.18 [135f05e] (zip) [debug] Python 3.10.6 (CPython 64bit) - Windows-10-10.0.17763-SP0 [debug] Checking exe version: ffmpeg -bsfs [debug] Checking exe version: ffprobe -bsfs [debug] exe versions: ffmpeg 4.3.2-2021-02-02-full_build-www.gyan.dev, ffprobe 4.3.2-2021-02-02-full_build-www.gyan.dev, rtmpdump 2.4 [debug] Optional libraries: sqlite3-2.6.0 [debug] Proxy map: {} [debug] [Fifa] Extracting URL: https://www.fifa.com/fifaplus/en/watch/4V8H8qv7QM1LNVk5gUwYFa [Fifa] 4V8H8qv7QM1LNVk5gUwYFa: Downloading webpage [Fifa] 4V8H8qv7QM1LNVk5gUwYFa: Downloading Video Details [Fifa] 4V8H8qv7QM1LNVk5gUwYFa: Downloading Preplay Parameters ERROR: [Fifa] 4V8H8qv7QM1LNVk5gUwYFa: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using yt-dlp -U File "C:\Transmogrifier\yt-dlp.py\yt_dlp\extractor\common.py", line 644, in extract ie_result = self._real_extract(url) File "C:\Transmogrifier\yt-dlp.py\yt_dlp\extractor\fifa.py", line 62, in _real_extract preplay_parameters = self._download_json( File "C:\Transmogrifier\yt-dlp.py\yt_dlp\extractor\common.py", line 1004, in download_content res = getattr(self, download_handle.name)(url_or_request, video_id, **kwargs) File "C:\Transmogrifier\yt-dlp.py\yt_dlp\extractor\common.py", line 968, in download_handle res = self._download_webpage_handle( File "C:\Transmogrifier\yt-dlp.py\yt_dlp\extractor\common.py", line 838, in _download_webpage_handle urlh = self._request_webpage(url_or_request, video_id, note, errnote, fatal, data=data, headers=headers, query=query, expected_status=expected_status) File "C:\Transmogrifier\yt-dlp.py\yt_dlp\extractor\common.py", line 795, in _request_webpage raise ExtractorError(errmsg, cause=err)
File "C:\Transmogrifier\yt-dlp.py\yt_dlp\extractor\common.py", line 777, in _request_webpage return self._downloader.urlopen(self._create_request(url_or_request, data, headers, query)) File "C:\Transmogrifier\yt-dlp.py\yt_dlp\YoutubeDL.py", line 3639, in urlopen return self._opener.open(req, timeout=self._socket_timeout) File "C:\Program Files\Python310\lib\urllib\request.py", line 525, in open response = meth(req, response) File "C:\Program Files\Python310\lib\urllib\request.py", line 634, in http_response response = self.parent.error( File "C:\Program Files\Python310\lib\urllib\request.py", line 563, in error return self._call_chain(*args) File "C:\Program Files\Python310\lib\urllib\request.py", line 496, in _call_chain result = func(*args) File "C:\Program Files\Python310\lib\urllib\request.py", line 643, in http_error_default raise HTTPError(req.full_url, code, msg, hdrs, fp) urllib.error.HTTPError: HTTP Error 404: Not Found

Looks like Fifa has changed API's url.
Just need to change
https://github.com/yt-dlp/yt-dlp/blob/aeaf905e22614812e29c652a8140feaae08ce279/yt_dlp/extractor/fifa.py#L62-L63
to
        preplay_parameters = self._download_json(
            f'{preconnect_link}/videoPlayerData/{video_id}', video_id, 'Downloading Preplay Parameters')['preplayParameters']

Originally posted by @Bricio in https://github.com/yt-dlp/yt-dlp/issues/3633#issuecomment-1205953337

How is this different from #3633?

How is this different from #3633?

#3633 is a problem in the matching url, that should not match urls with something between /watch and video id. And to add the support for that urls.
https://github.com/yt-dlp/yt-dlp/blob/aeaf905e22614812e29c652a8140feaae08ce279/yt_dlp/extractor/fifa.py#L11

I think it's any URL with /movies/ or /series/ in URL between /watch/ and video id, so any video that's not a match replay.

To solve that we need to create extractors, or some program flow, to identify this urls, and process it correctly.
That is what #3640 is about.

This one is a change in FIFA's API.
Every url are not working right now. Even urls that was working before. Like the first test.
https://github.com/yt-dlp/yt-dlp/blob/aeaf905e22614812e29c652a8140feaae08ce279/yt_dlp/extractor/fifa.py#L13
D:\ytdlp>yt-dlp.exe -Uv "https://www.fifa.com/fifaplus/en/watch/7on10qPcnyLajDDU3ntg6y"
[debug] Command-line config: ['-Uv', 'https://www.fifa.com/fifaplus/en/watch/7on10qPcnyLajDDU3ntg6y']
[debug] Portable config "D:\ytdlp\yt-dlp.conf": ['--ffmpeg-location', '.\\ffmpeg\\bin', '--ignore-config']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8 (No VT), error utf-8 (No VT), screen utf-8 (No VT)
[debug] yt-dlp version 2022.07.18 [135f05e] (win32_exe)
[debug] Python 3.8.10 (CPython 64bit) - Windows-7-6.1.7601-SP1
[debug] Checking exe version: ".\ffmpeg\bin\ffmpeg" -bsfs
[debug] Checking exe version: ".\ffmpeg\bin\ffprobe" -bsfs
[debug] exe versions: ffmpeg N-105453-gcc5eb2e662-20220204 (setts), ffprobe N-105453-gcc5eb2e662-20220204
[debug] Optional libraries: Cryptodome-3.15.0, brotli-1.0.9, certifi-2022.06.15, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3
[debug] Proxy map: {}
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2022.07.18, Current version: 2022.07.18
yt-dlp is up to date (2022.07.18)
[debug] [Fifa] Extracting URL: https://www.fifa.com/fifaplus/en/watch/7on10qPcnyLajDDU3ntg6y
[Fifa] 7on10qPcnyLajDDU3ntg6y: Downloading webpage
[Fifa] 7on10qPcnyLajDDU3ntg6y: Downloading Video Details
[Fifa] 7on10qPcnyLajDDU3ntg6y: Downloading Preplay Parameters
ERROR: [Fifa] 7on10qPcnyLajDDU3ntg6y: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "yt_dlp\extractor\common.py", line 644, in extract
  File "yt_dlp\extractor\fifa.py", line 62, in _real_extract
  File "yt_dlp\extractor\common.py", line 1004, in download_content
  File "yt_dlp\extractor\common.py", line 968, in download_handle
  File "yt_dlp\extractor\common.py", line 838, in _download_webpage_handle
  File "yt_dlp\extractor\common.py", line 795, in _request_webpage

  File "yt_dlp\extractor\common.py", line 777, in _request_webpage
  File "yt_dlp\YoutubeDL.py", line 3639, in urlopen
  File "urllib\request.py", line 531, in open
  File "urllib\request.py", line 640, in http_response
  File "urllib\request.py", line 569, in error
  File "urllib\request.py", line 502, in _call_chain
  File "urllib\request.py", line 649, in http_error_default
urllib.error.HTTPError: HTTP Error 404: Not Found

It is an easy fix, but a different kind of problem.

Hey, I am a newbie so I have a question does this fix include modifying fifa.py only. Can i give it a try ?


Bump django from 4.0 to 4.0.7 in /ch2-hello-world-app

Bumps django from 4.0 to 4.0.7.

Release notes
Commits

updated-dependencies:

dependency-name: django dependency-type: direct:production ...

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>

Am a Student from Ghana - Africa

Thank you


Add nodePackages.tern

Things done:

[x] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

More
I also removed node-xmpp-core which has a broken dependency.
cc @DamienCassou @offlinehacker @shlevy

Looks good to me, thanks.


Multicam synchronization by audio aligning

Hi there, thanks for your very interesting video tool !
Due to its "Exporting to Editors" feature, it would be very useful to make it able to synch multiple video tracks of the same event (aka multicam recordings), an ability available on commercial products such as PluralEyes or Syncaila.
The most interesting/complete resource to easily implement it is AudioAlign (wich is based on .NET Aurio library) by @protyposis.
Hope that inspires !

Not sure why I kept this alive for so long. Auto-Editor doesn't even have a system to move timeline clips.


Using lowercase keywords in schema.prisma cannot generate clients correctly

Hello, I just tried this package and followed the README but I get this error when I run the command dart run orm generate

@moepoi See https://github.com/odroe/prisma-dart#model-deserialize-why-run-build_runner-build
Steps:

Add json_serializable package - dart pub add json_serializable -d
Add build_runner package - dart pub add build_runner -d
Run build_runner build command - dart run build_runner build

reason:
Type-safe input and output need to be done using json_annotation.

There are currently no plans to remove it, because json_annotation works well, although it can't be used after running dart run orm generate. But at the moment we don't have the manpower to develop a JSON serializer on its own and can only rely on json_annotation to run.

@moepoi 😫, it's a bug
Reason, use lowercase keywords in schema.prisma

I checkout a new branch to fix it

@moepoi Fixed in 2.2.1 version


Allure report 1.4.23: docstrings (test case description) displays incorrectly

pytest-allure-adaptor == 1.7.2
allure commandline verison == 1.4.23
Firefox/Chrome == latest

In my python code docstrings are written like that:
    """
    Assert on:
        status code == 200
        response from server is JSON
        json response object contains attributes: 'iid', 'sub_site_id'
        'iid', 'sub_site_id' is digits
    """

In the testsuite.xml, generated by adaptor:
      <description>
    Assert on:
        status code == 200
        response from server is JSON
        json response object contains attributes: 'iid', 'sub_site_id'
        'iid', 'sub_site_id' is digits
    </description>

In the testcase.json generated by allure commandline (here we can see line wrapping and "space layout"):
  "description" : {
    "value" : "\n    Assert on:\n        status code == 200\n        response from server is JSON\n        json response object contains attributes: 'iid', 'sub_site_id'\n        'iid', 'sub_site_id' is digits\n    ",
    "type" : "TEXT"
  }

But browser displays description without the line wrapping and "space layout": http://i.imgur.com/LPeF5CN.png
Also I want to say that the description of the test cases would be easier to see in the expanded form (with the possibility of collapse)

Temporarily for myself solved by this way:
<pre> {{test case.description.value}} </ pre>
(templates\testcase\testcase.html 46 line)
But this not the best way I think)

@ex3me0 hi! Sorry for the delay! I'll take a look

closed as duplicate https://github.com/allure-framework/allure-core/issues/690


Add Words to a certain language

Amazing project! Really, I'm not just flattering :)
I was wondering if there is a possibility to add certain words to certain languages on the fly?
Teaching Franc more things on the fly.

@tomerb15 Thank you!
That’s going to be very hard. The three franc’s are built from several sources. The code is generated on publish time by the code in this repo. So though the code to do that is in this repo, the runtime library doesn’t support it.

Thanks for the explanation.
The advantages and options are endless if Franc will be able to learn stuff.
For my project, there are many words and sentences that are being identified as English instead of Portuguese and vise versa, if i can't prevent the next time it happens, i can't use this awesome lib.

For my project, there are many words and sentences that are being identified as English instead of Portuguese and vise versa, if i can't prevent the next time it happens, i can't use this awesome lib.

Just adding words won’t work. That’s not how franc works. It takes a different approach, and this is one of the “not so cool parts” of franc. For less languages but smaller inputs, I believe you’ll fare better using cld.


Image backups incorrect time of last backup

Hi,
Infscape UrBackup Appliance 1.11.4
Exporter V12 (running as a Docker Image
All Image based backups show the
urbackup_backup_lasttime{backup_type="image"}
show incorrect time with a last backup of 1970-01-01 02:00:00
54.6 years or the query<PHONE_NUMBER>
However in the Infiscape GUI it shows the correct date and time

running urbackup_backu_lasttime, shows the ones that have the incorrect time of  0.  so for some of the backups

I had to make some amendment to the temple Granada Dashboard, once I understood, how to fix things for a mix of image and file backups (some clients do either or both).


Bug fix + helper improvements + testing for embedded uint64_t

Bug fix due to inability failing snprintf with uint64_t on embedded:

Added ability to convert from uint64_t to hex string representation on embedded
Generalized uint64 printing function to print either decimal or hexadecimal representation of uint64_t
Added unit tests for conversion from uint64_t to dec or hex

~format


invoke completion-at-point with C-TAB

First : thank you Marjin for both "Eloquent JavaScript" and Ternjs. I owe you a lot for these.
Second: My tern auto complete didn't work as I expected since the default M-TAB invokes OS application  switch key (I use Ubuntu 14.04). I wanted to use  js3-mode, Auto complete(TAB), Yasnippet  (I put it to shift-TAB so it wont conflict with auto) and Tern (I want to invoke it with C-TAB and . )  so I added
    (define-key tern-mode-keymap [(control tab)] 'completion-at-point)

in keymap section of code. Which I think will help many who are new to Emacs.
Now I can get all these great packages together. and who needs WebStorm any more :).
https://github.com/dshamaeli/My-Emacs.git

I think this is something that should go into a user's .emacs, not in the Tern plugin (completion-at-point is a standard command, and where to bind it is up to the user).


Add shutdownAsync for RedisClient

Currently, if users call shutdown() in RedisFuture handler, it'll be a deadlock.
To solve this, introduced shutdownAsync() for RedisClient.

Make sure that:

[x] You have read the contribution guidelines.
[x] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
[x] You submit test cases (unit or integration tests) that back your changes.

@mp911de PTAL

Coverage increased (+0.2%) to 91.997% when pulling 01781277adb5b84dc6f2606bb16dd968f4565d9b on jongyeol:feature/add-shutdown-async into d00f767a9a1780b29ba909c5834308214205665e on mp911de:master.

Coverage increased (+0.2%) to 91.997% when pulling 01781277adb5b84dc6f2606bb16dd968f4565d9b on jongyeol:feature/add-shutdown-async into d00f767a9a1780b29ba909c5834308214205665e on mp911de:master.

Thanks for your PR. I'll take a look in detail. Just out of curiosity: Why would you shut down a client in the scope of another RedisFuture callback?

IMO, First of all, in asynchronous model (like Netty or others), connect/close/shutdown should be async too like Netty's connect/close. If blocking codes and non-blocking codes are mixed in one logic, unintentional long blocking is possible in event loop or one thread.
I know it's not a general case. But, if the connection is temporary like a temporal data checking tool for multiple clusters. Then, users may want to open connection and getting data and close and shutdown "sequentially". And, in CompletableFuture or Promise manner or Reactive way, closing and shutting down in callback is natural for sequence. Of course, if the user uses another executor or thread pool for shutting down, it's no problem. But, for a library, avoiding deadlock or long blocking is better in my thought.

I wasn't questioning the feature at all, I was already curious when someone would ask for that feature. Lettuce would require an end-to-end asynchronous connection (Future<StatefulConnection> connectAsync()) because connection initialization is blocking.

That's merged and polished. You might be also interested in #486.


 It seems to me we're adding a lot of complexity to the frontend to support some fairly minor functionality. Does the admin really need to know what URL endpoints are supported? We only need this because we're not fully implementing the spec, but that's changing quickly. Can't we just say we're implementing the spec at version x (when x is fixed, which I agree is a problem at the moment), and leave it at that?

I think having the right routes reflected to the admin is a really helpful debugging tool for our users.  We might not be fully implementing the spec for a while (whatever the spec ends up being!).  Let's give our users the clearest idea of what works and what doesn't in the mean time; I think that's important.
I also like the decorator abstraction.  It cleans up a bit of the repetition in the decorators on the routes and gives us some more flexibility in what we want to do.

@jeromekelleher pushed change that eliminated the global variable

OK, I buy these arguments @dcolligan. Thanks for clearing out the global variable. I'm +1 modulo my paranoia above.

@jeromekelleher pushed an update with the assert

+1. Merging.


refactor(avm): kernel trace and finalization

The original objective of this PR was to just remove kernel finalize() from trace.cpp. Other things were done on top but I do not claim to have solved or constrained everything.
Something that I realized while working on this: right now gas is broken for SLOAD/SSTORE/UNENCRYPTEDLOG because they still either use SET or take multiple lines (or should). However, if they take multiple lines, we have to move them to their own gadget, and if we do so, then their kernel accesses (1 per item) will make the kernel trace not  be 1-1 anymore. So, we might need to rethink this whole trace.

PIL

Made kernel trace officially virtual
Moved most constraints, lookups, etc from main to kernel
Changed a few constraints; now we will constrain all rows of the execution trace (this bleeds to "last + 1" using the shifts, on purpose)
Changed some names and added some comments to make it more understandable, but still needs love

CPP

Encapsulated kernel finalization in its own finalize
Changed sel_last to actually be the last row of the execution trace, as PIL says. (in any case, it's not used now)
Other misc changes:

error reporting in check circuit now only reports first failure for each subrelation (otherwise rows were spammed, but it didn't mean that the actual row didn't satisfy it, just that the accumulator was already "dirty")
Moved execution hints to their own hpp

#8049  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on  Graphite

Benchmark results
Metrics with a significant change:

avm_simulation_time_ms (Token:mint_public): 73.2 (+64%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 42.6 (-37%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_ms
5,788
1,564 (-1%)
711
748
767 (-1%)

proof_construction_time_sha256_30_ms
11,853
3,197 (+1%)
1,410
1,433 (-1%)
1,477

proof_construction_time_sha256_100_ms
45,436
12,014 (+1%)
5,470 (+1%)
5,429
5,390

proof_construction_time_poseidon_hash_ms
78.0
34.0
34.0 (-21%)
58.0 (-9%)
87.0 (-5%)

proof_construction_time_poseidon_hash_30_ms
1,537
424
201
223
268

proof_construction_time_poseidon_hash_100_ms
5,659
1,519
685 (+1%)
714 (-3%)
746 (-1%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
4,324
7,844
14,852

l1_rollup_calldata_gas
49,708
92,398
177,644

l1_rollup_execution_gas
1,383,202
2,130,860
3,958,145

l2_block_processing_time_in_ms
252 (-3%)
446 (+2%)
805 (-1%)

l2_block_building_time_in_ms
9,315
18,033
36,058 (-1%)

l2_block_rollup_simulation_time_in_ms
9,314
18,033
36,058 (-1%)

l2_block_public_tx_process_time_in_ms
7,851 (-1%)
16,492
34,487 (-1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
2,990
3,871 (+3%)

node_database_size_in_bytes
12,591,184
16,691,280

pxe_database_size_in_bytes
16,254
26,813

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Function
time_ms
bytecode_size_in_bytes

FeeJuice:_increase_public_balance
54.0 (+1%)
8,139

FeeJuice:set_portal
10.5 (-10%)
2,362

Token:constructor
83.9 (+3%)
31,107

FPC:constructor
57.3 (+6%)
22,380

FeeJuice:mint_public
38.8 (+1%)
6,150

Token:mint_public
:warning: 73.2 (+64%)
11,720

Token:assert_minter_and_mint
:warning: 42.6 (-37%)
8,028

AuthRegistry:set_authorized
45.2 (+2%)
4,537

FPC:prepare_fee
239
8,812

Token:transfer_public
21.1 (-23%)
47,358

FPC:pay_refund
58.5 (+2%)
12,082

Benchmarking:increment_balance
967
7,450

Token:_increase_public_balance
38.8 (-7%)
8,960

FPC:pay_refund_with_shielded_rebate
65.4 (-5%)
12,631

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.160 (+2%)

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
2.22 (+3%)
3.93 (-2%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.116 (+3%)
0.112 (-2%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
11.7
18.1 (+1%)
30.2 (-7%)
59.0 (+1%)
114 (+1%)

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.112
0.105 (+1%)
0.0993 (-5%)
0.102 (+1%)
0.102

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
14.4
25.5
43.5 (-1%)
82.1
162 (+1%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
109
207
355
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.109 (-1%)
0.102 (-1%)
0.105 (-1%)
0.102
0.102 (+1%)

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
16.5 (+1%)
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
132
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.106 (+1%)
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
64,779
668,997

Transaction size based on fee payment method
| Metric |  |
| - |  |

Merge activity

Aug 19, 7:10 AM EDT: @fcarreiro merged this pull request with Graphite.


Update PDF to reflect new design and add aliases

Changes the PDF coversheet to reflect the latest design. Also adds
a placeholder for aliases to be populated from the server where
applicable.

This is being dealt with in #116 now 👋


Simplify swiftTestingDirectoryPath.

Since all platform-specific paths in this function end in return nil, we can simplify a bit.
Also a couple of drive-by newline changes.
Checklist:

[x] Code and documentation should follow the style of the Style Guide.
[x] If public symbols are renamed or modified, DocC references should be updated.

@swift-ci please test


Force full documentation

Let's work towards a fully-documented crate. Feel free to rebase from main when necessary.

Now at 450 undocumented items.


Make boss room smaller

User Story
As someone who doesn't like hide and seek, I'd like to be stopped by the boss and not have to search through the boss room for it, so that I don't feel like the boss is hiding from me
Acceptance Criteria

The rooms are smaller
Monsters are moved to stay in the rooms

Why is this feature needed? Please describe the problem your requested feature wants to solve

It can be hard to find the bosses in the rooms and too easy to walk past them
Describe the solution you'd like

Harder to just walk past without even seeing them

Adjust layout of chests in top left corner room on floor 2-4.


AKNodeRecorder creates empty file.

AKNodeRecorder is creating empty files for me.
I don't think installTapOnBus's block is being called. As for why...
Is anyone else having this issue?

Playing and Recording is definitely the order of the day with Laurent also looking at making improvements so we'll tackle this.

Should be fixed soon !
:-)
I have a working beta that does the job.
But not happy with my implementation. Give me 2 days !...
:-)

Sounds good!

Fixed !
(should be online soon in the develop branch)

Nice work Laurent!


Provide real world examples

Feature Description
Please provide real world examples in the style of the docker-compose.yml at Install Elasticsearch with Docker.
A cluster of 2 nodes on the same host are a starting point, I would love to see how to "officially" setup and run a "production" cluster on 3 bare-metal servers.

Hi @bluepuma77,
I see specific techniques for running containers across multiple nodes as a question of orchestration. We (Elastic, and the Docker team specifically) don't make recommendations or assumptions about the orchestration system in use at various sites. Our goal is to provide high-quality images that will work well with Docker in any orchestration context.
A real-world, production-ready configuration is, by its nature, specific to the orchestrator, the storage backend, the network topology and many other site-specific properties. Even if we only consider the orchestrator, we are forced to ask: "should the example focus on Kubernetes, Mesos, ECS, Swarm or something else?".
I would think the best path for someone designing a deployment would be to combine our documentation with a quality book on their orchestrator of choice. Docker is the glue layer between our images and the orchestrator, so our contract is to interact well with Docker. The orchestrator has the same contract, but from the other side, forming a stack. If we "overreach" in the stack layers, we have a terrible combinatorial explosion problem!

Hi @jarpy,
thanks for the response, I do understand your point of view. If you don't want to give a recommendation regarding orchestration that is fine. But I am coming from a different angle.
I want to run Elastic. Clustered. In Docker. 3 machines. Hosted bare metal.
It took me several days to get it up and running with v2.2. With a scripted Docker command for every machine. But it seems with every new version some parameters change and it is suddenly not working anymore.
Furthermore securing the cluster was hard. For port 9200 you could use a http proxy, but for port 9300 you needed a different solution. VPN is hard to configure, Docker swarm mode doesn't allow "unmanaged" containers to use an encrypted swarm overlay network. So create 3 Docker services and "pin" each to a single machine? With X-Pack (security) it should be easier - for 30 days.
Anyway, how about providing simple docker commands to run a cluster on 3 machines?

### SERVER2 ###
...

### SERVER3 ###
...

Clustered. In Docker. 3 machines. Hosted bare metal.

Sure! Docker doesn't really add much complexity then, since you're not dealing with overlay networks and the like. Your script looks pretty solid, and I think it's worth noting that there is very little "Docker stuff" in it. With the exception of the volume attachment flags, the important parts of your script are arguments to the Elasticsearch process. They are the same whether you are running inside Docker or not. Elasticsearch's network settings are well documented already, we shouldn't duplicate them in the Docker section.
What we try to document in the Docker section, is those extra capabilities and complexities that are layered on top the basic Elasticsearch experience. For example, the ability to define settings (such as the network settings) via environment variables.
That might be an old version of your script, so forgive me if I'm on the wrong track, but you also appear to be running the Elasticsearch image that was made by Docker Inc, not this one. The two images have no relation to each other (other than containing Elasticsearch!) so if our documentation seems misaligned with your experience, that might be a big factor.

I think my example is far from complete and not working. I would like to see an "official" real world example on the official Install Elasticsearch with Docker page. How to do it right, set up a redundant Elastic cluster, with best practice commands/files/scripts.
Running Elasticsearch from the command line in Production mode are good headlines, but from my point of view an Elastic cluster on the same machine is useless (power breaks, harddisk breaks, CPU/RAM breaks), the current single docker-compose.yml is for cluster demo purpose only.
A production environment should be at least two machines, so one can fail. With all the implications for the example commands/files/scripts e.g. to connect to another machine, etc.

@dliappis Do you have an opinion on this?

Designing a production-grade deployment of Elasticsearch is a big topic, and involves many variables that are unique to the application and the infrastructure. Sadly, there simply isn't a "one right way" to design and deploy a cluster. Any concrete design that we might suggest would be, necessarily, an incorrect design for many people. We really ,really don't want to give people incorrect information.
Additionally, few of the design decisions around an Elasticsearch deployment are really unique to Docker. So even if we could say what the "right" way is, most of it wouldn't belong in the Docker specific documentation.
We may have been unclear about the meaning of "production mode", sorry if that's so. We don't mean "completely production ready". We simply mean the pre-existing definitions of "production mode" and "development mode" as defined elsewhere in the Elasticsearch documentation. We are, naturally, not suggesting that collocating multiple nodes of a production cluster on the same hardware is a good idea. You are absolutely correct that it's a very bad idea indeed!

@jarpy for sure it's a long way to get to an optimized production grade Elastic cluster.
What I would just like to see is how to actually run basic elasticsearch-docker on multiple machines, not just on a single machine.

I would also like to see a real-world example installation example

There is a discuss comment with a Vagrantfile that can bring two or more vms to serve as an example of running a clustered example with Docker. YMMV and this doesn't take advantage of any advanced orchestration features. There's also a discussion in https://github.com/elastic/elasticsearch-docker/issues/91 on configuring elasticsearch with Docker Swarm.


Automated PR

Notes

This PR is created by StackGen to update the IAC files.

References

StackGen | Docs
Refer this

PR added in DevInfra handson demo session.


Feature/local server component

Packages a specific version of the Server Component into the extension vsix, which will then be automatically installed when connected to a server.
Closes #157.

@william-xiang

We won't do a version bump here because we do not need to.
I removed dsc.ts from the vsix build.


Flynn: Son of Crimson is reported as available in Humble library, but it isn't?

Check for existing issue
Saw nothing obvious to me searching for opened and past with "humble", "flynn", etc. keywords.
Describe the bug
I saw that the game "Flynn: Son of Crimson" is associated to Humble Library in PlayNite, however the game is not in the Humble App.  I checked if I owned it through other bundle, choice, etc. on Humble, but no (I was planning to buy a new bundle so I used Playnite to see what I already have and noticed that and then went looking out of curiosity and no trace of that game in Humble).
I thought it might have been available and removed, so I tried to force update on the Humble Library to see if it removes it from the list (since no more in my library), but it stays there (I suppose it would remove it if that happen or maybe that is the source of the issue?).  I looked the Configuration Options of the "Humble" (not "Humble Keys Library"), and nothing obvious give a hint of why this apparent leak might happen.
If I try to install it, it bring me to the Humble App, but without any prompt.  I tried with another game (A Hat In Time) and it does bring me to a screen to install as expected, but not with "Flynn: Son of Crimson".
So for some reason, it appears to me that game is fetched but isn't really available or... it is available through other means that PlayNite Humble addon figure out but I am not aware of... but logically all these Humble Games Collection should be through the Humble App.
Note: I have not scanned if there are other examples like this, but I can collaborate to compare available list versus reported list if that help.
Diagnostics ID
30527059-c05e-464d-a4b5-1a03f55f78ee

The game is available as part of Humble Games Collection so it's being imported because you also have "Import Humble Choice games" option enabled.
No idea why the install action doesn't work for this specific game.

to see if it removes it from the list
Playnite never removes games automatically, you need to do it manually even if integration plugin stops reporting a game.

Yeah, outside curiosity, it doesn't matter much in practice for me for that game, but it might be important at some point or be something configurable (I have not gave much thoughts yet).
Is there a value somewhere that indicate how the game was imported, etc.!? (Like if I want to debug that the game was added on X date or whatever -- or if I would like to debug what an addon do, like list of games it fetch [yeah, I guess I could go on, understand code base and it would be trivial from there supposing code base is not hard to understand, etc.])
When I talk about fast thoughts:

~If I decide that game X should not appear in my library from Humble library, and if I remove and re-synch it will re-add, maybe there should be a way to ignore the importation of a specific title for a given library (if that doesn't already exist)~
// OK I just tried to remove the game and it gives me the option to add to exclusion list, so already been thought.  I however just deleted and re-imported and the game is not re-imported back as you said (make sense).

Maybe for some library I might want to enable "erase if doesn't exist"... (or maybe it can be a kind of warning -- but I can see this being cumbersome -- just thinking out loud) -- Of course here since I personally have not customized anything, I can probably just delete all "Humble" related games, run sync, and I will have a fresh valid list for current day. (Of course if I decide to alter some meta-data, etc. then I would need to keep delta and be able to re-apply, more complicated somehow if we can't easily manipulate PlayNite database like a developer, or maybe play with tags/category if I really care about such acccuracy/refreshment -- probably hard to automatize/parametrize without some more thoughts)

Of course, if for some reason I altered game data (especially with Humble where we could download some DRM-free game, game might still be valid in library).  Of course for some service (Xbox game pass, etc.?) where games library might cycle, someone might want to know which one are active or past title associated, etc. (and maybe that has already been thought about!)

All in all, if that is the explanation, I would say this is "by design" and a non-issue then (I have never added game manually so far, and if we can find out that game was indeed in Humble (Trove?) then we will be 100% sure, but I think we can safely assume that is what happened here!).  So I close this issue (feel free to reply to my thoughts if you have something to say!)
Thanks
P.S., Game Id was flynn_sonofcrimson_trove (Database Id: d0bd22ff-d910-4a34-bda0-6db5128c4d51) -- probably come from that old Humble Bundle Trove (but I am not subscribed to that since long and did not give it much attention)


Remove unnecessary last layer

Remove last layer argument from layers initialize.

:octocat: cibot: Thank you for posting issue #446. The person in charge will reply soon.


fix run-in-docker instructions

Yah, it turns out both of our instructions are broken.
So I first did "make" and I got this error:
std/generate.sh
cd std && npm run build

><EMAIL_ADDRESS>build /go/src/github.com/jkcfg/jk/std
> mkdir -p build && rollup -c > build/std.js | terser --compress defaults=false,dead_code --module | prettier --stdin-filepath std.js > build/std.js

sh: 1: rollup: not found
sh: 1: terser: not found
sh: 1: prettier: not found

So I then did 'make jk' and it appeared to work.   But the resulting jk didn't have 'std' built in, unsurprisingly.

I got it to work by running make dep outside of docker, ignoring the error about missing go and then running make inside docker.   But I did have node & npm installed.

Ah, ah! that makes sense now. Indeed you need make dep first to retrieve the node modules we need to build the js part of the std library. For instance CI has:
        - ./run-in-docker.sh make dep install test

I forgot the dep step because I have my node_modules directory already.
So I think changing the instructions to:
        - ./run-in-docker.sh make dep jk

would do the trick!

indeed it does! updated.

`quay.io is having an outage at the moment:
docker: Error response from daemon: Get https://quay.io/v2/: EOF.

Re-started the run.

Given we're just changing a markdown file here. Going to merge! thanks a lot for your first contribution! :)


custom client web part(SPFx -sppkg) not appearing in webpart gallery list

Category

[# ]  Bug

Expected or Desired Behavior
Helloword web-part should display on webpart gallery to add in to the SharePoint page
Observed Behavior
After deploying the SPFx webpart in to the app-catalog ,the web-part is not coming in webpart gallery.
Previously it was working but after drop RC0 it is not working for my tenant.
ideally webpart should be there in webpart gallery "under  Development" as configure in webpart.manifest:
"groupId": "fd11922f-5da7-4fba-8828-962969da5295",
"group": { "default": "Under Development" },
Steps to Reproduce
--Create a new webpart using  "yo @microsoft/sharepoint".
-Gulp serve--> working fine.
-after that try to deploy on your dev site like below:
-Change CDN path with you :
"cdnBasePath": "your sharepointsite/SiteAssets/test/"
-gulp bundle --ship
-gulp package-solution --ship
-Upload contents of "temp\deploy" to CDN site path

deploy on AppCatalog
-Add app in your site
-Create a sharepoint page and add webpart
Here i'm not getting my App-part group with name"Under Development" OR "Custom"

Let me know how can i see my webpart?

Hi @vbartari , Is the web part visible on a modern page toolbox? Are you on a dev tenant or a tenant where first release is enabled (not for specific users, but for everyone) ?

@vbartari  how do you know if you are in the tenant where first release has been enabled?

@manishgarg1 and @juanmlarios , Yes first release is enable for my tenant as "first release for ALL".
And as i said in my post i was working on SPFx webpart but after RC0 drop i'm not able to see my old webpart it's giving error and the new  webpart is not coming in webpart selection

Everything is working fine except showing webpart in webpart gallery so please suggest me regarding that only. why webpart is not in inside"Under Development"Or "Custom" after RC0 drop

Hi @vbartari - looks like we found an issue I think.  I had this working last week on a test tenant (on RC0), but something seems to have caused it to stop working.  We'll update this issue when we track what is happening.

Hi @patmill - Yes please update us about the new changes which we need to configure for our SPFx webpart to show in webpart gallery.
also I want to inform you that, one of my colleague's are able to see  RC0 SPFx webpart inside"Under Development"  for one sitecollection in her tenant and same are not coming in different site collection within the same tenant also not in root level site.
This is very different situation where we are not able to understand why it's not coming for all site collection in same tenant and also it's not working for other's tenant except that colleague :(

@vbartari
Question about the CDN path:
"cdnBasePath": "your sharepointsite/SiteAssets/test/"

I assume this is the entry on the write-manifest.jso file in the config folder.
does the SiteAssets/test folder have to exist before the deployment?

Thanks

@dcu-sharepoint : Yes the  SiteAssets/test folder have to exist before the deployment.
steps to follow are:

Run command "Gulp bundle --ship" --It will create package inside Temp--deploy.
upload that packages to your "your sharepointsite/SiteAssets/test/"
Run command :gulp package-solution --ship
it will create app package inside  sharepoint folder
: Upload that "sppkg" in to your appcatalog and deploy
Go to your site collection add the app which you have created and now you should be able to add youe webpart from webpart gallery.
:In my case webpart are not coming after RC0 drop.

I have experienced the same issue. In the same tenancy the web part can be added at a Modern Page after adding the app in one Site Collection and in another Site Collection it does not appear at all. Both Site Collections were created one after another, both have a developer site as the root site and FR is turned on. The web part does however appear in the Layouts version of the workbench in each as I would expect.
I cannot add to a classic SharePoint page in either Site Collection.

thanks vBartari....

From: vbartari<EMAIL_ADDRESS>Sent: Wednesday, January 18, 2017 1:02 AM
To: SharePoint/sp-dev-docs
Cc: L. Carlos Rodriguez; Mention
Subject: Re: [SharePoint/sp-dev-docs] custom client web part(SPFx -sppkg) not appearing in webpart gallery list (#353)
@dcu-sharepointhttps://github.com/dcu-sharepoint : Yes the SiteAssets/test folder have to exist before the deployment.
steps to follow are:

Run command "Gulp bundle --ship" --It will create package inside Temp--deploy.
upload that packages to your "your sharepointsite/SiteAssets/test/"
Run command :gulp package-solution --ship
it will create app package inside sharepoint folder
: Upload that "sppkg" in to your appcatalog and deploy
Go to your site collection add the app which you have created and now you should be able to add youe webpart from webpart gallery.
:In my case webpart are not coming after RC0 drop.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-docs/issues/353#issuecomment-273391635, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVrwrwH_ABYPXANQ6R6_EoofqknJ1hWMks5rTarmgaJpZM4LkfcY.

Hi All @juanmlarios @patmill @dcu-sharepoint ,
Now my tenant and test updated with latest changes related to the RC0 and i'm able to see my Client webpart in all the pages classic as well as in modern.

I am assuming this issue is not resolved. Hence closing. Please reactivate if it continues to be an issue.

same here! now staring to add code to the webpart to read data from a list. and now the fun begins.

From: vbartari<EMAIL_ADDRESS>Sent: Sunday, January 22, 2017 3:40 PM
To: SharePoint/sp-dev-docs
Cc: L. Carlos Rodriguez; Mention
Subject: Re: [SharePoint/sp-dev-docs] custom client web part(SPFx -sppkg) not appearing in webpart gallery list (#353)
Hi All @juanmlarioshttps://github.com/juanmlarios @patmillhttps://github.com/patmill @dcu-sharepointhttps://github.com/dcu-sharepoint ,
Now my tenant and test updated with latest changes related to the RC0 and i'm able to see my Client webpart in all the pages classic as well as in modern.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-docs/issues/353#issuecomment-274357667, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVrwr2I2FDQzpvY7Nw5dTf6Yr0Hz2OQ5ks5rU77WgaJpZM4LkfcY.

Is this issue fixed?
I'm using SPFx v1.0 but still get this error. Do you have any ideas?

I believe I am having the same issue.
I had no problem uploading and deploying an app all week, but today I went through all the steps about 3 times and nothing happens after the sppkg is uploaded to the App Catalog. I am not asked to Deploy anything and the ''deploy'' column still shows ''No''.
I also don't see the application anywhere when I try to ''Add App'' or browse installed Web-Parts on my Communication Site.
Any ideas what could be wrong?

@marcdepelteau  - Is the app valid?  Please include the error messages in the view and see that there are no error messages.  If there are no error messages and you are still not able to deploy it could you send the package to grahamc at Microsoft.com and I can take a look at it.
Thanks,
Graham

@mcmynn83 Hi Graham,
When I look at the app in the list, it is listed as valid, but not deployed. I sent you an email with screenshots and the package as well. Thanks for taking the time to look into this.

Issue has been resolved.  Just needed to deploy the app which is can be done via the ribbon if it is not done at initial upload time (the dialog will launch after upload completes so if you navigate away or stop the browser it may not show up).

Whenever I try to add the app it says "Sorry, something went wrong".
I'm stuck here:
--Create a new webpart using "yo ".
-Gulp serve--> working fine.
-after that try to deploy on your dev site like below:
-Change CDN path with you :
"cdnBasePath": "your sharepointsite/SiteAssets/test/"
-gulp bundle --ship
-gulp package-solution --ship
-Upload contents of "temp\deploy" to CDN site path
-deploy on AppCatalog
-Add app in your site I cannot add it says Something went wrong but all above went fine
Any Ideas???

"Features like JavaScript and CSS are available on the local computer, so rendering web parts will fail unless your local host is running". Open  .manifest.json from \ dist folder.
"internalModuleBaseUrls": [
"https://`your-local-machine-name`:4321/"
]
Execute local server: gulp serve --nobrowser So try add webpart again.
https://docs.microsoft.com/pt-br/sharepoint/dev/spfx/web-parts/get-started/serve-your-web-part-in-a-sharepoint-page


Contacts and places are sorted case insensitive

Avoid duplicates

[X] Bug is not mentioned in the FAQ
[X] Bug is specific for Android only (cannot check on Apple hardware)
[X] Bug is not already reported in another issue

Describe the bug
Contacts and places are sorted case insensitive. That makes it harder to find a contact again, if names are (accidentally) created with mixed lowercase and uppercase characters. UI elements sorted alphabetically should generally be case insensitive in all applications.
Steps to reproduce the issue

Create contact "B".
Create contact "A1".
Create contact "a2".

Expected behaviour
Contacts should be sorted A1, a2, B (case insensitive). Contacts are sorted A1, B, a2 (case sensitive).
The same issue exists for places.
Possible Fix
If that is a Java collection being sorted, a second argument String.CASE_INSENSITIVE for the Collections.sort() call would be an appropriate fix.

Internal Tracking ID: EXPOSUREAPP-4488

I created a PR (#2017) to fix this issue for persons, locations and the overview itself.

Dear @Bananeweizen, @PhilippNowak96, and community
Thank you for your contributions. We have created a ticket for the bug in the internal Jira system. Any further developments will be notified here in this Github issue.
Best wishes,
DS

Corona-Warn-App Open Source Team
Internal Tracking ID: EXPOSUREAPP-4488

Tested: not an issue in iOS 14.3 / iPhone 6s / CWA 1.10.1

"Fix sorting of persons and places to be case insensitive for names (EXPOSUREAPP-4488)(closes #2012)" https://github.com/corona-warn-app/cwa-app-android/pull/2017 is included in v1.11.0-RC1.

"Fix sorting of persons and places to be case insensitive for names (EXPOSUREAPP-4488)(closes #2012)" https://github.com/corona-warn-app/cwa-app-android/pull/2017 is included in v1.11.0-RC1.


Added option to hide Container

I needed a way to hide containers but I couldn't figure out a way to do so.
I plan to update the docs and add an example, but could you check if you like the way it was programmed before I do that.
Thanks a lot!
Example usage
buildingContainer := widget.NewContainer(
		// the container will use a plain color as its background
		widget.ContainerOpts.BackgroundImage(image.NewNineSliceColor(color.NRGBA{0x13, 0x1a, 0x22, 0xff})),

		// the container will use an anchor layout to layout its single child widget
		widget.ContainerOpts.Layout(widget.NewRowLayout(
			widget.RowLayoutOpts.Spacing(10),
			widget.RowLayoutOpts.Padding(widget.Insets{
				Top:    10,
				Bottom: 10,
				Left:   10,
				Right:  10,
			}),
		)),
	)
buildingContainer.Hidden = true

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Good morning! I love the idea of hiding elements but I think the property
belongs on the widget object not the container. That way we can set any
widget to hidden.
So you could call
container.GetWidget().Hidden = true
or
button.GetWidget().Hidden = true
On Wed, Jul 5, 2023, 10:29 AM CLAassistant @.***> wrote:

[image: CLA assistant check]
https://cla-assistant.io/ebitenui/ebitenui?pullRequest=81
Thank you for your submission! We really appreciate it. Like many open
source projects, we ask that you sign our Contributor License Agreement
https://cla-assistant.io/ebitenui/ebitenui?pullRequest=81 before we can
accept your contribution.
You have signed the CLA already but the status is still pending? Let us
recheck https://cla-assistant.io/check/ebitenui/ebitenui?pullRequest=81
it.
—
Reply to this email directly, view it on GitHub
https://github.com/ebitenui/ebitenui/pull/81#issuecomment-1621878999,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJ7PVTC6L7JJIPLEHMIJ2TXOV237ANCNFSM6AAAAAAZ7BMIS4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks @mcarpenter622 I knew I wasn't on the right track.
I added the attribute to Widget and adapted the layout render to ignore widgets that are in Hidden state.
This still needs to be tested with all layout types, but wanted to get your thoughts on code.

Other than some misspellings in your comments, that looks good to me! I'll
have to test it later to confirm but thank you for the awesome work!
On Wed, Jul 5, 2023, 1:12 PM Samuel @.***> wrote:

Thanks @mcarpenter622 https://github.com/mcarpenter622 I knew I wasn't
on the right track.
I added the attribute to Widget and adapted the layout render to ignore
widgets that are in Hidden state.
This still needs to be tested with all layout types, but wanted to get
your thoughts on code.
—
Reply to this email directly, view it on GitHub
https://github.com/ebitenui/ebitenui/pull/81#issuecomment-1622166581,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJ7PVWDC5WADPHDPKBCTPLXOWN75ANCNFSM6AAAAAAZ7BMIS4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Alternatively we could add something like HiddenBehaviour with NonBlocking and Blocking

How about an enum for Visibility?:
Visibiilty_Show
Visibility_Hide //hidden but takes up space
Visibility_None //hidden and doesn't take up space
On Thu, Jul 6, 2023, 4:09 AM Samuel @.***> wrote:

Alternatively we could add something like HiddenBehaviour with NonBlocking
and Blocking
—
Reply to this email directly, view it on GitHub
https://github.com/ebitenui/ebitenui/pull/81#issuecomment-1623186748,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJ7PVXIKF2M43KXVZRZMRLXOZXCZANCNFSM6AAAAAAZ7BMIS4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Great idea. I'll code it in and do some testing.

I added an example to play with. There's still odd behavior with RowLayout where the blue box in the example still takes up space although it's set to Visibility_None. I'm not sure how to fix that. Any guidance @mcarpenter622?
I'm not sure about the names also:
Visibility_Show Visibility = iota
Visibility_Hide            // Hide widget, but take up space
Visibility_None            // Hide widget, but don't take up space

When I was using it the difference between Visibility_Hide and Visibility_None was confusing. From the names it's hard to see which is which. What do you think about Visibility_Hide_Blocking and Visibiliy_Hide?

@kidk  Sorry for taking so long to respond, been dealing with some stuff with work.  I am ok with the suggested names. I havent had a chance to check out the Row Layout issue yet.

No worries @mcarpenter622 There's no urgency from my side at all, so whenever you have time. 👍
I'll make the suggested changes soon.

So I've been testing this tonight and from what I can tell the RowLayout is working as expected. The issue with the blue box in your PR is that it is in a gridLayout. GridLayouts have a column and stretch setting, It doesn't care about what children are in each cell.  I changed middleContainer to a RowLayout and added a 3rd element. When I "None" or "Hide' the blue box, the new child behaves as I would expect.   All in all this looks like a great change. My only requests are 1) Update the enum names if you'd like, and add a section in the launch.json file for visibility (alphabetized) Otherwise I am happy to merge this!

Hey @kidk I really like this PR! Just checking to see if you're still willing to update it? If not I'll make the few changes I mentioned a couple weeks ago and merge it =)

@mcarpenter622 I've updated the constants and example.
I think it's good for final review

Thank you for the great PR! Sorry it took me so long to review it. I didnt get an alert when you commented for some reason =(.


Overriding default properties from API example

Good afternoon,
My apologies in advance if this ends up being a "stupid" question...
For whatever reason, the very simple example for stamp.props(...args) from the API docs doesn't appear to be working for me. The baffling thing is I've used stampit before and don't recall ever having this issue...
I have an index.js file that looks exactly like the example:
// index.js
const stampit = require('stampit');

const stamp = stampit().props({
  factor: 1
});

console.log(stamp().factor); // 1
console.log(stamp({factor: 5}).factor); // 5

When I run node index.js each log outputs 1, instead of 1 and 5 as expected:
stampit-test$ node index.js
1
1

I have a completely clean folder with nothing but index.js and stampit ^3.1.3 as the only dependency. I'm running node 6.11.2 (which is the latest LTS, or at least close) and npm 5.3.0.
Let me know your thoughts, of if I'm just completely crazy and/or doing something absolutely wrong. :)

Stamp is a new paradigm. It's natural to have issues. :)
Your code implies that you are using stampit v2. However, you are using v3. Basically, you hit the breaking change between v2 and v3.
See here: https://github.com/stampit-org/stampit/releases/tag/v3.0.0

The factory first argument properties are no longer automatically assigned to the instance.

You'll find there the change, and a workaround if really needed.
The good news is - there were no breaking changes for a year. Moreover, no breaking changes are expected in any foreseeable future. :)
Feel free to post any other questions. Cheers 👍

btw, fixing the docs now.


When @Test methods are defined in a parent and child @AfterClass methods are called twice

public abstract class A {
	@Test
	public void test0() {
		System.out.println("test0: "+ this.getClass().getCanonicalName());
	}

	@AfterClass
	public void afterClass0() {
		System.out.println("afterClass0" + this.getClass().getCanonicalName());
	}
}

public class B extends A {
	@Test
	public void test() {
		System.out.println("test: "+ this.getClass().getCanonicalName());
	}

	@AfterClass
	public void afterClass() {
		System.out.println("afterClass"+this.getClass().getCanonicalName());
	}
}

results in:
test0: B
afterClassB
afterClass0B
test: B
afterClassB
afterClass0B
which is IMHO incorrect
I guess this was introduced in commit:
Fixed: @AfterClass not being run in some subclassing situations
  public synchronized boolean removeAndCheckIfLast(ITestNGMethod m, Object instance) {
    List<ITestNGMethod> l = m_classMap.get(instance);
    if (l != null) {
      l.remove(m);
      // It's the last method of this class if all the methods remaining in the list belong to a
      // different class
      for (ITestNGMethod tm : l) {
        if (tm.getRealClass().equals(m.getRealClass())) return false;
      }
      return true;
    } else {
      throw new AssertionError("l should not be null");
    }
  }

would return true twice after @Tests from Both classes A and B

Why is that the expected behavior? A lot of our test fail because of this behavior. Our expectation of the AfterClass was that it was called once, after all the test of the instance are runned. Why? because the parent test setup some resources on which the child test depends on. So we may have this issue:
parent.beforeClass: setup some resources
parent.test
parent.afterClass: clean those resources
child.test: use those resources, but woups! Those resource are now cleaned.

The @AfterClass method you define in the parent is seen in each child, per Java's inheritance rules.
Either you re-init these resources in each @BeforeClass or you shouldn't put your clean up code in the @AfterClass. How about an @AfterTest and grouping all your classes that need this clean up once in the same  tag?

I opened issue https://github.com/cbeust/testng/issues/110 with a more explicit example of why that should be the expected behavior.


Document fields of bitfield

It might be useful to be able to add documentation comments to the (custom) fields of a public bitfield, because they are part of the public API.
I haven't encountered the need for this just yet, but it could come up later.

Implemented in d893497.
With the current implementation, the documentation comments for the getter and setter are the same. But I think this is enough for most use case.

Thank you for your speed of issue fixing.


Undefined method `set_flash_message!'

I have custom Registtration Controller and receive an error
Undefined method `set_flash_message!'
class Users::RegistrationsController < Devise::RegistrationsController
def create
build_resource(sign_up_params)
resource.save
yield resource if block_given?
if resource.persisted?

  resource.add_role "user"

  if resource.active_for_authentication?
    set_flash_message! :notice, :signed_up
    sign_up(resource_name, resource)
    respond_with resource, location: after_sign_up_path_for(resource)
  else
    set_flash_message! :notice, :"signed_up_but_#{resource.inactive_message}"
    expire_data_after_sign_in!
    respond_with resource, location: after_inactive_sign_up_path_for(resource)
  end
else
  clean_up_passwords resource
  set_minimum_password_length
  respond_with resource
end

end

You need to give us more information on how to reproduce this issue, otherwise there is nothing we can do. Please read CONTRIBUTING.md file for more information about creating bug reports. Thanks!


UI-Banners not showing on Login screen

Rancher Server Setup

Rancher version: 2.4.17 & 2.5.9 & 2.6.0
Installation option (Docker install/Helm Chart): Helm Chart

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): RKE1

Proxy/Cert Details: None

Information about the Cluster

Kubernetes version: 1.18.20
Cluster Type (Local/Downstream): Local

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): N/A

Describe the bug
UI-Banners show once logged in, but does not show on login page. Banners should display on login page.
To Reproduce

Set any banner
Logout

Result
Login Page does not have banner
Expected Result
UI-Banner show on login page
Screenshots

Additional context

confirmed this is an issue on v2.6.0:
We should show banners on the login page

tested on 2.6-head (a6e7905):

header banner shows on login screen - pass
footer banner shows on login screen - pass

Other issues:

both of these work, but there seems to be some sort of caching issue; sometimes when I log out, the banner(s) aren't showing. But a hard refresh fixes the issue. I think this is OK to close for now, as we have other tickets logged for refresh issues.


Update spring-boot-loader-tools, ... to 3.1.2

About this PR
📦 Updates

org.springframework.boot:spring-boot-loader-tools
org.springframework.boot:spring-boot-maven-plugin

from 2.7.14 to 3.1.2 ⚠
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (2.7.14).
You might want to review and update them manually.
README.adoc

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.springframework.boot" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.springframework.boot" }
}]

labels: library-update, early-semver-major, semver-spec-major, old-version-remains, commit-count:1

Superseded by https://github.com/lefou/mill-spring-boot/pull/54


Change driver.py and geomstr.py to do interpolation for a line.

This request is needed for Moshiboard based laser cutter since Moshiboard do not interpolate as expected as in the Meerk40t codes.
Moshiboard does not correctly cut an oblique line like in following image.

When Moshiboard is requested to cut a oblique line, it cuts with two lines. One is 45 degrees angled line and the other is horizontal or vertical line. The following image shows this.

Above shows the issue and below shows the result with the changes included in this pull request.

Thank you for your comments.
I took quik-hack approach and found that self._goto_absolute(x, y, on & 1) at the line 398 in meerk40t/moshi/driver.py command Moshiboard to cut lines and arcs. Since Moshiboard does not have Zingl-Bresenham line draw algorithm to cut a line, we need to cut a line into segments. So I changed two files to treat a line as an arc.
I don't intend to change a horizontal or vertical line to small zig-zag lines.  Sorry if my change do that. I just thought such a line will segmented into small horizontal or vertical lines and there should be no harm theoretically since arcs are already segmented as such.
I don't know if the change for the line 238 in moshi/driver.py I proposed is really needed.

Thank you for your comments.
I took quik-hack approach. I din't intend to change a horizontal or vertical line to small zig-zag lines.
How about changes like attached file? It only changes moshi/driver.py.
20241003.txt

Oh, please just ignore comment line below

               # use Zingl-Bresenham line draw algorithm

Thank you for your comments.
I took quik-hack approach. I din't intend to change a horizontal or vertical line to small zig-zag lines.
How about changes like attached file? It only changes moshi/driver.py.
20241003.txt

Looking good to me, did you test it ?

Yes, I have tested it.


Documentation and Example page missing

Describe the bug
at this page:  https://capacitor-community.github.io/stripe/
the links to Documentation and examples point to :
. https://zyra.github.io/capacitor-stripe/installation
. https://zyra.github.io/capacitor-stripe/usage
Expected behavior
A clear and concise description of what you expected to happen.
they should point to :
https://capacitor-community.github.io/stripe/installation
https://capacitor-community.github.io/stripe/usage

thx you kind sir

Thanks for issue!
Today this plugin of v3 is released. This not compatible with v1. All APIs have been revamped. So I will close this issue. If you still have the same problem, please create a new Issue. Thank you.


Using a non-Supabase OAuth implicit grant flow for non-login purposes logs the user out

We're running into https://github.com/supabase/gotrue-js/issues/527 but it was closed incorrectly as @hf seemed to not fully grok the issue. In fact their comment:

If you need to use OAuth in your app for other purposes (to re-authorize or ask for a bigger scope -- to read a user's contacts for example) you should implement this within your app.

Is exactly what fails due to the issue. You can not implement an implicit grant oauth request within your application without go-true hijacking the returning request and assuming it's a supabase login.
Say for example my application uses supabase for auth but somewhere in my app I use an implicit grant flow to get access to a user's data on a third party site, not a supabase auth provider, just another site that uses implicit oauth grants to access data. gotrue-js hijacks the callback because it thinks it's seeing a incoming supabase grant when in fact it's seeing the third party grant. This not only blocks finishing the third-party grant it wipes the current supabase session.
Original issue details below.

Bug report
Describe the bug
If a site using Supabase Auth uses an OAuth implicit grant flow for reasons other than managing user accounts (e.g., fetching data from a third party website), then upon redirect, GoTrueClient will automatically detect the #access_token fragment, and attempt create a session using that token.
This token, naturally, cannot be used for Supabase authentication. The resulting error causes any existing user session to be removed.
To Reproduce

Go to supabase.com, and log in to your user account.
Append #access_token=anystring to the URL, and reload the page.
Observe that you have been logged out.

This can also be demonstrated in a fresh project such as https://github.com/supabase/supabase/tree/master/examples/user-management/nextjs-ts-user-management
Any OAuth grant flow that places an unrecognized #access_token in the URL will also log out the user, whether it was intended to or not.
Expected behavior
The user remains logged in during OAuth flows unrelated to user account management. Failing that, the app clearly communicates that

A user login process has been initiated due to URL contents.
The login process failed due to an invalid access token.

System information
Reproduced in supabase-js 1 and 2, with gotrue-js 1.24 and 2.2.2.
Additional context
I'm a dummy, so for all I know this is a feature request rather than a bug report, but it drove me crazy for a hot minute until I figured it out.
Workaround/fix:
I fixed this for myself by patching GoTrueClient's _isImplicitGrantFlow method to check for a custom flag in the state argument that I give to the OAuth provider, preventing _getSessionFromUrl from triggering unintentionally.
_isImplicitGrantFlow() {
        return (isBrowser() &&
            (Boolean(getParameterByName('access_token')) ||
                Boolean(getParameterByName('error_description')))
                && Boolean(!getParameterByName('state')?.startsWith('nogrant')));
    }

Another solution might involve a client option to designate a URL path where GoTrueClient will ignore #access_tokens, and using that path in the OAuth redirect for non-login OAuth providers.

Is exactly what fails due to the issue. You can not implement an implicit grant oauth request within your application without go-true hijacking the returning request and assuming it's a supabase login.

I see, this makes some sense. I'll see what we can do about this in future major versions. There's no way for us to change the behavior now without breaking backward compatibility. Until then, you can use the detectSessionInUrl option, which when set to false won't pick up the implicit flow parameters from the OAuth redirect back to your application.
For example, if the OAuth redirect takes the user back to /oauth-callback on your application, you can initialize GoTrueClient like so:
new GoTrueClient({
  detectSessionInUrl: window.location.pathname !== "/oauth-callback"
})

Or, when using supabase-js, something like:
createClient('...', '...', {
  auth: {
    detectSessionInUrl: window.location.pathname !== "/oauth-callback"
  }
})

I'll close this as won't fix but will be addressed in v3.


Fixed width for song title

Hi,
I like your app. I would like to suggest a new feature. Sometimes when the song name gets too long it disappears from the menubar so I suggest giving a fixed width for the title in the menubar while the title is moving back and forth to show the whole of it. If anybody finds it irritating for something to be constantly moving in the menubar, the feature could be turned off from settings.

Please read the "Issues" tab before posting your own, as there is a similar issue - #71 .
https://github.com/kmikiy/SpotMenu/issues/71
Thanks.

Hi,
I created a pull request that lets the user define their own maximum width, that way the user can decide how much space should be used at max and solve this issue .
Have a look here: https://github.com/kmikiy/SpotMenu/pull/207
Cheers!


"Require Cycle" warning is back on 4.0.1

Describe the Bug
When launching the app I get the "Require Cycle" warning that we've had in previous versions.

Require cycle: index.js -> node_modules/react-native-track-player/src/index.ts -> node_modules/react-native-track-player/src/hooks/index.ts -> node_modules/react-native-track-player/src/hooks/useIsPlaying.ts -> index.js
Require cycles are allowed, but can result in uninitialized values. Consider refactoring to remove the need for a cycle.
Screen Capture on Android device:

Steps To Reproduce
How can someone else reproduce this bug?
Install 4.0.1, build and launch app
Environment Info:
Paste the results of npx react-native info

System:
OS: macOS 14.1
CPU: (10) arm64 Apple M1 Pro
Memory: 497.20 MB / 32.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 16.19.1 - ~/.nvm/versions/node/v16.19.1/bin/node
Yarn: 1.22.21 - ~/.nvm/versions/node/v16.19.1/bin/yarn
npm: 8.19.3 - ~/.nvm/versions/node/v16.19.1/bin/npm
Watchman: Not Found
Managers:
CocoaPods: 1.14.2 - /Users/jlopezdominguez/.rvm/rubies/ruby-3.0.0/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 23.4, iOS 17.4, macOS 14.4, tvOS 17.4, visionOS 1.1, watchOS 10.4
Android SDK: Not Found
IDEs:
Android Studio: 2023.2 AI-232.10227.8.2321.11479570
Xcode: 15.3/15E204a - /usr/bin/xcodebuild
Languages:
Java: <IP_ADDRESS> - /opt/homebrew/opt/openjdk@17/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 17.0.2
react-native: 0.67.5 => 0.67.5
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found

Paste the exact react-native-track-player version you are using
4.0.1
Real device? Or simulator?
Both
What OS are you running?
Tested on Android 13 and 14, also iOS 16.4 and 16.5.1

try https://github.com/lovegaoshi/react-native-track-player/commit/de77707abb8d20042dcdfc014524b6bd84bf5f1b


Biome Bundle not working

Hi, im trying to use biome bundle but its not working. I type /mv create WorldName normal -g TerrainControl but it justs makes a vanilla world.

Make sure to check the server console for errors.

Try typing "/mv create world normal -g TerrainControl".
The default name for a Biome Bundle world is 'world', not 'WorldName'.

If you're attempting to use BiomeBundle on 1.11, then the issue may be that BiomeBundle includes an outdated version of TerrainControl. Try using TerrainControl for 1.11: http://forum.mctcp.com/t/terraincontrol-for-spigot-1-11/1324/10

Biome Bundle works fine with latest builds.

Gotta love that support time


Counters on Mac OSX

similar to '/proc/'
or, a DTrace solution

we will not implement a Mac specific solution for now.


Merge pull request #869 from Microsoft/dev

Push dev to master for v7.1.2

Codecov Report

Merging #870 into dev will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #870      +/-   ##
============================================
+ Coverage     48.74%   48.77%   +0.02%
- Complexity     2799     2801       +2
============================================
  Files           116      116
  Lines         27875    27875
  Branches       4650     4650
============================================
+ Hits          13589    13595       +6
+ Misses        12083    12079       -4
+ Partials       2203     2201       -2

Flag
Coverage Δ
Complexity Δ

#JDBC42
48.3% <0%> (+0.02%)
2759% <0%> (+2%)
:arrow_up:

#JDBC43
48.72% <0%> (ø)
2801% <0%> (+2%)
:arrow_up:

Impacted Files
Coverage Δ
Complexity Δ

...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
45.73% <0%> (-0.66%)
108% <0%> (ø)

...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java
33.11% <0%> (+0.34%)
258% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b331c3b...0703897. Read the comment docs.