finish unit tests for AllReady.Areas.Admin.Controllers.EventController(EventAdminController.cs)

@tonysurma, @MisterJames please label with "jump-in". Part of Issue #620
some tests exist, but the rest are stubbed out in:
AllReady.UnitTest.Areas.Admin.Controllers.EventAdminControllerTests

I'm looking to jump-in on this one.  Did this class disappear?

@SteveKennedy, what happened here is there was a global renaming of anything called "activity" to "event". Looking at the history of the EventControllerTests, it used to be named ActivityControllerTests, so I'll change the name of this Issue to reflect the name change.
Looking at EventControllerTests, it looks like there are still plenty of tests to be written, so feel free to start into them.
Thanks

@tonysurma could I take this one? I'm pretty sure I can get a couple of tests done this weekend.

sure, thanks

@tonysurma, this is a dupe of Issue #617. One of these should be closed and just leave the one open to represent the work that still needs to be done

leaving this open

@tonysurma I've been looking at these tests as a way to get more familiar with Moq.  I've filled in a few of the stubs and found some bad tests.  Please assign me 😄

@mgmccarthy Question: Looking at the stub for CreateGetSendsCampaignSummaryQueryWithCorrectCampaignId.  Not sure what the intent of this test.  CampaignSummaryQuery is not publicly exposed in the EventController class.

@c0g1t8, I'm not too sure what you mean "is not publicly exposed"...
The EventController class's Create method looks like this:
[Route("Admin/Event/Create/{campaignId}")]
public async Task<IActionResult> Create(int campaignId)
{
    var campaign = await _mediator.SendAsync(new CampaignSummaryQuery { CampaignId = campaignId });
    if (campaign == null || !User.IsOrganizationAdmin(campaign.OrganizationId))
    {
        return Unauthorized();
    }

    var viewModel = new EventEditViewModel
    {
        CampaignId = campaign.Id,
        CampaignName = campaign.Name,
        TimeZoneId = campaign.TimeZoneId,
        OrganizationId = campaign.OrganizationId,
        OrganizationName = campaign.OrganizationName,
        StartDateTime = DateTimeTodayDate(),
        EndDateTime = DateTimeTodayDate()
    };

    return View("Edit", viewModel);
}

the test stub should test that the CampaignSummaryQuery is being sent with the correct CampaignId

@mgmccarthy Looked into the other tests.  Should this be CreateGetReturnsCorrectView_AndCorrectCampaignID?

@mgmccarthy Okay - just got it.  The test to ensure that CampaignSummaryQuery is called once with the correct parameters. 😄   Thanks.

@c0g1t8, it does not return CampaignId, it returns EventEditViewModel.
Please do a search for other controller's that use mediator.SendAsync in the code. Then find that controller's unit tests. There are a ton of examples that show how to test what the mediator is sending
The CreateGetSendsCampaignSummaryQueryWithCorrectCampaignId unit only tests this line of the action method:
var campaign = await _mediator.SendAsync(new CampaignSummaryQuery { CampaignId = campaignId });

@mgmccarthy I think I've found a possible bug.  I'm working on PostEventFileSendsEventByEventIdQueryWithCorrectEventId.

The order of parameters calling UploadEventImageAsync appear to be incorrect in PostEventFile method of the EventController class.
I'm not sure what the course of action should be.  Do I fix the controller and submit it as part of the updated tests?  Do I file a separate issue?
Looking for guidance.

Don't know how I removed myself.  Can one of the powers to be please reassign me. 😄

I think because you removed yourself I can't assign you...

c0g1t8, check the implementation of IImageService.UploadEventImageAsync and see where it actually puts the image (aka, the path to the file). I believe the implementation uses Azure blob storage, so my guess is that the blob path would differ based on the word "Event" or something along those lines.

@c0g1t8

I'm not sure what the course of action should be. Do I fix the controller and submit it as part of the updated tests? Do I file a separate issue?

First check the implementation. If the two params (organizationId and eventId) are "backwards" as your finding suggests, then open a separate issue for it. It should not be part of the unit test work you're doing.
Thanks

regardless of github not allowing re-assignment (don't know why) you can make a PR - thanks!

@mgmccarthy Working on MessageAllVolunteersReturnsHttpNotFoundResult_WhenEventIsNull.  MessageAllVolunteers does not have a code path that returns HttpNotFoundResult.
       [HttpPost]
        [ValidateAntiForgeryToken]
        public async Task<IActionResult> MessageAllVolunteers(MessageEventVolunteersViewModel viewModel)
        {
            if (!ModelState.IsValid)
            {
                return BadRequest(ModelState);
            }

            var eventsOrganizationId = await _mediator.SendAsync(new OrganizationIdByEventIdQuery { EventId = viewModel.EventId });
            if (!User.IsOrganizationAdmin(eventsOrganizationId))
            {
                return Unauthorized();
            }

            await _mediator.SendAsync(new MessageEventVolunteersCommand { ViewModel = viewModel });

            return Ok();
        }

Skip this test or create a new issue?  I'm thinking the latter.

@mgmccarthy Dug farther.
public async Task<int> Handle(OrganizationIdByEventIdQuery message)
{
    var @event = await _context.Events.AsNoTracking()
        .Include(e => e.Campaign)
        .ThenInclude(c => c.ManagingOrganization)
        .SingleAsync(t => t.Id == message.EventId);

    return @event.Campaign.ManagingOrganization.Id;
}

The implementation assumes @event will always will be found.  I think this is a bad assumption.
I'm thinking we need to re-implement MessageAllVolunteers with EventByEventIdQuery instead.  This will allow for a check for when Event is null.
public async Task<Event> Handle(EventByEventIdQuery message)
{
    // TODO: can we leave off some of these .Include()?
    return await _context.Events
        .Include(a => a.Location)
        .Include(a => a.Campaign).ThenInclude(c => c.ManagingOrganization)
        .Include(a => a.RequiredSkills).ThenInclude(rs => rs.Skill).ThenInclude(s => s.ParentSkill)
        .Include(a => a.VolunteerTasks).ThenInclude(t => t.AssignedVolunteers).ThenInclude(tu => tu.User)
        .Include(a => a.VolunteerTasks).ThenInclude(t => t.RequiredSkills).ThenInclude(ts => ts.Skill)
        .SingleOrDefaultAsync(a => a.Id == message.EventId);
}

The queries don't match and I don't know the domain well enough to know if that's a valid option.
Thoughts?

@c0g1t8

Working on MessageAllVolunteersReturnsHttpNotFoundResult_WhenEventIsNull. MessageAllVolunteers does not have a code path that returns HttpNotFoundResult

I'd delete the test stub. FYI, these test stubs were created a while ago, and there have been code changes to the classes the test stubs test, so some of them might no longer be relevant or even make sense.

@c0g1t8

The implementation assumes @event will always will be found. I think this is a bad assumption.

No, this is a good assumption.
Where did the eventId come from that we're using to look up the event? It was passed in as a value on the MessageEventVolunteersViewModel:
public async Task<IActionResult> MessageAllVolunteers(MessageEventVolunteersViewModel viewModel)

what code calls the MessageAllVolunteers action method? The \Areas\Admin\Views\Event\Details.cshtml view:
<form asp-area="Admin" asp-controller="Event" asp-action="MessageAllVolunteers" method="post">

        <input type="hidden"<EMAIL_ADDRESS>name="eventId" id="message-eventId">

            Subject
            <input type="text" class="form-control wide" name="subject" id="messageVolunteersModal-subject">

            Message
            <textarea rows="4" class="form-control wide" name="message" id="messageVolunteersModal-message"></textarea>

Sending message...

 Message sent

        <button type="button" class="btn btn-default" data-dismiss="modal">Close</button>
        <button type="submit" id="sendMessageToVolunteers" class="btn btn-primary">Send Message</button>

</form>

you can see above, we're passing in the @Model.Id for the eventId value. What loads the Details.cshtml page and give the @Model.Id its value? The EventAdminController.Details action method, which has the EventId on the EventDetailQuery viewmodel.
So the value is guaranteed on the read that loads the Details.cshtml page. If you look a the code, you'll see that if EventDetailQuery returns null, the page will not be loaded.
So, what would be the reason that the eventId would not be there? It's guaranteed to be loaded by the Details action method and it's a hidden value on the Details.cshtml view.
The only logical reason for that lookup to fail is if someone deleted the event between the time you loaded the details page and clicked on the Message All Volunteers button. I'm not too sure if you can delete an event (and if you can, why you'd want to delete an event), but both ops (delete the event, or Message all Volunteers) are both performed by a user with admin access. My initial guess is this will be one person, or a small group of people that are allowed to do admin-based operations per Campaign and or Org.
Try not to put .SingleOrDefault on every query "just in case". This makes it tougher for new contributors to understand the system. If there is a query using .SingleOrDefault, the first question I ask myself is "why would this value/query return null?". Then I work backwards from the query to see how the parameter(s) supplied by the query are created/loaded. Almost every time you do this, you can see that the Default part of the query can be left off b/c there is either no logical reason for the query to fail, or there is a VERY small edge case around non-collaborative data where something MIGHT be missing.
I wrote a blog post about this very thing. Give it a read if you'd like:
http://www.michaelgmccarthy.com/2017/01/27/optimize-for-the-happy-path-null-checks/

@mgmccarthy

I'd delete the test stub. FYI, these test stubs were created a while ago, and there have been code changes to the classes the test stubs test, so some of them might no longer be relevant or even make sense.

Deleting MessageAllVolunteersReturnsHttpNotFoundResult_WhenEventIsNull and proceeding onwards. 😄

@mgmccarthy

I wrote a blog post about this very thing. Give it a read if you'd like:
http://www.michaelgmccarthy.com/2017/01/27/optimize-for-the-happy-path-null-checks/

Very insightful.  I do agree that we often write too much defensive code especially when you are in control of all the entry points.

@c0g1t8 after you accept the invite I can assign you again.  Thanks

@mgmccarthy - I found another test that looks like it needs to be deleted DeleteConfirmedSendsEventDetailQueryWithCorrectEventId
Below is the code for the method:
[HttpPost, ActionName("Delete")]
[ValidateAntiForgeryToken]
public async Task<IActionResult> DeleteConfirmed(DeleteViewModel viewModel)
{
    if (!viewModel.UserIsOrgAdmin)
    {
        return Unauthorized();
    }

    await _mediator.SendAsync(new DeleteEventCommand { EventId = viewModel.Id });

    return RedirectToAction(nameof(CampaignController.Details), "Campaign", new { area = "Admin", id = viewModel.CampaignId });
}

I'm pretty sure that it needs to be deleted since EventDetailQuery is never called.

@mgmccarthy
Renaming EditPostAddsValidationErrorsToModelStateErrors_WhenEventDetailsModelValidatorHasErrors to EditPostAddsValidationErrorsToModelStateErrors_WhenEventEditViewModelValidatorHasErrors.
Renaming EditPostReturnsCorrectView_WhenEventDetailsModelValidatorHasErrors to EditPostReturnsCorrectView_WhenEventEditViewModelValidatorHasErrors.
Trying to be descriptive and accurate.  I am assuming that will be alright with you.

@mgmccarthy
I'm working on EditPostInvokesUploadEventImageAsyncWithTheCorrectParameters_WhenModelStateIsValid_AndFileUploadIsNotNull_AndFileUploadIsAnAcceptableImageContentType and need to Mock IsAcceptableImageContentType.  It's an extension method.
I've done the following:
            var formFile = new Mock<IFormFile>();
            formFile
                .Setup(x => x.IsAcceptableImageContentType())
                .Returns(true);

But when I run the test, I get the following:

Can you provide me some guidance?  How do I mock an extension method?

@tonysurma Can you assign me?  There are only 5 tests left to be completed.  They all require the ability to mock extension methods.  But in the mean time, I'm going to create a PR of what I've completed.

@mgmccarthy
I've been doing some research.  It looks like you can't use Moq to Mock an extension in general 😞.  I did find Mocking Static Methods for Unit Testing.  But that requires changing the implementation of the extension.
Should I skip these last remaining tests?  Have we encountered this issue before?

@mgmccarthy
Figured it out 😄.  Looks like what I needed to do was not to Mock IsAcceptableImageContentType directly.  A clue was provided by looking at it's implementation.
        public static bool IsAcceptableImageContentType(this IFormFile file)
        {
            var isImageContentType = false;
            var contentType = file.ContentType.ToLowerInvariant();

            if (contentType == "image/png" ||
                contentType == "image/jpeg" ||
                contentType == "image/gif")
            {
                isImageContentType = true;
            }

            return isImageContentType;
        }

What I needed to mock was ContentType.  I came up with the following:
            var formFile = new Mock<IFormFile>();
            formFile
                .Setup(x => x.ContentType)
                .Returns("image/png");

This worked.  I'm proceeding to complete the remainder of the tests now.

Renaming EditPostDoesNotInvokeDeleteImageAsyncWithTheCorrectParameters_WhenModelStateIsValid_AndFileUploadIsNotNull_AndFileUploadIsAnAcceptableImageContentType_AndThereIsAnExistingImage to
EditPostDoesNotInvokeDeleteImageAsyncWithTheCorrectParameters_WhenModelStateIsValid_AndFileUploadIsNotNull_AndFileUploadIsAnAcceptableImageContentType_AndAnExistingImageDoesNotExist.
To provide a better description of the test.

@c0g1t8

Figured it out :smile:. Looks like what I needed to do was not to Mock IsAcceptableImageContentType directly. A clue was provided by looking at it's implementation.

Nice job!


conda_ops_dev_install.sh should only download dependencies

One small thing that I noticed recently.
The current conda_ops_dev_install.sh installs and then uninstalls OPS, which is a bit redundant.
The file now looks like this
conda install -y -c omnia openpathsampling
conda update -y --all
conda uninstall -y openpathsampling
git clone https://github.com/openpathsampling/openpathsampling.git
cd openpathsampling && pip install -e . && cd ..

which could be converted to (using the --only-deps option of conda):
conda install -y -c omnia openpathsampling --only-deps
conda update -y --all
git clone https://github.com/openpathsampling/openpathsampling.git
cd openpathsampling && pip install -e . && cd ..

Actually, the best thing is to do would be to have this and our Travis installation process be similar. Installing the last release means we get the dependencies of the last release; if dependencies have changed, there may be problems with the developer install (John pointed this out when I first introduced the dev install script: https://github.com/openpathsampling/openpathsampling/pull/728#issuecomment-350567482).
The current Travis installation was based on an original setup that was more complicated than needed, and then became a mess as parts of it were jettisoned in quick fixes. We used conda-build because MDTraj did; but we're pure Python, so don't need it. But that is why everything is in a conda recipe. Then conda-build started giving troubles, so we stopped using it. Then there were performance problems with conda, causing the install process to time out on Travis, so we had to find a workaround.
Currently we extract the requirements from the conda recipe, put them into a string on the bash command line, and request installs like that. The script that we use extract from the conda yaml is devtools/install_recipe_requirements.py, only the --dry option is being used for now. This process is ugly.
Long term, I think we want to keep all the requirements in a pip-style requirements.txt, even if pip can't install some things. Eventually, we want things that aren't pip-installable to be optional installs. The main problem with that is OpenMM, and you should be able to run OPS (with the toy engine) without installing OpenMM. But that will wait for 2.0, because of the way storage handles simtk.unit. Maybe even have two files: requirements.txt and conda_requirements.txt, to make it very clear.
The pip-style files can be passed to conda as conda install --file requirements.txt. Then the dev install script would just clone the repo and run a conda command to install all the requirements. We'd also use a similar conda command to install on Travis.

@sroet: This will be fixed by #840. Please take a look at the solution over there, and let me know if you have any thoughts on it!


Is it possible to make the backup compatible with the MySql Workbench import?

Additionally, There is a problem in Excluding a table.  The table was excluded but not the trigger associated with it.
Since you already have a collection of excluded tables can't you use it to filter the triggers?
.i.e
Show Triggers Where `Table` not in ('tabmename','tablename');
As for the issue with importing the backup to Work Bench. This is the same for Procedures, Functions, Triggers and Events.
What you can do is double the delimiter before the routine name and after the END statement. Something like.
DELIMITER ;;
CREATE PROCEDURE MyProcedure()
BEGIN
END ;;

Export_WriteLine("DELIMITER " + ExportInfo.ScriptsDelimiter+ExportInfo.ScriptsDelimiter);

if (ExportInfo.ExportRoutinesWithoutDefiner)
    Export_WriteLine(trigger.CreateTriggerSQLWithoutDefiner + " " + ExportInfo.ScriptsDelimiter + ExportInfo.ScriptsDelimiter);
else
    Export_WriteLine(trigger.CreateTriggerSQL + " " + ExportInfo.ScriptsDelimiter + ExportInfo.ScriptsDelimiter);

Export_WriteLine("DELIMITER " + ExportInfo.ScriptsDelimiter);

With the above code I have successfully imported a backup without an error in Workbench Version 8.0.23 with MySql Server Version 5.7.33.

Thanks,
Dennis

Or as a temporary and faster solution. You can add the table name in your MySqlTrigger i.e.
public class MySqlTrigger
{
    string _tablename = "";
    string _name = "";
    string _createTriggerSQL = "";
    string _createTriggerSQLWithoutDefiner = "";

    public string TableName  { get { return _tablename; } }
    public string Name { get { return _name; } }
    public string CreateTriggerSQL { get { return _createTriggerSQL; } }
    public string CreateTriggerSQLWithoutDefiner { get { return _createTriggerSQLWithoutDefiner; } }

    public MySqlTrigger(MySqlCommand cmd, string triggerName, string definer, string tablename)
    {
         _name = triggerName;
         _tablename = tablename;

And in your MySqlTriggerList Class
public MySqlTriggerList(MySqlCommand cmd)
{
    _sqlShowTriggers = "SHOW TRIGGERS;";

    try
    {
        DataTable dt = QueryExpress.GetTable(cmd, _sqlShowTriggers);

        foreach (DataRow dr in dt.Rows)
        {
            _lst.Add(new MySqlTrigger(cmd, dr["Trigger"] + "", dr["Definer"] + "", dr["Table"] + ""));
        }
    }
    catch (MySqlException myEx)
    {
        if (myEx.Message.ToLower().Contains("access denied"))
            _allowAccess = false;
    }
    catch
    {
        throw;
    }
}

Then in your MySqlBackup Class
if (trigger.CreateTriggerSQL.Trim().Length == 0 ||
   trigger.CreateTriggerSQLWithoutDefiner.Trim().Length == 0 ||
   Export_ThisTableIsExcluded(trigger.TableName))
   continue;

Although I still believe passing the Excluded tables object to your MyTriggerList Class would be better, but I don't think the above approach would make a noticeable performance issue.
Thanks
Dennis

Hi, @DennisRodriguez , thanks for the information provided. I will look into this issue in few days and I'll try to come out with a solution. thanks again.


Unclosed branch-not-covered span in report when using with babel

Please use the template provided below, when reporting bugs:
Using babel messes up some branch-coverage spans in coverage report:
Expected Behavior
nyc --reporter=lcov mocha without --compilers js:babel-register

Observed Behavior
nyc --reporter=lcov mocha with --compilers js:babel-register

Bonus Points! Code (or Repository) that Reproduces Issue
repro: https://github.com/laggingreflex/nyc-branch-test
Forensic Information
node v7 npm v3 win10

ah nm, dupe #501.


Reverting the discovery job

PR Type:
Refactoring

PR Description:
This PR reverts the service discovery job and hard-codes the service discovery due to compatibility issues with ArgoCD caused by the addition of pre-install hooks. The discovery job has been removed and the discovery has been hard-coded instead. The chart and app versions have been updated to 1.15.6.

PR Main Files Walkthrough:
 files:
charts/kubescape-operator/Chart.yaml: Updated the chart and app versions to 1.15.6.
charts/kubescape-operator/templates/configs/cloudapi-configmap.yaml: Removed pre-install and pre-upgrade hooks from the configmap and hard-coded the metrics and services.
charts/kubescape-operator/templates/kollector/statefulset.yaml: Removed pre-install and pre-upgrade hooks from the statefulset.
charts/kubescape-operator/templates/kubescape/deployment.yaml: Added a new environment variable 'KS_DEFAULT_CLOUD_CONFIGMAP_NAME' to the deployment.
charts/kubescape-operator/templates/servicediscovery/job.yaml: Disabled the service discovery job.
charts/kubescape-operator/templates/servicediscovery/role.yaml: Disabled the service discovery role.
charts/kubescape-operator/templates/servicediscovery/rolebinding.yaml: Disabled the service discovery rolebinding.
charts/kubescape-operator/templates/servicediscovery/serviceaccount.yaml: Disabled the service discovery serviceaccount.
charts/kubescape-operator/values.yaml: Renamed the cloudConfig from 'ks-cloud-config' to 'url-config' and added hard-coded values for metrics and services under serviceDiscovery.

User Description:
Overview
This PR reverts the discovery job and hard-codes the service discovery. The changes were made due to compatibility issues with ArgoCD caused by the addition of pre-install hooks. The discovery job has been removed and the discovery has been hard-coded instead.

I'm reading this: https://argo-cd.readthedocs.io/en/stable/user-guide/helm/#helm-hooks
What was exactly the issue with ArgoCD?

I'm reading this: https://argo-cd.readthedocs.io/en/stable/user-guide/helm/#helm-hooks What was exactly the issue with ArgoCD?

maybe https://github.com/argoproj/argo-cd/issues/15472

As discussed with @dwertent , I have removed the service discovery so that we don't have stale garbage in our chart.
If we need that logic we can take it from git for a better solution.

We will not need this PR once this is merged: https://github.com/kubescape/helm-charts/pull/297


[request] Orthography profile review

Please review the orthography profile in etc/orthography.tsv

@tresoldi ?

On it.


Libft should give a timeout after 10 seconds

For the libft, I found in the hard way :( that Moulinette will give a timeout if the following takes more than 10 seconds to finish this:
make clean && make && make fclean && make && make re && ls -l libft.a
This means that even though, everything is correct, if you add a lot of extra functions (in my case, about 35), it will time out and give you a zero, no matter what.

Please send us your makefile And we'll take a look at it

Sure, here it's. This one is without the 35 extra functions.

clean:
		@rm -f $(OBJS)
		@echo "[INFO] Objects removed!"

fclean: clean
		@rm -f $(NAME)
		@echo "[INFO] Library [$(NAME)] removed!"

re:		fclean all

Sadly, We can't do anything about this on the school's side. The moulinette is kept up and running and updated by the Dev Team at the school. You should contact the peda to talk about it.
I think a way to have it pass would be to have like 5 extra functions, validate your project and then add the 30 functions to your lib afterwards.
By doing this you would significantly reduce the time that takes the make command to compile all your data.
On 42FC though, i'll add an issue tagged with enhancement to get something done about it like if extra func > 10 : timeout = 60 seconds.
PS : You should put your .PHONY at the end of the Makefile
Have a nice day ! 😄

@jraleman Thank you for having noticed this issue. My colleagues and I also have experienced this issue, even if our Makefiles did compile in less than 10 seconds.
Unfortunately, the fact is that we cannot reproduce the technical conditions of the moulinette that makes our Makefiles to exceed the timeout of 10 seconds. Because it is remotely executed on 42's servers and because of conditions that differs on date and time depending on the server availabality.


Remove whitespace in logging

Task name: AzurePowerShell@v5, AzurePowerShell@v4
Description: Removed the spaces at the beginning of command messages. These specific messages were not in line with the rest of the similar messages:
Documentation changes required: N
Added unit tests: N
Attached related issue: N
Checklist:

[x] Task version was bumped
[x] Checked that applied changes work as expected

@microsoft-github-policy-service agree

@celloza Can you please update the task version. Please check instruction to understand how to do it.

Set task versions to:
"version": {
    "Major": 1,
    "Minor": 236,
    "Patch": 0
  }

given that change happened after Tuesday of week 3 of sprint 235.

/azp run

Misunderstood versioning... fixed it now.

/azp run

/azp run

/azp run

Ran the build tasks on v4 and v5 which modified the task versions again.

@mmrazik / @v-gayatrij the documentation states that the version numbers should be 4.236.0 and 5.236.0 respectively in this case, but when running npm build for these tasks they're changed to 4.235.0 and 5.235.
Which should it be?

Updated to 4.236.0 and 5.236.0 respectively.

/azp run

/azp run

Hi @celloza , could you please build both the tasks using "node make.js build --task " cmd and commit changes to this branch

node make.js build --task AzurePowerShellV4

> prepending PATH /workspaces/azure-pipelines-tasks/node_modules/.bin
tsc tool:
Version 4.0.2
/workspaces/azure-pipelines-tasks/node_modules/.bin/tsc
npm tool:
6.14.12
/home/codespace/.volta/tools/image/node/10.24.1/bin/npm
...
Build successful

and
node make.js build --task AzurePowerShellV5

> prepending PATH /workspaces/azure-pipelines-tasks/node_modules/.bin
tsc tool:
Version 4.0.2
/workspaces/azure-pipelines-tasks/node_modules/.bin/tsc
npm tool:
6.14.12
/home/codespace/.volta/tools/image/node/10.24.1/bin/npm
...
Build successful.

but,
git status
On branch patch-1
Your branch is up to date with 'origin/patch-1'.

nothing to commit, working tree clean

Abandoning to do new PR.


libcbor: 0.8.0 -> 0.9.0, libfido2: 1.9.0 -> 1.10.0

Motivation for this change
#149317
https://github.com/Yubico/libfido2/blob/1.10.0/NEWS
Combining updates to avoid rebuilding everything that depends on
libfido2 twice.
Also, since libfido2 is only in-tree user of libcbor
(and uses 0.9.0 with this release)
this makes more sense than it might otherwise :).
Still rebuilding locally.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

cc #152743 (although don't know that this will impact the findings there so far).


python312Packages.pyhanko: 0.25.1 -> 0.25.3

Diff: https://github.com/MatthiasValvekens/pyHanko/compare/refs/tags/v0.25.1...v0.25.3
Changelog: https://github.com/MatthiasValvekens/pyHanko/blob/v0.25.3/docs/changelog.rst

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 357713

x86_64-linux

:x: 2 packages failed to build:

sasview
sasview.dist

:white_check_mark: 20 packages built:

maigret
maigret.dist
open-webui
open-webui.dist
python311Packages.certomancer
python311Packages.certomancer.dist
python311Packages.pyhanko
python311Packages.pyhanko-certvalidator
python311Packages.pyhanko-certvalidator.dist
python311Packages.pyhanko.dist
python311Packages.xhtml2pdf
python311Packages.xhtml2pdf.dist
python312Packages.certomancer
python312Packages.certomancer.dist
python312Packages.pyhanko
python312Packages.pyhanko-certvalidator
python312Packages.pyhanko-certvalidator.dist
python312Packages.pyhanko.dist
python312Packages.xhtml2pdf
python312Packages.xhtml2pdf.dist


Unused variables and imports are not highlighted

Does this issue occur when all extensions are disabled?: Yes

Issue Type: Bug
Intellisense shows suggestions but doesn't hightlight unused variables and imports. Problem occurred in .js, .ts and .tsx files.
VS Code version: Code - Insiders 1.61.0-insider (71ca6e8e74591ae5c577d52a2aa1bd0c3df5ac32, 2021-10-05T01:25:37.698Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-9300H CPU @ 2.40GHz (8 x 2400)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.84GB (1.11GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (29)

Extension
Author (truncated)
Version

better-comments
aar
2.1.0

project-manager
ale
12.4.0

color-info
bie
0.7.0

path-intellisense
chr
2.4.0

vscode-markdownlint
Dav
0.44.4

vscode-eslint
dba
2.1.25

es7-react-js-snippets
dsz
3.1.1

EditorConfig
Edi
0.16.4

prettier-vscode
esb
9.0.0

auto-rename-tag
for
0.1.8

vscode-graphql
Gra
0.3.18

wordcounter
kir
2.3.0

contextualduplicate
laf
0.2.0

vscode-language-babel
mgm
0.0.35

dotenv
mik
1.0.1

python
ms-
2021.9.1246542782

jupyter-renderers
ms-
1.0.3

vscode-versionlens
pfl
1.0.9

material-icon-theme
PKi
4.10.0

multi-command
ryu
1.5.1

code-settings-sync
Sha
3.4.3

stylelint
shi
0.51.0

vscode-fileutils
sle
3.4.5

code-spell-checker
str
2.0.8

code-spell-checker-czech
str
0.1.9

sass-indented
syl
1.8.18

vscode-icons
vsc
11.6.0

dictionary-completion
yzh
1.1.0

material-theme
zhu
3.13.1

File no.1:
export const two = () => 'Hello'

File no.2:
export const three = () => 'Three'

File no.3:
import { two } from './two' // Unused import
import { three } from './three' // Unused import

const foo = 'Foo' // Unused variable
const bar = 'bar' // Unused variable

Screen - missing highlights for unused code in .tsx file:

Thanks. What is the language mode of the tsx file? Do other TypeScript features work in it?

The language mode is originally typescriptreact. I've changed it to JavaScript (Babel). Other features, such as Intellisense suggestions for example, work.


After launching the wallet, the icon changes from Dappnet to BeamX

Linux,MacOS
BEAM Build number: 7.1.12823.5364.

https://user-images.githubusercontent.com/45556620/173809228-4687eaa5-ebd3-4f8c-b358-974e96f04046.mp4

checked


Add an algorithm for ~dissolve with a tolerance

A function similar to the non-orthogonal version of "Aggregate Polygons (Cartography)".

Has been added in geofileops


Tax rates on customer portal

Hi guys
can you help me with tax rates. So when the customer pays first i can pass the tax_rates property for checkout-session, but when would change the subscription plan cant see the tax_rates and after the change didnt get the tax_rates information in response json. Do you have any idea how can i solve this? Of course the tax wont be on the invoice too.
Thx for help.

@dancixx sorry, this one slipped through the cracks.
In the customer portal currently only "static" tax rates are supported that you specified during the checkout session creation: https://github.com/stripe/stripe-firebase-extensions/blob/next/firestore-stripe-subscriptions/POSTINSTALL.md#applying-static-tax-rates
In Stripe checkout it will look like this:

And in the customer portal like this:

It works as long as you've specified the tax_rates on the initial checkout session creation, e.g.
const docRef = await db
  .collection('${param:CUSTOMERS_COLLECTION}')
  .doc(currentUser)
  .collection('checkout_sessions')
  .add({
    price: 'price_1GqIC8HYgolSBA35zoTTN2Zl',
    tax_rates: ['txr_1HCjzTHYgolSBA35m0e1tJN5'],
    success_url: window.location.origin,
    cancel_url: window.location.origin,
  });

Does this work with createPortalLink method too?

@dancixx no, you don't specify this when creating the portal link. The tax rate is stored on the subscription and the portal reads it from there.

@thorsten-stripe It is interesting, because I can see the tax data on firestore subs doc but on customer portal on subs update no tax data. :(

Can you provide some screenshots please?

@thorsten-stripe
First is the existing subs in firestore there is the tax_rates data

Second: on customer portal on subs update there is no tax data, just can see 'adót nem tartalmaz' (sry for lang)

Thrid: on checkout session you can see the VAT correctly.

These are my callbacks for methods:
export function checkoutSession({ firebase, firestore }, priceId, teamId, tierLevel, product, user) {
    return async function () {
        console.log({product})
        try {
            const docRef = await firestore
                .collection('profiles')
                .doc(user.uid)
                .collection('checkout_sessions')
                .add({
                    billing_address_collection: 'required',
                    price: priceId,
                    tax_rates: ['txr_1HxioRABw9RvoAv3vLypvhDB'],
                    success_url: window.location.origin + '/success',
                    cancel_url: window.location.origin,
                    allow_promotion_codes: true,
                    default_tax_rates: ['txr_1HxioRABw9RvoAv3vLypvhDB'],
                    metadata: {
                        userUid: user.uid,
                        teamUid: teamId,
                        tierLevel: tierLevel,
                        productId: product.id,
                        stripe_metadata_subsUid: product.stripe_metadata_subsUid,
                        stripe_metadata_team: product.stripe_metadata_team,
                        stripe_metadata_tierLevel: product.stripe_metadata_tierLevel
                    }
                });

            docRef.onSnapshot(async (snap) => {
                const { error, sessionId } = snap.data();
                if (error) {
                    alert(`An error occured: ${error.message}`);
                }
                if (sessionId) {
                    const stripe = await loadStripe('pk_test_51HxiKAABw9RvoAv3LwjXhz3XDTJ3zCzcN3rLhkaOQyHOpjmOU1jsgnwcVa8xsHWOrr2HfFL4ZjUN71oHukcK0k6U00lt6OEdg8');
                    stripe.redirectToCheckout({ sessionId });
                }
            });
        } catch (error) {
            console.log(error);
        }
    };
}

export function createPortalLink() {
    return async function () {
        try {
            const functionRef = fb.app().functions('us-central1').httpsCallable('ext-firestore-stripe-subscriptions-createPortalLink');
            const { data } = await functionRef({ returnUrl: window.location.origin });
            console.log({ data });
            window.location.assign(data.url);
        } catch (error) {
            console.log(error);
        }
    };
}

@thorsten-stripe can see some issue there?

@dancixx sorry for the delay here :( This is an issue with how Stripe invoices handle proration for invoice items. I've added a workaround here that should hopefully work for you: https://github.com/stripe/stripe-firebase-extensions/pull/170

@thorsten-stripe I updated the new version, and I watched the changelog but I didnt find which point should I use or should I change anything, if not then is there no changes in my case.

@dancixx correct, this was an internal change only: https://github.com/stripe/stripe-firebase-extensions/pull/170/files#diff-70e8f3204cac2da7d57e95d6985978367a24a4f399fdd4099d1a9fbe3f724b21R154-R160
So for new subscriptions your code above should work, the important step is setting the top-level tax_rates param (example: ), which you are doing.
You can see this in action in the demo: https://stripe-subs-ext.web.app
On the invoice you will then see the tax that was applied:

@thorsten-stripe thank you very much it worked.
I have only one more question, when I set the properties for the checkout session for subscription mode, should set the "mode" params set, or only when I use "payment" mode, and this is the same with the tax_rates, I think it works with default_tax_rates too. So my concept can be seen below, is it correct?
const docRef = await firestore
                .collection('profiles')
                .doc(user.uid)
                .collection('checkout_sessions')
                .add({
                    billing_address_collection: 'required',
                    price: priceId,
                    tax_rates: ['txr_1HxioRABw9RvoAv3vLypvhDB'],
                    success_url: window.location.origin + '/success',
                    cancel_url: window.location.origin,
                    allow_promotion_codes: true,
                    metadata: {
                        userUid: user.uid,
                        teamUid: teamId,
                        tierLevel: tierLevel,
                        productId: product.id,
                        stripe_metadata_subsUid: product.stripe_metadata_subsUid,
                        stripe_metadata_team: product.stripe_metadata_team,
                        stripe_metadata_tierLevel: product.stripe_metadata_tierLevel
                    }
                });

@dancixx mode defaults to subscription only if you want to do one-time payments you have to specify mode: payment.  But you can also supply mode: subscription it's just not required.
tax_rates needs to be tax_rates and is then mapped to default_ tax_rates by the extension.


refactor: Move features to their own namespace

:tada: This PR is included in version 2.0.0-next.43 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


MaxRetryException thrown from RequestHandlerAsync is not catchable

RetryRequestAsync calls ThrowMaxRetryExceptionWhenNeeded, but returns a Task.  If you try to await this method, the exception is not catchable because it is thrown rather than set on the Task.

@entroper ty for reporting this and sending 2 PR's. Sorry for not looking into this sooner.
We had several tests for async and MaxRetryExceptions.
I tried to capture the behaviour in a more explicit tests (no assert library syntax), see the attached commit, but I am unable to reproduce the behaviour you are seeing.
Can you provide a bit more information on how you are calling and catching RetryRequestAsync.

Closing this because I need some more information to reproduce this:
See also: https://github.com/elastic/elasticsearch-net/commit/755acae6749fcd51dae64cf866e5f92ba5731d6b


Add the "I want to help button"

Just add this button with no functionality for now. Style it to match the Figma design,

hi @jaygabe I want to contribute to your project and would love to solve this issue. can you please assign me this issue?
thank you


nuxt.config : app > head > titleTemplate doesn't work with a function.

Environment

Operating System: Darwin
Node Version:     v18.13.0
Nuxt Version:     3.4.3
Nitro Version:    2.3.3
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      app, runtimeConfig, css, modules, components, vite, devtools
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-mtzzdy?file=app.vue
Describe the bug
The nuxt.config has a titleTemplate that can be set as a function. But the function doesn't work.
We are trying to have the SiteName when there is an empty title and the Title | SiteName when the title exists.
We are using the <Title> component.
<Head>
  <Title> My title </Title>
</Head>

export default defineNuxtConfig({
  app: {
    head: {
      titleTemplate: (titleChunk) => {
        return titleChunk ? `${titleChunk} | Site Name` : 'Site Name';
      },
    },
  },
});

It doesn't work. It just shows the title.
Additional context
No response
Logs
No response

You can instead use titleTemplate as a function within app.vue or set it as a string in nuxt.config. (You can't set it as a function in nuxt.config because this can't be serialised and passed into the build.)
We should update the types for this to disallow functional use, or warn if functions are passed within app.head - wdyt @harlan-zw?

Agreed!
Also, you can use templateParams to achieve the same result without needing a function. The %separator will be omitted when the page title is empty.
export default defineNuxtConfig({
  app: {
    head: {
      titleTemplate: `%s %separator %siteName`,
      templateParams: {
        siteName: 'Site Name',
        separator: '|',
      },
    },
  },
});

See https://stackblitz.com/edit/github-mtzzdy-vgkx5b?file=nuxt.config.ts

Thank you both!
I didn't know about the templateParams property. I cannot find any documentation about it.
I tried and it works like a charm. 💯


Find/remove unused imports

Hi @Mastersam07 ,
This is still yeah? I want to work on it..

Hi @Mastersam07,
After carefully going through the entire application, I didn't find any unused imports in all the files in the src directory.

Hi @Michael-Ogundipe
I believe you have it all wrong. Finding and removing unused import is a feature request. A command to be added to pub studio.


Update to use allow list rather than whitelist

Consider using allow list rather than a whitelist.

However, there's an issue with the terminology. It only makes sense if you equate white with 'good, permitted, safe' and black with 'bad, dangerous, forbidden'. There are some obvious problems with this.

Further reading: https://www.ncsc.gov.uk/blog-post/terminology-its-not-black-and-white

Thank you!


How to change currency?

I don't want to change language, but use € instead of $. number(1234).format('€0,0.00') just returns "1,234.00", ignoring the currency symbol. I've looked through the docs and the exisitng issues, but couldn't find any way to just change the currency symbol.

Any news ? I installed the module, but Just the dolar symbol seems to be working

Yes the dollar sign is what tells the format it is a currency that works in the format string.  to change the symbol the locale needs to be changed

@genne Did you find a way to  expressing €10 and $10 at the same page?

@eduardoalba the only way for me was to exclude the currency from the expression and prepend it manually after formatting it. I.e.
let format = "0,0[.]00";
let isNegative = value < 0;
if (isNegative) {
    value = -value;
}
let numberString = currencySymbol + numeral(value).format(format);
if (isNegative) {
    numberString = "-" + numberString;
}

I think this is an issue with the version 2.0.6 as well. This might help:
numeral.localeData().currency.symbol = '€'


Shipping charge remains unchanged after selecting different shipping method on checkout

Current behavior

I hv activated two shipping method in magento, in vsf it display the two shipping methods correctly. However when selecting the non-default one, the shipping cost above the total does not change.
When proceed to payment it selected the default shipping method again.
** I tried to add '.native ' at line 88 shipping.vue
(@change="$v.shipping.shippingMethod.$touch();)
like how you guys fixed shipping country bug, but no luck.
Expected behavior

Shipping charge changes upon shipping method selection
Steps to reproduce the issue

Repository

Can you handle fixing this bug by yourself?

[ ] YES
[ ] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser:
OS:
Node:
Code Version:

Additional information

Thanks for pointing this out! Please select on which version have You got this issue: demo/next/test?

I am debugging base on 1.8.3, with magento 2.3.0.
I checked by console.log the 'currentShippingMethod' variable in vsf/core/modules/checkout/components/shipping.ts,  the shipping method is not changed by the @change function by selection (changeShippingMethod triggered from theme/compoents/core/blocks/Checkout/Shipping.vue), it still showing the default selected shipping method.

Could you Please check 1.8.5 and 1.9.0? There were fixed around shoppingu methods i guess

Hello,
Sorry I found out I have forgotten to add the method to local.json in vue-storefront/config.
I did update my code upon to the newest version.
Sorry for the trouble!
Thanks a lot!

something to add before I close this issue.
I found out the bug due to vuetique theme, shipping.vue
i changed the radio button code to default theme's one and it works again.

Thanks! Could you please create an issue in the https://github.com/AbsoluteWebServices/vuetique-theme? Thanks a lot!

Sure sure!


NetworkPolicy check not implemented?

In https://github.com/Shopify/kubeaudit#audit-network-policies is the following describe:
It checks that every namespace should have a default deny network policy installed.
See Kubernetes Network Policies for more information:

But actually the code https://github.com/Shopify/kubeaudit/blob/master/cmd/networkPolicies.go only iterates over existing networkPolicies and doesn't check if the default-deny policy is set. Also currently only the default allow all policy is checked (which leads to an warning).

Thank you for the PR @johscheuer, exactly what I was looking for 😍

@johscheuer can we close this issue now? @TheKangaroo it should be in v0.4.x now


Hiding the become partner button when no more loan is needed (frontend)

We need to disable/hide the "Become a Partner" button once loans are no longer needed. Similarly we need to hide the "Pay Rent" button when we are still collecting rent.

[ ] Add tasks with mark down.

Once the load is granted in full the become a partner button is replaced with the pay rend button.


Issues with node example

Hi, that project looks really amazing, i'm testing the integration with NodeJS, and, im trying to run the example of node, when i'm doing the steps refer in docs of repo, i have an issues, see:
Step 1. Clone the repo:

Step 2. Move to examples-node directory and install dependences:

Step 3. Run "faceDetection.js" with ts-node:

What is the best solution for that error? Yesterday im trying improve that, like fix imports error, but nothing work for me, sorry if the question is too dumb, but i'm doing the steps of the repo and idk what happens

I have the exact same problem.

I have the exact same problem.

Try run this command.
npm i<EMAIL_ADDRESS>


VMatrix struct

matrix should be abstracted a bit more into a new struct with some helper methods.
Should hold max_insert logic to help address #2.

increment to += 1 at coords
insert takes VEntry and +=1 at location
construct should handle the dimension logic (need to think about best implementation, take regions path? args? etc.)

Maybe also things like:

insert_midpoint
insert_start
insert_fragment

To increase the range of matrices you can generate.


Empty black box on iOS

Hey @EddyVerbruggen,
I tried out this plugin today and it works great on Android, but on iOS I’m unfortunately not seeing a map—all I see is a black box.

I’ve tried your demo and my own custom app and I get the same. Any idea what might be up here? The logs tell me that I have permissions and mapbox.show doesn’t log any errors, so I’m not sure what’s up.
Thanks.

Oh, one completely unrelated note: this code on the docs:
mapbox.hasFineLocationPermission().then(
    function(granted) {
      // if this is 'false' you probably want to call 'requestFineLocationPermission' now
      console.log("Has Location Permission? " + result);
    }
);

result is not defined here. I’m guessing you meant to use granted in the console.log() call.

Hey TJ, thanks for the report. It was a bit buried by all other stuff in my mailbox, but I just stumbled on it again and took a moment to fix it.
Turned out the Mapbox guys changed the location of the resource files a bit, so the plugin could no longer load the map. That's what you get when you don't pin to a specific SDK version. The plugin now pins to a version it is known to work well with (should have done that in the first place).
The doc is also fixed, thanks for noticing that!

No worries, I can only imagine what your GitHub notification situation is like 😛
Thanks for the fix! 👍


Regression in .indexes command

Running .indexes t should print table not found if table t does not exist.
--- FAIL: TestRunTablesCmd (0.00s)
    --- FAIL: TestRunTablesCmd/Table_with_options (0.00s)
        command_test.go:38:
            	Error Trace:	command_test.go:38
            	Error:      	An error is expected but got nil.
            	Test:       	TestRunTablesCmd/Table_with_options
            	Messages:   	%!(EXTRA bool=true)

See also: #232

Good catch, I am going to correct it.


Dev: remove self-closing HTML tags in helpers

The W3C validator displays a warning for : Self-closing tag syntax in text/html documents is widely discouraged.

See

https://github.com/codeigniter4/CodeIgniter4/issues/6602#issuecomment-1268432153
https://forum.codeigniter.com/showthread.php?tid=83552

I made the changes in form_helper.php, not sure how to commit the changes or does the branch on the right hand side have the commit included? Sorry, newbie.....

The spec has changed. Now, "void" or "self-closing" elements should not include the slash, when served as HTML 5 doctype. However, if it is being served as XHTML, the closing slash may be required (check the docs in this case). In practical use, pages will usually display as expected even if the closing / has been included, but this is not gauranteed (it is dependent on the browser effectively re-writing the code for you, and interpreting it as you intended.) Also, if for some reason your page is required to pass HTML 5 validation, it might not pass if you close tags for void elements.

https://stackoverflow.com/questions/3558119/are-non-void-self-closing-tags-valid-in-html5

Closed by #6789


fix(docs): Update Encoding Object example

closes https://github.com/OAI/OpenAPI-Specification/issues/3170

Thanks for the fix, @jeremyfiel.
Unfortunately, we can't modify files that have already been published and can only modify minor versions.
It looks like we don't have a 3.0.4 branch but I can create one if you want.

Hi Ron,
This is not a patch update, only a docs issue to explain the example
correctly. I don't believe that would require anew version, would it?
On Fri, Feb 24, 2023, 15:16 Ron @.***> wrote:

Thanks for the fix, @jeremyfiel https://github.com/jeremyfiel.
Unfortunately, we can't modify files that have already been published and
can only modify minor versions.
It looks like we don't have a 3.0.4 branch but I can create one if you
want.
—
Reply to this email directly, view it on GitHub
https://github.com/OAI/OpenAPI-Specification/pull/3171#issuecomment-1444403391,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHU7MTPT6HUEWQPRT5MMQ3DWZEJKPANCNFSM6AAAAAAVHJA5A4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Unfortunately, it would. Anything under the versions directory cannot be updated once published, we can only add new versions.

are there any other errata in the works?

I don't see anything for 3.0 (there is for 3.1), but happy to start one if needed.

since it was updated in 3.1.x.  I guess there's no burning reason to create a new patch version. There is no behavior change.

I have a couple of proposals for a quick 3.0.4.  @webron unless you'd rather I did not, I will tag the issue for this PR with the 3.0.4 label and also the other clarifications/bugfixes I've noticed recently.

I don't see a technical reason not to release 3.0.4. We'll potentially retire 3.0.X after the next minor/major version is released.

@jeremyfiel there's now a v3.0.4-dev branch with a versions/3.0.4.md file.  This PR has been re-targeted to that branch which is why it shows a bunch of extra commits (those are the post-3.0.3 commits on main, which are not relevant to 3.0.4.md).
You'll want to either close this and open a new PR, or edit the commit to only apply to 3.0.4.md, rebase it on top of the v3.0.4-dev branch, and force-push.

ok. probably easier and cleaner to close and make a new one. will do so
On Wed, Mar 1, 2023 at 12:19 PM Henry Andrews @.***>
wrote:

@jeremyfiel https://github.com/jeremyfiel there's now a v3.0.4-dev
branch with a versions/3.0.4.md file. This PR has been re-targeted to
that branch which is why it shows a bunch of extra commits (those are the
post-3.0.3 commits on main, which are not relevant to 3.0.4.md).
You'll want to either close this and open a new PR, or edit the commit to
only apply to 3.0.4.md, rebase it on top of the v3.0.4-dev branch, and
force-push.
—
Reply to this email directly, view it on GitHub
https://github.com/OAI/OpenAPI-Specification/pull/3171#issuecomment-1450531063,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHU7MTMHVUCPJX6RI5NZLX3WZ6ALFANCNFSM6AAAAAAVHJA5A4
.
You are receiving this because you were mentioned.Message ID:
@.***>


Ollama (llama2) running in VM Box on Ubuntu but /api/generate not working

Hey, i pulled llama2 as described and im running it with 'ollama run llama2'
It is working inside the terminal with no errors, but as soon as i try to to reach it via
curl http://localhost:11434/api/generate -d '{   "model": "llama2",   "prompt":"Why is the sky blue?" }'
it just says:
{"error":"model "llama2" not found, try pulling it first"}

Hi, i have the same issue. Can i ask how you solved it?


python37Packages.smart_open: 3.0.0 -> 4.0.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.smart_open is: "smart_open is a Python 2 & Python 3 library for efficient streaming of very large file"
meta.homepage for python37Packages.smart_open is: ""
meta.changelog for python37Packages.smart_open is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 4.0.0 with grep in /nix/store/fpw2vpjaifsnwn0yifn0sqhnx13nryvv-python3.7-smart_open-4.0.0

directory tree listing: https://gist.github.com/071ba0816a5239171d6de7127c928248

du listing: https://gist.github.com/46335b965d1c5d1efea5f922c5c81e96

Rebuild report (if merged into master) (click to expand)

16 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python37Packages.gensim
python37Packages.smart_open
python38Packages.gensim
python38Packages.smart_open

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/fpw2vpjaifsnwn0yifn0sqhnx13nryvv-python3.7-smart_open-4.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python37Packages.smart_open https://github.com/r-ryantm/nixpkgs/archive/0ce40561e0c5cc928b4659004a3facc4844a7e67.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/fpw2vpjaifsnwn0yifn0sqhnx13nryvv-python3.7-smart_open-4.0.0
ls -la /nix/store/fpw2vpjaifsnwn0yifn0sqhnx13nryvv-python3.7-smart_open-4.0.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

4 packages built:

python37Packages.gensim
python37Packages.smart_open
python38Packages.gensim
python38Packages.smart_open

Maintainer pings
cc @jyp for testing.

Result of nixpkgs-review pr 104901 run on x86_64-darwin 1

4 packages built:

python37Packages.gensim
python37Packages.smart_open
python38Packages.gensim
python38Packages.smart_open


Atlas for the analysis

In Ciric 2017 they used 164 Power and 333 Gordon as the main atlases.
At some point we will need to decide what to use.

not availible in nilearn: Gordon, FIND, brainnetome, Glasser (possibly not applicable)
not clear: ICA (I would assume it's Smith 2009, but there's also Allen 2011)
done: Craddock, difumo, BASC, Schaeffer

After dealing with nilearn atlas fetcher and try to harmonise them, I think the most sensible thing to do is probably curate the atlases ourselves, and then add to the workflow.
In the future if TemplateFlow supports atlas that would be a good way.
For now I feel the quickest way to move things forward is prepare the collection of atlas for this project manually....

Good place to get atlases: https://github.com/rmarkello/neuromaps
For OHBM, it might be worth it to check the hard parcels only.

It might worth start a separated project for curating the atlas we will be using.
We will break down certain atlas (such as difumo) in to discrete regions and calculate the centroids (c.f. #14 )

I have started a summary here: https://docs.google.com/spreadsheets/d/1_95MCxMz8HgbhLzKUv0yxnukFlIWeFwZLJq5xoysark/edit?usp=sharing
Let's finalise things here.

Final decision:

schaefer 7 network all resolutions
mist all resolutions
segmented difumo all resolutions
gordon 333


Lambda functions using deprecated nodejs4.3

I have a client with this deployed in production and they are receiving warning notices that the lambda calls are using nodejs4.3 which is now deprecated. Can the scripts be updated to 8.10?
Both the backup and restore templates contain nodejs4.3 references.

Thanks for bringing this to our attention. We are looking into it.

Dear all,
we also have a client using the efs-backup in production. It would be appreciated a lot if it can be fixed soon, since the official notification tells us, that "the ability to create new Lambda functions configured to use the Node.js v4.3 runtime will be disabled on July 31, 2018".
Is there any chance, that a fix will be available within the next two weeks?

Thanks @gsingh04. We briefly tested it on staging  and it looks good so far.


How can I put logstash-output-zabbix into this assembly. To transfer logs not only to elasticsearch, but also zabbix ?

Problem description
Hello again. How can I put logstash-output-zabbix into this assembly. To transfer logs not only to elasticsearch, but also zabbix ?
Extra information
Stack configuration

Docker setup

$ docker version

Client:
 Version:           20.10.7
 API version:       1.41
 Go version:        go1.13.8
 Git commit:        20.10.7-0ubuntu1~20.04.1
 Built:             Wed Aug  4 22:52:25 2021
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true

Server:
 Engine:
  Version:          20.10.7
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.13.8
  Git commit:       20.10.7-0ubuntu1~20.04.1
  Built:            Wed Aug  4 19:07:47 2021
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.5.2-0ubuntu1~20.04.2
  GitCommit:
 runc:
  Version:          1.0.0~rc95-0ubuntu1~20.04.2
  GitCommit:
 docker-init:
  Version:          0.19.0
  GitCommit:

$ docker-compose version

docker-compose version 1.29.2, build 5becea4c
docker-py version: 5.0.0
CPython version: 3.7.10
OpenSSL version: OpenSSL 1.1.0l  10 Sep 2019

Container logs

$ docker-compose logs

[OUTPUT HERE]

@sasha198407 the zabbix output is built-in, so you only need to configure it inside your pipeline according to the docs: https://www.elastic.co/guide/en/logstash/current/plugins-outputs-zabbix.html

Here's what shows
logstash-plugin list --group output
Using bundled JDK: /usr/share/logstash/jdk
OpenJDK 64-Bit Server VM warning: Option UseConcMarkSweepGC was deprecated in version 9.0 and will likely be removed in a future release.
/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/bundler-1.17.3/lib/bundler/rubygems_integration.rb:200: warning: constant Gem::ConfigMap is deprecated
logstash-output-cloudwatch
logstash-output-csv
logstash-output-elasticsearch
logstash-output-email
logstash-output-file
logstash-output-graphite
logstash-output-http
logstash-output-lumberjack
logstash-output-nagios
logstash-output-null
logstash-output-pipe
logstash-output-redis
logstash-output-s3
logstash-output-sns
logstash-output-sqs
logstash-output-stdout
logstash-output-tcp
logstash-output-udp
logstash-output-webhdfs

Or shouldn't he be here?

Oh, you're right, sorry!
You also need to add the following directive to your Logstash Dockerfile, right below those lines:
https://github.com/deviantony/docker-elk/blob/5103d468597306d6caa70b6b779c806a26882738/logstash/Dockerfile#L6-L7
RUN bin/logstash-plugin install logstash-output-zabbix

Thanks. I'm going to try now. Another question. If I understand correctly, this assembly does not include Elastalert. Where can I see how to add it here?

Installed
Using bundled JDK: /usr/share/logstash/jdk
OpenJDK 64-Bit Server VM warning: Option UseConcMarkSweepGC was deprecated in version 9.0 and will likely be removed in a future release.
Validating logstash-output-zabbix
Installing logstash-output-zabbix
/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/bundler-1.17.3/lib/bundler/rubygems_integration.rb:200: warning: constant Gem::ConfigMap is deprecated
Installation successful

Glad to see you figured out the installation 👍
Regarding Elastalert, I'm not familiar with the configuration it takes to make it work, but I see a reference to a Docker image in their docs at https://github.com/Yelp/elastalert#docker. I'm sure you can use that image and add a new service to the docker-compose.yml file with the parameters mentioned in the docs.
Beware though, the Elastalert project is unmaintained. You might be better off using the alerting mechanism that is built into Kibana instead: https://www.elastic.co/what-is/kibana-alerting.

Do I understand correctly that this mechanism is paid?

This page lists basic alerts as a free Kibana feature: https://www.elastic.co/subscriptions

@sasha198407 in case the original issue is solved (installation of the zabbix output), feel free to close.


Check health & ready: move to flags

This makes it more consistent with other command like import rules. We don't have stricts rules and uniformity accross promtool unfortunately, but I think it's better to only have the http config on relevant check commands to avoid thinking Prometheus can e.g. check the config over the wire.

cc @tjhop

cc @tjhop

I'm fine with the reasoning 👍


Add missing space into the log message

Hi @utix, thanks for the PR.
Please resolve the conflict. This is apparently caused by your previous PR.

Conflict solved


Update aiohttp dependency

What is this PR for?

Update aiohttp and async-timeout dependency
aiohttp 3.7 has https://github.com/aio-libs/aiohttp/issues/4818 exploit
Changes were tested with all jsonld based flows

Codecov Report

Merging #1606 (03cca99) into main (308161f) will decrease coverage by 0.03%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##             main    #1606      +/-   ##
==========================================
- Coverage   95.74%   95.71%   -0.04%
==========================================
  Files         528      528
  Lines       32515    32590      +75
==========================================
+ Hits        31133    31194      +61
- Misses       1382     1396      +14


Exception when I start to write some docstrings.

Hi, I'm using Atom with the linter-flake8 package and I'm getting this exception from pep8:
Error: Traceback (most recent call last):
    File "/usr/local/bin/flake8", line 11, in sys.exit(main())
    File "/usr/local/lib/python3.5/dist-packages/flake8/main.py", line 33, in main report = flake8_style.check_files()
    File "/usr/local/lib/python3.5/dist-packages/pep8.py", line 1672, in check_files runner(path)
    File "/usr/local/lib/python3.5/dist-packages/flake8/engine.py", line 95, in input_file return fchecker.check_all(expected=expected, line_offset=line_offset)
    File "/usr/local/lib/python3.5/dist-packages/pep8.py", line 1456, in check_all self.check_logical()
    File "/usr/local/lib/python3.5/dist-packages/pep8.py", line 1328, in check_logical (start_row, start_col) = mapping[0][1]
TypeError: 'NoneType' object is not subscriptable

This happens sometimes when I start writing a docstring such as:
def f():
    """

If you need more information just ask. (I was unsure what to include.)
Thanks.

What version of flake8 are you using?

2.4.1 (pep8: 1.5.7, pyflakes: 0.8.1, mccabe: 0.3.1) CPython 3.5.0+ on Linux

Looking at stacktrace, I had the same problem (or just very, very similar) on file like this:
$ cat pep8_error.py
class A(object):
    """
    """
        """

But upgrade of pep8 from 1.5.7 to 1.6.2 solved this problem:
$ pep8 --version
1.5.7
$ pep8 pep8_error.py
Traceback (most recent call last):
  File "/usr/local/bin/pep8", line 11, in <module>
    sys.exit(_main())
  File "/usr/local/lib/python2.7/site-packages/pep8.py", line 1929, in _main
    report = pep8style.check_files()
  File "/usr/local/lib/python2.7/site-packages/pep8.py", line 1672, in check_files
    runner(path)
  File "/usr/local/lib/python2.7/site-packages/pep8.py", line 1684, in input_file
    return fchecker.check_all(expected=expected, line_offset=line_offset)
  File "/usr/local/lib/python2.7/site-packages/pep8.py", line 1456, in check_all
    self.check_logical()
  File "/usr/local/lib/python2.7/site-packages/pep8.py", line 1328, in check_logical
    (start_row, start_col) = mapping[0][1]
TypeError: 'NoneType' object has no attribute '__getitem__'
$ // upgrading pep8
$ pep8 --version
1.6.2
$ pep8 pep8_error.py
pep8_error.py:4:9: E901 TokenError: EOF in multi-line string

Except this was on Mac OS X, Python 2.7.10

Same problem here, with more up-to-date version:
2.5.1 (pep8: 1.5.7, pyflakes: 1.0.0, mccabe: 0.3.1, radon: <property object at 0x10b5dc788>)
CPython 2.7.10 on Darwin

I was running into this issue, but upgrading to pep8 v1.6.2 seems to have resolved it.

Since this was an issue with flake8 preventing a 1.6.x series version of pep8 and 1.7.0 has been released with this fix, I'm closing this. Everyone should upgrade their version of pep8/flake8.

+1 for updating pep8 package.
I had the same issue with pep8 1.5.7
After pip install --upgrade pep8 I got pep8 1.7.0
No errors anymore.


Add some spacing between the ListItems

No functional changes. Just add some whitespace so it's to visually separate different things in this list in this example page.

[x] I have followed (at least) the PR section of the contributing guide.

@smithgraeme I'm sorry, but it doesn't match our coding style.


Add CNAME file for MkDocs and gh-pages

MkDocs requires you to put a CNAME file in your docs dir. This is most likely what caused the site not to work.
This is supposed to fix the problems talked about in #56

Did not solve it, despite the job log saying:
Run mkdocs gh-deploy --force
INFO     -  Cleaning site directory
INFO     -  Building documentation to directory: /home/runner/work/twomes-generic-esp-firmware/twomes-generic-esp-firmware/site
INFO     -  Documentation built in 0.46 seconds
WARNING  -  Version check skipped: No version specified in previous deployment.
INFO     -  Copying '/home/runner/work/twomes-generic-esp-firmware/twomes-generic-esp-firmware/site' to 'gh-pages' branch and pushing to GitHub.
To https://github.com/energietransitie/twomes-generic-esp-firmware
 + 881ca6b...fcb5[7](https://github.com/energietransitie/twomes-generic-esp-firmware/actions/runs/3264444069/jobs/5365098452#step:5:8)3f gh-pages -> gh-pages (forced update)
INFO     -  Based on your CNAME file, your documentation should be available shortly at: http://www.energietransitiewindesheim.nl/
INFO     -  NOTE: Your DNS records must be configured appropriately for your CNAME URL to work.


Changed EventSetup access upstream

CMSSW PR: cms-sw#37566

Modified deprecated eventSetup method in HGCalTriggerTools
Modified trigger tools setup access in validation. Which will conflict with  387fe76b86b667429c9ca9fd2235910f711ce159 (#6 )

Conflicts solved in 61ff27641fd5e9da8ebed126707b366f008300a9


Feature: use @gnosis.pm/safe-module-deployments to get allowance module address

What it solves
This PR is a part of https://github.com/gnosis/safe-react-apps/issues/229 to enable spending limits on avalanche, polygon, binance smart chain, and goerli networks.
How this PR fixes it
Instead of an environment variable for spending limits address, we now have a package for module deployments similar to safe deployments, and this PR integrates that package. I also had to add chainId in functions related to spending limits because the module address may be different across networks.
How to test it

Create/spend spending limits on existing networks to test that it still works on previously integrated networks
Create/spend spending limits on new networks (Bsc, polygon, goerli, avalanche)

It seems that testing is only possible on polygon because other networks aren't part of safe-config-service on staging

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 38 (18.42%)  changed or added relevant lines in 6 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.05%) to 35.565%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/routes/safe/components/Settings/SpendingLimit/RemoveLimitModal.tsx
0
1
0.0%

src/routes/safe/components/Balances/SendModal/screens/ReviewSendFundsTx/index.tsx
0
2
0.0%

src/logic/contracts/spendingLimitContracts.ts
3
11
27.27%

src/routes/safe/components/Settings/SpendingLimit/NewLimitModal/Review.tsx
0
9
0.0%

src/logic/safe/utils/spendingLimits.ts
3
14
21.43%

Files with Coverage Reduction
New Missed Lines
%

src/logic/safe/utils/spendingLimits.ts
1
17.86%

src/routes/safe/components/Settings/SpendingLimit/NewLimitModal/Review.tsx
1
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
3549

Relevant Lines:
9026

💛  - Coveralls

Trying to remove the module from the "Advanced" section shows this error in the console.
Tried the same in the dev env and it works fine there, so the issue is just here in this PR
I a 2/2 safe, enable the module by creating a spending limit for any owner
Go to adv options and click the delete icon
Sign the tx
The result is what can be seen in the snapshot. The tx is never created

Note: To test this one in polygon, the CGW must be disabled.
In Polygon, I was able to create a spending limit for an owner, but I wasn't able to send the token with that user. I get this error in the console as soon as I sign in the MM popup

@francovenica this is not related to the PR... It has to do something with polygon gas prices, I saw people in discord reporting this. @gnosis/safe-web could you please check?

@francovenica this is not related to the PR... It has to do something with polygon gas prices, I saw people in discord reporting this. @gnosis/safe-web could you please check?

True. I tried again bumping up the gas price in the MM popUp and the tx went through just fine. So this is not an issue for this PR.
Thanks for pointing it up

The issue I was having trying to remove the module is not happening anymore (idk if it was fixed or was a just something that wasn't working for a moment)
Tried in BSC a safe with existing spending limit (use of it, adding a new owner, removing it) and adding the module to a new safe.
Tried in polygon (adding a new spending limit to a safe, using it and removing it)
Tried in rinkeby in a safe that already had the module enabled and enabling it in another safe.
Looks good to me


wait for blackfire agent to start on dyno boot

This change waits for the socket to be ready before proceeding on dyno boot.
It helps e.g. in scenarios where the agent absolutely must be up, e.g. in testing (for heroku/heroku-buildpack-php).
Our specific use case is that we run a simple command, and assert that the agent starts up (and emits "Waiting for new connection"), but sometimes, the agent takes a little too long to print that, so the command has already finished.
Sure, we could just have a blanket sleep, but this can actually also happen with real-life apps, where the PHP extension is then unable to connect to the socket if the agent isn't there.
The same looping logic (except waiting for a PID file, not a socket) is already in place for other background programs in the PHP buildpack on Heroku, and has increased reliability a lot in these "sometimes, the traffic through all these clouds is a little slow") edge cases.
Does this make sense?
(could increase the sleep time to e.g. 0.2 or 0.3 if you're concerned that this spams too many messages; in my tests, there were usually six or seven "Waiting for blackfire agent..." messages on startup, but this is only printed with a suitable log level anyway, and too high a sleep value means "wasting" time on dyno boot as it'll potentially be slow to detect the socket once it's there)

Thanks @dzuelke !
This definitely makes sense 🙂


Normalize path to change

This PR addresses #13659

Pull Request Test Coverage Report for Build 399542171

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.144%

Totals

Change from base Build 399340609:
0.0%

Covered Lines:
21853

Relevant Lines:
48650

💛  - Coveralls


List improvements

Re: #55 and #56, this PR:

Adds support for the to-be-implemented features in List
Changes slicing and addition to return Python lists instead of Redis-backed Lists.
Reduces number of race conditions for list operations
Increases test coverage for lists.py significantly

This is for the 0.3.0 release (see #59). I'll probably squash the commits here together before merging.

This PR also removes the non-standard List.get method. It was ostensibly in place because we previously retrieved the length of the list in order to calculate overflow, which made it inefficient relative to just retrieving what's there.
My reading of the Redis docs for LINDEX suggests we can avoid that by detecting None.
When writeback=True we will still need to retrieve the length of the list.


Docstring consistency

Some small fixes to docstring values i noticed when going through the api docs.
Trying to follow: http://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html

Thanks for cleaning this up.
This makes me think we should have a CONTRIBUTING.rst file to detail the styleguide for things like this (also to mention that when you contribute things you should be sure to write docs/tests, mention moto, etc).


Conflict handling

Test that RestClient::Conflict is passed through (or something CouchRest specific) so that it can be properly handled.
This should also be documented.

CouchRest::Conflict FTW.


Docs.MS CI Updates for System.Memory.Data

CI Update for release of System.Memory.Data

Docs Build status updates of commit 74a4ea7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

bundlepackages/azure-dotnet.csv
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Move fontawesome icons check at compile-time

Now, we have the list of icons we use with their "variant(s)" (ie Brands, Regular or Solid) represented by a trait. To render as one of the variant, the corresponding method needs to be called.

The icons structs are now generated in the sub-crate directly. Since there is no int into having the render_* method I originally added, I instead kept the filters and simply updated them. Code still got simplified and the checks are now at compile-time. :)

Updated!

Removed serde impl on GlobalAlert and simplified the field to a specific icon.

Gonna send a follow-up for the doc for the fontawesome crate.


[docs]: Migrated docs to Sveltekit

Before submitting the PR, please make sure you do the following

[x] Read the Contributing guide
[x] Prefix your PR title with [@svelteui/core], [@svelteui/actions], [@svelteui/motion], [@svelteui/core], [core], or [docs].
[x] This message body should clearly illustrate what problems it solves.

Tests

[x] Run the tests with npm test and lint the project with yarn lint or just run yarn repo:prepush and check to see if it's passing.

This PR migrates the whole docs codebase to SvelteKit. It still needs a lot of work and the deployment would also probably have to be altered but I want to hear your thoughts on this

@Brisklemonade Pinging you, since you are also working on this in another branch

First of all, thank you so much for this PR, it looks like a lot of work and from a first look at the code, it looks good.
I'm of the opinion this could be done by steps, we could create a new branch for the new docs and this could be merged and then improved upon by small incremental steps. What do you think @Brisklemonade?

So, I'll go ahead and merge this against a branch for the migration of the docs to sveltekit. For now the objective is to maintain the same design and behaviour and just port it to sveltekit.
This can be merged now with problems, we can fix it in the branch moving forward and when it's ready we push to next-minor.
Thank you so much @Caladan08, could you resolve the conflicts to that it is merged?

Actually I don't even know what the conflicts are since here in Github, it is just showing that there are conflicts and that the conflicts are "too complex to resolve in the web editor"

Hum, I'll check it out

I hope you don't mind, I've fixed the conflicts on the branch. Could you make sure that nothing is broken after that? I checked and all seemed to work, but I want to make sure. After that I'll merge it and then we start by working on the current problems: (SSR is kinda broken due to the current limitation of svelteUI - a PR with a fix is ready, navigation, search, deployment, etc)

Yep, I've tried the code and everything works! Thanks


Cannot compile

When i open build.sh to compile it shows this error . i'm running on ubuntu 15.10
/bin/sh: 1: i686-pc-elf-gcc: not found
Makefile:61: recipe for target 'dev_drivers' failed
make: *** [dev_drivers] Error 127

this issue is too old and was probably my fault, so i'm closing it. Thank you


Add command to generate boilerplates

This adds a new make command to the vue cli to generate items (see issue #7). The boilerplates are defined in each repo in a .vue-boilerplates folder. For an example, see an example .vue-boilerplate dir in my fork of webpack-simple.
$  vue make

  Usage: vue-make make <type> [name]

  Options:

    -h, --help  output usage information
    -l, --list  list available generators and usage examples

$  vue make component auth/RegisterComponent

Created:  src/auth/RegisterComponent.vue

$ vue make --list

  Examples:

    # Create a new Vue Component in a `.vue` format
    $ vue make component widgets/CounterWidget

    # Create a new Vue directive
    $ vue make directive DatePicker

Still a lot of work to do before it's usable, but I dog-fooded it for a day and it works quite nice for a toy project.
Things that can be added on top of this:

Add extra flags which customize the content of a generated file
Right now, the file is copied verbatim. We can have some flags passed and used to replace text on the files.
Ideally I'd like to use something like vue make:component  like laravel.
Crowd-source ideas for generators to add...

Cool! I like the idea.

One thing is can we keep code style consistent - I didn't include it in vue-cli but ideally can you lint your code against this ESLint config: https://github.com/vuejs/vue/blob/dev/.eslintrc

Ok. Awesome! I'll lint them, make this more functional and send pull requests to different template repos. Will update this pull request.

I discussed this with @skyronic and we agreed on closing it.
Main reasoning is that we want to keep vue-cli focused to get initial template on your disk from where you just run npm run xyz scripts to do your development and/or builds.

@zigomir @yyx990803 Maybe this pr should be re-opened? Creating components by running something like vue generate component Hello would be very cool and time saving!


Release/1.1.300

Why was default_expand_messages removed? Is there anyway I can have this auto expand behavior in 1.1.300?


I could see, what's missing to "Go" to the stored state:

The "Go" button calls goToLatLon/setLatLon, which sets the defaults. So I added goToState: (lat: number, lon: number, pitch: number, yaw: number, distance: number) => void; and setState(lat, lon, pitch, yaw, distance)
In SavedPlaceParams and addNewPlace I added pitch, yaw and distance. I did NOT add them to addNewPlace, that would mean no backward compatibility. I even removed lat, lon because it is redundant in .link. In useLayoutEffect, all values are taken from .link now.
(I hope, this will go to the "def" branch)
#121

Thank you!