Update DomainEventHelper for not reusing ThreadLocal event

It can reuse an Event not corresponding to the same "domain action" on a previous phase (which I suppose was the main intention for reusing).

I'm not sure about this pull request.... seems that a new event is created for each phase.
In my original design I create a new event for hide, and for disable, but then reuse the same event for validate/pre-execute/post-execute.  This opens up the possibility that validation phase could (as a performance optimization) "push" results onto the event, to pass downstream to the later *execute phases.  That seems a good thing to me.
With your redesign, that wouldn't be possible.
What issue does the new design address?

Problem is that previous design was not working properly, as it was getting the event from a ThreadLocal that could contain other Event dispatched "in the middle" of another Event's processing (ie, a wrapped property is set in the middle of another Event processing).
So it was reusing an Event that was not corresponding to the same one on previous phases.
As there can be multiple Events simultaneously executing, the only way I envision, if your use case must be supported, is to change from a ThreadLocal single "existingEvent", to a List of them.
HTH,
Oscar

El 7/2/2015, a las 12:29, Dan Haywood<EMAIL_ADDRESS>escribió:
I'm not sure about this pull request.... seems that a new event is created for each phase.
In my original design I create a new event for hide, and for disable, but then reuse the same event for validate/pre-execute/post-execute. This opens up the possibility that validation phase could (as a performance optimization) "push" results onto the event, to pass downstream to the later *execute phases. That seems a good thing to me.
With your redesign, that wouldn't be possible.
What issue does the new design address?
—
Reply to this email directly or view it on GitHub https://github.com/apache/isis/pull/22#issuecomment-73360587.

Óscar Bou Bou
Responsable de Producto
Auditor Jefe de Certificación ISO 27001 en BSI
CISA, CRISC, APMG ISO 20000, ITIL-F
902 900 231 / 620 267 520
http://www.twitter.com/oscarbou http://www.twitter.com/oscarbou
http://es.linkedin.com/in/oscarbou http://es.linkedin.com/in/oscarbou
http://www.GesConsultor.com http://www.gesconsultor.com/
Este mensaje y los ficheros anexos son confidenciales. Los mismos contienen información reservada que no puede ser difundida. Si usted ha recibido este correo por error, tenga la amabilidad de eliminarlo de su sistema y avisar al remitente mediante reenvío a su dirección electrónica; no deberá copiar el mensaje ni divulgar su contenido a ninguna persona.
Su dirección de correo electrónico junto a sus datos personales constan en un fichero titularidad de Gesdatos Software, S.L. cuya finalidad es la de mantener el contacto con Ud. Si quiere saber de qué información disponemos de Ud., modificarla, y en su caso, cancelarla, puede hacerlo enviando un escrito al efecto, acompañado de una fotocopia de su D.N.I. a la siguiente dirección: Gesdatos Software, S.L. , Paseo de la Castellana, 153 bajo - 28046 (Madrid), y Avda. Cortes Valencianas num. 50, 1ºC - 46015 (Valencia). Asimismo, es su responsabilidad comprobar que este mensaje o sus archivos adjuntos no contengan virus informáticos, y en caso que los tuvieran eliminarlos.

OK, understood.   In which case, your design wins.
If later on we want to re-introduce the concept of reusing events between phases then we can put the extra machinery back in (Lists, etc).
I'll merge this shortly.

Many thanks, Dan.

El 7/2/2015, a las 12:48, Dan Haywood<EMAIL_ADDRESS>escribió:
OK, understood. In which case, your design wins.
If later on we want to re-introduce the concept of reusing events between phases then we can put the extra machinery back in (Lists, etc).
I'll merge this shortly.
—
Reply to this email directly or view it on GitHub https://github.com/apache/isis/pull/22#issuecomment-73361100.


Get a Tree & Get a Tree Recursively is one endpoint and should be combined

recursive is a parameter like in many other GET routes
https://github.com/octokit/routes/blob/11a432f1a9fe33d526a78bfeff91ab6ec256ab53/index.json#L2232-L2287

closed by https://github.com/octokit/routes/pull/120


make sure "traffic_ctl config reload" only reloads configs that changed

(cherry picked from commit 8fd7ee003020cb8c064c5b4702f543148a183a9a)

[approve ci autest]


Can't use array elements in math

For some reason I can't do arithmetic operations with array elements.
(Type conversion error)
Example: dim array:push 1,array:print array:print array[0]+1

That's strange... It seems to work as expected for me!

Have you got any errors in DevTools about it? Do you know if the type conversion error occurs for print array or just print array[0]+1?

I forgot to mention, yes, the error only occurs at array[0]+1. What is weird, is that it works on the phone, but both devices keep atto up-to-date. I can't check it on the PC right now, but when I can, I will write more info.

What is even weirder is that it still works on my phone, but when it's in this code (it's on the bottom of the comment), it doesn't work on both devices (coord2Array[0] is a normal number). I tried running this code (on the phone) and tried these commands:
dim abc:push 23,abc:print abc[0]+2 (returns 25, works ok)
print coord2Array[0]+2 (Type conversion error)
Basically, it's like this:

Works on PC? No
Works on mobile? Yes
Works on PC in this code? No
Works on mobile in this code? No

Even if I am doing something wrong, the simple dim x:push 1,x:print x+1 command returns different results on different devices. I don't think it should have problems converting 2 into a number though.
Also, "this" code:
https://atto.devicefuture.org/?code=1 rem {redacted}
2 rem {redacted}
10 rem []
20 boardX%25%3D19
30 boardY%25%3D14
40 graphSize%25%3D16
50 arrows%3Dsplit("wdsa") rem yes...w d s a.
60 rem [Generate free space]
70 dim free
80 for freeY%25%3D0 to boardY%25
90 for freeX%25%3D0 to boardX%25
100 push freeX%25%3B"%3B"%3BfreeY%25%2Cfree
110 next
120 next
130 rem [Generate the snake]
140 dim snake
150 for snakePart%25%3D0 to 4
160 snakePartCell%24%3D1%2BSnakePart%25%3B"%3B"%3B1
170 push snakePartCell%24%2Csnake
180 remove free%2Cfind(snakePartCell%24%2Cfree)
190 next
200 rem []
210 goAngle%25%3D1
220 gosub 540
230 rem [Game loop]
240 rem [Read key data]
250 input ctrl%24 rem Mobile-friendly.
260 if find(ctrl%24%2Carrows)!%3D-1
270 goAngle%25%3Dfind(ctrl%24%2Carrows)*90
280 end
290 rem [Move the snake]
300 coord2Array%3Dsplit(last(snake)%2C"%3B")%0A310%20push%20coord2Array%5B0%5D%2Bsin(goAngle%25)%3B%22%3B%22%3Bcoord2Array%5B1%5D%2Bcos(goAngle%25)%2Csnake%0A320%20rem%20%5BCheck%20apple%5D%0A330%20if%20last(snake)%3Dapple%24%0A340%20gosub%20540%0A350%20apples%25%3Dapples%25%2B1%0A360%20else%0A370%20remove%20snake%2C0%0A380%20end%0A390%20rem%20%5BCheck%20loss%5D%0A400%20if%20find(last(snake)%2Cfree)%3D-1%0A410%20print%20%22You%20lost!%20Score%20(apples)%3A%20%22%3Bapples%25%0A420%20stop%0A430%20end%0A440%20rem%20%5BRendering%5D%0A450%20cls%0A460%20graphX%25%3DgraphSize%25boardX%25%0A470%20graphY%25%3DgraphSize%25boardY%25%0A480%20rem%20%5BRendering%3A%20Background%5D%3A%0A490%20rem%20%5BRendering%3A%20Snake%5D%0A495%20fg%20%22rgb%22%2C0%2C128%2C0%3A%0A500%20rem%20%5BRendering%3A%20Snake%20head%5D%0A505%20fg%20%22rgb%22%2C0%2C255%2C0%3A%0A510%20rem%20%5BRendering%3A%20Apple%5D%0A515%20fg%20%22rgb%22%2C255%2C0%2C0%3A%0A520%20goto%20240%0A530%20rem%20%5BApple%5D%0A540%20apple%24%3Dfree%5Bfloor(random*len(free))%5D%0A550%20return
I originally made it in a simple text editor and still debugging it.

Weirdly, it works on PC now, but not in the code. Here's a DevTools screenshot of running this code on PC. There are no new error messages after the conversion error.

It might not seem immediately obvious, but coord2Array items appear to be strings, which won't work with the + operator! To get it to work, you'll need to modify your program to be:
304 value0=coord2Array[0]:value1=coord2Array[1]
305 push value0%+sin(goAngle%);";";value1%+cos(goAngle%),snake

At the moment, list items can't be casted to a number like coord2Array[0]%, so the items must be stored in variables that can then be subsequently casted. It might be worth modifying atto and making the + operator automatically cast strings to numbers (just like how ; basically casts numbers to strings when used) to prevent the confusing type conversion error, so I'll keep the issue open for that.


Allow removing replica from domain replication group

What changed?
Allow removing replica from domain replication group

Why?
For https://github.com/uber/cadence/issues/4342

How did you test it?
Test with local env

Potential risks
No.

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build dfb2554c-8eb5-4948-adb6-7c6c950ce386

5 of 6 (83.33%)  changed or added relevant lines in 2 files are covered.
49 unchanged lines in 11 files lost coverage.
Overall coverage decreased (-0.006%) to 56.825%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/domain/handler.go
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

service/history/execution/mutable_state_task_refresher.go
1
74.4%

common/membership/rpServiceResolver.go
2
73.58%

common/persistence/executionManager.go
2
75.75%

common/persistence/statsComputer.go
2
96.43%

common/task/fifoTaskScheduler.go
2
85.57%

common/task/parallelTaskProcessor.go
2
92.48%

service/history/queue/timer_gate.go
3
95.83%

service/history/task/transfer_active_task_executor.go
4
70.49%

common/persistence/sql/sqlExecutionStore.go
5
61.07%

service/history/shard/context.go
9
66.02%

Totals

Change from base Build 342acb5b-b46a-4ccb-8973-8f80d22c6bf4:
-0.006%

Covered Lines:
78044

Relevant Lines:
137342

💛  - Coveralls


Moving to Selenium 3.11.0

Coverage remained the same at 68.927% when pulling 5b999b198b5ecf29aed51dfde104b127df46b089 on myznikov:moving_to_selenium_3_11_0 into b2ed4af5179d45ccca7d1023f6da4171f3e5e082 on sterodium:master.


Erase destroyed shader modules from LayerData.

Remove a shader module from the LayerData when vkDestroyShaderModule is called. This makes sure that we don't accidentally use pointers to destroyed objects.
Add a hook on DestroyShaderModule function in the compile_time_layer and runtime_layer.

Could you also update the PR title / description on the website? When we squash commits uses these instead of actual commit messages.

Could you also add the link to the issue at the bottom? The convention is:

@miladHakimi Could you also add this to the PR description?


Cargo IANAL

It would be really nice to have a cargo command that analizes all dependencies and:

Verifies that the licenses are compatible.
Informs the user about any additional use/distribution restrictions.
Helps the user choose an appropriate license (if not already specified).

This doesn't have to cover all licenses, just the common ones (MIT, Apache2, the GPLs, the BSDs, etc...).

Do you know of any preexisting data for 1 and 2 that cargo can reuse?

For 1, there's this for GPL compatibility... That's why I said we should start with common ones. Unfortunately, license compatibility is not transitive so this gets a little tricky.

Big :+1:. It would be very nice to have such feature.

This, or something like it, is really necessary in my eyes. Since you can easily rack up tons of transitive dependencies with just a couple direct ones, it would be nice to have a tool like this.
I don't know if there's a 'crates.io user agreement' but there should also be some kind of terms you have to agree to before uploading your crate which states that the license you specify in your Cargo.toml overrides any other licenses in your repository, for those rare cases someone might put down MIT and actually uses GPL.

Automated license-compatibility checking is really complicated if not impossible. Also you don't want Cargo to have something declared OK which turns out to be not OK.
It would be nice though to have a command that lists all dependencies and their licenses.

Automated license-compatibility checking is really complicated if not impossible.

This isn't automated license-compatibility checking. This is automated project compatibility checking using a precomputed license compatibility matrix of common licenses. (see the gnu link above). This is totally doable for a small set of well understood, common licenses.

Just came across this somewhat relevant article today: Streamlining license compliance with FOSSology 3.0

I've been meaning to do something like this for a while and finally got round to finishing my prototype and pushing it to github: https://github.com/Nemo157/cargo-lichking.

BSD-new            .   .    ✔    ✔   ✔     ✔      ✔      ✔    .    .     .     .

 Can't I have a GPL program that has a Apache or MIT dependency?

@tbu- according to Wikipedia, gnu.org and http://www.dwheeler.com/essays/floss-license-slide.html you can. Maybe @ticki's matrix is assuming the compatability is transitive and not showing that explicitly?

@ticki's matrix is completely wrong, maybe even if you check everything under the diagonal.
If you've no problem with any common licenses, then you only need to worry about mutual incompatibilities, probably only Apache vs (L)GPLv2 and MPL 1 vs GPL. Now the GPLv3 has resolved compatibility issues with Apache and [https://www.fsf.org/blogs/licensing/mpl-2.0-release](MPL 2 resolved compatibility issues with the GPL).
At this point, I think the major source of problems for common licenses issue is Apple's AppStore restrictions, which seem incompatible with third parties developers using GPLed libraries.  There are rumors the FSF might eventually develop an AppStore amenable license based around reproducible builds, but that's probably years off.

@burdges @Nemo157 @tbu- It is based on the fact that these licenses are transitive with each other. If you extend the set, it might not be transitive, though.

@ticki That's why we need something more extensive than a simple matrix.

Pretty sure a matrix does work, I basically used one for cargo-lichking: https://github.com/Nemo157/cargo-lichking/blob/master/src/license.rs although that doesn't assume any kind of transitivity of the relationship and just has a fully specified matrix.

In practice, this kind of thing is more complex, particularly because there's an implicit difference between the licence for the whole, and the licence for the source. The former incorporates the source along with not only artifacts, but the way in which it is structured, delivered, organised or even marketed (!) Oh, and then one has to add in legal domain (country, and, in places like the UK, region; eg how Scots law works here with overlap) and choice of vendoring author / legal entity (company).
So the most useful thing a tool could do is show license usage as SPDX codes (or, ideally, as SPDX codes as per the Debian COPYRIGHT file format, which is more subtle) by crate, by type of dependency. And even then, it wouldn't be 100% right. For example, take clippy. It gets listed as a dependency because it's a compiler plugin, but it's actually never shipped in a binary... so if clippy was AGPL, say, it wouldn't actually virally infest any other code.
I would suggest we look at adopting Debian's COPYRIGHT file format  for cargo, though. It's something I've used for a couple of years now, and it makes documenting license details, copyright statements and authorship transparent and explicit. Of course, it would mean writing a parser for Debian-style files, but that wouldn't be a bad thing at all. And they're not hard.

There are other considerations than straight license compatibility. For an example I have been directly involved with, the LGPL was designed against closed-source software, at the expense of copyleft free software. So even though LGPL and MPL are compatible, there are redistristribution constraints that forces Mozilla to distribute binary code from LGPL source code in a separate shared library instead of statically linking it like everything else. These kind of problems are especially hitting Rust code, since the Rust compiler defaults to static linking.

https://github.com/fossas/fossa-cli accomplishes this, and is OSS -- a PR could be a great home for cargo support

I do not think fossa qualifies as an open source tool. Only their client is open, the analysis is done on their servers.

For example, if a Linux distributor is creating a package, they may wish to have the ability to check the licence list of the relevant crate as a standard feature of cargo.
It is hoped that functions such as cargo-lichking and cargo-license will become standard features.
cargo lichking bundle

The above features would be eagerly awaited by distributors.


Exception when running pyhanko sign ltvfix

Describe the bug
I get an exception when I am trying to run ltvfix on a signed PDF file.
To Reproduce

Get the CA certificate:
wget https://www.sk.ee/upload/files/TEST_of_EE_Certification_Centre_Root_CA.der.crt
Run the pyhanko ltvfix on the document
pyhanko sign ltvfix --trust TEST_of_EE_Certification_Centre_Root_CA.der.crt  --field Signature1 lorem-ipsum-signed.pdf

Expected behavior

Run LTV fix successfully

Environment (please complete the following information):
pyHanko==0.12.0
pyhanko-certvalidator==0.19.4

Additional context
  File "$VENV/lib/python3.8/site-packages/pyhanko/sign/validation/dss.py", line 133, in _cms_objects_to_streams
    yield seen[obj_bytes]
KeyError: [...]

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "$VENV/bin/pyhanko", line 8, in <module>
    sys.exit(launch())
  File "$VENV/lib/python3.8/site-packages/pyhanko/__main__.py", line 7, in launch
    cli(prog_name='pyhanko')
  File "$VENV/lib/python3.8/site-packages/click/core.py", line 1128, in __call__
    return self.main(*args, **kwargs)
  File "$VENV/lib/python3.8/site-packages/click/core.py", line 1053, in main
    rv = self.invoke(ctx)
  File "$VENV/lib/python3.8/site-packages/click/core.py", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "$VENV/lib/python3.8/site-packages/click/core.py", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "$VENV/lib/python3.8/site-packages/click/core.py", line 1395, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "$VENV/lib/python3.8/site-packages/click/core.py", line 754, in invoke
    return __callback(*args, **kwargs)
  File "$VENV/lib/python3.8/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "$VENV/lib/python3.8/site-packages/pyhanko/cli.py", line 632, in ltv_fix
    output = validation.add_validation_info(
  File "$VENV/lib/python3.8/site-packages/pyhanko/sign/validation/__init__.py", line 302, in add_validation_info
    return asyncio.run(coro)
  File "/Users/tlilja/.pyenv/versions/3.8.10/lib/python3.8/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/Users/tlilja/.pyenv/versions/3.8.10/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
    return future.result()
  File "$VENV/lib/python3.8/site-packages/pyhanko/sign/validation/dss.py", line 645, in async_add_validation_info
    resulting_dss = DocumentSecurityStore.supply_dss_in_writer(
  File "$VENV/lib/python3.8/site-packages/pyhanko/sign/validation/dss.py", line 443, in supply_dss_in_writer
    dss.register_vri(
  File "$VENV/lib/python3.8/site-packages/pyhanko/sign/validation/dss.py", line 215, in register_vri
    crl_refs = set(
  File "$VENV/lib/python3.8/site-packages/pyhanko/sign/validation/dss.py", line 140, in _cms_objects_to_streams
    dest.append(ref)
AttributeError: 'tuple' object has no attribute 'append'

lorem-ipsum-signed.pdf

Yikes, that sure looks like a bug. I'll take a closer look; thanks for the report and the sample file!

I've fixed the bug in a bugfix branch off 0.12.0 (see commit message of linked commit). I'll merge that into master now. Is this blocking you to the point that you need a bugfix release, or can it wait?

Thanks for the quick fix. While I can probably work around the problem, a bugfix release would be nice.

Done, I just released 0.12.1 :).


Port over too many files open fix to this.

Can test by running the code on the fracas set. The current version will get the following error before completing (about 3/4 of the way through the dataset):
Error: "starting shell command" resulted in error "Too many open files"
  [condition type: SYSCALL-ERROR]

Fixed with https://github.com/genelkim/lenulf/pull/3


Remove Glusterfs

Removed the usage of glusterfs from deployment.

Glusterfs is removed in v0.0.15, so closing this PR.


make slayer plugin consider more alternatives for slayer tasks

also remove some target names for which the task name already matches the NPCs and thus creates useless extra computation

resolves #16983

ping @Nightfirecat

Added in ad7120ed1334fe058517418190b5956ea0254f42, b6abba997f35a1a7e2a03bea33829b0485792853, 83777bb8e543974044c61fc7d97954c84b14b377, and 6d3d14b111cea564c06bd4ed66c3b1b0099a06fe. Thank you!


chore: modernize dependencies and codebase

Fixes or Changes Proposed

chore: update gradle → 8.1.2 (latest/beta)
chore: minimum jvm → 11
chore: update kotlin → 1.8.20
chore: update dokka → 1.8.10
chore: update node → 20.0.0
chore: update ktlint → 0.42.1
chore: update KJS yarn lock
chore: add pkgst repositories
chore: tune gradle flags
chore: remove deprecated native targets
chore: general build file cleanup
chore: tune flags for kotlin compiler
chore: rework and fix CI build for PRs
chore: enable gradle configuration cache+stable mode
chore: upgrade and align github action step versions
fix: ignore spellcheck results in code/literals (IDEA)
fix: main = became mainClass.set
fix: classifier = became archiveClassifier =
fix: more efficient use of Yarn from Gradle
feat: add support for sonar
feat: add support for kover/codecov
feat: add support for dependabot
feat: add support for dependency check action
feat: add support for detekt plugin
feat: add version catalog and transition to deps from that
feat: add gradle doctor plugin, sonar, kover, version check
feat: add API check plugin and dump surface
feat: add kotlinx benchmark plugin

PR Checklist

[ ] I have added a CHANGELOG.md entry for any noteable changes or fixes.
[ ] I have added test coverage for any new behavior or bug fixes.

reopening from elide


csi-rbd provisioner resources

The helm chart does not allow you to independently set resources for the csi-rbdplugin in the provisioner separately from the node. We are finding that the mememory uses are different for each. The node is how many parallel mounts need to happen at once. The provisioner needs more memory to cover all the creates/deletes that can happen in parallel.

@Madhu-1 or @leseb were you not looking into this for Rook?

this is already fixed in rook

here it is https://github.com/rook/rook/pull/5287

Should this not also get added to the Helm charts and examples we maintain in this repository?

yes, these changes we need in helm charts, its kind of refactoring the helm value.yaml files.


[DOC] README_0.8.0_release_update

Description
Updates the README.md to point to release 0.8.0 instead of 0.7.0
This pull request is categorized as a:

[x] Documentation

This will need to be verified prior to merging and after the 0.8.0 release is out

release 0.8.0 is live: https://github.com/SeedSigner/seedsigner/releases/tag/0.8.0


Can't SSH into bosh director.

Successfully deployed the cluster and have everything up and running on GCP.   I can get into Opsmanager fine, and I can target the bosh director fine, but I cannot seem to figure out how to ssh into the director itself.   I can ping the instance, I can telnet to port 22.  I have tried ubuntu, my login, root, vcap...nothing seems to work.

@dbbaskette do you happen to have the commits or PR handy that implemented this?


Add simple Colab demo

Just a suggestion - so it's easy to try out with one click :) Note that this pull request depends upon #1
(A Huggingface/Gradio demo would be even better! ... @AK391)

I appreciate that you like our work and thank you for your nice contribution.  We will consider to release a Gradio demo soon!

@josephrocca thanks for suggesting, added a gradio demo here https://github.com/YangtaoWANG95/TokenCut/pull/3 and great work on the colab
@YangtaoWANG95 great paper, please see the PR for the gradio demo


improve feed scroll

feed scroll becomes really problematic on react-native dev
on web it is a little problematic
maybe we need to find a better scrollable list solution

[ ] feed is slow when scrolling alot
[  ] feed is sensitive, when scrolling it will click on items and open modal

@sirpy What are the issues associated with the scroll?

update existing package, apply customizations via patch-package instead of making a fork like we have did in the past. OR research for the better package providing everyting we're need
look at optimizations, remove render functions, replace them via usage of nested components wrapped onto React.memo. Install why did  you render and check for extra re-renders, decrease theirs count
ask @sirpy regarding the exact issues we met (e.g. sometimes popup is opened during scroll, slow scroll with the large feed etc), fix them

Vlad have added it onto changelog but it's still 'in sprint'
so, @vldkhh @roma-hladilka was this fixed or not ?


Set echo logger log level based on context

We can send the log level via headers but there still is a need to set the log level on the logger that is on the echo instance

If we switch to zap as per #18  this won't be needed


Question : Is it possible to run with gsap

Hey guys , I am wondering if its possible to run it with the greensock animation platform instead of tweenjs. I will try maybe tomorrow, but I was hoping for advice if you think its a bad idea and why.

Hi @jkanchelov short answer is probably no. FYI, this project is not in active development so feel free to fork to fit your needs. We have abandoned it to implement a better publishing solution for Animate CC, which is yet to be released called PixiAnimate (https://github.com/jiborobot/pixi-animate). You might want to watch that project.

Thanks for the information. Me and my team are migrating to pixi from flash and currently looking for solutions if possible to keep the workflow as close as it can be as before. Could you share any info about the pixi-animate project about the progress and when to expect it.
Thanks in advance.

@jkanchelov Email me and I can add you to the prerelease. We haven't fully supported Windows yet, Mac only.

Done. Thanks !


Add summary reportlets to HTML report

Related to #13. Still missing run-wise anatomical and DWI summaries.
Changes proposed in this pull request

Add "About" reportlet with command.
Add "Summary" reportlet with summary of collected data.
Write out top-level reportlets to individual reconstruction pipelines' output directories.
Pin nireports to new release that supports PNGs.

Codecov Report
Attention: Patch coverage is 44.44444% with 25 lines in your changes missing coverage. Please review.

Project coverage is 33.70%. Comparing base (c80616e) to head (775442c).

Files
Patch %
Lines

qsirecon/workflows/base.py
14.28%
18 Missing :warning:

qsirecon/interfaces/utils.py
66.66%
4 Missing :warning:

qsirecon/interfaces/reports.py
75.00%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   33.42%   33.70%   +0.28%
==========================================
  Files          56       56
  Lines        6825     6842      +17
  Branches      894      893       -1
==========================================
+ Hits         2281     2306      +25
+ Misses       4446     4435      -11
- Partials       98      101       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

The summary reportlets are being written to the output_dir rather than individual QSIRecon pipeline directories. I could either move the reportlet generation to the individual pipelines' workflows or copy any reportlets to the pipeline directories. I'm leaning toward the latter.

@mattcieslak do you think QSIRecon should write out the recon spec? It seems useful.

@mattcieslak do you think QSIRecon should write out the recon spec? It seems useful.

Definitely. It's at least as important as the config.toml file

I add that in then

Okay it's added and it looks good.


FileNotFoundError

I am using a dataset of the format 'completion' to finetune a Falcon model. All json files are stored inside a folder named 'corpus' with the following format:
{'text': ...}
The yml looks like this:
datasets:
  - path: corpus
    type: "completion"

But I am getting this error:
===================================BUG REPORT===================================
Welcome to bitsandbytes. For bug reports, please run

python -m bitsandbytes

 and submit this information together with your error trace to: https://github.com/TimDettmers/bitsandbytes/issues
================================================================================
bin /home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/bitsandbytes/libbitsandbytes_cuda113.so
/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/bitsandbytes/cuda_setup/main.py:149: UserWarning: Found duplicate ['libcudart.so', 'libcudart.so.11.0', 'libcudart.so.12.0'] files: {PosixPath('/home/user/miniconda3/envs/fastai/lib/libcudart.so'), PosixPath('/home/user/miniconda3/envs/fastai/lib/libcudart.so.11.0')}.. We'll flip a coin and try one of these, in order to fail forward.
Either way, this might cause trouble in the future:
If you get `CUDA error: invalid device function` errors, the above might be the cause and the solution is to make sure only one ['libcudart.so', 'libcudart.so.11.0', 'libcudart.so.12.0'] in the paths that we search based on your env.
  warn(msg)
CUDA SETUP: CUDA runtime path found: /home/user/miniconda3/envs/fastai/lib/libcudart.so
CUDA SETUP: Highest compute capability among GPUs detected: 8.0
CUDA SETUP: Detected CUDA version 113
CUDA SETUP: Loading binary /home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/bitsandbytes/libbitsandbytes_cuda113.so...
WARNING:root:`trust_remote_code` is set to true. Please make sure that you reviewed the remote code/model.
INFO:root:loading tokenizer... tiiuae/falcon-7b
Using bos_token, but it is not set yet.
Using pad_token, but it is not set yet.
Using unk_token, but it is not set yet.
INFO:root:Unable to find prepared dataset in last_run_prepared/adaed1483e102f8f139bc363237dab29
INFO:root:Loading raw datasets...
INFO:root:No seed provided, using default seed of 42
Resolving data files: 100%|██████████████| 4585/4585 [00:00<00:00, 14958.87it/s]
Traceback (most recent call last):
  File "/home/user/axolotl/scripts/finetune.py", line 352, in <module>
    fire.Fire(train)
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/fire/core.py", line 141, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/fire/core.py", line 475, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/fire/core.py", line 691, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
  File "/home/user/axolotl/scripts/finetune.py", line 222, in train
    train_dataset, eval_dataset = load_prepare_datasets(
  File "/home/user/axolotl/src/axolotl/utils/data.py", line 385, in load_prepare_datasets
    dataset = load_tokenized_prepared_datasets(
  File "/home/user/axolotl/src/axolotl/utils/data.py", line 106, in load_tokenized_prepared_datasets
    ds = load_dataset(
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/datasets/load.py", line 1773, in load_dataset
    builder_instance = load_dataset_builder(
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/datasets/load.py", line 1502, in load_dataset_builder
    dataset_module = dataset_module_factory(
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/datasets/load.py", line 1137, in dataset_module_factory
    ).get_module()
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/datasets/load.py", line 712, in get_module
    data_files = DataFilesDict.from_local_or_remote(
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/datasets/data_files.py", line 779, in from_local_or_remote
    DataFilesList.from_local_or_remote(
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/datasets/data_files.py", line 747, in from_local_or_remote
    data_files = resolve_patterns_locally_or_by_urls(base_path, patterns, allowed_extensions)
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/datasets/data_files.py", line 347, in resolve_patterns_locally_or_by_urls
    for path in _resolve_single_pattern_locally(base_path, pattern, allowed_extensions):
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/datasets/data_files.py", line 291, in _resolve_single_pattern_locally
    raise FileNotFoundError(error_msg)
FileNotFoundError: Unable to find '/home/user/axolotl/corpus' at /home/user/axolotl
Traceback (most recent call last):
  File "/home/user/miniconda3/envs/fastai/bin/accelerate", line 8, in <module>
    sys.exit(main())
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/accelerate/commands/accelerate_cli.py", line 45, in main
    args.func(args)
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/accelerate/commands/launch.py", line 941, in launch_command
    simple_launcher(args)
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/accelerate/commands/launch.py", line 603, in simple_launcher
    raise subprocess.CalledProcessError(returncode=process.returncode, cmd=cmd)
subprocess.CalledProcessError: Command '['/home/user/miniconda3/envs/fastai/bin/python', 'scripts/finetune.py', 'config.yml']' returned non-zero exit status 1.

Which seems weird since it was able to load the files. Why wouldn't it be able to find the corpus folder?
Any ideas of what I am doing wrong?

Unfortunately, I don't think we support loading by folder yet. You would need to point to each individual file or combine them into one. I'm very sorry for that .. We're open to PR this, if you're interested.

You might want
- path: corpus/text0.json

Although, I might recommend converting the json to jsonl (there is script in the data directory) and then combine all those files.

Thanks for the suggestion. I did that but now the following message appears:
===================================BUG REPORT===================================
Welcome to bitsandbytes. For bug reports, please run

python -m bitsandbytes

 and submit this information together with your error trace to: https://github.com/TimDettmers/bitsandbytes/issues
================================================================================
bin /home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/bitsandbytes/libbitsandbytes_cuda113.so
/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/bitsandbytes/cuda_setup/main.py:149: UserWarning: Found duplicate ['libcudart.so', 'libcudart.so.11.0', 'libcudart.so.12.0'] files: {PosixPath('/home/user/miniconda3/envs/fastai/lib/libcudart.so.11.0'), PosixPath('/home/user/miniconda3/envs/fastai/lib/libcudart.so')}.. We'll flip a coin and try one of these, in order to fail forward.
Either way, this might cause trouble in the future:
If you get `CUDA error: invalid device function` errors, the above might be the cause and the solution is to make sure only one ['libcudart.so', 'libcudart.so.11.0', 'libcudart.so.12.0'] in the paths that we search based on your env.
  warn(msg)
CUDA SETUP: CUDA runtime path found: /home/user/miniconda3/envs/fastai/lib/libcudart.so.11.0
CUDA SETUP: Highest compute capability among GPUs detected: 8.0
CUDA SETUP: Detected CUDA version 113
CUDA SETUP: Loading binary /home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/bitsandbytes/libbitsandbytes_cuda113.so...
WARNING:root:`trust_remote_code` is set to true. Please make sure that you reviewed the remote code/model.
INFO:root:loading tokenizer... tiiuae/falcon-7b
Using bos_token, but it is not set yet.
Using pad_token, but it is not set yet.
Using unk_token, but it is not set yet.
INFO:root:Unable to find prepared dataset in last_run_prepared/43194b0cd77ed92a1e04ae3ec307e7fc
INFO:root:Loading raw datasets...
INFO:root:No seed provided, using default seed of 42
WARNING:datasets.builder:Found cached dataset json (/home/user/.cache/huggingface/datasets/json/default-bd0b29b61691cfff/0.0.0/e347ab1c932092252e717ff3f949105a4dd28b27e842dd53157d2f72e276c2e4)
100%|████████████████████████████████████████████| 1/1 [00:00<00:00, 875.82it/s]
INFO:root:tokenizing, merging, and shuffling master dataset
Traceback (most recent call last):
  File "/home/user/axolotl/scripts/finetune.py", line 352, in <module>
    fire.Fire(train)
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/fire/core.py", line 141, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/fire/core.py", line 475, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/fire/core.py", line 691, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
  File "/home/user/axolotl/scripts/finetune.py", line 222, in train
    train_dataset, eval_dataset = load_prepare_datasets(
  File "/home/user/axolotl/src/axolotl/utils/data.py", line 385, in load_prepare_datasets
    dataset = load_tokenized_prepared_datasets(
  File "/home/user/axolotl/src/axolotl/utils/data.py", line 256, in load_tokenized_prepared_datasets
    samples = samples + list(d)
  File "/home/user/axolotl/src/axolotl/datasets.py", line 40, in __iter__
    yield self.prompt_tokenizer.tokenize_prompt(example)
  File "/home/user/axolotl/src/axolotl/prompt_tokenizers.py", line 233, in tokenize_prompt
    tokenized_full_prompt = self._tokenize(full_prompt)
  File "/home/user/axolotl/src/axolotl/prompt_tokenizers.py", line 70, in _tokenize
    result["input_ids"][-1] != self.tokenizer.eos_token_id
IndexError: list index out of range
Traceback (most recent call last):
  File "/home/user/miniconda3/envs/fastai/bin/accelerate", line 8, in <module>
    sys.exit(main())
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/accelerate/commands/accelerate_cli.py", line 45, in main
    args.func(args)
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/accelerate/commands/launch.py", line 941, in launch_command
    simple_launcher(args)
  File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/accelerate/commands/launch.py", line 603, in simple_launcher
    raise subprocess.CalledProcessError(returncode=process.returncode, cmd=cmd)
subprocess.CalledProcessError: Command '['/home/user/miniconda3/envs/fastai/bin/python', 'scripts/finetune.py', 'config.yml']' returned non-zero exit status 1.

Thanks for the suggestion. I did that but now I am facing the following message:
`===================================BUG REPORT===================================
Welcome to bitsandbytes. For bug reports, please run
python -m bitsandbytes
and submit this information together with your error trace to: https://github.com/TimDettmers/bitsandbytes/issues
bin /home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/bitsandbytes/libbitsandbytes_cuda113.so
/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/bitsandbytes/cuda_setup/main.py:149: UserWarning: Found duplicate ['libcudart.so', 'libcudart.so.11.0', 'libcudart.so.12.0'] files: {PosixPath('/home/user/miniconda3/envs/fastai/lib/libcudart.so'), PosixPath('/home/user/miniconda3/envs/fastai/lib/libcudart.so.11.0')}.. We'll flip a coin and try one of these, in order to fail forward.
Either way, this might cause trouble in the future:
If you get CUDA error: invalid device function errors, the above might be the cause and the solution is to make sure only one ['libcudart.so', 'libcudart.so.11.0', 'libcudart.so.12.0'] in the paths that we search based on your env.
warn(msg)
CUDA SETUP: CUDA runtime path found: /home/user/miniconda3/envs/fastai/lib/libcudart.so
CUDA SETUP: Highest compute capability among GPUs detected: 8.0
CUDA SETUP: Detected CUDA version 113
CUDA SETUP: Loading binary /home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/bitsandbytes/libbitsandbytes_cuda113.so...
WARNING:root:trust_remote_code is set to true. Please make sure that you reviewed the remote code/model.
INFO:root:loading tokenizer... tiiuae/falcon-7b
Using bos_token, but it is not set yet.
Using pad_token, but it is not set yet.
Using unk_token, but it is not set yet.
INFO:root:Unable to find prepared dataset in last_run_prepared/43194b0cd77ed92a1e04ae3ec307e7fc
INFO:root:Loading raw datasets...
INFO:root:No seed provided, using default seed of 42
Downloading and preparing dataset json/default to /home/user/.cache/huggingface/datasets/json/default-bd0b29b61691cfff/0.0.0/e347ab1c932092252e717ff3f949105a4dd28b27e842dd53157d2f72e276c2e4...
Downloading data files: 100%|██████████████████| 1/1 [00:00<00:00, 12985.46it/s]
Extracting data files: 100%|████████████████████| 1/1 [00:00<00:00, 1874.97it/s]
Dataset json downloaded and prepared to /home/user/.cache/huggingface/datasets/json/default-bd0b29b61691cfff/0.0.0/e347ab1c932092252e717ff3f949105a4dd28b27e842dd53157d2f72e276c2e4. Subsequent calls will reuse this data.
100%|████████████████████████████████████████████| 1/1 [00:00<00:00, 567.72it/s]
INFO:root:tokenizing, merging, and shuffling master dataset
Traceback (most recent call last):
File "/home/user/axolotl/scripts/finetune.py", line 352, in
fire.Fire(train)
File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/fire/core.py", line 141, in Fire
component_trace = _Fire(component, args, parsed_flag_args, context, name)
File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/fire/core.py", line 475, in _Fire
component, remaining_args = _CallAndUpdateTrace(
File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/fire/core.py", line 691, in _CallAndUpdateTrace
component = fn(*varargs, **kwargs)
File "/home/user/axolotl/scripts/finetune.py", line 222, in train
train_dataset, eval_dataset = load_prepare_datasets(
File "/home/user/axolotl/src/axolotl/utils/data.py", line 385, in load_prepare_datasets
dataset = load_tokenized_prepared_datasets(
File "/home/user/axolotl/src/axolotl/utils/data.py", line 256, in load_tokenized_prepared_datasets
samples = samples + list(d)
File "/home/user/axolotl/src/axolotl/datasets.py", line 40, in iter
yield self.prompt_tokenizer.tokenize_prompt(example)
File "/home/user/axolotl/src/axolotl/prompt_tokenizers.py", line 233, in tokenize_prompt
tokenized_full_prompt = self._tokenize(full_prompt)
File "/home/user/axolotl/src/axolotl/prompt_tokenizers.py", line 70, in _tokenize
result["input_ids"][-1] != self.tokenizer.eos_token_id
IndexError: list index out of range
Traceback (most recent call last):
File "/home/user/miniconda3/envs/fastai/bin/accelerate", line 8, in
sys.exit(main())
File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/accelerate/commands/accelerate_cli.py", line 45, in main
args.func(args)
File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/accelerate/commands/launch.py", line 941, in launch_command
simple_launcher(args)
File "/home/user/miniconda3/envs/fastai/lib/python3.10/site-packages/accelerate/commands/launch.py", line 603, in simple_launcher
raise subprocess.CalledProcessError(returncode=process.returncode, cmd=cmd)
subprocess.CalledProcessError: Command '['/home/user/miniconda3/envs/fastai/bin/python', 'scripts/finetune.py', 'config.yml']' returned non-zero exit status 1.`

Okay, I've been struggling with this exact same issue (if you don't support loading by folder, please put a check in, don't just close this issue as done!  :)  ).  Merging .json together into a single json array and specifying an absolute path to that array is a valid workaround. But again, we need a check and a useful error message, otherwise people will keep wasting hours or days on this  :)

@enn-nafnlaus , hey, a PR for this just merged. Please let us know how it works.
https://github.com/OpenAccess-AI-Collective/axolotl/pull/221


Better to use osu!standard hit windows instead of generic hit windows?

Since this game mode is conceptually similar to osu!standard, I think it would be better to grab the hit window from there instead (class OsuHitWindow). What do you think?

Personally, I've thought of it being more like 8k mania, and mania has 5 hit windows (rainbow, 300, 200, 100, 50), while std only has 3 (300, 100, 50).

It's similar in controls sure, but the game mechanics are entirely different, and I find it very hard to hold accuracy when playing. Also, mania has less things to keep track of visually, while this has around the same mental load as osu!standard. That's why i propose changing the hit window to osu!standard.
Anyway, feel free to ignore this if you want, I still have a lot of fun playing this nonetheless.

👍 Yeah ok, I'll add a mod for this if a few more people say the same thing (or whenever I find the time to). Just a little surprising to me haha, since I thought this game mode would appeal more to the mania type players.

Just so you know, I'm a top mania player 😊
Anyway, in osu!mania, there's not much on the screen aside from notes falling down, so the timings can be very tight and it's still playable. This ruleset however is comparable to osu!standard in terms of information to process, and the fixed keybinds don't really make it any easier to play. That's why I proposed changing the hit window to osu!standard hit windows

Interesting, that makes sense (for reference, I do not play mania LOL).
On a side note,

the fixed keybinds don't really make it any easier to play.

This was mentioned in #175 as well, and keybinds should be changeable. Are the soyokaze! keybinds not showing up in the keyboard settings? Maybe I should mention on the README where to find these settings.

It does show up for me in the centralized binding settings


Handle changing symmetries in VASP

During a geometry optimization or frequency calculation, the symmetry of the cell can change.
When symmetry-reduction is active, the number of reduced k-point can change by ionic update.
This causes errors when reshaping eigenvalues extracted from the OUTCAR, which are contingent on the (original) no. irreducible k-points:
"root":{
  "event":string"Error reading eigenvalues"
  "proc":string"Entry"
  "process":string"process_entry"
  "process_worker_id":string"QrhFb34pRf6tYAkBJQqhpQ"
  "parser":string"parsers/vasp"
  "step":string"parsers/vasp"
  "logger":string"nomad.processing"
  "timestamp":string"2023-08-17 16:19.03"
  "level":string"ERROR"
}

The frequency calculation that brought this error to light: trash:///freqsafd_pbe.zip

Note: when the ionic positions are updated and the main file is vasprun.xml, the <kpoints> should be derived from <calculations>, else from the "standalone" tag (under <modeling>).

This is apparently a new VASP feature (as of version 6?), so especially with vasprun.xml one has to distinguish between the placement of <kpoints>: under modeling or calculation (only in newer versions, not sure about the single-point case).

Correction, the cause is not the VASP version, but the routines chosen to perform frequency / phonon calculations.
I came to this conclusion after finding another example that uses IBRION = 6: entry_id = y0MhHRV_TIb_zamDSdM2QB6o84bF


polyserve failed on cygwin, win7

frren@FRREN-CN ~/git/codelab-components
$ polyserve
C:\Users\frren\AppData\Roaming\npm\node_modules\polyserve\bin\polyserve:14
const resolve = require('resolve');
^^^^^
SyntaxError: Use of const in strict mode.
at exports.runInThisContext (vm.js:73:16)
at Module._compile (module.js:443:25)
at Object.Module._extensions..js (module.js:478:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Function.Module.runMain (module.js:501:10)
at startup (node.js:129:16)
at node.js:814:3

Please file this against polyserve.

Didn't thought of there would be a polyserve project... Here it goes, https://github.com/PolymerLabs/polyserve/issues/42
(Nice number, 42 :)


fix(obstacle_stop_planner): change polygon creating method

Description

If the use_predicted_objects true there was a bug. If the obstacle left of the trajectory, stop planner founds an intersection and send stop. To fix this, I changed polygon creating method, and also it removes the opencv lib dependency.

In the picture, as you can see that although obstacle is outside of the trajectory, obstacle_stop_planner assumes there is an obstacle on the path. While using predicted_objects, node checks there is intersection between vehicle footprint and obstacle polygon. Before this PR, while creating polygon, checking polygon direction is unobserved. Because the direction is not determined, bg::intersects returns false positive while obstacle is left of the trajectory.
Tests performed

Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@brkay54 Thanks you. I'll review this.
Are you eady for review?

@satoshi-ota Yes, it is ready for review.

@brkay54 This PR loogs good. And, I'm going to test by TIER IV internal senarios.
By the way, I was hoping you could explain briefly where the bug code is :pray:
And, I think it is better to update PR title fix(obstacle_stop_planner): ~ if this is a bug fix PR.

@satoshi-ota Thank you for reply. There are a lot of bugs for using predicted object option and I am currently working on this. I am going to open another PR for fixing other bugs and some improvements. This PR just fixes the problem that occurred while creating polygons. I gonna add brief explanation for bug and change the name of PR.

@brkay54 I confirmed this PR doesn't cause any regression. I'll aprove.
And, could you fill Tests performed (just paste movie is OK) and Effects on system behavior in PR description?


Add Mouse: Logitech G Pro Mouse

Expected behavior:

Logitech G Pro Mouse isn't listed in the available and supported mice.
Actual behavior:

Eh... I guess have it listed?
How often does this problem occur?

This problem occurs... (Fill in here)
It's a feature/enhancement request
Please describe the steps to reproduce this issue:
N/A
What is the version of Aurora you are experiencing this issue with?

v0.6.4b
Does the previous version of Aurora have this issue?
N/A
Please include any logs, screenshots, or files that are related to this issue:
N/A but if one of the listed Logitech mice will work let me know which one will map properly.  I don't know if the G900 or the G502 will actually map properly.
EDIT: Looks like it is "working" but I have no way to verify if it is working properly.  If you can advise me on which supported games that Aurora can map over supported mouse -> mouse lighting for let me know and I'll try to check it.  I actually set it on Generic for now.

If it works as generic it should work the same for everything. If it doesn't light up on games then the problem might be aurora connecting to that game, and not aurora connecting to the mouse.


Check links in src/*.md files

This should help to avoid problems like #478

Oops, it looks like this is already covered by mdbook-linkcheck


issue149 Do no show creation of an executor in the doc examples

#149
This PR follows up on https://github.com/eclipse/microprofile-lra/pull/150 which was merged before Clement had the opportunity to contribute (sorry @cescoffier )
The change request was to not show the creation of a thread pool in the example (since thread pools are normally managed by the container).

@cescoffier I added your AWS S3 example, thanks


Introduce chain api helpers

E.g. last_finalized_block, get_genesis_hash, get_blocks. I think these are standard functionalities and should be offered by the api-client.
See worker implementation: https://github.com/integritee-network/worker/blob/master/core-primitives/node-api/api-client-extensions/src/chain.rs

The implementation of get_blocks is complicated by the fact that BlockNumber is not necessarily a number. We cannot easily create a Range from it. See:
https://github.com/integritee-network/worker/blob/6c84d2c76c13be162afe2607d1a1ef5b01707c6f/core-primitives/node-api/api-client-extensions/src/chain.rs#L77
Some options:

Restrict BlockNumber to implement the Step trait (nightly only feature)
Pass in a slice of BlockNumber instead of start/end
I think I would go for the slice as it allows for different use cases as well. @haerdib What do you think?

Yes, I'd also vote for the slice. I'd rather not enforce more traits than substrate does, as this would risk incompatibility in some cases.


refactor: treat Clock, Telemetry and TypeManager as standard services

What this PR changes/adds
Clock, Telemetry and TypeManager were registered in a special way into the DefaultServiceExtensionContext, that made more complicate to understand their behavior, and caused some test to have a special extension class (look at TypeManagerDependencyInjectionExtension.java that has been deleted indeed).
This PR registers them in a BootServicesExtension class.
The respective get methods in ServiceExtensionContext have been deprecated.
Why it does that
simplicity
Further notes

made DependencyInjectionExtensions register by default the requested services as mocks, this would avoid the need to explicitly define mocked services when testing extension classes (that was pretty annoying).
to do that I refactored (and completed its test coverage) InjectorImpl, to accept in construction a function that return a default service instance giving its type, this simplified logic as well.
removed  getFeatureName method/featureString field from FieldInjectionPoint as they were unused

Linked Issue(s)
Closes #2376
Checklist

[x] added appropriate tests?
[x] performed checkstyle check locally?
[x] added/updated copyright headers?
[x] documented public classes/methods?
[x] added/updated relevant documentation?
[x] assigned appropriate label? (exclude from changelog with label no-changelog)
[x] formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

Codecov Report
Base: 64.71% // Head: 64.67% // Decreases project coverage by -0.05% :warning:

Coverage data is based on head (5d2b618) compared to base (8d305d4).
Patch coverage: 47.76% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2412      +/-   ##
==========================================
- Coverage   64.71%   64.67%   -0.05%
==========================================
  Files         845      846       +1
  Lines       17518    17495      -23
  Branches     1057     1056       -1
==========================================
- Hits        11337    11315      -22
- Misses       5743     5744       +1
+ Partials      438      436       -2

Impacted Files
Coverage Δ

...va/org/eclipse/edc/boot/BootServicesExtension.java
0.00% <0.00%> (ø)

...ipse/edc/connector/core/CoreServicesExtension.java
93.75% <ø> (-0.19%)
:arrow_down:

...junit/extensions/DependencyInjectionExtension.java
0.00% <ø> (ø)

.../edc/connector/transfer/TransferCoreExtension.java
0.00% <ø> (ø)

...e/framework/DataPlaneDefaultServicesExtension.java
0.00% <0.00%> (ø)

...ipse/edc/protocol/ids/IdsCoreServiceExtension.java
0.00% <0.00%> (ø)

...va/org/eclipse/edc/web/jersey/JerseyExtension.java
100.00% <ø> (ø)

...service/DecentralizedIdentityServiceExtension.java
0.00% <0.00%> (ø)

...a/org/eclipse/edc/iam/did/web/WebDidExtension.java
0.00% <0.00%> (ø)

.../eclipse/edc/iam/oauth2/Oauth2ClientExtension.java
0.00% <0.00%> (ø)

... and 47 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


tauri-runtime-wry still used win32 feature flag

Wry did remove support for winrt: https://github.com/tauri-apps/wry/commit/c37973e47318e9cff2712eb4a394c07734f58d54
and there fore the flagh win32 was removed.
tauri-runtime-wry still uses this flag:
https://github.com/tauri-apps/tauri/blob/70a1941468f55f0dc09ac2e13802945891d766f4/core/tauri-runtime-wry/Cargo.toml#L15

Hi there,
It'll be fixed on the next wry release.  Hopefully in the next day(s)...
Actually, the tauri dev branch is locked to wry 0.11 and still has the win32 flag.
Thanks for pointing it up!

i do use a wry patch on my end (fixing the flicker https://github.com/tauri-apps/wry/commit/e28bcce0884937365013fda3098f64f9956d569f)
but changed to dev branch because the PR was completed.
But i change to rev patch instead!


Correct URL in README

Just noticed that the package control URL was broken in the README :)

Thanks!


Add upsert and insert graph options in params

This patch allow for query based insert and upsert graph options
Typical use case is to have different options based on authenticated user rights

Thanks @Thomas-git , released in 7.5.0


add new strings about streaming and permissions on EO, ZH-CN/TW

Thank you for the additions!

Thank you for the additions!


Update deps

:tada: This PR is included in version 8.1.0-develop.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 8.2.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 8.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


collect metrics from "bmc getsysinfo system_fw_version"

Hi, I'd like to collect the BIOS version from IPMI.
I tried to add code by myself.
However, I am not familiar with golang so that but I couldn't make packages.
Could you add the feature please ?
ISSUE TYPE

Enhanced

HOW TO GET THE INFO
ipmitool bmc getsysinfo system_fw_version
SAMPLE COMMAND OUTPUT
 $ ipmitool -H <target host> -I lanplus -U <user> -P <password> bmc getsysinfo system_fw_version
  Version1.0

In most cases, the return value is "strings". not integer.
METRICS EXAMPLE
# HELP ipmi_bmc_sysinfo Constant metric with value '1' providing details about the BMC.
# TYPE ipmi_bmc_sysinfo gauge
ipmi_bmc_sysinfo{system_fw_version="Version 1.0"} 1

Or, could you check my code and teach me how to modify the code please ?
https://github.com/soundcloud/ipmi_exporter/pull/52

Hi, thanks for the request, this seems like good information to export. It can actually be done much simpler than in the PR you provided. I will take a look at this in the next days.

Hey there,
sorry, not exactly "the next days", but you know... So, this is now on master, if you can run that I'd be happy to hear if it works for you. I'll also prepare the next release soon, but there are a few more things I'd like to add before that.

Hi, I'm sorry for too late reply.
I found that it work well. thank you so much!

I'm sorry for too late reply.
I found the new key in latest version.
However, It shows as below ,even bmc getsysinfo system_fw_version works well.
ipmi_bmc_info{firmware_revision="x.xx",manufacturer_id="Our vender name.",system_firmware_version=""} 1

I'll check our systems and I'll open the Issue in case I found the cause in codes.
Thank you so much!


refactor: rename Zone 'BLACK_LISTED_EVENTS' to 'UNPATCHED_EVENTS'

related to this one, https://github.com/angular/angular/pull/29617
After zone.js upgrade to 0.9.0, we rename BLACK_LISTED_EVENTS to UNPATCHED_EVENTS, but we still support BLACK_LISTED_EVENTS for backward compatibility.

Actually, with beta.10, the framework has updated to use zone 0.9.0


Where is org.springframework.web.reactive.function.server.router?

I'm new to here, and I follow the README.md guide, when I execute gradle build or gradle bootRun, I got the compiled error, like below:

So,  where is org.springframework.web.reactive.function.server.router ? Thanks!

Sorry about that Spring Framework snapshots are not built for a week due to an issue on our build server, it will be fixed shortly I will warn you.

Understand, and thanks in advance!

Snapshots are back, it should work again now.


Hello, may be a new version is needed, thanks

v2.0.2 has some bugs sometimes, if a json file is too big(50 thousands or more lines), it always loading... when I choose a small json file, it still loading. I need to close VS Code, then it works. In addition, display of the number of member in json object is very useful for me.

can we get a new version? the latest version is two years old.


bug: ShapeTree.title calls ph_idx  on non-placeholder shapes

Hi, I'm trying to read the title from this file: https://www.dropbox.com/s/2q3m0hpzrxum8mj/CommuniKate20-es.pptx?dl=0
with this code:
#!/usr/bin/python
from pptx import Presentation

prs = Presentation("testSuite/test1/CommuniKate20-es.pptx")

for slide in prs.slides:
    title_placeholder = slide.shapes.title
    print "New Slide!"

but I get this ValueException immediately... :s
'''
Traceback (most recent call last):
File "./reduce.py", line 8, in
title_placeholder = slide.shapes.title
File "/Library/Python/2.7/site-packages/python_pptx-0.5.7-py2.7.egg/pptx/shapes/shapetree.py", line 226, in title
if elm.ph_idx == 0:
File "/Library/Python/2.7/site-packages/python_pptx-0.5.7-py2.7.egg/pptx/oxml/shapes/shared.py", line 77, in ph_idx
raise ValueError("not a placeholder shape")
ValueError: not a placeholder shape
'''
Bit confused, as the code was copied from https://www.dropbox.com/s/xuvhyzo26gfqtun/Screenshot 2015-03-21 14.28.08.png?dl=0  - have I just muddled myself up or does this look like a bug? (either in the code or the docs...)
Awesome tool by the way - saved me hours and hours so far... just finishing this script would be amazing...
J

Hi Joe, yes, this actually does look like a bug. Line 225 in pptx/shapes/shapetree.py should be:
for elm in self._spTree.iter_ph_elms():

instead of:
for elm in self._spTree.iter_shape_elms():

You can work around this by adding your own title placeholder function like this:
def slide_title_placeholder(slide):
    for shape in slide.shapes:
        if not shape.is_placeholder:
            continue
        if shape.placeholder_format.idx == 0:
            return shape
    return None

Keep in mind this function can return None because not all slides necessarily have a title placeholder.
I'll leave this issue open as a bug report to get this fixed up.

Workaround worked perfectly :)

Fixed in v0.5.8.


ReadinessNode and ReadinessQueueInner leak due to a reference cycle

There's a logical reference cycle between ReadinessNode and ReadinessQueueInner.
First, every ReadinessNode registered to some queue has a clone of the Arc (referenced via an AtomicPtr). It is kept even after the node is deregistered.
Second, the queue always holds a logical reference to every ReadinessNode registered with it (extra 1 in ref_count). This one is also kept even after the node is deregistered.
The Drop impl for ReadinessQueueInner attempts to break this reference cycle, but ReadinessQueueInner::drop cannot run until the nodes are already released. Furthermore, it releases only the nodes that are in the readiness queue, but some of them may be absent from it at the moment of dropping.
Tested using tokio-core with the following test, which leaks a ReadinessQueueInner, several ReadinessNodes and two file descriptors on every iteration, running into the default file descriptor limit of 1024 and breaking.
#[test]
fn tokio_fd_leak() {
    let handle = thread::spawn(move || {
        for _ in 0..1000 {
            println!("Starting loop...");
            let core = tokio_core::reactor::Core::new().unwrap();
        }
    });
    handle.join().unwrap();
}

Oh dear sounds bad! Thanks for the report!


Quick start for GPU version:

I got an error after using the command:
docker pull lukalabs/cakechat-gpu:latest && \
nvidia-docker run --name cakechat-gpu-server -p <IP_ADDRESS>:8080:8080 -it lukalabs/cakechat-gpu:latest bash -c "CUDA_VISIBLE_DEVICES=0 python bin/cakechat_server.py"

Output:
2019-08-18 14:09:11.496399: W tensorflow/core/common_runtime/bfc_allocator.cc:271] ***************************************************************************************xxxxxxxxxxxxx
2019-08-18 14:09:11.496449: W tensorflow/core/framework/op_kernel.cc:1273] OP_REQUIRES failed at random_op.cc:202 : Resource exhausted: OOM when allocating tensor with shape[50000,128] and type float on /job:localhost/replica:0/task:0/device:GPU:0 by allocator GPU_0_bfc
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1334, in _do_call
    return fn(*args)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1319, in _run_fn
    options, feed_dict, fetch_list, target_list, run_metadata)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1407, in _call_tf_sessionrun
    run_metadata)
tensorflow.python.framework.errors_impl.ResourceExhaustedError: OOM when allocating tensor with shape[768,2304] and type float on /job:localhost/replica:0/task:0/device:GPU:0 by allocator GPU_0_bfc
	 [[{{node decoder_scope/decoder_1/random_uniform/RandomUniform}} = RandomUniform[T=DT_INT32, dtype=DT_FLOAT, seed=87654321, seed2=5561963, _device="/job:localhost/replica:0/task:0/device:GPU:0"](decoder_scope/decoder_1/random_uniform/shape)]]
Hint: If you want to see a list of allocated tensors when OOM happens, add report_tensor_allocations_upon_oom to RunOptions for current allocation info.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "bin/cakechat_server.py", line 11, in <module>
    from cakechat.api.v1.server import app
  File "/root/cakechat/cakechat/api/v1/server.py", line 3, in <module>
    from cakechat.api.response import get_response
  File "/root/cakechat/cakechat/api/response.py", line 14, in <module>
    _cakechat_model = get_trained_model(reverse_model=get_reverse_model(PREDICTION_MODE))
  File "/usr/local/lib/python3.5/dist-packages/cachetools/__init__.py", line 46, in wrapper
    v = func(*args, **kwargs)
  File "/root/cakechat/cakechat/dialog_model/factory.py", line 76, in get_trained_model
    model.init_model()
  File "/root/cakechat/cakechat/dialog_model/keras_model.py", line 30, in wrapper
    return func(*args, **kwargs)
  File "/root/cakechat/cakechat/dialog_model/keras_model.py", line 279, in init_model
    self.print_weights_summary()
  File "/root/cakechat/cakechat/dialog_model/keras_model.py", line 30, in wrapper
    return func(*args, **kwargs)
  File "/root/cakechat/cakechat/dialog_model/keras_model.py", line 263, in print_weights_summary
    weights = self._model.get_weights()
  File "/usr/local/lib/python3.5/dist-packages/keras/engine/network.py", line 492, in get_weights
    return K.batch_get_value(weights)
  File "/usr/local/lib/python3.5/dist-packages/keras/backend/tensorflow_backend.py", line 2420, in batch_get_value
    return get_session().run(ops)
  File "/usr/local/lib/python3.5/dist-packages/keras/backend/tensorflow_backend.py", line 206, in get_session
    session.run(tf.variables_initializer(uninitialized_vars))
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 929, in run
    run_metadata_ptr)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1152, in _run
    feed_dict_tensor, options, run_metadata)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1328, in _do_run
    run_metadata)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1348, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.ResourceExhaustedError: OOM when allocating tensor with shape[768,2304] and type float on /job:localhost/replica:0/task:0/device:GPU:0 by allocator GPU_0_bfc
	 [[node decoder_scope/decoder_1/random_uniform/RandomUniform (defined at /usr/local/lib/python3.5/dist-packages/keras/backend/tensorflow_backend.py:4139)  = RandomUniform[T=DT_INT32, dtype=DT_FLOAT, seed=87654321, seed2=5561963, _device="/job:localhost/replica:0/task:0/device:GPU:0"](decoder_scope/decoder_1/random_uniform/shape)]]
Hint: If you want to see a list of allocated tensors when OOM happens, add report_tensor_allocations_upon_oom to RunOptions for current allocation info.

Caused by op 'decoder_scope/decoder_1/random_uniform/RandomUniform', defined at:
  File "bin/cakechat_server.py", line 11, in <module>
    from cakechat.api.v1.server import app
  File "<frozen importlib._bootstrap>", line 969, in _find_and_load
  File "<frozen importlib._bootstrap>", line 958, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 665, in exec_module
  File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
  File "/root/cakechat/cakechat/api/v1/server.py", line 3, in <module>
    from cakechat.api.response import get_response
  File "<frozen importlib._bootstrap>", line 969, in _find_and_load
  File "<frozen importlib._bootstrap>", line 958, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 665, in exec_module
  File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
  File "/root/cakechat/cakechat/api/response.py", line 14, in <module>
    _cakechat_model = get_trained_model(reverse_model=get_reverse_model(PREDICTION_MODE))
  File "/usr/local/lib/python3.5/dist-packages/cachetools/__init__.py", line 46, in wrapper
    v = func(*args, **kwargs)
  File "/root/cakechat/cakechat/dialog_model/factory.py", line 76, in get_trained_model
    model.init_model()
  File "/root/cakechat/cakechat/dialog_model/keras_model.py", line 30, in wrapper
    return func(*args, **kwargs)
  File "/root/cakechat/cakechat/dialog_model/keras_model.py", line 277, in init_model
    self._model = self._build_model()
  File "/root/cakechat/cakechat/dialog_model/model.py", line 253, in _build_model
    decoder_training_model, decoder_model = self._decoder(y_tokens_emb_model, condition_emb_model)
  File "/root/cakechat/cakechat/dialog_model/model.py", line 412, in _decoder
    (outputs_seq_0, initial_state=dec_hs_1)
  File "/usr/local/lib/python3.5/dist-packages/keras/layers/recurrent.py", line 570, in __call__
    output = super(RNN, self).__call__(full_input, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/keras/engine/base_layer.py", line 431, in __call__
    self.build(unpack_singleton(input_shapes))
  File "/usr/local/lib/python3.5/dist-packages/keras/layers/cudnn_recurrent.py", line 237, in build
    constraint=self.kernel_constraint)
  File "/usr/local/lib/python3.5/dist-packages/keras/legacy/interfaces.py", line 91, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/keras/engine/base_layer.py", line 249, in add_weight
    weight = K.variable(initializer(shape),
  File "/usr/local/lib/python3.5/dist-packages/keras/initializers.py", line 218, in __call__
    dtype=dtype, seed=self.seed)
  File "/usr/local/lib/python3.5/dist-packages/keras/backend/tensorflow_backend.py", line 4139, in random_uniform
    dtype=dtype, seed=seed)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/random_ops.py", line 243, in random_uniform
    rnd = gen_random_ops.random_uniform(shape, dtype, seed=seed1, seed2=seed2)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/gen_random_ops.py", line 733, in random_uniform
    name=name)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/op_def_library.py", line 787, in _apply_op_helper
    op_def=op_def)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/util/deprecation.py", line 488, in new_func
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/ops.py", line 3274, in create_op
    op_def=op_def)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/ops.py", line 1770, in __init__
    self._traceback = tf_stack.extract_stack()

ResourceExhaustedError (see above for traceback): OOM when allocating tensor with shape[768,2304] and type float on /job:localhost/replica:0/task:0/device:GPU:0 by allocator GPU_0_bfc
	 [[node decoder_scope/decoder_1/random_uniform/RandomUniform (defined at /usr/local/lib/python3.5/dist-packages/keras/backend/tensorflow_backend.py:4139)  = RandomUniform[T=DT_INT32, dtype=DT_FLOAT, seed=87654321, seed2=5561963, _device="/job:localhost/replica:0/task:0/device:GPU:0"](decoder_scope/decoder_1/random_uniform/shape)]]
Hint: If you want to see a list of allocated tensors when OOM happens, add report_tensor_allocations_upon_oom to RunOptions for current allocation info.

But cpu version is ok.

@xandyxor The first line of output reads "Resource exhausted: OOM when allocating tensor with shape[50000,128] and type float".
OOM stands for "Out of memory". What is the size of RAM on your GPU?
In order to decrease memory usage you may set lower params OUTPUT_SEQUENCE_LENGTH and SAMPLES_NUM_FOR_RERANKING in config file.
See a similar issue: https://github.com/lukalabs/cakechat/issues/66


Correction for raw affiliation CBGP, INRAE, CIRAD, IRD, Institut Agro Montpellier, Univ. Montpellier, Montpellier, France

Correction needed for raw affiliation CBGP, INRAE, CIRAD, IRD, Institut Agro Montpellier, Univ. Montpellier, Montpellier, France
raw_affiliation_name: CBGP, INRAE, CIRAD, IRD, Institut Agro Montpellier, Univ. Montpellier, Montpellier, France
new_rors: 03rnk6m14;003vg9w96;05kpkpg04;051escj72;05q3vnk25;05h7ddb14
previous_rors: 03rnk6m14;003vg9w96;05kpkpg04;051escj72;05q3vnk25
works_examples: W4400048098
contact: 214121fc6ba4e416d891907cd0803a8e:3cbeec0b00b47e7966dc53be035792e7c65d @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-18. The new affiliations should be visible within the next 7 days.


fix misleading 'Using the default environment' message

The logic to determine whether to show you the "Using the default environment, which is now production" message would show you the message even if you had one or more - just not all - variables set in your local environment. Now the message will only display if you have none of the variables set, which is how it should be when building for production.
@gniezen please review and update your #251 accordingly.
CC @darinkrauss

LGTM :shipit:

 [uploader] fix misleading message re: building for production

LGTM too, merging.


OU-446: Support FIPS

This PR looks to add FIPS support. It updates the go version to 1.22, and uses recommended FIPS compliant images and tags. Due to some of the recommended images not being available publicly a Dockerfile.dev is added to the repo as a way to build and test images locally.

/lgtm


Support git format-patch diffs

git format-patch uses --- to separate the commit body from the changes overview.
This parser expects that to be part of an old_file node and returns an error.
Here's a random kernel patch and the syntax tree it produces:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/patch/?id=da3b1c2
source [0, 0] - [36, 0]
  context [0, 0] - [0, 70]
  context [1, 0] - [1, 33]
  context [2, 0] - [2, 36]
  context [3, 0] - [3, 71]
  context [4, 0] - [4, 21]
  context [6, 0] - [6, 63]
  context [7, 0] - [7, 67]
  context [8, 0] - [8, 7]
  context [10, 0] - [10, 102]
  context [11, 0] - [11, 42]
  context [12, 0] - [12, 39]
  context [13, 0] - [13, 67]
  context [14, 0] - [14, 44]
  ERROR [15, 0] - [15, 3]
  context [16, 0] - [16, 77]
  context [17, 0] - [17, 46]
  command [19, 0] - [19, 154]
    filename [19, 11] - [19, 154]
  index [20, 0] - [20, 41]
    commit [20, 6] - [20, 19]
    commit [20, 21] - [20, 34]
    mode [20, 35] - [20, 41]
  old_file [21, 0] - [21, 75]
    filename [21, 4] - [21, 75]
  new_file [22, 0] - [22, 75]
    filename [22, 4] - [22, 75]
  location [23, 0] - [23, 29]
    linerange [23, 3] - [23, 8]
    linerange [23, 9] - [23, 14]
  context [24, 0] - [24, 64]
  context [26, 0] - [26, 18]
  deletion [27, 0] - [27, 22]
  addition [28, 0] - [28, 28]
  context [29, 0] - [29, 17]
  context [31, 0] - [31, 10]
  context [32, 0] - [32, 3]
  context [33, 0] - [33, 5]

This grammar focuses only on diff syntax. Patch syntax should be covered in a separate grammar which injects this diff grammar.

Patch syntax is diff syntax with --- in a context line.

I can't find a formal definition for patch and/or diff

GNU diffutils supports several distinct formats:

normal (default)
unified (used by git)
context (common)
side by side (very rare)
ed script (almost obsolete)
RCS script (does anyone use this?)

Ideally, this parser would handle the first three formats. (maybe in separate grammars?)

My understanding is that patch syntax is a superset of diff

I suppose you're right as per the Kernel documentation.
It's in fact a combination of mbox and unified diff.

There is no way to not handle part of a document with tree-sitter

I know, but you can parse the --- marker as a context node to avoid the error.
At least until someone (maybe me?) writes a grammar for the patch format.

Yeah, the error node should be cleaned up. I have fixed the parsing to produce a deletion node though rather than context in 6d7c499bc4d26cdc527ddc2d0026d23aac14f97a, since --- may mark the deletion of a line containing only "--".
I don't use patch format myself so I am uninterested in maintaining a grammar for it. This grammar should serve as a decent example if you would like to tackle it yourself though.


Fix paralle's subcommand for zsh as default shell

parallel will run the subcommand using $SHELL. So the parallel command
line, double-quoted string, will be substituted twice, one by bash (the
script shell) and one by $SHELL.
However, zsh and bash have different string substitution behavior -- zsh
will substitute "$^" but bash won't.
Change to use single quote string.
$ echo foo | SHELL=/bin/bash parallel echo "\$^"
$^ foo
$ echo foo | SHELL=/bin/zsh parallel echo "\$^"
foo
$ echo foo | SHELL=/bin/zsh parallel echo '\$^'
$^ foo

Thanks for the patch!


Regex Doesn't support specified number of characters {n}

The bug
Regex doesn't seem to support basic regex syntax. {n}
To Reproduce
Give a full working code snippet that can be pasted into a notebook cell or python file. Make sure to include the LLM load step so we know which model you are using.
# put your code snippet here
from guidance import models, gen

# Load a HuggingFace Transformers model
lm = models.Transformers("gpt2")

lm = lm + 'Generate a phone number: ' + gen(regex='\d{3}-\d{3}-\d{4}')
print(lm)
#  Generate a phone number: 1{3}-8{3}-8{4}

System info (please complete the following information):

OS (e.g. Ubuntu, Windows 11, Mac OS, etc.): Ubuntu
Guidance Version (guidance.__version__): 0.1.5

This is a limitation of the pyformlang library we are using right now to convert from regex patterns into guidance grammars. We don't plan to keep this dependency in the long run, so will leave this issue open to flag that {n} support should be in the next iteration :)


 Closing and reopening it did not change it.  I have not been able to recreate it. I had never seen it before I used the gpu code. This was on windows10.

@ahopper have you had this happen recently?

I've not seen this again and have run with gpu quite a lot even though it is off by default on windows so I'll close it.

I'm seeing this problem too, A very simple Popup or a PopupRoot render black on Windows 10. Not sure how can I help troubleshooting the problem.


How to retrieve data from a pivot table?

I want to get the data from a database and export to excel, is there any way?

@samaslima that's quite simple:) I have 2 ways to do that:

The simplest way to get excel with data without any styles:

worksheet.columns = [
  { header: 'Id', key: 'id', width: 10 },
  { header: 'Name', key: 'name', width: 32 },
  { header: 'D.O.B.', key: 'DOB', width: 10, outlineLevel: 1 }
];

data.forEach(function(e){worksheet.addRow(e);});

More complex, with styles by using BETA version of my library (based on exceljs): https://github.com/Siemienik/xlsx-renderer/

import Renderer from 'xls-renderer/lib/xls-renderer/Renderer';
import CellTemplatePool from 'xls-renderer/lib/xls-renderer/CellTemplatePool';
import {Workbook} from 'exceljs'

   const renderer = new Renderer(new CellTemplatePool());

    const data = itemService.getAll()

    const result = await renderer.render(async () => {
            const template = new Workbook();
            return await template.xlsx.readFile('./my-awesome-raport-template.xlsx');
        }, data);

    await result.xlsx.writeFile('./my-awesome-raport.xlsx');

this solution get your template my-awesome-raport-template.xlsx what was made in excel, and render output based on them.
For example this template file:

gives:


Improve GCE encryption speed by 10x

It turns out that the IOPS available to a VM are based on
the aggregate (or perhaps largest) drive attached to the VM.
We are bottlenecked on GCE by the speed of the dd src dest
where both src and dest are smallish (10-20G) drives.
By attaching (but not using) a large drive to the encryptor
instance results in more IOPS (typically 10x) available for
both the src and dest drives.

👍


FullTextIndex missing ExcludeObjectTypes list?

Hello!  Thank you for building such a great tool!
Both FullTextCatalogs and FullTextStoplists are in the ExcludeObjectTypes list; however it appears that FullTextIndexes are not:
*** Argument 'ExcludeObjectTypes' has an invalid value: 'FullTextIndexes'.
Is there something I overlooked or missing?

Hi @MikeMcWilliams, do you mind referencing the article in question?

Hi @MikeMcWilliams, I'm closing this issue because we haven't heard from you. If that changes, please feel free to respond below.


I got an error on my GitHub GDS action

Link to your wokwi project
https://github.com/mmolteni-secpat/tinytapeout02_chi3shares/actions

https://tinytapeout.com/faq/#my-github-action-is-failing-on-the-pages-part


enumerateStaticDependencies should not be called on CleanDependencies()

overrides of enumerateStaticDependencies might be used to create and configure a static dependency, which would get recreated during cleaning steps for dynamically launched dependencies.
Fix: remove need to call the enumeration on dependency stopped event (Clean Dependencies)

fixed in 1.2.1 release


Dead downloads

Dropbox link is dead in addition to http://kypapps.co.cc/. Working download to built program:
https://drive.google.com/file/d/1HxVeK4bPMPX-GGIPBEaSUuVpzVupjAPc/view?usp=sharing

Thanks for this!


firebase_core not found for flutter_web (Flutter 1.9)

I upgraded my flutter to 1.9, and trying out flutter-web for an existing project. Got stuck at "firebase_core" is not found error  anyone experiencing the same issue ? Here's error:
i$ flutter run -d Chrome
Launching lib/main.dart on Chrome in debug mode...
Skipping compiling flutter_widgets|lib/main_web_entrypoint.dart with ddc because some of its
transitive libraries have sdk dependencies that not supported on this platform:
firebase_core|lib/firebase_core.dart

Existing Flutter plugins do not yet work on the Web. One workaround is to create an abstraction over Firebase and use different implementations, one for mobile (such as firebase_core) and one for web (such as firebase).
/cc @mit-mit this is another signal that we need to teach pub to surface which platforms are supported by which plugins. The issue will become even more acute with the Web and desktop in the mix.

/cc @hterkelsen in you case you have a better answer

Here is what i am doing to use the native SDKs: https://stackoverflow.com/a/57979044/7303311
Here s the article i did<EMAIL_ADDRESS>You have to use conditional imports.
If you want to use Firebase auth on web and mobile i created a package that does this for you with the official SDKs: https://pub.dev/packages/fb_auth
Let me know if you have any questions

Thanks Rody for the pointers. I see https://pub.dev/packages/fb_auth uses
Bloc, and example is also based on Bloc pattern. Could you explain how
could I use this plug-in for Provider pattern ?
On Tue, 17 Sep 2019 at 11:29, Rody Davis<EMAIL_ADDRESS>wrote:

Here is what i am doing to use the native SDKs:
https://stackoverflow.com/a/57979044/7303311
Here s the article i did:
<EMAIL_ADDRESS>You have to use conditional imports.
If you want to use Firebase auth on web and mobile i created a package
that does this for you with the official SDKs:
https://pub.dev/packages/fb_auth
Let me know if you have any questions
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/40360?email_source=notifications&email_token=AFZNNNME3EIAVYRPNRN5FPLQKEOZ7A5CNFSM4IWGEZ3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD65OZXY#issuecomment-532344031,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFZNNNJC35FASLHHBCH75JDQKEOZ7ANCNFSM4IWGEZ3A
.

The bloc part is purely optional and not needed to use the plugin, I just include it to simply all the logic usually around auth.
You can call the plugin directly with FBAuth.login() and other calls!

Cool. Thank you!
On Tue, Sep 17, 2019, 1:52 PM Rody Davis<EMAIL_ADDRESS>wrote:

The bloc part is purely optional and not needed to use the plugin, I just
include it to simply all the logic usually around auth.
You can call the plugin directly with FBAuth.login() and other calls!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/40360?email_source=notifications&email_token=AFZNNNMFO6OVLKEAZ3HU4ELQKE7RHA5CNFSM4IWGEZ3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD653UCA#issuecomment-532396552,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFZNNNMPH47Y6YMFWO6TZILQKE7RHANCNFSM4IWGEZ3A
.

@AppleEducate I got Firebase auth working on web. However no luck using cloud_firestore for Flutter web. It seems to have dependency on firebase_core|lib/firebase_core.dart, which is causing it to fail.

cloud_firestore is just for mobile, on web everything is in firebase, including firestore.
You will just import cloud_firestore on the mobile side. I will release a blog post soon

@AppleEducate I've written a plugin wrapper for mobile and web Firebase auth here. Usage example is in this project
I've created a generic user say MyAuthUser in wrapper to deal with web and mobile since both returns different data types (AuthUser for web, and FirebaseUser for mobile). Do you have a better idea to deal with this ?

Wow! This is great! Thanks for all this work!
I'm sure @collinjackson is going to love this too!

I also created a wrapper 😅
fb_auth that does the same thing!
https://pub.dev/packages/fb_auth

@ditman @collinjackson   We are using @AppleEducate 's fb_auth https://pub.dev/packages/fb_auth  in our web and mobile app.  So far it works great.  Hoping to get Firestore, Firebase Storage, and Functions working soon with both mobile and web.   Any thoughts, tips, or updates on these?   I know @AppleEducate is working on those too and also trying to get Google signin working for web.

I also created a wrapper 😅
fb_auth that does the same thing!
https://pub.dev/packages/fb_auth

@AppleEducate I created a wrapper for fb_auth with intention to add missing functionality around firestore, google-signin for web etc. Do you have an ETA for this to be included in  fb_auth. I would rather prefer waiting if it's around the corner :)

Oh yes! I’m planning on adding all the methods that are shared! And probably a week.
Feel free to make a PR too, I can add what you have so far 👍🏼

Hello all!
We still haven't landed on the exact approach on where to put the code for the web implementations of plugins, but it is likely that the current approach we're using will change a little bit.
There's currently talks on going to a "Federated" model, where plugins can be split across multiple packages, and any plugin author can "endorse" 3rd party implementations for platforms that they can't (or don't want to) build.
Here's a document discussing the federated approach: https://flutter.dev/go/federated-plugins . (The technical approach will result familiar because @hterkelsen did something similar to what is being proposed there for the current plugins for web implementation!)
I think the model above fits pretty well what we need to do for the Flutter for web plugins, but the plugins team is taking some time to make sure the transition is smooth for everybody (tooling, maintainability, currently open PRs, the works!)
As soon as the federated approach solidifies enough, we can answer the question of "How can I help you build this?". We'll probably prepare a writeup on "How to write plugins for Flutter for web", and push some of the ones that we've been working on so far (like the url_launcher or image_picker).
In the meantime, we'll have to live with the extra friction that is well documented on this ticket (and probably others). Hang in there!
Again, thanks for all the contributions! Keep them coming!

@ptyagicodecamp
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/1128. Any further collaboration will be done there.


Hangs encountered in IDAKLUJax unit tests (test_jacrev_vmap and others)

PyBaMM Version
develop
Python Version
3.11.8
Describe the bug
The test_jacrev_vmap test case in the TestIDAKLUJax class (present in tests/unit/test_solvers/test_idaklu_jax.py) hangs quite a lot during local development. It is one of the slowest tests to pass, to the point that coverage logging almost gets stuck indefinitely on 99% and that this test, in particular, takes time in several orders of magnitude more to complete when compared to the rest of the tests.
This is most likely coming from the recent migration to using pytest for running the unit tests (#3857), which also brought support for pytest-xdist for parallel execution of unit tests, where JAX-related unit tests take up a lot of time in CI in parallel mode.
Here's an SVG from a profiling sample with the pytest-profiling plugin from @prady0t earlier in the #infrastructure channel on Slack:

Expand to view

which reveals that something is up with the JAX-related tests.
Steps to Reproduce
There isn't a better reproducer at this time, but to reproduce one can run nox -s coverage or its pytest --cov equivalent in the root directory – it is a bit slower than nox -s unit, but both of them seem to have the same issue.
Relevant log output
No response

Temporary solution: wrap all classes and the methods with @pytest.mark.xdist_group(name="serial execution") to run them inside the same worker in serial mode.
This resolves the test_jacrev_vmap execution and it runs as normal – but test_jacrev_vector_getvars, and test_solver_ + test_solver_sensitivities from the JAX BDF solver are three other culprits which still aren't happy – they still take a lot longer than any other test. I assume we can extract more speedups with the newly enabled parallel testing, however, these test cases do not seem to budge and are causing bottlenecks. Maybe @jsbrittain would have some suggestions here?

To bring some rudimentary sense of the issue at hand, here's what I can see locally on an M-series macOS machine:
Running the entire coverage suite with the JAX tests included:
1596 passed, 2 skipped in 663.93s (0:11:03)

And running it again, except test_idaklu_jax.py and test_jax_bdf_solver.py brings 98% of the test suite to completion at just 87 seconds!

@agriyakhetarpal To me it looks like the functions in there are parallel. So parallel tests with parallel code means a ton of extra threads. On my Mac those tests seem to use 4 threads each

I want to help with this issue. Please let me know if you need another hand.

Thanks, @prady0t, well, it's really just the attempt in https://github.com/pybamm-team/PyBaMM/issues/3948#issuecomment-2028878236 that's helped with one out of the four tests, so we need to dig deeper since the tests are running in parallel which slows it down but also that they are really slow in serial execution too. I think this can be tackled at a later time since the tests pass, at least. I think you're doing #3940 with @lorenzofavaro and that is a higher-priority issue we need to tackle at this moment :)

Oops, I just realised that I mentioned and I tagged the wrong person, I am sorry. By all means, please feel free to help out here, @cringeyburger!

This was discussed in the GSoC meeting today for the pytest migration project and I don't seem to have this problem anymore with the recent update to jaxlib==0.4.27.
======================================================================= short test summary info ========================================================================
SKIPPED [1] tests/unit/test_expression_tree/test_operations/test_latexify.py:84: Only run for Linux
SKIPPED [1] tests/unit/test_solvers/test_idaklu_jax.py:91: Both IDAKLU and JAX are available
=================================================================== 1608 passed, 2 skipped in 56.63s ===================================================================
nox > Session unit was successful.

and the trio of test_jacrev_vmap, test_jacrev_vector_getvars, and test_solver_sensitivities runs without any hangs – neither of them seems to cause any troubles with my macOS machine. We should be in a position to close this for now, if someone else can confirm this by running a fresh nox -s unit, that would be great.

I don't think I have seen it recently either


⚠ Bofrost.at has degraded performance

In 55e5bff, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 819 ms

Resolved: Bofrost.at performance has improved in 33c860b after 13 minutes.


Links not rendered

URL of the docs page
https://docs.dapr.io/developing-applications/building-blocks/secrets/secrets-scopes/
How is it currently worded?
There is ]] in two links preventing them from rendering
How should it be worded?
]

Merged!


Avoid unuseful view state updates

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 69.795%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
933

Relevant Lines:
1250

💛  - Coveralls


Document usage of openshift_hosted_cluster_metrics feature

I tried to deploy openshift cluster metrics by setting node['cookbook-openshift3']['openshift_hosted_cluster_metrics]totrue`.
I encountered the following gotchas and bugs:

node['cookbook-openshift3']['openshift_hosted_metrics_parameters']['HAWKULAR_METRICS_HOSTNAME'] must be set explicitly (while we could default it to the value of node['cookbook-openshift3']['openshift_master_metrics_public_url'])
metrics do not deploy anymore unless node['cookbook-openshift3']['openshift_hosted_metrics_parameters']['IMAGE_VERSION'] is set to `v1.3.1'

Regarding the HAWKULAR_METRICS_HOSTNAME parameter, I believe we could default it to the value of node['cookbook-openshift3']['openshift_master_metrics_public_url'], eg:
default['cookbook-openshift3']['openshift_hosted_metrics_parameters'] = {}.tap do |parameters|
  parameters['HAWKULAR_METRICS_HOSTNAME'] = node['cookbook-openshift3']['openshift_master_metrics_public_url']
end

Regarding the IMAGE_VERSION parameter, I believe that it has the implicit value of 'latest' (which is v1.4.0 since this week). This cookbook implements the cluster metrics in a LWRP that follows the instructions for v1.3.x. As a consequence, some setup is missing, as shown by the logs of the my failed installation:
[root@default-centos-72 ~]# oc logs -n openshift-infra hawkular-metrics-t033u
2017-01-20 17:45:44 Starting Hawkular Metrics
Error: the service account for Hawkular Metrics does not have permission to view resources in this namespace. View permissions are required for Hawkular Metrics to function properly.
Usually this can be resolved by running: oc adm policy add-role-to-user view system:serviceaccount:openshift-infra:hawkular -n openshift-infra

Let's document this and/or set sensible defaults for node['cookbook-openshift3']['openshift_hosted_metrics_parameters']

I have a PR ready to add integration tests for the hosted metrics feature, but wait for #60 to be merged before I submit it.

The feature is demonstrated in https://github.com/IshentRas/cookbook-openshift3/blob/master/.kitchen.yml#L64-L68 and now tested with inspec, can close this issue.


Major performance regression in 2.5.0 for jiwer.transforms.RemovePunctuation

There is a major performance regression in jiwer.transforms.RemovePunctuation in 2.5.0
%timeit jiwer.transforms.RemovePunctuation() gives 228 ms ± 4.34 ms per loop on 2.5.0
but
%timeit jiwer.transforms.RemovePunctuation() gives 1.35 µs ± 8.61 ns per loop on 2.4.0
this is 168,888 times slower.
I had a pipeline where I was computing the WER both with and without removing punctuation. I was recreating the transform list each time. This can be solved by computing it up front and caching the transformations, but I am very surprised to find this to be the cause of my regression.

Looks like this is caused by https://github.com/jitsi/jiwer/commit/0fc3893027bcc03114b34e33da5c5298b7da20e1#

Thanks for spotting the issue and making a quick PR!