open pull-request overview board

A a contributor
I would like to know what pull-request are open
So I can help and/or track the progress
This is especially important with openSCD-core, the plug-ins/code can be in multiple repositories.
Acceptance criteria:

Overview board on the OpenSCD organization with all (automatically updated) pull-requests from all repositories within the OpenSCD organization
Public for everyone
It should not exclude external pull-requests
Add them to .github as generic github action for the entire organization (https://docs.github.com/en/actions/using-workflows/sharing-workflows-secrets-and-runners-with-your-organization)

Collums:
Pending
Changes requested
Approved
Done
Dones get emptied evey first of the month 0:00 UTC

We wait for this first: https://github.com/orgs/openscd/projects/4/views/6?pane=issue&itemId=37844467

https://github.com/openscd/oscd-components/pull/38


Make navbar sticky on top

Kindly assign under hacktoberfest

Hey @abhay-raj19. I tried to make the navbar sticky in mobile view. but it seems like the code is written to make the navbar sticky not it's not working. I changed, removed, and added many possibilities but still did not succeed. Can you help?!!

can i work on this issue?

@Pritam-2002 go for it .


Going Apache 2.0

Do you @itsmeft24 and you @MarcelCoding hereby agree that your code, that you contributed to the GitHub repository "offsetting/x-flipper-360" will be licensed under the "Apache 2.0" license from the point of time when both of you agreed to this License, by writing a comment under this GitHub pull request (https://github.com/offsetting/x-flipper-360/pull/2) acknowledging your agreement?

i am agreeing

i am also agreeing


cargo valgrind unexpectedly crashed (but may be misbehaving instrumented program)

Reporting this here, since cargo-valgrind asked me nicely to do so.
Project: https://github.com/barafael/crisp/tree/cargo-valgrind-bug. There is a note in main.rs with a possibly related call to free.
Gist of trace (because it's too long for GitHub issue): https://gist.github.com/barafael/8360ad9aa31fc747fd53568be2bb35cc
Steps to reproduce

Clone project on branch cargo-valgrind-bug
Run cargo valgrind run
Enter * 1 2
Hit CTRL-C

Note, I just found out it's actually a double free at lval_del(tree). Suppose I can close the issue? Undefined behaviour in the observed program is not a bug in cargo-valgrind, is it :D

Thanks for opening this issue. You've done everything right: even if your program has an issue, cargo valgrind should handle it gracefully and tell you the error 😉
Thanks for the reproducer as well, I'll try to publish a fix soon[^1].
[^1]: just for your information: you can also attach the output as a file or use the following HTML tags to make the output collapsible: . But the Gist is, of course fine as well.

Could you try out the release 2.1.0? This nicht contain the fix for your issue.

hmm, I cannot reproduce the issue anymore with any of the previous versions or the current version. I'm seeing the expected output from valgrind, instead.

So, it seems this issue is resolved now? That would be very nice! Regardless, I'll do some more testing on the weekend when I have some time :)

I have again installed version 2.0.3, with which I had originally observed this issue. However, now I fail to reproduce it. Perhaps, clang and valgrind versions play a role? The observed program was anyway exhibiting undefined behaviour... What do you think, can we close this issue? Seems to me yes.

Yeah, you're right, let's close this issue then. GitHub makes it easy to reopen it, should the issue arise again. In this case: feel free to re-open.
Thanks!


Allow passing whole directory as argument for -f

If kedge create -f foo is called and foo is directory deploy all *.yml  files in that directory.
Same behaviour for delete, generate and apply

:+1:


update install_requires according to setup.py

see https://github.com/aiidateam/plumpy/blob/v0.12.2/setup.py

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


HEAD request

Closes #109

Nicely done! Only two change I would suggest:

In real code I would expect 5, 0 to be accompanied by a quick note about what the numbers mean, so that the reader doesn't have to look up the Duration API to figure out what the timeout is set to. Maybe something like this:
// Set a 5 second timeout for the request.

The wording of the intro makes it sound like the timeout is a way to avoid needing to receive a body, but actually the HEAD request is the way to avoid needing to receive a body. Could you rearrange those or move the timeout sentence to its own paragraph to make this clearer?

Done. I rephrased it in a different way so it doesn't sound tied together.

Here it is. Thanks for the great example!


Low perfomance with batch size > 1

I am getting about 10 times less fps on rk3568 chip, inferencing model with batch size more than one. Is it some chip peculiarities or i am doing something wrong?
Here are configurations and model perfomance screenshots.
Batch size 1:

Batch size 2:

hello， I set rknn_batch_size>1 during the phase building 3568 rknn model with rknn-toolkit2 1.3.0. but the rknn model is still batch = 1, when use it to inference.

thanks，View the knn document, some operators in rknn only support rknn_batch_size=1, such as pooling and activating 。Therefore, the rknn_batch_size>1 setting does not work。

thanks，View the knn document, some operators in rknn only support rknn_batch_size=1, such as pooling and activating 。Therefore, the rknn_batch_size>1 setting does not work。

Do you know if this is still true for toolkit v2.0.0(beta) and if so, if these restrictions are documented anywhere?


Completion always pushing "clear" and "exit"

Hi,
Thanks a lot by this awesome script!
I've setted completion as array of commands. Then, everytime I press TabTab commands "clear" and "exit" get added multilpe times.
Because complete_helper() does command.push without checking.
I've fixed by adding condition "$.inArray('clear',commands)==-1".
Although, that will only work if completion settings is an array.
Best regards.

I'm also affected by this.

Fixed in devel branch. Your $.inArray in complete_helper will work for both array and function.


Corrections Needed in README and Type Hinting in Code

Thank you for your work on CEC. I'm very interested in your research because I'm currently doing similar work. I installed the environment according to your README and tried to run your code, and I found some issues in it.
First, The command to run the program in the README needs to be updated. The parameters passed in hydra should not include --. For example, python3 main/dmlab/train.py --method={METHOD} --task={TASK} --gpus={GPU} --data_path={DATA_PATH} should be changed to python3 main/dmlab/train.py method={METHOD} task={TASK} gpus={GPU} data_path={DATA_PATH}.
Secondly, it seems that you have used the wrong type hint, for example, you wrote list[float] instead of List[float], which will result in TypeError: 'type' object is not subscriptable. The same thing happens to Dict and Tuple.
I believe these issues might be bugs in the codebase. As such, I kindly request your assistance in addressing and rectifying these problems. After making these changes, please ensure to test the code thoroughly to prevent any further problems. Thank you.

I

Thank you for your work on CEC. I'm very interested in your research because I'm currently doing similar work. I installed the environment according to your README and tried to run your code, and I found some issues in it.
First, The command to run the program in the README needs to be updated. The parameters passed in hydra should not include --. For example, python3 main/dmlab/train.py --method={METHOD} --task={TASK} --gpus={GPU} --data_path={DATA_PATH} should be changed to python3 main/dmlab/train.py method={METHOD} task={TASK} gpus={GPU} data_path={DATA_PATH}.
Secondly, it seems that you have used the wrong type hint, for example, you wrote list[float] instead of List[float], which will result in TypeError: 'type' object is not subscriptable. The same thing happens to Dict and Tuple.
I believe these issues might be bugs in the codebase. As such, I kindly request your assistance in addressing and rectifying these problems. After making these changes, please ensure to test the code thoroughly to prevent any further problems. Thank you.

I followed you use command like python main/robomimic/train.py method=cec task=lift data_path="/mimicgen/datasets/core/" gpus=cpu, but it said
  @hydra.main(config_name="common", config_path="train_config")
Could not override 'method'.
To append to your config use +method=cec
Key 'method' is not in struct
    full_key: method
    object_type=dict

Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.

Should I use '+' to override? And it told me again and agin cpu is not right,but i only have cpu now


Add test for selecting a single complex field array and its parent struct array [databricks]

PR tries to mimic the test in Spark's SchemaPruningSuite.
We create a table with complex fields and try to read only a subfield to see if column pruning is working the way it's supposed to i.e. we are not reading unnecessary columns. e.g. if we have a complex type contact with an array of friends, like so
Contact {
   first_name: String
   middle_name: String
   last_name: String
   friends: Array[Contact]
}

selecting spark.table("contacts").select(explode("friends").alias("friend").select("friend.first_name") shouldn't also read the middle_name and last_name of the friends field.
fixes #8712
fixes #8713
fixes #8714
fixes #8715

It would be good for description in this PR (if not also the issue #8712) to be more descriptive of the change.
The test here is a sampling of tests covered in SchemaPruningSuite. The objective is to cover some scenarios where column pruning might be tripped up. SchemaPruningSuite does this by selecting different combinations of column (and sub-column) projections.
You should consider combining these tests into a single change. All that's changing between these tests is the output projection.

Adding to this for clarity:

There are 4 scenarios listed in #8666, sampled from SchemaPruningSuite. I don't think it's necessary to exhaustively run all the cases. We just need a few to test that the pruning is working.
Some effort will be needed to do the equivalent of checkScan and checkScanSchemata. We'll just need to check that the file-scan operator in question has the expected read schema, just like in the test.

build

connection failure in premerge

build

premerge failing with the following Exception which seems to be unrelated to this change. I also see another PR failing with the same exception
[2023-07-26T21:17:28.616Z] [1m[31m../../src/main/python/parquet_testing_test.py[0m:116: in <module>
[2023-07-26T21:17:28.616Z]     @pytest.mark.parametrize("path", gen_testing_params_for_valid_files())
[2023-07-26T21:17:28.616Z] [1m[31m../../src/main/python/parquet_testing_test.py[0m:105: in gen_testing_params_for_valid_files
[2023-07-26T21:17:28.616Z]     for f in locate_parquet_testing_files():
[2023-07-26T21:17:28.616Z] [1m[31m../../src/main/python/parquet_testing_test.py[0m:91: in locate_parquet_testing_files
[2023-07-26T21:17:28.616Z]     raise AssertionError("Cannot find parquet-testing data in any of: " + locations)
[2023-07-26T21:17:28.616Z] [1m[31mE   AssertionError: Cannot find parquet-testing data in any of: /home/jenkins/agent/workspace/jenkins-rapids_premerge-github-7623-ci-2/integration_tests/src/test/resources/parquet-testing/data/*.parquet, /home/jenkins/agent/workspace/jenkins-rapids_premerge-github-7623-ci-2/integration_tests/src/test/resources/parquet-testing/bad_data/*.parquet, /home/jenkins/agent/workspace/jenkins-rapids_premerge-github-7623-ci-2/thirdparty/parquet-testing/data/*.parquet, /home/jenkins/agent/workspace/jenkins-

build

build

@razajafri try to upmerge and then run the premerge tests again.

build

I am looking into the CI failure. From the logs, the test that I added is possibly crashing the JVM which is causing
subsequent test failures but everything passes on my local workstation.
It could just be a coincidence that the connection dropped so I will try to kick this off one more time.

build

Self-bootstrap failure during launch. Please try again later and contact Databricks if the problem persists. Node daemon fast failed and did not answer ping

build

build

build

build

build

@mythrocks @revans2 can you please take another look


apply bug for native functions

setTimeout.apply {x -> console.log "hello", 1000}

Expected behavior: hello must be printed after one second.
Observed behavior: hello is printed immediately.

This will also fix #8.

This too depends on #60.


Add specific status checks for Zed branches

Zed branches swap support for python 3.6 with python 3.10, necessitating a change in the required tox workflows:

Previously, the rules applied to all branches matching the pattern stackhpc/**. I've changed this to just match against stackhpc/{wallaby,xena,yoga,zed} which has the upside of not matching against any stray branches such as stackhpc/yoga-feature but the downside of not going back any further than wallaby. I'm assuming we don't need any more than that but can tack on more if required.

Previously, the rules applied to all branches matching the pattern stackhpc/**. I've changed this to just match against stackhpc/{wallaby,xena,yoga,zed} which has the upside of not matching against any stray branches such as stackhpc/yoga-feature but the downside of not going back any further than wallaby. I'm assuming we don't need any more than that but can tack on more if required.

I think we may have some deployments on Victoria.


Update nonicons.lua

Adding 5 new nonicon "extension_icons" as suggested here: https://github.com/lite-xl/lite-xl-plugins/issues/144#issuecomment-1673625744

Thank you! Would you mind also bumping the plugin version in manifest.json?

Thank you! Would you mind also bumping the plugin version in manifest.json?

Hope I did it right :wink:

Yep, looks good, thanks!


scrollend on touch block

Hi,
scrollEnd should be triggered also when the user block the scroll tap on the scroll while is in movement in v5

scrollEnd not working on Android 4.0.3 Chrome

When at the beginning or end of the scrolling wrapper, if I scroll against the border (no elements moving), the scrollStart is firing, but there is no ScrollEnd firing. Happens only with snap on.


Unable to login or register

Describe the bug
Can't login or create a user. Fails wirh the error: Fatal error: Uncaught Error: Call to a member function fetch_assoc() on boolean in C:\wamp64\www\BusKaro\index.php on line 154
To Reproduce
Steps to reproduce the behavior:

Start WAMP
Go to localhost/buskaro
Try to login or register
Notice error on the bottom of the website

Expected behavior
The user can log in or register
Desktop (please complete the following information):

OS: Windows 10 Pro
Browser Chrome

I would like to help on this issue

Sure, @madhavgoyal98

Buskaro has not yet implemented features that prevent SQL Injection attacks, but what is this about SQL Injection:
SQL Injection
Technique that malicious users use to “inject” SQL code into a lawful SQL statement using Web form fields, the URL, or other input means;
It may compromise the security of the web application;
It can enable unauthorized query, update, and delete operations to be performed on the database.
To avoid SQL Injection the following features are used:
Avoiding SQL Injection

Preprocessing (validating) data entered in form (or URL) fields is recommended to prevent SQL Injection attacks;
// Validation of Populated Data in Form Fields
     function input_filter ($data) {
         // remove spaces at the beginning and
         // at the end of the string
         $data = trim ($data);

// remove against slashes:
         // "water snake" becomes "water snake"
         $data = stripslashes ($data);
         $data = htmlspecialchars ($data);
return $data;
     }
The PHP htmlspecialchar function, for example, removes some special characters from the string, such as quotation marks, by replacing these characters with the corresponding HTML codes;

In addition to validating data from form fields or URLs, it is also recommended not to enter the name of PHP variables directly into the SQL string;

Instead, use the concept of prepared statements (presented below).
Prepared Statement is a feature that allows you to execute the same SQL statement over and over, more efficiently and more safely.
Main advantages:
• Greater security against SQL Injection attacks.
• May reduce the execution time of multiple SQL queries on the server, as their preparation can be performed only once (although the query may be executed repeatedly);
• Can reduce data traffic with the server as the SQL statement does not have to be resubmitted in full again and again;
Basic operation:
• Preparation: An SQL template is created and sent to the DBMS. However, certain values are left open (called parameters). Example: INSERT INTO Customers VALUES (?,?,?)
• DBMS preprocesses the SQL statement (checks the syntax, among others), but does not execute it;
• Execution: later, the application gives values to the parameters and executes the declaration;
Can I implement these features (preprocessing / validating and prepared statements) that prevent SQL Injection attacks?

Thanks @EuricoMazivila for the inputs. Indeed, defence against SQL Injection is crucial for the project. We can either split this issue into two or if we don't get a response from @madhavgoyal98 soon, we can have you assigned on this one so you can resolve both the issues in under #14
Let me know what you think!
Thanks again :)

That's fine by me, but for me to start will depend a lot more on the response of @EuricoMazivila madhavgoyal98…
I have a question- Which of the 15 databases should I use if I start with my contributions?
Thank you so much for letting me participate…

Can @EuricoMazivila create a new issue and work under that for SQL Injection?
This issue is closed now


Mark homework 1, exercise 1,2  of Peigen Zhou

Homework1
The SHA is 659e3596f5271fbf4772eeb35b982b3225488e74
The homework fold hw1 is inside the stat679work repo.
Exercise 1-3
Inside HW1, I already wrote all the things I have done into readme.md file check here, which contains:

Scripts purpose
Command I used
Full code snapshots
Summary table

Professor @cecileane, I also add a makefile to execute all commands in hw1.
Best,
Peigen

Hi Peigen,
Great work! You even have a makefile, this is fantastic. And for this, you added an "undoNormalizeFileNames" script to clean the project. Fantastic! Are you sure that you will be learning something from this course? You could add a target called "all" so that we can type make to do it all. I had to change the name of your filename from makeFile to makefile, and I had to do make clean first, but after that it worked beautifully.
It's all super well documented.
You also have a license for your repository, great choice, I highly approve.
Your script to normalize (or un-normalize) file names is elegant in its design. It would have been better, however, to use timetest${i}_snaq.log instead of timetest$i\_snaq.log. Generally, it is good practice to access shell variables with ${i} instead of $i.
Unfortunately, you didn't fully use this exercise to practice with grep. It was one of the main goals of this homework. None of your commands used extended regular expressions. It is great that you used parameter expansion and a clever use of cut with various delimiters, but learning to use extended regular expressions would be useful for all other languages, not just the shell.
Last small thing: in a csv file, there should be not spaces before/after the commas that delimit the columns. Well, another small thing: I didn't have it in my list, but "hahahaha" is not a good message for a git commit...
Please close this issue, or assign it to me and I can close it.

Hi, Professor @cecileane
Thanks for all your comment for this home work, my new commit is here 199c88cba05b4b9eded4d9ed49c742d5f8c76193
I took the Professor Karl Broman's course before, which is a fantastic course as yours too. So that I try to acquire this habits to make a makefile of our my projects.
For the makeFile that is a mistake, I forgot the do git rm --cached makeFile.....
And I change all the summary to use extended regular expressions, here is the Code
Thanks for your effort!


[Upload Flow] Start SampleUploadFlowHeader and add additional details

This PR moves the current upload flow titles to Headers and adds some additional details like a help link.
Going to put these up as they're ready. NEXT UP: the tab selectors and footer.
One big change is moving getProjectMetadataFields and getAllHostGenomes up a level to MetadataUpload so that it can be called once and use those fields for host genomes and required fields listing + MetadataManualInput. So MetadataManualInput is no longer async.
Also moves the title details for each page to SampleUploadFlowHeader

^ updated screenshots based on design requests

On a wide screen, this looks a little off.

Can we wrap the Header in a NarrowContainer as well?

I really don't like the multiple lines of text visually. For "Required Fields" and "Host Genomes", can we hide them under a "View/Hide Required Fields and Host Genomes" button, like we do with "More Info" here? So when the user clicks on that, they'll show up in a grey box. You can put this button on the same line as "See Metadata Dictionary" and maybe separate it with a "|", so there's only one line of text.

Can you make the margin-bottom on the title 5px instead of 15? There's a little too much whitespace for elements that should be grouped together visually.

I also don't like these multiple lines, but can't figure out what to do with the "Need help? Message us". I kind of want to remove it, or just show it when we display errors, but let's leave it for now.

@MarkAZhang 👍 updated with all the changes


:sparkles: Groups should be exportable

We need a new endpoint export on a group that returns all the users of this group (since it is not possible to filter on group)
Then will need to add an issue on sugoi-ui to have on each group line the export feature

closed by https://github.com/InseeFr/sugoi-api/commit/55ef15db53480f027e9952aaa8586662c02f1a2f


Unable to prune deleted files

Current Behavior
I've enabled Prune Sector Roots after deleting a bunch of files. But after weeks, the sectors still aren't deleted.
Every now and then I keep getting alerts that pruning failed, and the logs are full with the same error.
The alert:
timestamp06-02-2024 15:04:34
failed to prune contract fcid:5719ae71088e0fcfe6fd266ae88f73c5ab09d395de546e74f04c1e87263d02ca; couldn't verify contract roots proof, host ed25519:09a5972a8fe871f765a52729fab15a78a2e0a7d85a8b614de3f4295f2a87292b, version 1.6.0; host supplied invalid Merkle proof
originautopilot.autopilot
host key
ed25519:09a5...
contract ID
5719ae71088e...
hostVersion1.6.0

Full error from the logs:
contract fcid:5719ae71088e0fcfe6fd266ae88f73c5ab09d395de546e74f04c1e87263d02ca, host ed25519:09a5972a8fe871f765a52729fab15a78a2e0a7d85a8b614de3f4295f2a87292b version 1.6.0, err: failed to prune contract fcid:5719ae71088e0fcfe6fd266ae88f73c5ab09d395de546e74f04c1e87263d02ca; couldn't verify contract roots proof, host ed25519:09a5972a8fe871f765a52729fab15a78a2e0a7d85a8b614de3f4295f2a87292b, version 1.6.0; host supplied invalid Merkle proof
Expected Behavior
.
Steps to Reproduce
No response
Version
#1469b66
What operating system did the problem occur on (e.g. Ubuntu 22.04, macOS 12.0, Windows 11)?
Debian Docker
Autopilot Config
{         "contracts": {                 "set": "autopilot",                 "amount": 50,                 "allowance": "135793206078600000000000000000",                 "period": 6048,                 "renewWindow": 2016,                 "download":<PHONE_NUMBER>00,                 "upload":<PHONE_NUMBER>00,                 "storage":<PHONE_NUMBER>0000,                 "prune": true         },         "hosts": {                 "allowRedundantIPs": true,                 "maxDowntimeHours": 1440,                 "minRecentScanFailures": 10,                 "scoreOverrides": null         } }
Bus Config
{         "default": "autopilot" } {         "hostBlockHeightLeeway": 6,         "maxContractPrice": "1000000000000000000000000",         "maxDownloadPrice": "5805101409000000000000000000",         "maxRPCPrice": "1000000000000000000000",         "maxStoragePrice": "694444444444",         "maxUploadPrice": "2902550705000000000000000000",         "migrationSurchargeMultiplier": 10,         "minAccountExpiry":<PHONE_NUMBER>0000,         "minMaxCollateral": "10000000000000000000000000",         "minMaxEphemeralAccountBalance": "1000000000000000000000000",         "minPriceTableValidity":<PHONE_NUMBER>0 } {         "minShards": 4,         "totalShards": 12 } {         "enabled": true }
Contract Set Contracts
23
Anything else?
No response

Possibly fixed once https://github.com/SiaFoundation/hostd/pull/296 is merged and has seen some adoption

I'm assuming most of us on Zen have updated. No change in behaviour so far.

I have been running dev on my node that manages 4TB and constantly uploads/downloads and deletes data. Several TB per day. That node has pruning enabled and has been running without issues for a while now. We recently merged a bunch of stuff related to pruning, all stuff I discovered from doing this test:
https://github.com/SiaFoundation/renterd/pull/1240
https://github.com/SiaFoundation/renterd/pull/1230
https://github.com/SiaFoundation/renterd/pull/1229
I think we can close this issue and re-open it if necessary.

@peterjan Looking good on my side.
I only had around 700GB left on my test node. I didn't check the logs, but it looks like everything got pruned fine after I deleted it.


The option "user_context" does not exist.

I used "sentry/sentry-laravel": "^0.12.0@dev" earlier and it worked with user_context correctly. How to resolve this error for version 1.0-beta?

Look for user_context in the upgrade documentation of the sentry-php the Laravel integration uses.
I see the user context documentation is currently missing from the Laravel documentation so that will be added back later.
The gist is to do instead of $client->user_context(['email' => 'foo@example.com']); do:
use Sentry\Hub;
use Sentry\Scope;

Hub::getCurrent()->configureScope(function (Scope $scope): void {
    $scope->setUser(['email' => 'foo@example.com']);
});

Indeed. Would be great to update examples configs as well.

We never had ik documented in the example since there is no user context in a clean Laravel setup, but it is documented correctly now!

https://docs.sentry.io/platforms/php/laravel/#user-context

no user context in a clean Laravel setup

Well, yes, but examples do contain user_context:
https://github.com/getsentry/sentry-laravel/blob/4cf6852fd38c8cbd0a52179cfdc74b156866ade4/examples/laravel-5.4/config/sentry.php#L13
https://github.com/getsentry/sentry-laravel/blob/39e918a8f2c9d06c7408d275095e36ad4258886d/examples/laravel-5.5/config/sentry.php#L13

Ah, OK, these old examples are supposed to stick at the version < 1.
But they are partly been updated, that why it raises some confusions.

@LeoColomb good point, totally missed those :( Thanks for letting me know!
I updated those example to reflect the config option changes here: #197

For those who had cache config on remote server and are now trapped in a loop with that error, you must uninstall sentry/sentry-laravel by removing it from composer.json, deploy, clear config, reinstall sentry, and deploy again.

Alternatively you can remove the config cache file manually: bootstrap/cache/config.php.

It's a real shame that this package stopped supporting sending user details out of the box. It feels incredibly lazy that I need to create a middleware to configure Sentry myself because the Laravel-specific Sentry bridge doesn't do it by itself.

Sorry you feel this way so strongly.
However, the option to add the user context is not gone but it’s called differently now.

https://docs.sentry.io/platforms/php/laravel/#user-context

So this option send_default_pii should be documented in the config/sentry.php

I think we shouldn't because then where do we stop with documenting options in there and syncing their defaults with the base package, there are quite a few and more may be added later at any time. Better to keep that in the documentation IMHO.
For reference, they are all documented here: https://docs.sentry.io/error-reporting/configuration/?platform=php


about test.py

When I run your test command, this error appears. What is the reason for this

You can print the size of lrs in line50 and check the dimensions.


feat: don't upload the same asset multiple times

This change implements two asset upload frugality measures:

If a lambda.AssetCode object is reused for multiple Lambdas,
the same underyling Asset object will be reused (which leads to
the asset data only being uploaded once).
If nonetheless multiple Asset objects are created for the same
source data, the data will only be uploaded once and subsequently
copied on the server-side to avoid the additional data transfer.

Fixes #989.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Ping

I dare not ask - toolkit integration test?

It's integ-tested by integ.multi-assets.ts


depends-on plot/vglt system not found

I have a new install of Portacle on Windows, and  (ql:quickload :ips) is failing with the following condition:
System "plot/vglt" not found
   [Condition of type QUICKLISP-CLIENT:SYSTEM-NOT-FOUND]

I cannot see a :plot/vglt package anywhere? Quicklist has a vgplot package but this does not export plot/vglt
What am I missing?
Thanks!

Ah! got it working.. had to install the plot package using instructions in the following section:
https://lisp-stat.dev/docs/getting-started/#manual-install

Thank you for the report. I have requested that plot be added to quicklisp. After this is done, the install will be automatic.
I'll close this now. If you have other problems (or suggestions/comments), please open a new issue. I'm through the pie chart now and starting on stem-and-leaf, in case you need those.


Setup error

01a6035e3d6868851793443d644580d2466e3ced produced an setup error for me.
  Running setup.py (path:/src/hijack-master/setup.py) egg_info for package hijack-master
    Traceback (most recent call last):
      File "<string>", line 17, in <module>
      File "/src/hijack-master/setup.py", line 48, in <module>
        description=read('DESCRIPTION'),
      File "/src/hijack-master/setup.py", line 41, in read
        encoding='utf8').read()
    TypeError: 'encoding' is an invalid keyword argument for this function
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

  File "<string>", line 17, in <module>

  File "/src/hijack-master/setup.py", line 48, in <module>

    description=read('DESCRIPTION'),

  File "/src/hijack-master/setup.py", line 41, in read

    encoding='utf8').read()

@aldarund on which python version did you encountered this error?

@walterrenner Python 2.7.6

@aldarund can you confirm, that #106 fixes this issue?

Circumvented the problem by removing the two unicode characters from README (fd8f113)

This issue appears to have been resolved and can most likely be closed.


Issue/241 frequency spiking neuron

Replace the 20 artificial spikes we inserted until now with spikes generated with a frequency spiking cell.
This is a cell that spikes regularly for a set period.
This connections outgoing from this cell mirror all the outgoing connections of cells with gid % 20 == 0.
This means that 5% extra connections have been added to the model to implement the equivalent behaviour with an 'implemented' neuron.
To implement this behavoir a new cell_group type has been introduced.
The fs_cell is extremely small and is not implemented on the backends.
Includes:
Unit test for the fs_cell functionality

I implemented all comment EXCEPT the rss_cell as an explicit part of the description: The neuron is part of the model and should therefore not be a surprise . I could split it out into 1000 normal neurons and 1 regular spiking neuron. But the current recipe structure and definition currently is full of magic .
I would suggest to defer this change until we have had a design session on the model creation API.

I changed the recipes to add the rss_cell automatically and have the user only define the nr of mc cells.
All review comments have been addresses.


Flutter 3.13.1 support

Require Flutter 3.13.1 support

The current Dart SDK version is 3.1.0.
Because test_app depends on youtube_shorts any which requires SDK version >=3.2.0 <4.0.0, version solving failed.
You can try the following suggestion to make the pubspec resolve:

Try using the Flutter SDK version: 3.16.9.

But I dont want to change my version.
any possibility this could run on my version.

Wow, man! So sorry for the time to replying 🙏
Github did not notified me that someone had opened an issue..
I fixed the problem you related in version 4.0.0.
(Also introduced ads possibility :D)
Please update your dependency and let me now if the problem is now resolved. I'll stay in wait for further updates.

Closing issue due to lack of response

ok thanks


Update homework_1.md

I added PNG file.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[ ] I can confirm that my changes are working as intended

You have unfortunately made a pull request to the wrong repo. You shouldn't be making a pull request to uoft-dsi/sql, but rather your own forked sql repo. Please read the instructions on your onboarding Assignment Submission Guide more carefully.

Hi Daniel,Thanks for letting me know the mistake! How could i remove that pull request and do i need to pull request again under my own repository?Thanks in advance!Shaohe Wang在 2024年5月21日，09:33，Daniel Razavi @.***> 写道：
You have unfortunately made a pull request to the wrong repo. You shouldn't be making a pull request to uoft-dsi/sql, but rather your own forked sql repo. Please read the instructions on your onboarding Assignment Submission Guide more carefully.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

I have already closed this PR. Yes you need to make a PR on your own repo. Please read the instructions on your onboarding Assignment Submission Guide more carefully.

Thanks Daniel. Please see my new request of homework1.
Shaohe Wang

2024年5月21日 09:53，Daniel Razavi @.***> 写道：
I have already closed this PR. Yes you need to make a PR on your own repo. Please read the instructions on your onboarding Assignment Submission Guide https://github.com/UofT-DSI/onboarding/blob/main/onboarding_documents/submissions.md more carefully.
—
Reply to this email directly, view it on GitHub https://github.com/UofT-DSI/sql/pull/30#issuecomment-2122691723, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3XQOKDXTYNADATKATDJYZTZDNGULAVCNFSM6AAAAABH3GTGXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRSGY4TCNZSGM.
You are receiving this because you authored the thread.


fix: fix Makefile in bizdemo/easy_note/cmd/user and bizdemo/easy_note/cmd/note

What type of PR is this?
fix: 更正了bizdemo中user微服务和note微服务里的Makefile中rpc服务端代码生成命令，添加了-use标识
What this PR does / why we need it (en: English/zh: Chinese):
en: add -use flag in Makefile of user service and note service in bizdemo/easy_note
zh: 更正了bizdemo中user微服务和note微服务里的Makefile中rpc服务端代码生成命令，添加了-use标识
Which issue(s) this PR fixes:
#60

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

need to sign cla

PATL @justlorain

LGTM


Update project to Swift 5 and Xcode 10.2 recommended settings.

Hi! Big fan of TagListView. Would you mind accepting this minor PR to move TagListView to Swift 5 and Xcode 10.2's recommended settings (primarily around localizability)?

Thank you for the quick merge! Would you be willing to go one more step and release a new version (say, 1.4.0 or 1.3.3) as Swift 5 and publish to Cocoapods?


add HNTenna option to app

Request to add the HNTenna as an antenna option in the app.

superseded by #1080


Create Storage - zone selection clears the disk offering value

http://cs-ui-ci.z1.netpoint-dc.com:8080/bwsw/master/storage/create
user develop
Steps:

Login by user
Go to Storage
Click on disk creation button
Select disk offering
Select Zone

Expected result:  disk offering value is selected
Actual result:  disk offering is empty
Connected feature ID: storage_disk_create

HeyRoach/801-create-volume-selection-bug
To test: storage_disk_create


Fix/logs

Coverage decreased (-0.04%) to 90.34% when pulling 97ce6bc1493cefba0d3af45cff3277bef1dea1c5 on fix/logs into d7e86f8001b7755c6a99be5f88fdd9f45968bcde on master.

Coverage decreased (-0.04%) to 90.34% when pulling f62baa2d08ef812295445e2a01773fb21d736f6c on fix/logs into d7e86f8001b7755c6a99be5f88fdd9f45968bcde on master.


Toggle in settings to stop validating project config

@riasvdv
Since our use of Scout is somewhat complicated and we end up having three arrays with the same indexName in our indices in the Scout config, the exception "Index names must be unique in the Scout config" is thrown. However, there is unfortunately no way around creating non-unique index names with our current configuration, and the indices get pushed to Algolia correctly.
Might it be possible to add a toggle in the settings to disable config validation – or maybe even just in the scout.php config file? It would help us tremendously. 🙏
Thanks in advance!

@martinhellwagner could you post your scout config?

<?php

$mapper = include '_partials/scout/mapper.php';
$mappingsFolder = __DIR__ . '/_partials/scout/mappings/';
$mappingsFiles = scandir($mappingsFolder);
$mappingsList = [];
$finalMappings = [];

foreach ($mappingsFiles as $file) {
    if (in_array($file, ['.', '..'])) continue;
    $indexName = basename($file, '.php') . '_' . \Craft::$app->config->env;
    $mappingsList[$indexName] = include $mappingsFolder . $file;
}

foreach ($mappingsList as $indexName => $mappings) {
    foreach ($mappings as $section => $mapping) {
        $finalMappings[] = $mapper($mapping, $section, $indexName)[0];
    }
}

$result = [
    "sync" => false,
    "connect_timeout" => 1,
    "application_id" => "xxx",
    "admin_api_key" => "xxx",
    "indices" => $finalMappings,
];

return $result;

We have a pretty complicated mapping going on that needs to be run three times (one for each section) for a specific index name.

I know this isn't the answer you want – but until I can take a look, it seems like you could have one index, with the element querying for all three sections, and then deal with any indexing differences in the  transformer.
The only way I can imagine needing to do what you're describing is if you needed a given entry to be mapped to 3 unique Algolia objects in the same Algolia index.

This is actually what I've tried, but couldn't get it to work. Unfortunately I can't spend any more time on that right now, as we need indexing to work again sooner than later.

@martinhellwagner fair enough – there's been discussion of making indexName non-unique here: https://github.com/riasvdv/craft-scout/issues/69
I'm hoping to get to that this week, which hopefully should help you. Stay tuned!

Thank you so much – really appreciated! 👍
By the way, I'm also experiencing the problem described in https://github.com/riasvdv/craft-scout/issues/152 – just FYI.

Thanks - hoping to plow through a bunch of issues this week.

@martinhellwagner Going to close this in favor of a solution from #69.


task management performance fixes

Closing in favour of https://github.com/apache/druid/pull/12099


[FEATURE]  Make RpcNodePort and HttpNodePort optional

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the feature
Make RpcNodePort and HttpNodePort optional
Motivation
More flexible
Describe the solution
No response
Additional context
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Sending this PR for this issue https://github.com/apache/incubator-uniffle/pull/305


JDK version error on build after updating to CLI v1.22.0

Describe the bug
After updating the CLI to v1.22.0 I went into my project folder, ran bubblewrap update (which went fine) and hen I ran bubblewrap build to do a new build. It took a while and by the end this error was thrown in the console:
cli ERROR Command failed: ./gradlew assembleRelease --stacktrace

FAILURE: Build failed with an exception.

* Where:
Build file '/home/....../......-bubblewrap/app/build.gradle' line: 20

* What went wrong:
An exception occurred applying plugin request [id: 'com.android.application']
> Failed to apply plugin 'com.android.internal.application'.
   > Android Gradle plugin requires Java 17 to run. You are currently using Java 11.
      Your current JDK is located in /home/stefan/.bubblewrap/jdk/jdk-<IP_ADDRESS>+1
      You can try some of the following options:
       - changing the IDE settings.
       - changing the JAVA_HOME environment variable.
       - changing `org.gradle.java.home` in `gradle.properties`.

* Try:
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

This is followed by a whole stack trace (if needed I'll post it too)
To Reproduce
Steps to reproduce the behavior:

Update Bubblewrap CLI package to the latest version
Open the terminal inside a bubblewrap project directory
Run bubblewrap update
Run bubblewrap build

Expected behavior
The app should build successfully
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Linux (Ububtu 24)
Browser Chrome

   > Android Gradle plugin requires Java 17 to run. You are currently using Java 11.
      Your current JDK is located in /home/stefan/.bubblewrap/jdk/jdk-<IP_ADDRESS>+1

Try deleting home/stefan/.bubblewrap folder and run bubblewrap init to download JDK 17.

   > Android Gradle plugin requires Java 17 to run. You are currently using Java 11.
      Your current JDK is located in /home/stefan/.bubblewrap/jdk/jdk-<IP_ADDRESS>+1

Try deleting home/stefan/.bubblewrap folder and run bubblewrap init to download JDK 17.

Thank you, this worked for me!

This worked for me as well, however bubblewrap still generates APK's that instantly crash when starting, I would like to know if I am the only one having this issue, but noone replied to my thread.

This worked for me as well, however bubblewrap still generates APK's that instantly crash when starting, I would like to know if I am the only one having this issue, but noone replied to my thread.

I didn't try that yet but thanks for the heads up. I'll definitely not upload anything to Google Play before first testing it locally on the phone.


Akamai/linode provider

This pull request introduces a new Akamai store to the project, updates dependencies, and adds necessary documentation. The most important changes include the implementation of the Akamai store, updates to the go.mod dependencies, and the addition of documentation for the Akamai store.
Akamai Store Implementation:

Added a new Akamai store with methods for initializing the client, starting a search, and retrieving kubeconfig for a specific path (pkg/store/kubeconfig_store_akamai.go).
Updated the initialize function in switcher.go to handle the new Akamai store type (cmd/switcher/switcher.go).
Added the Akamai store type and configuration to types.go (pkg/store/types.go).
Included Akamai store kind in the list of valid store kinds and added the corresponding configuration struct in config.go (types/config.go). [1] [2] [3]

Dependency Updates:

Updated several dependencies in go.mod to their latest versions, including golang.org/x/tools, golang.org/x/oauth2, and github.com/linode/linodego (go.mod). [1] [2] [3] [4]

Documentation:

Added documentation for the Akamai store, including usage instructions and configuration examples (docs/stores/akamai/akamai.md).

Awesome, thank you very much.

Awesome, thank you very much.

@danielfoehrKn Done :)


Broken CI because of matplotlib 3.6.0 release

The CI is currently broken, and since it broke on the release date of matplotlib 3.6.0, that is my suspected culprit...

I should add that the pandas update to version 1.5.0 also contributed to the breaking tests.


clipboard.writeImage can only paste inside apps but not in folders

Hello everyone. When I use clipboard.writeImage, I can copy an image and paste it into word and other apps. But when I try pasting it into file explorer the paste button is grayed out. I am assuming copying an image file means it can be pasted anywhere. This is on windows 10, version 1809 running electron 4.1

sorry, had so many tabs open I thought I was on the electron github page not electron-windows-store


guard against undefined req.agent

Issue #, if available:
Fixes #312
Description of changes:
Guards against undefined req.agent
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

PTAL


Code-first schema: support easier way to view derived schema

Ideally once we have nice generated clients for all our languages, it should be only rare+advanced cases that require seeing the raw graphql schema. But it does feel important to expose that information anyways, for debugging if nothing else.
Right now the easiest way to view the schema derived by an SDK is to start dagger dev and look at the schema in the graphiql console.
This is fine in the immediate term but we probably shouldn't rely on that.
One alternative idea is to expose this in the CLI somehow; it may fit in neatly with the dagger project CLI being worked on here (depending on the direction that PR goes): https://github.com/dagger/dagger/pull/3281

Ancient issue, no longer relevant


Allow for custom permissions for shared sources

Current deploys ensure that shared/uploads exists but the directory is left owned by web_user in the web_group group.  The permissions set are 0755 therefore, unless the owner of hhvm/php-fpm is the web_user, uploads aren't possible.  This pull request allows for the setting of looser permissions granting group writeable shared sources.

Makes sense to me :+1:


Constructor does real work

The current constructor of HanziWriter is calling setCharacter(). Which is too soon in my code, and don't let me really manage when setCharacter() gets called. This is a minor issue, but is a little annoying and goes against some (debatable) design principles : a constructor should not do any real work (only setting up inner variables).
I'm willing to make a PR on that, taking into account the fact that you need to keep backwards compatibility.
To elaborate why it is better to avoid any complex behavior in constructors, here are a few discussion about that:
http://misko.hevery.com/code-reviewers-guide/flaw-constructor-does-real-work/
https://softwareengineering.stackexchange.com/questions/224063
https://softwareengineering.stackexchange.com/questions/159193
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c41-a-constructor-should-create-a-fully-initialized-object
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-factory
As a fix, I would suggest to make it optional (default would still be to call setCharacter(), but this should be removed in next major release), and provide a factory that would create the widget and load a character HanziWriter.Create() to still offer the use case of setting up and loading a character in one go.
I'm totally aware that it's kind'a matter of taste here, and I will very happily and kindly understand any dismissal of this proposal.

I think you're right, it's not ideal that the HanziWriter constructor does all this setup work, especially now that there's better error handling so the user might be required to call setCharacter manually anyway. It's probably better to use a factory method like you said for HanziWriter.create() or something similar which does what the current constructor does. The constructor can just take options and/or the target element, or maybe just leave everything blank and allow the user to set those up in multiple calls afterwards. As a transition, we can have the constructor work with variable numbers of arguments, so if the second argument is a string we can assume it's the current behavior, and if not assume it's the new behavior.

@vaab @chanind
Hi guys, I totally agree with you on the above, I was going to raise the following bug when I saw this one

create a new HanziWriter() object to initialise it (it's still hidden so not used yet)
this.writer = new HanziWriter(characterDiv, character, {   		width: imgWidth,   		height: imgHeight,   		padding: 5,   		showOutline: true,   		drawingWidth: 22, // thickness of the drawing   		delayBetweenStrokes: 400, // milliseconds   		showCharacter: false,   		highlightOnComplete: false   	});
then later call the setCharacter method in order to really set the character we want you want
this.writer.setCharacter(character);

It creates 2  elements in the  one, with a bad overriding etc. as a consequence.
It may not have been the "way to use it" but in my case I would like to initialise everything before hand before even knowing which character I want to use.
So I'm looking forward for a fix as described above, or at least a fix on the new + set -> error

That's a good push to fix this. I'll work on a pr in the next few days!


Weather Extension for Weather Changes

Is your feature request related to a problem? Please describe.
I want to add a weather extension to show the actuall weather of the current location with other parameters
Describe the solution you'd like
I will use JS, HTML and CSS with weather API to fetch the weather data.
What problem is this feature trying to solve?
Adding a new weather feature so that users can quickly take a look
How do we know when the feature is complete?
I will share you the screenshot of the feature
@Sulagna-Dutta-Roy please assign this issue to me and add the gssoc and level labels
Thanks
Satyam

Hello @satyam8932 I see you dropped a email to us. In my project mentor is Inactive. Kindly respond in the discord/github for faster response instead of looping everyone.
Also acknowledge the bunch of issues and PRs can take some time because I am not available fully 24hrs. Thank you

Already added this project in my repository #82. So closing it


Feature: Sync configuration between two environments  within an application

🔖 Feature description
Sync configuration  between two environments within an application
🎤 Pitch / Usecases
There are multiple environment added within an application and most of the time we have to test the same fix or feature across environments and for that we want to sync the configurations, this feature we want use for active-active and active- passive cluster.
🔄 Alternative
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

AB#7456

Duplicate of #4366


storage ?

thanks for all the fosite work you have done. Its really helps for setting up auth and authz.
I am planning to build a GUI example in Flutter and Goi for others to use. If you want i can do it on your repo or ours.
https://git.sr.ht/~eliasnaur/gio/tree/master
Good Mirror: https://github.com/theclapp/gio-mirror
Issue: https://todo.sr.ht/~eliasnaur/gio
SO, I was wondering if your are going to use the mongodb storage with hasher and argon2 though
Also i am planning to also setup a Badger DB storage that uses CRDT so you get automatic HA.

Hi @joe-getcouragenow!
Thank you for you kind words 😄
As for using fosite+storage(mongo)+hasher, that is exactly how we have composed our oauth server that we are using in production with over 100K users.
To do this you have to use the 'manual' compose option that takes in a hasher, as composeAll forces you down the path of bcrypt, which is great, but argon2id is recommeded.
So to bring it all together you would have something like this (modified from the example in fosite/README.md - apologies if it contains errors, I'm freehand copy+pasta'ing):
package main

import argon2 "github.com/matthewhartstonge/hasher"
import "github.com/matthewhartstonge/storage/mongo"
import "github.com/ory/fosite/compose"
import log "github.com/sirupsen/logrus"

// This var block contains all the pre-configuration we need to configure to instatiate a fosite instance.
var (
  	// check the api docs of compose.Config for further configuration options
  	config = &compose.Config {
  	  	AccessTokenLifespan: time.Minute * 30,
		// ...
	}

	// storage binds in the fosite compliant mongo storage driver.
	storage= newMongo()

	// hasher provides a way to inject in a different hashing algorithm. defaults to bcrypt if nil.
	hasher = argon2.New(nil)

	// This secret is being used to sign access and refresh tokens as well as
	// authorization codes. It must be exactly 32 bytes long.
	secret = []byte("my super secret signing password")

	// This secret is being used to sign access and refresh tokens as well as
	// authorization codes. It must be exactly 32 bytes long.
	secret = []byte("my super secret signing password")

	// Provides us the key to use to generate RSA signed jwt tokens.
	privateKey, _ = rsa.GenerateKey(rand.Reader, 2048)
)

// newMongo inits a fosite-storage compatible mongo client.
func newMongo() *mongo.Store {
	store, err := mongo.NewDefaultStore()
	if err != nil {
		log.WithError(err).Fatal("error creating new store")
	}

	return  store
}

// oauth2Provider composes together all the requirements to configure our fosite instance.
var oauth2Provider = compose.Compose(
	config,
	storage,
	&CommonStrategy{
		CoreStrategy:               NewOAuth2HMACStrategy(config, secret, nil),
		OpenIDConnectTokenStrategy: NewOpenIDConnectStrategy(config, key),
		JWTStrategy: &jwt.RS256JWTStrategy{
			PrivateKey: key,
		},
	},
	hasher,

	OAuth2AuthorizeExplicitFactory,
	OAuth2AuthorizeImplicitFactory,
	OAuth2ClientCredentialsGrantFactory,
	OAuth2RefreshTokenGrantFactory,
	OAuth2ResourceOwnerPasswordCredentialsFactory,

	OpenIDConnectExplicitFactory,
	OpenIDConnectImplicitFactory,
	OpenIDConnectHybridFactory,
	OpenIDConnectRefreshFactory,

	OAuth2TokenIntrospectionFactory,

	OAuth2PKCEFactory,
)

// TODO: Implement OAuth2 handlers...

Hope that helps!
In terms of adding in a fosite compliant badgerDB backend, that would be cool!
Feel free to:

fork this repo
create a branch off of development called feature/badger

I've just created a discord server if you would like to chat: https://discord.gg/PMMmP3

@matthewhartstonge
Looks good. I will work on it now..
Here is the CRDT WAL lib i am basing my work on: https://github.com/StreamSpace/ants-db
Its based on IPFS and so designed to run in a NATed network environment and so not suitable. I need to work on a Server based one to replace RAFT still.
Btw the discord invite fails for me !! Se screenshot.

@joe-getcouragenow interesting!
Yeah, I've found raft can be very chatty over the network..
Sorry - discord tokens by default expire after 24 hours, try this one-time-use token instead: https://discord.gg/EmSrAA


Revise contracts - more tests and events

prevent quotes being re-used
emit event in buyer wallet when quote successfully converted to po
emit events in master data maintenance for Sellers and eShops for record create and change
tests for all above
more tests for quote approvers

ready to merge


Use _implementation attribute for relevant NumPy aliases

With the introduction of __array_function__ it has become impossible to use NumPy's implementation directly by aliasing such functions. To fix this behavior, a new _implementation attribute was added, ensuring libraries built on top of NumPy can fallback to its implementation.
This PR makes use of this new attribute to ensure functions like cupy.can_cast will fallback to numpy.can_cast. The tests added here will work for both NumPy < 1.17 (internally using the previous behavior of simply calling numpy.can_cast directly), and for NumPy >= 1.17 (internally calling numpy.can_cast._implementation). Tests won't work if NUMPY_EXPERIMENTAL_ARRAY_FUNCTION=1 for NumPy 1.16.x, that doesn't have the _implementation attribute that allows these functions to work.

This is related to #2024 and #2029.
I think this can be treated as enhancement rather than a bug as the currently it is implemented as expected (infinite loop issue has already been resolved in #2024).

@kmaehashi well, sort of. Indeed the infinite recursion was fixed in #2024, but none of those functions work without the _implementation dispatch when __array_function__ is enabled.

The test you added in this PR seems to pass also in the current master branch. How can I reproduce the issue?

Yes, it passes, which is good, because we want it to continue working as it does today. :)
The only way to reproduce the issue is to have NumPy >= 1.16 and have the environment variable NUMPY_EXPERIMENTAL_ARRAY_FUNCTION=1, for which CuPy isn't testing with CI currently.

@pentschev We want to merge this PR after NumPy 1.17 is released because the users don't face these errors unless setting NUMPY_EXPERIMENTAL_ARRAY_FUNCTION=1 until NumPy 1.17 is released. How do you think?

@asi1024 thanks for raising this concern. I checked with the people who raised the Dask issue that depends on this fix and they don't need this urgently, so let's wait for NumPy 1.17 to be released.

Now NumPy 1.17.0rc1 is released. I have locally confirmed that this fix works correctly. Thanks!
Jenkins, test this please.

Jenkins CI test (for commit efde8caa6d15b0feecab5f0f3e1d7717f1ef1437, target branch master) failed with status FAILURE.

I had to do a few changes, using _implementation is discouraged due to that being a private NumPy attribute (see comment https://github.com/dask/dask/pull/4822#discussion_r295986153), and several complications that arise from that, a detailed discussion can be found here.
The general suggestion for now is to have a wrapper to those functions, as per https://github.com/dask/dask/pull/4822#issuecomment-504178937.
That said, I have done exactly that, created functions to mostly wrap the NumPy implementation.

I see. I agree to create functions which wrap the NumPy implementations.
Could you rename the title of this PR?

I see. I agree to create functions which wrap the NumPy implementations.
Could you rename the title of this PR?

Done.

@asi1024 new commits should address the issues pointed out by you, let me know if there's anything else.

LGTM excepts the comment.

Jenkins, test this please.

Jenkins CI test (for commit ceca7bce30bc33a90d352458188ae539b5e5be8e, target branch master) failed with status FAILURE.

Jenkins' failure doesn't look like it's related to this PR, can you confirm @asi1024?

Jenkins failure seems unrelated to this PR. Thank you for the PR!

Thanks for reviewing and merging this @asi1024 !


Fill out dependencies in Azure deployment

High Level Description

Quite often templates will fail to deploy because a resource that is required by zero-th master NIC is not available. That is because the current master NIC resource template only waits for the 2200+ indexed SSH port rules to be established. Rather, all of them should wait for the rules that are consistently named regardless of master count
Also hard codes the rule names that are not indexed across the masters given that there can only be one anyway.

Related Issues

Azure PR checks fail with errors like this: https://teamcity.mesosphere.io/viewLog.html?buildId=602849&buildTypeId=ClosedSource_Dcos_IntegrationTests_CloudIntegrationTests_DcosOssAzureIntegrati_2&tab=buildLog#_focus=435

Checklist for all PR's

[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here: This will be exercised by existing Azure integration tests.
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@spahl can you please review?

Failure with the vagrant integration test around ucr and pid isolator is flaky.


Update visual-studio-code-insiders to 1.23.0,95101bf3f6d00105621cdddb639ea62b95ea2468

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Strange, looks like my SHA256 isn't right, as calculated by cask-repair:
$ openssl sha -sha256 visual-studio-code-insiders--1.23.0,95101bf3f6d00105621cdddb639ea62b95ea2468.zip
a4335f2b8680c84c37f6b108bf453451b6f535b3fa1e775da15ed6956d058762
$ shasum -a 256 visual-studio-code-insiders--1.23.0,95101bf3f6d00105621cdddb639ea62b95ea2468.zip | awk '{ print $1 }'
a4335f2b8680c84c37f6b108bf453451b6f535b3fa1e775da15ed6956d058762
$ shasum -v
5.96
$ which shasum
/usr/local/bin/shasum

While the appcast url confirms with Travis…
https://vscode-update.azurewebsites.net/api/update/darwin/insider/VERSION
"sha256hash":"ca47a2626eb2d017600a3d06b66c80d333b6c7d815a26c5b7defb315c9252194"

Running script.sh...

>>> brew cask _audit_modified_casks daa150abd5f6b14f405ff6a0a23a4927bcff32d3...21a775d7e40678336dae039dc742d17c4890b8e8
==> 1 modified cask: visual-studio-code-insiders
==> Downloading https://az764295.vo.msecnd.net/insider/95101bf3f6d00105621cdddb639ea62b95ea2468/VSCode-darwin-insider.zip
==> Verifying checksum for Cask visual-studio-code-insiders
==> Note: running "brew update" may fix sha256 checksum errors
audit for visual-studio-code-insiders: failed
 - download not possible: Checksum for Cask 'visual-studio-code-insiders' does not match.

Expected: a4335f2b8680c84c37f6b108bf453451b6f535b3fa1e775da15ed6956d058762
Actual:   ca47a2626eb2d017600a3d06b66c80d333b6c7d815a26c5b7defb315c9252194
File:     /Users/travis/Library/Caches/Homebrew/Cask/visual-studio-code-insiders--1.23.0,95101bf3f6d00105621cdddb639ea62b95ea2468.zip

To retry an incomplete download, remove the file above.
Error: audit failed for 1 cask: visual-studio-code-insiders

Yes, definitely something strange here. Have checked multiple times and I also get the checksum:
a4335f2b8680c84c37f6b108bf453451b6f535b3fa1e775da15ed6956d058762

By running cask-repair, openssl sha -sha256 and shasum -a 256.

Thanks. Glad it's not me. Thinking Microsoft's SHA256 is wrong or their system is out of sync.

Opened an issue with Microsoft: https://github.com/Microsoft/vscode/issues/47446

Microsoft pushed an update, confirmed the SHA256 matches now.


Reading position walks backwards when switching display settings

This issue is a:

Bug report

Expected behaviour
The user's reading position should stay fixed when switching between display modes (double column to single column spread)
Observed behaviour
Instead the reading position "walks" backward every time there's a change between double column and single column and continues until the start of the spine item (chapter) if repeated multiple times.
Steps to reproduce

Open a book and navigate to the middle or end of a long chapter
Make sure the browser window is maximized and set the display setting explicitly to double columns.
Switch to single column then observe the reading position
Switch back to double column, observe the position
Repeat steps 3 and 4 until you reach the start of the chapter.

Test file(s)
Accessible EPUB3 sample
Product

Readium cloud reader app

latest development build uploaded at https://readium.firebaseapp.com

Web browser

Chrome

Operating system

OSX

Additional information
This could also happen when changing font sizes, but I have not tested this.
You can do this with less clicking from the JS console by entering:
ReadiumSDK.reader.updateSettings({syntheticSpread:"single"})
ReadiumSDK.reader.updateSettings({syntheticSpread:"double"})

I am not able to reproduce with https://readium.firebaseapp.com/?epub=epub_content%2Faccessible_epub_3
Perhaps another EPUB?

I am able to reproduce with https://readium.firebaseapp.com/?epub=epub_content%2Fmoby_dick
That's because there is a MediaQuery that changes the font-face from serif (two-page spread) to sans-serif (single page), so each time there is a switch, the character in the upper-left corner ("reading location") changes. Thus the "walking backwards" effect.
Although this is a very annoying behaviour, it actually totally makes sense given the current implementation of the "reading location" logic (character in the upper left corner). We could fix this by changing the definition of the "reading location", maybe by using a similar to the URL goto parameter (and the "share location" feature) which preserves the JSON for Readium's "open book data" content pointer. Technically it's easy, the main challenge is to define when the "reading location" is set, when it gets reused (i.e. settings change, TOC show/hide, viewport resize, etc.), and when the character in the upper-left corner is used.

@danielweck: here's a link to a screen capture of the bug on https://readium.firebaseapp.com/?epub=epub_content%2Faccessible_epub_3
https://www.dropbox.com/s/3rap04ou4y1myb7/moonwalk.mov

I was able to work around this issue by following these steps:

When any navigation action (except orientation change) occurs, store the first visible CFI from the resulting location that was navigated to. Also store the current orientation at time of navigation action.

When orientation changes, do nothing. (i.e. do not store the first visible CFI or the new orientation after orientation change).

When the orientation changes back, navigate to the stored first visible CFI.

It's a good workaround, I agree.
But let's try to fix the "accessible EPUB3" case, because in principle the single vs. double page switch should not result in shifting characters (reading location in the upper-left corner should be stable).
As mentioned on the concall, I will try to reproduce this behaviour on my secondary display (I can't on my laptop, maybe this issue is sensitive to screen resolution).


Refactored: Fix spaces and missing semicolons.

PR Summary
Refactored files.

[x] Added semicolons
[x] Added and deleted spaces
[x] Added loop-array length variable in for-loop.  The for-loop performance will be improved.

Lint Results
Before
$ grunt jshint
>> 281 errors in 43 files

After
$ grunt jshint
>> 53 errors in 43 files

Reviewed and thanks.


Implement Seek trait for readers

ISSUE 9 - Implement Seek trait for readers
Fixes #9
Description

create and append will now return a WriteStream instead of a box, which will contain the inner stream which supports Write and may support Seek (according to the protocol).
read will now return a ReadStream instead of a box, which will contain the inner stream which supports Read and may support Seek (according to the protocol).

Type of change
Please select relevant options.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist

[x] My code follows the contribution guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I formatted the code with cargo fmt
[x] I checked my code using cargo clippy and reports no warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] The changes I've made are Windows, MacOS, Linux compatible (or I've handled them using cfg target_os)
[ ] I increased or maintained the code coverage for the project, compared to the previous commit

Acceptance tests
/

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 62 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-8.5%) to 70.736%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/fs/mod.rs
0
2
0.0%

src/fs/stream.rs
0
60
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-8.5%

Covered Lines:
394

Relevant Lines:
557

💛  - Coveralls


Implement Parallel Processing for Performance Improvement

The current processing of audio and video files in PySubtitle is sequential, which can be slow for large files. Implementing parallel processing can significantly improve performance.
Tasks:

Investigate and implement parallel processing techniques for audio extraction and speech recognition.
Ensure that the parallel processing implementation is thread-safe and efficient.
Update the documentation to include information on performance improvements.

concurrent.futures is probably and easy way

Yes but have already add it on your last pull req. It will be good if each new addition to the code is made on a branch associated with the issue concerned. This allows better visibility


WIP: Fix samplecount bug

in PreaggregateConversions (https://github.com/rackerlabs/blueflood/compare/master...tilogaat:fix-samplecount-bug?expand=1#diff-b643ac2bbdc21b81d8434e67b8c56026L73) withCount was being invoked by passing the sampleCount and the Count was always being set to the sampleCount value in the counterRollup class. A side effect of this is that sampleCount should have been long, but was mistakenly set to int.

Closing it in favor of #453


update the timestamp of the events in same SQL statement with state transition

Old:

UPDATE ae_active_job_state_job_states SET ae_active_job_state_job_states.updated_at = '2021-06-21 17:24:22.076344', ae_active_job_state_job_states.status = 'running' WHERE ae_active_job_state_job_states.id = 1
UPDATE ae_active_job_state_job_states SET ae_active_job_state_job_states.updated_at = '2021-06-21 17:24:22.079012', ae_active_job_state_job_states.started_at = '2021-06-21 17:24:22' WHERE ae_active_job_state_job_states.id = 1

New:

UPDATE ae_active_job_state_job_states SET ae_active_job_state_job_states.updated_at = '2021-06-21 17:27:17.601070', ae_active_job_state_job_states.status = 'running', ae_active_job_state_job_states.started_at = '2021-06-21 17:27:17' WHERE ae_active_job_state_job_states.id = 1

https://trello.com/c/RjzTfmAk/1282-optimize-aeactivejobstate


Add add_chapter() as alias for add_page()

This provides the option for a more natural-sounding API when generating books.

Coverage decreased (-0.6%) to 98.214% when pulling 8b2423a335d38f65ce29ca0fbe93b4cc14497d1f on elebow:add-chapter-alias-for-add-page into 255577350fc2aa428073592bf9d9fe15fd110fa7 on anqxyr:master.

Not totally sure about this one, will need to think a bit about it.
Either way, I don't like this class-level attribute assignment aliasing. If I end up merging it, I'll rewrite it as a proper method first.

My reasoning for preferring a class attribute for aliasing is that the method signature only has to be maintained in a single place. Any changes to the arguments of add_page() will be automatically reflected in the alias.
That said, here is a branch using a separate method, if you decide to merge the functionality: https://github.com/elebow/mkepub/commits/add-chapter-alias-for-add-page-method. I can update this PR if you'd like.


Core data (in go) call of metadata to check device name/id not working

Core data should allow a check of the existence of the device in any event to be checked in metadata.  Does not appear to be working.  This should also be a configurable option to turn or off the check based on level of trust the user has with data reported by device services (check at first and turn off later when the device is known to work well).

I'm going to close this one as a duplicate of #128


Beauty

The design systems for Nix you've been cooking up recently are looking great.
I haven't tried out flake parts or std or similar systems yet; but the style you have here with interfaces and implementations split with modules to typecheck is really appealing.
In the future I'm hoping to carve out the time to explore these because it seems like it would save me from a lot of bespoke patterns I keep iterating through.

Since you mentioned std. I'm tinkering with an idea:
{
  inputs.std.url = "...";
  outputs = {std, self}: std.growOn {
    cellsFrom = ./nix;
    cellBlocks = with std.blockTypes [
      # assumes ./nix/<cell>/packages.nix
      # to contain drv-parts modules
      (drvParts "packages" {ci.build = true;})
    ];
  }
  {
    packages = std.harvest self ["mycell" "packages"];
  };
}


Translated to Japanese 20200321

Signed-off-by: TakaoShimizu<EMAIL_ADDRESS>/kind content
/kind transalation
/area documentation
What this PR does / why we need it:
Useful for Japanese

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leodido
You can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I added dco. What should I do for merge to Master?

/assign @leodido

LGTM label has been added.  Git tree hash: 618c328d26605b87db095e6bd74c0e296a7621d4

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign fntlnz
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign fntlnz
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign fntlnz
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Already, falco.org has dropdown list for language.
Can we merge to Master?
/assign @fntlnz

@TakaoShimizu we need you to remove the draft flag from the PR first :)

I also confirm that once this PR gets merged the dropdown will contain Japanese.
I tested locally too.

LGTM label has been added.  Git tree hash: b0f4964458f8ed37969ebf364cdc045fa7d5b364

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TakaoShimizu I noticed I could do the thing myself and removed the draft since you asked to merge to master and this LGTM

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz, leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz,leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Call operator are not supported

Try
. {dir}
& {dir}

The previous cache is not cleared is this case.

I think I understand what you mean.
Repro steps:
Explain something valid, and then try to explain .{} or & {}. The previous explanation will be shown again, together with an error.

@LaurentDardenne thanks for letting me know. I fixed it. Deploy is running, should be ready in under 10mins.


File rename (and some other operations) in FileSystem moves keyboard focus out of FileSystem

Godot version
v4.2.dev6.official [57a6813bb]
System information
Godot v4.2.dev6 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 6GB (NVIDIA; <IP_ADDRESS>40) - Intel(R) Core(TM) i5-3570K CPU @ 3.40GHz (4 Threads)
Issue description
File rename in FileSystem moves keyboard focus out of FileSystem
When a file is renamed in FileSystem, keyboard focus is lost. There doesn't seem to be any way to move focus back to FileSystem by using keyboard only. You need to click FileSystem by mouse.
Some other operations do the same. Losing the focus makes it quite annoying to make operations to multiple files.
Keyboard focus is lost:

rename
duplicate
create new folder

Keyboard focus is kept:

delete
create new script / text file / resource

Steps to reproduce

Select icon.svg
Press F2 to rename the file
Try to move in the FileSystem using keyboard or renaming the file again by pressing F2
-> nope, that doesn't work

Minimal reproduction project
N/A

@miv391 please assign me this issue.

I've experiences it all over the 4.2 releases!

Confirmed, seems reproducible both in 4.1.2-stable and 4.2-dev6. 4.2 has even worse issues with trying to do renames from keyboard only, but that's a separate bug.

Duplicate of https://github.com/godotengine/godot/issues/33126


BinanceApiRestClient connection question

What's a better practice? Should I close() the connection to the BinanceApiRestClient and create a new one when I need to, or keep a reference to it for each call and use the same instance?
Any reply appreciated...

The best practice is to re-use the same instance of the client.


Exporting colors doesn't export anything

The code in inventory.js seems to imply a dialog should open to select a save location, but this does not happen. A message saying “Exporting to colors.json/colors.json” shows up and goes away, but no file is exported anywhere as far as I (or spotlight) can determine.

Fixed in this pull request
https://github.com/getflourish/Sketch-Style-Inventory/pull/62

I have a small Sketch file, with 2 pages. One page has rectangles with all my colors. I choose Generate Color Inventory, a page labeled color inventory is created, an alert saying Analyzing Colors appears, and then the only thing that shows is a blank background. Perhaps I am using the plugin wrong or not doing steps in the right order. I certainly never see anything like Swatches. Can anyone illuminate?

Same issue as ChrisARaymond : generate only an empty artboard on a new page.
And if "export" is checked, no dialogue appears to save a file.
Many tries with different sort of selections, etc.
Sketch 3.5.1
Thanks

Updated the plugin to the new bundle format. Generate & Export should work again with the latest non-App Store versions.


[qc] Bug trying to launch the server

COmmand:
sct_qc -folder ~/qc_batch_processing/

Bug
Spinal Cord Toolbox (version: 3.0.3)
Running /Users/Tanguy/sct_3.0.3/scripts/sct_qc.py -folder /Users/Tanguy/qc_batch_processing/
Check folder existence...
Traceback (most recent call last):
  File "/Users/Tanguy/sct_3.0.3/scripts/sct_qc.py", line 58, in <module>
    _copy_assets(qc_path)
  File "/Users/Tanguy/sct_3.0.3/scripts/sct_qc.py", line 33, in _copy_assets
    shutil.copy2(os.path.join(assets_path, 'index.html'), dest_path)
  File "/Users/Tanguy/sct_3.0.3/python/lib/python2.7/shutil.py", line 130, in copy2
    copyfile(src, dst)
  File "/Users/Tanguy/sct_3.0.3/python/lib/python2.7/shutil.py", line 82, in copyfile
    with open(src, 'rb') as fsrc:
IOError: [Errno 2] No such file or directory: '/Users/Tanguy/sct_3.0.3/assets/index.html'

Data attached!
qc.zip

Duplicate of #1300.


Enh: Docs - authorization.md

Fix example note about service accounts

@erictune Are you the right person to review this?

This was duplicate of #309  and was merged with b6531ec3


Activity Text not rendering Curly Braces and text between them in Teams

When sending an Activity from out Teams App/Bot with Text containing curly braces*, the braces and text between them is not displayed in Microsoft Teams.  (Tested in Windows Desktop Client, IOS Mobile client)
*Curly braces: shown text { hidden text and hidden braces } shown text
When sending the same text in an Adaptive Card in the Attachments of an Activity there are no issues and the text is displayed correctly.
Example of a message (copy from Bot Framework Emulator, here displayed correctly) not displaying the curly braces and the text between them when opened in Microsoft Teams, as reproduction step:
{
  "type": "message",
  "serviceUrl": "https://7505-81-82-247-96.ngrok.io",
  "channelId": "emulator",
  "from": {
    "id": "bdde1c80-68a7-11ec-977e-239e4f47d82a",
    "name": "Bot",
    "role": "bot"
  },
  "conversation": {
    "id": "d48cafb0-6d6f-11ec-977e-239e4f47d82a|livechat"
  },
  "recipient": {
    "id": "8aaa72b4-df3e-4d0f-b11e-cf3aca74f1b9",
    "role": "user"
  },
  "locale": "en-US",
  "text": "I did not find any files in **random folder name {w}ith braces**.",
  "inputHint": "acceptingInput",
  "attachments": [],
  "entities": [],
  "replyToId": "6871a3a0-6d72-11ec-86bc-170dcc4eb344",
  "id": "69790180-6d72-11ec-86bc-170dcc4eb344",
  "localTimestamp": "2022-01-04T16:24:30+01:00",
  "timestamp": "2022-01-04T15:24:30.488Z"
}

Acceptance criteria: Just displays the text and curly braces as expected.
Workaround: Replace the curly braces with their Unicode equivalent ({ with { and } with }).

@JordyGit - We are looking into this issue. We will update you.

@JordyGit - We are able to repro this issue and we have raised a bug for it.
We will let you know once we get updates on it.

@JordyGit -  We are checking it with engineering team and let you know the updates

any updates?

@JordyGit, @i-rox - Curly braces {} are special characters in Markdown and have to be escaped for them to render:
Basic Syntax | Markdown Guide
If you change the text to the following it will work:
"I did not find any files in random folder name \{w\}ith braces."
Please note the backslash itself is special character so it also needs to be escaped.

Still notable all other special characters work without the need for escaping them except { or }

I tried escaping them with \ or \ but teams displays them so still i use my own workaround of replacing them with { or }

@JordyGit - We have tested below text with \ and we are getting curly braces and text between them.
"I did not find any files in random folder name \{w\}ith braces."

Could you please check and confirm on this?

Maybe it has been fixed in the meantime. I can check later when working on the app again. It's ok to close it for now. If not fixed I'll come back to this issue.

We are closing this issue for now. Please feel free to reopen if required.


stalwart-mail: 2024-11-07

Updates the mailserver and its frontend to the recent tags published at 7th November.
https://github.com/stalwartlabs/mail-server/releases/tag/v0.10.6
https://github.com/stalwartlabs/webadmin/releases/tag/v0.1.18
https://github.com/stalwartlabs/webadmin/releases/tag/v0.1.19
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This looks good to me, leaving another day open to give a chance to ofborg to finish.

how do we feel in general about backporting non breaking bumps of stalwart to stable channels? As we have a brand new release branch, we could cleanly start with that if we like to do so.
I am mainly asking as i am thinking about switching my machine that hosts the mail server back to stable channels again and that might make my maintainance easier.

I dont think youll encounter opposition as long as you are willing to test backports yourself


[improve][broker] Log warning on missing URL configuration for cluster creation/update

Master Issue: #19866
Motivation
As proposed in https://github.com/apache/pulsar/issues/19866#issuecomment-1582407793, warning message can be provided on existence of URL verification fails.
Modifications

For Cluster create/update API, log warning when service url or broker url is missing.

Verifying this change
Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Thanks for your contribution! I'm checking this patch now.
Please revert the format only changes (whitespace) so that we narrow the conflict possibility.

Merging...
Thank you!


spec_helper refactoring and fixing Scan tests

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context

some methods (like with_env_values) are defined in more than one spec_helper.rb, with the same signatures and functionality
they also have different behavior. For example, the method below does not accept any block (contrary to what the comment says), which means that the block passed in is ignored (sic!), and any test code inside the block does not get executed. See #14502 for a demo.

https://github.com/fastlane/fastlane/blob/875e3482906044a4f9806dc869c8813d3a2e9a57/fastlane_core/spec/spec_helper.rb#L36-L43

stubbing.rb does not seem to add any value, so I simply moved its content into spec_helper.rb to have less entities. If the team feels strongly about having it as a separate file, I will delete that commit from this PR
from several implementations of with_... methods (some more permissive than others) I picked / reimplemented with the following principles:

always take a block (this is a common convention for with_... methods in rspec. Ruby developers would expect it to take a block). Despite stub_const looks very pretty to use, it does not allow to limit scope (the scope always equals that of the whole it block) and requires a different naming convention (ex.: stub_env_values)
complain if the method is called without block (dropped unused feature to "permanently change environment variable" because it's not useful - ENV['MYVAR'] does the same).

Uh-oh, I've no idea what happened on AppVeyor. Time to dust off my virtualbox and download some Windows images.

The tests failing are those which were not running before the fix. See #14502 which "breaks" them but they keep passing.. Looks like they are severely out of date and can be removed. WDYT?

Ugh, I had looked at that with_env_values a bit ago and wondered how it works - but assumed I must be missing some magic here. How did you discover this?
Left some comments.

Oh, pretty recent that test even. Well, I think nobody will miss those tests then. Bye 👋

After sitting for a while staring at the code over the weekend, I decided that it's worth fixing these tests. PTAL?

Is there anything else I can do for this PR?

No, I think we are just waiting for someone with more ruby chops to come along from the team and leave an "Approve" review. I don't fully trust myself here.

Hey there friendly Fastlane team, may I humbly request some feedback for this PR? It's blocking some of the further contributions I have in queue.


Bumb TibberLink stable to 2.2.0

PR tries to update to 2.2.0 .... if 2.2.1 with only 4 days would be ok - I'll change the PR


CVE-2017-5929 - Logback dependencies update

https://nvd.nist.gov/vuln/detail/CVE-2017-5929#vulnDescriptionTitle

According to https://nvd.nist.gov/vuln/detail/CVE-2017-5929 "QOS.ch Logback before 1.2.0 has a serialization vulnerability affecting the SocketServer and ServerSocketReceiver components." so either you update to a version greater than or equal to 1.2.0 or find a way to persuade them to change the issue, considering that from https://logback.qos.ch/news.html "Release 1.2.0 fixes a rather severe serialization vulnerability in SocketServer and ServerSocketReceiver." and the ticket they refer to (https://jira.qos.ch/browse/LOGBACK-1231) affects version 1.1.8.

Odd, the CPE configuration on https://nvd.nist.gov/vuln/detail/CVE-2017-5929#vulnConfigurationsArea says

versions up to (including) 1.1.10

Changing to Logback 1.1.11 should satisfy that requirement.

Actually you are correct! I just checked and the fix was to convert to variables from int to long.
That fix is not present in the 1.1.11 branch.
I'll reopen this and update to 1.2.0.

versioneye and coverity are both unreachable today; if those turn up green, we can close this item.

coverity is green ,versioneye still giving http 508 errors

I already released v1.1.5 5 days ago. I think we should close this.

i am waiting for versioneye website to confirm the fix for the cve ,thats why this was still open.

It's at least 8 days that VersionEye website is unreachable: https://github.com/versioneye/versioneye/issues/730 :/

maybe we shoud change to another dep analyzing service then

versioneye is shut down : https://blog.versioneye.com/2017/10/19/versioneye-sunset-process/

I have added skyp.io deps analysis service; skyps rerport shows logback vuln is fixed, but log4j isnt;  Introduced through: javabeanz/owasp-security-logging@javabeanz/owasp-security-logging#38dce79070bb868a9c734cb24cbfb6fece629c05 ›<EMAIL_ADDRESS>Remediation: Upgrade to<EMAIL_ADDRESS>with CVE-502 https://cwe.mitre.org/data/definitions/502.html


Incompatibility with carryon+

I got a crash when I tried picking up a backpack using carryon+ ....idk if it is an issue with your mod or the other.
https://pastebin.com/e0pGsrFV

Somewhat of a duplicate of #92. See asiekierka's response here. But I'm leaving this open since it's still a reoccurring issue.
I'm not sure how CarryOn manages to mess up our "facing" value. It could also be an issue on our end but I wouldn't know. I suggest you contact the CarryOn+ developer(s) and let them know. In the meantime, blacklist backpacks from being carried.


SA1405 (DebugAssertMustProvideMessageText) exception for user-defined Debug.Assert

If the user defines their own Debug.Assert method as follows, and then calls it with one argument, an ArgumentOutOfRangeException is thrown. This is caused by an assumption in SystemDiagnosticsDebugDiagnosticBase.HandleMethodCall that symbolInfo.Parameters.Length equals invocationExpressionSyntax.ArgumentList.Arguments.Count.
namespace System.Diagnostics
{
    internal static class Debug
    {
        public static void Assert(bool condition, string message = null)
        {
        }
    }

    internal static class ClassName
    {
        public void Method()
        {
            Debug.Assert(false);
        }
    }
}

:memo: This actually happened.

grabbed


Rewrite expunge

This PR rewrites the expunge() method in ImapFolder to ensure that only messages that were marked with the \Deleted flag by K-9 Mail are expunged. This process is described in section 4.2.4 of RFC 4549

Rebased in #2927


create a new middleware jsonIndentMiddleware

This is a way to replace the jsonAdapter option by a middleware option.
It could be a lot of code and complexity for a small win.
But it also provides more options (prefix and indent strings)

Closing, replaced by this: https://github.com/ant0ine/go-json-rest/pull/121


NoiseReduce Service Added

@ankykong Thank you so much for this and so sorry for the loooooong delay. :pray:  This needs a rebase and added a few minor comments. But looks great!

This has been implemented here: https://github.com/pipecat-ai/pipecat/pull/611


Fixed DeprecationWarning, updated deps

(node:70907) DeprecationWarning: Tapable.plugin is deprecated. Use new API on '.hooks' instead

@quackes Are you going to take a look at this? After that PR, I want to suggest one improvement that will solve this issue: https://github.com/webpack/webpack/issues/8521. If you are not going to support this package, then I will fork it and will support it myself. Just say it.

Hey,
thanks for submitting the PR.
I will try to find time this evening.
I appeciate your effort!
Greetings :)

Am 10.03.2019 um 12:50 schrieb Ivan Rudoy<EMAIL_ADDRESS>@quackes Are you going to take a look at this? After that PR, I want to suggest one improvement that will solve this issue: webpack/webpack#8521. If you are not going to support this package, then I will fork it and will support it myself. Just say it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Nice Work thank you very much. I will update the test sample a little, and try a few things and publish this asap.

Thank you 😄


Linux support

I've reshuffled things around a little, they almost match your initial commit in this PR. When it comes to abstracting targets, I think that in the beginning implicitly agreeing on the interface between different Process implementations should be enough - I don't think there is any need for a wrapper Target just yet. This also kinda mirrors what we already do in terms of c API in Zig's libstd in os.zig and c.zig.


⚠ ClamAV has degraded performance

In b8881ed, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 458 ms

Resolved: ClamAV performance has improved in aac6a5f.


added histogram ai critic feature

kindly review this and tell me if I can improve the histogram in any way

Hi @benslamahafedh , I am not really convinced with this design.
I will try to add data about what we need to display and maybe add some frames and then we can open the issue again.
Therefore I need to close this MR.
Thank you Hafedh for the contribution!