Remove all dynamic property lookups from HystrixRollingPercentile

In practice, modifying the HystrixRollingPercentile data structure at runtime doesn't have the desired effect.  Modifying the data structure to actually allow for this is not straightforward and would cause data loss in some cases (when the window gets shortened).  Rather than allow for dynamic reconfiguration, this PR removes all instances where dynamic properties are queried at runtime.  It increases throughput on reads (while command executions are ongoing) by 40-60%.  In particular, caching the value of bucketSizeInMilliseconds avoids calling the division operation multiple times per read and write.

NetflixOSS » Hystrix » Hystrix-pull-requests #127 FAILURE
Looks like there's a problem with this pull request

NetflixOSS » Hystrix » Hystrix-pull-requests #128 SUCCESS
This pull request looks good


Update importTable to represent directory list as String[] instead of String

In #1060 we add the ability to specify multiple directories for the importTable command. The current API for importTable expects multiple directories to be specified as a single, possibly comma-delimited String. @keith-turner raised the fact that the API should more explicitly reflect reality of the data it seeks to represent and take a String[] instead of a String.
We should try to get this in for 2.1.0

Seems like a good idea, but I'd suggest Set<String> instead of String[]

Per @arvindshmicrosoft comment on #1060, this will include documentation updates for the importTable workflow.

Missed something, ImportExportIT failed in https://jenkins.revelc.net/job/2.1/75/


Refactoring button variants

We added the mobile button sizes to design guide.

we updated button variants with 2.0.0 https://trendyol.github.io/baklava-react-native/?path=/docs/components-button--page


use Standard

Closes https://github.com/Level/level.js/issues/100
To be squashed.

I'll get this merged in before https://github.com/Level/level.js/pull/111 and rebase that after


added fix in contributing guide for error when running locally

Pre-Submission Checklist

[X] Your pull request targets the staging branch of FreeCodeCamp.
[X] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[X] You have only one commit (if not, squash them into one commit).
[X] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[X] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[X] Tested changes locally.
[ ] Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

Applied change in contributing guide for solution to possible problem when trying to get FCC running locally.

I think this is submitted correctly now.

@bonham000 can you please do git pull --rebase upstream staging and reslove any merge conflicts that you have. It looks like CONTRIBUTING has changed since you made your fork

Closing this PR since we merged https://github.com/FreeCodeCamp/FreeCodeCamp/pull/11879#event-877658761


Crash in build 0.5.3-beta3 on Android 7.1.2.

Hi, I was using build 0.5.3-beta2 on my latest release, and looks like everything was working well, but I have crashes on Android 10 devices:
Caused by java.lang.IllegalArgumentException
Invalid column COUNT(*) AS count
I saw that in latest release 0.5.3-beta3 you wrote that you have fixed this, but after update to this version, the app is constantly crashes when I try to open selection screen. Can't give you logs, because my phone for some reason don't show them. Can you please try to reproduce this and fix? Thanks.

Did you try to update the glide engine. It worked in our case to use
implementation 'com.github.bumptech.glide:glide:4.11.0'
in the build gradle


Create print_character_of_an_ascii_value.php

Why:
Closes #ISSUE_NUMBER
What's being changed:
added php program to print character of an ascii value

Please link the issue number.
Thank you!

@victoriacheng15 linked now check


Adding missing emitter code from big merge

Signed-off-by: Ricardo Koller<EMAIL_ADDRESS>

[Current coverage][cc-pull] is 44.21%

Merging [#79][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.17%

@@             master        #79   diff @@
==========================================
  Files            29         29
  Lines          3548       3564    +16
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1575       1576     +1
- Misses         1973       1988    +15
  Partials          0          0

Powered by Codecov. Last updated by [613828d...4ccb9ae][cc-compare]
[cc-base-branch]: https://codecov.io/gh/cloudviz/agentless-system-crawler/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/cloudviz/agentless-system-crawler/compare/613828dde2792912c66def9ffd6c2ec92db896a2...4ccb9ae32b4476865de7823475dcfdffb0b062bb?src=pr
[cc-pull]: https://codecov.io/gh/cloudviz/agentless-system-crawler/pull/79?src=pr

@duglin @MHBauer @sastryduri we need this one ASAP for the watson package, I missed this during the big merge. The package will be broken @sastryduri unless this code is in.

What's up with the fiu.edu email? Can you sign it with your IBM email instead?

@MHBauer Amended the commit

@ricarkol please use your ibm email, not gmail

Sorry for that. Amended the commit with the correct email this time.


Bug: Error Unknown switches "--help"

Description
Error accessing helper
How to reproduce
When accessing the --help parameter the error is returned
What do you expect
Parameter list
What happened instead
Unknown switches "--help"]
Software:

Gem version: 0.0.2
Ruby version:  2.6.5

This is actually something that Thor doesn't support out of the box. You can issue --help on tail (e.g. dopstick --help), but have to use dopstick help command to show help for a given command.
I'll see what I can do.


Message control menu icon

Click Target Area:

Reordered Icons:

Tooltip:

@SiddharthVarshney next time please write a proper description of the change in the PR title; "Messagebox" is pretty non-specific :)

@timabbott I have updated the commit message, can you review this?

Please update the PR description, too.

Yeah, I will make that those changes

I don't think I agree with the reordering; the star being on the outside makes things look a lot better when the message isn't hovered.
Also, does this change end up increasing the width of the message controls area a lot?  That can be problematic on mobile web by reducing the available horizontal space for follow-up messages.

I'll remove that reordering commit.
And yes there is an increase of the width of message controls(by 10px in total). But giving a large area also help on touch devices where the finger cannot be that precise as a mouse click.
In mobile view, this is the current state

Follow-up message:

(the icons on the text was a previously present issue)

Re: tooltips, I think we want to make them all JS rather than removing the one that is.  @vinitS101 FYI.

I guess I'm OK with the sizing changes; we should deploy and get feedback.  And of course figure out a solution for that overlap issue on mobile sizes.

I have already added a tooltip to the menu icon as part of #14539. (The stars are left)

I removed the reordering and tooltip commit @timabbott

OK, after testing this somewhat extensively, I merged this as 476808128c6208e9d0b05966688f8185b56ad410 with a few changes:

Renamed message_star semi-duplicate div name to star_container.  I think we might want to rename the star CSS class to message_star too for readability and better uniqueness; would you be up for doing that in a follow-up commit?
Fixed a bug where the star positions were vertically off before a message had been hovered and in the mobile view.
Some small offset adjustments that effectively revert the increase in width of the component.

I'd really appreciate your doing some extensive QA on this to look for further problems.
And @ryanreh99 can you test ASAP to make sure this PR didn't break the "resend message" CSS, both in the web and responsive mobile designs?  Thanks!

And @ryanreh99 can you test ASAP to make sure this PR didn't break the "resend message" CSS, both in the web and responsive mobile designs?

Tested this for both cases and it lgtm. 👍


Dependency symfony/inflector is abandoned

PHP Version
irrelevant
Shopware Version
any 6.x
Expected behaviour
Should not be dependent on an abandoned piece of software.
Actual behaviour
Depends on symfony/inflector
See: https://packagist.org/packages/symfony/inflector
How to reproduce
Just call
composer update --dry-run
in your project root.
And when it tells
Package symfony/inflector is abandoned, you should avoid using it. Use EnglishInflector from the String component instead.
than you see that warning, that I am talking about.

Thanks for pointing out the issue, sadly we can not drop the dependencies in a minor release, but we will remove those dependencies in the next major version.
I created a official issue tracker ticket for that and will close this issue for now.
https://issues.shopware.com/issues/NEXT-23972

See your other issue for the answer.


Mention the snap package for easier install

Hi, we are deprecating snaps. They are not mentioned for this reason. See https://github.com/ipfs/ipfs-cluster/issues/593

Sorry, I mixed cluster website with IPFS :/


Do we want a class based interface?

Currently the interface is the single function matheval::parse.
Pros: It carries no state. (that is not entirely true, the grammar is a static variable inside the function for faster evaluation on subsequent calls).
Cons: It carries no state.  That means if we only change the symbol table for an otherwise unmodified AST, we pay the cost of parsing again.
A class interface could look like this:
matheval::Parser<double> parser;
parser.parse("x+1");              // parses the expression and stores it's AST
parser.register_symbol("x", 1);   // add a symbol to the table
double two = parser.evaluate();   // evaluate the AST with the given symbols
parser.register_symbol("x", 2);   // overwrite the existing symbol
double three = parser.evaluate(); // evaluate the AST with the new symbols (no re-parsing required)

The problem I see here is that it is way more verbose.  Also it makes the parser somewhat non-local which might make it hard for users to track where they registered which symbol and which expression is currently stored.

Fixed in 0274e0a2e4803a922f5f713758c1ac779d958f2a.


Allow traefik requests and limits customization

This pull requests adds a new variable to hold traefik requests and limits values. Defaults are the current values used on helm but can be customized by the end user.

@mysticaltech got another one for you, easier to review though ;)


Release 3.0.0 to develop

What
Release 3.0.0 to develop
Why
Sync https://github.com/stellar/stellar-disbursement-platform-backend/pull/475 back to develop.
Checklist
PR Structure

[x] This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR title and description are clear enough for anyone to review it.
[x] This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

[x] This PR adds tests for the new functionality or fixes.
[x] This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

[x] No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
[x] No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
[x] No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
[x] No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

[x] This is not a breaking change.
[x] This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

[x] Does the deployment work after merging?

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr476.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr476.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr476.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr476.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr476.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr476.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr476.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr476.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr476.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr476.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr476.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr476.previews.kube001.services.stellar-ops.com


Question about k_thread_entry_t and k_thread_create

Hello everyone, I was navigating through various drivers using threads to do background work and I noticed that almost everywhere there are thread creations that use functions with a different definition than the k_thread_entry_t.
For example at adt7420_trigger, we can see that the adt7420_thread function has only two params and both have different type than (void *):
https://github.com/zephyrproject-rtos/zephyr/blob/4c3bcbafef27b690273fc5e1b14b18d76a35b5d3/drivers/sensor/adt7420/adt7420_trigger.c#L129-L133
https://github.com/zephyrproject-rtos/zephyr/blob/4c3bcbafef27b690273fc5e1b14b18d76a35b5d3/drivers/sensor/adt7420/adt7420_trigger.c#L57
https://github.com/zephyrproject-rtos/zephyr/blob/eac2f7c76399bb4b30b6f2aaeb253ca5fdfa1f95/include/kernel.h#L382

How does this work properly?
Is this a good practice or we should use methods with definition based on k_thread_entry_t and cast the params later on?

How does this work properly?

The other arguments are provided in registers or the stack when the new thread is set up, they are just ignored.

Is this a good practice

No, it's not.

So from what you said I guess that indeed the best solution is to use methods with a definition based on k_thread_entry_t.
Should we close this?

Yeah, this is an ABI violation, but it's harmless on existing architectures.


SOLR-16203: Initialize schema plugins loaded by SPI name

https://issues.apache.org/jira/browse/SOLR-16203

First attempt in efadf94dc6ac87027ef708c71c58d3848e7a9a0d:
Naïve solution, explicitly calling inform() in FieldTypePluginLoader. The two tests from JIRA are added to this PR to demonstrate.
There may be a more elegant place to do the init. We risk double inform if not using SPI since we don't check that here. Perhaps there is some method somewhere that could be called on the entire chain instead of in each init(), such as the one in ManagedIndexSchema#informResourceLoaderAwareObjectsInChain(). I did not dive deep here. Open to suggestions from folks who know the code better.

Second attempt:
The first attempt did not work for packages, since FieldTypePluginLoader#init was too early in the cycle to initialize analyzers from packages.
Managed schema handled the missing inform call after SPI already, so moved the method informResourceLoaderAwareObjectsForFieldType from ManagedIndexSchema to IndexSchema and use it at the end of IndexSchema#readSchema. All tests pass.

Thanks for nice proposals @uschindler , the method is now private and code cleaner


fix multiTooltip appearance with empty title

https://github.com/nnnick/Chart.js/issues/1039

+1
@nnnick @fntneves @fulldecent @derekperkins @tannerlinsley @jakesyl

Can anybody review this pull request? It is important for me because currently there is no way to display tooltip without a title.

@dima117 I think this is fine. I'm waiting for a comment from one of the people I tagged above before I merge it.

Thanx for your reply. I was afraid that my request was forgotten.
I am developing the scatter chart for the chart.js. I need MultiTooltip without title for display information about nearly located points (they may be related to different datasets). For example, look at the second chart on this page: https://github.com/dima117/Chart.Scatter

@dima117 Great work so far! I know a number of people will be interested in having that.

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain typeshape.com has exceeded the max emails per hour (1/1 (100%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from github-smtp2-ext4.iad.github.net ([<IP_ADDRESS>]:51826 helo=github-smtp2a-ext-cp1-prd.iad.github.net)
by whm01.mammoth.net.au with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.85)
(envelope-from<EMAIL_ADDRESS>id 1YgEJo-000mD4-6W
for<EMAIL_ADDRESS>Fri, 10 Apr 2015 01:24:42 +1000
Date: Thu, 09 Apr 2015 08:24:31 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
s=pf2014; t=1428593071;
bh=cO2edHTJ76kfqTHOb9KjSQrEO0WsxRgveHjRHF9T7WQ=;
h=From:Reply-To:To:In-Reply-To:References:Subject:List-ID:
List-Archive:List-Post:List-Unsubscribe:From;
b=XYUnQiuq9lLicAokLGKYWTgoGrSzmrqy/wSVo/AbHEUEXV4j42gTAOaDJkQ5m7mDg
KMArrUNUDatLpjvMgJQDjiEhnvuNAlwzVfXmOt3Dk15Tu3QWOgbwd4qCBv4qtgiERV
Va4LpH5YYxkZzcR+YAZhWqBPaNAIQpvwlL7UI3nM=
From: Evert Timberg<EMAIL_ADDRESS>Reply-To: "nnnick/Chart.js"<EMAIL_ADDRESS>To: "nnnick/Chart.js"<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [Chart.js] fix multiTooltip appearance with empty title (#1040)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_552699af7e1c9_2c193ff56847f2a09126f3";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: etimberg
X-GitHub-Recipient: thowmas
List-ID: nnnick/Chart.js <Chart.js.nnnick.github.com>
List-Archive: https://github.com/nnnick/Chart.js
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/AAzPAchu1zejyUzshem_-8P_pFpgnpMCks5n9pEvgaJpZM4D59hm
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>X-Spam-Status: No, score=-5.0
X-Spam-Score: -49
X-Spam-Bar: -----
X-Ham-Report: Spam detection software, running on the system "whm01.mammoth.net.au",
has NOT identified this incoming email as spam.  The original
message has been attached to this so you can view it or label
similar future email.  If you have any questions, see
root@localhost for details.
Content preview:  @dima117 Great work so far! I know a number of people will
be interested in having that. --- Reply to this email directly or view it
on GitHub: https://github.com/nnnick/Chart.js/pull/1040#issuecomment-91263344
[...]
Content analysis details:   (-5.0 points, 5.0 required)
pts rule name              description

-0.0 RCVD_IN_MSPIKE_H4      RBL: Very Good reputation (+4)
[<IP_ADDRESS> listed in wl.mailspike.net]
-0.0 SPF_PASS               SPF: sender matches SPF record
-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
2.1 HTML_IMAGE_ONLY_12     BODY: HTML: images with 800-1200 bytes of words
0.0 HTML_MESSAGE           BODY: HTML included in message
-0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
-0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
-5.0 RCVD_IN_DNSWL_HI       RBL: Sender listed at http://www.dnswl.org/, high
trust
[<IP_ADDRESS> listed in list.dnswl.org]
-0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
X-Spam-Flag: NO
----==_mimepart_552699af7e1c9_2c193ff56847f2a09126f3
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
@dima117 Great work so far! I know a number of people will be interested in having that.

Reply to this email directly or view it on GitHub:
https://github.com/nnnick/Chart.js/pull/1040#issuecomment-91263344
----==_mimepart_552699af7e1c9_2c193ff56847f2a09126f3
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
@dima117 Great work so far! I know a number of people will be interested in having that.
—Reply to this email directly or view it on GitHub.

----==_mimepart_552699af7e1c9_2c193ff56847f2a09126f3--

Does anyone remember about this PR?


Start styling the UI/UX Frontend

** Jon **
I haven't thought much about styling but it would be nice to have a some green in the colour pallette.

#8bc53f - yellow green
#050609 - rich black
#774936 - bole

@jonparker I've put a PR for the foundation styling... let me know your thoughts! Very weird working on something so separately from the rest of the team!!

Thank you, this is awesome. I've merged the PR in.

@jadetrue there's been a few updates to how endpoints are added in the UI.
It would be great to improve the styling on the edit form if you get a chance.
Also we should add more instructions in the form itself on how to create a webhook.
I guess there's lots of ways to make the UX more friendly.


Revert "3203 rendering tex errors"

Reverts twosigma/beaker-notebook#4685
breaks master because replacing a span with a div causes problems.
just changing it back doesn't work either.
also, the math with color is not working.
i think the throwOnError false option is not well enough supported by katex and we need to rethink how to handle errors.


MineCreators Mapping

MineCreators is a vibrant Discord server dedicated to content creators that has taken an exciting step in expanding its community into the Minecraft universe. In an effort to offer players unique experiences, we have introduced an exciting Bedwars mode. We're committed to providing an inclusive and fun space for the Minecraft community, and we won't stop there. In the near future, we plan to add other exciting modalities such as BoxPvP and Skywars to provide our members with a variety of challenges and thrills. Join MineCreators and be part of a community that is constantly growing and evolving. The adventure is just beginning!

Not sure why there is a zip file added

Where is the zip file?


Allow for YouTube Subscribe Functionality

Problem
YouTube subscribe is not supported.
Rationale
Adding a YouTube subscribe button would be awesome and allow users to see how many
people are subscribed to the channel, but also subscribe easily themselves. This would
work great for embedded videos.
Solution
I'll implement the YouTube subscribe button using the YouTube API. This will be dependent
upon expanding the config to allow for API keys and usernames.
Pros of Solution:

Shr will have a button that will allow users to subscribe on YouTube. This is helpful for embedded videos.

Cons of Solution:

Shr will handle more features, but is this something you want?

If you'd like to move forward, let me know and I'll submit a PR!

Sounds good to me! Another good idea 👍


Focus stacking may loose precision?

When I tried to do a stack it felt like I couldn't step at the resolution I could while I was in MDI. Investigate why

Motion controller has been really overhauled. I think its fine right now


Output of the discriminators.

Hi.
I can't get how it is guaranteed that the discriminators' outputs are in (0, 1)???
In either DiscriminatorS in hifi-gan/models.py or DiscriminatorP in hifi-gan/models.py, I cannot find sigmoid-like stuffs.
But while computing losses of the discriminators in your implementations, it seems the outputs are treated as it is probabilities.

Ok, now i've read the LSGAN paper.


Null safety feedback: return after Map containsKey test should be non-nullable

Given this:
  final Map<String, String> _specialWords = {
    "skis": "ski",
    "skies": "sky",
  };

This construct:
    if (_specialWords.containsKey(_word)) return _specialWords[_word];
should consider the return type to be acceptable as String rather than String?
Dart SDK version: 2.12.0-133.7.beta (beta) (Tue Jan 12 09:25:38 2021 +0100) on "linux_x64"```

The problem is that I can in theory overwrite the containsKey method in my own Map implementation to do something else and the analyzer will not have any clue about it.

The problem is that I can in theory overwrite the containsKey method in my own Map implementation to do something else and the analyzer will not have any clue about it.

Is it possible to do something like have the return type be "bool
@notNullIfTrue" so that it's part of the contract?
On Thu, Jan 21, 2021, 02:19 Jacob Bang<EMAIL_ADDRESS>wrote:

The problem is that I can in theory overwrite the containsKey method in
my own Map implementation to do something else and the analyzer will not
have any clue about it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/44721#issuecomment-764531854,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAC4FO7DPZPI5MG7NEZE4T3S275R3ANCNFSM4WK6RWOA
.

Is it possible to do something like have the return type be "bool
@notNullIfTrue" so that it's part of the contract?
On Thu, Jan 21, 2021, 02:19 Jacob Bang<EMAIL_ADDRESS>wrote:

The problem is that I can in theory overwrite the containsKey method in
my own Map implementation to do something else and the analyzer will not
have any clue about it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/44721#issuecomment-764531854,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAC4FO7DPZPI5MG7NEZE4T3S275R3ANCNFSM4WK6RWOA
.

FWIW you can rewrite your code as:
final specialWord = _specialWord[_word];
if (specialWord != null) return specialWord;

FWIW you can rewrite your code as:
final specialWord = _specialWord[_word];
if (specialWord != null) return specialWord;

/cc @leafpetersen @lrhn @eernstg

/cc @leafpetersen @lrhn @eernstg


[SPARK-23342][SQL][TEST] Add ORC configuration tests for ORC data source

What changes were proposed in this pull request?
This issue adds test coverage for ORC configuration with ORC names and Hive names.
Example:

orc.stripe.size, hive.exec.orc.default.stripe.size
orc.row.index.stride, hive.exec.orc.default.row.index.stride
orc.compress.size, hive.exec.orc.default.buffer.size

Note that these tests are added to both OrcSourceSuite and HiveOrcSourceSuite because both Spark native and hive implementation supports them. The followings are the related code.

Apache ORC 1.4.1 OrcConf.java
Hive 1.2.1 OrcFile.java HiveConf.java

How was this patch tested?
Pass the newly added test cases.

Test build #87100 has started for PR 20517 at commit 13a012f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/622/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/623/
Test PASSed.

Test build #87101 has started for PR 20517 at commit e51b2e7.

Test build #87100 has finished for PR 20517 at commit 13a012f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87100/
Test FAILed.

Test build #87101 has finished for PR 20517 at commit e51b2e7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87101/
Test FAILed.

Retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/633/
Test PASSed.

Test build #87117 has started for PR 20517 at commit e51b2e7.

Test build #87117 has finished for PR 20517 at commit e51b2e7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87117/
Test PASSed.


Refactor lakefs_export script output

Avoid temporary files
Don't read entire "rclone check" output into memory
Detect "rclone check" success/failure directly rather than via error
output

This is part of #4841 but obviously not a fix for it.

Thanks, @lynnro314 !
Updated docs with changed script envariables and will pull once tests green.


fix: When there is no browser, the app shouldn't crash

Hi everyone,
When a link can't be opened, an Exception is triggered, but was never caught in SmoothHtmlWidget.
We now show a message to inform the user.
It will fix #4719

Codecov Report

Merging #4729 (cc50145) into develop (2d90250) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #4729      +/-   ##
==========================================
- Coverage     9.90%   9.90%   -0.01%
==========================================
  Files          310     310
  Lines        15807   15812       +5
==========================================
  Hits          1566    1566
- Misses       14241   14246       +5

Files
Coverage Δ

...smooth_app/lib/generic_lib/smooth_html_widget.dart
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


dyld[15728]: missing symbol called

When running the example on the homepage. Mac M2

same on Mac M1 Pro


[util/topgen] Error handling: Absence of RV_PLIC Hjson

If rv_plic.hjson doesn't exist, the topgen will fail. The user shall manually generate rv_plic.hjson inside the top then run topgen.
Revise the topgen flow as below to solve this issue:

Reads IPs and ignore rv_plic at first.
Add interrupt to the top (up to amend_interrupt function in the merge_top function)
Generate RV_PLIC
Read RV_PLIC hjson object (returned value from generate_plic function) and add relative informations to the module list (rerun amend_ip for rv_plic only)
continue the rest of the topgen code.

This is related to lowRISC/stwg-base#743 lowRISC/stwg-base#802

This is a very old issue and it seems to be related to https://github.com/lowRISC/opentitan/pull/4944#pullrequestreview-575245310. @eunchan , do you want to check if this is done or still needed?

This is a very old issue and it seems to be related to https://github.com/lowRISC/opentitan/pull/4944#pullrequestreview-575245310. @eunchan , do you want to check if this is done or still needed?

Still need this IMO. Pirmin, do you see any error on secondary topgen? The secondary topgen does not have rv_plic.hjson at the beginning. I assume the topgen errors out , how did you solve?

Still need this IMO. Pirmin, do you see any error on secondary topgen? The secondary topgen does not have rv_plic.hjson at the beginning. I assume the topgen errors out , how did you solve?

I think the following code section in topgen.py solves this issue:
https://github.com/lowRISC/opentitan/blob/650bd0434abb173a568126f5e04a27685543f181/util/topgen.py#L1019-L1029
Basically, if the rv_plic.hjson in hw/{top_name}/ip/rv_plic is not available for the initial validation (this is the case for the secondary top levels), we use the one from hw/ip/rv_plic. The newly generated rv_plic.hjson is then validated again inside generate_plic().

I think the following code section in topgen.py solves this issue:
https://github.com/lowRISC/opentitan/blob/650bd0434abb173a568126f5e04a27685543f181/util/topgen.py#L1019-L1029
Basically, if the rv_plic.hjson in hw/{top_name}/ip/rv_plic is not available for the initial validation (this is the case for the secondary top levels), we use the one from hw/ip/rv_plic. The newly generated rv_plic.hjson is then validated again inside generate_plic().

Ah.. thanks for pointing out Pirmin.
Then, we can close. :)

On Jan 26, 2021, at 11:40 PM, Pirmin Vogel<EMAIL_ADDRESS>wrote:
I think the following code section in topgen.py solves this issue:
https://github.com/lowRISC/opentitan/blob/650bd0434abb173a568126f5e04a27685543f181/util/topgen.py#L1019-L1029 https://github.com/lowRISC/opentitan/blob/650bd0434abb173a568126f5e04a27685543f181/util/topgen.py#L1019-L1029
Basically, if the rv_plic.hjson in hw/{top_name}/ip/rv_plic is not available for the initial validation (this is the case for the secondary top levels), we use the one from hw/ip/rv_plic. The newly generated rv_plic.hjson is then validated again inside generate_plic().
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/lowRISC/opentitan/issues/28#issuecomment-768098665, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJDG3SYJ26G3EMRCJGT2SDS367NTANCNFSM4ISTJR5A.

Ah.. thanks for pointing out Pirmin.
Then, we can close. :)

On Jan 26, 2021, at 11:40 PM, Pirmin Vogel<EMAIL_ADDRESS>wrote:
I think the following code section in topgen.py solves this issue:
https://github.com/lowRISC/opentitan/blob/650bd0434abb173a568126f5e04a27685543f181/util/topgen.py#L1019-L1029 https://github.com/lowRISC/opentitan/blob/650bd0434abb173a568126f5e04a27685543f181/util/topgen.py#L1019-L1029
Basically, if the rv_plic.hjson in hw/{top_name}/ip/rv_plic is not available for the initial validation (this is the case for the secondary top levels), we use the one from hw/ip/rv_plic. The newly generated rv_plic.hjson is then validated again inside generate_plic().
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/lowRISC/opentitan/issues/28#issuecomment-768098665, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJDG3SYJ26G3EMRCJGT2SDS367NTANCNFSM4ISTJR5A.


quart.redirect documentation and source code mismatch

The documentation says that quart.redirect has 3 parameters:

location – the location the response should redirect to.
code – the redirect status code. defaults to 302.
Response (class) – a Response class to use when instantiating a response. The default is werkzeug.wrappers.Response if unspecified.

However, when inspecting the source code, this does not seem to be true:
def redirect(location: str, code: int = 302) -> WerkzeugResponse:
    """Redirect to the location with the status code."""
    if current_app:
        return current_app.redirect(location, code=code)

    return werkzeug_redirect(location, code=code)

These are the old versions of docs. This is the current version: https://quart.palletsprojects.com/en/latest/reference/source/quart.helpers.html#quart.helpers.redirect

sorry for that, thanks!


internal(fix): Update fetch polyfill for tests and fix some tests

Fixes # .
Motivation

Solution

Open questions

https://github.com/github/fetch/pull/575 seems to break jest timer mocks

Closing in favor of https://github.com/coinbase/rest-hooks/pull/973 for now


Streaming support

Summary
Everything was going great here...until I actually tried to test the code. client.subscribe(...) hangs forever instead of returning a Streaming<Envelope> as expected.
Halp!
Things I've Tested

I used a local version of tonic and traced down where it hangs. It makes it this far, and then gets stuck.
This is unusual. My code looks a whole lot like the client streaming example in the Tonic repo, which I've run alongside the server-streaming example and does work as expected. The stream is returned immediately and then you wait for messages on the stream.
This issue has nothing to do with my Subscription code, since that code never gets run. Also, the same issue is reproducible on subscribe_once, which doesn't use the Subscription struct at all.
I've confirmed from the node logs that the subscription request does make it to the node and no errors are logged
I haven't found anyone else with the same Tonic issue as me. If I can come up with a reproducible test case in their repo I'll create one

Theories

Something weird is happening with Tokio and deadlocks. No idea why this wouldn't be happening with the query endpoint, which works great. But possible.
Our nodes are doing something non-standard with GRPC, and Tonic is uniquely sensitive about the issue. Maybe something to do with trailers?

Anyone have any ideas?

Moved this PR description to a comment for posterity:
Everything was going great here...until I actually tried to test the code. client.subscribe(...) hangs forever instead of returning a Streaming as expected.
Halp!
Things I've Tested
I used a local version of tonic and traced down where it hangs. It makes it this far, and then gets stuck.
This is unusual. My code looks a whole lot like the client streaming example in the Tonic repo, which I've run alongside the server-streaming example and does work as expected. The stream is returned immediately and then you wait for messages on the stream.
This issue has nothing to do with my Subscription code, since that code never gets run. Also, the same issue is reproducible on subscribe_once, which doesn't use the Subscription struct at all.
I've confirmed from the node logs that the subscription request does make it to the node and no errors are logged
I haven't found anyone else with the same Tonic issue as me. If I can come up with a reproducible test case in their repo I'll create one
Theories
Something weird is happening with Tokio and deadlocks. No idea why this wouldn't be happening with the query endpoint, which works great. But possible.
Our nodes are doing something non-standard with GRPC, and Tonic is uniquely sensitive about the issue. Maybe something to do with trailers?
Anyone have any ideas?


Integrated settings for TrollStore installations

When UTM is installed with TrollStore, the settings page is not available. We need an alternative way to display the settings, probably through the app itself.

Yeah I would like to config something on UTM

https://github.com/opa334/TrollStore/issues/211


Unknown issue on Safari, with Potential route of Discovery

Environment

Browser: Safari
Context: WebAssembly storage implementation

Issue Description
Experiencing a peculiar inconsistency with Safari in handling storage using WebAssembly. This issue is not observed in other browsers, regardless of whether they are in private or normal modes. I wasn't experiencing this issue till transitioning to WASM.
Behavior in Safari
Normal Mode
In normal mode, Safari selects WasmStorageImplementation.sharedIndexedDb due to missing:

MissingBrowserFeature.dedicatedWorkersInSharedWorkers
MissingBrowserFeature.sharedArrayBuffers

However, storage doesn't function as anticipated.
Private Mode
In private mode, additional missing features are noted:

MissingBrowserFeature.fileSystemAccess

Surprisingly, it operates correctly in this mode, which contrasts with the normal mode.
Other Browsers
In other browsers, both in private and normal modes, it works seamlessly using the same WebAssembly setup.
Seeking Solutions
I am seeking insights or solutions to address this issue in Safari's regular browsing mode. Currently, I lack detailed debug information beyond what's provided, as it's error output is gibberish. This problem only arises on my live site (not in visiting the page during development on safari, while debugging on chrome), adding to the complexity of diagnosing it. The 'features used' might offer clues to someone well-versed in this area. If there's a better way to get debug information, I might be able to with direction on how to go about that.

Thanks for the report, I'll try to reproduce this with an example from this repository.

However, storage doesn't function as anticipated.

Is it just completely broken without giving any error message or is there more that might be relevant?

In private mode, additional missing features are noted:

Does it also pick sharedIndexedDb there?

it does pick sharedIndexedDb
I believe that it successfully creates the Database (i.e. in my debug panel I can see the expected db got created)
though afterwards, nothing is getting stored. Normally I'd get a dropdown showing at least a little of what got stored,
(as shown on pre-migration)

After migration

So I'm making the assumption that nothing is getting stored. My initial (blindly attempting) pull request's goal was to see if perhaps there was an issue with utf-8, as for why we discussed I don't think that's the case.
output from private mode: Using WasmStorageImplementation.sharedIndexedDb due to missing browser features: {MissingBrowserFeature.dedicatedWorkersInSharedWorkers, MissingBrowserFeature.fileSystemAccess, MissingBrowserFeature.sharedArrayBuffers}

Update: I think the trail might have been completely off; there's two new things that might give you clue to what's up.

Sure, my Discord username is simonbinder

I might add some strange things discovered in Safari 17.4.1. It seems like deploying web application with Cross-Origin-Embedder-Policy header set to require-corp breaks the WasmDatabase entirely (Safari only, other browsers have no issues). The application initializes and works perfectly fine with the first run, however on each following page refresh the drift throws the error in the console, unable to initialize:

Note: I'm building the examples/app application (cd examples/app && dart run build_runner build && flutter build web) and then deploying it with the following command:
dhttpd '--headers=Cross-Origin-Embedder-Policy=require-corp;Cross-Origin-Opener-Policy=same-origin' --path build/web/

The drift picks IndexedDB for storage:
Using WasmStorageImplementation.sharedIndexedDb due to unsupported browser features: {MissingBrowserFeature.dedicatedWorkersInSharedWorkers}

And the culprit seems to be the IndexedDB's database not being populated, as like WasmDatabase doesn't have the write access (it should contain blocks, etc):

What's even more strange is the fact that deploying application without the COEP/COOP headers works fine and even deploying the COEP with credentialless works fine! However, when COEP is set to credentialless, the drift seems to consider SharedArrayBuffers as being unavailable:
Using WasmStorageImplementation.sharedIndexedDb due to unsupported browser features: {MissingBrowserFeature.dedicatedWorkersInSharedWorkers, MissingBrowserFeature.sharedArrayBuffers}

Yet I can confirm the headers are set:

Perhaps Safari with COEP set to require-corp needs some additional deployment configuration? I'll try to investigate this a bit and leave a comment, if something is up.

Thanks for the report! Did you already have a database from a previous run in the first screenshot? Drift should pick opfsLocks here, unless it detects that the IndexedDB database already exists (so that no data is lost).

However, when COEP is set to credentialless, the drift seems to consider SharedArrayBuffers as being unavailable:

When I tried that, crossOriginIsolated also reported false in the console - so shared buffers really are unavailable.
The problem, I think, comes from here: https://github.com/simolus3/drift/blob/2d870a6cf54e190dab6459dfd5060c42ce97ba2f/drift/lib/src/web/wasm_setup/shared.dart#L116-L139
We're checking whether an IndexedDB database exists because, if it does, we don't want to use OPFS even it is available. The problem is that (despite aborting the transaction) we seem to create the database inadvertently with that check. That's a big problem, because it now means that as soon as we reach a state where OPFS doesn't exist/is unavailable, we'll try to use that broken database.
Most browsers support indexedDb.databases though, I'll migrate the check to that if it's supported to avoid creating the database here.

So I've fixed that in 996176d8a5daf535371e9512cbe8dea5b2f8b284, but that only prevents new versions from accidentally creating a bogus database. Depending on how widespread this problem is we may have to bump the schema version for IndexedDB and create the stores if they don't exist.

Hi, we experience the same/similar issue on the Safari private window. The first time the app load create the db, however when refreshing/reloading the app cannot access the db "NotFoundError: The object can not be found here"
Version: 2.19.1 and latest 2.21.0

Good catch! I can reproduce the issue, but I couldn't figure out why it's happening (the error originates in the shared drift worker, which can't be debugged on Safari. There's also no stack trace). So it will likely be a bit of a challenge to track this down, but having something that reproduces this is definitely helpful.

Ok, Safari doesn't support storing Blobs in IndexeDb in private browsing windows (or so it seems). There's a fairly easy workaround (https://github.com/simolus3/sqlite3.dart/pull/266), I'll have to do some more testing before releasing it.


Reservation state : 'unknown'

I'm not sure if this is just something that has yet to be implemented, but currently I always get reservation state: 'unknown' when configuring a slice with slice_manager.create() and I find it uninformative.  It would be nice if the information printed from the 'reservations' object would be in a clear and organized format so the user also doesn't miss when the lease start/end period is.

SliceManager is not used directly now by the user. Fablib API provides Sliver state as:

Nascent
Ticketed
Active
Failed
Closed


What type of update are you requesting?
A new version of an existing package
Current Package Identifier
simplewall
Package Version
3.8.3
Please describe the changes you would like to see
https://github.com/henrypp/simplewall/releases

There used to be in progress, but the installer file had been flagged by Microsoft Defender SmartScreen. I'll try if this false-positive is already resolved.

https://github.com/microsoft/winget-pkgs/pull/166831#issuecomment-2277794921
https://github.com/microsoft/winget-pkgs/pull/166831#issuecomment-2278605545

Manually verified in Windows Sandbox. A new pull request will be submitted.

There's still false-positive. 😞 Issue should be closed as not planned.
Suggested policy: https://github.com/microsoft/winget-pkgs/labels/Blocking-Issue https://github.com/microsoft/winget-pkgs/labels/Area-External https://github.com/microsoft/winget-pkgs/labels/Validation-SmartScreen-Error


Improve dependencies for dirlinks.

Summary
This PR updates the dependencies for dirlinks so they're all real files. This allows dirlinks rule to not have to be rerun every time.
This PR also changes the name from dirlinks to .dirlinks, since a file named .dirlinks is created to denote that all siymlinks have been created
Changes:

tools/link.sh

link.sh now detects broken symlinks. Previously, it would return 0 if the symlink existed, but didn't point to anything.

tools/Makefile.unix

Added dependencies to symlinks as order-only prerequisites. See https://www.gnu.org/software/make/manual/html_node/Prerequisite-Types.html
Removed touch from symlink recipes by specifying them as order only prerequisites.
Check Kconfig variables before adding directories as symlinks
Added rule for $(TOPDIR)/arch/dummy/Kconfig
Added rule for $(ARCH_SRC)/board/board
Use $(APPDIR) instead of $(CONFIG_APPS_DIR), since on line 64 $(APPDIR) is validated and realpath is called on the path

.gitignore

Added ignore rule for external folder dirlink dependencies
Added a rule clean_dirlinks to cleanup the symlinks in the correct order

Impact
setting up the symlinks is a one time job, we shouldn't have to do it multiple times.
Testing
Step 1: configure nuttx:
$ (cd tools && ./configure.sh -a ../incubator-nuttx-apps stm32f3discovery:nsh)

part of the configure step ends up calling .dirlinks.
Step 2: We can confirm that .dirlinks doesn't need to be run again by running with the question flag: --question
$ make .dirlinks --question
$ echo $?
0

Step 3: confirm make succeeds.
make

There is typo on simlink (correct should be symlink) spread throughout the PR.

This PR needs to be tested with https://github.com/apache/incubator-nuttx-apps/pull/936. How do I configure CI to do that?

There is typo on simlink (correct should be symlink) spread throughout the PR.

whoops, will fix!

This PR needs to be tested with apache/incubator-nuttx-apps#936. How do I configure CI to do that?

Unfortunately, we can't do that for non-release branches (at least, this is the state at the moment).
However, your apps PR is merged, so next push should pull the latest apps with the required changes.

@AlanRosenthal we seem to have the same parallel build issue here as the last PR.

@AlanRosenthal we seem to have the same parallel build issue here as the last PR.

I believe something is wrong with the clean rule. I should have a patch fixing it up soon. Glad to see there's comprehensive tests in CI

@AlanRosenthal we seem to have the same parallel build issue here as the last PR.

@Ouss4 CI is passing!

This PR needs to be tested with apache/incubator-nuttx-apps#936. How do I configure CI to do that?

That PR was merged, so now it will be possible to test using it

sorry about that @gustavonihei & @Ouss4. When I rebased this PR I accidentally included WIP changes. I've reverted them

@xiaoxiang781216 @gustavonihei PTAL.

@AlanRosenthal let's merge into one patch?

@AlanRosenthal let's merge into one patch?

done! happy new year

@AlanRosenthal we may need update Makefile.win too


Load step from url

Currently, only steps from the local file system can be loaded into the steps library. Scriptcwl should also be able to load steps from urls.

For single files http/https urls can already be used like, for example, this:
wf.load(step_file="https://raw.githubusercontent.com/WhatWorksWhenForWhom/nlppln/develop/cwl/anonymize.cwl")
This functionality was already implemented in cwltool.load_tool.fetch_document


Code?

Sounds really interesting :) But I can't seem to find the actual code…only a README and some basic setup files. Is it possible that you forgot to commit a file?

In the end I never implemented it. I did make a change to Ren'Py to serialise the AST to analyse externally (https://github.com/robotlolita/renpy/commit/7c8f4ce5fb0ad9528db57bb43c10ea1d437fdeba), but that was all.

I see, thanks for the quick answer! I used grep in the end to transform the script into a simplified outline - works pretty well.


[feature] programmatic page creation

So I've spent a little bit of time trying to see if I could make ssg work like Gatsby for page creation (with the createPage node API hook).
My approach is currently

Fetch data from my CMS in createIndex and cache it
Use this.ssgData in the preload function of my [slug].svelte component

The main problem with this approach is that the route matching is dependent on file structure. My [slug].svelte component can only match routes at level 1. If I want sub-pages I need to create a component at [one]/[two].svelte. The problem is I would like to be able to create an indefinite number of nested routes on my external CMS without having to worry about how many sub-folders I created in the source code.
Another problem (arguably) that is obvious with the way Sapper create files on export is it only creates files for routes that can be crawled from the index page. We cannot create 'hidden' pages or landing pages for example.
Is it something you are interested to handle with ssg @sw-yx ?
For now, ssg seems to be focused on having your data along with your source code. If we want to enable programmable page creation it seems we are going to diverge from Sapper's core principles in major ways.

About the second problem, I just discovered the (new?) --entry option that I think allows us to specify entry points for our app to be crawled from.
If we implement programmatic routes creation, we could use this option to specify all created routes...

hey! yes. my intention is to depart from Sapper sooner or later. Quite frankly i have been dragging my feet because it will be a lot of work. but yeah a programmatic createPages api makes sense.
if you have a way to implement it in this project and need it to get your stuff done, be my guest. i can't promise i'll get to the ssg rewrite soon since it is just a hobby project

Sure! I understand.
To be honest I wouldn't know where to begin to do that with Sapper.
I have a feeling that a new svelte ssg implementation might be around the corner with your recent experiments and the guys active on the svelvet projet (for reference).
If I get to the point where I really need this, I think I will just hack around it with nested folders like I mention above for now.

yes, exactly. too early to do this now. it would actually NOT be that hard, if you read the Sapper source code you can figure out where to insert it but it takes time and energy haha. lets just make sure we have this api when we do the rewrite


Play ding.mp3 instead of tri-tone sound for notifications on OSX. #636

Before submitting, please confirm you've

[x] read and understood our Contributing Guidelines
[x] completed Mattermost Contributor Agreement
[x] executed npm run lint:js for proper code formatting

Please provide the following information:
Summary
Play ding.mp3 instead of tri-tone sound for notifications on OSX.
Issue link
https://github.com/mattermost/desktop/issues/636
Test Cases

OSX 10.12.6

Additional Notes
None.

Thank you for your feedback.
The app would always play the sound even when the user disabled notification sounds in OS preferences (On macOS, Preferences.app -> Notifications). At least the app should follow the preference. It's a reason why we use built-in sound.
Unfortunately I'm not familiar at macOS native part, so I'm not sure which Electron API can get the appropriate value. (Possibly systemPreferences.getUserDefault()?)

Actually, I already use the code from this PR and that's not the case for me. The notification sound setting still works. If there's a better way to solve it, then by all means, but this solution does work.

It would be helpful if the case is concretely written in detail.
I'm sure that's confusing point though, the sound for desktop app's notifications depend on two kinds of preferences.

A: Mattermost webapp -> Main Menu [≡] -> Account Settings -> Notifications -> Desktop notifications -> Notification sound
B: OS preferences (On macOS, Preferences.app -> Notifications or "Do Not Disturb" of Notification Center)

When B is off, the app should not play the sound even if A is on. i.e. B has higher priority to disable the sound. But this PR plays the sound in that case.

That's just a by-product of using a custom alert sound. As far as I'm aware, there's no way around it, and most major apps (i.e. Discord, Slack) that use alerts just provide a do not disturb setting from within the app (or some other way to turn off notification sounds, which we already have)

A little researched. Surely it seems there is no way to get Do Not Disturb settings. However I couldn't hear sound of notifications from Slack in No Not Disturb. But the sound is different, so I think there is a way to change it. (In my memory, sound parameter of new Notification() is not supported yet...)
Oppositely, I'm not sure why ding.mp3 should be used instead of built-in sound. Would you explain about your case?

To clarify; for me, the slack sound is muted when Slack's built-in do not disturb status is enabled, but the sound always plays when only OSX's do not disturb mode is on. That's how it's always been for me, presumably because there's no way to check the setting in the API
The custom sound is just a lot better-suited. I'd be fine with another sound, but in my opinion, the default tri-tone sound is very loud, jarring, dated, and out of place for a messaging alert.
(And I'm not the only one that feels this way):
https://mattermost.uservoice.com/forums/306457-general/suggestions/17213822-use-custom-notification-sound
https://mattermost.uservoice.com/forums/306457-general/suggestions/8686084-change-notification-sound

I see about the situation. By the way, I missed a changelog in Electron. Since v1.7.7, sound is supported on macOS. I'm wondering if you would like to investigate it. I think that it properly uses custom sounds and 'Do Not Disturb'.
As described at https://github.com/electron/electron/pull/10293, you would need to specify the local file.

Ah, very cool! Will do.

@yuya-oc Thinking about how to tackle this. While the new electron notification class does support sounds, unfortunately it does not seem to be do-not-disturb-aware. So the only reason to use the sound property would be idealism. There's actually a reason not to use it as well, which is the throttling feature that's used for Windows. Let me know if you'd rather I use that property (my vote would be not).
Luckily, there is a way to check whether notifications are muted via dnd. Will submit a PR for that soon.

We actually might want to use sound if it works on Windows as it'll let us kill the throttle code. I don't have a Win machine so can't test unfortunately

@philip-peterson Let us know if we can help, or if you have any questions about Yuya's comment above?

@jasonblais @yuya-oc I've been working to get the Electron API to find the sound. The docs suggest that the file needs to be present in the Resources folder, so I tweaked the electron-builder.json to include that file. Unfortunately even after doing so, Electron seems to be unable to find the file. I've tried relative paths, absolute paths, and also referring to the file by name with no extension. Please let me know if you have any other suggestions.

@philip-peterson I have looked up docs and codes. I could get the custom sound in the main process when I converted the mp3 to aiff, but I'm not sure why.
const notification = new Notification({
  title: 'Main Process',
  sound: 'ding' // Locate ding.aiff to ~/Library/Sounds/
})

The doc is writing about the main process. But its implementation is also used by renderer processes. So I had thought sound should work in webview. But when using debugger, sound was not passed to the native part. Probably sound is not implemented yet in Chromium because sound doesn't exist in content::PlatformNotificationData struct.
A way to avoid the problem is to use the main process and IPC. But that would need more complicated codes because IPC can't pass callback functions.

Hey @philip-peterson - any questions on Yuya's note above?

Closing this PR due to inactivity, let us know if you'd like it reopened :)


Wrong reference to embedded images

[x] I tried updating to the latest version.

[ ] I can't, there is an issue.

[x] I Am on Windows

[x] Docker for Windows
[ ] Ubuntu Bash on Windows
[ ] Fedora Bash on Windows

[ ] I Am on Linux
[ ] I Am on macOS

Description
When running jekyll/jekyll on Docker for Windows as described below, links based on {{ site.url }} resolve to <IP_ADDRESS> and not <IP_ADDRESS> resulting in broken links to embedded images:

Steps
docker run --rm -v C:\`lab\MyLab\:/srv/jekyll -p 4000:4000 -it jekyll/jekyll jekyll serve

Output
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux-musl]
Configuration file: /srv/jekyll/_config.yml
            Source: /srv/jekyll
       Destination: /srv/jekyll/_site
 Incremental build: enabled
      Generating...
                    done in 1.579 seconds.
 Auto-regeneration: enabled for '/srv/jekyll'
    Server address: http://<IP_ADDRESS>:4000/
  Server running... press ctrl-c to stop.

Expected
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux-musl]
Configuration file: /srv/jekyll/_config.yml
            Source: /srv/jekyll
       Destination: /srv/jekyll/_site
 Incremental build: enabled
      Generating...
                    done in 1.579 seconds.
 Auto-regeneration: enabled for '/srv/jekyll'
    Server address: http://<IP_ADDRESS>:4000/
  Server running... press ctrl-c to stop.

Test in Ubuntu for Windows
jekyll serve
Configuration file: /mnt/c/lab/MyLab/_config.yml
            Source: /mnt/c/lab/MyLab
       Destination: /mnt/c/lab/MyLab/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
                    done in 1.961 seconds.
                    Auto-regeneration may not work on some Windows versions.
                    Please see: https://github.com/Microsoft/BashOnWindows/issues/216
                    If it does not work, please upgrade Bash on Windows or run Jekyll with --no-watch.
 Auto-regeneration: enabled for '/mnt/c/lab/MyLab'
    Server address: http://<IP_ADDRESS>:4000/
  Server running... press ctrl-c to stop.
``

Jekyll makes very bad defacto assumptions when they tightly coupled the binding host for the server to the url host they choose to use, and present to you. There is no way we can stop that problem other than to rewrite pieces of Jekyll (probably not gonna happen,) or to ask you to file a bug with Jekyll and point out that binding the bind host to the url host is error prone when ran behind a proxy.  Though, they're unlikely to fix the issue, since it's existed since about 3.3 AFAIW.
We need the server to be bound to <IP_ADDRESS> to forward it to your system, and they tightly couple logic that shouldn't be coupled together in a way that presents as a bug from us, but it's really not, because we can't do anything to fix it (sadly.)
There are two ways you can fix it quickly yourself:

Drop {{ site.url }} and use absolute URL's without protocol
Do 1 and use {% if jekyll.env == "production" %}<base href={{ site.url }}>{% endif %}
Use {{ site.baseurl }}


InvalidRequestError: The model text-davinci-003 has been deprecated

Is there a way to bypass this or change the model from my end to run factscore using OpenAI models?

Not in the library currently, we are tracking it in #38

@shrusti-ghela A quick workaround would be to replace the davinci model with OpenAI's suggested gpt-3.5-turbo-instruct. (See OpenAI Deprecations)
# Look for this code snippet
def call_ChatGPT(
    message, model_name="text-davinci-003", max_len=1024, temp=0.7, verbose=False
):

# And replace it with this workaround:
def call_ChatGPT(
    message, model_name="gpt-3.5-turbo-instruct", max_len=1024, temp=0.7, verbose=False
):

Assuming you're using a virutal environment you will find this piece of code in venv/lib/python3.9/site-packages/factscore/openai_lm.py. Note: Normally you shouldn't change the library code in your personal installation, because it will be overwritten when a new version is released, but just to get it working for the moment, this might be fine.


Constraints resizing issue with viewForSupplementaryElement

New issue checklist

[ X] I have reviewed the README and documentation
[X ] I have searched existing issues and this is not a duplicate

General information

IGListKit version: pod 'IGListKit', '~> 3.0'
iOS version(s): 11.4 simulator
CocoaPods/Carthage version: latest
Xcode version: 9.4.1
Devices/Simulators affected: only tested on iPhone X simulator
Reproducible in the demo project? (Yes/No): Not tested
Related issues: /

Issue
TLDR : The constraints of the nib are not resizing properly as expected.

I can't get the constraints working following this example
I have built a test header using a nib. it's a UICollectionReusableView subclass.
The label inside the cell in in the size in whatever size the nib is.
I have colored the background of the cell dark gray and the label background is yellow to highlight the issue.
Example with small cell in nib.

Example with larger cell in nib.

The size implementation return the correct size of the container. As expected:
func sizeForSupplementaryView(ofKind elementKind: String, at index: Int) -> CGSize {

    print("collectionContext!.containerSize.width: \(collectionContext!.containerSize.width)")
    return CGSize(width: collectionContext!.containerSize.width, height: 40)
}

If have double and triple checked, but I have 100% for sure set the constraints correctly with leading, trailer, top and bottom to the cell borders.
Out of pure desperation I have also tried to set a UIView as superview for the label, without success. As expected.
Everything is 100% implemented as in the example above.
Help is very appreciated.

I just double checked again, the only difference to the example is, that my list controller is a ListBindingSectionController subclass.

This is my header implementation:
class DevicesListHeaderCell: UICollectionReusableView {

    @IBOutlet weak var buildingLabel: UILabel!

    override func awakeFromNib() {
        super.awakeFromNib()
        // Initialization code
    }

    func bindViewModel(_ viewModel: Any) {

        self.layoutIfNeeded()
        self.buildingLabel.text = viewModel as? String
    }

}

I had also tried to set the width constraint of the label, pass the size of the container and update the label's constant. No success at all. The size of the label remains the cell size of the nib.

Got it. Thanks for the lib. And thanks to John Sundell for inviting Ryan so I got pointed to it.


Don't map minecraft:teleport to the eseentials version of the command

By blocking access to the standard Minecraft /teleport command, you're essentially limiting selectors and teleporting to entities (you can't teleport to entities with the essentials command, even with the UUID)
For example, I was trying to make a command block that would teleport a player to a specific entity that's attached to a fence using lead, but it kept on spitting out "Player not found" errors on the first argument that had the entity UUID

If you unblock minecraft:tp and minecraft:teleport, you should also map tp and teleport to their vanilla implementations.


AttributeError: '_Union' object has no attribute 'qualname'

Steps to reproduce the problem:

pip3 install mitmproxy
mitmproxy
Crash (see below)

Any other comments? What have you tried so far?
$ mitmdump
Traceback (most recent call last):
  File "/usr/local/bin/mitmdump", line 11, in <module>
    sys.exit(mitmdump())
  File "/usr/local/lib/python3.6/site-packages/mitmproxy/tools/main.py", line 106, in mitmdump
    dump_options = options.Options()
  File "/usr/local/lib/python3.6/site-packages/mitmproxy/options.py", line 123, in __init__
    self.rfile = rfile
  File "/usr/local/lib/python3.6/site-packages/mitmproxy/optmanager.py", line 111, in __setattr__
    self._typecheck(attr, value)
  File "/usr/local/lib/python3.6/site-packages/mitmproxy/optmanager.py", line 122, in _typecheck
    typecheck.check_type(attr, value, expected_type)
  File "/usr/local/lib/python3.6/site-packages/mitmproxy/utils/typecheck.py", line 24, in check_type
    if typeinfo.__qualname__ == "Union":
AttributeError: '_Union' object has no attribute '__qualname__'

System information
mitmproxy 1.0.0
Python 3.6.0
OS X 10.11.6
(mitmproxy --sysinfo gives the same traceback above)

3.6 already - nice! 😄
Thanks for the report! We are hitting the same on our CI servers, in #1884, that should be fixed soon. ☺

Yeah, I got it too — with brew installation and with usual pip3.

We have a rough fix in #1884 - will be merged soon!

In the meantime, please feel free to take our binaries from https://github.com/mitmproxy/mitmproxy/releases/tag/v1.0. We hope to have this fixed ASAP, but we're getting weird CI errors and need to investigate.

We just pushed 1.0.1 which fixes compatibility with Python 3.6. Thanks again for reporting this! :smiley:


Fix #244 -- Refactor dump_message function to force content key

Bug Description
When there is a retry, a 400 error is raised from the API, stating that the 'content' property is required in the 'messages.1' object.
Proposed Fix
Force the “content” key to correspond to the Message object in the OpenAI API.
PR Comment:
Hi team! I've investigated the issue described in #244 and identified the root cause of the error. It seems that when there is a retry, a 400 error is raised from the API, indicating that the 'content' property is required in the message object.
To fix this, I suggest forcing the "content" key to correspond to the Message object in the OpenAI API. This will ensure that the required properties are correctly passed to the API.
Please review the changes and let me know if you have any feedback. Once approved, I will proceed with merging the PR.
Fix #244
Please feel free to customize and modify the comment as  #needed..

Summary by CodeRabbit

Bug Fixes

Improved message handling to ensure sensitive data is not included in the output.
Enhanced message retry logic for better stability and consistency.

Documentation

Updated documentation to reflect changes in message processing.

Tests

Added new test cases to verify the correct transformation of messages.
Updated existing tests to align with the latest code changes.

Oh this is great.
As an aside we're running into an issue.
Can you update this pr to also pop the tools call and put it in contents?
We can't reask if there's a tool call and I was meaning to try to play with dump message more.

would be great if you can add some tests like
with a @pytest.mark.skipif(not "AZURE_OPENAI_KEY" in os.environ)
then i can try to set up my own env in the tests

looks good let me know if its ready to merge

It is ready for me :+1:


removed task ref name when processing event queue

Pull Request type

[x] Bugfix

Fixes https://github.com/Netflix/conductor/issues/3494

Hi @astelmashenko , Changes looks good. Can you please add a small unit test around this? Please check reference

@manan164 , I quickly checked the reference test. DefaultEventQueueProcessor is wirtten a way it will require a lot of ceremony to setup a test. To make it easier to test DefaultEventQueueProcessor should be refactored e.g. into testable service with logic to process events and processor with code that subscribes to observable/etc.
What do you think about the reafactoring?

@manan164 , why do not we merge this?


Not able to install the latest version of Aniyomi even after downloading it.

Steps to reproduce
Example: Installation
1: Downloaded the latest update as per alert notification.
2: App installing.
3: Issue here: At the almost end part of the installation the bar stops and message appears saying "App is not installed".
Expected behavior
The app should have installed the latest update.
Actual behavior
The app doesn't perform the installation despite having the latest version downloaded and it seems to happen across multiple devices. It says "App not installed". The functionality of the app is normal.
Crash logs
No response
Aniyomi version
<IP_ADDRESS>
Android version
Android 11
Device
Realme C3
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Maybe you are downloading the wrong APK, download the APK which has the biggest size from the releases section


Replace match with if/else logic to restore compatiibility with earlier Python versions

The __init__.py currently uses the match statement, which was introduced only in Python 3.10. Unfortunately, this means pygdsm is incompatible with earlier Python versions, in particular on clusters etc. where upgrading may not be straightforward. As far as I could tell, the match statement was in fact the only source of incompatibility with older Python versions, so here my suggestion to replace it with if/else logic instead.
I have verified this works on a local Python 3.6 installation. I have also added the python_requires argument to the setup.cfg file, as I think this is how pip can tell which Python versions are supported. I suppose the version number also has to be bumped before this can be released, but I am not sure exactly how/if you would like to proceed from here : )

Thanks @sjoerd-bouma -- finally merged (sorry this dropped off my radar)!


Margin auto allows negative values

Report

[x] I have searched existing issues and this is not a duplicate

Issues and Steps to Reproduce
Create a setup like follows
<View style={{ height: 500 }}>
  <View style={{ flex: 0, height: 300 }} />
  <View style={{ flex: 0, marginTop: 'auto', height: 300 }} />
</View>

Or use playground link
Expected Behavior
The bottom view should overflow the parent (as happens on the web)
Actual Behavior
The bottom view gets a negative top margin applied, and overlaps the top view. Nothing overflows the parent
Link to Code
https://yogalayout.com/playground?eyJ3aWR0aCI6NTAwLCJoZWlnaHQiOjUwMCwibWluV2lkdGgiOm51bGwsIm1pbkhlaWdodCI6bnVsbCwibWF4V2lkdGgiOm51bGwsIm1heEhlaWdodCI6bnVsbCwiZmxleERpcmVjdGlvbiI6MCwicG9zaXRpb24iOnsidG9wIjpudWxsLCJyaWdodCI6bnVsbCwiYm90dG9tIjpudWxsLCJsZWZ0IjpudWxsfSwiY2hpbGRyZW4iOlt7IndpZHRoIjoiIiwiaGVpZ2h0IjoiMzAwIiwibWluV2lkdGgiOm51bGwsIm1pbkhlaWdodCI6bnVsbCwibWF4V2lkdGgiOm51bGwsIm1heEhlaWdodCI6bnVsbCwicG9zaXRpb24iOnsidG9wIjpudWxsLCJyaWdodCI6bnVsbCwiYm90dG9tIjpudWxsLCJsZWZ0IjpudWxsfSwiZmxleFNocmluayI6IjAifSx7IndpZHRoIjoiIiwiaGVpZ2h0IjoiMzAwIiwibWluV2lkdGgiOm51bGwsIm1pbkhlaWdodCI6bnVsbCwibWF4V2lkdGgiOm51bGwsIm1heEhlaWdodCI6bnVsbCwibWFyZ2luIjp7InRvcCI6ImF1dG8ifSwicG9zaXRpb24iOnsidG9wIjpudWxsLCJyaWdodCI6bnVsbCwiYm90dG9tIjpudWxsLCJsZWZ0IjpudWxsfSwiZmxleFNocmluayI6IjAifV19
Notes
If you remove marginTop: auto you get the correct behaviour
I did find these few lines
I'm not sure what the logic of remainingFreeSpace is - if it should allow negative values or not. If it does allow them, it might just need a max(0, ...)

Hi @jacobp100
Thank you for reporting this. I just pushed a PR for that bug fix.

Amazing. Thanks so much!

@NickGerleman is this something you'd be willing to accept a PR for Yoga 3? Or is it unlikely to get accepted if it'll break things at Meta
https://www.yogalayout.dev/playground?code=DwGQhgng9grgLgAgMZQHYDMCWBzAvAb3xgGcBTAdVICMARU9MGAGzmIC4EGmyBfHgPgBQCBMAByUACakExOBCakC+AO6ZJcABYcAzAFYADABoEm0jk1xdhkwAcwkyZlTYOAJgN8hIkeKky5BSVCNQ1tBB0DY1NzbEsOABYokwBbMAAnbGcAISg4OCgUjgByRgLivgQAem8fP2lZeUVlUK1dZJiLKwQARijKmuFRKolpIWAq8Gh4fiA

I’d be willing to give it another go. I’ve been leaning a bit on merging things where existing coverage doesn’t show lots of product changes, and this one might not be too bad.

I think it's literally just these two lines
https://github.com/facebook/yoga/blob/main/yoga/algorithm/CalculateLayout.cpp#L1046
https://github.com/facebook/yoga/blob/main/yoga/algorithm/CalculateLayout.cpp#L1062
Need a max(flexLine.layout.remainingFreeSpace, 0)

I think the change will stick, but fixing justify-content overflow behavior in particular did subtlety break a couple real-world UIs at Meta. Namely, there were cases where main axis would overflow, and justification would happen to remove space between items to make it not noticeable. Should be rare though I think.


Add ability to map claims to user profile fields and to roles

This enhancement adds the ability to map Auth0 claims to Drupal user profile fields as well as the ability to select a claim to be used to map to a set of granted roles for the user.

Thx for the contribution


[RESOLVED] High ICMP ping response time

Problem started at 14:46:29 on 2023.04.28
Problem name: High ICMP ping response time
Host: HP_iLO
Severity: Warning
Operational data: Value: 373ms
Original problem ID: 20160
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23268&eventid=20160

Problem has been resolved in 4m 0s at 14:50:29 on 2023.04.28
Problem name: High ICMP ping response time
Host: HP_iLO
Severity: Warning
Original problem ID: 20160


[New Primitive] NumberInput

Feature request

Overview
Capture number input from user and enable the user to increase/decrease the number value
Examples in other libraries
https://mantine.dev/core/number-input/
Who does this impact? Who is this for?
All users

Another example: https://chakra-ui.com/docs/components/number-input/usage


Email section Positioned

Description
The Existing Email section was colliding with the background image, Now the image section moved a bit down which will not cause the background image section.
Motivation and Context
Moved since colliding with background image.

Closes #426

Screenshots (if appropriate):

Types of changes

[X ] Bug fix (non-breaking change which fixes an issue)

Checklist:

[ X] My code follows the code style of this project.
[ X] My change requires a change to the documentation.
[X ] I have updated the documentation accordingly.

Can you give labels into this PR and assign me as well


Version bumped to 1.5.3. Added isAnimated param to toolbar

Hello Vladimir,
I added isAnimated parameter to:

hideToolbar
showToolbar
hideNavbar
showNavbar

methods. When you pressed an input in phone, animation looks bad. Because of that, i added isAnimated parameter. Default is true, so everybody can use same as before.
I wrote changes to CHANGELOG.md ( with your virtual list update )
Have a great day!

Thanks, i merged it manually because of the following reasons:

Version shouldn't be bumped
Too much indent space (4 spaces instead of 2 for tab)
I changed logic to contra verse. So if we don't pass new parameter, nothing should change, so no classes is added. And it adds "not-animated" class in case we pass "noAnimated" parameter

Thank you Vladimir.
I will be careful.
Interestingly i using tab (2 spaces area) in webstorm but when i upload, it changes. I'll find why it is happening.
Have a great day!


v1.15.0 is available

https://github.com/go-gitea/gitea/releases/tag/v1.15.0 is available.
There a re some breaking-changes in gitea 1.15.0. Needs testing bevore merging this PR!

Working well on https://backwesen.de/


UnhandledPromiseRejectionWarning: #

i dont know why it happends, i disabled 2fa and still.
let fortniteAPI = new Fortnite(
    [
<EMAIL_ADDRESS>        "pass",
        "MzRhMDJjZjhmNDQxNGUyOWIxNTkyMTg3NmRhMzZmOWE6ZGFhZmJjY2M3Mzc3NDUwMzlkZmZlNTNkOTRmYzc2Y2Y=",
        "ZWM2ODRiOGM2ODdmNDc5ZmFkZWEzY2IyYWQ4M2Y1YzY6ZTFmMzFjMjExZjI4NDEzMTg2MjYyZDM3YTEzZmM4NGQ="
    ]
);

fortniteAPI.login().then(() => {

});

and the email and pass are from epic games launcher?

I have the same problem these tokens are no longer valid, otherwise yes it is necessary to put the identifier of the launcher

yes, so frustrating

try fortniteAPI.login().catch(e => {console.log(e)})


fix: do not check for browser extension in mobile app

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #57469

Well in the mobile app we handle testing challenges differently so the number of script/style tags are different.

Also, why does the mobile app have this issue? Thing is, this feels like it shouldn't be necessary, even though I can see how it can work.

My theory (that I can't prove yet) was that there was no inherited stylesheet in the mobile app. The mobile app is using a DOM parser and I don't see it inventing a new stylesheet.


cmd/compile: improve const expr if/else DCE

Suppose these two functionally identical definitions of f:
func f1() T {
	if constX <= constY {
		return funcA() // cost(funcA) ~ 60
	} else {
		return funcB() // cost(funcB) ~ 60
	}
} // cost(f1) < 80

func f2() T {
	if constX <= constY {
		return funcA() // cost(funcA) ~ 60
	}
	return funcB() // cost(funcB) ~ 60
} // cost(f2) > 120 (or < 80 if condition is false)

f1 can be inlined, but f2 is only inlineable if constX <= constY is false.
The problem with f1 is that it will trigger go lint warning (if block ends with a return statement, so drop this else and outdent its block).
Example of where it strikes: if you do a const-expression branching depending on the bits.UintSize, inlining may not happen if code does not follow exact pattern. And even if you know the pattern for if/else, it conflicts with go lint.
Related to https://github.com/golang/go/issues/17566.
This issue is only about pre-inlining DCE, which affects function cost.
I am going to link this issue in the upcoming CL that uses explicit else in this case to trigger dead code elimination before inlining.

This rule triggers few times during $ ./make.bash on linux/amd64.
Providing these cases for additional context.
//=trigger= runtime/lfstack_64bit.go:41:6 lfstackUnpack
if GOARCH == "amd64" {
    return (*lfnode)(unsafe.Pointer(uintptr(int64(val) >> cntBits << 3)))
}
// Everything below is removed...

//=trigger= runtime/malloc.go:401:6 sysAlloc
// If using 64-bit, our reservation is all we have.
if sys.PtrSize != 4 {
    return nil
}
// Everything below is removed...

//=trigger= path/filepath/path.go:165:6 ToSlash
//=trigger= path/filepath/path.go:175:6 FromSlash
if Separator == '/' {
    return path
}
// Everything below is removed...

//=trigger= path/filepath/symlink.go:15:6 isRoot
if runtime.GOOS != "windows" {
    return path == "/"
}
// Everything below is removed...

//=trigger= path/filepath/symlink.go:29:6 isDriveLetter
if runtime.GOOS != "windows" {
    return false
}
// Everything below is removed...

//=trigger= math/big/float.go:353:6 validate
if !debugFloat {
    // avoid performance bugs
    panic("validate called but debugFloat is not set")
}
// Everything below is removed...

//=trigger= math/big/float.go:1179:6 validateBinaryOperands
if !debugFloat {
    // avoid performance bugs
    panic("validateBinaryOperands called but debugFloat is not set")
}
// Everything below is removed...


Sida Lillian - Update Social Media URLs contact info

https://lead.asknet.community/profiles/Sida-Lillian/
#209 see comment

We need some improvements around her, Photo, and more so the fact that she is no longer in the camp but rather in Juba, we should now change her contact to Juba instead of Rhino camp, and @maliarich please confirm if she is still with you in CC4d

if the results pend we can remove her name from the site and archive it for a moment

Not sure  if she's part of  us, @Math-TECH-Hub @dawaedina27 .

Please provide a final remark @Math-TECH-Hub or @dawaedina27 so that we can see what to do with the profile, otherwise thanks for your reply @maliarich

@maliarich @Math-TECH-Hub and  @dawaedina27 please is she still with you, yes or no, if yes then summit another photo of her please, and here location. @romeoplat please follow the guys of CC4D

No! She is currently in Juba and this is the number she is is using<PHONE_NUMBER> for WhatsApp and phone calls

solved with next release thx @maliarich and @DutKulang


Migrate package to ESM (no libp2p upgrade)

[x] Change library to ESM: "type": "module"
[x] ESM works with web-chat example (see esm-examples branch
[x] Ensure .js extensions are present thanks to build script
[x] Use protons instead of ts-proto
[x] Use tsc + rollup + terser instead of tsc + webpack
[ ] Re-introduce commonjs build and ensure it works when imported in projects
[x] Fix UMD build (js-libp2p is cannot be bundled with rollup due to the usage of node's cluster, this will be fixed by upgraded to latest js-lib2p).

Notes:

~Will fix UMD later~ UMD fixed by reverting to webpack for it
For NodeJS, only ESM is supported.

Status update: This is basically done
Note that we dropped require support in NodeJS environment, Use import instead.
Last step would be to test require in the browser, it is supposed to work but haven't.
23756c55f40b1580579d0904a6c8547e7f325e53 released at<EMAIL_ADDRESS>


Add arithmetic analysis test suite

Adds a test suite for the arithmetic_analysis directory. Also fixes usage of global scope in files in that folder.
Note that the newton_raphson_method file is broken and it requires too much effort to fix. The tests for that method are failing because of this.

Fixes #55

Tests are failing because of broken implementation (not our responsibility), so I'm merging now.


Unclear error message and also unclear how to fix it

error: External type `ethereum_types::U256` must be defined in a service to use in an RPC interface.
   --> src/main.rs:129:88
    |
129 |     pub fn increase_allowance(&mut self, ctx: &Context, spender: Address, added_value: U256) -> bool {
    |                                                                                ^^^^

So I think this limitation is really problematic for developers of services. Is this a fundamental limitation of Rust Oasis services or is this just something which has not yet been implemented in the compiler?

You can’t use external types because they’re not cross-language. E.g, a typescript service cannot pull in this crate (or any crate).

You want to allow only a least common denominator of types to satisfy all languages, I think this would be very limited. What if I do not care about calling my service from any other language?
So you are saying that there is a hard-coded list of potential types I can use in my service's state and this is it? Or that I cannot use anything from outside? If it is the latter, then why doesn't compile step of Oasis service pull in the typing information from outside and saves it when compiling the service, somewhere in the service? So why would a local definition work but external not? Just pretend that the external definition is local by at-compile time injecting it in, or something?

Also, nothing about such limitations is documented here.

Also here in documentation is says (emphasis mine):

The only thing to keep in mind is that the types must be serializable so that their data can be persisted to storage

So it seems this is not the only thing which I have to keep in mind about types? I have to keep in mind that I cannot use u128 and that I cannot use externally defined types? Anything else I should keep in mind?

And yes, it is true that state is not the same as values being passed over RPC, but it is not very useful if I can store in state values I cannot pass over RPC, no?

I have now the same problem with H256 type.

OK, so replacing all those types in arguments with [u8; 32] and then calling U256::from inside the body of the function worked. Maybe that should be added as a help message to the error? Like, "convert it to something basic and then use that instead of the custom type".
I still believe that if there is a standard way to handle this automatically it should be done. JSON?
Also, extra fun: why U256 can be used as return value from RPC functions? It cannot be used as arguments, but as return values it does not complain? This makes no sense.


Error in beforeCreate hook: "ReferenceError: document is not defined"

Hi,
when i use Typewriter, i have this error when i first load my website.

Do you know how can i avoid it ?
thx ! :)

@lecodeurnormand Could you provide codesandbox example?


Rendering lots of vector layers then toggling off a vector tile layer causes all vector layers to disappear until moving the map slightly

Working with version 9.1.
I'm in the process of testing my map for performance issues so I'm doing things like toggling all the layers on/off quickly, zooming around with the full load of data displayed, etc. I have quite a few layers, but I don't think I'm displaying anything that OpenLayers shouldn't be able to handle, it's a max of 10k points and 500 polygons. The points are vector layers and the polygons are vector tile layers. I'm finding problems with rendering though; when I toggle on every layer and then toggle off the vector tile layer of the state boundaries, all the points displayed disappear until I zoom in or out a tiny little bit or move the map in some way; if I do that, all the points display again. I have tried to force the map to render using renderSync(), but it doesn't fix the issue. And once this problem occurs one time, it continues to fester, causing the points to disappear any time I toggle on/off any of the vector tile layers.
The map doesn't seem to have any other performance/rendering issues; I can zoom in/zoom out and pan smoothly with all layers displayed at once. No lag. No flickering. No disappearing display. It's just this one problem that seems to plague me when it comes to toggling layers on and off. This is not the only map I've experienced this exact problem in either. I am leaning toward it being a z-index problem, like the map just glitches and interprets the z-indexes I have set incorrectly until it's forced to redraw when the map moves, but I haven't been able to solve it yet.
Please watch the attached video to see the issue.
https://github.com/user-attachments/assets/5e109197-6cdc-4f38-ac9e-6109ab0dc6e1
For reference, the z-index of all point layers is set to 4. The z-index of "Hydropower Potential - County Scale" (vector tile layer) is 1. The z-index of "Hydropower Potential - State Scale" (this is the Vector Tile Layer that makes all points disappear in the video upon toggling it off) is 2. The z-index of the OpenStreetMap TileLayer is 0. The updateWhileAnimating and upateWhileInteracting properties are set to the default, but I have tried setting them both to true and it makes no difference.
I have checked that layer visibility doesn't change for the point layers and that my render cycle with React is doing what it's supposed to do and my React state reflects what it should and everything looks fine there. I've stepped through my code and verified that the map.removeLayer() function is only being called on the single layer where the toggling occurs.
My other theory aside from the z-index being wonky is maybe it could possibly be a styling function thing? I create my style functions like this:
export const createStyleFunc = (
    layerName: string,
    geomType: string,
    isAOI: boolean,
    fillColor: string
): StyleFunction => {
    const state = store.getState();

    let normalStyle: Style;
    let selectStyle: Style;
    switch (geomType) {
        case 'point':
            normalStyle = new Style({
                image: new Circle({
                    radius: 4,
                    fill: new Fill({ color: fillColor }),
                    stroke: new Stroke({
                        color: 'black',
                        width: 1,
                    }),
                }),
            });
            selectStyle = new Style({
                image: new Circle({
                    radius: 4,
                    fill: new Fill({ color: fillColor }),
                    stroke: new Stroke({
                        color: '#0cf7f0', //Electric blue
                        width: 2,
                    }),
                }),
            });
            break;
        case 'polygon':
            normalStyle = new Style({
                stroke: new Stroke({
                    color: fillColor,
                    width: 1,
                }),
                fill: new Fill({
                    color: 'rgba(255, 255, 255, 0)',
                }),
            });
            selectStyle = new Style({
                stroke: new Stroke({
                    color: 'rgb(86, 0, 245, 1)',
                    width: 2,
                }),
                fill: new Fill({
                    color: 'rgba(86, 0, 245, 0.1)', //Purple
                }),
            });
            break;
    }

    const lyrStyle = (feature: Feature): Style => {
        const selectedFeatures = state.map.selectedFeatures[layerName];
        if (selectedFeatures === undefined) {
            return normalStyle;
        } else if (Object.keys(selectedFeatures).includes(feature.getId() as string)) {
            return selectStyle;
        } else {
            return normalStyle;
        }
    };

    return lyrStyle as StyleFunction;
};

The layers themselves are created like this:
export const createVectorLayer = (
    wrkspaceName: string,
    layerName: string,
    geomType: string,
    fillColor: string,
    isAOI: boolean,
    cqlFilter?: string,
    maxFeatures?: number,
    loaderCallback?: Function
) => {
    const vectorLayer = new VectorLayer({
        source: createVectorSource(wrkspaceName, layerName, cqlFilter, maxFeatures, loaderCallback),
        style: createStyleFunc(layerName, geomType, isAOI, fillColor),
        properties: { name: layerName, isAOI: isAOI },
        zIndex: 4,
    });
    return vectorLayer;
};

export const createMVTLayer = (
    wrkspaceName: string,
    layerName: string,
    extent: Extent,
    geomType: string,
    isAOI: boolean,
    idField: string,
    z: number,
    fillColor?: string,
    featureType?: string
) => {
    const tg = createTileGrid(extent);
    const mvt = new VectorTileLayer({
        opacity: 1,
        declutter: true,
        extent: extent,
        source: createVectorTileSource(wrkspaceName, layerName, tg, idField, featureType),
        style: createStyleFunc(layerName, geomType, isAOI, fillColor),
        properties: { name: layerName, isAOI: isAOI },
        zIndex: z,
    });

    return mvt;
};

Steps to Reproduce
Using OpenLayers in a React framework, load a couple vector tile layers on a map and 10k points, then turn off a vector tile layer and see what happens? I don't think my problem would be easy to reproduce, but I'm hoping someone can at least give me an idea of what might be wrong.
Expected behavior
I expect to toggle off a vector tile layer and have the remaining layers that should be visible, remain visible.

I went digging through the issues for an hour and came across this one: #15611
If I remove the declutter: true property in my createMVTLayer function, the issue is solved. This solution works for me because I'm not using any labels on my VectorTileLayers yet, but I will eventually, so this is really just a stop gap for now.
Alternatively, I also tried leaving declutter: true in my createMVTLayer function and then also setting opacity: 1 and declutter: true in my createVectorLayer function. This also solves the problem, but decluttering my points isn't something I want for my map, so I am opting not to do this.

This issue should be fixed in v10. Can you try with OpenLayers v10.2.1?


question about --old-fc flag

When i try to train a new model with infulence loss (old classifier regularization), i cant find "your_old_fc_weights_dir". Could you plz tell me where i can find the "fc_weights_dir"?

Hi there,
You can save the fc layer of your old model by torch.save()


Memory leak caused by default initialisation of xlib

Hello,
I managed to find a memory leak caused by "longjohn", a dependency loaded by default through xlib.

What fixed it was configuring xlib in production mode:
global.__xlibInitArgs = Object.assign({ envLevel: 'PROD', logLevel: 'ERROR' }, global.__xlibInitArgs);

I suggest to modify the phanthomjscloud initialisation of xlib to also contain the two parameters above.

This is scheduled to get fixed during the coming week.


Fix links in FAQ page #168

What have been done: We fixed the links in the FAQPage - including the Google forms links
Pushed to: hotfix-fix-links-in-FAQ
Tag somebody: @RohrerHope
Version: 2.1.4
Asking for validation:

Check on mobile and on desktop if the issue have been correctly fixed.
If everything is correct, move the card to accepted column.
If the issue isn't fixed, re-open the comment clearly what the problem is and what is the desired result.
Move the card to have issues column.
Merge (or express approval in) the corresponding PR if needed. Move the card to the launch column.

I need guidance on where to test this one.
Thanks.


Update requirement.txt

Need to have a gpu-based and cpu-based requirements.txt

Satisfied here: https://github.com/DavidCarlyn/object_detection/commit/81869f789b43889f18b66d0974e5f90dc7f0c0d9


Should required field be set as nullable?

https://github.com/go-swagger/go-swagger/blob/bd526d67cc1c49acad8e7643a399ea62d3342c12/generator/types.go#L579
I have got a weird generated client, my non required fields are set as value, and required fields are as pointers.
Having required field in schema means that this field must have a value, so pointer is not needed, and vice versa having not required fields means this fields can be nil so - pointers.
Am I missing something, or this is bug?
	// address street
	AddressStreet string `json:"addressStreet,omitempty"`

	// commune
	// Required: true
	Commune *Commune `json:"commune"`

it's intended. we're using the pointers to distinguish between unset and empty

Still something is not clear for me.
Unsetted value cannot be required, required values have to be always set, so required fields shoudn't be with pointers.
In the other hand empty value is always a value, empty string cannot be represent as nil.

For validation we have to be able to distinguish between absent and zero.
For example one can interpret required to be a distinct requirement from the value it's referring to eg a string.
An API can decide that a value is required but that an empty value is acceptable.
It's not the job of go-swagger to have opinions on the semantics of an API.
I agree that it's a suboptimal choice and it definitely violates the principle of least surprise as is evident by the various issues about this subject. However changing it is both a very large and risky change and secondly is a very breaking change as it would break every application that is using go-swagger and there are a lot of them.
This PR #557 holds the solution, but because I was too late with adding it, so it will probably never get merged or completed.

Ok, I understand why you go this way.
About validation, you can always validate raw map, if validation fail then legacy object shouldn't be created, if validation pass then object should fit its schema.
Still this is the best clienst/server generator for GO :D, but for my purposes I will just fork this project and simplify this behaviour for my own, imho this simple thing was over complicated here.

@casualjim this project is still in version 0.x, so your fix #557 is one of the most wanted for the version 1 ;). Agreed with @michalq - this bug causes to make a fork. You don't want the models generated this way in project where you are using go-swagger for the first time, because this bug will spread through the project and make it impossible to bring models back to normal in future.