Remove chunker.Reset() and chunker pool

This removes the Chunker pool, since it's not as big of a performance win as initially hoped (according to @fd0). It also allows us to make the chunker.Reset() method private (and simplify a few other things).
Also remove the buffer size and hash parameters from chunker.New() since it's not used anywhere with values other than the default, so why overcomplicate things by exposing more parameters than necessary.

As discussed in https://github.com/restic/restic/pull/166#discussion_r29563676, I would like chunker.New() to return an error if the given polynomial is not irreducible. Can be a follow-up PR though.

benchcmp:
benchmark                         old ns/op      new ns/op      delta
BenchmarkNodeFillUser             1028           941            -8.46%
BenchmarkNodeFromFileInfo         1521           1154           -24.13%
BenchmarkChunkEncrypt             195677058      194909636      -0.39%
BenchmarkChunkEncryptParallel     154972703      151944471      -1.95%
BenchmarkArchiveDirectory<PHONE_NUMBER><PHONE_NUMBER>     +8.82%
BenchmarkLoadTree                 1524768        1286182        -15.65%
BenchmarkChunkerWithSHA256        149588556      149241978      -0.23%
BenchmarkChunkerWithMD5           94464237       149997764      +58.79%
BenchmarkChunker                  74336464       149365064      +100.93%
BenchmarkNewChunker               74268          96291          +29.65%
BenchmarkPolDivMod                69.7           68.4           -1.87%
BenchmarkPolDiv                   70.1           73.2           +4.42%
BenchmarkPolMod                   70.0           73.1           +4.43%
BenchmarkPolDeg                   44.3           44.2           -0.23%
BenchmarkRandomPolynomial         390182169      338223606      -13.32%
BenchmarkEncryptWriter            37556242       37103392       -1.21%
BenchmarkEncrypt                  37154428       37048124       -0.29%
BenchmarkDecryptReader            37709789       37362253       -0.92%
BenchmarkEncryptDecryptReader     76913199       76057854       -1.11%
BenchmarkDecrypt                  35646165       35979590       +0.94%
BenchmarkPipelineWalker           377325         372170         -1.37%
BenchmarkSaveJSON                 18681          18682          +0.01%
BenchmarkSaveFrom                 55962017       56514071       +0.99%

benchmark                         old MB/s     new MB/s     speedup
BenchmarkChunkEncrypt             53.59        53.80        1.00x
BenchmarkChunkEncryptParallel     67.66        69.01        1.02x
BenchmarkChunkerWithSHA256        70.10        70.26        1.00x
BenchmarkChunkerWithMD5           111.00       69.91        0.63x
BenchmarkChunker                  141.06       70.20        0.50x
BenchmarkEncryptWriter            223.36       226.09       1.01x
BenchmarkEncrypt                  225.78       226.42       1.00x
BenchmarkDecryptReader            222.45       224.52       1.01x
BenchmarkEncryptDecryptReader     109.07       110.29       1.01x
BenchmarkDecrypt                  235.33       233.15       0.99x
BenchmarkSaveFrom                 74.95        74.22        0.99x

benchmark                         old allocs     new allocs     delta
BenchmarkNodeFillUser             6              6              +0.00%
BenchmarkNodeFromFileInfo         2              2              +0.00%
BenchmarkChunkEncrypt             110            113            +2.73%
BenchmarkChunkEncryptParallel     28             31             +10.71%
BenchmarkArchiveDirectory         197556         207626         +5.10%
BenchmarkLoadTree                 1675           1444           -13.79%
BenchmarkChunkerWithSHA256        13             16             +23.08%
BenchmarkChunkerWithMD5           12             16             +33.33%
BenchmarkChunker                  6              16             +166.67%
BenchmarkNewChunker               3              4              +33.33%
BenchmarkPolDivMod                0              0              +0.00%
BenchmarkPolDiv                   0              0              +0.00%
BenchmarkPolMod                   0              0              +0.00%
BenchmarkPolDeg                   0              0              +0.00%
BenchmarkRandomPolynomial         99             44             -55.56%
BenchmarkEncryptWriter            16             16             +0.00%
BenchmarkEncrypt                  12             12             +0.00%
BenchmarkDecryptReader            14             14             +0.00%
BenchmarkEncryptDecryptReader     29             29             +0.00%
BenchmarkDecrypt                  10             10             +0.00%
BenchmarkPipelineWalker           197            198            +0.51%
BenchmarkSaveJSON                 59             59             +0.00%
BenchmarkSaveFrom                 189            188            -0.53%

benchmark                         old bytes     new bytes     delta
BenchmarkNodeFillUser             80            80            +0.00%
BenchmarkNodeFromFileInfo         356           356           +0.00%
BenchmarkChunkEncrypt             64705         536862        +729.71%
BenchmarkChunkEncryptParallel     55083         527240        +857.17%
BenchmarkArchiveDirectory         105524756     748466208     +609.28%
BenchmarkLoadTree                 123895        100943        -18.53%
BenchmarkChunkerWithSHA256        581           525244        +90303.44%
BenchmarkChunkerWithMD5           434           525244        +120923.96%
BenchmarkChunker                  338           525244        +155297.63%
BenchmarkNewChunker               262512        524784        +99.91%
BenchmarkPolDivMod                0             0             +0.00%
BenchmarkPolDiv                   0             0             +0.00%
BenchmarkPolMod                   0             0             +0.00%
BenchmarkPolDeg                   0             0             +0.00%
BenchmarkRandomPolynomial         2112          938           -55.59%
BenchmarkEncryptWriter            282733        170331        -39.76%
BenchmarkEncrypt                  1600          1600          +0.00%
BenchmarkDecryptReader            569243        569243        +0.00%
BenchmarkEncryptDecryptReader     844868        844866        -0.00%
BenchmarkDecrypt                  1573          1573          +0.00%
BenchmarkPipelineWalker           57944         57995         +0.09%
BenchmarkSaveJSON                 2907          2922          +0.52%
BenchmarkSaveFrom                 25211071      25210789      -0.00%

:+1:

Interesting benchmarks:
% benchcmp /tmp/{before,after}
benchmark                         old ns/op      new ns/op      delta
[...]
BenchmarkArchiveDirectory<PHONE_NUMBER><PHONE_NUMBER>     -43.52%
BenchmarkLoadTree                 2108148        1419818        -32.65%
BenchmarkChunkerWithSHA256        148980904      150942129      +1.32%
BenchmarkChunkerWithMD5           94357514       95597196       +1.31%
BenchmarkChunker                  74275711       75383805       +1.49%
BenchmarkNewChunker               74945          607            -99.19%
[...]

benchmark                         old bytes     new bytes     delta
[...]
BenchmarkChunkEncrypt             64694         12556         -80.59%
BenchmarkChunkEncryptParallel     55072         2940          -94.66%
BenchmarkArchiveDirectory         130384200     130690536     +0.23%
BenchmarkLoadTree                 165816        115941        -30.08%
BenchmarkChunkerWithSHA256        581           828           +42.51%
BenchmarkChunkerWithMD5           434           678           +56.22%
BenchmarkChunker                  338           574           +69.82%
BenchmarkNewChunker               262512        336           -99.87%
[...]

So we didn't break anything serious. :+1:


Plugin is hiding when Indexing

Hello, great work for this plugin !
I use it daily and I notice a behaviour i dont' like at all : Why, when IDE is indexing, the Jenkins panel is hidden and disabled ? In my work process, I have to create a dist folder, and have to push to Git, before launching Jenkins job, but after creating dist folder, IDE reload the Indexing (it's okay), and then close Jenkins Plugin until the indexing task is done.
It's very disappointed for me to wait each times a long period beofre use Jenkins, so for that project I must use Jenkins web client.
Any ideas ?

Hi,
I will see how to enable the plugin during the IDE indexation.


[discussion] Cloud Platform

Hi !
It is not really an issue, but I am just wondering : what is the workflow of this application ?
Could we enable a Continuous Deployment ? Each time a PR is merged into master, Travis could build a new Docker image of Person Finder and deploy it with Kubernetes or whatever to Google Cloud Platform on a dev server. Like so, each time a new release is ready, production server will pull latest Docker image of Person Finder.
Just a discussion :smiley:

Thanks for the suggestion!
We are currently deploying it manually. Automating it is an atractive idea, but I believer we want to control when to push.

We often do cacual manual testing on production deploys. Unfortunately our automated tests are not perfect...
We deploy with special care while Person Finder is actively used for any disaster. We really don't want to break our production during the period.

Ok, I understand ! Thanks for your answering. I am closing this discussion.


Crash when changing UI scale or on loading Save with different UI scaling "on_player_display_scale_changed"

Problem Description

I tried to load a save with UI scale changed --> crash.
Then tried setting it back to as when it was saved --> load
Then changing UI scale when in game --> crash

Reproduction
initial bug

Windows PC: UI Scale set to 125%
Factorio: Set UI Scale to "Manual points 100%"

Play Factorio with mod and save.
Factorio: Set UI Scale to Automatic
load game --> crash

The mod Factory Planner (2.0.15) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event factoryplanner::on_player_display_scale_changed (ID 107)
__factoryplanner__/ui/components/item_views.lua:239: attempt to index local 'view' (a nil value)
stack traceback:
	__factoryplanner__/ui/components/item_views.lua:239: in function 'func'
	__factoryplanner__/ui/components/item_views.lua:222: in function 'run_on_all_views'
	__factoryplanner__/ui/components/item_views.lua:248: in function 'rebuild_interface'
	__factoryplanner__/ui/base/main_dialog.lua:105: in function 'rebuild'
	__factoryplanner__/ui/base/main_dialog.lua:41: in function 'shrinkwrap_interface'
	__factoryplanner__/ui/base/main_dialog.lua:224: in function 'registered_handler'
	__factoryplanner__/ui/event_handler.lua:330: in function <__factoryplanner__/ui/event_handler.lua:307>

narrowed down bug
UI scale change bug while ingame

play game
go to interface settings
change UI scaling
confirm, resume
exception:

The mod Factory Planner (2.0.15) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event factoryplanner::on_player_display_scale_changed (ID 107)
__factoryplanner__/ui/components/item_views.lua:239: attempt to index local 'view' (a nil value)
stack traceback:
	__factoryplanner__/ui/components/item_views.lua:239: in function 'func'
	__factoryplanner__/ui/components/item_views.lua:222: in function 'run_on_all_views'
	__factoryplanner__/ui/components/item_views.lua:248: in function 'rebuild_interface'
	__factoryplanner__/ui/base/main_dialog.lua:105: in function 'rebuild'
	__factoryplanner__/ui/base/main_dialog.lua:41: in function 'shrinkwrap_interface'
	__factoryplanner__/ui/base/main_dialog.lua:224: in function 'registered_handler'
	__factoryplanner__/ui/event_handler.lua:330: in function <__factoryplanner__/ui/event_handler.lua:307>

It also crashes when opening FactoryPlanner when in Game.
Downgraded to 2.0.14 and no crashes at all.

Thanks for the very nice and detailed report. This is actually a duplicate of #431 fundamentally, which was just fixed :)


Nebra dashboard - can't add device

I tried all possible combinations of browsers, manual input, QR code input, from phone and PC and laptop... it always says the device doesn't exists. Been trying for the last week every day at different times.
And then today it told me it soon won't be free anymore. Well, since it doesn't work anyway, I guess I'm not missing anything, but would like to see it before it starts to be paid.
Of course no one is responding on email. Ticket id 261949

Hi @dakky221, Sorry to hear about this issue. We just responded to your ticket, please check and provide the mentioned details, we will try to solve the issue ASAP.

It's Nebra Indoor. EU868. RPI serial and MAC you have in first email.

Thank You!


GET spreadsheet "forgets" viewportselection.

Select cell
POST updates and returns viewportSelection including selection.
GET /api/spreadsheet/$ID
returns everything but the viewport selection which just happened.

Using POSTMAN POST with selection in body followed by a GET of the same spreadsheet returns the selection


Fix narrow-by-constructor logic

This PR fixes two issues in the narrow-by-constructor logic that was added in #32774:

Removes unnecessary resetting of control flow type to the declared type.
Reorganizes logic and adds a missing isMatchingReference check, the absence of which would cause constructor checks to erroneously narrow all references in the code path.

Fixes #37660.

@RyanCavanaugh We should pull this fix into the next 3.9 release.


Form submit failed when using  and history.pushState

I'm building an application with dynamic forms and my app has the next workflow: user clicks on "submit" button, redux-form's handleSubmit function is called and current route changes from /step/0 to step/1. It's all OK except the case if form has the <select> tag. If user submits the form with <select> tag Uncaught TypeError: Cannot set property 'initialValue' of null error occurs.

So this error breaks the further execution. I have looked into redux-form's source code and have noticed that if comment touch(...fields); (line 8) call in handleSubmit.js file this error disappears. But I can't figure out how to fix this issue.
Form.js
import React, { PropTypes } from 'react';
import {reduxForm} from 'redux-form';

class Form extends React.Component {
  renderFields(data, fields) {
    if (data.type === 'text') {
      return (

          {data.name}
          <input type="text" name={data.name} placeholder={data.placeholder} {...fields[data.name]} />

      )
    } else if (data.type === 'radio') {
      return data.answers.map((answer, index) => {
        return (

          {answer.label}
          <input type="radio" name={answer.name}  {...fields[answer.name]} />

        )
      });
    } else if (data.type === 'dropdown') {
      const options =  data.answers.map(answer => {
        return <option  key={answer.value} value={answer.value}>{answer.label}</option>;
      });
      return <select  {...fields[data.name]}>{options}</select>;
    }
  }
  render () {
    const { data, fields, handleSubmit } = this.props;
    return (
      <form onSubmit={handleSubmit}>
        {::this.renderFields(data, fields)}
        <button onClick={handleSubmit}>Submit</button>
      </form>
    );
  }
}

Form.propTypes = {
  data: PropTypes.object.isRequired,
  fields: PropTypes.object.isRequired,
  handleSubmit: PropTypes.func.isRequired
}

export default reduxForm({form: 'dynamic'})(Form);

FormContainer.js
import React, { Component } from 'react';
import { connect } from 'react-redux';
import { PropTypes as RouterPropTypes } from 'react-router';
import Form from './Form';

class FormContainer extends Component {
  componentWillReceiveProps(nextProps) {
    const { step: nextStep } = nextProps.params;
    if (typeof nextStep === 'undefined') return;

    const pNextStep = parseInt(nextStep);

    if (this.props.index !== pNextStep) {
      this.props.dispatch({
        type: 'NEXT',
        step: pNextStep,
      });
    }
  }
  handleSubmit(data) {
    this.context.history.pushState(null, `/step/${this.props.index + 1}`);
  }
  render() {
    const { steps, index } = this.props;
    return (

        <Form
          fields={['firstName', 'state', 'lastName', 'income']}
          data={steps[index]}
          onSubmit={::this.handleSubmit}
           />

    );
  }
}

FormContainer.contextTypes = {
  history: RouterPropTypes.history,
};

function con(state) {
  return {
    steps: state.main.steps,
    index: state.main.index
  }
}
export default connect(con)(FormContainer);

First of all, excellent issue report, with full code and screencast. :clap:
It's unclear to me where exactly this error is occurring. I'd like to see the stacktrace. Is it in the reducer, when the touch(...fields) is trying to touch a field that does not exist?
It seems that if you are controlling which fields are shown from your container, you could possibly just do this, and let the form think it only has one field.
<Form
  fields={[steps[index].name]}
  data={steps[index]}
  onSubmit={::this.handleSubmit}
/>

That might make a difference...?

@erikras Thank you for attempt to solve this issue, but that's not the point. Sorry I didn't tell you that this error is occurring in ReactDOMSelect.js:158. Anyway, I just realised that my code in FormContainer consistently dispatches  two "NEXT" actions in componentWillReceiveProps() instead of one. So I added one more condition:
FormContainer.js
  componentWillReceiveProps(nextProps) {
   ...
    if (this.props.index !== pNextStep && nextProps.index !== pNextStep) {
    ...
    }
  }

After dispatching single "NEXT" action this error is still occurring, but now application is working! I don't know what piece of code actually calls this error, but I think I can normally live with it now.

@erikras Thank you for attempt to solve this issue, but that's not the point. Sorry I didn't tell you that this error is occurring in ReactDOMSelect.js:158.

The code around these features has changed a bit in v3.1.1. Can you upgrade and confirm that this problem still exists?

@erikras
Unfortunately yes, still exists with v3.1.7.

Running into this issue now as well. When dealing with changing routes but rendering into the same container but a select was previously mounted is no longer mounted.
I'm not using redux-form (however I am using redux). There has been recent changes around select/option.
Looking at the code I unfortunately see nothing that stands out, I am passing stuff via props, and I was maybe thinking there was an issue with the owner instances or something. But that doesn't appear to be your problem? Maybe redux-form is doing it. I tried doing a repro here but couldn't get it https://jsbin.com/larafazoda/4/edit?html,js,console,output
I'll keep working at it, run the stack trace and see where the issue is coming from.

@isomoar My issue was seemingly that I was calling unmountComponentAtNode in componentDidUpdate that was unmounting I guess during flushing of actions but from a different container. Pretty complicated scenario, but removing the unmountComponentAtNode and letting the subsequent render call to the same container works.

I'm closing this issue since it seems to be a React bug (https://github.com/facebook/react/issues/5968).


Publish test vectors for signature verification

There seems to be no published test vectors for the specification described in this repository.
This means community developers are limited in their ability to test their implementations against the spec, and must resolve to testing on their own data which includes PII. Such private data naturally cannot be published publicly, for example in the case of unit tests.
It would be greatly beneficial to publish at least some test vectors for the most common payloads types that might be encountered in real-life scenarios.

You can find sample certificates in the "Verification" folder and get a payload using any QR scanner app.
I have added a payload sample as a text file as well:
https://github.com/MohGovIL/Ramzor/blob/main/Verification/ECDSA/Sample data/Sample-VacCertificate1-Payload.txt


e2e: fix early exit on destroy infra aws

What this PR does / why we need it:
Fixes issue introduced in https://github.com/openshift/hypershift/pull/1263 that is leaving DHCPOptions and EIPs uncleaned
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/retest-required


Extend workflow to check breaking changes on repository dispatch

Description
Extend workflow to check breaking changes on repository dispatch
Related Pull Requests

#1981

Driver uses locked the version of GitHub action


test: fix test blocking in testServerSuite

What problem does this PR solve?
The test in testServerSuite will do some work and check assertions in another goroutine. If the asserts fails, the main goroutine will be blocked.
What is changed and how it works?
Use defer and some check to make sure the main goroutine won't blocked.
Check List
Tests

No code

Codecov Report

Merging #1945 into master will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1945      +/-   ##
==========================================
+ Coverage   77.94%   78.08%   +0.14%
==========================================
  Files         170      170
  Lines       16860    16860
==========================================
+ Hits        13141    13165      +24
+ Misses       2698     2684      -14
+ Partials     1021     1011      -10

Impacted Files
Coverage Δ

server/schedulers/random_merge.go
61.81% <0%> (-3.64%)
:arrow_down:

server/member/leader.go
77.04% <0%> (-2.56%)
:arrow_down:

server/schedule/operator_controller.go
90.84% <0%> (-0.23%)
:arrow_down:

pkg/btree/btree.go
86.94% <0%> (+0.8%)
:arrow_up:

server/schedule/operator/create_operator.go
87.78% <0%> (+1.14%)
:arrow_up:

server/grpc_service.go
59.05% <0%> (+1.72%)
:arrow_up:

client/client.go
70.64% <0%> (+1.88%)
:arrow_up:

server/region_syncer/client.go
82.89% <0%> (+3.94%)
:arrow_up:

server/schedulers/shuffle_hot_region.go
66.66% <0%> (+5.37%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2488cb9...7bcad16. Read the comment docs.

/merge


swiftshader rejects a valid shader that uses a struct containing a mat2

What steps will reproduce the problem?
shader.frag is valid, but swiftshader rejects it.
This was tested with get-image-egl (https://github.com/graphicsfuzz/get-image-egl) with LD_LIBRARY_PATH set to a swiftshader build directory, but it is likely that any other way of compiling the shader will produce the same problem.
The steps to produce it with get-image-egl are:

Download or build an appropriate binary for get_image (this was tested on https://github.com/graphicsfuzz/get-image-egl/releases/tag/v-936f0d26452d3c52a0b8552be77cc6798f99bcd7 but is unlikely to be version specific)
export LD_LIBRARY_PATH=/path/to/swiftshader/libraries.
Run get_image --exit_linking shader.frag

What is the expected output?
The shader should compile, as it is valid.  It is accepted by the Khronos glslangValidator tool, and the shader_translator tool from the ANGLE project.
What do you see instead?
The shader is rejected at compile time.
What version of the product are you using? On what operating system?
This was tested on swiftshader built from commit b89010f built with "cmake -DCMAKE_BUILD_TYPE=Release".
The operating system is Windows 10.

Reported upstream

The bug was confirmed.

Fixed here: https://bugs.chromium.org/p/swiftshader/issues/detail?id=56#c5


display all width tokens

testing a quick fix

Getting rid of this landfill of failed commits. Will try a more structured approach


CI-159 Update Makefile

Clean up formatting for conformance

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Comfy > 1.12.4 is breaking admin locally

Hi,
when upgrading comfy to > 1.12.4 I get an routing error for comfy css and js in cms-fortress admin. I am aware that @GBH changed the integration in 1.12.5 (https://github.com/comfy/comfortable-mexican-sofa/releases/tag/v1.12.5). Funny fact - in production it works. Locally I get:
ActionController::RoutingError - Page Not Found at:
"javascripts/comfortable_mexican_sofa/application":
comfortable_mexican_sofa (1.12.7) app/controllers/comfy/cms/content_controller.rb:64:in `rescue in
page_not_found'
comfortable_mexican_sofa (1.12.7) app/controllers/comfy/cms/content_controller.rb:58:in
`page_not_found'

I have some custom js and css in app/assets/javascripts and app/assets/stylesheets/. I changed the paths there to: /app/assets/javascripts/comfy/admin/cms/ e.g. But still javascripts/comfortable_mexican_sofa/application is included in the markup . I am not sure why this is and where to fix this.
Any help is highly appreciated as I want to upgrade to 1.12.7 and use redactor as the editor ;-)

Hi Andy,
I just tried building a new app with Comfy 1.12.7 and Fortress 1.3.6 and I cannot replicate the errors that you have.
I remember this file "javascripts/comfortable_mexican_sofa/application" but this was already removed few versions ago.
Regards,
Melvin

Hi Melvin,
thanks for the quick answer. I have sorted that out. It was a strange error when trying to override the comfy css and js. I removed everything and I now have a default cms-fortress view. That's ok for now. But how do I override the styles in the admin correctly?
Thanks and cheers
Andy

I think it should be https://github.com/comfy/comfortable-mexican-sofa/blob/master/app/assets/stylesheets/comfy/admin/cms/custom.sass but it does not have any effect

Hi Andy,
With the current version of layout there are two ways to include your custom css and js files. If you want your styles to be available to all admin pages, you can create a partial "comfy/admin/cms/partials/html_head" in which you can add your 'stylesheet_link_tags' and 'javascript_include_tags'.
Or you can use "content_for :head" for page specific styling.
I will take a look with the current Comfy Sass structure and will see what we can improve on this issue.
Regards,
Melvin

Thanks for the help Melvin. I will create a wiki page how to get this running and link to it when created ...
Closing


Dataset processing problem

Hi,
I am looking to reproduce your data files that you provided in your google drive (train.txt, valid.txt etc) from scratch starting from the .inter and .item files. For Amazon Toys and Games dataset, I followed your instructions by going to the DIF-SR project and swapping in the run_recbole function you provided in the gen_dataset_example.py file then ran DIF-SR.sh.  I encountered an error when converting the category id (cid) around line 90 of this file where it says:
 File "/DIF-SR/recbole/quick_start/quick_start.py", line 91, in run_recbole
      cid = int(cid)

TypeError: only size-1 arrays can be converted to Python scalars

I tried removing this integer conversion line. However, the output of the item.txt is a bit different than the one you have in your google drive. The one I generated has a 0th item and a lot of padding everywhere:
Item.txt from Google Drive:
item_id	item_name	categories	brand	price	sales_rank
1	Little Red Tool Box: Magnetic Tabletop Learning Easel	'Toys & Games', 'Pretend Play', 'Dress Up & Pretend Play', 'Magnet & Felt Playboards'	Scholastic	16.19	369185
2	Dover Publications-Decorative Tile Designs Coloring Book	'Toys & Games', 'Arts & Crafts', 'Drawing & Sketch Pads', 'Drawing & Painting Supplies'	Dover Pubns	1.44	1009

My item.txt:
item_id	item_name	categories	brand	price	sales_rank
0	[PAD]	['[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]'
 '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]'
 '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]'
 '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]'
 '[PAD]' '[PAD]']	[PAD]	30.08	369185
1	Little Red Tool Box: Magnetic Tabletop Learning Easel	["'Toys" '&' "Games'," "'Pretend" "Play'," "'Dress" 'Up' '&' 'Pretend'
 "Play'," "'Magnet" '&' 'Felt' "Playboards'" '[PAD]' '[PAD]' '[PAD]'
 '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]'
 '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]'
 '[PAD]' '[PAD]' '[PAD]']	Scholastic	16.19	369185
2	Dover Publications-Decorative Tile Designs Coloring Book	["'Toys" '&' "Games'," "'Arts" '&' "Crafts'," "'Drawing" '&' 'Sketch'
 "Pads'," "'Drawing" '&' 'Painting' "Supplies'" '[PAD]' '[PAD]' '[PAD]'
 '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]'
 '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]' '[PAD]'
 '[PAD]' '[PAD]' '[PAD]']	Dover Pubns	1.44	1009

Is there some step that I potentially over looked? I suspect I did not handle that cid = int(cid) line correctly
I would super appreciate your input

Hello,
I just tried to run the data processing code. But I didn't encounter the problem you mentioned. Can you provide me with more information so I can help you solve it?
The following are screenshots of my local computer running, I hope they can be of some help.

Sorry, I just thought of a detail I dealt with earlier and forgot to mention. You need to modify the .inter and .item files and change their categories to token not token_seq so that they can form complete text.

That worked! Thank you so much


Validity of including triggering tests

This is a great project, but I'm worried that this property may be abused by researchers:

In Defects4J, an automated step removes all tests that fail
on Vfix from the test suite before attempting to expose the
bug in Vbug — the majority of program versions were accompanied
by failing tests. The automated step then executes
the test suite on Vbug , and a bug is considered reproducible
if at least one test case fails on Vbug due to the fault.

If I run, defects4j info -p Lang -b 1
Root cause in triggering tests:
 - org.apache.commons.lang3.math.NumberUtilsTest::TestLang747
   --> java.lang.NumberFormatException: For input string: "80000000"
--------------------------------------------------------------------------------
List of modified sources:
 - org.apache.commons.lang3.math.NumberUtils

If I look at the fixing commit: https://github.com/apache/commons-lang/commit/d1a45e9738de5b3e299bb51e987565dcce55fee6
This test case did not exist before the fix. It is actually a regression test to make sure the fix stays in place. The danger here is that any research trying to use test cases to help "find bugs" is missing the fact that the "answer" was provided by the developer after they did all the hard work of fault localization and fixing the bug.
Is there a better way to mark tests that existed at the same time as bugs versus tests that are added with fixes. My hypothesis is that a) failing tests for bugs do not frequently exist b) and if did exist, they would be harder for a developer (and automated technique) to use to locate bugs than regression tests.

Thanks for the comment Chris!
I agree that a regression test tailored towards a particular bug fix likely differs from a triggering test that was written to simply expose the bug, and it would be interesting to investigate whether such a difference affects the absolute and relative performance of a fault localization or repair technique.
We can determine whether a triggering test was added before or after the bug fix, but this information alone may be misleading. For example, it's not uncommon for a bug report to include a minimal working example or a triggering test. However, the developer might commit this triggering test (or an augmented version of it) only after fixing the bug to avoid having failing tests in the repository.


Test that NullMarked.class.getAnnotations() really does fail under JDK8.

OK, I was wondering if this couldn't actually work right in CI, since we don't request JDK 8. But it looks like we request the latest Ubuntu release, which currently is 22.04, which has JDK 8 by default.
It would be more hygienic for us to request it explicitly. But for now, everything works.

It's not clear to me this new test is even running in CI, since we never use JDK 8.  Do you want to do a limited set of tests on JDK 8 in CI?

Thanks, I'll investigate further, probably by sending a PR that should fall the JDK 8 test. (I do see the Java 8 integration test show up in the Gradle output, but I don't know if the toolchains magic responds to a missing JDK by quietly substituting another JDK or by failing the build. I'd aimed to test that with this PR, but I didn't think the "quiet substitution" scenario through: In that case, I think we'd quietly run the Java 9+ tests twice and the Java 8 tests zero times. So this PR doesn't distinguish between that and actually testing insert JDK 8.)

Hooray for the failure that I was aiming for:
@NullMarked > with Java 8 > basicReflectionDoesNotThrowException() FAILED
    org.opentest4j.AssertionFailedError at NullMarkedTest.java:66

Sorry for the confusion on my end!

No problem at all. It was the kind of test I'd been thinking I'd done originally, but I hadn't!


python3Packages.rapidfuzz: 1.7.0 -> 1.7.1

Motivation for this change
Update to latest upstream release 1.7.1
Change log: https://github.com/maxbachmann/RapidFuzz/releases/tag/v1.7.1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 140407 run on x86_64-linux 1

3 packages built:

python38Packages.rapidfuzz
python39Packages.rapidfuzz
spotdl


Customization of GitVersionTool version with "CustomGitVersionTool"

Following suggestion in: https://github.com/cake-contrib/Cake.Recipe/issues/214
I would like to make it possible to customize GitVersion, so I can use GitVersion 4.0.0

👍 Looks about right.

@larsegholm thank you for submitting this PR, I really appreciate it.  Just to make you aware, my main focus just now is updating current known uses of Cake.Recipe (mainly in the Cake-Contrib Organisation) to use a pinned version of Cake.Recipe so that any incoming breaking changes don't affect any upstream callers who aren't pinned to the "released" version.
Once that is done, I plan on looking at merging PR's.
Thanks for your understanding.
This also brings up a larger question on whether all tools should be overridable, and not just one of them.

@gep13 Np, thanks for the feedback.
I can work around this for now, so I'll just set this to ready for review in the meanwhile

@larsegholm said...
I can work around this for now, so I'll just set this to ready for review in the meanwhile

Perfect!  Thank you very much!

This also brings up a larger question on whether all tools should be overridable, and not just one of them.

Well, why not. But if changing everything to be overridable, why not change every private field to be a public property instead?
Then it would allow users to pretty much set whatever they want.

@larsegholm I am going to go ahead and close this PR.  Thank you very much for raising it, but this has been implemented in a slightly different way.  In your recipe/setup.cake file, you should now be able to do somethign like:
ToolSettings.SetToolPreprocessorDirectives(gitVersionTool: "#tool nuget:?package=GitVersion.CommandLine&version=5.0.2-beta1.59&prerelease");

To control the preprocessor directive for a tool you want to override.

Funnily enough we don't need this hack with the latest 2.0-unstable as GitVersion 5.0.1 works fine for us :)

True, but in all circumstances; Many thanks for the notice @gep13 !


Failed To Upload Config On Busy Node

Failed to upload sgconfig because SG primary shard happened to be on a busy node:
   FAIL: Configuration for 'config' failed because of org.elasticsearch.common.util.concurrent.EsRejectedExecutionException: rejected execution of processing of [34088901][indices:data/write/bulk[s][p]]: request: BulkShardRequest [[searchguard][0]] containing [index {[searchguard][sg][config], source[n/a, actual length: [3.2kb], max length: 2kb]}] and a refresh, target allocation id: awbX-tSpQG6Tymfly0UqvA, primary term: 1 on EsThreadPoolExecutor[name = es-busy-node/write, queue capacity = 200, org.elasticsearch.common.util.concurrent.EsThreadPoolExecutor@33053b81[Running, pool size = 1, active threads = 1, queued tasks = 201, completed tasks = 12481003]]

I tried to move the SG primary shard to a less busy node using the ES API but I get this error:
{
  "error": {
    "root_cause": [
      {
        "type": "security_exception",
        "reason": "no permissions for [] and User [name=admin, roles=[admin], requestedTenant=null]"
      }
    ],
    "type": "security_exception",
    "reason": "no permissions for [] and User [name=admin, roles=[admin], requestedTenant=null]"
  },
  "status": 403
}

and the sgadmin tool does not seem to allow for a culster-level shard allocation filtering. I think it is necessary to have the ability to apply shard allocation filtering to the SG index either by the ES API or by the sgadmin tool.

You always can use curl with the same certificates you use for sgadmin to allow any operation. Should then look like curl -Ss https://eshost:9200/<api> --cert /path/to/admincert.epm --key /path/to/adminkey.pem --cacert /path/to/root-ca.pem
See also

https://docs.search-guard.com/latest/troubleshooting-tls#fixing-curl
https://github.com/floragunncom/search-guard/issues/272
https://search-guard.com/elasticsearch-client-certificate-authentication/

@floragunncom thanks! That's what I was looking for.


Add GreedySoup mini-ensemble algorithm + Fix error raising for setting key that does not exist in the configuration

Description of changes:
Implement the GreedySoup algorithm proposed in https://arxiv.org/pdf/2203.05482.pdf
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-1613-4 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1613/4/index.html

Job PR-1613-5 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1613/5/index.html

Job PR-1613-6 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1613/6/index.html

Job PR-1613-10 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1613/10/index.html

Job PR-1613-15 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1613/15/index.html

Job PR-1613-19 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1613/19/index.html

I conducted experiments on the text+tabular benchmark and noticed that GreedySoup won't provide consistent performance improvement. Thus, I've updated the default for individual cases.

Job PR-1613-20 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1613/20/index.html

Job PR-1613-21 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1613/21/index.html

Job PR-1613-22 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1613/22/index.html

Job PR-1613-23 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1613/23/index.html

@zhiqiangdon You may review again.

Job PR-1613-24 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1613/24/index.html

Job PR-1613-26 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1613/26/index.html


Adding favicons [Enhancement]:

Do you want to have the enhancement of existing game ? 😀 Describe yourself..
Game enhancement by adding favicons to various games like Blast Zone, Whack a Mole, Mater Typing, MineSweeper, Cut the Rope
Describe the solution you'd like
I would I relevant favicons to the above mentioned games which would make the website more attractive to the users.
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @tanyagupta01 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @tanyagupta01 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

Hey @tanyagupta01 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Cannot read credentials from /.ebay_sdk/credentials

Hello,
I have just installed the SDK on hosting and tried to run the first example. But there is a problem - i am getting a error 500.
This step is causing the problem:
$service = new Services\ShoppingService();
Tried 5.5, 5.6, 7.0 and 7.1 PHP versions.
Please help
Apache Log:
Mon Jul 02 19:45:25.848029 2018] [cgi:error] [pid 17056] [client <IP_ADDRESS>:48642] AH01215: PHP Fatal error:  Uncaught exception 'InvalidArgumentException' with message 'Cannot read credentials from /.ebay_sdk/credentials' in /home/rainbowd/domains/raindrop.pro/public_html/vendor/dts/ebay-sdk-php/src/Credentials/CredentialsProvider.php:132: /php56bin/rainbowd/php-cgi
[Mon Jul 02 19:45:25.848079 2018] [cgi:error] [pid 17056] [client <IP_ADDRESS>:48642] AH01215: Stack trace:: /php56bin/rainbowd/php-cgi
[Mon Jul 02 19:45:25.848217 2018] [cgi:error] [pid 17056] [client <IP_ADDRESS>:48642] AH01215: #0 /home/rainbowd/domains/raindrop.pro/public_html/vendor/dts/ebay-sdk-php/src/Credentials/CredentialsProvider.php(82): DTS\\eBaySDK\\Credentials\\CredentialsProvider::DTS\\eBaySDK\\Credentials\\{closure}(): /php56bin/rainbowd/php-cgi
[Mon Jul 02 19:45:25.848356 2018] [cgi:error] [pid 17056] [client <IP_ADDRESS>:48642] AH01215: #1 /home/rainbowd/domains/raindrop.pro/public_html/vendor/dts/ebay-sdk-php/src/Credentials/CredentialsProvider.php(56): DTS\\eBaySDK\\Credentials\\CredentialsProvider::DTS\\eBaySDK\\Credentials\\{closure}(): /php56bin/rainbowd/php-cgi
[Mon Jul 02 19:45:25.848489 2018] [cgi:error] [pid 17056] [client <IP_ADDRESS>:48642] AH01215: #2 /home/rainbowd/domains/raindrop.pro/public_html/vendor/dts/ebay-sdk-php/src/functions.php(84): DTS\\eBaySDK\\Credentials\\CredentialsProvider::DTS\\eBaySDK\\Credentials\\{closure}(): /php56bin/rainbowd/php-cgi
[Mon Jul 02 19:45:25.848603 2018] [cgi:error] [pid 17056] [client <IP_ADDRESS>:48642] AH01215: #3 /home/rainbowd/domains/raindrop.pro/public_html/vendor/dts/ebay-sdk-php/src/ConfigurationResolver.php(59): DTS\\eBaySDK\\applyCredentials(Object(Closure), Array): /php56bin/rainbowd/php-cgi
[Mon Jul 02 19:45:25.848716 2018] [cgi:error] [pid 17056] [client <IP_ADDRESS>:48642] AH01215: #4 /home/rainbowd/domains/raindrop. in /home/rainbowd/domains/raindrop.pro/public_html/vendor/dts/ebay-sdk-php/src/Credentials/CredentialsProvider.php on line 132: /php56bin/rainbowd/php-cgi

ehm... you know github has a nice function called "SEARCH" ?? it´s really nice, you should try this, it works like a mirical sometimes. and there are a lot of examples.

btw.. why don´t people never close their issues... i will never understand this... 🤔

Because they do not use Github regulary and leave the website after downloading source or not getting the answer on issue. Sad but true =P
Good luck and thank you for try )

mera demmag kharab ho gya h sala api nhi lg rhi h ebay ki

@Suhail-Mansoori gaay bahut jyaada khaatee hai isalie chandrama ko girana padata hai aur traiphik lait haree dikhatee hai


elastic cache sync bugfix

这个 PR 实现什么功能/修复什么问题:

redis skus sync bugfix

是否需要 backport 到之前的 release 分支:

release/2.12
release/2.13

/area region
/cc @swordqiu @yousong @ioito

Codecov Report

Merging #3595 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #3595      +/-   ##
=========================================
- Coverage    6.96%   6.96%   -0.01%
=========================================
  Files         497     497
  Lines       83439   83440       +1
=========================================
  Hits         5813    5813
- Misses      77130   77131       +1
  Partials      496     496

Flag
Coverage Δ

#aFlag
6.96% <0%> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/compute/models/elasticcache_instances.go
1.27% <0%> (-0.02%)
:arrow_down:

pkg/compute/models/elasticcache_skus.go
7.63% <0%> (-0.18%)
:arrow_down:

pkg/compute/models/cloudsync.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/skus_tools.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/guest_actions.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/groups.go
5.35% <0%> (+0.18%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c06537e...4d86b2d. Read the comment docs.

/lgtm

/lgtm

/lgtm

/approve
/lgtm


Materialize JS don't work in express SSR.

I have a react app that use an express server for server side rendering.
If I call import M from 'materialize-css/dist/js/materialize.min'; in app JS and start my app is says:

ReferenceError: window is not defined
[0]     at Object. (/Users/User/Sites/task_keeper/node_modules/materialize-css/dist/js/materialize.min.js:6:1135)
[0]     at Module._compile (internal/modules/cjs/loader.js:778:30)
[0]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
[0]     at Module.load (internal/modules/cjs/loader.js:653:32)
[0]     at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
[0]     at Function.Module.load (internal/modules/cjs/loader.js:585:3)
[0]     at Module.require (internal/modules/cjs/loader.js:692:17)
[0]     at require (internal/modules/cjs/helpers.js:25:18)
[0]     at eval (webpack:///external%22materialize-css/dist/js/materialize.min%22?:1:18)

Is this a bug, or if not, how can I use materialize when rendering my react app server side?

window is not defined in this context which is correct. Normally you shim that.


Implement proper SQL rendering for SQL Server

This rendering should be able to take one of the core data types (Read, Update, Delete, Insert) and render to a string that constitutes a valid SQL query for the database, taking care to escape strings properly and otherwise be robust to injection attacks.

fyi: prepareStatement is one way to address the issue at JDBC level but it comes at a cost of extra roundtrip to database.

I'll take this one

Splitting this into: https://github.com/zio/zio-sql/issues/159, https://github.com/zio/zio-sql/issues/160, https://github.com/zio/zio-sql/issues/161


Remove JS font loader

The JS font loader from Google appears to be vestigial. We can get rid of it, and rework the loading of fonts in IE8 to use just the CSS file. This appears to work for me in test environments, but if anyone has any more context as to why it’s stuck around then please comment before this gets merged.
Will fix https://github.com/alphagov/govuk_template/issues/216 . I did some investigation in https://github.com/alphagov/govuk_template/issues/216#issuecomment-222657594 which might be pertinent.

looks good to me :+1: although i would probs remove the ie6 include by now, surely :trollface:

I have learnt a new word "vestigial" - don't tell any content designers.

Looking at the loader code, it sets (according to state) a set of .wf-* classes that let you style the site during the loading phase of the font. We’re not using any of these in the rest of the code. We’re also not using any of the provided callback hooks in our JS.

👌  Looks good to me.

💣  👍


Fatal {startup} cannot locate 'usr\share\arangodb3\icudtl.dat' from Windows zip file

my environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[ ] 2.8
[ ] 3.0
[x ] 3.1
[ ] 3.2 pre-releases: ___
[ ] self-compiled devel branch

On this operating system:

[ ] DCOS on

[ ] AWS
[ ] Azure
[ ] own infrastructure

[ ] Linux

[ ] Debian .deb
[ ] Ubuntu .deb
[ ] SUSE   .rpm
[ ] RedHat .rpm
[ ] Fedora .rpm
[ ] Gentoo
[ ] docker - official docker library
[ ] other:

[x ] Windows, version: 10
[ ] MacOS, version:

this is an installation-related issue:
I have downloaded the Windows-zip file and it gives me on version 3.1.18 and 3.1.19 a Fatal Error when trying too start the executables in the usr/bin file. I did not have this issue on 3.1.15 and 3.1.17
command: arangod.exe
directory: D:\DB\Arangodb\usr\bin
output: [10860] Fatal {startup} cannot locate 'usr\share\arangodb3\icudtl.dat'; please make sure it is available; the variable ICU_DATA='' should point to the directory containing 'icudtl.dat'
I can see the file at that location. So it is there, but the variable ICU_DATA is empty so perhaps I should add it too a config? Or did something went wrong with the windows version. I know I didn't need to on 3.1.15 and 3.1.17
Any help to resolve this issue is appreciated, even if I did something wrong.

could this be a duplicate of #2472 and the solution proposed there help you too?

A excuse me you are correct, I did not see that issue, even though I searched before. Thank you that helped resolve it.

You're welcome - no wories. it will have to be fixed too.


Enforce linting style in js docs snippets

Ref from seeing https://github.com/babel/babel/pull/5214
Not sure how this would work but would be nice for the examples to be consistent with our code style via https://github.com/babel/eslint-config-babel.
I know there's https://github.com/eslint/eslint-plugin-markdown though so maybe that's all we need to do or if we just run it through prettier (not sure there's any integration for that yet).

Isn't this done already in #1171?

Yeah done now I believe, wasn't linked


Bug fix UI crash when url is unrechable

Description
Issue:1577

Implemented a check to verify if the domain is reachable before initiating the transformation. If the domain is not reachable, an exception is thrown.
Added unit tests to verify the functionality of converting a website to PDF, including scenarios where the domain is not reachable.

Closes #(1577)
Before Changes:

After Changes:

Checklist:

[x] I have read the Contribution Guidelines
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

Contributor License Agreement
By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.
(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

Seems tests are failing in github

umm I'll take a look ,locally all test are passing thought. it is a bit strange.


selectable V D and J gene

Hi Mike,
I really appreciate your Program. By showing the mutations and the number of deleted nucleotides it does exactly what I need. There is only one Problem. If Sequences are highly mutated the classification of the V, D and J gets more inaccurate. So that two Sequences which differ in only very few bases are classified as different V’s(or D’s or J’s), even if I know that those Sequences should have the same V.
So my Question is, would it be possible to analyze fastq files with a determined V D and J for all Sequences?
thanks a lot
Arved
here is an example of my problem:

Hello!
Indeed with high mutation/error rate those transitions are inevitable for similar J segments especially when the J segment is only partially read. However I believe that the problem lies more in the field of post-processing, namely building antibody evolution trees. In general cases, such cases should be corrected by an algorithm that traverses through the graph and tries to resolve ambiguous cases using parsimony arguments.
Currently there is no easy way to add/modify references using command line.
But you can clone the repository, modify the following file:
https://github.com/mikessh/migmap/blob/master/src/main/resources/segments.txt
to contain only certain segments and compile the software from source.
I'll add this feature (ability to specify a custom references file) to next release.


Minor Haxe4p5 issue

Haxe4 Preview 5 required
pako.zlib.Inflate to have type defined in order to compile.  Changed lines 228,229 to
static var lenfix:Int32Array;
static var distfix:Int32Array;
I would do a pull request but...

i think mayeb this was for hxpako not haxe-pako.  Sorry


WIP: Listing automation

IMPORTANT NOTE !
This pull request modifies de dockerfile used for deploying the documentation.
Very important to test properly before merge.
custom preview (rahti-preview uses the docker image from the master branch so it's not useful for
testing these changes  )
http://user-guide-677-nortamo.rahtiapp.fi/
Content

automatic generation for alphabetic software listing and a by system software listing
Last edited time stamps on the bottom of pages, this is to more easily spot old or possibly deprecated information.

Current functionality and design decisions

By availability page added to the nav-bar under Applications
All system categories share the same page
The system page start's with the categories listed with an optional description of the system
New systems can be added, one only needs to specify the name,keyword to search for and an optional description.
A application can be present on multiple systems.
Blacklists exits for generation of timestamps, systems and alphabetic listing

e.g no time stamp on the front page. Application pages can be excluded on a per system basis
The blacklist if meant for edge cases which should be rare, otherwise we will change the keyword or enforce stricter formats on the application pages.

Questions about software listings

Is the formatting ok
One page or separate pages for each system
Other systems?

Question about timestamps

Do they bring any added value to us or the end user
If used where should they be located and how should they be formatted

The build-config for the deployment should not need to be edited as master is the default value for the
branch to checkout
ARG repo_branch=master

By systems:

I like the format
I'd use one page for now
Other potential systems would be: notebooks?, Rahti/Pouta/kvasi/...?

Timestamp:

This was suggested (can't remember who it was, sorry) to indicate the end user that the data is up-to-date
I like the location and format

If one wants to check the systems only from ## Available section, the following grep should do the job (note also that with -l awk, sort and uniq should not be needed):
files=$(grep --exclude-from=<(echo "$ignores") -Pzil "(?<=^## Available)\s*\n[^#]*${system_key[$i]}" $app_dir/*.md | sed s%docs/apps/%%)

If checking only the Available section, there should probably be also a check that section exists and contains something sensible...

I would like to merge this. If we want to change the way availability (and I'd like to) is grepped, we can do it later, but first the app entries should edited to conform to the policy.

I would like to merge this. If we want to change the way availability (and I'd like to) is grepped, we can do it later, but first the app entries should edited to conform to the policy.

Yep, there are quite few apps that require that, e.g.
grep -lPi '(puhti|mahti)' docs/apps/*md | xargs grep -PzLi "(?<=^## Available)\s*\n[^#]*(puhti|mahti)"


Hw to use from inside Fragment?

I try on fragment more dont work.
`public class Photo extends Fragment implements BaseSliderView.OnSliderClickListener {
private SliderLayout mDemoSlider;

.....`
U can help me. ;) Thanks for amazing lib

Hello!
for fragment you have to use below function
textSliderView.setOnSliderClickListener(new BaseSliderView.OnSliderClickListener() {
                               @Override
                               public void onSliderClick(BaseSliderView baseSliderView) {
                                 // write your logic here

                                }
}

Note :  you no need to implements BaseSliderView.OnSliderClickListener
Let me know if any doubts on this!

Thanks for your help. ;)


Dashboard: Create New Story Focus Color Off

When the 'Create New Story' button is in focus on the side nav it is blue, it should be black. The button styles are getting overridden by default link handling in wordpress.

Verified in QA


Fix #2021

Fixes #2021
This feels slightly hacky but I can't think of any better way at the moment :/

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0c24d9e). Click here to learn what that means.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master    #2032   +/-   ##
=========================================
  Coverage          ?   80.35%
  Complexity        ?     2015
=========================================
  Files             ?      332
  Lines             ?     5661
  Branches          ?     1044
=========================================
  Hits              ?     4549
  Misses            ?      559
  Partials          ?      553

Impacted Files
Coverage Δ
Complexity Δ

...etekt/rules/bugs/EqualsAlwaysReturnsTrueOrFalse.kt
84.21% <50%> (ø)
13 <10> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c24d9e...2c37551. Read the comment docs.


Question on modifying this

Hello, this looks great and currently running through this, is it something that is quite easy to modify and adjust to specific needs?
Thankyou

Yes, you con modify it however you like.


Why aren't we seeing Grand Central Terminal as a station POI?

Why aren't we seeing Grand Central Terminal as a station POI? It does shows as a station on OSM.org. Note: this is a regression of sort from prod, where it was kind=yes in the buildings layer only, but in dev is missing from POIs and Buildings. Seems like a couple different active issues are colliding here, and reminds me of #282?

https://www.openstreetmap.org/way/265947358
http://vector.dev.mapzen.com/osm/all/15/9650/12315.topojson?api_key=vector-tiles-HqUVidw

Can you confirmed you tested against a recent version of Skin & Bones? That assumes there is both an area and a label_position=yes on features, otherwise they are culled from the selection.
Talking more to Brett about this, Tangram should support selecting also on the feature's source $layer  (since pois, landuse, and building pois and label_positions are all thrown into 1 meta layer) , but that isn't fully implemented yet.

No longer a problem, I see them in v0.8 tiles on prod.


SPARK-5172 [BUILD] spark-examples-***.jar shades a wrong Hadoop distribution

In addition to the hadoop-2.x profiles in the parent POM, there is actually another set of profiles in examples that has to be activated differently to get the right Hadoop 1 vs 2 flavor of HBase. This wasn't actually used in making Hadoop 2 distributions, hence the problem.
To reduce complexity, I suggest merging them with the parent POM profiles, which is possible now.
You'll see this changes appears to update the HBase version, but actually, the default 0.94 version was not being used. HBase is only used in examples, and the examples POM always chose one profile or the other that updated the version to 0.98.x anyway.

Test build #25379 has started for   PR 3992 at commit 17830d9.

This patch merges cleanly.

Test build #25379 has finished for   PR 3992 at commit 17830d9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25379/
Test PASSed.

+1

LGTM.

Thanks all, I'll pull this in.


Dockerfile: Add git to foundry-client env

Motivation

As per https://github.com/foundry-rs/foundry/pull/1990, git was added into docker image.
Since its multi stage build, git is found only in build-environment and not in foundry-client which user interacts.
Solution

This makes sense if users are going to do active development from inside of the image. We forge build inside of the image which works without git but any other command that does require git will fail without it in the actual image

Yeah makes sense for things like forge install


Remove unneeded javascript polyfills

Now that we're not supporting IE9 anymore there might be other polyfills that are not needed anymore.
Please check all javascript polyfills and compare with caniuse.com and supported browsers

All of the libraries are finally updated.


修复静态Tag不生效的问题

What is the purpose of the change
当前方式提供方通过配置文件的方式使用标签路由功能，标签不会写入元数据中心的revision中，导致消费方筛选路由列表时无法获取到提供方标签，最终标签路由功能失效。
<dubbo:service delay="5000" interface="org.apache.dubbo.demo.DemoService" timeout="3000" ref="demoService" registry="registry1" protocol="dubbo" tag="gray"/>
Brief changelog
将提供方通过配置文件的方式配置的标签路由的TAG_KEY纳入元数据中的revision中，能被消费方识别。
Verifying this change
按应用注册模式，将静态标签路由纳入revision计算，以支持提供方通过配置文件的静态方式打标签，且消费方能根据静态标签进行路由。
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Please merge the latest 3.0 branch to your branch to resolve conflicts

Closing for no responses in days.


chore: update drizzle-orm beta 0.30.9-d939ec2

Running CI test on new beta release. DO NOT MERGE!

This could also be left as draft if you want to prevent a merge.


Proxy the google places request in native

Details

Remove unused google places api key
Proxy the google places api requests in native too

Fixed Issues

$ https://github.com/Expensify/App/issues/13789
PROPOSAL: https://github.com/Expensify/App/issues/13789#issuecomment-1377715114
Tests

Create workspace
Go to the workspace settings and start adding a bank account:

Use Connect manually setup
Use routing number 123123123
Use account number 123123

Continue to the Company step
Enter something in "Company address" (i.e. "12 w")
Verify that you get some suggestions
Tap on a suggested result
Verify that other fields like the zip code, the address, the city and the state get populated

[x] Verify that no errors appear in the JS console

Offline tests
N/A: you won't get any suggestions
QA Steps

Create workspace
Go to the workspace settings and start adding a bank account:

Use Connect manually setup
Use routing number 123123123
Use account number 123123

Continue to the Company step
Enter something in "Company address" (i.e. "12 w")
Verify that you get some suggestions
Tap on a suggested result
Verify that other fields like the zip code, the address, the city and the state get populated

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@aldo-expensify I can't select the suggestion on Android, do experience it too?
https://user-images.githubusercontent.com/25520267/211651006-4671523b-c25d-4da0-a1fb-7f90fa2b1af0.mov

@aldo-expensify I can't select the suggestion on Android, do experience it too?
Screen.Recording.2023-01-11.at.03.01.47.mov

Good catch!, I didn't test clicking on the results

@aldo-expensify Adding keyboardShouldPersistTaps to the AddressSearch scroll view fix the issue. Reference: https://github.com/FaridSafi/react-native-google-places-autocomplete#use-inside-a-scrollview-or-flatlist

I noticed that in Android, when you tap on a result, the request to get the tapped address's details is not set 🤷

@aldo-expensify Adding keyboardShouldPersistTaps to the AddressSearch scroll view fix the issue. Reference: https://github.com/FaridSafi/react-native-google-places-autocomplete#use-inside-a-scrollview-or-flatlist
keyboardShouldPersistTaps={true} is deprecated, keyboardShouldPersistTaps="always" also fix the issue.

Cool, thanks for that! I'll try it.

Ok!, retested on Android/IOS native/web and web and it seems to be working fine for all of them. I'll update the test/QA instructions to include tapping on a result and making sure it works :P.
Thanks a lot @mollfpr

I can't add the test recording for mWeb Safari, because I can't go through the sign-in due to POST http://localhost:8080/api?command=BeginSignIn 429 (Too Many Requests). Is that okay?

I can't add the test recording for mWeb Safari, because I can't go through the sign-in due to POST http://localhost:8080/api?command=BeginSignIn 429 (Too Many Requests). Is that okay?

I would say it is fine. I tested it and it worked fine.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @grgia in version: 1.2.53-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @Julesssss in version: 1.2.53-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Expand on Request/response features

I posted previously about the lack of detailed docs with some of more advanced ASP.NET Core features and the list just goes on and on.
On the page referenced below, we have a list of request/response feature interface which supposedly we could use to manipulate (as it seems) all sorts of stuff in our ASP.NET Core apps.
Sadly, the article starts with three paragraphs of a talk that delivers very little value and is written in a very hard to understand way.
The article should start with the problem. What the issue is and how the features/tech outlined below solves it. Most of these pages fail at that premise.
Next, given the talk is about a more advanced topic, at least one of these feature interfaces should've been explained in detail, providing code how to use/manipulate it. Not a single of these interfaces has been provided with that. The links which the interface names link to go to API docs and there's the most minimal description of an API possible.
for example
https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.http.features.ihttpresetfeature?view=aspnetcore-3.1

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 41d7ad78-542f-236c-f5b4-0273558674b9
Version Independent ID: f64165fc-ccf3-62cd-9ae4-313dfe7d1911
Content: Request Features in ASP.NET Core
Content Source: aspnetcore/fundamentals/request-features.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @ardalis
Microsoft Alias: riande

If I break it down, for example

The Features property of HttpContext provides access to the collection of feature interfaces for the current request. Since the feature collection is mutable even within the context of a request, middleware can be used to modify the collection and add support for additional features.

Great, now how do we do that?

Some advanced features are only available by accessing the associated interface through the feature collection.

What does that even mean? An example of code would be nice.

Most feature interfaces provide optional, light-up functionality, and their associated HttpContext APIs provide defaults if the feature isn't present.

Again, an example would be nice. How does that optionality look like? What is a light-up functionality, an example maybe?
In general, what I'm saying is: all this seems nice and kinda looks like we could do a lot with but is lacking on documentation and code samples.

Thanks for the suggestion. This is an advanced feature not needed by most apps.
We don’t have the resources to invest in this area, so we are closing the issue. Should your request generate enough  👍 responses, we’ll reconsider. We'll also reconsider this issue in the next doc update.

Providing docs/sample on one or two of the features to showcase proper use is too much work? That's a bummer.
Should someone else stumble upon this issue, here is an article by Rick Strahl on this topic, does not cover everything but it covers enough. Especially since he isn't paid to do it.
https://weblog.west-wind.com/posts/2020/Mar/29/Content-Injection-with-Response-Rewriting-in-ASPNET-Core-3x
It's unfortunate the community has to rely on posts from MVPs for just about anything that's a bit more advanced these days.


PVSystem setup with different arrays - how to reproduce an actual system

Hey hey,
I am currently working with PVlib to do a solar energy estimation of an actual setup. This will be done by comparing the modelled power outputs with the measured power outputs of the system. For this, I have two different setups where I was wondering if you can help me with writing the correct system description for the setup. The setup can be seen in the attachment. It has two different inverters but the same modules, all having the same tilt but different orientation angles as can be seen in the code below. Inverter 1 has two strings: one with in total 9 modules in a row and another one with in total 6 modules in a row. Inverter 2 has two strings with 6 modules each.
After I imported all libraries and necessary imports (including inverters, modules, weather data) I started describing the system, see below. My difficulty is that I don’t know how to properly reproduce the actual setup within the code to model the power output.
times = pd.date_range('', '', closed='left', freq='H', tz=tz)

loc_1 = pvlib.location.Location(latitude , longitude, tz = [times.tz](http://times.tz/))
loc_2 = pvlib.location.Location(latitude, longitude, tz = [times.tz](http://times.tz/))

solar_position_1 = loc_1.get_solarposition(times)
solar_position_2 = loc_2.get_solarposition(times)

tilt = 90 #as they are all wall-mounted

#azimuth North facing
azimutht_ne1 = 48
azimuth_ne2 = 24
azimuth_n = 360
azimuth_nw1 = 336
azimuth_nw2 = 312

#mount
mount_ne1 = FixedMount(tilt, azimuth_ne1)
mount_ne2 = FixedMount(tilt, azimuth_ne2)
mount_n = FixedMount(tilt, azimuth_n)
mount_nw1 = FixedMount(tilt, azimuth_nw1)
mount_nw2 = FixedMount(tilt, azimuth_nw2)

#azimuth South facing
azimuth_sw1 = 241
azimuth_sw2 = 217
azimuth_s1 = 191
azimuth_s2 = 168
azimuth_se1 = 144
azimuth_se2 = 120

#mount
mount_sw1 = FixedMount(tilt, azimuth_sw1)
mount_sw2 = FixedMount(tilt, azimuth_sw2)
mount_s1 = FixedMount(tilt, azimuth_s1)
mount_s2 = FixedMount(tilt, azimuth_s2)
mount_se1 = FixedMount(tilt, azimuth_se1)
mount_se2 = FixedMount(tilt, azimuth_se2)

array_kwargs_1 = dict(module_parameters, temperature_model_parameters, modules_per_string = 3, strings = 1)
array_kwargs_2 = dict(module_parameters, temperature_model_parameters, modules_per_string = 2, strings = 1)

array_ne1 = Array(mount_ne1, name ='NE1', **array_kwargs_1)
array_ne2 = Array(mount_ne2, name ='NE2', **array_kwargs_1)
array_n = Array(mount_n, name ='N', **array_kwargs_1)
array_nw1 = Array(mount_nw1, name ='NW1', **array_kwargs_1)
array_nw2 = Array(mount_nw2, name ='NW2', **array_kwargs_1)

array_sw1 = Array(mount_sw1, name ='SW1', **array_kwargs_2)
array_sw2 = Array(mount_sw2, name ='SW2', **array_kwargs_2)
array_s1 = Array(mount_s1, name ='S1', **array_kwargs_2)
array_s2 = Array(mount_s2, name ='S2', **array_kwargs_2)
array_se1 = Array(mount_se1, name ='SE1', **array_kwargs_2)
array_se2 = Array(mount_se2, name ='SE2', **array_kwargs_2)

arrays_1_1 = [array_ne1, array_ne2]
arrays_1_2 = [array_n, array_nw1, array_nw2]
arrays_1 = [arrays_1_1, arrays_1_2]
arrays_2_1 = [array_sg64_sw1, array_sg64_sw2, array_sg64_s1]
arrays_2_2 = [array_sg64_s2, array_sg64_se1, array_sg64_se2]
arrays_2 = [arrays_2_1, arrays_2_2]

#PVsystem of arrays
system_1 = PVSystem(arrays = arrays_1, inverter_parameters = inverter_1, strings_per_inverter=2)
system_2 = PVSystem(arrays = arrays_2, inverter_parameters = inverter_2, strings_per_inverter=2)

As stated in the PVlib docs for pvlib.pvsystem.PVSystem():
The class supports basic system topologies consisting of:

N total modules arranged in series (modules_per_string=N, strings_per_inverter=1).
M total modules arranged in parallel (modules_per_string=1, strings_per_inverter=M).
NxM total modules arranged in M strings of N modules each (modules_per_string=N, strings_per_inverter=M).

For the setup with Inverter 1 we have once N=6 and once N=9 but M=2. How do I implement NxM in the code of the system description? For the setup with Inverter 2 it would be N=6 and M=2 and from this point of view easy to implement. But how do I feed into the system which 6 modules are connected in series? I tried to do two arrays who represent one string each but how do I feed this information exactly to PVlib? Is anyone familiar with this issue and can help me out?
Thank you very much, I would appreciate it.
setup_PVsystem.pdf

@kimcholi according to the attached pdf, the system has two inverters, and each inverter has two Array inputs. Within each Array there are groups of modules at different orientations. As of the current release, pvlib doesn't support an Array with several orientations; all modules in an Array are at the same orientation and tilt.
So in your code, after the Arrays are defined (array_ne1, etc.) you would have to do the following:

calculate DC output for each Array
combine DC output for Arrays connected in series to get DC voltage and DC power. pvlib doesn't have a function to add I-V curves in series; somewhere I have code that I could provide if desired. (@pvlib/pvlib-core this is why I'm leaving this as an issue, rather than asking to move it to a discussion)
input the combined DC to one of the multi-input inverter models, e.g., pvlib.inverters.sapm_multi

Thank you very much for the explanation @cwhanse. I will implement this in my model but will still keep this issue open in case another problem is coming up while I am doing so.

You are welcome @kimcholi
We use Issues to track items that require changes in pvlib itself (a request for a function to add series-connected I-V curves qualifies so I'm leaving this Issue open for now).
If you have usage questions, please open a Discussion, or ask on the pvlib google group or stackoverflow.

I actually would take up your offer for the code to add I-V curves  @cwhanse. This would then be the step to combine the  DC outputs for arrays connected in series, right? I have calculated each DC output for each array and would move on to the next step now for which I believe your code would be very helpful. Cheers :)

@cwhanse just one more clarification that I am not going down the wrong path. If I have a setup like like in the png-file, then I can go along with pvlib.pvsystem.PVSystem()  and use the arrays as a parameter (as long as an array has the same orientation), right? And then I can run it with  pvlib.modelchain.ModelChain.run_model()

@kimcholi As long as modules in an Array have the same orientation, and the Arrays are parallel inputs to the inverter, then yes I think you can use a ModelChain to execute this.

Thank you @cwhanse. Do you end up finding the code for the array setup with different orientations? I believe this could be a great help for me to model the setup.


Offer Object

The Offer Object is used to build the Offer UI and the Settings UI.
Parameters:

description: markdown text. Max 3 lines
image: 320x100
List (max 3 items)

This object was removed in the code review.


go mod tidy

Description
The master branch is broken, but it seems simple to fix. go mod tidy should do the trick.
Reference issue
https://github.com/pion/mediadevices/actions/runs/6471054300/job/17568631995#step:5:11

@bazile-clyde the branch protection setting already requires passing tests, and the PR of the broken master commit passed the all tests: https://github.com/pion/mediadevices/actions/runs/6388497827

We can add a workflow that makes a PR to apply go mod tidy automatically


Compilation under clang

This is the first part of changes needed for other platforms.
I do not have windows, so I haven't tried it back.
Next PR will be reworked CMakeLists to work on osx/linux.

Awesome!! Thank you much Julien!


Feature/credits update

The credits now use the new font and also made the lines a little taller, looks better overall.

Soo much better! Thank you.

Soo much better! Thank you.

Oh no, now I'm in the worse font :laughing:
I did make an outline version of the font... but ~1.5k for one name seems a little wasteful...

Oh no, now I'm in the worse font :laughing:
I did make an outline version of the font... but ~1.5k for one name seems a little wasteful...

1.5k on the launcher is hardly breaking the bank though :laughing: I'm sure we could find some other uses.

1.5k on the launcher is hardly breaking the bank though :laughing: I'm sure we could find some other uses.


feature - update a specific part of a snapshot

Hi Jest's guys, how are you?
I'd like to use Jest snapshots for my reducers (not only for my .jsx components).
The test would be something like:
describe.only('Dialog Reducer', () => {

    test(type.DIALOG_START, () => {
        expect(
            dialog('Test one', {
                type: type.DIALOG_START
            })).toEqual({
                active: true,
                text: 'Hi mom'
            });
    });

    test(type.DIALOG_END, () => {
        expect(
            dialog('Test two', {
                type: type.DIALOG_END
            })).toMatchSnapshot();
    });
});

There are two tests inside one script. The snapshot would be something like:
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Dialog Reducers DIALOG_START`] = `
Object {
  "active": false,
  "text": 'Hi Mom',
}
`;

exports[`Dialog Reducers DIALOG_END`] = `
Object {
  "active": false,
  "text": null,
}
`;

Suppose that both tests fail I would fix them one by one. After every fix I might need to update the snapshot just for one test.  But it looks like there isn't this chance because the command update the entire snapshot.
http://facebook.github.io/jest/docs/cli.html#updatesnapshot

Thanks, we're good, busy changing names and stuff 😉 cc: @cpojer @aaronabramov
There's a work in progress PR handling this, but it looks like it won't ship too early: https://github.com/facebook/jest/pull/3831
We also track the issue here: https://github.com/facebook/jest/issues/1798
Closing as a duplicate.


Fix the need to refresh page after signup to cast vote

The stateIndex was not updated because the comparison was between number and bigint.

Thanks for this.


drivers: hda: use interrupt for timing L1 exit on host DMA

To properly setup L1 exit timing this patch will use buffer interrupt
for HOST DMA and wait for Host HDA to actually start
First interrupt will clear all others.
Two main opens in the comments:

@abonislawski Can you check the compliance check fails? It seems you have a few codelines exceeding 100 char limit -> https://github.com/zephyrproject-rtos/zephyr/actions/runs/5586090177/job/15128093483?pr=60512

@abonislawski Compliance check still fails:
LONG_LINE: line length of 101 exceeds 100 columns
File:drivers/dma/dma_intel_adsp_hda.c
Line:452

 LONG_LINE: line length of 134 exceeds 100 columns
File:drivers/dma/dma_intel_adsp_hda_host_in.c
Line:[31](https://github.com/zephyrproject-rtos/zephyr/actions/runs/5877427821/job/15937542993?pr=60512#step:9:32)
 LONG_LINE: line length of 134 exceeds 100 columns
File:drivers/dma/dma_intel_adsp_hda_host_out.c

@abonislawski The twister test is failing to build error:
https://github.com/zephyrproject-rtos/zephyr/actions/runs/5983706902/job/16234163147?pr=60512
 INFO    - 1) tests/boards/intel_adsp/hda/boards.intel_adsp.hda on intel_adsp_cavs25 error (Build failure)
INFO    - 2) tests/boards/intel_adsp/hda/boards.intel_adsp.hda.1cpu on intel_adsp_cavs25 error (Build failure)
INFO    - 3) tests/boards/intel_adsp/hda_log/boards.intel_adsp.hda_log on intel_adsp_cavs25 error (Build failure)

Seems some dependency in IRQ setup is triggering on the cAVS25 build.

@lgirdwood can we try to prioritize this PR? It's been 2 Linux kernel cycles where we have to carry a revert to keep DMIC capture working...

A modified version of this PR that passes all CI checks is available at https://github.com/zephyrproject-rtos/zephyr/pull/62101

Merged as https://github.com/zephyrproject-rtos/zephyr/pull/62101


Is there a way to install locally rather than globally

Is there a way to install locally rather than globally?
I really treat bundle size of application. And it would be great if there a way to register locally in 1 specific page.

可以通过script标签引入dist目录下的 js和css即可，例如：

<link rel="stylesheet" href="css/thirdparty/vue-tour/vue-tour.css"/>


[WIP] RYA-177 adding optional geoindexing profile

Description

What Changed?
Moved geoindexing to a separate project and added a profile.

Tests

Coverage?

N/A
Links
Jira
Checklist

[ ] Code Review
[ x] Squash Commits

People To Reivew
@amihalik

This is meant to be a start to get us through a release -- there are at least three issues that should accompany this:

Bring back the geo examples
Have Map Reduce delegate to the DAO to write to indexers, not writing to them directly
Look at further refactoring to bring back the mongo geoindexing since it doesn't implicitly depend on geotools
I feel these are all relatively minor and could be solved later.

I'm still seeing gt libs pulled into the build eg:
[INFO] ------------------------------------------------------------------------
[INFO] Building Apache Rya Secondary Indexing 3.2.10-SNAPSHOT
[INFO] ------------------------------------------------------------------------

[...]

[INFO] Including org.geotools.xsd:gt-xsd-core:jar:14.3 in the shaded jar.
[INFO] Including org.geotools:gt-graph:jar:14.3 in the shaded jar.

What's the plan to resolve these before a release?

Sorry missed the jt dependency that was pulling those in.  Let me know if you see anything else being pulled in.

Better.  I'm still seeing gt dependencies.
try running mvn dependency:tree | grep gt in your environment.    Can you verify that you are running with the geoindexing profile not enabled and that you have my last commit?  I ran mvn dependency:tree, piped to file, and then searched for gt.  Didn't bring this up.

Yep, I will missing a commit.  Looks good.  Building and running the tests now.

Looks reasonable enough. I'll try to pull down the changes and take a look tmrw with fresh eyes.


Figure out issue with cancel.addEventListener("click", closeLogin)

We have stared at this for too long. city and state are defined in profile.html

Complete


Optimize unit tests and test data

Summary of scope
Go through the unit tests and unit test data:

simplify code where possible
replace the test screenshots with a simple image that has a minimal size to minimize this respository's size

Completed on release/v050 branch.


⚠ ECDC Shop has degraded performance

In 5a65e88, ECDC Shop (https://shop.memmingen-indians.de) experienced degraded performance:

HTTP code: 200
Response time: 24883 ms

Resolved: ECDC Shop performance has improved in a5b28eb after 11 minutes.


Initial developer documentation for bots and files support

We need to comment out or strongly note that the manifest changes are coming soon. Or we can just rip them out for now and add them once that comes.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/bots/bots-files.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Rule: rule-length

Made easy by now having the text attribute present in the AST. Thanks for that @charlieegan3!
Fixed existing violations against this rule, which were almost exlusively in tests. Sprinkled a few ignore directives in the places where it wasn't possible to make rules any shorter.
Fixes #236

Merging without review as the changes around text attributes in location is needed in current development tasks.


How to continue training from a checkpoint?

Checkpoint files for the models seem to be saved, but how do I continue training from a checkpoint? And how do I string different resolution models together to create bigger and better outputs?

This was answered here: https://github.com/255BITS/HyperGAN/issues/96


Can't compress stdin

$ echo tist|zopfli -c -|base64
Please provide filename
For help, type: zopfli -h
$ echo tist|zopfli -c /dev/stdin|base64
Files larger than 2GB are not supported.

This is a duplicate of issue #17.

Sure.