Workload configuration

This PR introduces a new CRD to allow fine grained configuration of a
HostedControlPlane's workload. It allows configuring settings that
affect scheduling such as affinity, tolerations and priority class as
well as resource requests, security context, etc.
To enable this configuration, a WorkloadConfiguration CR must be created
in the same namespace as a HostedControlPlane resource. Only one
WorkloadConfiguration resource may be present in a namespace. More than
one resource will result in reconciliation errors and will prevent that
particular control plane from being reconciled.

/test e2e-aws

To enable this configuration, a WorkloadConfiguration CR must be created
in the same namespace as a HostedControlPlane resource. Only one
WorkloadConfiguration resource may be present in a namespace. More than
one resource will result in reconciliation errors and will prevent that
particular control plane from being reconciled.

Are these assumptions meant to be documented?
Does this mean that the HCP namespace needs to be created ahead of time?
What's the reasoning behind that vs having an optional ref to this config in the HC CR?

We probably talked about this but since there is a 1:1 relationship with the HCP resource, but no explicity binding between the two, only implicit in the resource being present in the HCP namespace,  why do we not put all this in say a spec.deploymentConfiguration on the HCP spec?

I think this entire API is too generic and leaks implementation details out into the public API (deployment and container names, etc.) It also seems to introduce something like a fractal explosion of the test matrix that we'll never sufficiently cover.
Affinity rules can easily lead to breakages that I see no strategy for detecting or reporting. Letting the user override readiness and liveness probes seems like a recipe for users breaking components the operator is supposed to be rolling out in ways we've tested and controlled for.
What are the examples of underlying requirements driving this?

@ironcladlou You can take a look at the scheduling parts in ROKS manifests:
https://github.com/openshift/ibm-roks-toolkit/blob/master/assets/kube-apiserver/kube-apiserver-deployment.yaml#L17-L56

@ironcladlou You can take a look at the scheduling parts in ROKS manifests:
https://github.com/openshift/ibm-roks-toolkit/blob/master/assets/kube-apiserver/kube-apiserver-deployment.yaml#L17-L56

This shows what somebody is doing, but not why, and doesn't speak to whether we should repeat it here, or as proposed...

@ironcladlou the IBM team can better explain why they're using these settings, but it has to do with how they choose to schedule control plane workloads on their tugboat clusters. One of the reasons for making this configurable is that it is likely that every provider will want to customize the scheduling of their control plane workloads.

@ironcladlou the IBM team can better explain why they're using these settings, but it has to do with how they choose to schedule control plane workloads on their tugboat clusters. One of the reasons for making this configurable is that it is likely that every provider will want to customize the scheduling of their control plane workloads.

Even if we grant at least one user wants some manner of scheduling control of a component or set of components (setting aside whether it's really likely other providers need the same thing), is this API the way to achieve it?
For example, how does letting users override readiness probes for arbitrary containers in arbitrary deployments managed by HyperShift enable users to solve whatever scheduling challenge you're describing?
I just can't yet see a line from "IBM wants some scheduling control" to this API.

Let me provide reasoning

There's a few key reasons for what we do:

Multi zone deployments: that's probably the most simple (critical to our SLA and offering)
Tolerations: We taint our management cluster nodes to ensure only specific types of workload can run on specific types of machines. It helps to isolate customer master workload from other random components that might run in the management cluster that could cause disruptions. We only want master workload on nodes we use for masters
Restart Date: There is a want by users to be able to restart components without having to do a explicit patch update (helps sometimes for long running components, recovering from a memory leak or after overloading the apiserver, bad webhook, etc). Restart date gives a way for a customer to trigger rolling restarts of  all components
Pod affinity based on clusterid: We want to keep master components of a given cluster close to each other whenever possible. Significantly helps with webhook traffic and helps keep a given control plane confined to a node. We have seen situations with customers that run very busy and high scale masters (lots of api requests, etc) if their components are spread across a bunch of nodes there can be resource starvation across a large percentage of the management cluster fleet. We want to avoid that since that can cause evictions of other customer workload. Therefore: we aim to keep a given master's components in a given zone colocated on a node

These are all things that won't ultimately be IBM specific and be experienced by any team using hypershift at a large scale. This is some of the general operational tricks we have picked up during operating the offering.

Thanks for the detailed requirements, that's very useful.

There's a few key reasons for what we do:

Multi zone deployments: that's probably the most simple (critical to our SLA and offering)

Can you elaborate further on this? Which specific components within a single hostedcluster are you referring to, and how would you expect multi zone to be achieved?

Tolerations: We taint our management cluster nodes to ensure only specific types of workload can run on specific types of machines. It helps to isolate customer master workload from other random components that might run in the management cluster that could cause disruptions. We only want master workload on nodes we use for masters

This makes sense, but is the implication that every managed pod related to the hosted control plane should be taken together in this regard with tolerations applied to all the pods? Or is some finer level of control over individual components of the control plane required (e.g. a difference in tolerations between the apiserver and, say, the KCM or etcd?)

Restart Date: There is a want by users to be able to restart components without having to do a explicit patch update (helps sometimes for long running components, recovering from a memory leak or after overloading the apiserver, bad webhook, etc). Restart date gives a way for a customer to trigger rolling restarts of  all components

This sounds like bugs that need described and resolved (e.g. bugs in liveness or readiness checking). If there are specific reproducers here, that would be useful. I'm not sure this represents an API need as described.

Pod affinity based on clusterid: We want to keep master components of a given cluster close to each other whenever possible. Significantly helps with webhook traffic and helps keep a given control plane confined to a node. We have seen situations with customers that run very busy and high scale masters (lots of api requests, etc) if their components are spread across a bunch of nodes there can be resource starvation across a large percentage of the management cluster fleet. We want to avoid that since that can cause evictions of other customer workload. Therefore: we aim to keep a given master's components in a given zone colocated on a node

As with the tolerations requirement, does this apply uniformly to every pod for a hosted control plane? If not, then at what granularity or grouping of components would they apply? I also wonder if this represents a need for more reasonable defaulting on the hypershift side. Is there any default affinity rules for components which would obviate the need for API?
One more general response I have is that I consider every requirement above to be orthogonal. I do understand how the generic/catch-all configuration surface in this PR can provide a means to achieve them all one way or another, but I think to arrive at something supportable and coherent we should be discussing each piece separately and with more consideration for the support and overall API implications.
The API as described here isn't far from just turning off the operators and letting the user directly manipulate resources arbitrarily, which is a path I doubt we want to go down. I suggest we'll have better luck finding the right APIs if we separate the requirements discussions out a little.

We had an offline discussion about these topics and identified several actionable approaches and followup discussions, all of which taken together seem to eliminate the need for the API as proposed here. Let's pause this PR and break out the discussions into issues describing our intended direction for each piece.
/hold

/close


update wasmd to v0.53 NTRN-389

Main PR

Attach a successful test run, please

https://github.com/neutron-org/neutron-tests/actions/runs/10622857535

https://github.com/neutron-org/neutron-tests/actions/runs/10737552023/job/29779467130


Add support for spiced --version

spiced --version prints the cargo package version if the build is marked for release and prints "local" otherwise to signal to the CLI that upgrade is not necessary.

🦀

🦀


Please reply as soon as possible because the project is delivered on Sunday.

using this code to predicted labels .
%% load
load cnn
load test_x
%% test
net = cnnff(cnn,test_x);
[~, h] = max(net.o);
disp(h);
got this errors
Error in cnnff (line 12)
z = zeros(size(net.layers{l - 1}.a{1}) - [net.layers{l}.kernelsize - 1 net.layers{l}.kernelsize - 1 0]);
how fix this erorrs

refer to https://github.com/rasmusbergpalm/DeepLearnToolbox/issues/167


I.E. 9 Button Not Showing

I've noticed that in I.E. 9 the amazon payments button does not show on the checkout page. When viewing the issue in inspector i found an error.
Object doesn't support property or method 'addEventListener' for G.addEventListener("load",N,false);if

Hi teknology, do you know what file is causing this error?

In older versions of IE9 where the merchant is leveraging a 2.X version of jquery, the button may appear to 'do nothing' when clicked ot it may cause the button not to appear at all. In reality there are console errors in JavaScript thrown that will say something like "Object doesn't support property or method 'addEventListener'"
This is caused by jquery 2.X explicitly dropping support for IE8/9 and its use of the method addEventListener
To fix this problem, have the merchant add the following line to the head section of  any page containing the button

See here for more information
https://forum.jquery.com/topic/jquery-2-1-1-min-js-object-doesn-t-support-property-or-method-addeventlistener
teknology, can you give this a try?


feat: display list of services

List of services

a list showing all the available services
closes #33
demo

@amanuela97 can you please remove shadows

@amanuela97 there are conflicts, please resolve

@amanuela97 please click "resolve conversation" as soon as you fix it


Publish api docs and api doc coverage on PRs

ci: publish api docs and api coverage as well

example output:
https://github.com/zephyrproject-rtos/zephyr-testing/actions/runs/6345751206?pr=249

example output:
https://github.com/zephyrproject-rtos/zephyr-testing/actions/runs/6345751206?pr=249

Niiiice! FWIW I don't think publishing /api-docs is necessary as the doxygen doc is already pushed to /docs (/docs/doxygen/html, off the top of my head). Maybe just update the workflow output message to make it easier for folks to have a direct link.
The cost of all the S3 PUT requests for publishing the hundreds (thousands) of doc files for each PR is already quite significant and this would probably almost double it.
Also, as discussed on Discord I think that eventually the doc coverage reports should be made directly available from the Doxygen main menu.

The cost of all the S3 PUT requests for publishing the hundreds (thousands) of doc files for each PR is already quite significant and this would probably almost double the S3 bill altogether, as the bulk of it really is publishing doc artifacts to build.zephyrproject.org bucket.

I would not worry too much about S3 costs, those are minimal and actually it does not cost us to push data inside aws.

The cost of all the S3 PUT requests for publishing the hundreds (thousands) of doc files for each PR is already quite significant and this would probably almost double the S3 bill altogether, as the bulk of it really is publishing doc artifacts to build.zephyrproject.org bucket.

I would not worry too much about S3 costs, those are minimal and actually it does not cost us to push data inside aws.

Ya it's definitely not that expensive, but it's not free either :) We're making 2+ millions of PUT requests to the "build" bucket every day to push the numerous HTML files, and while it's "only" $0.005 per thousand requests, this is a couple hundred dollars monthly on the bottom line.


[BEAM-14347] Add function for simple function registration

This adds a basic function for non-structural DoFn registration. This doesn't actually need to be generic, and it doesn't have to be aware of its parameters (we could just accept an interface). I chose to do it this way because (1) it gives us greater type safety and (2) it matches the other registration functions

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @lostluck here's the simple function registration you suggested. Arguably we don't need it, but it was simple enough and gives us full consistency

R: @lostluck here's the simple function registration you suggested. Arguably we don't need it, but it was simple enough and gives us full consistency

We do need it for the same reason. Please add a benchmark for wrapping and invoking a simple function caller, and you'll see.
The stats combiners are simple binary functions eg for minIntFn
The current code generator generates registrations for them all and their factory wrappers specifically for the caller invoker.
The various struct wrappers happened 2nd originally, and piggy backed on the work to make functions faster (partly because that was faster than an alternative method receiver passing approach).

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

We do need it for the same reason. Please add a benchmark for wrapping and invoking a simple function caller, and you'll see.

Oh yeah, my point isn't that it isn't much better in terms of performance, just that its not a huge usability win vs the user manually calling these themselves. The performance bump is evident from the existing benchmarks on register.DoFnXxY which are doing the same thing, I'm pretty happy to add the extra benchmark though, and will have it shortly.
I should've been more clear in my original comment that I do still think this is a good idea, I just think it is less useful because its not too hard for users to do the right thing themselves already.

Oh fair!
But, as written, you aren't generating callers for the user, just the simple type and func registrations. The generic callers are where the execution time performance comes from, and they don't exist in your template.

But, as written, you aren't generating callers for the user, just the simple type and func registrations. The generic callers are where the execution time performance comes from, and they don't exist in your template.

Ah, you're right! Good callout, I'll fix it

Fixed with benchmarks! Thanks for calling this out, I'd gotten confused on what actually gets generated for these ones (which is also why I thought it was an easy one for users to do themselves)

Run GoPortable PreCommit


Jira pack doesn't allow creation of custom issue type

Jira pack alloes only the following issue types to be created:

Task
Story
Epic
Bug

I've created this issue to discuss the best way to make it to allow the creation of other types. I believe add other types to the action yaml is not good, because some places have custom types.
My idea is to totally remove the enum list from it, and make it a free string parameter.
Or, alternatively, create a parameter like custom_type and it will override the default value for the issue type.
What do you guys think?

My idea is to totally remove the enum list from it, and make it a free string parameter.
Seems like the only reasonable solution.

I would only update the description to say that task, story, bug and epic are typical types. Could also be custom_types.

hmm... let me see if i understood correcty:

remove the enum list
update the description

Is this right? If so I will do the changes and create a PR. Thanks, @manasdk!

@psychopenguin Yes you got it right.
:+1:


Updated docs, tests regrading verify_with_buffer and verify_shards_with_buffer

No breaking changes.

Codecov Report

Merging #4 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   98.82%   98.77%   -0.06%
==========================================
  Files           8        8
  Lines        2306     2362      +56
==========================================
+ Hits         2279     2333      +54
- Misses         27       29       +2

Impacted Files
Coverage Δ

src/lib.rs
96.69% <ø> (-0.39%)
:arrow_down:

src/lib_test.rs
100% <100%> (ø)
:arrow_up:

src/shard_utils.rs
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7547ca...8ca986e. Read the comment docs.


CSS Loader?

I often find the need for little loading spinners. There are a number of ways you can make these with css, but they are a bunch of code and not as customizable as I wish they were. Seems like it would be a great use-case for a mixin.
Some examples: http://projects.lukehaas.me/css-loaders/
Thoughts?

+1
I can add to my list.
On Sun, Sep 13, 2015 at 2:27 PM Jeff Escalante<EMAIL_ADDRESS>wrote:

I often find the need for little loading spinners. There are a number of
ways you can make these with css, but they are a bunch of code and not as
customizable as I wish they were. Seems like it would be a great use-case
for a mixin.
Some examples: http://projects.lukehaas.me/css-loaders/
Thoughts?
—
Reply to this email directly or view it on GitHub
https://github.com/jenius/axis/issues/215.

Maybe something like:
spinner($type = 'radial1', $color = $white, $size = "small", $bg = 'true')

Then we can add more types over time if needed. Thinking we might want to
have an optional 50% black background, so it works on top of any element
out of the box.
I've been wanting to redo the riots spinner anyway. 😛
On Sun, Sep 13, 2015 at 2:29 PM Daniel Box<EMAIL_ADDRESS>wrote:

+1
I can add to my list.
On Sun, Sep 13, 2015 at 2:27 PM Jeff Escalante<EMAIL_ADDRESS>wrote:

I often find the need for little loading spinners. There are a number of
ways you can make these with css, but they are a bunch of code and not as
customizable as I wish they were. Seems like it would be a great use-case
for a mixin.
Some examples: http://projects.lukehaas.me/css-loaders/
Thoughts?
—
Reply to this email directly or view it on GitHub
https://github.com/jenius/axis/issues/215.

Not entirely sure what you mean with the black background. Can't we just have a transparent background?
This sounds great though as far as initial options!

I just mean something like this: https://www.dropbox.com/s/ijs6u15qs3ha8h8/Screenshot 2015-09-14 11.46.48.png?dl=0
for when you don't know what the preloader will be overlaying

Ahh yeah gotchya. Yup, good idea.

This guy nailed it....
https://connoratherton.com/loaders
Has npm and bower installs..
Maybe we should just offer one simple one then have a link to these?

Sounds good to me. Not looking for a crazy array, just a simple one. Maybe slightly customizable like spin.js


allow saving to .md extension

It seems currently any extension gets overridden by .livemd, for websites like gitlab, they dont parse .livemd as markdown. It would be nice to make saving as .md possible so it gets parsed in the web gui as markdown.
NOTE
.gitattributes
*.livemd gitlab-language=markdown

does not seem to work on gitlab.

Yes, this is intentional. Note that similar formats, such as .rmarkdown, are on purpose not shown as markdown either (it was shown and they asked GitHub to remove it).

Why not allow overriding the extension? What is the reasoning behind this?

Because it is a subset of markdown and we don’t want to give the impression any markdown file works. There will be an export to markdown feature in the future though that will remove internal annotations and so on.


Enhancement: Add null-safety variable

Added null-safety to prevent the packages from throwing errors log if there is not enough sufficient data from the QR code.
Issue: QR code (UrlBookmark Type) is required to return title and url. Null exception thrown upon testing at generated QR code that returns empty title.
Solution: Add nullable String if the QR code returns empty title. Also, added nullable variable to other variables.

Thank you for your contribution! Can you please run flutter format . and push the changes?

@juliansteenbakker Welcome! Done.
Looking forward to contribute more for this package 🚀🚀🌝


Is there a way to get the cursor position?

Hi,
I want to track where the user's cursor currently is.
Is there a way I can do this?

Grab the ref and check it on the provided DOM node.


hyperlink in caption?

Hi, how to add hyperlink to the caption with this plugin? It's doesn't seem to interpret html tags in the caption.

HTML is not supported in title or alt takes, so i'm afraid not.

Hi @rhukster, I re-open the issue, because indeed on alt and on title you can't add HTML, but the figcaption's permitted content is flow content so, adding an hyperlink in the caption's field of the image's metadata, should render correctly.
It will be great if we can work this out with a template (as mentioned in https://github.com/trilbymedia/grav-plugin-image-captions/issues/6).
Please, let me know if a pull request with the template will be appreciated. Although I'm not very versed in php, I think I could do something in here.

A PR is always appreciated! Cheers.


Unraid ssh login

Hi,
i have to copy and sync a lot of files in unraid. When i try to login over terminal with ssh the standard username/password      rclone/rclone is wrong.
How to get in? With the GUI it's working.
The main reason why i need to ssh in, is that I can't copy folders over the GUI.
Thanks for helping me.
Br

Hello. You might want to check the rclone forums. I don't use/have Unraid anymore and I'm not maintaining this app. Sorry!


Hint for precision - zero digits

#464 @christianp Please review and let me know :)

Looks great, thanks! I'll add you to the CONTRIBUTORS file - edit that if you want.


Consider adding histogram support

This is a great tool to be sure, and I think it would be much better if it supported histograms. Often, when you are just trying to get a sense for some data, histogram is the most useful initial visualization.

I agree. I'd be reluctant to reinvent the wheel, but it seems the wheel hasn't been invented yet: https://github.com/chartjs/Chart.js/issues/3900
There doesn't seem to be Histogram support planned in the short term. I haven't ever coded a histogram chart before, so this sounds like an interesting challenge. Let me think about it.
PRs are also welcome, of course.

Some slow progress seems to be happening on the chartjs side:
https://github.com/chartjs/Chart.js/issues/3900
I'm sorry but I've been too busy to work on this so far; and I don't think I'll be able to any time soon.

It makes sense to wait for the library to implement support for it. If I have spare time, I may just try to implement something with bars, but not really sure if extending from Chart.js into this app is most sensible thing to do.

I'm also looking for histogram support for scientific plotting purposes. I'm wonder if someone could post a jsfiddle using some rough workaround approach (bar charts or something) until this feature is supported.

Here is a jsfiddle that I cobbled together over lunch using a bar chart to make a histogram.


Not equal seems to always fail

SWI-Prolog (threaded, 64 bits, version 9.1.10) % *** clpBNR v0.11.1 ***.
Dear Rick, a friend told gave me this small problem to implement : can prolog check if a given function is a "norm" or not. To be a norm, the function has to respect a couple of properties. The only one I started to implement is norm(a*X) = a * norm(X).
I know that Prolog is not the best language for theorem / math proving. Still, I though this could help him to find quickly counter-examples.
Saddly, I could not succeed. It looks like the not equal always fail.
Here is the code :

norm1(X, Y, N):-
    X::real,
    Y::real,
    N::real,
    { N == abs(X - Y)}.

normNok(X, Y, N):-
    X::real,
    Y::real,
    N::real,
    {N == exp(X-Y)}.

my_norm_under_test(X, Y, N):- norm1(X, Y, N).
%my_norm_under_test(X, Y, N):- normNok(X, Y, N).

is_a_norm_test1(A, X, Y, N1, N2) :-
    [A, X, Y, N1, N2]::real,
    {AX == A * X, AY == A*Y},
    my_norm_under_test(AX, AY, N1),
    my_norm_under_test(X, Y, N2),
    {AN2 == A*N2},
    format("N1 = "), write(N1), format("~nN2 = "), write(N2), format("~nA*N2 = "), write(AN2), format("~n"),
    {N1 == AN2}.

is_not_a_norm_test1(A, X, Y, N1, N2) :-
    [A, X, Y, N1, N2]::real,
    {AX == A * X, AY == A*Y},
    my_norm_under_test(AX, AY, N1),
    my_norm_under_test(X, Y, N2),
    {AN2 == A*N2},
    format("N1 = "), write(N1), format("~nN2 = "), write(N2), format("~nA*N2 = "), write(AN2), format("~n"),
    {N1 <> AN2}.

norm1 is a function that respect the property. Whereas normNok does not.
I can switch the norm to be tested by commenting / uncommenting the lines with my_norm_under_test.
When I test norm1, I have these outputs for these queries :

2 ?- is_a_norm_test1(0.5, 2.0, 3.0, N1, N2).
N1 = _12784{real(0.4999999999999989,0.5000000000000009)}
N2 = _12866{real(0.9999999999999991,1.0000000000000007)}
A*N2 = _18840{real(0.4999999999999995,0.5000000000000006)}
N1:: 0.50000000000000...,
N2:: 1.00000000000000... .

3 ?- is_not_a_norm_test1(0.5, 2.0, 3.0, N1, N2).
N1 = _24146{real(0.4999999999999989,0.5000000000000009)}
N2 = _24228{real(0.9999999999999991,1.0000000000000007)}
A*N2 = _29954{real(0.4999999999999995,0.5000000000000006)}
false.

It looks OK for me.
Now I switch to normNok and here are the results I got from the queries :

5 ?- is_a_norm_test1(0.5, 2.0, 3.0, N1, N2).
N1 = _792{real(0.6065306597126328,0.6065306597126342)}
N2 = _874{real(0.367879441171442,0.3678794411714427)}
A*N2 = _6516{real(0.18393972058572097,0.18393972058572142)}
false.

6 ?- is_not_a_norm_test1(0.5, 2.0, 3.0, N1, N2).
N1 = _2876{real(0.6065306597126328,0.6065306597126342)}
N2 = _2958{real(0.367879441171442,0.3678794411714427)}
A*N2 = _8600{real(0.18393972058572097,0.18393972058572142)}
false.

Query number 5 fails. Which is fine because N1 <> A*N2, so I cannot meet the constrain N1 == A*N2.
So if query 5 fails, why query 6 also fails ?? Even in the console output, the intervals of N1 and A*N2 are really far away, so I cannot see why not equal fails.
I tried other NOK norms (e.g. log and cos). Similar behaviour. I tried to restrains reals to be within -1e3, 1e3 : same behaviour.
Can you help ?
This is not an urgent matter at all.
Thanks in advance

Even trying without the implementation of my norms, I got similar weird results :
8 ?- {N1 == 0.6065, A == 0.5, N2== 0.3678, AN2 == A * N2}.

In these cases X<Y means the upper bound of X is less than the lower bound of Y by 1 floating point value which can be useful for some branch-and-bound search algorithms

Sorry, I meant "at least 1 floating point value".


Add LICENSE

Hi fedeAlterio,
Under what license would this package be available?
Regards,
pisch

Hi pisch.
Sorry for the delay. I see now that i do not have a license set up.
In these days I am trying to finish to developComputedAsync and EffectAsync functionalities. When everything is ready I will also add a license file
It will be MIT

Added to the main branch


All commands in General Commissioning are mandatory now.

Fixes https://github.com/project-chip/connectedhomeip/issues/18550
Problem
See issue.
Change overview
Mark the commands as not optional, regenerate.
Testing
Should be no behavior changes.  The fact that the codegen changes indicates that we have bugs in our AcceptedCommandList codegen (which are tracked already).

indicates that we have bugs in our AcceptedCommandList codegen

Fixed in https://github.com/project-chip/zap/pull/515


Pressing ESC closes MudDialog (requires also additions to mudKeyInterceptor)

Description

This PR improves MudDialog: Pressing ESC closes MudDialog, if close by backdrop click is possible. (closes #3379)
I noticed a difficulty or a bad ux: If there is a component with popover within a dialog and its popover is also closeable by ESC (like MudSelect, Picker), pressing escape does not close the popover, instead the dialog closes.
To prevent this I had to extend the mudkeyinterceptor with a possibility to update a keyoption:
Example-situation:

Focused a MudSelect nested in MudDialog, the popover opens (and sets StopDown to  StopDown = "Key+none" to stop propagation, otherwise the dialog would close)
Pressing ESC should now close only the Popover (and sets StopDown to  StopDown = "none")
Pressing ESC a second time should now close the popover

There are other components which react on ESC press and have to be investigated:

[x] MudSelect
[ ] MudAutocomplete
[ ] MudCheckBox
[ ] MudPicker
[ ] MudSwitch

How Has This Been Tested?
See test in 3aee5fd96d2cc042c322733653449feedfd190c2
Checks whether dialog is closed by ESC and whether dialog is not closed, if backdropclick is disabled

Checklist:

✔ The PR is submitted to the correct branch (dev).
✔ My code follows the code style of this project.
✔ I've added relevant tests.

Tests are fine locally...

I think we may use new CloseOnEscape parameter instead of backdropclick.

Very nice PR. Can be merged after adding the comments.

Thanks!

I added an issue for the other components you mentioned: #3400


[SPARK-35314][PYTHON] Support arithmetic operations against bool IndexOpsMixin

What changes were proposed in this pull request?

Support arithmetic operations against bool IndexOpsMixin.
Why are the changes needed?

Existing binary operations of bool IndexOpsMixin in Koalas do not match pandas’ behaviors.
pandas take True as 1, False as 0 when dealing with numeric values, numeric collections, and numeric Series/Index; whereas Koalas raises an AnalysisException no matter what the binary operation is.
We aim to match pandas' behaviors.
Does this PR introduce any user-facing change?

Yes.
Before the change:
>>> import pyspark.pandas as ps
>>> psser = ps.Series([True, True, False])
>>> psser + 1
Traceback (most recent call last):
...
TypeError: Addition can not be applied to booleans.
>>> 1 + psser
Traceback (most recent call last):
...
TypeError: Addition can not be applied to booleans.
>>> from pyspark.pandas.config import set_option
>>> set_option("compute.ops_on_diff_frames", True)
>>> psser + ps.Series([1, 2, 3])
Traceback (most recent call last):
...
TypeError: Addition can not be applied to booleans.
>>> ps.Series([1, 2, 3]) + psser
Traceback (most recent call last):
...
TypeError: addition can not be applied to given types.

After the change:
>>> import pyspark.pandas as ps
>>> psser = ps.Series([True, True, False])
>>> psser + 1
0    2
1    2
2    1
dtype: int64
>>> 1 + psser
0    2
1    2
2    1
dtype: int64
>>> from pyspark.pandas.config import set_option
>>> set_option("compute.ops_on_diff_frames", True)
>>> psser + ps.Series([1, 2, 3])
0    2
1    3
2    3
dtype: int64
>>> ps.Series([1, 2, 3]) + psser
0    2
1    3
2    3
dtype: int64

How was this patch tested?

Unit tests.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43285/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138763/

Test build #138766 has started for PR 32611 at commit 3f0fc27.

Test build #138766 has finished for PR 32611 at commit 3f0fc27.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138766/

Test build #138768 has started for PR 32611 at commit 6c5a5cf.

Test build #138768 has finished for PR 32611 at commit 6c5a5cf.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138768/

Test build #138769 has started for PR 32611 at commit b0b2a3b.

Test build #138769 has finished for PR 32611 at commit b0b2a3b.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138769/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43291/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43289/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43291/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43291/

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43292/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43292/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43289/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43289/

@xinrong-databricks can we show some examples in the PR description?

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43288/

Test build #138785 has started for PR 32611 at commit 3fef44b.

Test build #138785 has finished for PR 32611 at commit 3fef44b.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138785/

@HyukjinKwon Certainly, examples are added.

Test build #138788 has started for PR 32611 at commit e626c52.

Test build #138788 has finished for PR 32611 at commit e626c52.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138788/

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43308/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43308/

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43311/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43311/

CC @ueshin @HyukjinKwon @itholic

Test build #138809 has finished for PR 32611 at commit a123db8.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138809/

Test build #138811 has started for PR 32611 at commit bd63058.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43332/

Test build #138811 has finished for PR 32611 at commit bd63058.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43332/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43333/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43332/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138811/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43333/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43333/

Test build #138818 has started for PR 32611 at commit 925e34b.

Test build #138818 has finished for PR 32611 at commit 925e34b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43340/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138818/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43340/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43340/

Test build #138880 has started for PR 32611 at commit b4e2bc7.

Test build #138880 has finished for PR 32611 at commit b4e2bc7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138880/

Test build #138882 has started for PR 32611 at commit 43a2972.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43402/

Test build #138882 has finished for PR 32611 at commit 43a2972.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43402/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43404/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43402/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138882/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43404/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43404/

Test build #138885 has started for PR 32611 at commit 5e2f911.

Test build #138885 has finished for PR 32611 at commit 5e2f911.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138885/

Test build #138888 has started for PR 32611 at commit 99e66a1.

Test build #138888 has finished for PR 32611 at commit 99e66a1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43407/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138888/

Test build #138889 has started for PR 32611 at commit 7dac0d1.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43410/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43407/

Test build #138889 has finished for PR 32611 at commit 7dac0d1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43411/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43407/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138889/

Test build #138891 has started for PR 32611 at commit 7ea2876.

Test build #138892 has started for PR 32611 at commit a608e5a.

Test build #138891 has finished for PR 32611 at commit 7ea2876.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43411/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43410/

Test build #138892 has finished for PR 32611 at commit a608e5a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43413/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43414/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138891/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138892/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43413/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43411/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43410/

Test build #138895 has started for PR 32611 at commit 203f90a.

Test build #138895 has finished for PR 32611 at commit 203f90a.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138895/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43414/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43417/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43414/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43417/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43417/

Test build #138936 has started for PR 32611 at commit 9a8f0b9.

Test build #138936 has finished for PR 32611 at commit 9a8f0b9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43457/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138936/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43457/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43457/

Test build #138990 has started for PR 32611 at commit 98a5c8f.

Test build #138990 has finished for PR 32611 at commit 98a5c8f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43509/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138990/

Test build #138991 has started for PR 32611 at commit 5905012.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43509/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43509/

Test build #138991 has finished for PR 32611 at commit 5905012.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43510/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138991/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43510/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43510/

Test build #139033 has started for PR 32611 at commit adfc5cc.

Test build #139033 has finished for PR 32611 at commit adfc5cc.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139033/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43551/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43551/

Test build #139066 has started for PR 32611 at commit 7b6d6a6.

Test build #139066 has finished for PR 32611 at commit 7b6d6a6.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139066/

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43587/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43587/

Test build #139073 has started for PR 32611 at commit db12fb1.

Test build #139073 has finished for PR 32611 at commit db12fb1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43594/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139073/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43594/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43594/

Thanks! merging to master.


[Feature request] A shapes annotator, allowing for drawing shapes on a render plane

Shapes tools only work in 2D.
It would be amazing if they could work on a render plane, treating the render plane as a slice in 2D.

totally agree - you feel like you know enough to make it happen?! 🥳
might have time to hack on it over the weekend if you want to jump on zoom

It's tricky right, because we need to use the Shapes tools, so Shapes layer selected, but unblock them, so fool Shapes into accepting the plane as 2D mode?


🐞 client.Host().EnvVariable().Secret() is cached even when the var changes

What is the issue?
When I use an env variable as a secret, I would like to re-execute the pipeline if I update the env var.
Log output
First execution
DBGTHE: {"query":"query{host{envVariable(name:\"MY_SECRET_ID\"){secret{id}}}}","operationName":""}
DBGTHE: {"query":"query{container{from(address:\"alpine:latest\"){withSecretVariable(name:\"MY_SECRET_ID\", secret:\"eyJob3N0X2VudiI6Ik1ZX1NFQ1JFVF9JRCJ9\"){withExec(args:[\"sh\",\"-c\",\"echo super secret: $MY_SECRET_ID; date;\"]){stdout}}}}}","operationName":""}
#1 resolve image config for docker.io/library/alpine:latest
#1 DONE 0.8s

#2
#2 DONE 0.0s

#3 from alpine:latest
#3 resolve docker.io/library/alpine:latest
2023/02/15 17:59:38 LOGSTDOUT: super secret: my secret value
Wed Feb 15 16:56:13 UTC 2023

second execution after changing var
DBGTHE: {"query":"query{host{envVariable(name:\"MY_SECRET_ID\"){secret{id}}}}","operationName":""}
DBGTHE: {"query":"query{container{from(address:\"alpine:latest\"){withSecretVariable(name:\"MY_SECRET_ID\", secret:\"eyJob3N0X2VudiI6Ik1ZX1NFQ1JFVF9JRCJ9\"){withExec(args:[\"sh\",\"-c\",\"echo super secret: $MY_SECRET_ID; date;\"]){stdout}}}}}","operationName":""}
#1 resolve image config for docker.io/library/alpine:latest
#1 DONE 0.4s

#2 importing cache manifest from dagger:10686922502337221602
#2 DONE 0.0s

#3
#3 DONE 0.0s

#4 from alpine:latest
#4 resolve docker.io/library/alpine:latest
2023/02/15 18:00:30 LOGSTDOUT: super secret: my secret value
Wed Feb 15 16:56:13 UTC 2023

In the query, we can see the withSecretVariable.secret has the same value, so some caching is not basing itself on the value, but more on the name.
Steps to reproduce
package main

import (
	"context"
	"log"
	"os"

	"dagger.io/dagger"
)

func main() {
	// Change this value and reexecute.
	err := os.Setenv("MY_SECRET_ID", "my secret value ")
	if err != nil {
		panic(err)
	}

	ctx := context.Background()
	c, err := dagger.Connect(ctx, dagger.WithLogOutput(os.Stdout))

	secret := c.Host().EnvVariable("MY_SECRET_ID").Secret()

	stdout, err := c.Container().
		From("alpine:latest").
		//WithEnvVariable("CACHEBUSTER", time.Now().String()).
		WithSecretVariable("MY_SECRET_ID", secret).
		WithExec([]string{"sh", "-c", "echo super secret: $MY_SECRET_ID; date;"}).
		Stdout(ctx)

	log.Println("LOGSTDOUT:", stdout)
}

SDK version
Go SDK v0.4.5
OS version
Ubuntu 20.04

I think this is relevant https://github.com/moby/buildkit/issues/2547. Invalidate the cache when the value changes would be an information leak

This should be solved with the new implementation.
We can re-assess once it's in.

With the implementation in https://github.com/dagger/dagger/pull/4971, it shouldn't invalidate the cache and therefore respect https://github.com/moby/buildkit/issues/2547 which is better for security.


Logged data corrupted and not saved when closing the device

We realized that some data are corrupted and the joints values are not there after closing the logger
When closing the device we got the following errors
[ERROR][matioCpp::Variable::createVar] The name should not be empty.
[ERROR][matioCpp::Struct::Struct] The element at index 6 (0-based) is not valid.

cc @S-Dafarra

I tried to replicate the issue on my machine. The data are correctly logged

cc @carloscp3009

The first message is thrown from here: https://github.com/ami-iit/matio-cpp/blob/1d4008094d7362ae5d0b1c84443f3769d5011e91/src/Variable.cpp#L18-L23
The second message is thrown from https://github.com/ami-iit/matio-cpp/blob/1d4008094d7362ae5d0b1c84443f3769d5011e91/src/Struct.cpp#L53-L57 but I would say at this point it is already late because here the variables have already been created.
Another thing I can exclude is that this error is not thrown from the automatic conversion from a C++ struct. This is because the struct is filled by adding fields one by one (see here) and we would have seen this error instead.
At this point I guess that the problem might occur when creating the output structure in robometry.
Are you able to open the corrupted file in Matlab?

I just realized that there is a flaw in this piece of code https://github.com/ami-iit/matio-cpp/blob/1d4008094d7362ae5d0b1c84443f3769d5011e91/src/Struct.cpp#L53-L58
When creating the matio struct, I need to pass a nullptr terminated vector. The problem is that if, for some reason, one of the variables I wanted to add to the struct is not valid, I am pushing a nullptr to the vector, preventing matio to add anything that comes next.
In fact, in the "corrupted" file, there is data, but not all the data

At the moment, it is not clear yet what is the faulty signal, but we can patch the pipeline in two places:

in matioCpp printing a more description message and avoiding to push nullptr pointers when creating the struct.
in robometry making sure that no signal can have empty name.

in matioCpp printing a more description message and avoiding to push nullptr pointers when creating the struct.

Relevant PR https://github.com/ami-iit/matio-cpp/pull/80

At the moment, it is not clear yet what is the faulty signal, but we can patch the pipeline in two places:

in matioCpp printing a more description message and avoiding to push nullptr pointers when creating the struct.
in robometry making sure that no signal can have empty name.

Hi @S-Dafarra! Really thank you for deepering in the problem! I was wondering if the problem is in the camera signal  in the mat file

in robometry making sure that no signal can have empty name.

Done in https://github.com/robotology/robometry/pull/189
@carloscp3009 @GiulioRomualdi if you could test them, I will proceed with the merge process

At the moment, it is not clear yet what is the faulty signal, but we can patch the pipeline in two places:

in matioCpp printing a more description message and avoiding to push nullptr pointers when creating the struct.
in robometry making sure that no signal can have empty name.

Hi @S-Dafarra! Really thank you for deepering in the problem! I was wondering if the problem is in the camera signal in the mat file

I noticed that camera.jabra.rgb is empty, while camera.realsense.rgb.data seems to contain only 1.7153e+09

I wonder whether in a "good" dataset the entries on the main level are the same of https://github.com/ami-iit/bipedal-locomotion-framework/issues/846#issuecomment-2103022355

At the moment, it is not clear yet what is the faulty signal, but we can patch the pipeline in two places:

in matioCpp printing a more description message and avoiding to push nullptr pointers when creating the struct.

in robometry making sure that no signal can have empty name.

Hi @S-Dafarra! Really thank you for deepering in the problem! I was wondering if the problem is in the camera signal in the mat file

I noticed that camera.jabra.rgb is empty, while camera.realsense.rgb.data seems to contain only 1.7153e+09 repeated 20371 times

The Jabra Camera was disable for the last recording if I remember well. On the other hand, the realsense data present in the mat file is just the timestamp of each consecutive frame, so I would say it's accurate.

I wonder whether in a "good" dataset the entries on the main level are the same of #846 (comment)

This is how it should look like

The main suspect is that the "orientations" field appeared with a null name.

Looking at the YarpRobotLoggerDevice I noticed that  robometry::BufferManager m_bufferManager; is placed at line 178 while the names of the variables start from line 206.
The buffer manager saves the matfile while its destructor is called however as explained in https://stackoverflow.com/questions/2254263/order-of-member-constructor-and-destructor-calls the members are guaranteed to be initialized by order of declaration and destroyed in reverse order. This may create issues while saving the file
A possibility is to store the buffermanager in a unique_ptr and manually handle the destruction

After several attempts, we understood the problem was related to the connection of an exogenous signal vector. We had two main problem:

initMetadata uses the signalFullName for setting the channel name. However signalFullName is not set for classical vector signal.
https://github.com/ami-iit/bipedal-locomotion-framework/blob/e341b70f188562b5efdc717a2bdcfde8eb92aa77/devices/YarpRobotLoggerDevice/src/YarpRobotLoggerDevice.cpp#L839
YarpRobotLoggerDevice::initMetadata uses the  metadataNames to compute the size of the channel of the vector.
https://github.com/ami-iit/bipedal-locomotion-framework/blob/e341b70f188562b5efdc717a2bdcfde8eb92aa77/devices/YarpRobotLoggerDevice/src/YarpRobotLoggerDevice.cpp#L641
However, in some places, the provided metadata is empty so the  the channel size is set to zero.
https://github.com/ami-iit/bipedal-locomotion-framework/blob/e341b70f188562b5efdc717a2bdcfde8eb92aa77/devices/YarpRobotLoggerDevice/src/YarpRobotLoggerDevice.cpp#L839

I will open the PR with the modification discussed in https://github.com/ami-iit/bipedal-locomotion-framework/issues/846#issuecomment-2104786532
Still, I think we need to add a test perhaps using the new gazebo @xela-95 to intercept this earlier.

Cc @nicktrem

I renamed the issue to make it clearer. Currently, the logger is broken when a vector signal is logged as exogenous. No problems for vectors collection


feat: New landing page design

Details

New landing page design
Fixed Issues

Closes #2938
Tests

QA Steps

Match the UI with the Figma Designs
Previously we are only showing Terms in the mobile. In the new design we are showing Terms as well as license.

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web

Uploading Peek 2021-05-24 00-37.mp4…
Mobile Web

https://user-images.githubusercontent.com/32242596/119274573-30e89b00-bc2e-11eb-8f0f-d2b5ce5485b3.mp4
Desktop

https://user-images.githubusercontent.com/32242596/119274184-4c52a680-bc2c-11eb-9502-2b607e490fd4.mov
iOS

https://user-images.githubusercontent.com/32242596/119274178-44930200-bc2c-11eb-9da8-1f284690f3a3.mov
Android

https://user-images.githubusercontent.com/32242596/119274594-452c9800-bc2e-11eb-9d4d-ca05c62c646c.mp4

Looks like the mobile view should have more padding around the inner logo/UI/etc.

Looks like the mobile view should have more padding around the inner logo/UI/etc.

Sorry for the delay - hoping to review this tomorrow.

Hi, @shawnborton any update on this?

Sorry for the delay! Looking into this now, going to start adding design comments.
On desktop, the fine print does not have the same outer padding as the form above it:

Do we need the padding on the bottom of Forgot?? Doing so makes a slight jump in the position of the input when you go from email to password:

When the screen is in that weird middle size between mobile and desktop:

Let's actually make sure the content has a max-width and is just centered, like so:

Expensify at the bottom of the sidebar should actually use a .svg and not be written in text:

You can use this file here and it should be shown at 78px wide: expensify-wordmark.svg.zip

The sidebar itself should not be a fluid width on wide screens. I see you currently have it at 25%:

It should actually always be fixed at 375, the same as the sidebar width when you are signed into the app. Once we hit the responsive breakpoint where we hide the blue area on the right, then the sidebar should just be 100% wide.

Just chiming in as well to say I agree with Joe's feedback about this:

Landscape iOS has a bunch of space at the top.

Also just a heads up that I will be OOO next week, so tagging @michelle-thompson to help out with final design review while I am out.

Do we need the padding on the bottom of Forgot?? Doing so makes a slight jump in the position of the input when you go from email to password:

There is no padding 🤔

Landscape Compatibility and max width
https://user-images.githubusercontent.com/32242596/120931395-efb4b880-c70e-11eb-9b84-dfc1d450f2c4.mp4

Hey @Jag96 I think this is blocked on your review? We have a tight deadline for this one, can you take a look when you have a chance?

There is no padding 🤔

As long as the input field doesn't move around when switching screens, that is what's important here.
And I think the landscape view on mobile looks good 👍

Hi @Jag96 the TextLink is not working properly when used inline. Can we get the previous API back the open URL thing

the TextLink is not working properly when used inline
Is it just the styling that is not working? Or is there other functionality?

Can we get the previous API back the open URL thing
I'm not sure what previous API you're referring to, could you reference a previous commit to make it easier to understand what previous functionality you're referring to? Also, if this issue affects all inline TextLinks, our slack channel would be a good place to bring that up

the TextLink is not working properly when used inline

Is it just the styling that is not working? Or is there other functionality?

Can we get the previous API back the open URL thing

I'm not sure what previous API you're referring to, could you reference a previous commit to make it easier to understand what previous functionality you're referring to? Also, if this issue affects all inline TextLinks, our slack channel would be a good place to bring that up

I am talking about this -> https://github.com/Expensify/Expensify.cash/tree/c97a0d1af7c706ae916dbcb8a05f30b529978360/src/libs/openURLInNewTab

@Jag96 I have updated the PR

New text link api is not inline friendly.
Just open the https://expensify.cash/ and make the screen smaller, you can see that the full stop after privacy policy goes to the new line as it is part of the next sentence. I think someone missed this while reviewing.

@pranshuchittora #3502 solves this issue, but it is not shipped to production yet. You can confirm it's working by loading the staging server via https://staging.expensify.cash

@pranshuchittora #3502 solves this issue, but it is not shipped to production yet. You can confirm it's working by loading the staging server via https://staging.expensify.cash

I try migrating again but experiencing some weird behaviour.
https://user-images.githubusercontent.com/32242596/121744178-25e3a500-cb20-11eb-906c-14c8e26e07f6.mp4
import React from 'react';
import {Text, View} from 'react-native';
import styles from '../../../styles/styles';
import CONST from '../../../CONST';
import TextLink from '../../../components/TextLink';
import withLocalize, {withLocalizePropTypes} from '../../../components/withLocalize';
import LogoWordmark from '../../../../assets/images/expensify-wordmark.svg';

const TermsWithLicenses = ({translate}) => (
    <View>
        <View style={[styles.mt1, styles.alignItemsCenter]}>
            <LogoWordmark height={30} width={80} />
        </View>
        <View style={[styles.mt2, styles.flexRow, styles.flexWrap, styles.textAlignCenter]}>
            <Text style={[styles.loginTermsText]}>
                {translate('termsOfUse.phrase1')}
                {' '}
            </Text>
            <TextLink style={[styles.loginTermsText]} href={CONST.TERMS_URL}>
                {translate('termsOfUse.phrase2')}
            </TextLink>
            <Text style={[styles.loginTermsText]}>
                {' '}
                {translate('termsOfUse.phrase3')}
                {' '}
            </Text>
            <TextLink style={[styles.loginTermsText]} href={CONST.PRIVACY_URL}>
                {translate('termsOfUse.phrase4')}
            </TextLink>
            <Text style={[styles.loginTermsText]}>.</Text>
            <Text>
                <Text style={[styles.loginTermsText]}>
                    {translate('termsOfUse.phrase5')}
                    {' '}
                </Text>
                <TextLink style={[styles.loginTermsText]} href={CONST.LICENSES_URL}>
                    {translate('termsOfUse.phrase6')}
                </TextLink>
                <Text style={[styles.loginTermsText]}>.</Text>
            </Text>
        </View>
    </View>
);

TermsWithLicenses.propTypes = {...withLocalizePropTypes};

export default withLocalize(TermsWithLicenses);

I have tried migrating to TextLink again but experiencing some weird behaviour (Terms are being center aligned but the behaviour is not consistent). Can you help resolving them

@pranshuchittora could you elaborate on what the weird behavior is? Is it that the Money transmission... text is not aligning with the By logging in text? Or is it still the full stop after privacy policy goes to the new line as it is part of the next sentence?
Neither of these issues appear on main/staging, so they are related to this branch, and they both look like CSS issues.
If the only issue is that when making the web window smaller, it is possible for the . in privacy policy. to be on a new line, I don't think that is worth blocking this PR since it only happens if the window is 291 or 292 pixels wide (just those values). Also, on staging, the privacy policy. text is always on the next line, so this issue could still exist on previous branches, it likely just showed itself now since you've changed max-width for some components as part of these updates.

I have tried migrating to TextLink again but experiencing some weird behaviour (Terms are being center aligned but the behaviour is not consistent). Can you help resolving them

@pranshuchittora could you elaborate on what the weird behavior is? Is it that the Money transmission... text is not aligning with the By logging in text? Or is it still the full stop after privacy policy goes to the new line as it is part of the next sentence?
Neither of these issues appear on main/staging, so they are related to this branch, and they both look like CSS issues.
If the only issue is that when making the web window smaller, it is possible for the . in privacy policy. to be on a new line, I don't think that is worth blocking this PR since it only happens if the window is 291 or 292 pixels wide (just those values). Also, on staging, the privacy policy. text is always on the next line, so this issue could still exist on previous branches, it likely just showed itself now since you've changed max-width for some components as part of these updates.

I agree that it is not a blocker but using text link with center aligning content is behaving weirdly. This won’t appear in staging as it is not center aligned/justified in the current build.
No issue I will update the PR with TextLink component.

@Jag96 I have updated the PR, it's ready to merge

Requesting a review from Pullerbear to help with reviews since I'll be OOO the rest of the week

Requesting a review from Pullerbear to help with reviews since I'll be OOO the rest of the week

Headup, In the current main branch TermsWithLicenses is also behaving similarly (i.e. have aligning issues) in native.
https://expensify.slack.com/archives/C01GTK53T8Q/p1623814030375300

Links are still floating

Links are still floating

Able to make it work via
  <TextLink style={[styles.loginTermsText, {marginVertical: -4}]} href={CONST.LICENSES_URL}>
                    {translate('termsOfUse.phrase6')}
  </TextLink>

Is that the correct approach @Beamanator

All the issues have been fixed :)

Are all of your screenshots in the original comment up to date? If so, then I wanted to confirm that you saw my earlier feedback that the mobile view of the sign in form should have the form controls centered with a max-width of 295 like so:

I will be updating the screenshots.
Apart from that 295 will look very compact. Here's the 295 width

Sorry for the confusion, but I am suggesting that the form contents themselves should be at 295.

@stephanieelliott this PR is ready for final review -> https://expensify.slack.com/archives/C01GTK53T8Q/p1623949003407200

I have updated the PR
iOS

@Beamanator I have updated the PR.

I have updated the file structure.
For H3 styles I have removed the font-weight property and added a separate style named textBold with this approach we can have both H3 and H3 Bold this is more maintainable in the long run.
Regarding the merging of the ios and android, For the past 3 weeks I have been trying to fix the TermsWithLicenses weird behaviour in different platforms. Once again I tried to merge the 2 but no success.

Everything looks pretty good to me, but after seeing some screenshots on Web/Desktop, I think we might want to use some kind of fixed outer padding/gutter around the main content inside the blue area. From Figma, you can see where we have a fixed 80px on each side of the inner content in the blue area:

From the screenshots, you can see where that outer padding gets very skinny:

Thoughts on that?

I like that idea @shawnborton ! 👍

Any reason this was removed here? Doesn't this affect other h3/h4 elements? If you add this back you wouldn't need styles.textBold or styles.textStrong

So the use case is to use non bold version of h3

We're super close! I left a comment about the margin on top of the form in the left side. My other comment is around the phone image on the blue background. I feel like we don't need to make it react so much to the viewport height. Basically I think it can have a fixed height and a max-height at the same time. Maybe said another way, the phone image should generally always be the same size but in extreme circumstances (if the viewport height is super short), it can shrink down. But in the other case, like when the viewport height gets tall, I think it should have a max-height and not keep getting larger. Otherwise we would get this:

In that scenario, I think it would be better if the phone stayed the same size in relationship to the text to the left. We would then just take the text + phone and vertically center up that content in the blue area.
Here is a quick video of me resizing my browser so you can see it in action:

Let me know if that makes sense - I'm happy to mock something up if needed.

Can we also switch out all Expensify.cash refernces to "New.Expensify.com" please?

My other comment is around the phone image on the blue background. I feel like we don't need to make it react so much to the viewport height. Basically I think it can have a fixed height and a max-height at the same time. Maybe said another way, the phone image should generally always be the same size but in extreme circumstances (if the viewport height is super short), it can shrink down. But in the other case, like when the viewport height gets tall, I think it should have a max-height and not keep getting larger. Otherwise we would get this:

Making the height fixed will introduce a scrollbar which is not a good approach to responsiveness.

Making the height fixed will introduce a scrollbar which is not a good approach to responsiveness.

I think we need to balance reasonability with responsiveness though. We don't need the app to responsively scale to extreme, non-common height. If we can have a fixed image that works when the app is at say 600-700px tall, then I think we safely optimize for a majority of users.

Ok then what should be the plan of action

Just want to bump the change to use "New Expensify" in place of "Expensify.cash" in the two areas mentioned. Can we incorporate this into the PR?

I think the path forward is pretty simple with these small adjustments:

Looks good but:

Can you please address the comment here?
Address conflicts

Looks good but:

Can you please address the comment here?
Address conflicts

Sure

@shawnborton I have updated the PR with the final changes.

Thanks for the update! Do you know what's happening with the fine print here?

And cc @kevinksullivan - should it be "New Expensify" or "new Expensify"?

@pranshuchittora it also looks like you missed changing out Expensify.cash here:

Done

Wait somebody again changes the TermsWithLicenses 🤦🏼

Fixed, it was a file reference issue that occurred due to rebasing with the main.

@joelbettner I have updated the PR. cc @shawnborton

@pranshuchittora Thank you - one last change - can you please capitalize the "N" in New Expensify?

Done @shawnborton

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging         in version: 1.0.77-6🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

Web - Profile -  Too much space in mweb safari in log in page
Action Performed

Go to staging.expensify.cash

Expected Result
Log in page should be displayed properly
Actual Result
Too much space in mweb safari in log in page
Build: 1.0.78-0
Notes/Images/Video
OS and browser used: Safari

This is the expected behaviour

True, but I do think it would be nice if that top margin above the icon used a relative unit. Remember I left that comment here: https://github.com/Expensify/Expensify.cash/pull/3079#discussion_r666581784
We have this in place on our Expensify.com homepage:

Where the top padding is 15vh. Perhaps we can create a follow up issue to make this a bit more mobile friendly. To clarify, I don't think this is a blocker for paying @pranshuchittora for the work that was completed, I just think we can separately follow up with some enhancements.

🚀 Deployed to production         in version: 1.0.79-4🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


dont change to timer in nav on mobile

Bugfixes

Pull Request Test Coverage Report for Build 616

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.765%

Totals

Change from base Build 614:
0.0%

Covered Lines:
2077

Relevant Lines:
2090

💛  - Coveralls


completion sorting

We're now getting the sorting from the server, and doing the filtering in the client. When I type .text on a DivElement:

I get contextMenu showing up first, when there's a direct match for text. This issue started showing up when we started matching on contains in the string; startsWith didn't have this issue. I think short-term we should move back to using startsWith, and long term have all filtering and sorting down on the server.
@lukechurch @kasperpeulen

This is esp. annoying to the user, as they will type in e.text, hit return, and have e.contextMenu entered in :(

Agree, this is really annoying. What is going on with those arrows icons btw, shouldn't those be circled p's ?

I think short-term we should move back to using startsWith, and long term have all filtering and sorting down on the server.

I think this makes sense. I hadn't forseen this feature interaction :(

I was experimenting with representing getters and setters with left and right arrows. The arrows are different lengths though (the right arrow is shorter than the left) in our current font, so it didn't look good as I had it -

We moved back to filtering using startsWith.

@devoncarew @lukechurch
I added some filtering logic to this PR https://github.com/dart-lang/dart-pad/pull/218
which moves a 100% match on top
Maybe we can change back to contains if we add this filtering ?

we have a workaround


allow image updates to be forced if container not present #181

Supports #187. I've tested against my deployment of a PodTemplate it works wonderfully :)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


AsterNet command returns only last line

I'm sending the command below using C # and AsterNet.
The command executes, but only returns the last line of the command's response.
CommandAction cmdAction = new CommandAction ();
cmdAction.Command = "core show channels";
var response = manager.SendAction(cmdAction);

Ex:  response:  "0 calls processed"
Does anyone know how I do to return all lines of the command response?

Maybe the CoreShowChannelsAction action would be better?
Or maybe you are only getting one line because there only is one line?

The "core show channels" command is just an example. It occurs with any command that has more than 1 line.
In this example he brought the text: "0 calls processed"
But when running on the Asterisk console this is the return:
"asterisk*CLI> core show channels
Channel              Location             State   Application(Data)
0 active channels
0 active calls
0 calls processed"

Maybe #55 would be helpful for you?

I guess that ManagerEvent_CoreShowChannel hasn't been implemented still? Someone should probably just do that.

Maybe #55 would be helpful for you?

Unfortunately it doesn't help :(

As it was marked as a BUG, and I need to give a quick fix, I changed the project.
The problem is that the command returns several lines with the key name "output". The AsterNet project uses IDictionary and it does not support keys with the same name.
I worked around the problem by adding an extension to the "output" key name. ["output_0", "output_1", ... "output_x"] It is not an elegant solution :( , but it solved the problem without having to change many things in the code.

Helper.cs
    internal static void AddKeyValue(IDictionary list, string line)
    {
        int delimiterIndex = line.IndexOf(":");
        if (delimiterIndex > 0 && line.Length > delimiterIndex + 1)
        {
            string name = line.Substring(0, delimiterIndex).ToLower(CultureInfo).Trim();
            string val = line.Substring(delimiterIndex + 1).Trim();

                if (name == "output")
                {
                    int output_count = 0;
                    foreach (String key in list.Keys)
                    {
                        if (key.Length > 7 && key.Substring(0 , 7) == "output_")
                        {
                            output_count += 1;
                        }
                    }
                    name += "_" + output_count.ToString();
                }

            if (val == "<null>")
                list[name] = null;
            else
                list[name] = val;
        }
    }

I made a correction by changing Helper.cs
I added this line:
if (name == "output" && list.Contains("output")) val = list[name] + Environment.NewLine + val;
        internal static void AddKeyValue(IDictionary list, string line)
        {
            int delimiterIndex = line.IndexOf(":");
            if (delimiterIndex > 0 && line.Length > delimiterIndex + 1)
            {
                string name = line.Substring(0, delimiterIndex).ToLower(CultureInfo).Trim();
                string val = line.Substring(delimiterIndex + 1).Trim();

                if (name == "output" && list.Contains("output")) val = list[name] + Environment.NewLine + val;

                if (val == "<null>")
                    list[name] = null;
                else
                    list[name] = val;
            }
        }

Sorry for the late reply.
I'm using Asterisk 16
Before:

After:

that is great
thanks very much.


chore: remove all v1 artifacts

Also, rename testsV2 to tests.

We've handled the .build directory here: https://github.com/GoogleCloudPlatform/cloudsql-proxy/pull/1319.
I'll send a PR for examples next.


CTD noise and CNV output format

#30 for CTD only

Sorry for the one million files in the test zarr. I could also generate that on the fly instead of saving? maybe that's beter, not sure

Yes, I think that creating the zarr on the fly is better; as it will then also check whether zarr files are created as expected. Alternative is to put .zarr files in the gitignore?
Oh, and should the CNV is the title of this PR not be CSV?

Yes, I think that creating the zarr on the fly is better; as it will then also check whether zarr files are created as expected. Alternative is to put .zarr files in the gitignore?
Oh, and should the CNV is the title of this PR not be CSV?

The file format is CNV, a file format created by Seabird(the microcat brand)
The zarr file is in the test directory and used for the test. There already is a test for the creation of the zarr so that is not needed. I can either create it before running the rest by using the ctd function, but I think it might be better to replace this huge file with a very short zarr. That way a we have a fast test without having too much data on git

By changing the chunks parameter in the ParticleFile object creation, you can also limit the number of files (=chunks) generated. See the note at https://docs.oceanparcels.org/en/latest/examples/tutorial_parcels_structure.html#4.-Execution-and-output

By changing the chunks parameter in the ParticleFile object creation, you can also limit the number of files (=chunks) generated. See the note at https://docs.oceanparcels.org/en/latest/examples/tutorial_parcels_structure.html#4.-Execution-and-output

Ok makes sense I will keep that in mind. I have create a very small one now and I think this should be fine as test input?


Known issue: guinget 0.1.2 and 0.1.1 appear to ship with the same version of libguinget (0.1.1), even though they don't.

I forgot to increase the version number for libguinget before releasing it.

Version 0.1.3 fixes this issue by increasing the version number for the library. Not ready to close this yet.


Microsoft Edge Extension?

With anniversary update just around the corner for Windows 10 and support for extensions in Microsoft Edge, will the extension be ported over?
Thanks

As long as you're using Chrome/Firefox on your Windows 10 machine, the plugin should work fine. I haven't been able to upgrade/test with Microsoft Edge.

Oh I realize it works in Chrome/Firefox, what I'm asking is whether the extension will be made available for Microsoft Edge web browser.

It sounds like we might be able to support it with minimal effort:
This new model is Chrome-compatible which means that existing Chrome extension developers will be able to migrate their extensions to Microsoft Edge with minimal changes.

From https://developer.microsoft.com/en-us/microsoft-edge/platform/documentation/extensions/
What we'll need to do is wait for them to release their extension API beyond "a small number of extension authors" so we can see the impact.

If we could get this done, that would be great as its really the only thing preventing me from making MS Edge my primary web browser.

I'm having a great time with Brave at the moment.

This is being tracked here

Any update on this? Are we any closer to having the extension for Edge?

 We don't neeeeed it for mobile, as the extension support is not there yet for windows 10 mobile, but I don't see why there's no support for the desktop program! Seeing as it's the default browser for new Microsoft computers, this should be a priority!


Force driver restart

Is your feature request related to a problem? Please describe.
There are cases where LAN drivers are encountering unusual network errors while restarting after a hub boot - presumably due to a spike in attempted network activity while all drivers are simultaneously restarting.  Admittedly, this is an undiagnosed issue, but nevertheless users report on occasion that LAN drivers are not working after a hub reboot.    I have only on occasion been able to "catch" these issues viewing driver logs, but this is challenging to get logging working in time to see it.
Sometimes another hub reboot can solve the issue, but this is disruptive to users' environments, and is likely to cause the same issue since, again, all drivers are restarting.
If the user has the CLI, they can attempt to use it to "re-install" the driver, but the current edge:driver:install command has no affect unless there has been a change to the driver package.  So there currently is no way to force a single driver to restart.
Describe the solution you'd like
A clear and concise description of what you want to happen.
I would like to see an edge:drivers:restart command, or a flag added to the edge:drivers:install command to force a driver restart even if the package has not changed.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Rebooting the hub is the only other option, but this is disruptive in that it causes ALL drivers to restart, which is likely to result in the same theorized "network storm" issue described above.
Additional context
Add any other context or screenshots about the feature request here.

Can this be reviewed please


netinitialize: depend xxx_netinitialize on NET and not on NETDEV_LATEINIT

Summary
Depend xxx_netinitialize on NET and not on NETDEV_LATEINIT
Impact
None. Refactoring only
Testing
Pass CI

@pkarashchenko could you give some background on the need for this change? At first sight, it seems that after this patch xxx_netinitialize would be called twice when NETDEV_LATEINIT is selected.

@pkarashchenko could you give some background on the need for this change? At first sight, it seems that after this patch xxx_netinitialize would be called twice when NETDEV_LATEINIT is selected.

Let me double check, maybe I was too fast. Maybe I need to make an opposite change for RISC-V case. I will come back with the answer soon.

Let me close this and I will open a new one after check is done

@gustavonihei Please see the updated PR description. I've provided some more details.


chore(api): update fetch timetable query to order by dateOfEvent ASC

Change default sort order for /timetables/{caseRef} to dateOfEvent ASC

:tada: This PR is included in version 2.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Stopped importing records with no excerpt

Details logged here:
https://wordpress.org/support/topic/stopped-working-205/

Not sure what exactly changed to cause this to happen. The problem was null being passed in as the post_excerpt to the wp_insert_post() function. it is possible to pass in an empty string ('') or to leave the field out completely, but no longer possible to pass in a null and expect it to default.
The fix is to remove all fields with a null value before passing to wp_insert_post().


[SDK] ERC721 claimToBatch extension

Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
This PR introduces the claimToBatch functionality for the ERC721 extension, allowing multiple NFT claims in a single transaction. It includes new tests for this feature and optimizes the claim content processing.
Detailed summary

Added claimToBatch function in claimToBatch.ts for batch NFT claims.
Introduced ClaimToBatchParams type for defining batch claim parameters.
Implemented optimizeClaimContent function to combine identical recipient claims.
Created tests for claimToBatch and optimizeClaimContent in claimToBatch.test.ts.
Updated erc721.ts to export claimToBatch and related types.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Merge activity

Oct 22, 5:47 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


Should json be default feature ?

$ cargo update
    Updating crates.io index
      Adding itoa v1.0.5
    Updating markdown v1.0.0-alpha.5 -> v1.0.0-alpha.6
      Adding ryu v1.0.12
      Adding serde v1.0.152
      Adding serde_json v1.0.92

I am using mdast just to parse it and then process the mdast structures, e.g. I don't need json or any serialization out.
Would there be openness to having it as optional considering there are different ways to serialize out ?
Thanks for the great work btw ! :purple_heart:
Most of the ecosystem has serde as optional feature

It is optional? https://github.com/wooorm/markdown-rs/blob/00f8dd6a33ecf984af4d9c81f975c5a7d917d59f/Cargo.toml#L27

Yes but it's default optional as it's coming via default = ["json"]

Ah okay. So you can already turn it off, and then get what you are asking above, right?
But you think it should default to not having serde? Why do you want that?

People are used in the Rust ecosystem way to turn serde on or any other supplementary functionality.
Default feature set should not generally have any supplemental functionality enabled -
serde increases code sizes where I would expect a parser crate only to enable what is required for parsing
Ecosystem normal way is to not have default features that are not needed for the crate's primary function which in this case is parsing and not re-serializing which is optional additive feature especially since people can either choose html or json serialization optionally.
By turning it off we have to specify default-features = false and list all the features explicitly leading to pain to track all the changing features across the relases increasing maintenance overhead.
Code sizes are important for core parsing libraries especially in wasm/embedded contexts.


fix(addon-table): forgot add peer dependency

I don't think this is how we should fix it, I think we should get rid of the dependency since it's a legacy package. I'll take a look on Monday, should be possible one way or another.


feat: add app_json to application

I've opened issue #189 please tag that in future commits on this branch

Not quite working yet.  If I create a new application, click the checkbox and add app json and save, it is saved to the database.  However, if I then click on the application to edit it, the checkbox is unchecked so the app json -- which does exist -- is hidden.
Also, the entry field is still an input but I would like it to be a multi-line input

@kitajchuk not sure if you have time to take a quick look, but I want to use a textarea in a Checkzone, below is what it looks like if I simply swap the textarea in for the input, would you have any suggestions on improving the UI?


cocoapods not update?

I use pod 'HDWalletKit',but find that not have Sign UTXO based transaction

And Unlike with source code, thanks

Hi, @zhunye, version 0.2.6 contains it.
You can see example of usage in Essentia iOS App

If something is not clear feel free to reopen the issue.


BUG: Can't override {{date}} settings in 'schema 1.0.1'

Version (please complete the following information):

OS: Mac
Browser: Chrome
Web Clipper version: don't know
Obsidian version: 1.7.3

Describe the bug
I am trying to add a {{date}} to the note name but it seems to be overridden by 'schema 1.0.1', which I have no access to. The resulting text is 2024-10-09T21:32:03-04:00 even when I use {{date:YYYY-MM-DD}}. I expected a date like 2024-10-09.

This is a duplicate of #40. The correct use of the date filter is {{date|date:"YYYY-MM-DD"}}

Thanks, that works.


Page evaluate object with functions

Hello everyone, I can't pass the object inside which the function is in evaluate.
let someObj = {
      key1:  'foo',
      key2: (val) => (`key2 param is ${val}`)
};
page.evaluate(obj => {
 // I wanna call obj.key2('someval')
}, someObj)

Please, help me to resolve this issue

this isn't related here, ask in stackoverflow.


build: include cmd-socketio-server and socketio validators in the monorepo setup

Multiple changes, but they are tightly related to same issue so I introduced them in single PR, hope it's okay :)

Added two build steps in common packages.json to facilitate more complex build process of packages related to this PR. I will write another comment in code to this.
Added standalone projects to the global monorepo setup, namely:

./packages/cactus-cmd-socketio-server
./packages/cactus-plugin-ledger-connector-fabric-socketio
./packages/cactus-plugin-ledger-connector-go-ethereum-socketio
./packages/cactus-plugin-ledger-connector-sawtooth-socketio

All changed packages extends tsconfig.base.json, but most overwrites strict flag to false. This is the task for another PR. After fixing strict warnings we can merge verifier tests to the main jest config.

Related issue - https://github.com/hyperledger/cactus/issues/1671

All projects builds in typescript 4 set by the root config.
Updated the README files form connectors and examples to describe new (monorepo) build process. Also converted tabs to spaces.
I've lost a while trying to debug socketio errors when I forgot to run the init step in example app (I was sure it was my changes that caused that). I don't see for now any benefit of running two separate commands, so I've merged the init-* step to the build process itself so it's always executed.
Rewritten socketio and go-eheterum dockerfiles. Not strictly necessary for this PR, but now they are much smaller both in dockerfile lines and resulting container size. Tested with electricty-trade - works the same as before.
yarn.lock update - Changes from previous commits (I think it wasn't regenerated for a while) and from removing redundant and duplicated packages in this issue.
Fixed bug in Verifier that caused cartrade to fail compilation - for now just restored the previous implementation. Will be part of fixes to enable strict flag in this package (another task).
Examples were not included in monorepo setup, since it'd be tricky at the moment. It's better to containerize them instead of doing some fixes now.
Projects use ../../.build-cache like the other ones, so manual npm run build in package dir can do nothing. Do builds from root dir or clear the cache.

Closes: #1647
Signed-off-by: Michal Bajer<EMAIL_ADDRESS>

@outSH One more tip: There's a 're request review' button on GH that you can use to pass the ball back once you made requested changes on a PR (or when you addressed feedback/questions in general)
https://github.blog/changelog/2019-02-21-re-request-review-on-a-pull-request/

@outSH One more tip: There's a 're request review' button on GH that you can use to pass the ball back once you made requested changes on a PR (or when you addressed feedback/questions in general)
https://github.blog/changelog/2019-02-21-re-request-review-on-a-pull-request/

@petermetz Thanks, I'll use it from now on :) Is it PR ready for your approval?


same responses

if write same promts its generates same answers

Hello, give me please some example ^^
And, of course, it will give same answer, for example:

2+2?
4

sorry for long answer. i use this code:

Demonstrate on video:
https://github.com/user-attachments/assets/04afd1cf-1364-47af-888c-940c8d6df145

if needed i can send more code

if needed i can send more code

I think this is because past requests are not taken into account.