updating healthcheck to call datadog counter with tags

Description of what was changed
Breaking changes

Something to watch out for.

Definition of Done
There is not a hard requirement on what you need to do since it will vary heavily by task. But by saying that a task is complete you are saying that you have sufficient systems in place to guarantee what you have done.

[ ] some level of unit/integration tests
[ ] some level of monitoring links:
[ ] some level of alerts, links:
[ ] some level of documentation, links:

Secondary Impacts

[ ] Our docs have been updated or they don't need to be.
[ ] Our readmes have been updated or they don't need to be
[ ] Do our customers need to be notified?

LGTM


Arabic flag

Hey guys!
First, thank you for the amazing flag pack! I've started to use it in some projects but I found an important issue for me (and probably other users). I use the flags in the app language switcher so I found a problem with a flag for the Arabic language which is colocated with many countries. Could you add to the pack flag like that one? => https://commons.wikimedia.org/wiki/File:Flag_of_the_Arabic_language.svg
Thanks in advance

Before this issue gets dismissed as a flag for a country not defined in ISO-3166, this did not prevent you from including AFRUN, AMS, RAINBOW and UNASUR flags. Despite not being the best i18n practice, the flags (including ones provided by flagpack) are often used to describe languages. Arabic is spoken by more than 300 milion people worldwide - if RAINBOW deserves it's own flag, so does Arabic. Let's not ignore the issues only because we, living in english-first part of the world, are not directly affected.

Hi @lukaszflorczak and @Aareksio. Thanks for your feedback on Flagpack!🙌
Flagpack is collection of country flags and therefore we have no current plans to include flags that represent languages. Currently we are working toward making Flagpack completely based on ISO-3166. This will mean that in the upcoming major version of Flagpack, flags such as AMS, RAINBOW and AFRUN will be removed. This is a recent decision we made regarding other flag requests.
We regret not being able to offer you the flags that you request but we hope you can understand the policy we chose to decide which flags are included in Flagpack.

Thank you for the response. Clarifying you only recently decided to use ISO-3166 as the source of truth justifies the decision. Reading other issues, I haven't found any information as for why there are existing exceptions. Thank you!


Works with Filament ST64 and some comments

Hi,
Recently I bought a Filament amber ST64 E27 and was happy to find a Ruby library for the WiZ lights. Thanks for creating this!
I can confirm that the ST64 works correctly. It's detected as a "TunableLight", powering on/off, setting brightness and color temp, all seems to work as expected. There are a few things however:

The gem on rubygems.org is empty, there are no files in it. Pointing the gem source to the GitHub repo works, so I think something went wrong with packaging?

The minimum ruby version is 3.0.0. I'm using a raspberry Pi with a Raspbian packaged Ruby which is version 2.5. I'm not sure if you want to support older Ruby versions, but I can confirm that the gems works with Ruby 2.5.

I had some problems understanding the brightness level. The gem says "Brightness must be between 10 and 255", but below 25 I get an error (32602, Invalid params). So the range seems to be 25-255 (or 10-100 for the device). Perhaps mapping the values from 1-255 to 10-100 would be a bit easier to understand? (or maybe map from 1-100)

Also, would you accept a PR to add a shortcut to set the brightness level?
def brightness(value)
  dispatch_event(Wizrb::Lighting::Events::SetBrightnessEvent.new(value))
end

Thanks for your quick reply. I'm looking at the PR right now.


Sending emails for new petition sponsors

The email needs copy from Pete before merging.

New copy added. Ready to merge after code review.

Looks good.

Oh, wait.  No specs?


Classify :enetunreach as connectivity error

This is similar to what done in #94, and is necessary so that Tortoise.Connection will attempt a reconnection instead of terminating when the network is temporarily unreachable.
In my IoT project, if I unplug the ethernet cable, the following happens:

Upon the next keepalive ping, the Tortoise.Connection GenServer terminates due to :ping_timeout. Ideally, this would not cause the server to terminate, but rather to attempt a re-connection (as suggested in #116), but this is not the focus of this PR.

As the Tortoise.Connection GenServer is restarted by its supervisor, it quickly and repeatedly crashes when trying to connect due to {:error, :enetunreach}, and eventually the supervisor stops trying to restart it and the whole application terminates.

This PR classifies such error as a connectivity problem, and triggers the backoff reconnection logic instead.
Note: it is possible that other errors defined in http://erlang.org/doc/man/inet.html#type-posix might occur too in some cases (like :enetdown), even though I only experienced :enetunreach in my case.

Pull Request Test Coverage Report for Build 1

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 87.832%

Totals

Change from base Build 40:
0.3%

Covered Lines:
563

Relevant Lines:
641

💛  - Coveralls

👍 for this, I have the same problem. I have wrapped the client in a genserver that checks the internet connectivity to solve this for now, but it would be nice to have it in tortoise


Add examples  for SDK autoconfigure

Add autoconfigure and opentelemetry-exporter-otlp-logs
Add more configurations in docker-compose.yml to send metrics to dashboard
Add reflection configurations for spring-native

Hello @trask
this is actually decoupled with Newrelic, I have changed my PR title  and describe
All of these configurations comply with this https://github.com/open-telemetry/opentelemetry-java/tree/main/sdk-extensions/autoconfigure


Run FAST.Farm on windows.

Dear all,
When I run the IEA-15MW-Semi case on windows using FAST.Farm (compiled and installed using MinGW), it always terminating the process after "Running WakeDynamics." without any error messages and without generating any files. OpenFAST is working fine, I don't know what's going on, and I'd appreciate any advice.
CMD display when running FAST.Farm👇

CMD display when running OpenFAST👇

@NRELAdmin @jjonkman @bjonkman

Dear @CaiZhiming-HHU,
Do you have any any issues running the precompiled version of FAST.Farm for Windows as provided with the release of OpenFAST v3.5.3?
Best regards,

Dear @CaiZhiming-HHU,
Do you have any any issues running the precompiled version of FAST.Farm for Windows as provided with the release of OpenFAST v3.5.3?
Best regards,

This is what I encountered when I ran the precompiled version of FAST.Farm for Windows as provided with the release of OpenFAST v3.5.3. This problem only occurs when the IEA-15MW-Semi case calculation is run, and the NREL-5MW case calculation behaves normally.

Dear @CaiZhiming-HHU,
The FAST.Farm TSinflow r-test uses OpenFAST models of the NREL 5-MW baseline wind turbine.  Did you change this r-test to use OpenFAST models of the IEA Wind 15-MW RWT atop the VolturnUS semisubmersible?  Can you share your updated FAST.Farm primary input (.fstf) file?
Best regards,

IEA Wind 15-MW RWT atop the VolturnUS semisubmersible

I added the configuration files required by FAST.Farm (including the main input file .fstf) to the OpenFAST test case of https://github.com/IEAWindTask37/IEA-15-240-RWT/tree/master/OpenFAST/IEA-15-240-RWT-UMaineSemi. So the FAST.Farm test case of "IEA Wind 15-MW RWT atop the VolturnUS semisubmersible" is constructed.
In fact, I compiled and installed openfast-3.5.3 on a CentOS 7 system using gcc-11.1.0, and successfully run the FAST.Farm test case of "IEA Wind 15-MW RWT atop the VolturnUS semisubmersible" adapted by me.
But I was not satisfied with this, I wanted to successfully run this FAST.Farm test case on the Windows system, so I went through a series of attempts, and finally failed.
As you can see, first I used the precompiled FAST.Farm binary with stack overflow error, then I used MinGW (based on gcc-12.2.0) to compile and install openfast-3.5.3. The installation was successful, but when I executed the FAST.Farm command, it always terminating the process after "Running WakeDynamics." without any error messages and without generating any files.
This is my FAST.Farm primary input (.fstf) file👇

This is a visualization file that I processed after running it on a CentOS 7 system👇

Of course, I know that ROSCO requires different controllers (.so/.dll) in two different operating systems, and I take that into account.
In addition, I also tried to use MinGW (gcc-11.1.0), MinGW (gcc-13.2.0) and MinGW (gcc-10.2.0) to compile and install openfast-3.5.3 on Windows, the results are the same, the installation process is smooth, but When I run the IEA-15MW-Semi case on windows using FAST.Farm, it always terminating the process after "Running WakeDynamics." without any error messages and without generating any files.


Download image from Gravatar and store it in avatar after registration

Please solve https://github.com/vutuv/vutuv/issues/81 first.
The idea is to make life as easy as possible for a new user. If an image exists it should be downloaded and stored as an avatar. If no image exists do nothing.
<%= gravatar_url(@user) %>?d=404 will return a clean HTTP 404 error code if no image exists.
http://stackoverflow.com/questions/11582395/how-should-i-check-if-gravatar-exist

We use the Gravatar image by default for the registration. After that the user can upload a new one if he/she wants to.


Fixes serde::export private module error

I've been having this error trying to use this library, and I might as well fix it.
Good job on this though, this is a great library IMO.

@danii Thank you for the fix and thank you for the positive feedback!

@danii Thank you for the fix and thank you for the positive feedback!


Throws ClientErrorCode.CONNECT_BROKER_EXCEPTION in MQClientException when send max times still failed which in DefaultMQProducerImpl.java

What did you do?

Use rmq clinet to send msg to broker
Exception happens when retry to max times and the Exception code makes me confused.
I read the rmq client code and find it out

What did you expect to see?
Rmq client give me a exception code clearly, eg:RETRY_TO_FAILED

What did you see instead?
Throws  ClientErrorCode.CONNECT_BROKER_EXCEPTION in MQClientException when send max times still failed which in DefaultMQProducerImpl.java

information:
https://github.com/apache/rocketmq/blob/master/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java#L630

And another important issue is :
Also in DefaultMQProducerImpl.java#L596
https://github.com/apache/rocketmq/blob/master/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java#L596
Why  RemotingSysResponseCode.SYSTEM_BUSY is not in the retry list?Which is set in BrokerFastFailure.java when  [TIMEOUT_CLEAN_QUEUE] [PCBUSY_CLEAN_QUEUE] happens

@HymanShi As you described, rocketmq indeed need to polish the mechanism to make it more clear and useful for positioning problem, so would you like to polish this together?
The second question, if the producer still retries when the SYSTEM_BUSY exception was responded by the server, it will increase the load of the server, so in order to protect the server,
the producer will stop the retry process.

@HymanShi As you described, rocketmq indeed need to polish the mechanism to make it more clear and useful for positioning problem, so would you like to polish this together?
The second question, if the producer still retries when the SYSTEM_BUSY exception was responded by the server, it will increase the load of the server, so in order to protect the server,
the producer will stop the retry process.

@duhenglucky Thanks for your invitation, I'd like to polish this mechanism and how can i join it?
Reply to the second question:In fact, when users happen the SYSTEM_BUSY or other exceptions which are not in the retry list,users always resend the message themselves immediately in order to prevent sending failure.It will still increase the load of the server.Maybe rocketmq should provide a self-later-resend mechanism when SYSTEM_BUSY or other exception happens.


Theme: Cloudmin version detected incorrectly

On fresh install cloudmin GPL with virtualmin GPL, detect my cloudmin version incorectly PRO.
Cloudmin version 	8.4.kvm Pro

Ok, I'll take a look.
Thanks for reporting.

Thanks, I have another request, it is posible to display the drivers temperatures in line, not under each other. I have 4 drivers on server.

You can change it in theme settings already.

Once again, you have installed GPL versions only?

Do one more thing please. Open page source and find data-virtual-server-license and data-server-manager-license, what are the values for it?

..but you must open the source of the left frame by clicking on the navigation menu and selecting the show source..

Yes I installed just GPL version.
data-virtual-server-license="0"

Today I updated the cloudmin-server-manager to 9.0.kvm GPL version, and same issue.

Ok, I'll take a look.

Please test it with 18.00. I suppose it's still not displaying it correctly? If not just report here and I will do a fix look in 18.01.

Same issue, i tested under 18.00 version
http://server.rubencom.hu/images/authentic-theme2.jpg

If you switch back to default theme, what do you see??
What is the output of /usr/share/webmin/server-manager/module.info or for RHEL systems /usr/libexec/webmin/server-manager/module.info?

Will be fixed in 18.01. But please double check and tell what is the output of above.

Hi, today i updated to 18.02 version and same issue (BUG), I install authentic theme to other two servers and not detect the corect Cloudmin licence.
/usr/share/webmin/server-manager/module.info output
desc=Cloudmin GPL for KVM
category=webmin
depends=servers net proc 1.480
os_support=*-linux
version=9.0.kvm
onehost=kvm
vm2=kvm
gpl=1
desc_cz=Cloudmin GPL pro KVM
desc_cz.UTF-8=Cloudmin GPL pro KVM

Alright, I will test it later and come back to this issue.

Can you find in authentic-lib.pl
sub licenses {
    my ($id) = @_;
    if ( &foreign_available("virtual-server") && $id eq "vm" ) {
        my %virtualmin = &get_module_info("virtual-server");
        if ( $virtualmin{'version'} =~ /gpl/i ) {
            return 0;
        }
        else {
            return 1;
        }
    }
    elsif ( &foreign_available("server-manager") && $id eq "cm" ) {
        my %cloudmin = &get_module_info("server-manager");
        if ( $cloudmin{'version'} =~ /gpl/i ) {
            return 0;
        }
        else {
            return 1;
        }
    }
    else {
        return 0;
    }
}

And replace it with:
sub licenses {
    my ($id) = @_;
    if ( &foreign_available("virtual-server") && $id eq "vm" ) {
        my %virtualmin = &get_module_info("virtual-server");
        if ( $virtualmin{'version'} =~ /pro/i ) {
            return 1;
        }
        else {
            return 0;
        }
    }
    elsif ( &foreign_available("server-manager") && $id eq "cm" ) {
        my %cloudmin = &get_module_info("server-manager");
        if ( $cloudmin{'version'} =~ /pro/i ) {
            return 1;
        }
        else {
            return 0;
        }
    }
    else {
        return 0;
    }
}

That part seems to be making the problem. Reboot Webmin afterwards. Does it fix the issue?

I have updated 18.02 which will fix your bug. Just force upgrade.


Optional support for IS_CROWD for OD COCO label format

Description

Fix for the below stack trace with OD labels without IS_CROWD key:
<class 'KeyError'>
File "./rai_vision_insights.py", line 456 in main
rai_vi = RAIVisionInsights(
File "/azureml-envs/responsibleai-vision/lib/python3.8/site-packages/responsibleai_vision/rai_vision_insights/rai_vision_insights.py", line 239 in init
test = transform_object_detection_labels(
File "/azureml-envs/responsibleai-vision/lib/python3.8/site-packages/responsibleai_vision/utils/image_utils.py", line 134 in transform_object_detection_labels
int(label[IS_CROWD])])
Making it optional instead of removing it, due to significance (and potential support in future) for use-cases with crowds of people: https://github.com/AlexeyAB/darknet/issues/5567#issuecomment-626753196
Checklist

[ ] I have added screenshots above for all UI changes.
[ ] I have added e2e tests for all UI changes.
[ ] Documentation was updated if it was needed.

شكرا لك على المساعدة انا اوافق على السحب
في الاثنين، 30 أكتوبر 2023 في 10:12 م تمت كتابة ما يلي بواسطة Ilya
Matiach @.***>:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/responsible-ai-toolbox/pull/2395#pullrequestreview-1704897084,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDQ7ZEJPMYPBJ4GH7U2RYYDYB732BAVCNFSM6AAAAAA6PQNIBCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBUHA4TOMBYGQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***
com>


Compare new shaders (CAS, FSR, NIS)

https://github.com/mpv-player/mpv/wiki/User-Scripts#user-shaders
There are 3 new shaders, how about adding a comparison between Anime4K and the new ones?
FidelityFX CAS
AMD FidelityFX Contrast Adaptive Sharpening (CAS) provides a mixed ability to sharpen and optionally scale an image. The algorithm adjusts the amount of sharpening per pixel to target an even level of sharpness across the image. Areas of the input image that are already sharp are sharpened less, while areas that lack detail are sharpened more. This allows for higher overall natural visual sharpness with fewer artifacts.
FidelityFX FSR
AMD FidelityFX Super Resolution is a spatial upscaler: it works by taking the current anti-aliased frame and upscaling it to display resolution without relying on other data such as frame history or motion vectors. At the heart of FSR is a cutting-edge algorithm that detects and recreates high-resolution edges from the source image. Those high-resolution edges are a critical element required for turning the current frame into a “super resolution” image. FSR provides consistent upscaling quality regardless of whether the frame is in movement, which can provide quality advantages compared to other types of upscalers.
NVIDIA Image Scaling
NVIDIA Image Scaling is a spatial scaling and sharpening algorithm. The scaling algorithm uses a 6-tap scaling filter combined with 4 directional scaling and adaptive sharpening filters, which creates nice smooth images and sharp edges. In addition, an adaptive-directional sharpening-only algorithm is available. The directional scaling and sharpening algorithm is named NVScaler while the adaptive-directional-sharpening-only algorithm is named NVSharpen.

您的邮件已收到！谢谢！

Lanczos Variants+sharpen


broken naming convention for tfstate storage account.

storage.tf
Line 7
overwrite naming convention for storage account

Hi @MilanNXT as launchpad is transitioned to landing zone in 2006 release, this problem should be resolved with the new /landingzones/launchpad. Please review and provide feedback.


fix: Update WalletConnectConnector to handle individual namespaces like eip155:*

Description
Up until now WalletConnectConnector was set up to handle namespaces that included all data under global eip155 key i.e.
{
  "namespaces": {
    "eip155": {
      "chains": ["eip155:14", "eip155:19"],
      "methods": ["eth_sendTransaction", "eth_signTransaction", "personal_sign"],
      "events": ["accountsChanged", "chainChanged"],
      "accounts": ["eip155:14:0xab16a96d359ec26a11e2c2b3d8f8b8942d5bfcdb", "eip155:19:0xab16a96d359ec26a11e2c2b3d8f8b8942d5bfcdb"]
    },
  }
}

This worked as that's how majority of wallets implement the spec, however with v1 sunset we saw few wallets that return namespaces in another format (also valid)
{
  "namespaces": {
    "eip155:14": {
      "methods": ["eth_sendTransaction", "eth_signTransaction", "personal_sign"],
      "events": ["accountsChanged", "chainChanged"],
      "accounts": ["eip155:14:0xab16a96d359ec26a11e2c2b3d8f8b8942d5bfcdb"]
    },
    "eip155:19": {
      "methods": ["eth_sendTransaction", "eth_signTransaction", "personal_sign"],
      "events": ["accountsChanged", "chainChanged"],
      "accounts": ["eip155:19:0xab16a96d359ec26a11e2c2b3d8f8b8942d5bfcdb"]
    },
  }
}

Plus, there can be a combination of both formats returned. I updated connector to handle both when checking namespace chainId's and methods for validation.
Additional Information

[x] I read the contributing docs (if this is your first contribution)

Your ENS/address: asimetriq.eth

This PR seems to be fixing for this bug report:
https://github.com/wagmi-dev/references/issues/392
Pls review/merge it asap
Thanks

Pr is out of sync with actual branch will close and reopen to try and get latest updates. Looks like gh bug

@0xAsimetriq
For the wagmi versions after the version 1.3.4, for example version 1.3.5 or 1.3.7, we here even encounter the below error when starting the dApp:
error - Error: useConfigmust be used withinWagmiConfig``
The error is related to the usage of the hook useNetwork
Pls notice that this error does not occur for wagmi version 1.3.4

@midotrinh1211

Maybe website wasn't updated yet or there is an issue with Bifrost
Make sure you use wagmi hooks inside <WagmiConfig /> component with correct setup

@midotrinh1211

Maybe website wasn't updated yet or there is an issue with Bifrost
Make sure you use wagmi hooks inside <WagmiConfig /> component with correct setup

@0xAsimetriq
Thanks a lot for your reply.
Regarding point #1, if possible, pls discuss directly with Bifrost as it is the main mobile wallet on Songbird/Flare blockchain networks.
Regarding point #2, that error does not occur for wagmi version 1.3.4. The error occurs only for versions 1.3.5 and 1.3.7
Looking forward to your further reply on this.

@0xAsimetriq
With the latest version of 1.3.8, still same issue as reported above.


1.38.38 fails to build

trzeci/emscripten-slim:sdk-tag-1.38.38-64bit-64bit)[][%]()
The command '/bin/bash -c cd ${EMSDK}     &&  echo "## Clean-up Emscripten Installation"     &&  shopt -s globstar             &&  _file=`echo ./emscripten/*/site/build/text/docs/tools_reference/emcc.txt`     &&  _content=`cat ${_file}`     &&  rm -fr             ./emscripten/*/docs             ./emscripten/*/media             ./emscripten/*/site     &&  mkdir -p `dirname ${_file}`     &&  echo ${_content} >> ${_file}             &&  _file=`echo clang/*/src/emscripten-version.txt`     &&  _content=`cat ${_file}`     &&  rm -fr clang/*/src     &&  mkdir -p `dirname ${_file}`     &&  echo ${_content} >> ${_file}         &&  rm -fr binaryen/*/src     &&  rm -fr binaryen/**/test     &&  rm -fr binaryen/**/*.cmake     &&  rm -fr binaryen/**/Makefile         &&  rm -fr clang/*/*/docs     &&  rm -fr clang/*/*/tools     &&  rm -fr clang/*/*/projects     &&  rm -fr clang/*/*/cmake     &&  rm -fr clang/**/*.cmake     &&  rm -fr clang/**/Makefile             &&  find . -name "*.pyc" -exec rm {} \;     &&  find . -name "CMakeFiles" -type d -prune -exec rm -fr {} \;     &&  find . -name "CMakeCache.txt" -exec rm {} \;             &&  find . -name "*.o" -exec rm {} \;     &&  find . -name "*.a" -exec rm {} \;     &&  find . -name "*.inc*" -exec rm {} \;     &&  find . -name "*.gen.tmp" -exec rm {} \;             &&  find clang -type d -depth -empty -exec rmdir "{}" \;     &&  find binaryen -type d -depth -empty -exec rmdir "{}" \;             &&  rm -fr **/*_32bit     &&  rm -rf **/.git     &&  rm -rf **/tests     &&  rm -fr zips/*             &&  rm -fr /opt/cmake /usr/local/bin/cmake /cmake*             &&  sleep 2 &&  echo "## Done"' returned a non-zero code: 1
[INFO] Compiled [trzeci/emscripten-slim:sdk-tag-1.38.38-64bit] in: 0:00:01.159364
trzeci/emscripten-slim:sdk-tag-1.38.38-64bit - FAIL
At least one compilation set has failed to compile

Hi, just to state I'm aware about issue. Due vacation I will handle this in ~2w. Cheers!

Hi @dos1,
Unfortunately it took more than 2w, but eventually I fixed all related problems, sorry that it took so long, it was a nice puzzle to solve. At the moment I've started to rebuild all images 1.38.34 upwards. Will take a couple of hours until they land in registry,
At the moment you can check 1.38.40 as I was using it as a test case.
➜ docker run --rm -it trzeci/emscripten:sdk-tag-1.38.40-64bit emcc --version
Unable to find image 'trzeci/emscripten:sdk-tag-1.38.40-64bit' locally
sdk-tag-1.38.40-64bit: Pulling from trzeci/emscripten
9fc222b64b0a: ...
Digest: sha256:839c186ec629fcec7ebb5ad50b9a503415707d98cbdaa5afaf4d7e15555f1e7b
Status: Downloaded newer image for trzeci/emscripten:sdk-tag-1.38.40-64bit
emcc (Emscripten gcc/clang-like replacement) 1.38.40 ((unknown revision))
Copyright (C) 2014 the Emscripten authors (see AUTHORS.txt)
This is free and open source software under the MIT license.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Will keep this issue open for a couple of days to make sure everything works for you.
Cheers,

Should be done, please re-open in case of any problems,
Cheers!


[BUG] Async isn't actually being used, and prevents ctrl+c from correctly exiting the app

When I first started trying reviews, ^C didn't work very well... I had to bash it several times to get the app to quit.
Looking a bit closer, at the code, render in tasks.py is actually a blocking function.
In cli/main.py all of the async code can be removed:
import asyncclick as click

from ..tasks import render, single_render
from ..version import __version__

CONTEXT_SETTINGS = dict(help_option_names=["-h", "--help"])

@click.group(context_settings=CONTEXT_SETTINGS)
@click.version_option(__version__, "-v", "--version", message="version %(version)s")
def cli() -> None:
    """Reviews - A terminal UI Dashboard for monitoring code review requests.\n

    For feature requests or bug reports: https://github.com/apoclyps/reviews/issues
    """

@cli.command(help="Visualize code review requests as a Dashboard")
@click.option("-r", "--reload/--no-reload", default=True, is_flag=True)
def dashboard(reload: bool) -> None:
    """
    Command:\n
        reviews dashboard

    Usage:\n
        reviews dashboard --reload \n
        reviews dashboard --no-reload \n
    """

    click.echo("loading dashboard")

    if reload:
        render()
    else:
        single_render()

def main() -> None:
    """Entry point to CLI"""
    cli()

In my few manual tests this runs exactly the same as it did before - but now ^C will actually exit the program.

Thanks for the feedback @waynew - I agree this was a pain point of using reviews.
the initial spike introduced asyncclick as a quick and easy way to split the updates from renders but it was never fully implemented and a lot of the code got left around. #95 and #109 was the start of removing it but it's great to finally remove async and resolve this bug.
I'll ship a 0.1.8 version with the latest fixes today


Updated MicrosoftGovernmentAppCredentials to support Skills in Azure Gov

Fixes https://github.com/microsoft/botbuilder-dotnet/issues/3233
Added constructor to MicrosoftGovernmentAppCredentials that takes OAuthScope to support skills in gov.
Updated BotFrameworkHttpClient and BotFrameworkAdapter to pass the OAuthScope to MicrosoftGovernmentAppCredentials
Added SimpleBotToBot functional test for testing.
Added Microsoft.Bot.Framework.Skills.sln to load skills test projects.

Pull Request Test Coverage Report for Build 104482

0 of 0   changed or added relevant lines in 0 files are covered.
1285 unchanged lines in 160 files lost coverage.
Overall coverage decreased (-1.3%) to 78.298%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Facebook/FacebookAdapterOptions.cs
1
86.67%

/libraries/integration/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/ApplicationBuilderExtensions.cs
1
71.43%

/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisApplication.cs
1
96.36%

/libraries/Microsoft.Bot.Builder.AI.LUIS/V3/LuisApplication.cs
1
96.43%

/libraries/Microsoft.Bot.Builder.AI.LUIS/V3/LuisUtil.cs
1
96.35%

/libraries/Microsoft.Bot.Builder/BotStateSet.cs
1
85.0%

/libraries/Microsoft.Bot.Builder.Dialogs/Debugging/DebugSupport.cs
1
75.0%

/libraries/Microsoft.Bot.Builder.Dialogs/Debugging/SourceRange.cs
1
46.15%

/libraries/Microsoft.Bot.Builder.Dialogs.Declarative/ComponentRegistration.cs
1
71.43%

/libraries/Microsoft.Bot.Builder.Dialogs.Declarative/Resources/ResourceExplorer.cs
1
96.3%

Totals

Change from base Build 104413:
-1.3%

Covered Lines:
20518

Relevant Lines:
26205

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3


Dcr8898 email notifications

Okay, this looks like it can't automerge likely because I rebased to master, not dev, and master and dev are not currently in sync.  Suggestions for a resolution?
This setup uses the following configuration in 'config/environments/production.rb':
  config.action_mailer.raise_delivery_errors = true
  config.action_mailer.delivery_method = :smtp
  host = 'mentor-me-dev.herokuapp.com'
  config.action_mailer.default_url_options = { host: host }
  ActionMailer::Base.smtp_settings = {
    :address        => 'smtp.sendgrid.net',
    :port           => '587',
    :authentication => :plain,
    :user_name      => ENV['SENDGRID_USERNAME'], # The SendGrid 'ID' David provided
    :password       => ENV['SENDGRID_PASSWORD'],  # The SendGrid 'secret' David provided
    :domain         => 'heroku.com',
    :enable_starttls_auto => true
  }

THIS CONFIG DOES NOT WORK!  It fails with the following error:
Net::SMTPAuthenticationError (535 Authentication failed: Bad username / password
)

Note that this is a send error; the emails are being generated correctly.  In the development environment emails are created and then logged to the server console.  They are creating correctly there.  I don't see a way for me to troubleshoot this further, since it is essentially a configuration issue for which I do not have access to the necessary data (on the SendGrid side).
The configuration setup I used is consistent with both:
https://www.railstutorial.org/book/account_activation_password_reset#code-sendgrid_config
and
https://sendgrid.com/docs/Integrate/Frameworks/rubyonrails.html#-Configure-ActionMailer-to-Use-SendGrid
Soooo . . . any thoughts on either the Dev/Master issue or this config question would be welcome.
Happy Day After Halloween!
Damian

@dcr8898 merge conflict on this one

I've reviewed the code, you can skip going to read all the files.
David should review the portion damian asked about above then merge if it's fine.

Looks good


Updated Conflicts-with Scrutinizer tests using Mockito

updated test class by creating mocks for ConstraintFetcher

Can you fix the merge conflicts first?

Resolved the merge conflicts :)


Blog Post:  How fast is it to make a teal app?

Blog Post
Vague idea:
Teal makes it fast and easy to make simple RShiny Apps. But how fast, and how easy? How little code do we need to make a working teal app (e.g. with a demog table and ae table) which we can then customise with our study data)?
The example code could use {phamraverseadam} data.
@khatril are you or others in your team interested in this?

Seeing on the progress of this post?  We love to get it out soon!

Removing my assignment as I don't have bandwidth, please re-share with community to contribute to this great post!

Hi! Happy to take on this blog post.

@gigikenneth I think someone in the tea; channel expressed interest as well when i posted about this there yesterday? Maybe you could connect and cooperate?

@manciniedoardo Awesome, that would be great. I'll reach out to them.

Will be glad to collaborate on this with @gigikenneth


Add waitForAuth and requireAuth to e2e tests?

Can we get these into our e2e tests? Auth is currently problematic in e2e, but perhaps with email/password and using redirect vs popups we could manage this? These two directives probably deserve a run.

Doesn't seem to work with redirect; results are inconsistent. Giving up on this. Our e2e tests are shaky enough that I don't want to  add any additional inconsistencies.


Rotating Ion Thrusters with Debug Stick

Describe the bug
Basically, when using the Debug Stick on an Ion Thruster to rotate it, the thruster stops working.
To Reproduce
Steps to reproduce the behavior:

Give yourself a debug stick (/give @s minecraft:debug_stick 1)
Place an Ion Thruster
R-click the thruster with the stick to rotate it
Give it power
(Ps: on a ship ofc)

Expected behavior
Rotate the thruster without it stoping to work
Screenshots/videos
...
Logs
The game logs (latest.log, debug.log).
Versions

VS2 version: latest on vs discord (valkyrienskies-118-forge-2.1.1-beta.3e00ea733a3)
Mekanism version: Mekanism-1.18.2-<IP_ADDRESS>5

Additional context
...

Probably wont fix since the debug stick is a creative item and when you're in creative you can simply break and replace the block


RadzenDropdownDataGrid: Selected values get cleared if component is dynamically generated

When Radzendropdowndatagrid component is dynamically generated, it loses it's state when clicking outside the component. I have recorded a video showing the issue: https://youtu.be/YxjRH9oJ0uA
I also attempted to reproduce this issue in a minimal app, but so far, I have been unsuccessful. I am hoping you can provide some suggestions/ideas to get past the issue.

OS: Windows 11
Browser: IE Edge (Chromium based)
Browser Version: 126.0.2592.53
Radzen.Blazor Version: 4.32.7

I'm afraid without code replicating the issue we cannot assist. Use our forum if you are looking for general assistance from our community.


update all tests to work offline

Coverage increased (+0.1%) to 27.93% when pulling 40eb4d0f4c26a590b857a53e04fad87efcd9d470 on offline-tests into fb5ef9c67a14b10ac51eecb44f5569befb5c7a39 on master.

Coverage increased (+70.4%) to 98.254% when pulling 69ee1f1d31489b3050b625d7e50be623b4c39dec on offline-tests into fb5ef9c67a14b10ac51eecb44f5569befb5c7a39 on master.


Only first 100 rows shown, white pane below

I would like to render a table with 198 rows but only the first 100 are shown while a completely empty white pane is shown below, seemingly the size of the remaining 98 rows. I added the idx to the Vec to see how many were rendered as can be seen in the image below.

The 'white pane' is one large tr:

Am I doing something wrong? I use the following code

    <TableContent rows />

I am still on v0.10.2 due to some incompatibilities with leptonic when upgrading.
EDIT: on v0.13.0 I have the same issue.

For virtualization to work the scroll container needs to be known as well as its vertical size. Please have a look at the paginated_rest_datasource example to see how this can be set up.


Versioned Documentation

Create a "current", "next", and "release/X.X.X" versioned documentation.

Right now its just "main" / "latest". Will update for specific versions in future (probably)


Add ability to eliminate a lint rule per line or file

See [http://stackoverflow.com/questions/35136098/have-sass-lint-ignore-a-certain-line] for a thread on this. It seems that scss lint might support this in a similar way to eslint for JS files
There are often a few cases in any code base where you need to disable a lint rule for some particular reason. In my case, I need to import Google Material Design icons, but the documented css logic causes no-duplicate-properties and no-vendor-prefixes to fire. I therefore want to keep those rules for every other file in my tree except my font.scss file
// http://google.github.io/material-design-icons/
@font-face {
  font-family: 'Material Icons';
  font-style: normal;
  font-weight: 400;
  src: url('~material-design-icons/iconfont/MaterialIcons-Regular.eot'); // IE
  src: local('Material Icons'),
  local('MaterialIcons-Regular'),
  url('~material-design-icons/iconfont/MaterialIcons-Regular.woff2') format('woff2'),
  url('~material-design-icons/iconfont/MaterialIcons-Regular.woff') format('woff'),
  url('~material-design-icons/iconfont/MaterialIcons-Regular.ttf') format('truetype');
}

.material-icons {
  // Firefox
  -moz-osx-font-smoothing: grayscale;
  // WebKit
  -webkit-font-smoothing: antialiased;
  direction: ltr;
  display: inline-block;
  font-family: 'Material Icons';
  // IE
  font-feature-settings: 'liga';
  // preferred icon size
  font-size: 24px;
  font-style: normal;
  font-weight: normal;
  letter-spacing: normal;
  line-height: 1;
  // Safari, Chrome
  text-rendering: optimizeLegibility;
  text-transform: none;
  white-space: nowrap;
  word-wrap: normal;
}

maybe this should live under sasslint itself?

see https://github.com/sasstools/sass-lint/issues/70 - looks close to complete...


As an operator I want to Trigger a promotion based on an Item in the cart

[ ] User can choose the trigger "Item is in cart"

[ ] User can use inclusions and exclusions on the trigger to indicate which item(s) or item attributes should activate the trigger (issue 120)

Mockup  (Promotions / Detail / Item Trigger)  https://www.figma.com/file/vWot2cXXgjcsLpMq4SAX90/Kinetic?node-id=2020%3A54523&t=c9z0pplx66ozEPgb-0

Hi @brendan-shea-pm, do you want to add a numeric field beside this field to have the ability to add a number amount of items in the cart? Something like this.

@vannguyenn Yes that works. Could you add text to the left of the number field that reads "Number of items required in cart" so that it's clear what the number field represents?

@brendan-shea-pm Sure will do. Thanks

Hi @brendan-shea-pm Regarding the field label, I think we should do something like this for consistency and a better layout. WDYT?

@vannguyenn Yes that is a more elegant solution, thanks! Is there some way to indicate that this is the minimum number of items required? Want to make sure the user understands that it is ItemCount equal to or great than the number. So if a user puts 1 but the customer has 2 then the promo is still triggered.

@brendan-shea-pm  We can have a description under the field, our TextField component supports this

@vannguyenn Yes I like it! Can we say "Minimum number of items required to trigger promotion"

Sure, will update it


Investigate pytest issues on CI

CI run logs: logs_5403.zip
Failing pipeline: test (macos-latest, 3.9)

2 errors I found:

Warning raised by slow tests, fixed by #1005, as it rewrites the test. These should have been test errors but they were captured as thread warnings instead unfortunately, so it took some time to catch. @FasterSpeeding this is the test you told me about. Ig I fixed it by mistake 😅

2022-02-07T13:17:06.0187500Z tests/hikari/impl/test_rate_limits.py::TestWindowedBurstRateLimiter::test_throttle_when_limited_sleeps_then_bursts_repeatedly
2022-02-07T13:17:06.0188250Z   /Users/runner/work/hikari/hikari/.nox/pytest/lib/python3.9/site-packages/_pytest/threadexception.py:73: PytestUnhandledThreadExceptionWarning: Exception in thread Thread-5
2022-02-07T13:17:06.0188630Z
2022-02-07T13:17:06.0188810Z   Traceback (most recent call last):
2022-02-07T13:17:06.0202960Z     File "/Users/runner/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/threading.py", line 973, in _bootstrap_inner
2022-02-07T13:17:06.0203420Z       self.run()
2022-02-07T13:17:06.0203790Z     File "/Users/runner/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/threading.py", line 910, in run
2022-02-07T13:17:06.0204110Z       self._target(*self._args, **self._kwargs)
2022-02-07T13:17:06.0205110Z     File "/Users/runner/work/hikari/hikari/tests/hikari/impl/test_rate_limits.py", line 343, in _run_test_throttle_logic_on_this_thread
2022-02-07T13:17:06.0205510Z       event_loop.run_until_complete(self._run_test_throttle_logic_on_loop(event_loop))
2022-02-07T13:17:06.0205950Z     File "/Users/runner/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/asyncio/base_events.py", line 642, in run_until_complete
2022-02-07T13:17:06.0206270Z       return future.result()
2022-02-07T13:17:06.0206650Z     File "/Users/runner/work/hikari/hikari/tests/hikari/impl/test_rate_limits.py", line 396, in _run_test_throttle_logic_on_loop
2022-02-07T13:17:06.0207340Z       assert math.isclose(next_first - previous_last, period, abs_tol=max_distance_within_window), (
2022-02-07T13:17:06.0207720Z   AssertionError: distance between windows is not acceptable! 0=39.98175229 1=41.582799405, max diff = 0.05
2022-02-07T13:17:06.0207980Z   assert False
2022-02-07T13:17:06.0208390Z    +  where False = <built-in function isclose>((41.582799405 - 39.98175229), 1.5, abs_tol=0.05)
2022-02-07T13:17:06.0208780Z    +    where <built-in function isclose> = math.isclose
2022-02-07T13:17:06.0209290Z
2022-02-07T13:17:06.0209580Z     warnings.warn(pytest.PytestUnhandledThreadExceptionWarning(msg))
2022-02-07T13:17:06.0209800Z
2022-02-07T13:17:06.0209970Z tests/hikari/test_channels.py::TestTextChannel::test_trigger_typing
2022-02-07T13:17:06.0210810Z   tests/hikari/test_channels.py:302: PytestWarning: The test <Function test_trigger_typing> is marked with<EMAIL_ADDRESS>but it is not an async function. Please remove asyncio marker. If the test is not marked explicitly, check for global markers applied via 'pytestmark'.
2022-02-07T13:17:06.0211330Z     def test_trigger_typing(self, model):
2022-02-07T13:17:06.0211480Z
2022-02-07T13:17:06.0211760Z -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

Apart from the repr for TimedCacheMap being horrible for debugging this, it looks like another speed issue. #1005 also fixes this by completely removing the tests for it. If we were to keep it, I think there is also a way to not make it flaky

2022-02-07T13:17:05.9862020Z ____________ TestTimedCacheMap.test___setitem___garbage_collection _____________
2022-02-07T13:17:05.9862570Z
2022-02-07T13:17:05.9863100Z self = <tests.hikari.internal.test_collections.TestTimedCacheMap object at 0x1066f03a0>
2022-02-07T13:17:05.9863970Z
2022-02-07T13:17:05.9864460Z     @pytest.mark.asyncio()
2022-02-07T13:17:05.9864990Z     async def test___setitem___garbage_collection(self):
2022-02-07T13:17:05.9865520Z         mock_map = collections.TimedCacheMap(
2022-02-07T13:17:05.9866120Z             expiry=datetime.timedelta(seconds=hikari_test_helpers.REASONABLE_QUICK_RESPONSE_TIME * 3)
2022-02-07T13:17:05.9866660Z         )
2022-02-07T13:17:05.9867100Z         mock_map["OK"] = "no"
2022-02-07T13:17:05.9868290Z         await asyncio.sleep(hikari_test_helpers.REASONABLE_QUICK_RESPONSE_TIME * 2)
2022-02-07T13:17:05.9868850Z         assert mock_map == {"OK": "no"}
2022-02-07T13:17:05.9869350Z         mock_map["ayanami"] = "rei"
2022-02-07T13:17:05.9869850Z >       assert mock_map == {"OK": "no", "ayanami": "rei"}
2022-02-07T13:17:05.9870780Z E       AssertionError: assert <hikari.inter...t 0x1060cff40> == {'OK': 'no', 'ayanami': 'rei'}
2022-02-07T13:17:05.9871360Z E         Full diff:
2022-02-07T13:17:05.9871960Z E         - {'OK': 'no', 'ayanami': 'rei'}
2022-02-07T13:17:05.9872580Z E         + <hikari.internal.collections.TimedCacheMap object at 0x1060cff40>
2022-02-07T13:17:05.9873010Z
2022-02-07T13:17:05.9873200Z mock_map   = <hikari.internal.collections.TimedCacheMap object at 0x1060cff40>
2022-02-07T13:17:05.9873600Z self       = <tests.hikari.internal.test_collections.TestTimedCacheMap object at 0x1066f03a0>
2022-02-07T13:17:05.9873820Z
2022-02-07T13:17:05.9873960Z tests/hikari/internal/test_collections.py:251: AssertionError
2022-02-07T13:17:05.9874490Z ------------------------------ Captured log call -------------------------------
2022-02-07T13:17:05.9876750Z WARNING  asyncio:base_events.py:1885 Executing <Task pending name='Task-5' coro=<TestTimedCacheMap.test___setitem___garbage_collection() running at /Users/runner/work/hikari/hikari/tests/hikari/internal/test_collections.py:248> wait_for=<Future pending cb=[<TaskWakeupMethWrapper object at 0x105b67c10>()] created at /Users/runner/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/asyncio/base_events.py:424> cb=[_run_until_complete_cb() at /Users/runner/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/asyncio/base_events.py:184] created at /Users/runner/work/hikari/hikari/.nox/pytest/lib/python3.9/site-packages/pytest_asyncio/plugin.py:445> took 0.207 seconds


Construct Array from DataFrame with meta

Currently the _meta of values doesn't get correctly updated when using cuDF DataFrames instead of Pandas ones. Thus the _meta winds up being a NumPy array instead of a CuPy array.
It seems the meta handling code in Dask DataFrame hadn't been updated since Dask Array got its own meta.  As I mentioned there, there are some other issues that emerge if you allow any array-like object to be the _meta in an Array.

Oops totally missed that 😅
Thanks for working on this Gabe! Should we close this one out to consolidate work in that PR or vice versa? No strong feelings either way 🙂

I don't have a preference either. If we want to take the finalize-preserves-subclasses approach I used to get tests passing, let's consolidate on #7399. But if we want to take the check_type=False approach in #7491, then your PR here has a smaller diff.
Worth noting that either way, this comment applies: https://github.com/dask/dask/pull/7399#issuecomment-809757540. Once we merge this, users doing .values on a DataFrame containing ExtensionArrays are not gonna have a good time. ExtensionArrays are basically nonfunctional right now as Array chunks; you can't do any reductions or elementwise operations on them. Whereas right now, .vaules just fails, so it's only one possible error instead of many 😉 .

@jakirkham @gjoseph92 and I are planning to meet up to talk through a plan tomorrow at 1pm eastern. Please feel free to join or suggest a different time if you want to be in on that :)

Sounds good. Feel free to send me an invite 🙂

cc @douglasdavis (in case this discussion is of interest to you as well 🙂)

Closing so we can consolidate work in PR ( https://github.com/dask/dask/pull/7399 )


A more lovely pr

A more lovely pr.  LOL

If this don't get merged, perhaps the main repo would be nice(?)


You alexa device is currently offline

I want to control Alexa from my phone, but it thinks it is offline...
Sorry to clog this issues page, I really do like what you've done.

Sam - I have a similar issue. My Pi is definitely logged in and connected, I am able to press the button and talk to Alexa. However, the web interface (alexa.amazon.com) says that i am offline.
Am sure there's something different in the way we've setup the pi and use the python code you've developed. When using the reference java application the web interface (alexa.amazon.com) does show the device as online.
Able to help us out here with what changes might be required?

AlexaPi always reports as being "offline."  It's not an issue.  It's a function of the way the system works, only sending audio files to Amazon when there's something worth sending.
Other systems maintain an always-on server that is connected to Amazon.  They register as being "online."

Yeah this is mostly due to us still using the V1 Alexa API, once we get onto the V20160217 api and have a persistent HTTP/2 connection things like pushing from the app will become possible, might not work right away though!

Would an ETA on that be available? Also could you look at this https://github.com/sammachin/AlexaPi/issues/123 issue

We're very probably gonna do this on the new repo only. You can check it out in the meantime.


statically linked libscrypt

Description:
Due to continuous issues with pulling in libscrypt using SPM we need to use a statically linked version of the c library.  All the files are directly ported from: https://github.com/technion/libscrypt/tree/a402f4116245ce8677b3d9f4f87096b5ccbe26e9
The issue that required this change is due to: https://forums.swift.org/t/swift-package-manager-and-custom-build-configurations/29181/12
In our build machines we use XCode11 which at the time, SPM did not have support for any configurations outside of Debug and Release.  The solutions revolving around making SPM work would be incredibly hacky.
By including the C library directly we gain the ability to use the Scrypt implementation without the SPM overhead.
The reason we have to use Scrypt is outlined here: https://pathcheck.atlassian.net/wiki/spaces/TEST/pages/81231882/Hashing+of+GPS+points+-+Design#The-Hash-Calculation
Any swift implementation proved to not meet our performance requirements.  So we have to use a lower level language to not drain battery and waste cycles on users phones.
Linked issues:
https://github.com/Path-Check/covid-safe-paths/pull/928 : describes more reasons for bringing this in, in the first place
https://github.com/Path-Check/covid-safe-paths/pull/937 : brings up new reasons to port over to a static lib
How to test:
All tests remain unchanged, this is essentially a "hot swap" of how the project knows where our library is.

@johnschoeman @JacobJaffe @yonatanmk @efalkner @tstirrat @mattThousand This should fix up the staging build artifact issue.

@johnschoeman if we do upgrade to xcode 11.5.1 beta the SPM integration would be flawless!  I was able to pin down the xcode build issues by using different xcode versions locally.  The future integration would only require deleting the libscrypt folder and adding back the SPM module :)
I also don't have write access so feel free to merge this in.
I don't believe the Test / e2e-iphone-se cancel/fail is due to these changes.

@johnschoeman if we do upgrade to xcode 11.5.1 beta the SPM integration would be flawless! I was able to pin down the xcode build issues by using different xcode versions locally. The future integration would only require deleting the libscrypt folder and adding back the SPM module :)

Sounds good @tstirrat @efalkner I think well need to get 11.5.1 beta into the github workflow for the building is this something you can help out on?

I also don't have write access so feel free to merge this in.
I don't believe the Test / e2e-iphone-se cancel/fail is due to these changes.

Currently we are blocking all merges that dont pass these required tests, .... so we will need to actually get that to pass before merging in. :/

@johnschoeman https://github.com/Path-Check/covid-safe-paths/pull/937/checks?check_run_id=731238470#step:11:9 demonstrated the same behavior

@johnschoeman https://github.com/Path-Check/covid-safe-paths/pull/937/checks?check_run_id=731238470#step:11:9 demonstrated the same behavior

Yeah, I think the requirement on this one building is new.  I makes sense to fix the test in a separate pr, imo.

@MichaelNeas , I have this pr up for using xcode 11.5: https://github.com/Path-Check/covid-safe-paths/pull/948.
Assuming that theres no conflict in our devops setup and we are able to make the switch, what do you think about not merging this pr in?  Is there any work here that would be valuable outside of removing SPM?

@johnschoeman That'd be sweet, no value in merging this PR if all goes well with XCode 11.5, also thanks for upgrading the xcode version! 😄

@MichaelNeas , #948. was merged, so closing this now!  Let me know if you need any more assistance getting swift stuff setup.  thanks again!


Some problems(?) with imported Homebrew monsters?

EDIT: FYI, the bundled in SRD works perfectly and isn't showing any problems described below. It's only when importing e.g. 5etools JSON MM (which obviously overrides some SRD).
First of all, I'm not a coder or anything so this might be a problem on my end, or just plain old user error.
The problem I'm seeing is the skills -line in a statblock doesn't seem to be working correctly. E.g. a goblin should have Stealth +6 listed in its statblock. However, imported and inserted goblin (5etools) doesn't have any skills listed at all (whole skills section is missing from the statblock, even though the data is actually present in the imported monster's data when browsing/editing it).
So in effect, the data is imported correctly into `obsidian-5e-statblocks\data.json´, but when using the code:
  statblock
monster: Goblin

to insert a goblin, the skills option is not visible/rendered.
After fooling around a while with imported Homebrew creatures, and looking at them with the edit function I found something that might be the culprit:
When I look an imported goblin I see this:
skillsaves:
  stealth: "6"

Or in JSON:
  "skillsaves": {
    "stealth": "6"
  },

However, if I change them to:
skillsaves:
  - stealth: "6"

or:
  "skillsaves": [
    {
      "stealth": "6"
    }
  ],

...it starts to work. So add one - to YAML and/or [ ] to JSON.
This seems to happen with all imported monsters, and after editing them as described above they start to work. Of course to get them working I'd have to go through each and every monster I've imported to see if a) they should have skills listed by cross referencing with the source, and b) fix them one by one with manual edits...
Also I've found an another problem:
Some monsters don't import all data on some specific fields, for example a Ghost. It's missing half of the resistances, even though they're listed in the JSON I'm trying to import.
"resist": [
				"acid",
				"fire",
				"lightning",
				"thunder",
				{
					"resist": [
						"bludgeoning",
						"piercing",
						"slashing"
					],
					"note": "from nonmagical attacks",
					"cond": true

In this case everything after "thunder", gets omitted. So the whole line: "; bludgeoning, piercing, and slashing from nonmagical attacks" doesn't get imported at all. In this case the problem is not just a display error like it was with the "skills problem" described above, but instead the data isn't imported at all (meaning it's also missing when browsing the imported monster through edit -functionality). Dunno if this is just some weird formatting 5e tools uses and thus is unfixable or something (something to do with "nested" stuff?).
Some other lines behaving like this, using the same ghost as an example, are:
Speed: is missing "(hover)" after normal speed information
Senses: is missing "passive Perception 11" after Darkvision 60 ft.
Also it seems 5etools is using some @tag stuff that isn't imported/ignored, and thus is causing some weird text to appear into some descriptions, but that's a minor thing (and easily fixable/noticeable when importing, as opposed to some game mechanic stuff just not being there at all). For example, a direct quote from imported Ghost:
> "The ghost can move through other creatures and objects as if they were {@quickref difficult terrain||3}"

Same problem noted.  Using 5etools import.  Problem importing http://5etools.quantumdm.cyou/bestiary.html#maegera the dawn titan_skt


unexpected output of the RLbench finetuned model

Thanks so much to the authors for open-sourcing this work.
I followed the instructions (RLbench's prediction script) to evaluate the released checkpoint (https://drive.google.com/drive/folders/1uwCIFQ20a4yk5yOE073d82gELjM7_QaS) on the RLBench task, and I got some chaotic outputs (the same problem as https://github.com/Dantong88/LLARVA/issues/4#issue-2613147400),
example #1 (this is a normal output that we expect):
task: sweep dirt to the short dustpan, step:0, outputs: The next action step: [0.0032, -0.0173, 0.0002, -0.0569, 0.0004, 0.0189, 0.0229, 1.0]
example #2:
task: sweep dirt to the short dustpan, step:1, outputs: 1,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,
Sincerely hope that the authors can help us verify this issue!

Hello, we never encounter the same issue when we do released test. According to our results, the ckpt should have stable output for this task. Not sure what happens, maybe you just install a latest version transformer etc, or there is some difference between your comversation template and the one we used to train the model. We are happy to give more comments if you provide more details :)


Spinal Tap Case Missing Parenthesis

Spinal Tap Case intermediate algorithm
https://www.freecodecamp.com/challenges/spinal-tap-case
Issue Description
3rd test case is missing a closing parenthesis.  This does not really affect my experience with the challenge too much I just felt like it is something that should be fixed and would be an easy fix.  I would be interested in doing it just for fun if possible
Browser Information
Google Chrome, Mac OSX Yosemite
Screenshot

@twmilli thanks for the issue. So I do see the same thing but if you zoom out, you can actually see the closing parentheses.

Related #8390.
cc/ @hallaathrad

Could we add a ''  somewhere in 'The_Andy_Griffith_Show'?

Oh hahaha forgot the escapes
A '<wbr>'


Refactor xds support notify

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Environment

Dubbo version: xxx
Operating System version: xxx
Java version: xxx

Steps to reproduce this issue

xxx
xxx
xxx

Pls. provide [GitHub address] to reproduce this issue.
Expected Behavior

Actual Behavior

If there is an exception, please attach the exception trace:
Just put your stack trace here!

I want to try, please assign to me : )

I want to try, please assign to me : )

done

Any update on this task?

Any update on this task?
In process : https://github.com/apache/dubbo/pull/10885/files


Vote plugin

https://github.com/errbotio/err-poll has a bug (https://github.com/errbotio/err-poll/issues/4), if the bug prevails try to find and fix it, or just write another one ;)

https://github.com/ersiko/err-meetingbot might be more useful

This will make gci more fun.


linux-35 lost external connection phone device.

Type of Request
bug
Infrastructure Environment
LUCI, Github, Cocoon scheduler, Autosubmit, etc...
What is happening?
linux-35 lost external connection phone device.

Steps to reproduce
Step 1:
Step 2:
..
Step n:
Expected results
I expect to see X when Y is finished.

Replacing new USB cable, the cable was bad.


get_openai_callback() does not count tokens when LCEL chain used with .stream() method

System Info
langchain==0.0.335
python==3.10

Who can help?
@agola11
Information

[ ] The official example notebooks/scripts
[X] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[X] Chains
[X] Callbacks/Tracing
[ ] Async

Reproduction
From the LCEL interface docs we have the following snippet:
from langchain.chat_models import ChatOpenAI
from langchain.prompts import ChatPromptTemplate

model = ChatOpenAI()
prompt = ChatPromptTemplate.from_template("tell me a joke about {topic}")
chain = prompt | model

for s in chain.stream({"topic": "bears"}):
    print(s.content, end="", flush=True)

From the token usage tracking docs we have the snippet
from langchain.callbacks import get_openai_callback
from langchain.chat_models import ChatOpenAI

llm = ChatOpenAI(model_name="gpt-4")

with get_openai_callback() as cb:
    result = llm.invoke("Tell me a joke")
    print(cb)

that yields the following output:
    Tokens Used: 24
        Prompt Tokens: 11
        Completion Tokens: 13
    Successful Requests: 1
    Total Cost (USD): $0.0011099999999999999

I am trying to combine the two concepts in the following snippet
from langchain.prompts import ChatPromptTemplate
from langchain.callbacks import get_openai_callback
from langchain.chat_models import ChatOpenAI

llm = ChatOpenAI(model_name="gpt-4")
prompt = ChatPromptTemplate.from_template("tell me a joke about {topic}")
chain = prompt | llm

with get_openai_callback() as cb:
    for s in chain.stream({"topic": "bears"}):
        print(s.content, end="", flush=True)
    print(cb)

but get the following result:
    Tokens Used: 0
        Prompt Tokens: 0
        Completion Tokens: 0
    Successful Requests: 0
    Total Cost (USD): $0

Is token counting (and pricing) while streaming not supported at the moment?
Expected behavior
The following but with the actual values for tokens and cost.
    Tokens Used: 0
        Prompt Tokens: 0
        Completion Tokens: 0
    Successful Requests: 0
    Total Cost (USD): $0

@dosu-bot None of those issues is relevant to the one I raised.

@orestxherija orestxherija  Were you able to figure out how to track the token usage? I am currently struggling with this issue.

the problem is ChatOpenAI() can not count token when streming so you have to count it yourself
https://github.com/langchain-ai/langchain/blob/22d90800c86799a3a385b73ba09608c9b6565e0a/libs/community/langchain_community/chat_models/openai.py#L607

the problem is ChatOpenAI() can not count token when streming so you have to count it yourself
https://github.com/langchain-ai/langchain/blob/22d90800c86799a3a385b73ba09608c9b6565e0a/libs/community/langchain_community/chat_models/openai.py#L607

Yep as @NguyenDrasp mentioned, OpenAI doesn't currently return token usage when streaming. We could try to add our own approximate token counting to handle this, feel free to open an Ideas Discussion item with this feature request if that'd be useful!
Closing issue, but let me know if I'm missing something and we can reopen.

the problem is ChatOpenAI() can not count token when streming so you have to count it yourself
https://github.com/langchain-ai/langchain/blob/22d90800c86799a3a385b73ba09608c9b6565e0a/libs/community/langchain_community/chat_models/openai.py#L607

Yep as @NguyenDrasp mentioned, OpenAI doesn't currently return token usage when streaming. We could try to add our own approximate token counting to handle this, feel free to open an Ideas Discussion item with this feature request if that'd be useful!
Closing issue, but let me know if I'm missing something and we can reopen.

@baskaryan Can we use agent_executor.astream_events method to count tokens?
If so, which events/what is the best way to count the Prompt tokens and Completion tokens when using an Agent with Tools and Memory?

The main issue is that token counts aren't provided by the OpenAI API when streaming, so the calculation needs to be carried out on the client side.
Once you know how to do the calculation, you can do it:
Using astream events get the 'on chat model end' event and tokenize to count the tokens.
Using invoke, batch, stream pass a custom callback that calculates tokens from the 'on chat model end' callback.
To calculate the tokens can probably use tiktoken, but I'd recommend checking OpenAI forums to see how folks estimate the number of tokens in the streaming response.

Thanks @eyurtsev - I've figured out how to use TikToken for my particular LLM to count the tokens based on the block of strings, but I still haven't figured out WHICH parts of the event on_chat_model_end need to be counted. (using .astream_event() )
I'm finding that my Token count result is very different to the Total Token count in LangSmith traces by a large margin (up to 100s of tokens); so I must be counting the wrong things OR is the LangSmith Token count incorrect sometimes??
Ultimate objective is to know what OpenAI will be charging me.
Can you please tell me which parts of what events I should be using my TokenCounter to count?
And also, which parts are "Prompt" tokens and which are "Completion" tokens?
(I'm guessing in OpenAI terms Prompt = Input token cost, and
Completion = Output token cost, right?)

@hgoona and others - you can see a worked example of recreating the llm_info in this PR. I am using kwargs info, so it may be a bit fragile, but it's working for us. https://github.com/fablestudio/fable-saga/pull/55


Handling  Next localization with next.config.js

Is there a workaround for handling locales? I get 404 when trying to get to the blog with a locale.
http://localhost:3000/blog/post-slug will return the post correctly but http://localhost:3000/es-MX/blog/post-slug will return 404.
I don't mind if it returns the same content, I just want the post to be rendered as the same if the url has the locale.

I can access the post by building the url myself, using the slug directly as <Link href={/blog/${slug}} /> however, if I access this url with the locale, it would return this error:
NotFoundError: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.

So I guess my only option is to use another way to use the md files


Jt day 1

@Drew-Fisher That text file isn't used by my solution. I just wanted to have a link to the location of the puzzle for each day for easier reference. I can possibly turn it into an MD file if you'd like though and then it can be rendered with the link in GitHub when people are looking through the repo.

sorry I was not fully awake when I did the review I'll merge it.


AzureFileCopy@4 requires access to the storage account key, despite documentation stating otherwise.

Required Information
Type: Bug
Enter Task Name: AzureFileCopy@4
Environment

Azure Pipelines

Agent - Hosted :

Agent name: 'Azure Pipelines 3'
Current agent version: '2.195.2'
##[group]Operating System
Microsoft Windows Server 2016

Issue Description
In the official documentation of the Azure File Copy Task it is said that

The task supports authentication based on Azure Active Directory. Authentication using a service principal and managed identity are available. For managed identities, only system-wide managed identity is supported.

In the readme of the task AzureFileCopyV4, it is said that

As this version of task uses AzCopy 10, service principal needs to have one of these Storage Blob Data Contributor or Storage Blob Data Owner roles assigned to access resources.

I have set up a service principal and given it the Storage Blob Data Contributor role on a storage account.
When I run the pipeline, I get the following error :
2021-12-15T15:14:09.3656926Z ##[error]ExceptionMessage: The client '<REDACTED_OBJECT_ID>' with object id '<REDACTED_OBJECT_ID>' does not have authorization to perform action 'Microsoft.Storage/storageAccounts/listKeys/action' over scope '/subscriptions/<REDACTED_SUBSCRIPTION_ID>/resourceGroups/<REDACTED_RESOURCE_GROUP_NAME>/providers/Microsoft.Storage/storageAccounts/<redacted_storage_account_name>' or the scope is invalid. If access was recently granted, please refresh your credentials. (in function: Get-AzRMStorageKeys)

If we look at the task's code, we clearly see that the function Get-AzRMStorageKeys is called by the function Get-AzureStorageKeyFromARM, which is called in the middle of the file AzureFileCopy.ps1, without any particular logic to prevent calling it.
https://github.com/microsoft/azure-pipelines-tasks/blob/acc64cc7292c98597908325e53af9f898a896189/Tasks/AzureFileCopyV4/AzureFileCopy.ps1#L103-L104
This means that, contrary to what the documentation seems to indicate, this pipeline task always requires the storage account key to connect to the storage account, instead of using only the Storage Blob Data Contributor which should be enough for az-copy.
Expected behavior
Authentication to a storage account using a storage account key is deprecated and should be replaced with Azure AD authentication, using the Storage Blob Data Contributor role. AzureFileCopy should support this more secure authentication method to upload files to a blob container. Or at least the documentation should not claim it does.
Extra information
This subject has already been brought up by another user on the developer community forum, without any real solution provided aside from "use Azure CLI task instead".

@FurcyPin  Could you please assign "Storage Blob Data Owner"  role and confirm on same.
Thank you.

@v-saikumart
I just tried it, and I confirm that I get the same error, which is normal, as the role "Storage Blob Data Owner" does not inherit the right 'Microsoft.Storage/storageAccounts/listKeys/action' either.

Hi @FurcyPin
I believe that you have followed below steps.
i. Go to Service connections screen.
ii. Click Manage Service Principal which will redirect you to the Application Registration of the Service Principal. Copy the name.
iii. Go back and click Manage service connection roles which will redirect you to the IAM blade of the Azure Subscription. Here you need to assign a role to the service principal(Storage Blob Data Owner). Use name copied in previous step to search service principal.
Thank you.

Hi @v-saikumart
Yes, I followed these steps. I also checked afterwards that the role was correctly set.
But as I said, the role Storage Blob Data Owner does not grant the right 'Microsoft.Storage/storageAccounts/listKeys/action',
which AzureFileCopy@4 tries to use.

@FurcyPin  Could you please share full logs by keeping system.debug = true in pipeline.
Thank you.

@v-saikumart There you go: https://gist.github.com/FurcyPin/bc2f93faa1e6791b85ee3e0888111a75

@FurcyPin Thank you for the full logs.
As per the below mentioned logs, could you please verify Client secrets validity for SPN and confirm on same, as we have verified the task from our side and it is working as expected.

Hi @v-saikumart could you please be more specific ?
Let me summarize again:

If I give the role Storage Blob Data Contributor and Storage Blob Data Owner to the service principal it fails with an error saying that it does not have authorization to perform action Microsoft.Storage/storageAccounts/listKeys/action.
If I give the role Contributor or Owner to the service principal it does work.

What do you mean exactly by "working as expected" ?
Are you implying either one of these two statements ?
A. The role Storage Blob Data Owner should be giving the authorization Microsoft.Storage/storageAccounts/listKeys/action to the service principal.
B. AzureBlobCopy@4's expected behaviour is to always require the authorization Microsoft.Storage/storageAccounts/listKeys/action.

Hi @FurcyPin
A. Service principal needs to have  "Storage Blob Data Owner" role assigned to access resources, in this case we are able to run the task successfully.
B. Could you please verify Client secrets validity for SPN and below mentioned API alone.
https://management.azure.com//subscriptions//<REDACTED_SUBSCRIPTION_ID>/resourceGroups/<REDACTED_RESOURCE_GROUP_NAME>/providers/Microsoft.Storage/storageAccounts/<redacted_storage_account_name>/listKeys?api-version=2015-06-15
Thank you.

Hi @v-saikumart
A. As I mentioned in the initial post, the documentation says that the service principal needs to have one of Storage Blob Data Contributor or Storage Blob Data Owner. Is the documentation wrong, then ?
Nevertheless I tried once again, and I confirm that this works :

While this does not (same error as before) :

(I hid the service principal name for security reasons, but please trust me on this, it is the same one for all three roles, and it is the one that I am using in the pipeline)
I will try again tomorrow in case the right propagation took time to complete.
B. I'd love to verify "Client secrets validity for SPN and below mentioned API alone.", but I have no idea of how to do this. Please provide a detailed how-to procedure.
C. I still fail to see why you think that giving the ["Storage Blob Data Owner"] will solve things, it does not give the Microsoft.Storage/storageAccounts/listKeys/action authorization. It would help me greatly if you could explain with more details why you think this is supposed to work.
D. Alternatively, if you are trying to reproduce the issue on your side and it indeed works well with the role "Storage Blob Data Owner", could you please try to prevent authorization with shared access key on your storage account and confirm it still work on your side ?
Thanks.

Hi @FurcyPin
We need to provide "Contributor" or "Owner" and "Storage Blob Data Owner" then it does work. We will update the
readme of the task AzureFileCopyV4.
Thank you.

Hi @v-saikumart
Thanks for your answer. In that case I believe that the "Contributor" or "Owner" role alone should suffice, as the Shared Access Key grants full rights on the whole storage account.
This is the reason why I would like to be able to disable it. Should I create another issue as Feature Request to ask for the compatibility of AzureFileCopy with storage accounts with disabled shared access key ?
Regards

Hi @FurcyPin
Along with "Contributor" or "Owner" role, we need to have "Storage Blob Data Owner" role as well.
Thank you.

Hi @v-saikumart, thanks for your answer.
I might get this wrong, but from what I can see in the code, it looks like AzureFileCopy@4 behaves differently depending on whether it is writing on the blob or on the a VM.
While the block that copies on a VM seems to use AzureFileCopyRemoteJob, which does call azcopy, it looks like the block that performs the copy to blobs does not use it at all, but use the Write-Host command instead.
https://github.com/microsoft/azure-pipelines-tasks/blob/acc64cc7292c98597908325e53af9f898a896189/Tasks/AzureFileCopyV4/AzureFileCopy.ps1#L192-L207
Moreover, it looks like the Shared Access Key is mostly used to create the container if it does not exists.
https://github.com/microsoft/azure-pipelines-tasks/blob/acc64cc7292c98597908325e53af9f898a896189/Tasks/AzureFileCopyV4/AzureFileCopy.ps1#L126-L134
Again, this behavior is problematic, as it should be settable with an option "createContainerIfNotExists".
For instance, if I create a configuration container and make a typo when deploying to this container, I want the task to fail, not silently create another container (this exact scenario actually happened to me once and caused a production issue that would have been avoided had that option be set to False).

Any updates regarding timeline for the fix?

@ehanlon, Using AzureFileCopy@3 until AzureFileCopy@4 is fixed seems to be a workaround.

We've disabled key authentication and receive ##[error]Key based authentication is not permitted on this storage account. when trying to use an account with Storage Blob Data Contributor access rights.

Is there somenone working on the issue ?
If the StorageAccount is configured with allowSharedKeyAccess set to false, the task fails and still try to use the Storage Key to check if the container exists and try to create it.
So any updates regarding a timeline for a fix will be appreciate.

This is also an issue for me. I'm wanting just to have RBAC permissions assigned to the service connections' service principal, while having the "Allow storage account key access" configuration setting in the storage account disabled. I don't want to have access keys floating around.
Any updates on this?

I had come across this one as well and have raised with Microsoft as mentioned and worked on a work around utilising azure storage upload-batch as In https://learn.microsoft.com/en-us/cli/azure/storage/blob?view=azure-cli-latest#az-storage-blob-upload-batch
Command : az storage blob upload-batch -d '$(ContainerName)' -s $sourceDirectory --account-name $storageAccountName --auth-mode login in
AzureCLI@2 task Script type as 'ps'
Hope this helps

a bug for us too. we disable keys on storage accounts whenever possible. the task should be using Azure AD auth only, but it obviously does not since it errors out with "Key based authentication is not permitted on this storage account"

We are also experiencing the same bug. Shared key access is disallowed by policy so if we set it to false we get the error "Key based authentication is not permitted on this storage account"

@nadesu and @v-saikumart any updates on this please?

Same issue here, key disabled so no SAS meaning task has to use MS Entra but it doesn't so I get the error message "Key based authentication is not permitted on this storage account."
I'm using below syntax,
  - task: AzureFileCopy@5
    name: CopyTask
    displayName: 'Copy deployment artifacts to the storage account'
    inputs:
      sourcePath: '$(Pipeline.Workspace)/upload'
      azureSubscription: '${{ parameters.rg_name }}'
      destination: AzureBlob
      storage: ${{ parameters.storage_account_name }}
      containerName: ${{ parameters.container_name }}
      cleanTargetBeforeCopy: true

It has come to my attention that AzureFileCopy@6 is released.
We're successfully using that one now with Managed Identity and disabled Access Keys.
Perhaps this issue can be closed (as v6 would probably solve the problem reported here).
Ref: https://github.com/microsoft/azure-pipelines-tasks/releases/tag/v237


Client disconnects when trying to subscribe

Everytime i try to subscribe to a topic (any topic) it disconnects my client.
No error is thrown from what I observed from debugging.

Are you trying this behind a firewall ?. Does the x509 certificates have required IAM policies to connect, subscribe and publish to the IOT MQTT Topics ?

Everytime i try to subscribe to a topic (any topic) it disconnects my client.
No error is thrown from what I observed from debugging.

closed


Document lazy nature of acir generation when defining unused variables

Problem
Consider the following program:
fn main(x : Field, y : Field) {
    let z = x + x;
}

This program will not produce any opcodes.
Explanation
SSA IR
After optimizations the SSA IR will look like:
fn main f1 {
  b0(v0: Field, v1: Field):
    v2 = add v0, v0
    return unit 0
}

ACIR Generation
First observe that z which is v2 in the SSA IR is never used, so this is not a soundness concern.
In ACIR Gen, the binary addition is seen and since we can express an addition of two field elements in a single expression, the expression is stored in memory in an AcirVar.
Discussion
The main problem is that
fn main(x : Field, y : Field) {
    let z = x + x;
}

and
fn main(x : Field, y : Field) {
}

are seen as equivalent, when technically they are not; the first program with the binary operation is failable if the value of z at proving time does not equal two times the value of x.  The second program is infallible since there are no constraints at all.
Why is this okay?
Programs like this are only possible during debugging. If a user does not allow unused variables, then the compiler will not compile the circuit. I expect that the CI will be set to catch errors like this.

Also noting that after we add Dead Instruction Elimination (DIE) to our SSA passes the final SSA will be even more succinct:
fn main f1 {
  b0(v0: Field, v1: Field):
    return unit 0
}

Does this obviate the need for lazy acir generation entirely?


Add getMinFeeTxFixed function to EraTx

Issue Link : https://github.com/input-output-hk/cardano-ledger/issues/3181.

@lehins

First of all it should not be getMinFeeTxFixed, but instead setMinFeeTxOut, since setting the fee changes the size.

well by naming getMinFeeTxFixed I was trying to infer that the  returned value  of minFee is calculated in such a way that after updating the transaction with it, the getMinFeeTx pp newTx will return the same fee value.
I agree that the most straightforward solution is to add setMinFeeTx to Cardano.Ledger.Api.Tx, with something like this.
setMinFeeTx :: EraTx era => PParams era -> Tx era -> Tx era
setMinFeeTx pp  = go
  where
    go tx =
      let curMinFee = getMinFeeTx pp tx
          curFee =  tx ^. bodyTxL ^. feeTxBodyL
          modifiedTx = tx &  bodyTxL . feeTxBodyL .~ curMinFee
       in if curFee == curMinFee
            then tx
            else go  modifiedTx

The reason  I didn't  go with this approach is because getMinFeeTx  is called multiple times when implementing it like this. getMinFeeTx at least in alonzo era requires sizeTxF and sizeTxF is basically LBS.length $ serializeEncoding $ toCBOR $ tx.
This means we are re-serializing the entire tx multiple times (at least 3 times if we start with 0 txFee).
in, Current PR, I solve this issue of re-serializing transaction multiple times by serializing tx once and instead serializing fee multiple times.
Note that the change is transaction size is only due to change of serialized size of fee value. For this getMinFeeTxFixed had to access the internal details of feeCalculation and it ended up becoming era dependent.
If You think that re-serializing the transaction is not an issue, I can update the PR and implement simpler setMinFeeTx.

For Reference : CBOR serialization size of coin, and value of txMinFee
Fee  and   minFeeTx  for a dummy transaction with mainnet PParams.
initial Fee,  CBOR length of `Coin` (Bytes), minFeeTx
0 Lovelace      -> CoinSize: 1,  minFeeTx: 165061
2 Lovelace      -> CoinSize: 1,  minFeeTx: 165061
4 Lovelace      -> CoinSize: 1,  minFeeTx: 165061
8 Lovelace      -> CoinSize: 1,  minFeeTx: 165061
16 Lovelace     -> CoinSize: 1,  minFeeTx: 165061
32 Lovelace     -> CoinSize: 2,  minFeeTx: 165105
64 Lovelace     -> CoinSize: 2,  minFeeTx: 165105
128 Lovelace    -> CoinSize: 2,  minFeeTx: 165105
256 Lovelace    -> CoinSize: 3,  minFeeTx: 165149
512 Lovelace    -> CoinSize: 3,  minFeeTx: 165149
1024 Lovelace   -> CoinSize: 3,  minFeeTx: 165149
2048 Lovelace   -> CoinSize: 3,  minFeeTx: 165149
4096 Lovelace   -> CoinSize: 3,  minFeeTx: 165149
8192 Lovelace   -> CoinSize: 3,  minFeeTx: 165149
16384 Lovelace  -> CoinSize: 3,  minFeeTx: 165149
32768 Lovelace  -> CoinSize: 3,  minFeeTx: 165149
65536 Lovelace  -> CoinSize: 5,  minFeeTx: 165237
131072 Lovelace         -> CoinSize: 5,  minFeeTx: 165237
262144 Lovelace         -> CoinSize: 5,  minFeeTx: 165237
524288 Lovelace         -> CoinSize: 5,  minFeeTx: 165237
1048576 Lovelace        -> CoinSize: 5,  minFeeTx: 165237
2097152 Lovelace        -> CoinSize: 5,  minFeeTx: 165237
4194304 Lovelace        -> CoinSize: 5,  minFeeTx: 165237
8388608 Lovelace        -> CoinSize: 5,  minFeeTx: 165237
16777216 Lovelace       -> CoinSize: 5,  minFeeTx: 165237
33554432 Lovelace       -> CoinSize: 5,  minFeeTx: 165237
67108864 Lovelace       -> CoinSize: 5,  minFeeTx: 165237
134217728 Lovelace      -> CoinSize: 5,  minFeeTx: 165237
268435456 Lovelace      -> CoinSize: 5,  minFeeTx: 165237
536870912 Lovelace      -> CoinSize: 5,  minFeeTx: 165237
1073741824 Lovelace     -> CoinSize: 5,  minFeeTx: 165237
2147483648 Lovelace     -> CoinSize: 5,  minFeeTx: 165237
4294967296 Lovelace     -> CoinSize: 9,  minFeeTx: 165413
8589934592 Lovelace     -> CoinSize: 9,  minFeeTx: 165413
17179869184 Lovelace    -> CoinSize: 9,  minFeeTx: 165413
34359738368 Lovelace    -> CoinSize: 9,  minFeeTx: 165413
68719476736 Lovelace    -> CoinSize: 9,  minFeeTx: 165413
137438953472 Lovelace   -> CoinSize: 9,  minFeeTx: 165413
274877906944 Lovelace   -> CoinSize: 9,  minFeeTx: 165413
549755813888 Lovelace   -> CoinSize: 9,  minFeeTx: 165413
1099511627776 Lovelace  -> CoinSize: 9,  minFeeTx: 165413
2199023255552 Lovelace  -> CoinSize: 9,  minFeeTx: 165413
4398046511104 Lovelace  -> CoinSize: 9,  minFeeTx: 165413
8796093022208 Lovelace  -> CoinSize: 9,  minFeeTx: 165413
17592186044416 Lovelace         -> CoinSize: 9,  minFeeTx: 165413
35184372088832 Lovelace         -> CoinSize: 9,  minFeeTx: 165413
70368744177664 Lovelace         -> CoinSize: 9,  minFeeTx: 165413
140737488355328 Lovelace        -> CoinSize: 9,  minFeeTx: 165413
281474976710656 Lovelace        -> CoinSize: 9,  minFeeTx: 165413
562949953421312 Lovelace        -> CoinSize: 9,  minFeeTx: 165413
1125899906842624 Lovelace       -> CoinSize: 9,  minFeeTx: 165413
2251799813685248 Lovelace       -> CoinSize: 9,  minFeeTx: 165413
4503599627370496 Lovelace       -> CoinSize: 9,  minFeeTx: 165413
9007199254740992 Lovelace       -> CoinSize: 9,  minFeeTx: 165413
18014398509481984 Lovelace      -> CoinSize: 9,  minFeeTx: 165413
36028797018963968 Lovelace      -> CoinSize: 9,  minFeeTx: 165413
72057594037927936 Lovelace      -> CoinSize: 9,  minFeeTx: 165413
144115188075855872 Lovelace     -> CoinSize: 9,  minFeeTx: 165413
288230376151711744 Lovelace     -> CoinSize: 9,  minFeeTx: 165413
576460752303423488 Lovelace     -> CoinSize: 9,  minFeeTx: 165413
1152921504606846976 Lovelace    -> CoinSize: 9,  minFeeTx: 165413
2305843009213693952 Lovelace    -> CoinSize: 9,  minFeeTx: 165413
4611686018427387904 Lovelace    -> CoinSize: 9,  minFeeTx: 165413
9223372036854775808 Lovelace    -> CoinSize: 9,  minFeeTx: 165413

If You think that re-serializing the transaction is not an issue

I am pretty sure reserializing the transaction is not an issue. Especially since the fixed point is reached quite quickly. MOreover, it  is the most correct and the most general approach.

I've updated PR according to the discussion.


How to connected to target cluster via pegasus shell config

General Question
I have read the documentation, but can not found the way that use ./run.sh shell --config my_config.ini to connected to my target cluster. In other word, I don't know how to config it.
I tried to use the config file named my_cluster.cfg which I used to deployed cluster. But it not work,with the error like this:
W2024-08-30 11:17:43.874<PHONE_NUMBER>874826365 42119) : overwrite default thread pool for task RPC_CM_QUERY_PARTITION_CONFIG_BY_INDEX_ACK from THREAD_POOL_META_SERVER to THREAD_POOL_DEFAULT
Pegasus Shell 2.4.5-without-slog
Type "help" for more information.
Type "Ctrl-D" or "Ctrl-C" to exit the shell.

cannot find factory '' with factory type provider
        the following 2 factories are registered:
                nativerun (type: provider)
                simulator (type: provider)
        Please specify the correct factory name in your tool_app or in configuration file
got signal id: 11
./run.sh: line 1724: 42119 Segmentation fault      ./pegasus_shell ${CONFIG} $CLUSTER_NAM

And I read the code , I think we should get the section named[meta] to get meta list , I just konw how to write the xxxx.ini file

I also copy the config.ini file in CONFIG=${ROOT}/config-shell.ini.$PID
file like this:
[apps..default]
run = true
count = 1

[apps.mimic]
type = dsn.app.mimic
arguments =
pools = THREAD_POOL_DEFAULT,THREAD_POOL_META_SERVER
run = true
count = 1

[core]
tool = nativerun
pause_on_start = false

logging_start_level = LOG_LEVEL_DEBUG
logging_factory_name = dsn::tools::simple_logger
logging_flush_on_exit = false

enable_default_app_mimic = true

data_dir = ./pegasus_shell.data

[tools.simple_logger]
short_header = false
fast_flush = true
max_number_of_log_files_on_disk = 10
stderr_start_level = LOG_LEVEL_FATAL

[tools.simulator]
random_seed = 0

[network]
io_service_worker_count = 4

[threadpool..default]
worker_count = 4
partitioned = false
worker_priority = THREAD_xPRIORITY_NORMAL

[threadpool.THREAD_POOL_DEFAULT]
name = default
worker_count = 20

[threadpool.THREAD_POOL_META_SERVER]
name = meta_server

[task..default]
is_trace = false
is_profile = false
allow_inline = false
rpc_call_header_format = NET_HDR_DSN
rpc_call_channel = RPC_CHANNEL_TCP
rpc_timeout_milliseconds = 10000

[pegasus.clusters]
my_cluster = ip:port,ip2:port

[security]
  enable_auth = true
  krb5_keytab = /home/work/pegasus/xxxxx.keytab
  krb5_config = /etc/krb5.conf
  krb5_principal =<EMAIL_ADDRESS>  sasl_plugin_path = /home/work/pegasus/thirdparty/output/lib/sasl2
  service_fqdn = my_cluster_master_meta_host_name
  service_name = my_cluster

It worked,
But pegasus-shell connected to onebox, I am so confused ， because I think I configed meta-list in [pegasus.clusters].
During my operation, the output of the shell is as follows
[root@xxxxxx pegasus]# ./run.sh shell --config ker.ini
W2024-08-30 11:41:19.453<PHONE_NUMBER>453708642 42130) : overwrite default thread pool for task RPC_CM_QUERY_PARTITION_CONFIG_BY_INDEX from THREAD_POOL_META_SERVER to THREAD_POOL_DEFAULT
W2024-08-30 11:41:19.453<PHONE_NUMBER>453808438 42130) : overwrite default thread pool for task RPC_CM_QUERY_PARTITION_CONFIG_BY_INDEX_ACK from THREAD_POOL_META_SERVER to THREAD_POOL_DEFAULT
Pegasus Shell 2.4.5-without-slog
Type "help" for more information.
Type "Ctrl-D" or "Ctrl-C" to exit the shell.

The config file is: ker.ini
The cluster name is: onebox
The cluster meta list is:
>>> ls
list apps failed, error=ERR_TIMEOUT
>>>

When I change the file src/shell/main.cpp and  run.sh (I want to make pegasus shell connected to target cluster forcely).
Executing any command will time out.

If I'm not change the file , pegasus shell will be never connected to target cluster and always connected to onebox cluster.


Drop-in file systemd configuration

Pull Request (PR) description
Currently the Systemd drop-in file can only override environment variables.
I would like to expand this functionality to make it possible to override every configuration in the [Service] section of the drop-in file.
This Pull Request (PR) fixes the following issues
Fixes #1009

Please rebase. I just merged https://github.com/voxpupuli/puppet-jenkins/pull/1041 which means the tests should be green.


✨feat(zerolog): add MultiLevelWriter

What type of PR is this?

feat: add zerolog.MultiLevelWriter
What this PR does / why we need it (English/Chinese):

Support zerolog.MultiLevelWriter
Which issue(s) this PR fixes:
Fixes #17

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM


Mobile Responsiveness - Definitions Page

URL: https://uno-cpi-sta.herokuapp.com/definitions
Issue 1: Do we still plan to utilize this URL for the final deliverable?
Issue 2: This page does not appear to be formatted like the other pages on the application. If we keep it, would like to update formatting and rename to ‘Terminology’ instead of ‘Terminologies’.

@Jantz021991 Can we delete this page?

@jerrodanzalone  I will delete this page. This was based on the initial thought of having Data definition page in one which was eventually changed to what it is now 📦

@caadler as QA tester

this page has been deleted so no more work is needed on this ticket.


const XXX_{up,down}_ref ?

As dicussed in #13788, OpenSSL sometimes uses const in its API, but then casts it away internally.  The const indicates that the it's logically constant.
The project should consider making the object pointers in all the up_ref/down_ref function be const and then internally cast it away.  See X509_cmp() for an example.

The proposal as I read it here is to alter, for example:
int EVP_MD_up_ref(EVP_MD *md)

Such that it is defined as:
int EVP_MD_up_ref(const EVP_MD *md)

Is that correct?  I can't  argue that EVP_MD being const here is valid, I'm just not sure I see the value in light of the ABI breakage this introduces.
I agree that it creates a visual cue that indicates to the developer that the EVP_MD pointer in the example above isn't altered, and so might be considered thread safe, but its inclusion certainly isn't definitive
Can you elaborate more on what the value of this change is, to better evaluate it against the abi change impact?
FWIW, We have recently made a proposed coding style change, to being documenting functions using doxygen: https://github.com/openssl/technical-policies/pull/94
it might be reasonable alternate solution to this problem, as we add doxygen comments to add notes about thread safety to them.  That would obviate the need to change the ABI, and just assert that they are in fact thread safe

do whatever you want.


Add missing const attribute to asn1 api

Partially implements #4033, where possible - add const attribute to asn1 api functions' parameters (in scope of 3.0 release).
Status
READY

The CI is passing except for the ABI-API check which fails exactly as expected, so I'm removing the label "needs: ci".


SS-1070 update permissions handling

Description

Change default app permission level to project in all apps
Rename Note on link only privacy label in the custom, dash and shiny forms to Reason for choosing the link only option
Make sourceCodeDiv stop disappearing when choosing anything other than public access
Add info about link only access to info toggle

Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

[x] This pull request is against develop branch (not applicable for hotfixes)
[x] I have included a link to the issue on GitHub or JIRA (if any)
[x] I have included migration files (if there are changes to the model classes)
[ ] I have included, reviewed and executed tests (unit and end2end) to complement my changes
[ ] I have updated the related documentation (if necessary)
[x] I have added a reviewer for this pull request
[x] I have added myself as an author for this pull request
[ ] In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

Further comments
Anything else you think we should know before merging your code!

Seems to be okay and working.


[8.0.0] Coding standards, run PHP_CodeSniffer on Travis

Add Roots coding standards based on PSR-2
Add PHPCS to Travis
Update PHP files to pass coding standards

Closes #1176

lol


SystemTextJsonSerializer.Serialize ignores SerializationFormatting

Elastic.Clients.Elasticsearch version: 8.11.0
Elasticsearch version: -
.NET runtime version: 8.0.100
Operating system version: -
Description of the problem including expected versus actual behavior:
Unlike SerializeAsync<T>, Serialize<T> creates a new Utf8JsonWriter, which has its own JsonWriterOptions, which ignore JsonSerializerOptions. If SerializationFormatting.Indented, JsonWriterOptions still defaults to Indented = false.
Steps to reproduce:

Call DefaultSourceSerializer.Serialize<T> with SerializationFormatting.Indented
See that JSON is in single line

Expected behavior
JSON formatting follows specified SerializationFormatting.

Thanks for reporting!
Seems like we forgot to pass custom JsonWriterOptions to the Utf8JsonWriter constructor.