👌 IMPROVE:  Use gulp downloaded with npm

Description
Calling node ./node_modules/gulp/bin/gulp.js rather than just gulp in the scripts section of package.json runs the copy of gulp downloaded with npm rather than the user's globally installed version of gulp. This ensures the version of gulp run matches the version in package.json (e.g. a user could have gulp 3.x installed globally) and doesn't require users to install gulp globally.
Types of changes
Update the scripts section of package.json to call node ./node_modules/gulp/bin/gulp.js instead of gulp.
How Has This Been Tested?
I tested all script commands in package.json after the change.
Checklist:

[x] My code is tested.
[x] My code follows the WordPress code style.
[x] My code follows has extensive inline documentation like the rest of WPGulp.

I think that this PR is superficial and not required. When calling gulp from within an npm run-script what happens is that your local package install's bin path that you can find via echo $(npm bin) i.e. your_project/node_modules/.bin folder has the locally installed version of gulp as specified in the package.json file of WPGulp. That gets added to your PATH variable before the command is run, so we always end up using the local gulp version.
You can confirm this here: https://docs.npmjs.com/cli/run-script
In addition to the shell's pre-existing PATH, npm run adds node_modules/.bin to the PATH provided to scripts. Any binaries provided by locally-installed dependencies can be used without the node_modules/.bin prefix. For example, if there is a devDependency on tap in your package, you should write:

Since the installer is provided by WPGulp, and installer always installs the npm install packages we always end up with a local gulp bin path that gets executed.
If not let me know how :)
Looking forward!

Thanks for the link to the doc - I wasn't aware run-script added items to PATH automatically.


pre-commit hook?

Is there still a way to run terrascan with pre-commit? I noticed there was mention of an example .pre-commit-config.yaml in older docs but it's no longer mentioned anywhere now.

Hi @sosimon,
This is something that needs to be worked on The way the original .pre-commit-config.yaml file was written didn't work with v1.0.0 of Terrascan, so we had to remove it for now.

Submitted https://github.com/antonbabenko/pre-commit-terraform/pull/195 to address this for Terraform and planning on doing something similar in this repo to support all other IaC providers.

Closed via #953


Review ReportStream Research

Task 1-1: Review existing user research, including in reference to the CDC ReportStream solution for lab data routing (https://reportstream.cdc.gov/);

Review existing user research, including in reference to the CDC ReportStream solution for lab data  routing (https://reportstream.cdc.gov/)

Document how

Need to determine how best to integrate with existing ReportStream
Important to re-use existing connections (e.g. Hospitals, STLTs)


Issue/1 createdatabase

Checklist

[X] I have read the Contributing Guide
[X] I have checked to ensure this does not introduce an unintended breaking changes
[X] I have considered appropriate testing for my change

Description
EnsureDatabase and DropDatabase fuctionality implemented for Firebird

@droyad  Thank you for merging the other PR's. I guess the same will happen here when you have reviewed it :)

FYI the approval files should pop up a diff tool if they don't match which allows you to update them. Let me know if you that doesn't happen for you.


rmw_implementation: 0.8.2-1 in 'dashing/distribution.yaml' [bloom]

Increasing version of package(s) in repository rmw_implementation to 0.8.2-1:

upstream repository: https://github.com/ros2/rmw_implementation.git
release repository: https://github.com/ros2-gbp/rmw_implementation-release.git
distro file: dashing/distribution.yaml
bloom version: 0.9.0
previous version for package: 0.7.1-2

rmw_implementation
* Add support for Cyclone DDS. (#71 <https://github.com/ros2/rmw_implementation/issues/71>)
* Contributors: Ruffin

This release was made from the wrong devel branch.


Ordered & Timed Stage Actions

What's Changed

Stage actions can be ordered and timed. Users can select different stage actions through a modal. You can't yet add duplicate stage actions.
Some major refactoring of the CSS to be more modular.

What's next

Probably start tackling some more low hanging fruit, they just seem to keep on ripening.

Coverage increased (+0.0%) to 99.94% when pulling f95462cd2b4f189f2a07511d854a580876feb9e1 on simonv3:rory-stage-actions into 19fbe346e33c1f1c9bc5ecabf57e4afc9159a434 on openfarmcc:master.

Coverage increased (+0.0%) to 99.94% when pulling 87a9c33b6b946302dc1d53cc03c878f636e6a096 on simonv3:rory-stage-actions into 19fbe346e33c1f1c9bc5ecabf57e4afc9159a434 on openfarmcc:master.

Coverage increased (+0.0%) to 99.94% when pulling 87a9c33b6b946302dc1d53cc03c878f636e6a096 on simonv3:rory-stage-actions into 19fbe346e33c1f1c9bc5ecabf57e4afc9159a434 on openfarmcc:master.

Coverage increased (+0.0%) to 99.94% when pulling 7606400da0a868bc23869cbeb67040b9582384c0 on simonv3:rory-stage-actions into 739fe3ed42cff34a80257d23f9895d6356e1068e on openfarmcc:master.


Updating readme from branch example

Updates
I updated the readme.file Please review and accept.

Thoughts
I probably shouldn't, but okay  👍


Import obi dialgos

Mostly nits and some questions.  Looks like I was too late to catch you before the merge.

:tada: This PR is included in version 0.378.2 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Striaght up just does not work on 1.19.2

Doesn't show any preview of where blocks will be placed and won't place any blocks.
Only works in creative mode.

I have tested the mod with Minecraft 1.19.2 and it works as intended.
Could you provide me with additional information (exact versions of MC and Forge)?

I get the exact same thing.  Can get to the config screen but it just won't do anything.
All The Mods 8 v10, forge version 43.2.3

I have just tested the wand in ATM8 and it works normally. Do you have the required blocks in your inventory?


Refactor - Wraps SyscallRegistry in std::sync::Arc

Codecov Report

Merging #413 (127913f) into main (bc97474) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   90.11%   90.09%   -0.02%
==========================================
  Files          23       23
  Lines        9326     9330       +4
==========================================
+ Hits         8404     8406       +2
- Misses        922      924       +2

Impacted Files
Coverage Δ

src/elf.rs
91.88% <70.00%> (-0.11%)
:arrow_down:

src/assembler.rs
99.60% <100.00%> (ø)

src/jit.rs
93.07% <100.00%> (ø)

src/vm.rs
68.66% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


config page redux

[x] Implement config page with redux
[x] Address feedback
[x] Tests
[x] Squash/rebase

If this looks ok from a design/architectural perspective I will add tests/squash and wrap this up.

Thanks, nice work so far, I left some minor comments :)

This is ready to rebase/squash and ship. Any other feedback before I force push this branch?

Great work! go ahead and squash everything :)

:shipit:

@suisha seems there are merge conflicts after your squash, could you check please?

squashed again

Let's do this!


Update solana.tokenlist.json to remove imposter

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

@keone
greetings my friend,
you helped us before with an important request for our project and we really appreciate it.
CoinGecko has recently helped us out as well by removing the imposter coin from CoinGecko and placing us in their spot, as was necessary.
Now there is a problem. The imposter Dogelana, "Dogelana Token" "DLANA", has our CoinGecko ID listed under their token.
This is completely incorrect and actually is dangerous because on Birdeye and other Solana Explorers, it thinks that their price is our price. Which is wrong.
Can you please remove our unique CoinGecko ID from this fake scam project who tried to steal our project?


[PREGEL] Delete workers only via garbage collection

PREGEL_RESULT can be used in AQL to get result from a finished Pregel
run. For this to work, the conductor and workers of this Pregel run
still need to exist. A garbadge collection exists for Pregel which
runs every 20 seconds and only deletes Pregel runs (conductor and
workers) if their TTL is exceeded.
Bug: Directly after the Pregel run finished, its workers were deleted
without checking the TTL. This PR changes that such that only the garbage
collection deletes workers.

It's a feature, not a bug!


Visio shape detector not working for very simple diagrams

Seems to be broken on IE9

Moved visio processing to serverside allowing usage of namespace aware xml processing.


jdbc potential memory leak

Describe the bug
Using a yourkit to capture memory used by java application that uses thousands of prepared statements and non prepared statements to sqlite, i can see that the NativeDB's safeStmt set is much more than the statements is should track.. see screenshot
To Reproduce
Maybe run many prepare/non-prepare statements
Expected behavior
A clear and concise description of what you expected to happen.
Logs

Environment (please complete the following information):

OS: Centos
CPU architecture: x86_64]
sqlite-jdbc version [e.g. <IP_ADDRESS>]

Do you see any issue here?

I am experiencing a similar issue on Java 11.0.19, but not Java 11.0.16. Will confirm if it's the same issue soon.

I am potentially experiencing a similar issue on Java 11.0.19, but not Java 11.0.16. Which version of Java are you running?

openjdk version "17" 2021-09-14 OpenJDK Runtime Environment (build 17+35-2724) OpenJDK 64-Bit Server VM (build 17+35-2724, mixed mode, sharing)

From: Rhys Williams @.>
Sent: Tuesday, July 18, 2023 11:02:01 AM
To: xerial/sqlite-jdbc @.>
Cc: Mhanna AbuTareef @.>; Author @.>
Subject: Re: [xerial/sqlite-jdbc] jdbc potential memory leak (Issue #938)
I am potentially experiencing a similar issue on Java 11.0.19, but not Java 11.0.16. Which version of Java are you running?
—
Reply to this email directly, view it on GitHubhttps://github.com/xerial/sqlite-jdbc/issues/938#issuecomment-1639716160, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABAZ4TA3EXWS7WKILN43YFLXQY7HTANCNFSM6AAAAAA2I4TA2U.
You are receiving this because you authored the thread.Message ID: @.***>

CAUTION: This email originated from outside of K2view *

@gotson can anyone shed light on this?

@gotson can anyone shed light on this?

Someone would need to provide evidence of where the leak happens.

@mhanna I had exactly the same problem as you. A program running for 6+ hours doing requests and requests to an SQLite db.
The debian box has 6 GB of RAM and a variant of the program that does not make use of SQLite runs with less than 512MB.
After inspecting with VisualVM I found out that the instances of SafeStmtPtr were through the roof.
Simply closing the Statement calling close() solved my issue. I believe you should also be able to set them to automatically close on complete, although I haven't tested this.
I assume not closing the statement leaves some memory out of the JVM to remain allocated and when the SafeStmtPtr is collected the memory is leaked. Although this is a wild guess and I don't really know about JDBC's or SQLite's internals.

On my end it was less practical to use a try-with-resources due to a catch and error forwarding nightmare, there was a close() call in the catch but not if the statement was successful.
But the JavaDoc for Statement/Prepared statement is confusing

Releases this Statement object's database and JDBC resources immediately instead of waiting for this to happen when it is automatically closed. It is generally good practice to release resources as soon as you are finished with them to avoid tying up database resources.

So technically, while not a good practice, it should not leak memory if not done.
I have no proof of causality, but adding the close no matter what the outcome of the execution eliminated the memory leak.
Example based on the code that caused the leak. It's not ideal but it's the code I have to work with. The try-catch is removed for clarity.
// columns is a String[], value is Map<String, String>, query is String
PreparedStatement pStmt = connection.prepareStatement(query);
for (int i = 1; i <= columns.length; ++i) {
    pStmt.setString(i, this.values.get(columns[i - 1]));
}
pStmt = insert.getStatement(this.connection);
pStmt.execute();

// This line fixes it
pStmt.close();

To give a bit of context, this code is called in average 270 per file we process and we process around 4000 per run. A run lasts 8 hours. So over the course of those 8 hours, a little bit over a million times. The leak will likely not be noticeable for normal loads and only becomes a problem in large scale situations.

I can confirm that try-resource blocks (specifically around statements and ResultSets) are necessary to prevent native code memory leaks. Java never went over the max heap allocation in my testing, however in Task Manager I saw the JVM's total memory steadily rise as queries were run.
Here is a commit I did that fixed the memory leak for my project:
https://gitlab.com/jeseibel/distant-horizons-core/-/commit/b38b33e87e0bc25837220046767d732dba4e0053

Based on the observation that it's not Statement objects remaining in memory but SafeStmtPtr objects, I assume the Statement object is collected and leaves the SafeStmtPtr that should normally be properly "destroyed" when closing the Statement
If you look at the Statement class of the jTDS driver (which is used in the same codebase I have sqlite in, and does not leak):
protected void finalize() throws Throwable {
    super.finalize();
    try {
        close();
    } catch (SQLException e) {
        // Ignore errors
    }
}

I was not able to find such usage of the finalize() in the sqlite driver. I've only searched in the github web UI so if I missed it my bad.
However since finalization is deprecated in release 18 through JEP 421  I don't know what would be the proper way of cleaning underlying resources upon garbage collection of the Statement objects. The documentation mentions the Cleaner class but I've never actually used it.
The JEP 421 also mentions the use of try-with-resources and all others mechanisms of properly handling closable resources and it should be used, but it does not address the memory leak.

Connection and Statement are AutoCloseable. So we should really care about closing them in order to avoid leaks (ideally with try-with-resources).
Most of this confusion about not closing Statements really comes mostly from examples in the docs and code that completely forget to close them (like in readme.md and in demo/Sample.java).
I strongly believe we should update every example in the project to also correctly close Statements (not only Connections).

Most of this confusion about not closing Statements really comes mostly from examples in the docs and code that completely forget to close them (like in readme.md and in demo/Sample.java).
I strongly believe we should update every example in the project to also correctly close Statements (not only Connections) so then they would not induce or mislead into leaking issues.

as always, PRs are welcome :)

Submitted PR #1073 .
What do you think?

Submitted PR #1073 . What do you think?

will have a look when time allows, thanks !


feat: wcag 2.1 aa compliance update #1916

Issue : https://github.com/awslabs/iot-app-kit/issues/1916
Description :
Added @axe-core/playwright package to create automation test suites for accessibility.
Created automation test suites to check WCAG 2.1 AA Compliance Accessibility issues.
Playwright test cmd will also run accessibility tests.(yarn run test:e2e)
Note : For now we have skip the testcases so that PR can merge.

@Pushpajyothi Linting is failing. Could you take a look at that?

Due to conflicts closed this PR and raised new PR in IoT application


[Feature]: Auto width for widgets

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Similar to Auto height, a user has asked for an auto width feature.
Why should this be worked on?
In their use case, they have a two-column layout and when one of the widgets is invisible, they see empty space. Instead, they want the adjacent widget to expand sideways to take-up the space.
 Front conversations

Yes, agree with this ask. If not auto, add the ability for widgets to be collapsed. Also, auto-height does seem to take up some CPU cycles... ie.. it's much slower to render than fixed. I've stopped using it because of this.


Webview Did not show the text

Hi, i try to use this repo but when i read the issue, the webview did not show the content.
The error in logcat is : E/webcoreglue﹕ Should not happen: no rect-based-test nodes found.
Like the picture here,

the bottom of text BALI ERM 2014, there is the content text but did not show.
How to fix it?
Thanks

Hi @QwertyPong,
the errors logged by webkit usually don't cause any problems, it's just webkit being very verbose about what's going on when parsing the html.
I can have a closer look if you're willing to share your hpub, or the affected html-file.
Kind Regards,
Tobias

Thanks for reply @tobiasstrebitzer,
but when i use the old baker android, it's fine.
This is link for the hpub : http://www.safiahijab.com/magazine/baker.hpub
And how to setting google billing on this repo?
Thank you.

Hi @QwertyPong,
we have just pushed a new version of the app, integration XWalkView (a chromium-based web view) that might solve the display issues. Please upgrade to the latest version and let me know if it works :-)
I'll write some details on how to connect with google play in the Wiki shortly. I'll let you know when it's updated.

@tobiasstrebitzer Hello Tobias! I haven't found any Google Play Wiki. Is there still no documentation or have I searched not good enough?


Error During Logout

Hi Its Ganesh Kandu
I have Installed GeniXCMS 0.0.7 in My PC and getting an error on logout

Warning:  session_destroy(): Trying to destroy uninitialized session in  /geni289/inc/lib/Session.class.php on line 103
Warning:  Cannot modify header information - headers already sent by (output started at  /public_html/geni289/inc/lib/Session.class.php:103) in  /public_html/geni289/gxadmin/logout.php on line 27

Hi @GaneshKandu, Thanks for submitting the issue. I'll fix it soon.

Please Reply When you done :+1:  Thanks

this issue was fixed. please try to download our latest master version.
thanks

Hi, am Getting Blank Page on
http://{{ ip }}/genix/gxadmin/ &
http://{{ ip }}/genix/

hello, can you send me the error log ?
if you success installing it. please go to inc/config and open config.php
set this value error_reporting(0); to error_reporting(E_ALL);
and then send me the error reported by the browser.
thanks

got That
Parse error: syntax error, unexpected '[' in /home/soft/public_html/manual/genix/inc/lib/Router.class.php on line 99

thanks, please open inc/lib/Router.class.php
go to line 84. replace it with this code
    public static function run () {

        $m = self::match();
        // print_r($m);
        if (is_array($m)) {
            # code...

            $val = self::extract($m[0], $m[1]);

            if (isset($val) && $val != null ) {

                return $val;

            }else{
                $val = ['error'];
                return $val;

            }

        }else{

            $val = ['error'];
            return $val;

        }
    }

let me know if it's work
thanks

still Getting Same

Warning:  require({{httpdoc}}/manual/genix/gxadminautoload.php): failed to open stream: No such file or directory in {{httpdoc}}/manual/genix/gxadmin/logout.php on line 24

Warning:  require({{httpdoc}}/manual/genix/gxadminautoload.php): failed to open stream: No such file or directory in {{httpdoc}}/manual/genix/gxadmin/logout.php on line 24

Fatal error:  require(): Failed opening required '{{httpdoc}}/manual/genix/gxadminautoload.php' (include_path='.:/usr/local/apps/php54/lib/php') in {{httpdoc}}/manual/genix/gxadmin/logout.php on line 24

ah, thank you for bringing this up. i miss something.
at the /gxadmin/logout.php match with this code
define('GX_PATH', realpath(__DIR__ . '/../'));
define('GX_LIB', GX_PATH.'/inc/lib/');
define('GX_MOD', GX_PATH.'/inc/mod/');
define('GX_THEME', GX_PATH.'/inc/themes/');
define('GX_ASSET', GX_PATH.'/assets/');

require(GX_PATH."/autoload.php");

try {
    new System();
} catch (Exception $e) {
    echo $e->getMessage();
}

Hooks::run('user_logout_action');
Session::destroy();
header("Location: index.php");

at the /logout.php  match the content with this code
define('GX_PATH', realpath(__DIR__ . '/'));
define('GX_LIB', GX_PATH.'/inc/lib/');
define('GX_MOD', GX_PATH.'/inc/mod/');
define('GX_THEME', GX_PATH.'/inc/themes/');
define('GX_ASSET', GX_PATH.'/assets/');

require(GX_PATH."/autoload.php");

try {
    new System();
} catch (Exception $e) {
    echo $e->getMessage();
}

Hooks::run('user_logout_action');
Session::destroy();
header("Location: index.php");

let me know if it's work.
thanks

Working very well :+1:

cool, thank you for reporting the issue

Thanks to Fix


Update Go tutorial samples to remove prefix

Related to https://github.com/microsoftgraph/msgraph-sdk-go/issues/397
Remove the package prefix in query parameter structs in tutorial documentation for go. e.g Me  from package"github.com/microsoftgraph/msgraph-sdk-go/me"
i.e
query := me.MeMailFoldersItemMessagesRequestBuilderGetQueryParameters

should be
query := me.MailFoldersItemMessagesRequestBuilderGetQueryParameters

It appears this is a breaking change in the SDK as this was the correct struct name in 0.48.0.


Add in fusionConfig: jsExtPattern, resolveExtensions  (enable typescript)

This is change proposed in here: https://github.com/fusionjs/fusion-cli/pull/705
We are using typescript with fusionjs for last 3 month and its working smoothly, this is minimal (generic) change that allows to embrace typescript for the app code.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

any update for this PR? really need typescript support

I'll try to update this PR this week. Regarding those changes they do not cover running tests of typescript files. We have it working out of our own fork. I could update this PR with those changes or should I propose separate PR ?

I was a little bit overload recently, but here are coming back to work with this PR.
This change also incorporates minimal changes that allows us to have tests up and running for typescript code base.

!import

A canary release (0.0.0-canary.39fc7dc.0) has been cut with these changes.  I haven't played around with it yet though, but it should avoid having to fork + re-release this for now.

Thank you @Monar for the contribution and thanks to @AlexMSmithCA for cutting the canary release. My team has been using it for our migration from Flow to Typescript and that has been very useful.
One small thing to note - jsExtPattern should start with a dot jsExtPattern: /\.[jt]sx?$/ as that is being appended in testPathIgnorePatterns.

I just now found this PR and realized there's some overlap with the PR I'm working on #736. As this PR is much nicer in terms of changing the file extensions I'd like to build upon this and then add the ability to override the entry point on top.
What's the procedure here? It's kind of hard to know what to expect if part of the work is being done behind closed doors. What needs to happen for this to land on the master branch on this public repo?


#to_hash returning symbol keys (#341)

https://github.com/intridea/hashie/issues/341

My concern with this is that symbols are not garbage collected till Ruby 2.2. Other thoughts?

NB: only now I've noted Travis failing due to RuboCop offences, working on it.

Fixed RuboCop, but wow!
Now I see the specs fail with SIGSEGV on Rubinius.
Will investigate it later today.
Though, everything else is working now, please review.

Don't worry about Rubinius, I am "fixing" this in https://github.com/intridea/hashie/pull/344 by ignoring it. There's a lot of emotions flying around Rubinius segfaults.

I vote not to merge this until Ruby 2.2 is our minimum version. LMK how you feel about it. In the meantime squash commits/rebase.

@dblock should I try to reimplement this fix without keys-stored-as-symbols?..

I would say that has a higher chance of getting merged :)

Accepted.

Wow. It seems impossible (destructuring of Hash descendants apparently goes around to_hash method).
class A
  def to_hash
    {foo: 'bar'}
  end
end

class B < Hash
  def to_hash
    {foo: 'bar'}
  end
end

a = A.new
b = B.new

p({**a}) # => {foo: 'bar'}
p({**b}) # => {} -- ooops. Seems "internal" hash state is used
# therefore:
b['test'] = 1
p({**b}) # => wrong argument type String (expected Symbol) (TypeError)

I'll try to investigate it, but even tracing all method calls didn't help for now.

Apparently, as Hashie's classes are Hash subclasses, their #to_hash will NEVER be called on implicit conversion (explanation). Therefore, my conclusions are:

there should be NO method to_hash for any of Hashie::Hash descendants, but rather to_h (to_hash is semantically incorrect name considering all the things);
the only way for Hashie::Mash to act decently in **splat context is to have symbolic keys.

Both considerations are "breaking changes". As of to_hash I think it can be left (with mentioning of uselessness in implicit context), doing no harm.
As of symbolic keys, I have no idea of the "right" thing, considering garbage collector issues.
It seems, in fact, not much of rubyists rely on "double splat"/implicit conversion, if it topic haven't popped out earlier :(

Given Nobu's explanation of the semantics of #to_hash, I agree that #to_hash shouldn't be defined on any of our classes -- since we are already subclassing Hash -- and that we should only use #to_h.
This is a breaking change and would require a 4.0 release ... so we could use this as the starting point for a 4.0 release.
As for the splatting issue, I think we can switch to storing keys as symbols as long as we're okay with moving up our supported Rubies to 2.2+. I think the splatting behavior is something that is useful and since "a Mash is a Hash" it should be something that's supported.
All in all, if we want to use this as a 4.0 jumping off point, we should figure out what we want to do for 4.0 and mark this as a 4.0 feature.

@michaelherold This sounds reasonable. I do think that having Hashie require 2.2 is way too premature, it's such a popular library, I suggest waiting till 2.0 is relegated to the past like 1.9.3 is starting to be now.

@michaelherold @dblock Sounds reasonable to me. So, I think you can drop current pull-request totally (or merge it in something like pre-4.0 branch?), and just leave open corresponding ticket until those good times.

Lets leave it as is for now here and we'll get back to it at some point in the future. Thanks for having in there @zverok.

Note that Ruby 2.0 is reaching end of life in February, https://www.ruby-lang.org/en/news/2015/12/16/ruby-2-0-0-p648-released/.

Hello, is there any way you could bring this fix in only for latest ruby versions?

Hashie is still compatible with 2.0, but maybe it's time to deprecate that? Thoughts @michaelherold?

I'm fine with deprecating support for Ruby 2.0 since its EOL was about a year ago. I do want to make sure that we do a major version bump when we change that, though. Dropping support without doing the major version bump could lead to rough patches for people if we unintentionally push something that breaks compatibility.
Are there any other breaking change we would want to roll in for a 4.0 release? I have some persistence related stuff that could replace the Mash.load method, but it's not quite in a state for release.
I'm mildly against pushing a 4.0 release so quickly after a 3.5 release, but if this is something we need to then so be it.
Alternatively, we could just make a mixin that changes Mash to use symbols ...

I vote to sit on this for a couple more months and then doing what you suggest ^ with a major version change.

Closing in favor of https://github.com/intridea/hashie/pull/412, a Hashie extension that performs this.


WebVTT is based on SRT. Which is less rich than ASS.
AVFoundation provided by Apple only support WebVTT which means if I want the soft subtitles in the app. I have to convert ASS to WebVTT.
What will happen if I adopt WebVTT
The original ASS subtile from Crunchyroll looks like this

The SRT subtitle converted by ffmpeg -i enUS.ass -c:s srt enUS.srt looks like this

As you can see some words is not in the right position. It's better to remove those words and only keep bottom center.
Not all anime in Crunchyroll are fully subbed. For example

In this case. It looks like the same in both ASS and SRT.
Requirements for adopting ASS subtitles
I have to drop AVFoundation and use a third party video player.
What will happen if I do nothing
The subtitle will look good and English only. It's hard encoded in the video. You cannot turn it off or change to other languages.

Looks like I also have to bypass Cloudflare's anti-bot page to get soft subtitles.
I can use this pip package cloudscraper to accomplish it.
Command line tool CrunchyrollSwift-DL will support soft subtitles.
Because Swift for UI apps is not able to import Python. The UI app will remain as current.
If anyone have a bypass library in Swift and can be used on UI apps. Please reopen the issue.


npx cap open @capacitor-community/electron overwrites index.js

I am trying to customise electron/index.js ie add option for copy/paste but it keeps getting overwritten when npx cap open @capacitor-community/electron is executed. What is the recommended method to include the custom index.js?

Sorry was looking in wrong area build/src not src/index.ts


Something wrong with custom property values in expressions used in modifiers (and maybe issue with graph::Value size too?)

Crate versions
bevy version: 0.13.1
bevy_hanabi version: 0.10.0
Describe the bug
The value I'm setting for a custom property in an effect asset doesn't seem to be working properly. In the snippet below, I'm setting up a SetAttributeModifier that just writes the result of a mul involving a property to the AXIS_X attribute but something goes wrong and nothing is being displayed on the screen.
let mut module = Module::default();

// Just spawn everything in one spot
let init_pos = SetPositionCircleModifier {
    center: module.lit(Vec3::ZERO),
    axis: module.lit(Vec3::Z),
    radius: module.lit(0.0),
    dimension: ShapeDimension::Surface,
};

let prop = module.prop("my_prop");
let x_vec = module.lit(Vec3::X);
// let identity_mat = module.lit(MatrixValue::from(Mat3::IDENTITY));

// Transform the x axis with the my_prop matrix
let init_x_axis = SetAttributeModifier {
    attribute: Attribute::AXIS_X,
    value: module.mul(prop, x_vec),
    // value: module.mul(identity_mat, x_vec), // This works as you would expect
};

let effect = EffectAsset::new(32768, Spawner::rate(10.0.into()), module)
    .with_property("my_prop", Value::Matrix(Mat3::IDENTITY.into())) // Should just be identity matrix
    .init(init_pos)
    .init(init_x_axis);

commands.spawn(ParticleEffectBundle {
    effect: ParticleEffect::new(effects.add(effect)),
    ..default()
});

If you comment the value: module.mul(prop, x_vec) line out and use the one below instead, everything works fine and you can see the particles.
After poking around a bit I ran into this which makes me think it could be a layout issue? Not totally sure.
let value = Value::Matrix(Mat3::IDENTITY.into());
assert_eq!(value.as_bytes().len(), value.value_type().size());

assertion `left == right` failed
  left: 36
 right: 48

Expected behavior
To be able to use a custom property in a modifier expression for an effect asset.
To Reproduce
I made a reproduction repo over here. If you clone it and run cargo run and cargo test you should be able to see what I'm talking about.
I would dig a little deeper if I had more time right now and it's possible I'm just misunderstanding how this stuff is meant to work but hopefully someone can help me out. Thanks!

Thanks @liam-b for the report and repro. I think there's two things here:
The property but is I think a regression I saw recently. Try adding an EffectProperties component to the same entity as your ParticleEffect. I expect that might solve it. I think the code which auto-spawns it is broken.
The value size thing, I think it works as expected. When you query as_bytes() you're looking at the Rust data type on CPU (and even I think the internal representation which is private). But value_type().size() is the byte size on GPU according to WGSL layout rules, which are different from Rust. WGSL has stronger padding rules leaving more gaps for the benefit of more aligned access.

Oh wait no as_bytes() is also wrong for Mat3, should be 48 bytes indeed.

By the way to spawn everything in one place just use SetAttributeModifier(ATTRIBUTE::Position, ...) instead of a degenerate SetPositionCircleModifier. This will save a bunch of calculations which might introduce errors and NaNs due to the zero radius.

Reopening to wait for confirmation about EffectProperties, but I'd like to log a separate bug for it.

Yep, you seem to be right about EffectProperties not being auto spawned. But, when I add it like so, I get this error:
commands.spawn((
    ParticleEffectBundle {
        effect: ParticleEffect::new(effects.add(effect)),
        ..default()
    },
    EffectProperties::default(),
));

2024-04-03T00:37:20.082830Z  WARN bevy_hanabi: Asset  specifies motion integration but is missing Attribute::VELOCITY.
thread 'Compute Task Pool (2)' panicked at /Users/liam/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_hanabi-0.10.0/src/properties.rs:397:17:
assertion `left == right` failed
  left: 36
 right: 48
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Encountered a panic in system `bevy_hanabi::render::extract_effects`!

Which looks like it comes back to the padding issue! (which is still in 0.10.0, of course)
If I change bevy_hanabi to latest from git in my dependencies it now works! Although, the issue with needing to add EffectProperties still seems to be there. Anyway, I can do what I wanted now. Thanks for your help!

Yes the padding issue was probably there from the start.
I'll have a look at the EffectProperties spawning, it's probably a silly bug.

Fixed by #312


What are the correct upload settings and inclusion settings to use?

Thanks for your work on this great plugin!
The docs list these options:
  upload_native_symbols: true
  upload_source_maps: false
  include_native_sources: false

It's not clear to us which of these options to use.
We build apps for both mobile and web in one go (with --source-maps enabled on the web release) and then run flutter packages pub run sentry_dart_plugin, so I presume we want to enable all three options? Is there a reason why we wouldn't want to enable one of these options?
I think it'd be really nice to document what to do here. 🙏

@stx thanks for raising this.
See https://docs.sentry.io/platforms/flutter/upload-debug/
The readme actually explains each of the options and then it's up to your needs, but TLDR is (in your use case):
upload_native_symbols, you need it since you want to symbolicate Native events (e.g. iOS hard crashes).
upload_source_maps, you need it since you want to symbolicate Web events (from JS to Dart).
include_native_sources, that's optional, if you want to see source code context, enable it, otherwise, you see only class/method names and line numbers.

@marandaneto Thank you! We saw the docs but it was your explanation here that was missing and is perfect. :)


Download file with parameters

Hi guys.
In the current version of the project I didn't find an ability to make a download of a file with some parameters (like  Alamofire.request do). I needed this in my project, and i think it will be very useful to others.
I do not know if it would be useful to someone, but I make some code to realise this ability:
Thanks for your great work!
extension Manager {
    /**
        Creates a download request using the shared manager instance for the specified method, URL string
        and parameters.

        :param: method The HTTP method.
        :param: URLString The URL string.
        :param: parameters. `nil` by default.
        :param: destination The closure used to determine the destination of the downloaded file.

        :returns: The created download request.
    */
    public func download(
        method: Method,
        _ URLString: URLStringConvertible,
        parameters: [String: AnyObject]? = nil,
        destination: Request.DownloadFileDestination)
        -> Request
    {
        let mutableURLRequest = URLRequest(method, URLString, headers: nil)
        let encoding: ParameterEncoding = .URL
        let encodedURLRequest = encoding.encode(mutableURLRequest, parameters: parameters).0
        return download(encodedURLRequest, destination: destination)
    }
}

Hi @kaelite, thanks for the suggestion! I completely agree and implemented the change along with tests in 4e633d6d.
Cheers. 🍻


Does ZmarkupParser not need to apply a Privacy Manifest?

Apple policy requires libraries that use personal information to apply a Privacy Manifest, and I'm wondering if ZmarkupParser is unrelated to this.

ZMarkupParser purely uses Swift and data structures to convert HTML strings into NSAttributedStrings. I believe it does not involve any privacy-related issues.
Thank you for your question.


FIX Tests with hard coded IDs

Fixes the tests that rely on tags having specific IDs

whoop tests pass @tractorcow

Oh thanks @dhensby !


Update python 3.11 version in CI

This will fail currently because pyarrow isn't available for 3.11 yet

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (20ba1a8) compared to base (604304f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #282   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines          203       203
=========================================
  Hits           203       203

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Provide a status bar for outstanding jobs

This should include the number of jobs in the following states:

Done. For unit tests, this should be broken down into passed, failed, and error.
Executing. This means the job is at the worker.
Queued. This means the job is sitting at the broker waiting to be assigned to a worker.
Waiting on artifact. This means the job is blocked on the broker getting at least one artifact.
Pending. This means the job either hasn't been sent to the broker yet, or the client hasn't received an acknowledgement yet.

Pending. This means the job either hasn't been sent to the broker yet, or the client hasn't received an acknowledgement yet.
There is no state for this yet, I'm not sure its worth pursing at this time, we can always come back to it.


create 4.0.2 patch for updating version of log4j to 2.15.0

Describe the Task
there are active exploits in the wild, this is especially dangerous if you have forms on a webpage or external-facing service that feed into the JVM that have the log4j library enabled.
Need to update METviewer v4.0.1 code to be build and deployed with log4j 2.15.0
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 2 hours of work.
Sub-Issues
Consider breaking the task down into sub-issues.

[ ] Add a checkbox for each sub-issue here.

Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee

[ ] Select engineer(s) or no engineer required
[ ] Select scientist(s) or no scientist required

Labels

[ ] Select component(s)
[ ] Select priority
[ ] Select requestor(s)

Projects and Milestone

[ ] Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
[ ] Select Milestone as the next official version or Future Versions

Define Related Issue(s)
Consider the impact to the other METplus components.

[ ] METplus, MET, METdatadb, METviewer, METexpress, METcalcpy, METplotpy

Task Checklist
See the METplus Workflow for details.

[ ] Complete the issue definition above, including the Time Estimate and Funding Source.
[ ] Fork this repository or create a branch of develop.
Branch name: feature_<Issue Number>_<Description>
[ ] Complete the development and test your changes.
[ ] Add/update log messages for easier debugging.
[ ] Add/update unit tests.
[ ] Add/update documentation.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into develop.
Pull request: feature <Issue Number> <Description>
[ ] Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Linked issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version
[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Close this issue.

update to log4j 2.16


Add http basic auth

Add HTTP basic auth to access token request.
According to RFC :

Including the client credentials in the request-body using the two
parameters is NOT RECOMMENDED and SHOULD be limited to clients unable
to directly utilize the HTTP Basic authentication scheme (or other
password-based HTTP authentication schemes).  The parameters can only
be transmitted in the request-body and MUST NOT be included in the
request URI.

Are there any news on this?

Any idea when this will be merged?

I have no idea.

Sorry for the extremely long delay in getting this merged, and thank you for contributing! 🎉


Delete use case under default test

Discard defaulttest as its not significant or adding any value to project.

Deleted as part of PR #457


setting pytest logging level at queue time

In our productivity brainstorm meeting, it was brought up that it would be nice to have an easy way to enable logging on test pipelines, especially for issues that only seem to repro in CI. AFAIK (but correct me if I'm wrong!), currently you have to create a logger and open a draft PR to get pytest logging going, so this PR adds a way to set a queue time variable which indicates which level of logging you want:
PYTEST_LOG_LEVEL=<log-level>
This defaults to no logging. Note that if a library owner wants DEBUG logging and sensitive information unredacted, then they still must explicitly pass the logging_enable keyword argument into the client they use for tests.
Testing:
PYTEST_LOG_LEVEL=INFO: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3389008&view=logs&j=00d488d8-0928-537b-2837-a217e71ffc55&t=153f2ede-6903-56e0-bdbf-df96f42992de&l=179
Did not set queue time variable: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3391461&view=logs&j=00d488d8-0928-537b-2837-a217e71ffc55&t=153f2ede-6903-56e0-bdbf-df96f42992de&l=177

FYI you can also consume the SYSTEM_DEBUG env variable which will integrate with the Enable system diagnostics checkbox in the pipeline run UI:
https://learn.microsoft.com/en-us/azure/devops/pipelines/troubleshooting/review-logs?view=azure-devops#configure-verbose-logs

FYI you can also consume the SYSTEM_DEBUG env variable which will integrate with the Enable system diagnostics checkbox in the pipeline run UI:
https://learn.microsoft.com/en-us/azure/devops/pipelines/troubleshooting/review-logs?view=azure-devops#configure-verbose-logs

@benbp thanks for sharing, I didn't know about that! I tried a run with checking the box / SYSTEM_DEBUG, and it does produce more logging, but doesn't look like it enables pytest logging of the requests/responses. Unless I missed something, I think this PR still addresses the need for that.


Add PR workflow

Add a Github workflow for validating PRs - linting, testing, building etc

Implemented with e292d927fdcd6f0868e81455c534074ec1397205


trackLink and trackForm don't take options

Was wondering why trackLink and trackForm don't allow an options object to be passed.  I would like to use these functions but I can't anonymize the IP address of my users if I can't pass in options to these functions.
https://segment.com/docs/connections/sources/catalog/libraries/website/javascript/identity/#anonymizing-ip

@nmackey Thanks for logging this issue! I don't see a reason not to allow passing options to these methods - it seems like a reasonable thing to support!
In case you're currently blocked, a workaround is to write a plugin to anonymize the IP, here's a quick example that will anonymize the ip for every event made:
function anonymizeIp(ctx) {
  ctx.event.context.ip = '<IP_ADDRESS>';
  return ctx;
}

const noIpPlugin = {
  name: 'No IP',
  type: 'before',
  version: '1.0.0',
  isLoaded: () => true,
  load: () => Promise.resolve(),

  track: anonymizeIp,
  identify: anonymizeIp,
  page: anonymizeIp,
  alias: anonymizeIp,
  group: anonymizeIp
}

If you're using the JS snippet, the easiest way to use this would be to call analytics.register(noIpPlugin) right after your snippet - in this case you'd also want to add "register" to the analytics.methods array of the snippet.
If you're using analytics-next in an app where you bundle it yourself then you can add it when you call load:
AnalyticsBrowser.load({ writeKey: 'writeKey', plugins: [noIpPlugin] })

Fixed with https://github.com/segmentio/analytics-next/pull/417

Thanks for the fix and the anonymizeIp plugin/function 🔥


Will the Dubbo 3.0 version be released recently?

It's a long-term roadmap for dubbo, won't be released soon.


FIx the Kafka Operator based provisioning test, setting the broker proto according to kafka version

Description
The test is failing due to the Kafka broker protocol being set to 3.5 which doesn't work when using a different Kafka version, as when testing productized deliverables.
The strimzi API version in the POM has been bumped to 0.37-SNAPSHOT which is the only version supporting Fabric8 k8s client 6.8.1. When testing against community, a Kafka Operator v. 0.36.1 is deployed (stable channel), supporting Kafka 3.5.1.
Such APIs are also valid for interacting with the operator when a previous Kafka version is deployed, e.g.: 3.4.0 as we do when testing against productized deliverables (Red Hat AMQ Streams operator, stable channel).
Fix #75
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change
[x] Chore (non-breaking change which doesn't affect codebase;
test, version modification, documentation, etc.)

Checklist

[x] Code contributed by me aligns with current project license: Apache 2.0
[x] Pull Request contains a description of the changes
[x] Pull Request does not include fixes for multiple issues/topics
[x] Code is self-descriptive and/or documented
[ ] I have implemented unit tests to cover my changes
[x] I tested my code in OpenShift

/test all

/test periodic-ci-Intersmash-intersmash-main-periodic-intersmash-e2e-periodic

/test all

/test all

thank you for this MR, merging.


Yggdrasil connectivity degradation

Since this month (Nov) we started to notice some serious Yggdrasil degradation again. Mostly these are connectivity issues, but the latency in general went up by a lot also. We saw these issues before and could temporary resolve them with our peer list but we knew in advance it would return.
Our monitoring is sending pings over yggdrasil to all public nodes / ygg peers in the peer list. A performance graph of the last month:

This is time vs latency. The unavailability of an yggdrasil endpoint also happens regularly without a clear pattern. You can visit the graph at: https://mon.grid.tf/d/000000016/blackbox-yggdrasil-icmp?orgId=1&refresh=10s&from=now-24h&to=now
Keep in mind the above pings are done to the peer list nodes, so the monitoring server has these peers configured. Communication to ygg addresses not in this list is even worse.
I would like to state the urgency of this matter, since problems with yggdrasil reflect on all nets (main, dev, test and qa) and every service that uses yggdrasil. One could say yggdrasil is a backbone service of the grid, like the TFchain is. If it does not work, the Grid does not work ..
This will result in mostly timeout issues like these ones:

https://github.com/threefoldtech/test_feedback/issues/321

Since the start of this month we also noticed these kinds of log statements in ygg client logs: https://github.com/threefoldtech/tf_operations/issues/1269#issuecomment-1317304896
Ygdrasil in general seems to degrade with each upgrades, as can be seen here: https://github.com/yggdrasil-network/yggdrasil-go/issues/978
We see no real progress in improving these issues: https://github.com/yggdrasil-network/yggdrasil-go/releases
Although the last release might have improved the routing problems? -> https://github.com/yggdrasil-network/yggdrasil-go/releases/tag/v0.4.7 -> Buffers are now reused in the router for DHT and path traffic, which improves overall routing throughput and reduces memory allocations
A possible reason for all this could be point 8, 9 and 10 stated at this page: https://github.com/Arceliar/ironwood/#known-issues

Some essential protocol traffic requires round trips. That can be problematic when latency in the local network and latency of links in the global network differ significantly. In the extreme case, if we take the idea of a "world tree" literally, then a network with nodes on both earth and mars would be unusable even within one planet because of round trip protocol traffic that needs to go between planets. It's worth noting that the initial IP->key lookup and the crypto layer both require round trips, but that's a separate problem which is technically out of scope for the project (it's a research project on routing, not cryptography).

The current DHT is able to prevent traffic from unnecessarily leaving a subnet if there is exactly 1 gateway between the subnet and the rest of the network. Ideally, we would not want to exit a subnet just to re-enter via a different gateway. Going back to the mars example, even if the DHT was able to be constructed and kept consistent, having two gateways could case messages route from mars, to earth, and then back to mars. More realistically, if there's a local mesh network, we would like the network to be able to have multiple gateways to the internet overlay or bridges with other mesh networks, without those added links causing traffic within the local mesh to route outside and back in via a different gateway. This may turn out to be impossible (see e.g. Braess's paradox), but we can probably still do better than ignoring this completely.

Somewhat related to the above, there are some known network topologies where ironwood's stretch is terrible. Rings are the easiest example to point to: if two nodes are near each other, but on different side of the point that's directly opposite to the root, then their traffic will tend to take the long way (through the root) instead of going directly to each other. Ironwood also uses an unreasonable amount of memory on ring networks. We largely don't care about poor performance on rings, since they would lead to high path length even with a stretch-1 routing scheme. Unfortunately, ironwood performs poorly on spheres for largely the same, albeit with less memory use, which could become a major problem when building a large network on earth. There are ways to address this in the treespace routing scheme, but it's difficult to fix this in the DHT without introducing some security / denial-of-service vulnerabilities.

Strictly observational, But I found when deploying my public nodes that connections to over about 50 peers would start rotating connections, and when I crossed about 75 my nodes would crash on boot when they attempted to connect to all of them at once.
Realistically yggdrasil isn’t designed to have a centralized exchange, the concept is for nodes to peer with other local nodes around them furthering the mesh by the peers being connected almost in a cascade across a geographical area.
I think we should aim for each of the public peers to be able to maintain about 50 connections by their peers list, to do this we have to consider both the peers we add to the list, and the ones that will be found over multi cast.
We could functionally make this happen in the short term by creating small cell interchanges.
ultimately I think having cells of 22 peer co located clusters is the answer to work with what we have until a solution is found to the limitations were hitting,
So,
we have 22 peers in gent isolated on a vlan from all other nodes running yggdrasil
we have 22 peers in Salzburg  isolated on a vlan from all other nodes running yggdrasil
So we have 22 peers in st gallen isolated on a vlan from all other nodes running yggdrasil
each cluster of 22 peers will find its collocated partners over multi cast peering
Gent Peers->Salzburg
St.Gallen peers to ->Salzburg
Salzburg peers to odd gent nodes
Salzburg peers to even st Galen nodes
This would make Gents peer list
Salzburg 1-22 configured
Gent 1-22 by multicast
This would make the St Gallen peer list
Salzburg 1-22 configured
St gallen 1-22 by multicast
The Salzburg peer list would be
11 odd Gent nodes
11 even St Gallen nodes
22 Salzburg nodes by
this SHOULD make all of our public peers stay reliably connected, and provide enough capacity to support our current node structure, if it works the model can scale with the network as we add new gateway farms.

this appears to show adding the public peering effectively having put our subnet behind the public peers. the nodes that make up the wings are lose associated with node ids of the public peer list, and 3nodes are the large orb

a87607fa7039e1fffedfaaa11cc201e971fda1a0f131af950e3c5002b2154d7b	200:af13:f00b:1f8c:3c00:240:aabd:c67b 	1m49s 	 1kb 	 1kb	0 	tcp://gw307.vienna2.greenedgecloud.com:9943
vienna 2 was the root of our network at this point in time that things looked to be working well.

Checked some of our public nodes, they consistently have ~3K peers. While monitoring the peers of one of these, there were occasions were almost all of them got removed at once except for the newly added root peer and 1 other. They got added themselves again over a couple of seconds. There seems to be a correlations of this occurring and the latency spikes.
I've changed the binaries of the 2 devnet nodes with a local version with basic prometheus instrumentation tracking how many of each type of packet is sent/received, and how many peers are added/removed in general. Lets see if this has some info by tomorrow.

Graphs of the packets going through these nodes show a correlation between ping spikes to these nodes and "tree" packets coming in. This indicates the network is reorganizing. Also peer count was mostly steady (except for some instances yesterday), so this seems to be an unrelated issue. Considering that our public nodes have stable connections to eachother (at least they are always connected when I get the peer lists on these public nodes on devnet), this points to the network reorganization being triggered by "external" nodes (i.e. the yggdrasil network itself, which we inherently don't control).
After some deliberation, it was decided to not fork yggdrasil at this time, and remain part of the ecosystem. We hope that future developments will increase the stability of the network, but won't actively make changes to the current situation.
To solve the issues for the grid, which is the fact that RMB runs over yggdrasil and thus might cause temporal node instability, it was decided to introduce better proxy support, such that public nodes on the "regular" internet can proxy messages to "hidden" nodes. This removes the dependency on yggdrasil. See threefoldtech/home/issues/1373 for that.


(WIP) - convert SHOW TAG VALUES to distributed query

Should we expect some tests? If this is WIP, makes sense not so far.

@dgnorton -- is this still WIP?

@kostasb hit this, I think.

@dgnorton Should this be closed?


CI: Better build size debugging

This is a little bit of a redux of the issue I raised here: https://github.com/micropython/micropython/issues/8680
And the PR here: https://github.com/micropython/micropython/pull/8761
Neither of these have had any traction for a while, due to an impasse with the way flash sizes are declared with Pico's bi_decl being incompatible with how we might want to supply (or retrieve from) flash sizes in memmap_mp.ld.
The general idea is to split FLASH into APP and FILESYSTEM so we have an early failure if the two happen to overlap.
Without a linker error to catch this, a MicroPython build will generate a filesystem at runtime and overwrite itself in potentially catastrophic ways.
Making this tooling work requires adding an memmap_mp.ld to each board directory. Since this does not inherit the flash size from mpconfigboard.h it removes the previous "single source of truth" for flash size and... this can easily catch you out.
In all cases the linker variable _flash_app_size should be ACTUAL_FLASH_SIZE - MICROPY_HW_FLASH_STORAGE_BYTES. Eg: For Pico this is 2048 (2MB) - 1408 (1.4MB) = 640k.

Judging by the before and after of Tiny 2040 (8MB) the ulab module - as configured - weighs in at about 92k.

Having a long, hard think about how much appetite I have to babysit Yet Another Patch 😆


Fix skeleton labels

Motivation and context

Added skeleton addition tests in projects and tasks
Added skeleton sublabel editing tests
Refactored some code

How has this been tested?

Checklist

[ ] I submit my changes into the develop branch
[ ] I have added a description of my changes into the CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (see GitHub docs)
[ ] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

@azhavoro, please check these tests for signal handling.

@zhiltsov-max Could you please update the shema?

Please, reopen if you are going to continue the pr


feat: add upload success and error notifications

Description

Checklist

[ ] Read the contributing guidelines.
[ ] Each commit follows the Conventional Commit spec format.
[ ] Update the readme (if applicable).
[ ] Update or add any necessary API documentation (if applicable)
[ ] All existing unit tests are still passing (if applicable).

[ ] Add some steps so we can test your bug fix or feature (if applicable).
[ ] Add new passing unit tests to cover the code introduced by your PR (if applicable).
[ ] Any breaking changes are specified on the commit on which they are introduced with BREAKING CHANGE in the body of the commit.
[ ] If this is a big feature with breaking changes, consider opening an issue to discuss first. This is completely up to you, but please keep in mind that your PR might not be accepted.

Current dependencies on/for this PR:

next

PR #156

PR #158   👈

This comment was auto-generated by Graphite.

(unless what I'm looking for is Asset Manager Edit).

This is exactly it. Can't upload without that permission set on the key.

Fair enough, I'm happy to move forward with this as is and we can revisit if we receive feedback that the error isn't clear enough.


Validate cmake builds of OpenJ9 on Windows

cmake support is enabled on most platforms now for OpenJ9 but not Windows (there is one final fix that's going in). We should attempt to run a cmake build to verify that our build systems are set up with a suitable working cmake.
Suggest running a build manually on the machine with cmake enabled as it is for other platforms (--with-cmake at configure time shold do it)

[ ] build-softlayer-win2012r2-x64-1
[ ] build-softlayer-win2012r2-x64-2
[ ] build-azure-win2012r2-x64-1
[ ] build-azure-win2012r2-x64-2

After installing cmake via Cygwin (admittedly version 3.14.5 ), as well as the non-cygwin version (see the windows playbook in infra), I've been unable to get a working version of cmake on the Softlayer machines - when running cmake via cmd, I get a popup saying The procedure entry point uname_x could not be located in the dynamic link library C:\cygwin64\bin\cyguv-1.dll, followed by a cmake has stopped working error. Installing libcv-devel didn't change anything, and cyguv-1 doesn't appear in the Cygwin setup list.
Due to https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/1594 , I don't think it's a priority to try and fix this, therefore I'm going to just focus on confirming cmake is okay on the new IBMCloud machines :-)

[ ] build-ibmcloud-win2012r2-x64-1
[ ] build-ibmcloud-win2012r2-x64-2

All Windows-build machines should be ready to build OpenJ9 w/ cmake now :+1:


Clippy creds crate

Please help keep the CHANGELOG up to date by providing a one sentence summary of your change:

Apply clippy lints to credential crate

From clippy 0.0.212, this address part of https://github.com/rusoto/rusoto/issues/1166 . 😄 Also has some cargo fmt in here as well.

Happy to hear feedback on this one after the fact. I figure we can get this in sooner rather than later. 😄


Example data tables in documentation show only an error..

Describe the bug
If you navigate to the example section in the documentation (for example), all the examples fail to render. Attempting to view the example on CodeSandbox external site also fails with a 404 error.
Provide an example via Codesandbox! (required)
Use a new react-table codesandbox to reproduce the issue.
Steps To Reproduce
Steps to reproduce the behavior:

Go to https://react-table.tanstack.com/docs/examples/basic'
See error

Screenshots

OS: Ubuntu 20.04
Browser Brave Browser (built on Chromium)
Version 1.14.81 Chromium: 85.0.4183.102 (Official Build) (64-bit)

Upstream bug with codesandbox.

how to resolve it ?


guest cleanup: ensure pods are force-deleted

What this PR does / why we need it:
Without a kubelet present, pods will not go away without being force-deleted. Ensure that we do that whenever cleaning up pods.
Checklist

[x] Subject and description added to both, commit and PR.

why do we care of the pod going away after the kubelet is down?

Is this so once the kubelet went away, operators running in the management side can ack the operand pods were removing and proceed with their deletion operations?
e.g ingress operator needs to ack the controller in guest cluster is gone to proceed with deletion or something else?

/hold cancel

/retest-required

/hold cancel


[Feature Require]Functional Programming in Event Binding

In some case, one may want to bind a function returned by a method depends on the parameter: v-on:change="selected('province')", v-on:change="selected('city')", v-on:change="selected('district')"
But the above bindings will be treated as inline handlers by the compiler.
Hope the compiler will analyze and treat the handlers as a method handlers.

selected('province')($event)


Opening diffs shows errors on the left side

Opening changes from a PR (without checking it out) shows errors on the left hand side:

@RMacfarlane fyi this was feedback from the team.

Looks like this has been fixed upstream: https://github.com/microsoft/vscode/issues/105842


[Feature]: Top X download

Guidelines

[X] I agree to follow this project's Contributing Guidelines.

Description
A request came in to make a topx download feature for downloading matches beyond top 1.
Problem
top 1 matches are limiting.
Proposed Solution
add an option to download top and let the user specify the  number of x when that is selected (up to 50 or something reasonable).
Alternatives Considered
ask user to use the package.

Done in most recent


Couldn’t turn on service - TabMon-Postgres and TabMon

Dear Sir or Madam,
I have encountered a special situation after TabMon re-installation. I couldn’t turn on service TabMon-Postgres and TabMon. It is amazing that TabMon-Postgres and TabMon could be turn on if I turn off service Tableau Server Administration Controller. May I seek for your advice to know the root cause? I though it’s about port number (I am investigating in this way). And I need help to drill down into it. Thanks a lot!
Regards,
Andy

Hello,
Can you send me the TabMon logs? They are found here:
\TabMon\Logs\TabMon.log.txt
Once I have these I should be able to take a look.
Thanks,
Dan

Dear Dan
Thanks for your feedback! It would be divided into two parts: TabMon-Postgres and TabMon

TabMon-Postgres
When I try to turn on service TabMon-Postgres, it shows error message:
The TabMon-Postgres service on Local Computer started and then stopped. Some services stop automatically if they are not in use by other services or programs.
I have drilled into Event Viewer (run -> “eventvwr.msc -> WIndows Logs -> Application). And it shows error message:
FATAL: could not create any TCP/IP sockets

I have tried few solutions but fail. It would be shown as below for your reference:
Edit file C:\Windows\System32\drivers\hosts, then add the following words:
<IP_ADDRESS>	localhost

Tabmon
When I try to turn on service TabMon, it shows error message:
Window could not start the TabMon service on Local Computer.
Error 5: Access is denied.
In \TabMon\Logs\TabMon.log.txt, it shows ‘Invalid options in configuration’ and ‘Object reference not set to an instance of an object’. Capscreen would be shown as below. I am very sure the hostname and IP are correct. I have checked in cmd hostname and ipconfig. Hostname is UBDPHKWWEB02 and IP is 10.X.X.X.

For more background information, my re-installation step would be shown as below:

Uninstall TabMon
Delete TabMon folder and files
Execute ‘sc stop TabMon-Postgres’ in cmd
Execute ‘sc delete TabMon-Postgres’ in cmd
Delete C:\Postgres folder and files
Follow this YouTube instruction to install TabMon again (https://www.youtube.com/watch?v=oF7tGSE4lm0)

Thank you very much!
Regards,
Andy Law


Fix/tutorial grids nbdev tests

Fixed notebook tests for tutorial grids.
Cleanup repeated instantiation of grid generator for 1k
Minor doc improvements

it seems to forcing to
No such kernel named geowrangler

https://github.com/jupyter/nbclient/blob/main/nbclient/client.py#L181

I think I encountered that bug before. I'll try adding a check in the future. The problem is the notebook metadata for the kernelspec hardcodes the kernel name w/ch is not present in the github build env. Will fix with  another commit.

the last commit  (replace hardcoded kernel name) fixed the build problem. fyi @jtmiclat


added support for prefer headers along with unit and integration tests

This addresses https://jira.duraspace.org/browse/FCREPO-1273
Specifically, it allows users to control the Prefer headers sent to the fedora endpoint

As a general comment, more logging will make this codebase easier to trace and debug.

Resolved with: https://github.com/fcrepo4-labs/fcrepo-camel/commit/3ad67c8cb8a1eb2a5a92a2a1d218d75d9a4328f8


Update Cargo.lock

error: the lock file /build/source/Cargo.lock needs to be updated but --frozen was passed to prevent this
If you want to try to generate the lock file without accessing the network, remove the --frozen flag and use --offline instead.

It seems Rust requires the Cargo.lock file be kept up to date with Cargo.toml even if none of the dependencies changed. When packaging, it's important that the packages and dependencies be deterministic, hence why freezing Cargo.lock can be important.

just updated it, let me know if there are any other issues with it


Better default conf.yaml.example

Better default conf.yaml.example
The previous default conf.yaml.example generate does not pass ddev validate config. Is that intended or should be something to fix ? @FlorianVeaux

When I was working on this validator there was a consensus that - {} was to be avoided in our configs.
+1 for adding the tag sections here, we manually add it anyway


This is probably a bug

config.N_CPUS_PER_SERVER = n_cpus_per_server
config.N_CPUS_PER_WORKER = n_cpus_per_worker
config.N_CPUS_PER_SERVER = n_gpus_per_worker <------

Yes, thanks, that's a bug. The config part right now is simple because the next step will be automatic hardware configuration. Right now, it's set to Ray's defaults.


Added Games by Radhesh Goel

Author name
Author: Radhesh Goel

About your game
What is your game about?
My Games are about Fractal patterns because who doesnt love infinite patterns

How do you play your game?
w - Pan up
s - Pan down
a - Pan left
d - Pan right
i - Zoom in
j - Zoom out
k - Reset to defaults
Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)

[ ] The image is in the /games/img directory.
[ ] The name of the image matches the name of your file.

Thanks for your PR!

yeah
i love math art!

sorry, i forgot to check out my github inbox

Sorry for the delay! So could you split in 3 different PRs? Thanks:)

Sorry for the delay! So could you split in 3 different PRs? Thanks:)

Sure why not?

So do I get a sprig?

I am closing this PR to divide my games into 3 PR


Help Setting Up

Thanks for creating this Lambda Function. I'm very new to Lambda and was wondering if you can help me to configure this code in Lambda.
I'm unsure what to set the "handler" setting to. I've also just pasted the content of S3EventProcessorUnzip.java into the inline code entry. I also made sure to implement IAM Role settings you mention in the documentation.
Thanks again.

Hello, the handler property should bekornell.S3EventProcessorUnzip::handleRequest. I will add this to the README.

Thank you I will this a try and let you know how I go.

I'm running an S3 Put test but it's failing. Here is the test below (I'm not sure if I have this right)
{
"Records": [
{
"eventVersion": "2.0",
"eventTime": "1970-01-01T00:00:00.000Z",
"requestParameters": {
"sourceIPAddress": "<IP_ADDRESS>"
},
"s3": {
"configurationId": "testConfigRule",
"object": {
"eTag": "0123456789abcdef0123456789abcdef",
"sequencer": "0A1B2C3D4E5F678901",
"key": "publish_Sample_Workbook_-_200_Pages.zip",
"size": 1024
},
"bucket": {
"arn": "arn:aws:s3:::mybucket",
"name": "sourcebucket",
"ownerIdentity": {
"principalId": "EXAMPLE"
}
},
"s3SchemaVersion": "1.0"
},
"responseElements": {
"x-amz-id-2": "EXAMPLE123/5678abcdefghijklambdaisawesome/mnopqrstuvwxyzABCDEFGH",
"x-amz-request-id": "EXAMPLE123456789"
},
"awsRegion": "us-east-1",
"eventName": "ObjectCreated:Put",
"userIdentity": {
"principalId": "EXAMPLE"
},
"eventSource": "aws:s3"
}
]
}
Here is the error
{
"errorMessage": "Unexpected identifier",
"errorType": "SyntaxError",
"stackTrace": [
"Module.load (module.js:343:32)",
"Function.Module._load (module.js:300:12)",
"Module.require (module.js:353:17)",
"require (internal/module.js:12:17)"
]
}

I don't think you can do inline code entry for Java lambda, I believe you may have entered the Java code in the NodeJS (javascript) section. To submit the Lambda, you need to follow the readme instructions for packaging it.

Thanks for that. Like I said I new to all this so learning on the fly. So I installed maven and downloaded the project zip file. Extracted the zip file and executed mvn clean package.
It then proceeded to download a bunch of repos
mvn clean package
Warning: JAVA_HOME environment variable is not set.
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building aws-lambda-unzip 0.0.1-SNAPSHOT
[INFO] ------------------------------------------------------------------------
Downloading: http://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
Downloaded: http://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom (4 KB at 6.3 KB/sec)
Downloading: http://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/22/maven-plugins-22.pom
Downloaded: http://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/22/maven-plugins-22.pom (13 KB at 36.3 KB/sec)
Downloading: http://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/21/maven-parent-21.pom
Downloaded: http://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/21/maven-parent-21.pom (26 KB at 62.5 KB/sec)
Downloading: http://repo.maven.apache.org/maven2/org/apache/apache/10/apache-10.pom
Downloaded: http://repo.maven.apache.org/maven2/org/apache/apache/10/apache-10.pom (15 KB at 40.4 KB/sec)
on...and on and on...
Have I missed something? It seems to be downloading everything at http://repo.maven.apache.org

This is normal on the first run, it will store those artifacts in your local repo for future use. Make sure you get a 'SUCCESS' message at the end of the build and you should be OK.

Great, I was getting a little concerned. Here is where I got to. Looks like I've got some work to do to sort out why the compiling is not working.
[INFO] Changes detected - recompiling the module!
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[INFO] Compiling 1 source file to /tmp/aws-lambda-unzip-master/target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] No compiler is provided in this environment. Perhaps you are running on a JRE rather than a JDK?
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:39.041s
[INFO] Finished at: Mon Feb 20 14:26:51 AEST 2017
[INFO] Final Memory: 19M/246M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project aws-lambda-unzip: Compilation failure
[ERROR] No compiler is provided in this environment. Perhaps you are running on a JRE rather than a JDK?
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

You need to have a copy of JDK 8 installed and on your path for this work also. You can get this here for your platform http://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html

Progress has been made. I needed to do.
apt-get install openjdk-7-jdk openjdk-7-doc openjdk-7-jre-lib
Here is the result.
[INFO] Including com.amazonaws:aws-lambda-java-core:jar:1.0.0 in the shaded jar.
[INFO] Including com.amazonaws:aws-lambda-java-events:jar:1.1.0 in the shaded jar.
[INFO] Including com.amazonaws:aws-java-sdk-s3:jar:1.11.93 in the shaded jar.
[INFO] Including com.amazonaws:aws-java-sdk-kms:jar:1.11.93 in the shaded jar.
[INFO] Including com.amazonaws:aws-java-sdk-core:jar:1.11.93 in the shaded jar.
[INFO] Including commons-logging:commons-logging:jar:1.1.3 in the shaded jar.
[INFO] Including org.apache.httpcomponents:httpclient:jar:4.5.2 in the shaded jar.
[INFO] Including org.apache.httpcomponents:httpcore:jar:4.4.4 in the shaded jar.
[INFO] Including commons-codec:commons-codec:jar:1.9 in the shaded jar.
[INFO] Including software.amazon.ion:ion-java:jar:1.0.2 in the shaded jar.
[INFO] Including com.fasterxml.jackson.core:jackson-databind:jar:2.6.6 in the shaded jar.
[INFO] Including com.fasterxml.jackson.core:jackson-annotations:jar:2.6.0 in the shaded jar.
[INFO] Including com.fasterxml.jackson.core:jackson-core:jar:2.6.6 in the shaded jar.
[INFO] Including com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:jar:2.6.6 in the shaded jar.
[INFO] Including joda-time:joda-time:jar:2.8.1 in the shaded jar.
[INFO] Including com.amazonaws:jmespath-java:jar:1.11.93 in the shaded jar.
[INFO] Including com.amazonaws:aws-java-sdk-sns:jar:1.11.93 in the shaded jar.
[INFO] Including com.amazonaws:aws-java-sdk-sqs:jar:1.11.93 in the shaded jar.
[INFO] Including com.amazonaws:aws-java-sdk-cognitoidentity:jar:1.11.93 in the shaded jar.
[INFO] Including com.amazonaws:aws-java-sdk-kinesis:jar:1.11.93 in the shaded jar.
[INFO] Including com.amazonaws:aws-java-sdk-dynamodb:jar:1.11.93 in the shaded jar.
[INFO] Replacing original artifact with shaded artifact.
[INFO] Replacing /tmp/aws-lambda-unzip-master/target/aws-lambda-unzip-0.0.1-SNAPSHOT.jar with /tmp/aws-lambda-unzip-master/target/aws-lambda-unzip-0.0.1-SNAPSHOT-shaded.jar
[INFO] Dependency-reduced POM written at: /tmp/aws-lambda-unzip-master/dependency-reduced-pom.xml
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 46.175s
[INFO] Finished at: Mon Feb 20 14:31:14 AEST 2017
[INFO] Final Memory: 46M/248M
[INFO] ------------------------------------------------------------------------
So do I now just upload the aws-lambda-unzip-0.0.1-SNAPSHOT.jar to Lambda? Not sure what to do next

Yes. The rest of the configuration of your lambda should be similar as before, only difference is you upload the jar.

Slowly getting there. Uploaded the aws-lambda-unzip-0.0.1-SNAPSHOT.jar file and ran the test but got this error below.
{
"errorMessage": "Cannot find module '/var/task/kornell'",
"errorType": "Error",
"stackTrace": [
"Function.Module._load (module.js:276:25)",
"Module.require (module.js:353:17)",
"require (internal/module.js:12:17)"
]
}

Node.js 4.3 as Runtime...yeah?

Make sure the runtime parameter for your Lambda is 'Java 8', not Node.js

I must be getting close. Ran the test and ran out of memory, so I upped the memory to 256MB and now see this error.
{
"errorMessage": "Access Denied (Service: Amazon S3; Status Code: 403; Error Code: AccessDenied; Request ID: 39AA857E85B69295)",
"errorType": "com.amazonaws.services.s3.model.AmazonS3Exception",
"stackTrace": [
"com.amazonaws.http.AmazonHttpClient$RequestExecutor.handleErrorResponse(AmazonHttpClient.java:1579)",
"com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeOneRequest(AmazonHttpClient.java:1249)",
"com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeHelper(AmazonHttpClient.java:1030)",
"com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute(AmazonHttpClient.java:742)",
"com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer(AmazonHttpClient.java:716)",
"com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute(AmazonHttpClient.java:699)",
"com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$500(AmazonHttpClient.java:667)",
"com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute(AmazonHttpClient.java:649)",
"com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:513)",
"com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4194)",
"com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4141)",
"com.amazonaws.services.s3.AmazonS3Client.getObject(AmazonS3Client.java:1384)",
"kornell.S3EventProcessorUnzip.handleRequest(S3EventProcessorUnzip.java:54)",
"sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)",
"sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)",
"sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)",
"java.lang.reflect.Method.invoke(Method.java:498)"
]
}
Do I have my test correct? See Below
{
"Records": [
{
"eventVersion": "2.0",
"eventTime": "1970-01-01T00:00:00.000Z",
"requestParameters": {
"sourceIPAddress": "<IP_ADDRESS>"
},
"s3": {
"configurationId": "testConfigRule",
"object": {
"eTag": "0123456789abcdef0123456789abcdef",
"sequencer": "0A1B2C3D4E5F678901",
"key": "publish_Sample_Workbook_-_200_Pages.zip",
"size": 1024
},
"bucket": {
"arn": "arn:aws:s3:::mybucket",
"name": "sourcebucket",
"ownerIdentity": {
"principalId": "EXAMPLE"
}
},
"s3SchemaVersion": "1.0"
},
"responseElements": {
"x-amz-id-2": "EXAMPLE123/5678abcdefghijklambdaisawesome/mnopqrstuvwxyzABCDEFGH",
"x-amz-request-id": "EXAMPLE123456789"
},
"awsRegion": "us-east-1",
"eventName": "ObjectCreated:Put",
"userIdentity": {
"principalId": "EXAMPLE"
},
"eventSource": "aws:s3"
}
]
}
Here is the error
{
"errorMessage": "Unexpected identifier",
"errorType": "SyntaxError",
"stackTrace": [
"Module.load (module.js:343:32)",
"Function.Module._load (module.js:300:12)",
"Module.require (module.js:353:17)",
"require (internal/module.js:12:17)"
]
}

Here is my Trigger type, does this look correct?
Event type: ObjectCreatedByPut
Prefix:
Suffix: .zip

This looks fine. The 403 error means that Lambda does not have access to your S3 bucket when running. Make sure your lambda is using the IAM Role you have created with the policy from https://github.com/Craftware/aws-lambda-unzip#necessary-permissions

WOO HOO Got it working using the test. I had to make the following change to my policy as compared your example.
{
"Effect": "Allow",
"Action": [
"s3:GetObject",
"s3:PutObject",
"s3:DeleteObject"
],
"Resource": [
"arn:aws:s3:::mybucket",
"arn:aws:s3:::mybucket/*"
]
}
Now to test with an actual PUT to make sure the Trigger works.

Do you have an example setting for a trigger?
The files I want to trigger the Lambda on are formatted like this "publish_nameoffile.zip"
I have the following Trigger
Event type: ObjectCreated
Prefix: publish_
Suffix: .zip

The code of the lambda function will already ignore any file without the .zip extension. This configuration looks fine.

okay it looks like it's working but it extracted all the files into the root of the bucket.
I put my zip file in /bucket-name/folder1/folder2/publish_nameoffile.zip
It then extracted the files into /bucket-name
I need them placed in originating folder the zip file is in /bucket-name/folder1/folder2/

Seems the code for the in-place unzip was in another branch. Please pull the latest changes from master, rebuild and re-upload the zip.

Pulled the latest master, recompiled, uploaded the new aws-lambda-unzip-0.0.1-SNAPSHOT.jar and tested.
The Zip file was deleted but no files extracted. Not sure what I'm missing.

Oh and the Build was successful.

T E S T S
Results :
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- maven-jar-plugin:2.2:jar (default-jar) @ aws-lambda-unzip ---
[INFO] Building jar: /tmp/aws-lambda-unzip-master/target/aws-lambda-unzip-0.0.1-SNAPSHOT.jar
[INFO]
[INFO] --- maven-shade-plugin:2.4.1:shade (default) @ aws-lambda-unzip ---
[INFO] Including com.amazonaws:aws-lambda-java-core:jar:1.1.0 in the shaded jar.
[INFO] Including com.amazonaws:aws-lambda-java-events:jar:1.1.0 in the shaded jar.
[INFO] Including com.amazonaws:aws-java-sdk-s3:jar:1.11.93 in the shaded jar.
[INFO] Including com.amazonaws:aws-java-sdk-kms:jar:1.11.93 in the shaded jar.
[INFO] Including com.amazonaws:aws-java-sdk-core:jar:1.11.93 in the shaded jar.
[INFO] Including commons-logging:commons-logging:jar:1.1.3 in the shaded jar.
[INFO] Including org.apache.httpcomponents:httpclient:jar:4.5.2 in the shaded jar.
[INFO] Including org.apache.httpcomponents:httpcore:jar:4.4.4 in the shaded jar.
[INFO] Including commons-codec:commons-codec:jar:1.9 in the shaded jar.
[INFO] Including software.amazon.ion:ion-java:jar:1.0.2 in the shaded jar.
[INFO] Including com.fasterxml.jackson.core:jackson-databind:jar:2.6.6 in the shaded jar.
[INFO] Including com.fasterxml.jackson.core:jackson-annotations:jar:2.6.0 in the shaded jar.
[INFO] Including com.fasterxml.jackson.core:jackson-core:jar:2.6.6 in the shaded jar.
[INFO] Including com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:jar:2.6.6 in the shaded jar.
[INFO] Including joda-time:joda-time:jar:2.8.1 in the shaded jar.
[INFO] Including com.amazonaws:jmespath-java:jar:1.11.93 in the shaded jar.
[INFO] Including com.amazonaws:aws-java-sdk-sns:jar:1.11.93 in the shaded jar.
[INFO] Including com.amazonaws:aws-java-sdk-sqs:jar:1.11.93 in the shaded jar.
[INFO] Including com.amazonaws:aws-java-sdk-cognitoidentity:jar:1.11.93 in the shaded jar.
[INFO] Including com.amazonaws:aws-java-sdk-kinesis:jar:1.11.93 in the shaded jar.
[INFO] Including com.amazonaws:aws-java-sdk-dynamodb:jar:1.11.93 in the shaded jar.
[INFO] Including commons-io:commons-io:jar:2.5 in the shaded jar.
[INFO] Replacing original artifact with shaded artifact.
[INFO] Replacing /tmp/aws-lambda-unzip-master/target/aws-lambda-unzip-0.0.1-SNAPSHOT.jar with /tmp/aws-lambda-unzip-master/target/aws-lambda-unzip-0.0.1-SNAPSHOT-shaded.jar
[INFO] Dependency-reduced POM written at: /tmp/aws-lambda-unzip-master/dependency-reduced-pom.xml
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 7.838s
[INFO] Finished at: Mon Feb 20 15:35:25 AEST 2017
[INFO] Final Memory: 53M/235M
[INFO] ------------------------------------------------------------------------

Can you post the output of the Lambda execution? It should be available in your Cloudwatch logs.

Good work, it seems to be doing as advertised. Thank you very much for your assistance. You may need to update your documentation regarding the policy.
{
"Effect": "Allow",
"Action": [
"s3:GetObject",
"s3:PutObject",
"s3:DeleteObject"
],
"Resource": [
"arn:aws:s3:::mybucket",
"arn:aws:s3:::mybucket/*"
]
}
I need that for it to work.


Cannot build retdec on Ubuntu Linux

When I try to build I receive the following error:
Built target retdec-configtool
-- Could NOT find Python module pygments
-- Could NOT find Python module pygments.lexers.c_cpp
-- Found Python module yaml
-- LLVM host triple: x86_64-unknown-linux-gnu
-- LLVM default target triple: x86_64-unknown-linux-gnu
-- Building with -fPIC
-- Constructing LLVMBuild project information
-- Linker detection: GNU ld
-- Targeting X86
CMake Error at cmake/modules/LLVM-Config.cmake:175 (message):
Target X86 is not in the set of libraries.
Call Stack (most recent call first):
cmake/modules/LLVM-Config.cmake:312 (llvm_map_components_to_libnames)
cmake/modules/AddOCaml.cmake:69 (explicit_map_components_to_libraries)
bindings/ocaml/all_backends/CMakeLists.txt:1 (add_ocaml_library)

Hi, just to be sure are you trying to build the latest RetDec master? As we cannot test it on your system more details on how you tried to build RetDec could come handy. Like, what options did you use with cmake?
From the output it seems that the fail occurred while building included LLVM, during the cmake phase specifically. I don't know whether there might be some clues, but CMake generates error log when error occurs, can you send the log?
There should be something like this at the end of the output:
See also "/home/xkubov/projects/llvm/build/CMakeFiles/CMakeError.log".

Yes I am trying to build master. The steps I followed:

git clone https://github.com/avast/retdec.git
mkdir build && cd build
cmake .. -DCMAKE_INSTALL_PREFIX=
make

Link to CmakeError.log (which does not appear helpful)
https://gist.github.com/testhound/42c46bf566bc22e0f6b47e70546aa7d1
Link to CMakeOutput.log:
https://gist.github.com/testhound/c8be6fe5723af8b26c80e37a695c78b9

I've tested the build on Ubuntu 18.04 and had no problem. What version of Ubuntu and cmake do you use?
Also can you confirm that you are unable to build the following project too?
$ git clone https://github.com/avast/llvm
$ cd llvm
$ mkdir build && cd build
$ cmake .. -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_INCLUDE_TESTS=OFF -DLLVM_INCLUDE_EXAMPLES=OFF -DLLVM_INCLUDE_TOOLS=OFF
$ make

I am running Ubuntu 18.04.1 with cmake 3.10.2.
The cmake line above (step 4) fails for me.

I upgraded my cmake to 3.16.4 and still receive the failure. Here is the cmake output:
https://gist.github.com/testhound/19501f66c743c16e6bf903bc8f1b1486
Note following instruction for the latest llvm works:

git clone https://github.com/llvm/llvm-project.git
cd llvm-project
mkdir build && cd build
cmake ../llvm -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_INCLUDE_TESTS=OFF -DLLVM_INCLUDE_EXAMPLES=OFF -DLLVM_INCLUDE_TOOLS=OFF

Also this succeeds for me with the latest llvm:

git clone https://github.com/llvm/llvm-project.git
cd llvm-project/llvm
mkdir build && cd build
cmake ../ -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_INCLUDE_TESTS=OFF -DLLVM_INCLUDE_EXAMPLES=OFF -DLLVM_INCLUDE_TOOLS=OFF

Thank you for the additional info @testhound. Our LLVM is modified so it does not build parts that are not necessary for RetDec. This speeds up the build. One of the modifications is most probably the reason why the build fails for you with
Target X86 is not in the set of libraries.

 -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_INCLUDE_TESTS=OFF -DLLVM_INCLUDE_EXAMPLES=OFF -DLLVM_INCLUDE_TOOLS=OFF && \
    make -j$(nproc)

It uses Ubuntu 18.04, CMake 3.10.2, Python 2.7, and GCC 7.4.0, just like you do (based on the provided logs).
Before we start blindly changing the code, I would like to be able to reproduce the issue. I wonder what is so specific about your system that we are unable to reproduce the issue... :thinking:

I tried two local build today, using "-DLLVM_LOCAL_DIR=". I tried llvm 9.0 and llvm 8.x. I was able to get past the intital cmake error above but ran into compiler errors as the llvm code appears to have diverged.

I was able to determine the difference by comparing your cmake log with mine. The difference is that you have ocaml-findlib and libctypes-ocaml installed in your system, which triggers the build of OCaml bindings:
-- OCaml bindings enabled.

 -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_INCLUDE_TESTS=OFF -DLLVM_INCLUDE_EXAMPLES=OFF -DLLVM_INCLUDE_TOOLS=OFF

When we were modifying LLVM sources, we probably forgot about some file as we have never tried building OCaml bindings. Let me take a look and try to fix the issue.

In commit 02c33a8f48a342ed77cb7336b2161a6f371a05da, I have disabled the build of bindings when building LLVM. Reasons:

We do not need them. This should speed up the build.
Our modified version of LLVM does not build correctly when building OCaml bindings. Since we want to build only the very necessary parts, disable the build of all bindings.

Could you please try building the current RetDec's master to see if you are able to finish the build?

s3rvac thank you that solved my problem!

Great! Happy to help.


Conflict with Composer requirements

I have these two conflicting packages in my composer.json:
"apigen/apigen": "~4.0",
"anahkiasen/rocketeer": "~2.0"

Running composer update results in a conflict for requirement symfony/console:
- apigen/apigen v4.0.0 requires symfony/console ~2.6 -> satisfiable by symfony/console[v2.6.3, v2.6.0, v2.6.1, v2.6.2].
- Can only install one of: symfony/console[v2.6.0, v2.5.0].
- Can only install one of: symfony/console[v2.6.1, v2.5.0].
- illuminate/console v4.2.1 requires symfony/console 2.5.* -> satisfiable by symfony/console[v2.5.0, v2.5.1, v2.5.2, v2.5.3, v2.5.4, v2.5.5, v2.5.6, v2.5.7, v2.5.8, v2.5.9].

How can I solve this problem? illuminate/console dev-master already requires 2.6

Hm not sure there is much I can do, this is more of an issue with illuminate/console. I can't update to illuminate/console:~5.0 as it includes a lot of breaking changes, best solution would be to ask for the Symfony components to be bumped to 2.6 on Laravel's end

Reposted: https://github.com/laravel/framework/issues/7004

Note that alternatively you can also install Rocketeer globally or use the PHAR

I agree this is a bit of a bummer. I want laravel 5 to use ~2.3 and ~2.5` for the various symfony components but Taylor doesn't agree with me. What do you two think about that change?


User not prevented from deploying app in Github Source Type without Repository selected

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
While testing Deploy an application from Github (https://github.com/epinio/ui/issues/149) the expected behavior is that when a SourceType=Github is selected, the user should be prompted to enter the username/organization name first and the repository second and the branch third and the specific commit in 4th place in order to continue the deployment process; like this:

However it is possible to bypass if an user makes a normal selection as previously described, goes to the next screen and later returns to the previous one:

Expected Behavior
If an user selects Source Type = GitHub he/she should be forced to follow the path of selection username > repository > branch > commit
Steps To Reproduce

Install epinio on latest UI dashboard (it has to contain this issue: https://github.com/epinio/ui/issues/149)
Start deploying an app with Source Type = Github
Set username=epinio; repository=example-go; branch=main; commit; any. Expect Next button to be enabled
On next screen click on Previous button on bottom right corner
Once in the previous screen observe how Next button is enabled:

Environment
- OS:Linux
- Architecture:amd
- Epinio Version:1.1.0-latest
- Cluster:
  - Provider:
  - Options:
  - Kubernetes Version:

Logs
No response
Anything else?
No response

I just noticed the same thing happens without the need of changing screens if you select different repos.
Steps to reproduce:

Install epinio on latest UI dashboard (it has to contain this issue: https://github.com/epinio/ui/issues/149)
Start deploying an app with Source Type = Github
Set username=epinio; repository=example-go; branch=main; commit; any. Expect Next button to be enabled
Change username to other thing (ie:google)

Observe how click button is still enabled without having selected the rest of fields
@scures  is this part of the same bug or should it have a separate ticket?

Checked on epinio-dev and working
Checked Scenario 1 (original one):
After selecting everything and going back the commit table is unchecked, and so it the next button:

Also tested Scenario 2, changing username will reset everything:


Attempt to invoke virtual method play on a null object reference

Hello,
I am testing your library with a simple code
    JcPlayerView jcplayerView = (JcPlayerView) findViewById(R.id.jcplayer);
    ArrayList<JcAudio> jcAudios = new ArrayList<>();
    jcAudios.add(JcAudio.createFromFilePath("Asset audio", "/sdcard/Download/"+audioname));
    jcplayerView.initPlaylist(jcAudios);

    jcplayerView.playAudio(jcplayerView.getMyPlaylist().get(0));

And if I comment out the last line, a player shows in the activity and works awesome. However if i leave the line uncommented I get Attempt to invoke virtual method 'void com.example.jean.jcplayer.JcPlayerService.play(com.example.jean.jcplayer.JcAudio)' on a null object reference. The object I am referencing is not null, I checked that. What I am trying to do here is to autoplay the audio. Any idea why this is so? I am writing here as it seems to be a bug.
BTW, love the library.
Very best regards.

I am getting this error too and I try everything about that I didn't fixed yet.

This error happens because when initializing a playlist and next play an audio, the service is not ready yet, so a NullPointerException is thrown.
I am working to fix it, soon I release a new version.
Thank you for all :D

⚠   ⚠   ⚠  WARN  ⚠   ⚠   ⚠
For versions > 2.6.0-alpha, I  have changed the repository to Jitpack repository. See the docs for more information.
From this version the issue is solved: com.github.jeancsanchez:JcPlayer:2.6.10'