feat: rename "Saved Alerts" to "Alerts"

This PR resolves ONYX-565
Description
feat: rename "Saved Alerts" to "Alerts"
PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

feat: rename "Saved Alerts" to "Alerts" — devon

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (feat: rename "Saved Alerts" to "Alerts" — devon)

  Generated by :no_entry_sign: dangerJS against 118234136a4a04eac4fd75eea7ac5d069a1c9f46


Fix SHA1 hash linking

This changes the regex to look for a hash from 7 to 40 characters,
to match the use of abbreviated hash lookups in both git and github.
The restriction of not being a pure number is also removed because
1234567 is now considered a valid abbreviated hash, as is deadbeef.
A note has been added to the top of the code to state that the
literal regex match is fine, but no extra validation is currently
performed so some false positives are expected.
A future change could ensure that the hash exists in the repository
before rendering it as a link, although this might incur a slight
performance penalty.
Reverts part of commit 4a46613 and fixes #2053.

Can you add additional tests to markdown_test.go file?

LGTM

LGTM

A future change could ensure that the hash exists in the repository
before rendering it as a link, although this might incur a slight
performance penalty.

Please make a PR or an Issue 😉

Anyone could back port this to release/v1.1?


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-22-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 789

Questions ?
Please refer to the Backport tool documentation


Cleanup one-off development containers created via make

Before, any one-off container made by these make tasks hangs around in
an exited state after command execution is terminated - notice
development_app_run_e3b196b37f5d in the example below:
[maximilian: development] cleanup-one-off-development-containers *^ →
$ make rspec
docker-compose run app bin/rspec

...snip...

Finished in 36.48 seconds (files took 11.52 seconds to load)
286 examples, 0 failures, 177 pending

Randomized with seed 34516

[maximilian: development] cleanup-one-off-development-containers *^ →
$ docker-compose ps -a
              Name                            Command               State                 Ports
-------------------------------------------------------------------------------------------------------------
development_app_run_e3b196b37f5d   bin/rspec                        Exit 0
development_db_1                   docker-entrypoint.sh postgres    Up       5432/tcp
development_email_1                mailcatcher --foreground - ...   Up       1025/tcp, <IP_ADDRESS>:1080->1080/tcp

After, one off containers delete themselves when the container
exits. Notice in the example below that the
development_app_run_<container-id> container is not present after execution:
[maximilian: development] cleanup-one-off-development-containers +^ →
$ make rspec
docker-compose run --rm app bin/rspec

...snip...

Finished in 38.43 seconds (files took 11.91 seconds to load)
286 examples, 0 failures, 177 pending

Randomized with seed 10269

[maximilian: development] cleanup-one-off-development-containers +^ →
$ docker-compose ps -a
       Name                      Command               State                Ports
-----------------------------------------------------------------------------------------------
development_db_1      docker-entrypoint.sh postgres    Up      5432/tcp
development_email_1   mailcatcher --foreground - ...   Up      1025/tcp, <IP_ADDRESS>:1080->1080/tcp

Nice and tidy.

Cheers, mate!


Fix plugin remove for 2.x

bin/plugin does not have "--remove" option now, "remove" must be used instead.

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

Hi,
Thank you for the PR.
Since this module still needs to work with ES 1.x releases I will have to check if this change works there as well.
Since there are some more changes for ES 2.x required that are not backwards compatible i will most likely have to do 2 releases of the module and have 2 branches so that i can still work on ES 1.x things as well.

Hi,
Thank you very much for the PR but I've decided to merge #477 since it allows for backwards compat working with ES 1.x
PR #483 adds the test as well for ES 2.x
I'm planning to do a release early this week.

Hi. I'm ok with that, thank you!


invalid character error stopping android build

almost ready to do a next release for Electron Cash, but i would like to build 2.9.2 for android.  getting this error in build process
www.pastebin.com/yc9LvnuH

i think this is because of Electron-Cash has a dash in the name. testing without it...


typescript

Is this a bug report?
(write your answer here)

Can you also reproduce the problem with npm 4.x?

(Write your answer here.)
Which terms did you search for in User Guide?

(Write your answer here if relevant.)
Environment

node -v:
npm -v:
yarn --version (if you use Yarn):
npm ls react-scripts (if you haven’t ejected):

Then, specify:

Operating system:
Browser and version (if relevant):

Steps to Reproduce

(Write your steps here:)

Expected Behavior

(Write what you thought would happen.)
Actual Behavior

(Write what happened. Please add screenshots!)
Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

TypeScript is now officially supported as of Create React App 2.1. Read the release notes to get started!


Added information about how to draw a polygon

Some modifications were made in "Annotate" to bring some clarity about the way to draw the rectangle and the polygon for an image annotation (Fix #78).

Sorry for taking so long to get back on the PR! It looks all good, I added you in the authors and changed the date + fixed a couple of typos. Ready to merge!


Setup ReadTheDocs and properly comment everything.

To override the version included in your build, you can install this driver inside your board's / or /lib.
Change to:
To override the version included in your build, you can install this driver inside your board's /.

sys.path by default is ['', '/', '.frozen', '/lib']. This means that .frozen takes precedence over /lib.


Getting Lipo error while archiving build

Hi,
I am using Realm 5.0.1 with COCOAPODS. Everything is working fine when I debug my application with out any issues. But when I tried to archive my application getting following error
Build/Intermediates.noindex/ArchiveIntermediates/WhiteCoats\ QA/IntermediateBuildFilesPath/UninstalledProducts/iphoneos/Realm.framework/Realm
error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't move temporary file: /DerivedData/MyProject-ahsjmvfmwijwylcysqqjxydwbhiv/Build/Intermediates.noindex/ArchiveIntermediates/MyProject/IntermediateBuildFilesPath/UninstalledProducts/iphoneos/Realm.framework/Realm to file: Path/Xcode/DerivedData/MyProject-ahsjmvfmwijwylcysqqjxydwbhiv/Build/Intermediates.noindex/ArchiveIntermediates/MyProject/IntermediateBuildFilesPath/UninstalledProducts/iphoneos/Realm.framework/Realm.lipo (No such file or directory)
Command /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo emitted errors but did not return a nonzero exit code to indicate failure

@pavanbalu
Could you share more detail using the issue format?
Please include the Xcode version as well. Thanks!


EDC 0.4.1, When the contract is in the verified status on the consumer side, the data still can be transferred with http dataplane

Bug Report

A MVP solution is set based on the EDC library 0.4.1: https://github.com/Informatievlaanderen/VSDS-Dataspace-Connector/blob/main/gradle/libs.versions.toml
Full E2E procedure is https://github.com/Informatievlaanderen/VSDS-LDES-E2E-testing/tree/main/tests/034.dataspace-connector-consumer-and-provider#8-start-the-workbench-with-the-ldesclient

Describe the Bug
When the contract is in the verified status on the consumer side, the data still can be transferred from provider to consumer..
Steps to Reproduce

The following docker containers are up and running, did:web with NGIX server providing did documented is used as identity management tool.

Dataset and its policy has been published to the provider side:

{
    "@id": "fe1d4ebe-9d30-4e9c-a209-71f465413a3c",
    "@type": "dcat:Catalog",
    "dcat:dataset": {
        "@id": "devices",
        "@type": "dcat:Dataset",
        "odrl:hasPolicy": {
            "@id": "MQ==:ZGV2aWNlcw==:M2JiYWI2MTUtZTIxYi00ZGZjLWJhZDYtMzk2ZTdkMWFlYTRk",
            "@type": "odrl:Set",
            "odrl:permission": [],
            "odrl:prohibition": [],
            "odrl:obligation": [],
            "odrl:target": {
                "@id": "devices"
            }
        },
        "dcat:distribution": [
            {
                "@type": "dcat:Distribution",
                "dct:format": {
                    "@id": "HttpProxy"
                },
                "dcat:accessService": "2b4052a6-64ed-4ba4-a7c6-7eb5fe4d9d32"
            },
            {
                "@type": "dcat:Distribution",
                "dct:format": {
                    "@id": "HttpData"
                },
                "dcat:accessService": "2b4052a6-64ed-4ba4-a7c6-7eb5fe4d9d32"
            }
        ],
        "name": "device models",
        "id": "devices",
        "contenttype": "application/n-quads"
    },
    "dcat:service": {
        "@id": "2b4052a6-64ed-4ba4-a7c6-7eb5fe4d9d32",
        "@type": "dcat:DataService",
        "dct:terms": "connector",
        "dct:endpointUrl": "http://provider-connector:19194/protocol"
    },
    "participantId": "did:web:did-server:provider",
    "@context": {
        "@vocab": "https://w3id.org/edc/v0.0.1/ns/",
        "edc": "https://w3id.org/edc/v0.0.1/ns/",
        "dcat": "https://www.w3.org/ns/dcat/",
        "dct": "https://purl.org/dc/terms/",
        "odrl": "http://www.w3.org/ns/odrl/2/",
        "dspace": "https://w3id.org/dspace/v0.8/"
    }
}

Following contracted is sent from consumer to provider

{
  "@context": {
    "edc": "https://w3id.org/edc/v0.0.1/ns/",
    "odrl": "http://www.w3.org/ns/odrl/2/"
  },
  "@type": "NegotiationInitiateRequestDto",
  "connectorId": "provider",
  "connectorAddress": "http://provider-connector:19194/protocol",
  "consumerId": "consumer",
  "providerId": "provider",
  "protocol": "dataspace-protocol-http",
  "offer": {
   "offerId": "MQ==:ZGV2aWNlcw==:M2JiYWI2MTUtZTIxYi00ZGZjLWJhZDYtMzk2ZTdkMWFlYTRk",
   "assetId": "devices",
   "policy": {
     "@id": "MQ==:ZGV2aWNlcw==:M2JiYWI2MTUtZTIxYi00ZGZjLWJhZDYtMzk2ZTdkMWFlYTRk",
     "@type": "Set",
     "odrl:permission": [],
     "odrl:prohibition": [],
     "odrl:obligation": [],
     "odrl:target": "devices"
   }
  }
}

and got response
{
    "@type": "IdResponse",
    "@id": "99e37c99-9e18-40a0-b570-7e742fd77f43",
    "createdAt":<PHONE_NUMBER>781,
    "@context": {
        "@vocab": "https://w3id.org/edc/v0.0.1/ns/",
        "edc": "https://w3id.org/edc/v0.0.1/ns/",
        "odrl": "http://www.w3.org/ns/odrl/2/"
    }
}

In the log of provider we can see the error:

2024-02-15 11:19:09 SEVERE 2024-02-15T10:19:09.633130666 ContractNegotiation: ID 100c11cf-9af5-45e8-b635-350eaec90e45. Fatal error while [Provider] send finalization. Error details: {"@type":"dspace:ContractNegotiationError","dspace:code":"400","dspace:reason":"Invalid client credentials: Invalid counter-party identity","dspace:processId":"99e37c99-9e18-40a0-b570-7e742fd77f43","@context":{"@vocab":"https://w3id.org/edc/v0.0.1/ns/","edc":"https://w3id.org/edc/v0.0.1/ns/","dcat":"https://www.w3.org/ns/dcat/","dct":"https://purl.org/dc/terms/","odrl":"http://www.w3.org/ns/odrl/2/","dspace":"https://w3id.org/dspace/v0.8/"}}

On the consumer side the contract stays at verified

{
    "@type": "ContractNegotiation",
    "@id": "99e37c99-9e18-40a0-b570-7e742fd77f43",
    "type": "CONSUMER",
    "protocol": "dataspace-protocol-http",
    "state": "VERIFIED",
    "counterPartyId": "provider",
    "counterPartyAddress": "http://provider-connector:19194/protocol",
    "callbackAddresses": [],
    "createdAt":<PHONE_NUMBER>781,
    "contractAgreementId": "36ec20b7-e72f-4ea4-8079-568b2fc72e9e",
    "@context": {
        "@vocab": "https://w3id.org/edc/v0.0.1/ns/",
        "edc": "https://w3id.org/edc/v0.0.1/ns/",
        "odrl": "http://www.w3.org/ns/odrl/2/"
    }
}

On the provider is terminated
{
    "@type": "ContractNegotiation",
    "@id": "100c11cf-9af5-45e8-b635-350eaec90e45",
    "type": "PROVIDER",
    "protocol": "dataspace-protocol-http",
    "state": "TERMINATED",
    "counterPartyId": "did:web:did-server:consumer",
    "counterPartyAddress": "http://consumer-connector:29194/protocol",
    "callbackAddresses": [],
    "createdAt":<PHONE_NUMBER>666,
    "contractAgreementId": "36ec20b7-e72f-4ea4-8079-568b2fc72e9e",
    "errorDetail": "{\"@type\":\"dspace:ContractNegotiationError\",\"dspace:code\":\"400\",\"dspace:reason\":\"Invalid client credentials: Invalid counter-party identity\",\"dspace:processId\":\"99e37c99-9e18-40a0-b570-7e742fd77f43\",\"@context\":{\"@vocab\":\"https://w3id.org/edc/v0.0.1/ns/\",\"edc\":\"https://w3id.org/edc/v0.0.1/ns/\",\"dcat\":\"https://www.w3.org/ns/dcat/\",\"dct\":\"https://purl.org/dc/terms/\",\"odrl\":\"http://www.w3.org/ns/odrl/2/\",\"dspace\":\"https://w3id.org/dspace/v0.8/\"}}",
    "@context": {
        "@vocab": "https://w3id.org/edc/v0.0.1/ns/",
        "edc": "https://w3id.org/edc/v0.0.1/ns/",
        "odrl": "http://www.w3.org/ns/odrl/2/"
    }
}

Current result,
If now use the    "contractAgreementId": "36ec20b7-e72f-4ea4-8079-568b2fc72e9e" call for the data transfer, the data transfer works...
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.694501647 DSP: Incoming TransferStartMessage for class org.eclipse.edc.connector.transfer.spi.types.TransferProcess process: 5f8bf783-4444-4264-86df-a669ddd0f378
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.694798449 Starting verification...
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.694873745 Resolving other party's DID Document
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.701731731 Extracting public key
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.702018022 Verifying JWT with public key...
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.703634935 verification successful! Fetching data from IdentityHub
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.703716289 Retrieving verified credentials for did:web:did-server:provider
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.703752747 Using identity hub URL: http://provider-connector:19191/api/identity-hub
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.707995551 Retrieved 0 verifiable credentials from identity hub
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.708174546 Building ClaimToken
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.710600295 TransferProcess 5f8bf783-4444-4264-86df-a669ddd0f378 is now in state STARTED
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.71275019 Sending EDR to http://ldio-workbench:8082/client-pipeline/token
2024-02-15 11:22:18 DEBUG 2024-02-15T10:22:18.507268245 Transferring from HttpData to Api-response.
2024-02-15 11:22:18 DEBUG 2024-02-15T10:22:18.508020556 Executing HTTP request: http://ldes-server:8081/devices

I think the data should not be available to consumer now right? as the contracted is not in finalized status
Full log of provider:
2024-02-15 11:19:06 DEBUG 2024-02-15T10:19:06.642303015 DSP: Incoming ContractRequestMessage for class org.eclipse.edc.connector.contract.spi.types.negotiation.ContractNegotiation process
2024-02-15 11:19:06 DEBUG 2024-02-15T10:19:06.642554763 Starting verification...
2024-02-15 11:19:06 DEBUG 2024-02-15T10:19:06.642606221 Resolving other party's DID Document
2024-02-15 11:19:06 DEBUG 2024-02-15T10:19:06.647263785 Extracting public key
2024-02-15 11:19:06 DEBUG 2024-02-15T10:19:06.647564455 Verifying JWT with public key...
2024-02-15 11:19:06 DEBUG 2024-02-15T10:19:06.651741986 verification successful! Fetching data from IdentityHub
2024-02-15 11:19:06 DEBUG 2024-02-15T10:19:06.651875062 Retrieving verified credentials for did:web:did-server:consumer
2024-02-15 11:19:06 DEBUG 2024-02-15T10:19:06.651934838 Using identity hub URL: http://consumer-connector:29191/api/identity-hub
2024-02-15 11:19:06 DEBUG 2024-02-15T10:19:06.65801667 Retrieved 0 verifiable credentials from identity hub
2024-02-15 11:19:06 DEBUG 2024-02-15T10:19:06.658328257 Building ClaimToken
2024-02-15 11:19:06 DEBUG 2024-02-15T10:19:06.667794505 [PROVIDER] ContractNegotiation 100c11cf-9af5-45e8-b635-350eaec90e45 is now in state REQUESTED.
2024-02-15 11:19:07 DEBUG 2024-02-15T10:19:07.588750331 [ProviderContractNegotiationManagerImpl] ContractNegotiation 100c11cf-9af5-45e8-b635-350eaec90e45 is now in state AGREEING
2024-02-15 11:19:07 DEBUG 2024-02-15T10:19:07.591571935 ContractNegotiation: ID 100c11cf-9af5-45e8-b635-350eaec90e45. [Provider] send agreement
2024-02-15 11:19:07 DEBUG 2024-02-15T10:19:07.691939971 ContractNegotiation: ID 100c11cf-9af5-45e8-b635-350eaec90e45. [Provider] send agreement
2024-02-15 11:19:07 DEBUG 2024-02-15T10:19:07.692168727 [ProviderContractNegotiationManagerImpl] ContractNegotiation 100c11cf-9af5-45e8-b635-350eaec90e45 is now in state AGREED
2024-02-15 11:19:08 DEBUG 2024-02-15T10:19:08.651628088 DSP: Incoming ContractAgreementVerificationMessage for class org.eclipse.edc.connector.contract.spi.types.negotiation.ContractNegotiation process: 99e37c99-9e18-40a0-b570-7e742fd77f43
2024-02-15 11:19:08 DEBUG 2024-02-15T10:19:08.652102304 Starting verification...
2024-02-15 11:19:08 DEBUG 2024-02-15T10:19:08.65223401 Resolving other party's DID Document
2024-02-15 11:19:08 DEBUG 2024-02-15T10:19:08.657486682 Extracting public key
2024-02-15 11:19:08 DEBUG 2024-02-15T10:19:08.657789581 Verifying JWT with public key...
2024-02-15 11:19:08 DEBUG 2024-02-15T10:19:08.660313 verification successful! Fetching data from IdentityHub
2024-02-15 11:19:08 DEBUG 2024-02-15T10:19:08.660460502 Retrieving verified credentials for did:web:did-server:consumer
2024-02-15 11:19:08 DEBUG 2024-02-15T10:19:08.660539953 Using identity hub URL: http://consumer-connector:29191/api/identity-hub
2024-02-15 11:19:08 DEBUG 2024-02-15T10:19:08.665036093 Retrieved 0 verifiable credentials from identity hub
2024-02-15 11:19:08 DEBUG 2024-02-15T10:19:08.665350344 Building ClaimToken
2024-02-15 11:19:08 DEBUG 2024-02-15T10:19:08.667265982 [PROVIDER] ContractNegotiation 100c11cf-9af5-45e8-b635-350eaec90e45 is now in state VERIFIED.
2024-02-15 11:19:09 DEBUG 2024-02-15T10:19:09.607086275 [ProviderContractNegotiationManagerImpl] ContractNegotiation 100c11cf-9af5-45e8-b635-350eaec90e45 is now in state FINALIZING
2024-02-15 11:19:09 DEBUG 2024-02-15T10:19:09.608566828 ContractNegotiation: ID 100c11cf-9af5-45e8-b635-350eaec90e45. [Provider] send finalization
2024-02-15 11:19:09 DEBUG 2024-02-15T10:19:09.632693782 ContractNegotiation: ID 100c11cf-9af5-45e8-b635-350eaec90e45. [Provider] send finalization
2024-02-15 11:19:09 SEVERE 2024-02-15T10:19:09.633130666 ContractNegotiation: ID 100c11cf-9af5-45e8-b635-350eaec90e45. Fatal error while [Provider] send finalization. Error details: {"@type":"dspace:ContractNegotiationError","dspace:code":"400","dspace:reason":"Invalid client credentials: Invalid counter-party identity","dspace:processId":"99e37c99-9e18-40a0-b570-7e742fd77f43","@context":{"@vocab":"https://w3id.org/edc/v0.0.1/ns/","edc":"https://w3id.org/edc/v0.0.1/ns/","dcat":"https://www.w3.org/ns/dcat/","dct":"https://purl.org/dc/terms/","odrl":"http://www.w3.org/ns/odrl/2/","dspace":"https://w3id.org/dspace/v0.8/"}}
2024-02-15 11:19:09 DEBUG 2024-02-15T10:19:09.633535473 [ProviderContractNegotiationManagerImpl] ContractNegotiation 100c11cf-9af5-45e8-b635-350eaec90e45 is now in state TERMINATED
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.727109696 DSP: Incoming TransferRequestMessage for class org.eclipse.edc.connector.transfer.spi.types.TransferProcess process
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.727440936 Starting verification...
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.72750346 Resolving other party's DID Document
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.734876503 Extracting public key
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.73525345 Verifying JWT with public key...
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.737004334 verification successful! Fetching data from IdentityHub
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.73707733 Retrieving verified credentials for did:web:did-server:consumer
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.737113285 Using identity hub URL: http://consumer-connector:29191/api/identity-hub
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.741577837 Retrieved 0 verifiable credentials from identity hub
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.741760673 Building ClaimToken
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.744939353 TransferProcess 2bb47595-6d34-49ad-b44f-b8fbe46580ac is now in state INITIAL
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.674903402 [TransferProcessManagerImpl] TransferProcess 2bb47595-6d34-49ad-b44f-b8fbe46580ac is now in state PROVISIONING
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.676691257 TransferProcess: ID 2bb47595-6d34-49ad-b44f-b8fbe46580ac. Provisioning
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.679189892 [TransferProcessManagerImpl] TransferProcess 2bb47595-6d34-49ad-b44f-b8fbe46580ac is now in state PROVISIONED
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.679904226 [TransferProcessManagerImpl] TransferProcess 2bb47595-6d34-49ad-b44f-b8fbe46580ac is now in state STARTING
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.680574772 TransferProcess: ID 2bb47595-6d34-49ad-b44f-b8fbe46580ac. Initiate data flow
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.687188883 TransferProcess: ID 2bb47595-6d34-49ad-b44f-b8fbe46580ac. Send TransferStartMessage to http://consumer-connector:29194/protocol
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.71395309 TransferProcess: ID 2bb47595-6d34-49ad-b44f-b8fbe46580ac. Send TransferStartMessage to http://consumer-connector:29194/protocol
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.714531821 [TransferProcessManagerImpl] TransferProcess 2bb47595-6d34-49ad-b44f-b8fbe46580ac is now in state STARTED
2024-02-15 11:25:42 DEBUG 2024-02-15T10:25:42.201129934 DSP: Incoming CatalogRequestMessage for class org.eclipse.edc.catalog.spi.Catalog process
2024-02-15 11:25:42 DEBUG 2024-02-15T10:25:42.201405779 Starting verification...
2024-02-15 11:25:42 DEBUG 2024-02-15T10:25:42.20145101 Resolving other party's DID Document
2024-02-15 11:25:42 DEBUG 2024-02-15T10:25:42.207398653 Extracting public key
2024-02-15 11:25:42 DEBUG 2024-02-15T10:25:42.207702799 Verifying JWT with public key...
2024-02-15 11:25:42 DEBUG 2024-02-15T10:25:42.209809548 verification successful! Fetching data from IdentityHub
2024-02-15 11:25:42 DEBUG 2024-02-15T10:25:42.209906707 Retrieving verified credentials for did:web:did-server:federated-authority
2024-02-15 11:25:42 DEBUG 2024-02-15T10:25:42.20994707 Using identity hub URL: http://federated-authority:8181/api/identity-hub
2024-02-15 11:25:42 DEBUG 2024-02-15T10:25:42.287058437 Retrieved 0 verifiable credentials from identity hub
2024-02-15 11:25:42 DEBUG 2024-02-15T10:25:42.287290788 Building ClaimToken
2024-02-15 11:34:02 DEBUG 2024-02-15T10:34:02.104884232 DSP: Incoming CatalogRequestMessage for class org.eclipse.edc.catalog.spi.Catalog process
2024-02-15 11:34:02 DEBUG 2024-02-15T10:34:02.105158255 Starting verification...
2024-02-15 11:34:02 DEBUG 2024-02-15T10:34:02.105214718 Resolving other party's DID Document
2024-02-15 11:34:02 DEBUG 2024-02-15T10:34:02.110227166 Extracting public key
2024-02-15 11:34:02 DEBUG 2024-02-15T10:34:02.110586616 Verifying JWT with public key...
2024-02-15 11:34:02 DEBUG 2024-02-15T10:34:02.112539832 verification successful! Fetching data from IdentityHub
2024-02-15 11:34:02 DEBUG 2024-02-15T10:34:02.112691371 Retrieving verified credentials for did:web:did-server:federated-authority
2024-02-15 11:34:02 DEBUG 2024-02-15T10:34:02.112735076 Using identity hub URL: http://federated-authority:8181/api/identity-hub
2024-02-15 11:34:02 DEBUG 2024-02-15T10:34:02.119745623 Retrieved 0 verifiable credentials from identity hub
2024-02-15 11:34:02 DEBUG 2024-02-15T10:34:02.119917943 Building ClaimToken

full log of consumer
2024-02-15 11:19:05 WARNING 2024-02-15T10:19:05.774262085 The attribute https://w3id.org/edc/v0.0.1/ns/connectorAddress has been deprecated in type https://w3id.org/edc/v0.0.1/ns/ContractRequest, please use https://w3id.org/edc/v0.0.1/ns/counterPartyAddress
2024-02-15 11:19:05 WARNING 2024-02-15T10:19:05.77482416 The attribute https://w3id.org/edc/v0.0.1/ns/offer has been deprecated in type https://w3id.org/edc/v0.0.1/ns/ContractRequest, please use https://w3id.org/edc/v0.0.1/ns/policy
2024-02-15 11:19:05 DEBUG 2024-02-15T10:19:05.784107379 [ConsumerContractNegotiationManagerImpl] ContractNegotiation 99e37c99-9e18-40a0-b570-7e742fd77f43 is now in state INITIAL
2024-02-15 11:19:06 DEBUG 2024-02-15T10:19:06.622670232 [ConsumerContractNegotiationManagerImpl] ContractNegotiation 99e37c99-9e18-40a0-b570-7e742fd77f43 is now in state REQUESTING
2024-02-15 11:19:06 DEBUG 2024-02-15T10:19:06.624485168 ContractNegotiation: ID 99e37c99-9e18-40a0-b570-7e742fd77f43. [Consumer] Send ContractRequestMessage message
2024-02-15 11:19:06 DEBUG 2024-02-15T10:19:06.673923982 ContractNegotiation: ID 99e37c99-9e18-40a0-b570-7e742fd77f43. [Consumer] Send ContractRequestMessage message
2024-02-15 11:19:06 DEBUG 2024-02-15T10:19:06.674120001 [ConsumerContractNegotiationManagerImpl] ContractNegotiation 99e37c99-9e18-40a0-b570-7e742fd77f43 is now in state REQUESTED
2024-02-15 11:19:07 DEBUG 2024-02-15T10:19:07.613409762 DSP: Incoming ContractAgreementMessage for class org.eclipse.edc.connector.contract.spi.types.negotiation.ContractNegotiation process: 99e37c99-9e18-40a0-b570-7e742fd77f43
2024-02-15 11:19:07 DEBUG 2024-02-15T10:19:07.615689909 Starting verification...
2024-02-15 11:19:07 DEBUG 2024-02-15T10:19:07.6158342 Resolving other party's DID Document
2024-02-15 11:19:07 DEBUG 2024-02-15T10:19:07.633765905 Extracting public key
2024-02-15 11:19:07 DEBUG 2024-02-15T10:19:07.635343356 Verifying JWT with public key...
2024-02-15 11:19:07 DEBUG 2024-02-15T10:19:07.638885764 verification successful! Fetching data from IdentityHub
2024-02-15 11:19:07 DEBUG 2024-02-15T10:19:07.639463779 Retrieving verified credentials for did:web:did-server:provider
2024-02-15 11:19:07 DEBUG 2024-02-15T10:19:07.640608306 Using identity hub URL: http://provider-connector:19191/api/identity-hub
2024-02-15 11:19:07 DEBUG 2024-02-15T10:19:07.669429204 Retrieved 0 verifiable credentials from identity hub
2024-02-15 11:19:07 DEBUG 2024-02-15T10:19:07.671340654 Building ClaimToken
2024-02-15 11:19:07 DEBUG 2024-02-15T10:19:07.688816759 [CONSUMER] ContractNegotiation 99e37c99-9e18-40a0-b570-7e742fd77f43 is now in state AGREED.
2024-02-15 11:19:08 DEBUG 2024-02-15T10:19:08.636620813 [ConsumerContractNegotiationManagerImpl] ContractNegotiation 99e37c99-9e18-40a0-b570-7e742fd77f43 is now in state VERIFYING
2024-02-15 11:19:08 DEBUG 2024-02-15T10:19:08.638731539 ContractNegotiation: ID 99e37c99-9e18-40a0-b570-7e742fd77f43. [consumer] send ContractAgreementVerificationMessage
2024-02-15 11:19:08 DEBUG 2024-02-15T10:19:08.669606293 ContractNegotiation: ID 99e37c99-9e18-40a0-b570-7e742fd77f43. [consumer] send ContractAgreementVerificationMessage
2024-02-15 11:19:08 DEBUG 2024-02-15T10:19:08.669787788 [ConsumerContractNegotiationManagerImpl] ContractNegotiation 99e37c99-9e18-40a0-b570-7e742fd77f43 is now in state VERIFIED
2024-02-15 11:19:09 DEBUG 2024-02-15T10:19:09.615566055 DSP: Incoming ContractNegotiationEventMessage for class org.eclipse.edc.connector.contract.spi.types.negotiation.ContractNegotiation process: 99e37c99-9e18-40a0-b570-7e742fd77f43
2024-02-15 11:19:09 DEBUG 2024-02-15T10:19:09.615826207 Starting verification...
2024-02-15 11:19:09 DEBUG 2024-02-15T10:19:09.615897317 Resolving other party's DID Document
2024-02-15 11:19:09 DEBUG 2024-02-15T10:19:09.620674025 Extracting public key
2024-02-15 11:19:09 DEBUG 2024-02-15T10:19:09.62094611 Verifying JWT with public key...
2024-02-15 11:19:09 DEBUG 2024-02-15T10:19:09.62313152 verification successful! Fetching data from IdentityHub
2024-02-15 11:19:09 DEBUG 2024-02-15T10:19:09.623265851 Retrieving verified credentials for did:web:did-server:provider
2024-02-15 11:19:09 DEBUG 2024-02-15T10:19:09.623357836 Using identity hub URL: http://provider-connector:19191/api/identity-hub
2024-02-15 11:19:09 DEBUG 2024-02-15T10:19:09.627472347 Retrieved 0 verifiable credentials from identity hub
2024-02-15 11:19:09 DEBUG 2024-02-15T10:19:09.627684702 Building ClaimToken
2024-02-15 11:19:09 DEBUG 2024-02-15T10:19:09.629213551 DSP: Service call failed: Invalid client credentials: Invalid counter-party identity
2024-02-15 11:22:12 WARNING 2024-02-15T10:22:12.1828766 The attribute https://w3id.org/edc/v0.0.1/ns/connectorAddress has been deprecated in type https://w3id.org/edc/v0.0.1/ns/TransferRequest, please use https://w3id.org/edc/v0.0.1/ns/counterPartyAddress
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.190004859 [TransferProcessManagerImpl] TransferProcess 5f8bf783-4444-4264-86df-a669ddd0f378 is now in state INITIAL
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.191815198 Process 5f8bf783-4444-4264-86df-a669ddd0f378 is now INITIAL
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.193192066 Transfer Process created 5f8bf783-4444-4264-86df-a669ddd0f378
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.712028415 [TransferProcessManagerImpl] TransferProcess 5f8bf783-4444-4264-86df-a669ddd0f378 is now in state PROVISIONING
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.713066708 TransferProcess: ID 5f8bf783-4444-4264-86df-a669ddd0f378. Provisioning
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.715901787 [TransferProcessManagerImpl] TransferProcess 5f8bf783-4444-4264-86df-a669ddd0f378 is now in state PROVISIONED
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.716697797 [TransferProcessManagerImpl] TransferProcess 5f8bf783-4444-4264-86df-a669ddd0f378 is now in state REQUESTING
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.718786898 TransferProcess: ID 5f8bf783-4444-4264-86df-a669ddd0f378. Send TransferRequestMessage to http://provider-connector:19194/protocol
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.747654352 TransferProcess: ID 5f8bf783-4444-4264-86df-a669ddd0f378. Send TransferRequestMessage to http://provider-connector:19194/protocol
2024-02-15 11:22:12 DEBUG 2024-02-15T10:22:12.747984669 [TransferProcessManagerImpl] TransferProcess 5f8bf783-4444-4264-86df-a669ddd0f378 is now in state REQUESTED
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.694501647 DSP: Incoming TransferStartMessage for class org.eclipse.edc.connector.transfer.spi.types.TransferProcess process: 5f8bf783-4444-4264-86df-a669ddd0f378
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.694798449 Starting verification...
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.694873745 Resolving other party's DID Document
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.701731731 Extracting public key
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.702018022 Verifying JWT with public key...
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.703634935 verification successful! Fetching data from IdentityHub
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.703716289 Retrieving verified credentials for did:web:did-server:provider
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.703752747 Using identity hub URL: http://provider-connector:19191/api/identity-hub
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.707995551 Retrieved 0 verifiable credentials from identity hub
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.708174546 Building ClaimToken
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.710600295 TransferProcess 5f8bf783-4444-4264-86df-a669ddd0f378 is now in state STARTED
2024-02-15 11:22:13 DEBUG 2024-02-15T10:22:13.71275019 Sending EDR to http://ldio-workbench:8082/client-pipeline/token
2024-02-15 11:22:18 DEBUG 2024-02-15T10:22:18.507268245 Transferring from HttpData to Api-response.
2024-02-15 11:22:18 DEBUG 2024-02-15T10:22:18.508020556 Executing HTTP request: http://ldes-server:8081/devices

Thanks

Hi,
Make sure that connectorId and providerId in the negotiation request are set to your edc.participant.id configuration of the provider's connector!
As it seems, you are using did:web:did-server, so the request should look like this:
{   "@context": {     "edc": "https://w3id.org/edc/v0.0.1/ns/",     "odrl": "http://www.w3.org/ns/odrl/2/"   },   "@type": "NegotiationInitiateRequestDto",   "connectorId": "did:web:did-server:provider",   "connectorAddress": "http://provider-connector:19194/protocol",   "consumerId": "did:web:did-server:consumer",   "providerId": "did:web:did-server:provider",   "protocol": "dataspace-protocol-http",   "offer": {    "offerId": "MQ==:ZGV2aWNlcw==:M2JiYWI2MTUtZTIxYi00ZGZjLWJhZDYtMzk2ZTdkMWFlYTRk",    "assetId": "devices",    "policy": {      "@id": "MQ==:ZGV2aWNlcw==:M2JiYWI2MTUtZTIxYi00ZGZjLWJhZDYtMzk2ZTdkMWFlYTRk",      "@type": "Set",      "odrl:permission": [],      "odrl:prohibition": [],      "odrl:obligation": [],      "odrl:target": "devices"    }   } }


SAMZA-2009: Add ability to disable table metrics

This is to back port SAMZA-2004 to 0.14.1, due to the extend of changed made in Samza 1.0, the back port is actually done manually.
More details can be found here
https://github.com/apache/samza/pull/822

@weisong44 Does this need to be merged in? If not, let's close the PR.

This PR won't be needed.


use-browser-location

For V3, we want to ship a standalone hook wouter/use-browser-location that will replace wouter/use-location. The primary motivation for this is to remove confusion around import { useLocation } from "wouter" and import useLocation from "wouter/use-location".
This hopefully will make it more clear that the standalone hook can be used without wouter, while the hook imported from "wouter" will always rely on the current router's location.
I suggest that we don't just rename this module, but also work on some things the current version lacks:

[ ] Ensure that we monkey-patch pushState only once, see #167
[ ] Consider using globalThis when accessing location (this needs to be researched)
[ ] Allow to pass current state when performing navigation
[ ] I think we can safely drop this export const events, since it looks more like an implementation detail
[ ] Use named exports only, import { useBrowserLocation } from "wouter/use-browser-location"
[ ] Migrate type specs

Additional: does the state have to be returned from useBrowserLocation? There is a PR #325 that adds it as a third argument, however I am not sure it's the right approach, since other hooks (like hash location or memory) will not implement it.
We could however allow location hooks to return the optional object that they can populate with whatever implemetation-specific parameters they need.

@jeetiss Can we close this now?


ITK 5.2.1 Python Package Missing Wrappings

Description

The ITK Python 5.2.1 distribution does not contain several Python wrappings that were included in the 5.2.1 release schedule. This includes imread enhancements and additional wrappings for SymmetricSecondRankTensor and mesh filters.
The issue has been observed both locally and in Github CI depending on the ITK Python packages. CI is failing in the ITKStrain external module due to being unable to find wrappings that should be introduced in v5.2.1.
TransformToStrainImageFilter PR fails because GenerateImageSource is not wrapped for SSRT
Steps to Reproduce

pip install itk==5.2.1
Launch Python console and verify installation path and version

import itk
print(itk.__file__)
print(itk.__version__)

Check wrappings availability:

itk.MeshToMeshFilter.GetTypes()
itk.GenerateImageSource.GetTypes()

Try reading in vector-valued data with imread, such as a Nrrd sequence volume:

itk.imread('vectordata.seq.nrrd', pixel_type=itk.VariableLengthVector[itk.F])

Expected behavior

Package installs
File and version match current environment and 5.2.1
MeshToMeshFilter is wrapped for scalar types and GenerateImageSource is wrapped for real types per 5.2.1 release schedule
Vector image is read in successfully.

These steps pass when testing against a local build of ITK 5.2.1.

Actual behavior

Package installs

Successfully installed itk-5.2.1

Package path is correct but version is 5.2.0

>>> itk.__file__
'C:\\Users\\tom.birdsong\\Anaconda3\\envs\\venv-itk\\lib\\site-packages\\itk\\__init__.py'
>>> itk.__version__
'5.2.0'

I have verified that the distribution folders in this site-packages path are all named for version 5.2.1 such as follows:

itk_core-5.2.1.dist-info

Wrapping expansions in 5.2.1 are not included:

>>> itk.MeshToMeshFilter.GetTypes()
<itkTemplate itk::MeshToMeshFilter>
Options:
  [<class 'itk.itkMeshBasePython.itkMeshD2'>, <class 'itk.itkMeshBasePython.itkMeshD2'>]
  [<class 'itk.itkMeshBasePython.itkMeshD3'>, <class 'itk.itkMeshBasePython.itkMeshD3'>]
  [<class 'itk.itkMeshBasePython.itkMeshD4'>, <class 'itk.itkMeshBasePython.itkMeshD4'>]
  [<class 'itk.itkMeshBasePython.itkMeshF2'>, <class 'itk.itkMeshBasePython.itkMeshF2'>]
  [<class 'itk.itkMeshBasePython.itkMeshF3'>, <class 'itk.itkMeshBasePython.itkMeshF3'>]
  [<class 'itk.itkMeshBasePython.itkMeshF4'>, <class 'itk.itkMeshBasePython.itkMeshF4'>]

(no scalar types)
>>> itk.GenerateImageSource.GetTypes()
<itkTemplate itk::GenerateImageSource>
Options:
....

(no SSRT types)

imread fails

itk.imread('vectordata.seq.nrrd', pixel_type=itk.VariableLengthVector[itk.F])
Traceback (most recent call last):
  File "C:\Users\tom.birdsong\Anaconda3\envs\venv-itk\lib\site-packages\itk\support\template_class.py", line 525, in __getitem__
    this_item = self.__template__[key]
KeyError: (<class 'itk.itkVariableLengthVectorPython.itkVariableLengthVectorF'>, 3)

Reproducibility
100%
Versions
Expecting v5.2.1, may be pulling v5.2.0 despite naming?

Environment

I am using an Anaconda environment for Python 3.8.5 on Windows. CI is failing across at least Python 3.6 and 3.7 pipelines across platforms.
Additional Information

Float wrapping added for SymmetricSecondRankTensor in 5.2.1 seems to be present in the PyPi package:
<itkTemplate itk::SymmetricSecondRankTensor>
Options:
  [<itkCType double>, 2]
  [<itkCType double>, 3]
  [<itkCType double>, 4]
  [<itkCType float>, 2]
  [<itkCType float>, 3]
  [<itkCType float>, 4]

@dzenanz @thewtex

@tbirdso thanks for the report!
Yes, it looks like we ended up with the wrong hash in the release. Should be addressed with: https://github.com/InsightSoftwareConsortium/ITKPythonPackage/commit/380a0ce05adea5a3656f0327bb329fbcd1ce87ac
We'll build / test and upload as itk-5.2.1.post1.

These are now built / addressed, except for Linux-ARM, which is building.
CC @aylward


broke?

Most likely explanation is that RH changed the symbol for one of your stocks, so symbols saved locally do not match the RH API. If you use docker - you can try stopping and deleting the container (don't delete image to avoid re-download) and start a new container. It should pull the updated list of symbols.
Alternatively, if you want, post the list of stocks/symbols you have and I can check each of them manually.

Not using docker, deployed both in Windows & Linux machine. Any other thoughts/advice to fix? I haven't had this issue with other RH py scripts

Not using docker, deployed both in Windows & Linux machine. Any other thoughts/advice to fix? I haven't had this issue with other RH py scripts

I suspect the issue was that there were no dividend payouts, so dataframe was empty and as a result had no "instrument" field. Could you pull the latest version and try again?

Thanks for your quick reply. Making progress, the error disappears but now it is stuck downloading market data...
Downloading dividends from Robinhood
Downloading orders from Robinhood
Downloading market data for 20171108-20180618
It's been downloading for 30min+ now, doubt it really takes that long?

No, no way. Likely get's stuck somewhere because of empty dividends info. If I don't have ideas - may need to add verbosity to understand where it get's stuck.

Found where it gets stuck...
pf = web.DataReader(tickers, 'morningstar', start_date, end_date)
Maybe there's a ticker morningstar doesn't like?

Ah, it's totally possible. Getting stock data nowadays is difficult - I had to switch to morningstar after google killed it's API. You can check some more exotic tickers on their page.
Just to be sure, it is not something else - you can add pause=1.0 to that call, it is in folder backend/market_data.py on line 41. I suspect that if you have a large list of symbols to pull morningstar may not like it, so we can try to increase the delay between requests. If this does not work - then it is likely some exotic symbol.

Added pause=1.0, no effect.
Random question (simply because I'm not a smart coder) -
I tried to see what tickers it's actually trying to check with a print(tickers) and it's passing an array in format ['ticker' 'ticker' 'ticker']
I tested it manually with a small python script outside of yours and that seems to stall, the correct syntax is  ['ticker', 'ticker', 'ticker'] with a comma. Am I missing something?

I believe I found the exotic ticker, SESN. What do I do now? It's a valid ticker...

Submitted issue to pandas-datareader. I looked at their code and morningstar url and don't see anything which could explain it. Hopefully they can address it. Cheers.


2 tests failing on macOS

The sourceset resource comparison is failing, it appears that /private/var/folders/5n/ln1zz2ks6w7fp6s628z2t88w0000gn/T/ directory is a symlink into /var/folders/5n/ln1zz2ks6w7fp6s628z2t88w0000gn/T/
ca.cutterslade.gradle.helm.HelmPluginNonSourceTasksSpec > it generates the helm source set having the expected resource directory FAILED
java.lang.AssertionError: Unexpected resource directories. Expected <HELM-RESOURCES: [/var/folders/5n/ln1zz2ks6w7fp6s628z2t88w0000gn/T/HelmPluginNonSourceTasksSpec3260991630068251539/src/main/helm]>, actual <HELM-RESOURCES: [/private/var/folders/5n/ln1zz2ks6w7fp6s628z2t88w0000gn/T/HelmPluginNonSourceTasksSpec3260991630068251539/src/main/helm]>.
ca.cutterslade.gradle.helm.HelmPluginNonSourceTasksSpec > it generates the helm source set having the expected resource output directory FAILED
java.lang.AssertionError: Unexpected resource output directories. Expected <HELM-OUTPUT: /var/folders/5n/ln1zz2ks6w7fp6s628z2t88w0000gn/T/HelmPluginNonSourceTasksSpec3260991630068251539/build/resources/helm>, actual <HELM-OUTPUT: /private/var/folders/5n/ln1zz2ks6w7fp6s628z2t88w0000gn/T/HelmPluginNonSourceTasksSpec3260991630068251539/build/resources/helm>.

I am seeing the same issue.

I do not have access to a mac in order to validate or fix this issue, any idea what the cause might be?

Seems like the directories you are comparing are in fact different. See the /private prefix.


Fix url

Coverage remained the same at 100.0% when pulling 4b7d6a3608dc635ab9f9fca8e738c5046f4a7fc1 on piton4eg:patch-1 into 7be2be5be319fbd502a2d97a19cc86118d75191f on inaka:master.


service_worker.js eventually starts going high cpu and makes chrome unusable until killed (and at least one chrome eventually crashed.

service_worker.js eventually starts going high cpu and makes chrome unusable until killed (and at least one chrome eventually crashed.. it's done it multiple times now i've had to disable the extension for now unfortunately.
this started after (I think) after I updated to: da9afa6
also still did it with: ca22460

sorphin,
Can you provide what those column headers are?
The image shows the service worker tab using less memory than the vine tab
That "Browser" is the collective of all the tabs
A system can't have more than 100% CPU usage... so, not sure what that 95.1 represents
In over 24 hours I've not seen more than .5 to 1% cpu usage
when chrome crashed did you get a "waiting for tab" or something similar that indicated service_worker was what crashed

its from the cpu usage in the chrome process monitor. its 95% cpu and yes you can use more than 100% when there is more is multi cores.  and nope, chrome just blew away.
"Multiple CPUs (cores) and an app having multiple execution threads, means each available CPU could be used in part or 100% for a sum in the Activity Monitor display greater than 100%."

Ok, knowing that was a core % makes a difference understanding the
screenshot.  Logical core usage is different.  Thanks for the update.
How long was it open, do you remember, before it crashed?  Where you using
the notification window?  Did it have a ton of items on it?
On Fri, Mar 22, 2024, 2:35 AM sorphin @.***> wrote:

its from the cpu usage in the chrome process monitor. its 95% cpu and yes
you can use more than 100% when there is more is multi cores. and nope,
chrome just blew away.
"Multiple CPUs (cores) and an app having multiple execution threads, means
each available CPU could be used in part or 100% for a sum in the Activity
Monitor display greater than 100%."
—
Reply to this email directly, view it on GitHub
https://github.com/FMaz008/VineHelper/issues/65#issuecomment-2014448203,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAG5LZ2UCIH5HL2V3PFNKYTYZPGM5AVCNFSM6AAAAABFCVWIL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJUGQ2DQMRQGM
.
You are receiving this because you commented.Message ID:
@.***>

When I was using the notification window I never had any issues, I stopped using it though. I am however using the auto hide keywords... many of them...

Did the issue appear followong an action?for the most part VH dors its thing when the page load and then is done.
Can you provide rhe debug (d) when going high CPU?
Do you get a browser error such as "a script on this page is taking too long to respond..."?

Did the issue appear followong an action?for the most part VH dors its thing when the page load and then is done.

I just had my vine tabs sitting open, i wasn't actively doing anything in them.

Can you provide the debug (d) when going high CPU?

I'll have to turn it back on and turn back on key bindings and wait for it to happen again (no doubt that it will).. do you want me to pull the most current before I do?

Do you get a browser error such as "a script on this page is taking too long to respond..."?

Nope. No errors. Chrome just grinds to a slow drag and when i pull up the chrome process monitor, i see what you see in the screenshot, and when i kill it, all gets back to normal.

Do you have a really high number of vine tabs opened ?

6 total, one is my 'dashboard page, one is my orders, one is my reviews the, one is my RFY and the other 2 are items i'm on the fence on, that i hadn't pulled on yet.

How long are we talking about before you notice this happening? Is it something that happens 100% of the time or intermittent ?

it's happened twice now before i turned the extension off.  Both times, that window just sat in the background of other windows for a few hours.

I am really puzzled by this, the code for the service worker is not very long and I'm having a hardtime seing what could cause this.
I keep my browsers (firefox and chrome) open 24/7 and will always go overnight with the extension running and never encountered that issue.
Not invalidating your experience at all, but I'm wondering what could be different between us that could cause this.
If you can reproduce this with a high level of certainty, could you try the following 2 things to gather more information:
Disable your notifications. The service worker will still run but will literally do nothing.
I have actually had notifications off for a while now once you added the 'notification page', though i turned that off after a day because it was hard to sort through, and the keyword stuff is working (or was ) better for me). So notifications were off during all this

install the extension as a temporary add-on (Manual install on github) and after you confirmed this happen again with the latest code, try Terminating the service worker:

I only install via the gihub repo already.

Open the dev tool (right click, inspect) Go to the Application tab. The the left you, under application, you will see "Service worker", click on it. On the right, you should see Amazon.*... service_worker.js ... Status: Activated and is running [stop] Click stop.
This should stop the service worker from running, meaning your notifications will no longer work, but I'm curious to see if it will cause the high usage of CPU if you leave it overnight.

I'll give this a shot, again notifications were already turned off, so we'll see I guess.

To be clear, I specifically mean the "Check for New Items Every 30 sec" option. If that is disabled, and you reload the extension and are still having the issue, it narrows down the problem to less than half of the code in the file.

Well the idea is to figure out 2 things:

Is is really the service worker script that's the issue. (If it's happening while it's stopped, probably something else)
If the script is for sure the problem, is it the checking for notification portion that is causing the problem, or the internal messaging system which broadcast data to the tabs.

If the later is the problem, I might have ways to completely stop internal messaging when the notifications are off. Which is not a great solution, but at least the problem would be isolated to a specific feature.
BTW, thank you so much for testing all this, it's really hard to debug something without being able to be hands on, and I truly appreciate your patience with this :)

Well the idea is to figure out 2 things:

Is is really the service worker script that's the issue. (If it's happening while it's stopped, probably something else)
If the script is for sure the problem, is it the checking for notification portion that is causing the problem, or the internal messaging system which broadcast data to the tabs.

If the later is the problem, I might have ways to completely stop internal messaging when the notifications are off. Which is not a great solution, but at least the problem would be isolated to a specific feature.
BTW, thank you so much for testing all this, it's really hard to debug something without being able to be hands on, and I truly appreciate your patience with this :)

I'll advise here once/if i see any 'hits'... and thank you for creating this. it's helped make vine less... well, ghetto and more usable. I noticed you removed all the extra stats on the 'dashboard' page that you had added?

They should be back with v2.4.5 :)

FYI, it's not as bad as it was but it's definitely getting draggy a bit now.. here's the output from your 'debug'
[
0ms: TEMPLATE: Loading template view/notification_container.html from file.
0ms: HIDDENMGR: Loading list
1ms: PRE: Begining to load settings
24ms: HIDDENMGR: List loaded.
24ms: PRE: Done reading settings
24ms: TEMPLATE: Loaded template lib/vine-styling/desktop/remove-footer.css from memory.
24ms: TEMPLATE: Loaded template lib/vine-styling/desktop/remove-associate-header.css from memory.
24ms: TEMPLATE: Loaded template lib/vine-styling/desktop/more-description-text.css from memory.
24ms: TEMPLATE: Loaded template lib/vine-styling/desktop/etv-modal-on-top.css from memory.
24ms: TEMPLATE: Loaded template lib/vine-styling/desktop/striped-categories.css from memory.
24ms: TEMPLATE: Loaded template lib/vine-styling/desktop/limited-quantity-icon.css from memory.
24ms: BOOT: Thorvarium stylesheets injected
24ms: PRE: Settings loaded
137ms: BOOT: Booterloader starting
137ms: BOOT: Waiting on config to be loaded...
137ms: BOOT: Config available. Begining init() function
137ms: TEMPLATE: Loaded template view/notification_container.html from memory.
138ms: Fetching products data...
139ms: BOOT: Script injected
140ms: BOOT: Creating tabs system
140ms: TEMPLATE: Loaded template view/tabs.html from memory.
141ms: TEMPLATE: Loaded template view/widget_hideall.html from memory.
142ms: BOOT: Grid system completed
142ms: TEMPLATE: Loaded template view/bookmark.html from memory.
144ms: DRAW: Creating #vh-toolbar-B0CW9K126J
144ms: TEMPLATE: Loaded template view/toolbar.html from memory.
151ms: DRAW: Creating #vh-toolbar-B0CPWMRSHK
151ms: TEMPLATE: Loaded template view/toolbar.html from memory.
152ms: DRAW: Creating #vh-toolbar-B0CS3DBXWF
152ms: TEMPLATE: Loaded template view/toolbar.html from memory.
152ms: DRAW: Creating #vh-toolbar-B0CT29WDG6
152ms: TEMPLATE: Loaded template view/toolbar.html from memory.
154ms: DRAW: Creating #vh-toolbar-B0CTJMS6X2
154ms: TEMPLATE: Loaded template view/toolbar.html from memory.
156ms: DRAW: Creating #vh-toolbar-B0CS35748T
156ms: TEMPLATE: Loaded template view/toolbar.html from memory.
157ms: DRAW: Creating #vh-toolbar-B0CX2M28DK
157ms: TEMPLATE: Loaded template view/toolbar.html from memory.
159ms: DRAW: Creating #vh-toolbar-B0CTHXRXG1
159ms: TEMPLATE: Loaded template view/toolbar.html from memory.
160ms: DRAW: Creating #vh-toolbar-B0CS6JHPFV
160ms: TEMPLATE: Loaded template view/toolbar.html from memory.
161ms: DRAW: Creating #vh-toolbar-B0CWZ66YRV
161ms: TEMPLATE: Loaded template view/toolbar.html from memory.
162ms: DRAW: Creating #vh-toolbar-B09TGMNSDN
162ms: TEMPLATE: Loaded template view/toolbar.html from memory.
163ms: DRAW: Creating #vh-toolbar-B0CT2SXNVN
163ms: TEMPLATE: Loaded template view/toolbar.html from memory.
163ms: DRAW: Creating #vh-toolbar-B0CQR2NHYJ
163ms: TEMPLATE: Loaded template view/toolbar.html from memory.
163ms: DRAW: Creating #vh-toolbar-B0CS7XMT2W
163ms: TEMPLATE: Loaded template view/toolbar.html from memory.
164ms: DRAW: Creating #vh-toolbar-B0CSYNSTZ2
164ms: TEMPLATE: Loaded template view/toolbar.html from memory.
165ms: DRAW: Creating #vh-toolbar-B0CRVFMP83
165ms: TEMPLATE: Loaded template view/toolbar.html from memory.
166ms: DRAW: Creating #vh-toolbar-B0CS2ZZG9K
166ms: TEMPLATE: Loaded template view/toolbar.html from memory.
168ms: DRAW: Creating #vh-toolbar-B0CXSK5CLM
168ms: TEMPLATE: Loaded template view/toolbar.html from memory.
168ms: done creating toolbars.
601ms: FETCH: Waiting on hidden items list to be loaded...
601ms: FETCH: Waiting toolbars to be drawn...
601ms: FETCH: Interface loaded, processing fetch data...
601ms: DRAW: Processing ASIN #B0CW9K126J
601ms: DRAW: Setting Date
601ms: DRAW: Setting votes
601ms: DRAW: Setting orders
602ms: DRAW: Updating the toolbar
602ms: TILE: The item match the keyword 'rug', hide it
603ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B0CW9K126J
604ms: DRAW-UPDATE-TOOLBAR: Setting icon status
604ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
604ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
604ms: TEMPLATE: Loaded template view/widget_order.html from memory.
604ms: DRAW: Done updating the toolbar
604ms: DRAW: Processing ASIN #B0CPWMRSHK
604ms: DRAW: Setting Date
604ms: DRAW: Remote is ordering to show or hide item
604ms: DRAW: Setting votes
604ms: DRAW: Setting orders
604ms: DRAW: Updating the toolbar
605ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B0CPWMRSHK
605ms: DRAW-UPDATE-TOOLBAR: Setting icon status
605ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
605ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
605ms: TEMPLATE: Loaded template view/widget_order.html from memory.
605ms: DRAW: Done updating the toolbar
605ms: DRAW: Processing ASIN #B0CS3DBXWF
605ms: DRAW: Setting Date
605ms: DRAW: Remote is ordering to show or hide item
607ms: DRAW: Setting votes
607ms: DRAW: Setting orders
607ms: DRAW: Updating the toolbar
607ms: TILE: The item match the keyword 'womens', hide it
608ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B0CS3DBXWF
608ms: DRAW-UPDATE-TOOLBAR: Setting icon status
608ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
608ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
608ms: TEMPLATE: Loaded template view/widget_order.html from memory.
608ms: DRAW: Done updating the toolbar
608ms: DRAW: Processing ASIN #B0CT29WDG6
608ms: DRAW: Setting Date
608ms: DRAW: Remote is ordering to show or hide item
609ms: DRAW: Setting votes
609ms: DRAW: Setting orders
609ms: DRAW: Updating the toolbar
609ms: TILE: The item match the keyword 'solar lights', hide it
610ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B0CT29WDG6
610ms: DRAW-UPDATE-TOOLBAR: Setting icon status
610ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
610ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
610ms: TEMPLATE: Loaded template view/widget_order.html from memory.
610ms: DRAW: Done updating the toolbar
610ms: DRAW: Processing ASIN #B0CTJMS6X2
610ms: DRAW: Setting ETV
610ms: DRAW: Setting Date
610ms: DRAW: Remote is ordering to show or hide item
610ms: DRAW: Setting votes
610ms: DRAW: Setting orders
610ms: DRAW: Updating the toolbar
610ms: TILE: The item match the keyword 'boys', hide it
611ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B0CTJMS6X2
611ms: DRAW-UPDATE-TOOLBAR: Setting icon status
611ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
611ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
611ms: TEMPLATE: Loaded template view/widget_order.html from memory.
611ms: DRAW: Done updating the toolbar
611ms: DRAW: Processing ASIN #B0CS35748T
611ms: DRAW: Setting ETV
611ms: DRAW: Setting Date
611ms: DRAW: Remote is ordering to show or hide item
611ms: DRAW: Setting votes
611ms: DRAW: Setting orders
611ms: DRAW: Updating the toolbar
612ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B0CS35748T
612ms: DRAW-UPDATE-TOOLBAR: Setting icon status
612ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
612ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
612ms: TEMPLATE: Loaded template view/widget_order.html from memory.
612ms: DRAW: Done updating the toolbar
612ms: DRAW: Processing ASIN #B0CX2M28DK
612ms: DRAW: Setting Date
612ms: DRAW: Remote is ordering to show or hide item
612ms: DRAW: Setting votes
612ms: DRAW: Setting orders
612ms: DRAW: Updating the toolbar
614ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B0CX2M28DK
614ms: DRAW-UPDATE-TOOLBAR: Setting icon status
614ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
614ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
614ms: TEMPLATE: Loaded template view/widget_order.html from memory.
614ms: DRAW: Done updating the toolbar
614ms: DRAW: Processing ASIN #B0CTHXRXG1
614ms: DRAW: Setting Date
614ms: DRAW: Remote is ordering to show or hide item
614ms: DRAW: Setting votes
614ms: DRAW: Setting orders
614ms: DRAW: Updating the toolbar
614ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B0CTHXRXG1
614ms: DRAW-UPDATE-TOOLBAR: Setting icon status
614ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
614ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
614ms: TEMPLATE: Loaded template view/widget_order.html from memory.
614ms: DRAW: Done updating the toolbar
614ms: DRAW: Processing ASIN #B0CS6JHPFV
614ms: DRAW: Setting Date
614ms: DRAW: Remote is ordering to show or hide item
614ms: DRAW: Setting votes
614ms: DRAW: Setting orders
614ms: DRAW: Updating the toolbar
614ms: TILE: The item match the keyword 'kids', hide it
614ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B0CS6JHPFV
615ms: DRAW-UPDATE-TOOLBAR: Setting icon status
615ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
615ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
615ms: TEMPLATE: Loaded template view/widget_order.html from memory.
615ms: DRAW: Done updating the toolbar
615ms: DRAW: Processing ASIN #B0CWZ66YRV
615ms: DRAW: Setting ETV
615ms: DRAW: Setting Date
615ms: DRAW: Remote is ordering to show or hide item
615ms: DRAW: Setting votes
615ms: DRAW: Setting orders
615ms: DRAW: Updating the toolbar
615ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B0CWZ66YRV
615ms: DRAW-UPDATE-TOOLBAR: Setting icon status
615ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
615ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
615ms: TEMPLATE: Loaded template view/widget_order.html from memory.
615ms: DRAW: Done updating the toolbar
615ms: DRAW: Processing ASIN #B09TGMNSDN
615ms: DRAW: Setting Date
615ms: TILE: The item is more recent than the time marker, highlight it.
615ms: DRAW: Setting votes
615ms: DRAW: Setting orders
615ms: DRAW: Updating the toolbar
615ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B09TGMNSDN
615ms: DRAW-UPDATE-TOOLBAR: Setting icon status
615ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
615ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
615ms: TEMPLATE: Loaded template view/widget_order.html from memory.
615ms: DRAW: Done updating the toolbar
615ms: DRAW: Processing ASIN #B0CT2SXNVN
615ms: DRAW: Setting Date
615ms: DRAW: Remote is ordering to show or hide item
615ms: DRAW: Setting votes
615ms: DRAW: Setting orders
616ms: DRAW: Updating the toolbar
616ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B0CT2SXNVN
616ms: DRAW-UPDATE-TOOLBAR: Setting icon status
616ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
616ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
616ms: TEMPLATE: Loaded template view/widget_order.html from memory.
616ms: DRAW: Done updating the toolbar
616ms: DRAW: Processing ASIN #B0CQR2NHYJ
616ms: DRAW: Setting Date
616ms: DRAW: Setting votes
616ms: DRAW: Setting orders
616ms: DRAW: Updating the toolbar
616ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B0CQR2NHYJ
616ms: DRAW-UPDATE-TOOLBAR: Setting icon status
616ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
616ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
616ms: TEMPLATE: Loaded template view/widget_order.html from memory.
616ms: DRAW: Done updating the toolbar
616ms: DRAW: Processing ASIN #B0CS7XMT2W
616ms: DRAW: Setting ETV
617ms: DRAW: Setting Date
617ms: DRAW: Setting votes
617ms: DRAW: Setting orders
617ms: DRAW: Updating the toolbar
617ms: TILE: The item match the keyword 'women', hide it
617ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B0CS7XMT2W
617ms: DRAW-UPDATE-TOOLBAR: Setting icon status
617ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
617ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
617ms: TEMPLATE: Loaded template view/widget_order.html from memory.
617ms: DRAW: Done updating the toolbar
617ms: DRAW: Processing ASIN #B0CSYNSTZ2
617ms: DRAW: Setting Date
617ms: DRAW: Remote is ordering to show or hide item
617ms: DRAW: Setting votes
617ms: DRAW: Setting orders
617ms: DRAW: Updating the toolbar
617ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B0CSYNSTZ2
617ms: DRAW-UPDATE-TOOLBAR: Setting icon status
617ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
617ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
617ms: TEMPLATE: Loaded template view/widget_order.html from memory.
617ms: DRAW: Done updating the toolbar
617ms: DRAW: Processing ASIN #B0CRVFMP83
617ms: DRAW: Setting ETV
617ms: DRAW: Setting Date
618ms: DRAW: Remote is ordering to show or hide item
618ms: DRAW: Setting votes
618ms: DRAW: Setting orders
618ms: DRAW: Updating the toolbar
618ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B0CRVFMP83
618ms: DRAW-UPDATE-TOOLBAR: Setting icon status
618ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
618ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
618ms: TEMPLATE: Loaded template view/widget_order.html from memory.
618ms: DRAW: Done updating the toolbar
618ms: DRAW: Processing ASIN #B0CS2ZZG9K
618ms: DRAW: Setting Date
618ms: DRAW: Remote is ordering to show or hide item
618ms: DRAW: Setting votes
618ms: DRAW: Setting orders
618ms: DRAW: Updating the toolbar
618ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B0CS2ZZG9K
618ms: DRAW-UPDATE-TOOLBAR: Setting icon status
618ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
618ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
618ms: TEMPLATE: Loaded template view/widget_order.html from memory.
618ms: DRAW: Done updating the toolbar
618ms: DRAW: Processing ASIN #B0CXSK5CLM
618ms: DRAW: Setting Date
618ms: DRAW: Remote is ordering to show or hide item
618ms: DRAW: Setting votes
618ms: DRAW: Setting orders
618ms: DRAW: Updating the toolbar
618ms: DRAW-UPDATE-TOOLBAR: Updating ##vh-toolbar-B0CXSK5CLM
618ms: DRAW-UPDATE-TOOLBAR: Setting icon status
618ms: DRAW-UPDATE-TOOLBAR: Setting status related properties
618ms: DRAW-UPDATE-TOOLBAR: Create order widget (#2)
618ms: TEMPLATE: Loaded template view/widget_order.html from memory.
618ms: DRAW: Done updating the toolbar
618ms: Done updating products
626ms: HIDDENMGR: List loaded.
630ms: Saving hidden item(s) remotely...
633ms: HIDDENMGR: List loaded.
636ms: Saving hidden item(s) remotely...
4436ms: HIDDENMGR: List loaded.
4439ms: Saving hidden item(s) remotely...
5395ms: HIDDENMGR: List loaded.
5398ms: Saving hidden item(s) remotely...
9338ms: Storage used by arrTemplate: 15.16 KB representing 86 items
9376ms: Storage used by hiddenItems: 223.02 KB representing 2566 items
9376ms: Storage used by latestProduct: 21 Bytes representing 19 items
9377ms: Storage used by reviews: 1.1 KB representing 1 items
9377ms: Storage used by reviews_templates: 2 Bytes representing 0 items
9378ms: Storage used by settings: 2.8 KB
9379ms: TEMPLATE: Loaded template view/modal.html from memory.
14248ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
44253ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
74361ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
104433ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
134186ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
164250ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
194247ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
224254ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
254196ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
284308ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
314194ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
344240ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
374205ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
404291ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
434187ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
464251ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
494228ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
524280ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
554202ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
584291ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
614280ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
644282ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
674245ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
704322ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
734225ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
764272ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
794233ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
824311ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
854237ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
884285ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
914287ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
944270ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
974235ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
1004338ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
1034279ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
1064290ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
1094242ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
1124334ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
1154297ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
1184305ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
1214277ms: TEMPLATE: Loaded template view/notification_loading.html from memory.
1237227ms: Storage used by arrTemplate: 15.16 KB representing 86 items
1237234ms: Storage used by hiddenItems: 223.02 KB representing 2566 items
1237235ms: Storage used by latestProduct: 21 Bytes representing 19 items
1237236ms: Storage used by reviews: 1.1 KB representing 1 items
1237236ms: Storage used by reviews_templates: 2 Bytes representing 0 items
1237237ms: Storage used by settings: 2.8 KB

]

Interestingly.. with the extension turned off the service_worker.js process is still 'active' and it just showed running on that "chrome://serviceworker-internals/?devtools" page for the amazon.com entry.

be aware that amazon has it's own service_worker.js, that's a common name for them

Just for the sake of making thing easier, I renamed our service worker vh_service_worker.js to avoid any confusion

Just for the sake of making things easier, I renamed our service worker vh_service_worker.js to avoid any confusion

I'll resync.

I had hit 'stop' on the vh_service_worker.js process in the devtools window, and it continues to restart itself....

Not to be sassy, but that's a fantastic news! I worked really hard to make the service worker persistent. The fact that it can restart is great.

Well, it's been several days and with notifications off and with "check every 60" turned off (I haven't repulled yet since the other day).. 0 issues.

Any ideas then based on this?

I was using it and it actually caused less issues for me than regular notifications, but apparently even that caused its own issues (possiprobably) with this.... Do you want me to sync current and what do you want turned on? I haven't changed anything yet from what you told me to test with before.

We're working on rehauling the notification system, no ides why this is happening still, but the new system should be much much better in term of resource usage.
Sorry it's taking so long.

No worries. Was just making sure you didn't need me to do anything else.

I believe I just fixed the issue buly implementing a new broadcast system. Can you test the latest code on GIT to confirm?

Fixed the issue for me in chrome on osx.

Seems good here too.


How to set do not resize?

I want to do not resize and set resize_h and resize_w as None, but got the error:
ValueError: (InvalidArgument) The 'shape' in Reshape0p is invalid.The input tensor X'size must be equal to the capacity of 'shape'......

Currently the Paddle implementation do not support no-square input. I will try to fix it soon. Or you can directly resize the output frames.

Currently the Paddle implementation do not support no-square input. I will try to fix it soon. Or you can directly resize the output frames.

Thank you~


fix(interpolation): implementation of template function to header

Description
I think template function must be implemented in header, if without explicit instantiation in the impl file.
Otherwise, using such function may cause compile time error, or worse  symbol lookup error in runtime.
@takayuki5168
@TakaHoribe
reference:
https://stackoverflow.com/questions/495021/why-can-templates-only-be-implemented-in-the-header-file
A test was added in https://github.com/autowarefoundation/autoware.universe/commit/f4723923e738352bd684c77a96432ea0adc8d6fc
which cannot be compiled with the original code with the following message:
/usr/bin/ld: CMakeFiles/test_interpolation.dir/test/src/test_spline_interpolation.cpp.o: in function `spline_interpolation_SplineInterpolationPoints2dPolymorphism_Test::TestBody()':
test_spline_interpolation.cpp:(.text+0x21b7): undefined reference to `void SplineInterpolationPoints2d::calcSplineCoefficients<autoware_auto_planning_msgs::msg::TrajectoryPoint_<std::allocator<void> > >(std::vector<autoware_auto_planning_msgs::msg::TrajectoryPoint_<std::allocator<void> >, std::allocator<autoware_auto_planning_msgs::msg::TrajectoryPoint_<std::allocator<void> > > > const&)'

After the bug fix commit https://github.com/autowarefoundation/autoware.universe/commit/63a1cc24e3d9705a2b0a6a8c28896140827b73d4
, the test code can be successfully compiled and no error in the runtime also.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

I've fixed a little so that all CI will pass.
@HiroIshida Just checking. Could you verify that simple planning simulator works with this PR.
If there is no problem, you can merge. :+1:

@takayuki5168
Before opening PR, I already checking this change is compatible with other package (obstacle avoidance planner which uses  SplineInterpolationPoint2d inside), by recompiling that package and run a planning simulator.
Just in case, yesterday, I tried compiling whole source of autoware universe and tried psim after that. Then, I found planning simulator get stacked after putting an goal position with  autoware/state = 4 (planning). I'm not sure it is because of the change  in this PR or problem in build. Take me a little bit time to check the real cause of problem.
By the way, I don't have priviledge to merge. so after resolving the above issue, I want to ask you to merge.

@HiroIshida Got it. Take your time.

@takayuki5168  @TakaHoribe
I checked this change is OK, please merge this commit.


Documentation/guide for when and on what component-mode-height should be used

Our tokens component-mode-height, component-mode-spacingand component-mode-gapare not easy to know when should be used. I think if we create some guidelines that include examples on what components use them today and why it would be easier for designer to set up their components.
We also dont have any component-mode for our smaller components like:

Checkbox
Radio
Switch
Chip
Tag

We almost don't use the component mode tokens in react components, only Button uses component-mode-height but there are some issues with this.

Suggest we find a way to not have to use these tokens to reduce complexity and number of tokens.

We have decided and implementet to only use sizing tokens and remove component-mode-height and the compact set completely. This was do reduce the complexity.
There is a overview of our sizing tokens used in our Figma component library


Support Arbitrary Chapter Verse Delimiters

Add an option and support for a user picked chapter/verse delimiter instead of defaulting to ':'
Current plan is to have a limited set of options in a dropdown and only one being supported at a time. The options presented can easily be expanded in the future. Supporting more than one delimiter in use at a time however gets more complicated.

Added in 1.3.0


Cropper component not respecting parent's size

I have a cropper component in a column:

        <CropperComponent @ref="cropperRef"
                            Class="img-container"
<EMAIL_ADDRESS>                            InputAttributes="@InputAttributes"
                            Options="cropperOptions" />

And the CSS class:
.img-container,
.img-preview {
    text-align: center;
    width: 100%;
}

.img-container {
    height: 400px;
}

.img-preview {
    overflow: hidden;
}

.img-container > ::deep img {
    max-width: 100%;
}

.img-preview > ::deep img {
    max-width: 100%;
}

.preview {
    height: 200px;
    width: 150px;
}

When setting a large image, the component just expands (width & height) to fit image.
Is it possible to make the component respect its size defined in the css and/or the its parent?

Hi @cryo75. You can experimenting with ViewMode for Cropper Component. See details instruction in this page: https://cropperblazor.github.io/examples/viewmodes#simple-usage

Actually you can set up min and max dimensions in the following instruction with example of code:

Moreover you can see code base of demo part site and find suitable combination: https://cropperblazor.github.io/demo


Look for an example with if and is and tolerance

Hello,
I want to use the in-viweport with selector and toleranance but from the bottom of the page
if ( $('.mydiv').is( ':in-viewport(300)') ) {
	alert('yes');
	}

Thanks for your help!
Greeteings

A negative tolerance is what you need for this.


TcpEndpoint.kt:42-43: Create server object that listens...

The puzzle 2-e4762e32 from #2 has to be resolved:
https://github.com/kerelape/reikai/blob/a4ea7f8cc2f9ec4cc99dd99ab225c96646a43735/src/main/kotlin/me/kerelape/reikai/io/network/TcpEndpoint.kt#L42-L43
The puzzle was created by Киряев Кирилл on 20-Jul-22.
role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

I can't create GITHUB labels pdd. Most likely I don't have necessary permissions to kerelape/reikai repository. Please, make sure @0pdd user is in the list of collaborators:
POST https://api.github.com/repos/kerelape/reikai/labels: 404 - Not Found // See: https://docs.github.com/rest/reference/issues#create-a-label
/app/vendor/bundle/ruby/2.7.0/gems/octokit-4.25.1/lib/octokit/response/raise_error.rb:14:in `on_complete'
/app/vendor/bundle/ruby/2.7.0/gems/faraday-2.3.0/lib/faraday/middleware.rb:18:in `block in call'
/app/vendor/bundle/ruby/2.7.0/gems/faraday-2.3.0/lib/faraday/response.rb:42:in `on_complete'
/app/vendor/bundle/ruby/2.7.0/gems/faraday-2.3.0/lib/faraday/middleware.rb:17:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/octokit-4.25.1/lib/octokit/middleware/follow_redirects.rb:73:in `perform_with_redirection'
/app/vendor/bundle/ruby/2.7.0/gems/octokit-4.25.1/lib/octokit/middleware/follow_redirects.rb:61:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/faraday-2.3.0/lib/faraday/rack_builder.rb:153:in `build_response'
/app/vendor/bundle/ruby/2.7.0/gems/faraday-2.3.0/lib/faraday/connection.rb:445:in `run_request'
/app/vendor/bundle/ruby/2.7.0/gems/faraday-2.3.0/lib/faraday/connection.rb:281:in `post'
/app/vendor/bundle/ruby/2.7.0/gems/sawyer-0.9.2/lib/sawyer/agent.rb:99:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/octokit-4.25.1/lib/octokit/connection.rb:156:in `request'
/app/vendor/bundle/ruby/2.7.0/gems/octokit-4.25.1/lib/octokit/connection.rb:28:in `post'
/app/vendor/bundle/ruby/2.7.0/gems/octokit-4.25.1/lib/octokit/client/labels.rb:44:in `add_label'
/app/objects/vcs/github.rb:78:in `add_label'
/app/objects/tickets/tagged_tickets.rb:45:in `block in submit'
/app/objects/tickets/tagged_tickets.rb:45:in `each'
/app/objects/tickets/tagged_tickets.rb:45:in `submit'
/app/objects/tickets/commit_tickets.rb:36:in `submit'
/app/objects/tickets/emailed_tickets.rb:35:in `submit'
/app/objects/tickets/sentry_tickets.rb:45:in `submit'
/app/objects/puzzles.rb:136:in `block in expose'
/app/objects/puzzles.rb:126:in `loop'
/app/objects/puzzles.rb:126:in `expose'
/app/objects/puzzles.rb:38:in `deploy'
/app/objects/jobs/job.rb:38:in `proceed'
/app/objects/jobs/job_starred.rb:32:in `proceed'
/app/objects/jobs/job_recorded.rb:31:in `proceed'
/app/objects/jobs/job_emailed.rb:33:in `proceed'
/app/objects/jobs/job_commiterrors.rb:33:in `proceed'
/app/objects/jobs/job_detached.rb:48:in `exclusive'
/app/objects/jobs/job_detached.rb:36:in `block in proceed'
/app/objects/jobs/job_detached.rb:36:in `fork'
/app/objects/jobs/job_detached.rb:36:in `proceed'
/app/0pdd.rb:517:in `process_request'
/app/0pdd.rb:355:in `block in <top (required)>'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1685:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1685:in `block in compile!'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1023:in `block (3 levels) in route!'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1042:in `route_eval'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1023:in `block (2 levels) in route!'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1071:in `block in process_route'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1069:in `catch'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1069:in `process_route'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1021:in `block in route!'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1018:in `each'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1018:in `route!'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1140:in `block in dispatch!'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1112:in `block in invoke'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1112:in `catch'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1112:in `invoke'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1135:in `dispatch!'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:949:in `block in call!'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1112:in `block in invoke'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1112:in `catch'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1112:in `invoke'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:949:in `call!'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:938:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/rack-protection-2.2.0/lib/rack/protection/xss_header.rb:18:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/rack-protection-2.2.0/lib/rack/protection/path_traversal.rb:16:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/rack-protection-2.2.0/lib/rack/protection/json_csrf.rb:26:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/rack-protection-2.2.0/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/rack-protection-2.2.0/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/rack-protection-2.2.0/lib/rack/protection/frame_options.rb:31:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/rack-2.2.4/lib/rack/logger.rb:17:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/rack-2.2.4/lib/rack/common_logger.rb:38:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:255:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:248:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/rack-2.2.4/lib/rack/head.rb:12:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/rack-2.2.4/lib/rack/method_override.rb:24:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:218:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1992:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1552:in `block in call'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1768:in `synchronize'
/app/vendor/bundle/ruby/2.7.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1552:in `call'
/app/vendor/bundle/ruby/2.7.0/gems/rack-2.2.4/lib/rack/handler/webrick.rb:95:in `service'
/app/vendor/ruby-2.7.6/lib/ruby/2.7.0/webrick/httpserver.rb:140:in `service'
/app/vendor/ruby-2.7.6/lib/ruby/2.7.0/webrick/httpserver.rb:96:in `run'
/app/vendor/ruby-2.7.6/lib/ruby/2.7.0/webrick/server.rb:307:in `block in start_thread'

The puzzle 2-e4762e32 has disappeared from the source code, that's why I closed this issue.

@0pdd the puzzle #21 is still not solved.

@0pdd the only puzzle #21 is solved here.


chore(deps): upgrade path-parse in test/yarn.lock

This PR fixes a minor issue with path-parse in test/yarn.lock.
Fixes #4279

Argh, macOS build failed. Not sure if we need to do this. I'll cancel and rerun

Not sure why the audit-ci is timing out (didn't change anything there) but otherwise, this passed CI so merging


Upload PAM50 registered labels fot this dataset

Hello team,
I have PAM50 registered labels currently in a private google drive data-single-subject_PAM50_seg.zip that are used to train the model for TotalSegmentatorMRI project.
How can I upload those labels to this repo?
https://github.com/neuropoly/totalsegmentator-mri/pull/16#discussion_r1480637926
Thanks,
Yehuda

The answer is the same as in the issue data-multi-subject#155, but thanks for opening a separate issue for this repository too.


[bug]: watchtower server unable to handle state update

Background
I'm using a watchtower server and client pair for development, which is why the client is often restarted. The server has been offline as well for some time, which is why I think they somehow become unsynced.
lncli wtclient towers was empty, so I added a new tower/session. The session seemed to be added correctly, I have "num_sessions_acquired": 2.
The server shows some logs:
[INF] WTWR: Accepted incoming peer SESSION@<IP_ADDRESS>:49498
[ERR] WTWR: Unable to handle CreateSession from SESSION: connection with SESSION failed with code=CreateSessionCodeAlreadyExists
[INF] WTWR: Releasing incoming peer SESSION@<IP_ADDRESS>:49498

I also see those lines:
[INF] WTWR: Accepted incoming peer SESSION@<IP_ADDRESS>:41614
[ERR] WTWR: Unable to handle StateUpdate from SESSION: connection with SESSION failed with code=StateUpdateCodeClientBehind
[INF] WTWR: Releasing incoming peer SESSION@<IP_ADDRESS>:41614

It would be great to know how to get out of this state, perhaps adding a command that lets one remove sessions from the client and/or the server would help.
Your environment

server: lnd v0.15.5-beta
client: lnd v0.16.0-rc

cc: @ellemouton

just making a note that another user from slack also ran into the StateUpdateCodeClientBehind error:
2023-03-05 22:02:48.100 [WRN] WTCL: (anchor) SessionQueue(02e873cf0d9f3e93b1910fdc5344ae7b60e14f8d12c9560b38adefbfd17675bd51) unable to upload state update to tower=02b759a578157393d2a70444ff9204f2ca5c0c0dfac01d0873f1b0d57f090685c1@<IP_ADDRESS>:9911: received error code StateUpdateCodeClientBehind in StateUpdateReply for seqnum=1
2023-03-05 22:02:48.100 [ERR] WTCL: (anchor) SessionQueue(02e873cf0d9f3e93b1910fdc5344ae7b60e14f8d12c9560b38adefbfd17675bd51) unable to send state update: received error code StateUpdateCodeClientBehind in StateUpdateReply for seqnum=1

I think currently these non-OK statuses are completely unhandled in the tower client. So need to:

Find out what could be the cause of these errors
Implement a recovery (either auto recovery or allow user to force recovery)

fixed in https://github.com/lightningnetwork/lnd/pull/7541 :)


Fix TCP port range and string interpolation typos (#2759)

Pull request opened by the merge tool on behalf of #2759

Merged into branches iso3 in db11672693f552248635ea5638e34d512d21c289


Allow the client to take http.Handler

Right now the client only supports http.HandlerFunc. The more generic interface for Go is the http.Handler which is the interface that supports ServeHTTP. Instead of requiring HandlerFunc, it would be nice if the code accepted the http.Handler interface instead.

something like this? https://github.com/deferpanic/deferclient/pull/51

Yeah, though I'm surprised the code between the http.Handler and http.HandlerFunc are not shared since you can turn a http.HandlerFunc into an http.Handler

for sure - just seeing if that was the right direction

cc @pspeter3 https://github.com/deferpanic/deferclient/pull/51

This would be a fantastic addition, :+1: on getting #51 merged.

merged


[Macros] Diagnose invalid attached macros at the attribute location instead of the declaration.

@swift-ci please smoke test


Password functionality

Having the password hashing/checking functionality was really helpful for me!
Quick thought/question... Wouldn't saving the salt phrase along with the hash in the database essentially negate the purpose of hashing? I'm definitely no cryptographer, but that's what it seems like to me.

Sorry for not responding earlier, GitHub doesnt want to tell me about notifications for some reason!
Salting is used to combat "Rainbow Tables" which are tables of precalculated hashes for a certain hashing algo. Salts are completely unique per password and make rainbow tables useless by making it so each password would have a different hash than the other, making it so you would have to generate a rainbow table for every password in the database. At that point, you would be better off just brute forcing it manually, using up resources per attempt.
or in other words:

the point of the salt is simply to make it so that one rainbow table can't break every password in the DB.


kvstore: Fix aborted delayed delete warning

The code is generic and has nothing todo with nodes. Fix the warning
message.
Fixes: 07312c6d155 ("pkg/{kvstore,node}: delay node delete event in kvstore")

No need to run full CI, marked as ready to merge.


Simplify scalar handling in basic_math

Removed unnecessary preprocessing
Use math.log in preference to numpy.log (math is faster)
Changed class names

Use math.log in preference to numpy.log (math is faster)

I confirmed:
In [8]: dtype
Out[8]: dtype('float32')

In [10]: %timeit np.log(2.0, dtype=dtype)
1.29 µs ± 17.6 ns per loop (mean ± std. dev. of 7 runs, 1000000 loops each)

In [12]: %timeit dtype.type(math.log(2.0))
451 ns ± 13.2 ns per loop (mean ± std. dev. of 7 runs, 1000000 loops each)

Please explain why you want to change the name of FunctionNodes.

The names *Const were clearer than *Scalar in that the FunctionNodes don't take the corresponding operands.
Prefixing _ to the names is acceptable because they have label attributes.  (Otherwise I'd rather not.)

I reverted class renames.

The names *Const were clearer than *Scalar in that the FunctionNodes don't take the corresponding operands.

I thought the opposite. These FunctionNodes takes only scalars, not other constants (ndarrays).

If I can't rename the classes, can I rename self.value as self.scalar? It took me a while to understand they're actually scalars.

Please rebase this because I merged #5439 .

Jenkins, test this please.

Jenkins CI test (for commit 34ee9a6453b164c2f7b86fc6bc6e55cea66f10aa, target branch master) succeeded!


Improve the usability of WebClient

From an internal feed back:

What would the ideal API for building an HTTP request look like? Do you have some imaginary ideal example?

Using method chains like Spring WebClient is easy for me to write http request. Annotation pattern like Retrofit is also easy for me.I prefer the Spring WebClient way to annotation pattern.

What is the library/API you think Armeria team should benchmark?

Spring WebClient

What other features would you like to see in Armeria?

Prepare a method which maps HttpResponse to Java Object, like bodyToMono<T>

Related: #2148

https://www.reddit.com/r/java/comments/gcctln/which_http_client_framework_do_people_personally/

https://www.reddit.com/r/java/comments/gy8vi2/which_openfeign_client_is_the_best/

https://stackoverflow.com/questions/63660975/armeria-http-client-how-to-add-query-string-parameters#comment112614741_63664409
It may be useful if we can build/execute an HttpRequest fluently, so that, for example, add a query parameter easily.
// Not the final form - just an idea
HttpRequest req =
    HttpRequest.builder(HttpMethod.GET, "/foo")
               .queryParam("bar", "2")
               .cookie(...)
               .build();
webClient.execute(req);

// and/or:
webClient.prepare(HttpMethod.GET, "/foo")
         .queryParam("bar", "2")
         .cookie(...)
         .execute(); // or .execute(String.class) for automatic conversion

@ptrthomas wrote:

understood! maybe you should just accept an instance of QueryParams for e.g. webClient.post("/upload", qp, "{ \"foo\": \"bar\" }"), yes it is extra clunky, but it will help those new to the framework to be "aware" of this helper. a compromise would be to add queryParam() to RequestHeadersBuilder.

I'd love to take a stab. An idea on how the HttpRequestBuilder may look like
HttpRequestBuilder.[get,post,put,..]  // shortcut for method(HttpMethod.*)
                  .method(HttpMethod)
                  .path(String)
                  .mediaType(MediaType)
                  .headers(HttpHeaders)
                  .content(CharSequence|String|byte[]|HttpData)
                  .pathParams(Map<String, String>)
                  .queryParams(QueryParams)
                  .cookies(Cookies)
                  .timeout(long)

There may also be queryParam or cookie (singular) to add a single value. Then we can delegate all HttpRequest.of to builder. I think we can even deprecate the more complex ones in favor of builder pattern.
I'm still thinking on how webClient.prepare()...execute() would work. Maybe having another class (WebClientRequestBuilder?) that extends HttpRequestBuilder with an execute?

Yeah, having a class like WebClientRequestBuilder would be nice. We could extract the common methods in HttpRequestBuilder into some common interface or abstract class. What do you think, @tumile ?

https://www.mocklab.io/blog/which-java-http-client-should-i-use-in-2020/


Provide tree of headings in @island/headings

Is your feature request related to a problem? Please describe.
Since the @islands/headings packages provides headings as a list, instead of a tree, I am unable to render a proper tree in the table of contents.
Describe the solution you'd like
I would prefer that during parsing of the AST, headings be compiled into a tree-structure instead of (or in addition to) a list so that the relationships between headings is also available in the post.meta field.
Describe alternatives you've considered
This could be accomplished by a separate plugin but a lot of the code would be duplicated between the @islands/heading module and the separate one.
Additional context
Having the headings as a tree would make it possible to index the headings and provide meaningful numbering to them as well. For example, something like this would be possible if the headings were a tree.
§1 Chapter
  §1.1 Section
  §1.2 Section
    §1.2.1 Subsection
§2 Chapter
...

I'm happy to make a PR if this change seems useful to the general user base.

You can already create a tree structure from the list of headings.
Would you describe what structure you would expect to see when using "tree mode"?

I see your point about creating a separate module:

a lot of the code would be duplicated

Given that this feature seems reasonably common, it might make sense to include this in @islands/headings out of the box, under a nested: true opt-in setting (or similar).
Feel free to make a PR, and we can discuss what the API would look like. Thanks!


Improved slide styling options and added some features

Added title and description styling support for pageArray similar to imgStyle for images. Title and description are now centered (text alignment) by default. Added backwards compatible support for static image assets for pageArray.
Resolves: #5

Thanks for your enthusiastic pull requests
But I think https://github.com/FuYaoDe/react-native-app-intro/pull/34 this solution better
What do you think?

@FuYaoDe I totally agree with this but would you mind adding center alignment for title and description + title/description styling ?

title add center is ok but description not good, because maybe someone described very long will look unbalanced, and pageArray add title/description styling is good feature

I understand, you are right. Thanks for your attention and this helpful library.
Cheers !