Bad performance

Describe the bug
I read issue #31, which addressed bad performance issues. It looked like it had been fixed, but I'm still not able to squeeze much more than 500req/sec out of it. I'm connecting from a windows VM to a Linux server running mosquitto. Both are running on the same hardware. The mosquitto is practically asleep, while the .NET application is running at full tilt. I've tried it with both with and without async calls.
Which project is your bug related to?

Client

To Reproduce
Steps to reproduce the behavior:

Connect to server
Send messages in an infinite loop
Observe sending rate

Expected behavior
A clear and concise description of what you expected to happen.
Additional context / logging
KeepAlive timespan is set to 1 day
Code example
    static void Test(int total)
    {
        var factory = new MqttFactory();
        var mqttClient = factory.CreateMqttClient();
        var options = new MqttClientOptionsBuilder()
            .WithTcpServer("<IP_ADDRESS>")
            .WithKeepAlivePeriod(new TimeSpan(1, 0, 0, 0))
            .Build();

        //await mqttClient.ConnectAsync(options, CancellationToken.None);
        mqttClient.ConnectAsync(options, CancellationToken.None).Wait();

        var message = new MqttApplicationMessageBuilder()
            .WithTopic("SomeTopic")
            .Build();

        for (var n = 0; n < total; n++)
        {
            message.Payload = Encoding.UTF8.GetBytes($"test {n}");

            //await mqttClient.PublishAsync(message, CancellationToken.None);
            mqttClient.PublishAsync(message, CancellationToken.None).Wait();

            if (n % 1000 == 0)
            {
                Console.WriteLine($"n: {n}");
            }
        }
    }

I just did a quick check using M2Mqtt, which seems to do a little under 10k req/sec under the same circumstances. So it doesn't seem to be an issue with my setup.

Hi,
please answer the following questions so that I can try to analyze this issue:

Please avoid using keep alive interval (while testing this issue).
Which version do you use? 3.0.10-rc1?
Which platform do you use? .NET 4.5.2, 4.6, netstandard2.0?
Do you use the nuget or just some DLLs?

Please try 3.0.10-rc2 in the meantime.

use async version and run it in release mode, i didnt try your code but when running the benchmarks im above 200K msg/sec

if i run your code slightly modified i get 50k / sec with mqttnet and 300K msg/sec with kesterel as server and pipelines based transport in the client
using Microsoft.AspNetCore;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Hosting;
using Microsoft.Extensions.DependencyInjection;
using MQTTnet;
using MQTTnet.AspNetCore;
using MQTTnet.AspNetCore.Client;
using MQTTnet.Client.Options;
using MQTTnet.Server;
using System;
using System.Diagnostics;
using System.Text;
using System.Threading;
using System.Threading.Tasks;

namespace ConsoleApp3
{
    class Program
    {
        static async Task Main()
        {
            await MqttNet();
            await MqttNetAspnetCore();
            Console.ReadLine();
        }

        static async Task MqttNet()
        {
            var factory = new MqttFactory();

            var server = factory.CreateMqttServer();

            var mqttClient = factory.CreateMqttClient();
            var options = new MqttClientOptionsBuilder()
                .WithTcpServer("<IP_ADDRESS>")
                .WithKeepAlivePeriod(new TimeSpan(1, 0, 0, 0))
                .Build();

            await server.StartAsync(new MqttServerOptionsBuilder().Build());

            await mqttClient.ConnectAsync(options, CancellationToken.None);

            var message = new MqttApplicationMessageBuilder()
                .WithTopic("SomeTopic")
                .Build();

            var sw = Stopwatch.StartNew();
            var total = 100000;

            for (var n = 0; n < total; n++)
            {
                message.Payload = Encoding.UTF8.GetBytes($"test {n}");

                await mqttClient.PublishAsync(message, CancellationToken.None);

                if (n % 1000 == 0)
                {
                    //Console.WriteLine($"n: {n}");
                }
            }

            sw.Stop();

            Console.WriteLine($"msg/sec {total / sw.Elapsed.TotalSeconds}");
        }

        class Startup
        {
            public void ConfigureServices(IServiceCollection services)
            {
                services
                    .AddHostedMqttServer(mqttServer => mqttServer.WithoutDefaultEndpoint())
                    .AddMqttConnectionHandler()
                    .AddConnections();
            }

            public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
            {
            }
        }

        static async Task MqttNetAspnetCore()
        {
            var factory = new MqttFactory();

            var host = WebHost.CreateDefaultBuilder()
                .UseKestrel(o =>
                {
                    o.ListenAnyIP(1883, l => l.UseMqtt());
                })
                .UseStartup<Startup>()
                .Build();

            var mqttClient = factory.CreateMqttClient(new MqttClientConnectionContextFactory() );
            var options = new MqttClientOptionsBuilder()
                .WithTcpServer("<IP_ADDRESS>")
                .WithKeepAlivePeriod(new TimeSpan(1, 0, 0, 0))
                .Build();

            await host.StartAsync();

            await mqttClient.ConnectAsync(options, CancellationToken.None);

            var message = new MqttApplicationMessageBuilder()
                .WithTopic("SomeTopic")
                .Build();

            var sw = Stopwatch.StartNew();
            var total = 100000;

            for (var n = 0; n < total; n++)
            {
                message.Payload = Encoding.UTF8.GetBytes($"test {n}");

                await mqttClient.PublishAsync(message, CancellationToken.None);

                if (n % 1000 == 0)
                {
                    //Console.WriteLine($"n: {n}");
                }
            }

            sw.Stop();

            Console.WriteLine($"msg/sec {total / sw.Elapsed.TotalSeconds}");
        }
    }
}

Can this be closed? It seems like we're not able to reproduce your issue, @tomwimmenhove...

Strange. I'll look into it again if/when I have the time. I'll close it and maybe re-open if I find out more. Thanks for your trouble!


Variable name for the eager test

Test failure seems like infra failure, since one of the previously failing suites passed, I'm assuming it's all good.


[sqlsmith_branch_release]:be crash,stack:pipeline::ExchangeSinkOperator

Be stack
*** Aborted at<PHONE_NUMBER> (unix time) try "date -d @1655877785" if you are using GNU date ***
PC: @     0x7fd07fceb337 __GI_raise
*** SIGABRT (@0x3e800002896) received by PID 10390 (TID 0x7fcffa4f7700) from PID 10390; stack trace: ***
    @          0x3f6fad2 google::(anonymous namespace)::FailureSignalHandler()
    @     0x7fd0807a05f0 (unknown)
    @     0x7fd07fceb337 __GI_raise
terminate called recursively
    @     0x7fd07fceca28 __GI_abort
    @          0x187299d _ZN9__gnu_cxx27__verbose_terminate_handlerEv.cold
    @          0x5973366 __cxxabiv1::__terminate()
    @          0x59733d1 std::terminate()
    @          0x5973524 __cxa_throw
    @          0x18728a4 _Znwm.cold
    @          0x199f930 std::vector<>::_M_default_append()
    @          0x19fdcff starrocks::vectorized::BinaryColumnBase<>::append_selective()
terminate called recursively
    @          0x24bc7b8 starrocks::vectorized::NullableColumn::append_selective()
terminate called recursively
    @          0x24aa27a starrocks::vectorized::Chunk::append_selective()
    @          0x3475e80 starrocks::pipeline::ExchangeSinkOperator::Channel::add_rows_selective()
    @          0x347779d starrocks::pipeline::ExchangeSinkOperator::push_chunk()
    @          0x2874eb7 starrocks::pipeline::PipelineDriver::process()
    @          0x286a2b4 starrocks::pipeline::GlobalDriverExecutor::_worker_thread()
    @          0x2112059 starrocks::ThreadPool::dispatch_thread()
    @          0x210dc0a starrocks::Thread::supervise_thread()
    @     0x7fd080798e65 start_thread
    @     0x7fd07fdb388d __clone
    @                0x0 (unknown)

StarRocks version (Required)

You can get the StarRocks version by executing SQL select current_version()
mysql> select current_version();
+----------------------------+
| current_version()          |
+----------------------------+
| BRANCH-2.3-RELEASE 01b9054 |
+----------------------------+
1 row in set (0.00 sec)

Executing the following SQL will cause BE crashed with the same core stack:
select     ref_0.d_year as c0,    ref_0.d_month as c1,         max(       cast(ref_0.d_datekey as INT)) over (partition by ref_0.d_datekey order by ref_0.d_year) as c2,    unix_timestamp() as c3,    pi() as c4,    cast(coalesce(ref_0.d_lastdayinmonthfl,     ref_0.d_daynuminmonth) as INT) as c5,    ref_0.d_lastdayinmonthfl as c6,    ref_0.d_year as c7,    ref_0.d_year as c8 from    sqlsmith.hive_ssb_100g_orc_dates as ref_0 where (ref_0.d_date <= ref_0.d_month)    and (ref_0.d_datekey is NULL) limit 102;

select *
from  sqlsmith.hive_ssb_100g_orc_dates as ref_0
where (ref_0.d_date <= ref_0.d_month)   and (ref_0.d_datekey is NULL);

This SQL throws "ERROR 1064 (HY000): mismatched row count: 0 vs 2556"


Relocate if statement so schemaRegistry is still defined if pandaproxy is not enabled

This should hopefully close/fix https://github.com/redpanda-data/helm-charts/issues/237, assuming there is no dependency between schema registry and pandaproxy.
If there is, I guess close dismiss both the issue and this PR 😀

@vuldin Thanks for review 😊 I just rebased + bumped version to 2.3.16 (was 2.3.15 when you reviewed) due to another PR being merged.


Update API server --apiserver-count description.

A validation check is added for option --apiserver-count
in kubernetes ticket #38143. As a result, update related
description in doc.

This change is

Couple of comments, and needs to have the merge conflicts resolved.

thanks @devin-donnelly for the comments, have updated the patch, please take a look


Auto-close quotes do not work on MacOS with 'US International - PC' keyboard layout

Type: Bug
Does this issue occur when all extensions are disabled?: Yes
Does this issue occur in VS Code Insiders version?: Yes
Does this issue occur in Intel-based macs?: No
Since I got the latest version two days ago, 1.72.2, the auto-close quotes feature has stopped working as expected on my home computer, an Apple Silicon Macbook Air.
The feature works in my work computer, an Intel-based Mac with the same VSCode version and the same extensions + configurations synced up. It also works for all other auto-closing tags (parentheses, brackets, and braces). The issue only happens with quotes and double quotes.
When I select a word and type a quote, I expect it to be surrounded by quotes.
However, the word gets deleted, and I see only a single quote.
Something is clearly overriding it: when I hit Cmd+Z, it executes the undo operation, and the single quote is replaced by the expected result, the word between two quotes.
When I undo it again, I see a single quote again. When I undo it for the third time, the word returns to its original state. It takes three undo operations to get back to the original.

The issue happens when I select the "US International - PC" keyboard layout.
It works with the regular "US" keyboard layout.

@rafaelbeckel This works as expected for me. Not sure if you're aware, `, 'and " are special under the US Intl keyboard layout and act as "dead" keys, used to create accented letters on US Intl. To insert a ' you need to press ' and <space>:
https://user-images.githubusercontent.com/5047891/197353136-40be5db0-e5fb-48b4-ab5b-4f267eac6b37.mp4

mine 'auto insert closing quotes' not working only in markdown file,  even in https://vscode.dev/, please take a look:

with no extra settings:

with no extension installed:

@onezhaoyn What OS and browser are you using?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


typo: mediun -> median

@nschonni : Thanks for your contribution! The author, @, has been notified to review your proposed change.


Consistent behavior and control over numeric object initialization and setSize copying etc.

I fixed an earlier problem in test-declare (not actually related to this PR, but I fixed it here anyway).
Now there is a problem I'm not understanding.  test-declare fails because it says nimC can't be found.  But nimC is in the NAMESPACE exports, and test-declare works on my machine.  Chris can you try it?

is all of this in devel? I just did git pull and didn't pull anything new
in.
On Fri, Apr 14, 2017 at 10:05 AM, perrydv<EMAIL_ADDRESS>wrote:

I fixed an earlier problem in test-declare (not actually related to this
PR, but I fixed it here anyway).
Now there is a problem I'm not understanding. test-declare fails because
it says nimC can't be found. But nimC is in the NAMESPACE exports, and
test-declare works on my machine. Chris can you try it?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nimble-dev/nimble/pull/289#issuecomment-294192317,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACYr3kQf5GH-AxrSJckuOYmvQx_OzDjwks5rv6dKgaJpZM4M9KLC
.

No, it's in PR #289, which is where I made the comment from (but I guess that's not clear on receiving end).    What I'd like to do is merge this and the other pull request now for simplicity and then we can figure out the test-declare issue on devel.  OK?

yes, at this stage, having things in other branches is obviously confusing
me!
On Fri, Apr 14, 2017 at 10:37 AM, perrydv<EMAIL_ADDRESS>wrote:

No, it's in PR #289 https://github.com/nimble-dev/nimble/pull/289,
which is where I made the comment from (but I guess that's not clear on
receiving end). What I'd like to do is merge this and the other pull
request now for simplicity and then we can figure out the test-declare
issue on devel. OK?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nimble-dev/nimble/pull/289#issuecomment-294198592,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACYr3ps_1qC9mvRF2WC9jDmQfyBtP1I6ks5rv67UgaJpZM4M9KLC
.

Also merging this.


protractor not working with firefox

(node:13959) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
[14:00:05] I/launcher - Running 1 instances of WebDriver
[14:00:05] I/local - Starting selenium standalone server...
[14:00:06] I/local - Selenium standalone server started at http://<IP_ADDRESS>:52046/wd/hub
[14:00:06] E/launcher - The path to the driver executable must be set by the webdriver.gecko.driver system property; for more information, see https://github.com/mozilla/geckodriver. The latest version can be downloaded from https://github.com/mozilla/geckodriver/releases
[14:00:06] E/launcher - WebDriverError: The path to the driver executable must be set by the webdriver.gecko.driver system property; for more information, see https://github.com/mozilla/geckodriver. The latest version can be downloaded from https://github.com/mozilla/geckodriver/releases
at Object.checkLegacyResponse (/usr/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/error.js:505:15)
at parseHttpResponse (/usr/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/http.js:509:13)
at doSend.then.response (/usr/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/http.js:440:13)
at
at process._tickCallback (internal/process/next_tick.js:169:7)
From: Task: WebDriver.createSession()
at Function.createSession (/usr/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver.js:777:24)
at Function.createSession (/usr/lib/node_modules/protractor/node_modules/selenium-webdriver/firefox/index.js:640:55)
at createDriver (/usr/lib/node_modules/protractor/node_modules/selenium-webdriver/index.js:167:33)
at Builder.build (/usr/lib/node_modules/protractor/node_modules/selenium-webdriver/index.js:629:16)
at Local.getNewDriver (/usr/lib/node_modules/protractor/built/driverProviders/driverProvider.js:53:33)
at Runner.createBrowser (/usr/lib/node_modules/protractor/built/runner.js:195:43)
at q.then.then (/usr/lib/node_modules/protractor/built/runner.js:339:29)
at _fulfilled (/usr/lib/node_modules/protractor/node_modules/q/q.js:834:54)
at self.promiseDispatch.done (/usr/lib/node_modules/protractor/node_modules/q/q.js:863:30)
at Promise.promise.promiseDispatch (/usr/lib/node_modules/protractor/node_modules/q/q.js:796:13)
[14:00:06] E/launcher - Process exited with error code 199

@erved
Look like this is related to https://github.com/angular/protractor/issues/4408 and https://github.com/angular/protractor/issues/4411. This is fixed in PR https://github.com/angular/protractor/pull/4412 but is not released yet. Hopefully there will be a release a.s.a.p.. I'm not able to do that, that should be done by 1 of the members of the Protractor core team.
One advice for the next time, please use the issue template to indicate otherwise) that you have an issue
From the getting help section of the README.

Please ask usage and debugging questions on StackOverflow (use the "protractor" tag) or in the Angular discussion group. (Please do not ask support questions here on Github.)

You now don't have all the information for us to debug the issue (platform, versions and so on). I'm going to close it for now
Thanks!


Vue3 cannot deselect when using multiple

I use Asynchronous select to get the data but when I want to delete the selected data it cannot, please help

Feel free to reopen with a reproducible example. https://jsfiddle.net/g56vfpe4/

I was having a similar problem with version 1.5.0.
I had more than one components that the user supposed not to be able to deselect. And I could achieve that functionality with only one component.
Now that I've upgraded to the version 2.1.2, the feature is working just fine.
I need to adjust the css though.


Azure CLI task errors, but task is marked as success

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug
Enter Task Name: AzureCLIV2
Environment

Server - Azure Pipelines

If using Azure Pipelines, provide the account name, team project name, build definition name/build number: cbinfrastructure/cbi buildId=161260

Agent - Hosted

If using Hosted agent, provide agent queue name: Azure Pipelines/Windows-2019

Issue Description
I'm not sure if it's related to 12676, but twice in the last week I've seen a powershell script in the azure cli task throw an error, but the task does not fail

The errors show up on the pipeline summary as errors, but the task and job are still green

@hbuckle can you please enable debug logs and attach it here?
Also can you please attach the yaml for your task instance.
The task will typically not fail if the script returns exit code 0

@bishal-pdMSFT - It has only happened twice so I don't have a debug log, but this is the yaml
- task: AzureCLI@2
  displayName: terraform apply
  inputs:
    addSpnToEnvironment: true
    azureSubscription: ${{ parameters.environment.service_connections.azure_contributor }}
    workingDirectory: $(ResolvedWorkingDirectory)
    scriptType: pscore
    scriptLocation: inlineScript
    powerShellErrorActionPreference: stop
    failOnStandardError: true
    inlineScript: |
      $ErrorView = "NormalView"
      Import-Module PSDeployTools
      # various commands
      throw $stderrstring

The throw statement combined with powerShellErrorActionPreference: stop should cause a terminating error and fail the task, which is what usually happens

@hbuckle We've fixed and rolled out! Please check if the issue is happening again (make sure you have system.debug set as true when running the pipeline). If it's reproducible, please share the debug logs here or share them in a mail to<EMAIL_ADDRESS>

@hbuckle Since we couldn't get a response from you, we're closing the issue. Feel free to re-open if the issue persists. Thank!


Before handoff, figure out netlify setup

Before handoff, figure out netlify setup - who has access, can we control access with a google group, do we need a paid plan, is there anything we need to document about the account/site setup, etc.

Since we're only using this for deploy previews now, the work here is really just documentation of the Netlify setup to ensure that access is properly controlled


tests: update fetcher tests

The following PR updates the fetcher tests

cc @ivanayov

Looks good to me, just one comment.


Share Option

Create a share option (button maybe) that allows users to easily share their weather updates with friends and family.

Assign this issue to me please.


How to localize

How can I start localizing the new Chartbuilder?

Hmm, Chartbuilder 2 isn't quite set up to swap in another language, but it should be.
As a start (i guess) here's a (likely incomplete) list of places that contain thing that should be able to be localized:

Error Messaging in src/js/components/shared/DataInput.jsx
All of the headers following a step-number in various files
Every place there is a Button rendered in various files
Every place there is a labeled dropdown such as in the date format options
Sugar.js is already locale aware but I don't think we're currently loading in all locales for performance reasons.
Chartbuilder attempts to localize number formats automatically in the SessionStore but the fallback to comma separators and dot decimals should be able to be customized

The locale indicator should ultimately be stored in the SessionStore (Right @nsonnad?)
@probus what do you think would be the best way to go about this?

I've changed most of the styling for my publiciation and to make it work one d/m/y data.
Here are the key minimum things I did:

src/js/util/process-dates.js
Line 8: +Date.setLocale('en-AU');

Line 11: 	"lmdy": function(d) {

  return d.format('{M}/{d}/{yy}');

  return d.format('{M}/{d}/{yyyy}');

},

Line 15: 	"mmdd": function(d) {

  return d.format('{M}/{d}');

  return d.format('{d}/{M}');

Customise font sizes:
src/styl/chart-renderer.styl - Change $em_sizes

Import custom fonts:
src/styl/fonts.styl

Select custom fonts:
src/styl/type.styl

Set new default colours:
src/styl/colors.styl


Add zig std version info in %%status

Maybe this is more useful pushing into analysis-buddy. That way we can hardcode the SHA instead of using master.


 (Take a look at the example vector and what it gets projected to. Hopefully it should make sense.) https://github.com/StrangeZak/Handmade-Math/blob/master/test/hmm_test.cpp#L1662-L1673

By the way, to test it, all I did was change my projection matrix to use HMM_Orthographic with sensible settings instead of HMM_Perspective. My model and view matrices remained the same.


The size of word.dic or char.dic is different from the provided Chinese EMLo model!

The error like the under:
RuntimeError: Error(s) in loading state_dict for ConvTokenEmbedder:
size mismatch for word_emb_layer.embedding.weight: copying a param with shape torch.Size([71222, 100]) from checkpoint, the shape in current model is torch.Size([6169, 100]).
I think The model has been updated, but the corresponding vocab didn't. hope it be solved quickly!

我也遇到了此问题，请问您是怎么解决的啊

我也遇到了这个问题，请问怎么解决呢


Impossible to set branch deployment options with this action?

I have a single git repo which drives two different Cloudflare Pages.

selfie.dev is on branch deploy: release is production, selfie.dev/* is preview, works great!

kdoc.selfie.dev comes from the same repo, so it's not allowed to be on branch deploy, so I'm using this action, which only runs on the release branch

https://github.com/diffplug/selfie/blob/main/.github/workflows/publish-kdoc.yml

but looking at the deployments, the pushed to release are only preview. I have to push from main to count as production

but I don't want to deploy from main, and there's no way to change that because that settings window doesn't show up in the settings

The branch name is used by Cloudflare Pages to determine if the deployment is production or preview. Read more about git branch build controls.

How do I get those branch build controls? Am I missing something?

The branch control doesn't work on tag based automation. I still don't want to make my CI run every time on push. Have anyone figured out?


Bias UDP send loop towards the shutdown signal

What does this PR do?
We've observed an issue where the UDP generator will run forever, ignoring the shutdown signal. This PR biases the UDP generation task towards polling the shutdown signal to avoid this.
Motivation
Stop lading processes from spinning on UDP forever.
Related issues
N/A
Additional Notes
We may consider refactoring shutdown to abort async tasks rather than signal and expect cooperation.

This is pretty wild. Even rewritten as its own async task, the UDP sender causes other tasks on the runtime not to be polled. a699c70 works around the issue by adding an explicit yield point. This is on my radar to min-repr and file upstream after further investigation.

To repro with lading:

Set up a local lading target (I'm using an agent regression container)
Add a log output to the UDP send loop
Add an independent task that logs periodically
Test with & without the yield point

Here's the lading config I'm using:
generator:
  - udp:
      seed: [2, 3, 5, 7, 11, 13, 17, 19, 23, 29, 31, 37, 41, 43, 47, 53,
             59, 61, 67, 71, 73, 79, 83, 89, 97, 101, 103, 107, 109, 113, 127, 131]
      addr: "<IP_ADDRESS>:10000"
      variant: "json"
      bytes_per_second: "500 Mb"
      block_sizes: ["1Kb"]
      maximum_prebuild_cache_size_bytes: "256 Mb"

blackhole:
  - http:
      binding_addr: "<IP_ADDRESS>:9091"

Even rewritten as its own async task, the UDP sender causes other tasks on the runtime not to be polled. a699c70 works around the issue by adding an explicit yield point.

Dang. Getting upstream consideration of this would be excellent. I have wondered now and again if we might not profitably split lading's internals up so that each component runs on a single-threaded executor on top of an OS thread we manage from startup. We'd get better isolation, at least, for things like this. Non-trivial change, but it's crossed my mind now and again.

@blt sorry for the review re-request, I missed your comments earlier

Dang. Getting upstream consideration of this would be excellent. I have wondered now and again if we might not profitably split lading's internals up so that each component runs on a single-threaded executor on top of an OS thread we manage from startup. We'd get better isolation, at least, for things like this. Non-trivial change, but it's crossed my mind now and again.

This issue has me thinking about the same thing. Either a separate OS thread or another tokio runtime on its own pool of threads.


add "/cloud2butt" endpoint

Replicated functionality of the Chrome Cloud2Butt extension: http://cloud-2-butt.tumblr.com/

:) mind resolving conflicts?

Sure, how does that look? :)

aww yeah :)


Looking forward to supporting EIP712

Like signTypedData in @metamask/eth-sig-util
Implement offline signature of EIP712 protocol
Looking forward to supporting EIP712!
Looking forward to supporting EIP712!
Looking forward to supporting EIP712!

Hi @gaga021
Thanks for your suggestion. I'll add this in me todo list.

I was able to make a package for this, @sc0Vu  can you copy the code  and integrate in your
https://github.com/web3p/web3.php/issues/286


Feature: unit testing and model-based testing

This is a meta-issue for the work on unit testing for TLA+ and support for model-based testing. All relevant issues are labelled with FMBT.

[x] Enumeration of counterexamples: #833, #827, #542
[ ] Support for VIEW in TLC configs: #851
[ ] First prototype for unit testing: #810, RFC006, and #191

[x] Check action invariants: #801
[x] Check trace invariants: #822

Shall we spin off #730 into its own meta-issue? I guess, it will be a lot of work.

No customer


unclear which parameters to pass into function updateHotspot()

Description
When attempting to change the HotSpot position using the updateHotspot() function passing in the following parameters do not seem to work.
Example Code
var modelViewer = document.querySelector('#Model-Viewer');

modelViewer.updateHotspot(("hotspot-0", "(0, 0, 0)", "(0m -.1m 0m)"));

The function reaches this point in the code and always returns null:
updateHotspot(config) {
const hotspot = this[$hotspotMap].get(config.name);
            if (hotspot == null) {
                return;
            }

It seems that the function is looking for a class that has access to a .name property, but obviously passing in a string to the function as specified in the documentation would cause the function to always return null.
I have tried passing the function in other ways since the documentation is somewhat vague, but none of the options are able to return a value for config.name which isn't null.
Live Demo

https://volcano-legendary-crafter.glitch.me/

Version

model-viewer: v1.6.0

Browser Affected

[X] Chrome, version: xx.x.xxxx.xx
[ ] Edge
[ ] Firefox
[ ] IE
[ ] Safari

OS

[ ] Android
[ ] iOS
[ ] Linux
[ ] MacOS
[X] Windows

I have found a workaround by manually setting the position of the annotation. But I notice that the annotation's position does not re-render on screen even when changing the position in code.
var HotSpot = document.querySelector('#HotSpot');

HotSpot.dataset.position = String(x) + "," + String(y) + "," + String(z);

modelViewer.updateHotspot(HotSpot);

I figured that reaching the
this[$needsRender]();
in the updateHotspot() method would cause the Hotspot to update, but this does not occur.


Should the server restart when .ruby-version is changed?

I have checked that this feature is not already implemented

[x] This feature does not exist

Use case
Ruby now plans to to a patch release every two months or so, and repos are inconsistent about updaing their .ruby-version file. Here for example it declares 3.3.4 at the moment even though 3.3.5 is released. I make a habbit of removing previous patch releases when a new one releases and just hand-edit the .ruby-version file, no big deal. But I also have to manually reload the window to make ruby-lsp pick it up.
Should this happen automatically, same as with lockfile changes?
Description
See above
Implementation
No response

Thank you for the feature proposal!
Yes, we should definitely auto-reload if the .ruby-version change. Perhaps just watching the file to trigger the reload is enough? It would be good to give it a try just to ensure it works as expected.
We received this bug report #2411 which is related.


Use flags provided as gearman payloads instead of environment variables

This allows us to run multiple gearman jobs with different values for the flags.
Tested: Brought up a local gearman worker using
godep go build && AWS_REGION='us-east-1' gearcmd -name postgres-to-redshift -parseargs=true -cmd $CODE_GOME/postgres-to-redshift/postgres-to-redshift
Then posted a job using gearman -f "postgres-to-redshift" -- "<flags>" which ran the job correctly.

LGTM!


Refactor our stats RPC calls using a Multicall contract.

Every time a user opens up the app, we're doing a few hundred RPC calls to the BSC nodes. Some users get rate limited and face weird bugs. As we add more vaults, it becomes more of a problem.
We should deploy a Multicall contract on BSC and use it to turn all those requests into 1-3

@sirbeefalot Has a multicall contract been deployed on BSC? And if so, what is its address?


Add quickstart notebook to website

This is the notebook that makes full advantage of refactoring from data_utils.py so it will probably be the easiest point of entry for newcomers.

@NoraLoose

Linking this to #45 so the updated quickstart notebook can be tested

@jerrylin96 is your suggestion to use the quickstart notebook instead of the Quickstart, or the two somehow together? Please let us know in #45 so we can test this.


Pasting ñ á é í ó ú wrong

steps to reproduce:
copy https://raw.githubusercontent.com/bitcoin/bips/master/bip-0039/spanish.txt
paste it into vcode
the chars looks equals but they aren't, try ctrl + f and type che char, it won't find it in the list
you too can try open the saved file with another editor or browser

@mrbianchi  I don't understand what the problem is. When I copy e.g. acción from the file you have provided and paste it to VS Code, I see acción rendered fine:

@mrbianchi I don't understand what the problem is. When I copy e.g. acción from the file you have provided and paste it to VS Code, I see acción rendered fine:

the chars looks equals but they aren't, try ctrl + f and type the char in the find field by your own, it won't find it in the list

Then when I use the keyboard to write ó in chrome to find the char , chrome is normalizing the .txt and/or my typed char making it to match, but the file has an invalid char? That could be affirmative I think, because testing with saveing the file or copying the tiped ó from chrome to VS Code I don't find the error.
So now I think that it isn't a VS Code error, probably is a BIP39 error and I will open the issue there.
Your explanation was very useful, thanks.

The search feature built into Chrome is very fuzzy. For example, when I search for o it matches both ós. Here is a screenshot:

I guess that makes sense given they are a web browser and people might be opening pages written in a language that users might not have a keyboard layout for, etc.
I will close this issue on our side, because we work as designed.


turn component_runit_service into a custom resource

Description
This converts the component_runit_service resource into a custom resource and adds a ChefSpec spec for it. This aims for backwards compatibility and does not attempt to improve the resource in any way.
Issues Resolved
Initiated to appease ChefSpec 7.3 in omnibus projects that depend on this cookbook. ChefSpec 7.3+ no longer supports resource definitions and will error in test runs complaining about a missing params method.
Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Can we remove this pinning with this change: https://github.com/chef-cookbooks/enterprise-chef-common/blame/master/metadata.rb#L9

@rhass 🤔 Here's what I've been able to piece together about the hard-coded path problem.
You suspect the PATH entry in the templates for debian and for ubuntu are the problem, right?
We chatted a bit about this and left off thinking we may be able to work around this with the runit_attribtutes that are passed to the runit_service resource by component_runit_service. The existing init.d templates use:

@sv_bin - set with sv_bin attribute on runit_service which is not an attribute exposed directly on component_runit_service but settable through runit_attributes
@init_dir - set to the value of parsed_lsb_init_dir which is the value of a runit attribute lsb_init_dir with a default of /etc/init.d. The enterprise-chef-common cookbook's runit recipe overrides that attribute to #{install_path}/init.

Could Chef Server's rabbitmq PATH woes be addressed by updating the sv-rabbitmq-run.erb template directly to include the paths necessary to run the service rather than in the init.d script generated by the runit cookbook for the runit_service resource?

@marcparadise Yep, I was able to use this branch in an omnibus build of chef/supermarket.

I'm for shipping this as-is to unblock some other work in flight. More improvements can be made later.


German Translation

cc @ingorichter

Argh, GitHub had some database issues when I opened this PR.
Never did I delete the branch (at least not after filing the PR; I did so before because GitHub was unresponsive and didn't seem to recognize it).
Let's hope it all works now :^)

LGTM. Merging.


Vulkan: Fog volume illumination changes with movement direction of light

Godot version
v4.0.beta.custom_build [2ec0da1a7]
System information
Linux, Iris Xe Graphics, Forward+
Issue description
With a light moving as a child of the camera, moving through a fog volume gives inconsistent lighting results depending on the direction of movement: while moving forward, the brightness of the fog decreases and while moving backwards it increases. My expectation is for movement direction to not have any effect at all on fog illumination.
Steps to reproduce
Add an OmniLight to the scene as a child of the camera and move it back and forth through the fog volume.
Minimal reproduction project
fogtest.zip
An animation is included in the project to move the camera back and forth but it also can be demonstrated in-editor if you move the camera manually while viewing the camera preview.

I can confirm this with the MRP on 4.0.beta 621e32971 (Linux, GeForce RTX 4090 with NVIDIA 525.60.11).
However, this is not a bug, but an artifact of temporal reprojection (which is done to improve quality). If you disable volumetric fog temporal reprojection in the Environment properties, the issue goes away (at the cost of lower volumetric fog rendering quality).

However, this is not a bug, but an artifact of temporal reprojection (which is done to improve quality). If you disable volumetric fog temporal reprojection in the Environment properties, the issue goes away (at the cost of lower volumetric fog rendering quality).

Its actually even simpler than that, the camera goes from one end of a fog volume to the other. When at one end, the total depth of the fog is about 4 metres, at the other end it is only a few centimeters of fog. Fog scatters light backward, so when there is more fog, there is more light reaching the camera. If you change the MRP from using a local FogVolume to using global fog, the effect disappears even with temporal accumulation on.
There is no bug here, as you approach the end of a fog volume, there will be less fog accumulating and since the background is black, the image will get darker overall. If you want the brightness of the light to stay the same, then the amount of fog in front of the camera needs to stay the same.


COVID-346-fixed-spelling

quick fix for https://github.com/covid19india/covid19india-react/issues/346

Ahmadabad is no a correct name. instead Ahmedabad has to be added into the API.
https://github.com/covid19india/api/pull/54

Thanks, but this seems to have been fixed via #429


Dataplex GCS to BQ: support for GCS Dataplex tables without partitions

Adding support for Dataplex GCS tables without partitions

Build is running without failure now


TabsTitleControl.layout() slows down editor resize

open a diff editor (side-by-side)
resize via sash:

now open two editors side-by-side
resize via sash:

Most of the time is spent in two things:

the find widget: filled #34744
TabsTitleControl.layout:

Note: the time TabsTitleControl.layout takes is significantly larger when using the steps in #34716
i.e. 3K+ code lenses.

@alexandrudima looks like most time is spend in this call:

I am happy for advice how to avoid that. The tab title control is a display:flex container that lays out all tabs. I have seen performance issues before at this location and it seems worse the more tabs are opened.
I need the offsetWidth to update the scrollbar properly that shows when tabs overflow.
Maybe one idea is to buffer the layout calls and not run them sync from the mouse move listener in the sash widget.
/cc @joaomoreno

@bpasero I use various tricks to avoid sync forced layout:

measuring unknown width/height things at creation time. i.e. if a new tab is added with a custom label, the tab width can be measured when the tab is created/added. If a tab is modified to have a different label, the width can be measured at the modification time.
keeping track of known widths. If the workbench gets resized, the width of the tabs area can be saved in memory and the DOM would not need to be queried.

IMHO those two bullet points should cover the computation of scrollWidth (sum of all tabs width) and width (this is something the workbench knows)

keeping track of known widths

Yeah, the width should actually only be measured at the top level of a layout() call chain. Every step down that chain should split that width up accordingly. The TabsTitleControl.layout() method should take a dimension as an argument.

The expensive part is indeed the call to scrollWidth where Chrome has to compute the size of each tab. Knowing the size of the container is not enough so it turns out to be a matter of caching the sizes for each tab when the tab changes.

This is really bad. When opening/reloading the workbench with just one tab, ~50ms are spend. That makes it the most expensive single call after code loading and garbage collection.

[title.cpuprofile.txt](https://github.com/Microsoft/vscode/files/1438478/title.cpuprofile.txt)

@jrieken interestingly as soon as I move that layout call into a setTimeout(0) the code is much faster. So just the fact that we force a layout in Chrome during window startup causes a performance of 50ms vs. 0.xms in the other case...

The timeline tool tells me that it's causing re-layouts. So with some setTimeout-tricks you might be lucky and get a layout-ed state but I believe the problem is some html-properties are accessed that cause the browser to relayout the whole page.

You we consider something like https://github.com/wilsonpage/fastdom?

@jrieken I think fastdom is the equivalent of our scheduleAtNextAnimationFrame where you can batch operations to run on the next animation frame.

Pushed 2 changes:

for startup: scheduling the layout at next animation frame to avoid the critical path (https://github.com/Microsoft/vscode/commit/f54d16c464ee292a55de7f1f241e2e163830b08e)
found an issue where within the layout method I would force 2 full layouts because the way code was ordered (https://github.com/Microsoft/vscode/commit/81427242c5be6557be601a3f216b9a5718f98cbb)

The fix of avoiding a second layout call brings some nice performance boost for resizing of editors.
Previously

Now

The remaining performance issue with tabs is the fact that we access offsetWidth as well as scroll via scrollLeft. The only fix here is to:

scroll via absolute positioning (negative left)
remove flex and implement absolute pixel layout for the tabs
implement custom auto-scrolling behaviour (e.g. when doing DND and reaching tabs that are scrolled away)

I am not a big fan of going away from flex, so I will stop here for now.
@jrieken I extracted the startup perf issue into https://github.com/Microsoft/vscode/issues/38404 so that we have something to close and verify for November. I will keep this issue open and restore it how it was before.

I will keep this issue open and restore it how it was before.

@bpasero Did we make further improvements to this or why is this closed?

Did not want to close this actually, the performance is pretty much the same as before grid land:

ss

Talked with Alex and he is 👍 to close this issue given the changes I have made so far.

Yes, the layout is a lot faster for me now:


[Diagnostics] Improve missing conformance diagnostics by using affect…

…ed declaration
Instead of simply pointing out which type had conformance failures,
let's use affected declaration instead, which makes diagnostics much
richer e.g.
'List<[S], S.Id>' requires that 'S.Id' conform to 'Hashable'

versus
initializer 'init(_:id:)' requires that 'E' conform to 'Hashable' [with 'E' = 'S.Id']

Since latter message uses information about declaration, it can also
point to it in the source. That makes is much easier to understand when
problem is related to overloaded (function) declarations.

/cc @slavapestov

@swift-ci please smoke test

Sweet!

@rudkx I've updated PR to make it so sub-types diagnosed as "referenced" e.g.
referencing struct 'Decl1' on 'Conforms' requires that 'Y' conform to 'P'

or
referencing instance method 'joined()' on 'Collection' requires that 'Int' conform to 'Collection'

WDYT?

@swift-ci please smoke test

@xedin Looks great!

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - ad171e05cc1b6392100b9f39e299b1f7d3c130e1

Build failed
Swift Test OS X Platform
Git Sha - ad171e05cc1b6392100b9f39e299b1f7d3c130e1


[Post] Docviewer

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Csaba Péter seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Tag helpers and Razor expressions don't work well together on the same line

Describe the bug
Tag helpers and Razor expressions don't work well together on the same line.
Take for instance this line of code:
<button @(group.Builtin ? "disabled" : "") asp-page-handler="ShowGroupModal" type="submit">Edit</button>
In this case the asp-page-handler TagHelper has no effect.
If I swap the order, everything works, but Visual Studio does not recognize the expression syntax.

.NET Core SDK (reflecting any global.json):
 Version:   2.1.502
 Commit:    c74ce8f29f

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.17134
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.1.502\

Host (useful for support):
  Version: 2.1.6
  Commit:  3f4f8eebd8

.NET Core SDKs installed:
  2.1.403 [C:\Program Files\dotnet\sdk]
  2.1.500 [C:\Program Files\dotnet\sdk]
  2.1.502 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.1.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

Version 15.9.4
VisualStudio.15.Release/15.9.4+28307.222
Microsoft .NET Framework
Version 4.7.03056

Installed Version: Community

Application Insights Tools for Visual Studio Package   8.14.11009.1
Application Insights Tools for Visual Studio

ASP.NET and Web Tools 2017   15.9.04012.0
ASP.NET and Web Tools 2017

ASP.NET Core Razor Language Services   15.8.31590
Provides languages services for ASP.NET Core Razor.

ASP.NET Web Frameworks and Tools 2017   5.2.60913.0
For additional information, visit https://www.asp.net/

Azure App Service Tools v3.0.0   15.9.03024.0
Azure App Service Tools v3.0.0

Azure Data Lake Node   1.0
This package contains the Data Lake integration nodes for Server Explorer.

Azure Data Lake Tools for Visual Studio   2.3.3000.2
Microsoft Azure Data Lake Tools for Visual Studio

Azure Functions and Web Jobs Tools   15.9.02046.0
Azure Functions and Web Jobs Tools

Azure Stream Analytics Tools for Visual Studio   2.3.3000.2
Microsoft Azure Stream Analytics Tools for Visual Studio

C# Tools   2.10.0-beta2-63501-03+b9fb1610c87cccc8ceb74a770dba261a58e39c4a
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Common Azure Tools   1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

JavaScript Language Service   2.0
JavaScript Language Service

JavaScript Project System   2.0
JavaScript Project System

Microsoft Azure HDInsight Azure Node   2.3.3000.2
HDInsight Node under Azure Node

Microsoft Azure Hive Query Language Service   2.3.3000.2
Language service for Hive query

Microsoft Azure Stream Analytics Language Service   2.3.3000.2
Language service for Azure Stream Analytics

Microsoft Azure Stream Analytics Node   1.0
Azure Stream Analytics Node under Azure Node

Microsoft Azure Tools   2.9
Microsoft Azure Tools for Microsoft Visual Studio 2017 - v2.9.10730.2

Microsoft Continuous Delivery Tools for Visual Studio   0.4
Simplifying the configuration of Azure DevOps pipelines from within the Visual Studio IDE.

Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines

Microsoft Library Manager   1.0
Install client-side libraries easily to any web project

Microsoft MI-Based Debugger   1.0
Provides support for connecting Visual Studio to MI compatible debuggers

Microsoft Visual Studio Tools for Containers   1.1
Develop, run, validate your ASP.NET Core applications in the target environment. F5 your application directly into a container with debugging, or CTRL + F5 to edit & refresh your app without having to rebuild the container.

Node.js Tools   1.4.21001.1 Commit Hash:8dd15923800d931b153ab9e4de74e42a74eba5e6
Adds support for developing and debugging Node.js apps in Visual Studio

NuGet Package Manager   4.6.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit http://docs.nuget.org/.

ProjectServicesPackage Extension   1.0
ProjectServicesPackage Visual Studio Extension Detailed Info

ResourcePackage Extension   1.0
ResourcePackage Visual Studio Extension Detailed Info

ResourcePackage Extension   1.0
ResourcePackage Visual Studio Extension Detailed Info

SQL Server Data Tools   15.1.61810.11040
Microsoft SQL Server Data Tools

ToolWindowHostedEditor   1.0
Hosting json editor into a tool window

TypeScript Tools   15.9.20918.2001
TypeScript Tools for Microsoft Visual Studio

Visual Basic Tools   2.10.0-beta2-63501-03+b9fb1610c87cccc8ceb74a770dba261a58e39c4a
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Visual F# Tools 10.2 for F# 4.5   <IP_ADDRESS>.  Commit Hash: 6e26c5bacc8c4201e962f5bdde0a177f82f88691.
Microsoft Visual F# Tools 10.2 for F# 4.5

Visual Studio Code Debug Adapter Host Package   1.0
Interop layer for hosting Visual Studio Code debug adapters in Visual Studio

Visual Studio Tools for Containers   1.0
Visual Studio Tools for Containers

Thanks for contacting us, @CristianVladescu.
We should definitely raise an error in this case.


REPL UI tests need to set "interactive mode" option

Right now the tests initialize the REPL by passing an useIPython bool which turns into a executionMode string parameter at some point, which is passed all the way down to ActivateInteractiveWindow(VisualStudioApp app, string executionMode) which ignores it.
That means they end up using whatever mode happens to be set as default for the interpreter.
Output text comparison is also not working right when in 'interactive mode'. I think it may have worked in the past thanks to the ability to customize prompts, but that is no longer an option with the Roslyn interactive window (the test settings class has properties for them, but they are not used). It tries to compare the IPython prompts assuming that they are constant, which they aren't (index is incremented for each prompt).
We should also allow the use of Anaconda for running REPL UI tests.

I have work in progress for all of these.

Is your work to add better hooks for tests? If so, go ahead. They can and should override whatever environmental settings exist.
I don't want to programmatically expose the default mode for environments, as that's really just a user text file referencing a Python class (which has been handy for testing my work on #2722 :) ).


Automatic Pauses for Specific Symbols

The theme menu has now a section called Autopauses, where you can add a unlimited number of special strings (e.g. ".", ",","?","!").

Not well explained in the editor yet, but it actually only cares for single characters, so you can add all of these in one field if you want all of them to have the same pause duration.
A known problem right now is, that adding the "." string breakes all other commands that include a dot (like [pause=0.5] or [play=mysound.wav])

If you add more than one character unexpected stuff happens:

Unfortunately yeah. Too much time has passed. At this point it's easier to recreate it then to make this work again

okay, leaving this one for 2.0 then


feat: add s390x support to libvirt provider

https://github.com/confidential-containers/cloud-api-adaptor/issues/1248
This PR creates a domainXML based on the architecture of the target host. First it finds the architecture via the GetNodeInfo method. Then if the architecture (aka Model) is s390x we'd create the domain XML with the s390x specifics, else it returns the x86_64 version as before.

Hi @CarstenLeue !

Closing in favor of https://github.com/confidential-containers/cloud-api-adaptor/pull/1261


feat(#393): RuleTestCaseContainsMockery, NumberOfMockitoMocks

In this pull request I've introduced new rule RuleTestCaseContainsMockery  for mockery detection with Mockito
mocking framework.
@volodya-lombrozo take a look, please
closes #393

PR-Codex overview
This PR introduces a new rule to limit the number of mocks in test cases. It also adds support for JavaParser and updates dependencies.
Detailed summary

Added maxNumberOfMocks parameter in RuleCorrectTestCase and Cop classes
Updated JavaParserTestCase to include statements() method
Added maxNumberOfMocks field in RuleCorrectTestCases class
Updated ValidateMojo to support maxNumberOfMocks
Refactored Cop class to accept maxNumberOfMocks
Added MockeryTest and Mockery.java for testing mocks

The following files were skipped due to too many changes: src/test/resources/Mockery.java, src/it/exclusions/src/test/java/MockeryTest.java, src/test/resources/MockerySuppressed.java, docs/rules/mockery.md, src/test/java/com/github/lombrozo/testnames/javaparser/JavaParserTestCaseTest.java, src/main/java/com/github/lombrozo/testnames/javaparser/NumberOfMockitoMocks.java, src/test/java/com/github/lombrozo/testnames/javaparser/NumberOfMockitoMocksTest.java, src/test/java/com/github/lombrozo/testnames/rules/RuleTestCaseContainsMockeryTest.java, src/main/java/com/github/lombrozo/testnames/TestCase.java, src/main/java/com/github/lombrozo/testnames/rules/RuleTestCaseContainsMockery.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo updated, take a look, please

@volodya-lombrozo also researched the subject of detecting mockery and other similar patterns and found a few papers where researchers studied mock practices in the unit tests:

MockSniffer: Characterizing and Recommending Mocking Decisions for Unit Tests
To Mock or Not to Mock? An Empirical Study on Mocking Practices
An empirical study on the usage of mocking frameworks in Apache software foundation

At the moment I didn't found any practical tool that checks or alerts excessive mocking/stubbing.

@rultor merge

@volodya-lombrozo I also researched the subject of detecting mockery and other similar patterns and found a few papers where researchers studied mock practices in the unit tests:

MockSniffer: Characterizing and Recommending Mocking Decisions for Unit Tests
To Mock or Not to Mock? An Empirical Study on Mocking Practices
An empirical study on the usage of mocking frameworks in Apache software foundation

At the moment I didn't found any practical tool that checks or alerts excessive mocking/stubbing.

Good! Then we will be the first one.

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 6min)


chore: updated ci config and readme

Codecov Report

Merging #15 (54040b2) into master (3815030) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 54040b2 differs from pull request most recent head 875eb43. Consider uploading reports for the commit 875eb43 to get more accurate results

@@            Coverage Diff            @@
##            master       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           83        83
=========================================
  Hits            83        83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3815030...875eb43. Read the comment docs.


The problem with the description of the output in the code of Prepare for multi-head attention

Hi, sorry for bothering you. In the class PrepareForMultiHeadAttention(nn.Module), your description of the output is that the output has the shape [seq_len, batch_size, heads, d_k] or [batch_size, d_model]. But I think the output should be shaped as [seq_len, batch_size, heads, d_k] or [batch_size, heads, d_k] since x = x.view(*head_shape, self.heads, self.d_k). If my understanding is wrong, please correct me. Thank you very much!

yes you are right. will fix it. thank you

Fixed https://github.com/labmlai/annotated_deep_learning_paper_implementations/commit/3ec5fa9f3d86e33409dfb21d41ff3e2c0d1e249b


parse args in case when error

I have a stamemnt than run ok in postgresql : select * from customer m where id=case when id > max(id, :maxValue) then 1 else 2 end, max is customized defined function, but sql parser error:
`10:58:25.213 [main] ERROR com.q7link.framework.sql.utils.SqlParser - parse sql error : select * from customer m where id=case when id > max(id, :maxValue) then 1 else 2 end
java.lang.RuntimeException: net.sf.jsqlparser.JSQLParserException: Encountered unexpected token: "(" "("
at line 1, column 53.`
change arg maxValue to maxValue, it work fine.  does maxValue is keyword not as argument name? change arg maxValue to max, eg.  "select * from customer m where id=case when id > max(id, :max) then 1 else 2 end", it work without error.

also， "UR" | "RS" | "RR" | "CS" cannot as table alias, too.
it all work fine at version 1.4, now update to 4.4, many statement error occor.:(

On Mon, 2022-07-11 at 20:59 -0700, wolfjiang wrote:

"UR" | "RS" | "RR" | "CS"

Those keywords have been allowed again in 4.5-Snapshot.
Please download the latest Snapshot, there is a Maven Artifact
available.
Bets regards
Andreas

On Mon, 2022-07-11 at 20:59 -0700, wolfjiang wrote: "UR" | "RS" | "RR" | "CS"
Those keywords have been allowed again in 4.5-Snapshot. Please download the latest Snapshot, there is a Maven Artifact available. Bets regards Andreas

OK, thanks

But, The maxValue not fix

But, The maxValue not fix

Greetings!
Good catch, Function does not seem to accept JDBCNamedParameter e.g.
select fun( id, :maxValue)

Works with JSQLParser 4.6.
http://jsqlformatter.manticore-projects.com/jsqlformatter/demo.html?args=-c LTAEHcHsCcGsGcBQBlAogGVQYQCqgGICuAdgBSgCWAJgDSgD8oAlIgNyIcgQwIobZ4iZSrVAAuAA4BDaFIC2zNh0RcAZlIoAbeKHgViAYwCmoAERypADwBqUzYSOnKO4pAAuoKcU+bNkcEZUoG6QsEbE9HyYuAQk5NR0YhY2dg6KrEA


open with > web browser > missing line breaks in multi-line-strings

System information:

Operating system (distribution) and version: Windows 10
DBeaver version: <IP_ADDRESS>102141704
Additional extensions

Connection specification:

Database name and version: SQL Server 2019
Driver name: I don't know
Do you use tunnels or proxies (SSH, SOCKS, etc)?: no

Describe the problem you're observing:

line breaks are removed in the "open with  > Web browser" result
text is centered, this makes it hard to read. I would prefer left aligned or some logic depending on data type

text - left
numbers - right
but never centered

Steps to reproduce, if exist:

use a field of type varchar or nvarchar (I have only nvarchar)
enter content with line breaks
have a look in dbeaver, it looks correctly
use "open with > Web Browser"
look at the result and you miss linebreaks

Thank you for the report.

I think the missing linebreak could be fixed by adapting the used CSS and changing some white-space settings

Fixed:

verified


Update tree.html

Added features for html:

editable
drag&drop

Added some features for js:
Drag&Drop
Editable


Replaced onmouseover with hover for the featured pumpkin cards.

@christalchronicles have some conflicts with your PR. Don't forgot to fetch last updates before you merge git pull. All solved, everything is good now, good work!


"switch" type guard ignores side-effects to the variable being tested

TypeScript Version<EMAIL_ADDRESS>
Search Terms: switch, type guard, side effects
Code
let value: number = 3;

function setFour() {
    value = 4;
}

switch (value) {
    case 3:
        setFour();
        if (value === 4) // <- Error: TS2367: This condition will always return 'false'...
            console.log("Switched to 4");
}

Expected behavior:
I would expect that no typescript error should result.
Actual behavior:
error TS2367: This condition will always return 'false' since the types '3' and '4' have no overlap.
Playground Link: https://www.typescriptlang.org/play/index.html#src=let value%3A number %3D 3%3B

function setFour() {
    value %3D 4%3B
}

switch (value) {
    case 3%3A
        setFour()%3B
        if (value %3D%3D%3D 4) %2F%2F <- Error%3A TS2367%3A This condition will always return 'false'...
            console.log("Switched to 4")%3B
}

Ironically my actual use case was also in a parser and I had worked around it in the same manner... by using a function.  Thanks for quick response!


from_parquet does not work with file-like objects

For example
>>> import awkward as ak
>>> array = ak.Array([1, 2, 3])
>>> ak.to_parquet(array, "array.parquet")
>>> f = open("array.parquet", "rb")
>>> array2 = ak.from_parquet(f)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/nikolai/.local/lib/python3.9/site-packages/awkward/operations/convert.py", line 3566, in from_parquet
    single_file = pyarrow.parquet.ParquetFile(filename)
  File "/home/nikolai/.local/lib/python3.9/site-packages/pyarrow/parquet.py", line 217, in __init__
    self.reader.open(source, use_memory_map=memory_map,
  File "pyarrow/_parquet.pyx", line 947, in pyarrow._parquet.ParquetReader.open
  File "pyarrow/io.pxi", line 1473, in pyarrow.lib.get_reader
  File "pyarrow/io.pxi", line 1466, in pyarrow.lib.get_native_file
TypeError: Cannot convert bytes to pyarrow.lib.NativeFile

presumably because file-like objects are instances of Iterable, so it tries to loop over them here:
https://github.com/scikit-hep/awkward-1.0/blob/0fe77918e1fa828e539ff287153150d028decfda/src/awkward/operations/convert.py#L3616-L3617
>>> import awkward as ak
>>> ak.__version__
'1.3.0'

Actually noticed the issue when i tried to use an http file-like object from fsspec, so #886 could be related
python -m http.server

>>> import fsspec
>>> import awkward as ak
>>> of = fsspec.open("http://localhost:8000/array.parquet")
>>> f = of.open()
>>> array = ak.from_parquet(f)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/nikolai/.local/lib/python3.9/site-packages/awkward/operations/convert.py", line 3624, in from_parquet
    single_file = pyarrow.parquet.ParquetFile(filename)
  File "/home/nikolai/.local/lib/python3.9/site-packages/pyarrow/parquet.py", line 217, in __init__
    self.reader.open(source, use_memory_map=memory_map,
  File "pyarrow/_parquet.pyx", line 947, in pyarrow._parquet.ParquetReader.open
  File "pyarrow/io.pxi", line 1473, in pyarrow.lib.get_reader
  File "pyarrow/io.pxi", line 1466, in pyarrow.lib.get_native_file
TypeError: Cannot convert bytes to pyarrow.lib.NativeFile

@nikoladze you're right that the current implementation appears to be unable to handle File-like objects due to that Iterable check, which was introduced in #706.
Addressing this and #886 is going to take a little more time that I have available right now unfortunately. Is this something that you need and can't work around?

I'd like to run some tests with parquet files over http (also making use of streaming I/O, not downloading the file). For this it should be sufficient to have the file-like objects passed through correctly to pyarrow.parquet.ParquetFile.

You can try the bugfix-from-parquet-file-like branch if you want to perform some tests.

That seems to work for now. Thanks!

Then I think we should merge the PR! I'll go approve it.


How can i create audio from iPhone?

Hello @galbadrakh-p , sorry for the delay.
Let me check whether the function is available at this moment.
I am coming back tomorrow to give to you more information.
Thank you !


chore: Release python base sdk version 0.4.11

Related issues

https://linear.app/serverless/issue/SC-593/python-sdk-big-latency-overhead
https://linear.app/serverless/issue/SC-977/user-thetie-seeing-error-in-production-mode-with-python-sdk

@medikoo ready for review 🙏


Fixing a bug on packet print when packet creation failed

Description
Changes proposed in this pull request.
Test plan
Outline the test plan used to test this change before merging it.

Fixes #.

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1445",
    "commit-sha": "e79b2b1e6f898b77ff7c8940c2f05f3869278450"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "554",
    "commit-sha": "855af0f30ce441d6cfdd80a272d8fa4eb848d0ee"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1445",
    "commit-sha": "21889b250600891b0df925fde15d367df368ea96"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "554",
    "commit-sha": "855af0f30ce441d6cfdd80a272d8fa4eb848d0ee"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1445",
    "commit-sha": "21889b250600891b0df925fde15d367df368ea96"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "554",
    "commit-sha": "855af0f30ce441d6cfdd80a272d8fa4eb848d0ee"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1445",
    "commit-sha": "21889b250600891b0df925fde15d367df368ea96"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "554",
    "commit-sha": "855af0f30ce441d6cfdd80a272d8fa4eb848d0ee"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1445",
    "commit-sha": "21889b250600891b0df925fde15d367df368ea96"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "554",
    "commit-sha": "855af0f30ce441d6cfdd80a272d8fa4eb848d0ee"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1445",
    "commit-sha": "21889b250600891b0df925fde15d367df368ea96"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "554",
    "commit-sha": "855af0f30ce441d6cfdd80a272d8fa4eb848d0ee"
  }
]


swift-demangle: Also accept $s symbols without the $ prefix.

This makes it easier to copy-paste $s symbols with a double-click.
We already had this for $S, now it also works for the new mangling prefix $s.

@swift-ci smoke test and merge


Enforce DataLoader contract

Fixes #256
As mentioned in the above issue, KeyvAdapter currently provides an invalid function to DataLoader. Though the types don't indicate it, keyv.get(keys)(the plural/array overload) is capable of returning undefined in the event that the underlying Store.getMany returns undefined. When this happens, KeyvAdapter violates DataLoaders expectations (and it throws an error).
We can defend against this by handling the undefined case and returning an array of keys.length filled with undefined.

ah I see the link


feat: add examples

Add examples on how to generate prefix and suffix as options
update make file to run the said example
What type of PR is this?

[ ] Refactor
[ ] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update

Related Tickets & Documents

Related Issue #
Closes #

Added/updated tests?

[ ] Yes
[ ] No, and this is why:
[ ] I need help with writing tests

Added/updated documentation

[ ] Yes
[ ] No, and this is why:
[ ] I need help with writing documentation

Notes

Current dependencies on/for this PR:

main

PR #12

PR #13   👈

This stack of pull requests is managed by Graphite.

Merge activity

Nov 23, 1:45 PM: @rodneyosodo started a stack merge that includes this pull request via Graphite.


Crashes on Heroku

My instance seems to keep crashing randomly. I believe it is running out of memory but I am unsure why.
Do you have any recomended settings, e.g. max thread / minthreads? Have you seen any issues related to this?

It appears my Request Throughput seems to running at 30,002 and I am not sure why.

@mmorrison still haven't figured out if it's LocomotiveCMS or thew new hobby plan by Heroku. It was working on the old pricing plan perfectly but now I get the same errors.

@brandonmikeska I am running on the Standard 2x currently, with the same issues.

@did if this is true, and I believe you @mmorrison, it sounds we may have a memory leak somewhere.

@brandonmikeska is there anything I can provide you guys to help narrow down the issue?

@brandonmikeska @mmorrison how about using this new service https://www.skylight.io? They've got excellent posts on their blog (for instance: http://blog.skylight.io/hunting-for-leaks-in-ruby/).

I'll add skylight to the project. But I did start to notice something in the logs and was able to recreate it in the console by accessing the first account,  Locomotive::Account.first, not sure if it is related.
SystemStackError: stack level too deep
	from /app/vendor/bundle/ruby/2.2.0/gems/bson-3.2.4/lib/bson/string.rb:79:in `to_bson_cstring'
	from /app/vendor/bundle/ruby/2.2.0/gems/bson-3.2.4/lib/bson/string.rb:63:in `to_bson_key'
	from /app/vendor/bundle/ruby/2.2.0/gems/bson-3.2.4/lib/bson/symbol.rb:58:in `to_bson_key'
	from /app/vendor/bundle/ruby/2.2.0/gems/bson-3.2.4/lib/bson/hash.rb:45:in `block (2 levels) in to_bson'
	from /app/vendor/bundle/ruby/2.2.0/gems/bson-3.2.4/lib/bson/hash.rb:43:in `each'
	from /app/vendor/bundle/ruby/2.2.0/gems/bson-3.2.4/lib/bson/hash.rb:43:in `block in to_bson'
	from /app/vendor/bundle/ruby/2.2.0/gems/bson-3.2.4/lib/bson/encodable.rb:57:in `encode_with_placeholder_and_null'
	from /app/vendor/bundle/ruby/2.2.0/gems/bson-3.2.4/lib/bson/hash.rb:42:in `to_bson'
	from /app/vendor/bundle/ruby/2.2.0/gems/moped-2.0.7/lib/moped/protocol/message.rb:173:in `serialize_selector'
	from /app/vendor/bundle/ruby/2.2.0/gems/moped-2.0.7/lib/moped/protocol/message.rb:325:in `serialize'
	from /app/vendor/bundle/ruby/2.2.0/gems/moped-2.0.7/lib/moped/connection.rb:171:in `block in write'
	from /app/vendor/bundle/ruby/2.2.0/gems/moped-2.0.7/lib/moped/connection.rb:169:in `each'
	from /app/vendor/bundle/ruby/2.2.0/gems/moped-2.0.7/lib/moped/connection.rb:169:in `write'
	from /app/vendor/bundle/ruby/2.2.0/gems/moped-2.0.7/lib/moped/authenticatable.rb:64:in `login'
	from /app/vendor/bundle/ruby/2.2.0/gems/moped-2.0.7/lib/moped/operation/read.rb:55:in `block (2 levels) in execute'
	from /app/vendor/bundle/ruby/2.2.0/gems/moped-2.0.7/lib/moped/node.rb:118:in `block in connection'
... 9285 levels...
	from /app/vendor/bundle/ruby/2.2.0/gems/mongoid-4.0.2/lib/mongoid/query_cache.rb:190:in `first_with_cache'
	from /app/vendor/bundle/ruby/2.2.0/gems/mongoid-4.0.2/lib/mongoid/contextual/mongo.rb:199:in `block (2 levels) in first'
	from /app/vendor/bundle/ruby/2.2.0/gems/mongoid-4.0.2/lib/mongoid/contextual/mongo.rb:545:in `with_sorting'
	from /app/vendor/bundle/ruby/2.2.0/gems/mongoid-4.0.2/lib/mongoid/contextual/mongo.rb:198:in `block in first'
	from /app/vendor/bundle/ruby/2.2.0/gems/mongoid-4.0.2/lib/mongoid/contextual/mongo.rb:457:in `try_cache'
	from /app/vendor/bundle/ruby/2.2.0/gems/mongoid-4.0.2/lib/mongoid/contextual/mongo.rb:197:in `first'
	from /app/vendor/bundle/ruby/2.2.0/gems/mongoid-4.0.2/lib/mongoid/contextual.rb:20:in `first'
	from /app/vendor/bundle/ruby/2.2.0/gems/mongoid-4.0.2/lib/mongoid/findable.rb:144:in `first'
	from (irb):11
	from /app/vendor/bundle/ruby/2.2.0/gems/railties-4.2.4/lib/rails/commands/console.rb:110:in `start'
	from /app/vendor/bundle/ruby/2.2.0/gems/railties-4.2.4/lib/rails/commands/console.rb:9:in `start'
	from /app/vendor/bundle/ruby/2.2.0/gems/railties-4.2.4/lib/rails/commands/commands_tasks.rb:68:in `console'
	from /app/vendor/bundle/ruby/2.2.0/gems/railties-4.2.4/lib/rails/commands/commands_tasks.rb:39:in `run_command!'
	from /app/vendor/bundle/ruby/2.2.0/gems/railties-4.2.4/lib/rails/commands.rb:17:in `<top (required)>'
	from bin/rails:4:in `require'

we're not alone: http://stackoverflow.com/questions/32951455/mongoid-infinite-loop-on-query

Hello, I have this same error (running on Dokku).
If  access the Rails console and do:
Locomotive::Site.first
[...]
fields=nil runtime: 963.1169ms
  MOPED: <IP_ADDRESS>:27017 QUERY        database=loco collection=locomotive_sites selector={"$query"=>{}, "$orderby"=>{:_id=>1}} flags=[] limit=-1 skip=0 batch_size=nil fields=nil runtime: 965.1053ms
  MOPED: <IP_ADDRESS>:27017 QUERY        database=loco collection=locomotive_sites selector={"$query"=>{}, "$orderby"=>{:_id=>1}} flags=[] limit=-1 skip=0 batch_size=nil fields=nil runtime: 967.5288ms
  MOPED: <IP_ADDRESS>:27017 QUERY        database=loco collection=locomotive_sites selector={"$query"=>{}, "$orderby"=>{:_id=>1}} flags=[] limit=-1 skip=0 batch_size=nil fields=nil runtime: 969.5954ms
  MOPED: <IP_ADDRESS>:27017 QUERY        database=loco collection=locomotive_sites selector={"$query"=>{}, "$orderby"=>{:_id=>1}} flags=[] limit=-1 skip=0 batch_size=nil fields=nil runtime: 971.8912ms
  MOPED: <IP_ADDRESS>:27017 QUERY        database=loco collection=locomotive_sites selector={"$query"=>{}, "$orderby"=>{:_id=>1}} flags=[] limit=-1 skip=0 batch_size=nil fields=nil runtime: 974.1280ms
  MOPED: <IP_ADDRESS>:27017 QUERY        database=loco collection=locomotive_sites selector={"$query"=>{}, "$orderby"=>{:_id=>1}} flags=[] limit=-1 skip=0 batch_size=nil fields=nil runtime: 976.9187ms
  MOPED: <IP_ADDRESS>:27017 QUERY        database=loco collection=locomotive_sites selector={"$query"=>{}, "$orderby"=>{:_id=>1}} flags=[] limit=-1 skip=0 batch_size=nil fields=nil runtime: 980.5714ms
  MOPED: <IP_ADDRESS>:27017 QUERY        database=loco collection=locomotive_sites selector={"$query"=>{}, "$orderby"=>{:_id=>1}} flags=[] limit=-1 skip=0 batch_size=nil fields=nil runtime: 997.7921ms
SystemStackError: stack level too deep
        from /app/vendor/bundle/ruby/2.2.0/gems/bson-3.2.1/lib/bson/string.rb:79:in `to_bson_cstring'
        from /app/vendor/bundle/ruby/2.2.0/gems/bson-3.2.1/lib/bson/string.rb:63:in `to_bson_key'
        from /app/vendor/bundle/ruby/2.2.0/gems/bson-3.2.1/lib/bson/symbol.rb:58:in `to_bson_key'
        from /app/vendor/bundle/ruby/2.2.0/gems/bson-3.2.1/lib/bson/hash.rb:45:in `block (2 levels) in to_bson'
        from /app/vendor/bundle/ruby/2.2.0/gems/bson-3.2.1/lib/bson/hash.rb:43:in `each'
        from /app/vendor/bundle/ruby/2.2.0/gems/bson-3.2.1/lib/bson/hash.rb:43:in `block in to_bson'
        from /app/vendor/bundle/ruby/2.2.0/gems/bson-3.2.1/lib/bson/encodable.rb:57:in `encode_with_placeholder_and_null'
        from /app/vendor/bundle/ruby/2.2.0/gems/bson-3.2.1/lib/bson/hash.rb:42:in `to_bson'
        from /app/vendor/bundle/ruby/2.2.0/gems/moped-2.0.7/lib/moped/protocol/message.rb:173:in `serialize_selector'
        from /app/vendor/bundle/ruby/2.2.0/gems/moped-2.0.7/lib/moped/protocol/message.rb:325:in `serialize'
        from /app/vendor/bundle/ruby/2.2.0/gems/moped-2.0.7/lib/moped/connection.rb:171:in `block in write'
        from /app/vendor/bundle/ruby/2.2.0/gems/moped-2.0.7/lib/moped/connection.rb:169:in `each'
        from /app/vendor/bundle/ruby/2.2.0/gems/moped-2.0.7/lib/moped/connection.rb:169:in `write'
        from /app/vendor/bundle/ruby/2.2.0/gems/moped-2.0.7/lib/moped/authenticatable.rb:64:in `login'
        from /app/vendor/bundle/ruby/2.2.0/gems/moped-2.0.7/lib/moped/operation/read.rb:55:in `block (2 levels) in execute'
        from /app/vendor/bundle/ruby/2.2.0/gems/moped-2.0.7/lib/moped/node.rb:118:in `block in connection'
... 9285 levels...
        from /app/vendor/bundle/ruby/2.2.0/gems/mongoid-4.0.2/lib/mongoid/query_cache.rb:190:in `first_with_cache'
        from /app/vendor/bundle/ruby/2.2.0/gems/mongoid-4.0.2/lib/mongoid/contextual/mongo.rb:199:in `block (2 levels) in first'
        from /app/vendor/bundle/ruby/2.2.0/gems/mongoid-4.0.2/lib/mongoid/contextual/mongo.rb:545:in `with_sorting'
        from /app/vendor/bundle/ruby/2.2.0/gems/mongoid-4.0.2/lib/mongoid/contextual/mongo.rb:198:in `block in first'
        from /app/vendor/bundle/ruby/2.2.0/gems/mongoid-4.0.2/lib/mongoid/contextual/mongo.rb:457:in `try_cache'
        from /app/vendor/bundle/ruby/2.2.0/gems/mongoid-4.0.2/lib/mongoid/contextual/mongo.rb:197:in `first'
        from /app/vendor/bundle/ruby/2.2.0/gems/mongoid-4.0.2/lib/mongoid/contextual.rb:20:in `first'
        from /app/vendor/bundle/ruby/2.2.0/gems/mongoid-4.0.2/lib/mongoid/findable.rb:144:in `first'
        from (irb):4
        from /app/vendor/bundle/ruby/2.2.0/gems/railties-4.2.4/lib/rails/commands/console.rb:110:in `start'
        from /app/vendor/bundle/ruby/2.2.0/gems/railties-4.2.4/lib/rails/commands/console.rb:9:in `start'
        from /app/vendor/bundle/ruby/2.2.0/gems/railties-4.2.4/lib/rails/commands/commands_tasks.rb:68:in `console'
        from /app/vendor/bundle/ruby/2.2.0/gems/railties-4.2.4/lib/rails/commands/commands_tasks.rb:39:in `run_command!'
        from /app/vendor/bundle/ruby/2.2.0/gems/railties-4.2.4/lib/rails/commands.rb:17:in `<top (required)>'
        from bin/rails:4:in `require'
        from bin/rails:4:in `<main>'irb(main):005:0>

In fact in my case I can simply never connect to the interface as it always break into that loop.

I was able to switch over and use Compose MongoDB to get it too work. The stackoverflow article referenced MongoLab using sharded databases on the free plan. I looked into updating the mongo config, as suggested on stackoverflow, but was only able to find a way to change it in Mongo 5.0.
I hope this helps narrow down what the issue could be. I plan to monitor the app and will report back if I see the issue appear with the new Mongo provider.

note that in my case have the issue on Dokku, not on Heroku, this is using Mongo from https://github.com/dokku/dokku-mongo that is it's using the regular Mongo server 3.0.6 from here https://hub.docker.com/_/mongo/
For some reason I cannot easily make local tests outside this stack these days.
@mmorrison when you mentioned Mongo 5.0, you were talking about mongoid 5 ?

@rvalyi Yes sorry I was talking about Mongoid 5.

@mmorrison any chance you can share your Gemfile / Gemfle.lock ?  would like to test locomotive v3. I tried to just change the mongoid ref to mongoid 5.0.0n my Gemfile.lock but it doesn't seem as simple as I got this startup error then:
2015-10-09T02:21:35.033633036Z loco[web.1]: [13] Puma starting in cluster mode...
2015-10-09T02:21:35.033869468Z loco[web.1]: [13] * Version 2.13.4 (ruby 2.2.2-p95), codename: A Midsummer Code's Dream
2015-10-09T02:21:35.033983219Z loco[web.1]: [13] * Min threads: 5, max threads: 5
2015-10-09T02:21:35.034066833Z loco[web.1]: [13] * Environment: production
2015-10-09T02:21:35.034153963Z loco[web.1]: [13] * Process workers: 2
2015-10-09T02:21:35.034385462Z loco[web.1]: [13] * Preloading application
2015-10-09T02:21:37.945361518Z loco[web.1]: [13] ! Unable to load application: LoadError: cannot load such file -- bson
2015-10-09T02:21:37.945622485Z loco[web.1]: /app/vendor/bundle/ruby/2.2.0/bundler/gems/engine-45ac1129da05/lib/locomotive/dependencies.rb:1:in `require': cannot load such file -- bson (LoadError)
2015-10-09T02:21:37.945692608Z loco[web.1]:     from /app/vendor/bundle/ruby/2.2.0/bundler/gems/engine-45ac1129da05/lib/locomotive/dependencies.rb:1:in `<top (required)>'
2015-10-09T02:21:37.945729816Z loco[web.1]:     from /app/vendor/bundle/ruby/2.2.0/bundler/gems/engine-45ac1129da05/lib/locomotive/engine.rb:1:in `require'
[...]

working on it (https://trello.com/c/achbxT8J/83-mongoid-upgrade-to-mongoid-5-0)

Hello thanks @did. BTW I'll answer your email just been terribly busy these days and yes upgrading our website before signing new contracts (we have the wagon repo) is part of the rush... But kudos for the terrific work as usual.

@rvalyi Yea here is my Gemfile.lock, https://gist.github.com/mmorrison/c1489e4201fa6921843b.

@rvalyi @did I really appreciate your help!

@rvalyi thanks! (talk to you soon!)

I keep updated my work on that here: https://trello.com/c/achbxT8J/83-mongoid-upgrade-to-mongoid-5-0

Bummer, back to mongoid 4 :-( Check this out https://jira.mongodb.org/browse/MONGOID-4159.
This issue is so big that we can't upgrade to mongoid 5.
So, the initial issue is about MongoLab databases being sharded and Mongoid 4.0 seems unable to query collections without sharded keys. Let me ask people from MongoLab.

Email sent to the Mongolab team.

@did too bad for mongoid 5.
But notice that in my case I have the issue on Dokku with the regular Mongo server (in a Docker though), it's not Heroku and it's easy to reproduce. If that's really a problem for you to reproduce the issue, I can put an SSH key on that server and let you push and open a Rails console debug if that would help.
But really it's just the regular Dokku install with the official Mongo plugin and a push of this repo:
https://github.com/akretion/heroku-instant-deploy

MongoLab's answer:
This Sandbox database is now running MongoDB 3.0.x, which includes changes to MongoDB's authentication mechanism. This new mechanism is supported by certain newer driver versions
...
For your specific case of Ruby driver, Mongoid 4 doesn't support MongoDB 3.0. In this case if you still want to use the free sandbox database you would have to upgrade to Mongoid 5.

If using a 3.0-compatible driver(like Mongoid 5) is not an option, you may want to consider upgrading to a Shared or Dedicated plan (https://mongolab.com/plans/pricing/), which will provide MongoDB 2.6 as an option.

**Bottom line, Locomotive v3 only works with MongoDB 2.6. **

hum, my test ok Dokku was with MongoDB server 3.0.6, not 2.6, so it may explain why had the issue too.
@did now https://jira.mongodb.org/browse/MONGOID-4159 seems to have been reported recently and also it's classified as Blocker - P1, so eventually the mongoid team get it fixed soon enough. Sounds possible?

@rvalyi so I'm watching the issue, see how fast they'll fix it.

UPDATE MONGOID JIRA  Ruby Sprint 27 ends 26/Oct/15

I have also seen that it's one of the only 2 major mongoid bug. So that would be very unlikely they don't fix it...

Yeah i'm pretty sure MongoLab did this to get a bunch of people off their free plans knowing full well that the ruby community isn't quite MongoDB 3.0 ready yet.

from the Mongoid bug tracker, the fix entered in code review:
https://github.com/mongodb/mongoid/pull/4179

@did fixed and released on Monglab side https://github.com/mongodb/mongoid/commits/master
https://jira.mongodb.org/browse/MONGOID-4159
How do we stand on LocomotiveCMS regarding mongoid 5?

The deploy button works again!


Simplify Hue for new users

Sample config auto-discoveres Bridge IP
Username left blank so that the server will prompt you
Hue platform walks you through username creation (in as friendly a
way currently possible)

/cc @stephenyeargin, #28

:+1: I think you just cleared it off @madmod's todo list :smile:

:+1: Looks good. I can't try it out right now, but I will test it in a few hours. I think if we could add some ability for saving to the config.json we wouldn't need to stop running if this fails.

Yes agreed it would be great to have either a method for updating config.json (which I'm not super into, it feels wrong to fiddle with "your" config) or a method for accessory storage of preference data. Or an official method of "first time setup" for accessories. Lots to think about...

👎 on writing to the config
👍 to some sort of local storage (if more than 2 or 3 cases can be come up with)
👍 to not even thinking about it on this pull 😄

Ps: this pull is cool. Love it.

Thanks but it's just icing on the cake - thanks to @stephenyeargin and @madmod for doing all the real work supporting Hue! This was the last thing in my home that wasn't hooked up to HomeKit :smile_cat:


Issue#413

Since there are no cases where we want the ws client to continue when one of its linked processes dies, it need not trap exits. If the ws client does not trap exits, it will not receive the 'EXIT' messages.
Looks good to Merge. :+1:


Firewall Logs Widget - repeats the same log entries multiple times

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues and I am convinced that mine is new.

Describe the bug
The "Firewall Logs" Widget shows entries multiple times if there are only a few entries in the log file.
If e.g. the filter.log is containing only two entries and you are opening the dashboard page, initially there are only two entries shown. But every second these two entries are added again and again until the maximum of entries in the widget is reached.
Not sure with which version this behavior started. Noticed it with version OPNsense 20.7.8-amd64 for the first time.
To Reproduce
Steps to reproduce the behavior:

Make sure you have a small number of entries in the firewall log (e.g. 1 or 2)
Click on Dashboard
Make sure you have the Firewall Logs Widget installed
Check that every second (probably with every update of the content of the list), the entries in the list get added to the entries already shown in the widget until the maximum of entries to be shown is reached

Expected behavior
Only the last n entries should be listed in the widget. Every item should be shown at most once.
Describe alternatives you considered
Delete Firewall Logs Widget and re-adding it did not help.
Screenshots
The firewall log with one entry:

Firewall Logs Widget after 5 seconds on the Dashboard:

Relevant log files
filter.log
Additional context
Firewall has been in use for several years. Followed nearly every update.
Environment
OPNsense 20.7.8-amd64
FreeBSD 12.1-RELEASE-p12-HBSD
OpenSSL 1.1.1i 8 Dec 2020
AMD GX-412TC SOC (4 cores) (APU2E4)
Network Intel® I210-AT

Addendum: After the update to 21.1 (which went smooth!), the error in the Widget also shows up (at least in my context).
Current system after the update (also affected):
OPNsense 21.1-amd64
FreeBSD 12.1-RELEASE-p12-HBSD

Addendum: After the update to 21.1 (which went smooth!), the error in the Widget also shows up (at least in my context).
Current system after the update (also affected):
OPNsense 21.1-amd64
FreeBSD 12.1-RELEASE-p12-HBSD

Sali @thowe-switzerland,
Can you try this patch to confirm?
# opnsense-patch 5bfd6b66

Fixed also the maximum display being off by one and save button position.
Cheers,
Franco

Sälüt Franco :-)
Thanks for the quick patch. There still seems to be a problem: Now the one entry in the log file is first shown once, a second later twice. What changed is, that it does no longer "fill up" to the maximum.
After patching but before restart, the following error was  shown in GUI:
[01-Feb-2021 11:11:13 Europe/Zurich] PHP Warning:  in_array() expects parameter 2 to be array, string given in /usr/local/www/firewall_rules_edit.php on line 1222
What I have done:

applied the patch
Forced reload of GUI in the browser --> one entry shown twice + error message
restart firewall
Reload GUI in the browser --> one entry shown twice + no error message

PHP warning is from firewall categories rework, patches are 25573505db and 1ed095bc878
Can you confirm that the entry is duplicated?
# clog /var/log/filter.log

Looks good on my end: 11 entries in log and dashboard with limit set higher or equal to entry count ... no flapping of entries and truncating to e.g. 5 now also works correctly, but you never know with these JS things... :)

Strange. But yes. IT is not always deterministic... ;-)
I am sorry to say, that my situation is as follows (Note: in the meantime I am on 21.1):

Odd, which parameters do you use in the widget?

These are the parameters of my widget:

No other reports so I think unless need data points are added we can't do more.


Feature/system testing

PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?
Added a test suite

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
A new test suite
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

Changes Unknown when pulling 14563b97de3fe755cfbc1a7e426dcbb2f29d024a on feature/system-testing into ** on master**.


bump munit-scalacheck

I don't know why steward didn't open a PR for this bump? It just says scalacheck-effect is up-to-date.
Anyway, proposing that we bump to 1.0 now that it's released (🎉). Could we then release a full v2.0.0 of scalacheck-effect (assuming tests pass okay), or is there other work to do first?

Ohhhhhhh is native the hold up? Okay n/m


deanonimize set request goroutine

rationale as in #38
A few modifications have been made:

added logging message with SetRequest body to be inline with other RPCs.
substitute the textproto format from using protobuf encoder to proto.MarshalTextString

What I am a bit concerned about is

if it is needed to print the SetRequest as it is now in the YAML format
2020/06/10 20:54:21.616734 sending gNMI SetRequest: 'prefix:{}  update:{path:{elem:{name:"configure"}  elem:{name:"system"}  elem:{name:"name"}}  val:{json_val:"\"R1_20.5.r1_new\""}}' to 2.tcp.eu.ngrok.io:18772
Request:
prefix:
    update:
    path : configure/system/name
    value: json_val:"\"R1_20.5.r1_new\""

Maybe the log message is enough? It may not be enough when the more elaborated set is in use...

If it is needed, maybe we should change to JSON styled response to be inline with Get and Subscribe? Currently the output is in YAML format as well

@karimra I have added the printSetRequest in a JSON format as well in
f7c5127
here is the output:
❯ go run . --insecure set --update /configure/system/name:::json:::R1_20.5.r1_new --print-request

Set Request:
{
  "update": [
    {
      "path": "configure/system/name",
      "val": "json_val:\"\\\"R1_20.5.r1_new\\\"\""
    }
  ]
}
2020/06/12 13:15:45.984457 sending gNMI SetRequest: prefix='', delete='[]', replace='[]', update='[path:{elem:{name:"configure"}  elem:{name:"system"}  elem:{name:"name"}}  val:{json_val:"\"R1_20.5.r1_new\""}]', extension='[]' to 2.tcp.eu.ngrok.io:12753
{
  "source": "2.tcp.eu.ngrok.io:12753",
  "timestamp":<PHONE_NUMBER>767758642,
  "time": "2020-06-12T13:16:29.767758642+02:00",
  "results": [
    {
      "operation": "UPDATE",
      "path": "configure/system/name"
    }
  ]
}

lgtm


Is there any criterion for choosing alpha?

I wish to adopt IB loss to YOLOX for object detection....
However after several epoch finetuing the mAP drop from 80% to 30%.
I choose 1000 for alpha. When calculating the grad, I use the channel values of every pixel point on the input feature map of the classfier pred as "feature vector".

understood! thank you for response.


fix: update Jaeger dashboard to use Time Series panel in Grafana

Which problem is this PR solving?
Resolves #5833
Description of the changes
This PR updates the Jaeger dashboard JSON to replace the deprecated Grafana old Angular plugin with the Time Series panel. This change ensures compatibility with newer versions of Grafana.
How was this change tested?
The updated dashboard has been tested with Grafana version 11 to confirm proper rendering and functionality.
Checklist

[x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
[x] I have signed all commits
[ ] I have added unit tests for the new functionality
[ ] I have run lint and test steps successfully

for jaeger: make lint test
for jaeger-ui: yarn lint and yarn test

@mahadzaryab1 can you try this out? I wonder if we broke any of the metrics from RPC servers by switching to OTEL helpers

run the example per monitoring/jaeger-mixin/README.md


vcert: upgrade to v4.23.0 to fix certificate renewal stuck on TPP errors ("Click Retry" and "WebSDK CertRequest")

cert-manager was not able to retry some failed TPP certificates due to the fact that TPP does not automatically restarts the enrollment from 0 when the certificate already has a failed enrollment status from a previous enrollment.
More specifically, cert-manager was getting stuck on either:
WebSDK CertRequest Module Requested Certificate

or
This certificate cannot be processed while it is in an error state.
Fix any errors, and then click Retry.

With vcert v4.23.0, a call to "reset" is made when one of these two messages are found while polling for the certificate (i.e., while calling vcert's RetrieveCertificate function).
A bug that was preventing the Venafi issuer from renewing certificates when using TPP has been fixed. You should no longer see your certificates getting stuck with "WebSDK CertRequest Module Requested Certificate" or "This certificate cannot be processed while it is in an error state. Fix any errors, and then click Retry.".

/kind bug
/area venafi
/milestone v1.11
Fixes #5274

@maelvls I think you forgot make update-licenses

Thank you Tim. I tried running that multiple times, but I get stuck with the following:
$ make update-licenses
...
E0102 16:54:30.728855 2190371 library.go:110] Package image does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
E0102 16:54:30.728870 2190371 library.go:110] Package image/jpeg does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
W0102 16:54:31.181936 2190371 library.go:94] "github.com/klauspost/compress/zstd/internal/xxhash" contains non-Go code that can't be inspected for further dependencies:
<EMAIL_ADDRESS>E0102 16:54:40.961848 2190371 library.go:110] Package net/http/httptest does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
F0102 16:54:42.257647 2190371 main.go:75] some errors occurred when loading direct and transitive dependency packages

/approve
/lgtm

/test pull-cert-manager-master-e2e-v1-26

@maelvls Yes, we should add a comment explaining that this now works.


Snake can eat itself by turning around too quickly

To reproduce:
Make Snake head right.
As quickly as you can press down then left. If you are fast enough, it will produce a game over.

Fixed 6c209a692ec29e1f5370f0f643ed79f83fa6fb8b


Expression Export

This PR adds a front end component to the recent translate API endpoint in Herbie.
In Odyssey, there is an additional tab in the expression table for Expression Export. In this tab, there are 9 supported languages that the user expression can be translated into: python, c, fortran, java, julia, matlab, wls, tex, and js.
Expression translated into python:

Dropdown with language options:

Wonderful PR description here @benwang33 and a clean merge, thank you!

Note this will probably fail on versions of Herbie that don't have the translate endpoint set up, and there will be some kind of error. We should know what that error will look like and probably catch it and instruct the user to update Herbie if needed. I would go ahead and test this to confirm that we see an error.

This points at a major consideration for our one-click installation setup--version management. We'll need to figure out something basic for this.