URL correction request

Request type

[x] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details

The url of this page is not correct.
https://developer.mozilla.org/zh-CN/docs/Web/JavaScript/Reference/Operators/async允许声明一个函数为一个包含异步操作的函数
It should be like this one. This url will redirect to the above url. werid...
https://developer.mozilla.org/zh-CN/docs/Web/JavaScript/Reference/Operators/async_function

Hrm, this is strange indeed.
I can't fix the redirect either. When I go to https://developer.mozilla.org/zh-CN/docs/Web/JavaScript/Reference/Operators/async_function$edit, it gives me a 404 error.
Any thoughts @peterbe or @escattone ?

That is strange indeed. I appreciate why you'd get a 404 when trying to edit because the locale/slug combo does not exist:
>>> Document.all_objects.filter(locale='zh-CN', slug__istartswith='Web/JavaScript/Reference/Operators/async_')
<QuerySet []>

(note the use of .all_objects so it doesn't matter if it's deleted or not)
Now, that's no different from if it was /zh-CN/docs/gc70169ed627h521a98g1e9e5fb60d.
So, how on earth does this redirect?!
▶ curl -v https://developer.mozilla.org/zh-CN/docs/Web/JavaScript/Reference/Operators/async_function > /dev/null
...
> GET /zh-CN/docs/Web/JavaScript/Reference/Operators/async_function HTTP/2
> Host: developer.mozilla.org
> User-Agent: curl/7.64.1
> Accept: */*
>
* Connection state changed (MAX_CONCURRENT_STREAMS == 128)!
< HTTP/2 302
< content-type: text/html; charset=utf-8
< content-length: 0
< access-control-allow-origin: *
< cache-control: public, max-age=0, s-maxage=300
< content-language: zh-CN
< date: Wed, 06 May 2020 18:00:32 GMT
< etag: "d41d8cd98f00b204e9800998ecf8427e"
< location: /zh-CN/docs/Web/JavaScript/Reference/Operators/async%E5%85%81%E8%AE%B8%E5%A3%B0%E6%98%8E%E4%B8%80%E4%B8%AA%E5%87%BD%E6%95%B0%E4%B8%BA%E4%B8%80%E4%B8%AA%E5%8C%85%E5%90%AB%E5%BC%82%E6%AD%A5%E6%93%8D%E4%BD%9C%E7%9A%84%E5%87%BD%E6%95%B0
< server: meinheld/1.0.1
< strict-transport-security: max-age=63072000
< x-content-type-options: nosniff
< x-frame-options: DENY
< x-xss-protection: 1; mode=block
< vary: Cookie
< x-cache: Hit from cloudfront
< via: 1.1 f4710a63efd91d46133023148eb02e4e.cloudfront.net (CloudFront)
< x-amz-cf-pop: ATL56-C2
< x-amz-cf-id: QYGvEtny75feogHYKwvCWayucVeE9XgfLEIalu6QwmVkEm9FdCWhrg==
< age: 22
<
{ [0 bytes data]
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
* Connection #0 to host developer.mozilla.org left intact
* Closing connection 0

Same with HEAD requests by the way:
▶ curl -I https://developer.mozilla.org/zh-CN/docs/Web/JavaScript/Reference/Operators/async_function
HTTP/2 302
content-type: text/html; charset=utf-8
content-length: 0
access-control-allow-origin: *
cache-control: public, max-age=0, s-maxage=300
content-language: zh-CN
date: Wed, 06 May 2020 18:00:32 GMT
etag: "d41d8cd98f00b204e9800998ecf8427e"
location: /zh-CN/docs/Web/JavaScript/Reference/Operators/async%E5%85%81%E8%AE%B8%E5%A3%B0%E6%98%8E%E4%B8%80%E4%B8%AA%E5%87%BD%E6%95%B0%E4%B8%BA%E4%B8%80%E4%B8%AA%E5%8C%85%E5%90%AB%E5%BC%82%E6%AD%A5%E6%93%8D%E4%BD%9C%E7%9A%84%E5%87%BD%E6%95%B0
server: meinheld/1.0.1
strict-transport-security: max-age=63072000
x-content-type-options: nosniff
x-frame-options: DENY
x-xss-protection: 1; mode=block
vary: Cookie
x-cache: Hit from cloudfront
via: 1.1 2d26ba7e90592f6aaf3e7940a7088a63.cloudfront.net (CloudFront)
x-amz-cf-pop: ATL56-C2
x-amz-cf-id: z_ljFBiMzsWNlUKa05Ccbl2U4WNQe68PwP5b0ZsJJk5RROh8BDa-ZA==
age: 113

It's not like it's deleted or something like that:
>>> DocumentDeletionLog.objects.filter(locale='zh-CN', slug__istartswith='Web/JavaScript/Reference/Operators/async_function')
<QuerySet []>

Perhaps @escattone has a better theory of how that could happen. If it was something getting stuck in the CDN it just seems so strange because it's been way too long now for the CDN to hang on to it.
Also, I have a pretty fresh copy of the MySQL and I'm seeing this:
mysql> SELECT `wiki_document`.`id`, slug FROM `wiki_document` WHERE (`wiki_document`.`locale` = 'zh-CN' AND `wiki_document`.`slug` LIKE 'Web/JavaScript/Reference/Operators/a%');
+--------+------------------------------------------------------------------------------------------------------+
| id     | slug                                                                                |
+--------+------------------------------------------------------------------------------------------------------+
| 132551 | Web/JavaScript/Reference/Operators/Arithmetic_Operators                                              |
| 111857 | Web/JavaScript/Reference/Operators/Array_comprehensions                                              |
| 125951 | Web/JavaScript/Reference/Operators/Assignment_Operators                                              |
| 199130 | Web/JavaScript/Reference/Operators/async允许声明一个函数为一个包含异步操作的函数                     |
| 199606 | Web/JavaScript/Reference/Operators/await                                                             |
+--------+------------------------------------------------------------------------------------------------------+
5 rows in set (0.00 sec)

WHAT?! Not 20 min later I run it again (I copied the curl from above):
▶ curl -I https://developer.mozilla.org/zh-CN/docs/Web/JavaScript/Reference/Operators/async_function
HTTP/2 404
content-type: text/html; charset=utf-8
content-length: 29831
cache-control: max-age=0, no-cache, no-store, must-revalidate
content-language: zh-CN
date: Wed, 06 May 2020 18:28:38 GMT
expires: Wed, 06 May 2020 18:28:38 GMT
server: meinheld/1.0.1
strict-transport-security: max-age=63072000
x-content-type-options: nosniff
x-frame-options: DENY
x-xss-protection: 1; mode=block
vary: Accept-Encoding,Cookie
x-cache: Error from cloudfront
via: 1.1 fd09c5c8b7a01c40409708bf025b9228.cloudfront.net (CloudFront)
x-amz-cf-pop: ATL56-C2
x-amz-cf-id: 1Rl5dU-uOTfwlj59FuxV3O6sVBA4vnKFp1LfHGLnVVHux5X0up6cpg==

Cloudfront much?


Test styles

This PR attempts to fix flexbox and styling of main page to accurately represent our design. This does not have to be merged as I know we will be fixing the layout, but let me know what you think.
Blogs now sit in columns of 2 and expand to 100% when screen is downsized. Also adjusted the margin for mobile view so the last blog is not cut off.
Before:
https://user-images.githubusercontent.com/101610922/190837846-aab1f39e-4af4-4497-879c-940e9eec9981.mov
After:
https://user-images.githubusercontent.com/101610922/190837856-07200dd2-6099-4ecb-9000-7733c4a6ebd2.mov

Closing #83


why not use "strconv.ParseInt(value, 10, 64)" but "strconv.ParseInt(value, 10, 32)"

Hello,
In cpuinfo.go#L100 , I find that type of processor.Id is int64,  but the right value from strconv.ParseInt(value, 10, 32) is int32, so I wonder why not use strconv.ParseInt(value, 10, 64) instead ? Because it seams more reasonable to me.
tks in advance.
code location:https://github.com/c9s/goprocinfo/blob/master/linux/cpuinfo.go#L100

@moooofly Sounds reasonable. Please send a pull request to fix it up!


Ppower easy money

CODE REVIEW
Overall, this is an excellent PR. Power is a much needed feature that was on the issues list, so good work getting it done in time for the final demonstration.
The Good

The principles of Clean Architecture are adhered to quite well. For the powerrefund use case, I can see that all the relevant classes and interfaces have been created, and the use case moves through them in the correct order. Nice work!
Excellent job segregating the OpenWeatherAccessInterface into one which handles current weather only and another that handles forecast weather. Shows a deep understanding of SOLID principles.

The Bad

Some Javadocs are present, but commenting can be improved overall. Although much of the code is boilerplate, it still requires comments in order to be readable for those who did not write it

General Notes

Your code has significantly improved in quality over the course of the project. Good job.


Enhance the dumpEntities command

In CoreCommands there is a simple dumpEntities command that'll write all entities in the world to a debug file. That's great! But you don't always need all the entities, but something more specific.
The objective of this Good First Issue is to make a variant of that command that takes a parameter (or a ... list of parameters) for a specific Component to filter by then only write out those entities instead.
Easiest would just be to take a single Component, I'm not sure if it would be more useful to allow passing multiple components that you'd then want either all entities with any component match or only the entities that have all the listed components.
See entityManager.getEntitiesWith examples to see how to retrieve entities with a specific set of Components.

Is this still up for grabs?

Remember that github has the ability to assign an issue to someone who's commented on the issue even when they are not a contributor now @Cervator.  :-)

This issue can be closed


[BUG - Release] BPModLoaderMod, PreBeginPlay can execute after PostBeginPlay

Branch or Release
All with BPModLoaderMod support
Game and Engine Version
All, maybe ? Untested
Describe the bug
PostBeginPlay will at least occasionally execute before PreBeginPlay.
I haven't confirmed the reason for this but I suspect it's because there's a slight delay in our execution of PreBeginPlay becuase we need to locate it and confirm that it exists before we execute it, while UE can execute the regular BeginPlay (which PostBeginPlay uses to know when to execute) immediately after the actor is spawned into the world.
This could possibly be fixed by moving the execution of PreBeginPlay to a RegisterBeginPlayPreHook callback.
Mods directory
N/A
To Reproduce
Expected behavior
PreBeginPlay should always fire before PostBeginPlay, otherwise mods using PreBeginPlay will get inconsistent behavior.
Screenshots and UE4SS Log
Desktop (please complete the following information):
Additional context

BTW, it also seems to execute PostBeginPlay as many times as there's logic mods installed (#433). I've posted possible fix for this that issue.


Memoize Badge#to_s to reduce memory allocations

Profiled with memory_profiler.
$ bin/rubocop-profile lib/rubocop/cop/style

Before
Total allocated: 682975704 bytes (8263326 objects)
Total retained:  6103832 bytes (39018 objects)
....
allocated memory by file
-----------------------------------
  62890239  /Users/fatkodima/.rbenv/versions/2.6.5/lib/ruby/2.6.0/set.rb
  43983225  /Users/fatkodima/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/parser-<IP_ADDRESS>/lib/parser/source/tree_rewriter.rb
  43851800  /Users/fatkodima/Desktop/oss/rubocop/lib/rubocop/cop/base.rb
  43461557  /Users/fatkodima/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rubocop-ast-0.1.0/lib/rubocop/ast/node.rb
  39761197  /Users/fatkodima/Desktop/oss/rubocop/lib/rubocop/cop/style/commented_keyword.rb
  28841125  /Users/fatkodima/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rubocop-ast-0.1.0/lib/rubocop/ast/node_pattern.rb
  26456590  /Users/fatkodima/Desktop/oss/rubocop/lib/rubocop/cop/badge.rb     <==========
  23182282  /Users/fatkodima/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/parser-<IP_ADDRESS>/lib/parser/source/buffer.rb
  22439585  /Users/fatkodima/Desktop/oss/rubocop/lib/rubocop/cop/util.rb
......

After
Total allocated: 657230941 bytes (7767964 objects)
Total retained:  6102216 bytes (38992 objects)
......
allocated memory by file
-----------------------------------
  62890239  /Users/fatkodima/.rbenv/versions/2.6.5/lib/ruby/2.6.0/set.rb
  43983225  /Users/fatkodima/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/parser-<IP_ADDRESS>/lib/parser/source/tree_rewriter.rb
  43851800  /Users/fatkodima/Desktop/oss/rubocop/lib/rubocop/cop/base.rb
  43461557  /Users/fatkodima/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rubocop-ast-0.1.0/lib/rubocop/ast/node.rb
  39761197  /Users/fatkodima/Desktop/oss/rubocop/lib/rubocop/cop/style/commented_keyword.rb
  28841125  /Users/fatkodima/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rubocop-ast-0.1.0/lib/rubocop/ast/node_pattern.rb
  23182282  /Users/fatkodima/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/parser-<IP_ADDRESS>/lib/parser/source/buffer.rb
  22439585  /Users/fatkodima/Desktop/oss/rubocop/lib/rubocop/cop/util.rb
  21007465  /Users/fatkodima/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/parser-<IP_ADDRESS>/lib/parser/lexer.rb
  17836125  /Users/fatkodima/Desktop/oss/rubocop/lib/rubocop/cop/metrics/utils/code_length_calculator.rb
  16530814  /Users/fatkodima/Desktop/oss/rubocop/lib/rubocop/cop/commissioner.rb
.......

That line disappeared from the profile 😄
Memory savings: (682975704.0 - 657230941) / 682975704.0 * 100 = 4%
and in megabytes: (682975704.0 - 657230941) / 1024 / 1024 = 25mb.

Super interesting work!
I'll have to check more closely how this works. Some items make a lot of sense (source/buffer, node, lexer), some  seem bit surprising at first sight (set, node_pattern, and I wonder what code_length_calculator does).

BTW the stat on number of allocations decrease is ~6%, very cool.


minor overflow bug

I was checking ./runwolfbench 512 0 0 1 and it crashed on rhsort. Offending code:
      for (; i<n-4; i+=4) { x[i+4] += x[i+3] += x[i+2] += x[i+1] += x[i]; }
      for (; i<n-1; i++) { x[i+1] += x[i]; }

Seemingly working fix:
      for (; i+4<n; i+=4) { x[i+4] += x[i+3] += x[i+2] += x[i+1] += x[i]; }
      for (; i+1<n; i++) { x[i+1] += x[i]; }

Btw, have you had any luck improving performance on the 1-31 range?

Thanks. I went for changing n because I didn't know if the arithmetic for i would lift out of the loop (and didn't think about small numbers) but I don't see a performance difference.
You mean lengths 1 to 31? I think the amount of setup required means short arrays are never viable, so that it would be better to switch to a comparison sort.


Update procmon_linux.go

Codecov Report

Merging #267 (2eb0ffe) into int (3fad460) will decrease coverage by 2.40%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              int     #267      +/-   ##
==========================================
- Coverage   68.34%   65.93%   -2.41%
==========================================
  Files          14       14
  Lines        1510     1512       +2
==========================================
- Hits         1032      997      -35
- Misses        372      408      +36
- Partials      106      107       +1

Impacted Files
Coverage Δ

procmon_linux.go
62.77% <0.00%> (-7.60%)
:arrow_down:

procmon.go
84.61% <0.00%> (-15.39%)
:arrow_down:

eventhandler.go
53.81% <0.00%> (-5.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fad460...2eb0ffe. Read the comment docs.


"repair unwanted ruptured areas" in definition of Surgeon Role

The current definition of Surgeon Role is  "[superclass: physician role; definition: A physician role borne by a human being and that, if realized, is being realized by its bearer using operative manual and instrumental techniques on a patient to investigate and/or treat a pathological condition such as disease or injury, to help improve bodily function or appearance or to repair unwanted ruptured areas.]"
Is there a particular reason why "repair unwanted ruptured areas" is specifically included here? Perhaps a rewording of the definition would cover it:
   "A physician role realized by its bearer using operative techniques - direct or indirect (laparoscopic, robotic), on a patient to investigate and/or treat (1) a pathological condition such as a disease, disorder or injury, or (2) to help improve bodily function or appearance."

"unwanted ruptured areas" is covered by "disorder".
Note also the change in "operative manual and instrumental techniques".

@sivaramarabandi This definition was developed in the context of the CAFE project with domain experts including surgeons, so I'm not the best person to address this issue. @mbrochhausen what are your thoughts on Sivaram's suggestion?

I agree with some of the aspects Sivaram brought up:
I suggest the following edited version of the definition:
A physician role borne by a human being and that, if realized, is being realized by its bearer using operative manual and instrumental techniques on a patient to investigate and/or treat a disease, disorder or injury, to help improve bodily function or appearance or to repair unwanted ruptured areas.
For the other edits suggested by Sivaram I do not see any arguments in the initial message. I'd be interested to learn about those.

Sorry make that:
A physician role borne by a human being and that, if realized, is being realized by its bearer using operative manual and instrumental techniques on a patient to investigate or treat a disease, disorder or injury, to help improve bodily function or appearance or to repair unwanted ruptured areas.
Also, changes this might need edits to the subclasses of surgeon role necessary.

@aellenhicks was there any discussion around the use of the wording? As a surgeon, I am curious to know why someone wanted such specifics.

@sivaramarabandi: I think I'll answer that (if Amanda is ok with that). A definition draft was created using wikipedia and medical dictionaries. This draft was reviewed and edited by a group of domain experts in trauma (including surgeons). The assumption that someone requested the specificity you mention is incorrect. Rather, the specificity language seems to be residue from the draft version. Please be aware that none of the surgeons were per se ontologists.

Thanks, Mathias. SI aram  what are your thoughts?
Cheers,
Amanda
On Dec 28, 2016 11:32, "Mathias Brochhausen"<EMAIL_ADDRESS>wrote:

@sivaramarabandi https://github.com/sivaramarabandi: I think I'll
answer that (if Amanda is ok with that). A definition draft was created
using wikipedia and medical dictionaries. This draft was reviewed and
edited by a group of domain experts in trauma (including surgeons). The
assumption that someone requested the specificity you mention is incorrect.
Rather, the specificity language seems to be residue from the draft
version. Please be aware that none of the surgeons were per se ontologists.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ufbmi/OMRSE/issues/56#issuecomment-269501859, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHyM2R8DI8ozORrudKYqz7Vt6zd5GM94ks5rMo8MgaJpZM4LW-hy
.

You should revisit the definition if you can.

In light of this discussion, I have reverted all of the class additions, so they are no longer in the current version of OMRSE. I will move this question to the OMRSE email list. @sivaramarabandi Are you on the list?

Followed up on omrse mailing list again. Taking input for the next, then will resolve issue.

@aellenhicks I am not on the OMRSE email list. How do I get on it?

Hi Sivaram,
Here is the link for the Google group.
https://groups.google.com/forum/#!forum/omrse-discuss
Amanda
From: Sivaram Arabandi <notifications<EMAIL_ADDRESS>Reply-To: ufbmi/OMRSE <reply<EMAIL_ADDRESS>Date: Monday, February 6, 2017 at 9:40 AM
To: ufbmi/OMRSE <OMRSE<EMAIL_ADDRESS>Cc: aellenhicks <aellenhicks<EMAIL_ADDRESS>Mention <mention<EMAIL_ADDRESS>Subject: Re: [ufbmi/OMRSE] "repair unwanted ruptured areas" in definition of Surgeon Role (#56)
@aellenhickshttps://github.com/aellenhicks I am not on the OMRSE email list. How do I get on it?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/ufbmi/OMRSE/issues/56#issuecomment-277701211, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHyM2R__67IT8Osfo9ZqSweUO4LpredFks5rZzDKgaJpZM4LW-hy.

The last actionable item here is:

Define 'surgeon role' as follows:
A physician role borne by a human being and that, if realized, is being realized by its bearer using operative manual and instrumental techniques on a patient to investigate or treat a disease, disorder or injury, to help improve bodily function or appearance or to repair unwanted ruptured areas.

Then review its subclasses to see if edits to its subclasses are necessary as a result of above.

We discussed on today's (Nov 1, 2023) call dropping the "or to repair unwanted ruptured areas" clause.
We reviewed the subclasses and 'pediatric surgeon role' would also need to have its definition updated. We are working on proposals for new definitions of 'surgeon role', 'pediatric surgeon role', and 'neurosurgeon role' (that last one was a bit circular and also ungrammatical).

Following the OMRSE call discussion today, I suggest the following definition for 'surgeon role':

A physician role that, if realized, is realized by its bearer using operative manual and instrumental techniques to investigate, treat, or modify a patient's anatomical or physiological state for health, functional, or aesthetic purposes.

Note: Physician roles are borne by human beings, hence the removal of "borne by a human being" in the proposed definition.
Another note: The definition of physician role implies veterinarians cannot bear surgeon roles, since they don't work to promote human health; note sure if that is intended.

You can also add that it is realized by a surgical procedure.
Many surgical procedure classes out there.
Here is one we defined in the OHD many moons ago:

A series of steps followed in a regular, orderly, definite way, performed by a physician, dentist or surgeon by manual operation.

Here is a definition from OBIB:

A planned process that uses operative manual and instrumental techniques on a patient to investigate and/or treat a pathological condition such as disease or injury, or to help improve bodily function or appearance.

There plenty more ...

We discussed the current proposal:
A physician role that, if realized, is realized by its bearer using operative manual and instrumental techniques to investigate, treat, or modify a patient's anatomical or physiological state for health, functional, or aesthetic purposes.
One issue is that a surgeon's role is also realized when they do consultations, second opinions, and follow-up care after surgical procedures. So the definition needs to be expanded to include those activities as well.
A new proposal:
A physician role that, if realized, is realized by either (1) performing a surgical procedure, (2) consultation on the potential need for a surgical procedure, (3) giving a second opinion on the need for a surgical procedure, (4) providing post-operative and follow-up care after a surgical procedure, (5) explaining the benefits and risks of a surgical procedure to a patient or patient's parent or otherwise legally authorized representative, (6) obtaining informed consent for a surgical procedure, (7) giving instructions, directions, and communications to healthcare team members before, during, and after the performance of a surgical procedure related to the procedure.
Comment on informed consent: we reviewed OBI's "informed consent process" and like it, and it is applicable to #6 above particularly because it encompasses actually doing the consent and not just signing the papers.  Note that the bearer of the surgeon role is obtaining informed consent for a surgical procedure that they intend to carry out, either as lead surgeon or a member of the surgical team. For example, a surgical resident or fellow might do the informed consent on behalf of the attending and all other members of the surgical team.  There might be multiple surgical specialists involved in a surgical procedure, but informed consent is not necessarily performed by them all (especially if they're brought in unexpectedly to handle unanticipated situations that arise).
Comment on surgical procedure: we reviewed OHD, OBIB, and MAXO definitions of 'surgical procedure' and are not decided on which one "to use" (whether that means we include it specifically in the axiom or not, and we just allude to it).

Also we want to be abundantly clear that none of those activities is necessarily exclusive to surgeons (e.g. physician assistants). So we want to be explicit that for none of those activities, are we implying that every instance of the activity realizes a surgeon role. We did discuss that it might be possible that every instance of "obtaining informed consent for a surgical procedure" is actually performed by a surgeon and thus realizes a surgeon role.  However, that is not relevant to the definition of 'surgeon role'.

"A physician role that, if realized, is realized by its bearer using
operative manual and instrumental techniques to investigate, treat, or
modify a patient's anatomical or physiological state for health,
functional, or aesthetic purposes."
This I think would be the 'necessary and sufficient conditions' to define
the role. The rest of it - consultation, second opinion, etc. would all be
inherited from the more general physician role.
best
Sivaram

Sivaram Arabandi, MD, MS
ONTOPRO
W:  http://ontopro.com/
Ph:<PHONE_NUMBER>
Li : https://www.linkedin.com/in/sivaramarabandi/
Think Semantics. Tame Silos.
On Fri, May 3, 2024 at 12:01 PM Bill Hogan @.***> wrote:

We discussed the current proposal:
A physician role that, if realized, is realized by its bearer using
operative manual and instrumental techniques to investigate, treat, or
modify a patient's anatomical or physiological state for health,
functional, or aesthetic purposes.
One issue is that a surgeon's role is also realized when they do
consultations, second opinions, and follow-up care after surgical
procedures. So the definition needs to be expanded to include those
activities as well.
A new proposal:
A physician role that, if realized, is realized by either (1) performing a
surgical procedure, (2) consultation on the potential need for a surgical
procedure, (3) giving a second opinion on the need for a surgical
procedure, (4) providing post-operative and follow-up care after a surgical
procedure, (5) explaining the benefits and risks of a surgical procedure to
a patient or patient's parent or otherwise legally authorized
representative, (6) obtaining informed consent for a surgical procedure,
(7) giving instructions, directions, and communications to healthcare team
members before, during, and after the performance of a surgical procedure
related to the procedure.
Comment on informed consent: we reviewed OBI's "informed consent process"
and like it, and it is applicable to #6
https://github.com/mcwdsi/OMRSE/issues/6 above particularly because it
encompasses actually doing the consent and not just signing the papers.
Note that the bearer of the surgeon role is obtaining informed consent for
a surgical procedure that they intend to carry out, either as lead surgeon
or a member of the surgical team. For example, a surgical resident or
fellow might do the informed consent on behalf of the attending and all
other members of the surgical team. There might be multiple surgical
specialists involved in a surgical procedure, but informed consent is not
necessarily performed by them all (especially if they're brought in
unexpectedly to handle unanticipated situations that arise).
Comment on surgical procedure: we reviewed OHD, OBIB, and MAXO definitions
of 'surgical procedure' and are not decided on which one "to use" (whether
that means we include it specifically in the axiom or not, and we just
allude to it).
—
Reply to this email directly, view it on GitHub
https://github.com/mcwdsi/OMRSE/issues/56#issuecomment-2093405300, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AB4D6F2E4SXWGCNWS4S6SNDZAO7FBAVCNFSM4C235BZKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBZGM2DANJTGAYA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Sivaram, an excellent point with which I agree. We discussed on today's call that as a subclass of physician role, we also avoid the "circumstantial surgeon" like a layperson doing an emergency tracheotomy.

Agree... and the 'circumstantial' aspect has potential for use in other
situations such as 'circumstantial pilot' (a passenger without pilot
training flying a plane in an emergency), 'circumstantial soccer coach' (a
parent stepping in when the real coach couldn't make it to the practice),
etc.
On Wed, Jun 5, 2024 at 11:04 AM Bill Hogan @.***> wrote:

Sivaram, an excellent point with which I agree. We discussed on today's
call that as a subclass of physician role, we also avoid the
"circumstantial surgeon" like a layperson doing an emergency tracheotomy.
—
Reply to this email directly, view it on GitHub
https://github.com/mcwdsi/OMRSE/issues/56#issuecomment-2150434827, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AB4D6F4BG3NPJDKXN5Y2S7TZF4ZI5AVCNFSM4C235BZKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMJVGA2DGNBYGI3Q
.
You are receiving this because you were mentioned.Message ID:
@.***>


Fix crash when renaming input maps in single window mode

Fixes #86165
It already uses call_deferred in another branch, so IMO it's appropriate to add it here.

Superseded by #89346
Although that PR made the other deferred call irrelevant, so you could change it to regular call. But that's no longer a bugfix.

Sounds like I should close this one since it's no longer crash.


I can't run a unit test from QUnit

Steps to reproduce
Tell us about your environment:

Puppeteer version: 1.9.0
Platform / OS version:
URLs (if applicable):
Node.js version: 8.11.4

I have a external function that get a element
export const $ = (selector) => {
  return document.querySelector(selector);
};

but when I try to run it in the browser using puppeteer, it just returns me an empty object.
const puppetter = require('puppeteer');
const QUnit = require('qunit');
const path = require('path');
const fixturePath = path.resolve(__dirname, './fixtures');

const { module: testModule, test } = QUnit;
import { $ } from '../src/helpers/dollar';

testModule('$ - dollar DOM', function (hooks) {

    hooks.before(async function() {
      this.browser = await puppetter.launch();
    });

    hooks.after(async function () {
      await this.browser.close();
    });

    test('application loads and shows number of online users', async function (assert) {
      const page = await this.browser.newPage();
      await page.goto(`file:${fixturePath}/index.html`, { waitUntil: 'load' });

      const foo = await page.evaluate($, 'body');
      console.log(foo.toString())
      assert.equal(foo, 'Hello World!'); // foo is {} empty object

      await page.close();
    });
});

should not it be possible to do unit tests of functions that deal with the DOM? Should I be able to do everything I do in the browser by running puppeteer?
If i run $ like this function, all works. But I can be able to write unit test too:
export const $ = (selector) => {
  return document.querySelector(selector).innertText;
};

cc : @aslushnikov @entrptaher

The $ function has a typo. You are using .innertText not .innerText.

Did you try this way of exporting,

const $ = selector => document.querySelector(selector).innertText;
module.exports = $;

Did you transpile the module before using it in the browser? Most likely the browser still doesn't support module import/export, right?

@entrptaher even using this solution
const $ = selector => document.querySelector(selector);
module.exports = $;

if I put innerText inside the function works, but my original function is this, it returns only the element.
the title continue returning a empty object, the problem is not es5 or es6. The problem is with puppeteer way
test('Matches the big header', async function(assert) {
    const page = await this.browser.newPage();
    await page.goto('https://example.com');
    const title = await page.evaluate($, 'h1');
    assert.equal(title.innerText, 'Example Domain'); // title - {}
  });

That's not a bug, nor an issue.
.evaluate returns a Promise, which is not a HTML Node. So calling .innerText on that will not work.

@entrptaher following your stackoverflow aswer the problem persist.
I'm sorry, but this still seems like an issue, look at this scenario. the result will return - ReferenceError: _dollar is not defined
const $ = selector => document.querySelector(selector);
module.exports = $;

const puppeteer = require('puppeteer');

const QUnit = require('qunit');
const $ = require('./dollar');

const { module: testModule, test } = QUnit;

testModule('$ - dollar DOM', (hooks) => {
  hooks.before(async function() {
    this.browser = await puppeteer.launch();
  });

  hooks.after(async function() {
    await this.browser.close();
  });

  test('sould return the dom element if exist', async function (assert) {
      const page = await this.browser.newPage();
      await page.goto(`file:${fixturePath}/index.html`);

      await page.addScriptTag({ url: 'https://www.unpkg.com/domjson' });

      const bodyEl = await page.evaluate(() => {
        return domJSON.toJSON($('body'));
      });
      console.log(JSON.stringify(bodyEl, true, 2)); // return a empty object
      assert.ok(bodyEl);

      await page.close();
    });
});

Trying the evaluate script the .evaluate will return a {}
test('sould return the dom element if exist', async function (assert) {
      const page = await this.browser.newPage();
      await page.goto(`file:${fixturePath}/index.html`);

      await page.addScriptTag({ url: 'https://www.unpkg.com/domjson' });

      const bodyEl = await page.evaluate(`
          // Now I'm inside BROWSER environment
          () => {
            return domJSON.toJSON($('body'));
          }
      `);
      console.log(JSON.stringify(bodyEl, true, 2)); // {}
      assert.ok(bodyEl);

      await page.close();
    });

Now that's a Babel/Webpack issue.
Are you using babel/webpack?

babel
yes, importing on test.js file but using puppeteer as headless to these tests.

@villander try using page.evaluateHandle instead of page.evaluate. This way you'll get an ElementHandle as a result.
The page.evaluate won't return you any DOM node since it's not serializable and can't pass the process boundary.
Hope this helps.
P.S. note, that your page.evaluateHande($, 'body') is the same as await page.$('body'). See page.$ for details.

@aslushnikov I don't want to replace my function with page.$. I need test my function/modules on browser with Qunit + Puppeteer. I need to ensure that they will work in the browser at levels of unit testing, integration and acceptance

@villander you are trying to assert on node environment, but testing on browser environment, which is a contradiction. You cannot use dom elements on node environment.
So you have to do whatever I suggested above https://github.com/GoogleChrome/puppeteer/issues/3437#issuecomment-432506267 or do the assert on the browser environment. That's how it will work and if you see the hundreds of tests written on the puppeteer repo, they all have same method.

@entrptaher  come on the puppetter is not a headleess pro chrome? because when I do assert in evaluate I'm not in the browser?
So you mean there's no way I can do DOM assert on the puppetter, is that what you're telling me?
This comment https://github.com/GoogleChrome/puppeteer/issues/3437#issuecomment-432506267 you are using the same flow, doing assert after call .evaluate function.
Could you please send me a demo of this working in my scenario?

@aslushnikov the page.$ is a function from puppetter, i want to test my function.
I have private functions that deal with the DOM, I'm not using jquery. $ Is a private implementation

Puppeteer is a Headless Chrome Node API, not a testing library. But even in testing, puppeteer is best used for, automation, UI regression testing, screenshot Testing, performance Testing, load testing, end to end or acceptance testing.
In the example, I am doing whatever I want to do with my functions. And then asserting them on the node. You will see at least hundred people are doing the same thing same way right now. Either using this way, or using JSDOM.
You just have to change your way of testing them. You can return a DOM element, but whenever it comes on the node context, it won't be a dom element anymore but a controller/handle for that DOM element. You can learn more about JSHandle and ElementHandle.
Check the following resources:

https://mochajs.org/#running-mocha-in-the-browser
https://github.com/jasmine/gulp-jasmine-browser
https://github.com/facebook/jest/issues/848#issuecomment-340225198
https://jestjs.io/docs/en/puppeteer
https://github.com/smooth-code/jest-puppeteer
https://github.com/reid47/jest-browser

Peace.


Fix correct tox environments

The tox env list (found here) did not match with the testenv configuration. This caused for example calling tox without arguments to not run the style and typing checks.

I separated pytest from style and typing because testing should be done in a runtime env (we still need to make that distinction though I now realize). Separating style and type implies that one more environment is installed. This makes it (significantly) slower, while it is not that important for the tests. Fine with me, but I see no reason to do so.

Yeah, initially I was splitting the dependencies such that for typing you only needed the dev dependencies, but pytest needs all dependencies installed.
We could rename maybe to style, lint, unit test. That way the style environment is very minimal. And both lint and test have the runtime dependencies

I think I now have obtained what you wanted.
If you want to install the full development env, you need to issue "poetry install --with testrunner --with testing --with style --with typing"


The --recurse-to option is not working when python version 3.10.11 is installed

I am trying to build one image using the nuitka build image of Nuitka release verison 1.6 (i.e. Nuitka-1.6.tar.bz2), but when i am trying to use the --recurse-to option inside the container created from nuitka image then i am getting below error:
"nuitka: error: no such option: --recurse-to"

The python version installed is : 3.10.11
In the Nuitka documentatioin from the fowlloing url : "https://github.com/Nuitka/Nuitka/blob/develop/.github/ISSUE_TEMPLATE.md" , says that instead of --recurse-* we can use --follow-* but same type of error is displaying with the follow as well refer below screenshots for Nuitka Documantion as well as the error displaying when we use follow instead of recurse:

Can anyone please help me with this , or is it a bug?

Please read the docs, help output specifically.


ByteBuffer.clear should reset the ByteBuffer._slice.

Closes #1202. ByteBuffer.clear should reset the ByteBuffer._slice.
Motivation:
ByteBuffer.clear doesn't reset the ByteBuffer._slice. Imagine having a byte buffer slice (ByteBuffer.getSlice). Calling ByteBuffer.clear on the slice will reset the reader and writer, but the ByteBuffer.capacity will return the old slice size, not the full storage capacity. After this change ByteBuffer.clear will also reset the ByteBuffer._slice to regain the whole ByteBuffer._storage.
Modifications:
Just setting the full storage slice in the ByteBuffer.clear method.
Result:
After that change ByteBuffer.clear will reset byte buffer slice to full capacity of underlying storage.

It's all thanks to @Keno42 for spotting that! I had a really great time working with you guys.

@swift-nio-bot test this please


Hi ! HI ! HIII ! How to make a button

No, I won't say Hi ! again ! Like the title say, I can't make a button ! How to make a button !

	"buttonexample":
	{
		"text" : "Test.",
		"hoverText" : "§nTest.",
		"posX" : 36,
		"posY" : 70,
                    "texture" : "test:btnexample.png",
		"alignment" : "top_left",
		"action" :
		{
			"type" : "openLink",
			"link" : "www.example.com"
		}
            }

Don't forget if there's something after this add a comma after the last curly bracket
Buttons have 2 states hover and nohover basically you can create a texture for it with 2 states with the width of 16 and height of 32, button states occupy a 16x16 or you can have no like hover animation and instead make the text/color (or both) change when hovered
there's also actions like
{
"type" : "openGui",
"gui" : "example2ndgui"
}
(You can create custom guis you need more json files if so
{
"type" : "connectToServer",
"ip" : "play.skycade.net"
}
(example server btw it does actually exist tho)
{
"type" : "loadWorld",
"dirName" : "John's favorite world",
"saveName" : "blegh" (optional)
}
(random name for world)
{
"type" : "openFolder",
"folderName" : "mods" (uses minecraft instance folder as root folder)
}
https://www.curseforge.com/minecraft/mc-mods/custom-main-menu/pages/custom-main-menu/actions
https://pastebin.com/dJzLgnSL (List of open-able guis by default)

if your talking about the image being halfed, every button requires a hover image. all you need to do I reproduce the image in either the same or different format then place it directly below the current image. all will be in the same image. the top half is what appears as the normal image and the bottom half will only appear when they hover over the image.


Can we extract data annotation

Can we extract data annotation
Example
[Display(Name = "Id")]
public int? Id { get; set; }

There isn't any built-in functionality to extract data from attributes, but it is certainly possible. You can write your own extractor, that processes AttributeSyntax nodes. It will be very similar to SingularStringExtractor (https://github.com/lukaskabrt/PoExtractor/blob/dev/PoExtractor.CS/SingularStringExtractor.cs)

@lukaskabrt
Thanks, I did it
`public class DataAnnotationStringExtractor : LocalizableStringExtractor
{
public DataAnnotationStringExtractor(IMetadataProvider metadataProvider) : base(metadataProvider)
{
}
    public override bool TryExtract(SyntaxNode node, out LocalizableStringOccurence result)
    {
        result = null;
        if (node is AttributeArgumentSyntax accessor &&
            accessor.Expression is LiteralExpressionSyntax literal &&
            literal.IsKind(SyntaxKind.StringLiteralExpression)
            && (node.ToFullString().StartsWith("Name=") || node.ToFullString().StartsWith("Name =")))
        {
            result = new LocalizableStringOccurence()
            {
                Text = literal.Token.ValueText,
                Context = this.MetadataProvider.GetContext(node),
                Location = this.MetadataProvider.GetLocation(node),
            };

            return true;
        }
        return false;
    `

@lukaskabrt
Thanks, I did it.

@lukaskabrt can I send a PR for this, while I'm working with data annotations in Orchard Core


Missing build dependency

Current coverage is 86.74% (diff: 100%)

Merging #120 into master will increase coverage by 0.03%

@@             master       #120   diff @@
==========================================
  Files            20         20
  Lines          2988       2988
  Methods           0          0
  Messages          0          0
  Branches        437        437
==========================================
+ Hits           2591       2592     +1
  Misses          301        301
+ Partials         96         95     -1

Powered by Codecov. Last update 8d3832a...6218c09

Thanks.. landing (in rebased form) momentarily. Any idea what the Fedora equivalent of libssl-dev might be? We should probably update the Fedora advice too, one of these days.

It's probably "libssl-devel" but I'm not entirely sure. Paging @kneufeld ;)

openssl-devel

@kneufeld thanks! What's the full command we should recommend.. yum install python-pip build-essential python-devel libffi-devel openssl-devel? I'm sure we need something different than python-pip and build-essential in there.
Also, where can I find a list of Fedora package names online? For debian and ubuntu I use https://www.debian.org/distrib/packages and http://packages.ubuntu.com/ . Is there some equivalent for the fedora world?

Hi, I am installing on Fedora 23 right now.  Fedora does not have a build-essential packages, so I installed gcc-c++ and libtool instead, which pull in cc, autoconf, automake, glibc, kernel headers, etc as dependencies.  I have found I also needed to install redhat-rpm-config.
On at least Debian I had to run pip install --upgrade pip, as the distribution provided version was too old to compile all the dependencies.  I have ran this on Fedora too, but I am unsure whether it is required.
On my Debian system behind a firewall designed to mostly only allow connections in and out via Tor, I was unable to get magic-wormhole to run successfully.  I would be able to provide shell access to this system for debugging to a trusted individual with extra time if desired.  But perhaps I just need to punch the right hole or set up the right hidden service.  It didn't "just work" with torify wormhole.
On Fedora, it is dnf now instead of yum.  So, a complete package installation command might be dnf install python-pip python-devel libffi-devel openssl-devel gcc-c++ libtool redhat-rpm-config libsodium-devel I believe.
I'm afraid I do not know where the fedora rpm lists are best reviewed online.  My local system downloads them from https://download.fedoraproject.org/pub/fedora/linux/releases/ .

As of a release or two ago, yum is now dnf. No idea why they changed the name since as far as I can tell all the sub-commands and flags are the same. But I digress...
I usually just install gcc and gcc-c++ but the Fedora equivalent of apt install build-essential is dnf group install 'dnf group install 'C Development Tools and Libraries'. I know right, rolls right of the figer tips. dnf group list for other goodies.  But I digress...
dnf install python-pip etc looks correct, just build-essential is different.
As for a package list I always just do a dnf list > dnf.list as the first command on a box. Faster to grep than dnf search. But I digress.
I haven't used it but you're probably looking for https://admin.fedoraproject.org/pkgdb/packages/

Huh, this @xloem individual seems pretty bright. Especially since our two comments are virtually identical and posted 15 seconds apart. ;)

Sorry for the accidental snipe!  What a coincidence.

Again!


Made class name consistent with experiment name.

Consistently using “button-color-experiment” for class name and experiment name instead of an additional “button-experiment” class name.

LGTM

Thank you very much!


Clarification on why only compact groups

I was reading your paper and it mentions that the approach of implicit steerable kernels works for compact groups G<=O(n). I was wondering if it could work for bigger groups G<=GL(n), where GL is the general linear group.
On a similar note, since many physical systems require equivariance/invariance to unitary transformations U(n), do you think this approach would work? Since it would require the use of complex numbers.
Thank you! and sorry in advance if such questions are trivial, I was unable to find an answer.

To be honest, I don't think that G really needs to be compact. For the proof to work, we only require $\rho(g)^T = \rho(g)^{-1}$ (see Appendix A.2), which will also work for unitary groups.
You can also make it work for pseudo-Euclidean groups, although we achieved that not with irreps but with Clifford algebra: https://github.com/maxxxzdn/clifford-group-equivariant-cnns.
Regarding unitary groups, theoretically, there should be no problem. Unfortunately, you would need to build a G-MLP yourself since it is not supported by escnn at the moment. There are, however, MLPs I saw implemented for unitary groups, e.g. https://github.com/lie-nn/lie-nn

Thank you for your rapid answer! Since the transpose of the representation has to equal the inverse, I think that necessitates the group to be compact, in particular the unitary group is compact - and the inverse equals the conjugate transpose. Given this, would an implicit method not work for the general linear group GL(n)? I ask as I would rather prefer not to try to analytically derive the kernels for even more difficult groups. Thank you again!

I don't really have the answer for GL(n). As far as I know, people use group convolutions rather than steerable convolutions in many cases (see Table 14.1, thesis https://maurice-weiler.gitlab.io/), and I don't know if you can employ steerable convolutions there, for which implicit kernels are originally defined.

I see, I'll keep on searching. Thank you very much for your time!


Dev to Master

A fix for when the error
INDEX_SIZE_ERR: INDEX_SIZE_ERR: DOM Exception 1
is thrown

Uhhhh, I have no idea what changes are actually important. @joeyism This is going to need a rebase against master.

These changes still needed to be merged into dev meaning they were propper PR's.  Should we test the code to see if it works and make sure all the changes are relevant?


Fix incorrect substitution behavior and simplify substitution code

Closes #807

Thanks for fixing that bug! The main concern I have with the simplification is that this removes the memoization and avoiding constructing a new node if the arguments are unchanged after substitution. Is it possible to restore this while not reintroducing the bug?

To be clear, those things mainly have performance implications, I don't think it will affect the correctness of any other code paths (just means that deeper analysis is often required for comparing expressions for equality or extracting common subexpressions in the compiler).

Yeah I can restore it. The fix was just to raise a specific error and catch it when the schemas to be substituted don't match. We can do that with the original code, I just thought it would be easier to maintain if there wasn't as much indirection. Is there a benchmark for this to see what kind of perf hit there would be?

Thoughts on using toolz for memoization? It's a super lightweight dependency and would simplify some of the memoization in other places as well. It's not any better performance wise but is easier to read.

That's fine by me

Will you be able to tackle this in the next week or so? Looks like this may also fix #827

Yep I will finish this up this weekend.

@wesm Had some extra time this morning, can you review?

awesome thanks, looking now

Tests check out, thank you!


Default hit locations isn't applied to new sheets

I can not seem to repoduce this anymore.  Will wait for the v3.3 release then test again with a new game and if the issues still appears fixed I'll close this out.


cannot focus search results editor

To reproduce:

use the editor-based VSCode search UI
say pre whale, where whale is one of the hats in the search results

Result:
The search query is focused rather than the results. This makes it hard to use page up and page down to look through the search results.

I'm not sure if this is the same issue or deserves its own discussion. If I try to use cursorless to copy something from the search editor it will not end up in my clipboard, but if I use cursorless to select that text and then separately copy it it will end up in the clipboard.

This is somewhat improved but still not fixed. Now if your focus is in the search editor you should be able to use Cursorless. The problem is that we have no reliable way for cursorless to move focus from the input box to the actual search editor.


Sourcemaps not working in elaborate setup with system.js/node.js/babel/typescript (has example repro project)

VSCode Version: 1.2.1
OS Version: Windows 10

Steps to Reproduce:

Get https://github.com/mavericken/jspm-node-typescript-vscode.git
npm install
npm install -g node-inspector
node-debug loader.js app.ts (see sourcemaps working)
open in vscode and click debug (see sourcemaps not working)

Screenshots here:
https://github.com/mavericken/jspm-node-typescript-vscode/issues/2

Trying to get the repro to run, and I see a wide variety of errors. I think it has succumbed to bit rot.


add NEON RGB camera catalog

Add catalog and examples for NEON RGB camera imagery

This should be ready now! All the suggestions were applied in the last 2 commits.


Invoke-DbaQuery - allow header row if empty result set returned

Summarize Functionality
Sometimes we need to generate a file that includes a header row of the columns that would be present, even if there is no data to accompany them. I'd like to see a parameter allowing that as an option to the Invoke-DbaQuery function.
Is there a command that is similiar or close to what you are looking for?
Yes
Technical Details
Invoke-DbaQuery will generate headers if there is at least one row of data returned, but doesn't return any headers when there is no data. The same query in SSMS will return header information.
I think an extra parameter or switch something like "-AlwaysGenerateHeaders" might suffice to generate header information even if there is no other data returned.

it's not really a matter of what we do, rather that PS pipeline has nothing able to represent a zero-length results "with headers only" (which translates to a collection of properties, whose "names" are what you're looking for).
"" | Select col1, col2, col3, col4, col5  may SEEM to achieve what you want, but would be indistinguishable from a result with a single row with all values empty.
You can retrieve the column names from the "richer" datatable object though
$result = Invoke-DbaQuery -SqlInstance .... -Query "select 1 as a, 2 as b where 1=0" -as DataTable
$cols = $x.Columns
$allcols = $cols | % { $_.ColumnName }
##E.g. generating an header for a CSV file, empty
("" | select $allcols | ConvertTo-Csv -NoTypeInformation)[0]

Yeah this is a limitation of objects in PowerShell.


fix: allow type to be specified on resolver args

Motiving example:
(Note Schema.SignupMutationArgs)
import * as GQLImport from "graphql-import"
import * as Yoga from "graphql-yoga"
import * as YogaTypes from "graphql-yoga/dist/types"
import * as Schema from "./SchemaTypes"

const typeDefs = GQLImport.importSchema(__dirname + "/TypeDefs/Main.graphql")

const resolvers: YogaTypes.IResolvers = {
  Mutation: {
    signup: (source: any, args: Schema.SignupMutationArgs, ctx, info) => {
      console.log(args)
      return ""
    },
  },
}

const server = new Yoga.GraphQLServer({ typeDefs, resolvers })

server.start().then(server => {
  console.log("started server at %s", JSON.stringify(server.address()))
})

source/Main.ts(8,7): error TS2322: Type '{ Mutation: { signup: (_: any, args: SignupMutationArgs) => string; }; }' is not assignable to type 'IResolvers'.
  Property 'Mutation' is incompatible with index signature.
    Type '{ signup: (_: any, args: SignupMutationArgs) => string; }' is not assignable to type '(() => any) | IResolverObject | GraphQLScalarType'.
      Type '{ signup: (_: any, args: SignupMutationArgs) => string; }' is not assignable to type 'GraphQLScalarType'.
        Property 'name' is missing in type '{ signup: (_: any, args: SignupMutationArgs) => string; }'.

This PR fixes the above TS error.
The reason for any and not just Record<string,any> is that we're apparently (surprisingly...) hitting a TS bug:

https://stackoverflow.com/questions/46361905/property-is-missing-in-type-x-string-string
https://github.com/Microsoft/TypeScript/issues/13948

If I reduce the union type in Yoga to get at the error (the error message above hits the scaler case because the first two failed, hiding the error message we're interested in):
TSError: ⨯ Unable to compile TypeScript:
source/Main.ts(8,7): error TS2322: Type '{ Mutation: { signup: (_: any, args: SignupMutationArgs) => string; }; }' is not assignable to type 'IResolvers'.
  Property 'Mutation' is incompatible with index signature.
    Type '{ signup: (_: any, args: SignupMutationArgs) => string; }' is not assignable to type 'IResolverObject'.
      Property 'signup' is incompatible with index signature.
        Type '(_: any, args: SignupMutationArgs) => string' is not assignable to type 'GraphQLFieldResolver<any, any, { [argName: string]: any; }>'.
          Types of parameters 'args' and 'args' are incompatible.
            Type '{ [argName: string]: any; }' is not assignable to type 'SignupMutationArgs'.
              Property 'email' is missing in type '{ [argName: string]: any; }'.

IIUC               Property 'email' is missing in type '{ [argName: string]: any; }'. makes no sense because { [argName: string]: any; } should encompass the possibility for any string key name :('
So alas I am using any. Luckily it actually does not seem to matter for the developer as she only really cares at the time of resolver implementation and the Any we're putting here can be overridden as shown in my motivating example.

Hey @schickling or @nikolasburk, did you get a chance to look at this PR yet?

Apologies for the delay @jasonkuhrt. We'll look into this PR soon! 🙏

@jasonkuhrt This may be irrelevant as I haven't looked too deep into this PR, but you can usually avoid using any if you implement generics. Is this something we looked into?

@hassanbazzi IResolvers  models all resolvers, as per the name. Each resolver will have its own Args type (more or less). Therefore at the level of IResolvers I don't see how we can do anything useful. The main benefit of this PR is a small step forward to:

Allow typing Args at the resolver level.
Allow context to be typed at the resolver level.

This fixed the previous issues I reported.

I have PR #418 which I think addresses this more correctly

@Slessi yours looks better. Lets focus there. 👍


[Snyk] Upgrade net.kyori:adventure-text-minimessage from 4.13.0 to 4.13.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade net.kyori:adventure-text-minimessage from 4.13.0 to 4.13.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 24 days ago, on 2023-04-09.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Copy of https://github.com/ahmadk953/Poixpixel-Custom/pull/15


feature(lisong): add continuous dqfd

Description
add continuous dqfd
Related Issue
add continuous switch in dqfd_nstep_td_error
TODO
Check List

[ ] merge the latest version source branch/repo, and resolve all the conflicts
[ ] pass style check
[ ] pass all the tests

add label in your PR


iperf: 3.9 -> 3.10.1

Motivation for this change
Version bump
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 136027 run on x86_64-linux 1

6 packages marked as broken and skipped:

linuxPackages-libre.bcc
linuxPackages-libre.bpftrace
linuxPackages-libre.oci-seccomp-bpf-hook
linuxPackages_latest-libre.bcc
linuxPackages_latest-libre.bpftrace
linuxPackages_latest-libre.oci-seccomp-bpf-hook

40 packages built:

iperf
linuxPackages.bcc
linuxPackages.bpftrace
linuxPackages.oci-seccomp-bpf-hook
linuxPackages_4_14.bcc
linuxPackages_4_14.bpftrace
linuxPackages_4_14_hardened.bcc
linuxPackages_4_14_hardened.bpftrace
linuxPackages_4_19.bcc
linuxPackages_4_19.bpftrace
linuxPackages_4_19_hardened.bcc
linuxPackages_4_19_hardened.bpftrace
linuxPackages_4_4.bcc
linuxPackages_4_4.bpftrace
linuxPackages_4_9.bcc
linuxPackages_4_9.bpftrace
linuxPackages_hardened.bcc (linuxPackages_5_10_hardened.bcc)
linuxPackages_hardened.bpftrace (linuxPackages_5_10_hardened.bpftrace)
linuxPackages_hardened.oci-seccomp-bpf-hook (linuxPackages_5_10_hardened.oci-seccomp-bpf-hook)
linuxPackages_5_13.bcc
linuxPackages_5_13.bpftrace
linuxPackages_5_13.oci-seccomp-bpf-hook
linuxPackages_5_4.bcc
linuxPackages_5_4.bpftrace
linuxPackages_5_4.oci-seccomp-bpf-hook
linuxPackages_5_4_hardened.bcc
linuxPackages_5_4_hardened.bpftrace
linuxPackages_5_4_hardened.oci-seccomp-bpf-hook
linuxPackages_lqx.bcc
linuxPackages_lqx.bpftrace
linuxPackages_lqx.oci-seccomp-bpf-hook
linuxPackages_testing_bcachefs.bcc
linuxPackages_testing_bcachefs.bpftrace
linuxPackages_testing_bcachefs.oci-seccomp-bpf-hook
linuxPackages_xanmod.bcc
linuxPackages_xanmod.bpftrace
linuxPackages_xanmod.oci-seccomp-bpf-hook
linuxPackages_zen.bcc
linuxPackages_zen.bpftrace
linuxPackages_zen.oci-seccomp-bpf-hook

Result of nixpkgs-review pr 136027 at d1dae1af run on aarch64-linux 1

4 packages marked as broken and skipped:

linuxPackages_hardkernel_4_14.bcc
linuxPackages_hardkernel_latest.bcc
linuxPackages_testing_bcachefs.bcc
linuxPackages_testing_bcachefs.oci-seccomp-bpf-hook

8 packages skipped due to time constraints:

linuxPackages-libre.bcc
linuxPackages-libre.oci-seccomp-bpf-hook
linuxPackages_4_4.bcc
linuxPackages_4_9.bcc
linuxPackages_latest-libre.bcc
linuxPackages_latest-libre.oci-seccomp-bpf-hook
linuxPackages_xanmod.bcc
linuxPackages_xanmod.oci-seccomp-bpf-hook

19 packages built successfully:

iperf (iperf3)
linuxPackages.bcc (linuxPackages_5_10.bcc)
linuxPackages.oci-seccomp-bpf-hook (linuxPackages_5_10.oci-seccomp-bpf-hook)
linuxPackages_4_14.bcc
linuxPackages_4_14_hardened.bcc
linuxPackages_4_19.bcc
linuxPackages_4_19_hardened.bcc
linuxPackages_hardened.bcc (linuxPackages_5_10_hardened.bcc)
linuxPackages_hardened.oci-seccomp-bpf-hook (linuxPackages_5_10_hardened.oci-seccomp-bpf-hook)
linuxPackages_5_13.bcc (linuxPackages_latest.bcc)
linuxPackages_5_13.oci-seccomp-bpf-hook (linuxPackages_latest.oci-seccomp-bpf-hook)
linuxPackages_5_4.bcc
linuxPackages_5_4.oci-seccomp-bpf-hook
linuxPackages_5_4_hardened.bcc
linuxPackages_5_4_hardened.oci-seccomp-bpf-hook
linuxPackages_lqx.bcc
linuxPackages_lqx.oci-seccomp-bpf-hook
linuxPackages_zen.bcc
linuxPackages_zen.oci-seccomp-bpf-hook


Fails with Elixir ~> 1.7

This library uses internal mix api which has changed in recent Elixir versions. Once a nerves project moves to Elixir 1.7, this library will fail to compile. Issue is here:
warning: function Mix.Config.Agent.get/1 is undefined (module Mix.Config.Agent is not available)
lib/mix/lib/releases/config/config.ex:447

You can see how another library resolved this issue here: https://github.com/bitwalker/distillery/commit/54327922aaf11fd8db39bc17ae798bf7724f6918
The full set of compilation warnings follows:
warning: found quoted atom "insecure_cookie_in_distillery_config" but the quotes are not required. Quotes should only be used to introduce atoms with foreign characters in them
  lib/distillery/lib/cookies.ex:22

warning: "not expr1 in expr2" is deprecated. Instead use "expr1 not in expr2" if you require Elixir v1.5+, or "not(expr1 in expr2)" if you have to support earlier Elixir versions
  lib/mix/lib/releases/appups.ex:207

warning: "not expr1 in expr2" is deprecated. Instead use "expr1 not in expr2" if you require Elixir v1.5+, or "not(expr1 in expr2)" if you have to support earlier Elixir versions
  lib/mix/lib/releases/appups.ex:208

warning: System.stacktrace/0 outside of rescue/catch clauses is deprecated. If you want to support only Elixir v1.7+, you must access __STACKTRACE__ inside a rescue/catch. If you want to support earlier Elixir versions, move System.stacktrace/0 inside a rescue/catch
  lib/mix/lib/releases/errors.ex:68

warning: System.stacktrace/0 outside of rescue/catch clauses is deprecated. If you want to support only Elixir v1.7+, you must access __STACKTRACE__ inside a rescue/catch. If you want to support earlier Elixir versions, move System.stacktrace/0 inside a rescue/catch
  lib/mix/lib/releases/errors.ex:190

warning: System.stacktrace/0 outside of rescue/catch clauses is deprecated. If you want to support only Elixir v1.7+, you must access __STACKTRACE__ inside a rescue/catch. If you want to support earlier Elixir versions, move System.stacktrace/0 inside a rescue/catch
  lib/mix/lib/releases/errors.ex:246

warning: Mix.Config.read!/1 is deprecated. Use eval!/2 instead
  lib/mix/lib/releases/assembler.ex:601

warning: Mix.Dep.loaded/1 is deprecated. Mix.Dep.loaded/1 was private API and you should not use it
  lib/mix/lib/releases/models/app.ex:37

warning: function Mix.Dep.loaded_by_name/2 is undefined or private. Did you mean one of:

      * filter_by_name/2
      * filter_by_name/3
      * loaded/1

  lib/mix/lib/releases/models/app.ex:83

warning: function Mix.Config.Agent.get/1 is undefined (module Mix.Config.Agent is not available)
  lib/mix/lib/releases/config/config.ex:447

warning: function Mix.Config.Agent.stop/1 is undefined (module Mix.Config.Agent is not available)
  lib/mix/lib/releases/config/config.ex:448

warning: variable "expand_dir" is unused
  lib/nerves/artifact.ex:351

Building anything for nerves on elixir 1.7 will require the following PRs
https://github.com/nerves-project/nerves_runtime/pull/72
https://github.com/nerves-project/nerves/pull/316
https://github.com/nerves-project/shoehorn/pull/12

This has been updated and Nerves now supports elixir 1.7


Remove implementation that works with non-negative values only

Also, move preset sketches to DDSketches and deprecate factory methods in DDSketch.

@CharlesMasson what's the motivation for this change? In the tracer team we want to record strictly positive latencies and I have a couple of proofs of concept for more efficient IndexMappings which only work with positive values. It would be awkward to make these work with negative values.

@CharlesMasson what's the motivation for this change? In the tracer team we want to record strictly positive latencies and I have a couple of proofs of concept for more efficient IndexMappings which only work with positive values. It would be awkward to make these work with negative values.

We want to match what we do in other libs, and make it clearer that the sketch can handle negative values (we've seen confusion about it).
I don't think having a sketch that only handles non-negative values brings much benefit. The dense stores don't allocate memory for the count array if they stay empty, and we could even avoid constructing them in DDSketch if they don't receive any values. If we explicitly want to reject negative values or any range of values, we can still easily do it upstream.
Regarding IndexMapping, this PR doesn't introduce any changes, any of its implementations is still expected to work on positive values only.

@CharlesMasson that's fair enough - I had modified the store test to allow an IndexMapping to opt out of testing for negative values. I won't pursue this strategy, since it sounds like I would be cutting against the grain, and will make at least one of the IndexMappings take negative values.
Regarding what do you get from disallowing negative values - nothing if you restrict yourself to arrays with offsets or a map, but 2's complement complicates the prefix compressed IndexMapping I was planning to propose a lot, because it breaks ordering of mixed sign sets.


added the possibility a custom labels

Hi, I have added in this pr the possibility to add a custom label e.g. by
podLabels:
   app: shlink

Thanks for your contribution @AndrzejOlender. Released with v2.13.2

MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable
stuck with this error to add the labels , are we sure it works?


Scheduler Stops after all due dates missed

ex: Setting Daily Scheduler

01-05-2017
02-05-2017
03-05-2017
04-05-2017
05-05-2017

guess if my package got expired , and scheduler stopped working.
so new dates are not generating as scheduler was missed for all dates.

#714 Related Bug

#725 Solves this


Image Pullback of Behind Netskope Proxy

I am running k3d on a macbook and it connects to internet via organization proxy, netskope, it adds its own root certificates on the host, hence the docker pull works fine on host, but when same images are pulled on k3d cluster it would give ImagePullBackoff with following reason for the registries that are not dockerhub.
Failed to pull image "docker.keptn.sh/keptn/api:1.2.0": rpc error: code = Unknown desc = failed to pull and unpack image "docker.keptn.sh/keptn/api:1.2.0": failed to resolve reference "docker.keptn.sh/keptn/api:1.2.0": failed to do request: Head "https://docker.keptn.sh/v2/keptn/api/manifests/1.2.0": x509: certificate signed by unknown authority

Running into the same issue, is there any solution?

Hey there!
I guess this may help: https://k3d.io/stable/faq/faq/#running-behind-a-corporate-proxy
Let me know if that doesn't work out for you.

@iwilltry42 in my case the corporate MDM agent installed a certificate and used it to access the internet which wasn’t available on the k3d container, identifying it and mounting it on proper paths along with the root cert bundle worked

@drpdishant can you describe the exact steps you took?


openssl pkeyutl -verifyrecover no longer working for RSA

After commit https://github.com/openssl/openssl/commit/1ee906143c0b0ebb6bcbeb87277833a665e79836 using the openssl pkeyutl with -verifyrecover using an RSA key fails with Error: The non-raw input data length 128 is too long - max supported hashed size is 64. That commit now also performs the check for EVP_PKEY_OP_VERIFYRECOVER.
For an RSA sign processing, the input of course must be less than EVP_MAX_MD_SIZE. However, the signature output is then RSA modulus size (i.e. 128 bytes for an RSA 1024 bit key).
For the subsequent -verifyrecover the signature is then specified with the -in option. From the man page https://docs.openssl.org/master/man1/openssl-pkeyutl/;
Recover the signed data (e.g. if an RSA key is used):

openssl pkeyutl -verifyrecover -in sig -inkey key.pem

So for an RSA -verifyrecover the input is thus the RSA modulus size, i.e. 128 bytes for an RSA 1024 bit key. This is of course larger than EVP_MAX_MD_SIZE, but this is totally valid for -verifyrecover with RSA.
I did try to use -sigfile instead of -in with -verifyrecover, but this results in pkeyutl: Signature file specified for non verify. Similar, using -rawin in combination with -in results in pkeyutl: -digest and -rawin can only be used with -sign or -verify.
So in my opinion, the input length should not be checked for -verifyrecover, only for regular sign and verify (as it was before that commit).

@DDvO fyi. This might also be related to https://github.com/openssl/openssl/pull/25831.

After commit 1ee9061 using the openssl pkeyutl with -verifyrecover using an RSA key fails with Error: The non-raw input data length 128 is too long - max supported hashed size is 64. That commit now also performs the check for EVP_PKEY_OP_VERIFYRECOVER.

Oh, right, this is a bug.
We have been confused by the -in option having a different meaning for -verifyrecover than for -verify.
Moreover, I just noticed that the documentation of the  -verifyrecover option is wrong, saying:
Verify the input data (which must be a hash)

because, as you correctly pointed out, it must be the result of a signing operation,
and this may be longer than a digest, depending on the key type and size.

I did try to use -sigfile instead of -in with -verifyrecover, but this results in pkeyutl: Signature file specified for non verify.

Yeah, it would have been better if -verifyrecover had used the -sigfile instead of -in for its signature input.

Similar, using -rawin in combination with -in results in pkeyutl: -digest and -rawin can only be used with -sign or -verify.

That's intentional and correct, because the signature out does not combine with hashing.

Code fix is in #25903.

Related doc fixes I noticed on this occasion have become part of #25831.


sed() should accept multiple file arguments

Unix sed accepts multiple files. Is there a reason ShellJS's sed doesn't, or has just nobody gotten around to it yet?

I think this just hasn't been implemented yet. This sounds like it would make sense to have.
Right now sed() seems to return the modified text. I think, for the sake of backwards compatibility, if a single file is passed in, this should stay the behavior.
If multiple the files foo.txt and bar.txt are passed in that order, then I think the output should be an array along the lines of [ modified foo.txt, modified bar.txt ].
Would that be sufficient for your uses?

Yes; I have no need for the return value.

Sounds like a useful thing to me. I'm going to look into how this might be supported and see if I can make a PR. For now, though, your best bet is probably to use multiple sed() commands in a forEach loop. See the snippet taken from the README:

ls('*.js').forEach(function(file) {
  sed('-i', 'BUILD_VERSION', 'v0.1.2', file);
  sed('-i', /.*REMOVE_THIS_LINE.*\n/, '', file);
  sed('-i', /.*REPLACE_LINE_WITH_MACRO.*\n/, cat('macro.js'), file);
});

@cvrebert this should be resolved in #314. It'll work similarly to how grep() currently works. All output in one string, and each file gets replaced individually if the -i flag is passed.


[PLAT-7903] Improve in-Editor behaviour

Goal
Now that Bugsnag functionality is enabled for macOS, opening a project in Unreal Editor will also start Bugsnag in that process.
The aim of this PR is to avoid sending spurious errors and sessions.
Changeset

Ignores crashes that occur in the Editor outside of a PIE session, to avoid sending non-game related crashes to the dashboard. This records the state of GIsPlayInEditorWorld at crash time to determine whether the game was being played. Note that crashes that were caused by game code but occurred after play ended (e.g. if there some delay before the crash happening) will be ignored.

Disables automatic session tracking in the Editor, to avoid skewing session stability scores.

Disables app hang detection in the Editor, since any hangs are likely to be caused by the Editor whose UI regularly becomes unresponsive when starting builds etc.

Disables the "Start Automatically" functionality if GIsBuildMachine indicates running in a build machine process.

Implementation notes:

UE_EDITOR is 1 when building for the Editor
GIsEditor is false when the Editor is running a game using the -game command line switch
GIsPlayInEditorWorld is set to true when the Editor starts playing a game in-process (i.e. with the Play button)

Testing
Tested locally by running sample project in Editor, -game mode and stand-alone build while examining logs and network requests.

4. Disables the "Start Automatically" functionality if `GIsBuildMachine` indicates running in a build machine process.

The reasoning seems sound to me though I don't quite understand this bit.  I'm missing context but why would we only prevent automatic starting and not all operation in this mode?

The reasoning seems sound to me though I don't quite understand this bit. I'm missing context but why would we only prevent automatic starting and not all operation in this mode?

We could go further and prevent Bugsnag being starting in build machine mode. This is the bit I'm least sure about.

After discussion with @gareththackeray we have agreed to remove the GIsBuildMachine checks because we don't really understand enough about the use case of this mechanism.


TASK: Handle empty default values in AbstractFinisher

Checks if the final value, after resolving {...}s, is an empty string
and returns null.

@futape Thanks for this contribution!
From reading the code and Commit message I find it quite hard to realize what exactly this change solves though and if it might pose some breaking change. Could you elaborate and/or add a test?

sorry for the delay.
i opened an issue: #75

@bwaidelich ping on this one…

Thanks for pinging. I assigned myself and will look into this one asap


Run this project in Android Studio

Questions

Was this app developed in android studio, it is giving me several errors no matter my high computer specs and good internet?
There are many random folders in the parent folder, is this an android project?

I always use IntelliJ IDEA as Android Studio always lags behind on multiplatform support. But the project hasn't been touched in years, so it's unlikely to import without build changes to update to the latest of things. Google likes to break the data source and I got tired of dealing with it.
The folders are not random. The project is modularized. Each one has a specific purpose.

Thanks for the clarification @JakeWharton 👍, this was a nice idea but looks like google likes playing hide and seek, too bad


chore(plugins): replace deprecated CNI function

This pull request replaces the deprecated skel.PluginMain with its skel.PluginMainFuncs counterpart It adds a new function to the Cmd structure to convert the CNI methods into a standardized structure that can be passed to skel.PluginMain
If the CNI vendored repo is updated, there's a few other deprecated items introduced that could be cleaned aswell.

/test


Use new eachrow and eachcol

Now that https://github.com/JuliaLang/julia/pull/29749 has been merged, we can use for row in eachrow(M) and for col in eachcol(M) etc., instead of for i in axes(M, 2), M[:, i] or whatever.
Will need to get this pre-compatted first though, unless we use Julia 1.1

Also eachslice(M, dims) for arbitrary sizes.


docker logs mina

docker exec -it mina coda client stop-daemon script does not work and the process ends. what is the reason?

my output

my output

stop coda, remove and recreate .coda-config folder, restart it.

stop coda, remove and recreate .coda-config folder, restart it.


[BUG] Generated code attempts to modify const field

Describe the bug
I tried to build pyarrow with the 3.0b1 release of cython.  I received some errors that I do not receive with earlier versions (0.29.x) of cython.
Code to reproduce the behaviour:
    @property
    def dim_names(self):
        return tuple(frombytes(x) for x in tuple(self.stp.dim_names()))

(source)
Supplementary definitions:
# self.stp.dim_names() calls this C++ function (defined elsewhere in a pxd):
const vector[c_string]& dim_names()

frombytes is probably not relevant but it converts a C++ string to a python str.
Expected behaviour
I expect the function to build fine and return a list of strings.
OS
Linux
Python version
3.11.0
Cython version
3.0b1
Additional context
The generated function is:
		/* "pyarrow/tensor.pxi":556
 *     @property
 *     def dim_names(self):
 *         return tuple(frombytes(x) for x in tuple(self.stp.dim_names()))             # <<<<<<<<<<<<<<
 *
 *     @property
 */

                static PyObject *__pyx_pf_7pyarrow_3lib_15SparseCOOTensor_9dim_names_7__get___genexpr(CYTHON_UNUSED PyObject *__pyx_self, std::vector<std::string>  const __pyx_genexpr_arg_0) {
                  struct __pyx_obj_7pyarrow_3lib___pyx_scope_struct_15_genexpr *__pyx_cur_scope;
                  PyObject *__pyx_r = NULL;
                  __Pyx_RefNannyDeclarations
                  int __pyx_lineno = 0;
                  const char *__pyx_filename = NULL;
                  int __pyx_clineno = 0;
                  __Pyx_RefNannySetupContext("genexpr", 0);
                  __pyx_cur_scope = (struct __pyx_obj_7pyarrow_3lib___pyx_scope_struct_15_genexpr *)__pyx_tp_new_7pyarrow_3lib___pyx_scope_struct_15_genexpr(__pyx_ptype_7pyarrow_3lib___pyx_scope_struct_15_genexpr, __pyx_empty_tuple, NULL);
                  if (unlikely(!__pyx_cur_scope)) {
                    __pyx_cur_scope = ((struct __pyx_obj_7pyarrow_3lib___pyx_scope_struct_15_genexpr *)Py_None);
                    __Pyx_INCREF(Py_None);
                    __PYX_ERR(6, 556, __pyx_L1_error)
                  } else {
                    __Pyx_GOTREF((PyObject *)__pyx_cur_scope);
                  }
                  __pyx_cur_scope->__pyx_genexpr_arg_0 = __pyx_genexpr_arg_0;
                  {
                    __pyx_CoroutineObject *gen = __Pyx_Generator_New((__pyx_coroutine_body_t) __pyx_gb_7pyarrow_3lib_15SparseCOOTensor_9dim_names_7__get___2generator17, NULL, (PyObject *) __pyx_cur_scope, __pyx_n_s_genexpr, __pyx_n_s_SparseCOOTensor___get___locals_g, __pyx_n_s_pyarrow_lib); if (unlikely(!gen)) __PYX_ERR(6, 556, __pyx_L1_error)
                    __Pyx_DECREF(__pyx_cur_scope);
                    __Pyx_RefNannyFinishContext();

The referenced struct is:
/* "pyarrow/tensor.pxi":556
 *     @property
 *     def dim_names(self):
 *         return tuple(frombytes(x) for x in tuple(self.stp.dim_names()))             # <<<<<<<<<<<<<<
 *
 *     @property
 */
struct __pyx_obj_7pyarrow_3lib___pyx_scope_struct_15_genexpr {
  PyObject_HEAD
  std::vector<std::string>  const __pyx_genexpr_arg_0;
  PyObject *__pyx_v_x;
  PyObject *__pyx_t_0;
  Py_ssize_t __pyx_t_1;
};

The line that fails is:
__pyx_cur_scope->__pyx_genexpr_arg_0 = __pyx_genexpr_arg_0;

The error is:
/home/pace/dev/arrow/python/build/temp.linux-x86_64-cpython-311/lib.cpp: In function ‘PyObject* __pyx_pf_7pyarrow_3lib_15SparseCOOTensor_9dim_names_7__get___genexpr(PyObject*, std::vector<std::__cxx11::basic_string<char> >)’:
/home/pace/dev/arrow/python/build/temp.linux-x86_64-cpython-311/lib.cpp:161732:58: error: passing ‘const std::vector<std::__cxx11::basic_string<char> >’ as ‘this’ argument discards qualifiers [-fpermissive]
161732 |                   __pyx_cur_scope->__pyx_genexpr_arg_0 = __pyx_genexpr_arg_0;
       |                                                          ^~~~~~~~~~~~~~~~~~~
In file included from /usr/include/c++/11/vector:72,
                 from /home/pace/miniconda3/envs/conbench3/include/arrow/array/array_base.h:24,
                 from /home/pace/miniconda3/envs/conbench3/include/arrow/array.h:41,
                 from /home/pace/miniconda3/envs/conbench3/include/arrow/pch.h:23,
                 from /home/pace/dev/arrow/python/pyarrow/src/arrow/python/pch.h:23,
                 from /home/pace/dev/arrow/python/build/temp.linux-x86_64-cpython-311/CMakeFiles/lib.dir/cmake_pch.hxx:5,
                 from <command-line>:
/usr/include/c++/11/bits/vector.tcc:198:5: note:   in call to ‘std::vector<_Tp, _Alloc>& std::vector<_Tp, _Alloc>::operator=(const std::vector<_Tp, _Alloc>&) [with _Tp = std::__cxx11::basic_string<char>; _Alloc = std::allocator<std::__cxx11::basic_string<char> >]’
  198 |     vector<_Tp, _Alloc>::
      |     ^~~~~~~~~~~~~~~~~~~

If you want a short-term fix, I think it'll work if you split it into two lines:
names_tuple = tuple(self.stp.dim_names()
return tuple(frombytes(x) for x in names_tuple)

Should be fairly straightforward to fix in Cython though.
I also think there should be a std::move in __pyx_cur_scope->__pyx_genexpr_arg_0 = __pyx_genexpr_arg_0; although there might be a reason I didn't do that.

Thank you for the suggestion.  The workaround does work.  I don't think there will be a problem leaving it in so there is no rush to fix this issue on our account.

So I'm struggling to reproduce this with a cutdown example:
# distutils: language=c++

from libcpp.vector cimport vector
from libcpp.string cimport string

cdef extern from *:
    """
    #include <vector>

    const std::vector<std::string>& getVec() {
        static std::vector<std::string> x = {"1", "2", "3"};
        return x;
    }
    """
    const vector[string]& getVec() except+

def from_bytes(x):
    return x

def f():
    return tuple(from_bytes(x) for x in tuple(getVec()))

__pyx_genexpr_arg_0 seems to be a "fake-reference" rather than a copy, so I'm not quite sure what I have to do to force it to make a copy.
I can definitely run into other bugs - if you remove the tuple then it does . rather than -> on the fake reference (so fails). If you fix that then it struggles because it tries to assign a const_iterator to an iterator (although this is also the case in Cython 0.29.x so not a regression). So it's definitely a little fragile, but I can't easily get to the exact bug reported

I don't know if it matters but the main difference I see between your standalone example and the real thing is that you have getVec as a static function and in the real thing it is a class member function.  E.g.
    cdef cppclass CTensor" arrow::Tensor":
        shared_ptr[CDataType] type()

The f function also belongs to a class and it has a variable self.stp of type const CTensor*.  So then we get:
def f(self):
    return tuple(from_bytes(x) for x in tuple(self.stp.getVec()))

This isn't urgent or high priority for us.  The workaround handles this well.  So I don't know if I will have time to experiment with it much.

https://github.com/cython/cython/commit/37756faa8353e506842e12c7dcb5fcf586a5eec6


fix(atomic): fix .side-by-side container alignment

https://coveord.atlassian.net/browse/KIT-586

What does this change, in the page? Typically, I would expect a side-by-side helper to align vertically at the top of the parent container, not vertically centered.

It's a matter of personal taste I guess. These are just in the "sample index.html" page. Most likely will change soon anyway.


DropdownMenu: add nav category to replace links

This change: (check at least one)

[ ] Adds a new feature
[ ] Fixes a bug
[x] Improves maintainability
[ ] Improves documentation
[ ] Is a release activity

Is this a breaking change? (check one)

[ ] Yes
[x] No

Is the: (complete all)

[ ] Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
[ ] Test suite(s) passing?
[ ] Code coverage maximal?
[ ] Changeset added?
[ ] Component status page up to date?

What does this change address?
Possibly resolves #323 and possibly resolves #354
How does this change work?
Caveat: This relies on consumers to not use PharosDropdownMenuNavLink but instead use PharosDropdownMenuNavHeading or anything else really.
Not sure if we can or would like to restrict what elements could be used in that slot

I will check with the design folks @daneah -- stay tuned

@daneah I thought the nav heading has a carat that shows when something is a dropdown?

@chrisjbrown this looks like it could have legs to me; I think we do want to look further into the constraints you call out because ideally the developer will come away only having ~one right way to construct nav items (whether links or dropdowns). One way to do this might be to make the slot in the new component a named slot, so that only explicitly giving it the right name will properly render the dropdown content.
Aside: I think the use of the word Heading here serves to confuse when compared to actual headings that result in e.g. <h1> being rendered. You might consider DropdownMenuNavCategory or DropdownMenuNavLabel or some such.
@fswlee might you or other design folks have additional ideas? The purpose being to distinguish the pattern of "a thing that shows up and when hovered over shows a dropdown of links" (kind of like one of the two duties DropdownMenuNavLink currently serves) from the pattern of "I am a link directly in the nav that you can click on" (the think DropdownMenuNavLink will be going forward).

added the slot name (i think correctly)
still not terribly restrictive. but i don't really see a way to restrict slots to certain types 🤔

able to solve the AT click issue by using the private hasHover variable here
45360d2b71fe8b074f61b57d1205e9f13d5be448
though this exposed another issue where menu items are not being read correctly when navigating too them.
we suspect this may be caused by improper use of the role attribute. we're going to explore why that may be and if we can correct that in this PR
https://www.w3.org/WAI/ARIA/apg/patterns/menubar/examples/menubar-navigation/

able to solve the AT click issue by using the private hasHover variable here 45360d2
though this exposed another issue where menu items are not being read correctly when navigating too them. we suspect this may be caused by improper use of the role attribute. we're going to explore why that may be and if we can correct that in this PR https://www.w3.org/WAI/ARIA/apg/patterns/menubar/examples/menubar-navigation/

The issue exposed by this fix appears only to affect Chrome on both macOS and Windows. Both Safari and Firefox appear to work while using VoiceOver, announcing the menu item name as expected. While using Chrome, it appears that VoiceOver, JAWS, or NVDA are not able to properly calculated the menu items name.
It's not clear but the Dropdown Menu component works as expected, however the Dropdown Menu Nav does not. There may be an issue with how the Chrome browser is building the accessibility tree, which may make this issue difficult to fix.

Based on some further testing and research, this appears to be an issue with how Chrome is parsing the specific menu option name and I will be submitting an issue to them directly.
With that said, I believe the fix made with this change is a significant enough improvement over the current navigation menu that I recommending moving forward with it and noting the potential issues some users may have.


Gnosis safe connector should only automatically connect inside safe iframe

If you were connected to the snapshot app outside the Safe, it keeps the connection with the previous wallet.
We ask apps to auto-connect to the Safe when loaded in the Safe app context to minimize possible human errors.

After connecting using the Gnosis-safe connector the app no longer lets the user change wallet when outside of the Gnosis-safe iframe, it will get stuck on infinite loading.

Continued https://github.com/snapshot-labs/lock/issues/29


Excel: Use more fitting aliases for function-name, range, cell

function-name: Changed alias from keyword to builtin
range and cell: Changed alias from property to selector

Thank you!


Catch OutOfMemoryError and set imageView GONE

On a few devices, I've received an OutOfMemoryError exception crashing the app when setting the ImageResource.
Porposing to catch the out of memory exception and hiding the image rather than crashing the device.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

travis ci build failed due to a configuration issue on the build instance: the license hasn't been accepted for ConstraintLayout v1.0.2
File /home/travis/.android/repositories.cfg could not be loaded.
Checking the license for package Solver for ConstraintLayout 1.0.2 in /usr/local/android-sdk/licenses
Warning: License for package Solver for ConstraintLayout 1.0.2 not accepted.
Checking the license for package ConstraintLayout for Android 1.0.2 in /usr/local/android-sdk/licenses
Warning: License for package ConstraintLayout for Android 1.0.2 not accepted.
FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring project ':app'.

Could not resolve all dependencies for configuration ':app:_debugApk'.
A problem occurred configuring project ':library'.
You have not accepted the license agreements of the following SDK components:
[ConstraintLayout for Android 1.0.2, Solver for ConstraintLayout 1.0.2].
Before building your project, you need to accept the license agreements and complete the installation of the missing components using the Android Studio SDK Manager.
Alternatively, to learn how to transfer the license agreements from one workstation to another, go to http://d.android.com/r/studio-ui/export-licenses.html

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 33.656 secs
The command "./gradlew build connectedCheck" exited with 1.
Done. Your build exited with 1.

@MFlisar Could you please merge https://github.com/joeykrim/material-intro/pull/1 to fix issues with the Travis CI build?

Hello, new maintainer here! Thanks for your PR; I realize that some time has passed since this PR was last proposed, so I certainly understand if you are no longer able to devote time to this, but if you are able to, I would love to see the comments addressed. Of course, I fully understand if you are not able to — could you please let me know either way? I am hoping to close any pending open PRs before cutting a new release. Thanks!

@joeykrim Could you please merge joeykrim#1 to fix issues with the Travis CI build?

Hello, new maintainer here! Thanks for your PR; I realize that some time has passed since this PR was last proposed, so I certainly understand if you are no longer able to devote time to this, but if you are able to, I would love to see the comments addressed. Of course, I fully understand if you are not able to — could you please let me know either way? I am hoping to close any pending open PRs before cutting a new release. Thanks!

Done - let me know if there's anything else to be done to merge


Fixed#24690 - Add ArrayField Mutable Default Warning

Add ArrayField Mutable Default Warning

The idea is that you should not use mutable defaults in the first place. For example, default=list instead of default=[].

It would be useful here to explain things in a bit more detail. What happens if I actually want the default to be ['hello'] rather than an array? An answer is to pass it as lambda: ['hello']. This (as the default=list case) relies on the fact callable defaults are evaluated. An alternative would be to pass a tuple, but this means a newly instantiated object which hasn't had a round trip to the db would have an immutable value, which may easily cause bugs.
In any case, a link to the docs for field defaults seems appropriate.

Updated in https://github.com/django/django/pull/5078.


Updating Websocket readyState in case of websocketFailed event

Fix for https://github.com/facebook/react-native/issues/9465
We are building a react-native based application which extensively uses WebSockets. The Android app crashes right after waking up being in suspended mode for a coupe of days and throws an exception:
"Cannot send a message. Unknown WebSocket id 1"
Before calling WebSocket.send(...) method from WebSocket.js we always check its readyState. I believe the problem is caused by not updating readyState if case of 'websocketFailed' event. this.close() cause the current used websocket ID to be removed from mWebSocketConnections HashMap (WebSocketModule.java), but readyState stays the same.

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@tepamid updated the pull request - view changes

@tepamid updated the pull request - view changes

This fix seems reasonable, as we already set the readyState in case of the close event.
@satya164 What do you think?
@facebook-github-bot shipit


Payload size must be limited on slow connections due to Cumulocity server disconnects.

Over "slow" connections e.g., cellular, Cumulocity sever will consistently drop connections when a payload is over a certain size. Through testing we find this size limit to be roughly 2kB. However, this is an observation of a single device, and we have not quantified what exactly constitutes a  "slow connection".
Furthermore, the server stops responding, but keeps the TCP keep alive. So the client depends on the MQTT keep alive to know if the connection is disconnected.

@it-hms, Do you think this is/was related to a mismatch between MTUs?
I'm not sure we have encountered similar issues otherwise, and it might be difficult to implement this without having a defined metric for what is considered a slow network (which could also vary greatly from device to device).

@it-hms, Do you think this is/was related to a mismatch between MTUs?
I'm not sure we have encountered similar issues otherwise, and it might be difficult to implement this without having a defined metric for what is considered a slow network (which could also vary greatly from device to device).

This is likely related to MTU size. We can close this issue.


Support arrays

It currently isn't possible to add additional fields of an array type.
For example, this:
log4j.appender.graylog2.additionalFields={'tags': ['first_tag', 'next_tag', 'some_tag']}

leads to this:
Caused by: java.lang.ClassCastException: org.json.simple.JSONArray cannot be cast to java.lang.String
It would be nice, if the appender would support that.

@dploeger The GELF specification doesn't support arrays, so it wouldn't be too useful if gelfj emitted them.

Erm, okay. I'm a bit stumped, that it works, though. 😊 Thanks.


Case insensitive routes using react-router-config

Recently the sensitive flag was added, but it seems that it is not possible to set this flag when building routes using react-router-config.

It is. You'll use the extraProps or switchProps to do this: https://github.com/ReactTraining/react-router/blob/master/packages/react-router-config/modules/renderRoutes.js#L5

extraProps are passed to the child component, not to the Route component.
To be clear, I'm talking about the flag added by PR #5438. It's comparable to the exact, strict flags.

Then switchProps can be used when that is released.
A good PR might be to simplify things by just passing all the options on the route object to the <Route> as direct props, not a subset of them.

It looks like renderRoutes is manually passing strict and exact, so it needs to be updated to also pass sensitive. @jaap3 a PR that makes this change would be appreciated (with a test, please).
matchRoutes already just passes the route object to matchPath, so it doesn't need any changes.

6 months and no update... :cry:

Thanks for re-opening this, @pshrmn.

A good PR might be to simplify things by just passing all the options on the route object to the  as direct props, not a subset of them.

I agree @timdorr, we should probably just spread the route object as props to the <Route> component so it transparently supports all the same props.


jam write

Codecov Report

Merging #80 into master will increase coverage by 15.65%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #80       +/-   ##
==========================================
+ Coverage   41.54%   57.2%   +15.65%
==========================================
  Files           9       9
  Lines        1201    1208        +7
==========================================
+ Hits          499     691      +192
+ Misses        641     428      -213
- Partials       61      89       +28

Impacted Files
Coverage Δ

lib/msgapi/jam.go
60.25% <88.88%> (+59.28%)
:arrow_up:

lib/msgapi/squish.go
72.49% <0%> (+1.48%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af7ecd...eb18701. Read the comment docs.