perception and traffic light module error

Note: If you have a general support question and are looking for a quicker response, please checkout our discord channel for answers from the community:
https://bbs.carla.org.cn/ask
In what area(s)?

/area runtime

/area operator

/area placement

/area docs

/area test-and-release

Ask your question here
when i start the traffic light module and transform module, the traffic light module will be core dumped. the log in traffic light is:

the transform log is:

I also meet this question, seems that in apollo8.0, the traffic light module works normally but need transfer the result into apollo. And in apollo7.0, the  traffic light module didn't work

I also meet this question, seems that in apollo8.0, the traffic light module works normally but need transfer the result into apollo. And in apollo7.0, the traffic light module didn't work

thanks a lot！ In apollo8.0, the trafficlight module will report the error:
[�[1;34m/apollo/bazel-bin/modules/dreamview/dreamview --flagfile=/apollo/modules/common/data/global_flagfile.txt�[0m] �[1;34m �[m�[0;31mE1009 09:35:22.601780 736240 trafficlights_perception_component.cc:704] [perception]Can not find transform.<PHONE_NUMBER>.575453043 frame_id: world child_frame_id: novatel Error info: Lookup would require extrapolation into the future.  Requested time<PHONE_NUMBER>575452928 but the latest data is at time<PHONE_NUMBER>574592000, when looking up transform from frame [novatel] to frame [world]:timeout�[0m
[�[1;34m/apollo/bazel-bin/modules/dreamview/dreamview --flagfile=/apollo/modules/common/data/global_flagfile.txt�[0m] �[1;34m �[m�[0;31mE1009 09:35:22.601823 736240 trafficlights_perception_component.cc:670] [perception]get pose from tf failed, child_frame_id: novatel�[0m

Have you met this problem?

你好我直接用中文吧，我这里也不是很确定，但我感觉是perception在处理的时候遇到了时间同步问题。Apollo系统尝试查找novatel和world之间的坐标变换，但请求的时间戳（1728437722575452928）比当前数据中已有的最新时间戳（1728437722574592000）要大，导致查找失败。

I also meet this question, seems that in apollo8.0, the traffic light module works normally but need transfer the result into apollo. And in apollo7.0, the traffic light module didn't work

thanks a lot！ In apollo8.0, the trafficlight module will report the error:
[�[1;34m/apollo/bazel-bin/modules/dreamview/dreamview --flagfile=/apollo/modules/common/data/global_flagfile.txt�[0m] �[1;34m �[m�[0;31mE1009 09:35:22.601780 736240 trafficlights_perception_component.cc:704] [perception]Can not find transform.<PHONE_NUMBER>.575453043 frame_id: world child_frame_id: novatel Error info: Lookup would require extrapolation into the future.  Requested time<PHONE_NUMBER>575452928 but the latest data is at time<PHONE_NUMBER>574592000, when looking up transform from frame [novatel] to frame [world]:timeout�[0m
[�[1;34m/apollo/bazel-bin/modules/dreamview/dreamview --flagfile=/apollo/modules/common/data/global_flagfile.txt�[0m] �[1;34m �[m�[0;31mE1009 09:35:22.601823 736240 trafficlights_perception_component.cc:670] [perception]get pose from tf failed, child_frame_id: novatel�[0m

Have you met this problem?

你好我直接用中文吧，我这里也不是很确定，但我感觉是perception在处理的时候遇到了时间同步问题。Apollo系统尝试查找novatel和world之间的坐标变换，但请求的时间戳（1728437722575452928）比当前数据中已有的最新时间戳（1728437722574592000）要大，导致查找失败。

是否能够加您的联系方式？您是否有对桥的代码进行修改？

I also meet this question, seems that in apollo8.0, the traffic light module works normally but need transfer the result into apollo. And in apollo7.0, the traffic light module didn't work

thanks a lot！ In apollo8.0, the trafficlight module will report the error:
[�[1;34m/apollo/bazel-bin/modules/dreamview/dreamview --flagfile=/apollo/modules/common/data/global_flagfile.txt�[0m] �[1;34m �[m�[0;31mE1009 09:35:22.601780 736240 trafficlights_perception_component.cc:704] [perception]Can not find transform.<PHONE_NUMBER>.575453043 frame_id: world child_frame_id: novatel Error info: Lookup would require extrapolation into the future.  Requested time<PHONE_NUMBER>575452928 but the latest data is at time<PHONE_NUMBER>574592000, when looking up transform from frame [novatel] to frame [world]:timeout�[0m
[�[1;34m/apollo/bazel-bin/modules/dreamview/dreamview --flagfile=/apollo/modules/common/data/global_flagfile.txt�[0m] �[1;34m �[m�[0;31mE1009 09:35:22.601823 736240 trafficlights_perception_component.cc:670] [perception]get pose from tf failed, child_frame_id: novatel�[0m

Have you met this problem?

你好我直接用中文吧，我这里也不是很确定，但我感觉是perception在处理的时候遇到了时间同步问题。Apollo系统尝试查找novatel和world之间的坐标变换，但请求的时间戳（1728437722575452928）比当前数据中已有的最新时间戳（1728437722574592000）要大，导致查找失败。

另外，我在apollo8.0上运行traffic和perception，在transform模块运行的情况下会核心段崩溃，您有遇到过吗？

I also meet this question, seems that in apollo8.0, the traffic light module works normally but need transfer the result into apollo. And in apollo7.0, the traffic light module didn't work

thanks a lot！ In apollo8.0, the trafficlight module will report the error:
[�[1;34m/apollo/bazel-bin/modules/dreamview/dreamview --flagfile=/apollo/modules/common/data/global_flagfile.txt�[0m] �[1;34m �[m�[0;31mE1009 09:35:22.601780 736240 trafficlights_perception_component.cc:704] [perception]Can not find transform.<PHONE_NUMBER>.575453043 frame_id: world child_frame_id: novatel Error info: Lookup would require extrapolation into the future.  Requested time<PHONE_NUMBER>575452928 but the latest data is at time<PHONE_NUMBER>574592000, when looking up transform from frame [novatel] to frame [world]:timeout�[0m
[�[1;34m/apollo/bazel-bin/modules/dreamview/dreamview --flagfile=/apollo/modules/common/data/global_flagfile.txt�[0m] �[1;34m �[m�[0;31mE1009 09:35:22.601823 736240 trafficlights_perception_component.cc:670] [perception]get pose from tf failed, child_frame_id: novatel�[0m

Have you met this problem?

你好我直接用中文吧，我这里也不是很确定，但我感觉是perception在处理的时候遇到了时间同步问题。Apollo系统尝试查找novatel和world之间的坐标变换，但请求的时间戳（1728437722575452928）比当前数据中已有的最新时间戳（1728437722574592000）要大，导致查找失败。

是否能够加您的联系方式？您是否有对桥的代码进行修改？

@JasonBourne1998 你好，能帮忙看一下嘛？


Feature Request: import and export of config

Suggestion: config for the editor
I am working on a presentation and I am using Carbon for make the code look better but I need to setup all the time the look like of the "terminal" but i work on it in my free time so sometime i close all and work on other project and lost the config or part of it.
Is a bad idea to put an import/export of the config or something similare into Carbon?

I'd be happy to work on this aswell if no one takes it. 😄

Your config should be being saved to localStorage. Is the config not being saved for you?

Not always. Sometime I open the browser and Carbon has the default config

@fundor333 localStorage can only hold data up to a certain limit. Let's say you have 2 apps, and one extension that make use of localStorage and let's say your extension has full control over the size limit cap on localStorage. Then, it can potentially override data from other apps/extensions if it wanted to. This is true in case of Chrome; I'm not sure if the case holds for other browsers too.

What if we can upload a .json file (and it get saved in localStorage until a newly uploaded file overrides) which includes the settings and then carbon read the file and show (in a select widget) which settings ["latest-preset", "presentation"] you want to choose and carbon apply those settings.
Example of .json file
{
  "latest-preset": {
    "t": "base16-light",
    "bg": "none",
    "wt": "none",
    "wc": true,
    "fm": "Inconsolata",
    "fs": "18px",
    "ln": true,
    "ds": true,
    "dsyoff": "3px",
    "dsblur": "5px",
    "wa": true,
    "pv": "15px",
    "ph": "15px",
    "si": false,
    "wm": false,
    "es": "2x",
    "type": "png"
  },
  "presentation": {
    "t": "base16-light",
    "bg": "none",
    "wt": "none",
    "wc": true,
    "fm": "Inconsolata",
    "fs": "18px",
    "ln": true,
    "ds": true,
    "dsyoff": "3px",
    "dsblur": "5px",
    "wa": true,
    "pv": "15px",
    "ph": "15px",
    "si": false,
    "wm": false,
    "es": "2x",
    "type": "png"
  }
}

With the help of this feature, we can get more beautiful default theme created by users.

This 💡 is taken from carbon-now-cli, thanks to @mixn.

I love the idea, @mittalyashu. This would be great.

Right. I always thought you would just drop in a new json file which would immediately update the settings (including localStorage). No need to keep two copies.

I'm also working on a presentation, and it'd be nice to be able to download the config and store it in my presentation so I can load it when switching between computers


Removed time units

Summary
Addressing #99.
Details and comments
Unlike the suggestion in https://github.com/Qiskit/qiskit-ignis/issues/99#issuecomment-468894857, I prefer to remove any mention of time units altogether, assuming that it is self-evident that the user fixes the unit and remains consistent with it. Let me know and I'll fix if this is not good.
Still in progress because need to re-execute two notebooks. But other than these notebook re-executions, this is ready.

Fixed notebooks, so entirely ready now, removed WIP from title.

Could you please help with Travis' complaint that Python 3.6 fails, while 3.5 and 3.7 do pass. This is curious, considering that myself I work on Linux with Python 3.6 ...

After discussing with Yael, we'll keep the time units and will let the users control it some way or anther, though the first design (for delivery tomorrow) may not be the final

The gate cals are versus number of gates, they don't have a concept of time


Unified Input/Output Rules

Right now Surya has some mixed input/output rules. I propose unifying them to a common format.
For output, I suggest sending everything to stdout. For input, we should extend the rules Surya already has. Here is the current output from surya --help:
surya <cmd> [args]

Commands:
  surya describe <files..>                  show file contracts structure.
  surya graph <files..>                     generate graph of contract function
                                            calls.
  surya inheritance <files..>               generate graph of contract
                                            inheritance tree.
  surya dependencies <target_contract>      output a linearized list of smart
  <files..>                                 contract dependencies (linerized
                                            inherited parents).
  surya parse <file>                        output AST generated by the parser
                                            for the specified file in a textual
                                            tree format.
  surya ftrace <function_identifier>        output the selected function call
  <function_visibility_restrictor>          trace in a textual tree format.
  <files..>                                 External calls are marked in
                                            `orange` and internal calls are
                                            `uncolored`.
  surya mdreport <outfile> <infiles..>      output a markdown file

Options:
  -h, --help     Show help                                             [boolean]
  -v, --version  Show version number                                   [boolean]

For a new format I would suggest we use the following convention across all of Surya's operations
input
surya <cmd> infile1.sol infile2.sol ...
output
stdout

Agreed! :) I'm just talking about the syntax for reading commands into Surya.
So it would look something like this:
surya parameter1 parameter2 parameter3
``

|  surya |  parameter1 | parameter2 | parameter3  | parameter4  |
|---|---|---|---|---|
|  surya |  mdreport | files  |   |   |
| surya  | describe  | files  |   |   |
| surya  | graph  |  files |   |   |
|  surya | inheritance  |  files |   |   |
|  surya | parse  | files  |   |   |
|  surya | dependencies  | files  | target  |   |
|  surya | ftrace  |  files |  identifier | visibilityRestrictor  |

The reason why this is hard is because the variably sized parameter () has to go in the end, otherwise, there's no clear rule as to how to process the next ones. 😞

真的吗

@tcsiwula
Spam?


Simplify tikhonov exercise, solution only initially.

Suggested final version of Tikhonov exercise notebook (so far only solution notebook, will update the exercise itself, once the solution notebook is settled).

The spelling 'Regularisation' and 'Regularization' are both used (as are regulariser and regularisation)
Add legend to centre line plots add the argument label='xxx' to each plot set up, then show the key with: plt.legend()
The identity regularised Tikhonov should run over the data sinogram_noisy by default
I would consider removing the coding exercise 2 from identity regularised Tikhonov as you ask for the same coding input from the Gradient regularised Tikhonov in exercise 3.
Instead I would give them Tikhonov as a working example with a new exercise 2 which will have them change the noise level and directly compare CGLS and Tikonov. It would simply be a link back to the noisy sinogram generation, then run through everything again and display the CGLS and Identity Tikhonov reconstructions side-by-side efore moving on to the BlockFramework aside.
It also means if they struggle with exercise 3 (the gradient tikhonov implementation) they'll have a fully working example to use.

I've made the changes discussed. Could @evelinaametova  and @jakobsj  have a look at the changes to the notebook - especially exercise 2. Once you're happy I'll add the exercise notebook too.


T321

Closing this, as it has no description. Are you trying to contribute something here, or just futzing?


[Storage] consider throwing when uploading to existing blobs

Possibly use etag

@bterlson, thoughts?

@XiaoningLiu @jiacfan

Sometimes, customers wants to override existing blob though. While sometimes, customers don't. Need to clarify the default behavior, and support other behavior by additional parameter. It's a cross language design topoic though.

I believe other languages (.NET and Java) has a boolean parameter overwrite with default value of false.
Sent from my Windows 10 device
From<EMAIL_ADDRESS>Sent: Tuesday, October 22, 2019 19:10
To<EMAIL_ADDRESS>Cc: Jeremy<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [Azure/azure-sdk-for-js] [Storage] consider throwing when uploading to existing blobs (#5594)
Sometimes, customers wants to override existing blob though. While sometimes, customers don't. Need to clarify the default behavior, and support other behavior by additional parameter. It's a cross language design topoic though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-js%2Fissues%2F5594%3Femail_source%3Dnotifications%26email_token%3DABZ3QX3NEXDZJSGFJQBU4FLQP6XBJA5CNFSM4JBOZEOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB7ZGIA%23issuecomment-545231648&data=02|01|Jeremy.Meng%40microsoft.com|05f3f02130364d33430008d7575e2caa|72f988bf86f141af91ab2d7cd011db47|1|0|637073934292380413&sdata=bNM0HoIe3uMTJu8nw5w7r3rUzxhINtgFuuHz%2FoH7Odo%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABZ3QX7CDLMHVMU3K5EP7HTQP6XBJANCNFSM4JBOZEOA&data=02|01|Jeremy.Meng%40microsoft.com|05f3f02130364d33430008d7575e2caa|72f988bf86f141af91ab2d7cd011db47|1|0|637073934292380413&sdata=tvn1BdwP40SYfXylBDy5MbBayETEY3rnXExe7ZMk5BU%3D&reserved=0.

@tg-msft, What's the behaviour of .NET in this case?

I think throwing by default is the right behavior here, and an option overwrite: true to turn this off seems good too.

It will introduce breaking changes now as we are already GA and we conform to the original REST API's behavior.
We could add a overwrite option default to true, or a uploadIfNotExists interface.
@bterlson @xirzec @XiaoningLiu What do you think now?

If we've already GA'd overwrite behavior, then I think we could add the inverted flag (throwOnOverwrite = false) and maybe consider logging a verbose/debug message when we're overwriting with instructions on how to flip the flag if this behavior is unexpected?

User can get the functionality by calling the interfaces with the ifNoneMatch condition.
await blockBlobClient.upload(body, body.length, { conditions: { ifNoneMatch: "*"} });

Another thing to think about is how we should deal with it in the parallel upload functions, where we call several stageBlock and then commitBlockList. commitBlockList supports the conditon butstageBlock doesn't. So we will stage all the blocks and then throw when we commit the block list. Not sure if this is acceptable for the user.

@EmmaZhu I believe this is your decision to make 😄


Segmentation Fault when closing with alt+f4

ATTENTION!:
If you are experiencing issues migrating from pyglet 1.5 --> 2.0, please first read the migration
section in the documentation. https://pyglet.readthedocs.io/en/latest/programming_guide/migration.html
Describe the bug
the program crashes with segmentation fault when I close it with alt+f4, it works as expected with using close window button
System Information:
Linux Mint 21.2, with cinnamon
AMD ryzen 5 with integrated graphics
How To Reproduce
import pyglet
window = pyglet.window.Window()
pyglet.app.run()

https://pyglet.readthedocs.io/en/latest/programming_guide/quickstart.html
running the above code, and then using alt+f4 to close the window

I'm not able to replicate this on a Gnome desktop. I don't think this has ever been an issue, so it might be something particular to Cinnamon. I'll try it in a VM when I have time.

I tried a Mint 21.2 Cinnamon VM, and could not replicate this. I tried a fresh install, and after full upgrade.
In my case it was just using llmvpipe.
Which Ryzen 5 do you have? If it's a brand new one, there could be a driver issue with the older Mesa version. If that's the case, you can try a live USB with a newer Kernel + MESA stack, to confirm.

Closing as no further input from the user to troubleshoot this further.


Fix field description

The recently added description of the fields states that rd needs to be
0x010, which is obviously wrong. This PR fixes this sentence.

Irrelevant since last spec update. Therefore closing.


Are there any plans on doing a Forge Port of this? because i'd absolutely love to use this!

(Sample Text)

I only support official releases of Sodium. This mod is licensed under MIT, so anyone can freely port it if they want.

Okii X3


upgrade: fix handling broken dependents.

Ensure that we use the keg for checking linkage but that the dependents returned are still formulae.
Thanks to @scpeters for help in https://github.com/Homebrew/brew/pull/6698#pullrequestreview-314596027
Fixes #6715.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

looks good to me


Provide a ProcessLogger() to capture all output in isCommandAvailable().

What does this do?

isCommandAvailable() tries to run a command (i.e., "vcs" or "verilator") to see if that command is available. The previous version assumed that passing None as the 3rd argument to BasicIO() was sufficient to suppress stderr. That proved to be incorrect and passing None causes stderr to be output normally.
This is particularly obnoxious since running verilator without any arguments causes it to display its help message on stderr and return a non-zero exit code. The fix for that particular problem is to run verilator --version, but in any case, we shouldn't be inadvertently displaying stderr.
The fix is to provide a ProcessLogger() that captures (and ignores) both stderr and stdout.
I put together a test for this, but it requires using System.setOut() which doesn't play well in a multi-threaded environment.

I see, well, looks good!


Release Build fails

This issue consists of 2 parts: build command failing & release build not working. Tested on macOS Monterey M1.

The entry point definition in the package.json file is wrong, which causes the build command to fail. It currently states:

https://github.com/electron-vite/electron-vite-react/blob/d6f989c4f5099dbd84dc54fe3d7dc9a92d6691bc/package.json#L9
But should be
"main": "dist-electron/electron/main/index.js",

After making that adjustment, the build command succeeds, however, the release does not work and shows the following error in the dev tools:
Not allowed to load local resource: file:///Users/wouter/Documents/demo/electron-vite-react/release/2.1.0/mac-arm64/YourAppName.app/Contents/Resources/app.asar/dist-electron/dist/index.html

Extacting the asar file tells me that the index.html file sits in
app.asar/dist/dist/index.html

instead of
app.asar/dist-electron/dist/index.html

Thanks for you feedback! Fixed it.


Windows: Refactor container

Signed-off-by: John Howard<EMAIL_ADDRESS>@swernli
This PR is part of the proposal described in issue 10662 to port the docker daemon to Windows. This PR is one of the more complex PRs unfortunately, but many future PRs will depend on this PR, so hopefully this one can be merged relatively quickly :)  This PR is the first step at forking container.go into Linux and Windows versions. In doing that, it also required forking volumes.go to get compilation and integration tests to succeed, so I have also pulled in some minor changes which were slated for future PRs too in volumes. Note that container_windows.go still contains TODOs which will be addressed in future PRs which depend on this PR (didn't want to make a huge PR affecting dozens of files).
(Rebased 4/30 after engine removed)

LGTM

@tiborvass Fixed constructors. Thanks for the pointer to the right syntax.

@jhowardmsft awfully sorry but needs a rebase

Rebased

ah so sorry needs rebase

you can ping me after :)

Again??! Wow, things change fast around here :)

Rebased

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "10662-startcontainerrefactor" git@github.com:Microsoft/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

This will update the existing PR, so DO NOT open a new one.

Third time lucky on rebasing :)

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "10662-startcontainerrefactor" git@github.com:Microsoft/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

This will update the existing PR, so DO NOT open a new one.

Looks like we would not be able to merge this PR because of merge conflicts. Please rebase, fix conflicts, and force push to your branch.

@jhowardmsft Sorry, this requires rebasing again.

@unclejack Rebased. Waiting for Jenkins to complete.

LGTM


add conditional fc logo

also clarity icons now imports the custom elements shim itself, just needs it as a peer
resolves #1338

How can I test it locally? I tried changing the config devUrlRoot to point to firecloud.terra.bio, but that didn't seem to work

To test locally, negate the boolean in the branding lib.


fix up maven build a little more

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/fabric8-quickstarts-master-pullreq/247/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/fabric8-quickstarts-master-pullreq/248/
Test PASSed.


Company-mode annotation colours

First of all, thanks for your work on this theme, which I use regularly. It looks great.
One wee problem I'd noticed, however, is that the completion list for company-mode looks broken when annotations are used. I'm not sure how widely annotations are used, but they certainly show up with CIDER when connected to a Clojure REPL, which is where I noticed the problem.
I've now worked out that the problem seems to be that the company-tooltip-annotation-selection face isn't defined, which means that the selected line appears to have a "hole" in the middle of it when annotations are displayed.
I'm now working around it with:
(set-face-background 'company-tooltip-annotation-selection "#37474f")
...in my startup file, which works for my setup, but I'm not familiar with theming emacs, so not sure what's needed to make a generic solution.
Just thought you'd want to know.

Thank you for the tip. Closed in https://github.com/cpaulik/emacs-material-theme/commit/6263ad1ee4c9a6d055986f6c58fa57ad64a71e12

Fantastic service! Thanks.


[bug] requestAnimationFrame error for Capybara

Could someone patch the code to ensure requestAnimationFrame exists in the window.
We are using Capybara in our project to test the JavaScript and our tests are failing as the requestAnimationFrame function is undefined.
Thank you in advance.
--
Source
I have sourced the error to come from:
Layzr.prototype._requestTick = function() {
  if(!this._ticking) {
    requestAnimationFrame(this.update.bind(this));
    this._ticking = true;
  }
};

--
Traceback
Capybara::Poltergeist::JavascriptError:
One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).
   ReferenceError: Can't find variable: requestAnimationFrame
   ReferenceError: Can't find variable: requestAnimationFrame

Old version of phantomjs was the issue.

thanks for posting the fix, glad you were able to work it out.


Added Something.

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] Searched the bugtracker for similar pull requests
[ ] Read adding new extractor tutorial
[ ] Read youtube-dl coding conventions and adjusted the code to meet them
[ ] Covered the code with tests (note that PRs without tests will be REJECTED)
[ ] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[ ] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

It''s is wonderfull, Please try

Good morning sir thanks you sir

Thank you sir for doing the needful. Here's your free t shirt for your contribution


GH-4134 Test LmdbStore with the ShaclSail

GitHub issue resolved: #4134
Briefly describe the changes proposed in this PR:

PR Author Checklist (see the contributor guidelines for more details):

[ ] my pull request is self-contained
[ ] I've added tests for the changes I made
[ ] I've applied code formatting (you can use mvn process-resources to format from the command line)
[ ] I've squashed my commits where necessary
[ ] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@kenwenzel here are some optimizations I'm testing out.

Looks good. I also thought about integrating the estimate functions of libmdbx into LMDB:
https://libmdbx.dqdkfa.ru/group__c__rqest.html
It should be rather easy to patch LMDB but that would also implicate that we have to maintain a patched version of the LWJGL bindings...

Looks good. I also thought about integrating the estimate functions of libmdbx into LMDB: https://libmdbx.dqdkfa.ru/group__c__rqest.html
It should be rather easy to patch LMDB but that would also implicate that we have to maintain a patched version of the LWJGL bindings...

Do you think it would be possible to contribute it to LMDB instead?
Reading through he LMDB documentation I saw that there should be some cursor operations to get the first and last page, if the database is ordered. Maybe there is some way to estimate the size based on the addresses of the first and last page?
I remember you mentioned that you were reading a max of 1000 elements from the cursor when estimating the cardinality, is that still the case? Maybe we could do some optimized caching where we evict cardinality results based on how much resources it took to calculate them. So the cardinality for null rdf:type null null would be cached much longer than :peter rdf:type null null.
There is still the option of using the code from the ExtensibleStore which uses Hyper Log Log. I think the biggest issue with that code is that it requires refreshing if there is a lot of churn (data added and removed and then added again). During that refresh cycle it needs to read all the data from the database which would probably block all writers.

Looks good. I also thought about integrating the estimate functions of libmdbx into LMDB: https://libmdbx.dqdkfa.ru/group__c__rqest.html
It should be rather easy to patch LMDB but that would also implicate that we have to maintain a patched version of the LWJGL bindings...

Do you think it would be possible to contribute it to LMDB instead?

I've already posted a question on the OpenLDAP mailing list where I asked them to implement the feature. Unfortunately, I've got no response so far. But maybe I should offer my support regarding this topic...

Reading through he LMDB documentation I saw that there should be some cursor operations to get the first and last page, if the database is ordered. Maybe there is some way to estimate the size based on the addresses of the first and last page?

This is not possible as the keys are ordered but the b-tree pages are just randomly distributed.

I remember you mentioned that you were reading a max of 1000 elements from the cursor when estimating the cardinality, is that still the case? Maybe we could do some optimized caching where we evict cardinality results based on how much resources it took to calculate them. So the cardinality for null rdf:type null null would be cached much longer than :peter rdf:type null null.

Yes, that is still the case. I read a fixed number of entries to determine the medium distance of the keys. Then I skip to the last key and try to extrapolate the whole number based on the distance between the keys. I'm currently working on optimizing this a bit to fix #3982.

There is still the option of using the code from the ExtensibleStore which uses Hyper Log Log. I think the biggest issue with that code is that it requires refreshing if there is a lot of churn (data added and removed and then added again). During that refresh cycle it needs to read all the data from the database which would probably block all writers.

I also thought about implementing this but it would also require a considerable amount of storage space.

FYI - I am also working on improving the cardinality computation itself. Instead of just using the first n rows as samples to estimate the cardinality, I divide the whole search space into b buckets and then I use samples from these buckets for the estimation. I will probably push a PR this week.

@hmottestad I've tested the cardinality cache but can't see any improvments in our standard query benchmarks. Does this only pay off when using multi-threaded access?

@hmottestad Do you have any benchmarks with and without the cache?

@hmottestad Do you have any benchmarks with and without the cache?

No. I need to create some LMDB + SHACL benchmarks.

I've looked into this branch again and I can't reproduce the initial performance issues. So I've modified the branch to only add the tests and benchmark.


Fail to import jinja2

I tried gpt-code-review-action in my OSS repository, however it failed to import python module. How can I fix it? Please let me know if you need more information.
Error message
Traceback (most recent call last):
  File "/app/entrypoint.py", line 19, in <module>
    from langchain import PromptTemplate
  File "/usr/local/lib/python3.10/site-packages/langchain/__init__.py", line 6, in <module>
    from langchain.agents import MRKLChain, ReActChain, SelfAskWithSearchChain
  File "/usr/local/lib/python3.10/site-packages/langchain/agents/__init__.py", line 2, in <module>
    from langchain.agents.agent import (
  File "/usr/local/lib/python3.10/site-packages/langchain/agents/agent.py", line 17, in <module>
    from langchain.chains.base import Chain
  File "/usr/local/lib/python3.10/site-packages/langchain/chains/__init__.py", line 2, in <module>
    from langchain.chains.api.base import APIChain
  File "/usr/local/lib/python3.10/site-packages/langchain/chains/api/base.py", line 8, in <module>
    from langchain.chains.api.prompt import API_RESPONSE_PROMPT, API_URL_PROMPT
  File "/usr/local/lib/python3.10/site-packages/langchain/chains/api/prompt.py", line 2, in <module>
    from langchain.prompts.prompt import PromptTemplate
  File "/usr/local/lib/python3.10/site-packages/langchain/prompts/__init__.py", line 3, in <module>
    from langchain.prompts.chat import (
  File "/usr/local/lib/python3.10/site-packages/langchain/prompts/chat.py", line 10, in <module>
    from langchain.memory.buffer import get_buffer_string
  File "/usr/local/lib/python3.10/site-packages/langchain/memory/__init__.py", line 11, in <module>
    from langchain.memory.entity import (
  File "/usr/local/lib/python3.10/site-packages/langchain/memory/entity.py", line 8, in <module>
    from langchain.chains.llm import LLMChain
  File "/usr/local/lib/python3.10/site-packages/langchain/chains/llm.py", line 11, in <module>
    from langchain.prompts.prompt import PromptTemplate
  File "/usr/local/lib/python3.10/site-packages/langchain/prompts/prompt.py", line 8, in <module>
    from jinja2 import Environment, meta
ModuleNotFoundError: No module named 'jinja2'

https://github.com/m-mizutani/alertchain/actions/runs/4737718901/jobs/8410826552?pr=12
GitHub Action
https://github.com/m-mizutani/alertchain/blob/2c4a175d4ae95b8a457bfcd1e849107a04a12977/.github/workflows/review.yml
Ref: https://github.com/m-mizutani/alertchain/pull/12

The issue might be caused by the updates of langchain. It seems that the issue was already resolved. If the issue still happens, please feel free to reopen the issue.

https://github.com/hwchase17/langchain/issues/3113
https://github.com/hwchase17/langchain/releases/tag/v0.0.144


misleading code in README

as of MRI ruby1.9.3 code
email.message.save_attachments_to(folder)
doesn't work. There's no method "save_attachments_to" in Mail::Message

@gordonbanderson thanks I've merged your example into the readme.

This issue was moved to gmailgem/gmail#88


Logout Fix

On top of #197
Fix broken logout button in ProfileScreen
Bump version 0.1.4

It looks like there are other changes besides the logout fix and version bump:

adaptive icons
ios/android config

It looks like there are other changes besides the logout fix and version bump:

adaptive icons
ios/android config

This was built on #197 which is merged now. The only app.json changes are a version bump for the fix.


Demo gives false detections and test gives very less AP

I tried to test res101 on pascal VOC and while testing my AP is very less. Also when i use demo function then i get a lot of ROI's. Did anyone else also encounter this problem? If yes then can someone please point out what the problem is? Here is what i get in the end:
AP for aeroplane = 0.0480
AP for bicycle = 0.0091
AP for bird = 0.0132
AP for boat = 0.0146
AP for bottle = 0.0021
AP for bus = 0.0103
AP for car = 0.0946
AP for cat = 0.0134
AP for chair = 0.0134
AP for cow = 0.0125
AP for diningtable = 0.0000
AP for dog = 0.0000
AP for horse = 0.0000
AP for motorbike = 0.0000
AP for person = 0.0000
AP for pottedplant = 0.0000
AP for sheep = 0.0000
AP for sofa = 0.0000
AP for train = 0.0000
AP for tvmonitor = 0.0000
Mean AP = 0.0116

what arch do you use for compiling nms?

It's sm_30, My GPU is Quadro K2200.

maybe you can set gpu_nms false

maybe you can set gpu_nms false

hi, do you means that quadro k2200 doesn't work for gpu_nms?

I am following the steps from the repository webpage, and ran the default test script, but I get zeros everywhere.
GPU_ID=0
./experiments/scripts/test_faster_rcnn.sh $GPU_ID pascal_voc_0712 res101
...
...
Reading annotation for 4950/4952
Reading annotation for 4951/4952
Reading annotation for 4952/4952
Saving cached annotations to /home/sagarwal/tf-faster-rcnn/data/VOCdevkit2007/annotations_cache/test_annots.pkl
AP for aeroplane = 0.0000
AP for bicycle = 0.0000
AP for bird = 0.0000
AP for boat = 0.0000
AP for bottle = 0.0000
AP for bus = 0.0000
AP for car = 0.0000
AP for cat = 0.0000
AP for chair = 0.0000
AP for cow = 0.0000
AP for diningtable = 0.0000
AP for dog = 0.0000
AP for horse = 0.0000
AP for motorbike = 0.0000
AP for person = 0.0000
AP for pottedplant = 0.0000
AP for sheep = 0.0000
AP for sofa = 0.0000
AP for train = 0.0000
AP for tvmonitor = 0.0000
Mean AP = 0.0000
Results:
0.000
0.000
0.000
0.000
...
...
Let me know what am I doing wrong

I trained voc2007 with res101 for 70000 iters, gpu 1080ti, and got a rather poor result:
AP for aeroplane = 0.2782
AP for bicycle = 0.2954
AP for bird = 0.2458
AP for boat = 0.2351
AP for bottle = 0.2506
AP for bus = 0.2787
AP for car = 0.3772
AP for cat = 0.3108
AP for chair = 0.1801
AP for cow = 0.1772
AP for diningtable = 0.2642
AP for dog = 0.2280
AP for horse = 0.3338
AP for motorbike = 0.2789
AP for person = 0.3647
AP for pottedplant = 0.1520
AP for sheep = 0.1873
AP for sofa = 0.2236
AP for train = 0.3701
AP for tvmonitor = 0.2922
Mean AP = 0.2662
@skamranali have you solve your problem?
@endernewton

Have you solved this problem?

I trained voc2007 with res101 for 70000 iters, gpu 1080ti, and got a rather poor result:
AP for aeroplane = 0.2782
AP for bicycle = 0.2954
AP for bird = 0.2458
AP for boat = 0.2351
AP for bottle = 0.2506
AP for bus = 0.2787
AP for car = 0.3772
AP for cat = 0.3108
AP for chair = 0.1801
AP for cow = 0.1772
AP for diningtable = 0.2642
AP for dog = 0.2280
AP for horse = 0.3338
AP for motorbike = 0.2789
AP for person = 0.3647
AP for pottedplant = 0.1520
AP for sheep = 0.1873
AP for sofa = 0.2236
AP for train = 0.3701
AP for tvmonitor = 0.2922
Mean AP = 0.2662
@skamranali have you solve your problem?
@endernewton

Have you solved this problem?


[Regression] Server side column sorting

Guidelines
Describe the bug
On previous library, we can disable the internal state sort mechanism in order to use external managed one.
This can be done by setting a no-op customSort method on columns definition.
See :
https://github.com/mbrn/material-table/issues/64
https://github.com/mbrn/material-table/issues/1798
And PR Proposal for a new dedicated property : https://github.com/mbrn/material-table/pull/2480
To Reproduce

Go to 'https://codesandbox.io/s/charming-blackwell-8vz3d?file=/src/App.js'
Table is sorted on 'Pants'
Click on 'RESET SORT'
Nothing happen

Working sandbox (with previous library) :
https://codesandbox.io/s/autumn-microservice-hb1xu?file=/src/App.js
Expected behavior
If customSort is a no-op, internal sort state should not be used.
Desktop (please complete the following information):

OS: Windows 10
Browser Chrome
Version 94.0.4606.81

Yours faithfully,
LCDP

Excellent find @LeComptoirDesPharmacies!

This issue is still alive

A PR would be most welcome.

I have a problem, I need to sort columns by server-side data, but don't have a function or parameter to show the current sort that came from the server, any suggestions?

A PR would be most welcome. But I will take a look today.

Hi @Domino987,
If we get some free time one day we will try to do a Pull Request but hard to find yet.
@bot : Problem is still there.
Yours faithfully,
LCDP


better handle looking up docs, ensure we respect the proxy!

@david-fisher cutting a release to fix snapshots.


Create differential tests on output data prior to merging MPI and OpenMP solutions

(This issue is to start a discussion on testing strategies)
Once we get to the point of merging MPI and OpenMP parts of the code base it would seem useful to have end-to-end tests that can compare output runs to some 'golden outputs' so that we can catch any problems, and assess with any changes are within acceptable error bounds (e.g., due to re-association of float point operations coming from parallelisation). Calculating RMSE (or something similar) between the output and the golden output would seem a useful measure here (we can also just do bitwise comparison as well - although I suspect that meeting that would be optimistic). This would generally help I think with code optimisations. Sometimes the golden outputs would need to change (due to scientific reasons) but other times its good to have them to assess changes that we want to be semantics preserving (e.g., optimisations).

This issue depends on https://github.com/nextsimdg/nextsimdg/issues/334.


Add content Disposition Filename for view download

Customized file name with imageName-coordinate pattern which helps user to quickly locate the position from WSI.

@tymiao1220 There is another PR which would require a mild conflict resolution of this one.  Otherwise, once this passes linting, it looks like a good change.


Add Google Search with google-api-python-client

This PR implements the same Google search functionality found in Langchain using the google-api-python-client package.

Forgot to set a branch for this tool and the new one :stuck_out_tongue:


Allowing Intrusion Detection Controller to Jobs, CronJobs, PodTemplate Resources

Description

For PR author

[ ] Tests for change.
[ ] If changing pkg/apis/, run make gen-files
[ ] If changing versions, run make gen-versions

For PR reviewers
A note for code reviewers - all pull requests must have the following:

[ ] Milestone set according to targeted release.
[ ] Appropriate labels:

kind/bug if this is a bugfix.
kind/enhancement if this is a a new feature.
enterprise if this PR applies to Calico Enterprise only.

will be merged to a incoming feature PR for ADJobs podtemplate


Real-time object detection - Can't use videos

I want to do real-time object detection using this project. In the input tag if I add extensions like .mp4, .avi or any other video extension, the file doesn't get processed for object detection and the API doesn't return any prediction on that. Any Idea how can I change this project from static object detection to real-time object detection?
Any kind of help would be very appreciated

This particular web app was written as a simple wrapper around our Object Detection model with only takes in Images. We do have another code pattern web app using our facial age estimator model that does what you're talking about. We have considered taking the time to adapt it for other models like object detector if you want to start there.

Facial Age Estimator Web App: https://github.com/IBM/MAX-Facial-Age-Estimator-Web-App
Facial Age Estimator Web App using tf.js: https://github.com/IBM/fae-tfjs


dirMeta.animations.map is not a function when building with --prod

OS?
Ubunutu 16.04
Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and @angular/cli: 1.0.0-beta.31
node: 6.9.5
os: linux x64
@angular/common: 2.4.5
@angular/compiler: 2.4.5
@angular/core: 2.4.5
@angular/forms: 2.4.5
@angular/http: 2.4.5
@angular/platform-browser: 2.4.5
@angular/platform-browser-dynamic: 2.4.5
@angular/router: 3.4.5
@angular/cli: 1.0.0-beta.31
@angular/compiler-cli: 2.4.5
@angular/tsc-wrapped: 0.5.1
@ngtools/webpack: 1.2.9

Repro steps.
ng build --prod
The log given by the failure.
`ERROR in dirMeta.animations.map is not a function
ERROR in ./src/main.ts
Module not found: Error: Can't resolve './$$_gendir/app/app.module.ngfactory' in '/home/ash/dev/bucardo-web/src'
@ ./src/main.ts 5:0-74
@ multi ./src/main.ts`
Mention any other details that might be useful.
I'm not sure what has changed for this to happen, I'm sure I was building in prod with beta 31 before.  It works fine if I build in non-prod

This was to do with animation instructions not being picked up correctly by AOT builds, see #3280


(bug: mat-table): Sorting function in Material Table does not work Properly

https://stackblitz.com/edit/angular-ffbgwt?file=src%2Fapp%2Ftable-expandable-rows-example.ts
Steps tp reproduce:
if clicked on the arrow to sort and then on an element to expand, it will not expand. you have to click the element several times and the expansion animation is broken.

Environment
Angular: 11.0.9 and 12.0.0 and others
CDK/Material: 11.1.1 and 12.0.0 and others
Browsers: Problem manifests on both Chrome, FF and Edge
Operating System: MacOS. Windows 10

This has come up in the past. I believe that the root cause is https://github.com/angular/angular/issues/18847.


Anybody would like to make a new cross-platform tool like this with me?

i like this software,but now when i try to run this program.its show me that the dependency about a package named gksu does not installed .i have try my best to  installed that.but it failed. it seems that the author would not maintain this tool anymore.lets start a new one.

i like this software,but now when i try to run this program.its show me that the dependency about a package named gksu does not installed .i have try my best to installed that.but it failed. it seems that the author would not maintain this tool anymore.lets start a new one.

https://github.com/Nambers/vkeyboardsound
this may help you?


Smoothing out the game play

This patch basically removes all Timers, in favor of Future.delayed() and AnimationController().
The progress bar in the screens are animated via AnimationController.

This makes the animation much smoother

Timed transitions of Screens are done via Future.delayed(), I think they are much simpler to use and cleaner.
A bunch of input timeouts were added, so that the game can move on.

The game can play itself now, :)

:hammer:


import serialize-javascript report Cannot read properties of undefined (reading 'from')

Describe the bug
Create a new project through vite scaffolding and then import package serialize-javascript.
An error will be reported.

Reproduction
Key code snippets：link
reproduce：online link
However, create a project using Vue CLI, and then import package serialize-javascript will run normally.
Normal vue2 demonstration project（F12 see console.log normal output）：
Key code snippets：snippets
System Info
System:
    OS: macOS 12.2.1
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
    Memory: 38.52 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.10.0 - ~/.nvm/versions/node/v16.10.0/bin/node
    Yarn: 1.22.18 - ~/.nvm/versions/node/v16.10.0/bin/yarn
    npm: 7.24.0 - ~/.nvm/versions/node/v16.10.0/bin/npm
  Browsers:
    Chrome: 101.0.4951.64
    Safari: 15.3
  npmPackages:
    @vitejs/plugin-vue: ^2.3.3 => 2.3.3
    vite: ^2.9.9 => 2.9.9

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

So this is not vite's problem.
Because the dependency of buffer package is missing.
But I'm surprised that Vue CLI project works normally, while the project created by vite doesn't work properly.
I solve it in the following ways.
pnpm install buffer

The error prompt of vite is not clear.
Normally, it should prompt that the buffer package is not found.

Related: https://github.com/vitejs/vite/pull/6493#discussion_r793895109


[Enhancement]: Add the number of results output for show xxx commands

What would you like to be added?
When you execute a show segments, you'll have a nice output for the segment count like the belowing:

It would be much better to have the count output for show collections , show collection-loaded
Why is this needed?
It's hard to count by yourself.
Anything else?
No response

/assign @congqixia


jdbc join push down

IBM presto can push down the processing of  join queries, or part of  join queries into the connected jdbc data source.
The results of this pushdown can include the following benefits:

Improved overall query performance

Reduced network traffic between IBM presto and the data source

Reduced load on the remote data source

Significant cost reduction due to limited number of database hit

This completed through another RFC https://github.com/Thanzeel-Hassan-IBM/rfcs/blob/main/RFC-0009-jdbc-join-push-down.md
https://github.com/prestodb/rfcs/pull/31


yarn run setup fails

...because of missing ./collector/.env.example file in the current main...

try changing the .env.example file to .env, take away the .example on the end. also make sure the right credentials are entered in that file, also if you are using windows, running this from your IDE is a little tricky, stick your errors into ChatGPT and it will guide you through,

Pull in latest and the file will be there now, thanks!


feat: add flake.nix file to consume gt via nix

This PR adds a flake.nix file which is used to install go-template within the nix ecosystem.
In the future this could also be used to provide dev environments for developers.

Looks good to me. @danielzwink what are you thinking?


OPS-283: docker build&push workflow

add workflow for building docker image and pushing it to public registry

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   73.51%   73.51%
=======================================
  Files          41       41
  Lines        2398     2398
=======================================
  Hits         1763     1763
  Misses        518      518
  Partials      117      117

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 177bf2d...0ecd471. Read the comment docs.


Add missing HTTP methods

Description
TRACE and OPTIONS, albeit not commonly used, are valid HTTP methods. This adds support for making TRACE and OPTIONS requests without adding convenience methods as they are not commonly used (in Java/Kotlin/Android projects).
Additionally the documentation now has HTTPS everywhere, as all the linked domains support HTTPS.
Type of change
Check all that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (change which changes the current internal or external interface)
[X] This change requires a documentation update

How Has This Been Tested?
Tests for the new methods have been added
Checklist:

[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation, if necessary
[X] My changes generate no new compiler warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

This looks great to me! Thank you for taking on this!

 I've slowed started documented the code base as well, where I think it could use some, as I navigate it.


code coverage reporting and publishing

improve code coverage if possible
ensure coverage reports are being submitted to codecov during CI, potentially use an existing github action to do this
add coverage badge from codecov to README

Closing this issue because turns out there was a different issue, will create a new one for that.


add support for extra DHCP options

What this PR does / why we need it:
This PR allows support for extra DHCP options from 224 to 254 for private use.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
We need dhcp option 240 to configure our VM internally. It would be useful to have these extra DHCP options to do this. Without this, there isn't a way for us to pass additional DHCP options and we would really like to get this change in to make our setup work. Thank you!.
Release note:

Add extra DHCP Options from 224-254 for private use.

Signed-off-by: Real Name<EMAIL_ADDRESS>

@SchSeba following the instructions on the developer guide for functional tests. Receiving this error: https://github.com/kubevirt/kubevirt/issues/1859 (created an issue for it). I'm not missing any of the steps - these are what I follow:
make cluster-up
make cluster-sync
make functest

This is blocks me having the ability to test my changes. Any ideas here? The bug link has more description. Thanks!

@bharatnc I updated the issue with some questions

Hmm, I once did an implementation of optional dhcp options using the option code as the key in a map and Roman and I came to the conclusion that it would be better to write each option as it's own struct under DhcpOptions.

lets try to check if this breaks thinks.

ci test please

ci test please

@SchSeba , added functional tests for extra dhcp options.  Thanks!

ci test please

ci test please

@SchSeba, I see that the CI tests are failing some checks, is this what you are referring to?  Where do I add/modify CI tests? I realize they are aside func tests.

ci test please

@SchSeba, I see that the CI tests are failing some checks, is this what you are referring to? Where do I add/modify CI tests? I realize they are aside func tests.

My bad, just realized that command is used to run CI tests, thanks !

@SchSeba and @rmohr , looking forward to get this change merged :) Please let me know if there are any other changes that you would recommend. Thanks!

Hello contributor, thanks for submitting a PR for this project!
I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.
In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

Type ci test please on this PR to trigger automated tests for it.
Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow #3 option )
If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@SchSeba could you continue since I am not back until the middle of February?

@SchSeba , pardon me, accidentally clicked on close and comment while trying to add this comment, I have reopened the PR. It would be great to know if this PR looks fine for merging.  Looking to do have this merged. Thanks!

@bharatnc can you please run make and commit to make travis happy?

@SchSeba , sure running make now!

@bharatnc can you please run make and commit to make travis happy?

@SchSeba , sure running make now!

@SchSeba make did not introduce any changes, but the earlier build failure was due to a unused import, which I have fixed and pushed a while ago!

@bharatnc Now it looks good lets run the functional test
ci test please

ci test please

@bharatnc Now it looks good lets run the functional test
ci test please

Thanks!

@SchSeba , CI tests finished. The failed tests don't seem to be caused by the changes in this PR.
How does these integration tests work? I see that in many PRs, that were merged upstream , not all tests pass, for instance
https://github.com/kubevirt/kubevirt/pull/1889 or this https://github.com/kubevirt/kubevirt/pull/1947.
Comparing the results of these tests with those on the PRs being merged upstream, I suspect that the tests are flakey and that the passed tests might be sufficient to get this PR merged. Pls correct me if I'm wrong.

@davidvossel The network lanes looks good and also the PR looks good to me can you take a last look please?

@davidvossel The network lanes looks good and also the PR looks good to me can you take a last look please?

Thank you @SchSeba , @davidvossel , does this PR look good? :) looking forward to getting this merged.

Can you please rebase?

Can you pl

Can you please rebase?

Just rebased!

ci test please

looks good to me once CI passes.
I made one minor comment about the DHCP option's value length. Is that something we should limit in the validation webhook?

@davidvossel , I don't think its needed, the IANA doesn't impose a limit on the DHCP private range: https://www.iana.org/assignments/bootp-dhcp-parameters/bootp-dhcp-parameters.xhtml.


testool improvements

Tool itself

genenrate report html from csv
use the "defines asm" ignored tests
use the "solidity" ignored tests

Cases

check why disabled hash precompiles can pass testing? No post state check? @kunxian-xia
better use of modexp U256 overflow
check whether there is pairing len > 4. @kunxian-xia

create2collisionCode_d0_g0_v0 : inside l2 trace, when create2collision occures, we need to record codehash to prove collision..

Because we did not init ArchimedesBlock in https://github.com/scroll-tech/zkevm-circuits/blob/develop/geth-utils/l2geth/trace.go#L127-L144.

This means that the tracer does not return error when hash precompiles are called.

Since we do not have any gadget to handle hash precompile, the step of state PrecompileBlake2f is not constrained at all.

The max pairs in the test cases of ec_pairing is 3.

check whether there is pairing len > 4: how did you found that? re-run tests and grep logs?

yes, I run test cases whose id contains ecpairing again and print out the number of pairs (call_data_length / 192) it has.


Orpheus support

Would you be interested in adding support for this tool on Orpheus? The API shouldn't be that different.
I can even take a swing at it if you want.

I'm not against adding Orpheus support 👍 , the api should be very similar indeed as both are Gazelle based, that said i personally will likely not prioritise adding Orpheus support myself but if you have interest making a PR then i'm down to review and suggest changes as needed to get it merged


completely different output from browser vs CLI for interactive params example

Expected Behavior
I tested generating STL files from a single interactive jscad example from both the browser and command line. The command line version generates garbage data:
openjscad models/testIssue/testIssue.jscad  --baseRadius 5  --baseHeight 40  --stageHeightRatio 0.6  --stageRadiusRatio 0.6  --noseHeight 10  --numberStages 2  -o cli.stl
https://cl.ly/3u1p1u0v0J1V
and the browser generates this one using the same params:
https://cl.ly/18190x0f3y3E
Here is a picture of what is expected: https://cl.ly/1l2X0N05330i
and here is the jscad file I use to test this with:
https://cl.ly/2M2Z452N3z0v
I tested this with 2 different computers (mac and linux) and with  different jscad files and get this issue. why is this happening?
Specifications

Version:  OpenJSCAD 1.4.0 [Darwin:14.5.0,darwin:x64]
Platform: mac
Environment: browser, local server

Hi @jtoy  , very good catch :) thanks !
I will try out your script and investigate!


attempt to update the table failed

Describe the bug
To Reproduce
Steps to reproduce the behavior:

A topic is defined, which has the same structure as the table in SQL server.
Define a sink and try to update the data in the SQL Server table. Use the following configuration。

3.The error is as follows.

Desktop (please complete the following information):

OS: [linux]

The error is very obvious. duplicate key found, no related with pulsar function.

The error is very obvious. duplicate key found, no related with pulsar function.

This configuration key = "Id", isn't it an updated configuration?


Error MSB4044 - CheckEmbeddedRootDescriptor

Issue
I got this error in console when trying to publish:
ILLink.Tasks.targets(451,5): error MSB4044: The CheckEmbeddedRootDescriptor task did not receive a value for the required AssemblyPath parameter.
General
Created a new .NET Core 3.0 WPF project
Added ILLink.Tasks nuget package
Ran this command:
dotnet publish -c release -r win-x64 -o out

https://github.com/dotnet/core/issues/2208
https://github.com/dotnet/coreclr/issues/24397
https://github.com/dotnet/winforms/issues/210
https://github.com/mono/linker/issues/428


Cho mình xin dữ liệu sau khi đã lọc "71GB of long paragraphs for 1024-length model"

You can try to download the original file from CC100 and filter them by the length of your choice. We didn't do any extra preprocess for ViT5.
!wget http://data.statmt.org/cc-100/vi.txt.xz
!unxz vi.txt.xz


Spider stops when the domain has a redirect

I am trying to use the spider functionality, but the home page of my site redirects to /home. Because of that, the spider stops, probably because it didn't follow redirects.
Below the configuration I was using:
domains:
  test: "http://mytestdomain.com"

I've also tried to configure directly my home page on the domain URL, and it almost worked. The spider indexed the links of the page, but it put the path after the /home. Ex: /home/anotherpage, /home/secondpage, returning a 404 error.
Below the second configuration I was using:
domains:
  test: "http://mytestdomain.com/home"

Should the spider mode follow redirects?

Anemone is the gem we used for the spider, it should follow redirects by default.

I found what was causing this issue. The server I am runing wraith has basic authentication, and Anemone does not crawl it (I think when I opened this issue I run with "/home" in the domain on a server without password protection).
I have to crawl my site without password to generate the spider.txt correctly and then change snap.js file to be able to return the password in the website:
// sets the user name used for HTTP authentication.
page.settings.userName = 'user';
// sets the password used for HTTP authentication.
page.settings.password = 'password';

If it is HTACESS password then you can give your URL as<EMAIL_ADDRESS>(Follow :  https://github.com/BBC-News/wraith/issues/4). For code generated authentication I am still struggling.


create a home page

Cards to preview all the projects present in Awesome-CSS-Projects

Hey, I would like to work on it, But request you to pls elaborate a little more about the "Homepage". Do consider me to assign this issue.

Great @tanmay-S12

The idea is that cards should be dynamic i.e: read all folders present in Awesome-CSS-Projects
On the card click open the respective project code

here is a kind of sudo design 😅, you can modify however you like

Hi @irshadmd,
I would like to work on this issue. Please assign me this issue.

@irshadmd I think I can do the same with bootstrap, will send pull request soon

@tanmay-S12 are you working on it? if not I'll assign this issue to @AnshikaAgrawal5501

Hey, I wanted to work on this under hacktoberfest, just tell me can we make it using reactjs and you are talking about dynamic so, it should have a database to where I believe to add a button on home page to add new project but tell me how to persist data I mean which system you are using I am familiar with firebase, mongodb

@AnshikaAgrawal5501 assigning this to you

@AnshikaAgrawal5501 assigning this issue to you

Thanks! I will soon raise a PR with the complete work.


Feat/add handling missing env

Added handling missing PG_CONNECTION_STRING
Added handling missing CREDENTIALS_PATH
Updated README.md

No, it's not more relevant


analog stick vs d-pad

When setting up prototypes, it seems like the plugin sets up navigation to run from the analog stick.
It would be neat if you could choose analog stick, d-pad, or both. Of course for both you'd need a second prototype interaction defined.

You should be able to choose D-Pad in the navigation section while generating or linking a prototype.
To add on additional navigation methods, choose a different navigation method and use the Link feature on your existing prototype frames.
Lemme know if this resolves your issue.

Yes, sorry! I missed it. Cool that you can do the shoulder buttons too.


Window 'reduce to icon' and 'restore' animations are not right

With cairo it looks like the windows are animated taking the bottom-right point of the screen as origin, when normally the taskbar icon's position is used by explorer

This was an easy one and will be in the next release!


Initial Spanish translation

As part of #760, we want an initial translation done for kolibri-explore-plugin.

Here are the English versions of the strings. They come in three files because of how kolibri-explore-plugin is split up between frontend and backend, and different frontend modules. django.txt is actually a PO file but I had to rename it to get GitHub to accept it.
django.txt
kolibri_explore_plugin-messages.csv
welcome-screen-messages.csv

@jofilizola, the English versions of the strings for the kolibri-explore-plugin are above for you to take a look at.

@pwithnall I am organizing the translation file with screenshots, for people translating it might not be very obvious where things sit, since they are not so familiar with all of the UI element. There are a few things that I need help with, all marked in the document:

Error messages that I can't force to appear, would you be able to get me screenshots? YELLOW
Strings that are in the UI with no identifiers listed RED
Strings that I could not find where the in the UI they live PURPLE (are these fade.downloadCompletedLabel related to the individual content download, card UI?)
Strings that come straight from Kolibri as they are, the quizzes components are marked in gray, can we use the ones from Kolibri?

Here's the document, if you see something wrong there, please let me know!
Thanks!!

Left some comments and some screenshots (where I can easily produce them) in the document.

Here’s an updated version of the message files, including a lot more messages from other parts of the UI which were previously untagged for translation.
This should now be pretty much the full set of strings to translate.
LC_MESSAGES.zip

Thanks Philip! I'm going through the files and I spotted that the template-ui-messages.csv is empty when I open and  I don't see the .json file in the .zip folder. I don't know what I'm missing... could you take a look, please?

Ah yes, it’s meant to be empty. There aren’t actually any translatable messages in the template-ui package.

Ah, ok! Will there be?

Not unless someone adds more features to template-ui. The lack of messages to translate is because it doesn’t contain any human-readable strings, not because there are missing translation annotations.

Not unless someone adds more features to template-ui. The lack of messages to translate is because it doesn’t contain any human-readable strings, not because there are missing translation annotations.

@pwithnall did you use master branch for the extraction? I see some: git grep '$trs' packages/template-ui/

@jofilizola Here are the missing template-ui messages for translation:
template-ui-messages.zip

And here’s the final batch of strings for translation, from the loading screen:
loading-screen.zip
Included are the English strings, and my initial (dodgy) Latin American Spanish translation. It’ll need reviewing and tweaking.

@pwithnall I took the liberty to start importing the strings after I did QA of the documents. I started with the kolibri_explore_plugin.app-messages.json as is the only one in current master. Here is a PR: https://github.com/endlessm/kolibri-explore-plugin/pull/832
I wrote a simple script for this (pasted below for now). You can see in the output that there are some missing string IDs. Probably because of moving messages around between the components.
import os
import json
import csv

csv_path = 'Spanish_Translations_kolibri_explore_plugin-messages - kolibri_explore_plugin-messages.csv'
json_path = 'kolibri_explore_plugin/locale/es_419/LC_MESSAGES/kolibri_explore_plugin.app-messages.json'

json_data = {}
with open(json_path) as json_file:
    json_data = json.load(json_file)

csv_data = []
with open(csv_path, encoding='utf8') as csv_file:
    csv_reader = csv.reader(csv_file)
    for row in csv_reader:
        csv_data.append(row)

csv_data.pop(0)  # first line is header

total_missing = 0
for i, row in enumerate(csv_data):
    _id = csv_data[i][0]
    translation = csv_data[i][3].strip()
    if _id in json_data:
        if translation == '':
            # Ignore missing ones
            continue
        json_data[_id] = translation
    else:
        print(f'Missing ID: {_id}')
        total_missing += 1

with open(json_path, 'w', encoding='utf8') as json_file:
    json.dump(json_data, json_file, ensure_ascii=False, sort_keys=True, indent=2)

print(f'Total Missing: {total_missing}')

Here is the script above in a PR: https://github.com/endlessm/kolibri-explore-plugin/pull/834
The import would work like this:

Save the spreadsheet as CSV
Run the script to update the JSON, eg: ./scripts/import_translation.py ~/Descargas/Spanish_Translations_kolibri_explore_plugin-messages\ -\ kolibri_explore_plugin-messages.csv kolibri_explore_plugin/locale/es_419/LC_MESSAGES/kolibri_explore_plugin.app-messages.json

This is how it looks in my end. Some translations that were correctly imported (like "READ") are not being translated:

And here’s the final batch of strings for translation, from the loading screen: loading-screen.zip
Included are the English strings, and my initial (dodgy) Latin American Spanish translation. It’ll need reviewing and tweaking.

@manuq @pwithnall  I've prepared a new document for this: https://docs.google.com/spreadsheets/d/1fYO_rili_EVrdMiG3LTZf6AHyqTo2KG_eaIcL7yh__U/edit#gid=644360418 and used the translations we already had in other documents for the same copy.

This is how it looks in my end. Some translations that were correctly imported (like "READ") are not being translated:

https://docs.google.com/spreadsheets/d/1qtkHtDQOMzfK_8_IQnL59WGK-ub2BjIpsccjac7iYf0/edit#gid=1161103477
Line 26, 21, 22, 23 we have the translation to the media type in this document
The tabs translations are in this one: https://docs.google.com/spreadsheets/d/1J4OyG-KCARsC0hSc0zC0LOguUdpmVw_YJxYG2HA5rBc/edit#gid=1177927074
lines 72, 74

And here’s the final batch of strings for translation, from the loading screen: loading-screen.zip
Included are the English strings, and my initial (dodgy) Latin American Spanish translation. It’ll need reviewing and tweaking.

@manuq @pwithnall I've prepared a new document for this: https://docs.google.com/spreadsheets/d/1fYO_rili_EVrdMiG3LTZf6AHyqTo2KG_eaIcL7yh__U/edit#gid=644360418 and used the translations we already had in other documents for the same copy.

https://github.com/endlessm/kolibri-explore-plugin/pull/845

Spanish localization of the UI is fully working 7.1 onwards.


feat: treat external connection as open

This addresses: https://github.com/salsita/node-pg-migrate/issues/885
Here is the resulting "check trace" on why advisory lock is never released for external Client
exhibit A: It checks that the connection is connected and only if it is connected -- releases the lock

if (db.connected()) {
      if (!options.noLock) {
        await unlock(db).catch((error: unknown) => {
          logger.warn((error as Error).message);
        });
      }

      await db.close();
    }

exhibit B: Connection status is decided by this variable
    connected: () => connectionStatus === ConnectionStatus.CONNECTED,

exhibit C: When the client is created the connection status is not updated
const createConnection: DBConnection['createConnection'] = () =>
    new Promise((resolve, reject) => {
      if (isExternalClient || connectionStatus === ConnectionStatus.CONNECTED) {
        resolve();

exhibit D: The initial value is "DISCONNECTED"
let connectionStatus = ConnectionStatus.DISCONNECTED;

Alternatively, this can be fixed by:

Setting the connectionStatus variable to ConnectionStatus.CONNECTED
Rewriting the lock check to acknowledge the external client n some way

The provded solution seems more like the most one.
If any maintainer can advise on a better solution -- I would be glad to update the PR.

It looks like it is now the same check as in line 64
https://github.com/salsita/node-pg-migrate/blob/6f1751887218593428553f07237b866f6eb5f066/src/db.ts#L64
And so this might make sense 🤔
However I'm now not sure anymore how the code behaves when it comes to isExternalClient === true && connectionStatus === ConnectionStatus.ERROR
https://github.com/salsita/node-pg-migrate/blob/6f1751887218593428553f07237b866f6eb5f066/src/db.ts#L64-L70
Do we want to check for connectionStatus when it is an external client? Or do we want to ignore it?
I'm just asking because I just looked around 1 minute at the code, and have not dug deep into it.

Beside that, you need to run the formatter to make lint happy 😸

However I'm now not sure anymore how the code behaves when it comes to isExternalClient === true && connectionStatus === ConnectionStatus.ERROR

So ATM the connection status of the external is ignored and looking at the code it looks like the external connection is assumed to be a valid initialized connection. So the current implementation seems like it is in the spirit of the original.
If you feel like it I can replace the check on https://github.com/salsita/node-pg-migrate/blob/6f1751887218593428553f07237b866f6eb5f066/src/db.ts#L64 with a .connected() invocation.
in the meanwhile, i have added a test for this behaviour.

[...]
If you feel like it I can replace the check on
https://github.com/salsita/node-pg-migrate/blob/6f1751887218593428553f07237b866f6eb5f066/src/db.ts#L64
with a .connected() invocation.
[...]

I also thought about this.
So we could add an internal function like
const connected: DBConnection['connected'] = () => {
  return isExternalClient || connectionStatus === ConnectionStatus.CONNECTED
}

and then use this in both places.

One more further thinking idea that came into my mind is: Should we add a ConnectionStatus.EXTERNAL? 👀
That one would then have the meaning of "it is externally managed and so not in control of node-pg-migrate" 🤔

@Shinigami92  I have both extracted a check and introduced a new connection status.
There is no test for the latter as it is an internal private logic that is not exposed anywhere so i do not see a reason to try to cover it.

I will merge and release this when I have dedicated time and my non-company PC
Do you think this is a bugfix (-> 7.6.1) or is this a new feature (-> 7.7.0)?

Do you think this is a bugfix (-> 7.6.1) or is this a new feature (-> 7.7.0)?

This is a bug fix for me as I encountered it after starting to scale my API servers horizontally.
I was forced to implement a startup lock myself to ensure that migrations were checked on each server in a queue.
But even after implementing the lock on my side, the server startup was still failing with "Another migration is running".
For now, I have fixed it on my side with noLock options.
So I'd vote on 7.6.1.
P.S.: it would be cool to implement a waiting lock so that instead of failing it would wait for the lock to be released.
Unfortunately, there is something odd with the way 'pg_advisory_lock' works (it returns the response with no data right away instead of waiting for the lock).
I can submit a polling implementation instead. Which will try to acquire the lock, if not acquired it will wait for the TIMEOUT and repeat the process. this will be limited to the ATTEMPTS number.
If you are interested in this -- I can submit the pr sometimes later.

P.S.: it would be cool to implement a waiting lock so that instead of failing it would wait for the lock to be released.
Unfortunately, there is something odd with the way 'pg_advisory_lock' works (it returns the response with no data right away instead of waiting for the lock).
I can submit a polling implementation instead. Which will try to acquire the lock, if not acquired it will wait for the TIMEOUT and repeat the process. this will be limited to the ATTEMPTS number.
If you are interested in this -- I can submit the pr sometimes later.

Sounds good to me


Do not release any pokemon

This is my config, but it not release any pokemon. Tell me how to fix it?
config.txt

Duplicated #4459

I know. But I want release immediately, not wait till full the bag.

TransferPokemon
min_free_slot: Default 5 | Once the pokebag has less empty slots than this amount, the transfer process is triggered. | Big values (i.e 9999) will trigger the transfer process after each catch.

I saw it in the documentation.

Ok, thanks. I not yet read new documentation :))


Lexer Error: Unterminated quote at columns 0-1 ['] in expression ['].

I've got this error when debugging this page using AngularJS Batarang 0.8.1.  The error message is Lexer Error: Unterminated quote at columns 0-1 ['] in expression [']..  It looks like a ngHint problem.  Here is a screenshot below:

woot, nice bug find. surprised it only got reported now. Will look into it this week. Thank you for the demo!

issue related to https://github.com/angular/angularjs-batarang/issues/227
the problem is in the events module at https://github.com/angular/angular-hint/blob/master/src/modules/events.js#L14

This might be a similar issue:

Once I deactivate Batarang, everything works fine. This came up in the recent days so it was probably introduced with v0.8.0.

@erwinmombay Do you figure out the solution for this issue?

Still being worked on, might have a fix tomorrow.  Looks like there's a whole host of problems related to this.

@doggy8088 sorry not yet was out for a few days. will get back on this. apologies for the wait!

@doggy8088 finally got a fix for this! hold tight!

Yay!

@erwinmombay Great job! :+1:

:) just ran into this myself.

fix landed in https://github.com/angular/angular-hint/commit/26cfc749113a599a1e11a587091c558ee2e499b6

Worked for me. Thank you!

Thanks! The error in the console is gone, but all the "Scopes" information was just disappeared. :cry:
The same example to try, screenshot below:

@doggy8088 will take a look at that problem this weekend! ill see if theres a related issue somewhere


add asreview lab documentation page

This looks good to me and I took the liberty of resolving the merge conflict. :) I'll merge this now. I'll soon be updating the Catalog Items page so it's good to have all the changes merged in!


Anyone else seeing erroneous event notifications?

I have two of my cameras configured to send notifications via Gotify, and they are working, but this morning I have gotten about 12 notifications that say a Person was detected on one of the cameras. When I click the Camera link in the notification, I see all the events for that camera, but there are not any events saved for today. The most recent event was yesterday evening and was a car.
So I'm not sure why these erroneous event notifications are being generated when there is actually no event in Frigate.

I've actually had this happen before.
This should disappear once /review is in place.
However since the bug fix for the moment I no longer have any.

Hi, has this issue been resolved? Can it be closed?

Yes !


Documentation for Popovers incomplete - missing 'toggle' method (2.0-wip)

this pull request adds documentation for the 'toggle' method for Popovers.

sorry - this needs to go against templates explicitly

I'll add it though :)

I'm pretty new to github/twitter bootstrap/contributing to stuff/etc., so I don't know what you mean, but ok & thanks! :)


APPS-1030 Add read write mutex to state file

Codecov Report
Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (ec959be) 20.59% compared to head (60faa10) 20.40%.

Files
Patch %
Lines

pkg/service/backup_backend_local.go
0.00%
7 Missing :warning:

pkg/service/backup_backend_s3.go
0.00%
6 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   20.59%   20.40%   -0.20%
==========================================
  Files          28       28
  Lines        1175     1186      +11
==========================================
  Hits          242      242
- Misses        911      922      +11
  Partials       22       22

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Broken BaseHtml::getAttributeValue()

What steps will reproduce the problem?
This code based on http://www.yiiframework.com/doc-2.0/guide-input-file-upload.html and previously worked correctly.
Broken in https://github.com/yiisoft/yii2/commit/3fcc26996b9395d2892839b5bc8071c99a6cab07
Method getAttributeValue()
Model
class Blog extends ActiveRecord
{
    public static function tableName()
    {
        return 'blog';
    }

    public function rules()
    {
        return [
            [['files'], 'image', 'extensions' => 'png, jpg', 'minFiles' => 2, 'maxFiles' => 10],
        ];
    }

   ...

Controller
...

public function actionIndex()
{
    $model = new Blog();

    if ($model->load(Yii::$app->request->post())) {

        // getInstances return array of files
        $model->files = UploadedFile::getInstances($model, 'files');

        if ($model->save()) {
            if ($model->files) {
                // save files..
            }
            $this->redirect(['index']);
        }
    }

    return $this->render('upload_form', [
        'model' => $model,
    ]);
}

View

<?php $form = ActiveForm::begin([
    'options' => [
        'enctype' => 'multipart/form-data',
    ],
]); ?>

    <?= Html::activeFileInput($model, 'files[]', [
        'id' => 'upload-file',
        'multiple' => true,
        'accept' => 'image/*',
    ]); ?>

<?php ActiveForm::end(); ?>

We are submitting form with empty file input.
What is the expected result?
Model has errors ('minFiles' => 2) and form rendered again.
What do you get instead?
PHP Notice – yii\base\ErrorException
Array to string conversion
in /var/www/child/vendor/yiisoft/yii2/helpers/BaseHtml.php
line 537
$options['value'] = $value === null ? null : (string) $value;

Additional info

Q
A

Yii version
2.0.10-dev

PHP version
7.0.8-0ubuntu<IP_ADDRESS>

Operating system
Ubuntu 16.04

Also getAttributeValue() method is hard to understand with such a code style. Why
$matches[3] !== '[]' ?
if (!preg_match('/(^|.*\])([\w\.]+)(\[.*|$)/', $attribute, $matches)) {
    throw new InvalidParamException('Attribute name must contain word characters only.');
}

Why exception requires us to use only word characters while accepting []?
https://github.com/yiisoft/yii2/commit/3fcc26996b9395d2892839b5bc8071c99a6cab07#diff-95842e557ddaa8b8fa5d26cf31fefae7R2034

Failed to reproduce

'minFiles' => 2

This property does not belong neither to the ImageValidator nor to the FIleValidator. Is this property your custom?

Also getAttributeValue() method is hard to understand with such a code style. Why
$matches[3] !== '[]' ?

Regular expressions are often hard to understand :)

Why exception requires us to use only word characters while accepting []?

[] means that attribute will be represented as array.

This property does not belong neither to the ImageValidator nor to the FIleValidator. Is this your custom property?

Yes, this is own custom property. But it is not important for this issue:)
Exception Array to string conversion throws by BaseHtml for attribute files[] after $model->files = UploadedFile::getInstances($model, 'files');

Previously BaseHtml::getAttributeValue() returns null for files[] attribute. Now this returned empty array.

Verified as a BC breaking, thank you for a report.
However, the previous behavior was not consistent:
$model->foo = [];

var_dump(Html::getAttributeValue($model, 'foo')); // array[]; seems to be expected
var_dump(Html::getAttributeValue($model, 'foo[]')); // null; same here, element with key [] (empty key) is not present in array `foo`

$model->foo = ['type1', 'type2', ['sub-array', 'sub-array2']];

var_dump(Html::getAttributeValue($model, 'foo[1]')); // string(5): "type2"; expected, `$foo[1]` exists and equals string "type2"
var_dump(Html::getAttributeValue($model, 'foo[1][]')); // string(5): "type2"; wtf, why not `null`?

The problem seems to be not so obvious. @yiisoft/core-developers what do you think

Hmm... logically it should be array in this case. I'm for fixing all the usage of Html::getAttributeValue() and adding notes to UPGRADE.

There are a lot of use cases for this method and it will break a lot of things changing the behavior of it. Imo we should cover all use cases in test cases and then make the behavior logical and consistent in 2.1.

Original changes were reverted https://github.com/yiisoft/yii2/commit/c66b845f4809125d3e320ce138eed3b1ecb7b39d because of BC breaking and no change to normalize behavior without BC.


Import manifest changes from app history into depot history

Makes the new manifest history page worthwhile.

It's not worth the effort to parse stored history to populate the depots history with these manifests.


Remove version: SanfordLP.DYMOConnect version <IP_ADDRESS>

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://s3.amazonaws.com/download.dymo.com/dymo/Software/Win/DCDSetup<IP_ADDRESS>.exe
Response Error: The remote server returned an error: (403) Forbidden.
(Automated message - build 911)


ValidationException no working with ExceptionFilterAttribute

System Details

FluentValidation version: 8.4.0
Web Framework version (eg ASP.NET Core 2.1, MVC 5, WebApi 2. Delete if not applicable):
ASP.NET Core 2.1

Issue Description
ValidationException no working with ExceptionFilterAttribute
We have setup a CustomExceptionFilterAttribute on our .net core API to capture and handler exceptions. When our Abstract Validator fails on the controller we simply get a 400 bad request and the exception filter is missed completely  ->
public class RegisterUserValidator : AbstractValidator<RegisterUserCommand>
{
    public RegisterUserValidator()
    {
        RuleFor(x => x.FirstName)
            .NotEmpty();

        RuleFor(x => x.LastName)
            .NotEmpty();
}

public class CustomExceptionFilterAttribute : ExceptionFilterAttribute, IExceptionFilter
{
    public override void OnException(ExceptionContext context)
    {
        if (context.Exception is ValidationException)
        {
            context.HttpContext.Response.ContentType = "application/json";
            context.HttpContext.Response.StatusCode = (int)HttpStatusCode.BadRequest;
            context.Result = new JsonResult(
                ((ValidationException)context.Exception).Errors);

            return;
        }
}

When a model is send via POST request to the controller the exception filter does not fire at all unless we specifically specifiy .OnAnyFailure Rule for every single attribute

FluentValidation doesn't throw an exception when validation fails, which is why you can't catch it - there's nothing to catch.
FluentValidation just passes a list of validation errors to ASP.NET, which renders this as a 400 response. This is a feature of ASP.NET Core not of FluentValidation. If you want to turn it off or change the behavior then please read the asp.net documentation on this feature: https://docs.microsoft.com/en-us/aspnet/core/web-api/?view=aspnetcore-2.2#automatic-http-400-responses


Notification not showing all the test

screenshot here http://i.imgur.com/sWDfQaF.png
Big View notification style should be used to show all of the text

It's not needed. You just need the event topic and time.

@ahmed-fathy-aly Not really required. The text is not that much that we use Big View notifications. But you're welcome to add other things in the notification, we'll see if it looks good, we'll merge it. Closing this for now


_id format on after.insert

There is a different behavior between version 1.3 and 1.4 of Meteor,  on after.insert the _id attribute of document is in mongo format, not in meteor format, it's correct?
Thanks

I think I'm also seeing what @galdo666 is trying to say
When my collection has a idGeneration of 'MONGO', the doc._id from after.insert(userId, doc) is a string, and not the Mongo.ObjectID that's in the collection.
For example,
var collection1 = new Meteor.Collection('collection1', {idGeneration: 'MONGO'});
collection1.after.insert(function (userId, doc) {
  collection1.direct.findOne({_id: doc._id});
});

throws the following error on insert
Exception in callback of async function: TypeError: value.id.copy is not a function
I20160814-21:56:54.109(-10)?     at serializeObjectId (/Users/Marty/.meteor/packages/npm-mongo/.<IP_ADDRESS>a6cr++os+web.browser+web.cordova/npm/node_modules/bson/lib/bson/parser/serializer.js:252:14)

I believe this has to do with the updated  function after (id, err) in insert.js in 0.8.3, which works when the collection's id generation is based on strings, but not when it's set to use Mongo.ObjectIds. In this situation, doc._id should be of type Mongo.ObjectID.
If you'd like, I'll submit a PR with a test that reproduces this error and a fix that resolves it.


Added events on CSO

Signed-off-by: ghanshyam-11<EMAIL_ADDRESS>Pull request checklist

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature Enhancement
[ ] Test Automation
[ ] Code Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Community Operator listing
[ ] Other (please describe):

What is the current behavior?

What is the new behavior?

How risky is this change?

[ ] Small, isolated change
[ ] Medium, requires regression testing
[ ] Large, requires functional and regression testing

will raise a new PR to IBM:dev


feat: language option support

For TokenSigning backwards compatibility, some three-letter language codes are supported when used through hwcrypto.js
The extension does not set a default language - when language is not specified, the attribute is not included in the native application message

Looks good to me, but needs rebasing.


Refactor the configuration

[BUG]/[FEATURE] title
What changes were proposed in this pull request?
Why are the changes needed?

What are the items that need reviewer attention?
Related issues.
Related pull requests.
How was this patch tested?
/cc @related-reviewer
/assign @main-reviewer

LGTM.

Is there any user wechat group?


Removing noUiSlider

Before submitting...

[X] I have searched for duplicate or closed issues.
[X] I have read the CONTRIBUTING document and my issue is following the guidelines.
[X] I have read the template completely before filling it in.

Context
Do we need this Plugin? If yes for what?
I would remove it for the next release. Please comment here if there is any need in keeping this Plugin.
Current Behavior
No response
Expected behavior
No response
Possible Solutions or Causes
No response
Your Environment

Version used:
Browser Name and version:
Operating System and version (desktop or mobile):
Additional information you want to tell us:

implemented in v2-dev

What is your alternative for this?  HTML5 range does not do a dual selector without a fair bit of code.


Analytics for consignments

Adds a bunch of events to the consignments section
Exposes a function used in the AppRegistry to other components ( I have non-app registry root components for screens) /cc @alloy
Exposes the AppRegistry root level page track function for others to use
Adds docs on how to test the calls

Fails

:no_entry_sign:

No CHANGELOG added.

:no_entry_sign:

Missing Test Files:

src/lib/Components/States/__tests__/ZeroState-tests.tsx

If these files are supposed to not exist, please update your PR body to include "Skip New Tests".

  Generated by :no_entry_sign: dangerJS

OK, tests are in and docs will need a second look

Fails

:no_entry_sign:

Missing Test Files:

src/lib/Components/States/__tests__/ZeroState-tests.tsx

If these files are supposed to not exist, please update your PR body to include "Skip New Tests".

  Generated by :no_entry_sign: dangerJS

This looks great 💕. Def have a look at @alloy's comments, and if you wanna push changes, I can merge after 👍

OK, this is good to go on green 👍


User Verification / Display routes

We need a route to approve users! Essentially, when a user account is created, it will have the approved tag = false. We want admins to be able to approve a user by calling this route with a user id (Security can be handled at a later point). When this route is called with a user, it will set that approved tag to be true.
We also need two more routes for displaying users

A get route that returns a list of all non-admin users
A get route that returns a list of all admin users

This will be used to integrate the users page!

#45


Certificate is not attached with Windows installer

Description:
Certificate is not attached with Windows installer and when installing following message pops up.

This has been reported in following post :
https://twitter.com/chj915/status/1077271462346514432

This has been resolved in 0.990.2 release


Fixes global region zone update

Fixes global region zone update

Closing in favor of https://github.com/GoogleCloudPlatform/rad-lab/pull/169 which is up to sync. Also may need to rebase in my name to get around CLA issue


[DO NOT MERGE YET] Add 7.1 PHP version and make tag configurable

This is a preparation for the image streams update. Once streams include version 7.1 for the PHP image, this PR can be merged. Until then, the content in https://github.com/hhorak/cakephp-ex serves as a testing app for the PHP image.

This has been tested in CI for some time already, so we should be able to merge.


Clear Screen (Clear Pixels)

https://github.com/zacharyeast/Sense-Hat/blob/master/Clear LED's
Here is a simple but long way to clear all the pixels. Let me know if you know a shorter way!

sense.clear()
or
sense.clear(R, G, B)
and pick your colour.
as per the documentation.
On Tue, 11 Aug 2020, 8:49 pm zacharyeast<EMAIL_ADDRESS>wrote:

https://github.com/zacharyeast/Sense-Hat/blob/master/Clear LED's
Here is a simple but long way to clear all the pixels. Let me know if you
know a shorter way!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/astro-pi/python-sense-hat/issues/99, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYAXN75QJ3HIJRY3QIP4OLSAGOEJANCNFSM4P3OWIOQ
.

Hello,
Thanks! For some reason it seemed like sense.clear() didn't clear it every time for me.  That does work perfectly now though, so not sure what happened.


Bug-Fix-3.10/FE-162-display-geodesic-lines backport

Scope & Purpose
Backport for #18758

[x] :hankey: Bugfix

Checklist

[x] :book: CHANGELOG entry made

Related Information

[x] GitHub issue / Jira ticket: https://arangodb.atlassian.net/browse/BTS-777

@ajurdak  does this still need review? It looks like it conflicts a later PR: https://github.com/arangodb/arangodb/pull/18957/files

[x] https://jenkins01.arangodb.biz/job/arangodb-ANY-jslint/30412/


Created test harness for RFC6749

An abstract test harness for all conditions defined in the
OAuth RFC.

Coverage remained the same at 100.0% when pulling 891d339979f7d371de05183ce4885963ee176fa3 on feature/rfc_test_harness into ae94193e0b038e9738237b382549ef816a1e07b6 on develop.


Devops/dockerfile

Type

[ ] Feature
[ ] Bug fix
[ ] CI/CD
[ ] Documentation
[x] Other

Description
Writing dockerfile for building images for serverless, ftp, broker-service, proof-service. Include a Makefile for fast build, compose up, down services.

I just push commit to update dockerfile and docker compose corresponding to previous comment.

Closed here base on new permission changing


Correct NTPd package choosing under el9

Description
Making the jump from EL7 to EL9, I noticed the name of the package that delivers ntpd and ntpdate is now from the ntpsec project via EPEL9.
Issues Resolved
Check List

[x] A summary of changes made is included in the CHANGELOG under ## Unreleased
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable.

Cannot test:  Will not run Chef15+ due to licensing trapdoor; but code tests well in 14.15.6/el9 .

I'm not sure what the rel-label validator wants.  sio sarakasi yangu.

Released as: 5.2.2