Add additional labels if present

TL;DR
Please replace this text with a description of what this PR accomplishes.
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[ ] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   71.08%   71.08%
=======================================
  Files          57       57
  Lines        2352     2352
=======================================
  Hits         1672     1672
  Misses        542      542
  Partials      138      138

Impacted Files
Coverage Δ

promutils/labeled/counter.go
40.74% <100.00%> (ø)

promutils/labeled/gauge.go
41.81% <100.00%> (ø)

promutils/labeled/stopwatch.go
66.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 176da91...d9f5430. Read the comment docs.


Improve error message "No dependencies recognized!"

The error "No dependencies recognized!" is hard to debug. I'm stumbling upon this one for a basic Gradle (5.6) project and can't figure out what's wrong.
license_finder --debug should display more information about where the dependencies are looked for and what is expected.
build.gradle:
plugins {
    id "com.github.hierynomus.license" version "0.15.0"
}

Command:
license_finder --debug
LicenseFinder::GoModules: is not active
LicenseFinder::GoDep: is not active
LicenseFinder::GoWorkspace: is not active
LicenseFinder::Go15VendorExperiment: is not active
LicenseFinder::Glide: is not active
LicenseFinder::Gvt: is not active
LicenseFinder::Govendor: is not active
LicenseFinder::Trash: is not active
LicenseFinder::Dep: is not active
LicenseFinder::Bundler: is not active
LicenseFinder::NPM: is not active
LicenseFinder::Pip: is not active
LicenseFinder::Yarn: is not active
LicenseFinder::Bower: is not active
LicenseFinder::Maven: is not active
LicenseFinder::Gradle: is active
LicenseFinder::CocoaPods: is not active
LicenseFinder::Rebar: is not active
LicenseFinder::Nuget: is not active
LicenseFinder::Carthage: is not active
LicenseFinder::Mix: is not active
LicenseFinder::Conan: is not active
LicenseFinder::Sbt: is not active
LicenseFinder::Cargo: is not active
LicenseFinder::Dotnet: is not active
LicenseFinder::Composer: is not active
LicenseFinder::Gradle: no command defined

No dependencies recognized!

Version:
license_finder version
5.11.1

@outsideMyBox This would not be a trivial fix. We would need to add different reasoning for every package manager that LF supports. In this case, it looks like the problem is here: https://github.com/pivotal/LicenseFinder/blob/f24a5630db16448eb52f744f58ddf1ad97fccace/lib/license_finder/package_utils/gradle_dependency_finder.rb#L11
It is saying that there is no dependency-license.xml file created so there is no dependencies found. The plugin creating that file is found here: https://github.com/hierynomus/license-gradle-plugin
Not sure why it isn't creating one in your case.

I faced the same issue of having "No dependencies recognized!". I'm using
gradlew: 6.8.3
However, I confirm that the dependency-license.xml has been generated in {projectRootFolder}/build/reports/license. @outsideMyBox you might wanna check for yourself if it is there. Just that for me, the xml file contains nothing, which explains the "No dependencies recognized!".
I checked that I included id "com.github.hierynomus.license" version "0.15.0" in my root level build.gradle file and that's all. I did not override any default arguments for the downloadLicense task.
But I'm stuck here. Have you guys fixed the issue?

FYI hierynomus has updated to 0.16.1. The original issue here is weird because it is saying that there is no gradle command given. The version they are using of license finder is very old though. What you can try is to specifically run the plugin by adding it to your gradle and running ./gradlew downloadLicenses If the xml is empty, its probably a problem with your build setup


Fix duplicated conditions.

drivers/unix/net_socket_posix.cpp: In member function 'NetSocketPosix::NetError NetSocketPosix::_get_socket_error()':
drivers/unix/net_socket_posix.cpp:197:22: warning: logical 'or' of equal expressions [-Wlogical-op]
  197 |  if (errno == EAGAIN || errno == EWOULDBLOCK)
      |                      ^

editor/import/editor_scene_importer_gltf.cpp:2082:124: warning: this condition has identical branches [-Wduplicated-branches]
 2082 |      animation->track_set_interpolation_type(track_idx, track.weight_tracks[i].interpolation == GLTFAnimation::INTERP_STEP ? Animation::INTERPOLATION_NEAREST : Animation::INTERPOLATION_NEAREST);

drivers/unix/net_socket_posix.cpp: In member function 'NetSocketPosix::NetError NetSocketPosix::_get_socket_error()':
drivers/unix/net_socket_posix.cpp:197:22: warning: logical 'or' of equal expressions [-Wlogical-op]
 197 |  if (errno == EAGAIN || errno == EWOULDBLOCK)
     |                      ^

See https://stackoverflow.com/a/4058377, it looks like for portability's sake we do need to check both.

See https://stackoverflow.com/a/4058377, it looks like for portability's sake we do need to check both.

Works for me, thus I can ignore the warning for the function.

@reduz Please make a separate commit into master with fix of editor/import/editor_scene_importer_gltf.cpp. I will then update this PR where I'll just add the warning and exception for NetSocketPosix::_get_socket_error function.

@reduz Please make a separate commit into master with fix of editor/import/editor_scene_importer_gltf.cpp. I will then update this PR where I'll just add the warning and exception for NetSocketPosix::_get_socket_error function.

It's a different warning, so I'm sending a fix right now.

Sorry for the late review. Could you add a comment explaining why this warning is being ignored on this code chunk?

Would be good to add a comment, otherwise that's fine.

Done. And I also enabled the warning in SConstruct file.

The new warning found another occurrence:
modules/mono/utils/string_utils.cpp: In function 'int {anonymous}::sfind(const String&, int)':
modules/mono/utils/string_utils.cpp:68:48: error: logical 'or' of collectively exhaustive tests is always true [-Werror=logical-op]
      found = src[read_pos] == 's' || (c >= '0' || c <= '4');
                                       ~~~~~~~~~^~~~~~~~~~~

@neikeq - guess it's meant to be &&?

It fails building on Clang which doesn't know this warning.

@neikeq - guess it's meant to be &&?

Looks very likely to me, I'm updating the pull request.

It fails building on Clang which doesn't know this warning.

I've fixed that, thanks.

@akien-mga It survives tests, can you please merge it?

Thanks!


Entering the command code in a wsl2 bash terminal doesn't invoke vscode

Issue Type: Bug
I followed the instructions for installing vscode to the letter on two different windows PC's as a system install. One running Windows 10 Pro and WSL1 and the other Windows 10 Pro Insider Preview with WSL2. On neither machine was the code command available in WSL.
How do I get it to add the path to my ubuntu $PATH ?
VS Code version: Code 1.45.0 (d69a79b73808559a91206d73d7717ff5f798f23c, 2020-05-07T16:18:48.860Z)
OS version: Windows_NT x64 10.0.19624
Remote OS version: Linux x64 4.19.104-microsoft-standard

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz (4 x 3504)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.89GB (6.29GB free)

Process Argv

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: Ubuntu-18.04

OS
Linux x64 4.19.104-microsoft-standard

CPUs
Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz (4 x 3503)

Memory (System)
12.40GB (11.22GB free)

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

remote-wsl
ms-
0.44.2

Not sure if it's the exact same issue, but I ran into this too. Did a fresh WSL2 install and suddenly code . is working anymore. Saying it can't find Code.exe.

Worth noting that opening VSCode, opening a WSL Code via Remote-WSL: New Window, and then using code . through that integrated terminal works.
Worth noting that this worked on the same machine, all that changed was a fresh Ubuntu install.


Update test suite

Drop 3.7 and update to latest holoviz-tasks

Codecov Report

Merging #474 (bdae169) into main (51d5400) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   69.22%   69.19%   -0.04%
==========================================
  Files          78       78
  Lines        9054     9054
==========================================
- Hits         6268     6265       -3
- Misses       2786     2789       +3

see 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


.Net 5?

Are you planning to update to .net 5 and maybe even VS 2019 extensions?
I am doing a new project where I need custom graph traversing, so I see a lot of value in TSL and graph engine, but don't want to start using GE if it is not going to be updated anymore.
If not GE what would you recommend to look at?

@alenas Hello - yes, I've already moved to support both .NET 3.1 LTS and .NET 5. I've also updated the VS 2019 Extension with a few improvements and bug fixes. We made a lot of updates to Graph Engine and I will post updates in a week or new with the next Nuget Packages. The GE is not been abandoned and you can expect to see updated docs, a new developer's guide, a TSL modeling design guide and enhancements to Graph Engine for Service Fabric, and more options for Graph Traversal with using LIKQ.

@alenas Hello - yes, I've already moved to support both .NET 3.1 LTS and .NET 5. I've also updated the VS 2019 Extension with a few improvements and bug fixes. We made a lot of updates to Graph Engine and I will post updates in a week or new with the next Nuget Packages. The GE is not been abandoned and you can expect to see updated docs, a new developer's guide, a TSL modeling design guide and enhancements to Graph Engine for Service Fabric, and more options for Graph Traversal with using LIKQ.

Good to hear @TaviTruman. I can help you guys with bug fixes or testing, if you have something that is easy to delegate.

Good to hear @TaviTruman. I can help you guys with bug fixes or testing, if you have something that is easy to delegate.

@alenas That's awesome as there's a lot to do. We need help with testing for sure; keep an eye out as we are working to produce docs that describe what needs to be done.

@alenas That's awesome as there's a lot to do. We need help with testing for sure; keep an eye out as we are working to produce docs that describe what needs to be done.

Hi. Any news?

@alenas Yes, we have the .NET 5 build ready to go; we just want to fix a few things in the CI/CD build and we will have a new place to download NuGet packages. I am working to release it on Friday morning.

@TaviTruman I guess you need some help 😄

@alenas Hey there - I've got it done; however, I've been out due to surgery. I will make the new build and NuGet package available come Monday new week,

No worries @TaviTruman. Get well. Your wellbeing is more important than this.

@alenas I've got the new build ready it supports. netcoreapp2.0,. netcoreapp3.1 and .net5.0. I will try to merge lots of updates today.

Cool. I will wait patiently ;)

bump :-)

@alenas @mwherman2000 I have the build ready to go but need to set up a new NuGet Feed; I should have it ready tomorrow.

bump :)

Sorry guys - I've been out for a few weeks due to surgery; I will get this done this week.

I've settled in on .NET CORE 3.1 for a variety of reasons ...mostly dependencies on C# OSS project dependencies.

@TaviTruman HI pal, hope you recovered form your surgery now. Any news on the the updates ?

@TonyLo1 Hello here :-) I'm feeling much better now; took me way longer to recover from surgery. To answer your questions yes I'm ready to publish this week.

@TaviTruman  that’s great news on both fronts. Thank you for your tireless efforts to improve the project.

@TonyLo1 I'm unable to apply direct updates to this repo but all I maintain an up-to-date repo here: https://github.com/InKnowWorks/GraphEngine. There are many updates here as well as bug fixes as well. .NET 5 and .NET 6 support is ready. I've also added a lot of new capabilities - we have been working to update code generation so that we can take advantage of the latest advances in .NET and C#; we are also working on native client-side code for Java 17 and RUST. We are also looking to see what support for Python there is. I've written a Developers Guide but it is still a work-in-progress. I will provide an updated Readme file and general news on my repo home page.

@TonyLo1 I'm going to post a new build today. I'll send out a note regarding this build this evening.

@TaviTruman Greate job. I use neo4j in past years.  As a .net fans, I expect an excellect  graph db/engine .net related tightly all the time.  But this repo no update too long time.

@engine5d Thanks! neo4j is a great technology. Graph Engine is a fantastic technology but quite different when compared to technologies like neo4j. Microsoft does not seem to have any resources committed to this repo as you can see there is very little movement here. I do have a forked version of this repo: https://github.com/InKnowWorks/IKW-GraphEngine, and we are working on a lot of upgrades. We are working to continue the amazing work that Microsoft Research started some ten years ago. I have a small team working on improvements but will be adding more resources this year and into the future.

I'm curious about the kinds of software systems people are using the Trinity GraphEngine for?
Personally, I'm using Trinity to design and implement a decentralized agent architecture based on the W3C decentralized identifier and verifiable credential draft specifications.

@mwherman2000  We are planing to use GE for storing and query digital-twin data in local or distribute environments. we need to test the GE max capability for load digital-twin billions of instances. @TaviTruman

Here is a link to a commercial application that is 100% Graph Engine:

https://www.rocketurbiz.com/overview
https://www.rocketurbiz.com/developers

Here is what we are about ready to release in our next Graph Engine release:

https://github.com/InKnowWorks/IKW-GraphEngine

We are building a tool-chain for ontology-based software engineering and the Graph Engine sits at the center."

https://www.inknowworks.com/

I've bumped .NET from 3.1 to 6.0. I will close the issue later if you don't have further questions with regard to .NET support. Thank you, @alenas @TaviTruman @mwherman2000 @TonyLo1 @engine5d!


KafkaSource: Fixed wrong error logging during reconciliation

Signed-off-by: Francesco Guardiani<EMAIL_ADDRESS>From https://github.com/knative/eventing-contrib/issues/1291#issuecomment-638221293

/assign

/retest

/retest

Seems like it's a consistent failure on kafkasource tests aka i broke something :)

@slinkydeveloper Or the tests are problematic.


fix: Ensure status variable is properly quoted in conditional checks …

Description:
This change addresses a potential issue in the script where the status variable was not enclosed in quotes during conditional checks.
Unquoted variables can lead to unexpected behavior if the variable is empty or contains characters that disrupt the shell syntax. For instance, if the status variable is empty, the conditional checks like [ $status -eq 0 ] will throw an error and cause the script to fail. By adding quotes around $status, we ensure robust handling and prevent such runtime errors.
This fix enhances the script's reliability and prevents unexpected termination in edge cases.

probably ok

Merge activity

Dec 18, 2:13 PM EST: A user started a stack merge that includes this pull request via Graphite.

Thank you!


Issue 61 - Add Superseded Info to Get Products API

Added is_published filter parameter and excluded superseded products.
Note this also closes issue #62 because they are using the same model method internally. Although I went ahead and implemented it, I want to confirm this produces the expected behavior for the search scraper use case. If a product is indexed and then later superseded, how does the search index deal with that if the product updates view excludes superseded products?

Confirmed that new versions of products will have the same UUID to allow search indexing to keep in sync, therefore it's safe to exclude the original superseded products from the feed.

LGTM


Cannot use sct with mechanic/boontable

Cannot drag the pannel of boontable when use act.
Cannot load correct fonts of boontable.
http://martionlabs.com/arcdps-mechanics-log-plugin/

The boon table cannot load my own font with  the latest dev version as well, but sct options can.

I'll try to reproduce this and have a look into it later in the coming week.

Nodoooka He made the Chinese version of Marion Laboratories' Boon Table, but because he doesn't have the source code, he replaces it with a binary, but there is a problem with your sct coexistence.
If you don't use sct, Martion Laboratories' Boon Table can load fonts normally. If you use sct, Boon Table can't load fonts normally. The same is true with the #1 local version of sct. I think there may be a problem with "calling", or It is reassigned


Unable to load .osm file

Hi,
I am ultimately trying to create a network dataset of greater NYC using the create OSM Network Dataset tool, but currently, I am running into the problem of not being able to load any .osm files at all. I am using ArcGIS10.8.1. I've tried both the 32 and 64-bit versions of the editor tool. I've tried running it in the background and foreground. I've tried using the full file loader and just the load-only loader. I've tried running it with cutouts straight from OSM, queries I've run myself, and the simplest .osm file I can generate, but I keep getting the same error very early on.

Start Time: Mon Aug 16 22:13:40 2021
Counting elements in OSM file...
Counted 2275006 nodes, 175525 ways, and 4 relations.
Preparing geodatabase...
Object reference not set to an instance of an object.
at ESRI.ArcGIS.OSM.GeoProcessing.OSMGPFileLoader.Execute(IArray paramvalues, ITrackCancel TrackCancel, IGPEnvironmentManager envMgr, IGPMessages message)
Failed to execute (OSMGPFileLoader).
Failed at Mon Aug 16 22:15:16 2021 (Elapsed Time: 1 minutes 36 seconds)

The object reference not set to an instance of an object, but I can't track down anything more specific inside the OSMGPFileLoader, and I'm pretty sure its not the input file. If I give it an input with nothing at all, just header and closer, it runs trivially, but including even 1 node causes it to break. I'm attaching the file with 1 node. Hopefully, this is enough to find something.
Thanks
test.txt

Update: I had a colleague download the 10.8 editor and take a fresh cut from OSM, and he got the same error. I then found a copy of ArcMap 10.7, downloaded the 10.7 editor, took a fresh cut from OSM, and got the same error.

Fascinating update: I found a copy of 10.5, and it worked to load an OSM file once, but the second file attempt gave the same error

@hdd3NYU Can you post the parameters you're using when running the tool? It's possible that an unusual path or something like that is causing the tool to fail.

Which parameters are you referring to? My file path does go through OneDrive if that is useful but other than that it's just C:/User/etc...

When you execute the gp tool as the messages are displayed, you should see the parameters on how the tool is being executed as one one of the very first entries in the messages section -
Messages
Executing: OSMGPMultiLoader C:\Users\thomas\Downloads\andorra-latest.osm # # # DELETE_NODES DO_NOT_DELETE_OSM_FILE C:\data\osm_testing.gdb\andorra_pt C:\data\osm_testing.gdb\andorra_ln C:\data\osm_testing.gdb\andorra_ply
Start Time: Fri Aug 20 18:16:21 2021
Counted 248722 nodes, 12900 ways, and 288 relations.
Loading nodes...

Executing: OSMGPFileLoader "C:\Users\H3's Machine\OneDrive -<EMAIL_ADDRESS>PHD\Research\Freight Analysis\OpenStreeMap\HuntersPoint.osm" CONSERVE_MEMORY # "C:\Users\H3's Machine\OneDrive -<EMAIL_ADDRESS>PHD\Research\Freight Analysis\OpenStreeMap\Testing16Aug\HPtest" "C:\Users\H3's Machine\OneDrive -<EMAIL_ADDRESS>PHD\Research\Freight Analysis\OpenStreeMap\Testing16Aug\HPtest\HPtest_osm_pt" "C:\Users\H3's Machine\OneDrive -<EMAIL_ADDRESS>PHD\Research\Freight Analysis\OpenStreeMap\Testing16Aug\HPtest\HPtest_osm_ln" "C:\Users\H3's Machine\OneDrive -<EMAIL_ADDRESS>PHD\Research\Freight Analysis\OpenStreeMap\Testing16Aug\HPtest\HPtest_osm_ply"
Start Time: Fri Aug 20 21:36:00 2021

I am not seeing the name of either an enterprise or a file geodatabase in the path name. For my parameters you see something to the extend of 'C:\data\osm_testing.gdb' as a file geodatabase on my local hard disk.
If you are using the user interface in ArcMap, then additional error checking will take place and flag invalid storage locations.
In your case, something like "C:\Users\H3's Machine\OneDrive -<EMAIL_ADDRESS>PHD\Research\Freight Analysis\OpenStreeMap\Testing16Aug\OSMData.gdb\HPtest" might work as the target feature dataset. The additional feature class locations will should then be derived by the gp tool from that.

I was trying to load file of entire country (india). and convert it to network dataset. but I'm stuck at loading the file. I get error immediately after executing the tool. Anyone please help or suggest any other way to create a network dataset. Thank you.

I was trying to load file of entire country (india). and convert it to network dataset. but I'm stuck at loading the file. I get error immediately after executing the tool. Anyone please help or suggest any other way to create a network dataset. Thank you.

As I mentioned above, I literally had to go find an old copy (shout out to my university) and run it fresh on a machine that had never tried the conversion before


Algorithm Problem

Hi,
I read your code. I have some questions about the code details.
When using the ST-RNN, the masks are input into GRU as a parameter. Could you explain why you did this? What is the function of masks input？
Thanks!

Hi,
The masks are the same as "done" in the gym environment. If an episode is done, we use masks to clear the hidden states of GRU to all zeros. See [this line].(https://github.com/Shuijing725/CrowdNav_DSRNN/blob/88f9209da0c1572489d9dfc25ceb3e5497bc2517/train.py#L177)


Add min_score_confidence support for the Bedrock KB retriver

Add min_score_confidence support for the Bedrock KB retriver

add min_score_confidence field to AmazonKnowledgeBasesRetriever class
add unit tests and integration tests to test score
update kendra retriver _filter_by_score_confidence doc string

Closes: https://github.com/langchain-ai/langchain-aws/issues/48

cc @rozerarenu to review this PR.


Automated cherry pick of #4887: validate share on delete, update pulibc scope on mark standard

Cherry pick of #4887 on release/2.13.
#4887: validate share on delete, update pulibc scope on mark standard

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.13@b5900e6). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.13   #4894   +/-   ##
==============================================
  Coverage                ?   6.85%
==============================================
  Files                   ?     523
  Lines                   ?   89201
  Branches                ?       0
==============================================
  Hits                    ?    6119
  Misses                  ?   82574
  Partials                ?     508

Flag
Coverage Δ

#aFlag
6.85% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5900e6...761edb9. Read the comment docs.


Development: Make sure to unsubscribe from all observables in the tutorial groups client code

Checklist
General.

[x] This is a minor issue that I tested locally and was confirmed by another developer on a test server.

Motivation and Context

Improved tutorial group client code quality by making sure to unsubscribe from all observables (I know angular has built-in unsubscribe for some of them, like route params and HTTP, but I find it better to make sure not to rely on these built-ins). The subscriptions are cleaned up when the component is destroyed, protecting against memory leaks

Description

Followed the unsubscribe pattern recommended here: https://stackoverflow.com/questions/38008334/angular-rxjs-when-should-i-unsubscribe-from-subscription

Steps for Testing
Nothing to test, really.
Review Progress
Code Review

[ ] Review 1
[ ] Review 2

Test Coverage
No Changes

Codecov Report
Base: 79.90% // Head: 75.60% // Decreases project coverage by -4.30% :warning:

Coverage data is based on head (3ef2bf3) compared to base (a1ba7f2).
Patch coverage: 90.82% of modified lines in pull request are covered.

:exclamation: Current head 3ef2bf3 differs from pull request most recent head 74ee6c5. Consider uploading reports for the commit 74ee6c5 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5859      +/-   ##
=============================================
- Coverage      79.90%   75.60%   -4.31%
=============================================
  Files           2115     1108    -1007
  Lines          83728    43827   -39901
  Branches       12539     8268    -4271
=============================================
- Hits           66906    33136   -33770
+ Misses          9351     5576    -3775
+ Partials        7471     5115    -2356

Flag
Coverage Δ

client
75.60% <90.82%> (+0.04%)
:arrow_up:

server
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...cancellation-modal/cancellation-modal.component.ts
83.78% <73.33%> (+2.53%)
:arrow_up:

...ns/tutorial-group-session-row-buttons.component.ts
91.11% <73.33%> (+0.86%)
:arrow_up:

...utorial-groups/course-tutorial-groups.component.ts
78.57% <75.00%> (+0.79%)
:arrow_up:

...utorial-group-free-period-row-buttons.component.ts
94.28% <83.33%> (+0.73%)
:arrow_up:

...ow-buttons/tutorial-group-row-buttons.component.ts
95.34% <85.71%> (+0.75%)
:arrow_up:

...ial-groups-registration-import-dialog.component.ts
81.73% <88.23%> (+0.08%)
:arrow_up:

...utorial-group-free-periods-management.component.ts
91.83% <88.88%> (+0.92%)
:arrow_up:

...nt/tutorial-group-sessions-management.component.ts
84.09% <88.88%> (+1.16%)
:arrow_up:

...gistered-students/registered-students.component.ts
70.96% <100.00%> (+2.00%)
:arrow_up:

...iod/create-tutorial-group-free-period.component.ts
85.71% <100.00%> (+2.38%)
:arrow_up:

... and 1019 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

please get more approvals. 1 is not enough


Added Face API endpoint to the CS Face API Tutorial

The API now fails if you point it at an API endpoint that is different than the one that the key was created for.  I modified the steps code in the tutorial to make sure the reader notes their Face API endpoint when the keys are assigned, and specifies that endpoint with the face service client is created.

@BretStateham,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@BretStateham : Thanks for your contribution to the Azure documentation! The author, @v-royhar, has been notified to review your proposed change.

@BretStateham @Kaiqb Bret thank you for your contribution! If you can fix the merge conflict we can probably accept your change. Or, close this pr, and make the same change in a new pr with the current version of the file.

@BretStateham let me know if you need help with this. I will close it for now.


Move from Travis CI to Community Jenkins

The community uses https://jenkins.dataverse.org for different projects.
This project should move its CI testing from Travis to this service for sustainability.

Move or add?
https://github.com/AUSSDA/pyDataverse is tested on both Travis and Jenkins:

Travis: https://travis-ci.com/AUSSDA/pyDataverse
Jenkins: https://jenkins.dataverse.org/job/pyDataverse/

Why not both? 😄

Simple: the GitHub Pull Request Plugin allows filtering pathes, so Image builds will only happen when images are affected. Kubernetes stuff will only be tested when it is affected. This is not easy to achieve with Travis...

Hello World!

Since @poikilotherm have been talking about bots at http://irclog.iq.harvard.edu/dataverse/2019-06-27#i_99199 and I didn't know how he got @dataverse-bot to say something, I asked and he shared this screenshot:

Very cool stuff. I was telling him that I've seen commands @glassfishrobot Run CI tests please in pull requests at https://github.com/javaee/glassfish/pulls


GEODE-5533 Support Gradle 4.9 publication enhancements

Upgrading to Gradle 4.9 broke publish/install due to a non-existent jar
output from geode-assembly. More diligent pruning of the archives
configuration has fixed the problem.
Co-authored-by: Robert Houghton<EMAIL_ADDRESS>Co-authored-by: Patrick Rhomberg<EMAIL_ADDRESS>Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[x] Does gradlew build run cleanly?

[x] Have you written or updated unit tests to verify your changes?

[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

@upthewaterspout info is a non-default flag that would need to be set to get the output

@rhoughton-pivot Since this was only caught by doing install let's add install to the CI pipeline. Perhaps as part of the Build job.

@pivotal-jbarrett Added


Replace single quotes for import with double quotes

Reasoning:
When attempting to use the automatically provided snippet that utilises single quotes, the Solidity compiler throws the following error when trying to import the Task.sol file (which is in the same directory as the entry point .sol file being compiled):
Error compiling contracts
exit status 1; acc3bfbc0bcdda1626fe732d723192a145bcda0fee759662e0d76790a8336595.sol:1:1: Error: Source not found: File not found.
import 'Task.sol';
^----------------^

Replacing the single quotes with double quotes resolves this misleading error.

Thanks @bkrem =]

This and #3 have been published in v0.3.2

Awesome, thank you for the fast fixes!


In Desktop Cannot Scroll

Using this plugin, with tailwind css 3.18, the scroll bar gets hidden. But in desktop cannot scroll with the mouse or keyboard.

hi, repro?
like this
https://play.tailwindcss.com/DfHZcGih7B?size=598x720

https://play.tailwindcss.com/O34guOHwtx
Made the above. If you check in desktop it does not scroll. If you have put the mouse over the div also you cannot drag, which you can do if the scrollbar is there

You can check on devcms.foodxp.com/watch where we have used your excellent work. In mobile viewport you can drag the scroll but in desktop you cannot.

this is gestures for phone, not working in desktop, we need use grab cursor libraries, like swiper )


Example14 - AdePT integration with Geant4

This introduces an integration interface based on the GPU workflow adopted in Example13 and combined in a standard Geant4 CPU workflow:

arbitrary geometry via gdml file (/example14/detector/filename command) and optionally a magnetic field with constant Bz (/example14/detector/setField command)
physics list on the CPU, either HepEm or G4Em. HepEm physics on GPU.
a GPU region declared by the user (/example14/detector/regionname command) where entering particles are killed in the Geant4 application and handed over to the GPU. Particles are buffered to a threshold for a given event, then the whole batch is showered on GPU. The particles escaping the GPU region are put back to the Geant4 stack.
scoring per placed volume, based on a list of sensitive volumes declared by the user (/example14/detector/addsensitivevolume command. The hits produced on GPU by every batch are copied back to host and converted to Geant4 application hits (feature still being worked out)
a first attempt of abstracting the user scoring, by using a scoring type providing some basic interface, and typedef-ing AdeptScoring to this type in a header file. The user can provide then alternative implementations and only change the typedef.
the GPU integration is done via a specific G4VFastSimulationModel that instantiates one AdeptIntegration object per CPU worker thread. The different AdeptIntegration share on GPU the geometry and physics data structures, but work with independent track containers and streams.
The integration can be (de)activated using the command /param/(De)ActivateModel model
The example requires a change in Geant4 main transportation loop to flush the fast sim model buffer, so this will compile but not run correctly without the change

This is still WIP, it still has bugs in the mechanism of handing over tracks from GPU to host, but we've shared it so people can already have a look and comment. There are still a few areas to be cleaned up (related to hits, docs)

I tried running example14, but it wasn't overly successful:

It seems that you need the patch for Geant4 to add G4VFastSimulationModel::Flush. Not that anything during the build would complain because the method is only marked virtual ... final and not override, but I guess otherwise particles are left in the buffer forever?
When trying to run regardless, I'm buried with tons of debugging output. Is there a way to turn this off / down to an acceptable level?
I'm not even sure example14.in runs to completion; I've let it run for 5 minutes, it used 15 GB of memory, and produced 3.6 GB of log output!

It is expected to have this behaviour, I've made the PR even if the code is not yet in a working state so that comments on code can be made. The debugging output will be of course removed once the bug is fixed.

Andrei, did you put the Geant4 patch that I send you anywhere in Git? Maybe, for the time being we can simply put it in the example directory, so people can easily apply it.

I just did

Now we can compare scoring per placed volume in G4+AdePT vs. G4 standalone. There are big differences at this point per layer (up to 10%) pointing to remaining bugs. This is in magnetic field 0.1T.

Fixing the random seed sequence makes the comparison with Geant4 look much better

.

Thanks for the UI command to disable AdePT, now it's possible to test fully multi-threaded Geant4 and running on the GPU using the same binary, just using different macros. However, with a bit of testing on the CPU, I'm quickly getting crashes in Example14SensitiveDetector::RetrieveAndSetupHit. It looks a lot like memory corruption, sometimes segfaulting and some other times a  call to free failing with "invalid pointer"...

However, with a bit of testing on the CPU, I'm quickly getting crashes in Example14SensitiveDetector::RetrieveAndSetupHit. It looks a lot like memory corruption, sometimes segfaulting and some other times a call to free failing with "invalid pointer"...

This is hopefully fixed with my last commit. For G4 scoring and finding the hit id in the example, we rely on a mapping between the runtime G4VPhysicalVolume pointer and the VecGeom placed volume id. This requires the AdePT interface to be instantiated and initialized for the common data (G4HepEm physics + auxiliary volume data), even if we don't allocate GPU storage for tracks and everything else. It seems to work in my simple test, but please let me know if I missed something.

Why is the updating of regions and couples needed in the detector construction?
I guess because we load region settings from the GDML, triggered by the detector construction, so these are intrinsically coupled with geometry. I'm not sure if the GDML parser does more than storing temporarily the auxiliary volume info and letting the user deal with it. Probably this can be done much better, but I guess we'll need to postpone some of the design problems of the integration after merging. I would try to merge this as soon as we are at least happy with correctness and we are able to run in all modes that we want to test, and postpone the non-critical fixes.

I guess because we load region settings from the GDML, triggered by the detector construction, so these are intrinsically coupled with geometry. I'm not sure if the GDML parser does more than storing temporarily the auxiliary volume info and letting the user deal with it. Probably this can be done much better, but I guess we'll need to postpone some of the design problems of the integration after merging. I would try to merge this as soon as we are at least happy with correctness and we are able to run in all modes that we want to test, and postpone the non-critical fixes.

Did you test this? Loading GDML also loads all regions and if return the G4VPhysicalVolume from DetectorConstruction::Construct, the Geant4 kernel will take care of the rest.

However, with a bit of testing on the CPU, I'm quickly getting crashes in Example14SensitiveDetector::RetrieveAndSetupHit. It looks a lot like memory corruption, sometimes segfaulting and some other times a call to free failing with "invalid pointer"...

This is hopefully fixed with my last commit. For G4 scoring and finding the hit id in the example, we rely on a mapping between the runtime G4VPhysicalVolume pointer and the VecGeom placed volume id. This requires the AdePT interface to be instantiated and initialized for the common data (G4HepEm physics + auxiliary volume data), even if we don't allocate GPU storage for tracks and everything else. It seems to work in my simple test, but please let me know if I missed something.

Now it works if you call /param/InActivateModel AdePT. The provided testEm3G4.in doesn't do this right now and this fails during Flush.

Did you test this? Loading GDML also loads all regions and if return the G4VPhysicalVolume from DetectorConstruction::Construct, the Geant4 kernel will take care of the rest.

No, what I tested is that removing this logic from the detector construction doesn't work any more. So unless you can point me to a quick fix, I propose postponing this.

Indeed, it crashes because G4HepEm doesn't find any material-cuts couples. The reason is that you're trying to initialize physics in Example14DetectorConstruction::ConstructSDandField which is before the Geant4 kernel sets everything up in /run/initialize. The problem is that this is wrong because users can change physics settings via the macro and call /run/initialize again. So the correct fix here is to build physics tables only when Geant4 tells us to do that, which may happen multiple times during execution.

So the correct fix here is to build physics tables only when Geant4 tells us to do that, which may happen multiple times during execution.

The current schema of bundling integration with the fast sim model and initializing at an inappropriate phase is clearly generating problems and will need to be eventually fixed, but the fix is non-trivial AFAICT and I proposed postponing it to be able to do tests with the integration. Any objection to that?

So the correct fix here is to build physics tables only when Geant4 tells us to do that, which may happen multiple times during execution.

The current schema of bundling integration with the fast sim model and initializing at an inappropriate phase is clearly generating problems and will need to be eventually fixed, but the fix is non-trivial AFAICT and I proposed postponing it to be able to do tests with the integration. Any objection to that?

The important question here is: Can this be solved with the design centered around G4VFastSimulationModel? I don't see hooks that would allow us to properly build physics tables at the right time.

The important question here is: Can this be solved with the design centered around G4VFastSimulationModel? I don't see hooks that would allow us to properly build physics tables at the right time.
I think we diverge from what we try to do now. This is definitely not the final solution to be given to the user, and it has clear limitations, but it was started like this to demonstrate the functionality and to be able to do some performance measurements. So let's keep this discussion in mind, but move on to the current May goal.

I've added the conditional compilation of this example only if the Geant4 Flush feature is detected. Now the macros and geometry are placed in a separate macros directory and installed in the build directory, and the example comes with 2 tests. I did also a bit of extra cleanup and removed the G4 patch files. I think this is ready for a final review.

I think for merging we should squash.

I did also a bit of extra cleanup and removed the G4 patch files.

I think the patch files must be kept as long as there is no public version of Geant4 with the added interface.

I did also a bit of extra cleanup and removed the G4 patch files.

I think the patch files must be kept as long as there is no public version of Geant4 with the added interface.

Right... I'll put them back in a patches folder.


Select after csv import gives wrong values

Hi,
I'm using the sqlite3 backend. When I populate a table from csv and make a select from soci, in the first row are always zeros.
That's how I create the table.
create table test(
	a double not null,
	b double not null,
	c double not null,
	primary key (a, b)
	);

that's the "test.csv":
a, b, c
1,1,1
2,2,2
3,3,3

and that's how I load the values from the csv into my table:
.mode csv
.import test.csv test

some defines for understanding what's happening
and that's how I make the query (shortend, to be easier to understand ;))
    soci::rowset<soci::row> rs = db.prepare << "select a, b, c from test";
    std::vector<std::vector<double>> res;
    for (auto& row : rs)
    {
      std::vector<double> rowVec;
      for(size_t i = 0; i != row.size(); ++i)
      {
        const auto& props = row.get_properties(i);
        switch(props.get_data_type())
        {
        case soci::dt_double:
          rowVec.push_back(row.get<double>(i));
          break;

        default:
          break;
        }
      }
    res.push_back(rowVec)
  }

If I add some useless where clause in the sql statement, like "select a, b, c from test where a < 50"; everything works as expected.
Any idea what may cause the problem?

It seems pretty obvious that your import imported zeroes into the database. Please check it using sqlite interactively.

Sorry, but I don't. With the same select in the sqlite3shell I don't get the zeros.

@vadz Unfortunately I can't upload the database directly, but I attached a zip file. It contains a .patch file, with a test case for test-sqlite3.cpp , a data base file with just one table "test" and the csv file I used for importing the data. If you apply the patch file and copy the data base file for example to the bin directory containing the test executable, you can run the test and just make the select on the table in the command line. So it should be easy to verify the bug.
soci_test.zip

So is CSV a red herring then? I.e. can you reproduce the problem by doing normal inserts into the database?
Because while I can believe that there is a bug in SOCI rowset API when working with SQLite (still weird that nobody has found it until now, but possible), it seems completely impossible that it usually works but doesn't work when the database was populated via CSV import. IOW, this bug should be reproducible without involving any CSV at all.

P.S. I've just realized that your username looked familiar, sorry for not recognizing it initially!

I wasn't able to reproduce it without the csv import. When I fill the table with inserts everything works as expected.
And, as I wrote above, when adjusting the query and add a "where a < 5" for example, it works as well and doesn't return the zeros.

Sorry, I just don't see how is it possible. SOCI doesn't care or know how was the database filled, so its behaviour can't possibly depend on it if the database data is really the same in both cases. This is why I was so sure initially that it wasn't, i.e. that CSV import has simply created an extra row of zeroes. If this is not the case, I have no idea what's going on. Looking at your code more carefully now, I wonder what exactly is it supposed to do, i.e. why do you use row.push_back()?
I don't use SOCI with SQLite myself, so I'm afraid I don't have time/motivation to investigate this, but something seems really fishy here.

In my code above is a mistake. I used "row" two times. It was a bit too fast copy&paste plus shortening. The example from the zip file is better. I'll edit the code above to correct this.
So, in fact the code has a vector of vectors (I know, it's not the best representation for a table) and I just write the values in a vector.
I the real code it's more type independent to fit in the interface of our application and in all other cases it has worked like a charm. But it's the first time I used a csv import to fill a table. And to make it reproducible, I'll shortened the code to show the essential part here.
To be  honest, until today I used soci more or less like a black box. Shortly, I tried to debug inside soci today to find the problem myself, but since I'm not familiar with the implementation details I need more time for that.

All right, I'd a deeper look into this today. It seems that soci is right.
It's a mix of my fault and an interesting behavior of sqlite:
First, it would be good, if I had read the sqlite documentation more carefully. If the table already exists, the csv import interprets the first row as content, but I had the column names in it. During the insertion, sqlite doesn't check the types and inserts everything.
In the reading operation in post_fetch soci calls sqlite3_column_double() which ends in calling memRealValue which itselft calls sqlite3AtoF().
What happens here is: sqlite3 tries to interpret the value as double and tries to convert it. Since it cannot convert the value it writes a zero to the value pResult field and returns zero to indicate that it couldn't convert the value. But the calling function memRealValue ignores the return value so we don't have any information if the conversion was successful.
It looks like the sqlite3shell uses another functionality for select statements which doesn't ignore the return value of qlite3AtoF() and filters the not convertibles out.

I guess SOCI could get the column value as text and perform the conversion itself instead of relying on sqlite3_column_double(), but I don't know if it's really worth it. In principle, SOCI attaches more importance to types than SQLite, but I'm not sure if we can really make interface with SQLite typesafe, even if we try...


URL in Problem.Type doesn't exist

// Inflate expands a problem with contextal information.
// At present it adds the request's id as the problem's Instance, if available.
func Inflate(ctx context.Context, p *P) {
	//TODO: add requesting url to extra info

	//TODO: make this prefix configurable
	p.Type = "https://stellar.org/horizon-errors/" + p.Type

	p.Instance = requestid.FromContext(ctx)
}

https://github.com/stellar/horizon/blob/08885e0bae6fb2eb5ecece05483cbae0d35816e7/src/github.com/stellar/horizon/render/problem/main.go#L58

Also, looks like horizon.Client depends on Type field when returning result codes:
// ResultCodes extracts a result code summary from the error, if possible.
func (herr *Error) ResultCodes() (*TransactionResultCodes, error) {
	if herr.Problem.Type != "transaction_failed" {
		return nil, ErrTransactionNotFailed
	}

https://github.com/stellar/go/blob/411d5554e6d7cbb5b699f13aacf2a87d7a674b47/clients/horizon/error.go#L40
We need another field that will only contain error code - without URL to an error.

I'd vote for dropping the URL

@jedmccaleb moving away from the url wouldn't be compliant with https://tools.ietf.org/html/rfc7807
I'm a bit miffed that our first instinct is that the server is designed wrong in this situation when it looks to me like the client never worked for this scenario.

The nice thing about using a URL is that it should be resolvable to the docs for that error.  We haven't yet done that work, but we probably should.  I mean, I'm fine with us scrapping HAL and Problems and doing something entirely on our own if you guys think it will make things easier for devs, but let's not pretend like its going to solve the situation that gave rise to this problem...  the docs even include an example using the full url:  https://github.com/stellar/horizon/blob/master/docs/reference/errors/transaction-failed.md

I'm a bit miffed that our first instinct is that the server is designed wrong in this situation when it looks to me like the client never worked for this scenario.

I agree, that's is why I suggested:

We need another field that will only contain error code - without URL to an error.

According to specification, it's possible to extend problem object: Extension Members. My main concern with using URL in ResultCodes is that it may change in a future (there is even a comment suggesting this: //TODO: make this prefix configurable). We may also switch to using Title field.

The other thing is that the code in stellar/go was not reviewed and was not tested. I think we need to 1) disallow pushing directly to master branch in all of our repos 2) require at least 1 review from other team member. This can be easily switched in GitHub settings.

According to specification, it's possible to extend problem object: Extension Members.

If we're just going to use the "Do whatever you want" features of the spec to avoid using the spec how it was intended (the type URI is the identifier to switch on) then IMO we should just do our own thing.

My main concern with using URL in ResultCodes is that it may change in a future (there is even a comment suggesting this: //TODO: make this prefix configurable).

They won't be changing.  We need to implement redirects at those URLs to redirect into the documentation.

We may also switch to using Title field.

nonono :)  "title" is a human readable field, we shouldn't be coding against it.  A client would render the title to the user to explain why their request failed:

"title" (string) - A short, human-readable summary of the problem
type.  It SHOULD NOT change from occurrence to occurrence of the
problem, except for purposes of localization (e.g., using
proactive content negotiation; see [RFC7231], Section 3.4).

The other thing is that the code in stellar/go was not reviewed and was not tested. I think we need to 1) disallow pushing directly to master branch in all of our repos 2) require at least 1 review from other team member. This can be easily switched in GitHub settings.'

I'm cool with that, but this isn't the root problem IMO...  We're trying to do too much on too many different projects without enough collaboration and shared code.  this specific issue was "Hey, we've got this thing that looks like a horizon client in the bridge server, why don't we just import it into the monorepo minimally so others can use it?"   We chose the quick solution because we didn't have enough resources to choose the correct solution.

My main concern with using URL in ResultCodes is that it may change in a future (there is even a comment suggesting this: //TODO: make this prefix configurable).

They won't be changing. We need to implement redirects at those URLs to redirect into the documentation.

Then OK, EOT.


Live demo leads to a 404 page

The "Live demo" link in the repository's readme points to a page that no longer exists. Would be nice to have this fixed for evaluation purposes.

Oh yeah I forgot that that even exists. I need to fix that.

Still 404

No 404, but the link redirects to your Github profile. This is unfortunate since I was hoping to use the live demo to evaluate whether it's a good fit for a project I'm brainstorming.

No 404, but the link redirects to your Github profile. This is unfortunate since I was hoping to use the live demo to evaluate whether it's a good fit for a project I'm brainstorming.

It was changed recently. When I wrote the comment it was showing 404.

does anyone has a link to test the demo out?


Unclear how to add new dependencies

For this task here. I'm trying to add a dependency on secp256k1-haskell, which (to my best understanding), I've done here. However, when I try to spin up a nix-shell, I get this:
[koz@Sebastian cardano-base]$ nix-shell --show-trace
trace: Using IOHK default nixpkgs
trace: To make project.plan-nix for haskell-project a fixed-output derivation but not materialized, set `plan-sha256` to the output of the 'calculateMaterializedSha' script in 'passthru'.
trace: To materialize project.plan-nix for haskell-project entirely, pass a writable path as the `materialized` argument and run the 'updateMaterialized' script in 'passthru'.
trace: WARNING: No sha256 found for source-repository-package https://github.com/haskoin/secp256k1-haskell 885d0953d5a0fb08be181a80f3643b0135b04bcb download may fail in restricted mode (hydra)
fatal: couldn't find remote ref refs/heads/885d0953d5a0fb08be181a80f3643b0135b04bcb
error: program 'git' failed with exit code 128

       … while fetching the input 'git+https://github.com/haskoin/secp256k1-haskell?ref=885d0953d5a0fb08be181a80f3643b0135b04bcb'

       … while evaluating the attribute 'buildCommand' of the derivation 'hash-path'

       at /nix/store/g9r92jfark3sngrh57nnbbpjx6nbkfjg-nixpkgs-src/pkgs/build-support/trivial-builders.nix:7:7:

            6|     stdenv.mkDerivation ({
            7|       name = lib.strings.sanitizeDerivationName name;
             |       ^
            8|       inherit buildCommand;

       … while evaluating 'hashPath'

       at /nix/store/5zvkchh00rdd0g89cgky4h29p4d4q8c6-haskell.nix-src/lib/call-cabal-project-to-nix.nix:171:14:

          170|
          171|   hashPath = path:
             |              ^
          172|     builtins.readFile (pkgs.runCommand "hash-path" { preferLocalBuild = true; }

       … from call site

       at /nix/store/5zvkchh00rdd0g89cgky4h29p4d4q8c6-haskell.nix-src/lib/call-cabal-project-to-nix.nix:185:56:

          184|               in __trace "WARNING: No sha256 found for source-repository-package ${repoData.url} ${repoData.ref} download may fail in restricted mode (hydra)"
          185|                 (__trace "Consider adding `--sha256: ${hashPath drv}` to the ${cabalProjectFileName} file or passing in a lookupSha256 argument"
             |                                                        ^
          186|                  drv);

       … while evaluating the attribute 'buildCommand' of the derivation 'source-repository-package'

       at /nix/store/g9r92jfark3sngrh57nnbbpjx6nbkfjg-nixpkgs-src/pkgs/build-support/trivial-builders.nix:7:7:

            6|     stdenv.mkDerivation ({
            7|       name = lib.strings.sanitizeDerivationName name;
             |       ^
            8|       inherit buildCommand;

       … while evaluating anonymous lambda

       at /nix/store/5zvkchh00rdd0g89cgky4h29p4d4q8c6-haskell.nix-src/lib/call-cabal-project-to-nix.nix:236:46:

          235|         # Add replacement `source-repository-package` blocks pointing to the minimal git repos
          236|         ( pkgs.lib.strings.concatMapStrings (f: ''
             |                                              ^
          237|               echo "source-repository-package" >> ./cabal.project

       … from call site

       … while evaluating 'concatMapStrings'

       at /nix/store/g9r92jfark3sngrh57nnbbpjx6nbkfjg-nixpkgs-src/lib/strings.nix:53:25:

           52|   */
           53|   concatMapStrings = f: list: concatStrings (map f list);
             |                         ^
           54|

       … from call site

       at /nix/store/5zvkchh00rdd0g89cgky4h29p4d4q8c6-haskell.nix-src/lib/call-cabal-project-to-nix.nix:236:11:

          235|         # Add replacement `source-repository-package` blocks pointing to the minimal git repos
          236|         ( pkgs.lib.strings.concatMapStrings (f: ''
             |           ^
          237|               echo "source-repository-package" >> ./cabal.project

       … while evaluating 'optionalString'

       at /nix/store/g9r92jfark3sngrh57nnbbpjx6nbkfjg-nixpkgs-src/lib/strings.nix:202:5:

          201|     # String to return if condition is true
          202|     string: if cond then string else "";
             |     ^
          203|

       … from call site

       at /nix/store/5zvkchh00rdd0g89cgky4h29p4d4q8c6-haskell.nix-src/lib/call-cabal-project-to-nix.nix:230:9:

          229|       '' +
          230|         pkgs.lib.optionalString (builtins.length sourceReposEval != 0) (''
             |         ^
          231|         chmod +w -R ./cabal.project

       … while evaluating the attribute 'makeFixedProjectFile'

       at /nix/store/5zvkchh00rdd0g89cgky4h29p4d4q8c6-haskell.nix-src/lib/call-cabal-project-to-nix.nix:227:7:

          226|       sourceRepos = sourceReposBuild;
          227|       makeFixedProjectFile = ''
             |       ^
          228|         cp -f ${otherText} ./cabal.project

       … while evaluating the attribute 'buildCommand' of the derivation 'haskell-project-plan-to-nix-pkgs'

       at /nix/store/g9r92jfark3sngrh57nnbbpjx6nbkfjg-nixpkgs-src/pkgs/build-support/trivial-builders.nix:7:7:

            6|     stdenv.mkDerivation ({
            7|       name = lib.strings.sanitizeDerivationName name;
             |       ^
            8|       inherit buildCommand;

       … while evaluating anonymous lambda

       at /nix/store/5zvkchh00rdd0g89cgky4h29p4d4q8c6-haskell.nix-src/lib/import-and-filter-project.nix:5:1:

            4| { pkgs, haskellLib }:
            5| { projectNix, sourceRepos, src }:
             | ^
            6| let

       … from call site

       at /nix/store/5zvkchh00rdd0g89cgky4h29p4d4q8c6-haskell.nix-src/overlays/haskell.nix:488:27:

          487|               callProjectResults = callCabalProjectToNix args;
          488|               plan-pkgs = importAndFilterProject {
             |                           ^
          489|                 inherit (callProjectResults) projectNix sourceRepos src;

       … while evaluating the attribute 'hsPkgs'

       at /nix/store/5zvkchh00rdd0g89cgky4h29p4d4q8c6-haskell.nix-src/overlays/haskell.nix:510:43:

          509|               project = addProjectAndPackageAttrs rec {
          510|                   inherit (pkg-set.config) hsPkgs;
             |                                           ^
          511|                   inherit pkg-set;

       … while evaluating the attribute 'hsPkgs'

       at /nix/store/5zvkchh00rdd0g89cgky4h29p4d4q8c6-haskell.nix-src/overlays/haskell.nix:533:15:

          532|               # Haskell packages
          533|               hsPkgs = final.lib.mapAttrs (packageName: package':
             |               ^
          534|                 if package' == null

       … while evaluating 'cabalProject'

       at /nix/store/5zvkchh00rdd0g89cgky4h29p4d4q8c6-haskell.nix-src/overlays/haskell.nix:752:24:

          751|
          752|         cabalProject = args: let p = cabalProject' args;
             |                        ^
          753|             in p.hsPkgs // p;

       … from call site

       at /home/koz/mlabs/cardano-base/nix/haskell.nix:23:12:

           22|   # https://input-output-hk.github.io/haskell.nix/user-guide/projects/
           23|   pkgSet = haskell-nix.cabalProject {
             |            ^
           24|     inherit src;

       … while evaluating anonymous lambda

       at /home/koz/mlabs/cardano-base/nix/haskell.nix:4:1:

            3| ############################################################################
            4| { lib
             | ^
            5| , stdenv

       … from call site

       at /home/koz/mlabs/cardano-base/nix/pkgs.nix:3:32:

            2| pkgs: _: with pkgs; {
            3|   cardanoBaseHaskellPackages = import ./haskell.nix {
             |                                ^
            4|     inherit config

       … while evaluating anonymous lambda

       at /home/koz/mlabs/cardano-base/shell.nix:2:1:

            1| # This file is used by nix-shell.
            2| { config ? {}
             | ^
            3| , sourcesOverride ? {}

       … from call site

It isn't clear to me how new dependencies are to be added - the URL that is specified by --show-detail definitely exists, and the commit is live. What have I missed?

You don't need to add it to sources.json, you do need to add the sha256 line in cabal.project (for haskell.nix). You might also have an issue if the sha you're asking for isn't on the master branch?
(This project needs a CONTRIBUTING.md)

You may also need to teach haskell.nix about the pkg-config dependency mapping, like this, but for the secp256k1 library: https://github.com/input-output-hk/haskell.nix/pull/1295

@michaelpj I've updated my branch, but I'm still seeing the same issue. I'm also not sure how to determine what should go in the sha256 section of cabal.project.

Note that the sha256 field should be commented, as in the other source-repository-package stanzas.

You should be able to do the usual TOFU dance: Nix will tell you if it doesn't match. Also what Nick said.

@michaelpj @nc6 Commenting the sha256 field worked; this definitely needs documenting for contributors, as I've literally never seen this before.

You may also need to teach haskell.nix about the pkg-config dependency mapping, like this, but for the secp256k1 library: input-output-hk/haskell.nix#1295

How would I do this? There's no equivalent file here.

https://input-output-hk.github.io/haskell.nix/tutorials/pkg-map.html
In the short term you can put in a nixpkgs overlay providing libsecp256k1 = secp256k1. Ultimately I think it'll need a PR to haskell.nix so that downstream users have an easy time too.

Oh, ignore me, it's already there, so that should be fine.

@michaelpj I now get this error on a build attempt, so clearly something isn't there:
Resolving dependencies...
cabal: Could not resolve dependencies:
[__0] next goal: secp256k1-haskell (user goal)
[__0] rejecting: secp256k1-haskell-0.6.0 (conflict: pkg-config package
libsecp256k1-any, not found in the pkg-config database)
[__0] rejecting: secp256k1-haskell-0.5.0, secp256k1-haskell-0.4.0,
secp256k1-haskell-0.3.1, secp256k1-haskell-0.3.0, secp256k1-haskell-0.2.5,
secp256k1-haskell-0.2.4, secp256k1-haskell-0.2.3, secp256k1-haskell-0.2.2,
secp256k1-haskell-0.2.1, secp256k1-haskell-0.2.0, secp256k1-haskell-0.1.8,
secp256k1-haskell-0.1.7, secp256k1-haskell-0.1.6, secp256k1-haskell-0.1.5,
secp256k1-haskell-0.1.4, secp256k1-haskell-0.1.3, secp256k1-haskell-0.1.2,
secp256k1-haskell-0.1.1, secp256k1-haskell-0.1.0 (constraint from user target
requires ==0.6.0)
[__0] fail (backjumping, conflict set: secp256k1-haskell)
After searching the rest of the dependency tree exhaustively, these were the
goals I've had most trouble fulfilling: secp256k1-haskell

I think it's easier than you think. I just added the dep to cardano-crypto-class (it's on hackage!) and it seems to work fine: https://github.com/input-output-hk/cardano-base/tree/koz/secp-256k1

So you never needed to do the source-repository-package thing, I think.

Good to know, thanks!


bare-metal jenkins role

Docker Jenkins role is great for basic Jenkins setups. But doesn't work for several cases such as

when you absolutely need it to be on a baremetal install
when you are launching docker containers from Jenkins
etc.

This role will help address those cases.

This role works great, closing.


Implement DataFrame/Series reindex_like

Hi, this PR implements both DataFrame.reindex_like and Series.reindex_like.
I did not add a test about reindexing MultiIndex columns on single Index columns because it is currently not supported in koalas. Also, as for DataFrame.reindex, there is no test for reindexing single Index columns/index on MultiIndex columns/index, as it is not supported in pandas.

Nice work, @LucasG0 !
Let me take a look after test passing :)

Codecov Report

Merging #1880 into master will decrease coverage by 2.72%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1880      +/-   ##
==========================================
- Coverage   94.19%   91.47%   -2.73%
==========================================
  Files          40       40
  Lines        9867     9779      -88
==========================================
- Hits         9294     8945     -349
- Misses        573      834     +261

Impacted Files
Coverage Δ

databricks/koalas/missing/frame.py
100.00% <ø> (ø)

databricks/koalas/missing/series.py
100.00% <ø> (ø)

databricks/koalas/frame.py
93.59% <100.00%> (-3.14%)
:arrow_down:

databricks/koalas/series.py
95.68% <100.00%> (-1.28%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
25.66% <0.00%> (-66.65%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
47.82% <0.00%> (-52.18%)
:arrow_down:

databricks/koalas/__init__.py
71.66% <0.00%> (-18.34%)
:arrow_down:

databricks/conftest.py
89.83% <0.00%> (-10.17%)
:arrow_down:

databricks/koalas/spark/functions.py
88.88% <0.00%> (-7.41%)
:arrow_down:

databricks/koalas/accessors.py
86.13% <0.00%> (-6.94%)
:arrow_down:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62fb01c...9a8c7e8. Read the comment docs.

Despite Codecov report, coverage seems actually ok.

awesome, thanks @LucasG0 for working on this.

Great, @LucasG0 !
Looks pretty good to me.
Waiting for others opinion for a while.

Thanks! merging.


Gem effects on items

I was just wondering if a for example "mining speed" gem on a shield will still grand the effect, or if this gem is only usefull on a pickaxe.
Or like "swim speed" on a sword, etc. etc.

All gems work when applied anywhere, as long as the item is equipped/held appropriately


Releasing Cobalt 0.5

A "small" checklist for the release
update version numbers to 0.5.0

[x] in iOS sources on develop
[x] in Android sources on dev-nativeBars
[x] in Web sources on develop

merging dev-nativeBars to develop for core repos:

[x] Android : git merge dev-nativeBars to develop for Cobalt-Android
[x] iOS : git merge dev-nativeBars to develop for Cobalt-iOS
[x] iOS framework : update budnle and stuff from Cobalt-iOS develop branch
[x] Web : git merge dev-nativeBars to develop for Cobalt-Web
[x] Core parent repo : git merge dev-nativeBars to develop and ensure submodules are fine for all OSs

merging dev-nativeBars to develop for samples repos:

[x] Web : git merge dev-nativeBars to develop for all samples and ensure develop is used in all submodules
[x] Android : git merge dev-nativeBars to develop in HelloWorld and ensure develop is used in all submodules
[x] Android : git merge dev-nativeBars to develop in Catalog and ensure develop is used in all submodules
[x] Android : git merge dev-nativeBars to develop in SideMenu and ensure develop is used in all submodules
[x] iOS : git merge dev-nativeBars to develop in HelloWorld and ensure develop is used in all submodules
[x] iOS : git merge dev-nativeBars to develop in Catalog and ensure develop is used in all submodules
[x] iOS : git merge dev-nativeBars to develop in SideMenu and ensure develop is used in all submodules
[x] iOS : in SideMenu sample, update cobalt iOS repository to latest develop
[x] iOS : in Catalog sample, update cobalt iOS repository to latest develop
[x] iOS : in HelloWorld sample, update cobalt iOS repository to latest develop

creating develop and master branch for plugins :

[x] Web : for all plugins, create a develop branch and a master branch from 0.4.1
[x] iOS : for all plugins, create a develop branch and a master branch from 0.4.1
[x] Android : for all plugins except location, create a develop branch and a master branch from dev-nativeBars
[x] Android : for location plugin, merge dev-nativeBars to develop and create a master branch from develop

creating or updating master branches :

[x] Web : create a master branch from develop or merge it from develop for core repositories
[x] Web : create a master branch from develop or merge it from develop for plugins repositories
[x] Web : create a master branch from develop or merge it from develop for samples repositories
[x] Android : create a master branch from develop or merge it from develop for core repository
[x] iOS : create a master branch from develop or merge it from develop for core repositories
[x] Core parent : create a master branch from develop or merge it
from develop for core parent repository
[x] Plugins parent : create a master branch from develop or merge it from develop for all plugins parent repository

creating develop branch for fonts :

[x] iOS : for all fonts, create a develop branch from master
[x] Android : for all fonts, create a develop branch from master

Wiki

[x] Update current version in Roadmap on the wiki in dev-nativeBars branch
[x] wiki : merge branches to develop

delete dev-nativeBars from all repositories (including wiki)

[x] web core repositories
[x] web plugins repositories
[x] web samples repositories
[x] web fonts repositories
[x] web core repositories
[x] android plugins repositories
[x] android samples repositories
[x] android fonts repositories
[x] iOS core repositories
[x] iOS plugins repositories
[x] iOS samples repositories
[x] iOS fonts repositories
[x] wiki

Releasing !

[x] Write release notes
[x] Write blog article
[x] Check release notes are complete
[x] Check blog article is perfect
[x] Ensure all repositories are on master by default
[x] Merge wiki develop into master
[x] Close issues or move unfinished issues from release
[x] Create zip file with cloned cobalt grand-parent repo
[x] update website current version and zip file url in develop branch
[x] apply develop website branch to master and update server
[x] Publish release
[x] Publish blog article
[x] Make a party !

cleanup, delete 0.4.1 from all repositories (including wiki)

[x] web core repositories
[x] web plugins repositories
[x] web samples repositories
[x] web fonts repositories
[x] web core repositories
[x] web CLI repository
[x] android plugins repositories
[x] android samples repositories
[x] android fonts repositories
[x] iOS core repositories
[x] iOS plugins repositories
[x] iOS samples repositories
[x] iOS fonts repositories
[x] wiki

Make a party checkbox has been moved to issue #87


[BUG] Switch to the matching vault when scanning a  tx QR code with a mismatch vault

Previously, scanning a  tx QR code with a mismatched vault would automatically search for the correct vault and, if found, sign it. However, it now displays the error message: "Wrong vault selected."

https://github.com/vultisig/vultisig-android/issues/1293

@yevhen1sec , this is different from #1293. It should search for the correct value part, and if it finds the correct one, it must sign the transaction. Otherwise, it should show an incorrect value.

@aminsato "For the user it is confusing if he can sign tx with another vault selected."

@aminsato "For the user it is confusing if he can sign tx with another vault selected."

Okay cool


Don't query for groups if AAD token already contains groups

Issue:
If a user is member of more groups than the overage limit, then Azure AD does not emit groups claim in the token. Instead, it includes an overage claim in the token that indicates to the application to query Graph API to retrieve the user’s group membership.
However, for users that don't belong to a lot of AAD groups those groups are returned in the token. In that case Guard does not need to make a second call to fetch groups and instead can use groups already returned in the token.
E.g.:
{
  "aud": "spn:12f61069-cba6-4cc2-dae8-8a7b8ccf41c4",
  "iss": "https://sts.windows.net/<ID_OF_TENANT_T2>/",
  "iat":<PHONE_NUMBER>,
  "nbf":<PHONE_NUMBER>,
  "exp":<PHONE_NUMBER>,
  "acr": "1",
  "aio": "AWQAm/8HAAAASW3Mtsad0xxTH9GT5Cg5Z3OyEoSFjuhrP4OKeZO",
  "amr": [
    "pwd"
  ],
  "appid": "aa2z65ee-9ad4-4645-ab40-95f461599z37",
  "appidacr": "0",
  "email": "<redacted>",
  "family_name": "<redacted>",
  "given_name": "<redacted>",
  "groups": [
    "2a9de113-37eb-4b6c-8de7-7f734146f19b",
    "63ac0747-cd2a-4d31-b38f-9a43bde872b4",
  ],
  "idp": "https://sts.windows.net/<ID_OF_TENANT_T1>/",
  "ipaddr": "<IP_ADDRESS>",
  "name": "<redacted>",
  "oid": "<redacted>",
  "scp": "user_impersonation",
  "unique_name": "<redacted>",
  "ver": "1.0"
}

Fix:
Validate to check that groups are present in the token. If they are don't make a second call to Graph for fetching groups.

I will take on this after obo flow is merged. :)