apache recipe is targeted to the :web role, why?

it seems to me it should be targeted to the :app role, is setting it to :web a mistake or intentional?

I wrote the majority of this gem about 3 years ago or so. So I don't really recall. Probably because I considered apache as the 'web' server and it was proxying to a mongrel cluster which was the 'app' role? I wouldn't be against switching it to :app, I think it was there to allow for the distinction between web request proxy and the actual application instances.

I really hate making the switch by just changing the recipe; I first modified it to follow the with_role pattern and making it selectable.
My concern in if we change the recipe, and someone who is using and following the gem upgrades and does a deploy they could get a nasty surprise if they were depending on that role, or worse used that role in ignorance just to make the recipe work.
I think what I would like to do is some kind of deprecation of the apache recipe, and add a new apache recipe, named something like apache2 (which wouldn't be innacurate as the recipe actually installs apache2 not apache1.x.) in such a way that if someone does a deploy it stops them and issues a warning, to set X preference and use apache2.


'Use strict' @top and updated the file with const/let  [issue-702]

Added strict mode in filer.spec.js
Learn more about strict > https://www.w3schools.com/js/js_strict.asp
var abs = "..";

// changed to

const abs = "..";
// Variables which are objects of library are changed to const and rest are changed to let.

Please advice if I missed something.
Thank you

One tip @SahibArora: you use [issue-702] in your issue above, but it would be better to say Fixes #702, which GitHub will use to auto-close your bug when this PR lands.  Next time!


Author page will refuse to render a 404

Summary
Given a URL https:///11ty.dev/authors/:name/ - if :name doesn't exist, or :name contains uppercase characters, the serverless function fails.
Details
When there's a trailing slash, the HTTP status code is 500. The response is a JSON object, instead of HTML. The object looks like this:
{
  "error": "json.filter is not a function"
}

When the trailing slash is omitted, the status code is 404, and the object looks like this:
{
  "error": "No matching URL found for /authors/binyaminGreen in {\"/authors/:name/\":\"./src/authors/author-pages.md\"}"
}

Notes
This may be a problem with the internal Serverless plugin, but I decided to start from the beginning of the chain.

oops, hit enter by mistake

@pdehaan any thoughts?

Seems unfortunate.

[200] https://www.11ty.dev/authors/binyamingreen (lowercase)
[200] https://www.11ty.dev/authors/binyamingreen/ (lowercase trailing /)
[404] https://www.11ty.dev/authors/binyaminGreen (uppercase char)

{ "error": "No matching URL found for /authors/binyaminGreen in {\"/authors/:name/\":\"./src/authors/author-pages.md\"}" }

[500] https://www.11ty.dev/authors/binyaminGreen/ (uppercase char, trailing /)

{ "error": "json.filter is not a function" }

[500] https://www.11ty.dev/authors/usernotfound/ (lowercase, no user found, trailing /)

{ "error": "json.filter is not a function" }

Not sure if there's a way when using serverless to force the :name path to be lowercase. And intercept missing users and redirect or show a more meaningful error.
I honestly haven't tried playing w/ serverless paths yet, but it's high on my list now that 1.0 is released. ❤


Publishing Java katas

@jhoffner I already said many times that it was impossible to re-publish a Java translation of a kata. I wrote a new kata and I began trying to publish the Java translation of this new kata. No problem to "Validate" but, when publishing, for hours I had:

Please wait while we publish. We are validating your code and publishing your changes. This shouldn't take too long.

Impossible to publish. It is becoming very worrying! If it is impossible why not to tell it rather than the "Please wait...". The status page: "All Systems Operational".

It's working this morning.


New board nucleo g431kb

Added support for the ST Microelectronics nucleo g431kb board
The board port supports GPIO, PWM, the console and an i2c interface

also build error needs looking at and resolving

Not sure what has gone on here but no, probably best if you back up this branch to another branch, then nuke this branch, create a new branch from main then cherry-pick your commit onto it and force push.

to fix the CI failure, add the clock domain definition for the lptim,  in the board DTS,  with LSI, as the nucleo32 has no LSE clock
stm32_lp_tick_source: &lptim1 {
clocks = <&rcc STM32_CLOCK_BUS_APB1 0x80000000>,
<&rcc STM32_SRC_LSI LPTIM1_SEL(1)>;
status = "okay";
};


Connecting to HDFS using arrow R package

Hello!
I would like to be able to read parquet files from HDFS using arrow in R. This functionality is quite well documented for the python version of the package, but in R I have no idea how to do this. Some chapter in the cookbook on connecting to different filesystems would be great.
Thank you!

Hi @ira-saktor!  The bindings for this are not currently implemented in R; there is a ticket open here on the project JIRA: https://issues.apache.org/jira/browse/ARROW-6981
At present, I think your best bet would be to retrieve the files locally and working with them there.  I'll comment on the JIRA ticket to mention that there is user interest in implementing these bindings.


Refactor error handling, network requests, types

Requests

Introduce useGet for resource fetching

useSwr should never be used directly within a component; it should be wrapped in a custom hook calling useGet defined in hooks/api/*

Introduce usePost for resource mutations

useFetcher should never be used directly within a component; it should be wrapped in a custom hook calling usePost in hooks/api/*

All requests to the API requires an action key that describes the request (e.g. "fetch user", "update collection"). This action will be mapped to the error response if/when they occur
Fix res.json() reader to differentiate legit responses vs. actual errors

Errors

Introduced a custom error type called ApiError. This is a standard JS error that's decorated with a customMessage field, which is populated by our base level _fetcher, which in turn forwards the action from the call site
Error Boundary has been updated to better reflect errors. This uses formatDetailedError that can extract custom messages from our internal errors, with sane defaults

LocalStorage

Only cache successful responses locally under __swr__ prefix; prevent over-eager caching "errors" (failed requests) and "validating" (in-flight requests)

Directories

types/* contains primitive types only; API-specific types such as UserRequest and UserResponse are bundled next to the hooks that actually use them
In general, types should be defined close to the call site unless it is truly generic. As a result type EditModeNft has been moved within OrganizeGallery, given that it likely won't be used outside of that view

BIG


Adding required for api swagger for azure resource mover

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of “no breaking changes
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Updating API(s) in preview over 1 year
[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

This PR is marked as DoNotMerge, please let us know if is ready so we can review it.

This PR is marked as DoNotMerge, please let us know if is ready so we can review it.

This PR is marked as DoNotMerge, please let us know if is ready so we can review it.

Please do the review as it is ready. We added the label internally and will remove once the service side changes are deployed.

This PR is marked as DoNotMerge, please let us know if is ready so we can review it.

Please do the review as it is ready. We added the label internally and will remove once the service side changes are deployed.

Please, consider following ARM RPC for GET calls as indicated here, I'll approve the PR because you already have other GET calls using the same approach, but the recommendation is to end a GET api with either a resource name (single result), resource type (list) or a singleton (/default).

Please, consider following ARM RPC for GET calls as indicated here, I'll approve the PR because you already have other GET calls using the same approach, but the recommendation is to end a GET api with either a resource name (single result), resource type (list) or a singleton (/default).

Rule
Message
Explanation

❌ 1038 - AddedPath
The new version is adding a path that was not found in the old version.New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L965:5
Our service is not in GA currently and is there only in two public regions. We are adding this api in the preview swagger so that testing is done in the preview swagger itself before we move to non-preview swagger. No user will be impacted as no sdks or documentation have been published based on this api, so no user can directly call this api.

Rule
Message
Explanation

❌ 1038 - AddedPath
The new version is adding a path that was not found in the old version.New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L965:5
Our service is not in GA currently and is there only in two public regions. We are adding this api in the preview swagger so that testing is done in the preview swagger itself before we move to non-preview swagger. No user will be impacted as no sdks or documentation have been published based on this api, so no user can directly call this api.

@msyyc to help check why python SDK generation fail

@msyyc to help check why python SDK generation fail

@msyyc Yuchao Yan FTE to help check why python SDK generation fail

For python, the failure is fake and please ignore it

@msyyc Yuchao Yan FTE to help check why python SDK generation fail

For python, the failure is fake and please ignore it

Please let me know when it ready to merge.

Please let me know when it ready to merge.

Please let me know when it ready to merge.

We will remove the DoNotMerge tag and let you know when the service changes are deployed. thanks.

Please let me know when it ready to merge.

We will remove the DoNotMerge tag and let you know when the service changes are deployed. thanks.

hi @ChenTanyi. can you please help to merge this. we have removed the tag. thanks.

hi @ChenTanyi. can you please help to merge this. we have removed the tag. thanks.


Relax rule: Allow mixing basic operators without parens (+-*/)

There is talk that the preventing the mixing of basic arithmetic operators like 4 + 5 * 2 is too restrictive. This was released in standard v9. Currently standard requires that 4 + 5 * 2 be written as 4 + (5 * 2).
There was discussion about this in the original issue here: https://github.com/feross/standard/issues/566#issuecomment-278826261 and it came up on Twitter here: https://twitter.com/wa7son/status/838310839560060928
I think this is acceptable. I personally care more about parens for the other precedence levels which are much less well-understood.
Also, note: When adding a new rule to standard that we all agree is worth having, I usually prefer to keep all the options on (so it's as restrictive as is reasonable), and then to relax the rule in a patch version as folks bring up issues like this one.
So this is actually feedback that I was expecting 😉 Please share thoughts below.

FWIW, I was meh to -1 on the rule when it was discussed, but not enough to debate it. I ran into one project so far where I had to make a change because of the rule, which was to make 'string' + 42 * 42 be 'string' + (42 * 42), which was imo an improvement for everyone. If anything, I think a rule that requires maths to be separated from the string concat + is a nice rule.

I think the rule should be kept as is. While I appreciate concerns surrounding the restrictiveness of the rule, I think standard shines at making code explicit, and clear. Signifying precedence with parens falls right into this philosophy. Let us not forsake beginners nor forget the experience of encountering a new code base, sometimes two extra chars go a long way. imho.

I'm strongly in favour of relaxing this rule. I think it's the wrong strategy to drag everyone down to the average.
If we want to force everyone to write safe code, we should also ban --/++, force people to declare all variables in the top of the scope, not use Promises etc etc. There's no end to this!
We are in fact heading fast towards just recreating jslint. We have to ask our selfs if standard should be a style guide or if it should also be an error prevention tool. If it should also be an error prevention tool, we have to ask our selfs how experienced the developer is expected to be. We have have to be pragmatic about this. Do we expect developers to know entrylevel algebra? Do we expect them to know how to use Promises? Are prototypical inheritance too complex for people to understand? Most people don't understand regular expressions, so maybe we should disallow those?

When working with a group of developers on a single project, I've found that clarity in code is more productive then cleverness.
Adding parenthesis to signify precedence gives clarity to a non-trivial line of code, even if folks could comprehend it without them. I've rarely been upset at having extra parens as they usually help me break down the logic faster.
All that being said, I can see how this rule with all options on could get annoying pretty quick. No one likes feedback that their simple Arithmetic 2 * 10 + 1 is wrong because it doesn't have parenthesis.
Getting things back on track, here is the rule:
http://eslint.org/docs/rules/no-mixed-operators
And here are the default options:
{
    "no-mixed-operators": [
        "error",
        {
            "groups": [ // Sets that should require parenthesis for precedence differences
                ["+", "-", "*", "/", "%", "**"], // Arithmetic Operators
                ["&", "|", "^", "~", "<<", ">>", ">>>"], // Bitwise Operators
                ["==", "!=", "===", "!==", ">", ">=", "<", "<="], // Comparison Operators
                ["&&", "||"], // Logical Operators
                ["in", "instanceof"] // Relational Operators
            ],
            "allowSamePrecedence": true //
        }
    ]
}

Its unfortunate that there is no option for minimum number of operations on a line before checking, as I think that would be a great way to temper this rule.
I'm in favor of removing the Arithmetic operators from the rule as it would probably eliminate most of the annoyance.

If anything, I think a rule that requires maths to be separated from the string concat + is a nice rule.
I agree with this @dougwilson unfortunately there is not a rule/option that does this yet :(

Is keeping the Arithmetic operators in this rule worth it for catching these cases?

@watson It's clear that you're really frustrated. Sorry if this rule change caused you trouble.
I agree that this rule should be relaxed, since we don't want standard to become too noisy by e.g. warning about common code that most people think is perfectly fine.
In the future, it would be great to hear your feedback in the "release proposal" issue I always open before putting out a new major release. Here's the one for 9.0.0. It would be really helpful to get feedback then so we can catch issues like this before they go out in a new release.
Speaking of which, here is the release proposal for 10.0.0 that would be great to get your feedback on. This release adds two big changes: warn about deprecated Node APIs (so that maybe we can convince Node core this is a better way to handle deprecations than adding console warnings!) and enforce node.js-style callbacks get called with an error or null as the first argument. Please share feedback.

The rule has been relaxed in standard 9.0.1 and 10.0.0-beta.1. Cheers 🍻

"**"

Does anyone have a reference I can find as to when this was added to JS? TIL


Add Check for greater than 2 CPU sockets on a VMWare Machine

On a VMware machine, add in the blog article for the following.
https://blogs.vmware.com/vsphere/2013/10/does-corespersocket-affect-performance.html

Reopen - going to change this from an error to a warning note.


[DOCS] Review external_id usages

Since we plan to "hide" the external_id record attribute, maybe make sense to review examples (as this one) to use the id instead.

@frascuchon Is this closed?

Yeah. Closing it


fix(ksni): add id property to tray

In some environments the (e.g. Gnome with AppIndicator extension), the tray icon will not show up if the id is missing. To not break BC, I'm re-using the already mandatory title as ID.

@olback Could you release a new version with this bug fix?


Hope to add Sourcetree application software

Sourcetree is the running installation version. It's not the compressed file installation.


Total number of triggers filtered by tags

Hello all.
I would like to use Single Stat pane to count number of triggers filtered by some tags.
I have tagged triggers and I want to display total number of a kind of event in a dashboard.
This feature would be so usefull.
Thank you. Best regards.
Mehmet

I had almost the same task. I needed to display the total number of triggers of each severity. I solved it using plugin blendstat https://grafana.com/plugins/farski-blendstat-panel
I did 2 query by min.severity https://a.radikal.ru/a27/1906/89/0d852f8847b4.png
and used function 'Diff' (difference) in options, https://c.radikal.ru/c04/1906/b4/89de6ed08491.png
but function "Diff" I added by myself in file module.js.
https://b.radikal.ru/b30/1906/a3/b3ff841dcad1.png
https://d.radikal.ru/d37/1906/63/2fda117bfef1.png
You can use my file, put it in catalog  /var/lib/grafana/plugins/farski-blendstat-panel/dist/ and service grafana restart
I don'n know, how to attach this file module.js  to my comment

I had almost the same task. I needed to display the total number of triggers of each severity. I solved it using plugin blendstat https://grafana.com/plugins/farski-blendstat-panel
I did 2 query by min.severity https://a.radikal.ru/a27/1906/89/0d852f8847b4.png
and used function 'Diff' (difference) in options, https://c.radikal.ru/c04/1906/b4/89de6ed08491.png
but function "Diff" I added by myself in file module.js.
https://b.radikal.ru/b30/1906/a3/b3ff841dcad1.png
https://d.radikal.ru/d37/1906/63/2fda117bfef1.png
You can use my file, put it in catalog /var/lib/grafana/plugins/farski-blendstat-panel/dist/ and service grafana restart
I don'n know, how to attach this file module.js to my comment

Roman, thank you for all these valuable informations. I will try this.
You know there is no tag filter in blendstat. So I still need a solution with tags.
Best regards.

any comment @alexanderzobnin ? I think it's a good feature.
thank you.

Yea, I think it should be helpful.

Thank you.

I recently encounter this requirement and my solution was to collapse the query response into values using the native grafana transformation tools.


Parallel listeners

Ahh @mandy-chessell  sorry. The page remained somehow in cache and seen the comment after I merged. I'm talking with Ruxandra to rezolve your comment in a different commit


Missing dependency

When running DebugSignaturesComparerCli.exe the following error occurs. Is there some dependency missing or needs to be installed?
PS C:\Users\...\Downloads\DebugSignaturesComparer_v1.1.0> .\DebugSignaturesComparerCli.exe
A fatal error occurred. The required library hostfxr.dll could not be found.
If this is a self-contained application, that library should exist in [C:\Users\...\Downloads\DebugSignaturesComparer_v1.1.0\].
If this is a framework-dependent application, install the runtime in the global location [C:\Program Files\dotnet] or use the DOTNET_ROOT environment variable to specify the runtime location or register the runtime location in [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x64\InstallLocation].
PS C:\Users\...\Downloads\DebugSignaturesComparer_v1.1.0>

Maybe releases need to be made with self contained option - https://stackoverflow.com/a/61232023

I did not make the release build a self-contained app as that would make it significantly larger. Do you have the .NET (Core) Runtime installed?
https://dotnet.microsoft.com/download

Maybe not. I built from source and visual studio installed something and now it runs.... so probably not.
Maybe add to the readme that .net runtime is needed.
Thanks


Fix Github LFS Issue

The ML branch has not been updated because of issues pushing to Github from local storage. This is expected to be due to the large file storage set up before as a previous solution to this issue.

After removing all large files and saving them separately, as well as eliminating LFS tracking, the ML sections can be pushed as normal.


Initial checkin for 10 AWS specific doc only app pages.

Purpose of this pull request
This pull request (PR) ...
Issue number:

Select the type of change:

[ ] Minor Changes - Typos, formatting, slight revisions
[ ] Update Content - Revisions and updating sections
[x] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

@npande , there are several instances where you'll need to convert docs links to relative links. I've commented on a few but there are more.

We are having README.md in the apps repo , we cannot use relative paths. We are using the content of same README.md file in the docs repo. Can docs team update relative links in the documentation repo?

I will take care of this action. While I update the index page I will update these links too.


Add youth member role

Implemented a youth member role for content access which is assigned if the visitor is a member and has an age  <=36.

Hey Steffan,
and thank you so much for your contribution!
The code looks fine to me, but I wonder if that's the way we actually want to go ..
E.g. what happens if you want to target a youth member only from your local church? Will we then add another role for that?
I fear that without a clear goal for this, we'll continue adding more and more roles and end up having no control over the logic ..
Can you maybe describe the reason you need to identify youth members so we understand your use case?
Another solution to this is to have the logic inside the widget / plugin itself.
Only my 2 cents ..

Hi @cs1m0n, as I have implemented it right now, the role only targets youth members from my local church. I agree with you that a more flexible logic is the way to go. We needed a quick-n-dirty solution to limit access of our youth meeting livestreams to youth members of our church.

I found a way to accomplish our use case without changing the bcc-login plugin. I created a new separate plugin which applies the age restriction on the post/page. Maybe you want to add this snippet to the documentation?
wp-content/plugins/bcc-login-age-restriction/bcc-login-age-restriction.php:
<?php

/*
Plugin Name: BCC Login Age Restriction

Extension plugin for https://github.com/bcc-code/bcc-wp
*/

const dwjz_post_id = 1758; // the id of the post where to apply the age restriction
const dwjz_max_age = 36;

function dwjz_on_template_redirect() {
	// check post id
	if (get_the_ID() === dwjz_post_id && !dwjz_is_youth()) {
		return dwjz_not_allowed_to_view_page();
	}
}

add_action( 'template_redirect', 'dwjz_on_template_redirect', 1 );

function dwjz_filter_menu_items( $items ) {
	foreach ( $items as $key => $item ) {
		if ($item->object_id == dwjz_post_id && !dwjz_is_youth()) {
			unset( $items[ $key ] );
		}
	}

	return $items;
}

add_filter( 'wp_get_nav_menu_items', 'dwjz_filter_menu_items', 21 );

/*
Returns `true` if the current user's age is <= `dwjz_max_age`,
otherwise the function returns `false`.
*/
function dwjz_is_youth() {
	// Check if user is logged in to Wordpress
	if (!is_user_logged_in()) {
		return false;
	}

	// Check if oidc token is available
	if (!isset($_COOKIE['oidc_token_id'])) {
		return false;
	}

	// Check if oidc token is valid (still stored in transient)
	$token_id = $_COOKIE['oidc_token_id'];
	if ( ! empty( $token_id ) ) {
		$token = get_transient( 'oidc_id_token_' . $token_id );
	}
	if ( empty( $token ) ) {
		return false;
	}

	// Get token claims
	$claims = BCC_Login_Token_Utility::get_token_claims( $token );

	$birthdate = date_create($claims['birthdate']);
	$current_date = date_create();
	$diff = date_diff($birthdate, $current_date);
	$age = $diff->y;
	return $age <= dwjz_max_age;
}

function dwjz_not_allowed_to_view_page(){
	wp_die(
		sprintf(
			'%s
%s',
			__( 'Sorry, you are not allowed to view this page.', 'bcc-login' ),
			site_url(),
			__( 'Go to the front page', 'bcc-login' )
		),
		__( 'Unauthorized' ),
		array(
			'response' => 401,
		)
	);
}


Consider option to generate Markdown

Generate the preview and output as follows:
[Titles Extension :: Add-ons for Firefox](https://addons.mozilla.org/en-GB/firefox/addon/titles-extension/)
As this is suitable for use with Markdown files

I have started working on this and hope to release a new version soon

This issue is fixed in Release Titles Extension - 1.1.0 · glawrence/titles-extension


"Toast" is not announced by Voiceover or Talkback

Description
I expect the contents of the alert to be read by the screenreader when it appears on screen.
CodeSandbox/Snack link
https://snack.expo.dev/@simonflk/nativebase-alert-example
Steps to reproduce

Enable Voiceover on iOS or Talkback on Android device
Open snack link
Press any button to trigger a toast
Wait for screenreader to read contents of toast

NativeBase Version
3.4.3
Platform

[X] Android
[ ] CRA
[ ] Expo
[X] iOS
[ ] Next

Other Platform
No response
Additional Information
iOS 15.4.1
Android 12 (Pixel 5, April 2022 update)
Docs says:

On Android and Web, Toast renders under a View with accessibilityLiveRegion which announces the content rendered inside it to screen reader devices.
On iOS, accessibilityLiveRegion is not supported yet, so we use the
accessibilityAnnouncement
to announce the content.

But this is not happening for me

Hi @simonflk, Thanks for reporting the issue. We will look into it.


Add Current Issues Button

Closes https://github.com/shescoding/projects-platform-frontend/issues/102
I added a button for Current Issues. I also refactored the component to not have duplicate buttons based on the user's auth status if that's fine.
Screenshot:

Great work!


Fix NULs in text.

NUL character is a valid symbol in UTF8.
Fixes #195

Coverage increased (+0.06%) to 84.54% when pulling ac0129617fd4293e7c341a48bba2adfc85f5afe1 on egonelbre:fix-nullstring into e28cd440fabdd39b9520344bc26829f61db40ece on mattn:master.

Thank you


Bestscore not updated in multiple runs using callback

Description
When "train" function runs multiple times using callback, model.best_score remains the best from all previous runs.
This also affects the early stopping, and early stopping does not work correctly either.
When not using callback, the problem does not occur.
Reproducible example
import lightgbm as lgb
callbacks = [
    lgb.early_stopping(500),
 ]
#x_train, y_train, x_test, y_test are the lists of different data.
for j in range(len(x_train)):
    lgb_train = lgb.Dataset(x_train[j], y_train[j])
    lgb_eval = lgb.Dataset(x_test[j], y_test[j], reference=lgb_train)

    model = lgb.train(params, lgb_train, valid_sets=lgb_eval,
                    num_boost_round=10000, callbacks=callbacks,
                    )
print(model.best_score)

--When replacing the following code, it works fine.
model = lgb.train(params, lgb_train, valid_sets=lgb_eval,
                        early_stopping_rounds=500,
                        num_boost_round=10000,
                        )

Environment info
LightGBM version or commit hash: Windows 11, Python 3.7-64bit
Command(s) you used to install LightGBM
pip install lightgbm
Additional Comments

Thank you for your help. I didn't know that "callbacks" keeps the information like the normal variable.
Your solution works well. Thank you very much.


[stalbe/nginx-ingress] Fix wrong apiGroup templating in roles

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/nginx-ingress])

/ok-to-test

Thanks for the PR!
/lgtm


transition not working on weex-sdk 0.19+

Describe the bug
transition not working on weex-sdk 0.19+ ,i use the latest playground app。
To Reproduce
demo
http://dotwe.org/vue/825827b22050004ed6d101b1de9208af
Environment

Device: [XIAOMI MI5]
OS: [android 8.0]
Build from source [no]

You demo seems incorrect, here is the new one http://dotwe.org/vue/9a25405b1283b6dfd9ee7d56907d50e1

The root <div> is will be rendered to the whole screen by default, do not animate the size of it.
The width style should contain a unit, such as px.
Your transition-property is left, but you are changing the width.

so sorry for the mistakes in my demo !
But transition seems still not working in new demo,I try it on the new android playground app.
@Hanks10100


Upgrade to doctrine/orm v3 & doctrine/dbal v4

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 24 (100.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
104

Relevant Lines:
104

💛  - Coveralls

Released in 0.5.0.


Blue circle in teams section

Describe the bug
There is this big blue circle in team section, which is not looking nice. I don't know its purpose, but I think that it would look nice without it.
Possible solution
I have use inspection tool and it can be removed by removing division with class round1.
Screenshots

someone already create this issue


increase test timeout from 5m to 7m

Changes Unknown when pulling 3a60b75afb8d63484fcd873f19a866379b82c21e on timeout into ** on master**.

Changes Unknown when pulling cc668b180f6fc3f16e10156efde30b565ed1d824 on timeout into ** on master**.

Changes Unknown when pulling 92b14f8fcd5a7b8de73e6303de5e11fdd7384fe6 on timeout into ** on master**.

Changes Unknown when pulling 69b5568afba756ddc5f79dda477cd2081819d2b2 on timeout into ** on master**.

Changes Unknown when pulling 0406ea9e320472d10762a8c276a6cf6838306774 on timeout into ** on master**.

Changes Unknown when pulling 046dda6ec8bb97d209da8cc3175c71fcd4a54dc1 on timeout into ** on master**.

Coverage increased (+0.1%) to 69.425% when pulling 802bb878268dda673b14fba3bc1bd3d5e90f5fb1 on timeout into 77c5348f88108b9caca4cff52f74ac9c14a4b877 on master.


Currency for Indian customer wire payment is incorrect.

[Hi Team, while selecting India as country to get the payment information, it says Pay in USD which is incorrect.]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9b4e8220-2dd3-3ce2-b07e-03c793bac520
Version Independent ID: 5c7ca9c5-205a-66b0-eabe-ccae39ad0d61
Content: Pay your Microsoft Customer Agreement or Microsoft Online Subscription Program Azure bill - Microsoft Cost Management
Content Source: articles/cost-management-billing/understand/pay-bill.md
Service: cost-management-billing
Sub-service: billing
GitHub Login: @banders
Microsoft Alias: banders

@jefjack Thank you for posting your question. You are looking for cost details in different currencies. Currently for EA the pricing currency and billing currency is in local/billing currency – The Api only returns in the pricing/billing currency. Refer to - https://learn.microsoft.com/en-us/answers/questions/773930/different-currency#answer-774177
Hope this answers your question!

Not actually,
[image]
The above is the wire payment instructions that we get when we select India as country for wire payment details, however it says "Please pay in USD only" which is incorrect. Indian Customers pay by INR to the above wire transfer account.
We need you help to correct this.
Regards,
Jeffrey Jackson
Sr. Partner Tech Advisor
Azure Subscription and Billing Management Support
From: SadiqhAhmed-MSFT @.>
Sent: Wednesday, September 20, 2023 7:39 PM
To: MicrosoftDocs/azure-docs @.>
Cc: Mention @.>; Author @.>
Subject: Re: [MicrosoftDocs/azure-docs] Currency for Indian customer wire payment is incorrect. (Issue #114953)
@jefjackhttps://github.com/jefjack Thank you for posting your question. You are looking for cost details in different currencies. Currently for EA the pricing currency and billing currency is in local/billing currency - The Api only returns in the pricing/billing currency. Refer to - https://learn.microsoft.com/en-us/answers/questions/773930/different-currency#answer-774177
Hope this answers your question!

Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/114953#issuecomment-1727812021 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYY6CYWQ5JA6DA4FO4BQ2MLX3L2JRBFKMF2HI4TJMJ2XIZLTTGBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVE4DGNRXGAZDONBSURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2SOBTGY3TAMZRHEZ2I3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNJHA2TGMRYGM4DKMNENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWVDCNBVGQ2TMMJVGI42I3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNKGE3DSOBXGA2TOOBSURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2UMRSHE3DCOBYGAZTRJDOMFWWLKLIMFZV63DBMJSWZLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOMIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVA3TENRYGUYDENUCUR2HS4DFUVUXG43VMWSXMYLMOVS2UMJZGA2DKNRQG4ZTTAVEOR4XAZNFNRQWEZLMUV3GC3DVMWUTQMZWG4YDENZUGKBKI5DZOBS2K3DBMJSWZJLWMFWHKZNJHAZTMNZQGMYTSM4CUR2HS4DFUVWGCYTFNSSXMYLMOVS2SOBVGMZDQMZYGUYYFJDUPFYGLJLMMFRGK3FFOZQWY5LFVIYTINJUGU3DCNJSHGBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGE3DSOBXGA2TOOBSQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRSGI4TMMJYHAYDGOFHORZGSZ3HMVZKMY3SMVQXIZI.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Working a doc update for this with https://github.com/MicrosoftDocs/DocsLegal-pr/pull/1082

@jefjack The article is updated. I'm unsure exactly when it will be refreshed live, but it should be later this afternoon Redmond time.
#please-close


Secondary colour accent & Syntax highlighting

Request should fulfill #24
This turned out to be far easier than I expected. Turns out that discord is being sensible and only using ~6 global variables for all different languages, instead of manually supporting each language.

oops, forgot to capitalize the variables in the backend.

I'll be testing it out, would you mind squashing one commit like "feat: code highlight colors" and force pushing the branch? Thanks.

@guglicap
Done.
as I initially said, only the back ends themselves should need configuring/making the colours work.
I haven't gotten to test all the code syntax highlighting, so I might've missed one variable but I doubt it. Across a dozen languages it all seems to come back to these.

@VGrol Thanks, tested it and looking good. I pushed some updates to master in the meanwhile so you should probably rebase and update the @version 0.0.1 comment in master.scss to @version 0.0.2. I'm trying to make the project a little more structured now that more people are using it, or working on it. For this same reason, please change the commit message to have the prefix "feat:", short for "feature". Hope you understand, thank you.

@guglicap Remind me to not do branch management without my morning coffee. '
That mess of rebasing, force pushing aside....
Should be compliant to your requests.
Dear lord I need coffee.

@VGrol ahah, don't worry. I can relate. Thanks, merging.


Issue with theme option or subset label

Hi, a minor issue here for the UI.
The inner modal layer in theme options dont display the right subset option label (displayName attribute) I attach two clarifying images.
Theme Options list

Inner layer with suboptions list

As we can see, the label in the subset list is "animated background" but in the header of the inner layer it shows "theme systembackground" which is the subset attribute "name" and not the "displayName" atribute.
https://github.com/fabricecaruso/es-theme-carbon/blob/master/theme.xml#L101
Thanks!

ok fixed

thanks


Blocks.Tables.CombiTable1Ds seems inconsistent

CombiTable1Ds is a bit confusing.
What is the need of "columns" input parameter? I understand its need in CombiTable1D, not in CombiTable1Ds.
Indeed, since the model has a single input, the first column should indicate the input values and the others the interpolated output. So the number of table columns minus one will determine the number of outputs, and seems to be no need of the "columns" parameter.
Moreover, the "table" parameter has as a default:
fill(0.0,0,2)
and as description
"Table matrix (grid = first column; e.g., table[0,2])"
What is the meaning of having "0" as number of rows in the fill() function?
I propose to omit any default and use a more clear description, e.g.:
"Table matrix (grid = first column; e.g., table[0,1; 1,2; 2,0])"
As an alternative, a default for table could be  [0, 0; 1, 1]
for which output replicates the input.
Moreover, the documentation of the model seems to be pasted from the CombiTable1D's without some necessary modifications. But it is too early to suggest fixes on it.

I see three issues here.

Parameter columns: Via parameter columns it can be defined how many columns of the table are interpolated, i.e., you can select less than the available columns or reorder the columns. This is the expected behavior.

Default table parameter: In #1137 I also stumbled across the unusual default parameter fill(0.0,0,2). It was set to some reasonable default value by 414466def2e5ead4621e14276d5247658fe67340 but reverted again by c0f62028af0b89d3760cd0af6b9dece7c6acedeb as it raised some more issues.

Copy/pasted documentation: I fixed the one error I could find in master and maint/3.2.2. Please let me know if you observed some more errors.

Ah, I did not read documentation correctly. My fault.
Indeed everything was already clear, and your correction made it clearer.
The "strange" default value is justified by #1137 as well.
But I have still an issue.
You left as a description of table "Table matrix (grid = first column; e.g., table[0,2])". I really don't understand this.
I made a different proposal, which a like much more. As an alternative, if you prefer, we could put in the description a sub-table of the example used in the documentation, e.g.:
"Table matrix (grid = first column; e.g., table[0,0; 1,1; 2,4])"
I proposed differently, just to show that the output does not have to be monotonic.

OK, I additionally adapted the comment of the table parameter to match the one of Modelica.Blocks.Sources.TimeTable in  in master and maint/3.2.2.


Support file objects

Sometimes I want to read from or write two raw bytes in memory.  In these cases I'm used to supplying a BytesIO object.
In [1]: from io import BytesIO, StringIO

In [2]: f = BytesIO(b'name,amount\nAlice,100\nBob,200')

In [3]: import pandas as pd

In [4]: df = pd.read_csv(f)

In [5]: df
Out[5]:
    name  amount
0  Alice     100
1    Bob     200

In [6]: out = StringIO()

In [7]: df.to_csv(out)

In [8]: out.seek(0)
Out[8]: 0

In [9]: out.read()
Out[9]: ',name,amount\n0,Alice,100\n1,Bob,200\n'

If relevant reading and writing functions would support file objects as well as filenames then I could more easily use cyavro within distributed memory applications.

Yeah this is something that I would like to still add.  Not entirely sure what the most effective way is to go from a file-like object to a void*

What does the void* point to?

Basically you need to pass a pointer to a buffer housing the bytes to
libavro.
There was some recent stuff added in a pr that should be useful for this.
On Wed, Jan 13, 2016 at 22:56 Matthew Rocklin<EMAIL_ADDRESS>wrote:

What does the void* point to?
—
Reply to this email directly or view it on GitHub
https://github.com/MaxPoint/cyavro/issues/5#issuecomment-171521924.

I've taken a look at this.  Should be relatively simple to implement the writer/ reader.
Basically just need to dispatch to a different method at
https://github.com/MaxPoint/cyavro/blob/e03fda34e25af6e9198effeebace9d2961d03634/cyavro/_cyavro.pyx#L738
There are some more complexities involving setting up the correct file headers with reader/writer schemas but hopefully enough of the things i need are exposed in the libavro api.
Do you know of a good Cython api to BytesIO?

The code below seems to imply that we can also pass (heavily wrapped) char *s to these functions:
enum avro_io_type_t {
    AVRO_FILE_IO,
    AVRO_MEMORY_IO
};
typedef enum avro_io_type_t avro_io_type_t;

struct avro_reader_t_ {
    avro_io_type_t type;
    volatile int  refcount;
};

struct avro_writer_t_ {
    avro_io_type_t type;
    volatile int  refcount;
};

struct _avro_reader_file_t {
    struct avro_reader_t_ reader;
    FILE *fp;
    int should_close;
    char *cur;
    char *end;
    char buffer[4096];
};

struct _avro_writer_file_t {
    struct avro_writer_t_ writer;
    FILE *fp;
    int should_close;
};

struct _avro_reader_memory_t {
    struct avro_reader_t_ reader;
    const char *buf;
    int64_t len;
    int64_t read;
};

struct _avro_writer_memory_t {
    struct avro_writer_t_ writer;
    const char *buf;
    int64_t len;
    int64_t written;
};

Also, cc-ing @kwmsmith , who might be of some assistance on the Cython side.

I've finally managed to scrape away some time to take a look at the difference between how _avro_reader_file_t and _avro_reader_memory get initialized.  This seems mostly to boil down to the single avro record that is the header of the avro file that is not dealt with by the memory protocol.  (This is the way that the python avro implementation actually reads its schema).

Figured out what was missing.  Implemented


parameteric polynomial

Hi, yuanchen,
I have a question about how to define a polynomial with a given degree, because sometimes you may want to find a polynomial satifisying given constraints, which means you probably need to optimize all coefficients of a polynomial, not part of them.
So have you ever think about to do that? or am I just missed something?
thank you :)
some useful links you may need
google groups
stack overflow

Yea you can do that with poly_variable defined here: https://github.com/yuanchenyang/SumOfSquares.py/blob/master/src/SumOfSquares/basis.py#L110
You can see how that is used in the definition of poly_opt_problem: https://github.com/yuanchenyang/SumOfSquares.py/blob/master/src/SumOfSquares/SoS.py#L124


Minor fixes to German and French

Fixes:

A single instance of submeshes was translated as "Unter-Mesh" as opposed to "Submeshes" in German.
The User Inspector was translated as "Benutzer-Assistent" instead of "Benutzer-Inspektor", using the name for the wizards instead of inspectors.
The French translation of the Online Users facet had the two numbers swapped.

Closing this as nothing has happened in a year and I don't see anything happening in the future.


Add multiprocessing in apply

There are two probable path to achieve and it was written in apply_memory and apply_local separately.

looks nice!


CRS Simple Example

It would be good, if we have a sample with CRS-Simple Map.
The JS-Code would be:
      var map = L.map('map', {
        crs: L.CRS.Simple,
        minZoom: -2,
      });

      var bounds = [
        [0, 0],
        [1000, 1000],
      ];
      var image = L.imageOverlay(
        'https://leafletjs.com/examples/crs-simple/uqm_map_full.png',
        bounds
      ).addTo(map);

      map.fitBounds(bounds);
      map.pm.addControls();

We need someone who makes the html around it like index.html

Very necessary


how to use

i'm new to all this but found something during the install
i made a dir www in the homeassistant folder
/usr/share/hassio/homeassistant/www
then i used    git clone https://github.com/resoai/TileBoard.git
restarted homeassistant en have to go to this link to open the tilebaord:
https://(my.website):8123/local/TileBoard/index.html
capital T and B

So, what exactly is your question?

it was more a finding about the link,
on github under  how to use the link is was with lowercase letters
TileBoard will be available at http://HASS_IP:8123/local/tileboard/index.html and will prompt you for your login credentials after restarting Home Assistant
but if u use clone the folder is downloaded as TileBoard
for the rest thanks for the work u did, i loaded the default example config and it looks great
will try to customize it later


perf(fs): refactor readDirRecursive to await at the end with flat

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

By using the flat array method we can make performance for recursive directory reading even better, as seen in the attached picture:

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Thanks! By any chance can you make a small repo for me to well test this change? I want to make sure the change is not due to fs caches.

Sure thing! Give me a moment please.

@pi0
https://github.com/GalacticHypernova/readDirRecursive-Test
It's already preconfigured with the directory to test, which is also the one I used to get the results in the screenshot

Okay intresting. Try to change PR and current order like this:
async function main(){
console.time("PR")
const b =await readdirRecursiveNew("./images")
console.timeEnd("PR")

console.time("current")
const a=await readdirRecursive("./images")
console.timeEnd("current")
}

I get the opposite output when swapped away. Seems first run (whichever) fills the OS cache and makes next faster. (basically this refactor is not adding to the parallelism.)
(tested on Macbook Air M2 Node v20.11.0)
npx jiti index.ts
PR: 0.731ms
current: 0.34ms

Oh, interesting, allow me to see


add JSON-LD versions of schemas

Would be really nice if there were a JSON Schema > JSON-LD converter.

@dwhieb I was looking into this idea a bit. My takeaway is that we would need to assign each JSON file a @context field for it to be a valid JSON-LD file. The context appears to be the first part of the URI address of the schema so for example would the @context for Access just be the $id field i.e. "@context: http://schemas.digitallinguistics.io/Access-3.1.0.json"?
Or would it just be "@context: http://schemas.digitallinguistics.io/Access-3.1.0" with no file extension
or "@context: http://schemas.digitallinguistics.io/"
or "@context: http://schemas.digitallinguistics.io/Access-3.1.0.jsonld"
Basically it seems to me that the $id and $ref fields would need to either be changed to @context or at least redirected to .jsonld files.
Also we have to decide how deep we want to dive into the JSON-LD keywords: do we just want the simplest conversion by only assigning the @context field? or do we want to use the @type and @id and @value fields etc. to truly take advantage of the JSONLD functionality?
What do you think?

==============================
John W. Du Bois
Professor of Linguistics
University of California, Santa Barbara
Santa Barbara, California 93106
USA
<EMAIL_ADDRESS>On Sat, Jun 8, 2019, 1:16 PM vadekh<EMAIL_ADDRESS>wrote:

@dwhieb https://github.com/dwhieb I was looking into this idea a bit.
My takeaway is that we would need to assign each JSON file a @context
field for it to be a valid JSON-LD file. The context appears to be the
first part of the URI address of the schema so for example would the
@context for Access just be the $id field i.e. "@context:
http://schemas.digitallinguistics.io/Access-3.1.0.json"?
Or would it just be "@context:
http://schemas.digitallinguistics.io/Access-3.1.0" with no file extension
or "@context: http://schemas.digitallinguistics.io/"
or "@context: http://schemas.digitallinguistics.io/Access-3.1.0.jsonld"
Basically it seems to me that the $id and $ref fields would need to
either be changed to @context or at least redirected to .jsonld files.
Also we have to decide how deep we want to dive into the JSON-LD keywords:
do we just want the simplest conversion by only assigning the @context
field? or do we want to use the @type and @id and @value fields etc. to
truly take advantage of the JSONLD functionality?
What do you think?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/digitallinguistics/spec/issues/125?email_source=notifications&email_token=AIQ6S73KO34I42FF5JVKIKTPZPSORA5CNFSM4FXW7Z6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHZBWI#issuecomment-500142297,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIQ6S76H7AIYOGM5BH2YBWDPZPSORANCNFSM4FXW7Z6A
.

If you do provide JSON-LD versions of your schemas, you might be interested in re-using properties defined in the CLDF ontology.

More generally (and I admit to being biased here): I think digitallinguistics could profit from integration with CLDF. AFAICT, Daffodil does not provide much in terms of "macro-types" of data, such as wordlists, typological datasets, etc., but rather specifies "micro-types" like "Word". CLDF otoh has specifications for several macro-types, and (at least theoretically - dunno how well things like Cow work) there's a well-defined conversion from CLDF to JSON-LD. So if digitallinguistics (and Daffodil) operated on top of JSON-LD as converted from CLDF,

you'd get a specification for macro-types for free
you'd have a storage format that plays well with version control
you'd have a bridge to quite a bit of data

Btw.: Another - less well specified, but possibly more practical - way to get JSON from CLDF datasets is via having the data served by a Datasette app, as described here: https://github.com/cldf/cookbook/tree/master/recipes/datasette


[perfdash]: Migrate Docker image to distrolesss

Migrate to Docker image of perfdash to distroless base image.
Signed-off-by: Arnaud Meukam<EMAIL_ADDRESS>
What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes https://github.com/kubernetes/perf-tests/issues/604
Special notes for your reviewer:
I'll advise local test before push the image.
Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/GoogleContainerTools/distroless

/assign @wojtek-t @shyamjvs @mborsz

@ameukam Were you able to verify the new image works? IIUC none of the above presubmits verify this today unfortunately.

/assign @jupblb - to help as scalability oncall

@ameukam Were you able to verify the new image works? IIUC none of the above presubmits verify this today unfortunately.

No really. Can take a look this week.

Change Makefile to reflect the fact that binary is being built inside of the container (we don't need to build it at Makefile level)?

IMO, having a local build of perfdash accessible with just 1 command could be useful for local development. Happy to do the change in a followup PR.

Change Makefile to reflect the fact that binary is being built inside of the container (we don't need to build it at Makefile level)?

IMO, having a local build of perfdash accessible with just 1 command could be useful for local development. Happy to do the change in a followup PR.

Agreed. It makes sense to keep 'make perfdash' working, but dependency of 'container' target on 'perfdash' is unnecessary -- it makes 'make container' actually build perfdash binary twice: outside of the container and inside. Please remove the dependency of 'container' target on 'perfdash' in Makefile to avoid this.

/lgtm
/approve
It builds now, I checked an image and the binary starts correctly. I will try to push this to perfdash instance.

It's pushed and looks good now.
It required me to change permissions of files in /www (for some reason index.html on my disk had 0600 file mode). For now I'm assuming it was my workstation issue as git seems to have right permissions [1], but if ever anyone hits this again, we may consider adding some chmod calls to Dockerfile.
[1]:
$ git ls-tree master
100644 blob c92a424668ab7306e0bab33a2c37af5a31fd71ea	Chart.js
100644 blob e6598ee41b4fa0724f92fca2fbd68a7342b73012	angular-chart.css
100644 blob c7a59c50c94d88dccd544fb2a707483eb21a4389	angular-chart.js
100644 blob 45f812587e2bdf73620841cfc57af32172745f88	index.html
100644 blob 0c0ab7dea09ea61daf427db63967aab409720022	k8s_logo.png
100644 blob dc11581d0ea96ffeef45d3f9f65eb8a2a4cee666	script.js


Replace note with comment in resx files

<note> tags caused VS 2022 preview and VS 2022 int preview to remove values when editing resx files.
Some files already used <comment> so this makes resx consistent.
Microsoft Reviewers: Open in CodeFlow

Huh, I completely missed this. No clue, but I was directly modifying the files so this might have been a mistyped once, copied a hundred times situation. Sorry for the oversight, LGTM


Add helm3 catalog data

Problem:
With helm version being set at the catalog level, we need a helm 3 specific catalog
Solution
Add helm 3 specific catalog to Rancher
Issue
#25754

@cbron confirmed with Denise that the naming helm3-library is expected


always got timeout error

my website agent always get a timeout error,i don't know what's wrong with it,or can i set timeout value to larger?

/app/app/models/agents/website_agent.rb:399:in check_url' /app/app/models/agents/website_agent.rb:386:in block in check_urls'
/app/app/models/agents/website_agent.rb:385:in each' /app/app/models/agents/website_agent.rb:385:in check_urls'
/app/app/models/agents/website_agent.rb:483:in block (2 levels) in receive' /app/app/concerns/liquid_interpolatable.rb:64:in interpolate_with'
/app/app/models/agents/website_agent.rb:466:in block in receive' /app/vendor/bundle/ruby/2.5.0/gems/activerecord-5.1.1/lib/active_record/relation/delegation.rb:41:in each'
/app/vendor/bundle/ruby/2.5.0/gems/activerecord-5.1.1/lib/active_record/relation/delegation.rb:41:in each' /app/app/models/agents/website_agent.rb:465:in receive'
/app/app/concerns/sortable_events.rb:99:in receive' /app/app/jobs/agent_receive_job.rb:8:in perform'
/app/vendor/bundle/ruby/2.5.0/gems/activejob-5.1.1/lib/active_job/execution.rb:37:in block in perform_now' /app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/callbacks.rb:108:in block in run_callbacks'
/app/vendor/bundle/ruby/2.5.0/gems/i18n-0.8.1/lib/i18n.rb:257:in with_locale' /app/vendor/bundle/ruby/2.5.0/gems/activejob-5.1.1/lib/active_job/translation.rb:7:in block (2 levels) in module:Translation'
/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/callbacks.rb:117:in instance_exec' /app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/callbacks.rb:117:in block in run_callbacks'
/app/vendor/bundle/ruby/2.5.0/gems/activejob-5.1.1/lib/active_job/logging.rb:24:in block (4 levels) in <module:Logging>' /app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/notifications.rb:166:in block in instrument'
/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/notifications/instrumenter.rb:21:in instrument' /app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/notifications.rb:166:in instrument'
/app/vendor/bundle/ruby/2.5.0/gems/activejob-5.1.1/lib/active_job/logging.rb:23:in block (3 levels) in <module:Logging>' /app/vendor/bundle/ruby/2.5.0/gems/activejob-5.1.1/lib/active_job/logging.rb:44:in block in tag_logger'
/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/tagged_logging.rb:69:in block in tagged' /app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/tagged_logging.rb:26:in tagged'
/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/tagged_logging.rb:69:in tagged' /app/vendor/bundle/ruby/2.5.0/gems/activejob-5.1.1/lib/active_job/logging.rb:44:in tag_logger'
/app/vendor/bundle/ruby/2.5.0/gems/activejob-5.1.1/lib/active_job/logging.rb:20:in block (2 levels) in <module:Logging>' /app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/callbacks.rb:117:in instance_exec'
/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/callbacks.rb:117:in block in run_callbacks' /app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/callbacks.rb:135:in run_callbacks'
/app/vendor/bundle/ruby/2.5.0/gems/activejob-5.1.1/lib/active_job/execution.rb:33:in perform_now' /app/vendor/bundle/ruby/2.5.0/gems/activejob-5.1.1/lib/active_job/execution.rb:22:in block in execute'
/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/callbacks.rb:108:in block in run_callbacks' /app/vendor/bundle/ruby/2.5.0/gems/activejob-5.1.1/lib/active_job/railtie.rb:26:in block (4 levels) in class:Railtie'
/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/execution_wrapper.rb:85:in wrap' /app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/reloader.rb:68:in block in wrap'
/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/execution_wrapper.rb:85:in wrap' /app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/reloader.rb:67:in wrap'
/app/vendor/bundle/ruby/2.5.0/gems/activejob-5.1.1/lib/active_job/railtie.rb:25:in block (3 levels) in <class:Railtie>' /app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/callbacks.rb:117:in instance_exec'
/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/callbacks.rb:117:in block in run_callbacks' /app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.1.1/lib/active_support/callbacks.rb:135:in run_callbacks'
/app/vendor/bundle/ruby/2.5.0/gems/activejob-5.1.1/lib/active_job/execution.rb:20:in execute' /app/vendor/bundle/ruby/2.5.0/gems/activejob-5.1.1/lib/active_job/queue_adapters/delayed_job_adapter.rb:36:in perform'
/app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/backend/base.rb:81:in block in invoke_job' /app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/lifecycle.rb:61:in block in initialize'
/app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/lifecycle.rb:66:in execute' /app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/lifecycle.rb:40:in run_callbacks'
/app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/backend/base.rb:78:in invoke_job' /app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/worker.rb:230:in block (2 levels) in run'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/timeout.rb:93:in block in timeout' /app/vendor/ruby-2.5.1/lib/ruby/2.5.0/timeout.rb:103:in timeout'
/app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/worker.rb:230:in block in run' /app/vendor/ruby-2.5.1/lib/ruby/2.5.0/benchmark.rb:308:in realtime'
/app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/worker.rb:229:in run' /app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/worker.rb:312:in block in reserve_and_run_one_job'
/app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/lifecycle.rb:61:in block in initialize' /app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/lifecycle.rb:66:in execute'
/app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/lifecycle.rb:40:in run_callbacks' /app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/worker.rb:312:in reserve_and_run_one_job'
/app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/worker.rb:213:in block in work_off' /app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/worker.rb:212:in times'
/app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/worker.rb:212:in work_off' /app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/worker.rb:175:in block (4 levels) in start'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/benchmark.rb:308:in realtime' /app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/worker.rb:174:in block (3 levels) in start'
/app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/lifecycle.rb:61:in block in initialize' /app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/lifecycle.rb:66:in execute'
/app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/lifecycle.rb:40:in run_callbacks' /app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/worker.rb:173:in block (2 levels) in start'
/app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/worker.rb:172:in loop' /app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/worker.rb:172:in block in start'
/app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/plugins/clear_locks.rb:7:in block (2 levels) in <class:ClearLocks>' /app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/lifecycle.rb:79:in block (2 levels) in add'
/app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/lifecycle.rb:61:in block in initialize' /app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/lifecycle.rb:79:in block in add'
/app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/lifecycle.rb:66:in execute' /app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/lifecycle.rb:40:in run_callbacks'
/app/vendor/bundle/ruby/2.5.0/gems/delayed_job-4.1.4/lib/delayed/worker.rb:171:in start' /app/lib/delayed_job_worker.rb:6:in run'
/app/app/concerns/long_runnable.rb:71:in `block in run!'

@dsander help~~

You can set -e DELAYED_JOB_MAX_RUNTIME=2 to a larger value when creating the docker container. But a webserver taking longer than 2 minutes to complete sounds more like a network connection issue or a problem with the request.

You can set -e DELAYED_JOB_MAX_RUNTIME=2 to a larger value when creating the docker container. But a webserver taking longer than 2 minutes to complete sounds more like a network connection issue or a problem with the request.

i attempt  modify the website_agent.rb as this:
'''ruby
log "Fetching #{uri}"
#response = faraday.get(uri)
response = faraday.get do |req|
req.url  uri
req.options.timeout = 15           # open/read timeout in seconds
req.options.open_timeout = 5       # connection open timeout in seconds
end
log "response: #{response.body}"
'''
and set the DELAYED_JOB_MAX_RUNTIME with command:
heroku config:set DELAYED_JOB_MAX_RUNTIME=5
and all this have no effect

req.options.timeout = 15 # open/read timeout in seconds req.options.open_timeout = 5 # connection open timeout in seconds

Setting those will actually reduce the timeout, per default the WebsiteAgent does not have a timeout (it is only controlled by DELAYED_JOB_MAX_RUNTIME which is in minutes), your settings are in seconds. So the request will timeout in 5 or 15 seconds instead of 2 minutes.


Can't find CSS classes utilities documentation that comes bundled with Clarity

Summary
There is no documentation of what all classes come with Clarity UI. Under the theme section, it does not talk about the CSS classes available with Clarity.
If you have got any link or documentation, then please attach it in this issue so that is easily available.

What is the change? Documentation update to add more clarity on available CSS classes while using Clarity.
Why should it go in Clarity? There's no way to find out if there's any CSS class available for what I am looking for.
Does this change impact existing behaviors? If so how? No.
If this change introduces a new behavior, is this behavior accessible? NA

Use case
NA
Examples
NA
Workarounds
NA

This is a duplicate of some other requests, and something we've been working to improve. See #2212 for example. We do document most of the CSS classes we consider public and connected with specific components, such as in alerts.
With our evolution with Core, we are documenting all properties fully.

With the new website, Clarity Core documentation contains a whole dedicated section to all styling options. We aren't currently planning to invest in auditing the Clarity Angular documentation for any missing classes (there may be a few but most are documented), but are happy to consider improvements for missing details if people find them in the future. I'm closing this as resolved in new website for Clarity Core.

With the new website, Clarity Core documentation contains a whole dedicated section to all styling options. We aren't currently planning to invest in auditing the Clarity Angular documentation for any missing classes (there may be a few but most are documented), but are happy to consider improvements for missing details if people find them in the future. I'm closing this as resolved in new website for Clarity Core.


aligning "Budget Buddy" logo to the center

Logo is not center aligned.
Please assign this issue to me under hacktoberfest
Screenshot:

Hi @GauravChinavle ,
Thank you for showing interest in my repository. The logo alignment looks quite right to me, and I am not looking forward to changing it.
Best regards,
Shruti


service/debugger: improve NomalLocationSpec.Find's heuristics

When location spec is given and the base can be interpreted either in
source file name or function name, NomalLocationSpec searches both
the source file list and the function symbol list, and selects matching
candidates. Previously, all the matching candidates were added to one
single list regardless whether the candidate was from the source file
list or not. Then, later, Find tries to guess whether the candiate
was a function or a file based on a heuristic, i.e, whether the
candidate is an absolute file path. The heuristic is fragile - since
there is no guarantee that the included source file name is an absolute
path.
Instead, this CL preserves where the candidate was found; file list or
function symbol list. Then, use that info to determine whether the
candidate is a source file name or not.

I have no idea how to interpret the appveyor build failure logs.

Sometimes appveyor fails like this, we don't know why but it's unlikely to be our fault (since it's a compiler error).


HikariJNDIFactory Tomcat7 java version <IP_ADDRESS>

Ubuntu 14.04.2 LTS
/var/lib/tomcat7/conf/server.xml (basing off sample JNDI DataSource on wiki)
<GlobalNamingResources> <Resource name="jdbc/CORS" auth="Container" factory="com.zaxxer.hikari.HikariJNDIFactory" type="javax.sql.DataSource"                minimumIdle="2" maximumIdle="5" maximumPoolSize="40" connectionTimeout="300000"                jdbcUrl="jdbc:mysql://localhost:3306/CORS?zeroDateTimeBehaviour=convertToNull" dataSource.implicitCachingEnabled="true"               dataSource.user="" dataSource.password="" / </GlobalNamingResources>
jars put in /usr/share/tomcat7/lib/ as want access globally.
Tried using Hikari 2.3.7 and got:
Caused by: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory         at com.zaxxer.hikari.util.PropertyBeanSetter.<clinit>(PropertyBeanSetter.java:41)         at com.zaxxer.hikari.HikariJNDIFactory.getObjectInstance(HikariJNDIFactory.java:55)
added slf4j-api-1.7.10.jar and got:
Caused by: java.lang.NoClassDefFoundError: javassist/ClassPath         at com.zaxxer.hikari.HikariConfig.<clinit>(HikariConfig.java:31)         at com.zaxxer.hikari.HikariJNDIFactory.createDataSource(HikariJNDIFactory.java:76)         at com.zaxxer.hikari.HikariJNDIFactory.getObjectInstance(HikariJNDIFactory.java:67)         at org.apache.naming.factory.ResourceFactory.getObjectInstance(ResourceFactory.java:141)
added javassist-3.12.1.GA.jar and got:
same error as before.
Tomcat7 has only the ROOT app under webapps.
Tried using Hikari 2.3.8 - no change.
Searched the issues (and Google) and tried suggestions or added libraries to match - no change. Asking here as it 'appears' it is HikariConfig that is causing the issue...
Thank you,

@pgtips Have you tried javassist-3.18.2-GA?

Thank you for the prompt reply. I thought I had grabbed a recent version.
I just tried replacing with 3.18.2-GA - no change to error. (Tried 3.19.0 while I was at).

Sorry - closed by mistake.

Coming up on 1am here in Tokyo, I'll have to take a look tomorrow.

Understand - appreciate it.
Will keep digging and see if I can help at all.

(No doubt I still needed 3.18.2-GA)
Thanks!


ROX-11028: GraphQL subresolvers to include image/node/cluster prefix …

As per UI request, all subresolvers should contain a prefix of image, node, or cluster to decrease confusion at the cost of verbosity

looks good to me


Raspberry PI as i2c follower?

Hi,
Using Rppal, is it possible to make the Raspberry Pi (3B or Zero) act as a i2c follower too ?
I know that kind of behavior is possible with the Pigipio library and its Bsci2c function (or bscxfer) but now that I've switched to Rust I'm wondering if something similar is possible with Rppal too.
Thank you.

Thanks for the suggestion! Theoretically if pgpio can do it, so could rppal. However, one of the main differences with rppal is that the pigpiod daemon the client communicates with runs with superuser privileges, which is something I've been actively trying to avoid, but might be the only way to accomplish this. I'll add it to the list of feature requests and will look into it more once 0.12.0 has been released.
Considering this issue was opened several months ago, you may have already figured out how to do this in Rust. If so, I'd love to hear it!

Thanks for your reply. No, I didn’t really look any further how to do that with Rust, I asked on the official forum but didn't get any answer. In the meantime, I split my program in two, on one hand the program coded in Rust and on the other a C++ program running alongside and using the Pigpio library to handle the "i2c follower" side.
But I still use Rppal for sending data on the i2c bus and it would be great to be able to group everything in the Rust  program. Glad to read that you're considering this feature for a future version of Rppal. I hope it's feasible. Thank you very much.


Linear UI SDXL Support

Summary
SDXL x.x is currently only supported via a nodes graph. With the release of SDXL 1.0 imminent and the nodes editor being experimental , this will continue to be a major pain point for users who are new to Invoke AI and generative art.
Intended Outcome
SDXL is able to be used to generate images through the Linear UI.

Almost there. Final touches being applied. SDXL will be usable in TextToImage and ImageToImage on launch. Canvas will be added after.
Reference PR: https://github.com/invoke-ai/InvokeAI/pull/3973


Change AppState counter property from 'var' to 'let'

Change AppState property from var to let to avoid state mutability anywhere.
The example would be clearer and better. If you wanna do the State implementation with classes so the properties should be immutable.

Current coverage is 95.01% (diff: 100%)

Merging #160 into master will not change coverage

@@             master       #160   diff @@
==========================================
  Files            19         19
  Lines           762        762
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            724        724
  Misses           38         38
  Partials          0          0

Powered by Codecov. Last update 317b116...d6e68df

@gorozco58 Thanks for your suggestion! Due to the value semantics of Swift structs it is not necessary to mark the property as immutable (from your explanation it looks like you are already aware of that).
We recommend using structs for the app state in order to be able to use var properties alongside with value semantics. Having to construct a new value for every state mutation quickly becomes tedious (as the amount of properties grow) and requires additional tools such as lenses for being maintainable.
I'd like to keep this example simple by relying on value semantics of structs; I'm happy to discuss further, but I'll close the issue for now. I'm happy to reopen it in case others also think this would be a good change.
Once again, thanks a lot for the contribution!


will you relwase training code?

Hi~ Im very interesting in your paper, and I want t ask will you release training code for us to train it? I want to try to train my own dataset too!!!
Thank you for your help~

Same question here! Thanks for open sourcing this work.

Thanks for your comment. According to the current policy requirements, it is very frustrating that the release of training code is not supported, and the content of the release may be adjusted in the future according to the follow-up relevant policies, looking forward to your continued attention.


Ruby Capstone Kanban Board Setup

There are 3 people on the team :

@IsmaelMastronardi. Team member 1
@ivangonzalez224. Team member 2
@hajnaloltyan. Team member 3

Link to the project :
https://github.com/ivangonzalez224/Catalog-of-my-things/projects/1

STATUS: REQUIRED CHANGES :recycle::recycle:
Hi @IsmaelMastronardi, @hajnaloltyan, and @ivangonzalez224
Good job so far! I know you worked hard to implement this project, I really appreciate the effort you put in! But there are some issues that you still need to work on to go to the next project but you are almost there!

To highlight :champagne:

All requirements have specific card :heavy_check_mark:
Cards have descriptive tittle :heavy_check_mark:

Required changes :recycle: :recycle:

[ ] As required for the project, kindly ensure that each card on the board has a description of the task as some of them don't have description of the task. I recommend you to recheck all your cards and add description for those that don't have..

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please ping me @tresorsawasawa when you comment so I can receive the notification or use slack with the same name.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi @Team,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights
Made Requested Changes :heavy_check_mark:
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Obtain Access Token on Login

Please allow for obtaining an access token on login.  Currently, one can only obtain the id_token during login.
response_type=id_token token

Hi @rohitnarula7176 - can you please re-open this?  I suspect you missed this reply.
Thanks again for all your help.

Hi @rohitnarula7176 - any updates?

Hi @rohitnarula7176 - any updates?

Any thoughts 💭?

@spottedmahn Thanks for your thoughts on this scenario. We do not plan to support this scenario in our current roadmap. Due to reasons above this will need investigation and we will consider in our future backlog. Closing issue for now.

Hi @navyasric - did you read this comment?  The library already does this in parts of it!


Uncaught TypeError: Cannot read properties of null (reading 'latLngToLayerPoint')

Checklist

[X] I've looked at the documentation to make sure the behavior isn't documented and expected.
[x] I'm sure this is an issue with Leaflet, not with my app or other dependencies (Angular, Cordova, React, etc.).
[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I've searched through the current issues to make sure this hasn't been reported yet.

Steps to reproduce

Click on different markers
Get errors

I use Vue 3
Auxiliary library: vue-leaflet

Expected behavior
without error
Current behavior
If you press on different markers, then after that, when the map is enlarged, the markers float away
Console:
Uncaught TypeError: Cannot read properties of null (reading 'latLngToLayerPoint')
    at NewClass._updatePosition (Tooltip.js?aac7:181:1)
    at NewClass.fire (Events.js?f754:190:1)
    at NewClass._move (Map.js?aacc:1241:1)
    at NewClass._onZoomTransitionEnd (Map.js?aacc:1708:1)
    at NewClass._catchTransitionEnd (Map.js?aacc:1639:1)
    at HTMLDivElement.handler (DomEvent.js?fab0:92:1)

Before this error I get warning
listener not found (Events.js?f754:180)

Minimal example reproducing the issue
No response
Environment

Leaflet version: 1.8.0
Browser (with version): no matter
OS/Platform (with version): no matter

Hi, and thanks for taking the time to open a bug report in Leaflet.
However, in this repository we only handle bugs in "vanilla" Leaflet. This means that we do not handle bugs which are specific to frameworks such as:

React
Ractive
AngularJS
Bootstrap
Leaflet for R
Joomla
Wordpress
Ionic
Cordova
Vue
Electron
Polymer
TypeScript
D3
Folium
NativeScript
...etc

Please understand that we only have the time and energy to test Leaflet in plain web browsers.
Please try to either reproduce the bug without using any frameworks, or submit a bug to the appropriate repo.


Missing combat/data sites

Hi! I'm using the docker deployment for Pathfinder and it works like a charm! But I've realized that some entries are missing for combat and data sites, here's an example:

This happens with the event ones too, maybe I did something wrong on the install? Any help or input would be great! Thank you so much for all the effort put onto this amazing tool!

Hey,
Sorry about the slow reply. Event sites won't be added to PF. There's no published list of sites from CCP, so when they make new sites we have to manually add them to a list and publish a new version of pathfinder.
For that reason we won't add event sites. But if there are normal sites that are missing, feel free to add some data about them here and I'll try to add them in a future patch.

Related to https://github.com/goryn-clade/pathfinder/issues/135 and https://github.com/goryn-clade/pathfinder/issues/134
@weforgive i'll close this one as event sites are out of scope


Clean up profile where bitcoin buttons are wrapping

The styling for the buttons in the add a bitcoin receiving option was a bit wonky.
Before:

After:

Thanks for the PR, @skj3gg! :-)


⚠ Mobitopup has degraded performance

In aa734b1, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 4181 ms

Resolved: Mobitopup performance has improved in 386e144.


Retract v0.3.11 since it contains breaking changes.

This is based on #133 thanks @acpana!
Also bumps supported go versions since retract requires Go 1.16.
I plan to publish a 0.4.0 release instead once this is merged.

Let's also call out that we dropped support for 13/14/15 starting with 0.4.0 if that's ok

great call! Thanks Alex


Treesitter can't install

Version confirmation

[X] Confirm

Following prerequisites

[X] Confirm

Neovim version
NVIM v0.8.3 Build type: Release LuaJIT 2.1.0-beta3 编译者<EMAIL_ADDRESS>Features: +acl +iconv +tui See ":help feature-compile"       系统 vimrc 文件: "$VIM/sysinit.vim"          $VIM 预设值: "/opt/homebrew/Cellar/neovim/0.8.3/share/nvim"  Run :checkhealth for more info
Operating system/version
macos 13.3
Terminal name/version
iTerm2 3.4.19
$TERM environment variable
No response
Branch info
main (Default/Latest)
Fetch Preferences
SSH (use_ssh = true)
How to reproduce the issue
在我使用打开nvim的时候就会出现如下报错

一直按回车就是这样

但是我能正常下载其他所有插件，也能正常登陆github
Expected behavior
希望能正常安装所有插件
Actual behavior
No response
Additional information
No response

刚刚把电脑里所有有关nvim的东西删了重装后又出现这个错误

check other issues first

check other issues first

第一个问题我在卸载多次并重装后都会出现，我刚刚尝试了配置原版LazyVim也同样出现了这个问题，猜测是treesitter的问题，但是不知道怎么解决

So did u check other issues? What steps did u tried?

So did u check other issues? What steps did u tried?

目前来看没有其他问题，全部报错都是treesitter的。
我仅仅是使用nvim打开就会出现报错，没有进行其他操作。

https://github.com/ayamir/nvimdots/issues?q=label%3Atreesitter+sort%3Aupdated-desc+is%3Aclosed

刚刚把电脑里所有有关nvim的东西删了重装后又出现这个错误

same as #586.

We can't do more about the installation of treesitter. For well-known reason about GFW, you can't access github normally without proxy. Set terminal proxy if you have it. Below commands are needed if you use bash or zsh:
export http_proxy=http://<server>:<port>
export https_proxy=http://<server>:<port>

replace <server> and <port> with your own proxy setting.

We can't do more about the installation of treesitter. For well-known reason about GFW, you can't access github normally without proxy. Set terminal proxy if you have it. Below commands are needed if you use bash or zsh:We can't do more about the installation of treesitter. For well-known reason about GFW, you can't access github normally without proxy. Set terminal proxy if you have it. Below commands are needed if you use bash or zsh:
export http_proxy=http://<server>:<port>
export https_proxy=http://<server>:<port>

Replace <server> and <port> with your own proxy setting then open nvim.Replace  and  with your own proxy setting then open nvim.

上述sniprun的问题已经解决，非常感谢。
同时我已经在zsh中配置了代理，git clone也没有出现任何问题，但是treesitter的bug依旧存在

What is the output of :checkhealth nvim_treesitter and :lua vim.pretty_print(require("nvim-treesitter.parsers").get_parser_configs())?

In fact, we missed one breaking change: https://github.com/nvim-treesitter/nvim-treesitter/commit/93fa5df0a3f0aeb72df50a9d2110cb90fc5a0a13.
@Penguin-SAMA Pulling the latest updates would resolve this issue.


DRAGON QUEST BUILDERS [PCSE00912]

Game summary

Game name: DRAGON QUEST BUILDERS
Game serial: PCSE00912

Vita3K summary

Version: v0.1
Build number: 295-930b9fd
Commit hash: https://github.com/vita3k/vita3k/commit/930b9fd

Test environment summary

Tested by: HorrorTroll
OS: Windows 8.1
CPU: Intel Core i5-4200H
GPU: Nvidia Geforce GTX 950M
RAM: 6 GB DDR3

Issues

Softlock
Screenshots

Log
vita3k.log
Recommended labels

Softlock

Needs Nothing tag.

Needs Nothing tag.

game goes ingame+ with audio crackling issues, rare frame drops

vita3k.log

I just tried this game.  I do not have any sound issues.. no crackling issues or framerate drops.  However the are graphical issues with the grass.  Also the game crashes once you get outside and complete the first mission with Pippa.  Right after you get some petals for completing the task.
Here are my specs and two screenies.

Version: v0.2.0
Build number: 3570
Commit hash: https://github.com/vita3k/vita3k/commit/aa2c1cb0
CPU backend: Dynarmic.
GPU backend: Vulkan

Test environment summary

Tested by: Greenchili2
OS: Windows 11  23H2 22631.2861
CPU: AMD Ryzen 5 5600G 3.90 GHz
GPU: AMD Radeon Graphics
RAM: 16 GB

It runs pretty well with the odd frame drop and audio clipping, when I fix the house up and receive the reward the game and emulator crash and I go back to my phones home screen.

Compatibility seems to have improved a bit more recently:

I have tested up to mission in which you search for a 2nd person. The game will sometimes crash when completing a mission, so I recommend always saving before completing a mission. Dying also seems to cause a crash.
Graphics seem to have the same issues as in greenchill2's post, except the artifacts are now orange instead of green.
Audio appears to be perfect
Setting resolution scale to anything but 1x breaks lighting and massively increases the crash rate. OpenGL also breaks lighting and also reduces the frame-rate to single digits.

Here are my specs:

Version: v0.2.0
Build number: 3608
Commit hash: https://github.com/Vita3K/Vita3K/commit/53741632bc98ebd3770cbe55b723843e1b83a458
CPU backend: Dynarmic.
GPU backend: Vulkan

Test Environment Summary:

OS: Windows 10 22H2
CPU: Intel i9-11900K
GPU: NVIDIA GeForce RTX 3070
RAM: 32GB


unable to select text in chat window with mouse

Rocketchat 0.54.1
Electron: 2.6.0
MacOSX 10.12.4
Hi Devs.
I'm not able anymore to select text from the chat window with mouse. If i press the left mouse button and hold it to select text the entire rocketchat window is pinned and moving if i move the mouse. Is this a know bug of this version?
thanks and cheers

I'm also experiencing this issue since updating the client to 2.6.0.

2.6.1 works for me. Thanks!

This was fixed with 2.6.1. Issue should be closed.


Ransack search tasks

@ahoernecke Can you please review this commit and merge if there are no concerns?

I will submit a second PR when I am finished with test coverage.

@ahoernecke I went ahead and added a few tests for this controller to ensure ransack filtering is working correctly, that the content returned is valid json, and that the optional parameter to expand system metadata for tasks is working correctly.  This PR is ready to merge.


Hysteresis prevents second query from executing properly.

Looking at this notebook:

If you execute the first normal questies, they work. But then the second queries fail - and they even fail during parsing (e.g. they think they are the wrong type!).
If you execute the MC queries first, however, they work just fine - though if you then run the first queries, they fail.

The two queries should be independent. So something is messed up here!

After doing this query:
jets_antikt = (
    ds_dijet.Select(lambda e: e.Jets(uncalibrated_collection=jets_antikt_name))
    .Select(lambda e: e.Where(lambda j: (j.pt() / 1000) > 30))
    .Select(lambda e: e.Select(lambda j: (j.pt() / 1000)))
    .AsAwkwardArray("JetPt")
    .value()
)

This query fails:
llp_particles = (ds_llp
                 .SelectMany(lambda e: e.TruthParticles("TruthParticles"))
                 .Where(lambda tp: (tp.pt() / 1000) > 10)
                 .Where(lambda tp: abs(tp.pdgId()) == 35)
                 .Select(lambda tp: {
                         'pt': tp.pt() / 1000.0,
                         'pdgId': tp.pdgId(),
                 })
                 .AsAwkwardArray()
                 .value()
)

The first clue that things are going sideways is that the type matcher complains that there is no pdgId on a Jet_v1 object. Which is totally true, but for that second query there is no Jet_v1 anywhere.
And running that second query first works (and then the first query doesn't work).

It would seem the problem is in get_inherited, which is in util_types.py. This guy returns the Jets as an inherited class for some very strange reason. Actually, I do not have any direct testing or comments that are good enough to understand what is going on to really know what this method is doing!

This can't be a python bug:

Create a template class, that uses the Iterable[R] as inherited
Create a second with a second inherited type

Use get_inherrited to see if it gets confused.

This test fails with python 3.11:
def test_get_inherited_generic_twice():
    T = TypeVar("T")

    class bogus(Iterable[T]):
        pass

    myc = bogus[int]
    assert get_inherited(myc) == Iterable[int]

    myd = bogus[float]
    assert get_inherited(myd) == Iterable[float]

What the hell is going on?

Move to using typeguard, and also correctly instantiate types in place. Seems to pass all tests locally.


KeyError

Hi David,
Here is the sample code, which I am trying to run the query, can you please suggest how to resolve the KeyError
import pandas as pd
import json
from pylooker.client import LookerClient

api_endpoint = 'https://<my-looker-endpoint>:19999/api/3.1/'
client_id = '<my-looker-client_id>'
client_secret = '<my-looker-client_secret>'
lc = LookerClient(api_endpoint, client_id, client_secret)
query_data = lc.run_query('<my-looker-Query_ID>')
print(type(query_data))

KeyError                                  Traceback (most recent call last)
<ipython-input-22-9041a9264702> in <module>()

---> 14 query_data = lc.run_query('<my-looker-Query_ID>')
     15 print(type(query_data))
     16 #df = pd.DataFrame(look_data)

~\AppData\Local\Continuum\anaconda3\lib\site-packages\pylooker\client.py in run_query(self, slug, format, limit)
    118             url="{}{}/run/{}?limit={}".format(
    119                 self.api_endpoint + "queries/",
--> 120                 slug_response.json()["id"],
    121                 format,
    122                 limit,

KeyError: 'id'

Hey there @Lathesh-B-L!
Would you mind trying with the 3.0 API endpoint (https://looker.company.com:19999/api/3.0/)?


Trade tariff was handed over to HMRC

The source code for the trade tariff is now managed by HMRC.
https://github.com/trade-tariff/trade-tariff-backend
https://govuk-digital-services.herokuapp.com/projects/trade-tariff

@matthewford thanks for reporting this! Fixed in #421. I also updated the service name, although I'm not 100% sure what the best name for the service is, as it's named slightly different on the start page, the service header, and in the <h1> of the service.


Any chance of merging with existing Python Interface

Any chance of merging some of your code in with https://github.com/dnschneid/pysmartblinds?
I was thinking of forking some of your code in. But its yours so I figured I would bring it to your attention and see if you wanted to merge your control method in. It works great!

I think fundamentally the approach is too different. pysmartblinds does direct BTLE communication instead of using the bridge. I think they could benefit from getting the auth keys from the API like I do though instead of needing to capture them.

That said it’s permissively licensed on purpose so don’t let me stop you from repurposing.