Is there any plan to support OData Endpoint routing?

See detail at this issue:
https://github.com/OData/WebApi/issues/2103
Any feedback, please let me know.
THanks

Thanks @xuzhg (Sam). This is essentially a duplicate of #608. I've been participating on the threads on the OData repo for some time. I internally met with Saurabh and Mike several months back. I'm not one to chase pre-releases because I am the team here and I just don't have capacity to deal with a moving target. It's not really clear to me what the release schedule is or how many more changes may be coming. The beta seems to have been stable for a month or so now.
Sadly, it appears I may have to rewrite the OData routing infrastructure - again. I've had to do so in every flavor of OData since 5.8.x. The fact that the API Versioning matcher policy doesn't work as is is an indicator without even looking at the code. API Versioning doesn't do anything expect disambiguate duplicate routes by API Version. OData, in particular, always assumes there's one, and only one, possible match or fails. In Endpoint Routing, the matcher policy should only decide the possible matches. The base infrastructure decides on a 404 if there are no matches or 500 if there are duplicate matches. I've worked with the ASP.NET team since the public creation of the project and API Versioning was one of the scenarios they used to evaluate the Endpoint Routing design.
Despite my best efforts to urge this not to be the case in OData, the behavior always seems to remain the same. I'm hoping this time that may be just be the default behavior and easy to change without reimplementing the whole thing. Better still, since things are still in the beta phase, perhaps there will be a chance to make things play nicer together before the final release. I'm happy to have a conversation with you internally if the will help things become more synergistic. :)
Cheers!

@commonsensesoftware Thanks for sharing your thoughts. We (OData) schedule a regular sync meeting with .NET Team (ASP.NET) to figure out the routing stuffs. If you are interested in, i can forward that meeting to you so we can have a same platform to discuss the routing.

Any update on this? Is the current workaround to not use endpoint routing?

Any update on this ?

There's currently nothing new to report at this time. Officially, it's not supported - yet. I've heard it may just work, but I haven't tried it myself. Your mileage may vary.

For those following, this will now be the primary issue (since Sam is attached). I have an initial implementation working for, at least, the simple Endpoint Routing scenarios. No commitment on a release date, but I expect things to start progressing to a releasable state in the coming weeks.

@xuzhg as feared, OData continues to certain design decisions that make it hard to extend. I get that some things cannot (or will not) be changed, so I'll focus on the items that can be fixed:

ODataRouteBuilderExtensions.ConfigureDefaultServices and ODataEndpointBuilderExtensions.ConfigureDefaultServices are both internal, but should be public. This requires duplicating the code or using Reflection. I've historically done both. I'm back to Reflection because OData sometimes makes changes that are not duplicated between versions and then things break.
ODataBatchPathMapping.IsEndpointRouting should be public when it's internal. This makes it difficult for perform alternate setups. I have this with Reflection.
OData/WebApi#1750 is still not fixed. When will this ever happen? I've outlined everything including the 5 lines of code to fix it.  I need to commitment that PR will be accepted and release before I put in the effort. The list of old PRs do not instill confidence it would be worth my time, despite the community wanting it. @hassanhabib is even working around it in his demo

These are the most significant issues. I'll surface any others I find.

+@NetTecture
The next release to support this will contain a considerable refactoring to the way routes are configured. The primary objective is to address the existing inability to customize/extend the routing configuration without reimplementing everything. A key problem is that it's all done with extension methods, which are static and can, therefore, not be overriden. To address this, things will move to extension methods that return public, extendable builder objects.
For example, the new configuration will look like:
app.UseEndpoints( endpoints =>
{
    endpoints.MapControllers();
    endpoints.UseApiVersioning().MapODataRoutes( "odata", "api", modelBuilder.GetEdmModels() );
} );

This setup will also apply to the legacy IRouter setup for parity. The next release will keep the existing routeBuilder.MapVersionedODataRoute and routeBuilder.MapVersionedODataRoutes variants, but they will be marked obsolete and call routeBuilder.UseApiVersioning().MapODataRoute and routeBuilder.UseApiVersioning().MapODataRoutes respectively. I expect to completely remove the old extension methods in the next major version release.
I'm happy to discuss or debate if there is any feedback.

@commonsensesoftware
Just for your information. We are investigating the next Web API OData.
The configuration for the OData service will be different between the old and the new.
You can find it here: https://github.com/OData/AspNetCoreOData/blob/master/sample/ODataRoutingSample/Startup.cs#L68-L72
The above line will be the only configure line. There will be no "MapOData....Routes".
I'd wondering whether it can easy the api-version configuration or not?

@xuzhg looking good. If you're interested and willing, I'm happy to sync up internally.
I'd be interested to know how .AddModel will be mapped. API Versioning, in its purest form, is very simple. It adds a route matching policy that disambiguates duplicate routes by API version configured as pure metadata. I have stressed it many times before that OData should allow duplicate matches and then let the policy infrastructure decide what to do. By default, a client receives a 500 when there are duplicates, indicating the service author made a mistake. API Versioning adds a policy that will resolve the ambiguity if there is an appropriate match or pass through, resulting in the same 500. This is very simple with Endpoint Routing, but has continued to be difficult with all forms of routing in OData. I would be interested in any changes or thoughts being put into how OData routing will be realized.
I understand why the prefix exists, but I really think it should go away - for good. This continues to be incongruent with the rest of the routing system. Since it's not otherwise easy to understand the URL, it would be better suited by standard route constraints. For example:

api/[controller]/{property:edmProperty}
api/v{version:apiVersion}/[controller]/{action:edmAction}

This is obviously hypothetical and would probably negate the need for the ODataPathParser. While it's true that authors have to know about OData routing conventions, this is already a problem in all forms of OData routing (convention or attribute). Things bleed through one away or another. This type of approach would allow for strict and loose conformance to OData URL conventions, but allow developers to easily be in the driver's seat.

The 2nd part has to do with discovery, particularly for OpenAPI/Swagger. With respect to OData, this has an affinity to one or more EDM models. Today, API versioning has to collate these, which is a bit difficult with the prefix stuff. API Versioning knows how to pair up an EDM model because it annotates the EDM model with its own ApiVersionAnnotation that was mapped through VersionedODataModelBuilder.GetEdmModels(). Ultimately, I would ❤, and believe, the OData team should own the core of API Explorer support for OData. The current support is virtually non-existent. I've had to create all of it for OData, even though a bunch of it is not specific to API Versioning. Many developers adopt OData + API Versioning just so they get the rich API Explorer support.

5.0.0-RC.1 is now available. It includes support for Endpoint Routing. While minor on the surface, there are significant changes under the hood. Be sure to review the release notes and sample applications. The official release will likely occur after 2 weeks of burn-in. Please report any issues you encounter in a separate issue. Thanks.


PSA: potential lib breaking change after iterator-helpers proposal

lib Update Request

Configuration Check

My compilation target is ESNext and my lib is the default.
Missing / Incorrect Definition
The TS lib defs for Iterator, Iterable, and IterableIterator treat them as if they are all fictitious interfaces (a.k.a. protocols). The lib def's inheritance structure looks like this:
interface Iterator<T, TReturn = any, TNext = undefined> {
    // NOTE: 'next' is defined using a tuple to ensure we report the correct assignability errors in all places.
    next(...args: [] | [TNext]): IteratorResult<T, TReturn>;
    return?(value?: TReturn): IteratorResult<T, TReturn>;
    throw?(e?: any): IteratorResult<T, TReturn>;
}

interface Iterable<T> {
    [Symbol.iterator](): Iterator<T>;
}

interface IterableIterator<T> extends Iterator<T> {
    [Symbol.iterator](): IterableIterator<T>;
}

However, while Iterable and arguably IterableIterator are protocols, Iterator is an actual JS entity. See MDN docs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Iterator This has some practical issues, because what TS terms as IterableIterator is the actual JS Iterator class, but what TS terms as Iterator is what JS regards as "iterator-like" or "iterator protocol". For example, the def for new Set().values() says it returns an IterableIterator, while in fact it should return an instance of the JS Iterator instance.
This becomes more of an issue after the iterator-helpers proposal, which is going to expose Iterator as an actual global that people can use as extends. For example:
class MyClass {
  static #MyClassIterator = class extends Iterator {
    next() { ... }
  };

  [Symbol.iterator]() {
    return new MyClass.#MyClassIterator();
  }
}

Under the current lib def, #MyClassIterator won't be seen as iterable by TS, because it extends Iterator, not IterableIterator.
On the other hand, if we change the definition of Iterator to say it has [Symbol.iterator] (mirroring what happens in JS), then it will break code of the following kind:
function stepIterator(it: Iterator) {
  return it.next();
}

stepIterator({ next() {} });

Of course you could assume that almost all userland iterators are built-in and therefore inherit from Iterator and have @@iterator, but it's a breaking change nonetheless.
The question thus arises that when iterator-helpers lands, where should we put the new definitions on. Right now, I'm using core-js to polyfill these methods, and when writing declarations, I chose to put them on IterableIterator, so that new Set().values() works:
declare global {
  interface IterableIterator<T> {
    filter(
      predicate: (value: T, index: number) => unknown,
    ): IterableIterator<T>;
    map<U>(mapper: (value: T, index: number) => U): IterableIterator<U>;
    toArray(): T[];
  }
}

...but this is suboptimal, for obvious reasons (it means the Iterator class doesn't actually have these methods).
Sample Code

Documentation Link

IterableIterator is possibly the best place for them, but in the event that is too much of a break we may introduce a NativeIterator<T> or BuiltinIterator<T> interface to avoid breaks.
The biggest issue I see is that we can't properly model the type of the native Iterator constructor without using class, because the native Iterator class from the iterator helpers proposal is essentially abstract because you must still define next:
declare abstract class Iterator<T> {
  constructor();
  abstract next(value?: undefined): IteratorResult<T, void>;
  // ... iterator helper instance methods ...
  static from<T>(obj: Iterable<T> | TheCurrentIteratorType<T>): Iterator<T>;
  // ... iterator helper static methods ...
}

While we can model the abstract constructor using an abstract new constructor type, the abstract new syntax isn't supported on construct signatures in an interface. We also have no way to indicate an abstract method in an interface at the moment. If we did, a non-class version might look like this:
interface IterableIterator<T> extends Iterator<T> {
  // `abstract` here doesn't matter for implementing interfaces. it is
  // only applied when tied to an `abstract new` signature.
  abstract next(value?: undefined): IteratorResult<T, void>;

  [Symbol.iterator](): IterableIterator<T>;

  // ... iterator helper instance methods ...
}

interface IteratorConstructor {
  abstract new<T>(): abstract IterableIterator<T>
                  // ^^^^^^^^ opt-in to caring about the `abstract`-ness
                  //          of the interface.

  readonly prototype: IterableIterator<any>;

  from(obj: Iterable<T> | Iterator<T>): IterableIterator<T>;
  // ... iterator helper static methods ...
}

declare var Iterator: IteratorConstructor;

I’m confused; Iterator.prototype.next exists, why would you need to define it yourself?

ahhh, you're right, in this case it's IteratorHelperPrototype.next that the proposal adds.

It could be renamed to IteratorLike, similar to the existing PromiseLike for promises.

Now that iterator helpers are shipped in Chrome and Edge, meaning it will also ship in the next NodeJS release this month (and there are polyfills available too for other engines that currently have it behind experimental flags) it would be really nice if TypeScript could tackle typing the iterator helpers. Given the current naming conflict, it is difficult to write custom typings to fill in the gap in userland (and I haven't found any successful attempts in DT or polyfill packages).

A concrete proposal to maybe get the ball rolling:

As soon as possible, rename the existing Iterator interface to IteratorLike (or some other better name). Change all internal uses of Iterator to refer to IteratorLike instead, but no need to rename IterableIterator or anything else.
Add abstract class Iterator { ... } modeling the actual Iterator class in the language.

This is a breaking change for anyone using the Iterator type explicitly, but hopefully it's not that many - there's not much reason to explicitly use the Iterator type right now. There are only 176 files in DefinitelyTyped which use Iterator< right now, and manual inspection reveals that more than half of those aren't referring to the TS Iterator type (e.g. x, x, x).
The main way that this would break is that places which declared to need an Iterator<T> would start giving an error if provided with { next() {...} }, which previously worked. There do not appear to be that many cases of this. Also, types in dependencies which declare themselves to provide Iterator<T> and give { next() {...} } would appear to have .map etc, when in fact that is missing - this gives you the wrong typing, but not in a way which causes errors for existing code.

The main way that this would break is that places which declared to need an Iterator<T> would start giving an error if provided with { next() {...} }, which previously worked. There do not appear to be that many cases of this. Also, types in dependencies which declare themselves to provide Iterator<T> and give { next() {...} } would appear to have .map etc, when in fact that is missing - this gives you the wrong typing, but not in a way which causes errors for existing code.

The main way this would break is that any existing package that serves an Iterator<T> for any reason would now appear to have the methods of the native Iterator class when they may not, in fact, actually implement those. I still think the IterableIterator<T> type is the correct place to vend these methods from. Despite the difference in naming between the Iterator class and the IterableIterator interface, we can still describe a constructor type that works:
interface IteratorConstructor {
 // ...static methods
}
declare var Iterator: (abstract new <T>() => IterableIterator<T>) & IteratorConstructor;

The main way this would break is that any existing package that serves an Iterator<T> for any reason would now appear to have the methods of the native Iterator class when they may not, in fact, actually implement those.

That's what I was saying in the second half of the bit you quoted, yeah. But that wouldn't actually cause any existing code to fail to compile (except in quite obscure cases which depend on non-existence of map etc at the type level), so it's only debatably "breaking". And from a quick survey of DT that happens quite rarely anyway; not many people are manually implementing iterators.

I still think the IterableIterator<T> type is the correct place to vend these methods from.

IterableIterator is an interface which can be implemented by existing things which don't provide those methods. Merely having next and Symbol.iterator methods suffices to implement that interface, but doesn't give you map etc. Are you proposing to change the definition of IterableIterator so that implementing it requires implementing those methods? If you're going to make a breaking change anyway, I'd think it would be better to stick closer to the actual types.

Another option would be to stick with class for the declaration, but call it something other than Iterator so that name doesn't end up in the type namespace (and ideally mark that name as non-exported, but I don't know if that's possible), then add a new NativeIterator interface for the type-level name. Something like
declare abstract class __TheActualIteratorBuiltin<T> implements IterableIterator<T> {
  abstract next(value?: undefined): IteratorResult<T, void>;
  [Symbol.iterator]: () => NativeIterator<T>;

  map<R>(fn: (v: T) => R): NativeIterator<T>;
  // etc
}
declare var Iterator: typeof __TheActualIteratorBuiltin;
type NativeIterator<T> = __TheActualIteratorBuiltin<T>;

Incidentally, with any of these approaches, how do you update the type for Generator so that it properly inherits these new methods, without just copying them all over? Right now generators implicitly implement IterableIterator but they don't actually get any methods from anywhere.

Another option would be to stick with class for the declaration, [...]

class always introduces a value-space symbol in the binder, so it would always appear as if __TheActual... (or whatever we called it) is an actual value. We generally avoid that by using var declarations. The abstract new <T>(): IterableIterator<T> signature intersected with the IteratorConstructor interface achieves the same thing without introducing a non-existing value. Albeit without the ability to define an abstract method. We unfortunately don't have a way to define those outside of class currently.
I'm also fine with calling this NativeIterator<T> and updating the built-ins to use this interface instead.

Incidentally, with any of these approaches, how do you update the type for Generator so that it properly inherits these new methods, without just copying them all over?

We would just do interface Generator extends NativeIterator.

Are you proposing to change the definition of IterableIterator so that implementing it requires implementing those methods?

We've generally discouraged implementing them directly in the past to try to set the expectation that IterableIterator is the thing built-ins return. I'm not sure how many explicit implementations of IterableIterator exist today, though.

Albeit without the ability to define an abstract method. We unfortunately don't have a way to define those outside of class currently.

Yeah, that's what I was going for with the class thing. But if you think the cost of next not being abstract is worth the benefit of avoiding a new name appearing to be an actual global, that's reasonable. Shame there isn't a way to introduce the type-level class only for use in this file without polluting the global namespace.

I'm also fine with calling this NativeIterator<T> and updating the built-ins to use this interface instead. [...] I'm not sure how many explicit implementations of IterableIterator exist today, though.

There's 77 files on DT which match \bIterableIterator< right now, so, not many. But I'd personally still be happier with IterableIterator meaning just Iterable + Iterator. I'll get a PR starting with that approach for now; if you/the TS team decide that methods on IterableIterator would be better we can always switch over to that.

I may have a solution to use class without polluting the global scope. I'll test it out tomorrow.

Opened https://github.com/microsoft/TypeScript/pull/58222 as a draft with the NativeIterator approach, but I am happy to switch it over to use whatever other approach you'd like.

FYI as of today iterator helpers are shipped in NodeJS (v22)

What’s the next step to enable iterator helpers so we can use them in Node?


mustSupport for Required item's in Medication Card Composition? inconsistent handling (Oliver Egger, ahdis ag, original feedback by Rob)

ch.fhir.ig.ch-emed#1.0.0 /StructureDefinition-ch-emed-composition-medicationcard.html
Oliver Egger, ahdis ag, original feedback by Rob

Also, I did have a look at the specs and they look good (of course I’m still making my way through them).  I like some of the changes.  I did have one question.  When looking at the Medication Care Composition Profile, I saw that the section, card, and annotations had that nifty (must support icon).  I was curious why the OriginalRepresentation didn’t have it as well?  I thought the pdf was required.  The cardinality still has it as 1..1

Yes mustSupport is for the optional elements which "must be supported" in addition to the required ones. However I have seen now that

this is not consistent in the medication card where originalRepresentation is 1..1 and not mustSupoprt but section:card is 1..1 in addition with mustSupport.
the mustSupport does only show the Snapshot Table (Must Support) with mustSupport elements, I thought that included also required, either the IG Publisher changed that.

http://fhir.ch/ig/ch-emed/StructureDefinition-ch-emed-composition-medicationcard.html
Differential table:

Snapshot (MustSupport) Table:

As additional information for this issue the actual situation:
Description in IG:
The representation of the Medication Card document SHALL be embedded as a PDF in PDF/A-1 or PDF/A-2 format. The required elements in the PDF correspond to the minimum data set in the IPAG report. In the FHIR profiles, the flag mustSupport is set to true for these elements.

I propose that we need to provide a separate paragraph on the mustSupport in a next step and put it on the front page of the ig.
'The flag mustSupport requires that a creator and the consumer MUST support these elements if known. The mustSupport flag has been derived from the elements marked as the minimum data set in the IPAG report'

The flag mustSupport requires that the creator and the consumer MUST support these elements if they are known.
-> Anpassen an CH Core Diskussion 03.11.
Required if known for creator (not consumer)
2 Abschnitte auf Home
Bedeutung Flag Must Support (CH Core)
Meaning for Original Representation

Composition.section:originalRepresentation = MS true

@pjolo
Please review the change and if it is okay, please merge this pull request and close the issue.


Problem with duration of elements

Hello! I really like the program and it will be very useful for me. Unfortunately there is a problem with the durations of the elements. The elements are read, the playlist is being built correctly and everything seems fine but on random occasions (absolutely random - I cannot find a reason) an element is played with the duration of the previous element thus it is cut in the middle if longer, or repeated several times if shorter. I think that another fellow here ( #2 )  is having the same problem but playing around with item_duration which I do not use.
I am using VLC 3.0.6 on Windows 7. Here is mycode:
sources:     - path: D:\FOLDER\S1       shuffle: true     - path: D:\FOLDER\A1       shuffle: true     - path: D:\FOLDER\C1       shuffle: true     - path: D:\FOLDER\A2       shuffle: true     - path: D:\FOLDER\B1       shuffle: true     - path: D:\FOLDER\B2       shuffle: true     - path: D:\FOLDER\R1       shuffle: true     - path: D:\FOLDER\B3       shuffle: true     - path: D:\FOLDER\A3       shuffle: true     - path: D:\FOLDER\C2       shuffle: true     - path: D:\FOLDER\A4       shuffle: true     - path: D:\FOLDER\B4       shuffle: true     - path: D:\FOLDER\R2       shuffle: true     - path: D:\FOLDER\A5       shuffle: true     - path: D:\FOLDER\D1       shuffle: true     - path: D:\FOLDER\C3       shuffle: true     - path: D:\FOLDER\A6       shuffle: true     - path: D:\FOLDER\B5       shuffle: true     - path: D:\FOLDER\F1       shuffle: true

@emoapostolov Thanks for taking time to report! I will look into it in the coming days.

@EugeneDae Thanks for the answer. I was testing with different kind of video files and came to the conclussion that VERY different duration files bug the script. For example I play music videos (around 3:30 min each) but when a bumper - a short file around 0:10 min - came along OR a very long music video - around 5 or 5:30) it is configured to be played with the duration of the previous file. Then everything plays all right until again a very long or a very short element come along. Hope this will helps figuring out the problem.

Hello! Any chance of resolving my problem?


Modify the bottom menu on the home screen to accommodate more items

We have a little "links" section at the bottom of the home screen.

As we're adding more and more items to the "links" section—like Field Guide and Privacy Policy—the UI is getting a bit cramped.
We'd like to modify the UI in the links section so that more items fit nicely on it.

In particular, we were thinking of

removing the "Buzz About by Minnesota Pollinators" text, and
making it so that, on small screens, the About and Privacy Policy are moved into a three-dot menu, while Field Guide and Markers remain in the card itself. (That is, Field Guide and Markers would take one click to get to; About and Privacy Policy would be take two clicks to get to.)

Closed as of #249.


Improve GUI

New commit due to issues with previous revert.

Codecov Report

Merging #73 (6b608c4) into master (dc60919) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #73      +/-   ##
============================================
- Coverage     69.65%   69.51%   -0.14%
  Complexity      456      456
============================================
  Files            79       79
  Lines          1529     1532       +3
  Branches        170      171       +1
============================================
  Hits           1065     1065
- Misses          410      413       +3
  Partials         54       54

Impacted Files
Coverage Δ
Complexity Δ

.../java/seedu/address/model/util/SampleDataUtil.java
26.66% <0.00%> (ø)
2.00 <0.00> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc60919...6b608c4. Read the comment docs.


test rendering with Xpra

Hopefully, http://xpra.org solves the per-host-customization issues related to GPU drivers.
Links:

https://www.xpra.org/trac/wiki/Usage/Docker
https://github.com/rogaha/docker-desktop

Known issues:

VirtualBox GPU driver is blacklisted for client -> always falls back to Mesa software rendering

Hmmm ... I dug a little bit deeper into the docs of Xpra and it looks like I was wrong. OpenGL rendering is done on the server side as it seems (but maybe you can check this?). At least I couldn't get it to work. It was always using Mesa software rendering for glxgears. Maybe I am missing something but maybe I was just plain wrong.

hmm, i also failed to get proper OpenGL performance (same system, no containers, unix shared sockets (AFAIK), xpra acting as screen): https://github.com/malex984/dockapp/wiki/Xpra

=> does not look suitable for our usage yet :(


What if I render DOM using server side react?

// And when using document to get the dom element, server side won't support "document" object for the following code:
Modal.setAppElement(el);
Modal.injectCSS();
// I have also tried the following but It will prompt me about I need to insert element in that area
let el = React.findDOMNode(this.refs.cdrExportModal)
console.info('el', el)
Modal.setAppElement(el);
Modal.injectCSS();
Please help!

They discuss about it here:
https://github.com/rackt/react-modal/issues/15
but the Modal.injectCSS() still gave me problems, so I ended up doing this:
var React = require('react');
var Modal = require('react-modal');
var ExecutionEnvironment = require('react/lib/ExecutionEnvironment');

if (ExecutionEnvironment.canUseDOM) {
  Modal.injectCSS();
  Modal.setAppElement(document.getElementById('react-app'));
}
...

The server stopped crashing and it works on the frontend.

Hi,
I tried something like this,
import React, { Component, PropTypes } from 'react';

var ReactCSSTransitionGroup = React.addons.CSSTransitionGroup;
var Modal = require('react-modal');

export default class Emails extends Component {
    constructor(props, context) {
        super(props, context);

        this.state = {
            modalOpen: false
        };
    }

    componentDidMount () {
        var appElement = React.findDOMNode(this);

        Modal.setAppElement(appElement);
        Modal.injectCSS();
    }

    render () {
        return (

                <Modal
                        isOpen={this.state.modalOpen}
                        onRequestClose={this.closeModal}
                        >

Hello

                        <button onClick={this.closeModal}>close</button>

I am a modal

                        <form>
                            <input />
                            <button>tab navigation</button>
                            <button>stays</button>
                            <button>inside</button>
                            <button>the modal</button>
                        </form>
                    </Modal>

);
    }

    openModal() {
        this.state = {
            modalOpen: true
        };
    }

    closeModal() {
        this.state = {
            modalOpen: false
        };
    }

    getStoreState () {
        return {
            modalOpen: this.context.getStore(EmailsStore).isModalOpen()
        };
    }
}

but still it doesn't works,..
Any other suggestion to make it works on a isomorphic app?
Regards.

@eriknyk what is the error that you get with your code?

I have not errors, just it doesn't works

this happens just trying to run webpacked code server side:
/Users/patrickwilliams/git/frontend-home-profile/node_modules/react-modal/lib/helpers/ariaAppHider.js:1
 (exports, require, module, __filename, __dirname) { var _element = document.b
                                                                    ^
ReferenceError: document is not defined
    at Object.<anonymous> (/Users/patrickwilliams/git/frontend-home-profile/node_modules/react-modal/lib/helpers/ariaAppHider.js:1:78)
    at Module._compile (module.js:460:26)
    at Module._extensions..js (module.js:478:10)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/patrickwilliams/git/frontend-home-profile/node_modules/babel/node_modules/babel-core/lib/api/register/node.js:214:7)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.cls_wrapMethod (/Users/patrickwilliams/git/frontend-home-profile/node_modules/newrelic/lib/shimmer.js:230:38)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/patrickwilliams/git/frontend-home-profile/node_modules/react-modal/lib/components/Modal.js:4:20)

Same error. Even with
var ExecutionEnvironment = require('react/lib/ExecutionEnvironment');
if (ExecutionEnvironment.canUseDOM) {
Modal.injectCSS();
Modal.setAppElement(document.getElementById('react-app'));
}
...
We are using server side rendering, so yes, document it's not defined on server.
I think it's a priority fixing this, since many of us are using server side rendering :)

+1 for the same error on server side rendering. Would really love a fix for this.

+1. Running into same issue on server side rendering

+1 for same error with server side rendering.

+1 over here for supporting server side rendering.
If you need a short term solution you can downgrade to 0.3.0 which supports server side rendering.

at the end I make it works, but without any styles,.. seems Modal.injectCSS(); is not working as expected or I need to add some stylesheets manually?

This has been open for quite some time. Given the amount of people struggling with isomorphic rendering it's perhaps worth mentioning this library works client-side only in the project README.md.

I didn't try it yet, but it seems that a PR was merged: https://github.com/rackt/react-modal/pull/70
:)

Server side rendering should be working with<EMAIL_ADDRESS>Let me know if you have any issues.

@mzabriskie can you be more specific, I am still experiencing this, what changed and is there an example somewhere I can look at?

Just be clear, it doesn't throw any error, it just doesn't render the modal and I can't find any examples that show how to change the mount-point in a server-side compatible manner.


Can't map custom scope when 'propdeps-maven' used

When I'm using propdeps-maven, mapping of another custom configuration doesn't work well.
Something like below should do the job:
configurations {
    pu
    compile.extendsFrom pu
}

project.conf2ScopeMappings.addMapping(310, configurations.pu, 'compile')

However the last line Maven of PropDepsMavenPlugin.apply() method breaks something. Mapping is not propagated to both project.install.repositories.mavenInstaller.pom.scopeMappings and uploadArchives.repositories.mavenDeployer.pom.scopeMappings which results with generated pom without dependencies for my custom configuration.
It's enough to add, that commenting line apply plugin: 'propdeps-maven' fixes issues. Not sure is it a bug in gradle itself or some missusage of gradle API on the plugin side.
Two things worth of noticing:

I tried cooking simple example to recreate the issue (copy-pasted at the bottom). In the simple example only installer mapping doesn't contain my custom scope. However in the real, multi-module project, I'm currently working with, both installer and deployer mappings are affected. I'm not able to recreate deployer mappings issue for the sake of example though.
Calling pom {}.writeTo('file.xml') always shows correct pom with all necessary dependencies even though pom deployed with uploadArchives is missing my mapped dependencies.

In the following example there are also a few tasks added. Just run gradle pI dI map to see de differences between mappings which should be all the same. Speaking of my case (not the example below) output for the installer and deployer are the same including hashcode, but both are wrong as they are missing pu scope. In the example below only installer is missing pu scope.
buildscript {
    repositories {
        mavenCentral()
        maven { url 'http://repo.spring.io/plugins-release' }
    }
    dependencies {
        classpath 'org.springframework.build.gradle:propdeps-plugin:0.0.7'
    }
}

apply plugin: 'java'
apply plugin: 'maven'
apply plugin: 'propdeps'
apply plugin: 'propdeps-maven'

configurations {
    pu
    compile.extendsFrom pu
}

group = 'test'
version = 0.1

project.conf2ScopeMappings.addMapping(310, configurations.pu, 'compile')

uploadArchives {
    repositories {
        mavenDeployer {
            repository(url: 'file://localhost/c:/ubs/dev/work/tmp/m2')
        }
    }
}

dependencies {
    compile 'org.codehaus.groovy:groovy-all:2.3.6'
    runtime 'org.mongodb:mongo-java-driver:2.12.4'
    provided 'javax.servlet:javax.servlet-api:3.1.0'
    pu 'joda-time:joda-time:2.3'
    testCompile 'org.spockframework:spock-core:0.7-groovy-2.0'
}

task pomInstaller << {
    println '\nINSTALLER'
    printlnScope2ConfMapping(install.repositories.mavenInstaller.pom.scopeMappings)
}

task pomDeployer << {
    println '\nDEPLOYER'
    printlnScope2ConfMapping(uploadArchives.repositories.mavenDeployer.pom.scopeMappings)
}

task mappings << {
    println '\nMAPPINGS'
    printlnScope2ConfMapping(conf2ScopeMappings)
}

void printlnScope2ConfMapping(def conf2ScopeMappings) {
    println '-' * 50
    conf2ScopeMappings.mappings.each {
        println "\t$it.key.name - $it.value.configuration.name, $it.value.scope, $it.value.priority"
    }
    println '\nhashcode:' + conf2ScopeMappings.hashCode() + '\n\n'
}

The propdeps plugin has moved to the Spring Attic and is no longer maintained.


Add implementation of deref

Closes #41
Implementation

Add LOAD instruction in the instruction set.
During execution, pull out the value and divide it by 8 to get the original index and then get the value from data memory.

All integration tests and yamtests are passing. Merging this.


Untitled Draft Overload

I noticed that starting a new story but not writing any text still saves as a draft. This can result in a large number of drafts labeled as "untitled" if you just open the page to preview the editor.
Possible solution: detect content entry and then save as draft.

Shouldn't be too hard to fix this bug. I'll get to it today :+1:

@kenny-hibino : Looks like this has been fixed. otherwise please assign this issue to me. Thanks


[BUG] Random Macros not showing up in list

🔵 Describe the bug:
When importing a new macro, I received the message Updating MACRONAME. However in the list /gsse I dont see it there. I have camped and come back.. It is inside SAVEDVARIABLES under
GSE3Storage = {
Shows in there. But not in list.
🔵 To reproduce: (Steps to reproduce the behavior)

Import
dquHfaqEuX8vSFKbnfHzbQFrfnmrCmOwgv9mjnni6AsrY2evFdOghvY5efwNuu19uvG)bHbkfLoiGwOifpeinrQGlIk1gvvOpcensvf1jvvLvkfrVukkMPQICtujTtu(jvOLkk6PuMQexvKQTQQQ(Quu5TQQ4UaH9sgSkoSqlwK8yqMmaxwWMvvPplsPgTQsonQ61Qk1SfLUTuy3Q0VLQHlLooQewUQ8CinDLUovQTJkrFxKsgVuK6HRkOfwfXWYkF2Xm52a1rqMoWmDqmVkYkXSH7IkdbmcyeWiGraJagHmGU3V6pzPF)(2tRlDa6E)Q)KbsJ7)dpu((vSkobSmUV)2Fqbq7nAJBmfFw(LJsJSpfr30Bbe3aaz(eVhN4ZXvpsCISIJGkgojjjXlJRrOxhvfXWQi7)4JpMkBavfzpvedlZjueDPJ5(9IALbqfXWYCUXxAh2Wn0GdD(52)k(AaIFaeIaaHyEzoHIOlD(52)T)A08yqqNp2FnI0bqGoP)q7A1kdi0Y3VOQigwfXWYOHga0qJyEzoHIOlDWj5UQEXQYOHMhn0iRWPnidi0Y3VAfZRIyyvedlJgAaqdnI5L5ekIU0X7DH9IvLrdnpAOrwHtBqgqOLVF1kMxfXWYOHga0qJyEzoHIOlAGlChUqb6qNxanSFauVrQ4sh64kdpgMo4KCxvpmD84k4CKW0XJRGZrcthCsURQhMoECfCosy64XvW5iHPdoj3v1dthpUcohjmD84k4CKW0bNK7Q6HPJhxbNJeMoUYWJHPdoj3v1dthpUcohjmD84k4CKIvLrdnpAOrwHtBqgqOLVF1kwvfXWYOHga0qJyEzoHIOlD84k4CKIvLrdnpAOrwHtBqgqOLVF1kgsvedlJgAaqdnI5L5ekIU0PwZadwSQmAO5rdnYkCAdYacT89RwXAkvedlJgAaqdnI5L5ekIU05hOEJuXfo008OlkiOdodFIlSyvz0qZJgAKv40gKbeA57xTILRIyyz0qdaAOrmVmNqr0Lo4KCxvVyvz0qZJgAKv40gKbeA57xTIbwfXWYOHga0qJyEzoHIOlD84k4CKIvLrdnpAOrwHtBqgqOLVF1kMlvedlJgAaqdnI5L5ekIU0PwZadwSQmAO5rdnYkCAdYacT89RwzzgAdXvmVScN2GSp17TYSn0(r3xOLVFLzbUWD4U8XSA1k7VBk38z3)Jp(yQSbuvKvE83VdlwPKbAVrQ4Q0iR84VFhwVsPvRwzwBa6pheRkR5cXVb6(frvrRmUg2OdXnQISsmB4UOYqaJagbmcyeWiGraldO79R(twt2b8HnrZ2m9x82rLbsJ7)dpu((vSkgxLX141Dm7F3n84YWD57xLsMdHFJUZUIHLXIncYkF2Xm52a1rqMoWmDqM1gG(ZbXWjiLvCeuXWjjjjjY4((B)bfaT3OnUXu8z5xoknA1Qvca

🔵 The error:
Paste the error message in this blockquote.

🔵 Screenshots:

🔵 Expected behavior:
It to import and show the macro
🔵 GSE.lua file:
Please provide your GSE.lua file or the export string for the specific macro that is causing an issue.

To find the GSE.lua file:

GSE.lua.txt
🔵 Desktop (please complete the following information):

OS: Windows 10 64bit
Game Version [retail]

🔵 GSE Version:

Version: [e.g. 3.1.16]
Downloaded From: https://www.curseforge.com

🔵 Additional context:
Add any other context about the problem here.

Hey ,
two questions - do these appear after you log back in?
and when this doesn’t appear, what is the state of the Out of combat queue.  You can see the Out of combat queue by hovering over the GSE Minimap icon.

No, I have camped out all the way and back in.. Still nothing on it.. It knows it is there.. If I try to re-add it.. It shows hey want to merge, overwrite and so on.. Just wont show up in the list..

Also I have tried changing its name.. Wont show up either.. Says it adds it but nothing new is showing up on this character...

Also, as you can see I was orbiros.. Wasnt in combat at all.

Even with your GSE.lua file - it shows for me:

Could there be something else called THORESCOGUARD like a weak aura?

I have no addons except for GSSE

Still not there.

And I can ADD one that I make and it shows up.. Just that one isnt showing up at all. Hell if you want to do a zoom or something so I can show you I am fine with doing that as well.

https://wowlazymacros.com/t/druid-guardian-thoresco/30118
It is a druid guardian macro.. How is it a hunter macro?

Because it has a classid of 3 - in the configuration panel someone has set
that as a hunter macro not a druid macro before exporting it.  Every time
you import it sees that 3 and puts it in hunter.
You could also turn on seeing all classes macros and you will find it under
hunter.
The fault is in your import itself not in GSE.  GSE is just doing what it
is told.
On Wed, 9 Nov 2022 at 3:46 pm, fluffster @.***> wrote:

https://wowlazymacros.com/t/druid-guardian-thoresco/30118
It is a druid guardian macro.. How is it a hunter macro?
—
Reply to this email directly, view it on GitHub
https://github.com/TimothyLuke/GSE-Advanced-Macro-Compiler/issues/1216#issuecomment-1308224839,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEMCFLW6W577TFINNGEQLDWHMXSBANCNFSM6AAAAAAR2UU2ME
.
You are receiving this because you commented.Message ID:
@.***
com>

--
Timothy Minahan**M 0406 413 680  |  E @.**

Very good, thanks

Just FYI I switched over to Hunter, it shows it there.. But it was set to Gaurdian.. I moved it to just be druid and it now shows up under druid.. But my other macros are set to guardian and they show up..


Created company without Unique Id.

Describe the bug
Because of the Import time error Company1 is been created without Unique Id.
Screenshots

And Company 1's account is not got created.

ok
yeh company import jo pehle hamne try kiya useki wajah se hua


Resolves PowerChargerVisualizer is Obsolete

About the PR

Splits the PowerChargerVisualizer into a component/system pair.
TODO:

[ ] Testing

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Reopen when you come back to this.

@DrSmugleaf Commits tested and pushed. Reopen whenever is convenient.


[Suggestions] HUD, engine performance improvements and rendering

I just wanted to say, that i really like your mod, even though it's really small right now lol
I wanted to share some suggestions like

adding a ui while driving the boat like a fuel meter or a speedometer or an overheating meter
a turbocharger for extra horsepower
possibly make the boat tilt like in real life

anyways those are just suggesions, keep up the good work!

GUI / HUD
I am currently working on a GUI inventory screen which displays those, but HUD additions would make sense too.
Engine performance improvements
The turbocharger shouldn't be too difficult since the back-end already supports performance-improving, equipable items
Rendering
Tilting might be a bit more difficult since it would also need to offset (and maybe tilt) the passenger renderers too. I was thinking about rotating the engine left and right when taking corners and locking the steering if you don't counter-steer it again. But the main focus for now is to improve the general user experience since it still is not very intuitive on how to use the engine.

Thanks for the ideas and the input!

Here is a little update with the work in progress stuff
https://youtu.be/hsCjpWoXPTg?si=qgPZf7cxvDY7hHnX
I think I will also add the fuel and the power level to the HUD, like I did with the heat, and position it a bit differently.


Aux window: investigate possibly memory leaks

From a quick test, I see globals on aux windows surviving the close of said window, which indicates the aux window is captured from the main window and cannot be GC'ed. We should understand how to avoid these kinds of leaks.
Some pointers after having talked to Sam from Slack team:

https://medium.com/@marshallofsound/how-window-open-can-become-your-worst-memory-leak-76610d8f0323
store pointers to window only in WeakRef
avoid instanceof window.XY checks and do duck-type-checks to avoid pointers to the rich objects
find leaks in CI via automated heap dumps and scanning for Detached *
add a symbol to the child window and try to find that in the dump (childWindow.__leakTracker = symbol('my-unique-symbol-name'))

symbols do not cause a leak of the child window

//cc @alexdima @deepak1556

Some interesting learnings:

we leak a lot, independent of floating windows or not, easily observable by comparing heap snapshots and doing some actions such as opening/closing editor groups with editors
we have a ton of detached HTMLElement which is a sign that some memory region that is not GC'ed captures them even though they are not in the DOM anymore
unfortunately, through one leaking HTMLElement, you leak the entire DOM structure due to the fact that each HTMLElement is linked to its parents and children up to window
this is a really nice blog post to understand more about leaks from closures: An interesting kind of JavaScript memory leak

I am pushing fixes for things I noticed where we clearly leaked things, but there are changes in my PR that are more like workarounds for how GC works and I do not want to push that forward. From my basic testing, with opening text editors in floating windows and then closing that window, I no longer see these windows leak, but its almost impossible to cover all cases.

My point about https://github.com/microsoft/vscode/pull/206950/files#diff-897ee1b8c7895d892a0a4b3bb3b42c25f16d475a640cff8e968b52703b83c561R198 being strange is void. This was an issue with how I was registering the disposable in the MultiParts class and thus cause a leak because the disposable would just hang there.
As such, nothing obscure so far in V8 with regards to GC!


Add note about saleor-app-checkout, fix ports

This PR adds information about installing Saleor App Checkout (tunnel) and fixes wrong ports used in README

Since we're already working on making the local development possible, I've created another PR with just the ports update in README: https://github.com/saleor/saleor-platform/pull/215


Temp: Merge WorkflowChain migrator into temporary branch

I created this PR to merge one of the migrators into a temporary branch I am using for testing a migration notebook.

I will merge this into the eecavanna/temp-all-migrators-2 branch even though one of the tests is failing.


Outsourcing presets

Hey,
wouldn't it be wonderful to outsource https://github.com/openstreetmap/iD/tree/master/data/presets to its own repository so other projects like osmmybiz or onosm can benefit from them?

Yea this is #2656  - we've made a few attempts at this but it never happened.  Lots of history on that ticket and in linked discussions.  It probably will happen eventually, but it's not a priority for the iD team right now.
For now, having the presets tightly coupled with the iD code lets us make changes to them easily (such as adding field types or changing the way documentation works, or adding validation).  Other projects can and do still use them by depending on the generated files in dist/.

#6483 is a good issue too, to get a sense of where we are heading with iD development.
(also see our talk from SOTM-US 2019).
Me closing this issue doesn't mean that we don't want to extract the presets - it's more that we want to modularize everything a lot more including the presets, and this will take a while and we're working on it slowly.


Fulcrum is fragile to Stops and Start before it's fully synced.

Jun 01 12:31:57 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:31:57.892] BitcoinDMgr: starting 3 bitcoin RPC clients ...
Jun 01 12:31:57 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:31:57.893] BitcoinDMgr: started ok
Jun 01 12:31:58 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:31:58.343] <Controller> Block height 792402, downloading new blocks ...
Jun 01 12:31:58 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:31:58.344] <Controller> fast-sync: Enabled; UTXO cache size set to<PHONE_NUMBER> bytes (available physical RAM:<PHONE_NUMBER> bytes)
Jun 01 12:32:00 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:32:00.501] <Controller> FATAL: Failed to spend: 0cedc5603c2b0607344e435bbbe47e55c5a8274843b8b71db72f6f217987e422:1 (spending txid: 69dc1652988e26fa3fadf6fb74a16b97268f315db65f66d0071ada78728a26c9)
Jun 01 12:32:00 node-OptiPlex-3050 Fulcrum[342423]: **The database is now likely in an inconsistent state. To recover, you will need to delete the datadir and do a full resynch. Sorry!**
Jun 01 12:32:00 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:32:00.501] Stopping Controller ...
Jun 01 12:32:00 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:32:00.502] Stopping BitcoinDMgr ...
Jun 01 12:32:00 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:32:00.504] Closing storage ...
Jun 01 12:32:00 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:32:00.504] Storage UTXO Cache: Flushing to DB ...
Jun 01 12:32:01 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:32:01.670] Shutdown complete
Jun 01 12:32:01 node-OptiPlex-3050 systemd[1]: fulcrum.service: Main process exited, code=exited, status=1/FAILURE

If there is not a clean way to stop the Fulcrum process then maybe a warning should be added about the risks.

Why do you say it's not clean?
On Fri, 2 June 2023, 2:42 am nostitos, @.***> wrote:

Jun 01 12:31:57 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:31:57.892] BitcoinDMgr: starting 3 bitcoin RPC clients ...
Jun 01 12:31:57 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:31:57.893] BitcoinDMgr: started ok
Jun 01 12:31:58 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:31:58.343]  Block height 792402, downloading new blocks ...
Jun 01 12:31:58 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:31:58.344]  fast-sync: Enabled; UTXO cache size set to<PHONE_NUMBER> bytes (available physical RAM:<PHONE_NUMBER> bytes)
Jun 01 12:32:00 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:32:00.501]  FATAL: Failed to spend: 0cedc5603c2b0607344e435bbbe47e55c5a8274843b8b71db72f6f217987e422:1 (spending txid: 69dc1652988e26fa3fadf6fb74a16b97268f315db65f66d0071ada78728a26c9)
Jun 01 12:32:00 node-OptiPlex-3050 Fulcrum[342423]: The database is now likely in an inconsistent state. To recover, you will need to delete the datadir and do a full resynch. Sorry!
Jun 01 12:32:00 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:32:00.501] Stopping Controller ...
Jun 01 12:32:00 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:32:00.502] Stopping BitcoinDMgr ...
Jun 01 12:32:00 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:32:00.504] Closing storage ...
Jun 01 12:32:00 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:32:00.504] Storage UTXO Cache: Flushing to DB ...
Jun 01 12:32:01 node-OptiPlex-3050 Fulcrum[342423]: [2023-06-01 12:32:01.670] Shutdown complete
Jun 01 12:32:01 node-OptiPlex-3050 systemd[1]: fulcrum.service: Main process exited, code=exited, status=1/FAILURE
If there is not a clean way to stop the Fulcrum process then maybe a
warning should be added about the risks.
—
Reply to this email directly, view it on GitHub
https://github.com/ArmanTheParman/Parmanode/issues/18, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASQCCX5BLRQ2727MVG67NE3XJDA7TANCNFSM6AAAAAAYXGBQXI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Why do you say it's not clean?

Looks cleaner than I thought, but it got corrupted from just stop and starting it.
Now syncing with 3000mb cache. This thing is intense to sync, I'm at 92% and I'm expecting another full day to get it to complete.
Process is IO bound, indexing fulcrum seems to takes longer than IBD at +3 days
(Samsung SATA SSD)

The do warn it can get corrupted, especially is using fast sync


Python logo doesn't work well

When I try to add the Python logo to my code it appears of color green and only a corner is visible, must have an error on the code but I'm not able to resolve it. With the other logos I don't have any problem. Hope you can fix it, thanks.

Python logo does have to much white space around it, a 16x16 logo was put into a 64x64 viewBox.
here is test.html I used for trying to replicate any issues.

There are lot's of tools for that like https://www.svgviewer.dev/. I will do it myself a bit later if I have time.
@HananGK, write better bug reports. You have an issue that is probably very specific to your code and situation, I have to blindly punch the logo into different situation and hope your issue shows up. Give as much information as you can about what you are doing and section of the code. Try to write a Minimal, Reproducible Example (causing the issue in as few lines of code as possible.)

Yeah, python logo had it's size set to 2500x2500 and a way to large viewBox. Here is a fixed version, I removed the dimensions entirely, and set viewBox="16 16 32 32". Dirty but works.

Fixed 🚀
https://github.com/pheralb/svgl/commit/6ad19d71f48aa34ebddae8ae1418ac1b607d6903


Initial Beta

Description
Initial Beta release
Resolution/What did you add?

Authentication
Create new unique short urls

Additional Release Steps

Add sentry env variable to production environment

How can we test this?

Run tests with make test
Run services with docker compose up
Run application with make run

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new errors
[x] Is my code backwards compatible
[x] Have I written unit tests

Warnings

:warning:
:exclamation: Big PR

: Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

  Generated by :no_entry_sign: dangerJS against 28a6be94e815e96584a2522ed968705b7227644c

Warnings

:warning:
:exclamation: Big PR

: Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

  Generated by :no_entry_sign: dangerJS against 4f07de9da64f83702ef2ad895def8bd180705641

Warnings

:warning:
:exclamation: Big PR

: Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

  Generated by :no_entry_sign: dangerJS against 88ec243462be2456172d6f1357ee4e3a12015882

Warnings

:warning:
:exclamation: Big PR

: Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

  Generated by :no_entry_sign: dangerJS against 087d25104aceeaa177c469331a614a4277fa505e

Warnings

:warning:
:exclamation: Big PR

: Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

  Generated by :no_entry_sign: dangerJS against 3cae5d62edd21495c41c3d2e819419b4f2413edc

Warnings

:warning:
:exclamation: Big PR

: Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

  Generated by :no_entry_sign: dangerJS against 22ba8cb73c85d62f301cb7df2827deb39925e3ac

Warnings

:warning:
:exclamation: Big PR

: Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

  Generated by :no_entry_sign: dangerJS against 558790dc4666fa798553c2bab0889e19f7054b0f

Warnings

:warning:
:exclamation: Big PR

: Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

  Generated by :no_entry_sign: dangerJS against 91c3c7d1874093b4d3a4afbaa41e96b22f30ff67

Warnings

:warning:
:exclamation: Big PR

: Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

  Generated by :no_entry_sign: dangerJS against a4e7996260247c519b33eea09e3d929b18050e67

Warnings

:warning:
:exclamation: Big PR

: Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

  Generated by :no_entry_sign: dangerJS against c058607fa0d6ac1f1c134b846bbcf9caafb84307

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


l7policy documentation incorrect

@dflanigan
What issues does this address?
Fixes #400
What's this change do?
The documentation followed the written spec for the l7 feature from
OpenStack, but of course that drifted from what was eventually
implemented in the API. Rectified the doc with the API.
Where should the reviewer start?
Any background context?
Documentation for creation of l7 policies and rules is wrong.

Actually tested each command against a real mitaka deployment.


benchmark test ,only 15.95 [#/sec] , the qps is slow.

benchmark test ,only 15.95 [#/sec] , the qps is slow.
//sql
select * from biz_activity where id  = '2';

Server Software:
Server Hostname:        localhost
Server Port:            8000

Document Path:          /
Document Length:        216 bytes

Concurrency Level:      100
Time taken for tests:   62.687 seconds
Complete requests:      1000
Failed requests:        0
Total transferred:      334000 bytes
HTML transferred:       216000 bytes
Requests per second:    15.95 [#/sec] (mean)
Time per request:       6268.679 [ms] (mean)
Time per request:       62.687 [ms] (mean, across all concurrent requests)
Transfer rate:          5.20 [Kbytes/sec] received

Connection Times (ms)
              min  mean[+/-sd] median   max
Connect:        0    0   0.3      0       1
Processing:   204 5936 4413.4   4210   22326
Waiting:      204 5936 4413.5   4210   22326
Total:        204 5936 4413.4   4210   22326

this is  golang  benchmark.
//sql
select * from biz_activity where id  = '2';

Server Software:
Server Hostname:        localhost
Server Port:            8000

Document Path:          /
Document Length:        248 bytes

Concurrency Level:      100
Time taken for tests:   2.095 seconds
Complete requests:      1000
Failed requests:        0
Total transferred:      357000 bytes
HTML transferred:       248000 bytes
Requests per second:    477.39 [#/sec] (mean)
Time per request:       209.471 [ms] (mean)
Time per request:       2.095 [ms] (mean, across all concurrent requests)
Transfer rate:          166.43 [Kbytes/sec] received

Connection Times (ms)
              min  mean[+/-sd] median   max
Connect:        0    0   0.2      0       1
Processing:    15  183 140.5    111     754
Waiting:       15  182 140.7    111     754
Total:         15  183 140.5    112     754

Hi, @zhuxiujia. This was closed by accident?
If no, then could you please share the actual rps for rust-mysql-simple?

Hi, @zhuxiujia. Was this closed by accident?
If no, then could you please share the actual rps for rust-mysql-simple?

maybe  this create  not support Send and Sync trift,and async or  .await  support
in my project I have to use   Metux + lazy_static!() to use  it.
so  i think every single query or exec action  run  in  only one thread. It's even packaged in Tokio
just like
   let data = task::spawn_blocking(move || {
            //the singletion() method is a  lazy_static{  Metux(my::Conn) }
            let data = singleton().query("select * from biz_activity where id  = '2';");
            return data;
        }).await;

so the QPS/sec   also  slow.
but  if you  use  golang  std.sql to  benchmark this code (std library support  coroutines)
the qps  was high more than  500 QPS/sec

Hi, @zhuxiujia. Was this closed by accident?
If no, then could you please share the actual rps for rust-mysql-simple?

the benchmark code in Github project ( https://github.com/rbatis/rdbc )
in rdbc/rdbc/src/mysql/
/// use this command  run this code in project root,you may install your self mysql database
/// cargo test --release --color=always --package rdbc --lib mysql::test_bench_mysql --all-features -- --nocapture --exact
#[test]
pub fn test_bench_mysql(){
      let driver=MySQLDriver::new();
      let mut conn = driver.connect("mysql://root:TEST@localhost:3306/test").unwrap();

      let start_time=SystemTime::now();
      let total=1000;
      for i in 0..total{
          conn.query_raw("select * from biz_activity where id = 2");
          println!("done:{}",i);
      }
      count_time_tps(total,start_time);
}

Have you considered mysql_async create?


[Issue-374] Direct dictionary dataload failure with lenient date parsing

Fixed issue #374
Added UT for TimeStampDirectDictionaryGenerator

Closing this issue as have raised new PR #458 in the public branch.


Crash upon more than character inserted into Prefix field

I'm using Llama_Chat_gguf_VK_vulkan_mini.exe (which I believe is what most NVIDIA GPU users should be using?) and on completely default settings, I'll go into "Text Settings" and type into this field:

But upon inserting more than 1 character, the program crashes.
P.S. Please make Shift+Enter always insert a newline irrespective of the toggle status of Send messages by Enter (should probably be changed to "with Enter").

Hi! Thanks for the report, seems like Prefix is broken again, I'll look into it. Haven't used prefix for a long time.
As for Shift+Enter, I'm not sure it's possible in ImgUI (should be?), but it would be handy indeed.

Oh, and btw:

which I believe is what most NVIDIA GPU users should be using?

Both Clblast and Vulkan versions are compatible with Nvidia GPUs, just be aware that Clblast doesn't work with MoE models.

Pascal architecture if that makes a difference.

I see not much difference on my 1060 3GB (Vulkan is slightly faster, but each layer takes more VRAM), but that amount of VRAM is not enough to test that properly. However, Vulkan takes additional time to compile shaders on each launch, so it's a bit less convenient - and I don't use MoE models for now.
I've fixed the problem you've reported, please check. Shift + Enter should also work.


Refactor of LGSSM parallel inference

This PR slightly refactors the LGSSM parallel inference code and adds a few new features. The changes include:

Using named tuples for the messages (i.e. associative scan elements)
Minor tweaks to function/variable names
Adding a posterior sampler (inspired by @ezhang94's implementation!)
Adding support for bias terms in the dynamics and emissions (still no support for inputs)
Adding a preamble to explain indexing of the initial state, as suggested by by @gileshd

The code passes the current tests + a new sampling test (courtesy of @ezhang94)
from dynamax.linear_gaussian_ssm.parallel_inference_test import (
    TestTimeVaryingParallelLGSSMSmoother,
    TestTimeVaryingParallelLGSSMSampler,
    TestParallelLGSSMSmoother)

TestTimeVaryingParallelLGSSMSampler.test_sampled_covariances(TestTimeVaryingParallelLGSSMSampler)
TestTimeVaryingParallelLGSSMSampler.test_sampled_means(TestTimeVaryingParallelLGSSMSampler)

TestTimeVaryingParallelLGSSMSmoother.test_smoothed_means(TestTimeVaryingParallelLGSSMSmoother)
TestTimeVaryingParallelLGSSMSmoother.test_smoothed_covariances(TestTimeVaryingParallelLGSSMSmoother)
TestTimeVaryingParallelLGSSMSmoother.test_filtered_means(TestTimeVaryingParallelLGSSMSmoother)
TestTimeVaryingParallelLGSSMSmoother.test_filtered_covariances(TestTimeVaryingParallelLGSSMSmoother)
TestTimeVaryingParallelLGSSMSmoother.test_marginal_loglik(TestTimeVaryingParallelLGSSMSmoother)

TestParallelLGSSMSmoother.test_smoothed_means(TestParallelLGSSMSmoother)
TestParallelLGSSMSmoother.test_smoothed_covariances(TestParallelLGSSMSmoother)
TestParallelLGSSMSmoother.test_filtered_means(TestParallelLGSSMSmoother)
TestParallelLGSSMSmoother.test_filtered_covariances(TestParallelLGSSMSmoother)
TestParallelLGSSMSmoother.test_marginal_loglik(TestParallelLGSSMSmoother)

Currently the bias terms in these tests are 0, which should probably be changed so that we can ensure the biases are being handled correctly. I could just introduce a random bias, but was also wondering if it would make more sense to just import the test-models that are generated in inference_test.py? In general it seems kind of awkward that dynamax currently has three different ways to generate simulated LGSSMs for testing purposes, one for serial LGSSMs, one for parallel LGSSMs, and one for EKF testing.

Thanks @calebweinreb! I agree that unifying the test model generation would be a useful contribution! Let's do that in a separate issue/PR though.

Also, in case it seems like some of these changes came out of thin air, Caleb and I discussed adding the *Message classes offline. I think these nicely complement the parallel HMM inference code now.


request for annotation - POST tasks/search fails

Got Internal server error. Failed request to 'users' microservice: {"detail":"Forbidden"}
It fails when using non-admin jw-token.
It works fine with admin token

PR: https://github.com/epam/badgerdoc/pull/195


Make top example in README more logical

Pass what looks like a username to the callback.
And fix the name of the key in the returned table.

Thank you!


[Accessibility] Problem with text scaler

I'm using flutter 3.24.5 and on Apple devices (web and app) it seems that when we resize text, nothing is working.
Thank you!

Hi @Evhalon, please provide a complete minimal reproducible code sample along with detailed steps to reproduce so that we can properly investigate this.
Please also upgrade to the latest version of flutter stable (3.27.1) to see if you still experience this. If you do, please provide the updated output of flutter doctor -v.
Please share any screenshots/screen recordings that are relevant.
Thank you

Closing this as a duplicate of https://github.com/flutter/flutter/issues/160416


Use print() function in both Python 2 and Python 3

Legacy print statements are syntax errors in Python 3 but print() function works as expected in both Python 2 and Python 3.

Please fix in upstream NuttX if this isn't already resolved. https://github.com/apache/incubator-nuttx

apache/incubator-nuttx#3281


update to<EMAIL_ADDRESS>

Updates the version, and switch from electron-prebuilt to electron.

ping @mattdesl

Thanks, bumped minor version!


refactor(shell): Use new fancy anstyle API

What does this PR try to resolve?
Simplifies working with colored output
How should we test and review this PR?
Additional information
CC @joshtriplett

Way too fancy but I love it 👍🏾.
@bors r+

:pushpin: Commit bf664dabbe240a8541c8843fe9fe79f4b34282d5 has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit bf664dabbe240a8541c8843fe9fe79f4b34282d5 with merge 61debf843bd9255cbebcc72237721d3734245a93...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 61debf843bd9255cbebcc72237721d3734245a93 to master...


Update Version

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:

[ ] Pre-commit or other linting tools are used to fix the potential lint issues.
[ ] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

Why remove the code to check the version of mmengine
As we use the newest version of mmengine and it is no need to check the version currently, we can add the version check before release.


Add the tqdm library

Is your feature request related to a problem? Please describe.
When we begin download, I'd like to see how much fo the download is finished, and how quickly via a loading bar
Describe the solution you'd like
Import the super lightweight tqdm library and embed it into our loops that deal with downloading. Could be useful for queries that take a while as well to hear back from the api service
Additional context
Could be tough to infer the current state of a tqdm loading bar with multithreading. Have to make sure the loading bar doesn't increase and decrease as threads finish their tasks

Hi @jamie-sgro ,
I would like to contribute a PR on this issue. Can you assign it to me?
I have partially implemented what you suggested, with a multiple progress bar, each for a separate download.
Once the download is finished, it looks like the below picture.

If there is any specific requirement you think is useful, do let me know, ill add it to the PR.
Thanks,
Aman

That's great to hear @amanbagrecha, thanks for your contribution. Also I've drafted up my response to your new open issue. I'm just running it by the rest of the team to make sure my assumption regarding the dio holds true. I look forward to the PR for this tqdm issue!


Add license scan report and status

This is amendment of #369, and for closing that.
That PR is created by bot, so it may not be updated.

@pboling Would you please review this?

Pull Request Test Coverage Report for Build 708

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 706:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls

Pull Request Test Coverage Report for Build 708

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 706:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls

Pull Request Test Coverage Report for Build 708

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 706:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls

Pull Request Test Coverage Report for Build 708

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 706:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls

Looks great!  Thanks!


Setup ingresses in K8s version

I'm not absolutely sure, but I think it's actually possible for both docker-compose and k8s.
If we're allowing folks to setup hostnames via some vars (#3), it also makes sense to provision those hostnames and resolve them correctly.
In case of K8s, we can throw in some ingress resources that should take care of that, without expressing an opinion on which ingress class (Traefik vs Nginx) they should use.
In case of docker-compose, I think Docker can take care of hostnames for us, at least there's a hostname: param for a service, and we can describe the network and aliases for hosts, i.e. use default bridge network and set aliases that should resolve at least on the docker host. I don't know if docker-compose can actually provide ingresses — probably not, and it's probably obvious enough to the end users that they're responsible for routing traffic to the container if they prefer docker.
WDYT?

Ingresses are now available with the Studio Helm chart: https://github.com/iterative/helm-charts


Consider a humans.txt or robots.txt file

Just like how many websites have it, apparently!

Closed for now by 08dd447


[ENHANCEMENT] Export country list using ESM import

If you want to create a page with a selector to select countries, instead of clicking on it, it's a good idea to be able to get the list of countries from the library
i took it from source code, but it should be exported
(or i missed something ?)

So you want to get a list like export countries = ["cn", "us", "de", ...]?

i'll do as soon as possible

Done.
tells me if i made a mistake. i use github alone, for backup purpose mainly, so i'm not used to use pull requests


No way to aggregate customers by order count when limited to status

Several tasks (ids 288,292, 62, 64, 65) require to get the top k customers by the order count with status=x (e.g. status=completed, status=cancelled).
I could not find such an option in the UI. Nor did I find a successful user trajectory from those which were published.
What is the expected way to complete those tasks?
Thanks,
Eyal

(Probably also relevant to task ids 289-291)

You are right; there is no option to gather customers by the number of orders. These tasks require the agent to understand the tables. The humans also perform literal counting of orders per user, so there is no recording of the counting.


asdda

asdadsd

@MihaiDejeu this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2020-12-15T17:05:03.797891.
Estimation here is 60 minutes, that's how much you will be paid.
Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.
If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.

@MihaiDejeu please keep in mind that manual assignment of tickets is a bad practice and it is discouraged. Next time, please let me elect the assignee.

@MihaiDejeu thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.


Build error, ambiguous overload.

Attempting a build on Windows using GCC and mingw-w64 (g++ (i686-posix-dwarf-rev0, Built by MinGW-W64 project) 5.1.0). I am getting the following overload ambiguity error where add is called on the outbuffer object to add a numeric value. Does this look familiar or could this be a compiler/windows specific issue?
In file included from \AMQP-CPP-master\src\includes.h:40:0,
                 from \AMQP-CPP-master\src\array.cpp:7:
/AMQP-CPP-master/include/numericfield.h: In instantiation of 'void AMQP::NumericField<T, F, <template-parameter-1-3>, <template-parameter-1-4> >::fill(AMQP::OutBuffer&) const [with T = long long unsigned int; char F = 'T'; <template-parameter-1-3> = std::enable_if<true, long long unsigned int>; <template-parameter-1-4> = std::enable_if<true, long long unsigned int>]':

/AMQP-CPP-master/include/metadata.h:333:59:   required from here
/AMQP-CPP-master/include/numericfield.h:156:9: error: call of overloaded 'add(long long unsigned int&)' is ambiguous
         buffer.add(value);
         ^
In file included from AMQP-CPP-master\src\includes.h:34:0,
                 from AMQP-CPP-master\src\array.cpp:7:
/AMQP-CPP-master/include/outbuffer.h:138:10: note: candidate: void AMQP::OutBuffer::add(uint8_t)
     void add(uint8_t value)
          ^
/AMQP-CPP-master/include/outbuffer.h:149:10: note: candidate: void AMQP::OutBuffer::add(uint16_t)
     void add(uint16_t value)
          ^
/AMQP-CPP-master/include/outbuffer.h:161:10: note: candidate: void AMQP::OutBuffer::add(uint32_t)
     void add(uint32_t value)
          ^
/AMQP-CPP-master/include/outbuffer.h:173:10: note: candidate: void AMQP::OutBuffer::add(int8_t)
     void add(int8_t value)
          ^
/AMQP-CPP-master/include/outbuffer.h:184:10: note: candidate: void AMQP::OutBuffer::add(int16_t)
     void add(int16_t value)
          ^
/AMQP-CPP-master/include/outbuffer.h:196:10: note: candidate: void AMQP::OutBuffer::add(int32_t)
     void add(int32_t value)
          ^
/AMQP-CPP-master/include/outbuffer.h:208:10: note: candidate: void AMQP::OutBuffer::add(float)
     void add(float value)
          ^
/AMQP-CPP-master/include/outbuffer.h:219:10: note: candidate: void AMQP::OutBuffer::add(double)
     void add(double value)
          ^
CMakeFiles\amqp-cpp.dir\build.make:62: recipe for target 'CMakeFiles/amqp-cpp.dir/src/array.cpp.obj' failed
mingw32-make.exe[2]: *** [CMakeFiles/amqp-cpp.dir/src/array.cpp.obj] Error 1
CMakeFiles\Makefile2:66: recipe for target 'CMakeFiles/amqp-cpp.dir/all' failed
mingw32-make.exe[1]: *** [CMakeFiles/amqp-cpp.dir/all] Error 2
makefile:126: recipe for target 'all' failed
mingw32-make.exe: *** [all] Error 2

My mistake, this is not really an issue. For reference, here's what happened. I made some quick and dirty changes in attempt to build on my windows 7 system. I removed calls to htobe64, the alias for WinSock2 htonll. The htonll function was added to the windows socket libraries in windows 8/server 2012. So in my version of winsock2, htonll does not exist. My hasty removal included OutBuffer's add(int64_t) and add(uint64_t) which lead to the ambiguity. I just needed to replace those functions and give the htobe64 and be64toh an alternative definition other than htonll.


Create jack2.json to detect ~/.jackdrc

Hard-coded as shown at https://github.com/jackaudio/jack2/blob/develop/common/JackServerGlobals.cpp#L166

Closes #368


docs: Transaction consensus rules: Size rules

Motivation
Document the transaction consensus rules. This pull request is about a category of them that we called transaction size rules. Will close https://github.com/ZcashFoundation/zebra/issues/3426 if merged.
Solution
Document all the rules in the ticket, remove extra documentation and try to leave where possible just one text for each consensus rule.
Review
Anyone can review.
Reviewer Checklist

[ ] Consensus rule docs are in a good spot.
[ ] All the rules in the ticket were added or modified in this PR.
[ ] No piece of doc comment that i want to keep was deleted.

Follow Up Work
The other 2 sections of the transaction consensus rules which are in the following issues:

https://github.com/ZcashFoundation/zebra/issues/3427
https://github.com/ZcashFoundation/zebra/issues/3428

I was not able to found this rule :
[Pre-Sapling] The encoded size of the transaction MUST be less than or equal to 100000 bytes.
We probably don't implement it because we checkpoint but i was wondering if this should be quoted anyway somewhere in the code with a note on why it is not enforced.

I was not able to found this rule :
[Pre-Sapling] The encoded size of the transaction MUST be less than or equal to 100000 bytes.
We probably don't implement it because we checkpoint but i was wondering if this should be quoted anyway somewhere in the code with a note on why it is not enforced.

I suggest quoting it where we enforce the block size limit on transactions. (Since transactions must get mined into a block to be useful, we reject transactions that are larger than blocks.)

Thank you @teor2345 , i quoted the missing rule with some notes at https://github.com/ZcashFoundation/zebra/pull/3461/commits/4089e5a73e0637f6a31761a876f69f69d14a3098

This PR failed due to an unrelated timing issue in the acceptance tests:

---- zebra_zcash_listener_conflict stdout ----
Error:
0: conflicted node2 was still running, but the test expected a panic

https://github.com/ZcashFoundation/zebra/runs/5099762771?check_suite_focus=true#step:13:1742
I don't think we have a ticket for this failure, I haven't seen it in months.


Yuvaraj_Log_Time

Please publish my package and run it.
Yuvaraj_Log.Time.1.0.2.zip

@YuvarajKalaimani
Please modify the package name and publish it and create an issue again.


Error building Qt4.8.7 on system with foreign locales

I tried many times building qt4.8.7 using win10（64bit）plus vs2013, but there are always some problems occurring (as showed in the picture). I have already changed the wrong quotation in C:\D\Support\qt..\src\3rdparty\webkit\source\webcore\platform\DefaultLocalizationStrategy.cpp.
I searched many blocks for the answer ,and I was told to use this link"https://raw.githubusercontent.com/jcfr/qt-easy-build/4.8.7-update-to-cmake-3.4.3/windows_build_qt.ps1" instead of "https://raw.githubusercontent.com/jcfr/qt-easy-build/4.8.7/windows_build_qt.ps1". But the first link was unavailable. please help me.

@qq794863351  The branch 4.8.7 has just been updated to use the latest version of CMake (v3.11).
To address the issue, may be you could build Qt setting the local code page to US. May be you could try typing:
chcp 437

See https://ss64.com/nt/chcp.html

@jcfr Thanks for so quick a reply!
I tried typing chcp 437, but I think you misled the Chinese words for the errors. By typing chcp 437, the Chinese prompt can not show normally, but the errors still exist.

I finally build successfully by looking up the issues discussed in the following link：
https://github.com/jcfr/qt-easy-build/issues/19#issuecomment-336039272
here I want to summarize the solution to make it more clear:
When getting the errors like this, find the downloaded files at C:\D\Support. Open  file "qt-4.8.7-64-vs2013-deb" if you are building in debug mode.(open"qt-4.8.7-64-vs2013-rel" if building in release mode ) Then find C:\D\Support\qt-4.8.7-64-vs2013-deb\src\3rdparty\webkit\Source\WebCore\platform\DefaultLocalizationStrategy.cpp, open it and make two changes:
1.line 325 change the strange quotation marks:
return formatLocalizedString(WEB_UI_STRING("Look Up "%@"", "Look Up context menu item with selected word"), selectedCFString.get());
2.line 327 change the strange quotation marks, and add two '' ：
return WEB_UI_STRING("Look Up """, "Look Up context menu item with selected word").replace("", truncatedStringForLookupMenuItem(selectedString));
hope this can help others in the future.
BTW, when searching for the solutions, I find this error occurs almost only with Chinese users. and I do not know why..

@jcfr Thanks for so quick a reply!
I tried typing chcp 437, but I think you misled the Chinese words for the errors. By typing chcp 437, the Chinese prompt can not show normally, but the errors still exist.
60ec0ecb6a0a5c4c74e8c6a6d224cea
I finally build successfully by looking up the issues discussed in the following link：
#19 (comment)
here I want to summarize the solution to make it more clear:
When getting the errors like this, find the downloaded files at C:\D\Support. Open file "qt-4.8.7-64-vs2013-deb" if you are building in debug mode.(open"qt-4.8.7-64-vs2013-rel" if building in release mode ) Then find C:\D\Support\qt-4.8.7-64-vs2013-deb\src\3rdparty\webkit\Source\WebCore\platform\DefaultLocalizationStrategy.cpp, open it and make two changes:
1.line 325 change the strange quotation marks:
return formatLocalizedString(WEB_UI_STRING("Look Up "%@"", "Look Up context menu item with selected word"), selectedCFString.get());
2.line 327 change the strange quotation marks, and add two ''：
return WEB_UI_STRING("Look Up """, "Look Up context menu item with selected word").replace("", truncatedStringForLookupMenuItem(selectedString));
hope this can help others in the future.
BTW, when searching for the solutions, I find this error occurs almost only with Chinese users. and I do not know why..

@jcfr Thanks for so quick a reply!
I tried typing chcp 437, but I think you misled the Chinese words for the errors. By typing chcp 437, the Chinese prompt can not show normally, but the errors still exist.

I finally build successfully by looking up the issues discussed in the following link：
#19 (comment)
here I want to summarize the solution to make it more clear:
When getting the errors like this, find the downloaded files at C:\D\Support. Open file "qt-4.8.7-64-vs2013-deb" if you are building in debug mode.(open"qt-4.8.7-64-vs2013-rel" if building in release mode ) Then find C:\D\Support\qt-4.8.7-64-vs2013-deb\src\3rdparty\webkit\Source\WebCore\platform\DefaultLocalizationStrategy.cpp, open it and make two changes:
1.line 325 change the strange quotation marks:
return formatLocalizedString(WEB_UI_STRING("Look Up "%@"", "Look Up context menu item with selected word"), selectedCFString.get());
2.line 327 change the strange quotation marks, and add two ''：
return WEB_UI_STRING("Look Up """, "Look Up context menu item with selected word").replace("", truncatedStringForLookupMenuItem(selectedString));
hope this can help others in the future.
BTW, when searching for the solutions, I find this error occurs almost only with Chinese users. and I do not know why..

@jcfr Thanks for so quick a reply!
I tried typing chcp 437, but I think you misled the Chinese words for the errors. By typing chcp 437, the Chinese prompt can not show normally, but the errors still exist.

I finally build successfully by looking up the issues discussed in the following link：
#19 (comment)
here I want to summarize the solution to make it more clear:
When getting the errors like this, find the downloaded files at C:\D\Support. Open file "qt-4.8.7-64-vs2013-deb" if you are building in debug mode.(open"qt-4.8.7-64-vs2013-rel" if building in release mode ) Then find C:\D\Support\qt-4.8.7-64-vs2013-deb\src\3rdparty\webkit\Source\WebCore\platform\DefaultLocalizationStrategy.cpp, open it and make two changes:
1.line 325 change the strange quotation marks:
return formatLocalizedString(WEB_UI_STRING("Look Up "%@"", "Look Up context menu item with selected word"), selectedCFString.get());
2.line 327 change the strange quotation marks, and add two '''：
return WEB_UI_STRING("Look Up """, "Look Up context menu item with selected word").replace("", truncatedStringForLookupMenuItem(selectedString));
hope this can help others in the future.
BTW, when searching for the solutions, I find this error occurs almost only with Chinese users. and I do not know why..

@jcfr Thanks for so quick a reply!
I tried typing chcp 437, but I think you misled the Chinese words for the errors. By typing chcp 437, the Chinese prompt can not show normally, but the errors still exist.

I finally build successfully by looking up the issues discussed in the following link：
#19 (comment)
here I want to summarize the solution to make it more clear:
When getting the errors like this, find the downloaded files at C:\D\Support. Open file "qt-4.8.7-64-vs2013-deb" if you are building in debug mode.(open"qt-4.8.7-64-vs2013-rel" if building in release mode ) Then find C:\D\Support\qt-4.8.7-64-vs2013-deb\src\3rdparty\webkit\Source\WebCore\platform\DefaultLocalizationStrategy.cpp, open it and make two changes:
1.line 325 change the strange quotation marks:
return formatLocalizedString(WEB_UI_STRING("Look Up "%@"", "Look Up context menu item with selected word"), selectedCFString.get());
2.line 327 change the strange quotation marks, and add two  backslashes：

（sorry to put picture here, because backslash can not be shown)
hope this can help others in the future.
BTW, when searching for the solutions, I find this error occurs almost only with Chinese users. and I do not know why..

@jcfr here are some other questions, please help me.
1.my computer was installed with other version of Qt as well as Qt-addin for vs2013. if I uninstall them, will this influence  Qt 4.8.7?
2.my next step is to build 3d slicer, will the building mode of Qt ( debug or release, 64bit or 32 bit) have influence on building of slicer？ for example, need I choose 64bit cmake to build slicer if I build Qt in 64 bit?
really sorry to bother you

我也是这个错误，解决了啊，之前看到昨天看到有人说是 中文双引号问题，可是改了还是不行，Windows的控制台太tm难用了，而且改了双引号显然不对，转义之后就编译成功了，现在正在build Slicer。一会儿看看是不是成功。

1.my computer was installed with other version of Qt as well as Qt-addin for vs2013. if I uninstall them, will this influence Qt 4.8.7?

No it shouldn't

2.my next step is to build 3d slicer, will the building mode of Qt ( debug or release, 64bit or 32 bit) have influence on building of slicer？ for example, need I choose 64bit cmake to build slicer if I build Qt in 64 bit?

Yes, if you build Qt in 64-bit Release, you will have to select the corresponding Visual Studio Generator ending with Win64, in you case it would be Visual Studio 12 2013 Win64 and then select "Release" in virtual studio.
Or build using this command line:
cmake --build . --config Release  -- /m

here I want to summarize the solution to make it more clear:

Does this patch properly capture what you described:
325c325
<     return formatLocalizedString(WEB_UI_STRING("Look Up “%@”", "Look Up context menu item with selected word"), selectedCFString.get());
---
>     return formatLocalizedString(WEB_UI_STRING("Look Up \"%@\"", "Look Up context menu item with selected word"), selectedCFString.get());
327c327
<     return WEB_UI_STRING("Look Up “<selection>”", "Look Up context menu item with selected word").replace("<selection>", truncatedStringForLookupMenuItem(selectedString));
---
>     return WEB_UI_STRING("Look Up \"<selection>\"", "Look Up context menu item with selected word").replace("<selection>", truncatedStringForLookupMenuItem(selectedString));

@gopain

@jcfr

@qq794863351 我x64 Qt Debug模式编译好了，但是Release不可以，然后Slicer Debug也可以了，先开发吧，Release等打包的时候再来处理。

@jcfr Really thanks for your patience.
according to @gopain ,this error occurs because visual studio can not download some resources due to the Internet environment. I will try later by using vpn.

Closing as current maintenance are geared toward maintaining build for Qt 5.15.1 on Linux and macOS.
That said, contributions are welcome.


Error reporting in the Pipeline Trigger Extension

Describe the issue
There is a bug in the error-handling logic of the TriggerPipeline extension. It's currently failing to parse the error response when validation errors occur. This results in unhelpful error messages.
**Extension **

Extension: TriggerPipeline
Version: 2.0.6

To Reproduce
Simulate an Invoke-RestMethod failure, it will fail with the Cannot bind argument to parameter 'Message' because it is null.
Expected behavior
When there's an error you get useful error messages.
Log info
##[error]Cannot bind argument to parameter 'Message' because it is null.

Will check when I go do this


README Structure pattern (Enh)

hello @koladev32
Please update the README using a similar structure as for:
https://github.com/app-generator/sample-flask-best-practices
ty!

Good here!

Ty @koladev32 for the fix.


Error when running on Raspbian

It installs fine but I recieve this error when launching ds4drv http://imgur.com/43N9R5D (using Python 2.7-dev)
I think it has something to do with the packages I have? Though I did install all the dependencies, any ideas?

I can remember I had some similar problems.
The Packages on the Raspbian are a bit differently of the naming if I right.
Try to check that you really have pyudev installed and starting ds4drv with sudo.
I can confirm that ds4drv is working on the raspbian for me,  I noticed when you have overclocked the pi to much you getting lots of connection errors with the driver. The pi is working but the driver is stucking.

There has been a workaround that was posted in another issue similar to this problem.
https://github.com/chrippa/ds4drv/issues/66#issuecomment-189875102

Please test if this still occurs with ds4drv 0.5.1.


WYSIWYG editor textarea not recognized by LanguageTool

I am using LanguageTool's browser extension to check my language, spelling and grammar. It's an awesome tool that helps iron out some mistakes.
In Gitea's WYSIWYG editors, for example when writing an issue, I noticed that LanguageTool does not recognize the textarea.

As soon as I revert to the simple textarea, the textarea is recognized, though:

Initially I thought this might be due to the extended Markdown WYSIWYG functionality of the advanced editor. However, I checked both GitHub

and Stack Overflow:

My guess is that the LanguageTool extensions misread some HTML signature. I checked both the Firefox and Chromium extensions. They behave the same.
Unfortunately, I am not versed in web development, so I don't quite know what to look for. If someone can point me in the right direction, I can add more details.

This is because CodeMirror does not represent as something many browser addons can recognize. I think it can only be fixed by https://github.com/go-gitea/gitea/issues/10729.

Fixed by #19776

#19776

This feature has been deployed on try.gitea.io, feel free to test it and report bugs.


PR: Remove usage of load_exception in KernelComm

Description of Changes

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[ ] Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #11471
Depends on spyder-ide/spyder-kernels#204
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@impact27, I just merged spyder-ide/spyder-kernels#204, so please resync our subrepo again.

@impact27, I just did the resync myself, so don't worry about it.

Hello @impact27! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file bootstrap.py:

Line 153:60: E502 the backslash is redundant between brackets


AEROGEAR-2794 Document how to download the build artefact to device

JIRA: AEROGEAR-2794
MOTIVATION
Update the documentation for creating a mobile build with a section around how to access and download your artefact once it is ready using the generated QR code.

@maleck13, @odra updated


Automated cherry pick of #1779: baremetal: fix msdos last primary partition not resized

Cherry pick of #1779 on release/2.10.0.
#1779: baremetal: fix msdos last primary partition not resized

/lgtm
/approve

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@4833fbd). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release/2.10.0   #1781   +/-   ##
================================================
  Coverage                  ?   7.68%
================================================
  Files                     ?     410
  Lines                     ?   62604
  Branches                  ?       0
================================================
  Hits                      ?    4810
  Misses                    ?   57385
  Partials                  ?     409

Flag
Coverage Δ

#aFlag
7.68% <0%> (?)

Impacted Files
Coverage Δ

pkg/baremetal/utils/disktool/disktool.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4833fbd...def2f6b. Read the comment docs.


Error in running chatfred

I had a look at the troubleshooting section

[x] Yes
[ ] No

Describe your problem
A clear and concise description of what the bug is.
Installed workflow. It does not run. The debug window shows this error:
ERROR: ChatFred[Run Script] xcrun: error: invalid active developer path (/Library/Developer/CommandLineTools), missing xcrun at: /Library/Developer/CommandLineTools/usr/bin/xcrun
When I check ChatGPT API. It is not getting any requests.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots
If applicable, add screenshots to help explain your problem.
Relevant information from the ChatFred_Error.log file
Date/Time: 2023-03-10 16:32:29.819957
model: gpt-3.5-turbo
workflow_version: 1.2.0
error_message: Incorrect API key provided: sk-44******************************************PEG2.   You can find your API key at https://platform.openai.com/account/api-keys.
user_prompt: Why do birds fly?
temperature: 0.0
max_tokens: None
top_p: 1
frequency_penalty: 0.0
presence_penalty: 0.0

Additional context
Add any other context about the problem here.

Hey @fouadzreik!
The first idea which comes to my mind is that you may need to install Xcode developer tools. Try this - just type it in your terminal: xcode-select --install.