Allow Taint?

So my situation may be a little unique but perhaps someone could shine some light on it for me.
http://pubgaddict.com/gun
I am working on a Weapon Builder / Image creator. So far its working great with html2canvas and exporting and saving works good. However I have a feature that allows the user to upload a file from their computer using input form and it will change the background image of the div that html2canvas exports. However when it exports the image it does not sow the image the user uploaded. I'm not sure if this is just a allowTaint kinda thing or not? I believe I have coded it right no allow taint but still doesn't seem to work.
Perhaps I need to find a script that actually uploads the file to the server and then sets it as the background image? I dunno where to find this and I am by no means a coder so I'm winging it!.
Thanks for any help.

If I understood you correctly, the images uploaded by a user, where the upload only occurs on the browser (never actually sent over to the server), it isn't showing up in the generated canvas?
If so, I wouldn't be surprised that it isn't working (as it is a use case I've ran into before), but I don't see why it couldn't be made to work as well. Until a fix is available, one option is for you to draw the image into a canvas and then put it into the DOM.


Rectangle templates should use some kind of grid snapping other than Foundry's default

When drawing a rectangular template the dimensions snap to arbitrary decimal numbers instead of the 5′ increments they should be.
Ultimately I think this is because it's snapping the diagonal distance to 5′ increments, because typing the proper diagonal distance into the template distance results in a correct-looking template. But I'm not familiar enough with the system implementation to really check.
Apologies if this is an upstream issue, but I think the snapping is implemented by the system.
Images were taken on a completely clean install of both Foundry and the system with no modules.

If you want to create a 25 ft x 5 ft rectangle you can use the following piece of math to calculate the Direction/Distance.
let a = 25;
let b = 5;

let distance = Math.hypot(Math.abs(a), Math.abs(b)).toFixed(3);
let direction = (Math.atan(Math.abs(b) / Math.abs(a)) * (180 / Math.PI)).toFixed(3);

if ( a < 0 && b > 0) {
  direction = 180 - direction;
} else if ( a < 0 && b < 0) {
  direction = 180 + direction;
} else if ( a > 0 && b < 0) {
  direction = 360 - direction;
}

console.log(distance);
console.log(direction);

After doing some digging I figured out where this change would need to be made, pretty much an exception would need to be made for rectangles and instead of using a ray you would just need to calculate how many grid units (i, j) the destination is from the origin. If this isn't resolved by someone in a week or two I might try and take a crack at it.
https://github.com/foundryvtt/pf2e/blob/d49a94e09b5a5286791f625f16ede5db558db407/src/module/canvas/layer/template.ts#L33


Route throws null reference when TabBarView is combined with CupertinoTabView

When using CupertinoTabView inside a TabBarView the framework will throw Unhandled Exception: NoSuchMethodError: The getter 'focusScopeNode' was called on null when moving between tabs in a specific way.
We're using that combination of classes to get material design tabs but with iOS-style push navigation within the tab view.
This has been reported many times but without a repro:  #45539, #42829, #56827, and on Stack Overflow.
This is caused by this line in Route: the route gets disposed before the ticker completes, so navigator is null.
Steps to Reproduce

Run the sample below
Click on tab 3 without clicking on tab 2 first
Framework throws an exception:

Unhandled Exception: NoSuchMethodError: The getter 'focusScopeNode' was called on null.
Receiver: null
Tried calling: focusScopeNode
#0      Object.noSuchMethod  (dart:core-patch/object_patch.dart:53:5)
#1      Route.didAdd.<anonymous closure>
package:flutter/…/widgets/navigator.dart:212
#2      _rootRunUnary  (dart:async/zone.dart:1192:38)
#3      _CustomZone.runUnary  (dart:async/zone.dart:1085:19)
#4      _FutureListener.handleValue  (dart:async/future_impl.dart:141:18)
#5      Future._propagateToListeners.handleValueCallback  (dart:async/future_impl.dart:682:45)
#6      Future._propagateToListeners  (dart:async/future_impl.dart:711:32)
#7      Future._completeWithValue  (dart:async/future_impl.dart:526:5)
#8      Future._asyncComplete.<anonymous closure>  (dart:async/future_impl.dart:556:7)
#9      _rootRun  (dart:async/zone.dart:1184:13)
#10     _CustomZone.run  (dart:async/zone.dart:1077:19)
#11     _CustomZone.runGuarded  (dart:async/zone.dart:979:7)

Note that this only happens when you "skip over" a tab by, in this case, going from the first to last.
Expected results:
Tab changes, but an exception is thrown in the background.
Actual results:
Tab changes without throwing an exception.
Repro
import 'package:flutter/material.dart';
import 'package:flutter/cupertino.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) => MaterialApp(home: HomePage());
}

class HomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return DefaultTabController(
      length: 3,
      child: Scaffold(
        appBar: AppBar(
          bottom: TabBar(
            tabs: <Widget>[
              Tab(text: "Tab 1"),
              Tab(text: "Tab 2"),
              Tab(text: "Tab 3"),
            ],
          ),
        ),
        body: TabBarView(
          children: <Widget>[
            CustomTabView(label: "Click tab 3 without clicking tab 2 first"),
            CustomTabView(label: "Tab 2"),
            CustomTabView(
              label:
                  "If you didn't click tab 2, you'll find an exception in your debug console",
            ),
          ],
        ),
      ),
    );
  }
}

class CustomTabView extends StatelessWidget {
  final String label;

  CustomTabView({this.label});

  @override
  Widget build(BuildContext context) {
    return CupertinoTabView(
      onGenerateRoute: (_) => CupertinoPageRoute(
        builder: (context) {
          return Center(child: Text(label));
        },
      ),
    );
  }
}

Logs

[✓] Flutter (Channel stable, v1.17.5, on Mac OS X 10.15.5 19F101, locale en-GB)
    • Flutter version 1.17.5 at /Users/tom/dev/flutter
    • Framework revision 8af6b2f038 (13 days ago), 2020-06-30 12:53:55 -0700
    • Engine revision ee76268252
    • Dart version 2.8.4

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/tom/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = /Users/tom/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.1

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.47.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.2

[✓] Connected device (1 available)
    • iPad (7th generation) • 20451586-0B77-4E8D-9635-93F9A19159B9 • ios •
      com.apple.CoreSimulator.SimRuntime.iOS-13-5 (simulator)

• No issues found!

logs
Launching lib/main.dart on SM M305F in debug mode...
✓ Built build/app/outputs/flutter-apk/app-debug.apk.
Installing build/app/outputs/flutter-apk/app.apk...
Connecting to VM Service at ws://<IP_ADDRESS>:54120/KPI1HxpO8q0=/ws
D/ViewRootImpl@958606a[MainActivity](23953): ViewPostIme pointer 0
D/ViewRootImpl@958606a[MainActivity](23953): ViewPostIme pointer 1
E/flutter (23953): [ERROR:flutter/lib/ui/ui_dart_state.cc(166)] Unhandled Exception: NoSuchMethodError: The getter 'focusScopeNode' was called on null.
E/flutter (23953): Receiver: null
E/flutter (23953): Tried calling: focusScopeNode
E/flutter (23953): #0      Object.noSuchMethod  (dart:core-patch/object_patch.dart:51:5)
E/flutter (23953): #1      Route.didAdd.<anonymous closure>
E/flutter (23953): #2      _rootRunUnary  (dart:async/zone.dart:1198:47)
E/flutter (23953): #3      _CustomZone.runUnary  (dart:async/zone.dart:1100:19)
E/flutter (23953): #4      _FutureListener.handleValue  (dart:async/future_impl.dart:143:18)
E/flutter (23953): #5      Future._propagateToListeners.handleValueCallback  (dart:async/future_impl.dart:696:45)
E/flutter (23953): #6      Future._propagateToListeners  (dart:async/future_impl.dart:725:32)
E/flutter (23953): #7      Future._completeWithValue  (dart:async/future_impl.dart:529:5)
E/flutter (23953): #8      Future._asyncCompleteWithValue.<anonymous closure>  (dart:async/future_impl.dart:567:7)
E/flutter (23953): #9      _rootRun  (dart:async/zone.dart:1190:13)
E/flutter (23953): #10     _CustomZone.run  (dart:async/zone.dart:1093:19)
E/flutter (23953): #11     _CustomZone.runGuarded  (dart:async/zone.dart:997:7)
E/flutter (23953): #12     _CustomZone.bindCallbackGuarded.<anonymous closure>  (dart:async/zone.dart:1037:23)
E/flutter (23953): #13     _microtaskLoop  (dart:async/schedule_microtask.dart:41:21)
E/flutter (23953): #14     _startMicrotaskLoop  (dart:async/schedule_microtask.dart:50:5)
E/flutter (23953):
E/flutter (23953): [ERROR:flutter/lib/ui/ui_dart_state.cc(166)] Unhandled Exception: NoSuchMethodError: The getter 'focusScopeNode' was called on null.
E/flutter (23953): Receiver: null
E/flutter (23953): Tried calling: focusScopeNode
E/flutter (23953): #0      Object.noSuchMethod  (dart:core-patch/object_patch.dart:51:5)
E/flutter (23953): #1      Route.didAdd.<anonymous closure>
E/flutter (23953): #2      _rootRunUnary  (dart:async/zone.dart:1198:47)
E/flutter (23953): #3      _CustomZone.runUnary  (dart:async/zone.dart:1100:19)
E/flutter (23953): #4      _FutureListener.handleValue  (dart:async/future_impl.dart:143:18)
E/flutter (23953): #5      Future._propagateToListeners.handleValueCallback  (dart:async/future_impl.dart:696:45)
E/flutter (23953): #6      Future._propagateToListeners  (dart:async/future_impl.dart:725:32)
E/flutter (23953): #7      Future._completeWithValue  (dart:async/future_impl.dart:529:5)
E/flutter (23953): #8      Future._asyncCompleteWithValue.<anonymous closure>  (dart:async/future_impl.dart:567:7)
E/flutter (23953): #9      _rootRun  (dart:async/zone.dart:1190:13)
E/flutter (23953): #10     _CustomZone.run  (dart:async/zone.dart:1093:19)
E/flutter (23953): #11     _CustomZone.runGuarded  (dart:async/zone.dart:997:7)
E/flutter (23953): #12     _CustomZone.bindCallbackGuarded.<anonymous closure>  (dart:async/zone.dart:1037:23)
E/flutter (23953): #13     _microtaskLoop  (dart:async/schedule_microtask.dart:41:21)
E/flutter (23953): #14     _startMicrotaskLoop  (dart:async/schedule_microtask.dart:50:5)
E/flutter (23953):
D/InputMethodManager(23953): prepareNavigationBarInfo() DecorView@d7edc5e[MainActivity]
D/InputMethodManager(23953): getNavigationBarColor() -855310
V/InputMethodManager(23953): Starting input: tba=com.example.dev_flutter ic=null mNaviBarColor -855310 mIsGetNaviBarColorSuccess true , NavVisible : true , NavTrans : false
D/InputMethodManager(23953): startInputInner - Id : 0
I/InputMethodManager(23953): startInputInner - mService.startInputOrWindowGainedFocus
D/InputTransport(23953): Input channel destroyed: 'ClientS', fd=83
D/ViewRootImpl@958606a[MainActivity](23953): stopped(true) old=false
D/SurfaceView(23953): windowStopped(true) false io.flutter.embedding.android.FlutterSurfaceView{a2f65f8 V.E...... ........ 0,0-1080,2301} of ViewRootImpl@958606a[MainActivity]
D/SurfaceView(23953): surfaceDestroyed callback.size 1 #1 io.flutter.embedding.android.FlutterSurfaceView{a2f65f8 V.E...... ........ 0,0-1080,2301}
D/SurfaceView(23953): remove() io.flutter.embedding.android.FlutterSurfaceView{a2f65f8 V.E...... ........ 0,0-1080,2301} Surface(name=SurfaceView - com.example.dev_flutter/com.example.dev_flutter.MainActivity@a2f65f8@0)/@0x624fc10
D/ViewRootImpl@958606a[MainActivity](23953): MSG_WINDOW_FOCUS_CHANGED 0 1
D/InputMethodManager(23953): prepareNavigationBarInfo() DecorView@d7edc5e[MainActivity]
D/InputMethodManager(23953): getNavigationBarColor() -855310
E/ViewRootImpl@958606a[MainActivity](23953): Surface is not valid.

flutter doctor -v
[✓] Flutter (Channel dev, 1.20.0-7.1.pre, on Mac OS X 10.15.5 19F101, locale
    en-GB)
    • Flutter version 1.20.0-7.1.pre at /Users/taha/Code/flutter_dev
    • Framework revision 7736f3bc90 (2 days ago), 2020-07-10 16:33:05 -0700
    • Engine revision d48085141c
    • Dart version 2.9.0 (build 2.9.0-21.2.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.47.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.2

[✓] Connected device (4 available)
    • SM M305F (mobile) • 32003c30dc19668f • android-arm64  • Android 10 (API
      29)
    • macOS (desktop)   • macos            • darwin-x64     • Mac OS X 10.15.5
      19F101
    • Web Server (web)  • web-server       • web-javascript • Flutter Tools
    • Chrome (web)      • chrome           • web-javascript • Google Chrome
      83.0.4103.116

• No issues found!

Thanks for narrowing this down and identifying the culprit. We'll take a look!
CC @chunhtai

Same issue here. It is fixed in the master channel?

@DennisKragekjaer the original issue is fixed and should be in stable by now, can you create a new issue if you are still seeing the problem?


Add license

Hello! First of all, thanks for making this. I just went through the exercises and they were very valuable to me! This is the best macro teaching material I've come across thus far.
I think it would be great to add a license to this project.
For example, I hang out on exercism.org quite a bit. I think this project could be added to the Rust track over there mostly as-is, under a new concept for macros. I'm wondering if the creators of these exercises are open to them being shared in such a way. Adding a license could answer such questions.

Hey! Thanks so much for the kind words :)
Definitely seems reasonable to add a license. My preference would be to keep it standard, and make it MIT/Apache2 Dual License. I'm going to try and reach out to all the contributors who've made non-trivial contributions and get their OK for doing that; then I'll change the license.
As for adding it to exercism.org -- the more people it helps, the better! My only worry would be that we end up with two seperate "MacroKata"s being maintained separately. I don't think it'd be good to move everything just to Exercism (apart from anything else, this is already being used as teaching material in one university, and it wouldn't be appropriate to ask students to sign up for a service like that IMO). If there's interest in having it on Exercism, it'd be good if we could have some mechanism of keeping them in sync.

@light4 -- sorry to tag you here, but could you get in touch if you'd be OK licensing your contribution under MIT/Apache2 Dual License?

OK

Hi @remlse
I hereby license all the work in the repo as MIT or Apache-2, at your option.
I'm going to close this issue. If you (or anyone else) is interested in copying things over to exercism; I'd be very grateful if you could setup another issue so we can discuss what sharing content between here and there might look like.

Thank you very much!

My only worry would be that we end up with two seperate "MacroKata"s being maintained separately.

That's a valid concern. I will get in touch with other maintainers at exercism about the idea to add these exercises and make sure to get in contact with you via a new issue.


Implement Auto Exposure plugin

Objective

Add auto exposure/eye adaptation to the bevy render pipeline.
Support features that users might expect from other engines:

Metering masks
Compensation curves
Smooth exposure transitions

This PR is based on an implementation I already built for a personal project before https://github.com/bevyengine/bevy/pull/8809 was submitted, so I wasn't able to adopt that PR in the proper way. I've still drawn inspiration from it, so @fintelia should be credited as well.
Solution
An auto exposure compute shader builds a 64 bin histogram of the scene's luminance, and then adjusts the exposure based on that histogram. Using a histogram allows the system to ignore outliers like shadows and specular highlights, and it allows to give more weight to certain areas based on a mask.

Changelog

Added: AutoExposure plugin that allows to adjust a camera's exposure based on it's scene's luminance.

This is really cool and you write great docs.
I had a look because I'm a bit interested in the histogram usage (#11468). Out of scope here but I'm hoping for a generalized histogram solution in the future for Bevy.

Thanks for your feedback! I've made changes accordingly and fixed the CI.
A generalized histogram would be a bit more involved as the two compute shader passes rely on each other to work correctly, so there might be a slight performance hit if you want to separate them. I guess that's something to think about for a follow up PR?

Thanks for your feedback! I've made changes accordingly and fixed the CI.
A generalized histogram would be a bit more involved as the two compute shader passes rely on each other to work correctly, so there might be a slight performance hit if you want to separate them. I guess that's something to think about for a follow up PR?

Agreed, future follow up for sure. At that point I'm hoping a visual histogram (like the graph here: https://github.com/bevyengine/bevy/pull/12561) would be relatively simple by just binding the already computed histogram and displaying it. But that's off topic here :slightly_smiling_face:

Yep, none of my concerns are blocking here! I've committed the straightforward suggestions to reduce noise.

Oh and @mweatherley, food for thought: This consumes the CubicGenerator from the math crate. First use of splines i've seen "in the wild", might be something to evaluate the curve trait PR on.

Yeah, it looks to me like this could ultimately just use any Curve<Vec2>, but I haven't looked extremely closely at it.

I'll be addressing the doc things, I have some time for it. Latest merge with main unfortunately isn't working anymore so I'll be fixing that first!

@pcwalton you optimized out the exposure value that's in the ColorGradingGlobal in #13121, but the auto exposure shader is writing it's result to there. I looked for an alternative solution, but the auto exposure pass can't use the exposure value of theExtractedCamera, as that is used to render the scene before it's histogram can be constructed.
So I just added an extra #else for when sectional color grading is not used.

Very nice docs additions, thanks! Definitely wasn't necessary but it's great to leave the codebase just a bit nicer.

Oh and @mweatherley, food for thought: This consumes the CubicGenerator from the math crate. First use of splines i've seen "in the wild", might be something to evaluate the curve trait PR on.

Yeah, it looks to me like this could ultimately just use any Curve<Vec2>, but I haven't looked extremely closely at it.

It could absolutely use a generic Curve<Vec2>, the only requirement is that the curve is monotonic on the x-axis. Could be a nice cleanup to use Curve::resample for the compensation curve texture once Curve has landed.


[Bug] - check-device.py fails with --by-host option

The --by-host knob is broken and returns a trace:
$ check-devices.py -i anta-inventory.yml -c tests-bases.yml -u xxx -p xxx --by-host --table

Traceback (most recent call last):
  File "/home/tom/.pyenv/versions/arista-avd-3.9/bin/check-devices.py", line 7, in <module>
    exec(compile(f.read(), __file__, 'exec'))
  File "/home/tom/Projects/arista/network-test-automation/scripts/check-devices.py", line 312, in <module>
    reporter.report_summary_hosts(
  File "/home/tom/Projects/arista/network-test-automation/anta/reporter/__init__.py", line 251, in report_summary_hosts
    for host_read in result_manager.get_hosts():
  File "/home/tom/Projects/arista/network-test-automation/anta/result_manager/__init__.py", line 197, in get_hosts
    if str(testcase.host) not in result_list:
AttributeError: 'TestResult' object has no attribute 'host'

This option was working in v0.3.0 and is a regression part of one of these PRs:

85dca38 (HEAD -> master, upstream/master, origin/master, origin/HEAD) Doc: Update test pattern in documentation (#126)
630bff2 feat(asyncio): update scripts (#127)
6d50ac7 feat(anta.inventory): use aioeapi to handle a device session  (#122)
5b16412 Feat: add anta_test decorator (#123)
cbc6091 feat(anta.loader)!: Add support for path to custom tests (#119)

Closed by https://github.com/arista-netdevops-community/network-test-automation/pull/129


[SPARK-8587][PySpark] KMeansModel predict return distance

Many use cases also require to know the distance to the closest
cluster. This commit adds a parameter to return the distance
by default this parameter is off to not break existing
applications.

Can one of the admins verify this patch?

@samos123 Thanks for the PR, but per comments on the JIRA, we'll need to rethink the API.  Could you please close this for now, and we can plan on JIRA?

Sure was just meant to express what kind of functionality I wanted. Closing..

NAVER - http://www.naver.com/
<EMAIL_ADDRESS>님께 보내신 메일 <Re: [spark] [SPARK-8587][PySpark] KMeansModel predict return distance (#6979)> 이 다음과 같은 이유로 전송 실패했습니다.

받는 사람이 회원님의 메일을 수신차단 하였습니다.


Fix #27; ipu_eigh doesn't work for d<6, fall back to jnp.linalg.eigh

Custom eigh breaks for d < 6, fall back to jnp.linalg.eigh.

Thanks @AlexanderMath :+1:
Let's merge, and just revert when https://github.com/graphcore-research/tessellate-ipu/issues/12 is fixed


User data dump (& import)

I would really like to see a way to export all of a user's data from NewsBlur. One case is basically backing up everything - shared posts, blurblog, feed list & intelligence settings. Another use case would be greatly simplifying the transition from hosted NewsBlur to self-hosted/private NewsBlur instances.

The API is perfect for this. www.newsblur.com/api

Any chance this can be reopened? A one button "full export" feature in the web interface for premium users would be a huge quality of life improvement. I don't want to risk losing the work spent configuring Intelligence Trainer. This feature missing is a big reason to self-host NewsBlur where backups are simple to do, instead of using the officially hosted version.

You're right, a better one-click that downloads all the major tables in json format would be great. This should integrate saved stories as well as trainer data, feeds, and probably preferences. Import would be a necessary component.


Build Error For a CPU-only build on macOS Mojave

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution: macOS Mojave 10.14.3
Mobile device: NA
TensorFlow installed from (source or binary): trying to build from source (build issue)
TensorFlow version: r1.12
Python version: Python 3.6.5 |Anaconda, Inc.| (default, Apr 26 2018, 08:42:37)
Installed using virtualenv? pip? conda?: trying to build in a conda environment
Bazel version (if compiling from source): bazel-0.15-darwin-x86_64
GCC/Compiler version (if compiling from source): LLVM version 10.0.0 (clang-1<IP_ADDRESS>)
CUDA/cuDNN version: not installed (CPU-only build)
GPU model and memory: Radeon R9 M370X 2048 (CPU-only build)

Describe the problem
It seems like toUpper is defined twice. Once as a function in STL in and once as a macro in Python headers (pyport.h). There are other similar errors for tolower, isspace and such. See the log for more details.
Steps to reproduce the problem:

Check out the r1.12 branch of Tensorflow from Github.
Create a conda environment with Python 3.6.5 and activate it.
Pip install the dependencies: pip six numpy wheel mock keras_applications keras_preprocessing as described here.
Install bazel 0.15 from here.
Navigate to the Tensorflow root folder and ./configure.
Use the default values for python and dist-packages (first two questions).
Answer No to remaining questions during configuration.
bazel build --config=opt //tensorflow/tools/pip_package:build_pip_package.
Wait ~2 hours for bazel to build ~7400 files.

You should see a similar error message (and other similar errors) to the following:
ERROR: /Users/siavash/clarius/tensorflow/tensorflow/python/eager/BUILD:10:1: C++ compilation of rule '//tensorflow/python/eager:pywrap_tfe_lib' failed (Exit 1) In file included from tensorflow/python/eager/pywrap_tfe_src.cc:18: In file included from ./tensorflow/python/eager/pywrap_tfe.h:22: In file included from ./tensorflow/core/lib/core/status.h:23: In file included from bazel-out/darwin-opt/genfiles/tensorflow/core/lib/core/error_codes.pb.h:9: In file included from external/protobuf_archive/src/google/protobuf/stubs/common.h:39: In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/iostream:38: In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/ios:216: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__locale:518:15: error: C++ requires a type specifier for all declarations     char_type toupper(char_type __c) const               ^ bazel-out/darwin-opt/genfiles/external/local_config_python/python_include/pyport.h:706:29: note: expanded from macro 'toupper' #define toupper(c) towupper(btowc(c))
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
error.log

After doing a bit of digging, it seems like this is a known bug. It might be that the conda environment that I am using does not include the fix. I will investigate further.

It seems that I missed a clean (?) step and bazel is building against my Python 3.5.2. Python 3.5.2 does not include the fix, so now I have checked out building with Python 3.5.6 that does include the fix. I will see if this addresses the issue.

Tensorflow built successfully:
Target //tensorflow/tools/pip_package:build_pip_package up-to-date:   bazel-bin/tensorflow/tools/pip_package/build_pip_package INFO: Elapsed time: 6885.252s, Critical Path: 432.77s INFO: 8608 processes: 8608 local. INFO: Build completed successfully, 9125 total actions

The tested configurations table is extremely misleading as it clearly says that Python 2.7, 3.3-3.6 are tested. However, the pyport bug is not fixed in Python 3.5.2, which is one of the supported versions in the table.
The table should be updated to reflect this.

This is probably the same issue: https://github.com/tensorflow/tensorflow/issues/23096

I am closing this as I think it only requires the configuration table to be updated.


Allow root user for config.sh

Agent Version and Platform
Agent version 2.131.0
Linux Ubuntu 4.13.0-37-generic #42~16.04.1-Ubuntu
VSTS Type and Version
VSTS -> msazure.visualstudio.com
What's not working?
Right now if you run config.sh with root permissions the script exits explicitly, failing because of this check
if [ $user_id -eq 0 ]; then
    echo "Must not run with sudo"
    exit 1
fi

I believe support for running the script under normal user permissions was added because of #277. Why was running config.sh as sudo disallowed then?
This is an issue for me as I'm trying to write a DevTest artifact to install VSTS agents on Linux machines, and the artifacts by default get launched as root. The service even runs as root, so it's strange the setup scripts must be run under a user.

@bryanmacfarlane, can you give some insight here?

I am also facing the same issue on Debian 9.4

@bryanmacfarlane I can't remember why we don't allow run the agent as root in Linux/Mac, do you remember the reason?

Pinging @bryanmacfarlane

It's a bit fuzzy but I remember it had something to do with running as root at config time would lead to all the files being owned by 0 then when configured as a service to run as an account (current logged on account) there were issues.  So there was alignment - you configure as accountX, run as a service as accountX.
But perhaps now that the split has occured in #277 it's no longer required.
@samedder - have you tried your scenario E2E with that check commented out?  Do you run as a service or interactive?

@bryanmacfarlane
I tried it E2E but it seems to fail somewhere prior to launching the agent. I have to look more into the logs, seems like node was crashing somewhere. My artifact is designed to run as a service. I think the issue was that svc.sh wasn't getting generated correctly, the script then tried launching the agent as uid 100 and crashed.

Cool.  We can take up looking at supporting it.  In the meantime, if you can send _diag logs to @TingluoHuang , we can narrow down exactly where it's failing.
Your description of config as root and then running the svc as an account (100) sounds like the issue we hit.
I'll touch base with folks soon. Is there any option to run as an account?

I would like to avoid creating a user as part of the setup process. Considering that the build agent should run as root, I'd like to be able to run everything (config + agent) as root.
I have a project I need to finish first but I'll send logs shortly.

@TingluoHuang I looked through the logs and the only thing I could find is this warning:

[2018-04-03 02:37:09Z INFO RSAFileKeyManager] Loading RSA key parameters from file /usr/share/vsts-agent-install/.credentials_rsaparams
[2018-04-03 02:37:09Z INFO Terminal] WRITE LINE: Connecting to the server.
[2018-04-03 02:37:09Z INFO MessageListener] Attempt to create session.
[2018-04-03 02:37:09Z INFO MessageListener] Connecting to the Agent Server...
[2018-04-03 02:37:09Z INFO VisualStudioServices] Starting operation Location.GetConnectionData
[2018-04-03 02:37:10Z WARN VisualStudioServices] Authentication failed with status code 401.
P3P: CP="CAO DSP COR ADMa DEV CONo TELo CUR PSA PSD TAI IVDo OUR SAMi BUS DEM NAV STA UNI COM INT PHY ONL FIN PUR LOC CNT"
WWW-Authenticate: Bearer authorization_uri=https://login.microsoftonline.com/72f988bf-86f1-41af-91ab-2d7cd011db47, Basic realm="https://tfsprodwus22.app.visualstudio.com/", TFS-Federated

I'm trying to do PAT auth to the VSTS instance, but this seems like the auth is going elsewhere.

I tried to repro this and got more logs. If I try to install the agent using ./svc.sh install everything completes without error. If I get the status, it says agent launched:

/etc/systemd/system/vsts.agent.msazure.myagent.service
● vsts.agent.msazure.myagent.service - VSTS Agent (msazure.myagent)
Loaded: loaded (/etc/systemd/system/vsts.agent.msazure.myagent.service; enabled; vendor preset: enabled)
Active: active (running) since Tue 2018-04-17 18:51:39 PDT; 3min 19s ago

It also tries to launch, but crash appears to crash immediately:

Apr 17 18:54:55 parallels-vm runsvc.sh[6203]: Starting Agent listener
Apr 17 18:54:55 parallels-vm runsvc.sh[6203]: started listener process
Apr 17 18:54:55 parallels-vm runsvc.sh[6203]: <Buffer 0a 55 6e 68 61 6e 64 6c 65 64 20 45 78 63 65 70 74 69 6f 6e 3a 20>
Apr 17 18:54:55 parallels-vm runsvc.sh[6203]: <Buffer 53 79 73 74 65 6d 2e 55 6e 61 75 74 68 6f 72 69 7a 65 64 41 63 63 65 73
Apr 17 18:54:55 parallels-vm runsvc.sh[6203]: Agent listener exited with error code null
Apr 17 18:54:55 parallels-vm runsvc.sh[6203]: Agent listener exit with undefined return code, re-launch agent in 5 seconds.

The only time I can get the agent to stay alive is if in an interactive shell I launch ./runsvc.sh directly. Then the agent appears and online available in VSTS.

@samedder <Buffer 53 79 73 74 65 6d 2e 55 6e 61 75 74 68 6f 72 69 7a 65 64 41 63 63 65 73 ->System.UnauthorizedAcces
make sure root has all permission to the agent root directory

@TingluoHuang I see, you need to explicitly pass the username into the install script, it looks like the agent runs now, but I still see the same <Buffer logs in the status output. Is this expected?

vsts.agent.msazure.myagent.service - VSTS Agent (msazure.myagent)
Loaded: loaded (/etc/systemd/system/vsts.agent.msazure.myagent.service; enabl
Active: active (running) since Wed 2018-04-18 12:51:38 PDT; 1min 29s ago
Main PID: 853 (runsvc.sh)
CGroup: /system.slice/vsts.agent.msazure.myagent.service
├─853 /bin/bash /home/parallels/Downloads/vsts_agent_install/runsvc.s
├─858 ./externals/node/bin/node ./bin/AgentService.js
└─898 /home/parallels/Downloads/vsts_agent_install/bin/Agent.Listener

Apr 18 12:51:38 parallels-vm systemd[1]: Started VSTS Agent (msazure.myagent).
Apr 18 12:51:38 parallels-vm runsvc.sh[853]: .path=/usr/local/sbin:/usr/local/bi
Apr 18 12:51:38 parallels-vm runsvc.sh[853]: Starting Agent listener
Apr 18 12:51:38 parallels-vm runsvc.sh[853]: started listener process
Apr 18 12:51:38 parallels-vm runsvc.sh[853]: started running service
Apr 18 12:51:39 parallels-vm runsvc.sh[853]: <Buffer 53 63 61 6e 6e 69 6e 67 20
Apr 18 12:51:40 parallels-vm runsvc.sh[853]: <Buffer 43 6f 6e 6e 65 63 74 69 6e
Apr 18 12:51:41 parallels-vm runsvc.sh[853]: <Buffer 32 30 31 38 2d 30 34 2d 31

@samedder that's the normal STDOUT agent produced.
5363616e6e696e6720
436f6e6e656374696e
323031382d30342d31

->
Scanning...
Connectin...
2018-04-1...

@bryanmacfarlane @TingluoHuang thanks for the help, it sounds like everything works then if we omit the requirement that config is run as non-root. Maybe we should replace that check with a warning: if config run as root, svc must be launched as root.

apparently the script still does that check

@phil123456 - yes it does.  It also isn't true that everything works.  If you config as sudo/root and then run it as a service on osx / ubuntu, then it fails to start because the files are owned by root and the service won't start.
We aren't going to remove the check but I suggested we allow an override envvar ALLOW_RUNASROOT and if you set that we let you through.  Then the folks that want to run as root and their specific scenario runs as root, can set that envvar.

I am going to close this issue as #1514 merged.

@TingluoHuang I see, you need to explicitly pass the username into the install script, it looks like the agent runs now, but I still see the same <Buffer logs in the status output. Is this expected?

vsts.agent.msazure.myagent.service - VSTS Agent (msazure.myagent)
Loaded: loaded (/etc/systemd/system/vsts.agent.msazure.myagent.service; enabl
Active: active (running) since Wed 2018-04-18 12:51:38 PDT; 1min 29s ago
Main PID: 853 (runsvc.sh)
CGroup: /system.slice/vsts.agent.msazure.myagent.service
├─853 /bin/bash /home/parallels/Downloads/vsts_agent_install/runsvc.s
├─858 ./externals/node/bin/node ./bin/AgentService.js
└─898 /home/parallels/Downloads/vsts_agent_install/bin/Agent.Listener

Apr 18 12:51:38 parallels-vm systemd[1]: Started VSTS Agent (msazure.myagent).
Apr 18 12:51:38 parallels-vm runsvc.sh[853]: .path=/usr/local/sbin:/usr/local/bi
Apr 18 12:51:38 parallels-vm runsvc.sh[853]: Starting Agent listener
Apr 18 12:51:38 parallels-vm runsvc.sh[853]: started listener process
Apr 18 12:51:38 parallels-vm runsvc.sh[853]: started running service
Apr 18 12:51:39 parallels-vm runsvc.sh[853]: <Buffer 53 63 61 6e 6e 69 6e 67 20
Apr 18 12:51:40 parallels-vm runsvc.sh[853]: <Buffer 43 6f 6e 6e 65 63 74 69 6e
Apr 18 12:51:41 parallels-vm runsvc.sh[853]: <Buffer 32 30 31 38 2d 30 34 2d 31

How to explicitly pass the username in install script

Landed here. The envvar is now RUNNER_ALLOW_RUNASROOT as in the top os config.sh.
Just export RUNNER_ALLOW_RUNASROOT=1 and ./config.sh...... should work.

@cawoodm  they have changed the script, its  AGENT_ALLOW_RUNASROOT=1 now

Ah, I have since used export AGENT_ALLOW_RUNASROOT="1" - is export AGENT_ALLOW_RUNASROOT=1 equivalent?

No. for me this variable export AGENT_ALLOW_RUNASROOT="1" only work fine when running ./run.sh export and for ./svc.sh is necessary to setup to export AGENT_ALLOW_RUNASROOT=1

this woreked


[styles] Fix jss StyleSheet attach() call

[x] I have followed (at least) the PR section of the contributing guide.

Fix #19005
In the latest jss (10.0.1), a breaking change was introduced, making the StyleSheet.update() to return undefined instead of this - https://github.com/cssinjs/jss/pull/1242/files#diff-29aac1ba5d08e188c14800bc889c5474L186.
If was described here as well - https://github.com/cssinjs/jss/issues/1249#issuecomment-569451973
I Simply separated the calls

The alternative is
dynamicSheet.attach().update(props);


In which scenario I should use Authentication link from Web App Azure Portal and in which scenario I have to use MSAL Library

Core Library
@azure/msal or msal
Core Library Version
2.0
Wrapper Library
@azure/msal-angular
Wrapper Library Version
2.0
Description
I want to Authenticate user using Azure AD. I had application registration in Azure AD and everything is set up ,I am using Authentication link from Azure Portal Web app settings section. According to Microsoft dcoumentation MSAL library is recommended when to use MSAL library and when to use Azure Portal Authentication Azure Portal => Settings=> Authentication.
MSAL Configuration
No response
Relevant Code Snippets
No response
Identity Provider
Azure AD / MSA
Source
External (Customer)

@SujeetKulkarnii the Authentication service on App Service is a simpler but less flexible alternative to MSAL. If you are using MSAL, you should just disable it, as you have no need for it. See one of the deployment guides here.

Thank you @Doğan Erişen


Additional MXNet Convolution and Deconvolution tests

Add different batch sizes and channel numbers to
MXNet Convolution and Deconvolution tests.
Thanks for contributing to TVM!   Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

@kevinthesun

Thanks!


[Piper] initial setup for interoperator

Creates broker and interoperator docker images and images push to docker hubs (both internal and opensource urls)
Run protecode and whitesource scans

Pull Request Test Coverage Report for Build 4241

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 89.341%

Files with Coverage Reduction
New Missed Lines
%

core/utils/src/RetryOperation.js
1
94.74%

Totals

Change from base Build 4219:
-0.02%

Covered Lines:
9239

Relevant Lines:
9994

💛  - Coveralls


Compilation failure with GHC 7.8

Data/Unique/Id.hs:17:8:
Could not find module ‘GHC.IOBase’
Perhaps you meant GHC.Base (from base)
Use -v to see a list of the files searched for.
Failed to install uniqueid-0.1.1

Network/Socket/ByteString.cpphs:51:8:
Could not find module ‘GHC.IOBase’
Perhaps you meant GHC.Base (from base)
Use -v to see a list of the files searched for.
Failed to install network-bytestring-<IP_ADDRESS>


Fix language and typos

This PR fixes:

language
style
punctuation
some typos

Thanks for your review, Jack! Much appreciated as usual! I'll approve your suggestions and then I'll do a pass with Vale and see where it takes us

Ready for codeowner review. The Vale review will be done in a separate PR.

CI caught three typos:
docs/sources/examples/azure.md:52:35 - Unknown word (esults)
docs/sources/references/global-queries.md:54:50 - Unknown word (datas)
docs/sources/references/global-queries.md:54:56 - Unknown word (ource)

CI caught three typos:
docs/sources/examples/azure.md:52:35 - Unknown word (esults)
docs/sources/references/global-queries.md:54:50 - Unknown word (datas)
docs/sources/references/global-queries.md:54:56 - Unknown word (ource)

all fixed! thanks!

Hi @jdbaldry! Do you plan to re-review this PR?
Also all looks good from my side, so just let me know when to merge it, or if anything else is needed from us.

Some quick notes. This is overall a good improvement. Definitely more to work on, especially the alternating of person (we/you) throughout pages.

Thank you! hoping to fix this on the next PR


Confusing paragraph in Omnipose README.md

Pretty sure the following paragraph in the Omnipose readme doesn't make sense:
Notably, while we found that Omnipose does not benefit much from more than 500 epochs, Omnipose continues to improve until around 4000 epochs. It outperforms Omnipose at 500, but is significantly better at 4000. You can use --save_every <n> and save_each to store intermediate model traineing states to explore this behavior.
seems like some of the 'Omnipose' mentions here should be 'Cellpose'.
is:
Cellpose does not benefit much from more than 500 epochs, Omnipose continues to improve until around 4000 epochs. It outperforms Cellpose at 500, but is significantly better at 4000
correct?

You are right, and there is a typo in there too! Thank you for catching that.


Error during installation with React 18

npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>|| ^17.0.0" from<EMAIL_ADDRESS>I suppose it needs react 18 in the peer dependencies.

Due to potential breaking changes, supporting React 18 will require additional testing, before adding it as peer dependency.

This will be addressed in the next release

Added experimental support for React 18 in v2.0.2
If you encounter any problems please report them as new issues.


Overwolf: PoE Overlay could not be loaded.

🐞 bug report
The Overwolf Version is broken and not able to load.
I can click "Try again" 1000+ Times but... -> See Screenshot
Screenshots

🌍  Your Environment

Version:  1.0 Overwolf Version
PoE:  Steam 3.10.2d English

:( Might be a steam compatibility issue.

Hi, thanks for creating an issue. This can occur if the GGG Api is currently not reachable. The newest version has a cached version of those requests to prevent this. If this is still an issue please attach your application logs. See following post on how to do so.
https://support.overwolf.com/support/solutions/articles/9000176827-how-to-get-your-overwolf-logs

Yes your're right, seems to be the GGG Api!
Let see of the error happens again

Same bug here. Tried restarting, reinstalling for 3 days now.
2020-06-21 10:18:39,611 (WARN) </dist/poe-overlay-overwolf/main.d988df2af755987b7523.js> (:1) - An unexpected error occured while loading PoE Overlay.
My firewall is disabled too.


Add scheduled and delivered service hours

@idreyn this could be part of the effort to move COVID Recovery Dashboard features to the Data Dashboard yes?


Open AI/Azure API integration

I want to build a realtime speech to speech conversation and ended up here. Is it possible to use this project with open ai whisper API? Or any other way to achieve real time speech to speech conversation. Any help is appreciated

hi, we tried it, but: https://github.com/ufal/whisper_streaming/issues/94

@pratikiitdh there is WhisperFusion that might be interesting for you.


add basic RPA support

This PR adds a device config to tell the Device object to automatically create a random private address at power on. Optionally, there's also a periodic task to update the RPA based on a configurable timeout.
For manual control, the update_rpa method can be called.

I am thinking whether RPA rotation should be provided by Device itself? Providing attributes to support host-side security could be great, but handling them automatically is a little bit complicated (there are many Android issues due to the same behavior). Since Bumble is not a product, letting users rotate RPA manually should be enough.

I am thinking whether RPA rotation should be provided by Device itself? Providing attributes to support host-side security could be great, but handling them automatically is a little bit complicated (there are many Android issues due to the same behavior). Since Bumble is not a product, letting users rotate RPA manually should be enough.

I agree. This is why in this PR, automatic RPA update is off by default. Users can call Device.update_rpa() if they want to. The le_privacy_enabled is only a convenient way to have the device pick an RPA at power on, which can be useful if you need an RPA with some of the example code or apps but without writing code: just set the property in a device config.


TLS handshake error: no cipher suite supported by both client and server

I'm running the latest beta of lnd on Windows 10 (v1809, build 17763.253)
C:\Users\ben
λ  lnd --bitcoin.active --bitcoin.mainnet --bitcoin.node=bitcoind --bitcoind.dir=E:\Bitcoin --bitcoind.zmqpubrawblock=tcp://<IP_ADDRESS>:28332 --bitcoind.zmqpubrawtx=tcp://<IP_ADDRESS>:28333 --bitcoind.rpcuser=<snip> --bitcoind.rpcpass=<snip>
2019-02-06 17:54:13.887 [WRN] LTND: open C:\Users\ben\AppData\Local\Lnd\lnd.conf: The system cannot find the file specified.
2019-02-06 17:54:13.894 [INF] LTND: Version: 0.5.2-beta commit=v0.5.2-beta-rc7, build=production, logging=default
2019-02-06 17:54:13.894 [INF] LTND: Active chain: Bitcoin (network=mainnet)
2019-02-06 17:54:13.925 [INF] CHDB: Checking for schema update: latest_version=7, db_version=7
2019-02-06 17:54:13.936 [INF] RPCS: password RPC server listening on <IP_ADDRESS>:10009
2019-02-06 17:54:13.936 [INF] RPCS: password gRPC proxy started at <IP_ADDRESS>:8080
2019-02-06 17:54:13.936 [INF] LTND: Waiting for wallet encryption password. Use `lncli create` to create a wallet, `lncli unlock` to unlock an existing wallet, or `lncli changepassword` to change the password of an existing wallet and unlock it.

When I try running the latest Zap to connect on port 10009, it times out and I see nothing at all on the Lnd console:

If I try connecting to port 8080, it also times out, but the Lnd console reports a TLD handshake error:

For the search index:
2019/02/07 12:00:03 http: TLS handshake error from <IP_ADDRESS>:32681: tls: no cipher suite supported by both client and server

Any ideas?  One thing that isn't clear to me is if the RPC server listening on 10009 is the gRPC endpoint Zap wants, or if the "gRPC proxy" on 8080 is.  I'm new to Lnd, so I'm not sure what the difference between these services are.

Looks like this isn't specific to Zap.  Crossposted here: https://github.com/lightningnetwork/lnd/issues/2614

Any ideas? One thing that isn't clear to me is if the RPC server listening on 10009 is the gRPC endpoint Zap wants, or if the "gRPC proxy" on 8080 is. I'm new to Lnd, so I'm not sure what the difference between these services are.

gRPC listens on port 10009.
A REST interface is exposed on port 8080 (this is just a proxy to the rpc interface)
I'm going to close this issue since it sounds like you have this resolved now based on your comments over in the other issue that you created.


feat/add cdb actions

This adds some CDB related actions before the implementation of Automatic Generate Actions.

CDBRunInstanceHour/CreateDBInstanceHour
CDBDescribeInstances/DescribeDBInstances
OpenWanService/OpenWanService
CDBIsolateInstance/IsolateDBInstance
CDBOfflineIsolatedInstances/OfflineIsolatedInstances

LGTM


Allow MongoDB connections to use TLS

Fixes #205

This change is

thank you!

@rojer Thanks for this project (and the merge). It is very helpful.


Switching scenes not working in Unity Editor

Get the "Display Startup failed. Check HMD connection." error, only in the editor, and only in the scenes that were converted from the VRSamples project (no issues switching scenes between OSVR demo scenes).
A few times I saw this error:
ObjectDisposedException: The object was used after being disposed.
System.Runtime.InteropServices.SafeHandle.DangerousAddRef (System.Boolean& success) (at /Users/builduser/buildslave/mono-runtime-and-classlibs/build/mcs/class/corlib/System.Runtime.InteropServices/SafeHandle.cs:111)
OSVR.ClientKit.DisplayConfig.CheckDisplayStartup () (at z:/jenkins-node/workspace/Managed-OSVR/ClientKit/Display.cs:241)
OSVR.Unity.DisplayController.Update () (at Assets/OSVRUnity/src/DisplayController.cs:311)

Switching scenes still an issue when direct mode is enabled.

Seems to be a race condition. It doesn't always crash when switching scenes. @russell-taylor any idea why GetRenderInfo could be causing issues during a scene switch in Unity?
Sometimes the stack trace looks like:
========== OUTPUTING STACK TRACE ==================
0x00007FF9F5FA6AC2 (osvrRenderManager) [c:\users\greg\documents\osvr\osvr-rendermanager\osvr\renderkit\rendermanager.h:383] osvr::renderkit::RenderManager::GetRenderInfo
0x00007FFA1ABF4D6D (osvrUnityRenderingPlugin) [c:\users\greg\documents\osvr\osvr-unity-rendering\osvrrenderingplugin.cpp:323] UpdateRenderInfo
0x00000001402FFE62 (Unity) GfxDevice::InsertCustomMarkerCallback
0x00000001413FDE1E (Unity) GfxDeviceWorker::RunCommand
0x000000014140198F (Unity) GfxDeviceWorker::Run
0x00000001413FA36D (Unity) GfxDeviceWorker::RunGfxDeviceWorker
0x0000000140577EF6 (Unity) Thread::RunThreadWrapper
0x00007FFA2E9113D2 (KERNEL32) BaseThreadInitThunk
========== END OF STACKTRACE ===========
and sometimes it looks like:
========== OUTPUTING STACK TRACE ==================
0x00007FFA29C3F3A4 (nvwgf2umx) NVAPI_Thunk
0x00007FFA296A6F83 (nvwgf2umx) OpenAdapter12
0x00007FFA29C3FDE0 (nvwgf2umx) NVAPI_Thunk
0x00007FFA29EAA7AE (nvwgf2umx) NVAPI_Thunk
0x00007FFA29C8312F (nvwgf2umx) NVAPI_Thunk
0x00007FFA296AB9C0 (nvwgf2umx) OpenAdapter12
0x00007FFA296B2ADD (nvwgf2umx) OpenAdapter12
0x00007FFA296B2A4B (nvwgf2umx) OpenAdapter12
0x00007FFA296B28DB (nvwgf2umx) OpenAdapter12
0x00007FFA296AB82D (nvwgf2umx) OpenAdapter12
0x00007FFA29CC034A (nvwgf2umx) NVAPI_Thunk
0x00007FFA2A05BA2F (nvwgf2umx) NVAPI_Thunk
0x00007FFA2A05BBD6 (nvwgf2umx) NVAPI_Thunk
0x00007FFA2E9113D2 (KERNEL32) BaseThreadInitThunk
========== END OF STACKTRACE ===========

Jeremy reported occasional issues with 0 eyes being reported from GetRenderInfo.  I haven't had time to look into it yet.  My guess is that we're seeing a threading issue at work.  Otherwise, I don't know how RenderManager would know that there was a scene switch going on.  Does Unity register new render buffers during a scene switch?

It releases the render buffers in the current scene and registers new ones in the new scene, but something might be going wrong there. Will go down that path more carefully.

This was fixed upstream.


az group creation and az keyvault create failed

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az keyvault create
Errors:
400 Client Error: Bad Request for url: http://localhost:50342/oauth2/token
Traceback (most recent call last):
python3.6/site-packages/knack/cli.py, ln 215, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 654, in execute
    raise ex
cli/core/commands/__init__.py, ln 718, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
...
python3.6/site-packages/msrestazure/azure_active_directory.py, ln 486, in get_msi_token
    result.raise_for_status()
python3.6/site-packages/requests/models.py, ln 940, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: http://localhost:50342/oauth2/token

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.
Enter the following values
$myResourceGroup="<>"
$myKeyVault="<>" + $(get-random -minimum 10000 -maximum 100000)
$myLocation="westus"
az group create --name $myResourceGroup --location $myLocation
Expected Behavior
KeyVault created in Azure
Environment Summary
Linux-4.15.0-1091-azure-x86_64-with-debian-stretch-sid (Cloud Shell)
Python 3.6.10
Installer: DEB

azure-cli 2.9.0 *

Additional Context

if I do this directly like so:
 az keyvault create --resource-group "testvault" --name "testVault" --location "westus"
it works fine!

@zhoxing-ms  please help check az group part.

@allschu Hi, does this problem occur in CloudShell? If so, it's a known issue #11749 of Cloudshell. You can try to run az login as a workaround.

@zhoxing-ms tried to login again, but resulted in exactly the same error

Can we close this as a dupe of https://github.com/Azure/azure-cli/issues/11749?


crypto.rand_bytes/1 deprecated in new version of erlang

When I use websocket_client with Erlang/OTP 20, I meet this:
crypto.rand_bytes/1 is undefined or private. Did you mean one of: * rand_seed/1
in:
websocket_client/src/wsc_lib.erl:227:

With google the it seems a new api crypto.strong_rand_bytes to do the same work.

Seems like this is fixed by https://github.com/jeremyong/websocket_client/commit/9a6f65d05ebf2725d62fb19262b21f1805a59fbf


Temp fix using patch-package for maplibre-inspect issue

This is a temporary fix for:

#871

The fix is using patch-package to fix the part of the code that is causing the issue, I believe.
Initial tests shows that this is fixing the issue, I hope it is not introducing other issues.
A proper fix and also using the maplibre package will be done once a repo is migrated as can be expected after the following PR is resolved:

https://github.com/maplibre/maplibre/issues/359

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.19%. Comparing base (3727f5d) to head (7ef4821).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #885   +/-   ##
=======================================
  Coverage   57.19%   57.19%
=======================================
  Files         104      104
  Lines        2939     2939
  Branches      670      670
=======================================
  Hits         1681     1681
  Misses       1258     1258

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[New game]: Pac Go

🎮 Game Request
Game logic and basic description

Point down the features
Game points
The four enemies that try to catch Pac-Man. Each ghost has its own unique behavior
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Aditijainnn , You can't have another issue before completing the previous one 😀
you already have the following 1 open issues 👀 ! :
#4436

Hey @Aditijainnn ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

Hey @Aditijainnn !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹


INT  - TEMP LOGGING  - B 21478 rate area name id prime api

B-21478
Original INT PR
This PR adds logging to trace through code in attempt to resolve issue in loadTesting. RateArea is not present in loadTesting and we don't know why.  The logging will be removed before it is merged into MAIN.

Are you not able to log into loadtest db and investigate?

He did but didn't see anything in the db that was out of the ordinary and causing the issue.

Are you not able to log into loadtest db and investigate?
I've queried the data in loadTesting and everything checks out. I'm kind of stumped at the moment.

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against 89825bd223f11cd0f92f6944eb51c12937f2e9bf

Also there is a get_rate_area_id function I created in loadtest you can try out. It takes in consideration CONUS & OCONUS moves.
CREATE OR REPLACE FUNCTION get_rate_area_id(
    address_id UUID,
    service_item_id UUID,
    OUT o_rate_area_id UUID
)
RETURNS UUID AS $$
DECLARE
    is_oconus BOOLEAN;
    zip3_value TEXT;
BEGIN
    is_oconus := get_is_oconus(address_id);

    IF is_oconus THEN
        -- re_oconus_rate_areas if is_oconus is TRUE
        SELECT ro.rate_area_id
        INTO o_rate_area_id
        FROM addresses a
        JOIN re_oconus_rate_areas ro
        ON a.us_post_region_cities_id = ro.us_post_region_cities_id
        WHERE a.id = address_id;
    ELSE
        -- re_zip3s if is_oconus is FALSE
        SELECT rupr.zip3
        INTO zip3_value
        FROM addresses a
        JOIN us_post_region_cities uprc
        ON a.us_post_region_cities_id = uprc.id
        JOIN re_us_post_regions rupr
        ON uprc.us_post_regions_id = rupr.id
        WHERE a.id = address_id;

        -- use the zip3 value to find the rate_area_id in re_zip3s
        SELECT rz.rate_area_id
        INTO o_rate_area_id
        FROM re_zip3s rz
        WHERE rz.zip3 = zip3_value;
    END IF;

    -- Raise an exception if no rate area is found
    IF o_rate_area_id IS NULL THEN
        RAISE EXCEPTION 'Rate area not found for address % for service item ID %', address_id, service_item_id;
    END IF;
END;
$$ LANGUAGE plpgsql;

g2g long as we plan to remove the query from the logs after trouble shooting
also - couldn't this be determined with some db queries instead of app logging?

This will be removed when issue is resolved.  Everything works locally. Yes -- I've already queried the loadTesting db. I've executed the queries using loadTesting data and everything checks out. At this time, I don't know what it can be. This logging will confirm if it is going into  the expected Prime V3 API.  It merely wil log the actual sql the service layer is running.

Let tag up in the morning and get in the DB to poke around

I'm going to block this for now because I think there are additional actions and resources that can be used to troubleshoot instead of adding in logging.
I see you're depending on v_locations, but if you check out the function I made, there's different queries for CONUS & OCONUS.

How do you resolve the fact the issue is not present when running INT locally, regardless of present implementation?

I'm going to block this for now because I think there are additional actions and resources that can be used to troubleshoot instead of adding in logging.
I see you're depending on v_locations, but if you check out the function I made, there's different queries for CONUS & OCONUS.

BTW, this was written PRIOR to the new function.

Beth Grohmann db fix resolved loadTesting issue we were seeing. Temp debugging logging is no longer needed.


Add non-Cmd key keybindings.

Cmd key does not work for Windows (perhaps not Linux either?). Might be a good idea to use non-cmd key bindings for these platforms. No idea what shortcuts to use, I'm trying out the ones below right now:
'.platform-win32 atom-workspace':
  'ctrl-alt-k': 'supercollider:clear-post-window'
".platform-win32 atom-workspace atom-text-editor[data-grammar~='supercollider']":
  'ctrl-alt-l': 'supercollider:open-post-window'
  'shift-enter': 'supercollider:eval'
  'alt-.': 'supercollider:cmd-period'
  'ctrl-alt-k': 'supercollider:clear-post-window'
  'ctrl-shift-h': 'supercollider:open-help-file'

Very useful thanks. I'll get the ones for Linux too.


Add support for chat-protocol

@dantelmomsft can you please assign this to John?

@brunoborges  we are going to close this once we have integrated the streaming PR #38

PR #38 merged. do we agree to close this?

Let's get this up and running on the live demo before we close?

@dantelmomsft @johnoliver is the chat protocol up and running ?


Integrate the design by contract plugin

This was contributed but not yet integrated.

@jwgrenning For TERMINATE_TEST, I guess C++ exception is the way to go?

Can you show us a test using this?
On 7 Apr 2018, at 1:23, PengZheng wrote:

@jwgrenning
It works, though not quite straightforward:

define custom assert macro using customizable assertion handler:

#define ASSERT(cond, condstring) \
  BEGIN \
    if (LIKELY(cond)) NOOP; else \
      assert_fail(__FILE__, __LINE__, (condstring)); \
  END

typedef void (*assert_fail_t)(const char *, unsigned, const char *);

static assert_fail_t assert_handler = assert_fail_default;

void assert_fail(const char *file,
                         unsigned line,
                         const char *condition)
{
	assert_handler(file, line, condition);
}

assert_fail_t assert_fail_install(assert_fail_t handler)
{
	assert_fail_t old_handler = assert_handler;
	assert_handler = handler;
	return old_handler;
}

install customized handler in setup method:

static void assert_fail_mock(const char *file, unsigned line, const
char *condition)
{
	mock().actualCall("assert_fail_mock").withStringParameter("condition",
condition);
	TEST_EXIT;
}

	void setup(void)
	{
		old_handler = assert_fail_install(assert_fail_mock);
	}

I think some additional example (in the doc and the book) will be
helpful.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/cpputest/cpputest/issues/24#issuecomment-379433518

void assert_fail_mock(const char *file,
                      unsigned line,
                      const char *condition)
{
	mock().actualCall("assert_fail_mock").
			withStringParameter("condition", condition);
	TEST_EXIT;
}

void expectAssert(const char *condition)
{
	mock().expectOneCall("assert_fail_mock") .
			withStringParameter("condition", condition);
}

TEST_GROUP(Obj)
{
	ObjectStruct obj;
	eda_assert_fail_t old_handler;
	void setup(void)
	{
		mock().strictOrder();
		old_handler = assert_fail_install(eda_assert_fail_mock);
	}
	void teardown(void)
	{
		assert_fail_install(old_handler);
	}
};

TEST(Obj, CheckNull)
{
	expectAssert("inst != NULL");
	ObjectInit(NULL);
}

void ObjectInit(Object inst)
{
	ASSERT(inst != NULL);
        // more to do
}


Make NtfsFileAttributes a nullable flags enum

Fixes #8082

Removed None as the enum is nullable, and null will default to None.

Have you run the related unit tests in live mode?

Have you run the related unit tests in live mode?

Yes, I ran in live mode.


fix: race creating duplicates in ConnectedObjects reverseExpandDirect

Description
This fixes a race condition that leads to duplicates occasionally being returned. We had a similar issue we fixed in #475, but we missed this code path as well.
References

Review Checklist

[ ] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[ ] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

Codecov Report
Base: 81.92% // Head: 81.91% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (dfc1341) compared to base (be583c1).
Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
- Coverage   81.92%   81.91%   -0.01%
==========================================
  Files          87       87
  Lines       14385    14378       -7
==========================================
- Hits        11785    11778       -7
  Misses       2188     2188
  Partials      412      412

Impacted Files
Coverage Δ

pkg/server/commands/connected_objects.go
88.31% <100.00%> (-0.21%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


CAMEL-9180 - camel-cmis Lazy Initialize Session Facade

It should not be there at all, I will remove it

Fixed

merged right ?

yes


fix: await the save download event call

Description

The call to save the download event was not being awaited

:tada: This PR is included in version 1.13.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Captcha not displaying correctly

Captcha displays as a font error in one particular instance for an unknown reason.

try changing the font


Apple pay fixes

Description
Numerous fixes to ApplePay. Mostly concerning Tax and Shipping Tax based on shipping address.
ApplePay displays Grand Total, Shipping and Subtotal. Values are essentially Grand Total, Shipping and Grand Total - Shipping (Subtotal).
Also using shipping carrier's Method Title (customer configured) rather than Config Title.
Apple Pay only return 1st part of postcode - dummy 2nd part added to allow postcode matching.
Added adyen_apple_pay_shipping_rate_init event
Added config option to "Require customer to select a valid shipping method to complete order." without it customers can checkout without a valid shipping method.
On Authorisation - don't update HOLDED orders to processing.
Tested scenarios
Tested on client site with bespoke design & using Magento's base modern theme.
Fixed issue:  n/a

Hi @enru,
Thanks for the PR! We will have a look at it and test this locally. One note I see that countryCode you are using the country of the shopper shipping address but looking into Apple specs this needs to be the country code of the merchant: https://developer.apple.com/documentation/apple_pay_on_the_web/applepaypaymentrequest/1916117-countrycode . Could you revert that part of the code ? Not sure how you can retrieve this dynamically from Magento settings.
Regards,
Rik
Adyen

OK can do. Yeah there is no Magento config for merchant country - only a textarea field for full address . Would it be worth me adding a config variable into the Apple Pay config in Magento admin?
<EMAIL_ADDRESS>www.enru.co.uk
@enru

On 18 Jul 2018, at 07:52, Rik ter Beek<EMAIL_ADDRESS>wrote:
Hi @enru,
Thanks for the PR! We will have a look at it and test this locally. One note I see that countryCode you are using the country of the shopper shipping address but looking into Apple specs this needs to be the country code of the merchant: https://developer.apple.com/documentation/apple_pay_on_the_web/applepaypaymentrequest/1916117-countrycode . Could you revert that part of the code ? Not sure how you can retrieve this dynamically from Magento settings.
Regards,
Rik
Adyen
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I've updated this as requested & fixed a new issue where the email address for guest checkouts wasn't being saved to the order in Magento.


Update EVM diagram and execution context section

What changed? Why?

Replace EVM diagram
Update article section
Add data bytecode explanation and example

Notes to reviewers
How has it been tested?
Tested locally

Review Error for briandoyle81CB @ 2023-11-13 22:01:13 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help


Renew ICM production certificates

[x] Request certificates from ICM
[ ] Update SAML Metadata
[ ] Update GCCF workbook
[ ] Send metadata and workbook to SSC
[ ] Schedule outage and teams call for metadata refresh
[ ] Notify clients of production outage
[ ] Add new certificates to passport config ("new_...") to prepare for rotation
[ ] Hold teams call with SSC, SecureKey, 2Keys: Rotate certificates
[ ] Send request to IMTD to update certificates in Key Vault
[ ] Verify Certificates correctly update in Key Vault

From: Conceicao, Nelson
Sent: February 7, 2023 9:39 AM
To: Kenny, Melissa<EMAIL_ADDRESS>Cc: Radi, Mustapha<EMAIL_ADDRESS>Moussa, Wissam<EMAIL_ADDRESS>Harris, Doug<EMAIL_ADDRESS>Subject: RE: Cert - Error
Hi Melissa,
I hope you had a great weekend, any updates on this request?
Thank You
From: Conceicao, Nelson

See Azure DevOps board for history.  Ticket 9940 on Sprint board currently in "closed" column.

From: Conceicao, Nelson
Sent: February 10, 2023 9:04 AM
To: Kenny, Melissa<EMAIL_ADDRESS>Cc: Radi, Mustapha<EMAIL_ADDRESS>Moussa, Wissam<EMAIL_ADDRESS>Harris, Doug<EMAIL_ADDRESS>Subject: RE: Cert - Error
Hi Melissa,
Any updates from SSC?
From: Conceicao, Nelson
Sent: February 7, 2023 9:39 AM
To: Kenny, Melissa<EMAIL_ADDRESS>Cc: Radi, Mustapha<EMAIL_ADDRESS>Moussa, Wissam<EMAIL_ADDRESS>Harris, Doug<EMAIL_ADDRESS>Subject: RE: Cert - Error
Hi Melissa,
I hope you had a great weekend, any updates on this request?
Thank You
From: Conceicao, Nelson
Sent: January 31, 2023 9:18 AM
To: Kenny, Melissa<EMAIL_ADDRESS>Subject: Cert - Error
Hi Melissa,
Are you able to send over a request for them to re-sign the certs?
SME: ICM KMC must not have used the correct certificate profile, we provided that in the form.
Thank You
Nelson Conceicao
Senior Analyst, Digital Identity, Office of the Chief Information Officer
Treasury Board of Canada Secretariat / Government of Canada
<EMAIL_ADDRESS>/ Tel:<PHONE_NUMBER>

Note: Melissa is on Vacation :(

From: Kenny, Melissa<EMAIL_ADDRESS>Sent: February 14, 2023 12:08 PM
To: ICM KMC / GJI CGC (SSC/SPC<EMAIL_ADDRESS>Cc: Conceicao, Nelson<EMAIL_ADDRESS>Subject: FW: Cert - Error
Importance: High
Hi ICM KMC Team,
Please be advised that Nelson has been having issue with is 2 certificates.
I Attach again both forms Completed and Signed, we received both code on 24-01-2023, but Sadly Nelson and his team has been having error message:
This isn’t a regular personal Mykey, but a Certificate for an App.
Please let us know if you need more information.
Thanks
Melissa
A/Team Leader, Infrastructure/Operations
Treasury Board of Canada Secretariat / Government of Canada
<EMAIL_ADDRESS> / Tel:<PHONE_NUMBER>
I/Chef d’équipe, Infrastructure/Opérations
Secrétariat du Conseil du Trésor du Canada / Gouvernement du Canada
<EMAIL_ADDRESS> / Tél. :<PHONE_NUMBER>

Currently with Nelson, hopefully we revive this when he is back from leave (March 2).

New information provided to TBS (LRA) she has updated SSC, waiting for information from SSC.

The issue in now fixed. SSC implemented some changes (changed the role to Reflect End User) to make device certificates exportable.

Ticket has also been moved to Done status.

Getting the certificates is just the first step.

Sorry Doug, I thought this ticket is dedicated to the certificates issue we were encountering. My bad.

Created a task list with the remaining activities

looking at the checklist that some serious manual coordination and human intervention (i.e. error prone). how frequent do we need to that @harrdou ?

Waiting for SSC

Certificates have been received.
Next steps:
Schedule a change (4 teams) call with Doug, SSC, 2Keys and SecureKey in implement the cert

SSC has agreed to April 18, 2023 at 7am to rotate our production SAML certificates. Waiting confirmation from Doug.

The new certificates are now standing by on the production server, ready for manual deployment in sync with both ECM vendors.  They have also been sent to IMTD to be imported into the production Key Vault, from where they will be retrieved on the next reboot.

New certificates are up and running in SIC, GCKey and CBS.
Now just waiting for IMTD to update the production key vault.

Key Vault has been updated and verified.
All done!


Handle arbitrary layers from a client geojson datasource

Currently tangram-es core architecture requires datasource to contain features in appropriate uber layers, which are then be styled/filtered upon. However it is totally fine for a geojson to provide a feature collection with no uber layer defined (eg: https://transit.land/api/v1/operators.geojson).
Tangram-es should provide a way for these feature sets to be filtered/styled and drawn.

Almost all GeoJSON sources will be a standard FeatureCollection. The presence of a JSON wrapper splitting these into "layers" is just an arbitrary format that Tangram implemented. In Tangram JS we're supporting both -- a single GeoJSON object, or a set of layers provided as GeoJSON objects -- for both tiled and non-tiled GeoJSON (it was initially implemented for tiled GeoJSON since that's how our tiles were formatted, and then carried over to non-tiled GeoJSON because the code is shared).

For styling/filtering purposes, single-layer data sources simply omit the layer property in the data block, e.g.:
data: { source: geojson } is used to reference the data


Move JSON to SQLite creation to background process

Currently, the JSON to SQLite creation is in the renderer process. It should be moved to a background process.

This bug is obsolete. Sequelize uses an asynchronous API already, so there is not much benefit to moving this code to a separate process.


Move bucketing from hpu_model_runner

One of the biggest change here is lack of vllm logger, I need to use regular python prints instead.


add DWCAS

for reference:
https://github.com/boostorg/atomic/blob/5bbcce0f6e855dc4009e2e6977c62e0520c39573/include/boost/atomic/detail/core_arch_ops_gcc_aarch64.hpp#L1715

also fetch_min and fetch_max atomic operations would be useful

for reference:
https://github.com/boostorg/atomic/blob/5bbcce0f6e855dc4009e2e6977c62e0520c39573/include/boost/atomic/detail/core_arch_ops_gcc_aarch64.hpp#L1715

done


[Core] remove cupy dependency

Separate code from https://github.com/vllm-project/vllm/pull/3442 , only remove cupy dependency.

Support evidence from https://github.com/vllm-project/vllm/issues/3617 : this PR solved cupy initialization issue 👍

Can we get confirmation from AMD people that we can do the same thing to replace PyTorch RCCL? While I believe we don't have to do this in the current PR, I'd like to get confirmation and find someone who takes that.

@WoosukKwon @simon-mo thanks for the review! I talked to amd folks to ask for review. Let's see if we can get feedback today. If not, we can merge first, and let them send fix PRs later.

Overall I think we should take a small step for every release. Distributed related bugs like hang/deadlock are highly unstable and difficult to test.
My plan is to use pynccl as an equivalent replacement of cupy in v0.4.0 , and collect user feedback to decide the next move for v0.4.1 (e.g. removing tricky code wrote for cupy).
cc @WoosukKwon

Hello everyone,
I was able to get this resolved myself as well without removing cuppy as a dependency. What I had to do was Instead of using the VLLM or Nvidia base containers, I used the official Cupy(which includes the dependencies for the Nvidia drivers) image as my new base image and followed the Linux install instructions inside the container and committed it to a new image.


create client library for reporting application events

Client library is located in the AppMetrics.Client project. Usage sample:
private static readonly AppMetrics.Client.Tracker AppMetricsTracker =
new AppMetrics.Client.Tracker("http://<IP_ADDRESS>/AppMetrics/LogEvent.ashx", "CIAPI.CS.Excel");
// .......
AppMetricsTracker.Log("Event", "Test");


thebookisclosed.Vive: new package

Closes: https://github.com/microsoft/winget-pkgs/issues/194782
Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @,
Do you approve of these changes?
(Automated response - build 900.)

Verify:


Name mangler of minifier should understand block scoping

While working on https://github.com/swc-project/swc/pull/5763, I found that terser reuses variable names in more cases compared to swc.
Input
function test(foo, bar) {
    try {
        const bar = {};
        throw "PASS";
    } catch (error) {
        return bar(error);
    }
}
console.log(test(null, (x) => x));

Current

function n(n, o) {
    try {
        const t = {};
        throw "PASS";
    } catch (c) {
        return o(c);
    }
}
console.log(n(null, (n)=>n));

terser output

function n(n, o) {
    try {
        const n = {};
        throw "PASS";
    } catch (n) {
        return o(n);
    }
}
console.log(n(null, (n) => n));

@kdy1 Are there any traps to implement this? Or just improving the analysis here would be good enough?

There's no trap and improving the analyzer is the all of the required work


Can't update token details. It always fail with automerge-error.  Help needed!

I'm submitting a ...
[ ] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[x] question about how to use this project

Summary
I am trying to update my token details on the list.

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)
I am having error with found removed line: - "chainId": 101, which I accidentally put before 103. I also updated some other info.
My PR is #11647

Thank you in advance.

merged


(chore) clean dependencies

remove all dependencies from the go.mod file which are not required

LGTM


KAFKA-9564: Local Tiered Storage implementation for Remote Storage Manager

Tiered Storage implementation for Remote Storage Manager using the local file system. This will be used for system integration tests as well in the followup PRs.
Primary Contributor: Alexandre Dupriez<EMAIL_ADDRESS>Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@satishd
Can you please take a look when you get chance?

Did a first round. Will continue in upcoming days.
It would be very useful if this PR can add at least one test utilizing this setup.

Thanks, @divijvaidya and @showuon for reviewing the PR! Addressed your review comments. PTAL. I'll open a separate PR to add the TieredStorageTestHarness classes to effectively write an integration test.

@showuon @divijvaidya
Addressed your review comments. Please take another look. Thanks!

@kamalcph Please don't wait for my review on this. I think multiple folks are already on top of this.

Thanks for the update. Will have a 2nd round of review in the following days.

@jeqo @showuon @satishd
Addressed your review comments. PTAL. We can work on appending the offset as prefix to the remote log file-set in the next framework PR. Thanks!

We can work on appending the offset as prefix to the remote log file-set in the next framework PR. Thanks!
@kamalcph Sure, this can be done in other PR. Please file a JIRA if you have not yet so that we will not miss it.

We can work on appending the offset as prefix to the remote log file-set in the next framework PR. Thanks!
@kamalcph Sure, this can be done in other PR. Please file a JIRA if you have not yet so that we will not miss it.

Filed https://issues.apache.org/jira/browse/KAFKA-15194 to track this separately.

A few tests failed in jenkins jobs which are not related to the change, merging to trunk.

Sorry for missing to add the PR description in the commit message.
Tiered Storage implementation for Remote Storage Manager using the local file system. This will be used for system integration tests as well in the followup PRs.

Primary Contributors: Alexandre Dupriez<EMAIL_ADDRESS>Kamal Chandraprakash<[kamal.chandraprakash@gmail.com](mailto:kamal.chandraprakash@gmail.com)>

Hey @satishd
In case you didn't know, you can add co-authors in the commit by adding a line at the end of commit such as:
---------

Co-authored-by: Person2<EMAIL_ADDRESS>
GitHub automatically recognizes it and attributes the commit to both, e.g. check this commit https://github.com/apache/kafka/commit/6afcfba9f3949cc8e8eecac42dabb099ba9cc0a9


Invalid KConfig arguments causes spurious errors for certain boardfiles

Describe the bug
For some (but not all) boardfiles, introducing an erroneous KConfig argument causes bad warnings to be printed.
For instance, let's start with an example of normal behavior:

Navigate to zephyr/samples/net/sockets/echo.
execute west build -p -b cc3235sf_launchxl -- -DCONFIG_NET_CONFIG_LOG_LEVEL=y -DCONFIG_NET_SOCKETS_LOG_LEVEL_DBG=y

As expected, this will produce the following KConfig warning output:

warning: the value 'y' is invalid for NET_CONFIG_LOG_LEVEL (defined at subsys/net/Kconfig.template.log_config.net:48), which has type int -- assignment ignored

However, if we instead use the nrf9160dk_nrf9160_ns board: west build -p -b nrf9160dk_nrf9160_ns -- -DCONFIG_NET_CONFIG_LOG_LEVEL=y -DCONFIG_NET_SOCKETS_LOG_LEVEL_DBG=y
We get the following incorrect warning in addition to the one seen before:

warning: The choice symbol NET_SOCKETS_LOG_LEVEL_DBG (defined at
subsys/net/Kconfig.template.log_config.net:36) was selected (set =y), but no symbol ended up as the
choice selection. See
http://docs.zephyrproject.org/latest/kconfig.html#CONFIG_NET_SOCKETS_LOG_LEVEL_DBG and/or look up
NET_SOCKETS_LOG_LEVEL_DBG in the menuconfig/guiconfig interface. The Application Development Primer,
Setting Configuration Values, and Kconfig - Tips and Best Practices sections of the manual might be
helpful too.

This warning is completely incorrect, NET_SOCKETS_LOG_LEVEL_DBG should be able to be set with no issues.
Strangely, once this warning occurs, it will persist on subsequent builds so that even:
west build -p -b nrf9160dk_nrf9160_ns -- -DCONFIG_NET_SOCKETS_LOG_LEVEL_DBG=y
triggers the warning, although the build will otherwise succeed.
Seemingly, the only way to clear the warning is to abort the above build just after it prints the warning, then run it again.
So far, the only two boards in Zephyr that I have tried are nrf9160dk_nrf9160_ns and cc3235sf_launchxl, but this also affects the out-of-tree board thingy91_nrf9160_ns board.
It isn't clear to me whether this is specific to the nrf9160, or if it might be a broader issue, but I've been encouraged to raise a ticket here so that the right people can take a look.
It's worth noting that this seems to apply to all log-level settings, not just NET_SOCKETS_LOG_LEVEL and NET_CONFIG_LOG_LEVEL. Those two are merely the first two I could find that apply to the echo sample.
Impact
This is an annoyance; It causes confusion if one mistakenly forgets to append _DBG to a log output level. Once you are aware of the problem, it is easy enough to circumvent it by just restarting builds and avoiding incorrect KConfig arguments. Still, it signals that there may be some kind of bug in the KConfig processor.
Environment:

OS: Windows
Toolchain: zephyr-sdk-0.15.0
Commit SHA or Version used: 483126f492eaefd1bbd9daf7543a5dfd6a429795

@jackrosenthal Pinging you since you are now maintaining KConfig

However, if we instead use the nrf9160dk_nrf9160_ns board: west build -p -b nrf9160dk_nrf9160_ns -- -DCONFIG_NET_CONFIG_LOG_LEVEL=y -DCONFIG_NET_SOCKETS_LOG_LEVEL_DBG=y

This is incorrect, you cannot select a choice, CONFIG_NET_CONFIG_LOG_LEVEL needs to be dropped

The reason you get the warning is you are trying to select a symbol without enabling its dependencies which is not valid, this includes the dependencies and works: west build -p -b nrf9160dk_nrf9160_ns -- -DCONFIG_LOG=y -DCONFIG_NET_LOG=y -DCONFIG_NET_SOCKETS_LOG_LEVEL_DBG=y
Closing, not a bug.

@nordicjm

This is incorrect, you cannot select a choice, CONFIG_NET_CONFIG_LOG_LEVEL needs to be dropped

Yes, that I am aware of, but the issue I am pointing out is that this (seems to) cause an additional unrelated warning to be printed beyond the expected warning: the value 'y' is invalid for NET_CONFIG_LOG_LEVEL

The reason you get the warning is you are trying to select a symbol without enabling its dependencies which is not valid, this includes the dependencies and works west build -p -b nrf9160dk_nrf9160_ns -- -DCONFIG_LOG=y -DCONFIG_NET_LOG=y -DCONFIG_NET_SOCKETS_LOG_LEVEL_DBG=y

What about the fact that I have had west build -p -b nrf9160dk_nrf9160_ns -- -DCONFIG_NET_SOCKETS_LOG_LEVEL_DBG=y succeed with no warnings? If -DCONFIG_LOG=y -DCONFIG_NET_LOG=y is a necessity, then is this build succeeding a bug?
It feels very strange to me that repeating the same build twice will yield different results.

@nordicjm
west build -p -b nrf9160dk_nrf9160_ns -- -DCONFIG_NET_SOCKETS_LOG_LEVEL_DBG=y does not contain any invalid arguments.
It either should either always fail, or should always succeed (depending on whether -DCONFIG_LOG=y -DCONFIG_NET_LOG=y is required)  and I have seen both behaviors for that exact command, simply by performing it repeatedly.
If you really think that is alright, then I'll drop it, but I feel that I am failing to communicate clearly what has me concerned so I am restating it one last time

In your first message, you specifically say you use -DCONFIG_NET_CONFIG_LOG_LEVEL=y which is invalid. I've just ran west build -p -b nrf9160dk_nrf9160_ns -- -DCONFIG_NET_SOCKETS_LOG_LEVEL_DBG=y 9 times and each time the warning was emitted.

In your first message, you specifically say you use -DCONFIG_NET_CONFIG_LOG_LEVEL=y which is invalid.

@nordicjm I was apparently confused in my first message, I thought the warning was not expected for west build -p -b nrf9160dk_nrf9160_ns -- -DCONFIG_NET_SOCKETS_LOG_LEVEL_DBG=y, especially since it doesn't print (ever) for west build -p -b cc3235sf_launchxl -- -DCONFIG_NET_SOCKETS_LOG_LEVEL_DBG=y. I was always aware that -DCONFIG_NET_CONFIG_LOG_LEVEL=y  is invalid, but from my confused perspective it appeared to be affecting other commands.
But you corrected me on that, so that confusion is gone. I think we can drop the issue of -DCONFIG_NET_CONFIG_LOG_LEVEL=y for the time being.
But there does remain the fact that I can get inconsistent behavior with nrf9160dk_nrf9160_ns. See the following terminal output:
PS C:\ncs\zephyr_kconfig_bug\zephyr\samples\net\sockets\echo> west build -p -b nrf9160dk_nrf9160_ns -- -DCONFIG_NET_SOCKETS_LOG_LEVEL_DBG=y
-- west build: making build dir C:\ncs\zephyr_kconfig_bug\zephyr\samples\net\sockets\echo\build pristine
-- west build: generating a build system
Loading Zephyr default modules (Zephyr base).
-- Application: C:/ncs/zephyr_kconfig_bug/zephyr/samples/net/sockets/echo
-- CMake version: 3.22.1
-- Found Python3: C:/Python39/python.exe (found suitable exact version "3.9.5") found components: Interpreter
-- Cache files will be written to: C:/ncs/zephyr_kconfig_bug/zephyr/.cache
-- Zephyr version: 3.3.99 (C:/ncs/zephyr_kconfig_bug/zephyr)
-- Found west (found suitable version "0.14.0", minimum required is "0.7.1")
-- Board: nrf9160dk_nrf9160_ns, Revision: 0.7.0
-- Found host-tools: zephyr 0.15.0 (C:/Users/Georges/zephyr-sdk-0.15.0)
-- Found toolchain: zephyr 0.15.0 (C:/Users/Georges/zephyr-sdk-0.15.0)
-- Found Dtc: C:/ProgramData/chocolatey/bin/dtc.exe (found suitable version "1.5.0", minimum required is "1.4.6")
-- Found BOARD.dts: C:/ncs/zephyr_kconfig_bug/zephyr/boards/arm/nrf9160dk_nrf9160/nrf9160dk_nrf9160_ns.dts
-- Generated zephyr.dts: C:/ncs/zephyr_kconfig_bug/zephyr/samples/net/sockets/echo/build/zephyr/zephyr.dts
-- Generated devicetree_generated.h: C:/ncs/zephyr_kconfig_bug/zephyr/samples/net/sockets/echo/build/zephyr/include/generated/devicetree_generated.h
-- Including generated dts.cmake file: C:/ncs/zephyr_kconfig_bug/zephyr/samples/net/sockets/echo/build/zephyr/dts.cmake

warning: The choice symbol NET_SOCKETS_LOG_LEVEL_DBG (defined at
subsys/net/Kconfig.template.log_config.net:36) was selected (set =y), but no symbol ended up as the
choice selection. See
http://docs.zephyrproject.org/latest/kconfig.html#CONFIG_NET_SOCKETS_LOG_LEVEL_DBG and/or look up
NET_SOCKETS_LOG_LEVEL_DBG in the menuconfig/guiconfig interface. The Application Development Primer,
Setting Configuration Values, and Kconfig - Tips and Best Practices sections of the manual might be
helpful too.

Parsing C:/ncs/zephyr_kconfig_bug/zephyr/Kconfig
Loaded configuration 'C:/ncs/zephyr_kconfig_bug/zephyr/boards/arm/nrf9160dk_nrf9160/nrf9160dk_nrf9160_ns_defconfig'
Merged configuration 'C:/ncs/zephyr_kconfig_bug/zephyr/samples/net/sockets/echo/prj.conf'
Merged configuration 'C:/ncs/zephyr_kconfig_bug/zephyr/samples/net/sockets/echo/build/zephyr/misc/generated/extra_kconfig_options.conf'
Configuration saved to 'C:/ncs/zephyr_kconfig_bug/zephyr/samples/net/sockets/echo/build/zephyr/.config'
Kconfig header saved to 'C:/ncs/zephyr_kconfig_bug/zephyr/samples/net/sockets/echo/build/zephyr/include/generated/autoconf.h'
PS C:\ncs\zephyr_kconfig_bug\zephyr\samples\net\sockets\echo> ^C
PS C:\ncs\zephyr_kconfig_bug\zephyr\samples\net\sockets\echo> west build -p -b nrf9160dk_nrf9160_ns -- -DCONFIG_NET_SOCKETS_LOG_LEVEL_DBG=y
-- west build: generating a build system
Loading Zephyr default modules (Zephyr base).
-- Application: C:/ncs/zephyr_kconfig_bug/zephyr/samples/net/sockets/echo
-- CMake version: 3.22.1
-- Found Python3: C:/Python39/python.exe (found suitable exact version "3.9.5") found components: Interpreter
-- Cache files will be written to: C:/ncs/zephyr_kconfig_bug/zephyr/.cache
-- Zephyr version: 3.3.99 (C:/ncs/zephyr_kconfig_bug/zephyr)
-- Found west (found suitable version "0.14.0", minimum required is "0.7.1")
-- Board: nrf9160dk_nrf9160_ns, Revision: 0.7.0
-- Found host-tools: zephyr 0.15.0 (C:/Users/Georges/zephyr-sdk-0.15.0)
-- Found toolchain: zephyr 0.15.0 (C:/Users/Georges/zephyr-sdk-0.15.0)
-- Found Dtc: C:/ProgramData/chocolatey/bin/dtc.exe (found suitable version "1.5.0", minimum required is "1.4.6")
-- Found BOARD.dts: C:/ncs/zephyr_kconfig_bug/zephyr/boards/arm/nrf9160dk_nrf9160/nrf9160dk_nrf9160_ns.dts
-- Generated zephyr.dts: C:/ncs/zephyr_kconfig_bug/zephyr/samples/net/sockets/echo/build/zephyr/zephyr.dts
-- Generated devicetree_generated.h: C:/ncs/zephyr_kconfig_bug/zephyr/samples/net/sockets/echo/build/zephyr/include/generated/devicetree_generated.h
-- Including generated dts.cmake file: C:/ncs/zephyr_kconfig_bug/zephyr/samples/net/sockets/echo/build/zephyr/dts.cmake
Parsing C:/ncs/zephyr_kconfig_bug/zephyr/Kconfig
Loaded configuration 'C:/ncs/zephyr_kconfig_bug/zephyr/samples/net/sockets/echo/build/zephyr/.config'
No change to configuration in 'C:/ncs/zephyr_kconfig_bug/zephyr/samples/net/sockets/echo/build/zephyr/.config'
No change to Kconfig header in 'C:/ncs/zephyr_kconfig_bug/zephyr/samples/net/sockets/echo/build/zephyr/include/generated/autoconf.h'
-- The C compiler identification is GNU 12.1.0
-- The CXX compiler identification is GNU 12.1.0
-- The ASM compiler identification is GNU
-- Found assembler: C:/Users/Georges/zephyr-sdk-0.15.0/arm-zephyr-eabi/bin/arm-zephyr-eabi-gcc.exe
-- Configuring done
-- Generating done
-- Build files have been written to: C:/ncs/zephyr_kconfig_bug/zephyr/samples/net/sockets/echo/build
-- west build: building application
[1/288] Generating include/generated/version.h
-- Zephyr version: 3.3.99 (C:/ncs/zephyr_kconfig_bug/zephyr), build: zephyr-v3.3.0-1487-g483126f492ea
[2/288] Generating ../../tfm/CMakeCache.txt
-- Found Git: C:/Program Files/Git/cmd/git.exe (found version "2.39.1.windows.1")
CMake Warning at CMakeLists.txt:46 (project):
  VERSION keyword not followed by a value or was followed by a value that
  expanded to nothing.

-- The C compiler identification is GNU 12.1.0
-- The ASM compiler identification is GNU
-- Found assembler: C:/Users/Georges/zephyr-sdk-0.15.0/arm-zephyr-eabi/bin/arm-zephyr-eabi-gcc.exe
-- Found Python3: C:/Python310/python.exe (found version "3.10.1") found components: Interpreter
CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.22/Modules/GNUInstallDirs.cmake:239 (message):
  Unable to determine default CMAKE_INSTALL_LIBDIR directory because no
  target architecture is known.  Please enable at least one language before
  including GNUInstallDirs.
Call Stack (most recent call first):
  C:/ncs/zephyr_kconfig_bug/modules/crypto/mbedtls/CMakeLists.txt:42 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Performing Test C_COMPILER_SUPPORTS_WFORMAT_SIGNEDNESS
-- Performing Test C_COMPILER_SUPPORTS_WFORMAT_SIGNEDNESS - Failed
Hardlink created for C:\ncs\zephyr_kconfig_bug\zephyr\samples\net\sockets\echo\build\tfm\secure_fw\partitions\crypto\mbedcrypto\library\error.c <<===>> C:\ncs\zephyr_kconfig_bug\modules\crypto\mbedtls\library\error.c
Hardlink created for C:\ncs\zephyr_kconfig_bug\zephyr\samples\net\sockets\echo\build\tfm\secure_fw\partitions\crypto\mbedcrypto\library\version_features.c <<===>> C:\ncs\zephyr_kconfig_bug\modules\crypto\mbedtls\library\version_features.c
Hardlink created for C:\ncs\zephyr_kconfig_bug\zephyr\samples\net\sockets\echo\build\tfm\secure_fw\partitions\crypto\mbedcrypto\library\ssl_debug_helpers_generated.c <<===>> C:\ncs\zephyr_kconfig_bug\modules\crypto\mbedtls\library\ssl_debug_helpers_generated.c
Hardlink created for C:\ncs\zephyr_kconfig_bug\zephyr\samples\net\sockets\echo\build\tfm\secure_fw\partitions\crypto\mbedcrypto\library\psa_crypto_driver_wrappers.c <<===>> C:\ncs\zephyr_kconfig_bug\modules\crypto\mbedtls\library\psa_crypto_driver_wrappers.c
Hardlink created for C:\ncs\zephyr_kconfig_bug\zephyr\samples\net\sockets\echo\build\tfm\bl2\mbedcrypto\library\error.c <<===>> C:\ncs\zephyr_kconfig_bug\modules\crypto\mbedtls\library\error.c
Hardlink created for C:\ncs\zephyr_kconfig_bug\zephyr\samples\net\sockets\echo\build\tfm\bl2\mbedcrypto\library\version_features.c <<===>> C:\ncs\zephyr_kconfig_bug\modules\crypto\mbedtls\library\version_features.c
Hardlink created for C:\ncs\zephyr_kconfig_bug\zephyr\samples\net\sockets\echo\build\tfm\bl2\mbedcrypto\library\ssl_debug_helpers_generated.c <<===>> C:\ncs\zephyr_kconfig_bug\modules\crypto\mbedtls\library\ssl_debug_helpers_generated.c
Hardlink created for C:\ncs\zephyr_kconfig_bug\zephyr\samples\net\sockets\echo\build\tfm\bl2\mbedcrypto\library\psa_crypto_driver_wrappers.c <<===>> C:\ncs\zephyr_kconfig_bug\modules\crypto\mbedtls\library\psa_crypto_driver_wrappers.c
-- Configuring done
-- Generating done
-- Build files have been written to: C:/ncs/zephyr_kconfig_bug/zephyr/samples/net/sockets/echo/build/tfm
[7/288] Performing build step for 'tfm'
[331/332] Generating tfm_s_signed.bin
image.py: sign the payload
[332/332] Generating ../bin/tfm_s.elf
[13/288] Performing install step for 'tfm'
-- Install configuration: "MinSizeRel"
[278/288] Linking C executable zephyr\zephyr_pre0.elf

[282/288] Linking C executable zephyr\zephyr_pre1.elf

[288/288] Linking C executable zephyr\zephyr.elf
Memory region         Used Size  Region Size  %age Used
           FLASH:       89908 B       192 KB     45.73%
             RAM:       22248 B       128 KB     16.97%
        IDT_LIST:          0 GB         2 KB      0.00%
image.py: sign the payload
image.py: sign the payload

The highlights:
First, I attempt west build -p -b nrf9160dk_nrf9160_ns -- -DCONFIG_NET_SOCKETS_LOG_LEVEL_DBG=y
I get the warning.
Right after I get the warning, I abort the build (ctrl-C). I attempt west build -p -b nrf9160dk_nrf9160_ns -- -DCONFIG_NET_SOCKETS_LOG_LEVEL_DBG=y again.
This time, the build goes through with no warning.
So maybe the bug here, actually, is "aborting build early suppresses CMake warnings". I apologize for my confusion early on. Hopefully things are clear now?

What you are seeing is because you started configuring a build, files were written, but the overall cmake files which are actually used to build the project and what the python scripts use to determine if it is a valid cmake project are not there. @mbolivar-nordic do you consider this a bug in west if when doing west build the pristine option only works if cmake completely configured the project before rather than partially before being aborted with ctrl + c?

@mbolivar-nordic do you consider this a bug in west if when doing west build the pristine option only works if cmake completely configured the project before rather than partially before being aborted with ctrl + c?

If by "the pristine option" you mean --pristine always, then no; I would consider this to be a bug in the build system, since west just calls out to the build system to do that.
If you mean --pristine auto, then an incompletely configured build system is likely to cause difficult to diagnose problems. The auto mode usually works but it is by necessity based on heuristics and doesn't always get things right.

I wonder if we need some sort of sentinel files in the build system directory that contain the cmake start and stop times, so we can tell if configuration completed successfully or not. Something like that' is the only way I can think of to start making builds transactional and more robust. That's more a question for you and @tejlmand though, wouldn't you agree @nordicjm ?