Copy/Paste and Other Keyboard Shortcuts Do Not Work on MacOS

Describe the bug
Keyboard shortcuts on MacOS such as cmd/a, cmd/c, cmd/v, cmd/x, cmd/z, and others do not work in the Tauri window. Right-click context menus do behave correctly, but using the keyboard shortcuts for equivalent actions create the system error sound.
To Reproduce
npm run tauri dev and attempt to use keyboard shortcuts to manipulate the field.
Expected behavior
The respective keyboard shortcut to do its default function.
Platform and Versions (required):

Operating System - Mac OS, version 12.0.0 X64

Node.js environment
  Node.js - 16.1.0
  @tauri-apps/cli - 1.0.0-beta.6
  @tauri-apps/api - Not installed

Global packages
  npm - 7.11.2
  yarn - Not installed

Rust environment
  rustc - 1.54.0
  cargo - 1.54.0

App directory structure
/node_modules
/public
/src-tauri

App
  tauri.rs - 1.0.0-beta.5
  build-type - bundle
  CSP - default-src blob: data: filesystem: ws: wss: http: https: tauri: 'unsafe-eval' 'unsafe-inline' 'self' img-src: 'self'
  distDir - ../public
  devPath - http://localhost:8080

Additional context
Currently running on a MacOS 12.0.0 Public Beta, but this keyboard shortcut error doesn't appear in any other application. Some others were reporting this problem on #1055.
Edit: HTML markup
<html>
	<head>
		<title>Tauri Issue</title>
	</head>
	<body>
		<input type="text">
	</body>
</html>

You can fix this by adding a menu

sorry to resurrect this but i m having the same issues(macos as well), even after following the Creating a menu instructions to the letter.
Cannot use cmd+c nor cmd+v which is killing my mojo b/c this is a text editing app.
Would really appreciated any advice,
Thanks!

nope, still not working. Any update?

@serkandemirel0420 it does work, join our discord and we will help you triage it.

Think the API has changed now, as none of the docs are the same and links in this thread are broken. For anyone trying to maintain an app on the old API I was able to fix this by having a dedicated Edit menu:
    let file_menu = Submenu::new("File", Menu::new().add_item(new_thread).add_item(history).add_item(quit));
    let edit_menu = Submenu::new("Edit", Menu::new().add_native_item(MenuItem::Copy).add_native_item(MenuItem::Paste).add_native_item(MenuItem::SelectAll));
    Menu::new().add_submenu(file_menu).add_submenu(edit_menu)


Beautify CSS

I think we can improve a couple of things in the default CSS that is provided:

Beautify it a little
Remove ::selection and use user-select instead
Fix opacity when hovering on column header when it's been sorted
No need to check which direction it's sorted to display the arrow

table th[role=columnheader] {
	cursor: pointer;
}

table th[role=columnheader]:after {
	content: '';
	float: right;
	margin-top: 7px;
	border-width: 0 4px 4px;
	border-style: solid;
	border-color: #404040 transparent;
	visibility: hidden;
	-webkit-user-select: none;
	-moz-user-select: none;
	user-select: none;
}

table th[aria-sort=ascending]:after {
	border-bottom: none;
	border-width: 4px 4px 0;
}

table th[aria-sort]:after {
	visibility: visible;
	opacity: 0.4;
}

table th[role=columnheader]:hover:after {
	visibility: visible;
	opacity: 1;
}

For simplicity, we probably should create tablesort.css.

Also, I think users might already have role=columnheader on headers, but chose to also have no-sort class on it. We probably should account for that.

@xPaw these changes look great and yeah, for simplicity including a tablesort.css stylesheet makes sense too.

Also, I think users might already have role=columnheader on headers, but chose to also have no-sort class on it. We probably should account for that.

Current logic in code is to only add role=columnheader to headers that do not have no-sort, but for accessibility purposes we might need to add it to all headers. @tristen What do you think?

Yep, we should add role=columnheader always and add a rule in css that accounts for the addition of no-sort on the element. @xPaw you good to cook these changes into a PR?

@tristen Should I do :not(.no-sort) or add a .sortable on theads instead?

@xPaw ahhh both those options aren't ideal. Does:
table th[role=columnheader].no-sort:after
table th[role=columnheader].no-sort:hover::after { visibility: hidden; }

Work? It's a little wonky but it avoids adding an extra class or a not well supported selector..

It's a little wonky but it avoids adding an extra class or a not well supported selector..

You're looking at multiple selectors support, simple :not() is CSS3 and supported in all browsers.

You're looking at multiple selectors support, simple :not() is CSS3 and supported in all browsers.

Um whoops. Using :not() sounds great.


Error: Unable to get property '_chart' of undefined or null reference

Some of our users are reporting:
Error: Unable to get property '_chart' of undefined or null reference
User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; Trident/7.0; rv:11.0) like Gecko Environment: Gecko running on Windows 8
Chart.js v2.9.4
but we are unable to reproduce this error.  I notice that the dereference of _chart is not always accompanied by a check that the variable being dereferenced is  defined - might it be worth adding such checks so that we can avoid this error?

Do you know where in the code the _chart reference is coming from?

There are 24  such occurrences in the code - but I do not know (sadly) which one it is as by the time the error message reaches me in development the information has been lost.  May I propose that it should be policy, as in Kotlin, to check that every such  dereference is possible?

We can consider adding checks everywhere but to be honest, it's not going to really change the end user outcome because if this is undefined then the entire chart is likely to be broken.
I went back to look at the v2 branch and can see most of these references in the drawing elements and the tooltip. If this problem is in the drawing element, nothing is going to render on the chart and if the problem is in the tooltip, then the chart will not have any interactivity. In the V2 code, I think this could occur if destroy() is called on the chart instance but something is still using the old chart.
The good news is that in the v3 code, this is only used in the tooltip so it's less likely to occur.


Apple Devices not found

Hi,
is there a new problem with Apple Login?
Since Saturday my devices have not been found and tracked despite the correct login.
Before it works correct...
What can I do?

This is fixed in v3.1.4


Image padding calculation confusion

Shouldn't this condition be image_data_size % 64 > 60?
https://github.com/HE7086/pdf-md5-hashquine/blob/82ba3fcf52dfbc518efac7a98af10e4c127d1e76/project/gen.py#L23

Seems true, this is the exact same problem that happened in #1 , which didn't happen in my test runs.
There's a lot of hard-coded values and untested code paths in this project, let me know if you find any problem :)


Add Symfony 3 components to composer.json

After the release of Symfony 3 and the fact, that puli/manager is using the filesystem and event-dispatcher component, I added Symfony 3 support in composer.json.

Awesome, thanks! :)


Unable to use with vite as vite doesn't support require statement

Vitejs doesn't support require statement which is used inside xml2js module ref
there should be a migration done for ESmodules

Try window.require() bur not require()

Has anyone tried the result of running decaffeinate on this? The rollup incompatibility is particularly annoying.

Having same issues with Vite 2.8.0 when trying to use xml-js package. However, the solution I found was to get rid of Vite and go with Rollup (which is what Vite uses internally). The biggest drawback is that for live-editing/debugging Vite is much faster than Rollup for my project (1 sec compared to 30s).
package.json using rollup:

The rollup.config.js had to be modified by adding @rollup/plugin-commonjs  and @rollup/plugin-node-resolve
//rollup.config.js
import resolve from '@rollup/plugin-node-resolve';
import commonjs from '@rollup/plugin-commonjs';

export default {
  ...
  plugins: [
    ...
    // If you have external dependencies installed from
    // npm, you'll most likely need these plugins. In
    // some cases you'll need additional configuration -
    // consult the documentation for details:
    // https://github.com/rollup/plugins/tree/master/packages/commonjs
    resolve({
      browser: true,
      dedupe: ['svelte'],
      preferBuiltins: false
    }),
    commonjs(),
    ...
  ],
  ...

https://github.com/rollup/plugins/tree/master/packages/commonjs


Add navigation structure for learn section

As we expand the Quickstart tutorial and others start contributing tutorial content, we need a central structure for organising the learning pages on the site.
I've drafted a possible solution in this PR:

A new page layout is introduced with a navigation side bar which displays the contents of the learn section and the structure of the current page headings.
A yaml file is used to define the contents and order of the navigation bar whereby learning pages are grouped into named chapters

This approach:

makes navigation explicitly clear to site users (no getting lost among lots of pages);
allows contributors to start adding tutorial pages to the site now;
but is flexible enough that it can easily be restructured as the number of tutorials increases;

To add a page, contributors need only write a markdown file and add an entry under the appropriate chapter in the yaml data file. (I will update CONTRIBUTING.md)
For this draft PR I've just included the existing quickstart tutorial to demonstrate; eventually the landing page will be updated to include useful links etc.
@milancurcic , @certik what are your thoughts?
#build_preview

#build_preview

I think this is great and a step forward. I approve.
I anticipate that our structure of content will be more unordered than ordered, so we may drop the numbering, but we can figure this out later as we go.

Okay, I've restructured this PR so that it's less like a single monolithic book with chapters and
instead it allows single-page and multi-page mini-book tutorials.
The name and contents of each mini-book is defined in a yaml data file which is used to: populate the Learn landing page with a list of books, grouped by category; and populate a table-of-contents for each mini-book.
To demonstrate this, the Quickstart tutorial has been broken out into multiple pages so it's easier to navigate.
The 'Learn' landing page has been updated to also include an initial selection of third-party resources as well.
The Learn page is a little bare at the moment, but with the structure now in place it should be quite easy to start adding more mini-book tutorials (starting with #90).
I will add a section to the contributor guide on how to write a mini-book tutorial.
#build_preview

@LKedward this looks really great. Lots of work done here thank you!
We should put there a link to https://github.com/j3-fortran/fortran_proposals also I think.
I think it looks great, +1 from me.

An issue that comes up here is how to sort the books? Currently they don't seem sorted in any particular way. Books at the top of the list will be implicitly given higher priority or sense of importance. So we need to decide how to sort them:

Alphabetically by title?
Alphabetically by author last name?
Chronologically from newest to oldest?

As yes, good point, I hadn't considered this.
I'm not sure what the best/standard way to sort them is - my preference would be to sort by date with newest first to prioritise up-to-date editions.

Print books are now sorted by year descending - this can be changed to alphabetical if desired.
#build_preview

This looks really great. Easy to navigate and read! Really good job!

Thanks all for the feedback and suggestions. I will now merge and work on updating the contributor guide with instructions in a new PR.

#delete_preview


Remove kuksa-client

As kuksa-client has been moved to https://github.com/eclipse-kuksa/kuksa-python-sdk it should better be removed from old location, to avoid that pull-requests and issues are created in this repo.
Possible regressions:

Tests relying on that kuksa-client exist in master branch of this repo will fail. That is good, then they can start using the other repo
Tests relying on using kuksa-client docker contain from this repo will continue to work, but they will no longer test against "latest" released/unreleased version. If we consider it important to make sure that we everyone migrates we could upload a "broken" docker container, but that is hopefully not needed

This works for me, I also meanwhile tagged a "last 0.4.2" that already pushed a container printing a waring message (I did opt for that instead of pushing an "evil" not working container.
So we could move forward removing this in master, but anyway, it does need tiny rebase first :-D

@SebastianSchildt - It is rebased now


Close icon should use currentColor

I'm submitting a ...
[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior

When the background color of the modal is changed to something dark (to match the OS preferences for dark mode e.g.) the close icon remains black due to the fact, that it uses #000000 to fill the icon.
Expected behavior

The base64 encoded svg should be replaced with its corresponding svg code and use currentColor to fill the icon.
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" id="Layer_1" x="0px" y="0px" viewBox="0 0 512 512" style="enable-background:new 0 0 512 512;" xml:space="preserve" width="16px" height="16px">
<g>
    <path d="M505.943,6.058c-8.077-8.077-21.172-8.077-29.249,0L6.058,476.693c-8.077,8.077-8.077,21.172,0,29.249    C10.096,509.982,15.39,512,20.683,512c5.293,0,10.586-2.019,14.625-6.059L505.943,35.306    C514.019,27.23,514.019,14.135,505.943,6.058z" fill="currentColor"/>
</g>
<g>
    <path d="M505.942,476.694L35.306,6.059c-8.076-8.077-21.172-8.077-29.248,0c-8.077,8.076-8.077,21.171,0,29.248l470.636,470.636    c4.038,4.039,9.332,6.058,14.625,6.058c5.293,0,10.587-2.019,14.624-6.057C514.018,497.866,514.018,484.771,505.942,476.694z" fill="currentColor"/>
</g>
</svg>

And then maybe provide an additional (optional) property to color the icon separately from the modal text color if needed:
<ngx-smart-modal ... [icon]="'red'">...</ngx-smart-modal> which would add the provided color (or hexcode) to the surrounding button element.
Reproduction of the problem

https://plnkr.co/edit/j3kEpFufYkQV2PEXXj3S?p=preview
What is the motivation / use case for changing the behavior?

Dark UIs (e.g.) are fairly common nowadays and are pushed through OS Dark Modes. Therefore the close icon wouldn't be visible anymore if the UI changes to some dark theme.

Hi @marcreichel
Thank you for your report, it will be very interesting for SmartModal to implement this feature, which requires changing our img icon to a SVG icon.
I will check that if I have time soon, otherwise feel free to contribute ! 🤘

@khylias Submitted a PR 💪

Hi @marcreichel
For me add a input for set a color of the icon is overkill
But for the dark mode, I agree, and we just need to use
@media (prefers-color-scheme: dark) on our css

@LouisAugry Yeah, I've adjusted the PR. The color could be changed by setting the color of the .nsm-dialog-btn-close class in CSS. I also don't think the CSS on your side has to be touched in any way, because the color is inherited from the parent/root (by default) which is likely modified by the developer using ngx-smart-modal to match @media (prefers-color-scheme: dark).


cmd/asm: arm assembler "illegal combination" for CMPF in Go 1.5

It's likely something I'm doing wrong that just happened to work previously, but some ARM assembly that
worked fine in Go 1.4.2 (go version go1.4.2 darwin/amd64) is giving an error in Go 1.5 (go version go1.5 darwin/amd64)
The instruction CMPF F4, F1 at https://github.com/samuel/go-dsp/blob/master/dsp/math32_arm.s#L246 produced the follow in Go 1.4.2 running GOOS=linux GOARCH=arm GOARM=7 go build
vcmpe.f32  s2, s8
vmrs       APSR_nzcv, fpscr

In Go 1.5 I get during compile
asm: illegal combination 00128 (/Users/samuel/Dropbox/Workspace/go/src/github.com/samuel/go-dsp/dsp/math32_arm.s:246)	CMPF	F4, F1; PSR NONE PSR, 11 11

The problem is that cmd/internal/obj/arm only handles CMPF
instruction when the 2nd register is in Prog.Reg field, not in To,
but cmd/asm puts that into Prog.To.
Should we modify cmd/asm to add a special case or add another
rule to cmd/internal/obj/arm?
/cc @robpike

To me, it looks like a special case is needed in the assembler. The old 5a code explicitly put the second arg in a register, but the new one does not. This applies only to CMPF and CMPD, if I am reading the old code correctly.

This doesn't cherry-pick cleanly into the 1.5.1 release branch.
Rob, can you take a look?


Numerical gradient check fails?

So this is my first time toying around with Torch modules and the like, so there's a big chance I'm overlooking something obvious. I was trying to implement an attention model, but when testing the gradients using optim.checkgrad they didn't match. I later realised that even for this simple model, I can't get them to match:
nn = require 'nn'
require 'rnn'
require 'optim'

hiddenSize = 2
nIndex = 2
r = nn.Recurrent(hiddenSize, nn.LookupTable(nIndex, hiddenSize),
                 nn.Linear(hiddenSize, hiddenSize))

rnn = nn.Sequential()
rnn:add(r)
rnn:add(nn.Linear(hiddenSize, nIndex))
rnn:add(nn.LogSoftMax())

criterion = nn.ClassNLLCriterion()

function f(x)
  parameters:copy(x)
  -- Do the forward prop
  rnn:zeroGradParameters()
  local err = 0
  for i = 1, sequence:size(1) - 1 do
     local output = rnn:forward(sequence[i])
     err = err + criterion:forward(output, sequence[i + 1])
     local gradOutput = criterion:backward(output, sequence[i + 1])
     rnn:backward(sequence[i], gradOutput)
  end
  r:backwardThroughTime()
  r:forget()
  return err, grads
end

parameters, grads = rnn:getParameters()

sequence = torch.Tensor{1, 2, 1, 2}:resize(4, 1)
local err = optim.checkgrad(f, parameters:clone())
print(err)

This gives me errors anywhere between 0.1 and 0.01, which is way too big. After some digging I got to these lines in Recurrent.lua. Removing these lines seems to fix the problem, making the gradient error falls to around 1e-7.
         -- startModule's gradParams shouldn't be step-averaged
         -- as it is used only once. So un-step-average it
         local params, gradParams = self.startModule:parameters()
         if gradParams then
            for i,gradParam in ipairs(gradParams) do
               gradParam:mul(rho)
            end
         end

I fail to see where gradParams get averaged, so I don't really understand the logic behind these lines. They seem to just scale the gradients for the initial hidden states with the number of steps?

@bartvm You are absolutely right. I though I removed that when I removed the size-averaging. Integrated your changes and unit test here : https://github.com/Element-Research/rnn/commit/1613d03166138c8827319c7a391a631217aca1b9. Many thanks for finding this. Kind of freakish that none of the unit tests caught this o_O...

Great, thanks!
So up next I tried to do the same numerical gradient check using LSTMs, but failed again. In this case, I tracked it down to LinearNoBias. This subclass sets the bias to zero at the beginning, and resets the gradient accumulation before the update, but if you call model:getParameters() it will still return the bias as trainable parameters, and they are part of the forward prop. This means that the numerical gradient estimate ends up being "wrong".
I can see the motivation behind the minimal implementation of LinearNoBias but given that it (a) does useless calculations and (b) the parameters and getParameters calls return parameters that should not be trained, I'd prefer a proper implementation of LinearNoBias instead (even though it's largely a copy paste of Linear with some lines removed).

@bartvm Yup, I agree. Your new version of LinearNoBias should be more friendly to optim and more efficient. Thanks.

Hey @bartvm thanks again for this PR. Your unit test help me find a very pernicious bug that I would not have found otherwise for solving https://github.com/Element-Research/rnn/pull/105.


Resize the image in the browser within the max size of the image that OpenAI will process

Unresolved task from PR #286

This could be done without a library by drawing the image to a canvas with the desired dimensions, then using canvas.toDataURL() or canvas.toBlob() to get the image back again.


Why do Travis builds sometimes fail...

... when trying to restore Microsoft.CodeAnalysis.Common ?
1438  GET https://www.myget.org/F/aspnetvnext/api/v2/package/Microsoft.CodeAnalysis.Common/1.0.0-rc3-20150615-01
1439Error: DownloadPackageAsync: https://www.myget.org/F/aspnetvnext/api/v2/package/Microsoft.CodeAnalysis.Common/1.0.0-rc3-20150615-01
1440  Unknown header: 21712958

see https://travis-ci.org/aspnet/dnx/builds/67601969

Closed. Posted to aspnet/dnx.


Fixed a few typos

Ok sorry for the lapse - here it is!

Thanks @michaelforrest, could you please squash? :+1:

I'm editing this up on Github, not on a local copy - I don't think I can do a squash from here.

so many typos :( I'm the king of them I'm afraid. Thanks so much for going over this.


gate (v0.31.2) breaks cachePingTTL parsing for Lite Mode

Arch: x86_64
Go version: go1.20.6 linux/amd64
Tested on:

OS: Debian GNU/Linux 12 (bookworm) / Kernel: 6.1.0-10-amd64
OS: Fedora Linux 38 (Workstation Edition) / Kernel: 6.3.12-200.fc38.x86_64

I've been doing some testing of the latest Gate proxy versions lately, and a couple of days ago I had mentioned how v0.31.1 was unable to parse -1 or "-1" properly, referenced here: #221
A simple workaround was to simply pass "-1s", which seemed to do the trick.
The latest commit (https://github.com/minekube/gate/commit/59afe398a3125b1b5fa07b8347afa5000bf6b558), which attempts to solve the parsing issue however, seems to unfortunately break cachePingTTL parsing altogether:
Error logs

error reading config file "/home/server/minecraft/proxy/testing/config.yml": error unmarshaling config file "/home/server/minecraft/proxy/testing/config.yml" to *config.Config: yaml: unmarshal errors:
  line 10: cannot unmarshal !!str `-1s` into configutil.Duration

error reading config file "/home/server/minecraft/proxy/testing/config.yml": error unmarshaling config file "/home/server/minecraft/proxy/testing/config.yml" to *config.Config: yaml: unmarshal errors:
  line 10: cannot unmarshal !!str `-1` into configutil.Duration

error reading config file "/home/server/minecraft/proxy/testing/config.yml": error unmarshaling config file "/home/server/minecraft/proxy/testing/config.yml" to *config.Config: yaml: unmarshal errors:
  line 10: cannot unmarshal !!str `0s` into configutil.Duration

error reading config file "/home/server/minecraft/proxy/testing/config.yml": error unmarshaling config file "/home/server/minecraft/proxy/testing/config.yml" to *config.Config: yaml: unmarshal errors:
  line 10: cannot unmarshal !!str `0` into configutil.Duration

error reading config file "/home/server/minecraft/proxy/testing/config.yml": error unmarshaling config file "/home/server/minecraft/proxy/testing/config.yml" to *config.Config: yaml: unmarshal errors:
  line 10: cannot unmarshal !!str `1s` into configutil.Duration

error reading config file "/home/server/minecraft/proxy/testing/config.yml": error unmarshaling config file "/home/server/minecraft/proxy/testing/config.yml" to *config.Config: yaml: unmarshal errors:
  line 10: cannot unmarshal !!str `1` into configutil.Duration

error reading config file "/home/server/minecraft/proxy/testing/config.yml": error unmarshaling config file "/home/server/minecraft/proxy/testing/config.yml" to *config.Config: yaml: unmarshal errors:
  line 10: cannot unmarshal !!str `60s` into configutil.Duration

The configuration used was:
config.yml

config:
  bind: <IP_ADDRESS>:25565
  proxyProtocol: false
  lite:
    enabled: true
    routes:
      - host: ["*"]
        backend: <IP_ADDRESS>:25565
        proxyProtocol: false
        cachePingTTL: "60s"

I'm not experienced with Go but I did attempt to debug as best I could.
At line 625 in yaml/decode.go (https://github.com/go-yaml/yaml/blob/f6f7691b1fdeb513f56608cd2c32c51f8194bf51/decode.go#L625), an attempt to resolve the type in a switch statement results in something like:
interface {}(string) "-1s"
which will switch on case string @ line 647 (https://github.com/go-yaml/yaml/blob/f6f7691b1fdeb513f56608cd2c32c51f8194bf51/decode.go#L647), but will fail to equate to a durationType (https://github.com/go-yaml/yaml/blob/f6f7691b1fdeb513f56608cd2c32c51f8194bf51/decode.go#L332), thereby skipping the time.ParseDuration statement on the next line.
Interestingly, I don't think the wrapper functions introduced in (https://github.com/minekube/gate/blob/master/pkg/util/configutil/duration.go) are ever called. No breakpoints seemed to hit them. I wonder if this has to do with it being recognized as a string and not of it's respective type, possibly previously mentioned here #218 and here https://github.com/spf13/viper/issues/338#issuecomment-382376136
How to reproduce:

Manually download the binary at https://github.com/minekube/gate/releases/tag/v0.31.2.
Have a config.yml file using Lite-Mode, with the cachePingTTL value set to a numerical value with or without the "s" appended.
Attempt to run proxy.

Caveats:

Only tested using native Go binaries, and did not test with Docker or Kubernetes
Only tested cachePingTTL for Lite-Mode

Thanks, I’ll look into it asap.


Switch columns and rows

Greetings,
Sorry guy but, my client want to switch place of rows (hours) to column and column (date) to row. Can anyone give me a track or how to do it ?
Thank a lot

Any idea how to do it?

@sebastianpsf how did you end up solving the issue?

Any idea how to do it?

@sebastianpsf  were you able to solve your issue?

Hi,
You can code it with timeline (event ressource) and put correct option https://fullcalendar.io/docs/timeline-view. Unfortunately, i found no plugin

Any idea how to do it?

@sebastianpsf were you able to solve your issue?

Nope, I had to use react-selectable-fast


better logging for the kilt lambda when using hints

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area cfn-runtime
What this PR does / why we need it:
This provides better logging around application of the entrypoint and command changes

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign admiral0 after the PR has been reviewed.
You can assign the PR to them by writing /assign @admiral0 in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@admiral0: The label(s) area/cfn-runtime cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area cfn-runtime
What this PR does / why we need it:
This provides better logging around application of the entrypoint and command changes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/area cfn-runtime

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 6208aab9e1689c337d908fbcbffe0d4854f0bbf9


Keep plan name in instance aggregatedStatus when plan is terminal

Summary:
we were resetting Status.AggregatedStatus.ActivePlanName field when the plan was terminal. This lead to this field looking like this:
Status:
  Aggregated Status:
    Status:  COMPLETE

The idea of the field is to keep information about the last/current plan including plan name and status.
Signed-off-by: Aleksey Dukhovniy<EMAIL_ADDRESS>

if we want to change the meaning of this field. WDYT?

I agree with a confusing name, however, introducing a breaking change just to rename a field is unnecessary. Also, I'm planning to remove the AggregateStatus altogether after #1442 lands so 🤷♂


A question on a break statement in HF_LLM::forward()

Hi there!
I couldn't understand why a break has been used (not a continue) during creating batch_inputs and batch_outputs in the case there's no candidate for a context:
https://github.com/flowersteam/lamorel/blob/b012e2e8f164145af80084955fc79344049bb9e1/lamorel/src/lamorel/server/llms/hf_llm.py#L255-L256
This skips the next contexts and they don't come into batch_inputs and batch_outputs. Is this the desired behavior? If yes, could you please tell why is so? Furthermore, it seems that we would face KeyError during creating batch_input_representations, this way.
https://github.com/flowersteam/lamorel/blob/b012e2e8f164145af80084955fc79344049bb9e1/lamorel/src/lamorel/server/llms/hf_llm.py#L282-L286
as we're iterating over contexts including those we skipped earlier but there's no entry for them in _ids_tables.
@ClementRomac

Hi!
Thanks for spotting this. This looks like a legacy code that shouldn't be there anymore.
I think, at least for decoder-only models, we should create a single output with the last token of input to still be able to get activations when pre_encode_inputs=True. I guess the easiest fix would be to replace the break statement by _candidates = [""].
I need to properly test this to verify it is actually necessary.

Hi,
I opened this PR which should handle empty candidates.

Another thing. For decoder-only and pre_encode_input=True case, the tokenized_contexts=batch_inputs argument to custom module calls
lacks the last token of the context which has been prepended to the output. Is this really desired? Couldn't be confusing for the user?
https://github.com/flowersteam/lamorel/blob/c82d1b17d275ef40f5d5c23dafde0e56ef01e73e/lamorel/src/lamorel/server/llms/hf_llm.py#L346-L352


Cannot generate PAT token from dashboard or sandbox

Description
On the Sandbox dashboard, I am unable to generate a PAT token.
Current Behavior
When filling out the form and pressing generate, nothing happens and console shows a vague error.
Expected Behavior
I should be able to get a PAT token
Environment:
MacOS, Zen Browser

same here, I can't generate a token in both environments.

same here, I can't generate a token in both environments.

actually just found a temp fix, don't select all scopes, just use the ones you need, I think there's an issue with one or more scopes, that's why it's not generating the keys.

Sorry, I can't believe I missed this notification. Will prioritize this ASAP and ship a fix quickly.

Deployed a fix along with overhauling the entire form into an InlineModal for a better experience, error handling and more. Thank you for reporting this @salvinoto & @ojaydev and apologies again for missing the notification in the first place 🤦🏼♂


How to detect re-export?

Could anyone provide eslintrc rules which detect re-exported fields?
exports.a = 5;

// something here

exports.a = 10;

Thanks

Like, duplicate commonjs exports fields?
I'm not sure that's necessarily an error - there's a reason the best practice is to do module.exports = {…} and not to do exports.something =

Like, duplicate commonjs exports fields?

Yes

I'm not sure that's necessarily an error - there's a reason the best practice is to do module.exports = {…} and not to do exports.something =

Maybe =)
But i have a lot of legacy code and just want to detect duplicates
Is there any way to do it?

I am going to say this is out of scope for this plugin, which is focused more specifically on ES2016+ import/export syntax.
I double-checked the existing export rule which validates this for the "modern" syntax and it would not be trivial to extend it to cover CJS as well.
There may exist another ESLint plugin that does this, but I am not aware of any.
Cheers!

I wrote a plugin to support commonjs duplicate exports check: eslint-plugin-commonjs

@helloyou2012 amazing, works for me =)
Thank you!


[windows] NSRecursiveLock: missing initialization of mutex/condition variable

Looks like timeout condition variable and corresponding mutex are not initialized in RSMRecursiveLock implementation. Noticed random but often crashes in our test code. Best reproduced with nested lock/unlock calls
let lock1 = NSRecursiveLock()
let lock2 = NSRecursiveLock()

lock1.lock()
lock2.lock()
lock2.unlock() // <- crash or hang here

Not sure if there is no additional issues though, still getting very rare crashes. But success rate changed from, like, "1 success per 100 failures" to "1 failure per 100 success runs".

Um, no, no one would ever write code like that, this is ... yes, yes, something must be wrong with the checkout.  sigh  At least I got the non-recursive case right?  That counts for something right?

@swift-ci please test and merge


update README.md and ocid.conf.5.md

update build step in README.md
update missing docs for #153 , sorry for that

Signed-off-by: HaoZhang<EMAIL_ADDRESS>

LGTM


Order of Latitude and Longitude seems inconsistent in GeoJSON export

Hi,
From my very limited testing of the app, it seems that when exporting data in GeoJSON, in the geometry section of the file the coordinate pairs are [latitude, longitude] when the geometry is a point, but [longitude, latitude] when the type is polygon.
Could you please check on that and let me know if this is intentional?
Thanks,
Jan

Hi,
Thanks for the feedback, which app version did you check ? you can check the recent version the issue is fixed.
Thanks,
Lucien


Help cleans resnet train.ipynb -- use relative path imports, rid ACT module

Hey there, thanks for this great repo.  Very easy to use and clean implementation.
This tiny PR cleans a couple things that might be helpful for others.  It brings in the nice relative path imports in other notebooks that weren't in resnet_34_8s_train.ipynb.  Also there was an import from adaptive_computation_time, but this module isn't needed.
If I get around to it later I might also help add some documentation on setting up VOC for use with this repo.
Cheers!

Also just tacked on a small fix to README

Thank you, @peteflorence !
Have a look at my comment

@peteflorence  I have just realized that you did it much easier for other people to use.
Thank you

Very good!
I've used your repo as a building block in a new project, hopefully will open source that soon

@peteflorence I am glad this repo worked for you :)
Great :) Let me know if you do, I would love to have a look

Hey @warmspringwinds, circling back on this, we just had our project go live that built in part off this repo.
Here is code, video, arXiv pre-print.
Your repo was very helpful -- my first version of training up our networks used a derived version of your training notebook, just with new pre-processing and loss function swapped in (we are doing a different task than segmentation).
Cheers!, Pete

@peteflorence
That's a great work! I will have a more thorough look these days for sure!
I am glad that my work was useful for you :+1:


Error occurred when executing DownloadAndLoadMimicMotionModel:

Error occurred when executing DownloadAndLoadMimicMotionModel:
Cannot load E:\comfyui\ComfyUI-aki-v1.3\models\diffusers\stable-video-diffusion-img2vid-xt-1-1 because decoder.conv_in.bias expected shape tensor(..., device='meta', size=(64,)), but got torch.Size([512]). If you want to instead overwrite randomly initialized weights, please make sure to pass both low_cpu_mem_usage=False and ignore_mismatched_sizes=True. For more information, see also: https://github.com/huggingface/diffusers/issues/1619#issuecomment-1345604389 as an example.
File "E:\comfyui\ComfyUI-aki-v1.3\execution.py", line 151, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "E:\comfyui\ComfyUI-aki-v1.3\execution.py", line 81, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "E:\comfyui\ComfyUI-aki-v1.3\execution.py", line 74, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "E:\comfyui\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-MimicMotionWrapper\nodes.py", line 124, in loadmodel
mimicmotion_models = MimicMotionModel(svd_path, lcm=lcm).to(device=device).eval()
File "E:\comfyui\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-MimicMotionWrapper\nodes.py", line 46, in init
self.vae = AutoencoderKLTemporalDecoder.from_pretrained(
File "E:\comfyui\ComfyUI-aki-v1.3\python\lib\site-packages\huggingface_hub\utils_validators.py", line 114, in _inner_fn
return fn(*args, **kwargs)
File "E:\comfyui\ComfyUI-aki-v1.3\python\lib\site-packages\diffusers\models\modeling_utils.py", line 757, in from_pretrained
unexpected_keys = load_model_dict_into_meta(
File "E:\comfyui\ComfyUI-aki-v1.3\python\lib\site-packages\diffusers\models\model_loading_utils.py", line 154, in load_model_dict_into_meta
raise ValueError(

+1 i have the same question.

+1 I have the same issue

@jarry-LU @gaobatam Today, I resumed using this node and it's functioning normally again. The difference from before is that I have renamed the JSON files in each folder according to the examples to their correct names, and all models are now using fp16 models. This is because the files downloaded from Huggingface get their names changed. I do not know if you have successfully run it or not, but I hope my experience can be of some help.

@judian17
It worked! Thank you so much! I can't believe this error was related to the JSON configuration file names.


#1448 - Add search bar on help board with a search button

What does this pull request aim to achieve? 💯
Add search bar on help board with a search button
Please be concise and link any related issue(s):
closes #1701
closes #1702
closes #1691
closes #1686
closes #1684

[x] I have checked that no one else is working on similar changes.
[x] I have read the latest README and understand the development workflow.
[x] The name of this branch is: feature/<branch_name>, or hotfix/<branch_name> if this is a hotfix, where <branch_name> briefly describes the issue(s) resolved and is prefixed with the issue number(s) (e.g. 1127-1130-update-git-branching-model). The branch is created in a cloned version of this repo, not a forked repo.
[x] This branch is rebased/merged with the latest staging (or the latest production if it is a hotfix).
[x] There are no merge conflicts.
[x] There are no console warnings and errors.
[x] On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".
[x] The title describes the issue(s) being addressed using format: <issue_numbers> - <brief_issue_description> (e.g. #1127/#1130 - Update Git Branching Model)

@Zaydme

Issue #1685 : Search text box is NOT aligned yet, Please see below screenshot :FAIL

Offering/request Help caption is updated, refer below screenshot: PASS

Issue#1686: Mobile Search:
The functionality is changed as when user start typing in the search box, by default the search is performed  for 'POST', But
user cannot switch between the TABs for the same searched keyword. To perform search for the same entered keyword, user need to switch the TAB and the RE-type the word. User should be able to switch between TABs without re-typing the same keyword as in desktop. Refer below GIF: FAIL

@Zaydme @doheekim93 @joshmorel
We might need to consider translation for 'Post/Organization/People' in search functionality because

we have these words translated in profiles and 'Create Post' terms.

Currently they are not translated when language is switched.  refer below screenshot.

I would like to mention here that this issue is not related to feature, this error message is not translated for the filters as well.
The error messages are also not translated when there is no search data.
Refer below screenshot.

@rabbi08 you can find all the new keys that need to be translated here
note:
One or two keys were originally translated but will need to be translated again (like "All posts"). because some key names had to be changed for differentiation. as an example:
-    "all": "All posts",
+    "allPosts": "All posts",
+    "allPeople": "All people",
+    "allOrgs": "All organizations",

@Ritika92 @rabbi08 @doheekim93 current tracked GTM ids are as follow.

And for tracking search keywords that are typed in the input field, a custom "SERACH_KEYWORD" event will be fired

that will contain the search keywords
{
  gtm: {
    ...
  },
  event: 'SEARCH_KEYWORD',
  userId: 'xxxxxxxxxxxxxxxxxxxxxx',
  keyword: 'face mask and sanitizer'
}

can you please inform BI team of this to see if it's enough for them, or if they need to track something else.

@Zaydme

The user profile logo/avatar should also be clickable under 'Organization and People' TAB. This is working as expected under 'POST' tab. Refer below GIF.

@Zaydme

On Mobile, the search results are not updated when user switch between the TABs. unless user click on 'return' specifically. Please see below GIF.

Also, can we change the 'return' to 'Search' when user click in 'Search' box? also,  search is performed after clicking on 'magnifier' icon in search box.

The user filters are removed, when user perform search.

@rabbi08 you can find all the new keys that need to be translated here
note:
One or two keys were originally translated but will need to be translated again (like "All posts"). because some key names had to be changed for differentiation. as an example:
-    "all": "All posts",
+    "allPosts": "All posts",
+    "allPeople": "All people",
+    "allOrgs": "All organizations",

@Zaydme @Ritika92 @doheekim93
We have to message to #transalation as mentioned by Do Hee in the diagram below. We have to ensure our error messages are translated.

On this feature URL  https://feature1448-help-board-search-bar.fightpandemics.xyz/feed
1.A21 is organization profile created 3 different post as Entertainment as tag and Grocery/Food as tag.
2.Only Grocery/Food tagged post is getting displayed when I search post with with "A21" keyword
3.It is not displaying the "Entertainment" tags in the results.
please have a look at the attached gif.

1.When user sets filter and  click on apply filters it will display the results.
2.Upon clicking on any search results and navigating back to browser backward button, set filtered values are clearing automatically.

@vandanafs

for this case A21 has 2 posts with city visibility, so they are only visible for people in Exton, US. You can try and set a location filter to "Exton, PA, USA" and you will be able to see all 3 posts (as in the image)

for this issue there is a work in progress, and that's another feature, plese check https://github.com/FightPandemics/FightPandemics/pull/1709

@Zaydme did you change the position of the search bar?
I can't recall this overlapping issue being the case the last time.

yes, I did center the header search bar lately, I just fixed this overlapping issue :+1:

@Zaydme  https://github.com/FightPandemics/FightPandemics/blob/b347a0392498cb682c1de4e1d1110903b0020d62/client/src/actions/authActions.js#L22
Uses the function:
https://github.com/alinemorelli/react-gtm/blob/796bd199384de2a7eca36766ba16219fe1bb892b/src/TagManager.js#L45
Which practically works the same as if (window.dataLayer) window.dataLayer.push... but with some additions... Probably best to be consistent with using the react-gtm-module like in authActions. Otherwise I think we are good from my perspective.

@Zaydme
Search is not working as of now, please see below GIF.

@Zaydme
Search is not working as of now, please see below GIF.

@rabbi08 we have changed the db in preparation for the merge, so search functionality won't be working now.

@Zaydme
Search is not working as of now, please see below GIF.

@rabbi08 we have changed the db in preparation for the merge, so search functionality won't be working now.

@rabbi08 :How long it is not going to work?

@rabbi08 :How long it is not going to work?

@rabbi08 it should work just after the merge to staging


Removed the notion of VerticalChunkMeshSegments from SystemConfig and everywhere else.

Removed the notion of VerticalChunkMeshSegments from SystemConfig.
Everything else is a consequence, including chunks no longer having submeshes and related methods.

I have briefly tested this PR and everything seems to work as normal. However, I'm not sure how to test the features related to the ChunkMonitor, i.e. ChunkMonitorInfo and ChunkMonitorEvent. Where do those come into play?

Bummer. I forgot to take the chance to run checkstyle on everything. If I get any feedback requiring changes I'll try to remember.

The advanced monitoring system has to currently be enabled manually via monitoringEnabled - either changing it in the config file or setting the boolean in SystemConfig to true and deleting any existing config file. Then a second window should pop up when you launch the game :-)

There's a checkstyle plugin for eclipse that just adds Checkstyle warnings/errors to the regular list of problems. I would assume that there's something similar for IntelliJ so that you don't have to check  manually.

Yarrr :-)
https://github.com/MovingBlocks/Terasology/wiki/Checkstyle
Been a while since I had to hook it up so I forget if it is bundled with IntelliJ these days. Handy to be able to run Checkstyle on a single file inside the IDE.

Ha! I just found that I have checkstyle's realtime scan already enabled. So, I would just have to pay more attention to those little yellow signs on the side of the open file. However, I just noticed a problem. Those yellow signs are triggered by other inspections too. This means that if I run checkstyle from the tab it might tell me there's nothing wrong with the file even though there might be plenty of yellow signs from other inspections. So, by the look of it, I can't rely on checkstyle's realtime scan unless I can rely on all other active inspections. But in some cases those are too strict. I.e. in RenderingConfig.java there are plenty of getter/setter methods that are not in use and are triggering the yellow warnings.
So, if checkstyle is "the" project-provided code inspection tool, either it needs to stand out from the other realtime inspections OR we need to remember to run it manually OR we need to look into all other active inspections too, so that we can rely on those too. =?

Regarding the ChunkMonitor, thanks Cervator for letting me know. I just gave it a spin and it seems to work. Or at least it didn't complain about anything. So, apart from the dispose pendingMesh question above (which is sort of a side-thought and doesn't have to be addressed here) this PR is good to go.

There is a checkstyle tab at the very bottom of IntelliJ (probably similar in Eclipse). With it open you can hit a scan button and get just the Checkstyle warnings for that file with clicking them going to the right line. Super handy :)
Yeah IDEs will warn of other stuff too. Most the time that's simple enough and valid but there are definitely places where you'll end up with warnings even with files we'd consider "clean". That's one of the low priority todos to eventually find a better approach to, like how to resolve them and whether to try covering them in the Checkstyle config or similar :)


fix(common): Fixes issue where we couldn't get a backend type

This fixes an issue where if you have a single backend type set, you still would get a None backend type. This meant that unless you explicitly specified a type, it would always resolve to OCI as used by the client.
This takes a middle ground approach that lets people write less toml. If an explicit type is not specified and only one type of config exists for a registry, then the backend type of that single config will be used instead. For more than one, you must specify a default.
Please note that I renamed this from type to default as that term better expresses the intent of what this config is doing. A user isn't specifying the type of config so much as the default backend config to use here in the (currently) unlikely case you have a registry that talks more than one protocol

I'm not sure about this logic change. My intended behavior for resolving backend is:

If local config has a backend_type for the registry, use that (override, not default)
If the registry metadata (well-known url) has an explicit preferred protocol, use that
If the registry metadata has exactly one protocol configured, use that
Default to oci

This PR adds a new case between the first two options:

If local config has exactly one backend configuration for the registry, use that

This means that an implicit "default backend" would override a registry's explicit "preferred protocol", which seems like it could be a problem if a registry wants to switch preferred protocols.

Could you say more about the problem scenario this is trying to fix?

This is solving for the code in resolve_source. That currently works by (using original terminology here):

Fetching registry metadata unless the backend type is set to "local"
If the registry config has a backend_type set, then it uses that backend
If there is no backend type, use the preferred protocol from the registry metadata
If still none, use OCI

Based on how we have the config set up right now, it implies that theoretically, you could have more than one backend type per registry, so the point here was to be able to indicate that there is a preferred backend to use of the choices available. It also assumes that if you have only one item set, you intend for that config to be used for the registry. Let me restate what I think you are saying should be the order here so we can make sure we're on the same page.
The order of precedence for which backend config to use should be:

User specified config
Well known registry metadata
Default

If this is right and we go with the way it currently exists on main with a config that looks like this:
[namespace_registries]
test = "localhost:1234"

[registry."localhost:1234".warg]
config_file = "/a/path"

When resolve_source is called by the client, it will not use the config because there is no backend type set. Instead it will default to OCI. This is what I ran into when I was putting together the config for tests in cargo component. It was trying to make a call to the registry using the OCI client. To make this work with the current code on main, your config would have to be:
[namespace_registries]
test = "localhost:1234"

[registry."localhost:1234"]
type = "warg"

[registry."localhost:1234".warg]
config_file = "/a/path"

That feels redundant if all I have is a single config block for warg and seems like it would be really simple to miss and then have people wonder why their config isn't loading properly. This is why I had it default if there was only a single backend set. I do have a backend config, and it is warg by default since there is only one. This is the key scenario I am trying to fix here
The other use case I am less set on. I don't know if there will be registries that support both warg and OCI simultaneously, but if we are going to have multiple backends (which I assumed was the goal because we have the function that iterates over their types), then there should be a way to specify which one is the default. You can see an example of this in the tests I added. We would probably also need a function that lets you fetch while overriding the choice of backend.
So, with that said, we have a few options here:

Keep what is in main and document that you need to specify type if you are providing a config
Use this PR
Change how the resolve_source function works to match what we actually want loading preference to be (probably iterating over backends instead and checking which one to use)

In the examples and test cases, there is config_file = "/a/path". Is the config_file field used somewhere or just an example property?

That is where the warg config file is loaded from. In the test case, it is just a valid path for testing purposes. In a real config file, that would be pointing to a warg config if it was set


Hard-coded gcc path

When compiling with GPU support, the compiler path is set in the file
//third_party/gpus/crosstool/crosstool_wrapper_is_not_gcc on line 47 to 50:
CPU_COMPILER = ('/usr/bin/gcc')
etc

which can result in using an old version on e.g. clusters where several compilers might be installed under a path such as
/appl/gcc/5.3.0/bin/gcc
It would be nice to be able to configure the compiler path.
Edit: This overlaps with the hard coded paths in other parts of Bazel, see for example bazelbuild/bazel#760

It'd be good to have this as part of configure, but I don't know how awkward it is.  @ebrevdo: Care to comment?

https://github.com/tensorflow/tensorflow/pull/1220 might be relevant

@damienmg any thoughts?

I agree, for now it should probably be part of the ./configure script. With next Bazel realease the new auto-configuration mechanism could replace it.

+1 if we can configure via bazelrc.  Alternatively it would be great if we could set up a symlink or something similar to the way we do python

So what's the status of this.  Should we accept #1220 since that's going the ./configure route, or wait for bazel auto config?

I think you should accept #1220, bazel auto config is going to be in next bazel release but you probably don't want to stick to the latest bazel (and also have it a bit more tested before it goes live).

@vrv: This is fixed by #1220, right?

Yes.


run label missing from _from-orig_to-T1w_mode-image_xfm.txt

Related to #185
Issue due to #188
I have two T1w runs per session, but using poldracklab/smriprep:0.6.0 the resulting xfm file lost the run label (hence, I only have one xfm per session: smriprep/sub-{subject}/ses-{session}/anat/sub-{subject}_ses-{session}_from-orig_to-T1w_mode-image_xfm.txt)

Good catch. I think all of our test cases have been 1 T1w per session.
Fixing this will fix incorrect derivatives while leaving working derivatives alone, so this can be done as a bug-fix.

@fliem, would it be easy for you to test the new niworkflows branch? How do you usually run smriprep?

@oesteban I can confirm that this works as expected.


add addrLine2, 3 to address section

Rewrote the address section to be more readable. The 2nd and 3rd address lines should now be included in the NFR reports

DEV deployments have completed successfully!
Backend available
Frontend available

Your Pull Request code is being promoted!  Please follow the link below.
Main Merge Workflow


Update List to v1 API

I don't think this is a complete solution. I see in the doc examples folder for List that we have a range of types and variations which I have yet to implement. If I could get some friendly feedback and pointers that'd be great especially since this is my first public pull request! Thank you.

[Current coverage][cc-pull] is 88.14%

Merging [#311][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.17%

@@             master       #311   diff @@
==========================================
  Files            62         62
  Lines           822        827     +5
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            726        729     +3
- Misses           96         98     +2
  Partials          0          0

Powered by Codecov. Last updated by [2100627...6c7a3d6][cc-compare]
[cc-base-branch]: https://codecov.io/gh/TechnologyAdvice/stardust/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/TechnologyAdvice/stardust/compare/210062713f217049ac4c94c976c32939cd31dc11...6c7a3d63b3c3e324b511c6a070e6ef4e8d4688b7
[cc-pull]: https://codecov.io/gh/TechnologyAdvice/stardust/pull/311?src=pr

The next big step for this component is to turn the supported SUI HTML classes into a React Component API.  I would reference the work done in #268 which updated the Divider to our v1 API.
This is mostly centered around creating declarative props for component features.  Then, using our propUtils methods (useKey, useValueAndKey, etc) to build up the className.  Again, I'd reference the Divider PR #268.
We have an open issue to add documentation around this process.  I'll go ahead and start that right now.

Please let me know if this last commit was the direction you wanted to take. @levithomason

List API Proposal
The updates made to the <List /> are looking good so I will focus only on the ListItem here.  Items in SUI are a sore spot, your feedback and alternate ideas are much appreciated.
ListItem

The parent ui list was left out of all examples below for brevity.

The current ListItem supports the various list component parts via props (icon, image, header, and description).  Depending on the props used, the proper markup is generated.  This includes the sometimes necessary content div which wraps content adjacent to an icon or image.  See the current source for the ListItem.
In order to support our latest guidelines for markup, we need to consider using sub components for these component parts.  Here's why.
Props for component parts
The advantage to using props is that the JSX is minimal:
<List.Item icon='user' description='John Doe' />

The downside here is that any list item markup beyond that of plain text is awkward to work with.  What if you want a header link with an href, a data attribute on your icon, or p tags in your description?  You have to construct these outside the ListItem then pass them in as props.
Sub components for component parts
The advantage to using sub components is that it is flexible.  This example adds all the difficult markup I just mentioned above:
<List.Item>
  <List.ItemIcon name='user' data-foo='bar'>
  <List.ItemContent>
    <List.ItemHeader href='johndoe.com'>
      John Doe
    </List.ItemHeader>
    <List.ItemDescription>

John Doe is so awesome.

    </List.ItemDescription>
  </List.ItemContent>
</List.Item>

A better sub component naming scheme would be great.

The downside being that it is very verbose.  However, if you need flexibility then this is acceptable.
Supporting both
I'd like to support both of these.  This should be rather simple, actually.
If you have simple markup you can provide icon, image, header, or description props and we'll construct the markup for you.  No children are allowed.  This is what we do now, except we don't disallow children.
If you have intricate markup you may use children and construct it yourself.  No icon, image, header, or description props are allowed.
We have a customPropType called mutuallyExclusive.  It prevents mutually exclusive props from being used together.  We can make the icon, image, header, and description props mutually exclusive with children.
The following examples show both APIs I'm proposing.
Simple Item
<List.Item description='Apples' />
// or
<List.Item>Apples</List.Item>

Apples

Icon or Image
Markup adjacent to an image or icon must be placed in content.
<List.Item icon='users' description='Semantic UI' />
// or
<List.Item>
  <List.ItemIcon name='user' />
  <List.ItemContent>
    Semantic UI
  </List.ItemContent>
</List.Item>

    Semantic UI

Header & Description
Since the description here is more than just plain text, the prop API is not preferred.  I've shown it anyway.
const description = Click a link in our description.
<List.Item header='Header' description={description} />

// or

<List.Item>
  <List.ItemHeader>
    Header
  </List.ItemHeader>
  <List.ItemDescription>
    Click a link in our description.
  </List.ItemDescription>
</List.Item>

  Header

    Click a link in our description.

Image, Header & Description
The example here assumes the avatar class should be added to the image when the image prop is used.  Again, since the description contains more than plain the text, the props API is not ideal here.  It is shown anyway.
const description = (
  Last seen watching Arrested Development just now.
)
<List.Item
  image='daniel.jpg'
  header='Daniel Louise'
  description={description}
/>

// or

<List.Item>
  <List.ItemImage src='daniel.jpg' />
  <List.ItemHeader>Daniel Louise</List.ItemHeader>
  <List.ItemDescription>
    Last seen watching Arrested Development just now.
  </List.ItemDescription>
</List.Item>

      Daniel Louise

Last seen watching Arrested Development just now.

You can see the difficulties in using the props API for markup.  Also, the verboseness but flexibility of the sub component API.  Looking forward to your thoughts.

@levithomason I like this proposal very much. I think the cleanliness of sub-components makes the API more flexible and extensible for end users. I believe there will be ample instances where a user will want to enter a long description, and perhaps even include other components in a description. Passing everything through props alone would be very restrictive and cumbersome in that regard. That said, providing the shorthand format too is an excellent alternative for those opting out of unnecessary verbosity in their code. I think this would be a great step forward for maximizing the usability of our list components.

@levithomason Is it possible to merge List before merging ListItem or do you feel they go hand-in-hand? What still needs to be done in the List component sans ListItem?

I'd like to have the final API for the List and its subcomponents (ListItem) complete before merging. I'll be out today so I'll review this component tomorrow and make a check list of what we need to finish it up.

Okay, sounds good. Happy 4th!

Although I can create ListItem, ListHeader, etc. as subcomponents in the same folder as List (as seems to be described in the doc) this will result in a lot of duplication esp. with the Header component which has 9 files by itself (H1, H2, etc. Subheader). Do you still suggest these as duplicate components under the List directory?

 I'm not positive I took this in the direction you had in mind. The new commit does let you create list items both via sub-components and non-sub which was the primary goal. I also create the content and description elements which I'm not positive you wanted separated as reusable elements; it just seemed in line with the current style, but maybe I'm mistaken. The ItemHeader file is the file I have the biggest questions about both in placement of the file and the overall necessity as a separate file. Additionally, perhaps you were thinking that everything should be named Item* but I think that would lead to a lot of code duplication so I moved my initial commit against that. I'm looking forward to your feedback on this!

Note the List header "component part" does not support different h* tags nor subheader as the SUI "component" does.
SUI "component parts" often do not support nearly as many feature as their "component"  counter parts. Example, a list "header" vs a "ui header". The same is true for the "ui item" vs the list "item".
Though some components share the class "item" or "header", the supported features and markup are often entirely different. Because of this, I don't think we should reuse them between components.
All  said, I'm completely open to better proposals.

In response to your previous comment, what about icon and image? Do you feel those can be reused? Also, do you think placing header into a separate ItemHeader.js file is the way to go, and if it should be its own file, do you think it should be placed under the List directory or the views/Item directory? Thanks.

In response to your previous comment, what about icon and image? Do you feel those can be reused?

The SUI List docs appear to use the same markup as the Icon / Image components, so yes.

Also, do you think placing header into a separate ItemHeader.js file is the way to go, and if it should be its own file, do you think it should be placed under the List directory or the views/Item directory?

Yes, separate file. We have a lint rule that enforces this. It is important to keep one component per file for doc generation as well.
All List subcomponents should go in the List directory. I can see the reason for asking this since the name is ItemHeader. We may end up renaming things a bit once this is all laid out.
Please forgive the brevity and any  typos as I am on mobile. Thanks for all the work so far!

Do we put separate examples of using the component markup in the docs?

Do we put separate examples of using the component markup in the docs?

Which markup are you referring to here?

Which markup are you referring to here?

Examples of using the sub-component markup versus using regular props.

Ah, yes please.  You can reference the Accordion docs where I documented the same type of API options.  I've given examples of both the sub component markup and the props for markup.  I've also included docs in the props descriptions for this.

Regarding reuse of "component parts", I did some more thorough analysis of the header component part and here is what I'm thinking.
Header "Component Parts"
Looking at every component that supports the header part (not the ui header component), what is the common denominator and how can we effectively reuse this?  I've also linked the SUI docs for each.
Card Header

wrapped in content when sibling to icon

header class
can be an a tag

Dropdown Header

Does not directly support a header only by the fact that its component parts do.

as .dropdown > .menu > .header
as .dropdown > .message > .header

Item Header

always wrapped in content, even with no image sibling

header class
can be an a tag

List Header

wrapped in content when sibling to icon/image

header class
can be an a tag

Menu Header

never wrapped in content, never has sibling icon/image

header class (in an item)
header item class (as an item)
can be an a tag, not documented but valid (header as an link item)

Message Header

wrapped in content when sibling to icon/image

header class
a tag not documented, but valid

Modal Header

header class
a tag not documented, but does not pose an issue

Conclusion
Common: header class, can be an a tag
Unique: item class (Menu)
Proposal
How about we create a src/parts directory and begin reusable "component parts" there?  The "component parts" will include only common denominator functionality and props. Individual components can then extend as needed.  Example:
// src/parts/HeaderPart.js

function HeaderPart() {
  // support "header" class, href/onClick, `a` tag
}

// src/collections/Menu/MenuHeader.js
import HeaderPart from 'src/parts/HeaderPart'

function MenuHeader() {
  // render HeaderPart adding the "item" class when necessary
}

We would then do the same for content, meta, description, extra, etc.  If this seems sane, I can start on these "parts" and get the baseline going.
Thoughts?
/cc @jamiehill would love your input here as well.

I agree that this needs standardising.  My initial thinking was that the extra functionality required by varying components should be baked into Header it's self, but on second thoughts would pollute the logic trying to cater for different edge cases.
There seems to be some merit in maintaining the abstraction of using Header though.   Would it not be convenient to be able to utilize the Header sub comps:
<Card>
   <Card.Header.H1>Large Card Header</Card.Header.H1>
</Card>

If we abstract the core header logic into a separate component part, we can indeed then still composite variations, for prescribing components, using additional header component parts.  I think the key here is that we don't want to expose not pertinent props on Header, but still use a decorated version of it in other components?

I'm with you.  There's just too much variation between "components" and "component parts" to standardize completely.
I've moved this conversation to "Standardize Component Parts" #325.  You'll find a more thorough analysis and updated proposal there.  Feedback welcome.

@joshuazmiller it looks like this PR has gotten stale.  If you add me as a collaborator to your fork, I can help update it and get it merged.  LMK what your plans are.

Are there any activity? I can start over it on the weekend.

This one is open game IMO.  It might be worth starting from scratch and just copying over the relevant files.  The merge conflicts would be crazy otherwise.

I'm opened #551, seems we can close this PR.


bun: Add auto-updater script

Description of changes
Adds an auto-updater to the Bun package. Fixes https://github.com/NixOS/nixpkgs/issues/191784

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/add-auto-update-script-to-bun/21793/4

Also the commit message should start with the package name followed by colon as per the contributing guidelines.

Quick question, what is the equivalent of "cut"? It doesn't seem to be a package. FWIW, I'm trying to remove the first 5 letters from a string.

It is part of the coreutils package. Or you can just do it in jq with https://stedolan.github.io/jq/manual/#Array/StringSlice:.[10:15]

Thank you for all the help!


Web client

Atop #1801, #1802.
Motivation
The client half of https://github.com/linera-io/linera-protocol/issues/1609.

Proposal
When compiling with web, replace our existing gRPC client with a Wasm-compatible gRPC-Web–based client using tonic-web-wasm-client.
Since browser objects are neither Send nor Sync, a large part of this work is then to enable non–Send equivalents of various traits for structs containing non–Send objects.  linera-core in particular now never assumes that the client struct is Send.  linera-service, however, does.  In order to enable this, I have used trait-variant to construct, as automatically as possible, local and non-local variants of relevant traits.
Task list:

[x] convert relevant traits to use AFIT and trait-variant
[x] relax the Sendness bound that permeates linera-core and linera-rpc
[x] implement a gRPC-Web client when compiling for the browser
[x] deduplicate the implementations for the Web and non–Web clients
[x] add tests in which the Wasm client connects to the gRPC-Web endpoint implemented in https://github.com/linera-io/linera-protocol/pull/1735

Test Plan
As part of this PR, I shall add tests to be run in a headless browser using wasm-pack test.
Due to https://github.com/linera-io/linera-protocol/issues/1799 and https://github.com/linera-io/linera-protocol/issues/1800 these are not currently part of the standard test cargo test test suite, but can be run manually:
$ eval "$(linera net helper)"
$ linera_spawn_and_read_wallet_variables linera net up
$ cd linera-rpc
$ wasm-pack test --chrome --headless --features web -- --include-ignored

The above assumes you are using the provided Nix flake for a development environment; if not, first you will need to install wasm-pack, chromium, and chromedriver through your usual package distribution channels.  Tests also pass on Firefox, if you have Firefox installed — substitute --firefox for --chrome above.

Release Plan

Need to bump the major/minor version number in the next release of the crates.

Links

Closes #1609.
reviewer checklist

Remaining nits should be addressed by https://github.com/linera-io/linera-protocol/pull/1821 — so I'm going to go ahead and merge this one for now :)


Added SKLearn-like random forest API.

I've updated the classes; they now use mixins and multiple inheritance.


Getting a 404 Not found when accessing /domains/*/records

Hi!
Just set up a shiny new instance of Ackee but it doesn't work at all, I get a 404 Error when the ackee client tries to report to the server.
https://i.imgur.com/VA6RiZu.png
Took a look a the app routes and found that they were removed, perhaps it's the root cause of this issue?
https://github.com/electerious/Ackee/commit/d9621ae5ea4949072aa6ca51fdf4b14ab10fb0ec#diff-e6a5b42b2f7a26c840607370aed5301a

Oh I just forgot to update ackee client, problem solved ^^


🚀 Feature: Allow decimal numbers in Gauge component

🔖 Feature description
In the Gauge component, the large number in the middle should be able to display decimal numbers, such as "5.5".
🎤 Context
In my use-case, I want to display a value between 0 and 10. While the fill percentage of the circle is calculated correctly (5.5/10 yields 55% filling), the value displayed is rounded to 6, which is not acceptable for me.
✌ Possible Implementation
The displayed value is rounded when the maximum is not 100 (see https://github.com/backstage/backstage/blob/master/packages/core-components/src/components/ProgressBars/Gauge.tsx#L138). Since I do not know the intention behind that, I will keep this behavior.
I plan to add a new parameter ("decimalDigits" or the like), which I can set to 1 for my use-case (to yield "5.5" or "7.0"). If it is not set, the old behavior will be used to be backwards compatible.
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!
### Tasks
- [x] Implementation
- [ ] Documentation

fixed!


Exclude links from tracking

Allow to  exclude links from being tracked by adding a class "do-not-track", as sometimes this script breaks image gallery scripts or other javascripts that prevent the default click behaviour.

Thanks!


Multiselect is not visible

Hello. I'm pretty lame to frontend development, maybe there is a simple solution to my problem.
I'm using Vuexy VueJS 2.x template in my app. After adding Multiselect, I see it present in DOM, but not visible at all.
vue-multiselect version: "^2.1.7"
vue version: "2.6.12"
Steps to reproduce
Component:
<template>
  <section id="main" class="section-main">
    <multiselect v-model="selectedAdgroups" :options="adgroupSelectOptions">
    </multiselect>
  </section>
</template>
<script>
import Multiselect from 'vue-multiselect';

export default {
  components: {
    Multiselect
  },
  data() {

    return {
      adgroupSelectOptions: ['1', '2', '3']
      selectedAdgroups: null,  // for multiple choice
    }
  },
  computed: {},
  methods: {},

}
</script>

<style src="vue-multiselect/dist/vue-multiselect.min.css"></style>

Expected behaviour
Working multiselect
Actual behaviour

Styles:

+1

Have you solved it yet

@caoshunshu unfortunately, no. I’m out if ideas, that’s why I asked my question here

@MasterGroosha Reduced version  "vue-multiselect": "^2.1.0",

@MasterGroosha I'm facing the same issue. In my case it is running in Dev but not in Prod. Let me know if reducing version to 2.1.0 works for you.

I've put this in a js fiddle running Vue 2.7.9, and this is working fine: https://jsfiddle.net/mattelen/9x4Lgaw3/1/
I set it running Vue 2.6.12, and I'm then able to reproduce the issue: https://jsfiddle.net/mattelen/9x4Lgaw3/2/
Therefore I think that you will need to upgrade to Vue 2.7 to use the multiselect, as this is the latest Vue 2 version, and the migration path from 2.6 to 2.7 is very easy: https://v2.vuejs.org/v2/guide/migration-vue-2-7.html

For anyone else looking at this, it works just fine if you require the officially required minimum version of Vue 2.6.14, we were on 2.6.10 and it doesn't work but switching our project to 2.6.14 worked fine.


After git pull, it broke

I used agent mode, after doing pull
Discord wasn't showing apple music
So i did "./music-rpc.ts"
and terminal gave this
error: TS2420 [ERROR]: Class 'NamedPipe' incorrectly implements interface 'Conn'.
Type 'NamedPipe' is missing the following properties from type 'Conn': readable, writable
export class NamedPipe implements Deno.Conn {
~~~~~~~~~
at https://deno.land/x/namedpipe@0.0.3/src/client.ts:27:14
TS2739 [ERROR]: Type 'NamedPipe' is missing the following properties from type 'Conn': readable, writable
return await connect(path);
~~~~~~~~~~~~~~~~~~~~~~~~~~~
at https://raw.githubusercontent.com/harmonyland/discord_rpc/1d41f3c830a66d4f2699774bc3ec5b44cceb3a46/src/util.ts:33:7
Found 2 errors.
bc i was upgrading from the old npm method
so i did remove the whole folder and tried again, still output this
any ideas?

Oh nevermind, I can reproduce the error, I will investigate it

I temporarily fixed the issue in the latest commit eb3b5902771dea31d903bf70eb546d85d893acf0

Thanks, I'll get it and hope this get figured out
I like your work, thanks for make it happened 👍

You can now upgrade discord_rpc to 0.3.0 to fix the issue than using fork


Git directory structure

I think we should put Git on the main directory where the .README file exists. so that when users come to the repo get a gist of the project and can read the DOCS we want them to read.
so instead of going to /app/exerlog user sees the project after cloning the project. notice that we clone a repo it automatically will be extracted within a directory with the same name as the repo name
and also it would be great to add a explicit steps to run the app for the sake of running the app easier; so that they can follow the process of installation based on a guide.

Great idea I think this is being dealt with or will be dealt with after #10

PR #56 fixes this. Please merge if possible.


Sync C# cubic interpolation with core

Updates the C# implementation of cubic interpolation methods (mostly in Quaternion) with the latest changes implemented in core to keep C# in sync.
Included changes

Add missing check in Quaternion.Slerpni
Fix Transform3D interpolation and add spherical interpolation (Follow up to #53684)
Add GetAngle and GetAxis to Quaternion (Follow up to #54050 and #57675)
Add Exp and Log to Quaternion (Follow up to #57675 and #64678)
Fix Quaternion.CubicSlerp (Follow up to #63380)
Rename and fix Quaternion.SphericalCubicInterpolate (Follow up to #63532 and #63593)
Add CubicInterpolateInTime (Follow up to #63602)
Add CubicInterpolateAngle (Follow up to #64924)

I made separate commits for each core PR but I can squash them if that's not useful.
TODO

[ ] Add missing documentation or leave for a separate PR? Note that core methods are not documented either so it'd be nice to document them too.

Add missing documentation or leave for a separate PR? Note that core methods are not documented either so it'd be nice to document them too.

Depends how much the non-generated C# documentation follows the core documentation. If the summary tends to be the same, then it may be worth waiting for the core one to be documented first.

Depends how much the non-generated C# documentation follows the core documentation. If the summary tends to be the same, then it may be worth waiting for the core one to be documented first.

It tends to be the same, at least for these interpolation methods.

Thanks!


This could be easily bypassed

Since u r using x-forwarded-for header and headers can of course be modified, creating random ip addresses and sending them through x-forwarded-for is possible...

you could just as well use a VPN and avoid any detection altogether. I think the point is to provide an easy to use filter that blocks most "common" web traffic.

using a VPN you have the same problem as using proxy... u get only one IP, if you use multiples proxys then get multiples IP's but still limited, but using x-forwarded-for and random ip addresses, u have all the ip's u want... so "using a VPN" is not as evil as the method i described, i'm talking for example of scenarios like form automation, web scrapping and more...

@carloslopez1990 I am working on a new version that will make forwarded IPs disabled by default and only if you enable them will they then be used. This goes for CloudFlare and Codio as well.

Please see https://github.com/baminteractive/express-ipfilter/pull/26 for the change.


Collect more security related data

Like firewall, firmware password, automatic login, antivirus installed...

Closing this, too long open and no clear solution.

See PR #582 for firmware password status.


sandbox: add event monitor for podsandbox controller

Currently the podsandbox controller has to get event monitor from CRI plugin, that makes the podsandbox controller dependent on the CRI plugin, this PR decouples it by create a event monitor for podsandbox controller independently.

/needs-rebase

needs to rebase after #9463 is merged

/cc @mxpv @fuweid

needs-rebase after #9617 is merged

As https://github.com/containerd/containerd/pull/9617 is merged, this PR is rebased now, could you please take a look at it again? @fuweid @mxpv

Will take a look in two days. Thanks!

@fuweid PTAL

/retest


Timeout for a ping()

ping() should complete with an error after 30s from sending a request if no response from peer client has been received.

@llbartekll Still an issue?

yes

Not required


Add whitespace settings to .editorconfig

This ensures consistency within the project.
I set indents to tabs. If you prefer we use spaces, that's fine. I just want it to be consistent.

Thanks!


Add option to ignore prereleases?

I use prerelease tags when I deploy to stage, and normal tags when deploying to production.
In my releases I only want the normal tags to be there, and the changelog should also consider the last normal tag and ignore any prerelease tags.
Eg.

release v1.0.0
prerelease v1.1.0-0 (ignored)
prerelease v1.1.0-1 (ignored)
release v1.1.0

And changelog should generated should be b/w v1.0.0 and v1.1.0

I think you can use TAG_REGEX to filter it out? Something like this would work /^[0-9]+.[0-9]+.[0-9]+$/

I guess that would work, I'm no longer actively using gitlab and can't test it out so I'll close this issue.

@rohit-gohri I feel you man. The reason I stopped updating this repo is because I have moved of gitlab as well. Gitlab is just too unstable..We experienced major outage when we were using it almost every 2-3 months

@jk1z That's sad to hear. For me it was because I changed my job


VCE_MODIFIED_FOREGROUND not applied to text

I have put the following configuration in my zshrc:
POWERLEVEL9K_VCS_MODIFIED_FOREGROUND='red'
It seems the red color is only applied to the icon of the segment, but not to the part after it.
A picture might make this clearer:

I would expect the entire foreground to be modified.

Good catch! I'll have a look on that.

Fixed in next by merge of #214.


Ability to configure the default log level from VS Code

Ability to configure the default log level from VS Code

To verify:

F1 > Set Log Level...
Set the default log level using the action available on the log level.
Make sure the default log level is updated and also the current log level if the current log level is not default log level
4 Restart VS Code and make sure the default log level is updated.
Try 2-5 steps for updating the default log level of extensions

@sandy081 would the double checkmark (check-all) be a better icon for this?

Yeah, will change the icon.


ly does not start

ly does not start on any tty, i have to manually start it by typing ly , after it starts it shows this message: failed to access console.

@ramezhammad You should report the version of ly you tried, along with your operating system name and version. Also, confirm if you are using systemd or another init system. Did you install  ly from a package or some other way?

@ramezhammad You should report the version of ly you tried, along with your operating system name and version. Also, confirm if you are using systemd or another init system. Did you install  ly from a package or some other way?

Version of ly: latest version
OS: Fedora 33
init system: systemd
ly compiled from source

Version of ly: latest version
OS: Fedora 33
init system: systemd
ly compiled from source

Do you see errors in the system journal after  it fails to automatically start using journalctl ?

Do you see errors in the system journal after  it fails to automatically start using journalctl ?

i fixed it by uninstalling and reinstalling ly and the dependencies and updating my system.

i fixed it by uninstalling and reinstalling ly and the dependencies and updating my system.


way to save configuration

Say my-app loaded its config, then the user input some command like my-app config set X=Y
Now my-app wants to save the updated config
It seems that currently my-app would need to act on Result.filepath, so it needs to check if it's a package.json or some other file and write all the update logic itself
Would be nice to have a function to update the found config file

You can't really have broad format compatibility and writing support. For example, how would you even start trying to write to a potentially infinitely complex .js file?
I'd recommend a more specialized package like conf, which completely abstracts away the storage, if you need to support writing back to your configuration.


cigien: Watch thewebfactory.us

cigien requests the watch of the watch_keyword thewebfactory\.us. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

thewebfactory\.us has been seen in 1 true positive, 0 false positives, and 0 NAAs.

thewebfactory\.us has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Zoe in Charcoal HQ

Approved by Zoe in Charcoal HQ


Ticket Creation

Here with another question. Trying to create a ticket, but keep getting error
AttributeError("'dict' object has no attribute '__dict__'")
Below is my code. Thanks again for all the help so far :)
def createStafftopBlockTicket():     ct = tickets_api.TicketsAPI(url=cw.cwURL, auth=cw.cwAUTH)     ticketInfo = {         "summary": "This is a test of the API broadcast system",         "company": {             "id":"company_id"         },         "board": {             "name": "board_name"         },         "resources": "resource_to_assign"     }     print(ticketInfo)     ct = ct.create_ticket(ticketInfo)

Hey @nyteghost,
the quick answer is that on the line where you assign a dict to variable ticketInfo  has a couple of issues, but are easily fixed.
The create_ticket api requires you provide a Ticket object rather than a dict object.  But you had the right idea as you'll see in the solution below.
Here are two examples of the setup for a new ticket.  Use the approach you like best. Hope this helps.
from connectpyse.service import tickets_api, ticket

company_id = 45 #the id of the company
board_id = 2 #the id of the board
summary = 'magical ticket creation tests'
resources = 'johnTheTech'  #should match a cw username
url = ''
auth = ''

def add_ticket_using_dot_notation():
	ticket = ticket.Ticket()
	ticket.company = company_id
	ticket.board = board_id
	ticket.summary = summary
	ticket.resources = resources

	ct = tickets_api.TicketsAPI(url=url, auth=auth)
	new_ticket = ct.create_ticket(ticket)

def add_ticket_using_dict():
	ticket = ticket.Ticket(json_dict={
             "company":company_id,
             "board":board_id,
             "summary":summary,
             "resources":resources })

	ct = tickets_api.TicketsAPI(url=url, auth=auth)
	new_ticket = ct.create_ticket(ticket)

Where are you getting  ticket.Ticket from?

Never mind I see where. for some reason mine is not working when i do it your way, but i have to change ticket to newTicket like below.
newTicket = ticket.Ticket(json_dict={
"company":company_id,
"board":board_name,
"summary":summary,
"resources":resources })
but when i try and use either one i get
AttributeError: 'str' object has no attribute 'keys'

That seemed to have worked mostly. The problem I am having is the resources is not assigning though. Not sure why?

I guessed on that one.  In the ticket object, it’s defined as a string, so I assumed member user name.  Need to probably check the CW dev site for confirmation.
Another approach you can try is setting “owner” to a member id.  That would give that member ownership.
From: nyteghost @.>
Reply-To: markciecior/ConnectPyse @.>
Date: Thursday, January 27, 2022 at 4:45 PM
To: markciecior/ConnectPyse @.>
Cc: cocoaev @.>, Mention @.***>
Subject: Re: [markciecior/ConnectPyse] Ticket Creation (Issue #21)
That seemed to have worked mostly. The problem I am having is the resources is not assigning though. Not sure why?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: @.***>

Hey @nyteghost,
my apologies, I should have tested that code before providing it. Added in corrections and tested both approaches.
here is a working example of creating a ticket using the json object and fields you wanted and with setting ownership to a specific member.
Here is a link to :  CW Service Ticket API
def add_ticket_using_dict():
	company_id = 19297 #the id of the company
	board_id = 87 #the id of the board
	summary = 'magical ticket creation tests 2'
	memberid = 269

	api = tickets_api.TicketsAPI(url=BASE_URL, auth=AUTH)

	#create ticket object
	ticket_obj = ticket.Ticket(json_dict={"company": {"id":company_id},
		"board":{"id":board_id},
		"summary":summary,
		"owner": {"id":memberid}})
	new_ticket = api.create_ticket(ticket_obj)
	return new_ticket

Here is an example that works using the dot notation:
def add_ticket_using_dot_notation():
	company_id = 19297 #the id of the company
	board_id = 87 #the id of the board
	summary = 'magical ticket creation tests'
	memberid = 269
	#create the ticket object and pre-populate fields
	t = ticket.Ticket()
	t.company = {"id":company_id}
	t.board = {"id":board_id}
	t.owner = {"id":memberid}
	t.summary = summary

	#call CW to create a ticket using the data in your previously created ticket object
	api = tickets_api.TicketsAPI(url=BASE_URL, auth=AUTH)
	new_ticket = api.create_ticket(t)
	return new_ticket

In terms of adding resources to a ticket - you cannot do it at ticket creation, at least I couldn't find a way to do so.  I believe first you create a ticket, then add a schedule entry to it.  Here is an example of how to do that:
def add_schedule_to_ticket(ticketId):
	api = schedule_entries_api.ScheduleEntriesAPI(url=BASE_URL, auth=AUTH)
	sch = schedule_entry.ScheduleEntry()
	sch.member = {"id":269}
	sch.objectId = ticketId
	sch.type = {"id":4}  #find these here: https://cwapi/v4_6_release/apis/3.0/schedule/types
	new_sch = api.create_schedule_entry(sch)
	return new_sch

sch = add_schedule_to_ticket(1196184)

Hope this helps you get this sorted.


AMBARI-24587. Livy2 fails to restart

Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/stacks/HDP/3.0/services/SPARK2/package/scripts/livy2_server.py", line 148, in
LivyServer().execute()
File "/usr/lib/ambari-agent/lib/resource_management/libraries/script/script.py", line 351, in execute
method(env)
File "/var/lib/ambari-agent/cache/stacks/HDP/3.0/services/SPARK2/package/scripts/livy2_server.py", line 62, in start
self.configure(env)
File "/var/lib/ambari-agent/cache/stacks/HDP/3.0/services/SPARK2/package/scripts/livy2_server.py", line 52, in configure
setup_livy(env, 'server', upgrade_type=upgrade_type, action = 'config')
File "/var/lib/ambari-agent/cache/stacks/HDP/3.0/services/SPARK2/package/scripts/setup_livy2.py", line 53, in setup_livy
params.HdfsResource(None, action="execute")
File "/usr/lib/ambari-agent/lib/resource_management/core/base.py", line 166, in init
self.env.run()
File "/usr/lib/ambari-agent/lib/resource_management/core/environment.py", line 160, in run
self.run_action(resource, action)
File "/usr/lib/ambari-agent/lib/resource_management/core/environment.py", line 124, in run_action
provider_action()
File "/usr/lib/ambari-agent/lib/resource_management/libraries/providers/hdfs_resource.py", line 681, in action_execute
self.get_hdfs_resource_executor().action_execute(self)
File "/usr/lib/ambari-agent/lib/resource_management/libraries/providers/hdfs_resource.py", line 164, in action_execute
logoutput=logoutput,
File "/usr/lib/ambari-agent/lib/resource_management/core/base.py", line 166, in init
self.env.run()
File "/usr/lib/ambari-agent/lib/resource_management/core/environment.py", line 160, in run
self.run_action(resource, action)
File "/usr/lib/ambari-agent/lib/resource_management/core/environment.py", line 124, in run_action
provider_action()
File "/usr/lib/ambari-agent/lib/resource_management/core/providers/system.py", line 263, in action_run
returns=self.resource.returns)
File "/usr/lib/ambari-agent/lib/resource_management/core/shell.py", line 72, in inner
result = function(command, **kwargs)
File "/usr/lib/ambari-agent/lib/resource_management/core/shell.py", line 102, in checked_call
tries=tries, try_sleep=try_sleep, timeout_kill_strategy=timeout_kill_strategy, returns=returns)
File "/usr/lib/ambari-agent/lib/resource_management/core/shell.py", line 150, in _call_wrapper
result = _call(command, **kwargs_copy)
File "/usr/lib/ambari-agent/lib/resource_management/core/shell.py", line 314, in _call
raise ExecutionFailed(err_msg, code, out, err)
resource_management.core.exceptions.ExecutionFailed: Execution of 'hadoop --config /usr/hdp/<IP_ADDRESS>-175/hadoop/conf jar /var/lib/ambari-agent/lib/fast-hdfs-resource.jar /var/lib/ambari-agent/tmp/hdfs_resources_1535895647.58.json' returned 1. Initializing filesystem uri: hdfs://mycluster
Creating: Resource [source=null<EMAIL_ADDRESS>type=directory, action=create, owner=livy, group=null, mode=700, recursiveChown=false, recursiveChmod=false, changePermissionforParents=false, manageIfExists=true] in hdfs://mycluster
Exception occurred, Reason: Wrong FS<EMAIL_ADDRESS>expected: hdfs://mycluster
java.lang.IllegalArgumentException: Wrong FS<EMAIL_ADDRESS>expected: hdfs://mycluster
at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:781)
at org.apache.hadoop.hdfs.DistributedFileSystem.getPathName(DistributedFileSystem.java:240)
at org.apache.hadoop.hdfs.DistributedFileSystem$29.doCall(DistributedFileSystem.java:1583)
at org.apache.hadoop.hdfs.DistributedFileSystem$29.doCall(DistributedFileSystem.java:1580)
at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
at org.apache.hadoop.hdfs.DistributedFileSystem.getFileStatus(DistributedFileSystem.java:1595)
at org.apache.hadoop.fs.FileSystem.isFile(FileSystem.java:1768)
at org.apache.ambari.fast_hdfs_resource.Resource.checkResourceParameters(Resource.java:193)
at org.apache.ambari.fast_hdfs_resource.Runner.main(Runner.java:112)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.hadoop.util.RunJar.run(RunJar.java:318)
at org.apache.hadoop.util.RunJar.main(RunJar.java:232)

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3823/
Test PASSed.


RAINCATCH-539 - module boundaries for file module

Motivation
Remove stale templates and source code that was moved to file module.

LGTM


Exporting to multiple target Azure Storage Accounts?

Is it possible to have bc2adls export to multiple Storage Accounts, or deploy it multiple times to the same BC environment with each deployment pointing at a different target Storage Account?

Hi @Bertverbeek4PS, thanks so much for the quick response.
Our scenario is that we're in a transitional period after being acquired and while we had bc2adls working fine pre-acquisition, outputting to our chosen Storage Account and then being processed from there into our Data Warehouse, we now need to output the same data in parallel to a Storage Account owned by the acquiring business, so they can begin ingesting the same source data into their Data Warehouse.
If there's no way to do this with bc2adls itself then we'll have to instead put another process in place to copy the data from one location to the other, which is not a big problem, but just requires a few more things to move at our end, so we wanted to check first there was not some easier solution.

Hi @x3N1GM4x no sorry. In bc2adls there is no support of to multiple storage accounts.
I think it is easier to just copy the data in the pipeline that is already there.
So at the final stage in the pipeline you will store it in your own storage account and the one owned by the acquiring business.


Invalidate search result cache after write operations

Coverage decreased (-0.005%) to 95.183% when pulling 33acc638d8d9283acff5bcdf7a7d55aba6961672 on cody-invalidate-searches-on-updates into c2e8d051a7cc3b3278766f46443556af4b7801c6 on main.


Can't Link Anaconda Install Mac OS UE4.21

Hello, just want to start off by saying this is really a fantastic plugin you have put together here.
I have it working for my default install of Python, however for packaging purposes I'm trying to link a portable version of Python with pre-installed libraries from the UE4 project folder.  The install I have there is Anacondas which I have successfully linked in Sublime text, but for whatever reason when I try using that address in the build.cs for UnrealEnginePython which the terminal gives from 'which anaconda', XCode returns a build error 'Unable to find Python installation'.  I'm sure I'm missing something really simple here, but it seems like it should be working.  Thanks for your help.

Nevermind, I made a dumb mistake.  I realized that in the build.cs all of the linked files were pointing to the executable where as Sublime Text was linking to the bin folder, so for Anaconda it actually has a package which you have to explicitly show the contents to in order to find the executable.  Everything seems to be working now.

I thought I figured it out but I didn't.