@continue and @break directives not highlighted

Seems like the @continue and @break Blade directives for loops added in 5.2 aren't supported?

These directives are supported.

Yes, those work, I was talking about the one-line functionality:

@paulhbarker Yes i got it. Going to make a PR for that.
Fixed preview


fix host name at the reverse proxy by explicilty setting hostname bot…

At ReverseProxy, HTTP Header value for Host is not set properly (instead contains the hostname of the token-refresher).
With this problem, The local tests would pass as both the source and host to proxy are both 'localhost'.
This problem can be reproduced when the host to proxy to is different from the the host the token-refresher runs.
This fix require explicitly setting the hostname as part of HttpRequest at the ReverseProxy.
Checkout reference to this problem here

Ooops! removed not used functions..

Ooops! removed not used functions..

:rocket:

:rocket:


Failed to install imagededup on linux using pip install imagededup

Hi,
I got the following errors:
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
daal4py 2021.3.0 requires daal==2021.2.3, which is not installed.
scikit-image 0.18.3 requires PyWavelets>=1.1.1, but you have pywavelets 1.0.3 which is incompatible.
pyerfa 2.0.0 requires numpy>=1.17, but you have numpy 1.16.6 which is incompatible.
pandas 1.3.4 requires numpy>=1.17.3, but you have numpy 1.16.6 which is incompatible.
numba 0.54.1 requires numpy<1.21,>=1.17, but you have numpy 1.16.6 which is incompatible.
bokeh 2.4.1 requires pillow>=7.1.0, but you have pillow 6.2.2 which is incompatible.
astropy 4.3.1 requires numpy>=1.17, but you have numpy 1.16.6 which is incompatible.
Any idea, help?
Thanks

I`m facing the same issue :(

Hi,
We solved using the following settings:
git clone https://github.com/idealo/imagededup.git
cd imagededup
python -m venv venv
source ./venv/bin/activate
pip install -r requirements.txt
pip install "cython>=0.29"
python setup.py install

It seems it works for me

hey please try again we just updated pypi


[Bug]: Balloon bunki anim only shows on left turns

As mentioned on discord, the balloon bunki anim only ever seems to display on left turns, turning right shows no anim - if you use freecam and turn the camera around you can see the balloons did show though, but spawned above where the left turn would be :/
Pretty odd since the game uses the same code to flip the model to the right side as the other anims, doesn't seem to be skipping that code or anything, so not sure why it wouldn't work properly.
Strangely I'm like 95% sure I saw the balloons on the right side once or twice before, can remember they looked inverted at one point at least -- which was an issue with right side anims before -- haven't been able to make it happen again yet though.
Possible it might only work on some certain stage, maybe one of the stages has the right-side bunki position just at the right spot where the model-flip lets it work.
(tested reverse courses but no luck with them)
Might be useful to check other ports and see if right-side balloons ever show on them.

I played on 2/2SP (PS2) and couldn't get the balloons to spawn on the right side either. I briefly looked for footage and couldn't find any there either. I'm wondering if it was ever working as intended.


Angular 6 CLI does not copy library's assets folder into dist folder.

Versions
Angular CLI: 6.0.7
Node: 9.3.0
OS: darwin x64
Angular: 6.0.3
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.6.7
@angular-devkit/build-angular      0.6.7
@angular-devkit/build-ng-packagr   0.6.7
@angular-devkit/build-optimizer    0.6.7
@angular-devkit/core               0.6.7
@angular-devkit/schematics         0.6.7
@angular/cdk                       6.2.0
@angular/cli                       6.0.7
@angular/material                  6.2.0
@ngtools/json-schema               1.1.0
@ngtools/webpack                   6.0.7
@schematics/angular                0.6.7
@schematics/update                 0.6.7
ng-packagr                         3.0.0
rxjs                               6.2.0
typescript                         2.7.2
webpack                            4.8.3

Repro steps

Create a library @acme/lib1 using ng generate library @acme/lib1
Create assets folder under projects/acme/lib1/assets and add images
Add a "projects" -> "@acme/lib1" -> "architect" -> "build" -> "options" -> "assets" key to the library's config within angular.json file.
Build library using ng build @acme/lib1
Fail error should show and none of the assets will be copied to dist folder.

Observed behavior
Upon building & packaging an Angular 6 library e.g. @acme/lib1 using ng build @acme/lib1, the Angular CLI does not copy the library's assets into the dist/acme/lib1/assets folder. This happens also when using the --prod flag.
The CLI seems to only support copying the root app's assets but not library specific assets.
When trying to add "assets": ["src/assets"] to project @acme/lib1 within angular.json, the following error appears in the command line:

Schema validation failed with the following errors: Data path "" should NOT have additional properties(assets).

When creating the following custom rule to copying the files on ng build:
 "assets": [
    "src/favicon.ico",
    "src/assets",
     { "glob": "**/*", "input": "src/assets", "output": "../acme/lib1/assets/" }
],

I get the following error:

An asset cannot be written to a location outside of the output path.

While it is possible to work around this issue using other command line tools/scripts, it will be more consistent to add support for library's assets copy as well.
Desired behavior

Use Case
Very often libraries include image files, icons, css files and other static files which are needed to be distrubted with the package.
What would like to see implemented?
Add ability to define a library specific assets property within angular.json.
Example -
"@acme/lib1": {
      "root": "projects/acme/lib1",
      "sourceRoot": "projects/acme/lib1/src",
      "projectType": "library",
      "prefix": "lib",
      "architect": {
        "build": {
          "builder": "@angular-devkit/build-ng-packagr:build",
          "options": {
            "tsConfig": "projects/acme/lib1/tsconfig.lib.json",
            "project": "projects/acme/lib1r/ng-package.json",
            "assets": [ // <--------- this is currently not supported
              "src/assets"
            ]
          },
  ...}

What did you expect to see?
Project's specific assets should be copied from projects/acme/lib1/src/assets into dist/acme/lib1/assets.
Mention any other details that might be useful (optional)

Glad to see I'm not the only one with this problem.

This is currently expected behavior from ng-packagr, which powers the library packaging process in the the cli. The current suggestion is to copy manually after the build. I've heard mention that they will be addressing this in the future though.
See https://github.com/dherges/ng-packagr/issues/123#issuecomment-330029214

@lammers Could you expand on your answer please, where does this need to go for this to work?

@lammers I don't see how that would work, build-ng-packagr schema being like so :
{
  "title": "ng-packagr Target",
  "description": "ng-packagr target options for Build Architect.",
  "type": "object",
  "properties": {
    "project": {
      "type": "string",
      "description": "The file path of the package.json for distribution via npm."
    },
    "tsConfig": {
      "type": "string",
      "description": "The file path of the TypeScript configuration file."
    }
  },
  "additionalProperties": false,
  "required": [
    "project"
  ]
}

ok .. I just recognized that my scenario is different .. my assets are in the main project and are copied with the configuration above for the karma tests of the library project.

Having the same problem. Please let us know how to fix, or when a fix is in?

It's not currently supported @bmhumadi https://github.com/angular/angular-cli/issues/11317

we need support for this also!

I’m working on a big project, big enough that we were considering using nrwl also but the effort required to get our dozens of libraries setup to handle asserts correctly is a big hold up for the project.
I would love to see a simpler integration for assets as well.

Thanks For the update. I have some solution for assets/resources and release cycle as well https://github.com/SAP/angular-metaui that I am using right now, its not perfect but better than nothing;-)  Hopefully they will add in the next release or so.

Just to add another use case for this feature: when publishing a module to a private VSTS npm feed, it's required that the module include a .npmrc file at the root of the module that points to VSTS registry.  Since this file doesn't get copied into the dist directory, the file must be manually copied after each build before publishing.  This is a bit of a pain!

Why is this still not resolved?? Angular 6 not displaying assets,images after --prod build???? works fine locally! Finally ready for deploy and assets are not rendering at firebase after my ng build --prod?  All my other projects have worked in the past and I missing something in the latest version?

@bniedermeyer my current work around looks like it needs to change with every CLI update? No other project or version has ever been a problem with assets? I'm not having a go, but what you are saying is with this latest update I need to do more to work around this in order to render my assets? shouldn't it be getting simpler/easier?  Why isn't the current version including the assets folder within dist automatically? it has in the past right?
What do you mean when you say manually copy the assets to the build destination with a post build step? input - output like this? I have tried and not working. Have you got an example?
"assets": [
{ "glob": "**/*", "input": "src/assets", "output": "/assets" }
],
This works in older projects by default just not now?
"assets": ["src/favicon.ico", "src/assets/"],

@alvics it sounds like you are having a different issue other than what this thread is about. You are correct that assets were (and still are) included in builds for normal Angular projects managed by the CLI. However, this thread is talking about bundling assets for libraries created by the CLI with the ng generate library <library-name> command. This is due to a limitation of ng-packagr - the tool that enables the building of libraries within the CLI. See here for some more info on what's going on and some suggested strategies.
If you've recently added a library to an existing project's workspace that you recently upgraded and are now having assets issues there are some steps that may help you out here.
If you are not trying to build you own Angular library creating a new issue or reaching out to Stack Overflow or the Gitter channel should get you the help you need 😄

Hello I'm having same problem when creating library with extra localization files and also extra sass styles file which has to be preprocessed before a copy. I have to run another script to copy files into destination. It would be nice if that could work as integrated functionality of angular-cli, same as it can do with application type project. Will there be such support ?

Hello, we're also using a library with internal assets, Having the ability to include those assets without a custom script would be highly desirable.

@bniedermeyer: the current workaround is to manually copy the assets

You can write a simple npm script to copy the assets after library is built using cpx:
    "build-lib": "ng build test-lib --prod && npm run copy-lib-assets",
    "copy-lib-assets": "cpx \"projects/test-lib/.npmrc\" \"dist/test-lib\""

But it would be really great if this is possible via angular.json

This definitely should be available from angular.json. Library should be totally independent project and assets are quite important part of it.

Thank you for your interest in this issue.  This issue is currently on the project backlog.  However, as there is a viable method to accomplishing the underlying use case and post-build staging will always be required for specific scenarios,  other issues currently have a higher priority.
If the issue is not being addressed at the priority you would prefer, please consider contributing.  The project is open source and greatly appreciates and accepts contributions from the community.  For further details please see the contributing guidance found here: https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md

Since libraries are exported in the Angular Package Format, wouldn't that first have to be updated to contain guidance for asset output? I see a note about preferring "styles" and "template" over "styleUrls" and "templateUrls" but I don't see anything about assets.

It seems there are only two workarounds for this problem if angular-cli doesn't provide the capability of copying the assets folder across.

Forget about ng and write some hack in npm to emulate it and copy the assets folder across. With the npm postbuild hook or something.
Or just do it manually.

Either of those slow down quite a lot the development process. If someone has any other better idea, please shout!

I've just updated my project from Angular-4 to Angular-7.
my app-config folder is located as a sibling to src.
previously my assets in .angular-cli.json looked like:
"assets": [
    "assets",
    "favicon.ico",
    {
        "glob": "**/*",
        "input": "../app-config",
        "output": "./app-config"
    }
],

now the code that works for me, for the same folder structure, is (angular.json file):
"assets": [
    "src/favicon.ico",
    "src/assets",
    {
        "glob": "**/*",
        "input": "app-config",
        "output": "/app-config"
    }
],

@ortichon this is not related to the issue which is about bundling assets into an angular library.

hai any updates i also end up with the same issue
"assets": [ { "glob": "**/*", "input": "src/assets", "output": "/assets" } ], not working with
Angular CLI: 7.0.7
Node: 8.11.3
OS: win32 x64
Angular: 7.1.1
... animations, common, compiler, core, forms, http
... platform-browser, platform-browser-dynamic, router
Package                           Version
@angular-devkit/architect         0.10.7
@angular-devkit/build-angular     0.10.7
@angular-devkit/build-optimizer   0.10.7
@angular-devkit/build-webpack     0.10.7
@angular-devkit/core              7.0.7
@angular-devkit/schematics        7.0.7
@angular/cli                      7.0.7
@angular/compiler-cli             7.0.4
@angular/language-service         7.0.4
@ngtools/webpack                  7.0.7
@schematics/angular               7.0.7
@schematics/update                0.10.7
rxjs                              6.3.3
typescript                        3.1.6
webpack                           4.19.1

Heya, this isn't the first time an issue has been opened on this topic. https://github.com/angular/angular-cli/issues/13285, https://github.com/angular/angular-cli/issues/10927 and https://github.com/angular/angular-cli/issues/10869 are essentially the same thing as this one.
The short answer is that libraries are built with ng-packagr, and ng-packagr does not have an assets functionality. The feature request in it's issue tracker is https://github.com/ng-packagr/ng-packagr/issues/1092.
But it's a frequent issue that gets a lot of attention so I think it's worth it to go more into detail about this topic. We'll also leave it open and label it as a FAQ to increase visibility.
Building your browser app and building are library are similar insofar as they are both built.
That's about how similar they are though. Building an browser app is actually a completely different build pipeline than building a library. And that means that the pipeline has different configuration options.
For building browser apps we use webpack and a customized set of configurations in the @angular-devkit/build-angular package, whose sources are in this repository. For building libraries we use ng-packagr, whose sources are in https://github.com/ng-packagr/ng-packagr.
Some options you don't really expect to be there when building a library, like the path to the index.html file. It just doesn't make a lot of sense. Other options, like assets, you do expect to be there. It does make sense for a library to have assets, and many libraries do.
But since ng-packagr doesn't have an assets like feature, you can't set that option in angular.json. You get the Schema validation failed error, which means that the option doesn't exist.
I agree this is a desirable feature and that many libraries, like @angular/material, have assets and need to build them using custom code. It is reasonable to expect the feature to exist.
But the right place to request it is in https://github.com/ng-packagr/ng-packagr/issues/1092 because that is where the code for building libraries is. If you are interested in contributing to this feature, that is where you should discuss possible approaches and collaborate with people working on this feature.
Although it sounds like an easy thing, it's not necessarily as easy as just copying some files over. Especially if we're talking about sass files, or other files that are meant to be consumed in specific ways. Often you'll find special instructions in libraries about how the assets must be used.
I hope this sheds some light on the topic.

@filipesilva I understand it would be job for ng-packagr but since Angular CLI runs ng-packagr and we have no option to change the command to something like ng-packagr && node copyOurStuff.js — could you at least add some sort of hooks to Angular CLI so this could be done with Angular CLI in a single step? After all, it looks like this would be the idea behind angular.json and ng that I would create a library and build it using ng run my-library:build. But now I also have to sorta leave ng realm and run some irrelevant npm run my-library:postbuild task that I have to configure in a separate place of package.json that would run the script and only the name of it would be a sign that it is a necessary step in the build process.

i have solved this by changing the file path to another location which folder doesn't contain special character

@waterplea Angular version 8 brings the a stable Architect API which will allow for the extension and/or customization of builders like @angular-devkit/build-ng-packagr.

Re the last comment by @Splaktar, this blog post was just published which explains the Architect API: https://blog.angular.io/introducing-cli-builders-d012d4489f1b

After trying different approches.
My solution was to create angular build as a subfolder of where my assets are. This way I can access assets as ../
Example:
(build)---> myApp/myAngularBuild
(assets)--> myApp/
this way I can even build with
ng build --base-href ./ --watch

Some times ( ) cause these type of issue in build path
On Tue 25 Jun, 2019, 11:50 PM tecsolucionesinformaticas, <
<EMAIL_ADDRESS>wrote:

After trying different approches.
My solution was to create angular build as a subfolder of where my assets
are. This way I can access assets as ../
Example:
(build)---> myApp/myAngularBuild
(assets)--> myApp/
this way I can even build with
ng build --base-href ./ --watch
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/issues/11071?email_source=notifications&email_token=AJWMR64JGMFOFUMTJ5YCQHTP4JOXJA5CNFSM4FCPTQF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYREMHQ#issuecomment-505562654,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJWMR6YX4NNXV73AS6FGRC3P4JOXJANCNFSM4FCPTQFQ
.

i have solved this by changing the file path to another location which folder doesn't contain special character

Oh, so thank you, dhanarajknp! I used [] in the root folder name.

Something ? Anything ??

I am using nodemon in my project. I have been able to copy the images in dist folder of library. https://github.com/Sunbird-Ed/sunbird-ui-components/blob/master/nodemon.json. This works
However, Now I am facing issues in using these images in the lib components.

Well in the meantime I developed my own builder, that executes @angular-devkit/build-ng-packagr and then follows with additional functionality like copying assets etc. That way I do not need to leave the realm of ng commands and even logs fit perfectly.
There is however one more thing...I had to configure application assets in angular.json to copy the library assets so they are accessible during the runtime of the application.

Brilliant @klemenoslaj could you share your implementation?

Ck your base directory contain Any special characters
On Mon 16 Sep, 2019, 1:19 PM Bastien Lemaire<EMAIL_ADDRESS>wrote:

Brilliant @klemenoslaj https://github.com/klemenoslaj could you share
your implementation?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/issues/11071?email_source=notifications&email_token=AJWMR66WGH53XVFBYCKK6ODQJ43ARA5CNFSM4FCPTQF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6YLGKI#issuecomment-531673897,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJWMR6Z5N4CH3M4DANDDOFTQJ43ARANCNFSM4FCPTQFQ
.

@blemaire in fact I just opened an issue in angular-builders for that very reason. I didn't want to create yet another package, I'd rather contribute there.

I can't understand how, It's been more than one year.

Any news no this?

check your base directory contains special character
Wrong Eg : c:\programfile(S)\test
In above example ( is special character
Working Eg : c:\programfiles\test\
Thanks
dhanaraj.k
On Mon, Nov 11, 2019 at 1:28 PM rorry121<EMAIL_ADDRESS>wrote:

Any news no this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/issues/11071?email_source=notifications&email_token=AJWMR6ZWIRYMBQETAVAWAKLQTEGB3A5CNFSM4FCPTQF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDV66EI#issuecomment-552333073,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJWMR62QZPISAW6P2DT5V2DQTEGB3ANCNFSM4FCPTQFQ
.


AdditionalProperties is added to Properties

I have this simple Dto-object (we do schema-mapping manually):
public abstract class MyDto
{
    [JsonExtensionData]
    public Dictionary<string, object> Properties { get; } = new Dictionary<string, object>(StringComparer.Ordinal);
}

In JsonObjectHandler (and NewtonsoftObjectHandler), this property is added to the Properties-collection. And its presence triggers AdditionalPropertiesAllowed = true and sets AdditionalProperties-schema.
As I understand it, the presence of a JsonExtensionData-property should only enable AdditionalProperties, not added it a property

Good catch. Fixed by c47d3b70fc0fcc2d24e0a88789132a358d6ab7c5, including a test for both the STJ and Newtonsoft based-generators.


appmetrics 2.0 have performance downgrade, compared with appmetircs 1.0

For performance test, we are using acme-air as the sample application.

Run one baseline test, record throughput, response time and CPU usage
Run one performance test with ibm-apm + appmetrics v1.0.3, record throughput, response time and CPU usage
Then run one performance test with ibm-apm + appmetrics v2.0.1, record throughput, response time and CPU usage

Compare performance of 3 and 2 with 1 separately.
Here is the test result:

Node.js Process CPU 100%
% degradation vs. baseline for Transactions /sec
% increase vs. baseline for Average response time (ms)
% increase vs. baseline for overall CPU %

Resource Mode_v1.0.3
9.17%
1.73%
1.18%

Resource Mode_v2.0.1
14.54%
4.23%
1.92%

It seems the peformance of v2.0 have a lot of downgrade compared with appmetrics 1.0, especially on the throughput.
Do we have more background work in resource mode (not enable request and trace) in appmetrics 2.0? Do we be able to disable them?
Or there is any other way to improve the performance.

You have a lot more probes active, can you send me a snippet of the code where you are enabling appmetrics please

@xiaoshimimi, respond to the above comment.

@xiaoshimimi, response please

we will try to disable probes that 1.0.3 don't have and retest the performance

The performance got better with the following event disabled:
healthcenter.disable('eventloop');
healthcenter.disable('express');
healthcenter.disable('socketio');
healthcenter.disable('memcached');
healthcenter.disable('mqlight');
healthcenter.disable('postgresql');
healthcenter.disable('mqtt');
healthcenter.disable('redis');
healthcenter.disable('riak');
healthcenter.disable('oracledb');
healthcenter.disable('oracle');
healthcenter.disable('strong-oracle');

So we found the root cause of performance downgrade is new features enabled.
Do we think we still have buffer to improve the performance with those new features enabled? Because those features are resource level monitoring, we should make sure resource monitoring basically not affect user's application.

There is not much we can do to improve the probes, its always going to be the case that if you want more data, you pay a performance price

Though generally, an app wouldn't be using every single one of those probes, or even a majority.
Do you have a synthetic benchmarking app that attempts to use every supported DB?

Could we possible to provide a feature: disable all DB evens that not used in the monitored application? It might be easy to find: as long as there is no require('xxx'); (e.g. require('mongodb'); ) that means this application is not using that DB (e.g. mongodb).

we won't be triggering events if you are not using the DB in the application

Though generally, an app wouldn't be using every single one of those probes, or even a majority.

It's probably just one or two probes causing the change in performance, or even just the eventloop one.  As Toby says if a module isn't required then the associated probe will have 0 effect.
Being able to disable all probes (either by default or by one LOC instead of 20) might be worth doing.

could we enable toggling the probes on/off?
(add controls to dash board too, if possible)
I like the group off (and on) action idea, in the previous comment

@sjanuary do you have reason to suspect the eventloop probe? It's pure c++, and pretty low overhead, I would be suspecting one of the javascript monkey-patching probes, but guess work is not a replacement for banchmarking.

@sam-github no, I don't suspect the eventloop probe for any reason it was more to state that that would definitely be running even if none of the probes were as I'm not sure what kind of test application is being used here. Would definitely be good to see/do some benchmarking.

@sjanuary we need your double confirm that for the following events, we don't need to disable it actively, as long as we don't require them in application, they will have 0 affect to performance.
healthcenter.disable('express');
healthcenter.disable('socketio');
healthcenter.disable('memcached');
healthcenter.disable('mqlight');
healthcenter.disable('postgresql');
healthcenter.disable('mqtt');
healthcenter.disable('redis');
healthcenter.disable('riak');
healthcenter.disable('oracledb');
healthcenter.disable('oracle');
healthcenter.disable('strong-oracle');

That's important for us to decide whether we need to provide options to user to enable or disable those events.

@xiaoshimimi - that's right, as long as neither your application nor any of its dependencies require those modules.

@sjanuary Thank you :+1:

can this be closed now ?

Yes, thank you.


[BUG] Selecting 1 node at time will cause replacement on script

Godot Version
3.2.2 beta 1
OS version
ubuntu 19.10 x64
Problem
If you for example, select Button A, Press F9, button B, press F9 and so on
will make the plugin replace the onready var declaration
and will not place anthing on the function _ready()

Hmm that doesn't make sense. If that were true than you couldn't run this with an existing ready method at all. Perhaps the second thing you selected wasn't a button or text edit? The plugin currently only adds signal handles for those two node types.

ohhh I didnt know that!


Provide type files (.d.ts)

Is your feature request related to a problem?
Providing type files can help with plugin development.
Describe the solution you’d like
Indiekit has JSDoc comments, but does not generate type files.
Type files can be generated by tsc and exported via package.json exports or types / typesVersions field.
Describe alternatives you’ve considered
No response
Additional context
No response

I don’t want to go down the road of converting this project to TypeScript (a language whose spread is akin to a virus IMHO), but if providing types can be a fairly non-intrusive task that builds files and includes them in the published packages, certainly worth investigating!
Are types useful from a plug-in development perspective? How would they help, precisely?

You don't need to convert your project to TypeScript. tsc can generate variable files from JSDoc.
The most intuitive bit is postTemplate, which has to deal with an object called properties, which I can only guess at by reading existing plugins.

You don’t need to convert your project to TypeScript. tsc can generate variable files from JSDoc.

Sorry, I wasn’t clear; I assumed this was the case, was more thinking of this being a step on the slippery slope towards doing so!
Part of the reason for using JSDoc (and more recently adding .jsconfig.json to enable type checking), is to have all the benefits of TypeScript without introducing the complexity, namely compilation and code inscrutability. If the JSDoc documentation can benefit others building plug-ins, then I’m all for it!
If you wanted to submit a PR, then I’d happily review it and include types in the next release 😀 Otherwise, it might be a while until I look into this.

Also worth mentioning that, while most properties can be defined, these can be anything sent by a Micropub client. So for example, Indiekit doesn't have support for watch-of, which clients like Sparkles send for movie posts.

If you wanted to submit a PR, then I’d happily review it and include types in the next release 😀 Otherwise, it might be a while until I look into this.

Unfortunately, as I'm not very familiar with tsc (and the fact that I use TypeScript in almost every project), I'm afraid there's nothing I can do about it.

Been looking at this again. While I can configure TypeScript to output definition files from JSDoc, the files generated mostly contain gibberish, even by TypeScript standards. It’s also a lot of files to be distributing without really understanding what they contain or achieve.
I could manually write some files, but that’s a lot of time/effort, and without an automated workflow, likely to fall out of sync.
Whenever I delve into the world of Typescript, all I find is bugs and issues, most of which are hard to workaround if only using JSDoc to document types.
Perhaps there are other options for publicising these types (I’ve experimented with JSDoc parsers before, with varying success). And as to properties on postTemplate, I fear it would ultimately come down to being marked as any (these are mf2 properties for given post types, which are documented elsewhere).
Going to close this issue. Feel free to open if you have any other ideas for how documentation for Indiekit can be improved for plugin authors.

@paulrobertlloyd
I know this is closed, but hopefully I can add a tiny bit of useful color here as someone trying to stand up IndieKit.
My own website uses custom SSG tooling that I built a long time ago and sort of keep limping along. None of IndieKit's default post templates (for jekyll/Hugo/etc) work out of the box for me, so I set off to build my own.
This was made harder by the lack of a concrete type declaration for the postTemplate method. What exactly do the properties sent to this method contain? I looked at the Jekyll example to get an initial sense, but it took a little console.log-ing to get to the point where I had everything connected the way I wanted for my own blog tooling.
Where IndieKit interfaces with another software developer, and that software developer is expected to write some javascript, types might be very handy — both for initial development, and for assurance when upgrading IndieKit that assumptions about the shape of those types still hold.
Barring full adoption of TypeScript, JSDoc comments with types might be a good middle ground that avoids a build step for IndieKit while giving modern editors a leg up in type inference.

Hi @davepeck, thanks for confirmation that this is an area where the documentation can be improved. Good information to have. A few small things to note:

None of IndieKit's default post templates (for jekyll/Hugo/etc) work out of the box for me, so I set off to build my own.

I’ve made a few changes to those presets that will be released in the next beta release. Currently those presets dictate which properties can be sent to a post template, and these assumptions have been removed in #680 and #685.
If you take a look at the Jekyll preset now, for example, you’ll see that while it still accepts a properties object, apart from changing keys to known Jekyll equivalents (i.e. title → name, date → published), the post template does little else. Not sure if this helps for your particular use case, but worth noting.

What exactly do the properties sent to this method contain?

That short answer is: pretty much anything! For example, a simple note post may provide the following properties:
{
  type: "entry",
  content: {
    text: "Hello, world",
    html: "
Hello, world
"
  },
  published: "2024-02-26T21:00:00Z"
}

while a more complex post might contain the following:
{
  type: "entry",
  content: {
    text: "Haunted by the soundtrack from *All of Us Strangers*.",
    html: "
Haunted by the soundtrack from All of Us Strangers.
"
  },
  "jam-of": {
    type: "cite",
    url: "https://music.apple.com/gb/album/the-power-of-love/1365569059?i=1365570236",
    name: "The Power of Love",
    author: "Frankie Goes to Hollywood"
  },
  published: "2024-02-26T21:00:00Z",
  "post-status": "published",
  category: ["soundtracks"]
}

It really does depend on the post type and the content being published and I’m not sure how types would be able to tell you much beyond Object!

The doc comments suggest that these are "JF2 properties" but I haven't dug enough to find out what that means, or if a definition exists elsewhere.

Gah! I’ve fallen into the trap I’ve been trying to avoid with this project, which is too not assume knowledge of the in-and-outs of various IndieWeb protocols, standards and conventions. Clearly this is proving easier said than done. 😔
In short, JF2 is a serialisation of mf2 (Microformats), which in turn is a serialisation of Microformats that can be added to HTML. Or put another way, a standard way to represent common post properties, designed in a way that can be easily processed and stored.
Do you have any suggestions how I could improve the documentation to explain how JF2 properties are structured, stored and saved out to templates?

JSDoc comments with more complete types (beyond just properties is an object) might be a good middle ground that avoids new tooling for IndieKit

If you look throughout the rest of the code base, this is what I’ve tried to do, although doubtless it could be improved. I’ve not documented any custom interfaces, but open to the idea of doing so, especially where it is useful to users and plugin developers.

In short, JF2 is a serialisation of mf2 (Microformats), which in turn is a serialisation of Microformats that can be added to HTML

Ah, excellent -- I knew I'd run across JF2 before in my Indie Web wanderings but couldn't put my finger on it. Even just including a link in the right place (thanks!) is super helpful from a documentation perspective.

It really does depend on the post type and the content being published and I’m not sure how types would be able to tell you much beyond Object!

Yeah, no doubt a challenge. There are probably a core set of types that are in common enough use to be valuable as a baseline. As post types get more exotic/custom it seems less useful, I suppose.
You're right that great documentation would go a long way. Where different post types are concern, even writing that documentation may make the typing situation a little clearer.
In any case, thanks for all the awesome work you've done here; I'm still enjoying poking the tires. (And for your work on the IndieWeb wiki too -- very nice design updates.)

Made quite a number of updates to the documentation accompanying the release of v1.0.0 Beta 8. Hopefully these address some of the issues raised here.


v1.8.1 deck dump --select-tag X doesn't dump linked plugins

Such as title

This is the expected behaviour: whenever tags are used, it's expected that they are added accordingly to all entities.
Closing this. Feel free to reopen or comment back if you have any more doubts or questions.


Abstract grpc dial connection to remove duplicate code

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
82c96a936a4ce2a603dd10b352407867594e97a7
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
82c96a936a4ce2a603dd10b352407867594e97a7
link
/test gencheck_istio

pilot-e2e-envoyv2-v1alpha3_istio
82c96a936a4ce2a603dd10b352407867594e97a7
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
82c96a936a4ce2a603dd10b352407867594e97a7
link
/test pilot-e2e-envoyv2-v1alpha3_istio

gencheck_istio
82c96a936a4ce2a603dd10b352407867594e97a7
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Gridtools normalizations change.

This is partially a note if others experience this, but https://github.com/iancze/Starfish/pull/107  introduced changes to the interface of the Grids.
The Grid classes no longer have a norm attribute rather it is invoked on the load_flux call.
Invokation the old way gives a error
 from Starfish.grid_tools import PHOENIXGridInterface as PHOENIX
 phoenix_grid = PHOENIX(base=base, air=air, norm=False, wl_range=wl_range)
E           TypeError: __init__() got an unexpected keyword argument 'norm'

The doc strings need to be updated to reflect these changes. (The parameters are in the wrong place).

Thanks for pointing this out! I changed this as a form of consistency for all the Grids. The norm keyword only matters when calling the load_flux method and in the base class RawGridInterface that was the only place where it was defined. The subclasses started adding norm into the constructor, storing the value, and using that as the reference for load_flux. I'm not sure if it is more convenient to specify this in the constructor or the load_flux method, but the consistency is important. Which do you think makes more sense? Given that, I will make any changes and update the docs.

@jason-neal I've made a few changes in my efforts for #120 on the develop branch and have kept the documentation up to date. I will close this but please let me know if you have any issues.


[AutoPR compute/resource-manager] Updating an incorrect description for uploadsizebytes

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7025

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/6897


feat: multi area chart - react

Motivation
added a new multi area chart for the React package,
I had to change the useToggableDomainKey hook so that it will sort the domain keys based on the max value of each key. The purpose of this is to draw the area with the maximum value first. We will need to add an opacity prop because we might hide a portion of the chart.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist:

[ ] I have done the work for both React and Vue
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (Storybook)
[x] I have added unit tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

I removed the sorting of the areas, and added an opacity prop for the area.

I made some changes that were necessary because of the unit tests. One of them is the line color.
I will bring the necessary changes once I start working on the Vue version :wink:

The unit tests do not go through as expected. I made the needed changes into another branch for the Vue version of the multi Area chart.
so in order to repair the unit tests, we need to merge  #88.

We need to add the chart to the list of exported charts in both react & vue.

@marrouchi I have addressed the issue of the provided domain Keys and the opacity. You can now review it again.


Request: Please include Sony A7iv

I want to unlock the language limits :(. but it does not support a7 iv (ILCE-7M4).
Shows:
Switching to app install mode
Error: This device does not support apps

The error makes the reason pretty clear:
The A7M4 does not support apps.  No newer Sony does


Update banner in README

What would you like to share or ask?
Updated LinksHub tagline in the banner
Replace the image with this one

Additional information
No response

Hi, @rupali-codes. Let me work on this right now. Once completed, I will create a pull request and submit it for your review.


Version 0.14 preparations

@homu r+

:pushpin: Commit 52c299c has been approved by kvark

:hourglass: Testing commit 52c299c with merge ce9782c...

:sunny: Test successful - status


[#12] RPM support

Add a new .spec file to make the project support RPM installation.
Create RPM.md to provide instructions.

I am not familiar with RPM, and although it seems to work well, there may still be some issues.
I am not confident about this. Please review and let me know.
Thanks!

See the .spec file for pgmoneta/core for more examples

Merged.
Thanks for your contribution !


Incorrect sentence

"With A SKUs, all users who consume content also require Pro licenses."
The entire point of an A SKU is to embed for users without a Pro license.  Licensing is confusing enough for this product.  Please correct this sentence or clarify its meaning.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4c351d62-f45d-908e-bbc5-bc9bdcbe8372
Version Independent ID: e6f1968c-a72b-7f79-9105-6d685e099af5
Content: How to purchase Power BI Premium - Power BI
Content Source: powerbi-docs/enterprise/service-admin-premium-purchase.md
Service: powerbi
Sub-service: powerbi-premium
GitHub Login: @KesemSharabi
Microsoft Alias: kesharab

Thanks for your comment, @ibTnJohn. This issue has been assigned to the doc author for review.

Hi @ibTnJohn,
You're right that licensing for embedded analytics is confusing. I think you have in mind an ISV scenario, where the ISV is using an EM SKU to serve content to many 3rd party users. In this scenario, the third party customer (the ISV's customer) doesn't need a Power BI license at all. However, embedding the report (or any other Power BI item) in the ISV's app, is done by either a service user or a 'master' user. The documentation is referring to that user as the user 'who consumes content'. Therefore, I believe that the documentation here is correct.
Thanks,
Kesem

I am referring to an A SKU, not an EM. What I have in mind is a typical enterprise environment, where customers register and log in to access their personal accounts on a website and see their dashboards.  In this case, the website handles security and then accesses a report filtered by account number in a Power BI workspace backed with an A SKU through a master user account(which does have to be a Pro account).  I think it's misleading to state that “all users” in italics must have a Pro license.  From the perspective of the enterprise, the thousands of different people accessing the report are the users interacting with and consuming the data — the master user is merely acting as a service account serving the dashboard to the website. So while the statement is technically accurate,  I think changing the wording to something indicating all master or service accounts accessing Power BI for an A SKU must have a Pro license would be less confusing.  Thanks for your consideration.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Kesem Sharabi @.>
Sent: Sunday, June 26, 2022 9:18:41 AM
To: MicrosoftDocs/powerbi-docs @.>
Cc: ibTnJohn @.>; Mention @.>
Subject: Re: [MicrosoftDocs/powerbi-docs] Incorrect sentence (Issue #3906)
Hi @ibTnJohnhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FibTnJohn&data=05|01||33a97c5535704a01eb2908da577ec573|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637918499229154818|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=ThD5Tr52jU3QYACowexv6ML6tAYHov9WnXWkgY42uoI%3D&reserved=0,
You're right that licensing for embedded analytics is confusing. I think you have in mind an ISV scenario, where the ISV is using an EM SKU to serve content to many 3rd party users. In this scenario, the third party customer (the ISV's customer) doesn't need a Power BI license at all. However, embedding the report (or any other Power BI item) in the ISV's app, is done by either a service user or a 'master' user. The documentation is referring to that user as the user 'who consumes content'. Therefore, I believe that the documentation here is correct.
Thanks,
Kesem
—
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fpowerbi-docs%2Fissues%2F3906%23issuecomment-1166547107&data=05|01||33a97c5535704a01eb2908da577ec573|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637918499229154818|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Zg20EWglUaRz8mxNfXmG6B9oNlt1%2BbJasfPfB%2BUZxME%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALP5TBUFBUHXXVUGW73ENL3VRBREDANCNFSM5ZVDTR3A&data=05|01||33a97c5535704a01eb2908da577ec573|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637918499229154818|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=UbTBW4Fi7WlVP%2FG6xDeLxLwXsW6cF0VPGTx3uuwPwes%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

Hi @ibTnJohn,
Thank you for clarifying your point. I'll discuss this with the product team and see if we can revise the document to be clearer.
Kesem

Hi @ibTnJohn,
After consulting with the product team, I removed the sentence about the A SKUs from How to purchase Power BI Premium.
Thank you for bringing this into our attention.
Kesem


Mod causing server to crash on boot

Im running an AllTheMods 6 Server and updated the Envirotech Mods and Valkarie Lib
After updating those mods Apothesis keeps causing the server to crash and run in a boot loop
Minecraft Version 1.16.4
Forge Version forge-1.16.4-35.1.4
Crash Log https://pastebin.com/yRtWurmj

Duplicate of #255 (caused by psi, should be fixed on their end already)

How dose Psi have anything to do with this?


Memory leaks of dart::VirtualMemory

standalone/io/stdout_bad_argument_test
standalone/io/file_blocking_lock_test
Direct leak of 96 byte(s) in 3 object(s) allocated from:
    #0 0x60a72b in operator new(unsigned long) (/usr/local/google/home/rmacnak/dart3/sdk/out/ReleaseX64/dart+0x60a72b)
    #1 0x13d8910 in dart::VirtualMemory::ReserveInternal(long) (/usr/local/google/home/rmacnak/dart3/sdk/out/ReleaseX64/dart+0x13d8910\
)
    #2 0xfee331 in dart::PageSpace::AllocatePage(dart::HeapPage::PageType) (/usr/local/google/home/rmacnak/dart3/sdk/out/ReleaseX64/da\
rt+0xfee331)
...

@a-siva

This is due to the fact that we don't tell lsan about our mmap()ed regions. But the mmap()ed regions hold pointer to malloc()ed memory (for example VirtualMemory).

This should be fixed by a9fbe2004d3f197893


WC2-124 dependencies update

Update critical dependencies:

to

Also import of video.js css was missing and video was looking like this:

Self proof reading checklist

[x] Did I use eslint and black formatters
[ ] Is my code clear enough and well documented
[ ] Are my typescript files well typed
[ ] Did I add translations
[ ] My migrations file are included
[ ] Are there enough tests

Changes

remove react-leaflet-control by removing use of Control in MarkerMapComponent
update: @formatjs/cli, babel-loader, css-loader, style-loader, jsdom, node-sass to non breaking changes versions
import back video.js css to make it look better

How to test
Remove node_modules and run npm ci or delete docker webpack container and run a new build.
Launch the frontend and check dashboard is loading.
Go to an instance detail with a location and check the layer selection on the map is present and working.
You can add a mp4 file to an existant instance, then go to the list of submissions filtered on the form from the instance were you added a video, go to files, video, and check the render of the video
Print screen / video

@cypress


Provide user feedback when a plan is in Closing

When we delete a plan from UI, the UI will

Perform a close
Wait for close
Perform a delete

This issue is to track work to make it very clear that when we delete a plan, the plan transitions to a closing state, then will be deleting.
Thinking something where we visually saying Closing... in the status and show a spinner or dots moving something to indicate a task is in progress.
Also, we will want to make the close best effort, if the close fails we will want to ensure we still delete the Plan.

Fixed by #504


Add a skull timer

WIP PR
EDIT: no longer WIP and closes #6980

A 20-minute timer isn't universally correct; see the skull wiki page:

The "skull" will disappear automatically after 10 or 20 minutes depending on how the player got it; it disappears after 10 minutes after using the Abyss, and 20 after attacking a player. If a player re-enters the Abyss or attack another player that has not attacked them yet, the skull timer will reset. Having the amulet of avarice worn will cause the player to be indefinitely skulled up until 20 minutes after unequipping it.

A 20-minute timer isn't universally correct; see the skull wiki page:

The "skull" will disappear automatically after 10 or 20 minutes depending on how the player got it; it disappears after 10 minutes after using the Abyss, and 20 after attacking a player. If a player re-enters the Abyss or attack another player that has not attacked them yet, the skull timer will reset. Having the amulet of avarice worn will cause the player to be indefinitely skulled up until 20 minutes after unequipping it.

Ya, we are talking about edge cases in discord. It's going to be more of a pain than I thought. There is also the amulet of avarice. Also what happens if you enter pvp with the abyss skull timer on.

This doesn't check if somebody had an abyss skull and went into pvp. I don't know of a way to do that intuitively, I doubt it even changes the behavior of the skull, and I don't think it is a needed thing to be included. The abyssal bracelet does not proc when you have a skull up so it isn't needed to be checked at all.

Just thought I should leave a comment as this isn't exactly finished. I need to figure out how to refresh the timer in pvp and see if hopping worlds changes it at all.

I think this is as good as it will get functionality wise. Reviews are welcomed. The known edge cases are that this wont work if you are refreshing your skull on somebody who has previously attacked you but relogged recently. There is no way for me to check if another player has relogged as far as I can tell. The other known edge case is if somebody's animation changed while interacting with the lcoal player but not attacking them it will count as if they were attacking the local player (for example if someone throws a snowball at the player) and wont include them in the cantSkullOn map.

@15987632 "There is no way for me to check if another player has relogged as far as I can tell." - There is but it might be out of the question. That's using their total exp. When a player logs out, their experience is updated on the hiscores. Though it probably is not worth storing every player you come into contact with's exp.

This is terrible
There isn't a good way to do this and there always will be edge cases


22.1.4_1: Creating new VLAN interfaces fails to bring them up

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
Creating a new VLAN after the upgrade (and relevant changes in VLAN naming / structuring) with 22.1.4_1 creating newA clear and concise description of what the bug is, including last known working version (if any).
Tip: to validate your setup was working with the previous version, use opnsense-revert (https://docs.opnsense.org/manual/opnsense_tools.html#opnsense-revert)
To Reproduce
Steps to reproduce the behavior:

Go to Interfaces > Other Types > VLAN, Click on the "+"
Select a parent interface (that already has other VLANs in my case), assign a VLAN ID, click on save
Go to Interfaces > Assignments, click on the "+"
Select the newly-created VLAN interface from the dropdown list, then click on Save
Go to Interfaces > (Name of new OPT interface): Select "Enable interface", define i.e. an IPv4 address
Click on "Save", then apply the changes what should then enable and bring up the new VLAN interface

The issue is definitely reproducible for what I can tell after trying with 3 VLAN interface definitions.
Expected behavior
A VLAN interface is created and switches up (as the parent interface is also up) like previously-created ones, instead the interface remains down in the Web UI.
I've also checked the output of 'ifconfig' to realize now vlanXY interface was defined, then saw an error in /var/log/system as mentioned in "relevant log files".
Describe alternatives you considered
By replacing the name with the old way (i.e. re1_vlan112) in config.xml, then triggering a reload by changing the IP, then applying the settings in the UI, the VLAN interface came up working. Also: VLAN interfaces created before the upgrade also work flawlessly.
Defintely not "nice", but it did work at least in my case here as a workaround.
Screenshots
(Not availbale.)
Relevant log files
The following message appears in /var/log/system/(datecode).log
<11>1 2022-03-27Txx:xx:xx+00:00 apu1.removed.example opnsense 79614 - [meta sequenceId="9"] /interfaces.php: Unable to configure non-existent interface opt6 (vlan02)

Additional context
I don't have the ability to compare it on another system that easily.
Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 21.1.4_1 (amd64, OpenSSL).
PCEngines APU1, 4GB
Network Realtek RTL8111E

Go to Interfaces > Other Types > VLAN, Click on the "+"

did you hit apply after the adding a new vlan?

Hi and thank you asking for more precise information to reproduce the issue I ran into. Yes indeedt actually I did omit the apply button (didn't realize it to be honest).
Thanks to ZFS BE I temporarily booted back into 21.1.3 to compare the UI behavior: There is no apply button appearing on the preceding version. Yes, I was using the 221.4 UI under the assumption of how 22.1.3 and older releases worked. I did this under the assumption that I could hit apply also only after configuring / enabling the VLAN interface in one go. Sometimes it's is actually helpful to be able to prepare configuration changes in one go and only activate them in a final go only hiting Apply then.
Shouldn't the code check if the VLAN interface is already defined before it attempts enabling and setting IP addresses first? At least that's what I'd assume initially.

Eventually the code should configure the device assigned to the interface. We've only recently made an effort to track these relationships in the code base (22.1.3) for GIF/GRE/bridges, but more to come.

We've added additional validation in 4a754e02bdb for 22.1.5 to make the situation visible (apply missing).

Thank you @fichtner !

FWIW - this issue just helped me as I was pulling my hair out installing OPNsense 23.7-amd64 on a GoWin R86S.  I did the initial setup, and created VLANs on the 10G port, and I could not ping anything on the other side of them - they would fail with "no route to host".  ifconfig showed the subinterfaces were up, but in the interface assignment page they showed red even though the parent interface was green.
Marking the vlan interfaces as disabled, saving/applying, then marking them as enabled, saving/applying fixed the problem.
This might be related or not, but the workaround certainly helped me.

I can confirm I experienced the same issue as @jtamplin
No matter how many times I recreated the new vlans, they would just absolutely refuse to communicate to anything else on the vlan.
I could see the communication working on both the host, and on opnsense with tshark (on host) and tcpdump (on opnsense), so switch was ruled out as the problem.
I could see arp packets being sent by opnsense to host (Who has? packets), and the host tried to respond to opnsense via the address in the arp discovery packets.
I could see the arp packets being recevied by opnsense on the "master" interface (via tcpdump) but nothing got sent back to the vlan interface itself... thus preventing two way communication from working successfully.
I spent an entire day banging my head against the desk trying to get new vlans to work. It was driving me insane. All of the existing vlans worked fine, just new ones I created absolutely would not work
Eventually I logged into serial console (I have a Raspberry Pi permanently connected to serial port, so this was being emitted and received by the Pi) for opnsense and... if was filled with this quite odd message:
[ 323] freebsd_generic_rx_handler Warning: RX packet intercepted, but no emulated adapter

I could recreate that message by trying to "ping" opnsense from any new vlans created. Even after clicking apply every step of the way, and enabling / disabling the vlan interface from web ui.
From failing to find anything on Google to get it solved... I decided to try just giving opnsense a reboot...
And... it worked! After reboot all of the "new" vlans I've been banging my head against desk to get working magically started working after the reboot. Communication between hosts and opnsense was working!
Note: I did also see a few of these repeated shortly after boot, but I haven't seen them again... No idea if this is possibly related:
[1076] generic_netmap_dtor       Emulated netmap adapter for lagg1 destroyed
[1171] generic_netmap_attach     Emulated adapter for lagg1 created (prev was NULL)
[ 319] generic_netmap_register   Emulated adapter for lagg1 activated
[1171] generic_netmap_attach     Emulated adapter for lagg0 created (prev was NULL)
[1076] generic_netmap_dtor       Emulated netmap adapter for lagg0 destroyed
[ 319] generic_netmap_register   Emulated adapter for lagg0 activated

Note: lagg1 is my "LAN" interface with all of the vlans on it. lagg0 is "WAN" interface
And for good measure, here is my NIC information from dmesg:
igc0: <Intel(R) Ethernet Controller I226-V> mem 0x80200000-0x802fffff,0x80300000-0x80303fff at device 0.0 on pci2
igc0: Using 1024 TX descriptors and 1024 RX descriptors
igc0: Using 4 RX queues 4 TX queues
igc0: Using MSI-X interrupts with 5 vectors
igc0: Ethernet address: 60:be:b4:0d:62:c0
igc0: netmap queues/slots: TX 4/1024, RX 4/1024
igc1: <Intel(R) Ethernet Controller I226-V> mem 0x80000000-0x800fffff,0x80100000-0x80103fff at device 0.0 on pci3
igc1: Using 1024 TX descriptors and 1024 RX descriptors
igc1: Using 4 RX queues 4 TX queues
igc1: Using MSI-X interrupts with 5 vectors
igc1: Ethernet address: 60:be:b4:0d:62:c1
igc1: netmap queues/slots: TX 4/1024, RX 4/1024
igc2: <Intel(R) Ethernet Controller I226-V> mem 0x7fe00000-0x7fefffff,0x7ff00000-0x7ff03fff at device 0.0 on pci4
igc2: Using 1024 TX descriptors and 1024 RX descriptors
igc2: Using 4 RX queues 4 TX queues
igc2: Using MSI-X interrupts with 5 vectors
igc2: Ethernet address: 60:be:b4:0d:62:c2
igc2: netmap queues/slots: TX 4/1024, RX 4/1024
igc3: <Intel(R) Ethernet Controller I226-V> mem 0x7fc00000-0x7fcfffff,0x7fd00000-0x7fd03fff at device 0.0 on pci5
igc3: Using 1024 TX descriptors and 1024 RX descriptors
igc3: Using 4 RX queues 4 TX queues
igc3: Using MSI-X interrupts with 5 vectors
igc3: Ethernet address: 60:be:b4:0d:62:c3
igc3: netmap queues/slots: TX 4/1024, RX 4/1024
igc0: link state changed to UP
igc1: link state changed to UP
igc2: link state changed to UP
igc3: link state changed to UP
igc0: link state changed to DOWN
lagg0: IPv6 addresses on igc0 have been removed before adding it as a member to prevent IPv6 address scope violation.
igc1: link state changed to DOWN
lagg0: IPv6 addresses on igc1 have been removed before adding it as a member to prevent IPv6 address scope violation.
igc2: link state changed to DOWN
lagg1: IPv6 addresses on igc2 have been removed before adding it as a member to prevent IPv6 address scope violation.
igc3: link state changed to DOWN
lagg1: IPv6 addresses on igc3 have been removed before adding it as a member to prevent IPv6 address scope violation.
igc2: promiscuous mode enabled
igc3: promiscuous mode enabled
igc0: promiscuous mode enabled
igc1: promiscuous mode enabled
igc0: link state changed to UP
igc1: link state changed to UP
igc2: link state changed to UP
igc3: link state changed to UP
igc0: promiscuous mode disabled
igc1: promiscuous mode disabled
igc0: promiscuous mode enabled
igc1: promiscuous mode enabled

I've also included the pcap from opnsense showing that the "lagg1" interface does indeed receive the tagged packets correctly, but somehow the vlan interface doesn't actually know about them. Again, rebooting opnsense got everything working again, but doesn't explain why this happened. Every other vlan I created before yesterday worked fine without needing to do anything "magical"
pcap.zip

@davidsenk to debug vlan issues if/when they appear, use ifconfig on the machine (or use the interfaces overview page) to compare the ui settings with the ones being configured on the machine itself. Usually nothing magical happens, most common issues are related to settings not being applied (forgotten to press a button). If there's a step by step scenario which results in a missing tag, just open a new ticket, commenting on closed tickets is less useful.

@AdSchellevis
I do actually have a copy of the ifconfig output from before I rebooted!
vlan0.3901: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        description: vlan3901 (opt9)
        options=4000000<NOMAP>
        ether 60:be:b4:0d:62:c2
        inet6 fe80::62be:b4ff:fe0d:62c2%vlan0.3901 prefixlen 64 scopeid 0x13
        inet6 --PUBLIC ADDRESS OMITTED-- prefixlen 64
        inet <IP_ADDRESS> netmask 0xffffff00 broadcast <IP_ADDRESS>
        groups: vlan
        vlan: 3901 vlanproto: 802.1q vlanpcp: 0 parent interface: lagg1
        media: Ethernet autoselect
        status: active
        nd6 options=121<PERFORMNUD,AUTO_LINKLOCAL,NO_DAD>

I'm not entirely sure I have enough information to be able to reproduce the issue. I think it may be uptime dependent. I had 0 issues creating vlans before ~2 days ago. And vlans Ive created after rebooting also work fine, just the two vlans I was trying to create before rebooting (3901, and 1000) could send packets from opnsense, and get received on lagg1 and on the hosts (confirmed with tcpdump and tshark), but opnsense was not delivering it back to the vlan0.3901 / vlan0.1000 interfaces for some reason (as shown in the pcap files).
From comparing the above (pre-reboot) to the current ifconfig output for the vlan... it appears identical to me...
vlan0.3901: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        description: vlan3901 (opt9)
        options=4000000<NOMAP>
        ether 60:be:b4:0d:62:c2
        inet6 fe80::62be:b4ff:fe0d:62c2%vlan0.3901 prefixlen 64 scopeid 0xe
        inet6 --PUBLIC ADDRESS OMITTED-- prefixlen 64
        inet <IP_ADDRESS> netmask 0xffffff00 broadcast <IP_ADDRESS>
        groups: vlan
        vlan: 3901 vlanproto: 802.1q vlanpcp: 0 parent interface: lagg1
        media: Ethernet autoselect
        status: active
        nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>

The only difference I see is the IPv6 link-local scopeid is 0x13 pre-reboot and 0xe post-reboot; as well as the nd6 being 121 and also having NO_DAD prior to reboot. I don't think this would've made a difference as I could not communicate over IPv6 or IPv4, or even at L2, the packets just weren't coming back to the vlan0.3901 interface (as shown in the pcap file), even though lagg1 did receive them.
If I can come up with reproducible steps, I'll definitely open a new issue and reference these comments; but for now, this is just me documenting what I currently know to possibly help anyone else looking around on Google / etc. If it does end up being uptime dependent, I'll also be able to point back to this ;)
Thanks!


[Feature Request] Backports fail often due to CHANGELOG conflicts

Is your feature request related to a problem? Please describe
The backport fails for most PR due to conflicts on CHANGELOG.md. I am wondering if there is better way around this.
Describe the solution you'd like
Maybe provide some conflict resolution hints specifically for CHANGELOG.md?
Related component
Build
Describe alternatives you've considered
No response
Additional context
No response

Good idea. In the case where the diff is a 1-liner, try to apply both by default.

Agreed @ankitkala on unnecessary blockers caused by this. The most frustrating part is users not able to edit the changelog in UI and then commit it right away. The part where you have to manually checkout the code and raise a manual backport PR is irritating. Also, chances for human errors - what if I mistakenly edit other files.

In the case where the diff is a 1-liner, try to apply both by default.

I think for changelog failures - in CI for backport PRs, we can automate this.
Probably need to trigger something like git-merge-file --union in case of conflicts in changelog, haven't checked the exact usage, but looks like we can edit our CI to do a concatenate in changelog. Also, this can also be a comment command to github-actions to run a script and resolve conflicts, and commit changes.
Reference: https://git-scm.com/docs/git-merge-file

[Catch All Triage - 1, 2, 3, 4, 5]

coming from here: https://github.com/opensearch-project/OpenSearch/pull/15915#issuecomment-2392965374 (CC @reta)
IMHO this isn't just about backports, also normal PRs need to be rebased very regularly due to changelog conflicts. i'm not contributing that often here, but it's somewhat annoying 🙈
quoting what i wrote in the other PR:

i'm a big fan of having a changelog, but it's causing a lot of merge conflicts here 🙁
i've seen another repo (don't remember which, but i have a vague feeling that it was even in the opensearch org?) which had a subfolder where you created one file per PR for the changelog and some automated tooling then collected all of that together and merged it into the main changelog file for the release (and deleted the other files). maybe that might be an idea here as well to avoid the merge conflicts?

as a detail: i guess you could then do the equivalent of CHANGELOG.md and CHANGELOG-3.0.md by having a dedicated folder for the upcoming release and once you're ready to release that you remove the normal folder and rename the one for the upcoming release.

i've seen another repo (don't remember which, but i have a vague feeling that it was even in the opensearch org?)

@rursprung I suspect you're referring to OpenSearch-Dashboards: https://github.com/opensearch-project/OpenSearch-Dashboards/tree/main/changelogs
Full details about that solution are here. We should definitely look at moving to that approach if it is working well for the dashboards repo.

Most common problem:  Everyone's adding their Change log entry to the bottom of the list.  That's why they conflict.
Simple fix:  Add your entry in numeric sorting order.  If higher numbered PRs have already been merged this will minimize conflicts.

While somewhat disruptive in the short term, moving to the process implemented by OpenSearch_Changelog_Workflow will completely eliminate these merge conflict problems. OpenSearch-Dashboards is already using that approach. @dbwiddis @jainankitk What do you think?

While somewhat disruptive in the short term

We can minimize the disruption by timing the switch with a minor version bump.
I'm not clear from that proposal how we handle the 2.x and 3.x sections separately.


Android Support

Can i use it for android.
am using ionic

Not sure about Android, but you can use a mailing list for making basic questions.

You don't need this, Android > 5.0 (or with crosswalk > 4.1) natively supports webRTC.

lol
hmm
ok  thans @menelike


Support nested scoped spawns

Currently, the borrow checker rejects this code:
thread::scope(|scope| {
    scope.spawn(|| {
        scope.spawn(|| { // ERROR: cannot borrow `scope` here
        });
    });
});

We need a special spawn method that passes that same scope into the spawned thread. Perhaps something like this:
thread::scope(|scope| {
    scope.spawn_with(|scope| {
        scope.spawn(|| {
        });
    });
});

Bikeshedding 🚲: is spawn_with a good name for this method? Any other ideas? Does scope.with_spawn() read better?
Alternatively, rather than adding a new method, perhaps we could just pass the scope into scope.spawn()? The drawback is that writing scope.spawn(|_| { ... }) might get slightly annoying, but perhaps it's not too bad?
@pedrocr You might be interested in this feature.

Isn't that this issue:
https://github.com/crossbeam-rs/crossbeam/issues/173
I'm a little lost with the new crate organization.

@stjepang I think this is also something that's needed to remove the usage of the unsafe spawn in #44. I think I had both issues. The fuse bindings would need to pass me a scope to be able to spawn things inside it and I also had to do it directly. That's because I have both background threads generated by me and filesystem threads that are generated by fuse on things like a read().

As for the API having scope.spawn always provide a scope seems fine and doesn't seem annoying to me at all. It will require a semver bump though, but it simplifies the total API.

As an interesting parallel, the closure passed into rayon::Scope::spawn also takes another reference to the same scope: https://docs.rs/rayon/1.0.2/rayon/struct.Scope.html#method.spawn


Release 2.3.0

See changelog and upgrade guide

You need to add in the upgrading guide docs -- this only has the changelog stuff.

Upgrade doc already merged

+1


Dump backtrace if a core dump is called just "core"

I hope this lets us capture backtraces in CI. At least it makes it work on my laptop, which is valuable even if we need to do more for CI.
Fixes #2800.

If this works, a backtrace should appear in the compute log of the test_endpoint_crash[debug-pg16-trigger_segfault].

Ok, I now see a stacktrace in the compute log on x64 tests, e.g: https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9125/11019165404/index.html#behaviors/b1a8273437954620fa374b796ffaacdd/449cc866dbb1dc47/?attachment=9d9a072d64577a52.
But not on arm64 test runs. I guess we have configured those runners differently?
In any case, this PR seems good to so, I'll merge.