Searching LDAP by dn not working

Hi,
I played around with this sync tool and got this error:
Traceback (most recent call last):   File "SAMLTeamSyncAD.py", line 198, in <module>     main()   File "SAMLTeamSyncAD.py", line 108, in main     group_members = adsync.get_group_members(args.ad_group)   File "SAMLTeamSyncAD.py", line 54, in get_group_members     member_list.append(self.get_attr_by_dn(member))   File "SAMLTeamSyncAD.py", line 66, in get_attr_by_dn     attributes=['sAMAccountName'])   File "/home/s221676/.local/lib/python3.6/site-packages/ldap3/core/connection.py", line 786, in search     check_names=self.check_names)   File "/home/s221676/.local/lib/python3.6/site-packages/ldap3/operation/search.py", line 372, in search_operation     request['filter'] = compile_filter(parse_filter(search_filter, schema, auto_escape, auto_encode, validator, check_names).elements[0])  # parse the searchFilter string and compile it starting from the root node   File "/home/s221676/.local/lib/python3.6/site-packages/ldap3/operation/search.py", line 215, in parse_filter     raise LDAPInvalidFilterError('malformed filter') ldap3.core.exceptions.LDAPInvalidFilterError: malformed filter
I am wondering, how this search query ever worked:
https://github.com/github/saml-ldap-team-sync/blob/master/SAMLTeamSyncAD.py#L65
I was using
user_filter2: (&(objectClass=USER)(dn={userdn}))
where {userdn} is replaced by e. g. 'CN=John Smith,OU=,,OU=,OU=__,DC=example,DC=com'
I have ldap3 2.6.1 installed
According to this issue in ldap3 (https://github.com/cannatag/ldap3/issues/187), searching by 'dn' only works, if 'dn' is used as the search base, not as a search filter.
The python script works fine, after I changed it according to the suggestion in that issue.
Can anyone explain, if there is a way to use the script correctly in its current implementation or would you like me to open a pull request with my fix?
Best regards
Stefan

Thanks for opening this up @sradi! I'm looking into this now... seems the filter initially should have been distinguishedName instead of dn, but in my testing I'm getting an empty result. I'll dig into it a bit more tonight

@sradi this should be fixed by #17


fix: prevent editing money request in case create failure

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/44459
PROPOSAL: https://github.com/Expensify/App/issues/44459#issuecomment-2219926478
Tests

Disable internet connection
Go to FAB > Submit expense
Select the Distance option
Enter an invalid start location
Enter an invalid finish location
Submit the expense to a workspace
Enable the internet connection
Wait for the error on the request to appear
Click on X icon to clear the error

Verify that: After step 8, the user couldn't edit the money request. After step 9, the errored money request is cleaned up properly and the user is navigated back to the relevant report screen

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Disable internet connection
Go to FAB > Submit expense
Select the Distance option
Enter an invalid start location
Enter an invalid finish location
Submit the expense to a workspace
Enable the internet connection
Wait for the error on the request to appear
Click on X icon to clear the error

Verify that: After step 8, the user couldn't edit the money request. After step 9, the errored money request is cleaned up properly and the user is navigated back to the relevant report screen

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/8ba3b1f9-2fa1-4307-ab5b-f203649dcaa1

Android: mWeb Chrome

https://github.com/user-attachments/assets/24d8b567-4084-4688-96ec-20d4e7b65151

iOS: Native

https://github.com/user-attachments/assets/8e33c1a7-7621-438a-9aee-ddf0536d73a2

iOS: mWeb Safari

https://github.com/user-attachments/assets/d0f79a65-1c72-46c5-900f-fd6686430fd3

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/4582ba3b-f911-47b8-affc-52857181e7af

MacOS: Desktop

https://github.com/user-attachments/assets/4582ba3b-f911-47b8-affc-52857181e7af

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.15-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.15-9 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Slow cleanup when stopping the Quarkus application - Log message needed?

Note: this is just a developer experience issue.
I have seen a demo of a Quarkus Operator at Riviera DEV and when stopping the application, we have the message saying that the Quarkus application is stopped... and then you have to wait ~10 seconds before the application actually stops.
I suppose either this extension or the Kubernetes Client is doing some cleanup tasks at the end but it's a bit confusing as I didn't see anything in the log telling me that something was in progress.
Ideally, it would be nice if the cleanup task could be executed before the Quarkus stopped message is actually displayed.

Also it might have been the shutdown of the Kubernetes dev services so maybe it's there that we need to add a message.
It would be nice if you could have a look what's going on.

I am not sure what was going on but I haven't noticed any particular delay when shutting down applications. Will close this issue, please re-open with more details if you think this is necessary.


Fix bug when client disconnect after sending data

Had a bug when someone connected, sent a message with \r\n and immediatly disconnected
[INFO] [A317A8ED-2076-4E22-B4F6-925884DF9241] [core] HAProxy: proto=TCP4 src_ip=<IP_ADDRESS>:34982 dst_ip=<IP_ADDRESS>:587
[CRIT] [-] [core] RangeError: Maximum call stack size exceeded
[CRIT] [-] [core]     at new Uint8Array (native)
[CRIT] [-] [core]     at Buffer.subarray (native)
[CRIT] [-] [core]     at Buffer.slice (buffer.js:574:23)
[CRIT] [-] [core]     at Connection._process_data (/data/src/Haraka/connection.js:357:43)
[CRIT] [-] [core]     at Connection._process_data (/data/src/Haraka/connection.js:374:18)
Fixed the problem by applying what master smf said :o

:+1:


efibootmgr commands suggested in the README.md don't work.

Additionally, the refind_linux.conf mentioned in the README.md -
"Boot Default BE" "ro quiet loglevel=0 timeout=0 root=zfsbootmenu:POOL= spl_hostid="
"Select BE" "ro quiet loglevel=0 timeout=-1 root=zfsbootmenu:POOL= spl_hostid="

is very different from the config mentioned here -
"Boot default"  "zbm.prefer=zroot ro quiet loglevel=0 zbm.skip"
"Boot to menu"  "zbm.prefer=zroot ro quiet loglevel=0 zbm.show"

Pinging @zbm-dev for comments

I don't have enough information to diagnose the efibootmgr issue. Thanks for pointing out the discrepancy between the README and the wiki page; the syntax from the wiki is preferred, while the README suggests arguments that are now deprecated. We will fix the README shortly.


[material-ui][Switch] Doesn't show initial value when true

Steps to reproduce
Link to live example: https://juanigaray.github.io/mui-switch-initially-false-bug-report/
Link to minimal code: https://github.com/juanigaray/mui-switch-initially-false-bug-report/blob/main/src/App.js
Steps:

Instantiate a Switch element
Pass it an initial true value
Watch it render. It renders as if it were false

Current behavior
The Switch renders grey and pointing to the left, as if it were false. Then, if I click it once, it doesn't change.
Expected behavior
It should always be to the right and blue if the value prop that I pass to it is true, and to the left and grey if the prop that I pass to it is false.
Context
I'm trying to control a Switch component so that I manage its state from a React state.
I have experienced this in Vite and recreated it in create-react-app from scratch (see link above) just in case it was a Vite-specific issue.
Your environment
I'm using Mozilla Firefox for Linux Mint, version 129.0 (64-bit).

npx @mui/envinfo
  System:
    OS: Linux 5.15 Linux Mint 21.2 (Victoria)
  Binaries:
    Node: 21.5.0 - ~/.nvm/versions/node/v21.5.0/bin/node
    npm: 10.2.4 - ~/.nvm/versions/node/v21.5.0/bin/npm
    pnpm: Not Found
  Browsers:
    Chrome: 127.0.6533.119
  npmPackages:
    @emotion/react: ^11.13.0 => 11.13.0
    @emotion/styled: ^11.13.0 => 11.13.0
    @mui/core-downloads-tracker:  5.16.7
    @mui/material: ^5.16.7 => 5.16.7
    @mui/private-theming:  5.16.6
    @mui/styled-engine:  5.16.6
    @mui/system:  5.16.7
    @mui/types:  7.2.15
    @mui/utils:  5.16.6
    @types/react:  18.3.3
    react: ^18.3.1 => 18.3.1
    react-dom: ^18.3.1 => 18.3.1
    typescript:  4.9.5

Search keywords: switch initial value

Hey @juanigaray, you can think of a Switch as an <input type="checkbox">: they're both controlled by the checked prop. This is not something Material UI specific but how checkboxes work on the web: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/checkbox
You example should look like this:
-<Switch value={true} onChange={(_e, checked) => {alert(checked)}} />
+<Switch checked={true} onChange={(_e, checked) => {alert(checked)}} />

Hope this helps.

Ah, that makes sense, thanks forthe clarification


plugin.switchCamera();

Hello,
I am trying to use plugin.switchCamera(); for web implementation.
I have provided required deviceId, but still can't get it to work. As I see, your code uses removeTrack/addTrack... is there something that I need to do after plugin.switchCamera() is called? Because other users can't see new camera.

Try https://github.com/flutterjanus/flutter_janus_client/tree/v2_dev
And let me know if it fixes the problem for you

Works fine, thank you for help! :)

Fixed in 2.2.4


Upgrade to future

Changelog:

Update dependencies
Use Promise.denodeify instead promisify-node
Pretty code
Update Travis CI
Added badges for the David, npm and Travis CI status

Thanks for this PR! I makes the package really nice.
Please, return back the function isLess, and I am going to merge this then

Great work, thanks

Published as 1.1.1


python3Packages.pdoc: 12.3.1 -> 13.0.0

Description of changes
This pr disables the snapshot/pinning tests. They are primarily a sanity check during dev anyway. The other checks are more than sufficient for distribution.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 221577 run on x86_64-linux 1

2 packages failed to build:

home-assistant-component-tests.abode
python311Packages.jaraco-abode

5 packages built:

python310Packages.bx-py-utils
python310Packages.jaraco-abode
python310Packages.pdoc
python311Packages.bx-py-utils
python311Packages.pdoc

Those fail to build on master as well, without the pdoc bump.


[Compatibility] allthemodium

I would like compatibility with the mining dimension

There is no need for compatibility. Just use the biome names and configure the rest to spawn in that biome.


What if a layer has no features? Or an attribute more values?

We need to make sure these cases are covered.

@davidtheclark currently if you pass a geojson with no features, the output looks like this:

@mapbox-machine: Seems fine to me!


Refresh styling after LSP format

I noticed that after running vim.lsp.buf.format() that the styling of the newly formatted lines was no longer visible until I refreshed by entering and exiting insert mode. I don't know if there's a hook or something to re-apply the styling afterwards or not.

I still have not found a reliable way to do this. So, unfortunately this will be put on hold.

I will be closing this issue now.
Reasons:

Plugin now uses TextChanged event and therefore should work as normal.
Can't test markdown formatters due to lack of platform support.


Accessing session attributes in WebSockets

I posted a question about this on Stackoverflow: https://stackoverflow.com/questions/60753624/accessing-session-attributes-set-in-a-httpservlet-in-a-websocketservlet-jetty-w
Apparently the way we're doing HttpServlet+WebSocketServlet isn't possible (?), and we should consider rewriting (although I'm not sure it will solve the issue, considering everything else session-related in the log was identical in the two handlers).
I'm not super familiar with Jetty filters and handler chains, so some help would be appreciated.

I have rewritten the code to use a WebSocketUpgradeFilter, and session attributes seems to work.. Need to make the 404 handling work again though.

I have a working PR: https://github.com/tipsy/javalin/pull/903
I basically don't know what I'm doing here, so I'll have to ping someone from Jetty and ask about the approach.

I've made an alternative (suggested by @joakime in https://github.com/eclipse/jetty.project/issues/4687), which seems like a much safer change: https://github.com/tipsy/javalin/pull/905/files


Add basic logging for safegraph/patterns

Description
Add basic logging for safegraph/patterns
This only has start/eng time for now since # files/last export will take a bit more work with these indicators.
Fixes

Progress on #689

Friendly ping.

Friendly ping.


Replace oboInOwl: annotations by dcterms: annotations.

Replace oboInOwl:created_by and oboInOwl:creation_date annotations by dcterms:contributor and dcterms:date, respectively. This is part of a global move applying to all OBO ontologies.

Good to know, I should have checked the fbcv.Makefile before editing this one.
I am doing dpo right now and will submit that in a moment, so I’ll just merge here.


Cannot Install plugin

Hello,
I'm using Kibana 4.5.1 on Ubuntu 14.04.4 LTS.
I downloaded the plugin using this link https://github.com/clamarque/kibana_health_metric_vis/releases/download/v4.2/kibana_health_metric_vis-4.2.zip
Trying to install command using :
sudo bin/kibana plugin -i health-metric-vis -u file:/path/to/kibana_health_metric_vis-4.2.zip
I've this error message :1234:
Installing health-metric-vis
Attempting to transfer from file:/home/ubuntu/Téléchargements/kibana_health_metric_vis-4.2.zip
Transferring 32282 bytes....................
Transfer complete
Extracting plugin archive
Extraction complete
Optimizing and caching browser bundles...
Plugin installation was unsuccessful due to error "Optimizations failure.

    ERROR in ./optimize/bundles/kibana.entry.js
    Module not found: Error: Cannot resolve 'file' or 'directory' /opt/kibana/installedPlugins/health-metric-vis/public/health_metric_vis in /opt/kibana/optimize/bundles
     @ ./optimize/bundles/kibana.entry.js 129:0-54
"

Any Help please :+1:

@OuesFa Hi! You need to replace the version in the file package.json with your version. I have tested this and it works well.

Thank you it wored fine :+1:

You need to replace the version in the file package.json with your version
Do you mean following ?
unzip  kibana_health_metric_vis-4.2.zip
vim package.json
{
"name": "health_metric_vis",
"version": "<your kibana version.  e.g. 4.5.3>"
}
and re-compress zip archive.

I'm using Kibana 4.5.3 and kibana_health_metric_vis-4.2.zip, it doesn't work.

@n-agetsu Hi. Yes. replace your version in the version from package.json. Tell me if it's work fine?

@clamarque thanks for your response!
I tried rewrite package.json my kibana version(4.5.3), it doesn't work.
I'm using Kibana 4.5.3 Linux 64-BIT on Fedora 25.
I've following error message.
./kibana plugin -i health-metric-vis -u file:/home/agetsuma/elastic/plugin/kibana_health_metric_vis-4.2.zip
Installing health-metric-vis
Attempting to transfer from file:/home/agetsuma/elastic/plugin/kibana_health_metric_vis-4.2.zip
Transferring 32558 bytes....................
Transfer complete
Extracting plugin archive
Extraction complete
Optimizing and caching browser bundles...
Plugin installation was unsuccessful due to error "Optimizations failure.

    ERROR in ../optimize/bundles/kibana.entry.js
    Module not found: Error: Cannot resolve 'file' or 'directory' /home/agetsuma/elastic/kibana-4.5.1-linux-x64/installedPlugins/health-metric-vis/public/health_metric_vis in /home/agetsuma/elastic/kibana-4.5.1-linux-x64/optimize/bundles
     @ ../optimize/bundles/kibana.entry.js 127:0-54

Any help please.

@n-agetsu I have tested myself, It's works fine on version 4.5.3. Check the architectury of repository: When you extract the files, you must see this: kibana_health_metric_vis-4.2\kibana_health_metric_vis-4.2.\assets (for example)

@n-agetsu I see in your command that you use just 1 slash and not 2. Try with 2 slash like write in the readme.

@clamarque work fine! thanks.
In my case, there was no need rewrite package.json my kibana version.

you must see this: kibana_health_metric_vis-4.2\kibana_health_metric_vis-4.2.\assets (for example)
I tried this.

In sucess case,
zipinfo kibana_health_metric_vis-4.2.zip
Archive:  kibana_health_metric_vis-4.2.zip
Zip file size: 33498 bytes, number of entries: 14
drwxrwxr-x  3.0 unx        0 bx stor 17-Feb-15 09:02 kibana_health_metric_vis-4.2/
-rw-rw-r--  3.0 unx    11357 tx defN 16-Nov-18 15:51 kibana_health_metric_vis-4.2/LICENSE
-rw-rw-r--  3.0 unx     1378 tx defN 16-Nov-18 15:51 kibana_health_metric_vis-4.2/README.md
-rw-rw-r--  3.0 unx      209 tx defN 16-Nov-18 15:51 kibana_health_metric_vis-4.2/index.js
...

thank you for kind response!

I don't have an threshold for yellow. What's wrong? Thanks for any help.

@lisafitz Hi. What version did you use?  4.x or 5.x ?

5.0
On Apr 10, 2017, at 3:30 AM, Charles Lamarque<EMAIL_ADDRESS>wrote:
@lisafitz https://github.com/lisafitz Hi. What version did you use? 4.x or 5.x ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/clamarque/kibana_health_metric_vis/issues/6#issuecomment-292870886, or mute the thread https://github.com/notifications/unsubscribe-auth/AZorGx-Vdg3v0qVKXILlYl3KQYLLc9ioks5rudp6gaJpZM4LH7wK.


tableView.rx.itemDeleted Is not called

I'm not doing anything custom, I have a Rx animated data source, it lists the items fine, but it won't call "itemDeleted" or show the red delete slide.

 canEditRowAtIndexPath was required in Rx DataSource, but it wasn't documented anywhere.


As long as the payment isn't confirmed the purchase shouldn't be part of the result of restorePurchases

The following was reported to our security alias. It does not seem to me to be a security vulnerability so I am filing it as a normal issue. -@Hixie

Steps to Reproduce
I use in_app_purchase: 3.1.5 and test on an emulator inside Android Studio.

Buy a product with a slow test card. E.g.: "Slow test card, declines after a few minutes"
Call InAppPurchase.instance.restorePurchases() within the next minute

Expected results:
As long as the payment isn't confirmed the purchase shouldn't be part of the result of restorePurchases. Or at least should have the state: PurchaseStatus.pending
Actual results:
Purchase is returned when calling restorePurchases and [state] is PurchaseStatus.restored, [pendingCompletePurchase] is true
With these values I'm not able to say if the payment is confirmed or not. Giving access to a product can therefore be exploided by using a delayed, declining credit card and call restorePurchases.
(Stopping the delivery of the product when PurchaseStatus.restored && pendingCompletePurchase == true
isn't an option, because I want to be able to restore a purchase when the user behaves like this: Purchases a product and immediately closes the app)
It is possible to set the correct PurchaseStatus by hand. I call the following function inside InAppPurchase.instance.purchaseStream.listen for each PurchaseDetails:
static void _bugfixSetPending(PurchaseDetails purchaseDetails) {
  if (Platform.isAndroid &&
      purchaseDetails.status == PurchaseStatus.restored) {
    if (purchaseDetails is GooglePlayPurchaseDetails) {
      final state = purchaseDetails.billingClientPurchase.purchaseState;
      if (state == PurchaseStateWrapper.pending) {
        purchaseDetails.status = PurchaseStatus.pending;
      }
    } else {
      logger.w('Failed to access google purchase details.');
    }
  }
}

Thanks for following up on the problem.
(I still think it's related to security. I guess there are some app's where you could get products for free)  ;)

I got exactly the same issue :(

Agree... But for now I hope my function [_bugfixSetPending] helps you.
As for as I know it works perfectly :)

Hello guys,
I'm glad this issue is already opened, and it was even created by @Hixie. Thank you!
I have a critical add-on on this.
This bug is still present:
in_app_purchase 3.1.7
in_app_purchase_android 0.3.0+10
When the actual cancelation happens after a few minutes, no event is being added to the InAppPurchase.instance.purchaseStream.
Important!
The same issue occurs with "Slow test card, approves after a few minutes".
In this case:

At first we're getting the 'pending' event on InAppPurchase.instance.purchaseStream. That's okay.
But then during minutes we don't receive any event about the purchase is completed. Even though the payment is already accepted.
Until we call ourselves restorePurchases().

I guess it started to happen with transition to the Google Play Billing Library 5 (This issue was already present with in_app_purchase_android around 0.2.5).

As a temporary workaround, in addition to @WasaLordy 's solution. Whenever we're getting any pending (a real or a "fixed" pending) PurchaseDetails on the InAppPurchase.instance.purchaseStream, we need to start a timer to poll the restorePurchases() again.

Hi @serhii-k
I tested your described behaviour today and I used the same versions.
At least on my emulator I can agree that the "slow and declining test card" doesn't trigger any event after "PurchaseStatus.pending". I waited 16 minutes. Also no email is send from google to inform about the purchase error.
But for the "slow approves test card" I do get a second event after "PurchaseStatus.pending".
After 63 seconds I got "PurchaseStatus.purchased" and 5 seconds later the email from google with "Thank you" reached my mailbox.

Hi @WasaLordy
Yes, you are absolutely right. Thank you!
I have just tried it once again after reading your message, and it does send the "PurchaseStatus.purchased" event for the "slow approves test card".


new chapter Services/Service Mesh

theory intro
diagram
lab walkthrough

not sure what to pick for an example.
linkerd vs isito vs consul?

hey @networkop you plan to work on this? I love your tkng.io very much love to have this explanation straight from you

hey @imnmo , yes, I still plan to work on this. Hopefully will pick it up this summer


FYI: The Windows binary is detected on Virustotal on 2/70 engines

Just FYI: https://www.virustotal.com/gui/file/735513ba94130c49d15ea9c1444891afe89668786c3ff94067fb1aa70f292507

If you search for Trojan.Malware.300983.susgen, you'll find that there is a lot of false-positives by MaxSecure all over the place. I can do no more, then ignore this buggy scanner.
See also https://go.dev/doc/faq#virus


MINOR: [Python] Update bulding docs to allow setup.py CMake invocations to find Arrow

Following along the build documentation CMake was unable to find the arrow installation when the documentation gets to the point of invoking setup.py. This should fix that and prevent errors like:
CMake Error at /home/willayd/mambaforge/envs/pyarrow-dev/share/cmake-3.24/Modules/CMakeFindDependencyMacro.cmake:47 (find_package):
  By not providing "FindArrow.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "Arrow", but
  CMake did not find one.

  Could not find a package configuration file provided by "Arrow" with any of
  the following names:

    ArrowConfig.cmake
    arrow-config.cmake

  Add the installation prefix of "Arrow" to CMAKE_PREFIX_PATH or set
  "Arrow_DIR" to a directory containing one of the above files.  If "Arrow"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  build/dist/lib/cmake/ArrowPython/ArrowPythonConfig.cmake:54 (find_dependency)
  CMakeLists.txt:239 (find_package

Got the same question when using pip to install pyarrow. When will this be updated to the Pypi?

@WillAyd this is a correct fix for the docs if you are setting ARROW_HOME to a custom path (thanks for the catch!), but just to note since I see you are using mambaforge: if you set ARROW_HOME to the conda env prefix path (export ARROW_HOME=$CONDA_PREFIX), then you don't need to set CMAKE_PREFIX_PATH, because in that case Arrow will be installed in the conda env standard location, and cmake will find it automatically.

Got the same question when using pip to install pyarrow. When will this be updated to the Pypi?

@DK-DARKmatter I don't think there is anything to "update" for the PyPI packages. If you want to install from source from PyPI, you as user are responsible for ensuring you also have Arrow C++ and have set up the correct env variables to ensure building pyarrow will find that.

Got the same question when using pip to install pyarrow. When will this be updated to the Pypi?

@DK-DARKmatter I don't think there is anything to "update" for the PyPI packages. If you want to install from source from PyPI, you as user are responsible for ensuring you also have Arrow C++ and have set up the correct env variables to ensure building pyarrow will find that.

Hello, I am attempting to install Arrow C++ by "pip install pyarrow". I am getting the same error. What change do I need to do to fix it?

@niranjan23d @DK-DARKmatter it sounds like you are trying to pip install pyarrow on a platform or version of Python where a wheel is not available. Unless you care to install from source your best bet is to look for a wheel or use conda/mamba

I see. Thank you. I will try to install it onto python 3.10. I am trying to install it onto python 3.11

I see. Thank you. I will try to install it onto python 3.10. I am trying to install it onto python 3.11

@niranjan23d @DK-DARKmatter it sounds like you are trying to pip install pyarrow on a platform or version of Python where a wheel is not available. Unless you care to install from source your best bet is to look for a wheel or use conda/mamba

That fix totally worked! Thank you!


Add CAPE shading to metpy skewT plot

https://unidata.github.io/MetPy/latest/examples/Advanced_Sounding.html

@kafitzgerald not sure how I missed this, but CAPE is already shaded in https://projectpythia.org/advanced-viz-cookbook/notebooks/5-skewt.html#additional-skew-t-options
I could pull it out of the subplots to highlight it more, but whether or not we do that depends on how much time we have to dedicate to it.


First implements with structure

Basic code for future implementations, 4 tests passed.

approved for merge

approved for merge


Assignment Submissions

Build assignment submissions

[x] text entry
[x] file upload
[ ] media_recording

[ ] external tool


Enable ask password option not enable the ask password option on user creation

Describe the issue:
Enable ask password

How to reproduce:

Login to console
Navigate to the login & registration -> Invite User to Set Password
Enable user email registration

Expected results
Invited the user to set their password should be enable in user creation wizard
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: wso2is-7.0.0-rc1-SNAPSHOT-4957
OS: [e.g., Windows, Linux, Mac]
Database: postgres
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

Duplicate of https://github.com/wso2/product-is/issues/18248. Hence closing this issue.


[metrics] Remove redundant cloning of some metrics

Cloning of complex values like latency and response codes is unnecessary now as EventMetrics are cloned right after they are composed[1].
[1] Cloning right after creation sounds bad, but cloning of EventMetrics is handled in a central function (providing more safety and better handling), while creation of EventMetrics happens in many places.
https://github.com/cloudprober/cloudprober/blob/8eabdeba7c2f94135b12cfc48c3117e034eac5fc/probes/options/options.go#L292

I am still thinking about this. Maybe it will be cleaner to provide an option for RecordMetrics to ask for cloning, and keep cloning where it is today.

#820 is a better option I think.


Visual Testing for Interactions ( hover, active )

We need to add interactions tests for hover, active so that we can catch all changes being made to our components.

Closing as fixed in #25877


[windows] we can't read a URI in ldif file

URI = file:///c:/WINDOWS/clock.avi
Path = /c:/WINDOWS/clock.avi
We have a error when we execute this line https://github.com/go-ldap/ldif/blob/master/ldif.go#L455

When we execute the test in windows, we have the following error:
--- FAIL: TestLDIFURL (0.01s)
        ldif_test.go:178: Failed to parse LDIF: Error in line 3: failed to read /C:\Users\bobthesponge\AppData\Local\Temp\ldifurl474561
835: open /C:\Users\bobthesponge\AppData\Local\Temp\ldifurl474561835: The filename, directory name, or volume label syntax is incorrect
```` .


Strong mode should recognize new A//.named()

In the following example, the <T> is ignored.
var completer = new Completer/*<T>*/.sync();

The analyzer should handle the comment syntax as for literals.
(Workaround is currently to write new Completer<dynamic/*=T*/>.sync().

https://codereview.chromium.org/1870733002/


1.3

Place for questions on problem 1.3
1.3 Cleaning additional variables (10 points)
Clean the following variables; make sure to retain the original variable in data and use the derived suffix so it's easier to pull these cleaned out variables later (e.g., race_derived) to indicate this was a transformation
Here's code you can adapt to clean the dates for 1.3.4
### first, use regex to clean up the date columns
sentence['tmp_clnsdate'] = [re.sub(r'2[1-9]([0-9]+)', r"20\1", str(date))
                             if bool(re.search('\/2[1-9][0-9]+', str(date))) else
                            str(date)
                            for date in
                            sentence.SENTENCE_DATE]

Place for questions on problem 1.3
1.3 Cleaning additional variables (10 points)
Clean the following variables; make sure to retain the original variable in data and use the derived suffix so it's easier to pull these cleaned out variables later (e.g., race_derived) to indicate this was a transformation
Here's code you can adapt to clean the dates for 1.3.4
### first, use regex to clean up the date columns
sentence['tmp_clnsdate'] = [re.sub(r'2[1-9]([0-9]+)', r"20\1", str(date))
                             if bool(re.search('\/2[1-9][0-9]+', str(date))) else
                            str(date)
                            for date in
                            sentence.SENTENCE_DATE]

For further clarification (from Slack general channel)
Definitions for the indicators :

is_black_derived : True if {Black only, White/Black [Hispanic or Latino]}, else False
is_hisp_derived : True if {HISPANIC or White [Hispanic or Latino]}, else False
is_white_derived : True if White, else False
is_other_derived : True if is_black_derived == is_hisp_derived == is_white_derived == False , else False

Rephrasing the fourth sub-division:
the is_other_derived indicator should be True for all the races that were not included in the initialization of any of the previous indicators - and it should be False otherwise.

While  creating the is_other_derived indicator, you may either use np.where with parentheses, or define a boolean and assign values to the column without using np.where.


run_sprocket.py throws error

Can you help me with this error? I have followed the steps for VC:
This commands throughs an error for me:
### 4. Train GMM and converted GV ### Traceback (most recent call last):   File "run_sprocket.py", line 153, in <module>     str(PAIR_DIR))   File "/home/../../src/train_GMM.py", line 87, in main     jnth5 = HDF5(jntf, mode='r')   File "/home/../anaconda3/lib/python3.6/site-packages/sprocket_vc-0.18-py3.6.egg/sprocket/util/hdf5.py", line 47, in __init__     "h5 file does not exist in " + self.fpath) FileNotFoundError: h5 file does not exist in data/pair/SF1-TF1/jnt/it4_jnt.h5

@k2kobayashi Let me know where I might be wrong

@k2kobayashi I am faced with the same error. Please let us know the fix. Cheers

Hi @vivek-sethia and @malayaleecoder,
Thank you for notifying me and sorry for the serious bug.
I have modified and pushed it.
Could you pull the current master and run sprocket again?

@k2kobayashi Thanks for the patch, it's all good now.

@k2kobayashi Thank you its working. I will close this issue now.


View does not scroll when switching to same keyboard type text inputs

I have a sign up screen and when I go from Last Name to Email and Email to Password it works fine, but when I go to Confirm Password, it does not work. Going from Email to Confirm Password works but not from Password to Confirm Password (same keyboard type fields).

Handled by adding this to TextInput but need proper fix in lib:
onFocus={(e) => {
// Handle scroll from secure text entry to another input with secure text entry
confirmPassRef && confirmPassRef.current.setNativeProps({ secureTextEntry: false });
setTimeout(() => {
// @ts-ignore: Object is possibly 'null'.
confirmPassRef && confirmPassRef.current.setNativeProps({ secureTextEntry: !showConfirmPassword })
}, 50);
}}


On project list for DCP2  determine presence of matrices on a project from project response instead of bucket head requests.

@hannes-ucsc @theathorn  we will need a way on the Azul projects response (if its not there already) to determine if a project  has CGMs or HCA matrices.
Would be great to just have a boolean for each e.g. hasCGMs and hasProjectMatrices  or similar.
A single "hasMatrices" would also work.
We do not need the list of matrices just information about the existence so we can show or not the matrix download icon.
Can you indicate if this exists on the DCP2 projects response and what the fields are or create a blocking ticket in Azul  and block this ticket with it?
Thanks, Dave

Use hits[*].projects[0].contributorMatrices and hits[*].projects[0].matrices to determine existence on project list.


Fix isapprox for dictionaries in testing (and highlight existing errors)

It seems that the fixes yesterday for the data transposition worked for the positions but have broken the cell vectors. You can see this in the README example where the typo in the cell vectors Lattice="5.44 0.0 0.0 0.0 5.44 0.0 0.0 0.05.44" becomes
"cell": [
      [
         5.44,
         0.0,
         0.0
      ],
      [
         0.0,
         5.44,
         0.05
      ],
      [
         0.0,
         0.0,
         0.44
      ]
   ]

whereas it should be
"cell": [
      [
         5.44,
         0.0,
         0.0
      ],
      [
         0.0,
         5.44,
         0.0
      ],
      [
         0.0,
         0.05,
         0.44
      ]
   ]

This issue was being hidden by the isapprox function which was causing the comparison to exit early before comparing all the fields. It would compare the sub-dictionary "arrays" and return true before comparing the cells.
So this pull request should cause the tests to fail and highlight that the cells are not being transformed correctly.

OK, thanks, I'll take a look. I was reassured also by the explicit comparisons with the ASE cell vectors, but obviously something is wrong.

OK, the transpose bug is real but the typo in Lattice is unrelated: for backwards compatibilty the Lattice is treated specially and assumed to be a 9-element vector in Fortran (i.e. same as Julia) column-major order. That's what leads to the odd result above, which must be due to an error in the underlying C parser (or even in the grammar). I'll open an issue in the https://github.com/libatoms/extxyz repo since the Python wrapper does the same thing:
```$pip3 install extxyz
...
$ python3
Python 3.7.4 (default, Mar 26 2020, 11:57:44)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import extxyz
>>> extxyz.read("test.xyz")
Atoms(symbols='Si8', pbc=True, cell=[[5.44, 0.0, 0.0], [0.0, 5.44, 0.0], [0.0, 0.05, 0.44]])

The other entries in the info are indeed incorrectly transposed, I'll fix that shortly. Row- vs column-major has thrown up all sorts of issues!

merging into a new branch so I can finish debugging.


[CELEBORN-1565] Introduce warn-unused-import in Scala

What changes were proposed in this pull request?
This PR aims to introduce warn-unused-import in Scala.
Why are the changes needed?
There are currently many invalid imports, which can be checked using -Ywarn-unused-import.
And through silencer  plugin we can avoid some imports required in scala 2.11.
import org.apache.celeborn.common.util.FunctionConverter._

Does this PR introduce any user-facing change?
No
How was this patch tested?
GA

Finally, there is a PR to fix this problem. BTW Are there any tools to find unused methods?

Are there any tools to find unused methods

Maybe scalafix.
https://scalacenter.github.io/scalafix/docs/rules/RemoveUnused.html

Please fix the conflicts. This PR looks good to me.

Are there any tools to find unused methods

Maybe scalafix.
https://scalacenter.github.io/scalafix/docs/rules/RemoveUnused.html

Are there any relative tools for Java?

Are there any tools to find unused methods

Maybe scalafix.
https://scalacenter.github.io/scalafix/docs/rules/RemoveUnused.html

Is there any relative tools for Java?

Are there any tools to find unused methods

Maybe scalafix.
https://scalacenter.github.io/scalafix/docs/rules/RemoveUnused.html

Is there any relative tools for Java?

Are there any tools to find unused methods

Maybe scalafix.
https://scalacenter.github.io/scalafix/docs/rules/RemoveUnused.html

Are there any relative tools for Java?

Isnt there not a checkstyle rule for this ?

And I just realized we dont have checkstyle for Celeborn :-)
Perhaps that might help with this as well as other style enforcements ?

we dont have checkstyle for Celeborn

Because we use spotless-maven-plugin, there may be some check conflicts with checkstyle.
In addition, .scalafmt.conf is used in scala to check some formats.

Thanks. Merged into main(v0.6.0).


TestConsole should not throw when reading input

The behavior of TestConsole is to throw when you try to read a key and the queue is empty. This change will block untill input is provided.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: mathijs-dumon sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

To clarify why I think this change is need:
If you want to unit test a CLI which waits for a user to confirm (in my case a tool watching for changes in files), you have to add exception handling in the production code where we do the ReadKey() because the System.Console does not throw and simply blocks in this case.

@mathijs-dumon please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree [company="{your company}"]

@microsoft-github-policy-service agree
Op ma 15 apr. 2024 17:29 schreef microsoft-github-policy-service[bot] <
@.***>:

@mathijs-dumon https://github.com/mathijs-dumon please read the
following Contributor License Agreement(CLA). If you agree with the CLA,
please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of
intellectual property rights to my Submissions and I am not making
Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work
for my employer (or my employer has intellectual property rights in my
Submissions by contract or applicable law). I have permission from my
employer to make Submissions and enter into this Agreement on behalf of my
employer. By signing below, the defined term “You” includes me and my
employer.

@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement Contribution License Agreement
This Contribution License Agreement (“Agreement”) is agreed to by the
party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its
affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is
effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable
or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft
and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or
distributing code or other content to any
Project, including but not limited to communication on electronic
mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf
of, the Project for the purpose of
discussing and improving that Project, but excluding communication
that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material
Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement
before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now
or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions
is entirely Your original work.
Should You wish to Submit materials that are not Your original work,
You may Submit them separately
to the Project if You (a) retain all copyright and license information
that was in the materials as You
received them, (b) in the description accompanying Your Submission,
include the phrase “Submission
containing materials of a third party:” followed by the names of the
third party and any licenses or other
restrictions of which You are aware, and (c) follow any other
instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include
Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a
contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your
employer has intellectual
property rights in Your Submission by contract or applicable law, You
must secure permission from Your
employer to make the Submission before signing this Agreement. In that
case, the term “You” in this
Agreement will refer to You and the employer collectively. If You
change employers in the future and
desire to Submit additional Submissions for the new employer, then You
agree to sign a new Agreement
and secure permission from the new employer before Submitting those
Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the
Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive,
royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly
display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all
of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the
Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive,
royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or
the combination of the
Submission with the Project to which it was Submitted to make, have
made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the
Project.
Other Rights Reserved. Each party reserves all rights not
expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without
limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are
legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your
original work (except as You may
have disclosed under Section 3). You represent that You have secured
permission from Your employer to
make the Submission in cases where Your Submission is made in the
course of Your work for Your
employer or Your employer has intellectual property rights in Your
Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You
represent and warrant that You
have the necessary authority to bind the listed employer to the
obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless
You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE
WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED
UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO,
ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of
any facts or circumstances of which
You later become aware that would make Your representations in this
Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to
Projects and information about
contributions may be maintained indefinitely and disclosed publicly,
including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the
laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal
courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in
which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County,
Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire
agreement between the parties, and
supersedes any and all prior agreements, understandings or
communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may
be assigned by Microsoft.

—
Reply to this email directly, view it on GitHub
https://github.com/spectreconsole/spectre.console/pull/1138#issuecomment-2057139458,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACY6U7U4OC5EHVAD7FGRGTY5PW6TAVCNFSM6AAAAAAUBPUG56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJXGEZTSNBVHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hello @mathijs-dumon, thanks for this contribution, which I've now assigned to myself for review.

If you want to unit test a CLI which waits for a user to confirm (in my case a tool watching for changes in files), you have to add exception handling in the production code where we do the ReadKey() because the System.Console does not throw and simply blocks in this case.

I understand the change but it would be really helpful if you could also share a code example of exactly how you are using this patch.
I'm mindful this PR doesn't include any new/updated unit tests, and so I'd like to understand if this change is somehow fully covered by existing tests etc, or not.

Hello @mathijs-dumon, I'm still willing to consider your PR based upon its merits, however, without an underlying issue and/or a unit test showing why the change is necessary, I'm unable to proceed any further with it. Please consider making further contributions to it, otherwise it will be closed in due course.

Closing due to inactivity.  Feel free to reopen (and tag me), if you want to continue this PR.


_isCallable clashes with Celery

with Celery version 4.0.2
from celery import Celery
from rdkit.Chem import Descriptors

gives this error:
Traceback (most recent call last):
  File "/tmp/abc.py", line 5, in <module>
    from seacore.run.scoring import (
  File "/nfs/work/momeara/tools/anaconda2/envs/sea16/lib/python2.7/site-packages/seacore/run/scoring.py", line 23, in <module>
    from fpcore.rdkit_common import tc_matrix_rdkit
  File "/nfs/work/momeara/tools/anaconda2/envs/sea16/lib/python2.7/site-packages/fpcore/rdkit_common.py", line 20, in <module>
    from rdkit.Chem import Descriptors, inchi
  File "/nfs/work/momeara/tools/anaconda2/envs/sea16/lib/python2.7/site-packages/rdkit/Chem/Descriptors.py", line 195, in <module>
    _setupDescriptors(locals())
  File "/nfs/work/momeara/tools/anaconda2/envs/sea16/lib/python2.7/site-packages/rdkit/Chem/Descriptors.py", line 62, in _setupDescriptors
    if _isCallable(thing):
  File "/nfs/work/momeara/tools/anaconda2/envs/sea16/lib/python2.7/site-packages/rdkit/Chem/Descriptors.py", line 25, in _isCallable
    return (hasattr(collections,'Callable') and isinstance(thing,collections.Callable)) or \
  File "/nfs/work/momeara/tools/anaconda2/envs/sea16/lib/python2.7/abc.py", line 144, in __instancecheck__
    return cls.__subclasscheck__(subtype)
  File "/nfs/work/momeara/tools/anaconda2/envs/sea16/lib/python2.7/abc.py", line 180, in __subclasscheck__
    if issubclass(subclass, scls):
  File "/nfs/work/momeara/tools/anaconda2/envs/sea16/lib/python2.7/abc.py", line 161, in __subclasscheck__
    ok = cls.__subclasshook__(subclass)
  File "/nfs/work/momeara/tools/anaconda2/envs/sea16/lib/python2.7/site-packages/celery/utils/abstract.py", line 54, in __subclasshook__
    return cls._subclasshook_using(CallableTask, C)
  File "/nfs/work/momeara/tools/anaconda2/envs/sea16/lib/python2.7/site-packages/celery/utils/abstract.py", line 23, in _subclasshook_using
    all(_hasattr(C, attr) for attr in cls.__required_attributes__)
  File "/nfs/work/momeara/tools/anaconda2/envs/sea16/lib/python2.7/site-packages/celery/utils/abstract.py", line 23, in <genexpr>
    all(_hasattr(C, attr) for attr in cls.__required_attributes__)
  File "/nfs/work/momeara/tools/anaconda2/envs/sea16/lib/python2.7/site-packages/celery/utils/abstract.py", line 12, in _hasattr
    return any(attr in B.__dict__ for B in C.__mro__)
AttributeError: class _Feature has no attribute '__mro__'

Modifying rdkit/Chem/Descriptors.py by replacing
def _isCallable(thing):
  return (hasattr(collections,'Callable') and isinstance(thing,collections.Callable)) or \
                hasattr(thing,'__call__')

with
def _isCallable(thing):
  try:
    is_callable = (hasattr(collections,'Callable') and isinstance(thing,collections.Callable)) or \
              hasattr(thing,'__call__')
  except:
    return False
  return is_callable

no longer gives an error.

Hello,
When you apply your fix, do you still have access to all descriptors? _isCallable is important to make the descriptors available.

What happens if you reverse the import statements?

_Feature is part of celery and not RDkit. What Python, RDkit, and Celery version do you use?

I am using
 Python 2.7.11 :: Anaconda 4.1.0 (64-bit)
 celery: 4.0.2
 conda install -c rdkit rdkit=2016.09.2

With the original Descriptors.py, reversing the import statements no longer raises an exception.
With the modification, I am not sure if I have access to all the descriptors, but
>>> from celery import Celery
>>> from rdkit.Chem import Descriptors
>>> len(Descriptors.descList)
206

That is interesting. Let's try to find out what causes the exception. Can you add a print statement before the is_callable line and print thing?

entering the debugger pdb.set_trace() after it catches the exception
(pdb) thing
 _Feature((2, 6, 0, 'alpha', 2), (3, 0, 0, 'alpha', 0), 65536)
(pdb) up
(pdb) name
print_function
(pdb) mod
<module 'rdkit.Chem.GraphDescriptors' from '/nfs/work/momeara/tools/anaconda2/envs/sea16/lib/python2.7/site-packages/rdkit/Chem/GraphDescriptors.pyc'>
(pdb) isinstance(thing, collections.Callable)
*** AttributeError: class _Feature has no attribute '__mro__'
(Pdb) dir(thing)
['__doc__', '__init__', '__module__', '__repr__', 'compiler_flag', 'getMandatoryRelease', 'getOptionalRelease', 'mandatory', 'optional']

I cannot find Feature or _Feature in the code. ( @greglandrum, do you have an idea?)
Can you paste in your Descriptors.py file? The line numbers in your traceback don't correspond to the ones I see in master or any historical versions of the file.
The _isCallable function is called from the _setupDescriptors file. There is always a name associated with each thing. Can you find out which one that is?
  for mod in mods:
    tmp = dir(mod)

    for name in tmp:
      if name[0] != '_' and name[-1] != '_' and name not in others:
        # filter out python reference implementations:
        if name[:2] == 'py' and name[2:] in tmp:
          continue
        thing = getattr(mod, name)
        if _isCallable(thing):
          namespace[name] = thing
          _descList.append((name, thing))
  descList = _descList

Interestingly, this error does not occur when using Python 3.6 (I assume it also doesn't happen with Python 3.5).
This seems likely to be a celery bug, not an RDKit problem.

Did you try with celery on python3? The trackback shows that celery adds a hook (subclasshook) and is therefore part of the game. The celery code requires the mro attribute and as whatever is tested doesnt have it fails. I assume that whatever causes the problem is an old style class (Feature or _Feature = not derived from object). On python 3 this is therefore no longer a problem.
I tried to identify where Feature is defined, however couldn't find it on the pythons side. Guess it comes from C++
The suggested fix only hides the problem and doesn't address the cause.

Got it:
<module 'rdkit.Chem.GraphDescriptors' from '.../rdkit/Chem/GraphDescriptors.py'>
print_function
_Feature((2, 6, 0, 'alpha', 2), (3, 0, 0, 'alpha', 0), 65536)

The problem is therefore caused by from __future__ import print_function.  The fix is to include this specific function as an exception in the _setupDescriptors function.

I've created the PR #1443 which contains a simple fix. I no longer have Python 2.7 on my system, so it would be great if @momeara could check the fix. The modification are the two lines
        if name == 'print_function':
          continue

in the last test block of _setupDescriptors.
  for mod in mods:
    tmp = dir(mod)

    for name in tmp:
      if name[0] != '_' and name[-1] != '_' and name not in others:
        # filter out python reference implementations:
        if name[:2] == 'py' and name[2:] in tmp:
          continue
        if name == 'print_function':
          continue
        thing = getattr(mod, name)
        if _isCallable(thing):
          namespace[name] = thing
          _descList.append((name, thing))
  descList = _descList

PR #1443 solves the problem on my machine, nice work!


Chef PSModule is not installed if user selects it in the setup options

When installing the chef-client MSI and choosing the PSModule Wrapper, the powershell module is not actually installed. This is noticed in this issue originally filed in the chef-dk repo (note it successfully installs using the chef-dk MSI).
It looks like chef-dk has an omnibus config script that copies the module file and we need the equivilent in chef.

Or we could remove the option to install the wrappers with chef-client...
But as long as we ship knife (which is the main reason for the wrappers), we should probably include the module.

This was resolved with the work to repackage the contents of the MSI into a faster ZIP extraction method. Tested on Windows Server 2016/Chef Client 14.3.37 and the behavior is as expected, $PSModulePath is updated with the correct path and the chef.psm1 is in the correct location.
PS C:\Users\Administrator> Import-Module chef -Verbose
WARNING: The names of some imported commands from the module 'chef' include unapproved verbs that might make them less
discoverable. To find the commands with unapproved verbs, run the Import-Module command again with the Verbose
parameter. For a list of approved verbs, type Get-Verb.
VERBOSE: The 'chef-apply' command in the chef' module was imported, but because its name does not include an approved
verb, it might be difficult to find. For a list of approved verbs, type Get-Verb.
VERBOSE: Importing function 'chef-apply'.
VERBOSE: The 'chef-client' command in the chef' module was imported, but because its name does not include an approved
verb, it might be difficult to find. For a list of approved verbs, type Get-Verb.
VERBOSE: Importing function 'chef-client'.
VERBOSE: The 'chef-service-manager' command in the chef' module was imported, but because its name does not include an
approved verb, it might be difficult to find. For a list of approved verbs, type Get-Verb.
WARNING: Some imported command names contain one or more of the following restricted characters: # , ( ) {{ }} [ ] & -
/ \ $ ^ ; : " ' < > | ? @ ` * % + = ~
VERBOSE: The command name 'chef-service-manager' from the module 'chef' contains one or more of the following
restricted characters: # , ( ) { } [ ] & - / \ $ ^ ; : " ' < > | ? @ ` * % + = ~
VERBOSE: Importing function 'chef-service-manager'.
VERBOSE: The 'chef-shell' command in the chef' module was imported, but because its name does not include an approved
verb, it might be difficult to find. For a list of approved verbs, type Get-Verb.
VERBOSE: Importing function 'chef-shell'.
VERBOSE: The 'chef-solo' command in the chef' module was imported, but because its name does not include an approved
verb, it might be difficult to find. For a list of approved verbs, type Get-Verb.
VERBOSE: Importing function 'chef-solo'.
VERBOSE: The 'chef-windows-service' command in the chef' module was imported, but because its name does not include an
approved verb, it might be difficult to find. For a list of approved verbs, type Get-Verb.
VERBOSE: The command name 'chef-windows-service' from the module 'chef' contains one or more of the following
restricted characters: # , ( ) { } [ ] & - / \ $ ^ ; : " ' < > | ? @ ` * % + = ~
VERBOSE: Importing function 'chef-windows-service'.
VERBOSE: Importing function 'knife'.
PS C:\Users\Administrator> Get-Command -name chef-client

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Function        chef-client                                        0.0        chef


Updated to 2.x POM to be able to deploy a release

This change updates POM to 2.x so that we can cut a new release (or deploy a snapshot, which is what made me realize this change is needed)

Resolved separately


Require onTap event on ChartJS widget

Requirements:

Need to navigate to another screen on Tapping the Chart.
Currently ChartJS widget doesn't have onTap event, so need onTap widget in ChartJS widget

Alternative Solution I tried which didn't work:

I wrapped ChartJS widget with Column Widget and used onTap event on column, onTap event was working outside the area of ChartJS and the same onTap of column wasn't working in the area of ChartJS.

@TheNoumanDev please check this out. We should provide a onTap for ChartJs widget as well that a user can specify any action for. ChartJs is a webview embedded inside a native app, so you will need to get the onclick

Updated Example EDL is:
- ChartJs:
    onTap:
      executeCode:
        body: |
          console.log("hi");
    config: |
      {
        "type": "pie",
        "data": {
          "labels": ["Red", "Blue", "Yellow"],
          "datasets": [{
            "data": [300, 50, 100],
            "backgroundColor": [
                "rgb(255, 99, 132)",
                "rgb(54, 162, 235)",
                "rgb(255, 205, 86)"
            ]
          }]
        }
      }

Working on Web
https://github.com/user-attachments/assets/3c67e457-ea65-4b46-8f09-fec68f9d5ff8
Working on Emulator:
https://github.com/user-attachments/assets/075ab31d-71f9-45f4-bc0d-356891face05


Use bytes base for all values

Currently we have different types of "value" objects in jeo-maven-plugin with different types:
<o base="org.eolang.jeo.int" name="access" data="bytes" line="1656645624">00 00 00 00 00 00 00 03</o>

<o base="org.eolang.jeo.string" data="bytes" line="844659190">28 29 56</o>

<o base="org.eolang.jeo.bool" data="bytes" line="1984388884">00</o>

New version of eo saves all the values as bytes objects. We must do the same in jeo-maven-plugin:
<o base="org.eolang.jeo.int" line="33" name="access" pos="4">
    <o as="0" base="bytes" data="bytes" line="34" pos="6">00 00 00 00 00 00 00 04</o>
</o>

@volodya-lombrozo 2 puzzles #722, #723 are still not solved.

@volodya-lombrozo the puzzle #722 is still not solved; solved: #723.

@volodya-lombrozo all 2 puzzles are solved here: #722, #723.


[Feature Request] Allow setting an inactivity duration after which kochiku considers jobs abandoned

If, for example, a large part of your network becomes unavailable and jobs get dropped, it would be nice for kochiku to not consider those jobs still "pending" when they will in fact never be picked up. I'd probably set this to like 1-2 hours.

https://github.com/square/kochiku/pull/271


[nl interface] set up new data version of nl interface

this just sets up the new data version of nl interface. tile updates will come in separate PRs
separates nl interface endpoints into api & html
takes away delay when using query hash to search

There are some map js,etc loading now. It's okay but should make it as lean as possible as they all add latency.

thanks for the reviews!


How to locate the elements when we are doing mobile web testing?

Hello,
I am successfully able to do mobile web testing and able to launch the site in the connected device
I would like to do more test with the Testing the mobile web so how to locate an element when we are able to see the mobile web app in the inspector
please can you provide me with some details of how to locate elements when we test the mobile web
Thanks in advance...

In general it should be something like this: http://docs.seleniumhq.org/docs/appendix_locating_techniques.jsp
In other words you can use a number of finders/locators to get the element you need (e.g. id, name, text, partial link text, xPath, CSS selector).
By the way, your question is not related to selendroid.

Hello operatiay,
Thanks for the reply..
I have done the Testing the Mobile Web and below is the code:
package io.selendroid.demo.mobileweb;
import io.selendroid.SelendroidCapabilities;
import io.selendroid.SelendroidConfiguration;
import io.selendroid.SelendroidDriver;
import io.selendroid.SelendroidLauncher;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.openqa.selenium.By;
import org.openqa.selenium.WebDriver;
import org.openqa.selenium.WebElement;
import org.openqa.selenium.remote.DesiredCapabilities;
public class MobileWebTest {
private SelendroidLauncher selendroidServer = null;
private WebDriver driver = null;
@Test
public void shouldSearchWithEbay() {
// And now use this to visit ebay
driver.get("http://m.ebay.de");
// Find the text input element by its id
WebElement element = driver.findElement(By.id("kw"));

// Enter something to search for
element.sendKeys("Nexus 5");

// Now submit the form. WebDriver will find the form for us from the element
element.submit();

// Check the title of the page
System.out.println("Page title is: " + driver.getTitle());
driver.quit();

}
@Before
public void startSelendroidServer() throws Exception {
if (selendroidServer != null) {
selendroidServer.stopSelendroid();
}
SelendroidConfiguration config = new SelendroidConfiguration();
selendroidServer = new SelendroidLauncher(config);
selendroidServer.lauchSelendroid();

DesiredCapabilities caps = SelendroidCapabilities.android();

driver = new SelendroidDriver(caps);

}
@After
public void stopSelendroidServer() {
if (driver != null) {
driver.quit();
}
if (selendroidServer != null) {
selendroidServer.stopSelendroid();
}
}
}
Once the server is started I am able to see the app in the device attached to the PC and also in the link [http://localhost:4444/inspector/]
Now if you see in the above code we are able to find the text box by its id and passing the values Nexus 5 in the below lines
WebElement element = driver.findElement(By.id("kw"));
element.sendKeys("Nexus 5");
As much I am aware that the only way selendroid allows us to find the elements through its inbuilt tool Inspector then if someone wants to locate other elements through Inspector then what is the ways.I can able to see the complete HTML source code by locking the tree structure displays in the Inspector link
Thanks !

Sorry, I don't have time right now to run your scenario, but you might have a problem with the context (native vs. web).
A completely separate point is the following: Selendroid inspector doesn't work on web content. You'd need to write your selectors using other tools. you can open the website in a browser on your desktop and do the investigations what works for you.

Hello Operatiay,
Could you please provide info for the following queries.

Selendroid does support running test scripts on Opera browser on Mobile device.
what are the mobile browsers supports Selendroid.
Is there any mobile automation tool available in market for mobile web app testing (running test scripts) on mobile opera browser(Mobile Device).

Thanks in advance.
Regards,
Venkat


Release new version of codespan-lsp

It appears that lsp-types has recently been bumped to version 0.63.1, making codespan-lsp 0.5.0 no longer semver-compatible with this latest version. This new release adds support for LSP 3.15, which includes a number of improvements over the previous release. It would be nice if codespan-lsp could be bumped on Crates.io to work with this new release.

This should be published now, sorry for the wait!

@brendanzab No worries! Thanks for all the fantastic work on these crates.


Multigrid scrollToRow/scrollToColumn then scrolling in header no longer syncs with body scroll

What is the current behavior?
In the Multigrid demo:
https://bvaughn.github.io/react-virtualized/#/components/Multigrid
When you enter a scrollToRow of (say) 50, and then use your trackpad/scroll wheel while hovered over the left header column to scroll up/down, only the left header column scrolls, and not the body.
What is the expected behavior?
The whole Multigrid should scroll as normal, as before there was a scrollToRow/Column specified, and as if your mouse were hovered over the body (scrolling within the body still works as expected).
Which versions of React and react-virtualized, and which browser / OS are affected by this issue? Did this work in previous versions of react-virtualized?

Browser
Chrome 67

OS
macOS 10.13

React
whatever's used in the demo site as of this time

React DOM
same as above

react-virtualized
same as above, but also ran into this in 9.20.0

I agree, I think this PR https://github.com/bvaughn/react-virtualized/pull/1130 caused it.
I cannot use ScrollSync with ArrowKeyStepper together anymore :(.

Hello, I ran into this issue today, and in the process of digging around in the code to follow the steps already taken in the linked PR and issue, I made an edit which stopped the issue from happening to me. Diff below to allow you to test, also it is on a branch of my fork here
diff --git a/source/Grid/Grid.js b/source/Grid/Grid.js
index e2f4392..684eda8 100644
--- a/source/Grid/Grid.js
+++ b/source/Grid/Grid.js
@@ -819,33 +819,27 @@ class Grid extends React.PureComponent<Props, State> {
   static getDerivedStateFromProps(
     nextProps: Props,
     prevState: State,
   ): $Shape<State> {
     const newState = {};

     if (
       (nextProps.columnCount === 0 && prevState.scrollLeft !== 0) ||
       (nextProps.rowCount === 0 && prevState.scrollTop !== 0)
     ) {
       newState.scrollLeft = 0;
       newState.scrollTop = 0;

-      // only use scroll{Left,Top} from props if scrollTo{Column,Row} isn't specified
-      // scrollTo{Column,Row} should override scroll{Left,Top}
-    } else if (
-      (nextProps.scrollLeft !== prevState.scrollLeft &&
-        nextProps.scrollToColumn < 0) ||
-      (nextProps.scrollTop !== prevState.scrollTop && nextProps.scrollToRow < 0)
-    ) {
+    } else {
       Object.assign(
         newState,
         Grid._getScrollToPositionStateUpdate({
           prevState,
           scrollLeft: nextProps.scrollLeft,
           scrollTop: nextProps.scrollTop,
         }),
       );
     }

I'm still working through the code to figure out why it works! :sweat_smile: but, nothing is broken so far for me. There are two tests failing if you run yarn test, but doing the test steps manually does give the correct result.
Sorry that I can't be more certain, but I just opened up this codebase today. But I wanted to add my update to this thread in case anyone more familiar with the repo can help point in the right direction from here.

@jacoporicare
you're right, thanks. reverting to v9.19.1 did it for me.

@HUSSTECH, your change may break #1123 fix.
For me the workaround is, just after setting scrollToRow property to some value, reset it back to undefined using setTimeout, so it doesn't prevent using scrollTop anymore on further user scroll events.

Similar to @ddrozdov, our workaround for this is to reset scollToRow back to undefined using the onScroll method. This maintains the scrollToRow functionality, but still lets you scroll fixed multigrid columns. We found it easier to implement than using a promise/set timeout. Simplified example:
onScroll = scrollInfo => {
    if (this.state.scrollToRow !== undefined) {
        this.setState({ scrollToRow: undefined });
    }
    // do other stuff
}

<MultiGrid
    onScroll={this.onScroll)
    scrollToRow={this.state.scrollToRow}
    // other props
/>

I figured out that 'scrollToRow' is really hard to use for dynamic value. Just replace it by 'scrollTop'. For example, if your case is so simple like: 'I need to scroll my component to first row by some dynamic value with comparison' - just set 'scrollTop' to '1'.
In short: If your scrollToRow props is not working, try to replace it by the scrollTop like:
const getScrollTo = (value) => {
  if (isShouldUseLikeScrollToRow) {
    const rowHeight = 50;
    return value * rowHeight; // here write your own formula to calculate the scroll position.
  }
}

<Grid
  scrollTop={getScrollTo(10)}
  scrollToRow={scrollToRow} // don't use it for changing scroll position dynamically
/>


docs: add anonymized analytics

What I did
It would be really helpful for us to monitor growth by seeing our analytics from the docs page
fixes: APE-453
How I did it
I chose Plausible because they are privacy-preserving and open source
How to verify it
Once docs are released (on main) should be able to see the page

Also found this: https://www.goatcounter.com/

Another: https://github.com/plausible/analytics

Note, I had to switch to Chrome (and not Brave) to get the script to not be blocked.

Hmm, do all scripts get blocked by brave by default?

There is also the chance the privacy-browser purposely misleads the analytics tools, in the case to avoid penalty.
https://brave.com/privacy-updates/1-web-resource-replacements/#solution-dont-just-block-replace

I wish github pages just had analytics so it could tell us how many downloads we were getting lol

Maybe we should try the other 2 that you linked and see if they are considered "trackers" by Brave?
The GOAT one seems like it may be cognizant of this.

Maybe we should try the other 2 that you linked and see if they are considered "trackers" by Brave?
The GOAT one seems like it may be cognizant of this.

I'm into this. I like that the others are open source

I did get the script to load on chrome. Does anything show up on the account?

Try again, it wasn't watching

It works on Chrome but not Brave! I don't expect it to work on Brave though.

There's a way to set it up with a proxy method which may bypass this, but not screwing around with this now

I like how easy it integrates with our docs stack too.

Yeah, it's a 3rd party plugin, but seems relatively active so that's cool.


only use greenkeeper for production dependencies

Maybe we don't need to always update dev dependencies.
https://github.com/greenkeeperio/greenkeeper/issues/193

But wait. This repository has no dependencies other than dev dependencies. So the solution to this would be to just remove greenkeeper altogether. I don't think I want to do that. Closing.


Handling Missing Numbers in ANSI Escape Sequences

Your Windows build number:  (Type ver at a Windows Command Prompt)

Microsoft Windows [Version 10.0.16299.125]

What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots)

test@PC2:~$ printf "\033[31mtest\n"
test (red)
test@PC2:~$ printf "\033[31;mtest\n"
test (red)
test@PC2:~$ printf "\033[31;0mtest\n"
test (white)
test@PC2:~$

What's wrong
The second output is printed in red:

What should be happening instead:

The second output should be printed in white like on Linux:

According to Wikipedia (https://en.wikipedia.org/wiki/ANSI_escape_code):

All common sequences just use the parameters as a series of semicolon-separated numbers such as 1;2;3. Missing numbers are treated as 0 (1;;3 acts like the middle number is 0, and no parameters at all in ESC[m acts like a 0 reset code).

Further details are available from:
https://superuser.com/questions/1280903/how-to-enable-colors-with-win32-openssh-and-putty

It looks like this went out with 1809. Thanks for reporting it!


nnpdf: init at 4.0.4

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 173156 run on x86_64-linux 1

4 packages built:

nnpdf (python39Packages.nnpdf)
python310Packages.nnpdf
python310Packages.validphys2
validphys2 (python39Packages.validphys2)

Thanks!


Timesheet - 29/04/2021 - Bojan Ilijevski

Task 1
Managing social media
Answering private messages on Instagram and Facebook
Following/Unfollowing people on social media
Posted new gif on all of our stories on social media
Time Spent
1.5 hours

Task 2
Marketing Meeting
Proof of Work

https://docs.google.com/document/d/1BLMZRvthSsDG0JRLYqaSG-b8FtDDDYYOBOIfhMcYNdc/edit#

Time Spent
05 hours

Total Time Spent
2 hours
Account Number
b1b1e90107d804e5317c8527129ceaededdcb162a6737112b88712742a08bb72

Approved


Patch in pcmp_eq method for altivec [ppc64le] float

Commit dcbc81277b made use of the pcmp_eq method for Packet
for the first time, then works fine on x86 but fails to compile
on ppc64le because the pcmp_eq method was not implemented in
Eigen's arch/AltiVec/Complex.h for float. This patch adds this
implementation to get around the build break on ppc64le.
We will work on upstreaming this change into the Eigen source,
we'll need to also add the pcmp_eq method for double when we do
that.

You can prepare PR to Eigen and assign it to @rmlarsen for review. I think it's the preferred way.

Please copy Konstantinos Margaritis in the Eigen community as well.

FYI, I just submitted a PR into Eigen: https://bitbucket.org/eigen/eigen/pull-requests/619/add-support-for-pcmp_eq-in-altivec/diff

The upstream eigen PR is now merged. I'll close this PR and create a new one to update the eigen version used in TensorFlow.


Bundling QA IssueFixes(NOT Ready for Merge)

Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

closing it..will reopen


Fix a couple typos in README.

Terrific project, thanks for all your work!

Thanks @natecook1000!


[iOS] Custom NSURLSession configuration

Summary
While it is possible in the React Native implementation for Android to provide a custom configuration for HTTP requests, the iOS implementation does not allow for the same customization. As the NSURLSession used for HTTP requests on iOS is configured internally, one may for instance not supply an ephemeral configuration for HTTP requests. Other concerns related to the given problem have been addressed in the community: https://github.com/react-native-community/discussions-and-proposals/issues/166. I did make a PR with an RFC in the community repo, but after some discussion in the said repo, I figured I might as well make a PR with a suggestion :)
Changelog
[iOS] [Added] - Allow for configuring the NSURLSessionConfiguration
Implement a C function RCTSetCustomNSURLSessionConfigurationProvider which gives the app programmer the ability to provide a block which provides an NSURLSessionConfiguration that will be used for all HTTP requests instead of the default configuration. The provided block will be called when the session configuration is needed.
Test Plan
Unsure if this can be tested in any other way than uncommenting the example code in RNTester/RNTester/AppDelegate.mm.

+1 On this, this will greatly simplify implementations that need to use their own NSURLSessionConfiguration, ex. RCTCronetHTTPRequestHandler.mm

Any movement on this? I am looking for the ability to customize the iOS networking client like you do on Android.

@zsiegel I haven't heard from the review team. I assume they've had their hands full. Not sure if I should tag someone in the discussion, and in that case, who.

Hi @hakonk thanks for the PR, I'll see if I can ping someone for this.

Thanks, @safaiyeh 😊

Hey @safaiyeh, did you have luck finding anyone?

Hi @TheSavior, could someone check this out?

Nearly a year already..

Happy new year!
I guess there are more important PRs in the pipe still. Any news @safaiyeh ?

Happy new year!
I guess there are more important PRs in the pipe still. Any news @safaiyeh ?

Interesting that this important (for SSL Pinning that can't use sizzling) PR is still not merged.

@pke you mentioned this is useful for SSL pinning.
Can you elaborate on how? From what I can tell, Apple's docs on performing manual server trust authentication state that we should provide an NSURLSessionDelegate that evaluates sever trust within urlSession(_:didReceive:completionHandler:).
This PR does not allow us to set our own NSURLSessionDelegate, so how would this be useful in evaluating server trust?
@hakonk definitely open to your input as well. Thank you for this PR.

@taylorkline I believe you are right in that you would have to implement NSURLSessionDelegate as a part of implementing certificate or public key pinning, and this PR does not address that particular problem. In RCTHTTPRequestHandler.mm:99, you can see that self is assigned as the delegate for the NSURLSession instance. Thus, there is currently no way of supplying the delegate implementation from outside of React Native.
You can make use of swizzling when you do not have the means to implement NSURLSessionDelegate yourself. While I guess this would work most of the time, this mandates potential use of swizzling in other dependencies or your own code. Not really a problem in itself, it just isn't so transparent given that funky stuff happens at runtime. https://github.com/datatheorem/TrustKit does actually allow for implementing public key pinning with swizzling. That could possibly be useful if you want to achieve certificate or public key pinning in a React Native app.

@hakonk Thank you for confirming and thank you for your time.

@taylorkline iirc one can only sizzle functions once. So if one react native module sizzles the NSURLSession (for certificate pinning) then no other module could sizzle the session. The ability to provide the pinning configuration for the sessions directly removes the need to use sizzling for it. So thanks for merging this!

Is this in v0.65.0? The commit does not appear to be tagged with v0.65.0.

0.65 was cut on April 28th, before this PR was merged. This PR will be included in 0.66

@TheSavior I'm a bit confused. The changelog for 0.65.0 lists this PR.

Ah, I was looking at the tags on the commit as @taylorkline mentioned. It looks like this commit was cherry picked and thus doesn't have the same hash in the release branch. This commit is in 0.65.0 here: https://github.com/facebook/react-native/commit/c299694c87e9912d4c884b5acec04c708ed0f841
Sorry for the confusion! 😅

Alright, thanks for answering so quickly! 😄


Automatic adding undefined to dictionary maps

My suggestion was hidden in the closed #13792, so i open a new issue about that.
Every object map can be undefined on a random key access. Can we catch this in a general approach or do we have to find every needed definition?
I just changed my own code and had an issue with for in loops. Tested with TS2.1 perhaps this has changed in 2.2
const StringDict: { [index: string]: string; } = {foo: 'bar'};
for (let key in StringDict) {
   const thisStringValue = StringDict[key];
}
const StringDict2: { [index: string]: string | undefined; } = {foo: 'bar'};
for (let key in StringDict2) {
   const StringValueOrUndefined = StringDict2[key];
}

I cannot imagine a case where StringValueOrUndefined is really able to become undefined. So an extra check to make TS happy would burn CPU cycles.

I cannot imagine a case where StringValueOrUndefined is really able to become undefined.

const StringDict2: { [index: string]: string | undefined; } = {foo: 'bar', qua: undefined};
for (let key in StringDict2) {
   const StringValueOrUndefined = StringDict2[key];
}

So an extra check to make TS happy would burn CPU cycles.

This is why the postfix ! operator exists.

One of the questions was if this | undefined should be added by typescript itself for such constructions.


Chore/update dev packages

update packages for typescript/react

too many commits,,, based it off develop, not idea.


Flux: strange behavior for date.truncate( ,unit:1w)

For the function date.truncate a week should run from monday to sunday. But in flux the week runs from tuesday to wednesday.
Steps to reproduce:
Query to test the function date.truncate:
import  "date"
jetzt = 2021-03-06T06:31:15Z
from(bucket: "finanz")
  |> range(start: -12d, stop: date.truncate(t: jetzt, unit:1w))

Expected behavior:
It should stop at a sunday.
Actual behavior:
In my case it stopped at 2021-03-03T23:54:00.385770457Z , which is wednesday evening.
Environment info:
InfluxDB Version 2.0.4 (4e7a59b)

Moved issue to flux!


pylint

What changes were proposed in this pull request?
Make pylint happy for https://github.com/apache/spark/pull/31735
Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?
dev/lint-python

pip freeze:
certifi==2020.12.5
coverage==5.5
flake8==3.9.0
mccabe==0.6.1
numpy==1.20.1
pandas==1.2.3
pyarrow==2.0.0
pycodestyle==2.7.0
pyflakes==2.3.0
python-dateutil==2.8.1
pytz==2021.1
scipy==1.6.1
six==1.15.0
xmlrunner==1.7.7

Thanks @sadhen . I am also curious why not just directly push to the lei/pandas_udf branch? Do you need project permission on this repo? I can check .

Yes, I need the premission.


Flash not working with laracasts/flash:^3.0

I had a little headache after update my composer outdated modules. In the process I updated laracasts/flash to version 3.0 and the toastr stopped showing up. I didn't realized in the very beginning taking a couple of hours to identify what I did wrong. I'd like to suggest update sources in order to work with laracasts/flash:3.0. If you guys could explain to me how laraspace works with flash I can try update myself and send a pull request.

Hello marcus!
I am not aware about the changes in latest laracasts/flash package but you can check laraspace-notifs.blade.php & laraspace-notifs.js to see how it works.
Basically we just get the notification message and notification-level from session variable ( which comes from the package ) and then set it on data-attribute of the element in laraspace-notifs.blade.php.
And then in laraspace-notifs.js, we fire the notification based on the provided attributes.

Thank you for fast response @mohitpanjwani .
According to release log, version 3.0 has breaking changes from v2. Basically:
// Before
flash()->success('My message');

// After
flash('My message')->success();

// Before
flash()->overlay('My message');

// After
flash('My message')->overlay();

I'll take a look about the working flow of laraspace-notifs and any further news I leave here.

I made a little change on laraspace-notifs based on breaking changes. I hope it's correct.

Breaking Changes From v2
Please note that there are no breaking changes with v3, unless you published our old view templates to your project.

We now flash a single flash_notification array to the session, and nothing else. As such, if maintaining your own views, you'll need to update them accordingly. See here: https://github.com/laracasts/flash/blob/master/src/views/message.blade.php

Looks good to me! Can you add a PR for the same?


Transaction profiles

This PR adds transaction profiles. A profile contains a per-cycle information about:

Which transactions/methods were running. For running methods, which transaction/method called.
Which transactions wanted to run but couldn't, and which conflicting transaction was running instead.

TODO:

[ ] Calculating statistics for the entire profile.
[ ] Some way of visualizing profiles.

According to the point:

Some way of visualizing profiles.

I am currently thinking about two possible way:

Something similar to waveform, where we have a one timeline for each transaction. It is green if it is running, blue when not ready and red if conflicting, ready and not running
Graph between transactions and methods. Edges in such graph can visualise how often conflict on these methods/transactions caused a stall of one of them.

I am currently thinking about two possible way:
* Something similar to waveform, where we have a one timeline for each transaction. It is green if it is running, blue when not ready and red if conflicting, ready and not running

* Graph between transactions and methods. Edges in such graph can visualise how often conflict on these methods/transactions caused a stall of one of them.

Both ideas are great, but I think this should be left for a future PR. For now, I'm writing a command-line script which will show transaction and method statistics using inverted call trees (methods to transactions). Normal call trees (transactions to methods) might be useful too.


[Doc] Could not find content for role based API Lifecycle Management

Description:
Not fulfilling checklist items:
Help and Documentation - Is necessary documentation provided?
Related task:
Introduce organization specific life cycle states
Issue:
Topics/content covered under [1] Does not cover role based life cycle management. The data element "transitionPermission" need to be explained with a sample scenario. Refer https://blog.lakmali.com/2017/05/customizing-lifecycle-states-in-wso2.html
Doc Link:
[1] https://docs.wso2.com/display/AM2xx/Manage+the+API+Lifecyclee
Suggested Labels:
Doc, Bug
Affected Product Version:
2.1.0 update 14

We will not be fixing this as this issue is based on an older version of the product.